Re: [PATCH] gtk: listbox border was not rendered

2012-08-01 Thread Ivan Timofeev
Hi Luke, On 01.08.2012 03:29, Luke Symes wrote: I was the one who made the original patch that set listboxes to integer heights of the list items, which was reverted for causing trouble. The reason I wanted to fully show all list items was not because partially shown list items looked bad. It

Re: [PATCH] gtk: listbox border was not rendered

2012-07-31 Thread Ruslan Kabatsayev
Hi, After some checks I've come to the conclusion that your patch does it as it should, and the breakage should be fixed in oxygen-gtk. The only problem remains is when this fix should be done (i.e. there'll be some time until your patch gets into a released version of LibO, and until then we

Re: [PATCH] gtk: listbox border was not rendered

2012-07-31 Thread Ivan Timofeev
Hi Ruslan On 31.07.2012 17:56, Ruslan Kabatsayev wrote: After some checks I've come to the conclusion that your patch does it as it should, and the breakage should be fixed in oxygen-gtk. The only problem remains is when this fix should be done (i.e. there'll be some time until your patch gets

Re: [PATCH] gtk: listbox border was not rendered

2012-07-28 Thread Ruslan Kabatsayev
Hello, This mostly looks good, but breaks a bit border for oxygen-gtk (which somehow has worked before the patch, unlike other themes). Namely, the border now appears to be 1px while it should be 2px. I'd suggest using getFrameWidth() to adjust the shadow rect. OTOH, we've done quite some

Re: [PATCH] gtk: listbox border was not rendered

2012-07-28 Thread Ivan Timofeev
Hi Ruslan, On 28.07.2012 15:08, Ruslan Kabatsayev wrote: This mostly looks good, but breaks a bit border for oxygen-gtk I have just installed it, yeah - it is broken... :( (which somehow has worked before the patch, unlike other themes). Strange. I'd suggest using getFrameWidth() to