Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Thomas Arnhold
On 21.03.2013 15:06, Michael Meeks wrote: So I'd say that these huge spews of ascii-art don't serve a useful purpose: //- and bulky content-free comments (which we still have plenty of) should clearly take be a higher priority for

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Tor Lillqvist
> I think there is still so much to do before arguing about spaces or other > similar matter of taste details that have very little practical consequences. The practical consequence of inconsistent spacing/alignment, excessive vertical whitespace, pointless ASCII graphics etc is that developers g

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Lubos Lunak
On Thursday 21 of March 2013, Eike Rathke wrote: > Hi Philipp, > > On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: > > remove/add blank lines in sw/source/core > > I'd prefer if such mere cosmetical changes would not be done; while > inserting a blank line mostly i

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Kohei Yoshida
On 03/21/2013 09:31 AM, Eike Rathke wrote: Hi Philipp, On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: remove/add blank lines in sw/source/core I'd prefer if such mere cosmetical changes would not be done; while inserting a blank line mostly is ok for readabi

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Michael Meeks
Hi Eike, On Thu, 2013-03-21 at 14:31 +0100, Eike Rathke wrote: > On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) > wrote: > > remove/add blank lines in sw/source/core > > I'd prefer if such mere cosmetical changes would not be done; while > inserting a blank line mostly

Re: [PATCH] remove/add blank lines in sw/source/core

2013-03-21 Thread Eike Rathke
Hi Philipp, On Wednesday, 2013-03-20 17:31:03 +, Philipp Riemer (via Code Review) wrote: > remove/add blank lines in sw/source/core I'd prefer if such mere cosmetical changes would not be done; while inserting a blank line mostly is ok for readability, removing a blank line mostly for the sa