[REVIEW: 3-5, 3-4] fdo#43932 setting paper tray from print dialog

2012-03-14 Thread David Tardon
Commit 6d4cca9c22c52b5a7742adc47ebf1a2930e29764 is an attempt to fix fdo#43932 . The problem was that PrinterController always used default tray, unless it was overriden by application-set one. Now it actually uses the chosen one (which may not be the same the user selected, because of of printer

Re: [REVIEW: 3-5, 3-4] fdo#43932 setting paper tray from print dialog

2012-03-14 Thread Ivan Timofeev
Hi David, actually, your fix was my first attempt to solve the bug. It solved the UI problem, I remember. And then I decided to clean-up the code a bit... You might see my patch. :) But I cannot ever understand, how it fixes the real problem (setting paper tray).