Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-03 Thread Eike Rathke
Hi Tomáš, On Tuesday, 2012-04-03 00:54:22 +0200, Eike Rathke wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb Could you check if that works with your ICU 4.9 build and if so commit it to the 3-5 branch? Thanks Eike -- LibreOffice Calc

Re: [PUSHED][REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-03 Thread Eike Rathke
Hi, On Tuesday, 2012-04-03 15:08:41 +0200, Eike Rathke wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=43084e8b30c101a44510b7a8267d5c2b316a17bb Could you check if that works with your ICU 4.9 build and if so commit it to the 3-5 branch? Needed some backporting love, still

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Tomáš Chvátal
Ok, I commited the patch to the master, as the distros will mostly add icu49 now and libreoffice is the only offender that wont compile against it now please review the patch for 3-5 branch and commit if applicable. [1] Cheers Tom [1]

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Eike Rathke
Hi Tomáš, On Monday, 2012-04-02 18:53:16 +0200, Tomáš Chvátal wrote: I commited the patch to the master, as the distros will mostly add icu49 now and libreoffice is the only offender that wont compile against it now please review the patch for 3-5 branch and commit if applicable. [1] Bah,

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Caolán McNamara
On Mon, 2012-04-02 at 19:31 +0200, Eike Rathke wrote: Bah, I initially overlooked that the patch also changes the general char.txt, not only char_in.txt We have a problem here, as that changes behavior for Thai and Lao with existing ICU versions. Would be worth adding some sample text

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Eike Rathke
Hi Caolán, On Monday, 2012-04-02 20:10:23 +0100, Caolán McNamara wrote: On Mon, 2012-04-02 at 19:31 +0200, Eike Rathke wrote: Bah, I initially overlooked that the patch also changes the general char.txt, not only char_in.txt We have a problem here, as that changes behavior for Thai and