[REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 00:53 -0600, Norbert Thiebaud wrote: Fixed invalid conversion from SvUShorts to std::vector... *sigh* Please, pick to the appropriate branches. I pushed it on the 3.5 branch. With one more review (preferably from a writer maintainer) we're good for 3.5.1 I

Re: [REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Ivan Timofeev
On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ), aMins( aTabCols.Count() + 1, 0 ); Hmm,

Re: [REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Michael Meeks
On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: std::vectorsal_uInt16 aWish( aTablCols.Count() + 1, 0 ),

Re: [PUSHED][REVIEW 3.5.1 (?)] fdo#46144: Distributy Columns Evenly does not work with the selected columns

2012-02-27 Thread Caolán McNamara
On Mon, 2012-02-27 at 16:15 +, Michael Meeks wrote: On Mon, 2012-02-27 at 19:46 +0400, Ivan Timofeev wrote: On 27.02.2012 19:01, Michael Meeks wrote: Having said that I'm not hyper-happy with not initialising the vector's contents - don't we really want: