Re: -Wsign-promo (Re: [BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx)

2013-01-22 Thread Caolán McNamara
On Sat, 2013-01-19 at 11:28 +0100, Lubos Lunak wrote: it incidentally triggers when passing bool to SvStream, because it doesn't have any overload for operator(bool), and int is chosen over unsigned char AKA sal_Bool , so Caolan added it in e8bbb76827dd7a0e30d7d1db34a812a84d85f390 - if

Re: -Wsign-promo (Re: [BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx)

2013-01-21 Thread Stephan Bergmann
On 01/19/2013 03:12 PM, Michael Stahl wrote: On 19/01/13 11:28, Lubos Lunak wrote: -Wsign-promo is a rather pointless warning these days (the section in the gcc manpage is a funny read and not only because it talks about Cfront). I've Some of the funniness is likely due to

Re: -Wsign-promo (Re: [BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx)

2013-01-21 Thread Stephan Bergmann
On 01/19/2013 11:28 AM, Lubos Lunak wrote: On Friday 18 of January 2013, julien2412 wrote: Hello, On pc Debian x86-64 with master sources after having runned make clean, I've got this: /home/julien/compile-libreoffice/libo/sal/qa/rtl/strings/test_strings_value x.cxx: In instantiation of ‘void

-Wsign-promo (Re: [BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx)

2013-01-19 Thread Lubos Lunak
On Friday 18 of January 2013, julien2412 wrote: Hello, On pc Debian x86-64 with master sources after having runned make clean, I've got this: /home/julien/compile-libreoffice/libo/sal/qa/rtl/strings/test_strings_value x.cxx: In instantiation of ‘void testInt() [with T = rtl::OUString]’:

Re: -Wsign-promo (Re: [BUILD FAILS DEBUG MODE] with test_strings_valuex.cxx)

2013-01-19 Thread Michael Stahl
On 19/01/13 11:28, Lubos Lunak wrote: -Wsign-promo is a rather pointless warning these days (the section in the gcc manpage is a funny read and not only because it talks about Cfront). I've added more overloads to silence it, but I rather wonder why we have this explicitly enabled at