About fix for tdf#82744: WebDAV LOCK is released when document is saved

2015-07-14 Thread Giuseppe Castagno
Hi all, while implementing a fix for: https://bugs.documentfoundation.org/show_bug.cgi?id=82744 using ideas from a similar patch I proposed in AOO: https://bz.apache.org/ooo/show_bug.cgi?id=126305 I came across a comment on top of method SfxMedium::ShowLockedDocumentDialog. The comment

Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved

2015-07-14 Thread Tor Lillqvist
BTW, what does HAVE_FEATURE_MULTIUSER_ENVIRONMENT compile time flag (inside the commit recalled above) mean? The HAVE_FEATURE_* macros are (or should be) documented where defined, in config_host/config_features.h.in. In practice, HAVE_FEATURE_MULTIUSER_ENVIRONMENT currently means anything

Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved

2015-07-14 Thread Stephan Bergmann
On 07/14/2015 12:34 PM, Giuseppe Castagno wrote: I came across a comment on top of method SfxMedium::ShowLockedDocumentDialog. The comment states that lock/unlock should be put in the relevant ucb component. You mean the FIXME: ... comment added with

Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved

2015-07-14 Thread Giuseppe Castagno
Hi Stephan, On 07/14/2015 02:12 PM, Stephan Bergmann wrote: On 07/14/2015 12:34 PM, Giuseppe Castagno wrote: I came across a comment on top of method SfxMedium::ShowLockedDocumentDialog. The comment states that lock/unlock should be put in the relevant ucb component. You mean the FIXME: ...

Re: About fix for tdf#82744: WebDAV LOCK is released when document is saved

2015-07-14 Thread Giuseppe Castagno
Hi Tor, On 07/14/2015 03:13 PM, Tor Lillqvist wrote: BTW, what does HAVE_FEATURE_MULTIUSER_ENVIRONMENT compile time flag (inside the commit recalled above) mean? The HAVE_FEATURE_* macros are (or should be) documented where defined, in config_host/config_features.h.in