[SOLVED] Re: About use of sal_IntPtr for FontList::GetSizeAry, aStdSizeAry and mpSizeAry (svtools)

2020-09-12 Thread julien2412
Caolán McNamara wrote >> ... > These are font heights, and IMO I feel a humble int is sufficient for > their maximum range (https://gerrit.libreoffice.org/c/core/+/102466) on > looking at what goes into them Ok then, let's put this thread to SOLVED. -- Sent from:

Re: About use of sal_IntPtr for FontList::GetSizeAry, aStdSizeAry and mpSizeAry (svtools)

2020-09-12 Thread Caolán McNamara
On Thu, 2020-09-10 at 21:00 +0200, Julien Nabet wrote: > Hello, > > IMHO the use of sal_IntPtr in FontList class is wrong. > > Let's take a look at the 2 vars: > > 1) aStdSizeAry > > 2) mpSizeAry These are font heights, and IMO I feel a humble int is sufficient for their maximum range

About use of sal_IntPtr for FontList::GetSizeAry, aStdSizeAry and mpSizeAry (svtools)

2020-09-10 Thread Julien Nabet
Hello, IMHO the use of sal_IntPtr in FontList class is wrong. It's been there since 43135665bf9093c52f424069bcf83d50a93bdc0c: author    Fridrich Štrba 2013-06-10 12:49:33 +0200 committer    Fridrich Štrba 2013-06-10 14:03:34 +0200 commit    43135665bf9093c52f424069bcf83d50a93bdc0c (patch)