Re: Adding NeoOffice code to existing LibreOffice code

2024-02-18 Thread Patrick Luby
Thanks Thorsten! Just to set expectations: in most cases, the actual code copied will only be a few lines here and there. With LibreOffice, I try to do a new implementation and only look at the NeoOffice code when I see a familiar bug. For example, most of the macOS full screen feature is

Re: Adding NeoOffice code to existing LibreOffice code

2024-02-18 Thread Thorsten Behrens
Hi Patrick, Patrick Luby wrote: > Is this something that the ESC or legal committee needs to discuss? > I've poked Florian (and the new board, which is just today settling in). I believe NeoOffice being MPL now makes this a rather simple exercise, so I'd not block on getting this perhaps

Re: Adding NeoOffice code to existing LibreOffice code

2024-02-18 Thread Patrick Luby
I was able to avoid copying any NeoOffice code for tdf#126638. The NeoOffice fix used “selector swizzling” to override -[NSWindow performKeyEquivalent:] and I wanted to avoid any swizzling. Fortunately, I was able to use one the standard NSMenuDelegate callbacks to detect the problem. I would

Adding NeoOffice code to existing LibreOffice code

2024-02-16 Thread Patrick Luby
I would like to add some NeoOffice code to LibreOffice to fix the following macOS bug: https://bugs.documentfoundation.org/show_bug.cgi?id=126638 NeoOffice is now MPL v2.0 like LibreOffice so I assume that I will need to add some text in the license header of any LibreOffice files that I add