Re: Another C2220: warning treated as error with MSVC 2015

2016-07-24 Thread jan iversen
Hi We prefer patches to be submitted through gerrit, as it gives us a possibility to review them. Have a look at: https://wiki.documentfoundation.org/Development/GetInvolved#Prepare_to_submit_patches Apart from that, your patch changes the way the program works, by removing the try/catch claus

Re: Another C2220: warning treated as error with MSVC 2015

2016-07-24 Thread slacka
Can we trust MSVC 2015 unreachable code analysis like we with this similar issue? The patch below fixes the build: diff --git a/comphelper/source/misc/threadpool.cxx b/com

Another C2220: warning treated as error with MSVC 2015

2016-07-22 Thread Luke Benes
Here is another C2220 [build CXX] comphelper/source/misc/threadpool.cxx c:\\core\comphelper\source\misc\threadpool.cxx(80) : error C2220: warning treated as error - no 'object' file generated c:\\core\comphelper\source\misc\threadpool.cxx(80) : warning C4702: unreachable code C:/core/solenv/gbui