Re: B2DLineJoin::Middle, drawPolyLine etc

2016-02-02 Thread Caolán McNamara
On Tue, 2016-02-02 at 16:04 +0100, Armin Le Grand wrote: > Hi Caolan, > > In practise I know of no current usages - even on the UI that flag > is missing. If it can be removed (UNO API, ODF, ...), remove it. > checked once again: B2DLineJoin::Middle is sometimes mapped to > B2DLineJoin::NONE, so

Re: B2DLineJoin::Middle, drawPolyLine etc

2016-02-02 Thread Armin Le Grand
Hi Caolan, checked once again: B2DLineJoin::Middle is sometimes mapped to B2DLineJoin::NONE, sometimes to B2DLineJoin::Miter, both are nearly equally often used. This should be unified, I would prefer mapping to B2DLineJoin::Miter due to being graphically 'closer' to B2DLineJoin::Middle than

Re: B2DLineJoin::Middle, drawPolyLine etc

2016-02-02 Thread Armin Le Grand
Hi Caolan, no, not an error, another simple LineJoin method which just takes the 'middle' of the points to be joined. LineJoins are for fat lines, so you have an inner and outer edge of the current and next segment. To join the points of the inner edges, these are added and divided by two, sam

B2DLineJoin::Middle, drawPolyLine etc

2016-02-02 Thread Caolán McNamara
What is B2DLineJoin::Middle supposed to be ? I see that the vcl pdf, windows and quartz backends treat ::Middle the same as ::Mitre (so I made the cairo one do the same) On the the other hand I see cppcanvas...setupStrokeAttributes and filter...ImplWriteLineInfo would default ::Middle to the same