Re: [PUSHED] Fixing a .doc header regression

2012-11-28 Thread Miklos Vajna
On Mon, Nov 26, 2012 at 09:12:06PM +1100, Luke Deller l...@deller.id.au wrote: Thanks, done with gerrit: https://gerrit.libreoffice.org/1170 Caolán picked this up, marking the thread as pushed. signature.asc Description: Digital signature ___

Re: Fixing a .doc header regression

2012-11-26 Thread Luke Deller
Thanks for the welcome Jan and Miklos. I have been reading this list for a few weeks since starting to look at this issue, and the way you treat each other here with kindness and consideration makes this community very attractive. On Mon, Nov 05, 2012 at 04:38:21PM +0100, Jan Holesovsky wrote:

Re: Fixing a .doc header regression

2012-11-05 Thread Jan Holesovsky
Hi Luke, Luke Deller píše v Čt 01. 11. 2012 v 00:58 +1100: I am new to the LibreOffice code, and am trying to fix a regression I encountered with headers in a .doc file, reported as fdo#56513 Oh wow - first patch, and already in quite an involved area of binary .doc interoperability :-) -

Re: Fixing a .doc header regression

2012-11-05 Thread Miklos Vajna
On Thu, Nov 01, 2012 at 12:58:43AM +1100, Luke Deller l...@deller.id.au wrote: Anyone know about this, or want to review the patch I attached to that item? Hi Luke, As Kendy mentioned, best to post patches here directly, once they're accepted, bugzilla will be updated automatically anyway. I

Fixing a .doc header regression

2012-10-31 Thread Luke Deller
Hi, I am new to the LibreOffice code, and am trying to fix a regression I encountered with headers in a .doc file, reported as fdo#56513 Using gdb I traced the problem back to code in wwSectionManager::GetPageULData in sw/source/filter/ww8/ww8par6.cxx. This code checks whether the first