Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-22 Thread Stephan Bergmann
On 02/22/2017 12:19 AM, David Ostrovsky wrote: On Sun, 2017-02-19 at 20:53 +, Luke Benes wrote: config_host.mk: export UCRTSDKDIR=C:/PROGRA~2/WI3CF2~1/10/ export UCRTVERSION=10.0.10240.0 Looking at the creation date of that folder, it matches the creation date of C:\Program Files

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-21 Thread David Ostrovsky
On Sun, 2017-02-19 at 20:53 +, Luke Benes wrote: > config_host.mk: > export UCRTSDKDIR=C:/PROGRA~2/WI3CF2~1/10/ > export UCRTVERSION=10.0.10240.0 > > Looking at the creation date of that folder, it matches the creation > date of C:\Program Files (x86)\Microsoft Visual Studio 14.0. Thanks

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-21 Thread Stephan Bergmann
On 02/21/2017 08:06 AM, David Ostrovsky wrote: On Sun, 2017-02-19 at 20:53 +, Luke Benes wrote: config_host.mk: export UCRTSDKDIR=C:/PROGRA~2/WI3CF2~1/10/ export UCRTVERSION=10.0.10240.0 Looking at the creation date of that folder, it matches the creation date of C:\Program Files

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-20 Thread David Ostrovsky
On Sun, 2017-02-19 at 20:53 +, Luke Benes wrote: > config_host.mk: > export UCRTSDKDIR=C:/PROGRA~2/WI3CF2~1/10/ > export UCRTVERSION=10.0.10240.0 > > Looking at the creation date of that folder, it matches the creation > date of C:\Program Files (x86)\Microsoft Visual Studio 14.0. > > So

VS 2015 XP support? (was: MSVC 2015 builds Failing After 2017 Support added)

2017-02-19 Thread Kaganski Mike
Hi, On 2/19/2017 12:34 PM, David Ostrovsky wrote: Hm.., what was changed since MSVC 2017 support, is that we are passing toolset version, see commit message of the change you pointed to, and particularly this line in external packages make files: $(if $(filter

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-19 Thread Luke Benes
From: David Ostrovsky <d.ostrov...@gmx.de> Sent: Sunday, February 19, 2017 11:35 AM To: Luke Benes Cc: libreoffice-dev Subject: Re: MSVC 2015 builds Failing After 2017 Support added On Sun, 2017-02-19 at 18:56 +, Luke Benes wrote: > > The default sh

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-19 Thread David Ostrovsky
On Sun, 2017-02-19 at 18:56 +, Luke Benes wrote: > > The default should be that whatever comes with the compiler should > > be > > enough, and that installing any separate SDK should be optional. > > > Agreed, this is how MSVC 2015 worked before the 2017 patch. > > > > So, if your

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-19 Thread Luke Benes
> The default should be that whatever comes with the compiler should be > enough, and that installing any separate SDK should be optional. Agreed, this is how MSVC 2015 worked before the 2017 patch. > So, if your UCRTVERSION is 10.0.10240.0 (can you verify in > config_host.mk?), then the

MSVC 2015 builds Failing After 2017 Support added

2017-02-19 Thread David Ostrovsky
On Sat Feb 18 19:52:23 UTC 2017 Luke Benes wrote: >I'm getting the following build error: >C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\Win32\PlatformToolsets\ v140\Toolset.targets(34,5): >error MSB8036: The Windows SDK version 10.0.10240.0 was not found. >Install the

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-18 Thread Tor Lillqvist
The default should be that whatever comes with the compiler should be enough, and that installing any separate SDK should be optional. Or do the newer compilers (2015, 2017) not come with the SDK bits (include files and import libraries) we need any longer? --tml

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-18 Thread slacka
Thanks for the work-around, but that doesn't really answer my question. To clarify, before support for MSVC 2017 was added, I did not need the Win 10 SDK. Even after, I do not need the Win 10 SDK to build with MSVC 2013. Only MSVC 2015 has this new requirement. Was this change intentional? If

Re: MSVC 2015 builds Failing After 2017 Support added

2017-02-18 Thread Kaganski Mike
Hi Luke, On 2/18/2017 10:52 PM, Luke Benes wrote: When I try to build with MSVC 2015 after: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b862cbdd345ec57c2595629ded6a3969e1e65d56 I'm getting the following build error: Build started 2/18/2017 1:11:26 PM. Project

MSVC 2015 builds Failing After 2017 Support added

2017-02-18 Thread Luke Benes
When I try to build with MSVC 2015 after: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b862cbdd345ec57c2595629ded6a3969e1e65d56 I'm getting the following build error: Build started 2/18/2017 1:11:26 PM. Project