Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-22 Thread Eike Rathke
Hi Winfried, On Tuesday, 2012-11-20 13:24:06 +0100, Winfried Donkers wrote: The link to the help files has been broken, i.e. WEEKNUM now points to the (partially out of date) help text for WEEKNUM_ADD, but ISOWEEKNUM does not point to a help text. That link wasn't broken, the xhp files

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-22 Thread Winfried Donkers
Hi Eike, One important matter is still open: When opening calc-documents that use the 'old' functions, they are not always computed correctly. The 'new' functions differ in paramter count. I do not know where to add code for backward compatibility when opening these documents, but

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-20 Thread Winfried Donkers
Hi Eike, I'm currently putting your review into a better patch: -renaming the functions: I reverted some lines as you proposed. The link to the help files has been broken, i.e. WEEKNUM now points to the (partially out of date) help text for WEEKNUM_ADD, but ISOWEEKNUM does not point to a

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-16 Thread mariosv
Hi Winfried, a common question in ML, Ask and forums, is about the functions: SUMIFS 6.16.63, AVERAGEIFS 6.18.6, COUNTIFS 6.13.10 (OpenDocument-v1.2-part2) People often do not understand very well how to use SUMPRODUCT() or matrix formulas, and with them, is more complicate the use of regular

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-16 Thread Winfried Donkers
Hi Miguel, SUMIFS 6.16.63, AVERAGEIFS 6.18.6, COUNTIFS 6.13.10 The functions you name wait for license clearance to integrate the OOo code for these functions in LibO. fdo 41214 is about SUMIFS, AVERAGEIF(S) and COUNTIFS, you can read about all the details there. Winfried

Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-15 Thread Eike Rathke
Hi Winfried, Long overdue, but better late than never.. This needed some detailed review, which is why I postponed it originally. On Friday, 2012-10-05 12:25:57 +0200, Winfried Donkers wrote: Attached patch modifies the calc functions WEEKNUM and WEEKNUM_ADD to respectively ISOWEEKNUM and

Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-15 Thread Eike Rathke
Hi Winfried, On Tuesday, 2012-11-13 11:08:07 +0100, Winfried Donkers wrote: Would it be an idea if I submit the patch via gerrit? Not to hurry you, but to prevent it from getting burried accidentally ;) It's just buried in my mail folder ;-) Now that I wrote the review we don't need it in

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-15 Thread Winfried Donkers
Hi Eike. Now that I wrote the review we don't need it in gerrit (anymore). I look forward to your comments and probably will modify the code accordingly ;) (same goes for IFERROR() and IFNA() patches) If you have something ready for those you can submit it to gerrit, that's fine. I will,

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-11-13 Thread Winfried Donkers
-Oorspronkelijk bericht- Van: Eike Rathke [mailto:er...@redhat.com] Verzonden: maandag 15 oktober 2012 14:54 Aan: Winfried Donkers CC: libreoffice@lists.freedesktop.org Onderwerp: Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2 Hi Winfried, On Friday, 2012

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-10-23 Thread Winfried Donkers
Hi Eike, Is it correct that the patch has been pushed to master? I do not see anything related in master, probably it is just in your local branch? You are quite right, of course :) I apologise for disturbing you and quickly return to my investigating/experimenting with IFERROR(). Winfried

RE: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-10-22 Thread Winfried Donkers
Attached patch modifies the calc functions WEEKNUM and WEEKNUM_ADD to respectively ISOWEEKNUM and WEEKNUM. I noted that the patch for fdo50950 has been pushed to master whilst 'git pul --rebase'-ing this morning. However i did not see any mail that it has been checked. Is it correct that the

Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-10-22 Thread Eike Rathke
Hi Winfried, On Monday, 2012-10-22 09:27:35 +0200, Winfried Donkers wrote: I noted that the patch for fdo50950 has been pushed to master whilst 'git pul --rebase'-ing this morning. However i did not see any mail that it has been checked. Is it correct that the patch has been pushed to

Re: [PATCH] fdo#50950 modify calc functions WEEKNUM(_ADD) to comply with ODFF1.2

2012-10-15 Thread Eike Rathke
Hi Winfried, On Friday, 2012-10-05 12:25:57 +0200, Winfried Donkers wrote: Attached patch modifies the calc functions WEEKNUM and WEEKNUM_ADD to respectively ISOWEEKNUM and WEEKNUM. Just to tell you that I didn't forget about this patch, I'll come back to you with details later, maybe only