Re: #ifdef vs #if for feature checks

2013-03-20 Thread Thomas Arnhold
Yes, but our internal RSC doesn't support #pragma once ;) On 19.03.2013 07:53, vincent wrote: HI, I found some wiki about #pragma once compiler support http://en.wikipedia.org/wiki/Pragma_once#Portability http://en.wikipedia.org/wiki/Pragma_once#Portability Compiler#pragma once Clang

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Noel Grandin
On 2013-03-20 12:16, Thomas Arnhold wrote: Yes, but our internal RSC doesn't support #pragma once ;) Maybe we could make that a Medium Hack project? Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Michael Stahl
On 20/03/13 12:41, Noel Grandin wrote: On 2013-03-20 12:16, Thomas Arnhold wrote: Yes, but our internal RSC doesn't support #pragma once ;) Maybe we could make that a Medium Hack project? i've already filed https://bugs.freedesktop.org/show_bug.cgi?id=55324 about the CPP proliferation

Re: #ifdef vs #if for feature checks [proof of concept]

2013-03-20 Thread Thomas Arnhold
Hi, https://gerrit.libreoffice.org/#/c/2875/ At least on Linux with --without-java --enable-werror works for me. I only replaced guards like *_HXX_, *_HXX__ and *_HXX_INCLUDED which are not used at any other place. Those are ~8700 matches. Approx. 500 look like guards, but don't match the

Re: #ifdef vs #if for feature checks

2013-03-20 Thread Lubos Lunak
On Tuesday 19 of March 2013, Thomas Arnhold wrote: On 19.03.2013 00:02, Norbert Thiebaud wrote: otoh, #pragma once is supported by all the compiler we use isn't it ? so if we are going to change it, why not use that instead. There are some discussions about that on the Internet. Most

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Thomas Arnhold
On 19.03.2013 00:02, Norbert Thiebaud wrote: On Mon, Mar 18, 2013 at 11:17 AM, Lubos Lunak l.lu...@suse.cz wrote: On Monday 18 of March 2013, Tor Lillqvist wrote: Sounds great to me too; though of course I'd prefer to keep the diff smaller and not replace all the header guards: #ifndef

Re: Re: #ifdef vs #if for feature checks

2013-03-19 Thread vincent
Lunak Subject: Re: #ifdef vs #if for feature checks otoh, #pragma once is supported by all the compiler we use isn't it ? Excellent! Let's do that, unless somebody comes up with a counter-argument in a week or so. --tml ___ LibreOffice mailing list

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Christian Lohmaier
Hi Tor, *, On Tue, Mar 19, 2013 at 6:51 AM, Tor Lillqvist t...@iki.fi wrote: otoh, #pragma once is supported by all the compiler we use isn't it ? Excellent! Let's do that, unless somebody comes up with a counter-argument in a week or so. This doesn't help when the same file is used from two

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Michael Stahl
On 19/03/13 16:25, Christian Lohmaier wrote: Hi Tor, *, On Tue, Mar 19, 2013 at 6:51 AM, Tor Lillqvist t...@iki.fi wrote: otoh, #pragma once is supported by all the compiler we use isn't it ? Excellent! Let's do that, unless somebody comes up with a counter-argument in a week or so.

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Norbert Thiebaud
On Tue, Mar 19, 2013 at 10:25 AM, Christian Lohmaier lohmaier+libreoff...@googlemail.com wrote: Hi Tor, *, On Tue, Mar 19, 2013 at 6:51 AM, Tor Lillqvist t...@iki.fi wrote: otoh, #pragma once is supported by all the compiler we use isn't it ? Excellent! Let's do that, unless somebody comes

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Jan Holesovsky
Hi Thomas, Thomas Arnhold píše v Út 19. 03. 2013 v 05:55 +0100: There are some discussions about that on the Internet. Most interesting: Some kind of benchmark comparison at http://tinodidriksen.com/2011/08/31/cpp-include-speed/ Looks like header guards as we have them are the best

Re: #ifdef vs #if for feature checks

2013-03-19 Thread Norbert Thiebaud
On Tue, Mar 19, 2013 at 12:16 PM, Jan Holesovsky ke...@suse.cz wrote: That's a good point; so I think the person doing the script should check the build time of the entire LO with #pragma before pushing, but otherwise I wouldn't block the change just based on the benchmark - the benchmark

Re: #ifdef vs #if for feature checks

2013-03-16 Thread Noel Grandin
On Fri, Mar 15, 2013 at 5:58 PM, Lubos Lunak l.lu...@suse.cz wrote: The problem with this change is that there still may be some cases where #ifdef is used, either because some system #defines work that way (so those would be valid but different), or people would still use #ifdef out of