Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-24 Thread Korrawit Pruegsanusak
Hello Tim, Thanks for your patch. :-) I didn't test it yet, but just my nitpick: could you please remove the #include rtl/math.hxx which I added to make the build success ? It seems to be unused now. And FYI, Jan Holesovsky changed the zoom factor to 2^(1/4).

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-24 Thread Tim Hardeck
Hi Korrawit, thanks for the information, I have attached a new patch and also 25% is enforced like Stefan requested. Regards Tim On Tuesday 24 January 2012 12:13:20 Korrawit Pruegsanusak wrote: Hello Tim, Thanks for your patch. :-) I didn't test it yet, but just my nitpick: could you

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-23 Thread Tim Hardeck
Hi Stefan, thanks for testing. If 25% is an important number the function enforceStep could be used, if my patch gets accepted. But if other/more specific numbers are also important we really should consider using static/preprocessed zooming levels instead like the Adobe Reader seems to have.

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-22 Thread Stefan Knorr (Astron)
Hi Tim, finally got around to compiling with your patch in and testing the whole thing a bit and think I like the experience. Although, I would still love if you could make sure that we in all cases reach exactly 25% zoom at some point (not just 24 and 26). Thanks for your work. Astron.