Re: [Libreoffice] ODBC handles, a quibble

2011-10-10 Thread Terrence Enger
On Sun, 2011-10-09 at 15:09 +0200, Lionel Elie Mamane wrote: Just ignore the function that diff reports :) (Or send a patch to GNU diffutils so that it recognises C++ syntax ;-) ) Thank you for your reassurance that I am not hallucinating. All-in-all, I guess my attention is better applied

Re: [Libreoffice] ODBC handles, a quibble

2011-10-10 Thread Terrence Enger
On Sun, 2011-10-09 at 15:27 +0200, Lionel Elie Mamane wrote: I did not read *all* of it, but it seems the ODBC documentation contains no such madness. So my guess is that the Microsoft implementation of SQL-CLI that is ODBC defines that handles cross compilation units. IMHO the other

Re: [Libreoffice] ODBC handles, a quibble

2011-10-09 Thread Lionel Elie Mamane
On Tue, Oct 04, 2011 at 12:27:11PM -0400, Terrence Enger wrote: On Tue, 2011-10-04 at 11:27 +0100, Michael Meeks wrote: On Fri, 2011-09-30 at 14:13 -0400, Terrence Enger wrote: My interest is in the fractions of seconds in times and timestamps, an interest provoked by bug 34309 Error on

Re: [Libreoffice] ODBC handles, a quibble

2011-10-09 Thread Lionel Elie Mamane
On Thu, Sep 29, 2011 at 12:02:01PM -0400, Terrence Enger wrote: Silly me! While reading some of the LibreOffice code for ODBC connections, I started to look at ... ISO/IEC FCD 9075-3:2006(E) Title: Information technology - Database Languages - SQL - Part 3: Call-Level

Re: [Libreoffice] ODBC handles, a quibble

2011-10-05 Thread Caolán McNamara
On Tue, 2011-10-04 at 12:27 -0400, Terrence Enger wrote: (*) Caolán's patch fixes also ODatabaseMetaDataResultSet::getTimestamp. (Hunh? Why does the diff say that the changed line is in ODatabaseMetaDataResultSet::getShort? ... I still think the changed function is

Re: [Libreoffice] ODBC handles, a quibble

2011-10-05 Thread Terrence Enger
On Wed, 2011-10-05 at 13:31 +0100, Caolán McNamara wrote: I pushed my patch, mostly because its the simplest, and Lionel can double-check it later at his leisure. I agree. (*) Both patches discard milliseconds. I *guess* this is the right thing to do, but would welcome others'

Re: [Libreoffice] ODBC handles, a quibble

2011-10-04 Thread Michael Meeks
On Fri, 2011-09-30 at 14:13 -0400, Terrence Enger wrote: My interest is in the fractions of seconds in times and timestamps, an interest provoked by bug 34309 Error on importing a timestamp field from db2 via ODBC https://bugs.freedesktop.org/show_bug.cgi?id=34309. Nice - thanks for

Re: [Libreoffice] ODBC handles, a quibble

2011-10-04 Thread Terrence Enger
I am sorry for the length of this answer; hope it is worth reading. On Tue, 2011-10-04 at 11:27 +0100, Michael Meeks wrote: On Fri, 2011-09-30 at 14:13 -0400, Terrence Enger wrote: My interest is in the fractions of seconds in times and timestamps, an interest provoked by bug 34309 Error on

Re: [Libreoffice] ODBC handles, a quibble

2011-10-04 Thread Stephan Bergmann
On 10/04/2011 06:27 PM, Terrence Enger wrote: (*) In the hope of attracting critical feedback (but constructive, of course: this is after all LibreOffice grin /), I sprinkled the code liberally with questions and comments. Most conspicuously, - I cite the X/Open reference

Re: [Libreoffice] ODBC handles, a quibble

2011-10-03 Thread Terrence Enger
On Mon, 2011-10-03 at 11:06 +0100, Caolán McNamara wrote: On Thu, 2011-09-29 at 12:02 -0400, Terrence Enger wrote: The validity of a handle in a compilation unit other than the one in which the identified resource was allocated is implementation-defined. If I had to guess,

Re: [Libreoffice] ODBC handles, a quibble

2011-09-30 Thread Michael Meeks
Hi Terrence, First - it's awesome to have you looking at, reading and caring about the ODBC code - that's brilliant. On Thu, 2011-09-29 at 12:02 -0400, Terrence Enger wrote: Silly me! While reading some of the LibreOffice code for ODBC connections, I started to look at ... .. This

Re: [Libreoffice] ODBC handles, a quibble

2011-09-30 Thread Alexander Thurgood
Le 29/09/11 18:02, Terrence Enger a écrit : Hi Terry, Not sure whether what I have in my memory has any bearing on this, but... I remember discussions with Frank Schoenheit back from the OOo days about mysql ODBC driver misbehaviour because it erroneously reported some status and functionality

Re: [Libreoffice] ODBC handles, a quibble

2011-09-30 Thread Terrence Enger
On Fri, 2011-09-30 at 16:25 +0200, Alexander Thurgood wrote: Le 29/09/11 18:02, Terrence Enger a écrit : Hi Terry, Not sure whether what I have in my memory has any bearing on this, but... I remember discussions with Frank Schoenheit back from the OOo days about mysql ODBC driver