Re: [PATCH] Remove unused code (ImpSvtData)

2012-04-25 Thread Caolán McNamara
On Wed, 2012-04-25 at 05:16 -0700, Javier Catala wrote: Hi everyone, This patch removes unused destructor in the ImpSvtData class, as listed in unusedcode.easy Yeah, but see unusedcode.README and f. If the constructor used, but the destructor is unused. Then its probably a leak and we

[PUSHED] Re: [PATCH] Remove unused code (vcl)

2012-04-06 Thread Matúš Kukan
Hello, On 4 April 2012 17:14, Thomas Collerton tom.col...@gmail.com wrote: Hello all, this patch removes unused code in the Slider class as listed in unusedcode.easy Looks good = pushed Thanks, Matúš ___ LibreOffice mailing list

[PUSHED] Re: [PATCH] remove unused code (oox)

2012-04-05 Thread Jan Holesovsky
Hi Petr, Petr Vorel píše v Po 02. 04. 2012 v 16:18 +0200: removed unused classes from oox. Pushed: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07ff032c805835355ff0dff75b8ad534dfb770e9 Thank you! :-) Regards, Kendy ___ LibreOffice

Re: [PATCH] Remove unused code from gtkframe

2012-02-16 Thread Caolán McNamara
On Wed, 2012-02-15 at 22:55 +0100, Michael Stahl wrote: On 15/02/12 21:31, Kate Goss wrote: Hi Michael, Caolan, How accurate/ up to date is unusedcode.easy? Is there a way to make sure the methods I'm removing are genuinely unused? Its generally up to date, but it always requires at

[PUSHED] Re: [PATCH] Remove unused code

2012-02-16 Thread Radek Doulik
Hi Björgvin, looks good to me. Pushed. Thanks! Cheers Radek On Wed, 2012-02-15 at 01:10 +, Björgvin Ragnarsson wrote: Hi, Attached is a patch for removal of unused code in files core/basegfx/source/polygon/b3dpolygontools.cxx and core/basegfx/inc/basegfx/polygon/b3dpolygontools.hxx

[PUSHED] Re: [PATCH] Remove unused code

2012-02-15 Thread Jan Holesovsky
Just adding [PUSHED] :-) Radek Doulik píše v Út 14. 02. 2012 v 19:03 +0100: Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy

Re: [PATCH] Remove unused code from gtkframe

2012-02-15 Thread Michael Meeks
Hi Kate, On Tue, 2012-02-14 at 21:33 +, Kate Goss wrote: Please find attached a patch to remove a couple of methods listed in unusedcode.easy, from gtkframe. Sadly they are used - but only for the gtk3 mode that caolan is not compiling. Perhaps instead if you could move up the #if

Re: [PATCH] Remove unused code from connectivity::odbc

2012-02-14 Thread Caolán McNamara
On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote: Thanks, but this one should actually be used in ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, I'll convert getTableTypes to using it How about the other one ? C.

Re: [PATCH] Remove unused code

2012-02-14 Thread Radek Doulik
Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: This patch removes unused code as listed in unusedcode.easy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] Remove unused code

2012-02-13 Thread Caolán McNamara
On Mon, 2012-02-13 at 00:08 +, Björgvin Ragnarsson wrote: Hello, Attached is my first contribution to Libreoffice Looks good to me, pushed now, thanks for this. C. You should add yourself to http://wiki.documentfoundation.org/Development/Developers and link back to your last email via

Re: [PATCH] Remove unused code (9)

2012-02-13 Thread Michael Meeks
On Sat, 2012-02-11 at 12:01 +0800, Elton Chung wrote: This patch removes 11 unused methods. Lovely, it seems our delay at reviewing caused a few conflicts with others; hopefully you'll be able to pull / re-base any bits you have on top of what I pushed here. Thanks !

Re: [PATCH] Remove unused code from connectivity::odbc

2012-02-13 Thread Lionel Elie Mamane
On Mon, Feb 13, 2012 at 10:06:17PM +, Kate Goss wrote: Please see attached. From 099415fb77eddd7d211ae6ed547cb31b10484a37 Mon Sep 17 00:00:00 2001 From: Kate Goss katherine.g...@gmail.com Date: Sun, 12 Feb 2012 13:57:46 + Subject: [PATCH 1/2] Remove unused method

Re: [PATCH] Remove unused code (5)

2012-02-11 Thread Ivan Timofeev
On 10.02.2012 18:24, Elton Chung wrote: This patch removes 5 unused methods. Pushed, thank you. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code

2011-01-11 Thread Caolán McNamara
On Tue, 2011-01-11 at 22:23 +0100, Anders Jonsson wrote: Some more commented code, this time in calc. All code has been commented out at least since 2005. Looks good, pushed, thanks for this. From the patch, it seems that means that ScRedlineOptionsTabPage is now an empty function that just

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code and fix typos

2011-01-09 Thread Caolán McNamara
On Sun, 2011-01-09 at 02:06 +0900, Takeshi Abe wrote: Hi, Here is a bunch of cleanup on base. Looks good to me, pushed, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] [PUSHED] Re: [PATCH] Remove unused code

2010-12-18 Thread Caolán McNamara
On Sat, 2010-12-18 at 14:06 +0100, Anders Jonsson wrote: Some more blocks of unused code in libs-gui and libs-core. All have been commented out since at least 2006. All looks good, into the bin with it, thanks for this. Pushed now. C. ___