On Friday 14 of December 2012, pkoroau pkoroau wrote:
2012/12/12 Caolán McNamara caol...@redhat.com:
Could you submit a new patch with the fixups ?
C.
Sure! Thank you for the review.
Looks like this has been pushed yet, so done, thanks for the patch.
--
Lubos Lunak
l.lu...@suse.cz
2012/12/12 Caolán McNamara caol...@redhat.com:
Could you submit a new patch with the fixups ?
C.
Sure! Thank you for the review.
pkoroau
--
diff --git a/sw/inc/IDocumentTimerAccess.hxx b/sw/inc/IDocumentTimerAccess.hxx
index 84e3cd4..458ad79 100644
--- a/sw/inc/IDocumentTimerAccess.hxx
+++
On Sat, 2012-12-08 at 21:17 +0100, pkoroau pkoroau wrote:
2012/12/5 Caolán McNamara:
1. In e.g. SetNeedGrammarCheck and SetFieldsDirty shouldn't
StartBackgroundJobs only be called for the true case and not the
false case ?
I planned to negate. That should be:
if (
2012/12/5 Caolán McNamara:
1. In e.g. SetNeedGrammarCheck and SetFieldsDirty shouldn't
StartBackgroundJobs only be called for the true case and not the
false case ?
1. Yes, that's right.
if ( !GetUpdtFlds().IsInUpdateFlds()
!IsExpFldsLocked() )
2. I planned to negate. That should
On Wed, 2012-11-28 at 23:25 +0100, pkoroau pkoroau wrote:
Hello, I'm sending this patch to fix Writer's aIdleTimer.
This looks promising. But a couple of things.
1. In e.g. SetNeedGrammarCheck and SetFieldsDirty shouldn't
StartBackgroundJobs only be called for the true case and not the
false