Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

2012-05-10 Thread Andras Timar
2012/5/7 Jesús Corrius je...@softcatala.org: Hi Andras, If it fails, nothing special will happen. The control will not be sorted, that is. I don't think we should stop and rollback the install. We ignore the return code of most of our custom actions. The behavior of FindWindow or

Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

2012-05-10 Thread Jesús Corrius
OK, what about this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce1ac0851fe2e975f3fb47178730b914608610cf Looks good and perfectly safe for the 3-5 branch, IMO. Thanks for this. -- Jesús Corrius je...@softcatala.org ___ LibreOffice

Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

2012-05-07 Thread Jesús Corrius
Hi Andras, On Sun, May 6, 2012 at 10:34 PM, Andras Timar tima...@gmail.com wrote: Fortunately the tree control under Windows can receive a message that does the sort, so everything can be solved with pure Windows API calls.

Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

2012-05-07 Thread Andras Timar
2012/5/7 Jesús Corrius je...@softcatala.org: Hi Andras, On Sun, May 6, 2012 at 10:34 PM, Andras Timar tima...@gmail.com wrote:  Fortunately the tree control under Windows can receive a message that does the sort, so everything can be solved with pure Windows API calls.

Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

2012-05-07 Thread Jesús Corrius
Hi Andras, If it fails, nothing special will happen. The control will not be sorted, that is. I don't think we should stop and rollback the install. We ignore the return code of most of our custom actions. The behavior of FindWindow or FindWindowEx is different if some of the parameters are