Re: Chart test failures on mac: text size differences

On Mon, Mar 06, 2017 at 07:56:40PM +0200, Khaled Hosny wrote: > On Mon, Mar 06, 2017 at 11:21:25AM +, Tamas Zolnai wrote: > > On Tuesday, February 28, 2017 23:42 GMT, Khaled Hosny > > wrote: > > > > > On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Zolnai wrote: > > >

Re: Chart test failures on mac: text size differences

On Mon, Mar 06, 2017 at 11:21:25AM +, Tamas Zolnai wrote: > On Tuesday, February 28, 2017 23:42 GMT, Khaled Hosny > wrote: > > > On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Zolnai wrote: > > > Hi Khaled, > > > > > > > I don’t think text width or height are that

Re: Chart test failures on mac: text size differences

On Tuesday, February 28, 2017 23:42 GMT, Khaled Hosny wrote: > On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Zolnai wrote: > > Hi Khaled, > > > > > I don’t think text width or height are that interesting, but they are > > > probably a good approximation, so I

Re: Chart test failures on mac: text size differences

On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Zolnai wrote: > Hi Khaled, > > > I don’t think text width or height are that interesting, but they are > > probably a good approximation, so I repurposed one of the existing VCL > > tests to test this[1]. I tried testing also the text bounding

Re: Chart test failures on mac: text size differences

Hi Khaled, > I don’t think text width or height are that interesting, but they are > probably a good approximation, so I repurposed one of the existing VCL > tests to test this[1]. I tried testing also the text bounding rectangle > but it showed a 1 pixel difference on Mac, this should be fixed

Re: Chart test failures on mac: text size differences

Hi Khaled, On Sunday, February 26, 2017 23:30 GMT, Khaled Hosny wrote: > On Sat, Feb 25, 2017 at 09:58:58PM +, Tamas Zolnai wrote: > > Hi Khaled, > > > > > > However I think it would be better to debug this problem with a unit > > > > test in vcl module which

Re: Chart test failures on mac: text size differences

On Sat, Feb 25, 2017 at 09:58:58PM +, Tamas Zolnai wrote: > Hi Khaled, > > > > However I think it would be better to debug this problem with a unit > > > test in vcl module which tests directly the text rendering. I would > > > suggest that if you are working making text rendering consitent.

Re: Chart test failures on mac: text size differences

Hi Khaled, > > However I think it would be better to debug this problem with a unit > > test in vcl module which tests directly the text rendering. I would > > suggest that if you are working making text rendering consitent. The > > vcldemo does something similar, but it's just doing the

Re: Chart test failures on mac: text size differences

I missed the attachments! On Sat, Feb 25, 2017 at 11:23:51PM +0200, Khaled Hosny wrote: > On Sat, Feb 25, 2017 at 12:04:10PM +, Tamas Zolnai wrote: > > Hi Khaled, > > > > On Friday, February 24, 2017 19:40 GMT, Khaled Hosny > > wrote: > > > > > On Fri, Feb 24, 2017

Re: Chart test failures on mac: text size differences

On Sat, Feb 25, 2017 at 12:04:10PM +, Tamas Zolnai wrote: > Hi Khaled, > > On Friday, February 24, 2017 19:40 GMT, Khaled Hosny > wrote: > > > On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote: > > > Hi Khaled, > > > > > > I see you're working on text

Re: Chart test failures on mac: text size differences

Hi Khaled, On Friday, February 24, 2017 19:40 GMT, Khaled Hosny wrote: > On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote: > > Hi Khaled, > > > > I see you're working on text rendering, so I thought that my findings > > might be usefull for you. I had a

Re: Chart test failures on mac: text size differences

On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote: > Hi Khaled, > > I see you're working on text rendering, so I thought that my findings > might be usefull for you. I had a look at chart test failures on Mac > and found that it is because of text size differences. (I checked your >