Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-14 Thread Michael Meeks
Hi Christina, On Mon, 2012-03-05 at 14:59 +0100, Chr. Rossmanith wrote: as suggested on IRC I've removed the whole StrictSO52Compatibility stuff. It builds successfully - make test is on its way. git grep reported some test documents matching as well, so I expect some tests to fail.

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-14 Thread Chr. Rossmanith
Am 14.03.2012 15:42, schrieb Michael Meeks: Hi Christina, On Mon, 2012-03-05 at 14:59 +0100, Chr. Rossmanith wrote: as suggested on IRC I've removed the whole StrictSO52Compatibility stuff. It builds successfully - make test is on its way. git grep reported some test documents matching as

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-05 Thread Michael Meeks
On Fri, 2012-03-02 at 21:03 +0100, Chr. Rossmanith wrote: static const sal_Char pProlog[] and static const sal_Char pSO52CompatProlog[] share about 90% of their content (2 out of 84 lines differ). Wow - that is really horrible :-) I could split the prolog in three parts: part 1

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-05 Thread Chr. Rossmanith
Hi, as suggested on IRC I've removed the whole StrictSO52Compatibility stuff. It builds successfully - make test is on its way. git grep reported some test documents matching as well, so I expect some tests to fail. Christina Am 05.03.2012 12:41, schrieb Michael Meeks: On Fri, 2012-03-02

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-05 Thread Caolán McNamara
On Mon, 2012-03-05 at 11:41 +, Michael Meeks wrote: Caolan - I notice the option seems to be mentioned in: qadevOOo/testdocs/ttt.sda Which you touched last :-) is this a feature we need to keep ? Originally the smoketest just wrote out some .sdX files and reloaded