Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-16 Thread Miklos Vajna
Hi Bjoern, On Wed, Oct 15, 2014 at 10:36:23AM +0200, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Hi, On Wed, Oct 15, 2014 at 09:34:13AM +0200, Miklos Vajna wrote: My new builds now have a commit message like 2014-10-15: source-hash-defa080e585fb351bc4049b2f280d2e7e5256f6e in

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-15 Thread Miklos Vajna
Hi Terry, On Tue, Oct 14, 2014 at 10:28:21AM -0400, Terrence Enger ten...@iseries-guru.com wrote: On Tue, 2014-10-14 at 12:12 +0200, Bjoern Michaelsen wrote: Since you have the source hash in the build-info.txt file, it might be helpful to have some script tagging the commit accordingly

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-15 Thread Bjoern Michaelsen
Hi, On Wed, Oct 15, 2014 at 09:34:13AM +0200, Miklos Vajna wrote: My new builds now have a commit message like 2014-10-15: source-hash-defa080e585fb351bc4049b2f280d2e7e5256f6e in the dbgutil repo, hope that keeps everyone happy. :-) Thats lovely, but still doesnt show up in git bisect log,

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Stephan Bergmann
On 10/13/2014 10:07 PM, nicholas ferguson wrote: Suggest adding --enable-assert-dbg-never-abort prevent assert() aborts in debug mode. I see no good reason for that. (If your are so desperate that you need that for whatever reason, you should be able to add an ad-hoc patch locally,

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Bjoern Michaelsen
Hi, On Tue, Oct 14, 2014 at 09:35:25AM +0200, Stephan Bergmann wrote: On 10/13/2014 10:07 PM, nicholas ferguson wrote: Suggest adding --enable-assert-dbg-never-abort prevent assert() aborts in debug mode. I see no good reason for that. (If your are so desperate that you need that

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Stephan Bergmann
On 10/14/2014 10:51 AM, Bjoern Michaelsen wrote: Well, I see a good reason for that. I recently saw some bibisects being done with Mikloss dbgutils bibisect repo[1] and they seem to contain more git bisect skips than everything else leading to less than optimal results. Now the fact that the

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Miklos Vajna
Hi Bjoern, On Tue, Oct 14, 2014 at 10:51:32AM +0200, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: Well, I see a good reason for that. I recently saw some bibisects being done with Mikloss dbgutils bibisect repo[1] and they seem to contain more git bisect skips than everything else

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Michael Stahl
On 14.10.2014 11:19, Stephan Bergmann wrote: On 10/14/2014 10:51 AM, Bjoern Michaelsen wrote: Well, I see a good reason for that. I recently saw some bibisects being done with Mikloss dbgutils bibisect repo[1] and they seem to contain more git bisect skips than everything else leading to less

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Bjoern Michaelsen
Hi, On Tue, Oct 14, 2014 at 11:19:12AM +0200, Stephan Bergmann wrote: That sounds somewhat odd, given that at least make check apparently does not generally trigger failing asserts, so I would not assume that some random do something specific in LO would routinely do. Do you have an example?

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Bjoern Michaelsen
Hi Miklos, On Tue, Oct 14, 2014 at 11:49:24AM +0200, Miklos Vajna wrote: So it's the same as yours, just you need to do 'git show $sha1:build-info.txt', not 'git show $sha1' if you want to get core.git hashes. Not quite (unless Im missing something). Compare e.g.:

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Stephan Bergmann
On 10/14/2014 12:06 PM, Bjoern Michaelsen wrote: I havent bibisected with that repo myself yet, just saw that e.g.: https://bugs.freedesktop.org/show_bug.cgi?id=84733#c1 has a lot of skipped commits. (Looks like I at least cannot easily reproduce that on my Fedora machine, as that

Re: allow ASSERT_ALWAYS_ABORT for debug builds on windows to be true or false

2014-10-14 Thread Terrence Enger
On Tue, 2014-10-14 at 12:12 +0200, Bjoern Michaelsen wrote: Since you have the source hash in the build-info.txt file, it might be helpful to have some script tagging the commit accordingly so that 'git bisect log' shows the source hashes too. That would be helpful. However, I would ask for