Re: bug 74702

Hi Adrien, On 22.04.2019 12:43, Adrien Ollier wrote: > sorry I meant impedit3.cxx, lines 2805 and 2806. > > Ok I'll try to make some changes in gerrit. Nice, looking forward to see it mentioned here in the thread. Please note that answering someone's answer directly, without CCing the mailing

Re: bug 74702

Hi Adrien, Am 22.04.19 um 10:58 schrieb Adrien Ollier: > 1. there is function XParaPortionList::RefDevIsVirtual() that uses > attribute XParaPortionList::eRefDevIsVirtual which is of type OutDevType > which must be removed. > XParaPortionList::eRefDevIsVirtual is never set >

Re: bug 74702

Hi Adrien, First of all, it's best to have a tentative change in gerrit, with your proposed changes, to have better overview. Please create if you haven't yet, and post the link here. Thanks! On 22.04.2019 11:58, Adrien Ollier wrote: > 2. In editeng/source/editeng/impedit2.cxx it is required

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

Chiming in a little late. Am 15.04.19 um 09:50 schrieb Kaganski Mike: > On 15.04.2019 10:44, Adrien Ollier wrote: >> OutputDevice::AcquireGraphics() is a pure virtual function, so we cannot >> know in the general case what it does. >> And what is written is not really equivalent to what you

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

On 15.04.2019 10:44, Adrien Ollier wrote: > And what is written is not really equivalent to what you wrote because > if AcquireGraphics() is false, there is not a second check for mpGraphics Also note that when AcquireGraphics() is false (telling it could not acquire mpGraphics successfully),

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

On 15.04.2019 10:44, Adrien Ollier wrote: > OutputDevice::AcquireGraphics() is a pure virtual function, so we cannot > know in the general case what it does. > And what is written is not really equivalent to what you wrote because > if AcquireGraphics() is false, there is not a second check for

Re: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

On 15.04.2019 10:33, Adrien Ollier wrote: > Hello everybody, > > working on bug #74702 >  led me to > read file core/vcl/source/outdev/nativecontrols.cxx. > > I think there is an issue here: > > > > If mpGraphics == nullptr and

RE: bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart)

errata De : Adrien Ollier Envoyé : lundi 15 avril 2019 09:33 À : libreoffice@lists.freedesktop.org Objet : bug 74702 - Issue with bool OutputDevice::IsNativeControlSupported(ControlType, ControlPart) Hello everybody, working on bug