RE: patch removing Labels.xcu out of configuration

2013-02-18 Thread Michael Meeks
Hi Winfried, On Mon, 2013-02-18 at 08:43 +0100, Winfried Donkers wrote: I get an exception (warn:legacy.osl:24509:1:unotools/source/config/configitem.cxx:58: Exception from GetNodeNames: *['Avery A4']) which can well be the cause of not being able to overwrite existing labels.

RE: patch removing Labels.xcu out of configuration

2013-02-17 Thread Winfried Donkers
Hi Matus, Michael, Well, overwriting existing labels does not work I think, but it did not before either, so.. I think that's fine. If you would like to fix this, poke IMPL_LINK_NOARG(SwSaveLabelDlg, OkHdl) in sw/source/ui/envelp/labfmt.cxx Maybe if(RET_YES != eRet) makes it return before

Re: patch removing Labels.xcu out of configuration

2013-02-14 Thread Matúš Kukan
On 13 February 2013 22:05, Michael Meeks michael.me...@suse.com wrote: Wrt. the saving issue - it'd be interesting to see what happens in SwLabelConfig::SaveLabel as you step through that when clicking 'Ok' in the relevant dialog. Are we failing to add the node ? are we somehow not

Re: patch removing Labels.xcu out of configuration

2013-02-13 Thread Michael Meeks
Hi Matus, On Wed, 2013-02-13 at 21:04 +0100, Matúš Kukan wrote: I've finished my first patch on reducing configuration data and decided to send it this way. It looks lovely ! :-) thanks for that. It seems to work, although not as I was expecting. You still can't save modified