Re: SVG: scaling if no width/height is given

2013-06-23 Thread Regina Henschel
Hi Christina, Regina Henschel schrieb: Hi Christina, Regina Henschel schrieb: Hi Christina, I have seen you patch at Gerrit now. I think, that SvgAspectRatio::createLinearMapping is the wrong place to constrain the scaling because this method is used in svgimagenode.cxx and

Re: [Suspected Junk Mail] Re: SVG: scaling if no width/height is given

2013-06-21 Thread Michael Meeks
On Thu, 2013-06-20 at 21:24 +0200, bugreporte...@hushmail.com wrote: Please guys, this is about open source software and people having fun doing some coding/helping an open source project/s. Right - the root cause of these issues grows directly from the consequences of the choice to

Re: SVG: scaling if no width/height is given

2013-06-20 Thread Regina Henschel
Hi Christina, I have seen you patch at Gerrit now. I think, that SvgAspectRatio::createLinearMapping is the wrong place to constrain the scaling because this method is used in svgimagenode.cxx and svgstyleattributes.cxx too. I think, that the decision whether to keep aspect ratio or not,

Re: [Suspected Junk Mail] Re: SVG: scaling if no width/height is given

2013-06-20 Thread bugreporter99
I was rejected and blamed for even looking there .., But that is really off topic on this list That's really said when a person trys to help and gets rejected. Also it's frustrating to have to report the SAME bugs to TWO different bugtrackers. Please guys, this is about open source software

Re: SVG: scaling if no width/height is given

2013-06-20 Thread Regina Henschel
Hi Christina, Regina Henschel schrieb: Hi Christina, I have seen you patch at Gerrit now. I think, that SvgAspectRatio::createLinearMapping is the wrong place to constrain the scaling because this method is used in svgimagenode.cxx and svgstyleattributes.cxx too. I think, that the decision

Re: SVG: scaling if no width/height is given

2013-06-19 Thread Thorsten Behrens
Christina Roßmanith wrote: the problem described here - https://bugs.freedesktop.org/show_bug.cgi?id=64125 is caused by a missing width and height attribute of the SVG given as an example. So, what would we expect given a ViewBox attribute when importing a graphic? What I'd expect is that

Re: SVG: scaling if no width/height is given

2013-06-19 Thread Thorsten Behrens
Hi Armin, I wonder, you wrote: you have found the developer of the SVG import, congrats ;-) Christina has been doing great development work around the LibreOffice svg story, not limited to, but including 'your' svg code - as did a number of other people. In total, there are 26 very useful fixes

Re: SVG: scaling if no width/height is given

2013-06-19 Thread Armin Le Grand
Hi Christina, On 18.06.2013 21:09, Christina Roßmanith wrote: Hi, you have found the developer of the SVG import, congrats ;-). Sure I am willing to help and always interested in bug reports for my importer; I have fixed some in the last days anyways. To do so, I would need a bug report

Re: SVG: scaling if no width/height is given

2013-06-19 Thread Armin Le Grand
Hi Thorsten, On 19.06.2013 17:55, Thorsten Behrens wrote: Hi Armin, I wonder, you wrote: you have found the developer of the SVG import, congrats ;-) Christina has been doing great development work around the LibreOffice svg story, not limited to, but including 'your' svg code - as did

Re: SVG: scaling if no width/height is given

2013-06-19 Thread Bjoern Michaelsen
Hi Armin, On Wed, Jun 19, 2013 at 06:20:55PM +0200, Armin Le Grand wrote: The last ime I did and asked if I could use the obvious single-line change (long time ago) I was rejected and blamed for even looking there, you know ;-) You can -- obviously respecting the usual license. Its not like

SVG: scaling if no width/height is given

2013-06-18 Thread Christina Roßmanith
Hi, the problem described here - https://bugs.freedesktop.org/show_bug.cgi?id=64125 is caused by a missing width and height attribute of the SVG given as an example. So, what would we expect given a ViewBox attribute when importing a graphic? What I'd expect is that the aspect ratio is kept

Re: SVG: scaling if no width/height is given

2013-06-18 Thread Regina Henschel
Hi Christina, Christina Roßmanith schrieb: Hi, the problem described here - https://bugs.freedesktop.org/show_bug.cgi?id=64125 is caused by a missing width and height attribute of the SVG given as an example. So, what would we expect given a ViewBox attribute when importing a graphic? What