Re: UI tests opening all possible dialogs

Hi Raal, please have a look at the newest version of https://gerrit.libreoffice.org/#/c/74333/ I've added tests of the "cancel" button to wherever other tests check the work of that specific dialog. As far as possible I tried not to open new documents for the new test, but integrate into the

Re: UI tests opening all possible dialogs

Hi Artur, yes, because longest time of uitest is initialize and open LibreOffice. Thank you Regards, Raal On 25. 06. 19 13:30, Artur Neumann wrote: Hi Raal, so you would prefer if the "Cancel/Close" tests would be integrated in other tests of that dialog if those exist like I've done now

Re: UI tests opening all possible dialogs

Hi Raal, so you would prefer if the "Cancel/Close" tests would be integrated in other tests of that dialog if those exist like I've done now https://gerrit.libreoffice.org/#/c/74333/9/sc/qa/uitest/calc_tests/fillRandomNumber.py

Re: UI tests opening all possible dialogs

Hi Artur, see https://gerrit.libreoffice.org/#/c/74654/ - you can add test for Cancel button to existing tests. Cheers, Raal On 24. 06. 19 9:22, Artur Neumann wrote: Hi Raal & Markus I've moved the tests into a new folder and skipped tests that are already done in other tests. The lines

Re: UI tests opening all possible dialogs

Hi Raal & Markus I've moved the tests into a new folder and skipped tests that are already done in other tests. The lines have comments explaining why specific tests are skipped. https://gerrit.libreoffice.org/#/c/74333/ If you thing testing the "Cancel" button does not make sense, we can skip

Re: UI tests opening all possible dialogs

Hi Raal, thank you for the advice. I thought of deleting obsolete tests like uitest/calc_tests/about_test.py in the second step. But its true, as the more complex tests have to be kept anywhere some of the simple tests in my commit can be deleted. The question is though if in some cases they

Re: UI tests opening all possible dialogs

Hi, I didn't had  contact with Raal yet. Added him and you to the reviewers list. It takes around 3min to run all tests of the commit on my laptop (i5-4200U CPU @ 1.60GHz) and showing the UI. Using (LibreOffice Version: 6.3.0.0.beta1+ Build ID: 4904391e125eb66304a5c029def8d4c1a150952d) Currently

Re: UI tests opening all possible dialogs

Hello Artur, generally it looks useful, but please check first if such test exists. For example bug 120227 is already covered by this test https://opengrok.libreoffice.org/xref/core/sc/qa/uitest/pageFormat/tdf123508 .py . Please

Re: UI tests opening all possible dialogs

Hello Artur, On Fri, Jun 21, 2019 at 12:06 PM Artur Neumann wrote: > Forgot the link to the changes, here it is: > https://gerrit.libreoffice.org/#/c/74333/ > On 2019-06-20 5:01 p.m., Artur Neumann wrote: > > I've made some UI tests that open every dialog in calc, close it with the > "close" or

Re: UI tests opening all possible dialogs

Forgot the link to the changes, here it is: https://gerrit.libreoffice.org/#/c/74333/ On 2019-06-20 5:01 p.m., Artur Neumann wrote: > > I've made some UI tests that open every dialog in calc, close it with > the "close" or "cancel" button and if there is an "OK" button open it > again and click

UI tests opening all possible dialogs

I've made some UI tests that open every dialog in calc, close it with the "close" or "cancel" button and if there is an "OK" button open it again and click the "OK" button These tests should simply make sure there are no crashes by opening/closing the dialogues and protect against regressions