Re: changing the UNO dispose/disposing() protocol ?

2023-05-31 Thread Miklos Vajna
Hi Noel, On Tue, May 30, 2023 at 12:29:40PM +0200, Noel Grandin wrote: > > Do you have a context for this? I assume you dived into some actual > > problem and then this came up? > > > I am specifically looking at cleaning up memory leaks, and a lot of those > have to do with cycles forming in

Re: changing the UNO dispose/disposing() protocol ?

2023-05-30 Thread Noel Grandin
On Tue, 30 May 2023 at 10:25, Stephan Bergmann wrote: > This does not encourage implementations of XComponent to throw > DisposedException upon repeated calls to dispose, anyway. > > Aha, that is good to know! In that case I can fix the cases where it is unnecessarily throwing (one by one of

Re: changing the UNO dispose/disposing() protocol ?

2023-05-30 Thread Noel Grandin
On Tue, 30 May 2023 at 08:40, Miklos Vajna wrote: > Did you try if make check enforces the current behavior? > No idea. > > Do you have a context for this? I assume you dived into some actual > problem and then this came up? > > I am specifically looking at cleaning up memory leaks, and a lot

Re: changing the UNO dispose/disposing() protocol ?

2023-05-30 Thread Stephan Bergmann
On 5/28/23 16:02, Noel Grandin wrote: Specifically, I would like to change the part where if a component is already disposed, it throws a DisposedException. Instead it should simply ignore the call (i.e. return early) The documentation of css.lang.XComponent::dispose at

Re: changing the UNO dispose/disposing() protocol ?

2023-05-30 Thread Miklos Vajna
Hi Noel, On Sun, May 28, 2023 at 04:02:21PM +0200, Noel Grandin wrote: > I would like to change the existing UNO dispose()/disposing() protocol. > > Specifically, I would like to change the part where if a component is > already disposed, it throws a DisposedException. Instead it should simply

changing the UNO dispose/disposing() protocol ?

2023-05-28 Thread Noel Grandin
Hi I would like to change the existing UNO dispose()/disposing() protocol. Specifically, I would like to change the part where if a component is already disposed, it throws a DisposedException. Instead it should simply ignore the call (i.e. return early) The reason for this, is threefold (1)