accessibility/inc/standard/vclxaccessiblemenuitem.hxx | 2 codemaker/source/cppumaker/cpputype.cxx | 2 compilerplugins/clang/unnecessaryvirtual-dead.results | 12 - compilerplugins/clang/unnecessaryvirtual.results | 212 ++++++++++++++---- sc/inc/patattr.hxx | 2 vcl/inc/jsdialog/jsdialogbuilder.hxx | 8 6 files changed, 185 insertions(+), 53 deletions(-)
New commits: commit 6583f5d6b2120d1602c8a55c4e8dcc2b83503862 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Mon Jan 15 12:46:15 2024 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Mon Jan 15 13:56:05 2024 +0100 loplugin:unnecessaryvirtual Change-Id: I14ee125874b6f0f1ff5406a3eafea0b19df1a7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/accessibility/inc/standard/vclxaccessiblemenuitem.hxx b/accessibility/inc/standard/vclxaccessiblemenuitem.hxx index 4eec5fa6746e..aa6a0afc814a 100644 --- a/accessibility/inc/standard/vclxaccessiblemenuitem.hxx +++ b/accessibility/inc/standard/vclxaccessiblemenuitem.hxx @@ -41,7 +41,7 @@ class VCLXAccessibleMenuItem : public cppu::ImplInheritanceHelper< protected: virtual bool IsFocused() override; virtual bool IsSelected() override; - virtual bool IsCheckable(); + bool IsCheckable(); virtual bool IsChecked() override; virtual bool IsHighlighted() override; diff --git a/codemaker/source/cppumaker/cpputype.cxx b/codemaker/source/cppumaker/cpputype.cxx index c67772eb2e88..f600cff8ad8c 100644 --- a/codemaker/source/cppumaker/cpputype.cxx +++ b/codemaker/source/cppumaker/cpputype.cxx @@ -189,7 +189,7 @@ public: virtual void dumpHppFile(FileStream& o, codemaker::cppumaker::Includes & includes) = 0; - virtual void dumpEmbindCppFile(FileStream& o); + void dumpEmbindCppFile(FileStream& o); OUString dumpHeaderDefine(FileStream& o, std::u16string_view extension) const; diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results index ae2c471b216c..65b8bb57a09b 100644 --- a/compilerplugins/clang/unnecessaryvirtual-dead.results +++ b/compilerplugins/clang/unnecessaryvirtual-dead.results @@ -8,19 +8,21 @@ canvas/inc/base/graphicdevicebase.hxx:318 void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,) include/basegfx/utils/unopolypolygon.hxx:93 void basegfx::unotools::UnoPolyPolygon::modifying()const -include/comphelper/propmultiplex2.hxx:54 - void comphelper::OPropertyChangeListener2::_disposing(const struct com::sun::star::lang::EventObject &,) sc/source/core/opencl/opbase.hxx:447 void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class sc::opencl::outputstream &,) slideshow/source/engine/animationfactory.cxx:617 void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch() -vcl/inc/font/LogicalFontInstance.hxx:126 +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:2002 + void std::messages::do_close(int,)const +ux-gnu/../../../include/c++/13/streambuf:583 + void std::basic_streambuf::imbue(const class std::locale &,) +vcl/inc/font/LogicalFontInstance.hxx:123 void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,) vcl/inc/salframe.hxx:145 void SalFrame::SetRepresentedURL(const class rtl::OUString &,) -vcl/inc/salinst.hxx:204 +vcl/inc/salinst.hxx:203 void SalInstance::releaseMainThread() -vcl/inc/salinst.hxx:213 +vcl/inc/salinst.hxx:212 void SalInstance::BeforeAbort(const class rtl::OUString &,_Bool,) vcl/inc/salobj.hxx:49 void SalObject::Enable(_Bool,) diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results index 96c0ef52a9b5..3ddcc5fe93be 100644 --- a/compilerplugins/clang/unnecessaryvirtual.results +++ b/compilerplugins/clang/unnecessaryvirtual.results @@ -1,3 +1,5 @@ +accessibility/inc/standard/vclxaccessiblemenuitem.hxx:44 + _Bool VCLXAccessibleMenuItem::IsCheckable() basic/source/comp/codegen.cxx:478 void (anonymous namespace)::OffSetAccumulator::start(const unsigned char *,) basic/source/comp/codegen.cxx:479 @@ -214,6 +216,8 @@ canvas/inc/rendering/isurface.hxx:34 void canvas::ISurface::~ISurface() chart2/source/inc/WeakListenerAdapter.hxx:52 void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) +codemaker/source/cppumaker/cpputype.cxx:192 + void (anonymous namespace)::CppuType::dumpEmbindCppFile(class FileStream &,) extensions/source/dbpilots/unoautopilot.hxx:81 class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const extensions/source/propctrlr/commoncontrol.hxx:129 @@ -252,18 +256,14 @@ include/comphelper/interaction.hxx:53 void comphelper::OInteraction::select() include/comphelper/proparrhlp.hxx:83 class cppu::IPropertyArrayHelper * comphelper::OAggregationArrayUsageHelper::createArrayHelper()const -include/comphelper/propmultiplex2.hxx:54 - void comphelper::OPropertyChangeListener2::_disposing(const struct com::sun::star::lang::EventObject &,) -include/comphelper/propshlp.hxx:173 +include/comphelper/propshlp.hxx:172 class com::sun::star::uno::Any comphelper::OPropertySetHelper::getPropertyValueImpl(class std::unique_lock<class std::mutex> &,const class rtl::OUString &,) include/comphelper/solarmutex.hxx:59 _Bool comphelper::SolarMutex::tryToAcquire() include/comphelper/unique_disposing_ptr.hxx:170 void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,) -include/comphelper/weakeventlistener.hxx:121 +include/comphelper/weakeventlistener.hxx:120 void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) -include/sfx2/AccessibilityIssue.hxx:55 - void sfx::AccessibilityIssue::setParent(class weld::Window *,) include/svl/svdde.hxx:236 class DdeData * DdeTopic::Get(enum SotClipboardFormatId,) include/svl/svdde.hxx:237 @@ -276,13 +276,13 @@ include/svl/svdde.hxx:243 _Bool DdeTopic::StartAdviseLoop() include/svl/svdde.hxx:300 void DdeService::~DdeService() -include/svx/svdundo.hxx:752 +include/svx/svdundo.hxx:768 class std::unique_ptr<class SdrUndoAction> SdrUndoFactory::CreateUndoDiagramModelData(class SdrObject &,class std::shared_ptr<class svx::diagram::DiagramDataState> &,) -include/vbahelper/vbacollectionimpl.hxx:290 +include/vbahelper/vbacollectionimpl.hxx:289 int ScVbaCollectionBase::getCount() -include/vbahelper/vbacollectionimpl.hxx:295 +include/vbahelper/vbacollectionimpl.hxx:294 class com::sun::star::uno::Any ScVbaCollectionBase::Item(const class com::sun::star::uno::Any &,const class com::sun::star::uno::Any &,) -include/vbahelper/vbacollectionimpl.hxx:333 +include/vbahelper/vbacollectionimpl.hxx:332 unsigned char ScVbaCollectionBase::hasElements() include/vbahelper/vbahelperinterface.hxx:75 int InheritedHelperInterfaceImpl::getCreator() @@ -304,6 +304,8 @@ include/vcl/customweld.hxx:45 class rtl::OUString weld::CustomWidgetController::GetHelpText()const include/vcl/weld.hxx:109 void weld::Widget::set_visible(_Bool,) +sc/inc/patattr.hxx:126 + _Bool ScPatternAttr::operator==(const class ScPatternAttr &,)const sc/source/core/opencl/opbase.hxx:446 _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const sc/source/core/opencl/opbase.hxx:447 @@ -402,70 +404,198 @@ slideshow/source/inc/shape.hxx:221 void slideshow::internal::Shape::setIsForeground(const _Bool,) toolkit/inc/controls/geometrycontrolmodel.hxx:185 void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,)const -vcl/inc/font/LogicalFontInstance.hxx:126 +ux-gnu/../../../include/c++/13/bits/locale_facets.h:1092 + char std::ctype<char>::do_widen(char,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:1115 + const char * std::ctype<char>::do_widen(const char *,const char *,char *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:1142 + char std::ctype<char>::do_narrow(char,char,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:1168 + const char * std::ctype<char>::do_narrow(const char *,const char *,char,char *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:2220 + type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,_Bool &,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:2277 + type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,void *&,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:2535 + type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,_Bool,)const +ux-gnu/../../../include/c++/13/bits/locale_facets.h:2571 + type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,const void *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:636 + enum std::time_base::dateorder std::time_get::do_date_order()const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:654 + type-parameter-0-1 std::time_get::do_get_time(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:673 + type-parameter-0-1 std::time_get::do_get_date(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:692 + type-parameter-0-1 std::time_get::do_get_weekday(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:711 + type-parameter-0-1 std::time_get::do_get_monthname(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:730 + type-parameter-0-1 std::time_get::do_get_year(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:755 + type-parameter-0-1 std::time_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,char,char,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1613 + type-parameter-0-1 std::money_get::do_get(type-parameter-0-1,type-parameter-0-1,_Bool,class std::ios_base &,enum std::_Ios_Iostate &,long double &,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1625 + type-parameter-0-1 std::money_get::do_get(type-parameter-0-1,type-parameter-0-1,_Bool,class std::ios_base &,enum std::_Ios_Iostate &,basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > &,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1766 + type-parameter-0-1 std::money_put::do_put(type-parameter-0-1,_Bool,class std::ios_base &,type-parameter-0-0,long double,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1790 + type-parameter-0-1 std::money_put::do_put(type-parameter-0-1,_Bool,class std::ios_base &,type-parameter-0-0,const basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > &,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1975 + int std::messages::do_open(const class std::basic_string<char> &,const class std::locale &,)const +ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:2002 + void std::messages::do_close(int,)const +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:427 + void std::_Sp_counted_ptr::_M_dispose() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:431 + void std::_Sp_counted_ptr::_M_destroy() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:435 + void * std::_Sp_counted_ptr::_M_get_deleter(const class std::type_info &,) +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:526 + void std::_Sp_counted_deleter::_M_dispose() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:530 + void std::_Sp_counted_deleter::_M_destroy() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:538 + void * std::_Sp_counted_deleter::_M_get_deleter(const class std::type_info &,) +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:611 + void std::_Sp_counted_ptr_inplace::_M_dispose() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:618 + void std::_Sp_counted_ptr_inplace::_M_destroy() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:631 + void * std::_Sp_counted_ptr_inplace::_M_get_deleter(const class std::type_info &,) +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:695 + void std::_Sp_counted_ptr_inplace<type-parameter-0-0, type-parameter-0-1, _Lp>::_M_dispose() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:702 + void std::_Sp_counted_ptr_inplace<type-parameter-0-0, type-parameter-0-1, _Lp>::_M_destroy() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:845 + void std::_Sp_counted_array::_M_dispose() +ux-gnu/../../../include/c++/13/bits/shared_ptr_base.h:853 + void std::_Sp_counted_array::_M_destroy() +ux-gnu/../../../include/c++/13/cxxabi.h:307 + _Bool __cxxabiv1::__pbase_type_info::__pointer_catch(const class __cxxabiv1::__pbase_type_info *,void **,unsigned int,)const +ux-gnu/../../../include/c++/13/fstream:379 + long std::basic_filebuf::showmanyc() +ux-gnu/../../../include/c++/13/fstream:387 + typename type-parameter-0-1::int_type std::basic_filebuf::underflow() +ux-gnu/../../../include/c++/13/fstream:390 + typename type-parameter-0-1::int_type std::basic_filebuf::pbackfail(typename type-parameter-0-1::int_type,) +ux-gnu/../../../include/c++/13/fstream:400 + typename type-parameter-0-1::int_type std::basic_filebuf::overflow(typename type-parameter-0-1::int_type,) +ux-gnu/../../../include/c++/13/fstream:420 + basic_streambuf<type-parameter-0-0, type-parameter-0-1> * std::basic_filebuf::setbuf(type-parameter-0-0 *,long,) +ux-gnu/../../../include/c++/13/fstream:423 + typename type-parameter-0-1::pos_type std::basic_filebuf::seekoff(typename type-parameter-0-1::off_type,enum std::_Ios_Seekdir,enum std::_Ios_Openmode,) +ux-gnu/../../../include/c++/13/fstream:427 + typename type-parameter-0-1::pos_type std::basic_filebuf::seekpos(typename type-parameter-0-1::pos_type,enum std::_Ios_Openmode,) +ux-gnu/../../../include/c++/13/fstream:438 + int std::basic_filebuf::sync() +ux-gnu/../../../include/c++/13/fstream:441 + void std::basic_filebuf::imbue(const class std::locale &,) +ux-gnu/../../../include/c++/13/fstream:444 + long std::basic_filebuf::xsgetn(type-parameter-0-0 *,long,) +ux-gnu/../../../include/c++/13/fstream:447 + long std::basic_filebuf::xsputn(const type-parameter-0-0 *,long,) +ux-gnu/../../../include/c++/13/future:1488 + void std::__future_base::_Task_state<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2 (type-parameter-0-3...)>::_M_run(type-parameter-0-3 &&...,) +ux-gnu/../../../include/c++/13/future:1498 + void std::__future_base::_Task_state<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2 (type-parameter-0-3...)>::_M_run_delayed(type-parameter-0-3 &&...,class std::weak_ptr<class std::__future_base::_State_baseV2>,) +ux-gnu/../../../include/c++/13/future:1509 + shared_ptr<_Task_state_base<type-parameter-0-2 (type-parameter-0-3...)> > std::__future_base::_Task_state<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2 (type-parameter-0-3...)>::_M_reset() +ux-gnu/../../../include/c++/13/sstream:346 + long std::basic_stringbuf::showmanyc() +ux-gnu/../../../include/c++/13/sstream:358 + typename type-parameter-0-1::int_type std::basic_stringbuf::underflow() +ux-gnu/../../../include/c++/13/sstream:361 + typename type-parameter-0-1::int_type std::basic_stringbuf::pbackfail(typename type-parameter-0-1::int_type,) +ux-gnu/../../../include/c++/13/sstream:364 + typename type-parameter-0-1::int_type std::basic_stringbuf::overflow(typename type-parameter-0-1::int_type,) +ux-gnu/../../../include/c++/13/sstream:378 + basic_streambuf<type-parameter-0-0, type-parameter-0-1> * std::basic_stringbuf::setbuf(type-parameter-0-0 *,long,) +ux-gnu/../../../include/c++/13/sstream:397 + typename type-parameter-0-1::pos_type std::basic_stringbuf::seekoff(typename type-parameter-0-1::off_type,enum std::_Ios_Seekdir,enum std::_Ios_Openmode,) +ux-gnu/../../../include/c++/13/sstream:401 + typename type-parameter-0-1::pos_type std::basic_stringbuf::seekpos(typename type-parameter-0-1::pos_type,enum std::_Ios_Openmode,) +ux-gnu/../../../include/c++/13/streambuf:583 + void std::basic_streambuf::imbue(const class std::locale &,) +ux-gnu/../../../include/c++/13/streambuf:634 + int std::basic_streambuf::sync() +ux-gnu/../../../include/c++/13/streambuf:672 + long std::basic_streambuf::xsgetn(type-parameter-0-0 *,long,) +ux-gnu/../../../include/c++/13/streambuf:707 + typename type-parameter-0-1::int_type std::basic_streambuf::uflow() +ux-gnu/../../../include/c++/13/streambuf:749 + long std::basic_streambuf::xsputn(const type-parameter-0-0 *,long,) +ux-gnu/qt5/QtGui/qpaintdevice.h:74 + int QPaintDevice::devType()const +vcl/inc/font/LogicalFontInstance.hxx:123 void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,) -vcl/inc/jsdialog/jsdialogbuilder.hxx:165 +vcl/inc/jsdialog/jsdialogbuilder.hxx:161 void JSDialogSender::sendFullUpdate(_Bool,) +vcl/inc/jsdialog/jsdialogbuilder.hxx:164 + void JSDialogSender::sendAction(const class VclPtr<class vcl::Window> &,class std::unique_ptr<class std::unordered_map<class rtl::OString, class rtl::OUString> >,) +vcl/inc/jsdialog/jsdialogbuilder.hxx:166 + void JSDialogSender::sendPopup(const class VclPtr<class vcl::Window> &,const class rtl::OUString &,const class rtl::OUString &,) vcl/inc/jsdialog/jsdialogbuilder.hxx:168 - void JSDialogSender::sendAction(class VclPtr<class vcl::Window>,class std::unique_ptr<class std::unordered_map<class rtl::OString, class rtl::OUString> >,) -vcl/inc/jsdialog/jsdialogbuilder.hxx:170 - void JSDialogSender::sendPopup(class VclPtr<class vcl::Window>,class rtl::OUString,class rtl::OUString,) -vcl/inc/jsdialog/jsdialogbuilder.hxx:171 void JSDialogSender::sendClosePopup(unsigned int,) -vcl/inc/jsdialog/jsdialogbuilder.hxx:392 +vcl/inc/jsdialog/jsdialogbuilder.hxx:393 void JSWidget::show() -vcl/inc/jsdialog/jsdialogbuilder.hxx:405 +vcl/inc/jsdialog/jsdialogbuilder.hxx:406 void JSWidget::hide() -vcl/inc/jsdialog/jsdialogbuilder.hxx:419 +vcl/inc/jsdialog/jsdialogbuilder.hxx:420 void JSWidget::set_sensitive(_Bool,) -vcl/inc/jsdialog/jsdialogbuilder.hxx:427 +vcl/inc/jsdialog/jsdialogbuilder.hxx:428 class com::sun::star::uno::Reference<class com::sun::star::datatransfer::dnd::XDropTarget> JSWidget::get_drop_target() -vcl/inc/jsdialog/jsdialogbuilder.hxx:435 +vcl/inc/jsdialog/jsdialogbuilder.hxx:436 void JSWidget::freeze() -vcl/inc/jsdialog/jsdialogbuilder.hxx:441 +vcl/inc/jsdialog/jsdialogbuilder.hxx:442 void JSWidget::thaw() -vcl/inc/jsdialog/jsdialogbuilder.hxx:448 +vcl/inc/jsdialog/jsdialogbuilder.hxx:449 void JSWidget::grab_focus() -vcl/inc/jsdialog/jsdialogbuilder.hxx:492 +vcl/inc/jsdialog/jsdialogbuilder.hxx:494 void JSWidget::set_buildable_name(const class rtl::OUString &,) -vcl/inc/jsdialog/jsdialogbuilder.hxx:620 +vcl/inc/jsdialog/jsdialogbuilder.hxx:622 void JSComboBox::set_entry_text_without_notify(const class rtl::OUString &,) -vcl/inc/qt5/QtAccessibleWidget.hxx:165 - int QtAccessibleWidget::selectedItemCount()const -vcl/inc/qt5/QtAccessibleWidget.hxx:166 - class QList<class QAccessibleInterface *> QtAccessibleWidget::selectedItems()const +vcl/inc/qt5/QtFrame.hxx:160 + void QtFrame::registerDragSource(class QtDragSource *,) +vcl/inc/qt5/QtFrame.hxx:161 + void QtFrame::deregisterDragSource(const class QtDragSource *,) +vcl/inc/qt5/QtFrame.hxx:162 + void QtFrame::registerDropTarget(class QtDropTarget *,) +vcl/inc/qt5/QtFrame.hxx:163 + void QtFrame::deregisterDropTarget(const class QtDropTarget *,) vcl/inc/salframe.hxx:145 void SalFrame::SetRepresentedURL(const class rtl::OUString &,) vcl/inc/salframe.hxx:194 void SalFrame::Flush(const class tools::Rectangle &,) vcl/inc/salinst.hxx:95 _Bool SalInstance::SVMainHook(int *,) -vcl/inc/salinst.hxx:204 +vcl/inc/salinst.hxx:203 void SalInstance::releaseMainThread() -vcl/inc/salinst.hxx:213 +vcl/inc/salinst.hxx:212 void SalInstance::BeforeAbort(const class rtl::OUString &,_Bool,) vcl/inc/salobj.hxx:49 void SalObject::Enable(_Bool,) -vcl/inc/salprn.hxx:116 +vcl/inc/salprn.hxx:119 enum SalPrinterError SalPrinter::GetErrorCode() -vcl/inc/skia/gdiimpl.hxx:230 +vcl/inc/skia/gdiimpl.hxx:231 void SkiaSalGraphicsImpl::createSurface() -vcl/inc/skia/gdiimpl.hxx:240 +vcl/inc/skia/gdiimpl.hxx:241 void SkiaSalGraphicsImpl::flushSurfaceToWindowContext() -vcl/inc/skia/gdiimpl.hxx:263 +vcl/inc/skia/gdiimpl.hxx:264 int SkiaSalGraphicsImpl::getWindowScaling()const vcl/inc/unx/gtk/gtkdata.hxx:336 int GtkSalDisplay::CaptureMouse(class SalFrame *,) -vcl/inc/unx/saldata.hxx:50 +vcl/inc/unx/saldata.hxx:48 void X11SalData::Init() -vcl/inc/unx/saldisp.hxx:385 +vcl/inc/unx/saldisp.hxx:361 void SalX11Display::Yield() -vcl/inc/unx/salframe.h:211 +vcl/inc/unx/salframe.h:208 void X11SalFrame::updateGraphics(_Bool,) -vcl/inc/unx/salinst.h:41 +vcl/inc/unx/salinst.h:39 class SalX11Display * X11SalInstance::CreateDisplay()const -writerfilter/source/dmapper/TableManager.hxx:492 +writerfilter/source/dmapper/TableManager.hxx:490 void writerfilter::dmapper::TableManager::tableExceptionProps(const class tools::SvRef<class writerfilter::dmapper::TablePropertyMap> &,) -xmloff/source/forms/elementimport.hxx:549 +xmloff/source/forms/elementimport.hxx:548 class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySet> xmloff::OColumnImport::createElement() diff --git a/sc/inc/patattr.hxx b/sc/inc/patattr.hxx index ca2f75818a03..3c790c7637e3 100644 --- a/sc/inc/patattr.hxx +++ b/sc/inc/patattr.hxx @@ -125,7 +125,7 @@ public: ScPatternAttr(const ScPatternAttr& rPatternAttr); ~ScPatternAttr(); - virtual bool operator==(const ScPatternAttr& rCmp) const; + bool operator==(const ScPatternAttr& rCmp) const; // version that allows nullptrs static bool areSame(const ScPatternAttr* pItem1, const ScPatternAttr* pItem2); diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx b/vcl/inc/jsdialog/jsdialogbuilder.hxx index f0daa2a78323..e4fdd266851a 100644 --- a/vcl/inc/jsdialog/jsdialogbuilder.hxx +++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx @@ -161,10 +161,10 @@ public: virtual void sendFullUpdate(bool bForce = false); void sendClose(); void sendUpdate(VclPtr<vcl::Window> pWindow, bool bForce = false); - virtual void sendAction(const VclPtr<vcl::Window>& pWindow, - std::unique_ptr<jsdialog::ActionDataMap> pData); - virtual void sendPopup(const VclPtr<vcl::Window>& pWindow, const OUString& rParentId, - const OUString& rCloseId); + void sendAction(const VclPtr<vcl::Window>& pWindow, + std::unique_ptr<jsdialog::ActionDataMap> pData); + void sendPopup(const VclPtr<vcl::Window>& pWindow, const OUString& rParentId, + const OUString& rCloseId); virtual void sendClosePopup(vcl::LOKWindowId nWindowId); void flush() { mpIdleNotify->Invoke(); }