Re: floating point comparison plugin results

2016-01-26 Thread Eike Rathke
Hi Noel, On Thursday, 2016-01-21 14:47:47 +0200, Noel Grandin wrote: > This is the list of source locations where my new fpcomparison clang plugin > detects the use of == or != on floating > point values. Comparing ==0.0 or !=0.0 is fine, you can exclude those. Eike -- LibreOffice Calc

Re: floating point comparison plugin results

2016-01-25 Thread Armin Le Grand
Hi Noel, great work, great idea! Just one note: Will the plugin kept to be activated to warn in the future...? Am 21.01.2016 um 13:47 schrieb Noel Grandin: Hi (For further discussion) This is the list of source locations where my new fpcomparison clang plugin detects the use of == or !=

Re: floating point comparison plugin results

2016-01-25 Thread Noel Grandin
On 2016/01/25 12:18 PM, Armin Le Grand wrote: great work, great idea! Just one note: Will the plugin kept to be activated to warn in the future...? I'll have to think about that - there are quite a few places where it looks legal to use operator==, so I'd need quite an extensive whitelist

floating point comparison plugin results

2016-01-21 Thread Noel Grandin
Hi (For further discussion) This is the list of source locations where my new fpcomparison clang plugin detects the use of == or != on floating point values. Summary: only 252 source lines, which is less than I thought we'd have. Regards, Noel Grandin