Re: more visiting and less buffering in drawinglayer/

2021-12-06 Thread Armin Le Grand
Hi Lubos, On 12/4/21 2:15 PM, Luboš Luňák wrote: > On Friday 03 of December 2021, Armin Le Grand wrote: >> In this case it's - as you say - broken and thus an error. So please >> talk about it, report it > How likely would that achieve anything though? It's not like reporting a > problem

Re: more visiting and less buffering in drawinglayer/

2021-12-06 Thread Luboš Luňák
On Friday 03 of December 2021, Armin Le Grand wrote: > In this case it's - as you say - broken and thus an error. So please > talk about it, report it How likely would that achieve anything though? It's not like reporting a problem somehow magically fixes it. Even high-priority bugreports with

Re: more visiting and less buffering in drawinglayer/

2021-12-03 Thread Armin Le Grand
Hi, On 12/3/21 3:35 PM, Luboš Luňák wrote: > On Friday 03 of December 2021, Thorsten Behrens wrote: >> Luboš Luňák wrote: >>> I've implemented a cache in the Skia backend to handle cases of >>> drawinglayer being dumb and repeatedly asking to do expensive >>> redraws of the same stuff over and

Re: more visiting and less buffering in drawinglayer/

2021-12-03 Thread Armin Le Grand
Hi Noel, On 12/3/21 12:21 PM, Noel Grandin wrote: > Hi > > There will be a variety of drawinglayer related patches going through > as I work though some performance issues. > > So for drawinglayer code, we generally start with a hierarchy of > drawinglayer objects. > > Then we call that hierarchy

Re: more visiting and less buffering in drawinglayer/

2021-12-03 Thread Luboš Luňák
On Friday 03 of December 2021, Thorsten Behrens wrote: > Luboš Luňák wrote: > > I've implemented a cache in the Skia backend to handle cases of > > drawinglayer being dumb and repeatedly asking to do expensive > > redraws of the same stuff over and over again, which requires that > > the

Re: more visiting and less buffering in drawinglayer/

2021-12-03 Thread Thorsten Behrens
Luboš Luňák wrote: > I've implemented a cache in the Skia backend to handle cases of > drawinglayer being dumb and repeatedly asking to do expensive > redraws of the same stuff over and over again, which requires that > the underlying bitmap is the same object and not something created > from

Re: more visiting and less buffering in drawinglayer/

2021-12-03 Thread Noel Grandin
On Fri, 3 Dec 2021 at 15:06, Luboš Luňák wrote: > > In case that would involve removing buffering of bitmaps, please check > things No problem, not touching bitmaps at all, only the buffering of objects in the Primitive2D hierarchy.

Re: more visiting and less buffering in drawinglayer/

2021-12-03 Thread Luboš Luňák
On Friday 03 of December 2021, Noel Grandin wrote: > What I am doing is attempting to remove the intermediate creation of > drawinglayer objects (which is fairly expensive), and instead use a visitor > pattern (represented by the Primitive2DDecompositionVisitor abstract class) +1 > Along the

more visiting and less buffering in drawinglayer/

2021-12-03 Thread Noel Grandin
Hi There will be a variety of drawinglayer related patches going through as I work though some performance issues. So for drawinglayer code, we generally start with a hierarchy of drawinglayer objects. Then we call that hierarchy recursively, and it produces as output a list of more primitive