Re: need help with unit test and process service factory

2012-10-11 Thread Eike Rathke
Hi Michael, On Wednesday, 2012-10-10 20:59:54 +0100, Michael Meeks wrote: Do you mean g_main_context_iteration ? It's used both in the real code and unit test. It shouldn't be used in the real code - we should integrate with the glib mainloop that is plugged into VCL :-) AFAIK we

Re: need help with unit test and process service factory

2012-10-10 Thread Matúš Kukan
On 28 September 2012 11:26, Michael Meeks michael.me...@suse.com wrote: If we can create a unit test that doesn't require any of that, it'd be great of course. Having said that, I was not a great fan of the way those unit tests work in the 1st instance with that manual spin the loop n

Re: need help with unit test and process service factory

2012-10-10 Thread Matúš Kukan
On 28 September 2012 15:43, Michael Meeks michael.me...@suse.com wrote: IMHO it would be better to write unit tests to test the protocol fragments we get out of the calc core, and ensure that these continue to work nicely :-) run a stream of commands save document diff output etc.

Re: need help with unit test and process service factory

2012-10-10 Thread Michael Meeks
On Wed, 2012-10-10 at 21:15 +0200, Matúš Kukan wrote: On 28 September 2012 11:26, Michael Meeks michael.me...@suse.com wrote: If we can create a unit test that doesn't require any of that, it'd be great of course. Having said that, I was not a great fan of the way those unit

Re: need help with unit test and process service factory

2012-09-28 Thread Miklos Vajna
On Fri, Sep 28, 2012 at 01:44:28AM +0200, Matúš Kukan matus.ku...@gmail.com wrote: Ah, that's not true. It should be for building, but I forgot that for unit test we need empathy with two jabber accounts configured. Is that too much for tinderbox ? commit

Re: need help with unit test and process service factory

2012-09-28 Thread Michael Meeks
On Fri, 2012-09-28 at 01:44 +0200, Matúš Kukan wrote: On 28 September 2012 01:03, Matúš Kukan matus.ku...@gmail.com wrote: Also, it would be really great to have at least one linux tinderbox with --enable-telepathy. Only recent telepathy-glib is needed. Ah, that's not true. It should be

Re: need help with unit test and process service factory

2012-09-28 Thread Stephan Bergmann
On 09/28/2012 01:03 AM, Matúš Kukan wrote: I've tried --enable-telepathy again and found out that the unit test does not work now. After http://cgit.freedesktop.org/libreoffice/core/commit/?id=4917f0ceb2a7b1bb3ba878373f71f38d156278af I am getting: - Exception while getting config.ini url: null

Re: need help with unit test and process service factory

2012-09-28 Thread Michael Meeks
On Fri, 2012-09-28 at 09:35 +0200, Miklos Vajna wrote: commit 49cec3fa6f25cdf2f24602696b6a94570cbbfc2f added a libreoffice user profile for unit tests. Couldn't be a similar empathy profile added for the tubes test? And require empathy + telepathy of a certain version to be installed

need help with unit test and process service factory

2012-09-27 Thread Matúš Kukan
Hi, I've tried --enable-telepathy again and found out that the unit test does not work now. After http://cgit.freedesktop.org/libreoffice/core/commit/?id=4917f0ceb2a7b1bb3ba878373f71f38d156278af I am getting: - Exception while getting config.ini url: null process service factory It's from

Re: need help with unit test and process service factory

2012-09-27 Thread Matúš Kukan
On 28 September 2012 01:03, Matúš Kukan matus.ku...@gmail.com wrote: Also, it would be really great to have at least one linux tinderbox with --enable-telepathy. Only recent telepathy-glib is needed. Ah, that's not true. It should be for building, but I forgot that for unit test we need