On Sun, Apr 21, 2013 at 12:26:52PM +0100, Wols Lists wrote:
> On 20/04/13 22:42, Lionel Elie Mamane wrote:
>> Both of these methods allow to use git "natively" to apply the patch,
>> and (assuming your git is setup properly) to automatically get your
>> suggested commit message and the informatio
On 20/04/13 22:42, Lionel Elie Mamane wrote:
> Both of these methods allow to use git "natively" to apply the patch,
>> > and (assuming your git is setup properly) to automatically get your
>> > suggested commit message and the information of authorship recorded
>> > into git. For example, now I do
On Sat, Apr 20, 2013 at 12:50:05PM +0100, Wols Lists wrote:
> Okay, I'll sort out that patch and re-apply it for you. You should have
> a licence email on record - sent to the list 2012-05-18 "Wol's grant of
> licence".
It seems we had two entries for you in the developer's list. I merged
the two
Hi Lionel,
Okay, I'll sort out that patch and re-apply it for you. You should have
a licence email on record - sent to the list 2012-05-18 "Wol's grant of
licence".
I hope it was PGP signed ... :-)
Cheers,
Wol
On 19/04/13 17:26, Lionel Elie Mamane wrote:
> On Wed, Apr 17, 2013 at 09:39:59PM +01
On Wed, Apr 17, 2013 at 09:39:59PM +0100, Wols Lists wrote:
> I've now got the patch done.
> Could someone with a postgresql implementation please test and push?
Thank you for your patch. From looking at it, it looks good to go to
me, but technically I wasn't able to apply it and we have some
adm
I've now got the patch done.
Could someone with a postgresql implementation please test and push?
Cheers,
Wol
diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx b/connectivity/source/drivers/postgresql/pq_connection.cxx
index 4bc15e4..f0d9e03 100644
--- a/connectivity/source/dr
On Wed, Apr 17, 2013 at 08:28:21AM +0100, Wols Lists wrote:
> On 17/04/13 02:10, Lionel Elie Mamane wrote:
>> On Tue, Apr 16, 2013 at 09:24:03PM +0100, Wols Lists wrote:
>>> On 16/04/13 20:28, Lionel Elie Mamane wrote:
RTL_CONSTASCII_STRINGPARAM is a hack/optimisation specific to
compile
On 17/04/13 02:10, Lionel Elie Mamane wrote:
> On Tue, Apr 16, 2013 at 09:24:03PM +0100, Wols Lists wrote:
>> On 16/04/13 20:28, Lionel Elie Mamane wrote:
>>> On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
>
I can't get my argument casting right - in the original
code, match
On Tue, Apr 16, 2013 at 09:24:03PM +0100, Wols Lists wrote:
> On 16/04/13 20:28, Lionel Elie Mamane wrote:
>> On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
>>> I can't get my argument casting right - in the original
>>> code, matchIgnoreAsciiCaseAsciiL wraps its argument in
>>> RTL_C
Hi Wols,
On Tue, 2013-04-16 at 21:03 +0100, Wols Lists wrote:
> if( args[i].Name.matchIgnoreAsciiCase( OUString(
> keyword_list[j]), strlen( keyword_list[j] )))
> {
I guess that a different matchIgnoreAsciiCase call is happening and/or
the OUString constructor is c
On 16/04/13 20:28, Lionel Elie Mamane wrote:
> On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
>> The attached patch is not in logerrit (I've yet to set that up), and
>> there's an error in it so I'm hoping someone can help. It does a TODO in
>> the file, but I can't get my argument cas
On 16/04/13 19:25, Noel Grandin wrote:
> On Tue, Apr 16, 2013 at 6:36 PM, Wols Lists wrote:
>>
>> I need to force some type of type conversion - basically from "const
>> char *" to "const rtl::OUString&", I presume.
>
> You can either call
>matchIgnoreAsciiCase( OUString ( p ) )
> or
>mat
On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
> The attached patch is not in logerrit (I've yet to set that up), and
> there's an error in it so I'm hoping someone can help. It does a TODO in
> the file, but I can't get my argument casting right - in the original
> code, matchIgnoreAs
On Tue, Apr 16, 2013 at 6:36 PM, Wols Lists wrote:
>
> I need to force some type of type conversion - basically from "const
> char *" to "const rtl::OUString&", I presume.
You can either call
matchIgnoreAsciiCase( OUString ( p ) )
or
matchIgnoreAsciiCase( p, strlen(p) )
On 16/04/13 16:13, Lubos Lunak wrote:
> On Tuesday 16 of April 2013, Wols Lists wrote:
>> The attached patch is not in logerrit (I've yet to set that up), and
>> there's an error in it so I'm hoping someone can help. It does a TODO in
>> the file, but I can't get my argument casting right - in the
On 16/04/13 16:13, Lubos Lunak wrote:
> On Tuesday 16 of April 2013, Wols Lists wrote:
>> The attached patch is not in logerrit (I've yet to set that up), and
>> there's an error in it so I'm hoping someone can help. It does a TODO in
>> the file, but I can't get my argument casting right - in the
On Tuesday 16 of April 2013, Wols Lists wrote:
> The attached patch is not in logerrit (I've yet to set that up), and
> there's an error in it so I'm hoping someone can help. It does a TODO in
> the file, but I can't get my argument casting right - in the original
> code, matchIgnoreAsciiCaseAsciiL
The macro is there to calculate the size of the string at compile time,
which is normally a useful optimisation.
But given how you are changing the code, that optimisation is no longer
possible, at least not without pre-calculating it and storing it in
another array, which I don't think is war
On 16/04/13 15:38, Noel Grandin wrote:
> On 2013-04-16 16:16, Wols Lists wrote:
>> if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j] ))
>
> Surely this will work:
>
> if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j],
> strlen( keyword_list[j] )))
>
I'll have a play wit
On 2013-04-16 16:16, Wols Lists wrote:
if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j] ))
Surely this will work:
if( args[i].Name.matchIgnoreAsciiCaseAsciiL( keyword_list[j],
strlen( keyword_list[j] )))
??
Disclaimer: http://www.peralex.com/disclaimer.html
__
The attached patch is not in logerrit (I've yet to set that up), and
there's an error in it so I'm hoping someone can help. It does a TODO in
the file, but I can't get my argument casting right - in the original
code, matchIgnoreAsciiCaseAsciiL wraps its argument in
RTL_CONSTASCII_STRINGPARAM. This
21 matches
Mail list logo
