Re: using bool in rtl::OUStringBuffer::append

2012-10-04 Thread Noel Grandin
On 2012-10-03 22:03, Stephan Bergmann wrote: places. The commit seems to have caused some test failures and crashes. I reverted it for now. ...which only goes to show what a horrible mess C++ is in practice. bool is rather special, but you easily forget to consider all the consequences of

Re: using bool in rtl::OUStringBuffer::append

2012-10-04 Thread Stephan Bergmann
On 10/04/2012 07:49 AM, Noel Grandin wrote: On 2012-10-03 22:03, Stephan Bergmann wrote: places. The commit seems to have caused some test failures and crashes. I reverted it for now. ...which only goes to show what a horrible mess C++ is in practice. bool is rather special, but you easily

Re: using bool in rtl::OUStringBuffer::append

2012-10-04 Thread Lubos Lunak
On Thursday 04 of October 2012, Stephan Bergmann wrote: On 10/04/2012 07:49 AM, Noel Grandin wrote: On 2012-10-03 22:03, Stephan Bergmann wrote: places. The commit seems to have caused some test failures and crashes. I reverted it for now. ...which only goes to show what a horrible mess

Re: using bool in rtl::OUStringBuffer::append

2012-10-03 Thread Markus Mohrhard
Hey, after I got tinderbox mail complaining about ambiguous overload for rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a rtl::OUStringBuffer::append(bool) method or if there are reasons against it. From what I can see it could in the end even share the implementation

Re: using bool in rtl::OUStringBuffer::append

2012-10-03 Thread Stephan Bergmann
On 10/03/2012 07:00 PM, Markus Mohrhard wrote: after I got tinderbox mail complaining about ambiguous overload for rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a rtl::OUStringBuffer::append(bool) method or if there are reasons against it. From what I can see it could in the

Re: using bool in rtl::OUStringBuffer::append

2012-09-24 Thread Stephan Bergmann
On 09/23/2012 10:49 PM, Markus Mohrhard wrote: after I got tinderbox mail complaining about ambiguous overload for rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a rtl::OUStringBuffer::append(bool) method or if there are reasons against it. From what I can see it could in the

Re: using bool in rtl::OUStringBuffer::append

2012-09-24 Thread Michael Stahl
On 23/09/12 22:49, Markus Mohrhard wrote: Hey, after I got tinderbox mail complaining about ambiguous overload for rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a rtl::OUStringBuffer::append(bool) method or if there are reasons against it. From what I can see it could in

using bool in rtl::OUStringBuffer::append

2012-09-23 Thread Markus Mohrhard
Hey, after I got tinderbox mail complaining about ambiguous overload for rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a rtl::OUStringBuffer::append(bool) method or if there are reasons against it. From what I can see it could in the end even share the implementation with the