Re: xub_StrLen and = 64k paragraphs

2013-12-02 Thread Caolán McNamara
On Thu, 2013-11-28 at 23:03 +0100, Eike Rathke wrote: I'd rather like to see a value (SAL_MAX_INT32-1) as replacement and name it SAL_MAX_STRING FWIW, writer has a TXTNODE_MAX which is currently STRING_LEN - 2; C. ___ LibreOffice mailing list

xub_StrLen and = 64k paragraphs

2013-11-28 Thread Caolán McNamara
So now UniString is gone we have the chance to make use of OUString for = 64k paragraphs (#i17171#) but we basically have to decide what to do with places that currently return STRING_LEN/STRING_MAXLEN in xub_Strlen (unsigned short). Do we want to return -1 or SAL_MAX_INT32 as the replacement. -1

Re: xub_StrLen and = 64k paragraphs

2013-11-28 Thread Matteo Casalin
On Thu, 28 Nov 2013 16:02:06 + Caolán McNamara caol...@redhat.com wrote: So now UniString is gone we have the chance to make use of OUString for = 64k paragraphs (#i17171#) but we basically have to decide what to do with places that currently return STRING_LEN/STRING_MAXLEN in xub_Strlen

Re: xub_StrLen and = 64k paragraphs

2013-11-28 Thread Eike Rathke
Hi Caolán, On Thursday, 2013-11-28 16:02:06 +, Caolán McNamara wrote: Do we want to return -1 or SAL_MAX_INT32 as the replacement. -1 is nice but there is so much code in existence that expects the error/boundary condition return value to be any valid number that I reckon SAL_MAX_INT32