Re: [Libreoffice] [PATCH] CppCheck cleanliness in bootstrap

2011-01-05 Thread David Tardon
On Tue, Jan 04, 2011 at 10:41:26PM +0100, Guillaume Poussel wrote: Hi everybody, I've started to look at the huge listhttp://libreoffice.boldandbusted.com/of defects that Cpp Check show. I have corrected few things in bootstrap. The rest should be false positive or errors in dmake/ folder.

Re: [Libreoffice] [PATCH] [PUSHED] CppCheck cleanliness in bootstrap

2011-01-05 Thread David Tardon
On Wed, Jan 05, 2011 at 09:10:51AM +0100, David Tardon wrote: On Tue, Jan 04, 2011 at 10:41:26PM +0100, Guillaume Poussel wrote: Hi everybody, I've started to look at the huge listhttp://libreoffice.boldandbusted.com/of defects that Cpp Check show. I have corrected few things in

Re: [Libreoffice] [UX] Formula cursor proposals

2011-01-05 Thread Wols Lists
On 04/01/11 23:43, Christoph Noack wrote: The main issue is, that we do have two different input methods (one being WYSIWYG, the other one being the formula syntax) that have to be synced somehow. The content itself isn't the main problem, but things like cursor position and selection. We can

Re: [Libreoffice] Test script patch review request (1)

2011-01-05 Thread Tor Lillqvist
Would you also like to comment my updated method sent yesterday? Thanks! Well, it was not clear to me why you want to expand only initial tabs. Presumably when somebody uses tab characters in a source file, they intend them to tab to the next multiple of four columns regardless where on the

Re: [Libreoffice] [Linux] LibORC2: Impress video / `GLIBCXX_3.4.11' not found

2011-01-05 Thread Jan Holesovsky
Hi, NoOp píše v Út 04. 01. 2011 v 20:42 -0800: Can LibORC3 include an updated libstdc++.so.6 so that others do not have the same issue? Thanks. No response on the list. Would it help if I filed a bug report, or are LibO devs already aware of the issue? IMO this would be a blocking

Re: [Libreoffice] [REVIEW] unopkg --suppress-license

2011-01-05 Thread Cedric Bosdonnat
Hello Kohei, others, I have created a bug report for this (fdo#32840)... and fixed it in master branch. Could someone review it for a possible integration in 3.3 ? Regards, -- Cedric On Tue, 2011-01-04 at 16:09 -0500, Kohei Yoshida wrote: On Tue, 2011-01-04 at 22:04 +0100, Cedric Bosdonnat

Re: [Libreoffice] [Linux] LibORC2: Impress video / `GLIBCXX_3.4.11' not found

2011-01-05 Thread Michael Meeks
Hi there, On Fri, 2010-12-31 at 11:23 -0800, NoOp wrote: (soffice:22820): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstffmpeg.so': /opt/libreoffice/program/../basis-link/ure-link/lib/libstdc++.so.6: Gack; another instance of our internal libstdc++ biting

Re: [Libreoffice] Sign-off request

2011-01-05 Thread Michael Meeks
Hi Kohei, On Tue, 2011-01-04 at 16:06 -0500, Kohei Yoshida wrote: Could someone please give me a quick sign-off of this Done - looks great :-) Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot

[Libreoffice] [PUSHED] Re: [PATCH] Removed dependencies on tools/solar.h in waitoff.h

2011-01-05 Thread Jan Holesovsky
Hi Soeren, Soeren Moeller píše v Út 04. 01. 2011 v 19:48 +0100: Another small removal of dependencies on tools/solar.h, this time in sc/inc/waitoff.h Pushed, thank you! :-) Regards, Kendy ___ LibreOffice mailing list

Re: [Libreoffice] Change executable/sh names

2011-01-05 Thread Jesús Corrius
On Wed, Jan 5, 2011 at 5:38 AM, NoOp gl...@sbcglobal.net wrote: On 12/24/2010 03:26 PM, NoOp wrote: On 12/24/2010 11:32 AM, Jesús Corrius wrote: ... I see, I was able to reproduce it after making a few tests. Let me investigate this further. Scenarios that work (for me)

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST( EditList, AppWIn*)

2011-01-05 Thread Noel Power
Hi Joseph On -10/01/37 20:59, Joseph Powers wrote: The attached patch compiles and stands up to my limited testing; however, it's a large patch and touches a lot of sensitive code so I want someone with better knowledge of the Basic Macro Editor environment to review test it before I try

Re: [Libreoffice] [PATCH] new cppcheck cleaning in svx

2011-01-05 Thread Radek Doulik
Hi Julien, thanks for your patches. They look OK so I pushed them. Cheers Radek On Thu, 2010-12-30 at 00:51 +0100, Julien Nabet wrote: Hello, Here are 2 new patches for cppcheck cleaning in svx Compiling was ok Remarks : I had this with the last git version of cppcheck : 1)

Re: [Libreoffice] Formula cursor : bug or feature ?

2011-01-05 Thread Michael Meeks
Hi Jean, On Wed, 2010-12-29 at 21:11 +0100, Jean-Baptiste Faure wrote: Jonas wrote: Assuming someone cares to implement it... and you're are welcome to step up to the plate :) .. I strongly disagree : it is you who must not to destroy what is working very well. Jean - this sort of

Re: [Libreoffice] [Patch] Make SVG filter export text color

2011-01-05 Thread Michael Meeks
Hi Takeshi, On Tue, 2011-01-04 at 14:30 +0900, KUROSAWA, Takeshi wrote: I wrote patches for SVG export filter. Nice ! :-) thes look great. Having said that - I suggest we wait for Thorsten to review them (who gets back from holiday tommorrow). Is that ok ? Really great

[Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

2011-01-05 Thread Khaled Hosny
Hi every one, This my first message to the list, hopping it will be a fruitful experience :) I was trying to debug fdo#31016[1] since it breaks almost all my fonts, it toke me few months but I think I finally got the root of it (I started working on it few weeks before libreoffice was announced,

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Michael Meeks
Hi Robert, On Mon, 2011-01-03 at 02:16 +0100, Christian Lohmaier wrote: - aStyleSet.SetToolbarIconSize( STYLE_TOOLBAR_ICONSIZE_LARGE ); +aStyleSet.SetToolbarIconSize( nDispDPIY 160 ? STYLE_TOOLBAR_ICONSIZE_LARGE : STYLE_TOOLBAR_ICONSIZE_SMALL ); On large

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Robert Nagy
On (2011-01-05 14:27), Michael Meeks wrote: So - I would prefer to stick with large icons; and not use the DPI setting. I suggest instead, that we only use large icons if the true Y resolution 768 - how does that sound ? ATB, Michael. That would work fine too, I

Re: [Libreoffice] visual formula editor makes unwanted changes to command line

2011-01-05 Thread Michael Meeks
On Sun, 2011-01-02 at 21:12 +0100, Jonas Finnemann Jensen wrote: I have installed RC2 now, but I see no difference in formula editor. I don't think everything from master is merged into the release candidate... And since this is still an experimental feature we're slow at pushed things

[Libreoffice] [PUSHED] Re: [PATCH] Removed dependencies on tools/solar.h in drawpage.hxx/.cxx

2011-01-05 Thread Jan Holesovsky
Hi Soeren, Sören Möller píše v Út 04. 01. 2011 v 20:20 +0100: Replaced datatypes from tools/solar.h with corresponding types from sal/types.h in drawpage.hxx/.cxx and added missing include of sal/types.h in docparam.hxx Pushed, thank you! :-) I've just changed one thing, and that is that

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Kálmán „KAMI” Szalai
Hi Meeks, Robert, 2011-01-05 15:27 keltezéssel, Michael Meeks írta: Hi Robert, On large numbers of machines, nDispDPI is just broken - it is fetched (AFAIR) from Xft - and is ~hard-coded to 75 everywhere to save lots of grief from X servers getting it horribly wrong. So - the

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h in drawpage.hxx/.cxx

2011-01-05 Thread Kohei Yoshida
Hi Sören, Thanks for the patch. Is there a reason why this one is not an attachment? :-) Anyway, I have some comments. On Tue, 2011-01-04 at 20:20 +0100, Sören Möller wrote: Replaced datatypes from tools/solar.h with corresponding types from sal/types.h in drawpage.hxx/.cxx and added

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Robert Nagy
On (2011-01-05 14:27), Michael Meeks wrote: So - I would prefer to stick with large icons; and not use the DPI setting. I suggest instead, that we only use large icons if the true Y resolution 768 - how does that sound ? Oh wait, I misunderstood. That is wrong. I am on a 1920x1080

Re: [Libreoffice] [PATCH] De-Java-ise flat XML export

2011-01-05 Thread Jan Holesovsky
Hi Peter, Jan Holesovsky píše v Út 04. 01. 2011 v 11:13 +0100: I'm attaching a patch I somehow managed to patiently pull out of git :-) As I'm new to C++, libxslt, git and a few other things involved in creating the patch I feel it must be full of warts and cause random crashes, but

Re: [Libreoffice] BrOffice RC2

2011-01-05 Thread Andras Timar
Hi Michael, 2011/1/5 Michael Meeks michael.me...@novell.com No problem; there is one known branding bug inside the MSI, that we need to work around before release. Have you also solved https://bugs.freedesktop.org/show_bug.cgi?id=32389 (MSI installer is always in English regardless

[Libreoffice] Updating to latest git source code

2011-01-05 Thread Grega Fajdiga
Hi, Could somebody tell me how to update to the latest git release? There used to be a bin/g scvript that did that but it's gone. Thanks, -- Grega Fajdiga Hacquetova 5 1113 Ljubljana Slovenia GSM: +386 40 923 635 E-pošta: gregor.fajd...@guest.arnes.si

Re: [Libreoffice] [PATCH] [PUSHED] Translated comments from German to English

2011-01-05 Thread Kohei Yoshida
On Tue, 2011-01-04 at 22:26 +0100, Christina Roßmanith wrote: ...some more translations. Nice work! Pushed. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] Updates for Lightproof

2011-01-05 Thread Michael Meeks
Hi Kami, On Wed, 2010-12-22 at 18:28 +0100, Kálmán „KAMI” Szalai wrote: Please review the attached patch that provide updated support for Ligthproof extension integration for 3.3.x series. Looks lovely :-) but can we punt this for 3.3.1 ? I think we need to be getting into some really

Re: [Libreoffice] Oracle wordbook in LibO

2011-01-05 Thread Petr Mladek
Kálmán „KAMI” Szalai píše v Pá 31. 12. 2010 v 10:17 +0100: Hi All, Patches attached to issue, please review. Ah, we use Novell.dic in our build. It includes just language-independent names of Novell products, so it should not cause any harm to anyone. I attached different patches to the

Re: [Libreoffice] [PATCH] Fix-font-assignation-of-extra-fonts

2011-01-05 Thread Michael Meeks
Hi Kami, On Wed, 2010-12-22 at 18:22 +0100, Kálmán „KAMI” Szalai wrote: Sorry, my mistake. Attached. You sure these need review ? :-) your work looks nice - and no doubt it can be tweaked later if there are problems ? :-) /me feels bad about leaving this un-reviewed so long.

Re: [Libreoffice] Updating to latest git source code

2011-01-05 Thread Jonathan Aquilina
type ./g pull -r in the boot strap directory let me know if it works. On 1/5/11 2:40 PM, Grega Fajdiga wrote: Hi, Could somebody tell me how to update to the latest git release? There used to be a bin/g scvript that did that but it's gone. Thanks,

[Libreoffice] [Pushed] Refreshing some OxygenOffice related patches

2011-01-05 Thread Michael Meeks
Hi Kami, On Thu, 2010-12-30 at 08:17 +0100, Kálmán „KAMI” Szalai wrote: I attaching two patch that: * refreshing some OxygenOffice related patches * disable few OxygenOffice only patches from apply file Look fine to me for libreoffice-3-3; they only touch Oxygen pieces, pushed them

Re: [Libreoffice] Oracle wordbook in LibO

2011-01-05 Thread Kálmán „KAMI” Szalai
Hi! 2011-01-05 17:01 keltezéssel, Petr Mladek írta: Ah, we use Novell.dic in our build. It includes just language-independent names of Novell products, so it should not cause any harm to anyone. I attached different patches to the issue. KAMI, could you please review them? Can we introduce

[Libreoffice] 13th and 14th week development summary

2011-01-05 Thread Petr Mladek
Hi, this time a brief summary of what happened the 13th and 14th week on LibreOffice repos and two living branches: bugfixes-master-week-51-52.txt lists all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop,

Re: [Libreoffice] [PATCH] Fix-font-assignation-of-extra-fonts

2011-01-05 Thread Jan Holesovsky
Hi Kami, Kálmán „KAMI” Szalai píše v St 05. 01. 2011 v 17:41 +0100: PS. we have all those font's licenses in the license files right ? Sorry I really don't know the rules for this so I just wanted to review all changes that I made after I got warned ;o) I am sorry, that is probably my

Re: [Libreoffice] Oracle wordbook in LibO

2011-01-05 Thread Petr Mladek
Kálmán „KAMI” Szalai píše v St 05. 01. 2011 v 17:39 +0100: Hi! 2011-01-05 17:01 keltezéssel, Petr Mladek írta: Ah, we use Novell.dic in our build. It includes just language-independent names of Novell products, so it should not cause any harm to anyone. I attached different patches to

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Robert Nagy
Oh well then Linux is broken, again. :) In gedit the icons are bigger than the small ones but not as huge as in LibreOffice. Here you can see (LO with small icons): http://blade2k.humppa.hu/2011-01-05-182917_1920x1080_scrot.png (ws robert 22435)$ xdpyinfo | egrep (dimensions|dots per inch)

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Robert Nagy
It seems to me that gedit uses GTK_ICON_SIZE_MENU which is 16x16. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Christian Lohmaier
Hi Robert, *, On Wed, Jan 5, 2011 at 6:36 PM, Robert Nagy rob...@openbsd.org wrote: It seems to me that gedit uses GTK_ICON_SIZE_MENU which is 16x16. On GNOME it follows the theme, wich in turn follows the gconf-setting /desktop/gnome/interface/toolbar_icons_size so whatever your theme defines

[Libreoffice] [PUSHED] Re: [PUSHED] Re: [PATCH] typo fix in helppacks.ulf

2011-01-05 Thread Jan Holesovsky
Hi Andras, Andras Timar píše v Ne 02. 01. 2011 v 14:47 +0100: same typo in module_langpack.ulf Thank you, pushed to libreoffice-3-3. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Robert Nagy
Hi We should just ignore all the theming here since a lot of people are not running gnome or whatever window manager and just use stock gtk. On (2011-01-05 18:59), Christian Lohmaier wrote: Hi Robert, *, On Wed, Jan 5, 2011 at 6:36 PM, Robert Nagy rob...@openbsd.org wrote: It seems to me

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Christian Lohmaier
Hi Robert, *, On Wed, Jan 5, 2011 at 7:02 PM, Robert Nagy rob...@openbsd.org wrote: We should just ignore all the theming here No way - as gtk is always themed. Your screenshot demonstrate that your gedit is not using 16x16 for icons. So either you're not using small-toolbar setting at all,

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Robert Nagy
Hi I am *not* using any themes, it's the default GTK one. Anyways that does not matter now. On (2011-01-05 19:15), Christian Lohmaier wrote: Hi Robert, *, On Wed, Jan 5, 2011 at 7:02 PM, Robert Nagy rob...@openbsd.org wrote: We should just ignore all the theming here No way - as gtk

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Christoph Noack
Hi Robert, all! Am Mittwoch, den 05.01.2011, 18:32 +0100 schrieb Robert Nagy: Oh well then Linux is broken, again. :) In gedit the icons are bigger than the small ones but not as huge as in LibreOffice. Here you can see (LO with small icons):

Re: [Libreoffice] [Linux] LibORC2: Impress video / `GLIBCXX_3.4.11' not found

2011-01-05 Thread NoOp
On 01/05/2011 02:06 AM, Michael Meeks wrote: Hi there, On Fri, 2010-12-31 at 11:23 -0800, NoOp wrote: (soffice:22820): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstffmpeg.so': /opt/libreoffice/program/../basis-link/ure-link/lib/libstdc++.so.6: Gack;

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Phil Turmel
On 01/05/2011 12:14 PM, Michael Meeks wrote: Hi Robert, On Wed, 2011-01-05 at 16:24 +0100, Robert Nagy wrote: On (2011-01-05 14:27), Michael Meeks wrote: So - I would prefer to stick with large icons; and not use the DPI setting. I suggest instead, that we only use large icons if the

Re: [Libreoffice] Change executable/sh names

2011-01-05 Thread NoOp
On 01/05/2011 02:55 AM, Jesús Corrius wrote: On Wed, Jan 5, 2011 at 5:38 AM, NoOp gl...@sbcglobal.net wrote: ... Any progress on this? Would it help if I filed a bug report? This issue is (to me) critical regarding any further RC or full release of LibO. Sorry, I have been in Norway for

[Libreoffice] [PATCH] Fix passing distro specific branding via configure

2011-01-05 Thread Petr Mladek
Hi, the configure options --with-intro-bitmaps, --with-about-bitmaps did not longer worked. I think that nobody needs more pictures. The attached patches rename the above options to pass only one picture and fix the stuff to work. KAMI, could you sign it off for libreoffice-3-3 branch? Best

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h in drawpage.hxx/.cxx

2011-01-05 Thread Soeren Moeller
Hi and thank you for your comments 2011/1/5 Kohei Yoshida kyosh...@novell.com: Hi Sören, Thanks for the patch.  Is there a reason why this one is not an attachment? :-) It is not an attachment as I used git send-email to send it to the mailing list, but the result seems a bit wierd when

[Libreoffice] [PATCH] set RPATH correctly in the internal ICU

2011-01-05 Thread Petr Mladek
Hi, our build service found broken RPATH in libicudata.so.42.1; it is fixed by the attached patch Cedric, could you please sign it off for libreoffice-3-3. It works well on Linux with bash. I think that it can't be worse on other systems ;-) Best Regards, Petr From

Re: [Libreoffice] [PATCH] Updates for Lightproof

2011-01-05 Thread Kálmán „KAMI” Szalai
Title: Szalai Kálmán Hi Michael, Sorry for bugging you but it seems I sent it two times, and David already pushed in: Re: [Libreoffice] [PATCH] [PUSHED] Updates for LightProof extension handling It is required If someone packs LightProof because of changed

Re: [Libreoffice] [PATCH] set RPATH correctly in the internal ICU

2011-01-05 Thread Caolán McNamara
On Wed, 2011-01-05 at 20:22 +0100, Petr Mladek wrote: Hi, our build service found broken RPATH in libicudata.so.42.1 That libicudata is the biggest nuisance, causes all sorts of problems on different platforms. Rather an odd use of an elf file as data storage IIRC and manually created by icu

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 32133, which changed state. Bug 32133 Summary: Overlapping controls on Tools - Options - General panel https://bugs.freedesktop.org/show_bug.cgi?id=32133 What|Old Value |New Value

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-05 Thread Joost Eekhoorn
Michael, Sorry that I used the background color directly. I just do not known jet how to use themes. Is there a theme for displaying a warning label in a dialog? The color of the warning was inspired by the spec:

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Christoph Noack
Hi Christian! Am Mittwoch, den 05.01.2011, 19:40 +0100 schrieb Christian Lohmaier: Hi Christoph, *, On Wed, Jan 5, 2011 at 7:18 PM, Christoph Noack christ...@dogmatux.com wrote: [...] Mmh, I'm unsure how much it helps to compare the different applications. * gedit is a native

Re: [Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

2011-01-05 Thread Christian Lohmaier
Hi Christoph, *; On Wed, Jan 5, 2011 at 10:51 PM, Christoph Noack christ...@dogmatux.com wrote: [...] Thus, we have to take care that our default settings work well for the majority of users working in very different working conditions. [...] Yes, and that surely is the setting they use for

Re: [Libreoffice] Symbolic regression for curvefitting.

2011-01-05 Thread Fabian Deutsch
Hi Kohei, Am Mittwoch, den 05.01.2011, 13:02 -0500 schrieb Kohei Yoshida: On Sun, 2011-01-02 at 21:12 +0100, Fabian Deutsch wrote: Thoughts? I think this is a pretty interesting project worth consideration. One thing I noticed; you've chosen Vala as the language for this library. Is

Re: [Libreoffice] Test script patch review request (1)

2011-01-05 Thread Yifan Jiang
Ah...got more reading. `expand` is smarter than I have thought ( I misunderstood it as only fixed space characters can be provided to replace tabs), so to keep the source file looks the same as it used to be. This should be enough to: $ cat /tmp/tabfile | while read fn ; do expand $fn