[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 39026, which changed state. Bug 39026 Summary: Recent Documents list does not work https://bugs.freedesktop.org/show_bug.cgi?id=39026 What|Old Value |New Value ---

License statement

2012-02-16 Thread Dézsi Szabolcs
Hi, I confirm that all my past, present and future contributions to the LibreOffice project are licensed under the MPL / LGPLv3+. Regards Szabolcs Dezsi. ___ LibreOffice mailing list LibreOffice@lists.freed

[PATCH] Removed unused code from filter module MSFilterTracer class

2012-02-16 Thread Dézsi Szabolcs
Hi! This is my first patch, I hope everything's correct. Removed functions: MSFilterTracer::SetProperty(rtl::OUString const&, com::sun::star::uno::Any const&) MSFilterTracer::StartElement(rtl::OUString const&, com::sun::star::uno::Reference) Files modified: filter/inc/filter/msfilter/msfiltert

Re: Hosting LibreOffice online

2012-02-16 Thread Michael Meeks
Hi Drew, On Thu, 2012-02-16 at 00:50 -0500, drew wrote: > Well, after adding --enable-gtk3 it works. Nice :-) > WebSocket support was (is) an issue. > - Win7 and Vista with ie9: Fail > - HP Mini 110, Mi (Linux) w/ FireFox [latest updates applied]: Fail Oh - that is odd. I guess

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Timur changed: What|Removed |Added Depends on||44127 --- Comment #187 from Timur 2012-02-16 02

[PATCH] Removed unused code from MSFilterTracer

2012-02-16 Thread Dézsi Szabolcs
Hi! sry didn't attach file :$ This is my first patch, I hope everything's correct. Removed functions: (used unusedcode.easy) MSFilterTracer::SetProperty(rtl::OUString const&, com::sun::star::uno::Any const&) MSFilterTracer::StartElement(rtl::OUString const&, com::sun::star::uno::Reference) Fil

[PUSHED] Re: [REVIEW-3-5] Fix for crash in smartart import

2012-02-16 Thread Jan Holesovsky
Hi Muthu, Muthu Subramanian K píše v Čt 16. 02. 2012 v 15:58 +0530: > +1 > should we also push it to 3.5.x branches as well? Thanks for push, marking it [PUSHED]. No need to push to any other branch, libreoffice-3-5-1 is not created yet, and for -3-5-0 it is too late ;-) Thank you, Kendy

Re: [REVIEW-3-5] Fix for crash in smartart import

2012-02-16 Thread Muthu Subramanian K
+1 should we also push it to 3.5.x branches as well? On 02/16/2012 03:16 PM, Thorsten Behrens wrote: > Hi there, > > could someone please review > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=905df1bae9cab296ee7dd07e88813c667788ed8a > > and cherry-pick to -3-5? A very obvious g

[REVIEW-3-5] Fix for crash in smartart import

2012-02-16 Thread Thorsten Behrens
Hi there, could someone please review http://cgit.freedesktop.org/libreoffice/core/commit/?id=905df1bae9cab296ee7dd07e88813c667788ed8a and cherry-pick to -3-5? A very obvious getting-ahead-of-myself problem when accessing an iterator. ;) Thanks, -- Thorsten pgpbVNxgKDF88.pgp Description: P

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

2012-02-16 Thread Stephan Bergmann
On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote: Otherwise you can simplify it even more: sal_Bool bLeft = (meAlign == WINDOWALIGN_TOP || meAlign == WINDOWALIGN_LEFT) ? sal_False : sal_True; ... which of course reduces to bool bLeft = !(meAlign == WINDOWALIGN_TOP || meAlign == WINDOWALI

Re: [PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

2012-02-16 Thread Riccardo Magliocchetti
Il 16/02/2012 00:02, Mariusz Dykierek ha scritto: + some simplification > +sal_Bool bLeft = sal_True; > +if ( ( meAlign == WINDOWALIGN_TOP ) || ( meAlign == > WINDOWALIGN_LEFT ) ) > +bLeft = sal_False; I think that keeping possible values explicit could be a good thi

<    1   2