[Libreoffice-bugs] [Bug 104207] An easier way to backup custom toolbar presets
https://bugs.documentfoundation.org/show_bug.cgi?id=104207 tommy27changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #3 from tommy27 --- the reported told me in a private may that he resolved the issue thanks to the link I provided before -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104271] New: New comment box should automatically re-position and re-size appropriately based on the shape of text pasted into it
https://bugs.documentfoundation.org/show_bug.cgi?id=104271 Bug ID: 104271 Summary: New comment box should automatically re-position and re-size appropriately based on the shape of text pasted into it Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lopeonl...@gmail.com Description: Creating comments in Libre Office Calc is very tedious and inconvenient. After implementing this very simple algorithm it will be a pleasure to add new comments to a calc worksheet :) Steps to Reproduce: 1. Right click a cell in Calc and click "Add comment" 2. Add a comment to a cell that is on the right of the workspace. 3. Create a new comment and paste in some text. 4. Try paste some text into a new comment and then position it or resize it. 5. Try drag a new comment to a new position. Actual Results: 1. It opens a new comment box, positioned 3 cells above and 1 cell to the right of the cell. This is a very bad default position for a new comment, because: 2. It scrolls the whole calc workspace to the right unnecessarily, so you can't see the left column anymore, so you have to manually scroll left after adding the comment. 3. The comment box's position and width are not set appropriately. 4. It also does not allow you to immediately resize the comment box. You have to first click outside the comment box, then the new comment is hidden, then you have to right click the cell and show the comment. Then you have to click the comment once, ONLY then can you resize it. 5. The first time you drag a newly created comment box away from it's original position, it moves a little bit, then disappears and resumes it's original position. The 2nd time you drag it, it is dragged properly. Expected Results: The default position of the comment box should be that the left edge of the comment box is aligned with the left of the cell being commented on, and the top edge of the comment box should be aligned with the bottom of the cell being commented on. The above is just to correct the very inconvenient default position. But here comes the really useful/innovative part that will make calc a pleasure to add comments :) In a Nutshell: When text is pasted into the new comment box, the box should expand as necessary to accommodate the pasted text, up to a maximum width equal to the workspace in calc window; after setting the width, the height should be set to accommodate the entire comment text. #1. The top of the comment box should be aligned with the bottom of the cell being commented on. CALCULATING IDEAL COMMENT BOX WIDTH #2. The ideal width and height of the comment box should be calculated according to the following simple rules. First the algorithm must determine the longest line in the pasted text. That is the ideal width of the comment box, HOWEVER if it is wider than the viewable area then the comment box's ideal width must be reduced so that it fits into the calc window's workspace's width. Lines longer than the ideal width will be wrapped. 2.1 An option should be added for the user to specify the maximum calculated width for a comment box. Personally I won't limit the width. I paste a lot of code snippets, and I'm quite happy with comment boxes that take up the width of my workspace when necessary. But other people who are not programmers may likely paste mostly long paragraphs that don't have much line breaks, that can be arbitrarily wrapped at any length. They may prefer to limit their automatic comment box width. #3. If the calculated ideal width of the comment box can fit horizontally from the left edge of the cell being commented on, to the right edge of the workspace (at the current scroll position), then the left edge of the comment box should be aligned with the left of the cell being commented on, and the comment box should have the calculated ideal width as described above. #4. If the calculated ideal width exceeds what can fit in #3 then the comment box should be set to it's ideal width (#1) and the right edge of the comment box should be aligned with the right edge of the calc window's workspace. CALCULATING IDEAL COMMENT BOX HEIGHT The ideal comment box height must fit the number of lines in the pasted text, taking into consideration word-wrapping (if it occurs), given the comment box's (ideal calculated) width. The workspace's vertical scrolling position must be scrolled down if necessary if the bottom edge of the comment box is below the currently viewable area of the workspace... Calc does not provide the ability to scroll down inside a comment box, so the height of the comment box cannot be limited to the workspace height minus the height of the cell being commented on. Instead
[Libreoffice-bugs] [Bug 91107] Cut/Copy/Paste/"Select All" are active while they shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=91107 Buovjagachanged: What|Removed |Added Priority|medium |low Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Severity|normal |trivial --- Comment #6 from Buovjaga --- NEW per comment 5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/source
basic/source/comp/exprtree.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 379b7ffb68bed5bc376a91032a781be147a6eff1 Author: Pierre LepageDate: Sat Nov 5 14:52:44 2016 -0400 tdf#80731 Closing parenthesis is now detected (Mid statement and functions). Change-Id: I5efdb6c3ce71148672a8b76d3f1cc87b0fe04994 Reviewed-on: https://gerrit.libreoffice.org/30593 Tested-by: Julien Nabet Reviewed-by: Noel Grandin diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx index e7a2210..008976f 100644 --- a/basic/source/comp/exprtree.cxx +++ b/basic/source/comp/exprtree.cxx @@ -1055,6 +1055,11 @@ SbiExprListPtr SbiExprList::ParseParameters( SbiParser* pParser, bool bStandalon { if( ( pExprList->bBracket && eTok == RPAREN ) || SbiTokenizer::IsEoln( eTok ) ) { +if ( SbiTokenizer::IsEoln( eTok ) && pExprList->bBracket) +{ +pParser->Error( ERRCODE_BASIC_EXPECTED, RPAREN ); +pExprList->bError = true; +} break; } pParser->Error( pExprList->bBracket ? ERRCODE_BASIC_BAD_BRACKETS : ERRCODE_BASIC_EXPECTED, COMMA ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 44 +-- vcl/source/gdi/pdfwriter_impl.hxx | 61 +- 2 files changed, 56 insertions(+), 49 deletions(-) New commits: commit 4c5224a29fc11125bc845624a0ffe470416b791c Author: Noel GrandinDate: Tue Nov 29 14:37:55 2016 +0200 convert GraphicsState flags to o3tl::typed_flags Change-Id: I5b660895c470a904fa5f1bc8123cea901ad8cf9c Reviewed-on: https://gerrit.libreoffice.org/31365 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index 30daf70..cd391ca 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -11515,9 +11515,9 @@ void PDFWriterImpl::updateGraphicsState(Mode const mode) GraphicsState& rNewState = m_aGraphicsStack.front(); // first set clip region since it might invalidate everything else -if( (rNewState.m_nUpdateFlags & GraphicsState::updateClipRegion) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::ClipRegion) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateClipRegion; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::ClipRegion; if( m_aCurrentPDFState.m_bClipRegion != rNewState.m_bClipRegion || ( rNewState.m_bClipRegion && m_aCurrentPDFState.m_aClipRegion != rNewState.m_aClipRegion ) ) @@ -11527,7 +11527,7 @@ void PDFWriterImpl::updateGraphicsState(Mode const mode) aLine.append( "Q " ); // invalidate everything but the clip region m_aCurrentPDFState = GraphicsState(); -rNewState.m_nUpdateFlags = sal::static_int_cast(~GraphicsState::updateClipRegion); +rNewState.m_nUpdateFlags = ~GraphicsStateUpdateFlags::ClipRegion; } if( rNewState.m_bClipRegion ) { @@ -11550,34 +11550,34 @@ void PDFWriterImpl::updateGraphicsState(Mode const mode) } } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateMapMode) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::MapMode) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateMapMode; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::MapMode; getReferenceDevice()->SetMapMode( rNewState.m_aMapMode ); } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateFont) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::Font) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateFont; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::Font; getReferenceDevice()->SetFont( rNewState.m_aFont ); getReferenceDevice()->ImplNewFont(); } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateLayoutMode) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::LayoutMode) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateLayoutMode; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::LayoutMode; getReferenceDevice()->SetLayoutMode( rNewState.m_nLayoutMode ); } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateDigitLanguage) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::DigitLanguage) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateDigitLanguage; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::DigitLanguage; getReferenceDevice()->SetDigitLanguage( rNewState.m_aDigitLanguage ); } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateLineColor) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::LineColor) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateLineColor; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::LineColor; if( m_aCurrentPDFState.m_aLineColor != rNewState.m_aLineColor && rNewState.m_aLineColor != Color( COL_TRANSPARENT ) ) { @@ -11586,9 +11586,9 @@ void PDFWriterImpl::updateGraphicsState(Mode const mode) } } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateFillColor) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::FillColor) ) { -rNewState.m_nUpdateFlags &= ~GraphicsState::updateFillColor; +rNewState.m_nUpdateFlags &= ~GraphicsStateUpdateFlags::FillColor; if( m_aCurrentPDFState.m_aFillColor != rNewState.m_aFillColor && rNewState.m_aFillColor != Color( COL_TRANSPARENT ) ) { @@ -11597,9 +11597,9 @@ void PDFWriterImpl::updateGraphicsState(Mode const mode) } } -if( (rNewState.m_nUpdateFlags & GraphicsState::updateTransparentPercent) ) +if( (rNewState.m_nUpdateFlags & GraphicsStateUpdateFlags::TransparentPercent) ) { -rNewState.m_nUpdateFlags &=
[Libreoffice-commits] core.git: ucbhelper/source
ucbhelper/source/provider/propertyvalueset.cxx | 168 +++-- 1 file changed, 79 insertions(+), 89 deletions(-) New commits: commit 794c542953ca040d0e039f238bb00c95f6fdbaea Author: Noel GrandinDate: Tue Nov 29 14:02:47 2016 +0200 simplify macros Change-Id: Ib56bdc2f8a7015afc8ac83d7cfd6eb65089682bb Reviewed-on: https://gerrit.libreoffice.org/31364 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/ucbhelper/source/provider/propertyvalueset.cxx b/ucbhelper/source/provider/propertyvalueset.cxx index b53beba..4fd70e3 100644 --- a/ucbhelper/source/provider/propertyvalueset.cxx +++ b/ucbhelper/source/provider/propertyvalueset.cxx @@ -130,95 +130,86 @@ class PropertyValues : public std::vector< ucbhelper_impl::PropertyValue > {}; // Welcome to the macro hell... -#define GETVALUE_IMPL_TYPE( _type_, _type_name_, _member_name_, _cppu_type_ ) \ - \ -osl::MutexGuard aGuard( m_aMutex ); \ - \ -_type_ aValue = _type_(); /* default ctor */\ - \ -m_bWasNull = true;\ - \ -if ( ( columnIndex < 1 ) \ - || ( columnIndex > sal_Int32( m_pValues->size() ) ) )\ -{ \ -OSL_FAIL( "PropertyValueSet - index out of range!" );\ -} \ -else \ -{ \ -ucbhelper_impl::PropertyValue& rValue \ -= (*m_pValues)[ columnIndex - 1 ];\ - \ -if ( rValue.nOrigValue != PropsSet::NONE ) \ -{ \ -if ( rValue.nPropsSet & _type_name_ ) \ -{ \ -/* Values is present natively... */ \ -aValue = rValue._member_name_;\ -m_bWasNull = false; \ -} \ -else \ -{ \ -if ( !(rValue.nPropsSet & PropsSet::Object) ) \ -{ \ -/* Value is not (yet) available as Any. Create it. */ \ -getObject( columnIndex, Reference< XNameAccess >() ); \ -} \ - \ -if ( rValue.nPropsSet & PropsSet::Object )\ -{ \ -/* Value is available as Any. */ \ - \ -if ( rValue.aObject.hasValue() ) \ -{ \ -/* Try to convert into native value. */ \ -if ( rValue.aObject >>= aValue ) \ -{ \ -rValue._member_name_ = aValue;\ -rValue.nPropsSet |= _type_name_; \ -m_bWasNull = false; \ -} \ -else \ -{ \ -/* Last chance. Try type converter service... */ \ -
[Libreoffice-commits] core.git: ucbhelper/source
ucbhelper/source/provider/propertyvalueset.cxx | 160 - 1 file changed, 81 insertions(+), 79 deletions(-) New commits: commit 2833691149af36a7508bed2d5113a599f8460f91 Author: Noel GrandinDate: Tue Nov 29 14:01:11 2016 +0200 convert VALUE_SET constants to o3tl::typed_flags Change-Id: Ie2dead5e661cbcf31a92b3d38cba1983fa65dff4 Reviewed-on: https://gerrit.libreoffice.org/31363 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/ucbhelper/source/provider/propertyvalueset.cxx b/ucbhelper/source/provider/propertyvalueset.cxx index 142e142..b53beba 100644 --- a/ucbhelper/source/provider/propertyvalueset.cxx +++ b/ucbhelper/source/provider/propertyvalueset.cxx @@ -34,6 +34,7 @@ #include "osl/diagnose.h" #include "osl/mutex.hxx" #include +#include using namespace com::sun::star::beans; using namespace com::sun::star::container; @@ -44,44 +45,45 @@ using namespace com::sun::star::sdbc; using namespace com::sun::star::uno; using namespace com::sun::star::util; +enum class PropsSet { +NONE = 0x, +String = 0x0001, +Boolean = 0x0002, +Byte = 0x0004, +Short= 0x0008, +Int = 0x0010, +Long = 0x0020, +Float= 0x0040, +Double = 0x0080, +Bytes= 0x0100, +Date = 0x0200, +Time = 0x0400, +Timestamp= 0x0800, +BinaryStream = 0x1000, +CharacterStream = 0x2000, +Ref = 0x4000, +Blob = 0x8000, +Clob = 0x0001, +Array= 0x0002, +Object = 0x0004 +}; +namespace o3tl { +template<> struct typed_flags : is_typed_flags {}; +} + namespace ucbhelper_impl { -// PropertyValue. - - -const sal_uInt32 NO_VALUE_SET = 0x; -const sal_uInt32 STRING_VALUE_SET = 0x0001; -const sal_uInt32 BOOLEAN_VALUE_SET = 0x0002; -const sal_uInt32 BYTE_VALUE_SET = 0x0004; -const sal_uInt32 SHORT_VALUE_SET= 0x0008; -const sal_uInt32 INT_VALUE_SET = 0x0010; -const sal_uInt32 LONG_VALUE_SET = 0x0020; -const sal_uInt32 FLOAT_VALUE_SET= 0x0040; -const sal_uInt32 DOUBLE_VALUE_SET = 0x0080; -const sal_uInt32 BYTES_VALUE_SET= 0x0100; -const sal_uInt32 DATE_VALUE_SET = 0x0200; -const sal_uInt32 TIME_VALUE_SET = 0x0400; -const sal_uInt32 TIMESTAMP_VALUE_SET= 0x0800; -const sal_uInt32 BINARYSTREAM_VALUE_SET = 0x1000; -const sal_uInt32 CHARACTERSTREAM_VALUE_SET = 0x2000; -const sal_uInt32 REF_VALUE_SET = 0x4000; -const sal_uInt32 BLOB_VALUE_SET = 0x8000; -const sal_uInt32 CLOB_VALUE_SET = 0x0001; -const sal_uInt32 ARRAY_VALUE_SET= 0x0002; -const sal_uInt32 OBJECT_VALUE_SET = 0x0004; - struct PropertyValue { -OUString -sPropertyName; +OUStringsPropertyName; -sal_uInt32 nPropsSet; -sal_uInt32 nOrigValue; +PropsSetnPropsSet; +PropsSetnOrigValue; OUStringaString;// getString -boolbBoolean; // getBoolean +boolbBoolean; // getBoolean sal_Int8nByte; // getByte sal_Int16 nShort; // getShort sal_Int32 nInt; // getInt @@ -102,7 +104,7 @@ struct PropertyValue Any aObject;// getObject inline PropertyValue() -: nPropsSet( NO_VALUE_SET ), nOrigValue( NO_VALUE_SET ), +: nPropsSet( PropsSet::NONE ), nOrigValue( PropsSet::NONE ), bBoolean(false), nByte(0), nShort(0), @@ -146,7 +148,7 @@ class PropertyValues : public std::vector< ucbhelper_impl::PropertyValue > {}; ucbhelper_impl::PropertyValue& rValue \ = (*m_pValues)[ columnIndex - 1 ];\ \ -if ( rValue.nOrigValue != NO_VALUE_SET ) \ +if ( rValue.nOrigValue != PropsSet::NONE ) \ { \ if ( rValue.nPropsSet & _type_name_ ) \ { \ @@ -156,13 +158,13 @@ class PropertyValues : public std::vector< ucbhelper_impl::PropertyValue > {}; } \ else
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/dochdl/swdtflvr.cxx | 86 +-- sw/source/uibase/inc/swdtflvr.hxx| 25 +- 2 files changed, 56 insertions(+), 55 deletions(-) New commits: commit bc5aa635d7c847ffde9d9c78742d98f865d83805 Author: Noel GrandinDate: Tue Nov 29 13:46:49 2016 +0200 convert TransferBufferType to o3tl::typed_flags Change-Id: I69bed592e4c7c93ec9d6eb1e92481048370dfb90 Reviewed-on: https://gerrit.libreoffice.org/31361 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx b/sw/source/uibase/dochdl/swdtflvr.cxx index b139536..0b84f35 100644 --- a/sw/source/uibase/dochdl/swdtflvr.cxx +++ b/sw/source/uibase/dochdl/swdtflvr.cxx @@ -149,7 +149,6 @@ using namespace ::svx; using namespace ::com::sun::star; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::datatransfer; -using namespace nsTransferBufferType; #define DDE_TXT_ENCODINGosl_getThreadTextEncoding() @@ -214,7 +213,7 @@ SwTransferable::SwTransferable( SwWrtShell& rSh ) m_pBookmark( nullptr ), m_pImageMap( nullptr ), m_pTargetURL( nullptr ), -m_eBufferType( TRNSFR_NONE ) +m_eBufferType( TransferBufferType::NONE ) { rSh.GetView().AddTransferable(*this); SwDocShell* pDShell = rSh.GetDoc()->GetDocShell(); @@ -277,7 +276,7 @@ SwTransferable::~SwTransferable() delete m_pTargetURL; delete m_pBookmark; -m_eBufferType = TRNSFR_NONE; +m_eBufferType = TransferBufferType::NONE; Application::GetSolarMutex().release(); } @@ -440,7 +439,7 @@ bool SwTransferable::GetData( const DataFlavor& rFlavor, const OUString& rDestDo if( m_pWrtShell->GetURLFromButton( sURL, sDesc ) ) { m_pBookmark = new INetBookmark( sURL, sDesc ); -m_eBufferType = TRNSFR_INETFLD; +m_eBufferType = TransferBufferType::InetField; } } @@ -470,7 +469,7 @@ bool SwTransferable::GetData( const DataFlavor& rFlavor, const OUString& rDestDo m_pBookmark = new INetBookmark( static_cast(aContentAtPos.aFnd.pAttr)->GetValue(), aContentAtPos.sStr ); -m_eBufferType = TRNSFR_INETFLD; +m_eBufferType = TransferBufferType::InetField; if( bSelect ) m_pWrtShell->SelectTextAttr( RES_TXTATR_INETFMT ); } @@ -490,7 +489,7 @@ bool SwTransferable::GetData( const DataFlavor& rFlavor, const OUString& rDestDo } bool bOK = false; -if( TRNSFR_OLE == m_eBufferType ) +if( TransferBufferType::Ole == m_eBufferType ) { //TODO/MBA: testing - is this the "single OLE object" case?! // get OLE-Object from ClipDoc and get the data from that. @@ -558,18 +557,18 @@ bool SwTransferable::GetData( const DataFlavor& rFlavor, const OUString& rDestDo break; case SotClipboardFormatId::SVXB: -if( m_eBufferType & TRNSFR_GRAPHIC && m_pOrigGraphic ) +if( m_eBufferType & TransferBufferType::Graphic && m_pOrigGraphic ) bOK = SetGraphic( *m_pOrigGraphic, rFlavor ); break; case SotClipboardFormatId::GDIMETAFILE: -if( m_eBufferType & TRNSFR_GRAPHIC ) +if( m_eBufferType & TransferBufferType::Graphic ) bOK = SetGDIMetaFile( m_pClpGraphic->GetGDIMetaFile(), rFlavor ); break; case SotClipboardFormatId::BITMAP: case SotClipboardFormatId::PNG: // Neither pClpBitmap nor pClpGraphic are necessarily set -if( (m_eBufferType & TRNSFR_GRAPHIC) && (m_pClpBitmap != nullptr || m_pClpGraphic != nullptr)) +if( (m_eBufferType & TransferBufferType::Graphic) && (m_pClpBitmap != nullptr || m_pClpGraphic != nullptr)) bOK = SetBitmapEx( (m_pClpBitmap ? m_pClpBitmap : m_pClpGraphic)->GetBitmapEx(), rFlavor ); break; @@ -589,7 +588,7 @@ bool SwTransferable::GetData( const DataFlavor& rFlavor, const OUString& rDestDo case SotClipboardFormatId::FILECONTENT: case SotClipboardFormatId::UNIFORMRESOURCELOCATOR: case SotClipboardFormatId::SIMPLE_FILE: -if( (TRNSFR_INETFLD & m_eBufferType) && m_pBookmark ) +if( (TransferBufferType::InetField & m_eBufferType) && m_pBookmark ) bOK = SetINetBookmark( *m_pBookmark, rFlavor ); break; @@ -742,7 +741,7 @@ bool SwTransferable::WriteObject( tools::SvRef& xStream, { SwDoc* pDoc = static_cast (pObject); xWrt->bWriteClipboardDoc = true; -xWrt->bWriteOnlyFirstTable = 0 != (TRNSFR_TABELLE & m_eBufferType); +xWrt->bWriteOnlyFirstTable = bool(TransferBufferType::Table & m_eBufferType);
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx |9 ++ sw/source/filter/ww8/docxattributeoutput.hxx |2 - sw/source/filter/ww8/docxexport.cxx |2 - sw/source/filter/ww8/docxexport.hxx |2 - sw/source/filter/ww8/rtfattributeoutput.cxx | 15 +- sw/source/filter/ww8/rtfattributeoutput.hxx |2 - sw/source/filter/ww8/rtfexport.cxx |2 - sw/source/filter/ww8/rtfexport.hxx |2 - sw/source/filter/ww8/wrtw8esh.cxx| 23 sw/source/filter/ww8/wrtw8nds.cxx| 21 +++ sw/source/filter/ww8/wrtww8.hxx | 24 ++--- sw/source/filter/ww8/wrtww8gr.cxx| 11 +++- sw/source/filter/ww8/ww8atr.cxx | 37 +-- 13 files changed, 75 insertions(+), 77 deletions(-) New commits: commit 4d00ca767de19696084fc52ff3638c448233b818 Author: Noel GrandinDate: Tue Nov 29 13:37:10 2016 +0200 convert WRITEFIELD constants to o3tl::typed_flags Change-Id: I6412faee844e19195d57415874022bcf8547f4d7 Reviewed-on: https://gerrit.libreoffice.org/31360 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 7830a32..c4c226d 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -137,7 +137,6 @@ using namespace oox; using namespace docx; using namespace sax_fastparser; using namespace nsSwDocInfoSubType; -using namespace nsFieldFlags; using namespace sw::util; using namespace ::com::sun::star; using namespace ::com::sun::star::drawing; @@ -2384,7 +2383,7 @@ bool DocxAttributeOutput::EndURL(bool const) void DocxAttributeOutput::FieldVanish( const OUString& rText, ww::eField eType ) { -WriteField_Impl( nullptr, eType, rText, WRITEFIELD_ALL ); +WriteField_Impl( nullptr, eType, rText, FieldFlags::All ); } // The difference between 'Redline' and 'StartRedline'+'EndRedline' is that: @@ -6752,15 +6751,15 @@ void DocxAttributeOutput::WriteExpand( const SwField* pField ) m_rExport.OutputField( pField, ww::eUNKNOWN, sCmd ); } -void DocxAttributeOutput::WriteField_Impl( const SwField* pField, ww::eField eType, const OUString& rFieldCmd, sal_uInt8 nMode ) +void DocxAttributeOutput::WriteField_Impl( const SwField* pField, ww::eField eType, const OUString& rFieldCmd, FieldFlags nMode ) { struct FieldInfos infos; if (pField) infos.pField.reset(pField->CopyField()); infos.sCmd = rFieldCmd; infos.eType = eType; -infos.bClose = WRITEFIELD_CLOSE & nMode; -infos.bOpen = WRITEFIELD_START & nMode; +infos.bClose = bool(FieldFlags::Close & nMode); +infos.bOpen = bool(FieldFlags::Start & nMode); m_Fields.push_back( infos ); if ( pField ) diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx index 7c5149b..a870c17 100644 --- a/sw/source/filter/ww8/docxattributeoutput.hxx +++ b/sw/source/filter/ww8/docxattributeoutput.hxx @@ -366,7 +366,7 @@ public: const OUString , const SvxBrushItem* pBrush ) override; -void WriteField_Impl( const SwField* pField, ww::eField eType, const OUString& rFieldCmd, sal_uInt8 nMode ); +void WriteField_Impl( const SwField* pField, ww::eField eType, const OUString& rFieldCmd, FieldFlags nMode ); void WriteFormData_Impl( const ::sw::mark::IFieldmark& rFieldmark ); void WriteBookmarks_Impl( std::vector< OUString >& rStarts, std::vector< OUString >& rEnds ); diff --git a/sw/source/filter/ww8/docxexport.cxx b/sw/source/filter/ww8/docxexport.cxx index c36139c..4954bdb 100644 --- a/sw/source/filter/ww8/docxexport.cxx +++ b/sw/source/filter/ww8/docxexport.cxx @@ -274,7 +274,7 @@ void DocxExport::WriteHeadersFooters( sal_uInt8 nHeadFootFlags, #endif } -void DocxExport::OutputField( const SwField* pField, ww::eField eFieldType, const OUString& rFieldCmd, sal_uInt8 nMode ) +void DocxExport::OutputField( const SwField* pField, ww::eField eFieldType, const OUString& rFieldCmd, FieldFlags nMode ) { m_pAttrOutput->WriteField_Impl( pField, eFieldType, rFieldCmd, nMode ); } diff --git a/sw/source/filter/ww8/docxexport.hxx b/sw/source/filter/ww8/docxexport.hxx index 1b0b03b..ad5d911 100644 --- a/sw/source/filter/ww8/docxexport.hxx +++ b/sw/source/filter/ww8/docxexport.hxx @@ -152,7 +152,7 @@ public: /// Write the field virtual void OutputField( const SwField* pField, ww::eField eFieldType, -const OUString& rFieldCmd, sal_uInt8 nMode = nsFieldFlags::WRITEFIELD_ALL ) override; +const OUString& rFieldCmd, FieldFlags nMode = FieldFlags::All ) override; /// Write the data of the form field virtual void WriteFormData( const ::sw::mark::IFieldmark&
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/undobj.hxx | 23 +-- sw/source/core/undo/undel.cxx |6 +++--- sw/source/core/undo/undobj.cxx | 22 +++--- sw/source/core/undo/unmove.cxx |4 ++-- 4 files changed, 29 insertions(+), 26 deletions(-) New commits: commit b5a1f7cbf9c83f7b1cc6ea103047147ce3d63fee Author: Noel GrandinDate: Tue Nov 29 13:08:34 2016 +0200 convert DelContentType to o3tl::typed_flags Change-Id: I2c94b28e4c95c22c05ba7aed8e413cc7f6b70874 Reviewed-on: https://gerrit.libreoffice.org/31358 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/inc/undobj.hxx b/sw/inc/undobj.hxx index ef154ca..fedc567 100644 --- a/sw/inc/undobj.hxx +++ b/sw/inc/undobj.hxx @@ -26,6 +26,7 @@ #include #include #include +#include class SwHistory; class SwIndex; @@ -125,21 +126,23 @@ public: static bool HasHiddenRedlines( const SwRedlineSaveDatas& rSData ); }; -typedef sal_uInt16 DelContentType; -namespace nsDelContentType +enum class DelContentType : sal_uInt16 { -const DelContentType DELCNT_FTN = 0x01; -const DelContentType DELCNT_FLY = 0x02; -const DelContentType DELCNT_TOC = 0x04; -const DelContentType DELCNT_BKM = 0x08; -const DelContentType DELCNT_ALL = 0x0F; -const DelContentType DELCNT_CHKNOCNTNT = 0x80; +Ftn = 0x01, +Fly = 0x02, +Toc = 0x04, +Bkm = 0x08, +AllMask = 0x0F, +CheckNoCntnt = 0x80, +}; +namespace o3tl { +template<> struct typed_flags : is_typed_flags {}; } /// will DelContentIndex destroy a frame anchored at character at rAnchorPos? bool IsDestroyFrameAnchoredAtChar(SwPosition const & rAnchorPos, SwPosition const & rStart, SwPosition const & rEnd, const SwDoc* doc, -DelContentType const nDelContentType = nsDelContentType::DELCNT_ALL); +DelContentType const nDelContentType = DelContentType::AllMask); // This class has to be inherited into an Undo-object if it saves content // for Redo/Undo... @@ -171,7 +174,7 @@ protected: // Before moving stuff into UndoNodes-Array care has to be taken that // the content-bearing attributes are removed from the nodes-array. void DelContentIndex( const SwPosition& pMark, const SwPosition& pPoint, -DelContentType nDelContentType = nsDelContentType::DELCNT_ALL ); +DelContentType nDelContentType = DelContentType::AllMask ); public: SwUndoSaveContent(); diff --git a/sw/source/core/undo/undel.cxx b/sw/source/core/undo/undel.cxx index 073ed50..2b91ad4 100644 --- a/sw/source/core/undo/undel.cxx +++ b/sw/source/core/undo/undel.cxx @@ -147,7 +147,7 @@ SwUndoDelete::SwUndoDelete( { OSL_ENSURE( rPam.HasMark(), "PaM ohne Mark" ); DelContentIndex( *rPam.GetMark(), *rPam.GetPoint(), -DelContentType(nsDelContentType::DELCNT_ALL | nsDelContentType::DELCNT_CHKNOCNTNT) ); +DelContentType(DelContentType::AllMask | DelContentType::CheckNoCntnt) ); ::sw::UndoGuard const undoGuard(pDoc->GetIDocumentUndoRedo()); DelBookmarks(pStt->nNode, pEnd->nNode); @@ -990,7 +990,7 @@ void SwUndoDelete::RedoImpl(::sw::UndoRedoContext & rContext) { OSL_ENSURE( rPam.HasMark(), "PaM without Mark" ); DelContentIndex( *rPam.GetMark(), *rPam.GetPoint(), -DelContentType(nsDelContentType::DELCNT_ALL | nsDelContentType::DELCNT_CHKNOCNTNT) ); +DelContentType(DelContentType::AllMask | DelContentType::CheckNoCntnt) ); DelBookmarks(rPam.GetMark()->nNode, rPam.GetPoint()->nNode); } @@ -1006,7 +1006,7 @@ void SwUndoDelete::RedoImpl(::sw::UndoRedoContext & rContext) { OSL_ENSURE( rPam.HasMark(), "PaM without Mark" ); DelContentIndex( *rPam.GetMark(), *rPam.GetPoint(), -DelContentType(nsDelContentType::DELCNT_ALL | nsDelContentType::DELCNT_CHKNOCNTNT) ); +DelContentType(DelContentType::AllMask | DelContentType::CheckNoCntnt) ); DelBookmarks( rPam.GetMark()->nNode, rPam.GetPoint()->nNode ); } diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx index e630254..5d0dfb2 100644 --- a/sw/source/core/undo/undobj.cxx +++ b/sw/source/core/undo/undobj.cxx @@ -471,7 +471,7 @@ void SwUndoSaveContent::DelContentIndex( const SwPosition& rMark, ::sw::UndoGuard const undoGuard(pDoc->GetIDocumentUndoRedo()); // 1. Footnotes -if( nsDelContentType::DELCNT_FTN & nDelContentType ) +if( DelContentType::Ftn & nDelContentType ) { SwFootnoteIdxs& rFootnoteArr = pDoc->GetFootnoteIdxs(); if( !rFootnoteArr.empty() ) @@ -487,7 +487,7 @@ void
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/tox.hxx| 27 +++ sw/source/core/doc/doctxm.cxx | 38 +- sw/source/core/tox/tox.cxx|2 +- sw/source/core/unocore/unoidx.cxx | 24 sw/source/ui/index/cntex.cxx | 12 ++-- sw/source/ui/index/cnttab.cxx | 12 ++-- sw/source/ui/index/cnttab.src | 10 +- sw/source/uibase/inc/toxmgr.hxx |8 8 files changed, 66 insertions(+), 67 deletions(-) New commits: commit 3c1b1fb937c261987a430593ed525df78fa5ce07 Author: Noel GrandinDate: Tue Nov 29 13:03:39 2016 +0200 convert SwTOOElements to o3tl::typed_flags Change-Id: Ic0636c8f641cf70e0372b31f8a8d111b45ba6070 Reviewed-on: https://gerrit.libreoffice.org/31357 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/inc/tox.hxx b/sw/inc/tox.hxx index 27e84de..d612d0d 100644 --- a/sw/inc/tox.hxx +++ b/sw/inc/tox.hxx @@ -372,14 +372,17 @@ enum SwCaptionDisplay CAPTION_TEXT }; -typedef sal_uInt16 SwTOOElements; -namespace nsSwTOOElements -{ -const SwTOOElements TOO_MATH= 0x01; -const SwTOOElements TOO_CHART = 0x02; -const SwTOOElements TOO_CALC= 0x08; -const SwTOOElements TOO_DRAW_IMPRESS= 0x10; -const SwTOOElements TOO_OTHER = 0x80; +enum class SwTOOElements : sal_uInt16 +{ +NONE= 0x00, +Math= 0x01, +Chart = 0x02, +Calc= 0x08, +DrawImpress = 0x10, +Other = 0x80, +}; +namespace o3tl { +template<> struct typed_flags : is_typed_flags {}; } #define TOX_STYLE_DELIMITER ((sal_Unicode)0x01) @@ -406,8 +409,8 @@ class SW_DLLPUBLIC SwTOXBase : public SwClient SwTOIOptionsnOptions; // options of alphabetical index } m_aData; -SwTOXElementm_nCreateType;// sources to create the index from -sal_uInt16 m_nOLEOptions;// OLE sources +SwTOXElement m_nCreateType;// sources to create the index from +SwTOOElementsm_nOLEOptions;// OLE sources SwCaptionDisplay m_eCaptionDisplay; boolm_bProtected : 1; // index protected ? boolm_bFromChapter : 1; // create from chapter or document @@ -474,8 +477,8 @@ public: inline void SetOptions(SwTOIOptions nOpt); // index of objects -sal_uInt16 GetOLEOptions() const {return m_nOLEOptions;} -voidSetOLEOptions(sal_uInt16 nOpt) {m_nOLEOptions = nOpt;} +SwTOOElements GetOLEOptions() const {return m_nOLEOptions;} +voidSetOLEOptions(SwTOOElements nOpt) {m_nOLEOptions = nOpt;} // index of objects diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx index 75f1168..4b7418e 100644 --- a/sw/source/core/doc/doctxm.cxx +++ b/sw/source/core/doc/doctxm.cxx @@ -1329,10 +1329,10 @@ void SwTOXBaseSection::UpdateAuthorities( const SwTOXInternational& rIntl ) } } -static long lcl_IsSOObject( const SvGlobalName& rFactoryNm ) +static SwTOOElements lcl_IsSOObject( const SvGlobalName& rFactoryNm ) { -static struct SoObjType { -long nFlag; +static const struct SoObjType { +SwTOOElements nFlag; // GlobalNameId struct GlobalNameIds { sal_uInt32 n1; @@ -1340,27 +1340,24 @@ static long lcl_IsSOObject( const SvGlobalName& rFactoryNm ) sal_uInt8 b8, b9, b10, b11, b12, b13, b14, b15; } aGlNmIds[4]; } aArr[] = { -{ nsSwTOOElements::TOO_MATH, +{ SwTOOElements::Math, { {SO3_SM_CLASSID_60},{SO3_SM_CLASSID_50}, {SO3_SM_CLASSID_40},{SO3_SM_CLASSID_30} } }, -{ nsSwTOOElements::TOO_CHART, +{ SwTOOElements::Chart, { {SO3_SCH_CLASSID_60},{SO3_SCH_CLASSID_50}, {SO3_SCH_CLASSID_40},{SO3_SCH_CLASSID_30} } }, -{ nsSwTOOElements::TOO_CALC, +{ SwTOOElements::Calc, { {SO3_SC_CLASSID_60},{SO3_SC_CLASSID_50}, {SO3_SC_CLASSID_40},{SO3_SC_CLASSID_30} } }, -{ nsSwTOOElements::TOO_DRAW_IMPRESS, +{ SwTOOElements::DrawImpress, { {SO3_SIMPRESS_CLASSID_60},{SO3_SIMPRESS_CLASSID_50}, {SO3_SIMPRESS_CLASSID_40},{SO3_SIMPRESS_CLASSID_30} } }, -{ nsSwTOOElements::TOO_DRAW_IMPRESS, - { {SO3_SDRAW_CLASSID_60},{SO3_SDRAW_CLASSID_50}}}, -{ 0,{{0,0,0,0,0,0,0,0,0,0,0},{0,0,0,0,0,0,0,0,0,0,0}, -{0,0,0,0,0,0,0,0,0,0,0},{0,0,0,0,0,0,0,0,0,0,0} } } +{ SwTOOElements::DrawImpress, + { {SO3_SDRAW_CLASSID_60},{SO3_SDRAW_CLASSID_50} } } }; -long nRet = 0; -for( const SoObjType* pArr = aArr; !nRet && pArr->nFlag; ++pArr ) -for (auto & rId : pArr->aGlNmIds)
[Libreoffice-bugs] [Bug 70154] Writer crashes just before exiting on Windows XP
https://bugs.documentfoundation.org/show_bug.cgi?id=70154 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #35 from tommy27 --- I set status to NEW since there have been multiple independent confirmations. I also ask those people to tell if issue persists in latest LibO 5.2.3.3 release. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74326] slow document load when network enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=74326 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Ever confirmed|0 |1 --- Comment #7 from tommy27 --- (In reply to Buovjaga from comment #6) > Same as bug 97931? Does the workaround mentioned in the report help you? please answer this question and tell if issue is still present in LibO 5.2.3.3 status NEEDINFO until then -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82329] FILEOPEN: LibO hangs when opening a file from a mounted NFS drive and the file path contains special german chars (i.e. ü)
https://bugs.documentfoundation.org/show_bug.cgi?id=82329 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Summary|FILEOPEN: In Kubuntu 14.04 |FILEOPEN: LibO hangs when |LibreOffice hangs when |opening a file from a |opening a flie from a |mounted NFS drive and the |mounted nfs drive and the |file path contains special |file path contains spezial |german chars (i.e. ü) |german chars| Ever confirmed|0 |1 --- Comment #5 from tommy27 --- @Timon please answer to comment 4 and give an update of the bug status (present or not) in latest LibO 5.2.3.3 release status NEEDINFO until then -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75662] All of LibO 4.x hangs if Base is running when switching between video console and RDP session
https://bugs.documentfoundation.org/show_bug.cgi?id=75662 --- Comment #24 from Brolin Empey--- My other reason for replacing the video card in incubus/incubus64 was to see if I could use a 4k UHD-capable video controller because I was interested in upgrading from a 1920×1200 display (flat-panel video monitor) to a 4k UHD display (flat-panel video monitor). I do not know if it is related to this issue with LibreOffice Base inclusive-or possibly the JRE but Winamp is another application that often does not survive switching between the video console and an RDP session. Interestingly, Winamp does not use Java. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85238] LibO takes built-in font preference list as precedence instead of fontconfig
https://bugs.documentfoundation.org/show_bug.cgi?id=85238 --- Comment #5 from tommy27--- any news about 5.2.3.3? is issue still present or changed? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103975] FILEOPEN: DOCX: Incorrect page break moves content to page 2
https://bugs.documentfoundation.org/show_bug.cgi?id=103975 --- Comment #12 from Commit Notification--- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3de0128ec4e0fce998c84043a7f8f173f1f8ac96=libreoffice-5-3 tdf#103975 docx import: don't lose column break It will be available in 5.3.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakE.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx |7 +++ writerfilter/source/dmapper/DomainMapper.cxx |9 + 3 files changed, 16 insertions(+) New commits: commit 3de0128ec4e0fce998c84043a7f8f173f1f8ac96 Author: Justin LuthDate: Mon Nov 28 21:59:22 2016 +0300 tdf#103975 docx import: don't lose column break This round-trips terribly, but that was equally true before these patches. Change-Id: I4ed191c77e7f519d4c013fc83ef8b866b53d0c70 Reviewed-on: https://gerrit.libreoffice.org/31326 Tested-by: Jenkins Reviewed-by: Justin Luth (cherry picked from commit bbc7ed9c379019f31dc7ac234cf83ea151601465) Reviewed-on: https://gerrit.libreoffice.org/31341 diff --git a/sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakE.docx b/sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakE.docx new file mode 100755 index 000..ac3eb9f Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakE.docx differ diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx index 05a4904..78845fd 100644 --- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx +++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -129,6 +130,12 @@ DECLARE_SW_IMPORT_TEST(testMathMalformedXml, "math-malformed_xml.docx", FailTest CPPUNIT_ASSERT(!mxComponent.is()); } +DECLARE_OOXMLIMPORT_TEST(testTdf103975_notPageBreakE, "tdf103975_notPageBreakE.docx") +{ +// The problem was that the column break was getting lost. +CPPUNIT_ASSERT_EQUAL(style::BreakType_COLUMN_BEFORE, getProperty(getParagraph(2), "BreakType")); +} + DECLARE_OOXMLIMPORT_TEST(testN751017, "n751017.docx") { uno::Reference xTextFieldsSupplier(mxComponent, uno::UNO_QUERY); diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index 26168b8..aa279d6 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -3258,7 +3258,16 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, size_t len) if (m_pImpl->isBreakDeferred(PAGE_BREAK)) pContext->Insert(PROP_BREAK_TYPE, uno::makeAny(style::BreakType_PAGE_BEFORE)); else if (m_pImpl->isBreakDeferred(COLUMN_BREAK)) +{ +if ( m_pImpl->GetIsFirstParagraphInSection() || !m_pImpl->IsFirstRun() ) +{ +mbIsSplitPara = true; +m_pImpl->finishParagraph( m_pImpl->GetTopContextOfType(CONTEXT_PARAGRAPH) ); +lcl_startParagraphGroup(); +} + pContext->Insert(PROP_BREAK_TYPE, uno::makeAny(style::BreakType_COLUMN_BEFORE)); +} m_pImpl->clearDeferredBreaks(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104241] Not possible to scroll past page 1 in GS51-GettingStartedLO.odt ( large image on page 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=104241 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Ever confirmed|0 |1 --- Comment #1 from tommy27 --- reproduced under Win8.1 64 using LibO 5.2.3.3 I see that there's a kind of "huge" text cursor blinking in the first page... looks like the text cursor became so big to fill almost the entire page. maybe there's some conflitct between scrolling and cursor position. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104252] Embedded EMF files in docx document shows text content on screen but not in print or export
https://bugs.documentfoundation.org/show_bug.cgi?id=104252 Adolfo Jaymechanged: What|Removed |Added Attachment #129132|application/unknown |application/pdf mime type|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76017] Two finger touch pad scrolling in the horizontal axis is in the wrong direction
https://bugs.documentfoundation.org/show_bug.cgi?id=76017 tommy27changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||ba...@quipo.it Resolution|--- |FIXED --- Comment #17 from tommy27 --- let's mark it as fixed then. feel free to reopen if the bug persists -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104207] An easier way to backup custom toolbar presets
https://bugs.documentfoundation.org/show_bug.cgi?id=104207 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from tommy27 --- does it helps? status NEEDINFO waiting for reporter feedback -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] UNCONFIRMED bug count at 513
Tommy wrote: let's try to put it down to 500 by the end of the weekend!!! Tommy from 513 to 502 right now. good job guys. a little small additional effort is needed to break the 500 wall. Tommy ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 104264] LibO PDF import filter mangles font names
https://bugs.documentfoundation.org/show_bug.cgi?id=104264 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104264] LibO PDF import filter mangles font names
https://bugs.documentfoundation.org/show_bug.cgi?id=104264 tommy27changed: What|Removed |Added CC||ba...@quipo.it --- Comment #3 from tommy27 --- Created attachment 129147 --> https://bugs.documentfoundation.org/attachment.cgi?id=129147=edit screenshot I confirm bug under Win8.1 x64 using LibO 5.2.3.3 see my screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104267] change outlines selection for tables and cells
https://bugs.documentfoundation.org/show_bug.cgi?id=104267 tommy27changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Summary|an enhancement for the |change outlines selection |tables and cells|for tables and cells Ever confirmed|0 |1 --- Comment #1 from tommy27 --- would you please draw a mockup to make it easier to understand what you mean and what would be the final effect that you would like to see? status NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104259] FILEOPEN DOCX: Incorrect text alignment
https://bugs.documentfoundation.org/show_bug.cgi?id=104259 tommy27changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||ba...@quipo.it Resolution|--- |WORKSFORME --- Comment #3 from tommy27 --- I confirm bug under Win8.1 x64 using LibO 5.2.3.3 but I can tell you that bug is fixed in LibO 5.3.0.0.alpha1+ Build ID: 8d613870b2cd2e3e4396b4fa97dbd8080fda8f52 CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Layout Engine: new; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-18_22:58:29 Locale: it-IT (it_IT); Calc: group so RESOLVED WORKSFORME since the issue is gone in forthcoming 5.3.x branch. thanks for your bug report. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - common/MessageQueue.cpp common/MessageQueue.hpp common/Protocol.hpp kit/Kit.cpp test/TileQueueTests.cpp
common/MessageQueue.cpp | 179 +--- common/MessageQueue.hpp | 37 + common/Protocol.hpp |7 + kit/Kit.cpp | 10 +- test/TileQueueTests.cpp |8 +- 5 files changed, 208 insertions(+), 33 deletions(-) New commits: commit ff74d75d64e7ddf6ef7f4b269343fbb398992b82 Author: Ashod NakashianDate: Tue Nov 29 21:55:44 2016 -0500 loolwsd: improved MessageQueue Tiles no longer hog the queue ahead of all else. We now give priority to callback events, so clients get to know the document state sooner. Since tiles take long to render, an equal time is given to non-tiles (capped at 100ms). Finally, Impress preview tiles are given the lowest priority and rendered only when the queue is drained. Change-Id: I922c1e11200e5675f50d86b83baee1588cbbf66f Reviewed-on: https://gerrit.libreoffice.org/31394 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian (cherry picked from commit c326228774e720011b8845f0ee14b4c0a5f1d4f2) Reviewed-on: https://gerrit.libreoffice.org/31395 diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp index d9696e1..d6e1eed 100644 --- a/common/MessageQueue.cpp +++ b/common/MessageQueue.cpp @@ -191,46 +191,174 @@ int TileQueue::priority(const std::string& tileMsg) return -1; } -void TileQueue::deprioritizePreviews() +int TileQueue::findFirstNonPreview(bool preferTiles) const { +int firstTile = -1; +int firstElse = -1; for (size_t i = 0; i < _queue.size(); ++i) { -const auto front = _queue.front(); -const std::string message(front.data(), front.size()); +const auto& front = _queue[i]; +const bool isTile = LOOLProtocol::matchPrefix("tile", front); +//LOG_WRN("#" << i << " " << (isTile ? "isTile" : "non-tile")); -// stop at the first non-tile or non-'id' (preview) message -std::string id; -if (!LOOLProtocol::matchPrefix("tile", message) || -!LOOLProtocol::getTokenStringFromMessage(message, "id", id)) +if (isTile && firstTile < 0) +{ +const std::string msg(front.data(), front.size()); +std::string id; +const bool isPreview = LOOLProtocol::getTokenStringFromMessage(msg, "id", id); +//LOG_WRN("#" << i << " " << (isPreview ? "isPreview" : "isTile") << ": " << msg); +if (!isPreview) +{ +firstTile = i; +//LOG_WRN("firstTile: #" << i); +} +} +else if (!isTile && firstElse < 0) +{ +firstElse = i; +//LOG_WRN("firstElse: #" << i); +} +else if (firstTile >=0 && firstElse >= 0) { break; } +} -_queue.erase(_queue.begin()); -_queue.push_back(front); +if (preferTiles && firstTile >= 0) +{ +return firstTile; +} + +if (firstElse >= 0) +{ +return firstElse; +} + +if (firstTile >= 0) +{ +return firstTile; +} + +return -1; +} + +void TileQueue::bumpToTop(const size_t index) +{ +if (index > 0) +{ +Payload payload(_queue[index]); +//LOG_WRN("Bumping: " << std::string(payload.data(), payload.size())); + +_queue.erase(_queue.begin() + index); +_queue.insert(_queue.begin(), payload); } } +void TileQueue::updateTimestamps(const bool isTile) +{ +if (isTile) +{ +_lastGetTile = true; +_lastTileGetTime = std::chrono::steady_clock::now(); +} +else if (_lastGetTile) +{ +// Update non-tile timestamp when switching from tiles. +_lastGetTile = false; +_lastGetTime = std::chrono::steady_clock::now(); +} +} + +bool TileQueue::shouldPreferTiles() const +{ +if (_lastGetTile) +{ +// If we had just done a tile, do something else. +LOG_TRC("Last was tile, doing non-tiles."); +return false; +} + +// Check how long it's been since we'd done tiles. +const auto tileDuration = (_lastGetTime - _lastTileGetTime); +const auto tileDurationMs = std::chrono::duration_cast(tileDuration).count(); +const auto duration = (std::chrono::steady_clock::now() - _lastGetTime); +const auto durationMs = std::chrono::duration_cast(duration).count(); +LOG_TRC("Tile duration: " << tileDurationMs << "ms, nonTile duration: " << durationMs << "ms."); + +if (durationMs > MaxTileSkipDurationMs) +{ +LOG_TRC("Capping non-tiles to 100ms. Prefer tiles now."); +return true; +} + +if (durationMs > tileDurationMs) +{ +LOG_TRC("Capping non-tiles to tileDurationMs (" << tileDurationMs << "). Prefer tiles now."); +return true; +} + +// We can still do some more non-tiles. +LOG_TRC("Have
[Libreoffice-commits] online.git: common/MessageQueue.cpp common/MessageQueue.hpp common/Protocol.hpp kit/Kit.cpp test/TileQueueTests.cpp
common/MessageQueue.cpp | 179 +--- common/MessageQueue.hpp | 37 + common/Protocol.hpp |7 + kit/Kit.cpp | 10 +- test/TileQueueTests.cpp |8 +- 5 files changed, 208 insertions(+), 33 deletions(-) New commits: commit c326228774e720011b8845f0ee14b4c0a5f1d4f2 Author: Ashod NakashianDate: Tue Nov 29 21:55:44 2016 -0500 loolwsd: improved MessageQueue Tiles no longer hog the queue ahead of all else. We now give priority to callback events, so clients get to know the document state sooner. Since tiles take long to render, an equal time is given to non-tiles (capped at 100ms). Finally, Impress preview tiles are given the lowest priority and rendered only when the queue is drained. Change-Id: I922c1e11200e5675f50d86b83baee1588cbbf66f Reviewed-on: https://gerrit.libreoffice.org/31394 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp index d9696e1..d6e1eed 100644 --- a/common/MessageQueue.cpp +++ b/common/MessageQueue.cpp @@ -191,46 +191,174 @@ int TileQueue::priority(const std::string& tileMsg) return -1; } -void TileQueue::deprioritizePreviews() +int TileQueue::findFirstNonPreview(bool preferTiles) const { +int firstTile = -1; +int firstElse = -1; for (size_t i = 0; i < _queue.size(); ++i) { -const auto front = _queue.front(); -const std::string message(front.data(), front.size()); +const auto& front = _queue[i]; +const bool isTile = LOOLProtocol::matchPrefix("tile", front); +//LOG_WRN("#" << i << " " << (isTile ? "isTile" : "non-tile")); -// stop at the first non-tile or non-'id' (preview) message -std::string id; -if (!LOOLProtocol::matchPrefix("tile", message) || -!LOOLProtocol::getTokenStringFromMessage(message, "id", id)) +if (isTile && firstTile < 0) +{ +const std::string msg(front.data(), front.size()); +std::string id; +const bool isPreview = LOOLProtocol::getTokenStringFromMessage(msg, "id", id); +//LOG_WRN("#" << i << " " << (isPreview ? "isPreview" : "isTile") << ": " << msg); +if (!isPreview) +{ +firstTile = i; +//LOG_WRN("firstTile: #" << i); +} +} +else if (!isTile && firstElse < 0) +{ +firstElse = i; +//LOG_WRN("firstElse: #" << i); +} +else if (firstTile >=0 && firstElse >= 0) { break; } +} -_queue.erase(_queue.begin()); -_queue.push_back(front); +if (preferTiles && firstTile >= 0) +{ +return firstTile; +} + +if (firstElse >= 0) +{ +return firstElse; +} + +if (firstTile >= 0) +{ +return firstTile; +} + +return -1; +} + +void TileQueue::bumpToTop(const size_t index) +{ +if (index > 0) +{ +Payload payload(_queue[index]); +//LOG_WRN("Bumping: " << std::string(payload.data(), payload.size())); + +_queue.erase(_queue.begin() + index); +_queue.insert(_queue.begin(), payload); } } +void TileQueue::updateTimestamps(const bool isTile) +{ +if (isTile) +{ +_lastGetTile = true; +_lastTileGetTime = std::chrono::steady_clock::now(); +} +else if (_lastGetTile) +{ +// Update non-tile timestamp when switching from tiles. +_lastGetTile = false; +_lastGetTime = std::chrono::steady_clock::now(); +} +} + +bool TileQueue::shouldPreferTiles() const +{ +if (_lastGetTile) +{ +// If we had just done a tile, do something else. +LOG_TRC("Last was tile, doing non-tiles."); +return false; +} + +// Check how long it's been since we'd done tiles. +const auto tileDuration = (_lastGetTime - _lastTileGetTime); +const auto tileDurationMs = std::chrono::duration_cast(tileDuration).count(); +const auto duration = (std::chrono::steady_clock::now() - _lastGetTime); +const auto durationMs = std::chrono::duration_cast(duration).count(); +LOG_TRC("Tile duration: " << tileDurationMs << "ms, nonTile duration: " << durationMs << "ms."); + +if (durationMs > MaxTileSkipDurationMs) +{ +LOG_TRC("Capping non-tiles to 100ms. Prefer tiles now."); +return true; +} + +if (durationMs > tileDurationMs) +{ +LOG_TRC("Capping non-tiles to tileDurationMs (" << tileDurationMs << "). Prefer tiles now."); +return true; +} + +// We can still do some more non-tiles. +LOG_TRC("Have time for more non-tiles."); +return false; +} + MessageQueue::Payload TileQueue::get_impl() { -const auto front =
[Libreoffice-commits] online.git: kit/ChildSession.cpp wsd/TileCache.cpp
kit/ChildSession.cpp |5 + wsd/TileCache.cpp|2 +- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit 283cf812dedac64a63ed24e032ad3fc315bdda03 Author: Ashod NakashianDate: Tue Nov 29 22:59:47 2016 -0500 loolwsd: Writer doesn't have parts Fixup the part for EMPTY invalidation as well. N.B. Should replace 'EMPTY' with '0,0,INT_MAX,INT_MAX' to be consistent. Since both are expected, no compat issues should be expected. Change-Id: I066981622b1de71e9e849530df0583291b74b804 Reviewed-on: https://gerrit.libreoffice.org/31393 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp index b729b48..038a649 100644 --- a/kit/ChildSession.cpp +++ b/kit/ChildSession.cpp @@ -1061,6 +1061,11 @@ void ChildSession::loKitCallback(const int nType, const std::string& rPayload) " width=" + std::to_string(width) + " height=" + std::to_string(height)); } +else if (tokens.count() == 2 && tokens[0] == "EMPTY") +{ +const std::string part = (_docType != "text" ? tokens[1].c_str() : "0"); // Writer renders everything as part 0. +sendTextFrame("invalidatetiles: EMPTY, " + part); +} else { sendTextFrame("invalidatetiles: " + rPayload); diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp index 0ce257f..a6f0b7f 100644 --- a/wsd/TileCache.cpp +++ b/wsd/TileCache.cpp @@ -376,7 +376,7 @@ void TileCache::invalidateTiles(const std::string& tiles) } } -Log::error("Unexpected invalidatetiles request: " + tiles); +LOG_ERR("Unexpected invalidatetiles request [" << tiles << "]."); } void TileCache::removeFile(const std::string& fileName) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103975] FILEOPEN: DOCX: Incorrect page break moves content to page 2
https://bugs.documentfoundation.org/show_bug.cgi?id=103975 --- Comment #11 from Commit Notification--- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4307a850a310c0371bee1f79a8eb41fa8ff7fed2 tdf#103975 docx import: don't lose column break #2 It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakD.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx |7 +++ writerfilter/source/dmapper/DomainMapper.cxx |5 +++-- 3 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 4307a850a310c0371bee1f79a8eb41fa8ff7fed2 Author: Justin LuthDate: Tue Nov 29 08:15:40 2016 +0300 tdf#103975 docx import: don't lose column break #2 Change-Id: I871e10d675d9009c163dd2b0fc74d29206934e34 Reviewed-on: https://gerrit.libreoffice.org/31342 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakD.docx b/sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakD.docx new file mode 100755 index 000..37c7524 Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf103975_notPageBreakD.docx differ diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx index 78845fd..4fd658d 100644 --- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx +++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx @@ -130,6 +130,13 @@ DECLARE_SW_IMPORT_TEST(testMathMalformedXml, "math-malformed_xml.docx", FailTest CPPUNIT_ASSERT(!mxComponent.is()); } +DECLARE_OOXMLIMPORT_TEST(testTdf103975_notPageBreakD, "tdf103975_notPageBreakD.docx") +{ +// The problem was that the column break was moving outside of the columns, making a page break. +CPPUNIT_ASSERT_EQUAL(style::BreakType_COLUMN_BEFORE, getProperty(getParagraph(2), "BreakType")); +CPPUNIT_ASSERT_EQUAL( 1, getPages() ); +} + DECLARE_OOXMLIMPORT_TEST(testTdf103975_notPageBreakE, "tdf103975_notPageBreakE.docx") { // The problem was that the column break was getting lost. diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index aa279d6..439ecf2 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -3252,8 +3252,10 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, size_t len) m_pImpl->m_bIgnoreNextPara = false; return; } + +const bool bSingleParagraph = m_pImpl->GetIsFirstParagraphInSection() && m_pImpl->GetIsLastParagraphInSection(); PropertyMapPtr pContext = m_pImpl->GetTopContextOfType(CONTEXT_PARAGRAPH); -if (pContext && m_pImpl->GetSettingsTable()->GetSplitPgBreakAndParaMark()) +if (pContext && (m_pImpl->GetSettingsTable()->GetSplitPgBreakAndParaMark() || bSingleParagraph)) { if (m_pImpl->isBreakDeferred(PAGE_BREAK)) pContext->Insert(PROP_BREAK_TYPE, uno::makeAny(style::BreakType_PAGE_BEFORE)); @@ -3271,7 +3273,6 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, size_t len) m_pImpl->clearDeferredBreaks(); } -bool bSingleParagraph = m_pImpl->GetIsFirstParagraphInSection() && m_pImpl->GetIsLastParagraphInSection(); // If the paragraph contains only the section properties and it has // no runs, we should not create a paragraph for it in Writer, unless that would remove the whole section. bool bRemove = !m_pImpl->GetParaChanged() && m_pImpl->GetParaSectpr() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - kit/ChildSession.cpp
kit/ChildSession.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 64a8e7532124cb17a47bfa204fab5b0113737ac9 Author: Ashod NakashianDate: Tue Nov 29 23:13:24 2016 -0500 loolwsd: missing else Change-Id: I37458f0a8f13764fdd4010dfd38616dd6c15eac0 diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp index 755e593..e12f5e3 100644 --- a/kit/ChildSession.cpp +++ b/kit/ChildSession.cpp @@ -1053,7 +1053,7 @@ void ChildSession::loKitCallback(const int nType, const std::string& rPayload) " width=" + std::to_string(width) + " height=" + std::to_string(height)); } -if (tokens.count() == 2 && tokens[0] == "EMPTY") +else if (tokens.count() == 2 && tokens[0] == "EMPTY") { const std::string part = (_docType != "text" ? tokens[1].c_str() : "0"); // Writer renders everything as part 0. sendTextFrame("invalidatetiles: EMPTY, " + part); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - kit/ChildSession.cpp
kit/ChildSession.cpp |5 + 1 file changed, 5 insertions(+) New commits: commit 12d6db8a3dcc83cfdddb20893f2ca165a448 Author: Ashod NakashianDate: Tue Nov 29 22:59:47 2016 -0500 loolwsd: Writer doesn't have parts Fixup the part for EMPTY invalidation as well. N.B. Should replace 'EMPTY' with '0,0,INT_MAX,INT_MAX' to be consistent. Since both are expected, no compat issues should be expected. Change-Id: I066981622b1de71e9e849530df0583291b74b804 Reviewed-on: https://gerrit.libreoffice.org/31392 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp index 65868cf..755e593 100644 --- a/kit/ChildSession.cpp +++ b/kit/ChildSession.cpp @@ -1053,6 +1053,11 @@ void ChildSession::loKitCallback(const int nType, const std::string& rPayload) " width=" + std::to_string(width) + " height=" + std::to_string(height)); } +if (tokens.count() == 2 && tokens[0] == "EMPTY") +{ +const std::string part = (_docType != "text" ? tokens[1].c_str() : "0"); // Writer renders everything as part 0. +sendTextFrame("invalidatetiles: EMPTY, " + part); +} else { sendTextFrame("invalidatetiles: " + rPayload); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - 2 commits - common/IoUtil.cpp kit/ForKit.cpp
common/IoUtil.cpp |2 ++ kit/ForKit.cpp|4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit 7e5d83f41c42e8deac48f0dcff54768ec9cfc87f Author: Ashod NakashianDate: Mon Nov 28 20:34:18 2016 -0500 loolwsd: terminate forkit when wsd dies When we the pipe with wsd is closed we assume wsd has died and we terminate too. WSD can fork us anew, if it's still alive. Change-Id: I669ed717db973b50498a6bc08e1fca59c6563443 Reviewed-on: https://gerrit.libreoffice.org/31337 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian (cherry picked from commit 7a4250b90e4273f73ab5ab94c35728aeba9f0d63) diff --git a/common/IoUtil.cpp b/common/IoUtil.cpp index 6fea0b4..32238f3 100644 --- a/common/IoUtil.cpp +++ b/common/IoUtil.cpp @@ -329,6 +329,7 @@ int PipeReader::readLine(std::string& line, } else if (pipe.revents & (POLLERR | POLLHUP | POLLNVAL)) { +LOG_FTL("Pipe closed."); return -1; } } diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp index 4680c4d..b727817 100644 --- a/kit/ForKit.cpp +++ b/kit/ForKit.cpp @@ -75,9 +75,9 @@ public: if (ready <= 0) { // Termination is done via SIGTERM, which breaks the wait. -if (TerminationFlag) +if (ready < 0) { -if (ready < 0) +if (TerminationFlag) { LOG_INF("Poll interrupted in " << getName() << " and Termination flag set."); } commit 644eeafa013b031d33b764233b75a517a48d8e9b Author: Ashod Nakashian Date: Mon Nov 28 21:38:34 2016 -0500 Revert "IoUtil: remove never read write of 'n'" Setting 'n = -1;' helps to detect where the failure happened when receiveFrame throws. At the bottom of the function we log partially processed data by checking n (among others). This reverts commit 752372a2b022ad4a450df61bcc58c978840b9b37. Change-Id: I3294329c3d95b38d72c3fc824ab2eb7f2339adee Reviewed-on: https://gerrit.libreoffice.org/31339 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian (cherry picked from commit 21b1287444fc483adb8561243497ef466cd53fa9) diff --git a/common/IoUtil.cpp b/common/IoUtil.cpp index 2ee9c84..6fea0b4 100644 --- a/common/IoUtil.cpp +++ b/common/IoUtil.cpp @@ -79,6 +79,7 @@ void SocketProcessor(const std::shared_ptr& ws, try { payload.resize(payload.capacity()); +n = -1; // In case receiveFrame throws we log dropped data. n = ws->receiveFrame(payload.data(), payload.size(), flags); payload.resize(std::max(n, 0)); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 67254] Macros: Apostrophe (comment indicator) does not cancel underscore (split line) at the end of the line
https://bugs.documentfoundation.org/show_bug.cgi?id=67254 --- Comment #7 from Pierre Lepage--- In LO 5.2.3.3, I could not reproduce the bug. In addition, "ActiveWindow" is a method specific to MS-VBA. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97597] FILEOPEN: XLSX file on server opens with some blank tab pages (workaround: export MAX_CONCURRENCY=1)
https://bugs.documentfoundation.org/show_bug.cgi?id=97597 --- Comment #21 from k...@mroffice.org --- (In reply to Kohei Yoshida from comment #20) > (In reply to kees from comment #13) > > Created attachment 127421 [details] > > Example file: four tabsheets are missing data > > I'm guessing this file was saved *after* the data loss had occurred. > Ideally we need a file that contains all the data prior to the data loss so > that we can try and see if the data loss occurs... > > If that's not possible, we'll first have to start by creating such a test > file first. Correct. I dont have the original version anymore, but from my experience it will work with any xlsx, as long as it has a fair number of tabs (say >=15) and it will take a bit of time to open the file (say >= 4 seconds). It will still work even with this file - just duplicate some tabsheets if the file opens too fast for the problem to occur. By the way, we have now set MAX_CONCURRENCY=1 on all our workstations, and the problem has completely gone away. We have lifted the ban on opening xlsx over the network. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97597] FILEOPEN: XLSX file on server opens with some blank tab pages (workaround: export MAX_CONCURRENCY=1)
https://bugs.documentfoundation.org/show_bug.cgi?id=97597 --- Comment #20 from Kohei Yoshida--- (In reply to kees from comment #13) > Created attachment 127421 [details] > Example file: four tabsheets are missing data I'm guessing this file was saved *after* the data loss had occurred. Ideally we need a file that contains all the data prior to the data loss so that we can try and see if the data loss occurs... If that's not possible, we'll first have to start by creating such a test file first. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Atishay Jain License statement
I, Atishay Jain, hereby declare that all of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 104254] FILEOPEN DOCX image in header overlaps header text
https://bugs.documentfoundation.org/show_bug.cgi?id=104254 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Confirmed in Version: 5.4.0.0.alpha0+ Build ID: ef0e1c05c32a5a69502e0f0d1d97789c125345a2 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group - Version: 4.5.0.0.alpha0+ Build ID: 2851ce5afd0f37764cbbc2c2a9a63c7adc844311 Locale: ca_ES -Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76474] Other: Math formula
https://bugs.documentfoundation.org/show_bug.cgi?id=76474 Alexander Pchanged: What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- --- Comment #9 from Alexander P --- Apologies, I read the message and yet I managed to set it to RESOLVED - FIXED… Changing back to NEW. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/node.hxx| 26 +- starmath/source/node.cxx | 24 2 files changed, 25 insertions(+), 25 deletions(-) New commits: commit d53262282aed31819aa1ce9f608d5edba658dae4 Author: Takeshi AbeDate: Tue Nov 29 19:05:00 2016 +0900 starmath: Prefix members of SmSpecialNode etc. Change-Id: I7a1ac67f5fb3066b16b59a3a8277952d66572fb6 Reviewed-on: https://gerrit.libreoffice.org/31353 Tested-by: Jenkins Reviewed-by: Takeshi Abe diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx index 9ad19f1..52532c9 100644 --- a/starmath/inc/node.hxx +++ b/starmath/inc/node.hxx @@ -442,7 +442,7 @@ public: */ class SmSpecialNode : public SmTextNode { -boolbIsFromGreekSymbolSet; +bool mbIsFromGreekSymbolSet; protected: SmSpecialNode(SmNodeType eNodeType, const SmToken , sal_uInt16 _nFontDesc); @@ -528,16 +528,16 @@ public: */ class SmRootSymbolNode : public SmMathSymbolNode { -sal_uLong nBodyWidth; // width of body (argument) of root sign +sal_uLong mnBodyWidth; // width of body (argument) of root sign public: explicit SmRootSymbolNode(const SmToken ) : SmMathSymbolNode(NROOTSYMBOL, rNodeToken) -, nBodyWidth(0) +, mnBodyWidth(0) { } -sal_uLong GetBodyWidth() const {return nBodyWidth;}; +sal_uLong GetBodyWidth() const {return mnBodyWidth;}; virtual void AdaptToX(OutputDevice , sal_uLong nHeight) override; virtual void AdaptToY(OutputDevice , sal_uLong nHeight) override; @@ -595,11 +595,11 @@ public: */ class SmTableNode : public SmStructureNode { -long nFormulaBaseline; +long mnFormulaBaseline; public: explicit SmTableNode(const SmToken ) : SmStructureNode(NTABLE, rNodeToken) -, nFormulaBaseline(0) +, mnFormulaBaseline(0) { } @@ -619,24 +619,24 @@ public: */ class SmLineNode : public SmStructureNode { -bool bUseExtraSpaces; +bool mbUseExtraSpaces; protected: SmLineNode(SmNodeType eNodeType, const SmToken ) -: SmStructureNode(eNodeType, rNodeToken) +: SmStructureNode(eNodeType, rNodeToken) +, mbUseExtraSpaces(true) { -bUseExtraSpaces = true; } public: explicit SmLineNode(const SmToken ) -: SmStructureNode(NLINE, rNodeToken) +: SmStructureNode(NLINE, rNodeToken) +, mbUseExtraSpaces(true) { -bUseExtraSpaces = true; } -void SetUseExtraSpaces(bool bVal) { bUseExtraSpaces = bVal; } -bool IsUseExtraSpaces() const { return bUseExtraSpaces; }; +void SetUseExtraSpaces(bool bVal) { mbUseExtraSpaces = bVal; } +bool IsUseExtraSpaces() const { return mbUseExtraSpaces; }; virtual void Prepare(const SmFormat , const SmDocShell ) override; virtual void Arrange(OutputDevice , const SmFormat ) override; diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx index 11ff7bc..4ca990f 100644 --- a/starmath/source/node.cxx +++ b/starmath/source/node.cxx @@ -526,7 +526,7 @@ void SmTableNode::Arrange(OutputDevice , const SmFormat ) } // #i972# if (HasBaseline()) -nFormulaBaseline = GetBaseline(); +mnFormulaBaseline = GetBaseline(); else { SmTmpDevice aTmpDev (rDev, true); @@ -534,10 +534,10 @@ void SmTableNode::Arrange(OutputDevice , const SmFormat ) SmRect aRect = (SmRect(aTmpDev, , OUString("a"), GetFont().GetBorderWidth())); -nFormulaBaseline = GetAlignM(); +mnFormulaBaseline = GetAlignM(); // move from middle position by constant - distance // between middle and baseline for single letter -nFormulaBaseline += aRect.GetBaseline() - aRect.GetAlignM(); +mnFormulaBaseline += aRect.GetBaseline() - aRect.GetAlignM(); } } @@ -549,7 +549,7 @@ const SmNode * SmTableNode::GetLeftMost() const long SmTableNode::GetFormulaBaseline() const { -return nFormulaBaseline; +return mnFormulaBaseline; } @@ -1981,7 +1981,7 @@ void SmPolyLineNode::Arrange(OutputDevice , const SmFormat ) void SmRootSymbolNode::AdaptToX(OutputDevice &/*rDev*/, sal_uLong nWidth) { -nBodyWidth = nWidth; +mnBodyWidth = nWidth; } @@ -2582,17 +2582,17 @@ static bool lcl_IsFromGreekSymbolSet( const OUString ) } -SmSpecialNode::SmSpecialNode(SmNodeType eNodeType, const SmToken , sal_uInt16 _nFontDesc) : -SmTextNode(eNodeType, rNodeToken, _nFontDesc) +SmSpecialNode::SmSpecialNode(SmNodeType eNodeType, const SmToken , sal_uInt16 _nFontDesc) +: SmTextNode(eNodeType, rNodeToken, _nFontDesc) +, mbIsFromGreekSymbolSet(lcl_IsFromGreekSymbolSet( rNodeToken.aText )) { -bIsFromGreekSymbolSet = lcl_IsFromGreekSymbolSet( rNodeToken.aText ); } -SmSpecialNode::SmSpecialNode(const SmToken ) : -SmTextNode(NSPECIAL, rNodeToken,
[Libreoffice-bugs] [Bug 104267] an enhancement for the tables and cells
https://bugs.documentfoundation.org/show_bug.cgi?id=104267 Xisco Faulíchanged: What|Removed |Added CC||xiscofa...@libreoffice.org Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104076] FILESAVE: Slides with Color Effects Corrupted on when saved as PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=104076 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #6 from Xisco Faulí --- Confirmed in - Confirmed in Version: 5.4.0.0.alpha0+ Build ID: ef0e1c05c32a5a69502e0f0d1d97789c125345a2 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group - Version: 4.5.0.0.alpha0+ Build ID: 2851ce5afd0f37764cbbc2c2a9a63c7adc844311 Locale: ca_ES -Version: 4.3.0.0.alpha1+ Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 Bug 101912 depends on bug 71409, which changed state. Bug 71409 Summary: Excessive duplicate accessible focused events for Calc input line [a11y] https://bugs.documentfoundation.org/show_bug.cgi?id=71409 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104257] FILEOPEN DOCX: Wordart shadow is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=104257 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Confirmed in Version: 5.4.0.0.alpha0+ Build ID: ef0e1c05c32a5a69502e0f0d1d97789c125345a2 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104265] Crash in: ImpEditEngine::GetI18NScriptType(EditPaM const &, long *)
https://bugs.documentfoundation.org/show_bug.cgi?id=104265 --- Comment #1 from trogdoo...@gmail.com--- Happened in the same Office session as Bug 104266. So more specifically. I had 3-4 separate Impress windows open. Each window had open a separate .pptx file on them, I was swiftly going through all documents looking for something in particular. I searched one-by-one through each Impress window looking for a keyword using the Ctrl+F function to search for it. The program seemed to always crash just after I pressed the "next" button in the search bar (ctrl+F). It was never the first time though, usually at a random after I've had the program open for a time and I pressed "next" several times to search through the document. When the program did crash, all 4 windows would crash at once. I'm pretty sure I did not have any other open office products open at the time. I was simultaneously using firefox though, if that means anything. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputhdl.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 9ba24ac54100a5af6ecdde479ebeb5c916e6fad2 Author: Kohei YoshidaDate: Tue Nov 29 16:51:26 2016 -0500 tdf#71409: always create edit engine instance for the input window. In order to properly manage accessibility events esp when no letters are typed. Without this, doing things like: 1) hit F2 to active cell edit, 2) hit ESC to deactivate, 3) go back to 1) and repeat the cycle several times, 4) hit Shift-Ctrl-F2 to activate the top input window would result in duplicated accessibility events fired, the number of which depends on how many times the above step was repeated. Change-Id: I116fdcbc63cbe9d33039d38a47770a6813c4e523 Reviewed-on: https://gerrit.libreoffice.org/31389 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 1264eb9..d4e0a71 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -1894,8 +1894,14 @@ void ScInputHandler::UpdateActiveView() } } -if (pInputWin && eMode == SC_INPUT_TOP ) +if (pInputWin) +{ +// tdf#71409: Always create the edit engine instance for the input +// window, in order to properly manage accessibility events. pTopView = pInputWin->GetEditView(); +if (eMode != SC_INPUT_TOP) +pTopView = nullptr; +} else pTopView = nullptr; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 76474] Other: Math formula
https://bugs.documentfoundation.org/show_bug.cgi?id=76474 Alexander Pchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Alexander P --- I am currently using LO 5.2.3.3 on Fedora 25 and I can no longer reproduce the bug with either vectors or wide vectors. I have also tried ~20 different fonts. Marking as FIXED. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104266] Crash in: SfxItemSet::Get(unsigned short, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=104266 trogdoo...@gmail.comchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104266] Crash in: SfxItemSet::Get(unsigned short, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=104266 --- Comment #2 from trogdoo...@gmail.com--- So more specifically. I had 3-4 separate Impress windows open. Each window had open a separate .pptx file on them, I was swiftly going through all documents looking for something in particular. I searched one-by-one through each Impress window looking for a keyword using the Ctrl+F function to search for it. The program seemed to always crash just after I pressed the "next" button in the search bar (ctrl+F). It was never the first time though, usually at a random after I've had the program open for a time and I pressed "next" several times to search through the document. When the program did crash, all 4 windows would crash at once. I'm pretty sure I did not have any other open office products open at the time. I was simultaneously using firefox though, if that means anything. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75556] BASIC: LibreOffice Basic's 'Error' function does not return message which corresponds to the error code.
https://bugs.documentfoundation.org/show_bug.cgi?id=75556 --- Comment #8 from Pierre Lepage--- There is no bug in the BASIC engine. In the example cited, add "Option Explicit" to generate an error in the interpretation phase. At this point, "Erl()" is initialized correctly with the number of the line and "Error()" contains the correct message and Err() contains the correct BASIC error number. Without "Option Explicit", Erl(), Error() and Err() are respectively 0, "" and 0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/functions/fods/min.fods | 5423 1 file changed, 5423 insertions(+) New commits: commit f9578922d8dea4dcd411dfe39ddde417800b66c4 Author: ZdenÄk CrhonekDate: Tue Nov 29 18:38:35 2016 +0100 add MIN test case Change-Id: Idcfbfa43736e64c7270ccaf9766f25346e1e1b7e Reviewed-on: https://gerrit.libreoffice.org/31384 Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/sc/qa/unit/data/functions/fods/min.fods b/sc/qa/unit/data/functions/fods/min.fods new file mode 100644 index 000..86866db --- /dev/null +++ b/sc/qa/unit/data/functions/fods/min.fods @@ -0,0 +1,5423 @@ + + +http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:form x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.spreadsheet"> + 2016-07-24T08:15:55.36200P0D1LibreOfficeDev/5.3.0.0.alpha1$Linux_X86_64 LibreOffice_project/883024d657fb45c7da459017d2f936aac5644bfb + + + 0 + 0 + 120104 + 17092 + + + view1 + + + 2 + 8 + 0 + 0 + 0 + 0 + 2 + 0 + 0 + 0 + 0 + 0 + 75 + 60 + true + false + + + 4 + 14 + 0 + 0 + 0 + 0 + 2 + 0 + 0 + 0 + 0 + 0 + 75 + 60 + true + false + + + Sheet2 + 1241 + 0 + 75 + 60 + false + true + true + true + 12632256 + true + true + true + true + true + false + false + 1270 + 1270 + 1 + 1 + true + false + + + + + 7 + false + false + true + true + false + false + false + 1270 + 1270 + true + true + true + true + true + false + 12632256 + false + Lexmark-E352dn + + + cs + CZ + + + + + + de + DE + + + + + + en + US + + + + + + nl + NL + + + + + + true + true + 3 + 1 + true + 1 + true + lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg== + false + 0 + + + + + http://openoffice.org/2004/office; xmlns:xlink="http://www.w3.org/1999/xlink;> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + KÄ + + + + - + + + KÄ + + + + + + + + + + ( + + ) + + + + - + + + + + + + + + + + + + + + + + + + + KÄ + + + - + + + KÄ + + + + + +
[Libreoffice-commits] online.git: kit/ChildSession.cpp
kit/ChildSession.cpp | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) New commits: commit 4366d6aad4d369cc15a50b07c128cc8897a16d88 Author: Henry CastroDate: Tue Nov 29 20:22:23 2016 -0400 kit: render font failure if and only if fails encode PNG diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp index 65868cf..b729b48 100644 --- a/kit/ChildSession.cpp +++ b/kit/ChildSession.cpp @@ -359,6 +359,7 @@ bool ChildSession::loadDocument(const char * /*buffer*/, int /*length*/, StringT bool ChildSession::sendFontRendering(const char* /*buffer*/, int /*length*/, StringTokenizer& tokens) { std::string font, text, decodedFont, decodedChar; +bool bSuccess; if (tokens.count() < 3 || !getTokenString(tokens[1], "font", font)) @@ -401,15 +402,22 @@ bool ChildSession::sendFontRendering(const char* /*buffer*/, int /*length*/, Str LOG_TRC("renderFont [" << font << "] rendered in " << (timestamp.elapsed()/1000.) << "ms"); -if (!ptrFont || -!png::encodeBufferToPNG(ptrFont, width, height, output, LOK_TILEMODE_RGBA)) +if (!ptrFont) { -std::free(ptrFont); -return sendTextFrame("error: cmd=renderfont kind=failure"); +return sendTextFrame(output.data(), output.size()); +} + +if (png::encodeBufferToPNG(ptrFont, width, height, output, LOK_TILEMODE_RGBA)) +{ +bSuccess = sendTextFrame(output.data(), output.size()); +} +else +{ +bSuccess = sendTextFrame("error: cmd=renderfont kind=failure"); } std::free(ptrFont); -return sendTextFrame(output.data(), output.size()); +return bSuccess; } bool ChildSession::getStatus(const char* /*buffer*/, int /*length*/) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 101216] [META] Comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Aron Budeachanged: What|Removed |Added Depends on||104270 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104270 [Bug 104270] COMMENTING: Inserting a Comment at the end of paragraph causes it's termination symbol to shift right -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104270] COMMENTING: Inserting a Comment at the end of paragraph causes it' s termination symbol to shift right
https://bugs.documentfoundation.org/show_bug.cgi?id=104270 Aron Budeachanged: What|Removed |Added Priority|medium |low Status|UNCONFIRMED |NEW Version|5.1.4.2 release |5.1.0.3 release Keywords||bibisectRequest, regression CC||ba...@caesar.elte.hu Blocks||101216 Ever confirmed|0 |1 Severity|normal |trivial --- Comment #2 from Aron Budea --- Confirmed with 5.1.0.3 and 5.2.3.3 / Windows 7. Doesn't happen in 5.0.0.5. => regression Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101216 [Bug 101216] [META] Comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - desktop/source
desktop/source/lib/init.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 9985226ec803fa7e714eb10ec4a96a0fe6064e98 Author: Henry CastroDate: Tue Nov 29 17:19:00 2016 -0400 lok: ensure positive values for width and height also check the pointer memory block allocated Change-Id: I0ded04e06f80400e64c5e58126a32ee503aeb394 Reviewed-on: https://gerrit.libreoffice.org/31388 Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index c36ddd6..3bbf88b 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2580,8 +2580,13 @@ unsigned char* doc_renderFont(LibreOfficeKitDocument* /*pThis*/, *pFontWidth = nFontWidth; int nFontHeight = aRect.BottomRight().Y() + 1; *pFontHeight = nFontHeight; +if (!(nFontWidth > 0 && nFontHeight > 0)) +break; unsigned char* pBuffer = static_cast(malloc(4 * nFontWidth * nFontHeight)); +if (!pBuffer) +break; + memset(pBuffer, 0, nFontWidth * nFontHeight * 4); boost::shared_array aBuffer(pBuffer, NoDelete< sal_uInt8 >()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 98608] [LOCALHELP] Starmath: Update help page with right icons of new Elements left pane
https://bugs.documentfoundation.org/show_bug.cgi?id=98608 Gabor Kelemenchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104270] COMMENTING: Inserting a Comment at the end of paragraph causes it' s termination symbol to shift right
https://bugs.documentfoundation.org/show_bug.cgi?id=104270 --- Comment #1 from Gabriele Ponzo--- Created attachment 129145 --> https://bugs.documentfoundation.org/attachment.cgi?id=129145=edit EndOfParagraph symbol shifted on the right See attachment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 098fb95772b3184bb81180d1bc30c9753d30e2b6 Author: Henry CastroDate: Tue Nov 29 17:19:00 2016 -0400 lok: ensure positive values for width and height also check the pointer memory block allocated Change-Id: I0ded04e06f80400e64c5e58126a32ee503aeb394 Reviewed-on: https://gerrit.libreoffice.org/31388 Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index fa3446e..fe73f17 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2592,8 +2592,13 @@ unsigned char* doc_renderFont(LibreOfficeKitDocument* /*pThis*/, *pFontWidth = nFontWidth; int nFontHeight = aRect.BottomRight().Y() + 1; *pFontHeight = nFontHeight; +if (!(nFontWidth > 0 && nFontHeight > 0)) +break; unsigned char* pBuffer = static_cast(malloc(4 * nFontWidth * nFontHeight)); +if (!pBuffer) +break; + memset(pBuffer, 0, nFontWidth * nFontHeight * 4); aDevice->SetBackground(Wallpaper(COL_TRANSPARENT)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 104142] Hard to pick a line with an image in its background because of "grab hand " cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=104142 s.p.he...@gmx.net changed: What|Removed |Added CC||s.p.he...@gmx.net --- Comment #2 from s.p.he...@gmx.net --- Thank you for the link to the previous report. I missed that one! The workaround is really a bit clumsy. And if you forgot to name the element it, you run into very same problem. I can think of two possible improvements: 1. Make the pick cursor the arrow and not the grab hand. Change the cursor to the grab hand only if the main mouse button is clicked to show that the object can be moved now. 2. Highlight the object under the cursor. I believe that option 2 is the better one. It also follows current practice in CAD programs. Maybe it's also possible to combine 1 and 2? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 104142] Hard to pick a line with an image in its background because of "grab hand " cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=104142 s.p.he...@gmx.net changed: What|Removed |Added CC||s.p.he...@gmx.net --- Comment #2 from s.p.he...@gmx.net --- Thank you for the link to the previous report. I missed that one! The workaround is really a bit clumsy. And if you forgot to name the element it, you run into very same problem. I can think of two possible improvements: 1. Make the pick cursor the arrow and not the grab hand. Change the cursor to the grab hand only if the main mouse button is clicked to show that the object can be moved now. 2. Highlight the object under the cursor. I believe that option 2 is the better one. It also follows current practice in CAD programs. Maybe it's also possible to combine 1 and 2? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104270] New: COMMENTING: Inserting a Comment at the end of paragraph causes it' s termination symbol to shift right
https://bugs.documentfoundation.org/show_bug.cgi?id=104270 Bug ID: 104270 Summary: COMMENTING: Inserting a Comment at the end of paragraph causes it's termination symbol to shift right Product: LibreOffice Version: 5.1.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gpo...@gmail.com Seen on 5.1.4.2x64 (build f99d75f39f1c57ebdd7ffc5f42867c12031db97a) Win10home and on Elementary Linux Freya 0.3 (Ubuntu 14.04): Version: 5.3.0.0.beta1 Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536 CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout Engine: new; Locale: it-IT (it_IT.UTF-8); Calc: group 1. in Writer type just a word 2. hit CTRL+F10 to enable unprintable symbols visibility 3. leaving keyboard's cursor at the end of paragraph hit CTRL+ALT+C to insert a comment OUTPUT: the mirrored P reporting the end of paragraph is shifted on the right. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101972] Widgets in dialogs are flickering while modifier key are being pressed ( default rendering)
https://bugs.documentfoundation.org/show_bug.cgi?id=101972 Aron Budeachanged: What|Removed |Added Summary|Holding A modifier key in |Widgets in dialogs are |Dialog Windows every widget |flickering while modifier |start flashing (refresh)|key are being pressed ||(default rendering) --- Comment #7 from Aron Budea --- (In reply to Gabriele Ponzo from comment #6) > So you can confirm my bug: what's the version of LO? I can reproduce this even in current 5.2.3.3 and 5.3beta1 versions in Windows 7. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91107] Cut/Copy/Paste/"Select All" are active while they shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=91107 --- Comment #5 from Gabriele Ponzo--- I can confirm same behavior in 5.3 x64 Elementary Linux Freya 0.3 (Ubuntu 14.04) I've also given xsel -bc but paste in Writer is still active (only in Edit Menu, NOT on std toolbar). >From the same menu, Select All is active even in a new blank document. Doing it doesn't activate paste on std toolbar (in menu it's always on). Version: 5.3.0.0.beta1 Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536 CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout Engine: new; Locale: it-IT (it_IT.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104250] FILEOPEN XLSX: password is not required for unlocking protected sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=104250 --- Comment #7 from m.a.riosv--- If it is protected with a blank password shows the same behaviour saving and opening with LO, but not with a minimal password. Are we sure it is protected with a not blank password? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101978] Some ComboBox ( more evident on ones with graphical objects inside) flashes (redraw) on hover
https://bugs.documentfoundation.org/show_bug.cgi?id=101978 --- Comment #10 from Gabriele Ponzo--- (In reply to Gabriele Ponzo from comment #9) > (In reply to Buovjaga from comment #5) > > Confirmed with the comboboxes/dropdown menus. > > Who should put in confirmed status then? > > Thanks. > > > The Save button flicker is not very noticeable. I see maybe 1 flicker at the > > start. > > > > Win 7 Pro 64-bit Version: 5.3.0.0.alpha0+ > > Build ID: 7da2f3ce9f7b049c177a735a146dae84a764d3f7 > > CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; > > TinderBox: Win-x86@42, Branch:master, Time: 2016-10-04_03:49:06 > > Locale: fi-FI (fi_FI); Calc: CL > > > > Version: 5.2.0.0.beta1 (x64) > > Build ID: 1e9933ef611c66bcded94b84052543c78cf1c223 > > CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; > > Locale: fi-FI (fi_FI) Sorry, it's late... please ignore my previous reply! It's already in NEW status... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101978] Some ComboBox ( more evident on ones with graphical objects inside) flashes (redraw) on hover
https://bugs.documentfoundation.org/show_bug.cgi?id=101978 --- Comment #9 from Gabriele Ponzo--- (In reply to Buovjaga from comment #5) > Confirmed with the comboboxes/dropdown menus. Who should put in confirmed status then? Thanks. > The Save button flicker is not very noticeable. I see maybe 1 flicker at the > start. > > Win 7 Pro 64-bit Version: 5.3.0.0.alpha0+ > Build ID: 7da2f3ce9f7b049c177a735a146dae84a764d3f7 > CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; > TinderBox: Win-x86@42, Branch:master, Time: 2016-10-04_03:49:06 > Locale: fi-FI (fi_FI); Calc: CL > > Version: 5.2.0.0.beta1 (x64) > Build ID: 1e9933ef611c66bcded94b84052543c78cf1c223 > CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; > Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104250] FILEOPEN XLSX: password is not required for unlocking protected sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=104250 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Version|4.1 all versions|Inherited From OOo --- Comment #6 from m.a.riosv --- It's an inherited from OOo issue reproducible with AOo 4.1.3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104252] Embedded EMF files in docx document shows text content on screen but not in print or export
https://bugs.documentfoundation.org/show_bug.cgi?id=104252 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #9 from m.a.riosv --- I can't reproduce with Version: 5.2.3.3 (x64) Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Locale: es-ES (es_ES); Calc: group neither Version: 5.3.0.0.alpha0+ (x64) Build ID: 170105956f843047d4c79657584f0c01aa7814c7 CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-08-19_17:41:46 Locale: es-ES (es_ES); Calc: group Only with 5.3, looks like an OpenGL issue with it disable show the problem but works fine with it enable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101972] Holding A modifier key in Dialog Windows every widget start flashing ( refresh)
https://bugs.documentfoundation.org/show_bug.cgi?id=101972 --- Comment #6 from Gabriele Ponzo--- (In reply to Aron Budea from comment #5) > If I go to image Properties (which takes me to Wrap tab by default): > -pressing Alt repeatedly causes "None" to flash, > -pressing Alt or Ctrl continuously causes flickering to run through all the > widgets. > > Even the menu bar is flickering if I run my mouse pointer across. > > No flickering in native Windows Open/Save/etc. dialogs, though. Opetions > menu doesn't flicker, either. So you can confirm my bug: what's the version of LO? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104268] Solver: Current Solution is always displayed with 2 decimals
https://bugs.documentfoundation.org/show_bug.cgi?id=104268 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Created attachment 129144 --> https://bugs.documentfoundation.org/attachment.cgi?id=129144=edit Screenshot with solver box and result Hi Lauren, I can't reproduce with: Version: 5.2.3.3 (x64) Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Locale: es-ES (es_ES); Calc: groupeproduce with result on A2: 0,0005 Default style has 'Standar' for numbers on my instalation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 560 -- vcl/source/gdi/pdfwriter_impl.hxx |3 2 files changed, 563 deletions(-) New commits: commit 70ecf1919e3e3b9509ff55b2265b3d98d2a5f1aa Author: Khaled HosnyDate: Tue Nov 29 11:51:23 2016 +0200 Dead code m_aEmbeddedFonts is always empty now. Change-Id: Ia0cdfbabff29722d51b92ed47e04ef40d71f65be Reviewed-on: https://gerrit.libreoffice.org/31373 Reviewed-by: Khaled Hosny Tested-by: Khaled Hosny diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index 12fe24d..30daf70 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -3046,555 +3046,6 @@ static bool getPfbSegmentLengths( const unsigned char* pFontBytes, int nByteLen, return true; } -struct FontException : public std::exception -{ -}; - -// TODO: always subset instead of embedding the full font => this method becomes obsolete then -std::map< sal_Int32, sal_Int32 > PDFWriterImpl::emitEmbeddedFont( const PhysicalFontFace* pFont, EmbedFont& rEmbed ) -{ -std::map< sal_Int32, sal_Int32 > aRet; - -sal_Int32 nStreamObject = 0; -sal_Int32 nFontDescriptor = 0; - -SalGraphics *pGraphics = m_pReferenceDevice->GetGraphics(); - -assert(pGraphics); - -// prepare font encoding -sal_Int32 nToUnicodeStream = 0; -sal_uInt8 nEncoding[256]; -sal_Ucs nEncodedCodes[256]; -std::vector aUnicodes; -aUnicodes.reserve( 256 ); -sal_Int32 pUnicodesPerGlyph[256]; -sal_Int32 pEncToUnicodeIndex[256]; - -FontSubsetInfo aInfo; -sal_Int32 pWidths[256]; -const unsigned char* pFontData = nullptr; -long nFontLen = 0; -sal_Int32 nLength1, nLength2; -try -{ -if( (pFontData = static_cast(pGraphics->GetEmbedFontData(pFont, nEncodedCodes, pWidths, 256, aInfo, ))) != nullptr ) -{ -if( (aInfo.m_nFontType & FontSubsetInfo::ANY_TYPE1) == 0 ) -throw FontException(); -// see whether it is pfb or pfa; if it is a pfb, fill ranges -// of 6 bytes that are not part of the font program -std::list< int > aSections; -std::list< int >::const_iterator it; -int nIndex = 0; -while( (nIndex < nFontLen-1) && pFontData[nIndex] == 0x80 ) -{ -aSections.push_back( nIndex ); -if( pFontData[nIndex+1] == 0x03 ) -break; -sal_Int32 nBytes = -((sal_Int32)pFontData[nIndex+2])| -((sal_Int32)pFontData[nIndex+3]) << 8 | -((sal_Int32)pFontData[nIndex+4]) << 16 | -((sal_Int32)pFontData[nIndex+5]) << 24; -nIndex += nBytes+6; -} - -// search for eexec -// TODO: use getPfbSegmentLengths() if possible to skip the search thingies below -nIndex = 0; -int nEndAsciiIndex; -int nBeginBinaryIndex; -int nEndBinaryIndex; -do -{ -while( nIndex < nFontLen-4 && -( pFontData[nIndex] != 'e' || -pFontData[nIndex+1] != 'e' || -pFontData[nIndex+2] != 'x' || -pFontData[nIndex+3] != 'e' || -pFontData[nIndex+4] != 'c' -) -) -{ -++nIndex; -} -// check whether we are in a excluded section -for( it = aSections.begin(); it != aSections.end() && (nIndex < *it || nIndex > ((*it) + 5) ); ++it ) -; -} while( it != aSections.end() && nIndex < nFontLen-4 ); -// this should end the ascii part -if( nIndex > nFontLen-5 ) -throw FontException(); - -nEndAsciiIndex = nIndex+4; -// now count backwards until we can account for 512 '0' -// which is the endmarker of the (hopefully) binary data -// do not count the pfb header sections -int nFound = 0; -nIndex = nFontLen-1; -while( nIndex > 0 && nFound < 512 ) -{ -for( it = aSections.begin(); it != aSections.end() && (nIndex < *it || nIndex > ((*it) + 5) ); ++it ) -; -if( it == aSections.end() ) -{ -// inside the 512 '0' block there may only be whitespace -// according to T1 spec; probably it would be to simple -// if all fonts complied -if( pFontData[nIndex] == '0' ) -nFound++; -else if( nFound > 0 && -
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win
vcl/headless/svptext.cxx | 10 +--- vcl/inc/headless/svpgdi.hxx |7 - vcl/inc/quartz/salgdi.h | 10 vcl/inc/salgdi.hxx | 14 +-- vcl/inc/textrender.hxx |9 --- vcl/inc/unx/cairotextrender.hxx |9 --- vcl/inc/unx/genpspgraphics.h | 11 +--- vcl/inc/unx/salgdi.h |9 --- vcl/inc/win/salgdi.h | 10 vcl/quartz/salgdi.cxx|7 - vcl/source/gdi/embeddedfontshelper.cxx |3 -- vcl/unx/generic/gdi/cairotextrender.cxx |4 +-- vcl/unx/generic/gdi/font.cxx |4 +-- vcl/unx/generic/print/genpspgraphics.cxx | 30 ++-- vcl/win/gdi/salfont.cxx | 38 --- 15 files changed, 22 insertions(+), 153 deletions(-) New commits: commit 2e0ab512592e2e134faf9612a293fb8fdd0527d0 Author: Khaled HosnyDate: Tue Nov 29 13:39:37 2016 +0200 Strip down GetEmbedFontData to what is really used The only remaining user is EmbeddedFontsHelper, and it just needs the raw font data. Change-Id: Ia15c59158b5c9e44d0936463553303a3c8b6e0f5 Reviewed-on: https://gerrit.libreoffice.org/31374 Tested-by: Jenkins Reviewed-by: Khaled Hosny diff --git a/vcl/headless/svptext.cxx b/vcl/headless/svptext.cxx index 2d44659..63a10f5 100644 --- a/vcl/headless/svptext.cxx +++ b/vcl/headless/svptext.cxx @@ -73,15 +73,9 @@ bool SvpSalGraphics::CreateFontSubset( return m_aTextRenderImpl.CreateFontSubset(rToFile, pFont, pGlyphIds, pEncoding, pWidths, nGlyphCount, rInfo); } -const void* SvpSalGraphics::GetEmbedFontData( -const PhysicalFontFace* pFont, -const sal_Ucs* pUnicodes, -sal_Int32* pWidths, -size_t nLen, -FontSubsetInfo& rInfo, -long* pDataLen) +const void* SvpSalGraphics::GetEmbedFontData(const PhysicalFontFace* pFont, long* pDataLen) { -return m_aTextRenderImpl.GetEmbedFontData(pFont, pUnicodes, pWidths, nLen, rInfo, pDataLen); +return m_aTextRenderImpl.GetEmbedFontData(pFont, pDataLen); } void SvpSalGraphics::FreeEmbedFontData( const void* pData, long nLen ) diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx index bcd4ac6..ad6e4bf 100644 --- a/vcl/inc/headless/svpgdi.hxx +++ b/vcl/inc/headless/svpgdi.hxx @@ -153,12 +153,7 @@ public: int nGlyphs, FontSubsetInfo& rInfo ) override; -virtual const void* GetEmbedFontData( const PhysicalFontFace*, - const sal_Ucs* pUnicodes, - sal_Int32* pWidths, - size_t nLen, - FontSubsetInfo& rInfo, - long* pDataLen ) override; +virtual const void* GetEmbedFontData(const PhysicalFontFace*, long* pDataLen) override; virtual voidFreeEmbedFontData( const void* pData, long nDataLen ) override; virtual voidGetGlyphWidths( const PhysicalFontFace*, bool bVertical, diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h index f752fd2..382641e 100644 --- a/vcl/inc/quartz/salgdi.h +++ b/vcl/inc/quartz/salgdi.h @@ -365,16 +365,8 @@ public: // GetEmbedFontData: gets the font data for a font marked // embeddable by GetDevFontList or NULL in case of error // parameters: pFont: describes the font in question -// pWidths: the widths of all glyphs from char code 0 to 255 -// pWidths MUST support at least 256 members; -// rInfo: additional outgoing information // pDataLen: out parameter, contains the byte length of the returned buffer -virtual const void* GetEmbedFontData( const PhysicalFontFace*, - const sal_Ucs* pUnicodes, - sal_Int32* pWidths, - size_t nLen, - FontSubsetInfo& rInfo, - long* pDataLen ) override; +virtual const void* GetEmbedFontData(const PhysicalFontFace*, long* pDataLen) override; // frees the font data again virtual voidFreeEmbedFontData( const void* pData, long nDataLen ) override; diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx index e7382be..13e5e71 100644 --- a/vcl/inc/salgdi.hxx +++ b/vcl/inc/salgdi.hxx @@ -175,23 +175,13 @@ public: // GetEmbedFontData: gets the font data for a font
[Libreoffice-bugs] [Bug 104076] FILESAVE: Slides with Color Effects Corrupted on when saved as PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=104076 Lukechanged: What|Removed |Added Summary|FILESAVE: Slides with |FILESAVE: Slides with Color |Effects Corrupted on when |Effects Corrupted on when |saved as PPTX |saved as PPTX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104076] FILESAVE: Slides with Effects Corrupted on when saved as PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=104076 --- Comment #5 from Luke--- Created attachment 129143 --> https://bugs.documentfoundation.org/attachment.cgi?id=129143=edit Fill Color, another broken Color Effect -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104076] FILESAVE: Slides with Effects Corrupted on when saved as PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=104076 --- Comment #4 from Luke--- Created attachment 129142 --> https://bugs.documentfoundation.org/attachment.cgi?id=129142=edit Color Pulse Effect (Flicker) Incorrectly Exported There seems to be a problem with our OOXML color description. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104076] FILESAVE: Slides with Effects Corrupted on when saved as PPTX
https://bugs.documentfoundation.org/show_bug.cgi?id=104076 --- Comment #3 from Luke--- Created attachment 129141 --> https://bugs.documentfoundation.org/attachment.cgi?id=129141=edit Pulse Effect (Flash Bulb) Correctly Exported -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win
vcl/headless/svptext.cxx |5 -- vcl/inc/headless/svpgdi.hxx |1 vcl/inc/quartz/salgdi.h |9 vcl/inc/salgdi.hxx | 12 -- vcl/inc/textrender.hxx |1 vcl/inc/unx/cairotextrender.hxx |1 vcl/inc/unx/genpspgraphics.h |3 - vcl/inc/unx/salgdi.h |2 - vcl/inc/win/salgdi.h |9 vcl/quartz/salgdi.cxx|7 --- vcl/source/gdi/pdfwriter_impl.cxx| 60 --- vcl/unx/generic/gdi/cairotextrender.cxx |5 -- vcl/unx/generic/gdi/font.cxx |5 -- vcl/unx/generic/print/genpspgraphics.cxx |5 -- vcl/win/gdi/salfont.cxx |5 -- 15 files changed, 1 insertion(+), 129 deletions(-) New commits: commit 1ee56fc9f446bad5853b121a3c5b137c1d00bbf4 Author: Khaled HosnyDate: Tue Nov 29 10:41:53 2016 +0200 SalGraphics::GetFontEncodingVector() is a noop now Change-Id: Id706fa242277a0ea7ba44f52eab4a56e404bd2fa Reviewed-on: https://gerrit.libreoffice.org/31372 Tested-by: Jenkins Reviewed-by: Khaled Hosny diff --git a/vcl/headless/svptext.cxx b/vcl/headless/svptext.cxx index 65c7d05..2d44659 100644 --- a/vcl/headless/svptext.cxx +++ b/vcl/headless/svptext.cxx @@ -73,11 +73,6 @@ bool SvpSalGraphics::CreateFontSubset( return m_aTextRenderImpl.CreateFontSubset(rToFile, pFont, pGlyphIds, pEncoding, pWidths, nGlyphCount, rInfo); } -const Ucs2SIntMap* SvpSalGraphics::GetFontEncodingVector( const PhysicalFontFace* pFont, const Ucs2OStrMap** pNonEncoded, std::set const** ppPriority) -{ -return m_aTextRenderImpl.GetFontEncodingVector(pFont, pNonEncoded, ppPriority); -} - const void* SvpSalGraphics::GetEmbedFontData( const PhysicalFontFace* pFont, const sal_Ucs* pUnicodes, diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx index a5440e2..bcd4ac6 100644 --- a/vcl/inc/headless/svpgdi.hxx +++ b/vcl/inc/headless/svpgdi.hxx @@ -153,7 +153,6 @@ public: int nGlyphs, FontSubsetInfo& rInfo ) override; -virtual const Ucs2SIntMap* GetFontEncodingVector( const PhysicalFontFace*, const Ucs2OStrMap** ppNonEncoded, std::set const** ) override; virtual const void* GetEmbedFontData( const PhysicalFontFace*, const sal_Ucs* pUnicodes, sal_Int32* pWidths, diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h index f6776b3..f752fd2 100644 --- a/vcl/inc/quartz/salgdi.h +++ b/vcl/inc/quartz/salgdi.h @@ -362,15 +362,6 @@ public: FontSubsetInfo& rInfo // out parameter ) override; -// GetFontEncodingVector: a method to get the encoding map Unicode -// to font encoded character; this is only used for type1 fonts and -// may return NULL in case of unknown encoding vector -// if ppNonEncoded is set and non encoded characters (that is type1 -// glyphs with only a name) exist it is set to the corresponding -// map for non encoded glyphs; the encoding vector contains -1 -// as encoding for these cases -virtual const Ucs2SIntMap* GetFontEncodingVector( const PhysicalFontFace*, const Ucs2OStrMap** ppNonEncoded, std::set const** ) override; - // GetEmbedFontData: gets the font data for a font marked // embeddable by GetDevFontList or NULL in case of error // parameters: pFont: describes the font in question diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx index 71a8442..e7382be 100644 --- a/vcl/inc/salgdi.hxx +++ b/vcl/inc/salgdi.hxx @@ -172,18 +172,6 @@ public: int nGlyphs, FontSubsetInfo& rInfo ) = 0; -// GetFontEncodingVector: a method to get the encoding map Unicode -// to font encoded character; this is only used for type1 fonts and -// may return NULL in case of unknown encoding vector -// if ppNonEncoded is set and non encoded characters (that is type1 -// glyphs with only a name) exist it is set to the corresponding -// map for non encoded glyphs; the encoding vector contains -1 -// as encoding for these cases -virtual const Ucs2SIntMap* GetFontEncodingVector( -const PhysicalFontFace*, -const Ucs2OStrMap** ppNonEncoded, -std::set const** ppPriority) = 0; - // GetEmbedFontData: gets the font data for a font marked // embeddable by GetDevFontList or NULL in case of error // parameters: pFont: describes the
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-5.2.4.1'
Tag 'libreoffice-5.2.4.1' created by Christian Lohmaierat 2016-11-29 22:31 + Tag libreoffice-5.2.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJYPgGlAAoJEPQ0oe+v7q6j/ZUQAIa++hA5+PObAQ1WE4A9BsFm WTOt4Z+jW+GblUSTyardLVhNtmm5BM2Z8ltGHGkqq9xKu63CtoA71bfnu2prSUmU QQZAQckEjFQ2lagxQklc0MNmsYBXo200/HBLoXZnJK9r3PUV3DP4LhRntH5KFqzy IH7lhREEb3oRrEBLJprLdjvGdAzVaHbp5IOz2xskp2h5g3IC7fbl3T5E3uCJGQxD ycUfn10YF1JU1YAduntv1bJSWo/DLnLrji+ba5FuzkW7rH/53pAqi+zyaEPf1A02 g2+LxjS5GQBsRBEYSTJUFICig6KIv/c+4eKlxlsa0xgoF6pxSjd0VY8qUeLZU6/3 bepp4HpR+XCs+aykZsZ4i/o7Uo2fqbfyBgPJarsw3XJQCeWZLWdbzuq1zoQ90VCf LSkmKgg3JHEVZifa9WhnL+SmdcbcWHb4KEnmxPPEHKegmu7KEAP/q6C002GaPSSZ rojoJCFqchtIGPWOaqLvPcLPSkdgsTy260Uvb9TaRK08mAmoSaSzogTVic1g+8Rk gs7QU/qMzksOa7GWqNGNntu5FcbKJr1kwSBUEBHGHVHA41DNvtAgYph3vIU6tYlY ZIL2QXQbJV7F12qXpNi8KvqOKGxXVARZj4Iuif852zRzj+qA8ZZC6Px+rH9nDy8i SEKxIPivrTi2xFuV9Crf =H1tc -END PGP SIGNATURE- Changes since cp-5.1-branch-point-22: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-5.2.4.1'
Tag 'libreoffice-5.2.4.1' created by Christian Lohmaierat 2016-11-29 22:31 + Tag libreoffice-5.2.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJYPgGoAAoJEPQ0oe+v7q6jaHIP/j51I5SKTvKj5XQjFDtHHXdW nMyJxqsyubrJQQA4yyHW15AGvmjzt7z1hKS5cEONZKCqWydsb5oUFuVd0xgLvsVr 4O9va9XRGaUvJNmZc4gmMDCe4pgTL3xNs54PTAWxWs6nXqpYS1pTGfun/rEgYt7t zzAePqiNOQHrLHs1mg08qnjz2cn7wj9EM3zPDJX1cn6dmUosOKXX+AzWpgry71Lx onmz8hoLAzG20hgkT3ZnDNOHxEX3WapIQ7fKdWwBaWcglIeIaMUMCIwvt1Bqoav0 oR02XJus4dB+ANquZ4N8GBctQdEY0miRglLh67V3RFmid6X0VNPh6JbXTl1e5bGm SL153tFfKhVMSX81dn6QNFT/QI7ykuolIsIpil5JMSZlLbwYpf/zyxOT3J9GHwwv JX9Po5vxtnERFc6kDnETCjbU2A5TeDAS2oB9psmCh+3LynO6OmC5KHaMNT2+AM+W JpmT7dZECzy+ILAXZwqa1Pshn43tZZ0FG0Vl9VgYlqzp4DAPwx/5WboRHk6yR8CT GG2VFQ6o8kUG0E8JHTcwx04oRTFPWTlECnnUm3nPvBCi8xXb+L+nbpyKIkbXpKSA XKkDr4M7NCYlabjQSHczymoZJ14kVfFPvvxXGsJDoipCiV1bhetrv/1RveA9hR3z c/BuhSNezPz+LmX0m2QP =hRyY -END PGP SIGNATURE- Changes since libreoffice-5-2-branch-point-833: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-4' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6991df819033bb51501f412709aa0add1930 Author: Christian LohmaierDate: Tue Nov 29 23:31:34 2016 +0100 bump product verion to 5.2.4.1.0+ Change-Id: I03ca7cbd2e6418d4f6199cf2852ce5789f7f8504 diff --git a/configure.ac b/configure.ac index 7b96f85f..aae5bb0 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.2.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.2.4.1.0+],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-5.2.4.1'
Tag 'libreoffice-5.2.4.1' created by Christian Lohmaierat 2016-11-29 22:30 + Tag libreoffice-5.2.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJYPgGiAAoJEPQ0oe+v7q6j/JEQANBfvA5O7XozzLi0j/GXw8qh Db7tfLMDjN4M6MT6Oa1YFQqe9FMg5xg0QaiQrsf63eyr/NvLWtGzBIa17v+2HxI1 eyHs8S7/H9RqFTG/0Wo5Z9S0uSPhdyvx5eKjlITaKdAPAGpqbjwwLX31HNLrNQqX qx7eUO2wXp7q/CkCD24YXCofW8hFwVMfMzZBLl2Nd0RroTDp88nXu9zTVqCZR+cF +EfJKWlS8nCuGYP/K08RvrjCTkby/8+UncaqPxZlz7phFEMCL3FyRMOCagBJSZbs Zwq7okQlGjFmT4p9vJTqbP0sedvR3wP49rMCJO21gx2upiRGbA3jCY///isSvB4q RFGYNnh0OChqW6ImfUUDVRKwTtyvfPIM5sjG1WyIBMsJH8f3pph1W9VoQQE6ZWPi 2fetUec5ejT+hlY8s1A1s9Yf0NgdyWgwYB3pcDn8Ex7R7MEKXZxYCte+XEgiNffN TtJMUAx3+1os1mpmKMnnzSU2neSqcSwxjGb9ytIW5tl4b98n15FuTQn+AtJkkpr/ arJ7W0VzGs2yR41tuAPop60rq1c4idMzGdpmV7qrT9QNhUx9rqwUbuxM+vqzn/wA 7woKtqjBEYLjm2ArSZ5L3/1HjlbdcbuQbowh7iHZgmFN608rCWldxzUC3YKdGGe3 rm5BZDrMpsw8RuKXtazt =I58H -END PGP SIGNATURE- Changes since libreoffice-5-2-branch-point-20: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-5.2.4.1'
Tag 'libreoffice-5.2.4.1' created by Christian Lohmaierat 2016-11-29 22:30 + Tag libreoffice-5.2.4.1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAABAgAGBQJYPgGfAAoJEPQ0oe+v7q6j2KAP/0cqFoX85bR8RA1QtuXsTzY3 H1gnyYSbiTsb//FfZhaphq/GaXSnPu8mhUnvu5WCG+UcAKbRJqB9VJAJxOSQnL2q 96opa2JsDq0rEMkQRJJQheNWnkvIkIp6nLaFcq3xHMamo4qGxAgst/95uPZiSKrD qZyDf86tfv4d7wB1jXI72exSMS2lK3NO9XSTDeMpALXJXSS73BjWzNe3+iNnX+y7 2CbK6o9U6MFUNRcMVxckJz4e3bg/93Plx76mIJE/GZ2rdq9NuHtysQP2PYMZ1wB5 PHuOaXN6tfQq3UfbCmGqcHQ/MQGyhc/gT2VQRrdUYY/W8ALxQMWQgiGegKTahn6w hBKc0UKkBdhVZXcjg2XrLL8By6WKcOgrhtBzFvWqDg5U3dTFkONAeuy0YWcmrJ0M PvNsD7swLhNDm5JarLnIuf1KEC7wyU1BTH00RA4F4XxE6GjbPUq/mm2FpkGQO7hj NUXnU9/ugw1pqdX6CCZ8Ib9DypATU7Hy6nWYG3pquE/05OrsFMVlnK7T8o08EAlU CxTFdO02aKzMtVDClz9nI8/wkHEKD+CAQox8IUjlKpA1WTY75NUyajeNcaGG7Dnw UmcmdZJDn67MqDz2De+0Nmi/hoUsw/nMOufuNR+eL7SbvFPTDfP1Plk87jMqKsb0 +bNbYqY0EZkZOKhVKFk5 =hyjW -END PGP SIGNATURE- Changes since cp-5.1-branch-point-7: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 60055] insert text from scanner's OCR
https://bugs.documentfoundation.org/show_bug.cgi?id=60055 Aron Budeachanged: What|Removed |Added Blocks||104269 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104269 [Bug 104269] [META] Bugs related to scanning -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - 2 commits - configure.ac extras/source
configure.ac |2 +- extras/source/autocorr/lang/bg/DocumentList.xml| 12 extras/source/autocorr/lang/da/DocumentList.xml| 12 extras/source/autocorr/lang/hr/DocumentList.xml| 12 extras/source/autocorr/lang/is/DocumentList.xml| 12 extras/source/autocorr/lang/ro/DocumentList.xml| 12 extras/source/autocorr/lang/sl/DocumentList.xml| 12 extras/source/autocorr/lang/tr/DocumentList.xml| 12 extras/source/autocorr/lang/zh-CN/DocumentList.xml |7 +++ 9 files changed, 92 insertions(+), 1 deletion(-) New commits: commit 4940d1a24a8b0f836def0b603094686e281d3098 Author: Christian LohmaierDate: Tue Nov 29 23:29:47 2016 +0100 bump product version to 5.2.5.0.0+ Change-Id: I087482c0b7dfc42066a25648176d187a6c6d0d0f diff --git a/configure.ac b/configure.ac index 7b96f85f..d08c259 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.2.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.2.5.0.0+],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) commit c1e75eac41aa4cd28d6c761f6ff6dd87010a3e95 Author: Christian Lohmaier Date: Tue Nov 29 23:26:28 2016 +0100 update emoji autocorrect files from po-files Change-Id: If5bc2d9254832aad2c09092329a6c91bff211352 diff --git a/extras/source/autocorr/lang/bg/DocumentList.xml b/extras/source/autocorr/lang/bg/DocumentList.xml index 348a27a..627fe2c 100644 --- a/extras/source/autocorr/lang/bg/DocumentList.xml +++ b/extras/source/autocorr/lang/bg/DocumentList.xml @@ -20,46 +20,58 @@ + + + + + + + + + + + + diff --git a/extras/source/autocorr/lang/da/DocumentList.xml b/extras/source/autocorr/lang/da/DocumentList.xml index 63463d8..9ee0658 100644 --- a/extras/source/autocorr/lang/da/DocumentList.xml +++ b/extras/source/autocorr/lang/da/DocumentList.xml @@ -624,35 +624,47 @@ + + + + + + + + + + + + diff --git a/extras/source/autocorr/lang/hr/DocumentList.xml b/extras/source/autocorr/lang/hr/DocumentList.xml index 1924ed5..f83dee9 100644 --- a/extras/source/autocorr/lang/hr/DocumentList.xml +++ b/extras/source/autocorr/lang/hr/DocumentList.xml @@ -4,46 +4,58 @@ + + + + + + + + + + + + diff --git a/extras/source/autocorr/lang/is/DocumentList.xml b/extras/source/autocorr/lang/is/DocumentList.xml index 3d7d943..747d1e0 100644 --- a/extras/source/autocorr/lang/is/DocumentList.xml +++ b/extras/source/autocorr/lang/is/DocumentList.xml @@ -4,46 +4,58 @@ + + + + + + + + + + + + diff --git a/extras/source/autocorr/lang/ro/DocumentList.xml b/extras/source/autocorr/lang/ro/DocumentList.xml index bbb5433..0898da1 100644 --- a/extras/source/autocorr/lang/ro/DocumentList.xml +++ b/extras/source/autocorr/lang/ro/DocumentList.xml @@ -88,34 +88,46 @@ + + + + + + + + + + + + diff --git a/extras/source/autocorr/lang/sl/DocumentList.xml b/extras/source/autocorr/lang/sl/DocumentList.xml index 7587c29..4a8ca49 100644 --- a/extras/source/autocorr/lang/sl/DocumentList.xml +++ b/extras/source/autocorr/lang/sl/DocumentList.xml @@ -451,9 +451,13 @@ + + + + @@ -462,34 +466,42 @@ + + + + + + + + diff --git a/extras/source/autocorr/lang/tr/DocumentList.xml b/extras/source/autocorr/lang/tr/DocumentList.xml index 15208b6..48689e2 100644 --- a/extras/source/autocorr/lang/tr/DocumentList.xml +++ b/extras/source/autocorr/lang/tr/DocumentList.xml @@ -97,35 +97,47 @@ + + + +
[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning
https://bugs.documentfoundation.org/show_bug.cgi?id=104269 Aron Budeachanged: What|Removed |Added Depends on||42075 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42075 [Bug 42075] Add a scan-button to the "select scanner"-dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'libreoffice-5-2-4'
New branch 'libreoffice-5-2-4' available with the following commits: commit b2f15c4ac2ea0be4a5043baebad315e764c6c30b Author: Christian LohmaierDate: Tue Nov 29 23:28:02 2016 +0100 Branch libreoffice-5-2-4 This is 'libreoffice-5-2-4' - the stable branch for the 5.2.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.2.x release, please use the 'libreoffice-5-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Id7a88dea28124e8be0a2f7a4343bdaab86633315 commit c1e75eac41aa4cd28d6c761f6ff6dd87010a3e95 Author: Christian Lohmaier Date: Tue Nov 29 23:26:28 2016 +0100 update emoji autocorrect files from po-files Change-Id: If5bc2d9254832aad2c09092329a6c91bff211352 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'libreoffice-5-2-4'
New branch 'libreoffice-5-2-4' available with the following commits: commit 42275f0596f6a809524727f8974d682129266082 Author: Christian LohmaierDate: Tue Nov 29 23:27:41 2016 +0100 Branch libreoffice-5-2-4 This is 'libreoffice-5-2-4' - the stable branch for the 5.2.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.2.x release, please use the 'libreoffice-5-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I0f26550be4226d4b04e4bc90fe893c9543d21268 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning
https://bugs.documentfoundation.org/show_bug.cgi?id=104269 Aron Budeachanged: What|Removed |Added Depends on||60055 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=60055 [Bug 60055] insert text from scanner's OCR -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: Changes to 'libreoffice-5-2-4'
New branch 'libreoffice-5-2-4' available with the following commits: commit 83481fca48b9b16480ed5f52f4e40edafd48d52a Author: Christian LohmaierDate: Tue Nov 29 23:27:41 2016 +0100 Branch libreoffice-5-2-4 This is 'libreoffice-5-2-4' - the stable branch for the 5.2.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.2.x release, please use the 'libreoffice-5-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Id3afe1edb2bd9abd6f7e350efdec64610c7c3983 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-5-2-4'
New branch 'libreoffice-5-2-4' available with the following commits: commit d67e4896cc8683ebd7c50dbabe5e27f7587f7b66 Author: Christian LohmaierDate: Tue Nov 29 23:27:40 2016 +0100 Branch libreoffice-5-2-4 This is 'libreoffice-5-2-4' - the stable branch for the 5.2.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 5.2.x release, please use the 'libreoffice-5-2' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I108a214c084740b74afdd7782969e589eea4a522 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 69579] SCANNING: dpi-values are not processed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=69579 Aron Budeachanged: What|Removed |Added Blocks||104269 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104269 [Bug 104269] [META] Bugs related to scanning -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42075] Add a scan-button to the "select scanner"-dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=42075 Aron Budeachanged: What|Removed |Added Blocks||104269 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104269 [Bug 104269] [META] Bugs related to scanning -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning
https://bugs.documentfoundation.org/show_bug.cgi?id=104269 Aron Budeachanged: What|Removed |Added Depends on||104000 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104000 [Bug 104000] Writer media scan produces scrambled image -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning
https://bugs.documentfoundation.org/show_bug.cgi?id=104269 Aron Budeachanged: What|Removed |Added Depends on||69579 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=69579 [Bug 69579] SCANNING: dpi-values are not processed correctly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104000] Writer media scan produces scrambled image
https://bugs.documentfoundation.org/show_bug.cgi?id=104000 Aron Budeachanged: What|Removed |Added Blocks||104269 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104269 [Bug 104269] [META] Bugs related to scanning -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95856] Scan hangs in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=95856 Aron Budeachanged: What|Removed |Added Blocks||104269 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104269 [Bug 104269] [META] Bugs related to scanning -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning
https://bugs.documentfoundation.org/show_bug.cgi?id=104269 Aron Budeachanged: What|Removed |Added Depends on||101066 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101066 [Bug 101066] Dialog "SCANNING" not work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning
https://bugs.documentfoundation.org/show_bug.cgi?id=104269 Aron Budeachanged: What|Removed |Added Depends on||95856 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=95856 [Bug 95856] Scan hangs in Draw -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs