[Libreoffice-bugs] [Bug 95400] FILEOPEN: SVG: textLength and lengthAdjust attributes are not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=95400 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #6 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142917 --> https://bugs.documentfoundation.org/attachment.cgi?id=142917=edit sampleTextLength.svg in LO Draw 6.1 beta 2 In LO Draw 6.1 beta 2 it looks better than before, but there is different from original view of SVG (in Chrome or in Inkscape) confirm bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95276] SVG-image text layout bug (pixels cut off from text)
https://bugs.documentfoundation.org/show_bug.cgi?id=95276 --- Comment #11 from kompilainenn <79045_79...@mail.ru> --- still repro in LibreOffice 6.1 beta 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118239] Short cuts – allow for actions in reverse ways.
https://bugs.documentfoundation.org/show_bug.cgi?id=118239 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- You mean something more that ? And for many dialogs/frames repeating the "shortcut" already closes out the element. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 118239] Short cuts – allow for actions in reverse ways.
https://bugs.documentfoundation.org/show_bug.cgi?id=118239 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- You mean something more that ? And for many dialogs/frames repeating the "shortcut" already closes out the element. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 118240] New: AutoCaption shouldn't allow Categories with spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=118240 Bug ID: 118240 Summary: AutoCaption shouldn't allow Categories with spaces Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open Writer 2. Go to Tools - Options - Writer - AutoCaption, select LibreOffice Writer, write 'Test test' in category and select 1,2,3 in numbering... 3. Insert a new image -> Observed behaviour: The image's caption is 0. It should be 1 The Insert Caption dialog from Insert - Caption doesn't allow to insert spaces. Reproduced in Version: 6.2.0.0.alpha0+ Build ID: d60d695fcc5064e1f16842387fdce23456a64694 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded and LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118230] Replace... command does not remember order of alignment of elements after picture is placed
https://bugs.documentfoundation.org/show_bug.cgi?id=118230 --- Comment #2 from Susan Gessing --- Tested on Windows 8.1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118230] Replace... command does not remember order of alignment of elements after picture is placed
https://bugs.documentfoundation.org/show_bug.cgi?id=118230 Susan Gessing changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118236] FILEOPEN DOCX Checkbox-Content Control cannot be checked in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118236 --- Comment #4 from Susan Gessing --- Tested on Windows 8.1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'feature/latency' - wsd/ClientSession.cpp wsd/ClientSession.hpp
wsd/ClientSession.cpp | 58 ++
wsd/ClientSession.hpp |1
2 files changed, 32 insertions(+), 27 deletions(-)
New commits:
commit 3daf7893dff625dab59ecaec1d9af360350fd517
Author: Tamás Zolnai
Date: Tue Jun 19 16:15:37 2018 +0200
Handle part number a bit more robust in case of Writer
Change-Id: I7390f1c5f4289be67deacf3540068c040b230584
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 46bdfe775..85f740bea 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -48,7 +48,8 @@ ClientSession::ClientSession(const std::string& id,
_tileWidthPixel(0),
_tileHeightPixel(0),
_tileWidthTwips(0),
-_tileHeightTwips(0)
+_tileHeightTwips(0),
+_isTextDocument(false)
{
const size_t curConnections = ++LOOLWSD::NumConnections;
LOG_INF("ClientSession ctor [" << getName() << "], current number of
connections: " << curConnections);
@@ -291,17 +292,20 @@ bool ClientSession::_handleInput(const char *buffer, int
length)
}
else if (tokens[0] == "setclientpart")
{
-int temp;
-if (tokens.size() != 2 ||
-!getTokenInteger(tokens[1], "part", temp))
+if(!_isTextDocument)
{
-sendTextFrame("error: cmd=setclientpart kind=syntax");
-return false;
-}
-else
-{
-_clientSelectedPart = temp;
-return forwardToChild(std::string(buffer, length), docBroker);
+int temp;
+if (tokens.size() != 2 ||
+!getTokenInteger(tokens[1], "part", temp))
+{
+sendTextFrame("error: cmd=setclientpart kind=syntax");
+return false;
+}
+else
+{
+_clientSelectedPart = temp;
+return forwardToChild(std::string(buffer, length), docBroker);
+}
}
}
else if (tokens[0] == "clientzoom")
@@ -724,17 +728,20 @@ bool ClientSession::handleKitToClientMessage(const char*
buffer, const int lengt
}
else if (tokens[0] == "setpart:" && tokens.size() == 2)
{
-int setPart;
-if(getTokenInteger(tokens[1], "part", setPart))
-{
-_clientSelectedPart = setPart;
-}
-else if (stringToInteger(tokens[1], setPart))
+if(!_isTextDocument)
{
+int setPart;
+if(getTokenInteger(tokens[1], "part", setPart))
+{
_clientSelectedPart = setPart;
-}
-else
-return false;
+}
+else if (stringToInteger(tokens[1], setPart))
+{
+_clientSelectedPart = setPart;
+}
+else
+return false;
+ }
}
else if (tokens.size() == 3 && tokens[0] == "saveas:")
{
@@ -865,7 +872,7 @@ bool ClientSession::handleKitToClientMessage(const char*
buffer, const int lengt
std::string docType;
if(getTokenString(token, "type", docType))
{
-_docType = docType;
+_isTextDocument = docType.find("text") !=
std::string::npos;
}
}
@@ -1102,7 +1109,7 @@ void ClientSession::handleTileInvalidation(const
std::string& message,
if(!_clientVisibleArea.hasSurface() ||
_tileWidthPixel == 0 || _tileHeightPixel == 0 ||
_tileWidthTwips == 0 || _tileHeightTwips == 0 ||
- _clientSelectedPart == -1)
+ (_clientSelectedPart == -1 && !_isTextDocument))
{
return;
}
@@ -,14 +1118,11 @@ void ClientSession::handleTileInvalidation(const
std::string& message,
int part = result.first;
Util::Rectangle& invalidateRect = result.second;
-if(_docType.find("text") != std::string::npos) // For Writer we don't have
separate parts
-part = 0;
-
-if(part == -1) // If no part is specifed we use the part used by the client
+if( part == -1 ) // If no part is specifed we use the part used by the
client
part = _clientSelectedPart;
std::vector invalidTiles;
-if(part == _clientSelectedPart)
+if(part == _clientSelectedPart || _isTextDocument)
{
Util::Rectangle intersection;
intersection._x1 = std::max(invalidateRect._x1,
_clientVisibleArea._x1);
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index ed8266bbc..decc6c227 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -196,6 +196,7 @@ private:
// Type of the docuemnt, extracter from status message
std::string _docType;
+bool _isTextDocument;
std::vector _tilesOnFly;
boost::optional>
_tileCounterStartTime;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118183] FILEOPEN: bad text position rendering in table
https://bugs.documentfoundation.org/show_bug.cgi?id=118183 --- Comment #5 from Marina Latini (CIB) --- Created attachment 142916 --> https://bugs.documentfoundation.org/attachment.cgi?id=142916=edit wrong text position out of margins I attached a screenshot. the behaviour is different and this screenshot shoud clarify the real issue. The table is out of the left margin, try to look at the table properties but, with version Version: 6.1.0.0.beta1 (x64) Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: de-DE (en_GB); Calc: CL the text is out of table margins too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/qt5+kde5' - 39 commits - basctl/source configure.ac cui/source filter/source filter/uiconfig include/sfx2 include/vcl sc/inc sc/IwyuFilter_sc.yaml sc/so
Rebased ref, commits from common ancestor:
commit f9fd65b28f7d9c402b4e2bfb1b88e7b9b420d47b
Author: Katarina Behrens
Date: Tue Jun 19 15:59:50 2018 +0200
Folder picker is now really a folder picker
and not a regular file picker with wrong title
Change-Id: I849e7bb3d0cad197880fadd865f4d39f13245e97
diff --git a/vcl/unx/kde5/KDE5FilePicker.hxx b/vcl/unx/kde5/KDE5FilePicker.hxx
index 4fbbc487394c..6f175cc375cf 100644
--- a/vcl/unx/kde5/KDE5FilePicker.hxx
+++ b/vcl/unx/kde5/KDE5FilePicker.hxx
@@ -79,6 +79,7 @@ protected:
QGridLayout* _layout;
bool allowRemoteUrls;
+bool mbIsFolderPicker;
public:
explicit KDE5FilePicker(QFileDialog::FileMode);
diff --git a/vcl/unx/kde5/KDE5FilePicker2.cxx b/vcl/unx/kde5/KDE5FilePicker2.cxx
index 46bcccf4bd24..56734b4d36e9 100644
--- a/vcl/unx/kde5/KDE5FilePicker2.cxx
+++ b/vcl/unx/kde5/KDE5FilePicker2.cxx
@@ -83,6 +83,7 @@ KDE5FilePicker::KDE5FilePicker(QFileDialog::FileMode eMode)
, _extraControls(new QWidget)
, _layout(new QGridLayout(_extraControls))
, allowRemoteUrls(false)
+, mbIsFolderPicker(eMode == QFileDialog::Directory)
{
_dialog->setSupportedSchemes({
QStringLiteral("file"),
@@ -96,14 +97,12 @@ KDE5FilePicker::KDE5FilePicker(QFileDialog::FileMode eMode)
_dialog->setFileMode(eMode);
-if (eMode == QFileDialog::Directory)
+if (mbIsFolderPicker)
{
_dialog->setOption(QFileDialog::ShowDirsOnly, true);
_dialog->setWindowTitle(toQString(VclResId(STR_FPICKER_FOLDER_DEFAULT_TITLE)));
}
-setMultiSelectionMode(false);
-
connect(_dialog, ::filterSelected, this,
::filterChanged);
connect(_dialog, ::fileSelected, this,
::selectionChanged);
connect(this, ::setTitleSignal /*(const OUString&)*/, this,
@@ -191,6 +190,9 @@ void SAL_CALL
KDE5FilePicker::setMultiSelectionMode(sal_Bool multiSelect)
return Q_EMIT setMultiSelectionSignal(multiSelect);
}
+if (mbIsFolderPicker)
+return;
+
_dialog->setFileMode(multiSelect ? QFileDialog::ExistingFiles :
QFileDialog::ExistingFile);
}
commit 276adef1703ad1594fee3aaf7a170823cb583447
Author: Katarina Behrens
Date: Tue Jun 19 13:01:43 2018 +0200
Fix initial switch to folder in fileopen dlg
the argument passed is an URL, so using setDirectory wouldn't do
the trick, setDirectoryUrl would
Change-Id: I312f6e2a06b46777dc126f95f63ec0dbcb1f5799
diff --git a/vcl/unx/kde5/KDE5FilePicker2.cxx b/vcl/unx/kde5/KDE5FilePicker2.cxx
index 3d1491eab5cc..46bcccf4bd24 100644
--- a/vcl/unx/kde5/KDE5FilePicker2.cxx
+++ b/vcl/unx/kde5/KDE5FilePicker2.cxx
@@ -213,7 +213,8 @@ void SAL_CALL KDE5FilePicker::setDisplayDirectory(const
OUString& dir)
return Q_EMIT setDisplayDirectorySignal(dir);
}
-_dialog->setDirectory(toQString(dir));
+QString qDir(toQString(dir));
+_dialog->setDirectoryUrl(QUrl(qDir));
}
OUString SAL_CALL KDE5FilePicker::getDisplayDirectory()
commit 2e57b03efda51e3bf53386e2572e816c4d3382d6
Author: Stephan Bergmann
Date: Mon Jun 18 18:05:29 2018 +0200
loplugin:{implicitboolconversion,salbool}
Change-Id: I795a50241b9d77127b5ee5558e0cd706e0fdb76b
diff --git a/vcl/unx/kde5/KDE5FilePicker.hxx b/vcl/unx/kde5/KDE5FilePicker.hxx
index 69d86c5107a9..4fbbc487394c 100644
--- a/vcl/unx/kde5/KDE5FilePicker.hxx
+++ b/vcl/unx/kde5/KDE5FilePicker.hxx
@@ -173,7 +173,7 @@ Q_SIGNALS:
void setValueSignal(sal_Int16 nControlId, sal_Int16 nControlAction,
const css::uno::Any& rValue);
css::uno::Any getValueSignal(sal_Int16 nControlId, sal_Int16
nControlAction);
-void enableControlSignal(sal_Int16 nControlId, sal_Bool bEnable);
+void enableControlSignal(sal_Int16 nControlId, bool bEnable);
void setLabelSignal(sal_Int16 nControlId, const OUString& rLabel);
OUString getLabelSignal(sal_Int16 nControlId);
void appendFilterSignal(const OUString& rTitle, const OUString& rFilter);
@@ -199,7 +199,7 @@ private Q_SLOTS:
return getValue(nControlId, nControlAction);
}
-void enableControlSlot(sal_Int16 nControlId, sal_Bool bEnable)
+void enableControlSlot(sal_Int16 nControlId, bool bEnable)
{
return enableControl(nControlId, bEnable);
}
diff --git a/vcl/unx/kde5/KDE5FilePicker2.cxx b/vcl/unx/kde5/KDE5FilePicker2.cxx
index ce8af6a7eaf2..3d1491eab5cc 100644
--- a/vcl/unx/kde5/KDE5FilePicker2.cxx
+++ b/vcl/unx/kde5/KDE5FilePicker2.cxx
@@ -180,7 +180,7 @@ sal_Int16 SAL_CALL KDE5FilePicker::execute()
_dialog->show();
//block and wait for user input
-return _dialog->exec() == QFileDialog::Accepted;
+return _dialog->exec() == QFileDialog::Accepted ? 1 : 0;
}
void SAL_CALL KDE5FilePicker::setMultiSelectionMode(sal_Bool multiSelect)
commit 4bd93b662f5ad0556d573cb67ae7f4da5577ee23
Author: Katarina Behrens
Date: Mon Jun 18 11:24:36 2018 +0200
VCLKDE5Application is now unused as well
Change-Id:
[Libreoffice-bugs] [Bug 118236] FILEOPEN DOCX Checkbox-Content Control cannot be checked in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118236 Susan Gessing changed: What|Removed |Added Ever confirmed|0 |1 CC||susanjea...@yahoo.com Status|UNCONFIRMED |NEW --- Comment #3 from Susan Gessing --- Was able to reproduce in: Version: 6.0.5.1 (x64) Build ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751 CPU threads: 4; OS: Windows 6.3; UI render: GL; Locale: en-US (en_US); Calc: CL and Version: 6.2.0.0.alpha0+ Build ID: b1740fba0d1e6e3d69c3781734509317f42a0e4f CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-06-15_08:49:04 Locale: en-US (en_US); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'feature/latency' - loleaflet/src
loleaflet/src/layer/tile/CalcTileLayer.js |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
New commits:
commit 51e071475cfa5f80465014cea72ee675f73c60b4
Author: Tamás Zolnai
Date: Tue Jun 19 16:03:34 2018 +0200
Update calc related code to use the new update function
Change-Id: I437aa0f486237b110cf6a86d8c6091c4a79934ac
diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js
b/loleaflet/src/layer/tile/CalcTileLayer.js
index 3e0bf2dfa..10cdb155b 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -315,11 +315,7 @@ L.CalcTileLayer = L.TileLayer.extend({
},
_onZoomRowColumns: function () {
- this._updateClientZoom();
- if (this._clientZoom) {
- this._map._socket.sendMessage('clientzoom ' +
this._clientZoom);
- this._clientZoom = null;
- }
+ this._sendClientZoom();
// TODO: test it!
this._map.fire('updaterowcolumnheaders');
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - loleaflet/dist
loleaflet/dist/toolbar/toolbar.js |4
1 file changed, 4 insertions(+)
New commits:
commit 6cc8df82886291e1bda91dc6982e098318bc2b75
Author: Henry Castro
Date: Mon Jun 18 15:04:53 2018 -0400
loleaflet: disable the overflow buttons on the formula toolbar
Change-Id: I788625dd5c7fbd96372a19f3cdbcbefdddeb51c8
Reviewed-on: https://gerrit.libreoffice.org/56059
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/loleaflet/dist/toolbar/toolbar.js
b/loleaflet/dist/toolbar/toolbar.js
index ac547d55e..652a64de9 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -499,6 +499,10 @@ $(function () {
}
});
toolbar.contextmenu(function() { return false; });
+ $(w2ui.formulabar.box).find('.w2ui-scroll-left,
.w2ui-scroll-right').hide();
+ w2ui.formulabar.on('resize', function(target, e) {
+ e.isCancelled = true;
+ });
toolbar = $('#spreadsheet-toolbar')
toolbar.w2toolbar({
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118133] FILESAVE: DOC: Image is missing if roundtrip is done in headless mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118133 Miklos Vajna changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 --- Comment #26 from OfficeUser --- The second question from my comment above is for Eike. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 --- Comment #25 from OfficeUser --- @Stuart: > "Suspect flushing all cell content through edit engine just to provide layout > kerning is going to impose considerable performance drag. Are there any values for a performance degrade available if using EditEngine always? > What might be possible is for non-EditEngine cells tell OutputDevice to force > kerning off via SalLayoutFlags::DisableKerning (I didn't track how exactly we > call OutputDevice draws there). Is this possible to change per character? We need to keep in mind that we are talking of a character attribute (like bold, underlined, ...). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'feature/latency' - wsd/ClientSession.cpp
wsd/ClientSession.cpp |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 93e2c2b5b7937e7c7eb8f4198a58464eae7d01e5
Author: Tamás Zolnai
Date: Tue Jun 19 15:13:40 2018 +0200
In Impress setpart message syntax is a bit different.
Two alternative sytnax:
"setpart part=1"
"setpart 1"
Change-Id: I42683ca46d642d56cfc3dcc52a10d69a3f00462b
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index a9ad571bf..46bdfe775 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -726,7 +726,13 @@ bool ClientSession::handleKitToClientMessage(const char*
buffer, const int lengt
{
int setPart;
if(getTokenInteger(tokens[1], "part", setPart))
+{
_clientSelectedPart = setPart;
+}
+else if (stringToInteger(tokens[1], setPart))
+{
+_clientSelectedPart = setPart;
+}
else
return false;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Bug 85811 depends on bug 118217, which changed state. Bug 118217 Summary: Menubar: writer menubar update https://bugs.documentfoundation.org/show_bug.cgi?id=118217 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118217] Menubar: writer menubar update
https://bugs.documentfoundation.org/show_bug.cgi?id=118217 Heiko Tietze changed: What|Removed |Added Resolution|--- |WONTFIX CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Keywords|needsUXEval | Status|NEEDINFO|RESOLVED --- Comment #8 from Heiko Tietze --- (In reply to Xisco Faulí from comment #7) > (In reply to andreas_k from comment #6) > > or we close the bug cause it look that nobody is interested into. > > @heiko, what do you think? Yes, lets do that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 118217] Menubar: writer menubar update
https://bugs.documentfoundation.org/show_bug.cgi?id=118217 Heiko Tietze changed: What|Removed |Added Resolution|--- |WONTFIX CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Keywords|needsUXEval | Status|NEEDINFO|RESOLVED --- Comment #8 from Heiko Tietze --- (In reply to Xisco Faulí from comment #7) > (In reply to andreas_k from comment #6) > > or we close the bug cause it look that nobody is interested into. > > @heiko, what do you think? Yes, lets do that. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - download.lst
download.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d99f351377a335ffbc5deddfca2860815e3bcfad Author: Andras Timar Date: Tue Jun 19 15:27:31 2018 +0200 checksum of Noto-hinted.zip changed Change-Id: Ib7ebf33a69ebabbb28dd26ab1a702fc8c7c8ed66 diff --git a/download.lst b/download.lst index e9b96aa4f172..4fbd2eec9fe7 100644 --- a/download.lst +++ b/download.lst @@ -48,7 +48,7 @@ export FONT_LIBERATION_NARROW_TARBALL := 134d8262145fc793c6af494dcace3e71-libera export FONT_LIBERATION_TARBALL := 5c781723a0d9ed6188960defba8e91cf-liberation-fonts-ttf-2.00.1.tar.gz export FONT_LINLIBERTINEG_TARBALL := e7a384790b13c29113e22e596ade9687-LinLibertineG-20120116.zip export FONT_NOTO_TARBALL := Noto-hinted.zip -export FONT_NOTO_MD5SUM := 5489f1765afd34a2adfdc04d014762e7 +export FONT_NOTO_MD5SUM := 10caa4ab07fefe97292353493c217815 export FONT_NOTO_SANS_JP_TARBALL := NotoSansJP.zip export FONT_NOTO_SANS_JP_MD5SUM := 7f2597c54c292b4c72ffcdc5e6d31e4d export FONT_NOTO_SANS_KR_TARBALL := NotoSansKR.zip ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 44223] FILESAVE, FILEOPEN: No sound in presentations saved in .pptx format
https://bugs.documentfoundation.org/show_bug.cgi?id=44223 Xisco Faulí changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #14 from Xisco Faulí --- (In reply to Jan Holesovsky from comment #13) > To help solving this bug, can anyone attach a pptx presentation created in > PowerPoint that has some sound? - so that we can implement the preservation > of that... What about attachment 93222 from bug 74379 or the attachments in bug 103142 ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90243] SIDEBAR: Named shapes incorrectly named in custom animation tab
https://bugs.documentfoundation.org/show_bug.cgi?id=90243 --- Comment #8 from Commit Notification --- Mark Hung committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e559d360d0a19715bd6261b7dfc7f03eb7c9b99e tdf#90243 don't append index if shape already has a name. It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90243] SIDEBAR: Named shapes incorrectly named in custom animation tab
https://bugs.documentfoundation.org/show_bug.cgi?id=90243 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/animations/CustomAnimationList.cxx | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
New commits:
commit e559d360d0a19715bd6261b7dfc7f03eb7c9b99e
Author: Mark Hung
Date: Tue Jun 19 00:10:49 2018 +0800
tdf#90243 don't append index if shape already has a name.
Change-Id: I518ad83bf3782af7cb3144982ec8844a573f0de4
Reviewed-on: https://gerrit.libreoffice.org/56051
Tested-by: Jenkins
Reviewed-by: Katarina Behrens
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx
b/sd/source/ui/animations/CustomAnimationList.cxx
index 4f1b4eef4786..11d54bbe04f7 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -124,16 +124,25 @@ OUString getShapeDescription( const Reference< XShape >&
xShape, bool bWithText
{
OUString aDescription;
Reference< XPropertySet > xSet( xShape, UNO_QUERY );
+bool bAppendIndex = true;
+
if( xSet.is() )
{
-Reference< XPropertySetInfo > xInfo( xSet->getPropertySetInfo() );
-const OUString aPropName( "UINameSingular");
-if( xInfo->hasPropertyByName( aPropName ) )
-xSet->getPropertyValue( aPropName ) >>= aDescription;
+Reference xInfo(xSet->getPropertySetInfo());
+
+xSet->getPropertyValue("Name") >>= aDescription;
+bAppendIndex = aDescription.isEmpty();
+
+const OUString aPropName("UINameSingular");
+if(xInfo->hasPropertyByName(aPropName))
+xSet->getPropertyValue(aPropName) >>= aDescription;
}
-aDescription += " ";
-aDescription += OUString::number( getShapeIndex( xShape ) );
+if (bAppendIndex)
+{
+aDescription += " ";
+aDescription += OUString::number(getShapeIndex(xShape));
+}
if( bWithText )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 118217] Menubar: writer menubar update
https://bugs.documentfoundation.org/show_bug.cgi?id=118217 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #7 from Xisco Faulí --- (In reply to andreas_k from comment #6) > or we close the bug cause it look that nobody is interested into. @heiko, what do you think? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 118217] Menubar: writer menubar update
https://bugs.documentfoundation.org/show_bug.cgi?id=118217 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #7 from Xisco Faulí --- (In reply to andreas_k from comment #6) > or we close the bug cause it look that nobody is interested into. @heiko, what do you think? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114736] Crash with CJK characters in status bar (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=114736 --- Comment #23 from Commit Notification --- Tamas Bunth committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=221234c0203d5b3caf6907bff110fc1a9b71a5ad=libreoffice-6-0 tdf#114736 no need to call AdjustLayout here It will be available in 6.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114736] Crash with CJK characters in status bar (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=114736 Commit Notification changed: What|Removed |Added Whiteboard|target:6.1.0|target:6.1.0 target:6.0.6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/source
vcl/source/outdev/text.cxx |7 --- 1 file changed, 7 deletions(-) New commits: commit 221234c0203d5b3caf6907bff110fc1a9b71a5ad Author: Tamas Bunth Date: Sun Jan 28 00:14:55 2018 +0100 tdf#114736 no need to call AdjustLayout here Change-Id: Iae8c953155d46e53cffdf3483e3b4b95157719f6 Reviewed-on: https://gerrit.libreoffice.org/48761 Tested-by: Jenkins Reviewed-by: Tamás Bunth Reviewed-on: https://gerrit.libreoffice.org/49033 Tested-by: Jenkins Reviewed-by: Christian Lohmaier diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx index 5694a8165b58..6d43a5b9f9a3 100644 --- a/vcl/source/outdev/text.cxx +++ b/vcl/source/outdev/text.cxx @@ -888,13 +888,6 @@ void OutputDevice::DrawText( const Point& rStartPt, const OUString& rStr, if( mbInitFont ) InitFont(); - -OUString aStrModifiable = rStr; -ImplLayoutArgs aLayoutArgs = ImplPrepareLayoutArgs( aStrModifiable, nIndex, nLen, -0, nullptr); - -// position, justify, etc. the layout -pLayoutCache->AdjustLayout( aLayoutArgs ); pLayoutCache->DrawBase() = ImplLogicToDevicePixel( rStartPt ); ImplDrawText( *pLayoutCache ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118109] Graph axis value markers not displaying correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=118109 Xisco Faulí changed: What|Removed |Added Resolution|--- |DUPLICATE Keywords||bibisected, bisected Status|NEW |RESOLVED CC||xiscofa...@libreoffice.org --- Comment #5 from Xisco Faulí --- Regression introduced by https://cgit.freedesktop.org/libreoffice/core/commit/?id=35d062f7879d5414334643cb90bff411726b2168 which is the same as in bug 117088. Closing as RESOLVED DUPLICATED *** This bug has been marked as a duplicate of bug 117088 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117088] FILEOPEN: Some labels in charts are not displayed by default
https://bugs.documentfoundation.org/show_bug.cgi?id=117088 Xisco Faulí changed: What|Removed |Added CC||zacgarb...@gmail.com --- Comment #3 from Xisco Faulí --- *** Bug 118109 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118233] ReportBuilder does not know aliases for Firebird views
https://bugs.documentfoundation.org/show_bug.cgi?id=118233 --- Comment #3 from Gerhard Schaber --- Created attachment 142915 --> https://bugs.documentfoundation.org/attachment.cgi?id=142915=edit Sample DB -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118233] ReportBuilder does not know aliases for Firebird views
https://bugs.documentfoundation.org/show_bug.cgi?id=118233 --- Comment #2 from Gerhard Schaber --- In the attached example, the field picker shows the alias. When you select it, it will enter the original name of the view he current view is based upon. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-49'
Tag 'cp-5.3-49' created by Andras Timar at 2018-06-19 13:11 + cp-5.3-49 Changes since cp-5.3-47-5: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.3-49'
Tag 'cp-5.3-49' created by Andras Timar at 2018-06-19 13:11 + cp-5.3-49 Changes since cp-5.3-46: Andras Timar (1): remove extra ~ characters from German translation --- source/de/officecfg/registry/data/org/openoffice/Office/UI.po |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.3-49'
Tag 'cp-5.3-49' created by Andras Timar at 2018-06-19 13:11 + cp-5.3-49 Changes since cp-5.3-10: Olivier R (1): tdf#107558 French spelling dictionary (6.0.3) and thesaurus --- fr_FR/README_fr.txt |4 fr_FR/description.xml |2 fr_FR/fr.aff |17751 ++-- fr_FR/fr.dic |155369 +- fr_FR/package-description.txt |2 fr_FR/thes_fr.dat | 206 6 files changed, 88495 insertions(+), 84839 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.3-49'
Tag 'cp-5.3-49' created by Andras Timar at 2018-06-19 13:11 + cp-5.3-49 Changes since libreoffice-5-3-branch-point-28: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118233] ReportBuilder does not know aliases for Firebird views
https://bugs.documentfoundation.org/show_bug.cgi?id=118233 --- Comment #1 from Drew Jensen --- Using Ubuntu 18.04 w/ Libo 6.1 Beta2 I can't replicate your problem. I create a view with column aliases and when I create a RB report against it the field picker displays the column aliases, sorting and grouping displays the column aliases and the sidebar property editor for fields does the same. @Gerhard, do you have an example file you can share with the problem? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115034] Crash in: ScTransferObj::~ScTransferObj()
https://bugs.documentfoundation.org/show_bug.cgi?id=115034 Xisco Faulí changed: What|Removed |Added See Also||https://crashreport.libreof ||fice.org/stats/signature/Sc ||TransferObj::~ScTransferObj ||() -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 26d4b30be98bd2c5e99226475659606e50ec723c Author: Andras Timar Date: Tue Jun 19 14:57:13 2018 +0200 Bump version to 5.3-49 Change-Id: Ide834382539faf03cba7f887ae762144814f0c22 diff --git a/configure.ac b/configure.ac index e793a0bb5ce3..62aab35fca14 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[5.3.10.47],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[5.3.10.49],[],[],[https://collaboraoffice.com/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118234] fast crash when copy pasting header (level) 3 from one section to a location a couple of lines underneath
https://bugs.documentfoundation.org/show_bug.cgi?id=118234 Xisco Faulí changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118212] Launching Character dialog from any module crashes ( with CJK and CTL disabled )
https://bugs.documentfoundation.org/show_bug.cgi?id=118212 Xisco Faulí changed: What|Removed |Added Summary|Launching Character dialog |Launching Character dialog |from any module crashes |from any module crashes ( ||with CJK and CTL disabled ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118128] FILESAVE : Save as CSV : Error ... invalid parameter
https://bugs.documentfoundation.org/show_bug.cgi?id=118128 Xisco Faulí changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118128] FILESAVE : Save as CSV : Error ... invalid parameter
https://bugs.documentfoundation.org/show_bug.cgi?id=118128 Xisco Faulí changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source
framework/source/loadenv/loadenv.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit c5e1c4105f744ad9730cf74c9b36c2b23bbc0979
Author: Samuel Mehrbrodt
Date: Tue Jun 19 12:15:21 2018 +0200
Rename nFlags to nSearchFlags
Change-Id: Ib03046acf3d34fc307a3765d7d0b1b7d9448b507
Reviewed-on: https://gerrit.libreoffice.org/56088
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
diff --git a/framework/source/loadenv/loadenv.cxx
b/framework/source/loadenv/loadenv.cxx
index b527d0259e77..6ae60ebeadc5 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -143,7 +143,7 @@ css::uno::Reference< css::lang::XComponent >
LoadEnv::loadComponentFromURL(const
const css::uno::Reference< css::uno::XComponentContext >& xContext ,
const OUString&sURL ,
const OUString&sTarget,
-
sal_Int32 nFlags ,
+
sal_Int32 nSearchFlags ,
const css::uno::Sequence< css::beans::PropertyValue >&lArgs )
{
css::uno::Reference< css::lang::XComponent > xComponent;
@@ -163,7 +163,7 @@ css::uno::Reference< css::lang::XComponent >
LoadEnv::loadComponentFromURL(const
lArgs,
css::uno::Reference< css::frame::XFrame
>(xLoader, css::uno::UNO_QUERY),
sTarget,
- nFlags,
+ nSearchFlags,
loadEnvFeatures);
aEnv.startLoading();
aEnv.waitWhileLoading(); // wait for ever!
@@ -1035,8 +1035,8 @@ bool LoadEnv::impl_loadContent()
}
else
{
-sal_Int32 nFlags = m_nSearchFlags &
~css::frame::FrameSearchFlag::CREATE;
-m_xTargetFrame = m_xBaseFrame->findFrame(sTarget, nFlags);
+sal_Int32 nSearchFlags = m_nSearchFlags &
~css::frame::FrameSearchFlag::CREATE;
+m_xTargetFrame = m_xBaseFrame->findFrame(sTarget, nSearchFlags);
if (! m_xTargetFrame.is())
{
if (! impl_furtherDocsAllowed())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - framework/source
framework/source/loadenv/loadenv.cxx | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
New commits:
commit c6dbeee59fa4fd8b43f3ae182c18bf04d57c52dc
Author: Samuel Mehrbrodt
Date: Tue Jun 19 11:47:08 2018 +0200
tdf#118238 Only disable UI interaction when loading document as hidden
The "quiet" interaction handler was used unconditionally
when loading a document via the loadComponentFromURL API method.
So no dialog was shown asking the user whether he wants to enable macros.
With this patch, the "quiet" interaction handler is only used,
when the document was loaded with the "Hidden" property set.
Change-Id: Idd522d0bf605499b071390fb58312181b755dfca
diff --git a/framework/source/loadenv/loadenv.cxx
b/framework/source/loadenv/loadenv.cxx
index 5961c57596ab..4bb7b034c7c9 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -159,11 +160,19 @@ css::uno::Reference< css::lang::XComponent >
LoadEnv::loadComponentFromURL(const
{
LoadEnv aEnv(xContext);
+
+EFeature loadEnvFeatures = E_WORK_WITH_UI;
+comphelper::NamedValueCollection aDescriptor( lArgs );
+// tdf#118238 Only disable UI interaction when loading as hidden
+if (aDescriptor.get("Hidden") == uno::Any(true) ||
Application::IsHeadlessModeEnabled())
+loadEnvFeatures = E_NO_FEATURE;
+
aEnv.initializeLoading(sURL,
lArgs,
css::uno::Reference< css::frame::XFrame
>(xLoader, css::uno::UNO_QUERY),
sTarget,
- nFlags);
+ nFlags,
+ loadEnvFeatures);
aEnv.startLoading();
aEnv.waitWhileLoading(); // wait for ever!
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118212] Launching Character dialog from any module crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=118212 Xisco Faulí changed: What|Removed |Added Priority|medium |highest Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Xisco Faulí changed: What|Removed |Added Depends on||118164 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118164 [Bug 118164] [GTK3] Safe Mode dialog GUI is overlapping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118164] [GTK3] Safe Mode dialog GUI is overlapping
https://bugs.documentfoundation.org/show_bug.cgi?id=118164 Xisco Faulí changed: What|Removed |Added Blocks||103182 Summary|Safe Mode dialog GUI is |[GTK3] Safe Mode dialog GUI |overlapping |is overlapping --- Comment #13 from Xisco Faulí --- (In reply to Kat from comment #12) > (In reply to Xisco Faulí from comment #11) > > Finally, does it happen with SAL_USE_VCLPLUGIN=gtk soffice ? > > Thanks in advance > > It works with gtk2 Thanks, then it's a GTK3 problem Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - filter/source filter/uiconfig
filter/source/pdf/impdialog.cxx | 122 +++---
filter/source/pdf/impdialog.hxx | 25 +++
filter/uiconfig/ui/pdfsignpage.ui | 20 +++---
3 files changed, 73 insertions(+), 94 deletions(-)
New commits:
commit d565b3381cc1c3dcbc354de1ec7488d0c16d80d3
Author: Caolán McNamara
Date: Mon Jun 18 11:52:33 2018 +0100
weld ImpPDFTabSigningPage
Change-Id: Ia81f3f2ac3644e496ab679dc8e274b2d50f64edd
Reviewed-on: https://gerrit.libreoffice.org/56036
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index a02784cb7c7c..ca4bbae52e5a 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -1475,48 +1475,29 @@ IMPL_LINK_NOARG(ImplErrorDialog, SelectHdl,
weld::TreeView&, void)
}
/// The digital signatures tab page
-ImpPDFTabSigningPage::ImpPDFTabSigningPage(vcl::Window* pParent, const
SfxItemSet& rCoreSet)
-: SfxTabPage(pParent, "PdfSignPage","filter/ui/pdfsignpage.ui", )
+ImpPDFTabSigningPage::ImpPDFTabSigningPage(TabPageParent pParent, const
SfxItemSet& rCoreSet)
+: SfxTabPage(pParent, "filter/ui/pdfsignpage.ui", "PdfSignPage", )
, maSignCertificate()
+, mxEdSignCert(m_xBuilder->weld_entry("cert"))
+, mxPbSignCertSelect(m_xBuilder->weld_button("select"))
+, mxPbSignCertClear(m_xBuilder->weld_button("clear"))
+, mxEdSignPassword(m_xBuilder->weld_entry("password"))
+, mxEdSignLocation(m_xBuilder->weld_entry("location"))
+, mxEdSignContactInfo(m_xBuilder->weld_entry("contact"))
+, mxEdSignReason(m_xBuilder->weld_entry("reason"))
+, mxLBSignTSA(m_xBuilder->weld_combo_box_text("tsa"))
{
-get(mpEdSignCert, "cert");
-get(mpPbSignCertSelect, "select");
-get(mpPbSignCertClear, "clear");
-get(mpEdSignPassword, "password");
-get(mpEdSignLocation, "location");
-get(mpEdSignContactInfo, "contact");
-get(mpEdSignReason, "reason");
-get(mpLBSignTSA, "tsa");
-
-mpPbSignCertSelect->Enable();
-mpPbSignCertSelect->SetClickHdl( LINK( this, ImpPDFTabSigningPage,
ClickmaPbSignCertSelect ) );
-mpPbSignCertClear->SetClickHdl( LINK( this, ImpPDFTabSigningPage,
ClickmaPbSignCertClear ) );
+mxPbSignCertSelect->set_sensitive(false);
+mxPbSignCertSelect->connect_clicked(LINK(this, ImpPDFTabSigningPage,
ClickmaPbSignCertSelect));
+mxPbSignCertClear->connect_clicked(LINK(this, ImpPDFTabSigningPage,
ClickmaPbSignCertClear));
}
-
ImpPDFTabSigningPage::~ImpPDFTabSigningPage()
{
-disposeOnce();
}
-
-void ImpPDFTabSigningPage::dispose()
+IMPL_LINK_NOARG(ImpPDFTabSigningPage, ClickmaPbSignCertSelect, weld::Button&,
void)
{
-mpEdSignCert.clear();
-mpPbSignCertSelect.clear();
-mpPbSignCertClear.clear();
-mpEdSignPassword.clear();
-mpEdSignLocation.clear();
-mpEdSignContactInfo.clear();
-mpEdSignReason.clear();
-mpLBSignTSA.clear();
-SfxTabPage::dispose();
-}
-
-
-IMPL_LINK_NOARG( ImpPDFTabSigningPage, ClickmaPbSignCertSelect, Button*, void )
-{
-
Reference< security::XDocumentDigitalSignatures > xSigner(
security::DocumentDigitalSignatures::createWithVersion(
comphelper::getProcessComponentContext(), "1.2" ) );
@@ -1527,13 +1508,13 @@ IMPL_LINK_NOARG( ImpPDFTabSigningPage,
ClickmaPbSignCertSelect, Button*, void )
if (maSignCertificate.is())
{
-mpEdSignCert->SetText(maSignCertificate->getSubjectName());
-mpPbSignCertClear->Enable();
-mpEdSignLocation->Enable();
-mpEdSignPassword->Enable();
-mpEdSignContactInfo->Enable();
-mpEdSignReason->Enable();
-mpEdSignReason->SetText(aDescription);
+mxEdSignCert->set_text(maSignCertificate->getSubjectName());
+mxPbSignCertClear->set_sensitive(true);
+mxEdSignLocation->set_sensitive(true);
+mxEdSignPassword->set_sensitive(true);
+mxEdSignContactInfo->set_sensitive(true);
+mxEdSignReason->set_sensitive(true);
+mxEdSignReason->set_text(aDescription);
try
{
@@ -1543,7 +1524,7 @@ IMPL_LINK_NOARG( ImpPDFTabSigningPage,
ClickmaPbSignCertSelect, Button*, void )
const css::uno::Sequence& rTSAURLs = aTSAURLs.get();
for (auto const& elem : rTSAURLs)
{
-mpLBSignTSA->InsertEntry(elem);
+mxLBSignTSA->append_text(elem);
}
}
}
@@ -1553,62 +1534,57 @@ IMPL_LINK_NOARG( ImpPDFTabSigningPage,
ClickmaPbSignCertSelect, Button*, void )
}
// If more than only the "None" entry is there, enable the ListBox
-if (mpLBSignTSA->GetEntryCount() > 1)
-mpLBSignTSA->Enable();
+if (mxLBSignTSA->get_count() > 1)
+mxLBSignTSA->set_sensitive(true);
}
}
-
-IMPL_LINK_NOARG( ImpPDFTabSigningPage, ClickmaPbSignCertClear, Button*,
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 --- Comment #24 from V Stuart Foote --- Again, what effect of enabling "Use printer metrics for text formatting"? Allow that to impose overhead. As now, seems we only impose overhead when cell is actively being edited (w/F2) or as noted with multi-line cell content. Suspect flushing all cell content through edit engine just to provide layout kerning is going to impose considerable performance drag. If we have to pick performance over typeseting fidelity--99.9% of users are going to demand performance. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - loleaflet/dist
loleaflet/dist/toolbar/toolbar.js | 90 --
1 file changed, 67 insertions(+), 23 deletions(-)
New commits:
commit bec0781550bb5e0798971ee631bbdb4967867d3c
Author: Jan Holesovsky
Date: Tue Jun 19 13:53:56 2018 +0200
borders: Send .uno:SetBorderStyle with the appropriate params to the core.
Change-Id: I703dda35d3b412ff60602a6802b260d8709762fd
Reviewed-on: https://gerrit.libreoffice.org/56093
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/loleaflet/dist/toolbar/toolbar.js
b/loleaflet/dist/toolbar/toolbar.js
index f47b120b9..ac547d55e 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -241,16 +241,62 @@ function onClick(e, id, item, subItem) {
}
}
-function insertBorder() {
- var $grid = $('#setborderstyle-grid');
+function setBorders(left, right, bottom, top, horiz, vert) {
+ var params = {
+OuterBorder: {
+type : '[]any',
+value : [
+{ type : 'com.sun.star.table.BorderLine2', value : { Color : {
type : 'com.sun.star.util.Color', value : 0 }, InnerLineWidth : { type :
'short', value : 0 }, OuterLineWidth : { type : 'short', value : left },
LineDistance : { type : 'short', value : 0 }, LineStyle : { type : 'short',
value : 0 }, LineWidth : { type : 'unsigned long', value : 0 } } },
+{ type : 'com.sun.star.table.BorderLine2', value : { Color : {
type : 'com.sun.star.util.Color', value : 0 }, InnerLineWidth : { type :
'short', value : 0 }, OuterLineWidth : { type : 'short', value : right },
LineDistance : { type : 'short', value : 0 }, LineStyle : { type : 'short',
value : 0 }, LineWidth : { type : 'unsigned long', value : 0 } } },
+{ type : 'com.sun.star.table.BorderLine2', value : { Color : {
type : 'com.sun.star.util.Color', value : 0 }, InnerLineWidth : { type :
'short', value : 0 }, OuterLineWidth : { type : 'short', value : bottom },
LineDistance : { type : 'short', value : 0 }, LineStyle : { type : 'short',
value : 0 }, LineWidth : { type : 'unsigned long', value : 0 } } },
+{ type : 'com.sun.star.table.BorderLine2', value : { Color : {
type : 'com.sun.star.util.Color', value : 0 }, InnerLineWidth : { type :
'short', value : 0 }, OuterLineWidth : { type : 'short', value : top },
LineDistance : { type : 'short', value : 0 }, LineStyle : { type : 'short',
value : 0 }, LineWidth : { type : 'unsigned long', value : 0 } } },
+{ type : 'long', value : 0 },
+{ type : 'long', value : 0 },
+{ type : 'long', value : 0 },
+{ type : 'long', value : 0 },
+{ type : 'long', value : 0 }
+]
+},
+InnerBorder: {
+type : '[]any',
+value : [
+{ type : 'com.sun.star.table.BorderLine2', value : { Color : {
type : 'com.sun.star.util.Color', value : 0 }, InnerLineWidth : { type :
'short', value : 0 }, OuterLineWidth : { type : 'short', value : horiz },
LineDistance : { type : 'short', value : 0 }, LineStyle : { type : 'short',
value : 0 }, LineWidth : { type : 'unsigned long', value : 0 } } },
+{ type : 'com.sun.star.table.BorderLine2', value : { Color : {
type : 'com.sun.star.util.Color', value : 0 }, InnerLineWidth : { type :
'short', value : 0 }, OuterLineWidth : { type : 'short', value : vert },
LineDistance : { type : 'short', value : 0 }, LineStyle : { type : 'short',
value : 0 }, LineWidth : { type : 'unsigned long', value : 0 } } },
+{ type : 'short', value : 0 },
+{ type : 'short', value : 127 },
+{ type : 'long', value : 0 }
+]
+}};
+ map.sendUnoCommand('.uno:SetBorderStyle', params);
+}
- $grid.on({
- click: function() {
- // TODO send map.sendUnoCommand('.uno:
com.sun.star.table.BorderLine2' );
- $().w2overlay({ name: 'toolbar-up' });
- console.log('click border');
- }
- });
+function setBorderStyle(num) {
+ switch (num) {
+ case 1: setBorders(0, 0, 0, 0, 0, 0); break;
+ case 2: setBorders(1, 0, 0, 0, 0, 0); break;
+ case 3: setBorders(0, 1, 0, 0, 0, 0); break;
+ case 4: setBorders(1, 1, 0, 0, 0, 0); break;
+
+ case 5: setBorders(0, 0, 0, 1, 0, 0); break;
+ case 6: setBorders(0, 0, 1, 0, 0, 0); break;
+ case 7: setBorders(0, 0, 1, 1, 0, 0); break;
+ case 8: setBorders(1, 1, 1, 1, 0, 0); break;
+
+ case 9: setBorders(0, 0, 1, 1, 1, 0); break;
+ case 10: setBorders(1, 1, 1, 1, 1, 0); break;
+ case 11: setBorders(1, 1, 1, 1, 0, 1); break;
+ case 12: setBorders(1, 1, 1, 1, 1, 1); break;
+
+ default: console.log('ignored
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - loleaflet/dist
loleaflet/dist/toolbar.css| 15 ++-
loleaflet/dist/toolbar/toolbar.js |8
2 files changed, 14 insertions(+), 9 deletions(-)
New commits:
commit 4468f7a26e0a170f774d18a770c270f5d48da183
Author: Jan Holesovsky
Date: Tue Jun 19 11:29:33 2018 +0200
borders: Improve the look.
Change-Id: Ib7ca90285bb012a09f5fd2d867a3d588e831ec3a
Reviewed-on: https://gerrit.libreoffice.org/56092
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/loleaflet/dist/toolbar.css b/loleaflet/dist/toolbar.css
index 0ea6834a0..23bd74115 100644
--- a/loleaflet/dist/toolbar.css
+++ b/loleaflet/dist/toolbar.css
@@ -270,12 +270,17 @@ button.leaflet-control-search-next
.w2ui-icon.frame11 { background: url('../images/fr011.svg') no-repeat center
!important; }
.w2ui-icon.frame12 { background: url('../images/fr012.svg') no-repeat center
!important; }
-#insertborder-grid tr td {
-border-style: inset;
+#setborderstyle-grid tr td {
+box-sizing: border-box;
+background: rgba(255, 255, 255, 0.5);
+position: relative;
+padding: 2px;
+border: 1px solid #ccc;
+overflow: auto; /* child margins otherwise don't expand *this* element
(parent) */
}
-#insertborder-grid tr td:hover {
-border-style: solid;
+#setborderstyle-grid td:hover {
+border: 1px solid #888;
}
.w2ui-icon.accepttrackedchanges{ background:
url('../images/lc_accepttrackedchanges.svg') no-repeat center !important; }
@@ -302,7 +307,7 @@ button.leaflet-control-search-next
.w2ui-icon.italic{ background: url('../images/lc_italic.svg') no-repeat center
!important; }
.w2ui-icon.insertgraphic{ background: url('../images/lc_gallery.svg')
no-repeat center !important; }
.w2ui-icon.inserttable{ background: url('../images/lc_inserttable.svg')
no-repeat center !important; }
-.w2ui-icon.insertborder{ background: url('../images/lc_setborderstyle.svg')
no-repeat center !important; }
+.w2ui-icon.setborderstyle{ background: url('../images/lc_setborderstyle.svg')
no-repeat center !important; }
.w2ui-icon.next{ background: url('../images/lc_downsearch.svg') no-repeat
center !important; }
.w2ui-icon.numbering{ background: url('../images/lc_defaultnumbering.svg')
no-repeat center !important; }
.w2ui-icon.presentation{ background: url('../images/lc_dia.svg') no-repeat
center !important; }
diff --git a/loleaflet/dist/toolbar/toolbar.js
b/loleaflet/dist/toolbar/toolbar.js
index f232ebce3..f47b120b9 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -242,7 +242,7 @@ function onClick(e, id, item, subItem) {
}
function insertBorder() {
- var $grid = $('#insertborder-grid');
+ var $grid = $('#setborderstyle-grid');
$grid.on({
click: function() {
@@ -883,9 +883,9 @@ map.on('doclayerinit', function () {
switch (docType) {
case 'spreadsheet':
toolbarUp.remove('inserttable', 'styles', 'justifypara',
'defaultbullet', 'defaultnumbering', 'break-numbering');
- toolbarUp.insert('insertshapes',
- {type: 'drop', id: 'insertborder', img:
'insertborder', hint: _('Borders'), overlay: {onShow: insertBorder},
- html: '' +
+ toolbarUp.insert('setborderstyle',
+ {type: 'drop', id: 'setborderstyle', img:
'setborderstyle', hint: _('Borders'), overlay: {onShow: insertBorder},
+ html: '' +
'' +
'' +
'' +
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93987] SVG Export of Chart omits text (X Axis labels)
https://bugs.documentfoundation.org/show_bug.cgi?id=93987 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88278] [META] insert SVG image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Bug 88278 depends on bug 93987, which changed state. Bug 93987 Summary: SVG Export of Chart omits text (X Axis labels) https://bugs.documentfoundation.org/show_bug.cgi?id=93987 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93987] SVG Export of Chart omits text (X Axis labels)
https://bugs.documentfoundation.org/show_bug.cgi?id=93987 --- Comment #9 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142914 --> https://bugs.documentfoundation.org/attachment.cgi?id=142914=edit chart-svg-LO-6.1-beta-2.svg in Chrome looks fine after export chart to SVG from LibreOffice 6.1 beta 2 Status -> WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93987] SVG Export of Chart omits text (X Axis labels)
https://bugs.documentfoundation.org/show_bug.cgi?id=93987 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #8 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142913 --> https://bugs.documentfoundation.org/attachment.cgi?id=142913=edit chart-svg-LO-6.1-beta-2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117830] Wrong header/footer shown for intermittent section in DOC(X)
https://bugs.documentfoundation.org/show_bug.cgi?id=117830 --- Comment #5 from Dieter Praas --- I'm no expert in sections, but I see more than one section in your screenshot an alsop section breaks. When I open it in writer, I hve only one section. I assume, that section in writer has the same meaning as section in word. So does the file looses sections when it is opened in writer? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93583] EDITING formatted text on embedded SVG file displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=93583 --- Comment #8 from kompilainenn <79045_79...@mail.ru> --- still repro in LibreOffice 6.1 beta 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118212] Launching Character dialog from any module crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=118212 --- Comment #12 from V Stuart Foote --- Yup, enabling either CJK or CTL, or both (Tools -> Options -> Language Settings -> Languages: Default Languages for Documents checkboxes) eliminates all crashes. Setting back to Western only recreates the crashes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93522] Inserting SVG doesnt perform file format checking
https://bugs.documentfoundation.org/show_bug.cgi?id=93522 --- Comment #4 from kompilainenn <79045_79...@mail.ru> --- still repro in LibreOffice 6.1 beta 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - loleaflet/dist
loleaflet/dist/images/fr01.svg |7 +++
loleaflet/dist/images/fr010.svg | 10 ++
loleaflet/dist/images/fr011.svg | 10 ++
loleaflet/dist/images/fr012.svg |6 ++
loleaflet/dist/images/fr02.svg |6 ++
loleaflet/dist/images/fr03.svg |6 ++
loleaflet/dist/images/fr04.svg |6 ++
loleaflet/dist/images/fr05.svg |6 ++
loleaflet/dist/images/fr06.svg |6 ++
loleaflet/dist/images/fr07.svg |6 ++
loleaflet/dist/images/fr08.svg |6 ++
loleaflet/dist/images/fr09.svg |6 ++
loleaflet/dist/images/lc_setborderstyle.svg | 10 ++
loleaflet/dist/toolbar.css | 22 ++
loleaflet/dist/toolbar/toolbar.js | 23 +++
15 files changed, 136 insertions(+)
New commits:
commit 69235ad469be14b460e0f00f6b4a8215fc222b10
Author: Henry Castro
Date: Mon Jun 18 08:19:00 2018 -0400
loleaflet: add cell borders in Calc
Change-Id: I0105ee6c98b0eb043b60b56ea80007bae967df90
Reviewed-on: https://gerrit.libreoffice.org/56091
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/loleaflet/dist/images/fr01.svg b/loleaflet/dist/images/fr01.svg
new file mode 100644
index 0..a38747a9d
--- /dev/null
+++ b/loleaflet/dist/images/fr01.svg
@@ -0,0 +1,7 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr010.svg b/loleaflet/dist/images/fr010.svg
new file mode 100644
index 0..5b5ede39f
--- /dev/null
+++ b/loleaflet/dist/images/fr010.svg
@@ -0,0 +1,10 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
+
diff --git a/loleaflet/dist/images/fr011.svg b/loleaflet/dist/images/fr011.svg
new file mode 100644
index 0..7452f5a41
--- /dev/null
+++ b/loleaflet/dist/images/fr011.svg
@@ -0,0 +1,10 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
+
diff --git a/loleaflet/dist/images/fr012.svg b/loleaflet/dist/images/fr012.svg
new file mode 100644
index 0..9cde5ef00
--- /dev/null
+++ b/loleaflet/dist/images/fr012.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr02.svg b/loleaflet/dist/images/fr02.svg
new file mode 100644
index 0..b71acc0f1
--- /dev/null
+++ b/loleaflet/dist/images/fr02.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr03.svg b/loleaflet/dist/images/fr03.svg
new file mode 100644
index 0..8fcca7d78
--- /dev/null
+++ b/loleaflet/dist/images/fr03.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr04.svg b/loleaflet/dist/images/fr04.svg
new file mode 100644
index 0..63a82d6b8
--- /dev/null
+++ b/loleaflet/dist/images/fr04.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr05.svg b/loleaflet/dist/images/fr05.svg
new file mode 100644
index 0..b1f193391
--- /dev/null
+++ b/loleaflet/dist/images/fr05.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr06.svg b/loleaflet/dist/images/fr06.svg
new file mode 100644
index 0..70f392ffe
--- /dev/null
+++ b/loleaflet/dist/images/fr06.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr07.svg b/loleaflet/dist/images/fr07.svg
new file mode 100644
index 0..01d35e146
--- /dev/null
+++ b/loleaflet/dist/images/fr07.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr08.svg b/loleaflet/dist/images/fr08.svg
new file mode 100644
index 0..0942743f3
--- /dev/null
+++ b/loleaflet/dist/images/fr08.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/fr09.svg b/loleaflet/dist/images/fr09.svg
new file mode 100644
index 0..8241031d3
--- /dev/null
+++ b/loleaflet/dist/images/fr09.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
diff --git a/loleaflet/dist/images/lc_setborderstyle.svg
b/loleaflet/dist/images/lc_setborderstyle.svg
new file mode 100644
index 0..93e3cf682
--- /dev/null
+++ b/loleaflet/dist/images/lc_setborderstyle.svg
@@ -0,0 +1,10 @@
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+
+
+
diff --git a/loleaflet/dist/toolbar.css b/loleaflet/dist/toolbar.css
index 9d04ed1bc..0ea6834a0 100644
--- a/loleaflet/dist/toolbar.css
+++ b/loleaflet/dist/toolbar.css
@@ -257,6 +257,27 @@ button.leaflet-control-search-next
border-style: solid;
}
+.w2ui-icon.frame01 { background: url('../images/fr01.svg') no-repeat center
!important; }
+.w2ui-icon.frame02 { background:
[Libreoffice-commits] core.git: framework/source
framework/source/loadenv/loadenv.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 1115a60e6d825c049680e7f2caf318e36d481b12
Author: Samuel Mehrbrodt
Date: Tue Jun 19 11:47:08 2018 +0200
tdf#118238 Only disable UI interaction when loading document as hidden
The "quiet" interaction handler was used unconditionally
when loading a document via the loadComponentFromURL API method.
So no dialog was shown asking the user whether he wants to enable macros.
With this patch, the "quiet" interaction handler is only used,
when the document was loaded with the "Hidden" property set.
Change-Id: Idd522d0bf605499b071390fb58312181b755dfca
Reviewed-on: https://gerrit.libreoffice.org/56086
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/framework/source/loadenv/loadenv.cxx
b/framework/source/loadenv/loadenv.cxx
index 4703d1cf5161..b527d0259e77 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -152,11 +153,18 @@ css::uno::Reference< css::lang::XComponent >
LoadEnv::loadComponentFromURL(const
{
LoadEnv aEnv(xContext);
+LoadEnvFeatures loadEnvFeatures = LoadEnvFeatures::WorkWithUI;
+comphelper::NamedValueCollection aDescriptor( lArgs );
+// tdf#118238 Only disable UI interaction when loading as hidden
+if (aDescriptor.get("Hidden") == uno::Any(true) ||
Application::IsHeadlessModeEnabled())
+loadEnvFeatures = LoadEnvFeatures::NONE;
+
aEnv.initializeLoading(sURL,
lArgs,
css::uno::Reference< css::frame::XFrame
>(xLoader, css::uno::UNO_QUERY),
sTarget,
- nFlags);
+ nFlags,
+ loadEnvFeatures);
aEnv.startLoading();
aEnv.waitWhileLoading(); // wait for ever!
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 --- Comment #23 from Eike Rathke --- (In reply to Heiko Tietze from comment #16) > Eike, what do you think? As Khaled already explained correctly in comment 15, the EditEngine is not always used, only if cell content contains inline formatting, fields, spell-check errors, line breaks, ..., or text is rotated. For all simple strings (text, numbers, formula results) the string is fed to OutputDevice for performance reasons. Using EditEngine unconditionally is not the way to go. Additionally, kerning attributes are kept only at EditEngine text objects, there are no cell format kerning attributes. What might be possible is for non-EditEngine cells tell OutputDevice to force kerning off via SalLayoutFlags::DisableKerning (I didn't track how exactly we call OutputDevice draws there). Just a quick idea.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 3 commits - desktop/CppunitTest_desktop_lokinit.mk desktop/inc desktop/Module_desktop.mk desktop/qa desktop/source
desktop/CppunitTest_desktop_lokinit.mk | 49 +++
desktop/Module_desktop.mk |1
desktop/inc/lib/init.hxx |6 +
desktop/qa/unit/desktop-lok-init.cxx | 140 +
desktop/source/lib/init.cxx| 83 ++-
5 files changed, 275 insertions(+), 4 deletions(-)
New commits:
commit 749780c9b5e2922417a7686efc3e4f609bb20264
Author: Jan Holesovsky
Date: Tue Jun 19 01:18:08 2018 +0200
lok: Unit test for passing table borders via jsonToPropertyValuesVector.
Change-Id: Iadc0d76a1903d76fcd84f316d4796cc1dec13277
diff --git a/desktop/CppunitTest_desktop_lokinit.mk
b/desktop/CppunitTest_desktop_lokinit.mk
index 91493dee4530..07d235861d90 100644
--- a/desktop/CppunitTest_desktop_lokinit.mk
+++ b/desktop/CppunitTest_desktop_lokinit.mk
@@ -19,6 +19,8 @@ $(eval $(call
gb_CppunitTest_use_external,desktop_lok_init,boost_headers))
$(eval $(call gb_CppunitTest_use_sdk_api,desktop_lok_init))
+$(eval $(call gb_CppunitTest_use_ure,desktop_lok_init))
+
$(eval $(call gb_CppunitTest_set_include,desktop_lok_init,\
-I$(SRCDIR)/desktop/source/inc \
-I$(SRCDIR)/desktop/inc \
diff --git a/desktop/qa/unit/desktop-lok-init.cxx
b/desktop/qa/unit/desktop-lok-init.cxx
index 07abe887ccfd..69c209e9055e 100644
--- a/desktop/qa/unit/desktop-lok-init.cxx
+++ b/desktop/qa/unit/desktop-lok-init.cxx
@@ -20,10 +20,13 @@
#include
#include
-#include
+#include
#include
+#include
+#include
+
using namespace css;
/// Unit tests for desktop/source/lib/init.cxx internals.
@@ -35,9 +38,11 @@ public:
}
void testJsonToPropertyValues();
+void testJsonToPropertyValuesBorder();
CPPUNIT_TEST_SUITE(LOKInitTest);
CPPUNIT_TEST(testJsonToPropertyValues);
+CPPUNIT_TEST(testJsonToPropertyValuesBorder);
CPPUNIT_TEST_SUITE_END();
};
@@ -70,6 +75,64 @@ void LOKInitTest::testJsonToPropertyValues()
assertSequencesEqual(aArgs,
comphelper::containerToSequence(desktop::jsonToPropertyValuesVector(arguments)));
}
+void LOKInitTest::testJsonToPropertyValuesBorder()
+{
+const char arguments[] = "{"
+"\"OuterBorder\": {"
+"\"type\" : \"[]any\","
+"\"value\" : ["
+"{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" :
{ \"Color\" : { \"type\" : \"com.sun.star.util.Color\", \"value\" : 0 },
\"InnerLineWidth\" : { \"type\" : \"short\", \"value\" : 0 },
\"OuterLineWidth\" : { \"type\" : \"short\", \"value\" : 1 }, \"LineDistance\"
: { \"type\" : \"short\", \"value\" : 0 }, \"LineStyle\" : { \"type\" :
\"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" : \"unsigned long\",
\"value\" : 1 } } },"
+"{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" :
{ \"Color\" : { \"type\" : \"com.sun.star.util.Color\", \"value\" : 0 },
\"InnerLineWidth\" : { \"type\" : \"short\", \"value\" : 0 },
\"OuterLineWidth\" : { \"type\" : \"short\", \"value\" : 1 }, \"LineDistance\"
: { \"type\" : \"short\", \"value\" : 0 }, \"LineStyle\" : { \"type\" :
\"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" : \"unsigned long\",
\"value\" : 1 } } },"
+"{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" :
{ \"Color\" : { \"type\" : \"com.sun.star.util.Color\", \"value\" : 0 },
\"InnerLineWidth\" : { \"type\" : \"short\", \"value\" : 0 },
\"OuterLineWidth\" : { \"type\" : \"short\", \"value\" : 1 }, \"LineDistance\"
: { \"type\" : \"short\", \"value\" : 0 }, \"LineStyle\" : { \"type\" :
\"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" : \"unsigned long\",
\"value\" : 1 } } },"
+"{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" :
{ \"Color\" : { \"type\" : \"com.sun.star.util.Color\", \"value\" : 0 },
\"InnerLineWidth\" : { \"type\" : \"short\", \"value\" : 0 },
\"OuterLineWidth\" : { \"type\" : \"short\", \"value\" : 1 }, \"LineDistance\"
: { \"type\" : \"short\", \"value\" : 0 }, \"LineStyle\" : { \"type\" :
\"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" : \"unsigned long\",
\"value\" : 1 } } },"
+"{ \"type\" : \"long\", \"value\" : 0 },"
+"{ \"type\" : \"long\", \"value\" : 0 },"
+"{ \"type\" : \"long\", \"value\" : 0 },"
+"{ \"type\" : \"long\", \"value\" : 0 },"
+"{ \"type\" : \"long\", \"value\" : 0 }"
+"]"
+"},"
+"\"InnerBorder\":{"
+"\"type\" : \"[]any\","
+"\"value\" : ["
+"{ \"type\" : \"com.sun.star.table.BorderLine2\", \"value\" :
{ \"Color\" : { \"type\" : \"com.sun.star.util.Color\", \"value\" : 0 },
\"InnerLineWidth\" : { \"type\" : \"short\", \"value\" : 0 },
\"OuterLineWidth\" : { \"type\" : \"short\", \"value\" : 1 }, \"LineDistance\"
: { \"type\" : \"short\", \"value\" : 0 }, \"LineStyle\" : { \"type\" :
\"short\", \"value\" : 0 }, \"LineWidth\" : { \"type\" : \"unsigned
[Libreoffice-bugs] [Bug 92032] Imported SVG images do not support blur / blurred shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=92032 --- Comment #5 from kompilainenn <79045_79...@mail.ru> --- still repro in LibreOffice 6.1 beta 2. There is shadows by cherry, but it are not blurred -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117576] Image inserted as PDF initially is stored as both PDF and PNG, but a Deletion and Undo of the image is restored as PNG with loss of the original PDF stream ( steps in c
https://bugs.documentfoundation.org/show_bug.cgi?id=117576 --- Comment #24 from opensuse.lietuviu.ka...@gmail.com --- Horever Serge Krot committed a patch related to tdf#115005 (Do not remove original vector images from slides) and pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=070f3db51da48c70cde12050c18fb03de2192c0f=libreoffice-6-0 That patch should affect 6.0.4, but as you see, we still have dublicate PNG issue after using PNG vector images. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 117745] Writer: Split Options/Formatting Aids/"Display of" to groups "Formatting Marks Toggle" and "Field Display"
https://bugs.documentfoundation.org/show_bug.cgi?id=117745 Heiko Tietze changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |tietze.he...@gmail.com |desktop.org | Keywords|needsUXEval | Status|NEW |ASSIGNED CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 117745] Writer: Split Options/Formatting Aids/"Display of" to groups "Formatting Marks Toggle" and "Field Display"
https://bugs.documentfoundation.org/show_bug.cgi?id=117745 Heiko Tietze changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |tietze.he...@gmail.com |desktop.org | Keywords|needsUXEval | Status|NEW |ASSIGNED CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90284] SVG export misses a text object
https://bugs.documentfoundation.org/show_bug.cgi?id=90284 --- Comment #9 from kompilainenn <79045_79...@mail.ru> --- still repro in LibreOffice 6.1 beta 2. Text in braces is missing in SVG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117576] Image inserted as PDF initially is stored as both PDF and PNG, but a Deletion and Undo of the image is restored as PNG with loss of the original PDF stream ( steps in c
https://bugs.documentfoundation.org/show_bug.cgi?id=117576 --- Comment #23 from opensuse.lietuviu.ka...@gmail.com --- Perhaps related change in LO 6.1/master was described in https://bugs.documentfoundation.org/show_bug.cgi?id=115005 comment #18 : Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=79b2f1cb36ea4fec61b0620085313eb53fce9fa0 tdf#115005 Do not remove original vector images from slides -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117074] ODT with svm become bigger in LibreOffice 6.0.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=117074 opensuse.lietuviu.ka...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7576 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117576] Image inserted as PDF initially is stored as both PDF and PNG, but a Deletion and Undo of the image is restored as PNG with loss of the original PDF stream ( steps in c
https://bugs.documentfoundation.org/show_bug.cgi?id=117576 opensuse.lietuviu.ka...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7074 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - filter/source include/sfx2 sfx2/source
filter/source/pdf/impdialog.cxx |4 ++--
filter/source/pdf/pdfdialog.cxx |2 --
filter/source/pdf/pdfinteract.cxx |5 ++---
include/sfx2/passwd.hxx |2 +-
sfx2/source/dialog/passwd.cxx |2 +-
5 files changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 2e752143b59945223a6d6852890547a9f134bdab
Author: Caolán McNamara
Date: Mon Jun 18 21:29:52 2018 +0100
tidy up setting parents
Change-Id: Ic0d30d066c76f2b30a5c4e6c864d80c8242c2444
Reviewed-on: https://gerrit.libreoffice.org/56082
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/filter/source/pdf/impdialog.cxx b/filter/source/pdf/impdialog.cxx
index 9080dcca72dc..a02784cb7c7c 100644
--- a/filter/source/pdf/impdialog.cxx
+++ b/filter/source/pdf/impdialog.cxx
@@ -830,7 +830,7 @@ IMPL_LINK_NOARG(ImpPDFTabGeneralPage, ToggleExportPDFAHdl,
weld::ToggleButton&,
// if a password was set, inform the user that this will not be used in
PDF/A case
if( mxCbPDFA1b->get_active() && pSecPage && pSecPage->hasPassword() )
{
-std::unique_ptr
xBox(Application::CreateMessageDialog(GetFrameWeld(),
+std::unique_ptr
xBox(Application::CreateMessageDialog(m_xContainer.get(),
VclMessageType::Warning,
VclButtonsType::Ok,
PDFFilterResId(STR_WARN_PASSWORD_PDFA)));
xBox->run();
@@ -1194,7 +1194,7 @@ void ImpPDFTabSecurityPage::SetFilterConfigItem( const
ImpPDFTabDialog* paParen
IMPL_LINK_NOARG(ImpPDFTabSecurityPage, ClickmaPbSetPwdHdl, weld::Button&, void)
{
-SfxPasswordDialog aPwdDialog(GetFrameWeld(), );
+SfxPasswordDialog aPwdDialog(m_xContainer.get(), );
aPwdDialog.SetMinLen(0);
aPwdDialog.ShowMinLengthText(false);
aPwdDialog.ShowExtras( SfxShowExtras::CONFIRM | SfxShowExtras::PASSWORD2 |
SfxShowExtras::CONFIRM2 );
diff --git a/filter/source/pdf/pdfdialog.cxx b/filter/source/pdf/pdfdialog.cxx
index f66eb343e0c5..22dacdc099ee 100644
--- a/filter/source/pdf/pdfdialog.cxx
+++ b/filter/source/pdf/pdfdialog.cxx
@@ -104,13 +104,11 @@ Reference< XPropertySetInfo > SAL_CALL
PDFDialog::getPropertySetInfo()
return xInfo;
}
-
::cppu::IPropertyArrayHelper& PDFDialog::getInfoHelper()
{
return *getArrayHelper();
}
-
::cppu::IPropertyArrayHelper* PDFDialog::createArrayHelper() const
{
Sequence< Property > aProps;
diff --git a/filter/source/pdf/pdfinteract.cxx
b/filter/source/pdf/pdfinteract.cxx
index a08221562141..802c7a65d83a 100644
--- a/filter/source/pdf/pdfinteract.cxx
+++ b/filter/source/pdf/pdfinteract.cxx
@@ -60,9 +60,8 @@ sal_Bool SAL_CALL
PDFInteractionHandler::handleInteractionRequest( const Referen
for( sal_Int32 i = 0; i < nCodes; i++ )
aCodes.insert(
static_cast(aExc.ErrorCodes.getConstArray()[i]) );
-VclPtr xParent(VCLUnoHelper::GetWindow(m_xParent));
-ImplErrorDialog aDlg(xParent ? xParent->GetFrameWeld() : nullptr,
aCodes);
-(void)aDlg.run();
+ImplErrorDialog aDlg(Application::GetFrameWeld(m_xParent), aCodes);
+aDlg.run();
bHandled = true;
}
return bHandled;
diff --git a/include/sfx2/passwd.hxx b/include/sfx2/passwd.hxx
index 4c8b7f15868c..a09364cf6918 100644
--- a/include/sfx2/passwd.hxx
+++ b/include/sfx2/passwd.hxx
@@ -80,7 +80,7 @@ private:
voidSetPasswdText();
public:
-SfxPasswordDialog(weld::Window* pParent, const OUString* pGroupText =
nullptr);
+SfxPasswordDialog(weld::Widget* pParent, const OUString* pGroupText =
nullptr);
OUString GetUser() const
{
diff --git a/sfx2/source/dialog/passwd.cxx b/sfx2/source/dialog/passwd.cxx
index 71df5e7d8d72..497deca9ccb7 100644
--- a/sfx2/source/dialog/passwd.cxx
+++ b/sfx2/source/dialog/passwd.cxx
@@ -81,7 +81,7 @@ IMPL_LINK_NOARG(SfxPasswordDialog, OKHdl, weld::Button&, void)
// CTOR / DTOR ---
-SfxPasswordDialog::SfxPasswordDialog(weld::Window* pParent, const OUString*
pGroupText)
+SfxPasswordDialog::SfxPasswordDialog(weld::Widget* pParent, const OUString*
pGroupText)
: GenericDialogController(pParent, "sfx/ui/password.ui", "PasswordDialog")
, m_xPassword1Box(m_xBuilder->weld_frame("password1frame"))
, m_xUserFT(m_xBuilder->weld_label("userft"))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-cd-3-2' - configure.ac wsd/LOOLWSD.cpp
configure.ac|2 ++
wsd/LOOLWSD.cpp | 14 --
2 files changed, 14 insertions(+), 2 deletions(-)
New commits:
commit 7e3d01535df6606eddee0c53adf07dcf8e83be10
Author: Ashod Nakashian
Date: Tue Jun 19 07:21:22 2018 -0400
wsd: force anonymization when enabled with configure
This prevents disabling from loolwsd.xml when
the flags to anonymize are baked in at compile time.
Change-Id: If38ad3815bc9f18ed51b6626fc8c03528e7b8327
Reviewed-on: https://gerrit.libreoffice.org/56089
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/configure.ac b/configure.ac
index 4635514a4..eda74b178 100644
--- a/configure.ac
+++ b/configure.ac
@@ -164,11 +164,13 @@ AC_SUBST(LOOLWSD_LOGFILE)
if test -n "$enable_anonymize_filenames" ; then
LOOLWSD_ANONYMIZE_FILENAMES=true
fi
+AC_DEFINE_UNQUOTED([LOOLWSD_ANONYMIZE_FILENAMES],[$LOOLWSD_ANONYMIZE_FILENAMES],[Enable
permanent filenames anonymization in logs])
AC_SUBST(LOOLWSD_ANONYMIZE_FILENAMES)
if test -n "$enable_anonymize_usernames" ; then
LOOLWSD_ANONYMIZE_USERNAMES=true
fi
+AC_DEFINE_UNQUOTED([LOOLWSD_ANONYMIZE_USERNAMES],[$LOOLWSD_ANONYMIZE_USERNAMES],[Enable
permanent usernames anonymization in logs])
AC_SUBST(LOOLWSD_ANONYMIZE_USERNAMES)
MAX_CONNECTIONS=20
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 0a7de556b..b22075b0e 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -762,10 +762,20 @@ void LOOLWSD::initialize(Application& self)
}
// Get anonymization settings.
-AnonymizeFilenames = getConfigValue(conf,
"logging.anonymize.filenames", false);
-setenv("LOOL_ANONYMIZE_FILENAMES", AnonymizeFilenames ? "1" : "0", true);
+#ifdef LOOLWSD_ANONYMIZE_USERNAMES
+AnonymizeUsernames = true;
+#else
AnonymizeUsernames = getConfigValue(conf,
"logging.anonymize.usernames", false);
+#endif
setenv("LOOL_ANONYMIZE_USERNAMES", AnonymizeUsernames ? "1" : "0", true);
+
+#ifdef LOOLWSD_ANONYMIZE_FILENAMES
+AnonymizeFilenames = true;
+#else
+AnonymizeFilenames = getConfigValue(conf,
"logging.anonymize.filenames", false);
+#endif
+setenv("LOOL_ANONYMIZE_FILENAMES", AnonymizeFilenames ? "1" : "0", true);
+
if (AnonymizeFilenames || AnonymizeUsernames)
{
if (LogLevel == "trace")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104918] LibreOffice SQL parser chokes on Firebird's DATEDIFF syntax, making use impossible in normal (non-direct SQL) queries
https://bugs.documentfoundation.org/show_bug.cgi?id=104918 --- Comment #18 from Gerhard Schaber --- The same happens with DATEADD, by the way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88278] [META] insert SVG image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Bug 88278 depends on bug 87969, which changed state. Bug 87969 Summary: Incomplete display of imported .svg file with zoom levels > 110% https://bugs.documentfoundation.org/show_bug.cgi?id=87969 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87969] Incomplete display of imported .svg file with zoom levels > 110%
https://bugs.documentfoundation.org/show_bug.cgi?id=87969 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100925] When overwriting a cell, new content is displayed on top of the old content until finishing the edit
https://bugs.documentfoundation.org/show_bug.cgi?id=100925 --- Comment #96 from gust...@angulosolido.pt --- A fix for this problem on Ubuntu 16.04 with KDE and using the default version of Libreoffice shipped with Ubuntu: -- Section "Device" Identifier "card0" Driver "intel" Option "AccelMethod" "blt" EndSection at /usr/share/X11/xorg.conf.d/20-intel.conf. You also may want to go to systemsetting -> desktop behaviour -> desktop effects and uncheck the window maximize effect, just because this effect gets a little funky with the blt AccelMethod (just a tiny little glitch compared to the huge usability problem reported here). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87969] Incomplete display of imported .svg file with zoom levels > 110%
https://bugs.documentfoundation.org/show_bug.cgi?id=87969 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #20 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142911 --> https://bugs.documentfoundation.org/attachment.cgi?id=142911=edit SVG in LO Writer 6.1 beta 2 SVG opens very fast and looks fine in LO Writer 6.1 beta 2 Status -> WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118212] Launching Character dialog from any module crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=118212 --- Comment #11 from Tomaz Vajngerl --- Now I know which bug number to put in the fix :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118239] New: Short cuts – allow for actions in reverse ways.
https://bugs.documentfoundation.org/show_bug.cgi?id=118239 Bug ID: 118239 Summary: Short cuts – allow for actions in reverse ways. Product: LibreOffice Version: 6.0.4.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ricky.t...@gmail.com Description: Short-cuts are at best one-way commands. Such behaviour have an immediate negative effect on productivity. Description applies to any objects that fill the following requirement: Tool opening in a dedicated tool-bar or tool-window and for which a short-cut association does exist. Steps to Reproduce: Use any short-cut eligible as relevant object as above described; be it the tool Find-and-replace (key combination: Ctrl+H). Actual Results: Execution of such combination acts exclusively as an order either for displaying a tool-bar or opening a tool-window. In order to achieve the reverse effect –the closure of a tool-bar or tool-window–, a manual action applying to the respective Close icon is required. Expected Results: As a general enhancement aiming to a better productivity, such short-cuts to act in reverse ways. According to the tools involved, the execution of those short-cuts would be appropriate to act as commands that either display a tool-bar or open a tool-window, or remove a displayed tool-bar or close a tool-window. Illustration: e.g. 'Ctrl+H' may act as a command for either opening or closing its associated tool-window. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.4.2 Build ID: 6.0.4.2-4.fc28 CPU threads: 2; OS: Linux 4.16; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86938] inserted svg-image gets mangled
https://bugs.documentfoundation.org/show_bug.cgi?id=86938 --- Comment #9 from kompilainenn <79045_79...@mail.ru> --- still repro in LibreOffice 6.1 beta 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 Eike Rathke changed: What|Removed |Added Attachment #142904|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 Eike Rathke changed: What|Removed |Added Attachment #142864|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118221] Calc fails to render kerning=off (default setting) for single-line cells, only works during cell edit mode [F2] (affects screen, paper and PDF) [Comment 15]
https://bugs.documentfoundation.org/show_bug.cgi?id=118221 Eike Rathke changed: What|Removed |Added Attachment #142846|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118212] Launching Character dialog from any module crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=118212 Aron Budea changed: What|Removed |Added OS|Windows (All) |All --- Comment #10 from Aron Budea --- (In reply to Tomaz Vajngerl from comment #9) > Does it crash only when you have Asian / CTL disabled? Indeed, that seems to be the case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118223] PPTX slide not opening properly. There are missing elements when the slide is converted from PPTX to PDF using LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=118223 --- Comment #2 from Aakash --- The original PPTX file was created in Microsoft Powerpoint. If you try opening it with Powerpoint, the table should show up. As per our project requirements, we need to convert all PPTX to PDF format. Looks like only the PPTX is causing this issue. "Seems the borders are imported as 'Set No Borders'." Might seem like a noob query but can you please tell me how to prevent the borders from being imported as 'Set No Borders'? (In reply to MM from comment #1) > On windows 7 x64 with Version: 6.0.5.1 (x64) > Build ID: 0588a1cb9a40c4a6a029e1d442a2b9767d612751 > CPU threads: 3; OS: Windows 6.1; UI render: default > > When importing, i'm not seeing *any* tables unless I grab a [field] text and > drag downwards. Then suddenly a table becomes visible. Seems the borders are > imported as 'Set No Borders'. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83426] SVG's Load Slowly
https://bugs.documentfoundation.org/show_bug.cgi?id=83426 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #14 from kompilainenn <79045_79...@mail.ru> --- I opened both files from attach in LibreOffice 6.1 beta 2. There is delay when presentation opens, but changing of slide occurs very fast. I made it on Intel Core i-3 3120M 2,5 GHz with 4Gb of memory (notebook) My opinion -> WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118212] Launching Character dialog from any module crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=118212 --- Comment #9 from Tomaz Vajngerl --- Does it crash only when you have Asian / CTL disabled? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/inc sw/source sw/uiconfig
sw/inc/swabstdlg.hxx|2
sw/source/ui/dialog/swdlgfact.cxx |5 -
sw/source/ui/dialog/swdlgfact.hxx |2
sw/source/ui/misc/titlepage.cxx | 148 ++--
sw/source/uibase/inc/titlepage.hxx | 55 +
sw/source/uibase/shells/basesh.cxx | 28 +-
sw/uiconfig/swriter/ui/titlepage.ui | 53 +---
7 files changed, 135 insertions(+), 158 deletions(-)
New commits:
commit 04c041491983ec1f7bd71b965a55255ec0e3ea51
Author: Caolán McNamara
Date: Mon Jun 18 16:18:03 2018 +0100
weld SwTitlePageDlg
Change-Id: I16a82709f49ed9e85751afd8c8001705c40a6e6d
Reviewed-on: https://gerrit.libreoffice.org/56063
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 5caf37cb4c5b..9d6e4dbf147c 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -449,7 +449,7 @@ public:
SwWrtShell , SwField* pField, bool bPrevButton, bool bNextButton)
= 0;
virtual VclPtr
CreateInsFootNoteDlg(weld::Window * pParent,
SwWrtShell , bool bEd = false) = 0;
-virtual VclPtr CreateTitlePageDlg (
vcl::Window * pParent ) = 0;
+virtual VclPtr
CreateTitlePageDlg(weld::Window* pParent) = 0;
virtual VclPtr CreateVclSwViewDialog(SwView&
rView) = 0;
virtual VclPtrCreateInsTableDlg(SwView&
rView) = 0;
virtual VclPtr
CreateJavaEditDialog(weld::Window* pParent,
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index b623c5d81a87..ae69d4b54f04 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -949,10 +949,9 @@ VclPtr
SwAbstractDialogFactory_Impl::CreateInsFootNoteDl
return VclPtr::Create(new
SwInsFootNoteDlg(pParent, rSh, bEd));
}
-VclPtr SwAbstractDialogFactory_Impl::CreateTitlePageDlg (
vcl::Window *pParent )
+VclPtr
SwAbstractDialogFactory_Impl::CreateTitlePageDlg(weld::Window *pParent)
{
-VclPtr pDlg = VclPtr::Create( pParent );
-return VclPtr::Create( pDlg );
+return VclPtr::Create(new
SwTitlePageDlg(pParent));
}
VclPtr
SwAbstractDialogFactory_Impl::CreateVclSwViewDialog(SwView& rView)
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 60b7072bf4a1..a06afd8175b6 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -622,7 +622,7 @@ public:
SwWrtShell , SwField* pField, bool bPrevButton, bool bNextButton)
override;
virtual VclPtr CreateInsFootNoteDlg(
weld::Window * pParent, SwWrtShell , bool bEd = false) override;
-virtual VclPtr CreateTitlePageDlg ( vcl::Window
* pParent ) override;
+virtual VclPtr CreateTitlePageDlg(weld::Window*
pParent) override;
virtual VclPtr CreateVclSwViewDialog(SwView&
rView) override;
virtual VclPtrCreateInsTableDlg(SwView&
rView) override;
virtual VclPtr
CreateJavaEditDialog(weld::Window* pParent,
diff --git a/sw/source/ui/misc/titlepage.cxx b/sw/source/ui/misc/titlepage.cxx
index 4d21a57850fa..36034678463b 100644
--- a/sw/source/ui/misc/titlepage.cxx
+++ b/sw/source/ui/misc/titlepage.cxx
@@ -130,45 +130,44 @@ namespace
*/
void SwTitlePageDlg::FillList()
{
-sal_uInt16 nTitlePages = m_pPageCountNF->GetValue();
-m_pPagePropertiesLB->Clear();
+sal_uInt16 nTitlePages = m_xPageCountNF->get_value();
+m_xPagePropertiesLB->clear();
if (mpTitleDesc)
-m_pPagePropertiesLB->InsertEntry(mpTitleDesc->GetName());
+m_xPagePropertiesLB->append_text(mpTitleDesc->GetName());
if (nTitlePages > 1 && mpIndexDesc)
-m_pPagePropertiesLB->InsertEntry(mpIndexDesc->GetName());
+m_xPagePropertiesLB->append_text(mpIndexDesc->GetName());
if (mpNormalDesc)
-m_pPagePropertiesLB->InsertEntry(mpNormalDesc->GetName());
-m_pPagePropertiesLB->SelectEntryPos(0);
+m_xPagePropertiesLB->append_text(mpNormalDesc->GetName());
+m_xPagePropertiesLB->set_active(0);
}
sal_uInt16 SwTitlePageDlg::GetInsertPosition() const
{
sal_uInt16 nPage = 1;
-if (m_pPageStartNF->IsEnabled())
-nPage = m_pPageStartNF->GetValue();
+if (m_xPageStartNF->get_sensitive())
+nPage = m_xPageStartNF->get_value();
return nPage;
}
-SwTitlePageDlg::SwTitlePageDlg( vcl::Window *pParent ) :
-SfxModalDialog( pParent, "DLG_TITLEPAGE",
"modules/swriter/ui/titlepage.ui"),
-mpPageFormatDesc(nullptr)
+SwTitlePageDlg::SwTitlePageDlg(weld::Window *pParent)
+: GenericDialogController(pParent, "modules/swriter/ui/titlepage.ui",
"DLG_TITLEPAGE")
+, mpPageFormatDesc(nullptr)
+,
m_xUseExistingPagesRB(m_xBuilder->weld_radio_button("RB_USE_EXISTING_PAGES"))
+, m_xPageCountNF(m_xBuilder->weld_spin_button("NF_PAGE_COUNT"))
+, m_xDocumentStartRB(m_xBuilder->weld_radio_button("RB_DOCUMENT_START"))
[Libreoffice-commits] core.git: sal/Library_sal.mk sal/osl
sal/Library_sal.mk |5 +++-- sal/osl/unx/system.cxx | 13 + sal/osl/unx/system.mm |1 + 3 files changed, 17 insertions(+), 2 deletions(-) New commits: commit 3b6905e37a6baac08eaff00e6e42aced7d6896df Author: Tor Lillqvist Date: Tue Jun 19 10:02:42 2018 +0300 Don't waste time in macxp_resolveAlias() on files inside the app bundle LibreOffice uses its low-level API to look up files inside the app bundle thousands of times, all the time, and especially when starting something. Both when the process starts, and when a specific aspects of the application starts (like after typing a first character into a Writer document in a session). Having all those, too, go through this alias (bookmark) resolve dance is just insane. There won't be any aliases (bookmarks) there. This shaves almost a second from the delay after typing the first character into a Writer document in a session. There is still a noticeable delay left, though, likely mostly caused by Python (Lightproof) initialisation slowness. (It's cross-platform.) I would say that it is a bit questionable whether the macxp_resolveAlias() functionality is worth it at all, even. Change-Id: I2461141c6b58738befd0db4902eb25e63b788b79 diff --git a/sal/Library_sal.mk b/sal/Library_sal.mk index d33719097c9d..0227d6ffe32c 100644 --- a/sal/Library_sal.mk +++ b/sal/Library_sal.mk @@ -179,21 +179,22 @@ $(eval $(call gb_Library_add_exception_objects,sal,\ sal/osl/unx/security \ sal/osl/unx/signal \ sal/osl/unx/socket \ - sal/osl/unx/system \ sal/osl/unx/tempfile \ sal/osl/unx/thread \ sal/osl/unx/time \ $(if $(filter-out ANDROID IOS,$(OS)), sal/osl/unx/salinit) \ )) -# Note that the uunxapi.mm file just includes the uunxapi.cxx one +# Note that the uunxapi.mm file just includes the uunxapi.cxx one. Ditto for system.mm ifeq ($(OS),MACOSX) $(eval $(call gb_Library_add_objcxxobjects,sal,\ sal/osl/unx/uunxapi \ + sal/osl/unx/system \ )) else $(eval $(call gb_Library_add_exception_objects,sal,\ sal/osl/unx/uunxapi \ + sal/osl/unx/system \ )) endif diff --git a/sal/osl/unx/system.cxx b/sal/osl/unx/system.cxx index aacd91a1290a..dee35f5c3b92 100644 --- a/sal/osl/unx/system.cxx +++ b/sal/osl/unx/system.cxx @@ -37,6 +37,10 @@ #define RTL_MUTEX_LOCK #define RTL_MUTEX_UNLOCK +#include +#include +#include + #else //defined(MACOSX) static pthread_mutex_t getrtl_mutex = PTHREAD_MUTEX_INITIALIZER; @@ -162,6 +166,15 @@ int macxp_resolveAlias(char *path, int buflen) CFErrorRef cferror; CFDataRef cfbookmark; + // Don't even try anything for files inside the app bundle. Just a + // waste of time. + + static const char * const appBundle = [[[NSBundle mainBundle] bundlePath] UTF8String]; + + const size_t appBundleLen = strlen(appBundle); + if (strncmp(path, appBundle, appBundleLen) == 0 && path[appBundleLen] == '/') + return 0; + char *unprocessedPath = path; if ( *unprocessedPath == '/' ) diff --git a/sal/osl/unx/system.mm b/sal/osl/unx/system.mm new file mode 100644 index ..7495a3e73058 --- /dev/null +++ b/sal/osl/unx/system.mm @@ -0,0 +1 @@ +#include "system.cxx" ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice ESC call, Thur - 16:00 central European (local) time
Hi guys, Prototype agenda below, bug metrics also at the link below; extra items appreciated as last-week: https://demo.collaboracloudsuite.com/tdf/ Lets persevere with the jitsi goodness this week too at: https://meet.jit.si/TDFESC ATB, Michael. * Completed Action Items: * Pending Action Items: + disable HSQLDB auto-migration for now except for experimental (Tamas B) * Release Engineering update (Christian) + no releases planned this week. + 6.0.5 – RC2 status + 6.1.0 beta 2 status + 6.1 late features + calc threading default / fixing (Miklos) + ongoing – more fixes this week. + writer – red-lining re-factoring (Michael S) + . + Help format (Stephan) + + Get-involved info-bar & Help/About menu (Kendy) + merged. + Remotes + Android viewer + Online * Documentation (Olivier) * UX Update (Heiko) + Bugzilla (topicUI) statistics 246(246) (topicUI) bugs open, 290(290) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week 1 month 3 months 12 months added 5(5) 5(3) 21(1) 87(-1) commented 23(10) 48(2) 315(-26) 1694(-43) removed 0(0) 0(0) 1(-1) 10(-1) resolved 1(0) 4(0) 24(-1) 172(-3) + top 10 contributors: Tietze, Heiko made 19 changes in 1 month, and 741 changes in 1 year Kainz, Andreas made 17 changes in 1 month, and 36 changes in 1 year Thomas Lendo made 13 changes in 1 month, and 300 changes in 1 year Xisco Faulí made 10 changes in 1 month, and 321 changes in 1 year dieterp made 8 changes in 1 month, and 129 changes in 1 year Timur made 7 changes in 1 month, and 48 changes in 1 year Foote, V Stuart made 6 changes in 1 month, and 241 changes in 1 year Raal made 6 changes in 1 month, and 17 changes in 1 year Buovjaga made 4 changes in 1 month, and 158 changes in 1 year eisa01 made 4 changes in 1 month, and 7 changes in 1 year * Fuzz / Crash Testing (Caolan) + 12(-50) import failures, 5(+2) export failures + 1 import, 2 exports – mst layout assert + 1 import failure is Bjoern refactor related + ~4 calc import failures with null ScPatternAttr, etc + ooo33510-1.sxc failure bisected to 1e55a47e89a9d9d6cf9cb3993484022aaf2c097b tdf#62268: allow row height recalculation on document load, but looks innocent to me, so something underlying brought to the surface by that ? + coverity + ?? 4 (+2, -13) + forcepoint round 7. + ?? + oss-fuzz ?? (13 outstanding, 11 minor, lots of font cache unreproducibles + but not in last two days, maybe noel rtl::Reference change fixed it * Crash Reporting (Xisco) + http://crashreport.libreoffice.org/stats/version/5.4.6.2 + 517 (last 7 days) (-30) + http://crashreport.libreoffice.org/stats/version/5.4.7.2 + 524 (last 7 days) (+35) + http://crashreport.libreoffice.org/stats/version/6.0.3.2 + 947 (last 7 days) (-46) + http://crashreport.libreoffice.org/stats/version/6.0.4.2 + 1961 (last 7 days) (+168) + MultiSalLayout::AdjustLayout(ImplLayoutArgs &) + not backported to 6.0.5 – pity + ping Tamas Bunth? * Alpha bitmap progress (Michael) + quick update ? * Budget ranking (Thorsten) + on ESC share - “Budget2018” - add your ranking. + please rank stuff ... * GSoC schedule (Heiko) + Coding: May 14 - August 6 + please tell students to send a weekly status update. + apparently going well ... + Evaluation 1: June 11 – 15 + all mentors should be informed and working on that + no problems reported to Heiko + Evaluation 2: July 9 - 13 + Students Submit Code and Final Evaluations: August 6 - 14 + Mentors Submit Final Evaluations: August 14 - 21 + Results Announced: August 22 + https://wiki.documentfoundation.org/Development/GSoC/2018 * Hackfests & Events + working on a Munich event end of October (Thorsten) + an Open Gov’t meeting from the City of Munich + good to have a hack-fest back-to-back there. + potentially one in Switzerland later in the year / November + call for papers for the LibreOffice Conference still ongoing! (Sophie) + deadline: mid-July * mentoring/easyhack update committer... 1 week 1 month 3 months12 months open 90(-9) 150(15) 161(17) 165(18) reviews 1548(953)2800(1102) 5740(908) 19079(1070) merged 342(88) 1202(98) 3455(-17) 13499(145) abandoned 27(11) 77(-71) 276(8) 983(22) own commits
[Libreoffice-bugs] [Bug 81561] SVG: Text dropped when exporting embedded spreadsheet as svg from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=81561 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from kompilainenn <79045_79...@mail.ru> --- looks fine if make export from LibreOffice Draw 6.1 beta 2 Status -> WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88278] [META] insert SVG image filter (all modules)
https://bugs.documentfoundation.org/show_bug.cgi?id=88278 Bug 88278 depends on bug 81561, which changed state. Bug 81561 Summary: SVG: Text dropped when exporting embedded spreadsheet as svg from Draw https://bugs.documentfoundation.org/show_bug.cgi?id=81561 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81561] SVG: Text dropped when exporting embedded spreadsheet as svg from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=81561 --- Comment #9 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142910 --> https://bugs.documentfoundation.org/attachment.cgi?id=142910=edit svg from LO Draw 6.1 beta 2 in Chrome -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81561] SVG: Text dropped when exporting embedded spreadsheet as svg from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=81561 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #8 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142909 --> https://bugs.documentfoundation.org/attachment.cgi?id=142909=edit result of export to SVG from LO Draw 6.1 beta 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/docmacromode.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 68573b6e0668d2b8bb8c59a864d349d503d8422d Author: Samuel Mehrbrodt Date: Tue Jun 19 09:41:42 2018 +0200 Fix typo Change-Id: I57a5d3b1dcffba4c439a2f3817e8661c605e1b5f Reviewed-on: https://gerrit.libreoffice.org/56085 Reviewed-by: Samuel Mehrbrodt Tested-by: Samuel Mehrbrodt diff --git a/sfx2/source/doc/docmacromode.cxx b/sfx2/source/doc/docmacromode.cxx index c62a5ab87d9a..4872fc90496b 100644 --- a/sfx2/source/doc/docmacromode.cxx +++ b/sfx2/source/doc/docmacromode.cxx @@ -265,7 +265,7 @@ namespace sfx2 } } -// conformation is required +// confirmation is required bool bSecure = false; if ( eAutoConfirm == eNoAutoConfirm ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
