date:20180704

https://bugs.documentfoundation.org/show_bug.cgi?id=43438

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #17 from Mike Kaganski  ---
https://gerrit.libreoffice.org/56985

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118544] New: Optional macro parameter defined as Integer has type Variant/String causing type errors in the macro

https://bugs.documentfoundation.org/show_bug.cgi?id=118544

Bug ID: 118544
   Summary: Optional macro parameter defined as Integer has type
Variant/String causing type errors in the macro
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugsinlibreoff...@ecloud-business-solutions.com

Description:
In the macro below, we define the optional parameter 'length' as type Integer
with default value 32.

Yet the msgbox appears saying "Huh - why is length not of type integer" and
the debugger indicates Variant/String value "32"?

Then we get type error on the following line to calc the value of msb as length
is (somehow?) a Variant/String.

How is this possible?

Option Compatible 'Needed for the default value assignment in the function
definition on the next line
Function BitShiftWithWrapAround(cell as Double,shift As Integer, Optional
length As Integer=32)

CompatibilityMode(True) 'This line makes no difference
Dim result as Double

result = cell

' Before the next line executes, debugger shows length as "", type String - huh?
if not (typename(length)="Integer") then
' Yet here the type magically becomes Variant/String and the value
suddenly becomes "32" as a string
msgbox "Huh - why is length not of type integer"
end if

' Even stranger, now the type suddenly becomes Integer, value 32
msb = 2^(length-1)

   ' Remainder not included in this bug report- we don't make it past the line
above UNLESS the
   ' if - end if secton immediately above it is included.

   ' To make this function run we need a return value. Just return the msb for
now until this bug is sorted.
   return msb

end Function

Now for the really crazy part - if we remove the section:
  if not typename...
   msgbox ...
  end if

..then we get an LO macro error on the msb = ... line like so:
Inadmissible value or data type.
Data type mismatch.

This is crazy - testing the typename changes the type Not testing it
doesn't???

That reeks of side effects.

Steps to Reproduce:
1. Create macro - cut and paste from "Option Compatible" to "end Function"
2. Put a formula in a cell '=BitShiftWithWrapAround(2025167957,-1)'
3. Observe how the msgbox appears, and note the function still works.
4. Remove (or comment out) the 3 lines immediately before msb=
5. Repeat step 2.
6. Observe how an LO Macro error occurs, totally breaking the macro.

Actual Results:
Inadmissible value or data type.
Data type mismatch.

Expected Results:
Function should return 4050335914 (=2025167957 >> 1 with wraparound)

We didn't include the code to do this because we cannot get past the type
mismatch error without including unnecesary code before it, which appears to
produce a side effect.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 4.2.8.2
Build ID: 420m0(Build:2)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107830] [META] DOCX (OOXML) paragraph-related issues

https://bugs.documentfoundation.org/show_bug.cgi?id=107830
Bug 107830 depends on bug 82175, which changed state.

Bug 82175 Summary: FILEOPEN: DOCX - Line spacing isn't imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=82175

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108760] [META] DOCX (OOXML) style bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=108760
Bug 108760 depends on bug 82175, which changed state.

Bug 82175 Summary: FILEOPEN: DOCX - Line spacing isn't imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=82175

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: writerfilter/source

2018-07-04 Thread Justin Luth

 writerfilter/source/dmapper/StyleSheetTable.cxx |   15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)

New commits:
commit 961908dde51e44b93567cb59bd398778fe1ece10
Author: Justin Luth 
Date:   Wed Jul 4 07:26:36 2018 +0300

related tdf#82175 writerfilter: use docDefault, not w:default

Commit b8fa3952 for tdf#104713, added this w:default test to only
override style inheritance on well-formed documents (i.e. all default
values have been specified in the document. Otherwise the document
will have no defaults at all).

However, checking on w:default is not the best test of a well-formed
document. W:default had no impact on inheritance anyway, so it was a
bad test, and if we used that, shouldn't we setParent to
the default style instead of assuming it is "Standard"?
Besides, FindDefaultParaStyle() already exists, so a
separate boolean value wasn't necessary in that scenario.

So lots of reasons to tweak my old commit. It is prep work
for setting the parent to -none- instead of "Standard".

Change-Id: I0846c09775c9a86b506f13e3588aab437a9a93cc
Reviewed-on: https://gerrit.libreoffice.org/56824
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx 
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 7bb43fe5c6de..5d65e9339a28 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -258,7 +258,7 @@ struct StyleSheetTable_Impl
 /// Style names which should not be used without a " (user)" suffix.
 std::set  m_aReservedStyleNames;
 ListCharStylePropertyVector_t   m_aListCharStylePropertyVector;
-boolm_bHasImportedDefaultParaStyle;
+boolm_bHasImportedDefaultParaProps;
 boolm_bIsNewDoc;
 
 StyleSheetTable_Impl(DomainMapper& rDMapper, uno::Reference< 
text::XTextDocument> const& xTextDocument, bool bIsNewDoc);
@@ -281,7 +281,7 @@ StyleSheetTable_Impl::StyleSheetTable_Impl(DomainMapper& 
rDMapper,
 m_pCurrentEntry(),
 m_pDefaultParaProps(new PropertyMap),
 m_pDefaultCharProps(new PropertyMap),
-m_bHasImportedDefaultParaStyle(false),
+m_bHasImportedDefaultParaProps(false),
 m_bIsNewDoc(bIsNewDoc)
 {
 //set font height default to 10pt
@@ -452,8 +452,6 @@ void StyleSheetTable::lcl_attribute(Id Name, Value & val)
 break;
 case NS_ooxml::LN_CT_Style_default:
 m_pImpl->m_pCurrentEntry->bIsDefaultStyle = (nIntValue != 0);
-if (m_pImpl->m_pCurrentEntry->bIsDefaultStyle && 
m_pImpl->m_pCurrentEntry->nStyleTypeCode == STYLE_TYPE_PARA)
-m_pImpl->m_bHasImportedDefaultParaStyle = true;
 
 if (m_pImpl->m_pCurrentEntry->nStyleTypeCode != STYLE_TYPE_UNKNOWN)
 {
@@ -678,6 +676,7 @@ void StyleSheetTable::lcl_sprm(Sprm & rSprm)
 resolveSprmProps( m_pImpl->m_rDMapper, rSprm );
 m_pImpl->m_rDMapper.PopStyleSheetProperties();
 applyDefaults( true );
+m_pImpl->m_bHasImportedDefaultParaProps = true;
 break;
 case NS_ooxml::LN_CT_RPrDefault_rPr:
 case NS_ooxml::LN_CT_DocDefaults_rPrDefault:
@@ -933,10 +932,10 @@ void StyleSheetTable::ApplyStyleSheets( const 
FontTablePtr& rFontTable )
 {
 
StyleSheetTable_Impl::SetPropertiesToDefault(xStyle);
 
-// resolve import conflicts with built-in styles 
(only if normal style has been defined)
-if( m_pImpl->m_bHasImportedDefaultParaStyle
-&& pEntry->sBaseStyleIdentifier.isEmpty()
-&& !xStyle->getParentStyle().isEmpty() )
+// resolve import conflicts with built-in styles 
(only if defaults have been defined)
+if ( m_pImpl->m_bHasImportedDefaultParaProps
+&& pEntry->sBaseStyleIdentifier.isEmpty()   
//imported style has no inheritance
+&& !xStyle->getParentStyle().isEmpty() )
//built-in style has a default inheritance
 {
 xStyle->setParentStyle( "" );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places

https://bugs.documentfoundation.org/show_bug.cgi?id=105225

--- Comment #58 from Jim Raykowski  ---
Hi Eike, 

I'm at bit of a loss how that got by me. Need the XATTR_FILLSTYLE attribute in
the passed itemset here to let the area tab page know what background/area sub
tab page to select on invocation. Thanks for letting me know.

Here is the patch:
https://gerrit.libreoffice.org/#/c/56983/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77352] EDITING: Copying cell range with chart results in incorrect clipboard data

https://bugs.documentfoundation.org/show_bug.cgi?id=77352

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104836] Draw dimension line measurement changes from cm to mm when copying to Writer

https://bugs.documentfoundation.org/show_bug.cgi?id=104836

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43023] EDITING: Undo stack deleted after Drag from Navigator "As Copy" or "As Link"

https://bugs.documentfoundation.org/show_bug.cgi?id=43023

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81792] Master document incorrectly printing/exporting document with tables and footnotes

https://bugs.documentfoundation.org/show_bug.cgi?id=81792

--- Comment #15 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54465] FORMATTING: Inserting footnote in section (with columns), make that sections size grow to the full page

https://bugs.documentfoundation.org/show_bug.cgi?id=54465

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69679] EDITING: Problem in Copy-Paste when text contains characters with code 0Dh

https://bugs.documentfoundation.org/show_bug.cgi?id=69679

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106307] Wrong shape for numerals, based on locale and not the text language

https://bugs.documentfoundation.org/show_bug.cgi?id=106307

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81085] EDITING: Slides copied from a pptx presentation are sometimes duplicated or fail to copy

https://bugs.documentfoundation.org/show_bug.cgi?id=81085

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106153] Text boxes overlapping the page borders are handled wrong

https://bugs.documentfoundation.org/show_bug.cgi?id=106153

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97993] EDITING: Copy and Paste for Images / Shapes Wonky in Writer

https://bugs.documentfoundation.org/show_bug.cgi?id=97993

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105327] Two small lines at the screen page border when inserting a footnote

https://bugs.documentfoundation.org/show_bug.cgi?id=105327

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84973] "Date (fix)" fields updated when copy of document opened

https://bugs.documentfoundation.org/show_bug.cgi?id=84973

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
Bug 102998 depends on bug 116543, which changed state.

Bug 116543 Summary: Crash (fatal error) when attempting a mail merge print ( 
only the first time the connection is done)
https://bugs.documentfoundation.org/show_bug.cgi?id=116543

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2018-07-04 Thread Mike Kaganski

 sw/source/ui/fldui/flddb.cxx |   20 +++-
 1 file changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 54d76f5203aa5f3ef0e5afdca9d131dadeb3794e
Author: Mike Kaganski 
Date:   Wed Jul 4 01:33:38 2018 +1000

tdf#116543: don't forget to commit registrations in DB field editor

This avoids revoking the uncommitted registration when any mailmerge
doc is destroyed.

Also don't forget to pass relevant SwDocShell when registering data
source. This allows to register the data source for current document.

Change-Id: Id89be82b0120661700e9fee6a075e5877d76e3b0
Reviewed-on: https://gerrit.libreoffice.org/56891
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/source/ui/fldui/flddb.cxx b/sw/source/ui/fldui/flddb.cxx
index 6da535c89b69..7447a7708c87 100644
--- a/sw/source/ui/fldui/flddb.cxx
+++ b/sw/source/ui/fldui/flddb.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "flddb.hxx"
 #include 
@@ -78,6 +79,14 @@ SwFieldDBPage::~SwFieldDBPage()
 
 void SwFieldDBPage::dispose()
 {
+SwWrtShell* pSh = GetWrtShell();
+if (!pSh)
+pSh = ::GetActiveWrtShell();
+// This would cleanup in the case of cancelled dialog
+SwDBManager* pDbManager = pSh->GetDoc()->GetDBManager();
+if (pDbManager)
+pDbManager->RevokeLastRegistrations();
+
 m_pTypeLB.clear();
 m_pDatabaseTLB.clear();
 m_pAddDBPB.clear();
@@ -208,6 +217,10 @@ bool SwFieldDBPage::FillItemSet(SfxItemSet* )
 if(!pSh)
 pSh = ::GetActiveWrtShell();
 
+SwDBManager* pDbManager = pSh->GetDoc()->GetDBManager();
+if (pDbManager)
+pDbManager->CommitLastRegistrations();
+
 if (aData.sDataSource.isEmpty())
 aData = pSh->GetDBData();
 
@@ -477,7 +490,12 @@ IMPL_LINK( SwFieldDBPage, TreeSelectHdl, SvTreeListBox *, 
pBox, void )
 
 IMPL_LINK_NOARG(SwFieldDBPage, AddDBHdl, Button*, void)
 {
-OUString sNewDB = SwDBManager::LoadAndRegisterDataSource(GetFrameWeld());
+SwWrtShell* pSh = GetWrtShell();
+if (!pSh)
+pSh = ::GetActiveWrtShell();
+
+OUString sNewDB
+= SwDBManager::LoadAndRegisterDataSource(GetFrameWeld(), 
pSh->GetDoc()->GetDocShell());
 if(!sNewDB.isEmpty())
 {
 m_pDatabaseTLB->AddDataSource(sNewDB);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

RE: Make clean fails for unpackedTarballs in subpath firebird

2018-07-04 Thread Kaganski Mike

Hi Regina;

This is the problem with cygwin 2.10, which I had to describe in our wiki:
https://wiki.documentfoundation.org/Development/BuildingOnWindows#Install_Cygwin_Requirements:

"Cygwin 2.10.0-1 have introduced a breaking
change
related to treatment of files with
FILE_ATTRIBUTE_TEMPORARY
attribute set. This interferes with Firebird creating such files in
workdir/UnpackedTarball/firebird/gen/Debug/firebird (with names like
fb_trace_09y6aq), which results in failing build due to failure to remove a
non-empty directory. The problem is reported to be fixed in Cygwin snapshot
2018-03-09. The error message is like

rm: cannot remove
'D:/sources/lo-core1/workdir/UnpackedTarball/firebird/gen/Debug/firebird':
Directory not empty

A workaround is to open the directory using a file manager (like Windows File
Explorer) and remove the file(s) left there manually."

(Sorry for possible bad markup in my mail; I only have access to web UI of my
mail ATM.)
Building LibreOffice on Windows with Cygwin and MSVC: Tips
...
Build dependencies. Before you can start hacking LibreOffice on Windows, you
need to follow these instructions to set up a build environment. Install Visual
Studio
wiki.documentfoundation.org

Building LibreOffice on Windows with Cygwin and MSVC: Tips
...
Build dependencies. Before you can start hacking LibreOffice on Windows, you
need to follow these instructions to set up a build environment. Install Visual
Studio
wiki.documentfoundation.org

От: LibreOffice от имени Regina
Henschel
Отправлено: 5 июля 2018 г. 4:46
Кому: LO dev fdo
Тема: Make clean fails for unpackedTarballs in subpath firebird

Hi all,

if I use /opt/lo/bin/make clean it stops with the error message
"rm: das Entfernen von
'D:/Build_ODF_layers/core/workdir/UnpackedTarball/firebird/gen/Debug/firebird'
ist nicht möglich: Directory not empty"
And indeed it has a 0Byte file fb_trace_wj10i8 in
unpackedTarball/firebird/gen/Debug/firebird.

I can delete the file manually in Windows explorer. But I think it is an
error. I write here, because I don't find a suitable category in Bugzilla.

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

--
Best regards,
Mike Kaganski.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

 sc/source/core/data/table1.cxx |   75 +++--
 1 file changed, 58 insertions(+), 17 deletions(-)

New commits:
commit 7d0426a26f59ecf19a5e58b1554af884ddc56948
Author: Eike Rathke 
Date:   Wed Jul 4 20:43:34 2018 +0200

Limit GetNextPos() loops to range, if available, tdf#68290 follow-up

It's unnecessary to check all columns if there was a range marked
anyway. Also use GetPrintArea() only for bUnprotected and enlarge
the result a bit to cover the case where a protected form may be
empty but not have vidsual indications either.

Also adding nMoveY to nCol was nonsense all the time already, what
was actually meant is to add the direction of movement. Worked by
chance because nMoveY was always +1/-1.

Change-Id: Ic1175a607a1169f3ef0e28d0f3a91f8c526314f4
Reviewed-on: https://gerrit.libreoffice.org/56966
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 7903fa04d2d2233fe193eef7dfd3c203430edcc6)
Reviewed-on: https://gerrit.libreoffice.org/56977

diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 65b1b288fce7..9b672f67b054 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -1384,45 +1384,86 @@ void ScTable::GetNextPos( SCCOL& rCol, SCROW& rRow, 
SCCOL nMovX, SCROW nMovY,
 if ( nMovY && (bMarked || bUnprotected))
 {
 bool  bUp= ( nMovY < 0 );
-SCROW nUsedY = nRow;
-SCCOL nUsedX = nCol;
+const SCCOL nColAdd = (bUp ? -1 : 1);
+SCCOL nStartCol, nEndCol;
+SCROW nStartRow, nEndRow;
+if (bMarked && rMark.IsMarked())
+{
+ScRange aRange( ScAddress::UNINITIALIZED);
+rMark.GetMarkArea( aRange);
+nStartCol = aRange.aStart.Col();
+nStartRow = aRange.aStart.Row();
+nEndCol = aRange.aEnd.Col();
+nEndRow = aRange.aEnd.Row();
+}
+else if (bMarked && rMark.IsMultiMarked())
+{
+ScRange aRange( ScAddress::UNINITIALIZED);
+rMark.GetMultiMarkArea( aRange);
+nStartCol = aRange.aStart.Col();
+nStartRow = aRange.aStart.Row();
+nEndCol = aRange.aEnd.Col();
+nEndRow = aRange.aEnd.Row();
+}
+else if (bUnprotected)
+{
+nStartCol = 0;
+nStartRow = 0;
+nEndCol = nCol;
+nEndRow = nRow;
+pDocument->GetPrintArea( nTab, nEndCol, nEndRow, true );
+// Add some cols/rows to the print area (which is "content or
+// visually different from empty") to enable travelling through
+// protected forms with empty cells and no visual indicator.
+// 42 might be good enough and not too much..
+nEndCol = std::min( nEndCol+42, MAXCOL);
+nEndRow = std::min( nEndRow+42, MAXROW);
+}
+else
+{
+SAL_WARN("sc.core","ScTable::GetNextPos - bMarked but not marked");
+nStartCol = 0;
+nStartRow = 0;
+nEndCol = MAXCOL;
+nEndRow = MAXROW;
+}
 
 if (bMarked)
 nRow = rMark.GetNextMarked( nCol, nRow, bUp );
-pDocument->GetPrintArea( nTab, nUsedX, nUsedY );
 
-while ( SkipRow( nCol, nRow, nMovY, rMark, bUp, nUsedY, bMarked, 
bSheetProtected ))
+while ( SkipRow( nCol, nRow, nMovY, rMark, bUp, nEndRow, bMarked, 
bSheetProtected ))
 ;
 
-while ( nRow < 0 || nRow > MAXROW )
+while ( nRow < nStartRow || nRow > nEndRow )
 {
-nCol = sal::static_int_cast( nCol + 
static_cast(nMovY) );
+nCol += nColAdd;
 
-while ( ValidCol(nCol) && ColHidden(nCol) )
-nCol = sal::static_int_cast( nCol + 
static_cast(nMovY) );   //  skip hidden rows (see above)
-if (nCol < 0)
+while (nStartCol <= nCol && nCol <= nEndCol && ValidCol(nCol) && 
ColHidden(nCol))
+nCol += nColAdd;//  skip hidden cols
+
+if (nCol < nStartCol)
 {
-nCol = (bSheetProtected ? nUsedX : MAXCOL);
+nCol = nEndCol;
 
 if (++nWrap >= 2)
 return;
 }
-else if (nCol > MAXCOL || ( nCol > nUsedX && bSheetProtected ))
+else if (nCol > nEndCol)
 {
-nCol = 0;
+nCol = nStartCol;
 
 if (++nWrap >= 2)
 return;
 }
-if (nRow < 0)
-nRow = MAXROW;
-else if (nRow > MAXROW)
-nRow = 0;
+if (nRow < nStartRow)
+nRow = nEndRow;
+else if (nRow > nEndRow)
+nRow = nStartRow;
 
 if (bMarked)
 nRow = rMark.GetNextMarked( nCol, nRow, bUp );
 
-while ( SkipRow(

[Libreoffice-bugs] [Bug 118471] Sort button sorting also the first row

https://bugs.documentfoundation.org/show_bug.cgi?id=118471

--- Comment #15 from Yan Pas  ---
As a reporter and fixer of the opposite bug I can tell that it is easy to
deselect header row, but it's much more difficult to add header row if it
doesn't exist only for the sake of sorting. I was taking into account the
behavior of Microsoft Office Excel.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - solenv/gbuild

2018-07-04 Thread Thorsten Behrens

 solenv/gbuild/platform/unxgcc.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 52b85ab2adf74e82cb598d9273b1639b11c28270
Author: Thorsten Behrens 
Date:   Thu Jul 5 01:33:23 2018 +0200

gcc7: disable -Wdeprecated for dynamic excpt specs

gcc started to warn about c++11-deprecated dynamic exception
specifications thusly:

warning: dynamic exception specifications are deprecated in C++11 
[-Wdeprecated]

so disable this on the branch instead of a massive backport.

See https://en.cppreference.com/w/cpp/language/except_spec for a
discussion; this is still perfectly correct c++ code.

Change-Id: Iffbb82e4da24fb96fab57f233b8ebe41fbc850fa
Reviewed-on: https://gerrit.libreoffice.org/56981
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index bc449067e844..a86f6a6f6d49 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -45,6 +45,7 @@ gb_CXXFLAGS := \
$(gb_CXXFLAGS_COMMON) \
-fPIC \
-Wshadow \
+   -Wno-deprecated \
-Woverloaded-virtual \
$(CXXFLAGS_CXX11) \
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118139] FILEOPEN: Incorrect height of textboxes

https://bugs.documentfoundation.org/show_bug.cgi?id=118139

--- Comment #7 from Regina Henschel  ---
Created attachment 143312
  --> https://bugs.documentfoundation.org/attachment.cgi?id=143312=edit
File in doc and docx, and screenshot of file in Word 365

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118139] FILEOPEN: Incorrect height of textboxes

https://bugs.documentfoundation.org/show_bug.cgi?id=118139

--- Comment #6 from Regina Henschel  ---
(In reply to Xisco Faulí from comment #5)
> @Regina, I thought this issue could be of interested to you

But I do not really no the Word formats. Nevertheless, I have a little bit
investigated.

(In reply to Armin Le Grand (CIB) from comment #4)
> Confirmed.
> 
> Just wondering about the Shapes imported. It *seems* to be a GroupObject
> containing DrawObjects, but in context menu 'Group' commands are not allowed.

That is a bug in LibreOffice, inherited from OpenOffice.org. If the shape is
anchored as character, you cannot enter the group or ungroup it.
https://bz.apache.org/ooo/show_bug.cgi?id=83498 and for the special case of
Word import https://bz.apache.org/ooo/show_bug.cgi?id=54325

To examine the shape, you have to change the anchor "to character" or "to
paragraph" e.g.

> 
> To find that I will have to debug step-by-step the import of such a
> DrawObject. Thus:
> 
> - How was the example created?

The old Word version had a feature to insert an "AutoShape" and then add text
boxes to it. That had automatically generate a group containing the AutoShape
itself and the text boxes. Word had this feature, because in the beginning the
AutoShapes where not able to have text themselves. This auto-grouping is no
longer available in current Word versions.

> - Is there a more simple one with e.g. a single such DrawObject?

It makes no real difference, whether you have one or four text boxes. You have
always a "canvas" (that is the group) and therein the Autoshape and the text
boxes. The group has wrap and anchor properties and can have a custom name. I
was only once able to name a text box, but cannot reproduce it.

The AutoShape has the fill and line properties. Size and position are coupled
between group and AutoShape and you can use one or the other the change it.

> - Is there a way to create a bugdoc with minimal content (step-by-step)?
> 
> That would make looking into much easier.
https://www.youtube.com/watch?v=hfbXtylMlWY
You need e.g. Word 2003.

I have made a screenshot from Word 365, and will attach it together with the
used files.
Besides the wrong height, there are additional problems:
The borders are missing.
All shapes are named in Word, but the names are not imported and therefore the
shapes are not visible in the Navigator.

The import of the compatible docx has additional errors: The AutoShape is
missing. The text boxes are inserted as custom shapes and have "resize to
text". But as custom shapes they need "wrap", because in contrast to text boxes
the custom shapes have wrap not automatically. I have no strong opinion,
whether a solution with custom shape is better than a solution with a text box.
It might be, that the import of docx does not consider, that the document is in
"Compatability mode".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118352] Schema for XML output reports is using Japanese encoding and fonts, can cause display issues

https://bugs.documentfoundation.org/show_bug.cgi?id=118352

Markus Mohrhard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Markus Mohrhard  ---
Thanks. Merged the patch as
https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=653b1db88832b1c44327117510048e28eb136de3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118347] The name of the VC build project mentioned in the install instructions is incorrect (wrong extension).

https://bugs.documentfoundation.org/show_bug.cgi?id=118347

Markus Mohrhard  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Markus Mohrhard  ---
Thanks. Merged the patch as
https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=742d887de85f378ab817a992cdfa0778971df093

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] cppunit.git: 2 commits - contrib/xml-xsl INSTALL-WIN32.txt

2018-07-04 Thread Blake Madden

 INSTALL-WIN32.txt  |2 +-
 contrib/xml-xsl/report.xsl |   18 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 742d887de85f378ab817a992cdfa0778971df093
Author: Blake Madden 
Date:   Sun Jun 24 12:00:25 2018 -0400

Fix the name of the VC project mentioned in the build instructions.

diff --git a/INSTALL-WIN32.txt b/INSTALL-WIN32.txt
index cef4083..9069382 100644
--- a/INSTALL-WIN32.txt
+++ b/INSTALL-WIN32.txt
@@ -77,7 +77,7 @@ name is cppunitd.lib. The debug configuration cppunit dll 
name is cppunitd_dll.l
 Building:
 -
 
-* Open the src/CppUnitLibraries.dsw workspace in VC++.
+* Open the src/CppUnitLibraries.sln workspace in VC++.
 * In the 'Build' menu, select 'Batch Build...'
 * In the batch build dialog, select all projects and press the build button.
 * The resulting libraries can be found in the lib/ directory.
commit 653b1db88832b1c44327117510048e28eb136de3
Author: Blake Madden 
Date:   Sun Jun 24 15:00:34 2018 -0400

Make output XML report schema UTF-8 and remove Japanese specific 
information.

diff --git a/contrib/xml-xsl/report.xsl b/contrib/xml-xsl/report.xsl
index b394cdb..0a6da0f 100644
--- a/contrib/xml-xsl/report.xsl
+++ b/contrib/xml-xsl/report.xsl
@@ -1,22 +1,22 @@
-
+
 
-http://www.w3.org/1999/XSL/Transform; version="1.0" 
xml:lang="ja">
+http://www.w3.org/1999/XSL/Transform; version="1.0">
 
 
 
 
 Test Report

[Libreoffice-commits] core.git: sc/source

 sc/source/core/data/table1.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4bfa5d08c6ef94706e340f78ea1052e94a8c5915
Author: Eike Rathke 
Date:   Thu Jul 5 00:31:34 2018 +0200

Turn SAL_WARN into assert

... as it indicates a programming error.

Change-Id: I526846fe695fc7ed28336ea20cdba0c0db2e922a

diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 9af3ad511c45..ff58624e5743 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -1419,7 +1419,7 @@ void ScTable::GetNextPos( SCCOL& rCol, SCROW& rRow, SCCOL 
nMovX, SCROW nMovY,
 }
 else
 {
-SAL_WARN("sc.core","ScTable::GetNextPos - bMarked but not marked");
+assert(!"ScTable::GetNextPos - bMarked but not marked");
 nStartCol = 0;
 nStartRow = 0;
 nEndCol = MAXCOL;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

 sc/source/core/data/table1.cxx |   75 +++--
 1 file changed, 58 insertions(+), 17 deletions(-)

New commits:
commit 7903fa04d2d2233fe193eef7dfd3c203430edcc6
Author: Eike Rathke 
Date:   Wed Jul 4 20:43:34 2018 +0200

Limit GetNextPos() loops to range, if available, tdf#68290 follow-up

It's unnecessary to check all columns if there was a range marked
anyway. Also use GetPrintArea() only for bUnprotected and enlarge
the result a bit to cover the case where a protected form may be
empty but not have vidsual indications either.

Also adding nMoveY to nCol was nonsense all the time already, what
was actually meant is to add the direction of movement. Worked by
chance because nMoveY was always +1/-1.

Change-Id: Ic1175a607a1169f3ef0e28d0f3a91f8c526314f4
Reviewed-on: https://gerrit.libreoffice.org/56966
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 4506d3e17fe0..9af3ad511c45 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -1382,45 +1382,86 @@ void ScTable::GetNextPos( SCCOL& rCol, SCROW& rRow, 
SCCOL nMovX, SCROW nMovY,
 if ( nMovY && (bMarked || bUnprotected))
 {
 bool  bUp= ( nMovY < 0 );
-SCROW nUsedY = nRow;
-SCCOL nUsedX = nCol;
+const SCCOL nColAdd = (bUp ? -1 : 1);
+SCCOL nStartCol, nEndCol;
+SCROW nStartRow, nEndRow;
+if (bMarked && rMark.IsMarked())
+{
+ScRange aRange( ScAddress::UNINITIALIZED);
+rMark.GetMarkArea( aRange);
+nStartCol = aRange.aStart.Col();
+nStartRow = aRange.aStart.Row();
+nEndCol = aRange.aEnd.Col();
+nEndRow = aRange.aEnd.Row();
+}
+else if (bMarked && rMark.IsMultiMarked())
+{
+ScRange aRange( ScAddress::UNINITIALIZED);
+rMark.GetMultiMarkArea( aRange);
+nStartCol = aRange.aStart.Col();
+nStartRow = aRange.aStart.Row();
+nEndCol = aRange.aEnd.Col();
+nEndRow = aRange.aEnd.Row();
+}
+else if (bUnprotected)
+{
+nStartCol = 0;
+nStartRow = 0;
+nEndCol = nCol;
+nEndRow = nRow;
+pDocument->GetPrintArea( nTab, nEndCol, nEndRow, true );
+// Add some cols/rows to the print area (which is "content or
+// visually different from empty") to enable travelling through
+// protected forms with empty cells and no visual indicator.
+// 42 might be good enough and not too much..
+nEndCol = std::min( nEndCol+42, MAXCOL);
+nEndRow = std::min( nEndRow+42, MAXROW);
+}
+else
+{
+SAL_WARN("sc.core","ScTable::GetNextPos - bMarked but not marked");
+nStartCol = 0;
+nStartRow = 0;
+nEndCol = MAXCOL;
+nEndRow = MAXROW;
+}
 
 if (bMarked)
 nRow = rMark.GetNextMarked( nCol, nRow, bUp );
-pDocument->GetPrintArea( nTab, nUsedX, nUsedY );
 
-while ( SkipRow( nCol, nRow, nMovY, rMark, bUp, nUsedY, bMarked, 
bSheetProtected ))
+while ( SkipRow( nCol, nRow, nMovY, rMark, bUp, nEndRow, bMarked, 
bSheetProtected ))
 ;
 
-while ( nRow < 0 || nRow > MAXROW )
+while ( nRow < nStartRow || nRow > nEndRow )
 {
-nCol = sal::static_int_cast( nCol + 
static_cast(nMovY) );
+nCol += nColAdd;
 
-while ( ValidCol(nCol) && ColHidden(nCol) )
-nCol = sal::static_int_cast( nCol + 
static_cast(nMovY) );   //  skip hidden rows (see above)
-if (nCol < 0)
+while (nStartCol <= nCol && nCol <= nEndCol && ValidCol(nCol) && 
ColHidden(nCol))
+nCol += nColAdd;//  skip hidden cols
+
+if (nCol < nStartCol)
 {
-nCol = (bSheetProtected ? nUsedX : MAXCOL);
+nCol = nEndCol;
 
 if (++nWrap >= 2)
 return;
 }
-else if (nCol > MAXCOL || ( nCol > nUsedX && bSheetProtected ))
+else if (nCol > nEndCol)
 {
-nCol = 0;
+nCol = nStartCol;
 
 if (++nWrap >= 2)
 return;
 }
-if (nRow < 0)
-nRow = MAXROW;
-else if (nRow > MAXROW)
-nRow = 0;
+if (nRow < nStartRow)
+nRow = nEndRow;
+else if (nRow > nEndRow)
+nRow = nStartRow;
 
 if (bMarked)
 nRow = rMark.GetNextMarked( nCol, nRow, bUp );
 
-while ( SkipRow( nCol, nRow, nMovY, rMark, bUp, nUsedY, bMarked, 
bSheetProtected ))
+while ( SkipRow( nCol, nRow, nMovY, rMark,

[Libreoffice-bugs] [Bug 118543] New: main installer download FAIL after a few seconds.

https://bugs.documentfoundation.org/show_bug.cgi?id=118543

Bug ID: 118543
   Summary: main installer download FAIL after a few seconds.
   Product: LibreOffice
   Version: 6.0.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dbalt2...@ymail.com

Description:
Tried several different browsers and computers but LibreOffice download update
6.0.5 FAILURE, every time, after a few seconds. This has been for weeks now. 

Actual Results:
Download off the website 

Expected Results:
Download interrupt. "FAILURE"


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118542] New: clear direct formatting results in changing a selected cells content from liberation sans narrow 11 to liberation serif 12

https://bugs.documentfoundation.org/show_bug.cgi?id=118542

Bug ID: 118542
   Summary: clear direct formatting results in changing a selected
cells content from liberation sans narrow 11 to
liberation serif 12
   Product: LibreOffice
   Version: 6.0.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ken.x.gra...@gmail.com

Description:
i have a column with whole numbers & whole numbers with up to 4 decimal digits.
in order to suppress trailing decimal zeroes i try to maintain decimal
alignment via 
the space bar. note that this is similar to bug 115059 about which i've heard
nothing. note that i've deleted a number of spurious fonts. LSN is now followed
by LS.

Steps to Reproduce:
1.create a column & enter LSN numbers in successive cells.
2.clear direct formatting on 1 or more cells.
3.fix the problem or point me to a non proportional font which is narrow

Actual Results:
LSN 1! numbers changed to LS 12.

Expected Results:
no change


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.1.0.1'

Tag 'libreoffice-6.1.0.1' created by Christian Lohmaier 
 at 2018-07-04 21:44 +

Tag libreoffice-6.1.0.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJbPT/YAAoJEPQ0oe+v7q6jGj4QAMFbO2Hv2DOZ2kYmGWaBhBYD
4Rl4ZIhzZSgDggsKqawsqu4bczn8c3i1liGHHx5E9PaxOYd/xoBYfHCeFwIpJFpb
EqOVctfgKdX6i/df7DFrUcAuKlaGkj0Ru/b2OLkKiyheoKg6rKboDKiZ8swm397S
uLaqbbiqFIxTNt5T52U18djvaKfZ0E+ZL+Q5HiC5CxzauZ45AdwEBx2LyJdt+ghu
qGs9zTN9VuerdhiSul5HYcuRROtBSzh+QF7FXCZiszNtBOeWTt9GwQK/W83/2zcf
XFicr8ztOJB7AQc54wWmern/8RUigRL5Ous0arMLB5rST1LFNPw2i4jcKHhAt3GQ
QJkibErGxK03qu7FAXfG5bsa7v3DxC312Kh2goJh9DNZa7uQm54kqutM5sMK4x++
DvXiNexMNmoo9dJP7Memu3R26tXTrdDtkM1tktGNnMquEZa31olAScdz8DLYpHEf
euLrFoSzC5E9fFh0HLI3jJ1kAo6tijLruLP7kF82fGn8uMGDsEZRNVpr9bqYukDF
GgfOLgSzvX7Z8dH6fL44WjU2znogUhxViOrmrx6dyJKDOQGuevDvAfc/hTMfkbZ4
o29LE0kFRrrKMvN964fqk5Pup4hjkNFElPbKFYqawfuqWJtt4ggczaqvpcYpnv2/
MEQ2OQ+4YdILdzUbd7Wo
=Fv2M
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-34:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.1.0.1'

Tag 'libreoffice-6.1.0.1' created by Christian Lohmaier 
 at 2018-07-04 21:44 +

Tag libreoffice-6.1.0.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJbPT/bAAoJEPQ0oe+v7q6jEe4P/AzXsKW7MnxW+hKXoDis5OwX
N4VQ0CZ1RYnyPeiAMsv0QSd+1BLC+dJLBdxBX87Vgsg4kdH8Mi6xZyfxnR9Cunmn
CTNsDz2fAwtj3LE+Id7F+Em9dw1BW6DGALDHc3e7kQiDZuTv5hZidN9CfHJLtefv
l88IJMR8UB7I3Ijdj7f8X0dK38u7fOLzMLUtHF8lglDVJ14zqWpmdbWkwqI2wgep
4GqAZctISSvWoGwrGPq+L7k9D02iFwd7iQFR6MA7L8deFGVbEYf0BH6D1x2MoOGl
+iz+LWEvrC0CHb1zU/n+WsAeFJSSauBTruajy5YQaDeablBOsqnPqA3dnot8vDzv
COuIIIL7CqFRtHBMNj4/HFdKQNFOt4IwFTvadmvvaU1WdfGM3zPgO5VMGaNyWT/Q
lgJvQoE54VjzdHzA1I3zR77/A6DAahjToPrDadQfth0i62ITgAuEBBLg57TOODus
nL5cCx1ZsbXVxduiV8XqYl0SBwKQiAh0MY20gDcR3qcpfnFKEe5xizmt/K0hWOnd
wtOTdyFUPLemggvBRoonjTDywOFcNejrHYQzebGKvx00D6JW658S8L7QyK+iYpDA
iOTc18L8iMWTOBvxhCg0COusu3iHD3ankVU99x98KZz5hwXXkFNivWtbQ1jUaxyq
S4FawtUNCY3P4IUl/gHt
=tZ3K
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-8:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.1.0.1'

Tag 'libreoffice-6.1.0.1' created by Christian Lohmaier 
 at 2018-07-04 21:44 +

Tag libreoffice-6.1.0.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJbPT/VAAoJEPQ0oe+v7q6jWjUP/jcGQXvg78AEQVzZWrsxW2jb
Zr+O2SQuUTvFFTwLnNz+qmf5KUmRrn5BRViXBwP0TxeHR0EmUSbICPJiS2hedDRg
ZrP6/llmuYUj84yJrhEJmaIwHTWUmmYw/2xinXIWB1HgamjD/wMaShrbE0RklTiF
hoaBnGCcRF0CoIv8KpzG7fRcIy5gotwNHH3tM0xq9hyu0G1jfIfeDyrLGdRQW30n
YcSBF7f6l5jhew/HKjSSm26XpNIRTirY+tzqGIrTRrsyIq2d6f6sLDWL/GuF+3Mz
dncqNuy2Zww/Fsd/1dptq6eGJjdh3xZNI2ewOytDs8QvkbgD/dBlW3cM6kMo/9U+
77+tvsIrqb3Bo/8qV439b6T6noHAbozs+ul7VhREApK06t2zMh/KVOaBKGLPYxMn
57a6NJFX8tkcerWc/oLcpjeUZ4L2Y72yvJJ1dQUY783l/wGzS8r7/1aLBC7++dxc
zU3Hc6JEnRNtdoe0CAiIY8UETb2qe2rVFtfcI58z35lRxCU7H5m8RdX+X+h2mq9U
K5ufFp3IP49vKDnwHrEzD7bgCJRL32b4dkMGvmjwzgXVrwFA0vbeHfCp/QK1TlC5
kcNglmGFyopQFccwwDoDt92wxehx1Y0Yx8jCqbirG/NGH5ktQwbkJ+46raFNp7Fq
pDLXji43nPt9GhCVlkk/
=NAD+
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-6:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - configure.ac

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 07c5fdacc8e760809f0f6bfca37a7ce66d3b3d03
Author: Christian Lohmaier 
Date:   Wed Jul 4 23:45:41 2018 +0200

bump product version to 6.1.0.1.0+

Change-Id: Ida1c538e15bc0254f383a8471fc9bdfc5e1f83a4

diff --git a/configure.ac b/configure.ac
index cbbda6a4aa15..258370e9ec32 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.1.0.0.beta2+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.1.0.1.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.1.0.1'

Tag 'libreoffice-6.1.0.1' created by Christian Lohmaier 
 at 2018-07-04 21:45 +

Tag libreoffice-6.1.0.1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJbPT/eAAoJEPQ0oe+v7q6j3aEP+gKmWVJTApoKDdy0YyeblmYg
d8LrZrUw0CnzCIEzdV/yxl2UXfSODLkfbaLs2gIs7GMp/72CrMlu/5f+WR5Qfg7C
G15ohJKQY5idNU1Rz3aZgZ3PJjUebm9U7I1I3UBLBSIVjDHjGqr2i1sf7DGVXp7h
otf54cbbgknrXTnjQ5ZRObitdethACwMmKIwyzzXFs1sgLzG6dTaO1/+ZnIkId6/
bhgUFqCE0rFSwEbN/ZcD5J2MYTI0XSbDCcYO0Z6FBxYO3yn+cUt06QcdlDVA0qKp
S8eJIXFE7JkKmbl1hu5JSsbFFYlMASOI6Kbff/tYzTLZmv6+HBwuJ9D9/WMwHXy3
CR12X6pFG9JtPy5qCtPB3BsML7OlWiPiBwIXsRpU/u7kiSKwLcpxDLbpzY1if/+R
t/m30FFgG0/E+Sb4k2bwAu3FPr/xijLsaC0D/Ux1s96f2YHG33qTRtFfRoTGoD1i
5qaHkOabq9OffeGskdiLGocK39qopfpr5+0OQwXdBro3VwhbDEY/JW44zzxVDOhM
1WeqzNw1QIVqUvDNCSoUklhjeLXoaGHLoxuu6BMHgsHDyi9IhW4++M5TbD9Kmm72
Z6bsMZEhIpPfkPFCMKpqXA+tZsUNxS9JY5fuGM4uL9YOXQ8/dbRwgNI06Hvwv31y
mjM76k1s4aWVohNgTDqJ
=PTEy
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-644:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - translations

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5fbe8d12d91c86f0231a033a5c2e926ab9414769
Author: Christian Lohmaier 
Date:   Wed Jul 4 23:34:10 2018 +0200

Update git submodules

* Update translations from branch 'libreoffice-6-1'
  - update translations with the updated submodules

Change-Id: I0f59e5cb8f567d52c1124c2d13095d4b7ad4bfac
(cherry picked from commit b8215a9818b5f37753c604654b02cebbb776f4e4)

  - update translations for 6.1.0 rc1

and also test the auto-update of the core module

Change-Id: Id4556effa916c1d274f818bb5a5b700617fa6436
(cherry picked from commit be22e619a5440e0e9b8aed19734bac8401220896)

diff --git a/translations b/translations
index 2ed4096e23f5..261c756426ce 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 2ed4096e23f53b0a37bc0240b3cdb9a249432c14
+Subproject commit 261c756426cede3542656cc9b14234542fcb8ed8
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: translations

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e55e6d863080b5f03f6d14820c5c08b84eeab600
Author: Christian Lohmaier 
Date:   Wed Jul 4 23:34:10 2018 +0200

Update git submodules

* Update translations from branch 'master'
  - update translations with the updated submodules

Change-Id: I0f59e5cb8f567d52c1124c2d13095d4b7ad4bfac

diff --git a/translations b/translations
index be22e619a544..b8215a9818b5 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit be22e619a5440e0e9b8aed19734bac8401220896
+Subproject commit b8215a9818b5f37753c604654b02cebbb776f4e4
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Arawa - licence statement

2018-07-04 Thread Philippe Hemmel


Hi

For the record :

All contributions past and present made to LibreOffice from Arawa are 
available under the terms the MPL / LGPLv3+.


Until further notice, future contributions made to LibreOffice from 
Arawa are available under the terms the MPL / LGPLv3+.


Best regards

Philippe
Founder
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 118540] LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Henry Castro  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |hcas...@collabora.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2018-07-04 Thread Stephan Bergmann

 sw/source/uibase/inc/cfgitems.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 94813abf417250725bbfb09a9bc3a5ffd56f0e7a
Author: Stephan Bergmann 
Date:   Wed Jul 4 17:38:27 2018 +0200

Dead declaration

...without a matching definition.  (And the now implicitly-declared copy
assignment op will be defined as deleted, as the SfxPoolItem base class has 
a
deleted copy assignment op.)

Change-Id: I5dbe2954bf920a902f44d72fde3c481386633d54
Reviewed-on: https://gerrit.libreoffice.org/56962
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/uibase/inc/cfgitems.hxx 
b/sw/source/uibase/inc/cfgitems.hxx
index 79c2fb7780bf..c2187d2b0aa9 100644
--- a/sw/source/uibase/inc/cfgitems.hxx
+++ b/sw/source/uibase/inc/cfgitems.hxx
@@ -124,7 +124,6 @@ public:
 
 virtual SfxPoolItem*Clone( SfxItemPool *pPool = nullptr ) const 
override;
 virtual booloperator==( const SfxPoolItem& ) const override;
-SwShadowCursorItem& operator=( const SwShadowCursorItem& );
 
 void FillViewOptions( SwViewOption& rVOpt) const;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: config_host/config_global.h.in configure.ac include/editeng sw/source

2018-07-04 Thread Stephan Bergmann

 config_host/config_global.h.in  |3 +++
 configure.ac|   23 +++
 include/editeng/swafopt.hxx |   20 +++-
 sw/source/uibase/app/docsh2.cxx |4 +---
 4 files changed, 46 insertions(+), 4 deletions(-)

New commits:
commit a9303d85a4f201a42322e8e4ce5ebe6e6ca728b0
Author: Stephan Bergmann 
Date:   Wed Jul 4 15:51:02 2018 +0200

Make brittle SortedAutoCompleteStrings ownership handling more explicit

Change-Id: Ieaf2231a84d97528bb1b9a410c4ee0c38966dd27
Reviewed-on: https://gerrit.libreoffice.org/56950
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/config_host/config_global.h.in b/config_host/config_global.h.in
index e0dc1418e9cb..2bb60ca656ac 100644
--- a/config_host/config_global.h.in
+++ b/config_host/config_global.h.in
@@ -23,4 +23,7 @@ Any change in this header will cause a rebuild of almost 
everything.
 /* Compiler supports __attribute__((warn_unused)). */
 #define HAVE_GCC_ATTRIBUTE_WARN_UNUSED 0
 
+/* Guaranteed copy elision (C++17), __cpp_guaranteed_copy_elision (C++2a): */
+#define HAVE_CPP_GUARANTEED_COPY_ELISION 0
+
 #endif
diff --git a/configure.ac b/configure.ac
index bc76475962c9..45c19e72b9c0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6482,6 +6482,29 @@ if test "$GCC" = yes; then
 fi
 AC_SUBST([HAVE_GCC_FNO_SIZED_DEALLOCATION])
 
+HAVE_CPP_GUARANTEED_COPY_ELISION=
+AC_MSG_CHECKING([whether $CXX supports guaranteed copy elision])
+AC_LANG_PUSH([C++])
+save_CXXFLAGS=$CXXFLAGS
+CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11"
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([
+#if !defined __cpp_guaranteed_copy_elision
+struct S {
+private:
+S(S const &);
+public:
+S copy() const { return *this; }
+};
+void f(S & s) { S c(s.copy()); }
+#endif
+])], [
+AC_DEFINE([HAVE_CPP_GUARANTEED_COPY_ELISION],[1])
+AC_MSG_RESULT([yes])
+], [AC_MSG_RESULT([no])])
+CXXFLAGS=$save_CXXFLAGS
+AC_LANG_POP([C++])
+AC_SUBST([HAVE_CPP_GUARANTEED_COPY_ELISION])
+
 dnl ===
 dnl system stl sanity tests
 dnl ===
diff --git a/include/editeng/swafopt.hxx b/include/editeng/swafopt.hxx
index e8d7d3a6facf..f3b34adb32a7 100644
--- a/include/editeng/swafopt.hxx
+++ b/include/editeng/swafopt.hxx
@@ -20,6 +20,9 @@
 #ifndef INCLUDED_EDITENG_SWAFOPT_HXX
 #define INCLUDED_EDITENG_SWAFOPT_HXX
 
+#include 
+
+#include 
 #include 
 #include 
 #include 
@@ -52,8 +55,23 @@ struct CompareAutoCompleteString
 class SortedAutoCompleteStrings
   : public o3tl::sorted_vector
 {
+bool owning_;
+
+void operator =(SortedAutoCompleteStrings) = delete;
+
+#if !HAVE_CPP_GUARANTEED_COPY_ELISION
+public:
+#endif
+// For createNonOwningCopy only:
+SortedAutoCompleteStrings(SortedAutoCompleteStrings const & other):
+sorted_vector(other), owning_(false) {}
+
 public:
-~SortedAutoCompleteStrings() { DeleteAndDestroyAll(); }
+SortedAutoCompleteStrings(): owning_(true) {}
+
+~SortedAutoCompleteStrings() { if (owning_) DeleteAndDestroyAll(); }
+
+SortedAutoCompleteStrings createNonOwningCopy() const { return *this; }
 };
 
 } // namespace editeng
diff --git a/sw/source/uibase/app/docsh2.cxx b/sw/source/uibase/app/docsh2.cxx
index 1d1972da0f04..ab4c22a5b718 100644
--- a/sw/source/uibase/app/docsh2.cxx
+++ b/sw/source/uibase/app/docsh2.cxx
@@ -421,7 +421,7 @@ void SwDocShell::Execute(SfxRequest& rReq)
 
 rACW.SetLockWordLstLocked( true );
 
-editeng::SortedAutoCompleteStrings aTmpLst( rACW.GetWordList() );
+editeng::SortedAutoCompleteStrings aTmpLst( 
rACW.GetWordList().createNonOwningCopy() );
 pAFlags->m_pAutoCompleteList = 
 
 SfxApplication* pApp = SfxGetpApp();
@@ -455,8 +455,6 @@ void SwDocShell::Execute(SfxRequest& rReq)
 // clear the temp WordList pointer
 pAFlags->m_pAutoCompleteList = nullptr;
 }
-// remove all pointer we never delete the strings
-aTmpLst.clear();
 
 if( !bOldAutoCmpltCollectWords && bOldAutoCmpltCollectWords !=
 pAFlags->bAutoCmpltCollectWords )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108009] Can't save new file to WebDAV server

https://bugs.documentfoundation.org/show_bug.cgi?id=108009

--- Comment #4 from Vitaliy Lotorev  ---
Reproducible with Windows 7 and LibreOffice_6.0.5_Win_x64.msi

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118541] New: Undesired font embedded in pdf form created with Libre Office Writer

https://bugs.documentfoundation.org/show_bug.cgi?id=118541

Bug ID: 118541
   Summary: Undesired font embedded in pdf form created with Libre
Office Writer
   Product: LibreOffice
   Version: 6.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jean.francois.ta...@gmail.com

Description:
As I am a French guy, perhaps some of my sentences could be not clear enough.
Sorry for the trouble

I tried to create a pdf form by using LO Writer Version: 6.0.4.2 (x64)
1- save a .odt file
2- export the file as a pdf form, option send fdf
3- open the created pdf form with Adobe Reader DC 2018.011.20038
4- display properties of file, 'font' tab : several fonts are listed.
   a- variants of the Trebuchet font I have chosen
   b- Helvetica
   c- ZapfDingbats
The trouble and possible bug is that 
  1- Neither of these two fonts : Helvetica and ZapfDingbats were used by me in
the original .odt file.
  2- I verified this by exporting the same document to pdf, but without
including any form type (text box or else). The fonts displayed by Adobe Reader
were only variants of Trebuchet
  3- The most strange is that the Helvetica font is not installed on my
computer

I discover this as at some steps of the building of this new form, the pdf
became unreadable : all characters appears as small squares ! Due to the
presence of Helvetica, I presume

So it seems to me that :
- creating text box or else in a .odt file + exporting to pdf form
==> adds unwanted fonts Helvetica and ZapfDingbats
==> can create unreadable pdf forms

Thank you for all the good work done.
Especially the ability to create these very useful pdf forms
[I did this work for an association where I am a volunteer]

Regards

Jean-François TASTE
France

Steps to Reproduce:
1.Create a form with LO Writer, using only one type of font (Trebuchet in my
case)
2.Export this form to pdf
3.Display included fonts in the pdf

Actual Results:
Helvetica and ZapfDingbats are added

Expected Results:
Only original font used should appear


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.0.4.2 (x64)
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
Threads CPU : 4; OS : Windows 10.0; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: group

OS : W10 x64 1803

I don't know whether the same issue occurs or not with older versions of LO
Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108010] WebDAV browser is not showing files/directories containing non-latin characters

https://bugs.documentfoundation.org/show_bug.cgi?id=108010

Vitaliy Lotorev  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #5 from Vitaliy Lotorev  ---
Reproduced on Windows 7 and LibreOffice_6.0.5_Win_x64.msi

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - dictionaries helpcontent2 translations

 dictionaries |2 +-
 helpcontent2 |2 +-
 translations |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e1e96dedefc1bd89f9608413325eb206cee89f6c
Author: Christian Lohmaier 
Date:   Wed Jul 4 22:47:31 2018 +0200

reset submodules to their corresponding branch

Change-Id: I52f3d90a7a0e7b68c2f995d20b34b75792841fe0

diff --git a/dictionaries b/dictionaries
index 034a64c3834e..e240fb03f0ee 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 034a64c3834e3121c24490f58cbc7f9784081dee
+Subproject commit e240fb03f0ee569a17476fdae32a3bb047f02500
diff --git a/helpcontent2 b/helpcontent2
index f1da8711f724..d37a847e3ea2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit f1da8711f724c5f72b17533d48a0f8939929eebf
+Subproject commit d37a847e3ea2560371f4b97d6c52122137c108eb
diff --git a/translations b/translations
index 78ee7de91987..2ed4096e23f5 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 78ee7de9198757e5b81cf158e91f38ce1123c364
+Subproject commit 2ed4096e23f53b0a37bc0240b3cdb9a249432c14
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dictionaries helpcontent2

 dictionaries |2 +-
 helpcontent2 |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 8d69ca2d310de2e6275b93b4fd6cd40f05e9e84e
Author: Christian Lohmaier 
Date:   Wed Jul 4 22:45:06 2018 +0200

reset submodules to their corresponding branch

was broken after gerrit update

Change-Id: I56cc1ab0e9d5bb4acb54d5ca5538fefae290253c

diff --git a/dictionaries b/dictionaries
index 2180c26eabed..43f9b34b3bf6 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 2180c26eabeda8ed3315bc04acd0dd4fc3246736
+Subproject commit 43f9b34b3bf68f252a68827adf59a7f9a4b4d935
diff --git a/helpcontent2 b/helpcontent2
index 02fdfc49125c..2e878c0fb7d7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 02fdfc49125c2059e0153fc9f97da4ed71ae0b2c
+Subproject commit 2e878c0fb7d7ea39589c0b919d649ef109baf1d3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: translations

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cd3525f7c12f884e87000a5f36a717a0374bb1d0
Author: Christian Lohmaier 
Date:   Wed Jul 4 22:36:20 2018 +0200

Update git submodules

* Update translations from branch 'master'
  - update translations for 6.1.0 rc1

and also test the auto-update of the core module

Change-Id: Id4556effa916c1d274f818bb5a5b700617fa6436

  - update translations for 6.1.0 rc1

Change-Id: Ibff5b92a1b44ed2546d3ad25312e272ada2fa350

diff --git a/translations b/translations
index 2aa8e0473318..be22e619a544 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 2aa8e04733181b9e3c3cceb5ecb8fecee1106b24
+Subproject commit be22e619a5440e0e9b8aed19734bac8401220896
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97618] FILEOPEN drawing object (flow chart shapes) distorted in DOCX because of drawing canvas

https://bugs.documentfoundation.org/show_bug.cgi?id=97618

Aron Budea  changed:

   What|Removed |Added

Summary|writer: import .docx:   |FILEOPEN drawing object
   |drawing object (flow chart) |(flow chart shapes)
   |distorted   |distorted in DOCX because
   ||of drawing canvas
 Whiteboard|TooBusyNowNeedsFurtherTesti |
   |ngForPossibleRegressionAndP |
   |ossibleDuplicates   |
 CC||ba...@caesar.elte.hu

--- Comment #5 from Aron Budea  ---
Still occurs in 6.1 beta2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118529] LO crashes when on various UI actions

https://bugs.documentfoundation.org/show_bug.cgi?id=118529

Susan Gessing  changed:

   What|Removed |Added

 CC||susanjea...@yahoo.com

--- Comment #6 from Susan Gessing  ---

I repeated all steps for the following 2 builds. All dialogs opened with no
issues except for the Format->Cells in 6.0.5.2. When I selected this, LO
"almost" crashed. What I mean is it took several seconds and the "not
responding" message appeared right before the Format Cells dialog finally
appeared. It did appear though. (when I selected this option later, after
reopening LO, the dialog came up without hesitation, so none of this may
matter, but I brought it up just in case).

Version: 6.0.5.2 (x64)
Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
Locale: en-US (en_US); Calc: CL

and

Version: 6.2.0.0.alpha0+
Build ID: b1740fba0d1e6e3d69c3781734509317f42a0e4f
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-06-15_08:49:04
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104384] FILEOPEN DOCX: Textboxes in drawing canvas are corrupted

https://bugs.documentfoundation.org/show_bug.cgi?id=104384

Aron Budea  changed:

   What|Removed |Added

 Attachment #129293|application/unknown |application/pdf
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--comfortable for a "Global" user community

https://bugs.documentfoundation.org/show_bug.cgi?id=104318

V Stuart Foote  changed:

   What|Removed |Added

Summary|CTL, CJK, and Western   |CTL, CJK, and Western
   |Language controls in the|Language controls in the
   |GUI cause confusion,|GUI cause confusion,
   |handling languages and  |handling languages and
   |script selection needs  |script selection needs
   |rework--something more  |rework--comfortable for a
   |Unicode flavored|"Global" user community

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104318] CTL, CJK, and Western Language controls in the GUI cause confusion, handling languages and script selection needs rework--something more Unicode flavored

https://bugs.documentfoundation.org/show_bug.cgi?id=104318

V Stuart Foote  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||michael.me...@collabora.com
   Severity|normal  |enhancement
Summary|CTL formatting applies even |CTL, CJK, and Western
   |when CTL checkbox is|Language controls in the
   |unchecked   |GUI cause confusion,
   ||handling languages and
   ||script selection needs
   ||rework--something more
   ||Unicode flavored
 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - default_images/introabout

2018-07-04 Thread Matthias Seidel

 default_images/introabout/logo.png |binary
 1 file changed

New commits:
commit fecd7bd58075f721303296334b70e48a88f6118e
Author: Matthias Seidel 
Date:   Wed Jul 4 18:50:59 2018 +

Set print resolution to 144 pixel/inch

diff --git a/default_images/introabout/logo.png 
b/default_images/introabout/logo.png
index 980d8e8c50f6..834e143b77dc 100644
Binary files a/default_images/introabout/logo.png and 
b/default_images/introabout/logo.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118540] LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Buovjaga  changed:

   What|Removed |Added

 CC||hcas...@collabora.com,
   ||todven...@suomi24.fi
   Keywords||bisected

--- Comment #4 from Buovjaga  ---
Adding Cc: to Henry Castro

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118540] LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Drew Jensen  changed:

   What|Removed |Added

   Keywords||bibisected

--- Comment #3 from Drew Jensen  ---
bibisect output:

9f339ebbf0cab229472e6698c98664f2e629d798 is the first bad commit
commit 9f339ebbf0cab229472e6698c98664f2e629d798
Author: Jenkins Build User 
Date:   Sun Feb 18 18:23:10 2018 +0100

source sha:55f5afe532c61c6bc382f23e17dfeb6ed3985790

source sha:55f5afe532c61c6bc382f23e17dfeb6ed3985790

:04 04 5279b16405070ed4e1d397a4a8e9be657115b1a3
a716f5a506bf758b8b663caf6b259a141f9b5c5a M  instdir

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/qa sc/source

 sc/qa/unit/tiledrendering/tiledrendering.cxx |6 ++
 sc/source/ui/docshell/docsh.cxx  |   19 +++
 sc/source/ui/inc/tabvwsh.hxx |7 +--
 sc/source/ui/undo/undoblk.cxx|2 +-
 sc/source/ui/vba/excelvbahelper.cxx  |4 ++--
 sc/source/ui/view/cellsh.cxx |   25 +++--
 sc/source/ui/view/cellsh1.cxx|   16 +---
 sc/source/ui/view/cliputil.cxx   |2 +-
 sc/source/ui/view/drawvie4.cxx   |1 -
 sc/source/ui/view/gridwin.cxx|2 +-
 sc/source/ui/view/tabvwshc.cxx   |   16 
 sc/source/ui/view/viewfun3.cxx   |   11 +--
 sc/source/ui/view/viewfun7.cxx   |2 +-
 13 files changed, 53 insertions(+), 60 deletions(-)

New commits:
commit 6c2f1a228e297398f3d7eb3140b4c1878f67b7a9
Author: Henry Castro 
Date:   Tue Jun 26 23:32:41 2018 -0400

tdf#118308: Incorrect Paste Special dialog when ...

pasting content from another cell

In tiled rendering case (headless) each window has its own clipboard,
otherwise exists a unique clipboard (UNO service).

Change-Id: I7d5d0b085faeaffa3fc0a80914fbe9349f4aa402
Reviewed-on: https://gerrit.libreoffice.org/56508
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
Reviewed-on: https://gerrit.libreoffice.org/56652
Tested-by: Eike Rathke 

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 84c8ed3b7ed0..9fc932805413 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -15,6 +15,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1550,12 +1551,17 @@ void ScTiledRenderingTest::testMultiViewCopyPaste()
 // view #1
 ScTabViewShell* pView1 = 
dynamic_cast(SfxViewShell::Current());
 CPPUNIT_ASSERT(pView1);
+// emulate clipboard
+
pView1->GetViewData().GetActiveWin()->SetClipboard(css::datatransfer::clipboard::SystemClipboard::create(comphelper::getProcessComponentContext()));
 
 // view #2
 SfxLokHelper::createView();
 ScTabViewShell* pView2 = 
dynamic_cast(SfxViewShell::Current());
+// emulate clipboard
+
pView2->GetViewData().GetActiveWin()->SetClipboard(css::datatransfer::clipboard::SystemClipboard::create(comphelper::getProcessComponentContext()));
 CPPUNIT_ASSERT(pView2);
 CPPUNIT_ASSERT(pView1 != pView2);
+CPPUNIT_ASSERT(pView1->GetViewData().GetActiveWin()->GetClipboard() != 
pView2->GetViewData().GetActiveWin()->GetClipboard());
 
 // copy text view 1
 pView1->SetCursor(0, 0);
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 39ce7714fe1d..3d3e6473cd43 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -2755,24 +2755,11 @@ ScDocFunc *ScDocShell::CreateDocFunc()
 
 ScDocument* ScDocShell::GetClipDoc()
 {
-css::uno::Reference xTransferable;
-
+vcl::Window* pWin = nullptr;
 if (ScTabViewShell* pViewShell = GetBestViewShell())
-xTransferable.set(pViewShell->GetClipData());
-else
-{
-SfxViewFrame* pViewFrame = nullptr;
-css::uno::Reference 
xClipboard;
-
-if ((pViewFrame = SfxViewFrame::GetFirst(this, false)))
-xClipboard = pViewFrame->GetWindow().GetClipboard();
-else if ((pViewFrame = SfxViewFrame::GetFirst()))
- xClipboard = pViewFrame->GetWindow().GetClipboard();
-
-xTransferable.set(xClipboard.is() ? xClipboard->getContents() : 
nullptr, css::uno::UNO_QUERY);
-}
+pWin = pViewShell->GetViewData().GetActiveWin();
 
-const ScTransferObj* pObj = ScTransferObj::GetOwnClipboard(xTransferable);
+const ScTransferObj* pObj = 
ScTransferObj::GetOwnClipboard(ScTabViewShell::GetClipData(pWin));
 if (pObj)
 {
 ScDocument* pDoc = pObj->GetDocument();
diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index 2181e61aa325..8b4753e18c42 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -167,9 +167,6 @@ private:
 OUString   maName;
 OUString   maScope;
 
-// ClipData
-css::uno::Reference   m_xClipData;
-
 private:
 voidConstruct( TriState nForceDesignMode );
 
@@ -394,9 +391,7 @@ public:
 static void notifyAllViewsHeaderInvalidation(bool Columns, SCTAB 
nCurrentTabIndex);
 static bool isAnyEditViewInRange(bool bColumns, SCCOLROW nStart, SCCOLROW 
nEnd);
 css::uno::Reference getSelectedXShapes();
-
-const css::uno::Reference & 
GetClipData() { return m_xClipData; };
-void SetClipData(const 
css::uno::Reference& xTransferable) { 
m_xClipData = xTransferable; }
+static  css::uno::Reference 
GetClipData(vcl::Window* pWin);
 };
 
 #endif
diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

 sc/source/ui/docshell/docsh.cxx  |  542 +++
 sc/source/ui/docshell/docsh2.cxx |   42 +--
 sc/source/ui/docshell/docsh3.cxx |  152 +-
 sc/source/ui/docshell/docsh4.cxx |  342 
 sc/source/ui/docshell/docsh5.cxx |  228 
 sc/source/ui/docshell/docsh6.cxx |   66 ++--
 sc/source/ui/docshell/docsh8.cxx |   40 +-
 sc/source/ui/inc/docsh.hxx   |   70 ++---
 8 files changed, 741 insertions(+), 741 deletions(-)

New commits:
commit 6d7d6d2474e7c37da25cfb6ec88bfb84eb08b62b
Author: Henry Castro 
Date:   Thu May 31 17:39:26 2018 -0400

sc: prefix members of ScDocShell

Change-Id: I7c2a4e5e850b26da515719f7df869f12c49b0ad3
Reviewed-on: https://gerrit.libreoffice.org/55148
Tested-by: Jenkins 
Reviewed-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/56650
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index d2ae9a945c18..6fb0b4dc2a52 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -209,7 +209,7 @@ void ScDocShell::FillClass( SvGlobalName* pClassName,
 
 std::set ScDocShell::GetDocColors()
 {
-return aDocument.GetDocColors();
+return m_aDocument.GetDocColors();
 }
 
 void ScDocShell::DoEnterHandler()
@@ -239,16 +239,16 @@ HiddenInformation ScDocShell::GetHiddenInformationState( 
HiddenInformation nStat
 
 if ( nStates & HiddenInformation::RECORDEDCHANGES )
 {
-if ( aDocument.GetChangeTrack() && 
aDocument.GetChangeTrack()->GetFirst() )
+if ( m_aDocument.GetChangeTrack() && 
m_aDocument.GetChangeTrack()->GetFirst() )
   nState |= HiddenInformation::RECORDEDCHANGES;
 }
 if ( nStates & HiddenInformation::NOTES )
 {
-SCTAB nTableCount = aDocument.GetTableCount();
+SCTAB nTableCount = m_aDocument.GetTableCount();
 bool bFound = false;
 for (SCTAB nTab = 0; nTab < nTableCount && !bFound; ++nTab)
 {
-if (aDocument.HasTabNotes(nTab)) //TODO:
+if (m_aDocument.HasTabNotes(nTab)) //TODO:
 bFound = true;
 }
 
@@ -261,17 +261,17 @@ HiddenInformation ScDocShell::GetHiddenInformationState( 
HiddenInformation nStat
 
 void ScDocShell::BeforeXMLLoading()
 {
-aDocument.EnableIdle(false);
+m_aDocument.EnableIdle(false);
 
 // prevent unnecessary broadcasts and updates
-OSL_ENSURE(pModificator == nullptr, "The Modificator should not exist");
-pModificator = new ScDocShellModificator( *this );
+OSL_ENSURE(m_pModificator == nullptr, "The Modificator should not exist");
+m_pModificator = new ScDocShellModificator( *this );
 
-aDocument.SetImportingXML( true );
-aDocument.EnableExecuteLink( false );   // #i101304# to be safe, prevent 
nested loading from external references
-aDocument.EnableUndo( false );
+m_aDocument.SetImportingXML( true );
+m_aDocument.EnableExecuteLink( false );   // #i101304# to be safe, prevent 
nested loading from external references
+m_aDocument.EnableUndo( false );
 // prevent unnecessary broadcasts and "half way listeners"
-aDocument.SetInsertingFromOtherDoc( true );
+m_aDocument.SetInsertingFromOtherDoc( true );
 }
 
 void ScDocShell::AfterXMLLoading(bool bRet)
@@ -280,22 +280,22 @@ void ScDocShell::AfterXMLLoading(bool bRet)
 {
 UpdateLinks();
 // don't prevent establishing of listeners anymore
-aDocument.SetInsertingFromOtherDoc( false );
+m_aDocument.SetInsertingFromOtherDoc( false );
 if ( bRet )
 {
-ScChartListenerCollection* pChartListener = 
aDocument.GetChartListenerCollection();
+ScChartListenerCollection* pChartListener = 
m_aDocument.GetChartListenerCollection();
 if (pChartListener)
 pChartListener->UpdateDirtyCharts();
 
 // #95582#; set the table names of linked tables to the new path
-SCTAB nTabCount = aDocument.GetTableCount();
+SCTAB nTabCount = m_aDocument.GetTableCount();
 for (SCTAB i = 0; i < nTabCount; ++i)
 {
-if (aDocument.IsLinked( i ))
+if (m_aDocument.IsLinked( i ))
 {
 OUString aName;
-aDocument.GetName(i, aName);
-OUString aLinkTabName = aDocument.GetLinkTab(i);
+m_aDocument.GetName(i, aName);
+OUString aLinkTabName = m_aDocument.GetLinkTab(i);
 sal_Int32 nLinkTabNameLength = aLinkTabName.getLength();
 sal_Int32 nNameLength = aName.getLength();
 if (nLinkTabNameLength < nNameLength)
@@ -326,8 +326,8 @@ void ScDocShell::AfterXMLLoading(bool bRet)
 (aName[nIndex - 1] == '#') && // before 
the table name should be the # char

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/inc sc/qa sc/source

 sc/inc/postit.hxx   |  114 ---
 sc/inc/scmod.hxx|2 
 sc/qa/unit/ucalc.cxx|   18 -
 sc/source/core/data/documen3.cxx|3 
 sc/source/core/data/document.cxx|   10 
 sc/source/core/data/postit.cxx  |  554 +++-
 sc/source/core/tool/detfunc.cxx |2 
 sc/source/filter/excel/xeescher.cxx |2 
 sc/source/filter/xml/xmlexprt.cxx   |   10 
 sc/source/ui/app/scmod.cxx  |   28 -
 sc/source/ui/docshell/docfunc.cxx   |4 
 sc/source/ui/docshell/docsh.cxx |   33 ++
 sc/source/ui/drawfunc/futext3.cxx   |4 
 sc/source/ui/inc/docsh.hxx  |2 
 sc/source/ui/inc/notemark.hxx   |2 
 sc/source/ui/inc/undocell.hxx   |   45 ++
 sc/source/ui/undo/undocell.cxx  |  185 +++-
 sc/source/ui/unoobj/editsrc.cxx |2 
 sc/source/ui/unoobj/notesuno.cxx|2 
 sc/source/ui/view/drawview.cxx  |2 
 sc/source/ui/view/gridwin.cxx   |2 
 sc/source/ui/view/notemark.cxx  |2 
 sc/source/ui/view/tabview5.cxx  |2 
 sc/source/ui/view/viewfun6.cxx  |2 
 24 files changed, 403 insertions(+), 629 deletions(-)

New commits:
commit ee7638061e787e6a1c37b2d3be1c14852cbc3381
Author: Henry Castro 
Date:   Fri Jun 8 17:09:55 2018 -0400

sc: replace ScCaptionPtr with std::shared_ptr, tdf#117997, tdf#117228

Change-Id: I9b6a2c2504c9ce060906ac3bf156721709fef2f3
Reviewed-on: https://gerrit.libreoffice.org/55490
Tested-by: Jenkins
Reviewed-by: Eike Rathke 
Reviewed-on: https://gerrit.libreoffice.org/56651
Tested-by: Eike Rathke 

diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx
index bf29a9693904..de77e208b829 100644
--- a/sc/inc/postit.hxx
+++ b/sc/inc/postit.hxx
@@ -36,110 +36,6 @@ class ScDocument;
 namespace tools { class Rectangle; }
 struct ScCaptionInitData;
 
-/** Some desperate attempt to fight against the caption object ownership mess,
-to which none of shared/weak/plain pointer is a cure.
- */
-class ScCaptionPtr
-{
-public:
-ScCaptionPtr();
-explicit ScCaptionPtr( SdrCaptionObj* p );
-ScCaptionPtr( const ScCaptionPtr& r );
-ScCaptionPtr( ScCaptionPtr&& r );
-~ScCaptionPtr();
-
-ScCaptionPtr& operator=( const ScCaptionPtr& r );
-ScCaptionPtr& operator=( ScCaptionPtr&& r );
-explicit operator bool() const{ return mpCaption != nullptr; }
-const SdrCaptionObj* get() const{ return mpCaption; }
-SdrCaptionObj* get(){ return mpCaption; }
-const SdrCaptionObj* operator->() const { return mpCaption; }
-SdrCaptionObj* operator->() { return mpCaption; }
-const SdrCaptionObj& operator*() const  { return *mpCaption; }
-SdrCaptionObj& operator*()  { return *mpCaption; }
-
-// Does not default to nullptr to make it visually obvious where such is 
used.
-void reset( SdrCaptionObj* p );
-
-/** Insert to draw page. The caption object is owned by the draw page then.
- */
-void insertToDrawPage( SdrPage& rDrawPage );
-
-/** Remove from draw page. The caption object is not owned anymore by the
-draw page then.
- */
-void removeFromDrawPage( SdrPage& rDrawPage );
-
-/** Remove from draw page and free caption object if no Undo recording.
- */
-void removeFromDrawPageAndFree( bool bIgnoreUndo = false );
-
-/** Release all management of the SdrCaptionObj* in all instances of this
-list and dissolve. The SdrCaptionObj pointer returned is ready to be
-managed elsewhere.
- */
-SdrCaptionObj* release();
-
-/** Forget the SdrCaptionObj pointer in this one instance.
-Decrements a use count but does not destroy the object, it's up to the
-caller to manage this mess..
- */
-void forget();
-
-/** Flag that this instance is in Undo, so drawing layer owns it. */
-void setNotOwner();
-
-oslInterlockedCount getRefs() const;
-
-private:
-
-struct Head
-{
-ScCaptionPtr*   mpFirst;///< first in list
-oslInterlockedCount mnRefs; ///< use count
-
-Head() = delete;
-explicit Head( ScCaptionPtr* );
-};
-
-Head* mpHead;   ///< points to the "master" entry
-mutable ScCaptionPtr* mpNext;   ///< next in list
-SdrCaptionObj*mpCaption;///< the caption object, managed by 
head master
-bool  mbNotOwner;   ///< whether this caption object is 
owned by something else, e.g. held in Undo
-/* TODO: can that be moved to Head?
- * It's unclear when to reset, so
- * each instance has its own flag.
- * The last reference count
- * decrement automatically has the
- * then current

[Libreoffice-bugs] [Bug 100856] "More..." menu item in the language menus shows the global preferences dialog instead of a simple dedicated dialog, which is confusing

https://bugs.documentfoundation.org/show_bug.cgi?id=100856

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |qui...@gmail.com,
   |.freedesktop.org|tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Resolution|--- |WONTFIX

--- Comment #3 from Heiko Tietze  ---
We discussed the topic in the design meeting. The "More..." item is a nice
shortcut and useful to define the language for paragraph/section/all text. The
workflow via character dialog is strangely interrelated to how unicode scripts
are taken. All together we recommend to not change the current situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100856] "More..." menu item in the language menus shows the global preferences dialog instead of a simple dedicated dialog, which is confusing

https://bugs.documentfoundation.org/show_bug.cgi?id=100856

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |qui...@gmail.com,
   |.freedesktop.org|tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Resolution|--- |WONTFIX

--- Comment #3 from Heiko Tietze  ---
We discussed the topic in the design meeting. The "More..." item is a nice
shortcut and useful to define the language for paragraph/section/all text. The
workflow via character dialog is strangely interrelated to how unicode scripts
are taken. All together we recommend to not change the current situation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 118330] [NEWHELP] Change of terminology in CONTENTS sidebar

https://bugs.documentfoundation.org/show_bug.cgi?id=118330

--- Comment #5 from Adolfo Jayme  ---
I second Cor. Also, I see no value in adding an all-caps SHOUTOUT everywhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - 2 commits - sc/CppunitTest_sc_tiledrendering.mk sc/inc sc/qa sc/source

 sc/CppunitTest_sc_tiledrendering.mk   |2 
 sc/inc/scmod.hxx  |8 ---
 sc/qa/unit/tiledrendering/data/RangeCopyPaste.ods |binary
 sc/qa/unit/tiledrendering/tiledrendering.cxx  |   24 +++
 sc/source/ui/app/scmod.cxx|   24 ---
 sc/source/ui/docshell/docsh.cxx   |   48 ++
 sc/source/ui/inc/docsh.hxx|   11 +
 sc/source/ui/vba/excelvbahelper.cxx   |   15 --
 sc/source/ui/vba/vbarange.cxx |3 -
 9 files changed, 106 insertions(+), 29 deletions(-)

New commits:
commit 87dbab4452293903ac407bbb6b0bdd37207618e6
Author: Henry Castro 
Date:   Mon May 28 10:20:53 2018 -0400

sc: simplify ScModule::GetClipDoc

Change-Id: I36a79a41b989d37efc35a9f9b4bebca9bdaf9ee9
Reviewed-on: https://gerrit.libreoffice.org/54935
Tested-by: Jenkins 
Reviewed-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/56649
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index fc8145365871..26652ddf1808 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -662,28 +662,22 @@ void ScModule::SetDragJump(
 ScDocument* ScModule::GetClipDoc()
 {
 // called from document
+SfxViewFrame* pViewFrame = nullptr;
 ScTabViewShell* pViewShell = nullptr;
-const ScTransferObj* pObj = nullptr;
+css::uno::Reference xTransferable;
 
 if ((pViewShell = dynamic_cast(SfxViewShell::Current(
-pObj = ScTransferObj::GetOwnClipboard(pViewShell->GetClipData());
+xTransferable.set(pViewShell->GetClipData());
 else if ((pViewShell = 
dynamic_cast(SfxViewShell::GetFirst(
-pObj = ScTransferObj::GetOwnClipboard(pViewShell->GetClipData());
-else
+xTransferable.set(pViewShell->GetClipData());
+else if ((pViewFrame = SfxViewFrame::GetFirst()))
 {
-css::uno::Reference 
xClipboard;
-
-if (SfxViewFrame* pViewFrame = SfxViewFrame::GetFirst())
-xClipboard = pViewFrame->GetWindow().GetClipboard();
-
-if (xClipboard.is())
-{
-css::uno::Reference 
xTransferable(
-xClipboard->getContents(), css::uno::UNO_QUERY);
-pObj = ScTransferObj::GetOwnClipboard(xTransferable);
-}
+css::uno::Reference 
xClipboard =
+pViewFrame->GetWindow().GetClipboard();
+xTransferable.set(xClipboard.is() ? xClipboard->getContents() : 
nullptr, css::uno::UNO_QUERY);
 }
 
+const ScTransferObj* pObj = ScTransferObj::GetOwnClipboard(xTransferable);
 if (pObj)
 {
 ScDocument* pDoc = pObj->GetDocument();
commit 3ec1c27bf30d9b91a90220793147838cbf726a0d
Author: Henry Castro 
Date:   Thu May 17 11:12:56 2018 -0400

sc: release XTransferable2 when used with VBA compatibility helpers

Copy, Cut, PasteSpecial and Insert is used by Range excel object,
so after finishing executing the VBA script ensure to release XTransferable2
interface

Change-Id: I967a7ba1a1d101282f7a1b9d4b2e2ac3004f1c07
Reviewed-on: https://gerrit.libreoffice.org/54497
Tested-by: Jenkins 
Reviewed-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/56648
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/CppunitTest_sc_tiledrendering.mk 
b/sc/CppunitTest_sc_tiledrendering.mk
index ac70a06453ad..03e33652a69c 100644
--- a/sc/CppunitTest_sc_tiledrendering.mk
+++ b/sc/CppunitTest_sc_tiledrendering.mk
@@ -30,6 +30,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sc_tiledrendering, 
\
 scui \
 test \
 unotest \
+vbahelper \
 vcl \
 tl \
 utl \
@@ -47,6 +48,7 @@ $(eval $(call gb_CppunitTest_set_include,sc_tiledrendering,\
 ))
 
 $(eval $(call gb_CppunitTest_use_sdk_api,sc_tiledrendering))
+$(eval $(call gb_CppunitTest_use_api,sc_tiledrendering,oovbaapi))
 
 $(eval $(call gb_CppunitTest_use_ure,sc_tiledrendering))
 $(eval $(call gb_CppunitTest_use_vcl,sc_tiledrendering))
diff --git a/sc/inc/scmod.hxx b/sc/inc/scmod.hxx
index b2742ddba9a0..1ef0eed7b936 100644
--- a/sc/inc/scmod.hxx
+++ b/sc/inc/scmod.hxx
@@ -82,8 +82,7 @@ class ScModule: public SfxModule, public SfxListener, public 
utl::ConfigurationL
 ScDragData* m_pDragData;
 ScSelectionTransferObj* m_pSelTransfer;
 ScMessagePool*  m_pMessagePool;
-css::uno::Reference m_xClipData; // 
Only used by Vba helper functions
-// there is no global InputHandler anymore, each View has its own
+// there is no global InputHandler anymore, each View has it's own
 ScInputHandler* m_pRefInputHandler;
 ScViewCfg*  m_pViewCfg;
 ScDocCfg*   m_pDocCfg;
@@ -175,11 +174,6 @@ public:
 voidSetPrintOptions ( const ScPrintOptions& rOpt );
 voidInsertEntryToLRUList(sal_uInt16 nFIndex);
 
-

[Libreoffice-bugs] [Bug 118481] Display full view of all conditions in dialogue Conditional formatting for...

https://bugs.documentfoundation.org/show_bug.cgi?id=118481

Heiko Tietze  changed:

   What|Removed |Added

 CC||qui...@gmail.com,
   ||vstuart.fo...@utsa.edu

--- Comment #6 from Heiko Tietze  ---
We discussed the topic in the design session. The idea with user-defined
strings likely fails due to missing ODF specification. So we recommend to have
the section likewise a normal tree (whether plus/minus or triangle to
expand/collapse) inclusive an additional expand/collapse all control.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 118330] [NEWHELP] Change of terminology in CONTENTS sidebar

https://bugs.documentfoundation.org/show_bug.cgi?id=118330

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
  Component|Documentation   |UI
 Ever confirmed|0   |1
   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |so...@libreoffice.org,
   |.freedesktop.org|tietze.he...@gmail.com

--- Comment #4 from Heiko Tietze  ---
We discussed the topic in the design meeting. While the idea to promote module
names is good we think the clear names are more important. Good compromise
might be to add modules in brackets.

Macro and programming  -> Macros and scripting
Spreadsheets -> Spreadsheets (CALC)
Charts and Diagrams -> Charts and Diagrams
Installation -> %PRODUCTNAME Installation
Common Help Topics -> Common Help Topics
Database Functionality -> Database Functionality (BASE)
Presentation and drawings -> Presentation and drawings (IMPRESS/DRAW)
Formulas -> Formulas (MATH)
Text Documents -> Text Documents (WRITER)
HTML documents -> HTML documents (WRITER WEB)

We should involve l10n for the actual labels, for example if the modules are
written uppercase etc.

To think ahead we should do the same for the menu at File > New
 + Text documents (WRITER)
 ...
 + Database (BASE)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 118330] [NEWHELP] Change of terminology in CONTENTS sidebar

https://bugs.documentfoundation.org/show_bug.cgi?id=118330

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
  Component|Documentation   |UI
 Ever confirmed|0   |1
   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |so...@libreoffice.org,
   |.freedesktop.org|tietze.he...@gmail.com

--- Comment #4 from Heiko Tietze  ---
We discussed the topic in the design meeting. While the idea to promote module
names is good we think the clear names are more important. Good compromise
might be to add modules in brackets.

Macro and programming  -> Macros and scripting
Spreadsheets -> Spreadsheets (CALC)
Charts and Diagrams -> Charts and Diagrams
Installation -> %PRODUCTNAME Installation
Common Help Topics -> Common Help Topics
Database Functionality -> Database Functionality (BASE)
Presentation and drawings -> Presentation and drawings (IMPRESS/DRAW)
Formulas -> Formulas (MATH)
Text Documents -> Text Documents (WRITER)
HTML documents -> HTML documents (WRITER WEB)

We should involve l10n for the actual labels, for example if the modules are
written uppercase etc.

To think ahead we should do the same for the menu at File > New
 + Text documents (WRITER)
 ...
 + Database (BASE)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 104318] CTL formatting applies even when CTL checkbox is unchecked

https://bugs.documentfoundation.org/show_bug.cgi?id=104318

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |so...@libreoffice.org
   |.freedesktop.org|
   Keywords|needsUXEval |

--- Comment #25 from Heiko Tietze  ---
We discussed the topic in the design meeting. The recommendation is to remove
language dependent font families from tools > options at language as well as
the modules. The default setting should be defined in
officecfg/registry/data/org/openoffice/VCL.xcu or
i18npool/source/localedata/data/* (l10n may be interested in supporting the
default definition) with the usual way to override per styles: default (or
below in the hierarchy). The same workflow should work for paragraphs with a
different language.
Dev should consider side-effects such as search for kashida, which was only
working when CTL was enabled (bug 116242).

From the minutes:

   + e.g. in tabs with Tools > Options > Language Settings > Default on top
   + remove “For the current document only”
   + drawback: displaces language settings (locale = english) and font settings
(default = english)
   + how to deal with the character dialog? (Tomaz)
 + consequently we have to show all types at every time (Heiko)
 + could do that similar to fill styles (color, gradient, pattern...)
 + all types are needed in parallel so switching is bad (Tomaz)

   + flatten out "languages" needed/wanted (Stuart)
   + how to assign a default font to headings/text depending on locales
   + maybe add it to
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/VCL.xcu
 
 or in files below
https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/
 + see also tdf#112879
   + take defaults from this/these files (remove tools > options > language
settings > languages: default languages)
   => remove also _all_ tools > options > writer > basic fonts (*) and let the
user set-up defaults per styles: default
   + in multi-language documents/workflows the user is supposed to create
paragraph styles with specific languages that take their default from the
(non-configurable) defaults and may customize in the paragraph style dialog
   + when removing cjk/ctl dev should take care of spaghetti code similar to 
search/kashida sensitive depends in the past on tools > options > languages
on/off ( https://bugs.documentfoundation.org/show_bug.cgi?id=116242 )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 104318] CTL formatting applies even when CTL checkbox is unchecked

https://bugs.documentfoundation.org/show_bug.cgi?id=104318

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |so...@libreoffice.org
   |.freedesktop.org|
   Keywords|needsUXEval |

--- Comment #25 from Heiko Tietze  ---
We discussed the topic in the design meeting. The recommendation is to remove
language dependent font families from tools > options at language as well as
the modules. The default setting should be defined in
officecfg/registry/data/org/openoffice/VCL.xcu or
i18npool/source/localedata/data/* (l10n may be interested in supporting the
default definition) with the usual way to override per styles: default (or
below in the hierarchy). The same workflow should work for paragraphs with a
different language.
Dev should consider side-effects such as search for kashida, which was only
working when CTL was enabled (bug 116242).

>From the minutes:

   + e.g. in tabs with Tools > Options > Language Settings > Default on top
   + remove “For the current document only”
   + drawback: displaces language settings (locale = english) and font settings
(default = english)
   + how to deal with the character dialog? (Tomaz)
 + consequently we have to show all types at every time (Heiko)
 + could do that similar to fill styles (color, gradient, pattern...)
 + all types are needed in parallel so switching is bad (Tomaz)

   + flatten out "languages" needed/wanted (Stuart)
   + how to assign a default font to headings/text depending on locales
   + maybe add it to
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/VCL.xcu
 
 or in files below
https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/
 + see also tdf#112879
   + take defaults from this/these files (remove tools > options > language
settings > languages: default languages)
   => remove also _all_ tools > options > writer > basic fonts (*) and let the
user set-up defaults per styles: default
   + in multi-language documents/workflows the user is supposed to create
paragraph styles with specific languages that take their default from the
(non-configurable) defaults and may customize in the paragraph style dialog
   + when removing cjk/ctl dev should take care of spaghetti code similar to 
search/kashida sensitive depends in the past on tools > options > languages
on/off ( https://bugs.documentfoundation.org/show_bug.cgi?id=116242 )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Minutes from the design meeting 2018-Jul-04

2018-07-04 Thread Heiko Tietze

Present: Tomaz, Stuart, Heiko

Last week(')s todo's

 * Tools > Options > Asian/CTL always active
   Jun/27
   + https://bugs.documentfoundation.org/show_bug.cgi?id=104318 
   + e.g. in tabs with Tools > Options > Language Settings > Default on top
   + remove “For the current document only”
   + drawback: displaces language settings (locale = english) and font settings 
(default = english)
   + how to deal with the character dialog? (Tomaz)
 + consequently we have to show all types at every time (Heiko)
 + could do that similar to fill styles (color, gradient, pattern...)
 + all types are needed in parallel so switching is bad (Tomaz)
   Jul/04 
   + flatten out "languages" needed/wanted (Stuart)
   + how to assign a default font to headings/text depending on locales
   + maybe add it to 
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/VCL.xcu
 
 or in files below 
https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/
 + see also tdf#112879
   + take defaults from this/these files (remove tools > options > language 
settings > languages: default languages)
   => remove also _all_ tools > options > writer > basic fonts (*) and let the 
user set-up defaults 
 per styles: default
   + in multi-language documents/workflows the user is supposed to create 
paragraph styles with specific langauges
 that take their default from the (non-configurable) defaults and may 
customize in the paragraph style dialog
   + when removing cjk/ctl dev should take care of spaghetti code similar to  
search/kashida sensitive depends 
 in the past on tools > options > languages on/off ( 
https://bugs.documentfoundation.org/show_bug.cgi?id=116242 )

Tickets

 * Terminology in CONTENTS sidebar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118330 
   + use of module names instead of clear names, eg. Text document -> WRITER
   + promoting the modules is a good idea but not alone
   => better in brackets like "Text document (WRITER)" if there is an explicite 
module
 + Macro and programming  -> Macros and scripting
 + Spreadsheets -> Spreadsheets (CALC)
 + Charts and Diagrams -> Charts and Diagrams
 + Installation -> %PRODUCTNAME Installation
 + Common Help Topics -> Common Help Topics
 + Database Functionality -> Database Functionality (BASE)
 + Presentation and drawings -> Presentation and drawings (IMPRESS/DRAW)
 + Formulas -> Formulas (MATH)
 + Text Documents -> Text Documents (WRITER)
 + HTML documents -> HTML documents (WRITER WEB)
   => involve l10n for the actual labels whether or not upper case etc.
   => to think ahead we could also add this to File > New
 + Text documents (WRITER)
 ...
 + Database (BASE)

 * Calc, Conditional formatting: Drop expandable sections and show all at once
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118481 
   + introduce a user-defined string (Heiko)
   + might not be part of the ODF spec (Tomaz)
   + go with a standard tree that allow to keep nodes open including a switch 
to expand (or collapse) all nodes (Stuart)
   => do that

 * Tools > Language > For * > More...
   + https://bugs.documentfoundation.org/show_bug.cgi?id=100856 
   + remove "More..."
   + nice shortcut (Tomaz)
   + weird relation between font/unicode -> language <- dictionary (Stuart)
 needs additional review given possible Asian/CTL rework
   => better keep it = WF





signature.asc
Description: OpenPGP digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Minutes from the design meeting 2018-Jul-04

2018-07-04 Thread Heiko Tietze

Present: Tomaz, Stuart, Heiko

Last week(')s todo's

 * Tools > Options > Asian/CTL always active
   Jun/27
   + https://bugs.documentfoundation.org/show_bug.cgi?id=104318 
   + e.g. in tabs with Tools > Options > Language Settings > Default on top
   + remove “For the current document only”
   + drawback: displaces language settings (locale = english) and font settings 
(default = english)
   + how to deal with the character dialog? (Tomaz)
 + consequently we have to show all types at every time (Heiko)
 + could do that similar to fill styles (color, gradient, pattern...)
 + all types are needed in parallel so switching is bad (Tomaz)
   Jul/04 
   + flatten out "languages" needed/wanted (Stuart)
   + how to assign a default font to headings/text depending on locales
   + maybe add it to 
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/VCL.xcu
 
 or in files below 
https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/
 + see also tdf#112879
   + take defaults from this/these files (remove tools > options > language 
settings > languages: default languages)
   => remove also _all_ tools > options > writer > basic fonts (*) and let the 
user set-up defaults 
 per styles: default
   + in multi-language documents/workflows the user is supposed to create 
paragraph styles with specific langauges
 that take their default from the (non-configurable) defaults and may 
customize in the paragraph style dialog
   + when removing cjk/ctl dev should take care of spaghetti code similar to  
search/kashida sensitive depends 
 in the past on tools > options > languages on/off ( 
https://bugs.documentfoundation.org/show_bug.cgi?id=116242 )

Tickets

 * Terminology in CONTENTS sidebar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118330 
   + use of module names instead of clear names, eg. Text document -> WRITER
   + promoting the modules is a good idea but not alone
   => better in brackets like "Text document (WRITER)" if there is an explicite 
module
 + Macro and programming  -> Macros and scripting
 + Spreadsheets -> Spreadsheets (CALC)
 + Charts and Diagrams -> Charts and Diagrams
 + Installation -> %PRODUCTNAME Installation
 + Common Help Topics -> Common Help Topics
 + Database Functionality -> Database Functionality (BASE)
 + Presentation and drawings -> Presentation and drawings (IMPRESS/DRAW)
 + Formulas -> Formulas (MATH)
 + Text Documents -> Text Documents (WRITER)
 + HTML documents -> HTML documents (WRITER WEB)
   => involve l10n for the actual labels whether or not upper case etc.
   => to think ahead we could also add this to File > New
 + Text documents (WRITER)
 ...
 + Database (BASE)

 * Calc, Conditional formatting: Drop expandable sections and show all at once
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118481 
   + introduce a user-defined string (Heiko)
   + might not be part of the ODF spec (Tomaz)
   + go with a standard tree that allow to keep nodes open including a switch 
to expand (or collapse) all nodes (Stuart)
   => do that

 * Tools > Language > For * > More...
   + https://bugs.documentfoundation.org/show_bug.cgi?id=100856 
   + remove "More..."
   + nice shortcut (Tomaz)
   + weird relation between font/unicode -> language <- dictionary (Stuart)
 needs additional review given possible Asian/CTL rework
   => better keep it = WF





signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] help.git: source/text

2018-07-04 Thread Adolfo Jayme Barrientos

 source/text/shared/optionen/01010400.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2e878c0fb7d7ea39589c0b919d649ef109baf1d3
Author: Adolfo Jayme Barrientos 
Date:   Wed Jul 4 14:27:29 2018 -0500

tdf#117620 Update user-facing name of IgnoreAllList in Help

Change-Id: I706944e950c7fb6adeb577819df47f251c9ff96b

diff --git a/source/text/shared/optionen/01010400.xhp 
b/source/text/shared/optionen/01010400.xhp
index 4f6694b23..7c8a69f7f 100644
--- a/source/text/shared/optionen/01010400.xhp
+++ b/source/text/shared/optionen/01010400.xhp
@@ -82,7 +82,7 @@
 
 Book
 Specifies the book to be 
edited.
-The IgnoreAllList (All) includes all words that have 
been marked with Ignore during spellcheck. This list is valid only 
for the current spellcheck.
+The List of Ignored Words (All) includes all words 
that have been marked with Ignore during spellcheck. This list is 
valid only for the current spellcheck.
 The 
IgnoreAllList entry cannot be selected and cannot be deleted. Only 
the words included as content can be deleted. This happens automatically each 
time that $[officename] is closed.
 
 Language
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118540] LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Drew Jensen  changed:

   What|Removed |Added

   Keywords||regression
 CC||drewjensen.in...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
Bug 102593 depends on bug 104213, which changed state.

Bug 104213 Summary: Copy/Insert a row causes Calc to freeze
https://bugs.documentfoundation.org/show_bug.cgi?id=104213

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104213] Copy/Insert a row causes Calc to freeze

https://bugs.documentfoundation.org/show_bug.cgi?id=104213

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #8 from Buovjaga  ---
(In reply to Xavier Van Wijmeersch from comment #7)
> tested with original file, works fine.
> suggest to upgrade to 6.0.5.2

Yep, works now.

Arch Linux 64-bit
Version: 6.2.0.0.alpha0+
Build ID: ea39c41fdf63191579d25f327db81db14862251c
CPU threads: 8; OS: Linux 4.17; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on July 4th 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118540] LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Drew Jensen  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from Drew Jensen  ---
Confirmed, crash with both Version: 6.2.0.0.alpha0+
Build ID: 6af8aa411189993942d4a8a13199b0a5e026c003
CPU threads: 4; OS: Linux 4.15; UI render: GL; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-06-28_23:11:37

and 6.1 Beta2 (again Ubuntu 18.04)

No problem with 6.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102364] Freeze when doing Crtl + Z on large spreadsheet with concatenation

https://bugs.documentfoundation.org/show_bug.cgi?id=102364

Buovjaga  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

--- Comment #10 from Buovjaga  ---
Bibisected on Ubuntu 14.04 with 43all to range
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=923312f67fbf120158f01c2c0e588af38fc22364...a2c34b3d9ac2d7e43e52846308cc63447fd51f23

Might be from this extensive commit and the ones related to it:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=59f38babd074cc0b835a5d2a1c81af013dba0deb

Remove broadcaster from ScBaseCell, remove ScNoteCell and CELLTYPE_NOTE...
and Calc is now officially broken.  Let's start fixing this bit by bit...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sd/source

2018-07-04 Thread Justin Luth

 sd/source/ui/inc/DrawViewShell.hxx |4 
 sd/source/ui/view/drviews4.cxx |9 +
 sd/source/ui/view/drviewsa.cxx |2 ++
 sd/source/ui/view/drviewsh.cxx |5 -
 4 files changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 85ba2c3193d83c84e584ea8c008fdd4019cb8e2b
Author: Justin Luth 
Date:   Tue May 22 19:32:25 2018 +0300

tdf#109190 sd: only MakeVisible on mouseclick-up

Since MakeVisible() is called on both
mousebuttom-down and mousebuttom-up,
this also eliminates useless double-processing.

In the problematic use case, the user pressed Ctrl-A to select
a tall table. When clicking to de-select the cells, the contents
moved around in unexpected ways because the rectangle is at the
end of the selection during down-click, not at the cursor location.
The re-arrangment of the screen invalidates the mouse-up,
so the intended cursor position shifted.

In the bug's calendar example, position the screen so that items
20-31 are hidden, select the whole month, and then click
on 5. Before, it would move the screen down to show 31, and
the cursor would be placed at the screen position where 5
had originally been. Solved by only repositioning on
mouse-click up.

However, mouseButtonDown must still be honoured while
selecting, otherwise you can't select off-screen content
with the mouse.

This backport contains part of NFC commit b25f5909,
missing initialization commit
93bfc16d7d520042f58fa26968a2a9adbbe2afbe
and cancel MouseSelecting commit
e1bab58778fd501f2d2aff7e5dc61eefdc229c9a

Change-Id: I41c90a7b113dc59a3c8c385139a5bb41993646fa
Reviewed-on: https://gerrit.libreoffice.org/56262
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-on: https://gerrit.libreoffice.org/56799
Tested-by: Justin Luth 
Reviewed-by: Christian Lohmaier 

diff --git a/sd/source/ui/inc/DrawViewShell.hxx 
b/sd/source/ui/inc/DrawViewShell.hxx
index 1db285351c1b..92d02af8b7f9 100644
--- a/sd/source/ui/inc/DrawViewShell.hxx
+++ b/sd/source/ui/inc/DrawViewShell.hxx
@@ -116,6 +116,8 @@ public:
 virtual voidMouseButtonUp(const MouseEvent& rMEvt, ::sd::Window* pWin) 
override;
 virtual voidMouseButtonDown(const MouseEvent& rMEvt, ::sd::Window* 
pWin) override;
 virtual voidCommand(const CommandEvent& rCEvt, ::sd::Window* pWin) 
override;
+boolIsMouseButtonDown() { return mbMouseButtonDown; }
+boolIsMouseSelecting() { return mbMouseSelecting; }
 
 virtual voidResize() override;
 
@@ -445,6 +447,8 @@ private:
 css::uno::Reference< css::lang::XEventListener >  mxScannerListener;
 rtl::Reference mxClipEvtLstnr;
 bool  mbPastePossible;
+bool  mbMouseButtonDown;
+bool  mbMouseSelecting;
 
 virtual void Notify (SfxBroadcaster& rBC, const SfxHint& rHint) override;
 
diff --git a/sd/source/ui/view/drviews4.cxx b/sd/source/ui/view/drviews4.cxx
index a8e2621a1834..5ac6d84df981 100644
--- a/sd/source/ui/view/drviews4.cxx
+++ b/sd/source/ui/view/drviews4.cxx
@@ -269,6 +269,9 @@ void DrawViewShell::FreshNavigatrTree()
 void DrawViewShell::MouseButtonDown(const MouseEvent& rMEvt,
 ::sd::Window* pWin)
 {
+mbMouseButtonDown = true;
+mbMouseSelecting = false;
+
 // We have to check if a context menu is shown and we have an UI
 // active inplace client. In that case we have to ignore the mouse
 // button down event. Otherwise we would crash (context menu has been
@@ -300,6 +303,9 @@ void DrawViewShell::MouseButtonDown(const MouseEvent& rMEvt,
 
 void DrawViewShell::MouseMove(const MouseEvent& rMEvt, ::sd::Window* pWin)
 {
+if ( IsMouseButtonDown() )
+mbMouseSelecting = true;
+
 if ( !IsInputLocked() )
 {
 if ( mpDrawView->IsAction() )
@@ -409,6 +415,8 @@ void DrawViewShell::MouseMove(const MouseEvent& rMEvt, 
::sd::Window* pWin)
 
 void DrawViewShell::MouseButtonUp(const MouseEvent& rMEvt, ::sd::Window* pWin)
 {
+mbMouseButtonDown = false;
+
 if ( !IsInputLocked() )
 {
 bool bIsSetPageOrg = mpDrawView->IsSetPageOrg();
@@ -446,6 +454,7 @@ void DrawViewShell::MouseButtonUp(const MouseEvent& rMEvt, 
::sd::Window* pWin)
 //else the corresponding entry is set false .
 FreshNavigatrTree();
 }
+mbMouseSelecting = false;
 }
 
 void DrawViewShell::Command(const CommandEvent& rCEvt, ::sd::Window* pWin)
diff --git a/sd/source/ui/view/drviewsa.cxx b/sd/source/ui/view/drviewsa.cxx
index f894b074bd8f..7b8c1ce2b194 100644
--- a/sd/source/ui/view/drviewsa.cxx
+++ b/sd/source/ui/view/drviewsa.cxx
@@ -112,6 +112,8 @@ DrawViewShell::DrawViewShell( ViewShellBase& 
rViewShellBase, vcl::Window* pParen
   [this] () { return this->GetSidebarContextName(); },

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - chart2/qa oox/source

2018-07-04 Thread Justin Luth

 chart2/qa/extras/chart2export.cxx |1 +
 oox/source/export/chartexport.cxx |2 ++
 2 files changed, 3 insertions(+)

New commits:
commit 58284e26fa604edc02b7598cb77a5b272c288320
Author: Justin Luth 
Date:   Thu Jun 28 21:21:29 2018 +0300

tdf#115945 oox export: data label writeRunProperties

DataLabel font was always returning to the default - black.

Change-Id: I6c72a8daa699394b36f69fc54e0ba042f0255c18
Reviewed-on: https://gerrit.libreoffice.org/56616
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Szymon Kłos 
(cherry picked from commit ae2fd281e046b2199ef44777b84518cd3abb2952)
Reviewed-on: https://gerrit.libreoffice.org/56725
Reviewed-by: Christian Lohmaier 

diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index b77aeda6755b..da15d321a881 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -1583,6 +1583,7 @@ void Chart2ExportTest::testCustomDataLabel()
 load("/chart2/qa/extras/data/pptx/", "tdf115107.pptx");
 xmlDocPtr pXmlDoc = parseExport("ppt/charts/chart1", "Impress MS 
PowerPoint 2007 XML");
 CPPUNIT_ASSERT(pXmlDoc);
+assertXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:barChart/c:ser/c:dLbls/c:dLbl[1]/c:txPr/a:p/a:pPr/a:defRPr/a:solidFill/a:srgbClr",
 "val", "404040");
 
 Reference xChartDoc(getChartDocFromDrawImpress(0, 
0), uno::UNO_QUERY);
 CPPUNIT_ASSERT(xChartDoc.is());
diff --git a/oox/source/export/chartexport.cxx 
b/oox/source/export/chartexport.cxx
index bd91390d5f3c..16ae6a190ea3 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -3180,10 +3180,12 @@ void ChartExport::exportDataLabels(
 // Individual label property that overwrites the baseline.
 pFS->startElement(FSNS(XML_c, XML_dLbl), FSEND);
 pFS->singleElement(FSNS(XML_c, XML_idx), XML_val, I32S(nIdx), FSEND);
+exportTextProps( xPropSet );
 writeLabelProperties(pFS, this, xLabelPropSet, aParam);
 pFS->endElement(FSNS(XML_c, XML_dLbl));
 }
 
+exportTextProps( xPropSet );
 // Baseline label properties for all labels.
 writeLabelProperties(pFS, this, xPropSet, aParam);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sw/uiconfig

2018-07-04 Thread andreas kainz

 sw/uiconfig/swriter/ui/notebookbar.ui|  667 +-
 sw/uiconfig/swriter/ui/notebookbar_compact.ui| 1014 ++-
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui | 4745 +--
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui|  717 ++
 4 files changed, 5011 insertions(+), 2132 deletions(-)

New commits:
commit 5ac2b0a3748078d92c3ca8caeef276318bdb7176
Author: andreas kainz 
Date:   Wed Jul 4 17:06:37 2018 +0200

NB add support for media and printpreview content view

Change-Id: I6c9376c96a4bb4b7385aad3f48facdd36899e29a
Reviewed-on: https://gerrit.libreoffice.org/56956
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/sw/uiconfig/swriter/ui/notebookbar.ui 
b/sw/uiconfig/swriter/ui/notebookbar.ui
index f7fd0a5b5d99..a2a609ef8bf5 100644
--- a/sw/uiconfig/swriter/ui/notebookbar.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar.ui
@@ -1098,6 +1098,92 @@
   
 
   
+  
+True
+False
+
+  
+True
+False
+.uno:ShowSinglePage
+  
+
+
+  
+True
+False
+.uno:ShowTwoPages
+  
+
+
+  
+True
+False
+.uno:ShowBookview
+  
+
+
+  
+True
+False
+.uno:ShowMultiplePages
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:GoToStartOfDoc
+  
+
+
+  
+True
+False
+.uno:PageUp
+  
+
+
+  
+True
+False
+.uno:PageDown
+  
+
+
+  
+True
+False
+.uno:GoToEndOfDoc
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:Print
+  
+
+
+  
+True
+False
+.uno:ClosePreview
+  
+
+  
   
 True
 False
@@ -12249,6 +12335,447 @@
   
 
 
+  
+True
+False
+
+  
+True
+False
+center
+True
+
+  
+True
+False
+center
+True
+
+  
+True
+False
+immediate
+both
+False
+
+  
+True
+False
+.uno:ShowSinglePage
+  
+  
+False
+True
+  
+
+
+  
+True
+False
+.uno:ShowTwoPages
+  
+  
+False
+True
+  
+
+
+  
+True
+False
+.uno:ShowBookview
+  
+  
+False
+True
+  
+
+
+  
+True
+False
+center
+True
+.uno:ShowMultiplePages
+  
+  
+False
+False
+  
+
+  
+  
+False
+False
+0
+  
+
+
+  
+True
+False
+5
+5
+vertical
+  
+  
+False
+True
+5
+3
+  
+
+

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - solenv/gbuild

 solenv/gbuild/AllLangHelp.mk |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 4b475eb9f46082c5fd1e414f458da038264e6066
Author: Christian Lohmaier 
Date:   Wed Jul 4 17:23:15 2018 +0200

move helpfiles pattern rule above the plaing get_target one

as mac's make might pick the one without the dependency on the direcotry
when trying to "make" that .helpfiles target

Change-Id: I60a55be118bc9a41352dad94326247b02aef1dd6
Reviewed-on: https://gerrit.libreoffice.org/56961
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/solenv/gbuild/AllLangHelp.mk b/solenv/gbuild/AllLangHelp.mk
index c84714231507..475e7c0b326c 100644
--- a/solenv/gbuild/AllLangHelp.mk
+++ b/solenv/gbuild/AllLangHelp.mk
@@ -18,6 +18,12 @@ gb_AllLangHelp_AUXDIR := 
$(gb_AllLangHelp_HELPDIR)/$(gb_AllLangHelp_AUXDIRNAME)
 
 gb_AllLangHelp__get_helpname = $(1)/$(2)
 
+ifneq ($(ENABLE_HTMLHELP),)
+$(call gb_AllLangHelp_get_helpfiles_target,%): | \
+$(dir $(call gb_AllLangHelp_get_helpfiles_target,%)).dir
+   touch $@
+endif
+
 $(dir $(call gb_AllLangHelp_get_target,%)).dir :
$(if $(wildcard $(dir $@)),,mkdir -p $(dir $@))
 
@@ -103,12 +109,6 @@ endif
 
 endef
 
-ifneq ($(ENABLE_HTMLHELP),)
-$(call gb_AllLangHelp_get_helpfiles_target,%): | \
-$(dir $(call gb_AllLangHelp_get_helpfiles_target,%)).dir
-   touch $@
-endif
-
 # Add additional localized file to the help pack.
 #
 # gb_AllLangHelp_add_localized_file module basedir file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/gbuild

 solenv/gbuild/AllLangHelp.mk |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit b547f6a2d7fa228f195963314de9d256cc1ec8e5
Author: Christian Lohmaier 
Date:   Wed Jul 4 17:23:15 2018 +0200

move helpfiles pattern rule above the plaing get_target one

as mac's make might pick the one without the dependency on the direcotry
when trying to "make" that .helpfiles target

Change-Id: I60a55be118bc9a41352dad94326247b02aef1dd6
Reviewed-on: https://gerrit.libreoffice.org/56960
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/solenv/gbuild/AllLangHelp.mk b/solenv/gbuild/AllLangHelp.mk
index c4a0865992d9..7edaf7d68407 100644
--- a/solenv/gbuild/AllLangHelp.mk
+++ b/solenv/gbuild/AllLangHelp.mk
@@ -18,6 +18,12 @@ gb_AllLangHelp_AUXDIR := 
$(gb_AllLangHelp_HELPDIR)/$(gb_AllLangHelp_AUXDIRNAME)
 
 gb_AllLangHelp__get_helpname = $(1)/$(2)
 
+ifneq ($(ENABLE_HTMLHELP),)
+$(call gb_AllLangHelp_get_helpfiles_target,%): | \
+$(dir $(call gb_AllLangHelp_get_helpfiles_target,%)).dir
+   touch $@
+endif
+
 $(dir $(call gb_AllLangHelp_get_target,%)).dir :
$(if $(wildcard $(dir $@)),,mkdir -p $(dir $@))
 
@@ -93,12 +99,6 @@ endif
 
 endef
 
-ifneq ($(ENABLE_HTMLHELP),)
-$(call gb_AllLangHelp_get_helpfiles_target,%): | \
-$(dir $(call gb_AllLangHelp_get_helpfiles_target,%)).dir
-   touch $@
-endif
-
 # Add additional localized file(s) to the help pack.
 #
 # gb_AllLangHelp_add_localized_files module basedir file(s)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118540] LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Mike  changed:

   What|Removed |Added

 CC||bugzilla@mkr.email

--- Comment #1 from Mike  ---
Created attachment 143311
  --> https://bugs.documentfoundation.org/attachment.cgi?id=143311=edit
Fiel crashes LO 6.1b2, when Properties are opened in Print Preview Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118540] New: LO6.1b2: DOCX crashes when properties are opened in print preview mode

https://bugs.documentfoundation.org/show_bug.cgi?id=118540

Bug ID: 118540
   Summary: LO6.1b2: DOCX crashes when properties are opened in
print preview mode
   Product: LibreOffice
   Version: 6.1.0.0.beta2+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugzilla@mkr.email

Description:
The attached DOCX contains just the word "Test". It was created with Word 2007.

Opening Properties Menu, while in Print Preview Mode crashes LO 6.1 beta 2 and
6.2 alpha.

It does NOT crash LO 6.0.5! Only 6.1 and later!

Steps to Reproduce:
1. Open attached file
2. Open print preview mode
3. Click on "Properties..."
->

Actual Results:
LO 6.1 beta 2 and LO 6.2 alpha crash

Expected Results:
Properties of document are shown


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Could confirm crash in Safe Mode

Version: 6.1.0.0.beta2+ (x64)
Build ID: 33b7319e2e08812a2f7d3126e4b1ec90875d6165
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:libreoffice-6-1, Time: 2018-07-03_04:13:19
Locale: de-DE (de_DE); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Make clean fails for unpackedTarballs in subpath firebird

2018-07-04 Thread Regina Henschel


Hi all,

if I use /opt/lo/bin/make clean it stops with the error message
"rm: das Entfernen von 
'D:/Build_ODF_layers/core/workdir/UnpackedTarball/firebird/gen/Debug/firebird' 
ist nicht möglich: Directory not empty"
And indeed it has a 0Byte file fb_trace_wj10i8 in 
unpackedTarball/firebird/gen/Debug/firebird.


I can delete the file manually in Windows explorer. But I think it is an 
error. I write here, because I don't find a suitable category in Bugzilla.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

 sc/source/core/data/table1.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 867dec9f720b7f704aef4fd3d560b8015fc776a7
Author: Eike Rathke 
Date:   Wed Jul 4 14:27:38 2018 +0200

Check for HasAttrFlags::Protected instead ATTR_PROTECTION, tdf#68290 
follow-up

ATTR_PROTECTION at ScAttrArray is not sufficient as also
conditional formatting may apply protection to otherwise
unprotected cells. This now actually enables travelling
Enter->Right in the sample document of tdf#68290 to advance to the
next row / first col if at the end of a row for such protected
cells.

This matches what the ScTabView::MoveCursorRel() call then does
via ScTabView::SkipCursorHorizontal() and
ScTabView::SkipCursorVertical() (additionally checking protection
options for selectable cells which should be done in
ScTable::GetNextPos() as well). Actually when getting things
straight the call to MoveCursorRel() may not be needed anymore and
MoveCursorAbs() could be sufficient, but *only* if we can
differentiate between viewshell cursor travel and UNO
gotoNext()/gotoPrevious() calls.

Change-Id: I0fcb0ecd748bbde982b260db4f4696166cfc5e78
Reviewed-on: https://gerrit.libreoffice.org/56947
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 94af1b1100e8b48f755ec66b190d2017aae1dc00)
Reviewed-on: https://gerrit.libreoffice.org/56953

diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index e7faf4d87f10..65b1b288fce7 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -1303,7 +1303,10 @@ bool ScTable::ValidNextPos( SCCOL nCol, SCROW nRow, 
const ScMarkData& rMark,
 if (bMarked && !rMark.IsCellMarked(nCol,nRow))
 return false;
 
-if (bUnprotected && GetAttr(nCol,nRow,ATTR_PROTECTION)->GetProtection())
+/* TODO: for cursor movement *only* this should even take the protection
+ * options (select locked, select unlocked) into account, see
+ * ScTabView::SkipCursorHorizontal() and ScTabView::SkipCursorVertical(). 
*/
+if (bUnprotected && pDocument->HasAttrib(nCol, nRow, nTab, nCol, nRow, 
nTab, HasAttrFlags::Protected))
 return false;
 
 if (bMarked || bUnprotected)//TODO: also in other case ???
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118539] There isn't Recent Characters Toolbar Dropdown Control on toolbar by default

https://bugs.documentfoundation.org/show_bug.cgi?id=118539

Julien Nabet  changed:

   What|Removed |Added

Summary|There isn't Recent  |There isn't Recent
   |Charaters Toolbar Dropdown  |Characters Toolbar Dropdown
   |Control on toolbar by   |Control on toolbar by
   |default |default

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104213] Copy/Insert a row causes Calc to freeze

https://bugs.documentfoundation.org/show_bug.cgi?id=104213

--- Comment #7 from Xavier Van Wijmeersch  ---
tested with original file, works fine.
suggest to upgrade to 6.0.5.2

Version: 5.4.8.0.0+
Build ID: cc68977f1be22ac0f4a15eb37e05ccba13a7a554
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-4, Time:
2018-05-12_11:32:19
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.0.4.2
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118536] Memory for eight blank documents is rather high (480 MB x64) with OpenGL enabled

https://bugs.documentfoundation.org/show_bug.cgi?id=118536

Telesto  changed:

   What|Removed |Added

Version|6.1.0.0.beta2+  |5.2.0.4 release
Summary|Memory usage for a single   |Memory for eight blank
   |blank document is rather|documents is rather high
   |high (280 MB x64)   |(480 MB x64) with OpenGL
   ||enabled

--- Comment #1 from Telesto  ---
Small change. Memory usage for a multiple blank document is rather high
1. Open eight Calc (or Writer) documents with OpenGL enabled

Actual Results:
+/- 396 x64

Expected Results:
+/- 150 MB x64 with default rendering. So something like 200/ 250 MB?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118539] There isn't Recent Charaters Toolbar Dropdown Control on toolbar by default

https://bugs.documentfoundation.org/show_bug.cgi?id=118539

kompilainenn <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||bibisected, bisected

--- Comment #2 from kompilainenn <79045_79...@mail.ru> ---
result of bibicest for Writer:

dc1890909d6d87abc9afff368bfa8a6b68bd7723 is the first bad commit
commit dc1890909d6d87abc9afff368bfa8a6b68bd7723
Author: Norbert Thiebaud 
Date:   Wed Dec 20 17:06:19 2017 -0800

source sha:490287a1b22411f4ac32127c93228e06dad4ff22


https://cgit.freedesktop.org/libreoffice/core/commit/?id=490287a1b22411f4ac32127c93228e06dad4ff22
by Yousuf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/sdi

2018-07-04 Thread Xisco Fauli

 svx/sdi/svx.sdi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0c3f7154f4d2919f7d28a5db9578fc308f2c0d02
Author: Xisco Fauli 
Date:   Tue Jul 3 16:34:49 2018 +0200

tdf#118506: Disable orientation page in read only

Change-Id: I30994b95e65ddd70df7872f5cc41c339bf906f19
Reviewed-on: https://gerrit.libreoffice.org/56875
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index b42f0c2e7c11..5fcf5d7585b4 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -6214,7 +6214,7 @@ SvxPageItem Orientation SID_ATTR_PAGE_ORIENTATION
 [
 AutoUpdate = FALSE,
 FastCall = FALSE,
-ReadOnlyDoc = TRUE,
+ReadOnlyDoc = FALSE,
 Toggle = FALSE,
 Container = FALSE,
 RecordAbsolute = FALSE,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118369] Needs ellipsis: "Insert Image" button text on Properties sidebar

https://bugs.documentfoundation.org/show_bug.cgi?id=118369

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from Heiko Tietze  ---
(In reply to Explorer09 from comment #0)
> 4. Similar button can be seen on Master Slide View, Properties sidebar ->
> "Master Slide" section -> "Background" -> "Insert Image" button.

(In reply to Julien Nabet from comment #5)
> When trying 4., I click on "Master Slides" button on Sidebar but then I got
> 3 sections:

The mentioned button should be the same on master. With Abhyudaya's patch it
should have ellipsis now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118539] There isn't Recent Charaters Toolbar Dropdown Control on toolbar by default

https://bugs.documentfoundation.org/show_bug.cgi?id=118539

--- Comment #1 from kompilainenn <79045_79...@mail.ru> ---
Version: 6.1.0.0.beta2+ (x64)
Build ID: 33b7319e2e08812a2f7d3126e4b1ec90875d6165
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:libreoffice-6-1, Time: 2018-07-03_04:13:19
Locale: ru-RU (ru_RU); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118539] New: There isn't Recent Charaters Toolbar Dropdown Control on toolbar by default

https://bugs.documentfoundation.org/show_bug.cgi?id=118539

Bug ID: 118539
   Summary: There isn't Recent Charaters Toolbar Dropdown Control
on toolbar by default
   Product: LibreOffice
   Version: 6.1.0.0.beta2+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
There isn't Recent Charaters Toolbar Dropdown Control on toolbar (that was made
by Akshay Deep 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=800ac37021e3f8859a52c5eebca261a5d3bc5a11)
by default in Writer and in Calc.
Instead it  there is old icon Insert Special Character on toolbar.
IMHO it is regression

Steps to Reproduce:
1. Start Writer or Calc with clean user profile
2. Look at toolbar and old icon instead new Recent Charaters Toolbar Dropdown
Control
3.

Actual Results:
there is old icon Insert Special Character on toolbar

Expected Results:
There is Recent Charaters Toolbar Dropdown Control on toolbar by default


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118539] There isn't Recent Charaters Toolbar Dropdown Control on toolbar by default

https://bugs.documentfoundation.org/show_bug.cgi?id=118539

kompilainenn <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||akshaydeepi...@gmail.com,
   ||tietze.he...@gmail.com
   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

2018-07-04 Thread andreas kainz

 sw/uiconfig/swriter/ui/notebookbar.ui|  667 +-
 sw/uiconfig/swriter/ui/notebookbar_compact.ui|  123 
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui | 4525 ---
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui|  569 +
 4 files changed, 3862 insertions(+), 2022 deletions(-)

New commits:
commit e15ef2649d6aa15452a4be1f9e841ea8b349e908
Author: andreas kainz 
Date:   Wed Jul 4 17:04:09 2018 +0200

NB writer: add printpreview to all NB implementations

Change-Id: I763811ba4f0a5a9096be0b5d7f139a3acdb0086a
Reviewed-on: https://gerrit.libreoffice.org/56955
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar.ui 
b/sw/uiconfig/swriter/ui/notebookbar.ui
index f7fd0a5b5d99..a2a609ef8bf5 100644
--- a/sw/uiconfig/swriter/ui/notebookbar.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar.ui
@@ -1098,6 +1098,92 @@
   
 
   
+  
+True
+False
+
+  
+True
+False
+.uno:ShowSinglePage
+  
+
+
+  
+True
+False
+.uno:ShowTwoPages
+  
+
+
+  
+True
+False
+.uno:ShowBookview
+  
+
+
+  
+True
+False
+.uno:ShowMultiplePages
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:GoToStartOfDoc
+  
+
+
+  
+True
+False
+.uno:PageUp
+  
+
+
+  
+True
+False
+.uno:PageDown
+  
+
+
+  
+True
+False
+.uno:GoToEndOfDoc
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:Print
+  
+
+
+  
+True
+False
+.uno:ClosePreview
+  
+
+  
   
 True
 False
@@ -12249,6 +12335,447 @@
   
 
 
+  
+True
+False
+
+  
+True
+False
+center
+True
+
+  
+True
+False
+center
+True
+
+  
+True
+False
+immediate
+both
+False
+
+  
+True
+False
+.uno:ShowSinglePage
+  
+  
+False
+True
+  
+
+
+  
+True
+False
+.uno:ShowTwoPages
+  
+  
+False
+True
+  
+
+
+  
+True
+False
+.uno:ShowBookview
+  
+  
+False
+True
+  
+
+
+  
+True
+False
+center
+True
+.uno:ShowMultiplePages
+  
+  
+False
+False
+  
+
+  
+  
+False
+False
+0
+  
+
+
+  
+True
+False
+5
+5
+vertical
+  
+  
+False
+True
+5
+3
+  
+
+
+

[Libreoffice-commits] core.git: writerfilter/source

2018-07-04 Thread Jochen Nitschke

 writerfilter/source/rtftok/rtfdocumentimpl.cxx |   12 
 1 file changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 99d2c655012af86941f2cdc46fc555bcc27c8eba
Author: Jochen Nitschke 
Date:   Sat Jun 30 20:34:46 2018 +0200

cppcheck: variableScope

Change-Id: I9a01758812e5611c313a41225ec8e04b86e3bdf3
Reviewed-on: https://gerrit.libreoffice.org/56769
Tested-by: Jenkins
Reviewed-by: Jochen Nitschke 

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 8445b5c9a292..fca227d9a702 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -475,8 +475,6 @@ RTFDocumentImpl::getProperties(RTFSprms& rAttributes, 
RTFSprms const& rSprms, Id
 auto it = m_aStyleTableEntries.find(nStyle);
 if (it != m_aStyleTableEntries.end())
 {
-RTFReferenceProperties& rProps = 
*static_cast(it->second.get());
-
 // cloneAndDeduplicate() wants to know about only a single "style", so
 // let's merge paragraph and character style properties here.
 auto itChar = m_aStyleTableEntries.end();
@@ -490,15 +488,21 @@ RTFDocumentImpl::getProperties(RTFSprms& rAttributes, 
RTFSprms const& rSprms, Id
 RTFSprms aStyleAttributes;
 // Ensure the paragraph style is a flat list.
 if (!nStyleType || nStyleType == 
NS_ooxml::LN_Value_ST_StyleType_paragraph)
+{
+RTFReferenceProperties& rProps
+= *static_cast(it->second.get());
 lcl_copyFlatten(rProps, aStyleAttributes, aStyleSprms);
+}
 
 if (itChar != m_aStyleTableEntries.end())
 {
 // Found active character style, then update 
aStyleSprms/Attributes.
-RTFReferenceProperties& rCharProps
-= *static_cast(itChar->second.get());
 if (!nStyleType || nStyleType == 
NS_ooxml::LN_Value_ST_StyleType_character)
+{
+RTFReferenceProperties& rCharProps
+= 
*static_cast(itChar->second.get());
 lcl_copyFlatten(rCharProps, aStyleAttributes, aStyleSprms);
+}
 }
 
 // Get rid of direct formatting what is already in the style.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 118377] CRASH: Writer crashes inserting a section

https://bugs.documentfoundation.org/show_bug.cgi?id=118377

--- Comment #9 from Armin Le Grand (CIB)  ---
@Miklos: All correct - except me being a specialist for VCL ;-) Todo for
tomorrow...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100856] "More..." menu item in the language menus shows the global preferences dialog instead of a simple dedicated dialog, which is confusing