[Libreoffice-commits] core.git: include/svtools sfx2/source svtools/source

[Libreoffice Gerrit user]

 include/svtools/DocumentToGraphicRenderer.hxx   |1 
 sfx2/source/doc/objserv.cxx |   16 ++---
 svtools/source/filter/DocumentToGraphicRenderer.cxx |   23 
 3 files changed, 27 insertions(+), 13 deletions(-)

New commits:
commit af3e421fdb32f172d40ba4641f24f1356fcb55ce
Author: Muhammet Kara 
AuthorDate: Tue Jan 8 16:58:40 2019 +0300
Commit: Muhammet Kara 
CommitDate: Tue Jan 8 21:07:22 2019 +0100

Add method DocumentToGraphicRenderer::getPageCount()

And use that in sfx2 Redaction code to be independent of
the document/module type

Change-Id: Ic206f7a10a27d8d44566df34a10d009a34adf0a5
Reviewed-on: https://gerrit.libreoffice.org/65971
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/include/svtools/DocumentToGraphicRenderer.hxx 
b/include/svtools/DocumentToGraphicRenderer.hxx
index 5d153a2f5c71..4ce5cb4d41fa 100644
--- a/include/svtools/DocumentToGraphicRenderer.hxx
+++ b/include/svtools/DocumentToGraphicRenderer.hxx
@@ -68,6 +68,7 @@ public:
 ~DocumentToGraphicRenderer();
 
 sal_Int32 getCurrentPage();
+sal_Int32 getPageCount();
 /**
  * Get list of chapter names for a page, current page is set by
  * renderToGraphic().
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index fed50045b256..9fb13a899b1b 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -538,22 +538,12 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 if(!xModel.is())
 return;
 
-uno::Reference 
xTextViewCursorSupplier(
-xModel->getCurrentController(), uno::UNO_QUERY);
-if(!xTextViewCursorSupplier.is())
-return;
-
-uno::Reference 
xCursor(xTextViewCursorSupplier->getViewCursor(),
-  uno::UNO_QUERY);
-if(!xCursor.is())
-return;
-
-xCursor->jumpToLastPage();
-sal_Int16 nPages = xCursor->getPage();
-
 uno::Reference< lang::XComponent > xSourceDoc( xModel );
+
 DocumentToGraphicRenderer aRenderer(xSourceDoc, 
/*bSelectionOnly=*/false);
 
+sal_Int32 nPages = aRenderer.getPageCount();
+
 std::vector< GDIMetaFile > aMetaFiles;
 
 for (sal_Int32 nPage = 1; nPage <= nPages; ++nPage)
diff --git a/svtools/source/filter/DocumentToGraphicRenderer.cxx 
b/svtools/source/filter/DocumentToGraphicRenderer.cxx
index ec4b15966dda..5ea3982d0e00 100644
--- a/svtools/source/filter/DocumentToGraphicRenderer.cxx
+++ b/svtools/source/filter/DocumentToGraphicRenderer.cxx
@@ -253,6 +253,29 @@ sal_Int32 DocumentToGraphicRenderer::getCurrentPage()
 return 1;
 }
 
+sal_Int32 DocumentToGraphicRenderer::getPageCount()
+{
+Reference< awt::XDevice > xDevice(mxToolkit->createScreenCompatibleDevice( 
32, 32 ) );
+
+uno::Any selection( getSelection() );
+
+PropertyValues renderProperties;
+
+renderProperties.realloc( 4 );
+renderProperties[0].Name = "IsPrinter";
+renderProperties[0].Value <<= true;
+renderProperties[1].Name = "RenderDevice";
+renderProperties[1].Value <<= xDevice;
+renderProperties[2].Name = "View";
+renderProperties[2].Value <<= mxController;
+renderProperties[3].Name = "RenderToGraphic";
+renderProperties[3].Value <<= true;
+
+sal_Int32 nPages = mxRenderable->getRendererCount( selection, 
renderProperties );
+
+return nPages;
+}
+
 sal_Int32 DocumentToGraphicRenderer::getCurrentPageWriter()
 {
 Reference 
xTextViewCursorSupplier(mxModel->getCurrentController(), UNO_QUERY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

[Libreoffice Gerrit user]

 sw/qa/extras/ww8export/data/tdf122460_header.odt |binary
 sw/qa/extras/ww8export/ww8export3.cxx|7 +++
 sw/source/filter/ww8/wrtw8sty.cxx|2 +-
 3 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 13ed75dd3f84d38cce8f46792af560a5090ec180
Author: Justin Luth 
AuthorDate: Fri Jan 4 19:28:28 2019 +0300
Commit: Justin Luth 
CommitDate: Tue Jan 8 20:19:25 2019 +0100

tdf#122460 ww8export: always export H/F to first section

Normally the first section is considered a BreakCode == 2,
which guarantees that the headers/footers will attempt
to be written.
In the cases where it isn't, the very first section
definitely needs to include any possible Headers/Footers.

This was already done for DOCX via bug 78606 in LO 5.0.

Both DOCX and RTF seem to ignore this first aSect,
so this change won't affect them.

Change-Id: Ie08eedea9202f0922e0e505a92fe4a66ef6c4a24
Reviewed-on: https://gerrit.libreoffice.org/65859
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ww8export/data/tdf122460_header.odt 
b/sw/qa/extras/ww8export/data/tdf122460_header.odt
new file mode 100644
index ..420121dc9a4d
Binary files /dev/null and b/sw/qa/extras/ww8export/data/tdf122460_header.odt 
differ
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx 
b/sw/qa/extras/ww8export/ww8export3.cxx
index ccf79c83e300..60bf801b25ef 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -54,6 +54,13 @@ DECLARE_WW8EXPORT_TEST(testTdf122429_header, 
"tdf122429_header.doc")
 CPPUNIT_ASSERT(headerIsOn);
 }
 
+DECLARE_WW8EXPORT_TEST(testTdf122460_header, "tdf122460_header.odt")
+{
+uno::Reference pageStyles = 
getStyles("PageStyles");
+uno::Reference pageStyle(pageStyles->getByName("Default 
Style"), uno::UNO_QUERY);
+bool headerIsOn = getProperty(pageStyle, "HeaderIsOn");
+CPPUNIT_ASSERT(headerIsOn);
+}
 
 DECLARE_WW8EXPORT_TEST(testFdo53985, "fdo53985.doc")
 {
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx 
b/sw/source/filter/ww8/wrtw8sty.cxx
index b5ee75531701..af39bf4ef063 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -1012,7 +1012,7 @@ MSWordSections::MSWordSections( MSWordExportBase& rExport 
)
 AppendSection( *static_cast(pI), *pNd, 
pFormat, nRstLnNum );
 }
 else
-AppendSection( rExport.m_pCurrentPageDesc, pFormat, nRstLnNum );
+AppendSection( rExport.m_pCurrentPageDesc, pFormat, nRstLnNum, 
/*bIsFirstParagraph=*/true );
 }
 
 WW8_WrPlcSepx::WW8_WrPlcSepx( MSWordExportBase& rExport )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source vcl/unx

[Libreoffice Gerrit user]

 cui/source/inc/cuitabline.hxx  |1 
 cui/source/tabpages/tpline.cxx |   17 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx   |  323 +++--
 3 files changed, 193 insertions(+), 148 deletions(-)

New commits:
commit 6b4ea2d8ddd681fec98773d7e0bbec9657a1fc08
Author: Caolán McNamara 
AuthorDate: Tue Jan 8 16:48:20 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 8 22:00:37 2019 +0100

tdf#122527 dot symbols in chart menubutton not working

a few problems here

*) each symbol was drawn on top of the previous one instead of clearing it
*) some spurious placeholder text in the menu entry
*) m_nSymbolType not set correctly on activation of a submenu entry
*) under gtk3 adding entries to the submenus didn't inform the
   menubutton of their addition
*) we can drop m_xMenu because set_item_sensitive can be used
   instead, which didn't exist at the initial time of writing

Change-Id: Id339992c4192f3782fddfd56cb3e9b67cfcbe2a2
Reviewed-on: https://gerrit.libreoffice.org/65977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/cuitabline.hxx b/cui/source/inc/cuitabline.hxx
index 639ad645c7ce..284a0e656a55 100644
--- a/cui/source/inc/cuitabline.hxx
+++ b/cui/source/inc/cuitabline.hxx
@@ -148,7 +148,6 @@ private:
 std::unique_ptr m_xMtrEndWidth;
 std::unique_ptr m_xTsbCenterEnd;
 std::unique_ptr m_xCbxSynchronize;
-std::unique_ptr m_xMenu;
 std::unique_ptr m_xGalleryMenu;
 std::unique_ptr m_xSymbolsMenu;
 std::unique_ptr m_xCtlPreview;
diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index c71f5de04910..1fb061467e77 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -108,7 +108,6 @@ SvxLineTabPage::SvxLineTabPage(TabPageParent pParent, const 
SfxItemSet& rInAttrs
 , m_xMtrEndWidth(m_xBuilder->weld_metric_spin_button("MTR_FLD_END_WIDTH", 
FieldUnit::CM))
 , m_xTsbCenterEnd(m_xBuilder->weld_check_button("TSB_CENTER_END"))
 , m_xCbxSynchronize(m_xBuilder->weld_check_button("CBX_SYNCHRONIZE"))
-, m_xMenu(m_xBuilder->weld_menu("menuSELECT"))
 , m_xCtlPreview(new weld::CustomWeld(*m_xBuilder, "CTL_PREVIEW", 
m_aCtlPreview))
 , m_xFLEdgeStyle(m_xBuilder->weld_widget("FL_EDGE_STYLE"))
 , m_xGridEdgeCaps(m_xBuilder->weld_widget("gridEDGE_CAPS"))
@@ -1410,7 +1409,7 @@ IMPL_LINK_NOARG(SvxLineTabPage, MenuCreateHdl_Impl, 
weld::ToggleButton&, void)
 aBitmap.Scale(nScale, nScale);
 
 }
-pVD->SetOutputSizePixel(aBitmap.GetSizePixel(), false);
+pVD->SetOutputSizePixel(aBitmap.GetSizePixel());
 pVD->DrawBitmapEx(Point(), aBitmap);
 m_xGalleryMenu->append(pInfo->sItemId, *pUIName, *pVD);
 }
@@ -1422,7 +1421,7 @@ IMPL_LINK_NOARG(SvxLineTabPage, MenuCreateHdl_Impl, 
weld::ToggleButton&, void)
 }
 
 if (m_aGrfNames.empty())
-m_xMenu->set_sensitive("gallery", false);
+m_xSymbolMB->set_item_sensitive("gallery", false);
 }
 
 if (!m_xSymbolsMenu && m_pSymbolList)
@@ -1494,15 +1493,15 @@ IMPL_LINK_NOARG(SvxLineTabPage, MenuCreateHdl_Impl, 
weld::ToggleButton&, void)
 double(MAX_BMP_HEIGHT) / 
static_cast(aSize.Height());
 aBitmapEx.Scale(nScale, nScale);
 }
-pVD->SetOutputSizePixel(aBitmapEx.GetSizePixel(), false);
+pVD->SetOutputSizePixel(aBitmapEx.GetSizePixel());
 pVD->DrawBitmapEx(Point(), aBitmapEx);
-m_xSymbolsMenu->append(pInfo->sItemId, "foo", *pVD);
+m_xSymbolsMenu->append(pInfo->sItemId, "", *pVD);
 }
 pInvisibleSquare=pPage->RemoveObject(0);
 SdrObject::Free(pInvisibleSquare);
 
 if (m_aGrfNames.empty())
-m_xMenu->set_sensitive("symbols", false);
+m_xSymbolMB->set_item_sensitive("symbols", false);
 }
 }
 }
@@ -1522,10 +1521,12 @@ IMPL_LINK(SvxLineTabPage, GraphicHdl_Impl, const 
OString&, rIdent, void)
 {
 SvxBmpItemInfo* pInfo = m_aGalleryBrushItems[sNumber.toUInt32()].get();
 pGraphic = pInfo->pBrushItem->GetGraphic();
+m_nSymbolType = SVX_SYMBOLTYPE_BRUSHITEM;
 }
 else if (rIdent.startsWith("symbol", ))
 {
-SvxBmpItemInfo* pInfo = m_aSymbolBrushItems[sNumber.toUInt32()].get();
+m_nSymbolType = sNumber.toUInt32();
+SvxBmpItemInfo* pInfo = m_aSymbolBrushItems[m_nSymbolType].get();
 pGraphic = pInfo->pBrushItem->GetGraphic();
 }
 else if (rIdent == "automatic")
@@ -1559,7 +1560,7 @@ IMPL_LINK(SvxLineTabPage, GraphicHdl_Impl, const 
OString&, rIdent, void)
 return;
 }
 
-if(pGraphic)
+if (pGraphic)
 {
 Size aSize = 

[Libreoffice-commits] core.git: Changes to 'libreoffice-libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-libreoffice-6-2-0' available with the following commits:
commit cbf16c681c8f71752aab2753515a07348d353fdc
Author: Christian Lohmaier 
Date:   Tue Jan 8 23:02:11 2019 +0100

Branch libreoffice-libreoffice-6-2-0

This is 'libreoffice-libreoffice-6-2-0' - the stable branch for the 6.2.0 
release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.2.x release,
please use the 'libreoffice-libreoffice-6-2' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Id8be2a61e03b8f14dd41e69f2849b71f5dad31a8

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: writerfilter/source

[Libreoffice Gerrit user]

 writerfilter/source/dmapper/PropertyMap.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 93d3ef817af1e07ff8b6ea2e6636358c1762a62a
Author: Justin Luth 
AuthorDate: Tue Jan 8 18:37:21 2019 +0300
Commit: Justin Luth 
CommitDate: Tue Jan 8 20:19:58 2019 +0100

writerfilter: avoid exception - IsProtect not page style property.

Change-Id: I3e91bc82e5857116f5d94103a7c22ce333e4f89b
Reviewed-on: https://gerrit.libreoffice.org/65976
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 9d236a7ce5c1..91716a64dbe4 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1730,7 +1730,9 @@ void SectionPropertyMap::ApplyProperties_( const 
uno::Reference< beans::XPropert
 
 for ( beans::PropertyValue* pIter = vPropVals.begin(); pIter != 
vPropVals.end(); ++pIter )
 {
-if ( pIter != pCharGrabBag && pIter != pParaGrabBag )
+if ( pIter != pCharGrabBag && pIter != pParaGrabBag
+ && pIter->Name != "IsProtected" //section-only property
+   )
 {
 vNames.push_back( pIter->Name );
 vValues.push_back( pIter->Value );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/src/control/Control.PartsPreview.js |   33 --
 1 file changed, 16 insertions(+), 17 deletions(-)

New commits:
commit 1eb1adc9dacc6e877c75f82ec1c8d1fe71a053b6
Author: Henry Castro 
AuthorDate: Tue Jan 8 11:23:52 2019 -0400
Commit: Henry Castro 
CommitDate: Tue Jan 8 16:47:24 2019 -0400

loleaflet: create only once slide sorter scrollbar

affects performance recreating scrollbar each slide preview

Change-Id: I2e414850b920de69da119dc57310d3960b5a343e

diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index c5b24729c..f21d4811a 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -34,6 +34,7 @@ L.Control.PartsPreview = L.Control.extend({
if (!this._previewInitialized)
{
// make room for the preview
+   var control = this;
var docContainer = 
this._map.options.documentContainer;
L.DomUtil.addClass(docContainer, 
'parts-preview-document');
setTimeout(L.bind(function () {
@@ -43,6 +44,20 @@ L.Control.PartsPreview = L.Control.extend({
var previewContBB = 
this._partsPreviewCont.getBoundingClientRect();
this._previewContTop = previewContBB.top;
var bottomBound = previewContBB.bottom + 
previewContBB.height / 2;
+
+   $('#slide-sorter').mCustomScrollbar({
+   axis: 'y',
+   theme: 'dark-thick',
+   scrollInertia: 0,
+   alwaysShowScrollbar: 1,
+   callbacks:{
+   whileScrolling: function() {
+   control._onScroll(this);
+   }
+   }
+   });
+   this._scrollContainer = $('#slide-sorter 
.mCSB_container').get(0);
+
for (var i = 0; i < parts; i++) {

this._previewTiles.push(this._createPreview(i, e.partNames[i], bottomBound));
}
@@ -65,7 +80,7 @@ L.Control.PartsPreview = L.Control.extend({
},
 
_createPreview: function (i, hashCode, bottomBound) {
-   var frame = L.DomUtil.create('div', 'preview-frame', 
this._partsPreviewCont);
+   var frame = L.DomUtil.create('div', 'preview-frame', 
this._scrollContainer);
L.DomUtil.create('span', 'preview-helper', frame);
 
var imgClassName = 'preview-img';
@@ -187,22 +202,6 @@ L.Control.PartsPreview = L.Control.extend({
 
_updatePreview: function (e) {
if (this._map.getDocType() === 'presentation' || 
this._map.getDocType() === 'drawing') {
-   // the scrollbar has to be re-initialized here else it 
doesn't work
-   // probably a bug from the scrollbar
-   var control = this;
-   this._previewTiles[e.id].onload = function () {
-   $('#slide-sorter').mCustomScrollbar({
-   axis: 'y',
-   theme: 'dark-thick',
-   scrollInertia: 0,
-   alwaysShowScrollbar: 1,
-   callbacks:{
-   whileScrolling: function() {
-   control._onScroll(this);
-   }
-   }
-   });
-   };
this._previewTiles[e.id].src = e.tile;
}
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-libreoffice-6-2-0' available with the following commits:
commit d816c5a5c8e95258445b3f30d374523e1c3c134a
Author: Christian Lohmaier 
Date:   Tue Jan 8 23:01:58 2019 +0100

Branch libreoffice-libreoffice-6-2-0

This is 'libreoffice-libreoffice-6-2-0' - the stable branch for the 6.2.0 
release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.2.x release,
please use the 'libreoffice-libreoffice-6-2' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I145a1e06338e011ec191bae76513491f30ff82ef

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'libreoffice-libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-libreoffice-6-2-0' available with the following commits:
commit cc840bda10221ff800def3d29a45dbac4848c51f
Author: Christian Lohmaier 
Date:   Tue Jan 8 23:01:59 2019 +0100

Branch libreoffice-libreoffice-6-2-0

This is 'libreoffice-libreoffice-6-2-0' - the stable branch for the 6.2.0 
release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.2.x release,
please use the 'libreoffice-libreoffice-6-2' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Ib993a60a5ed48ed3d143cc69002f65b9dd434109

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'libreoffice-libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-libreoffice-6-2-0' available with the following commits:
commit 276bbfbf7b55acdb833aad8118ea34abcec9f944
Author: Christian Lohmaier 
Date:   Tue Jan 8 23:01:59 2019 +0100

Branch libreoffice-libreoffice-6-2-0

This is 'libreoffice-libreoffice-6-2-0' - the stable branch for the 6.2.0 
release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.2.x release,
please use the 'libreoffice-libreoffice-6-2' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I974e0ba8551de29856b015978bf9b2bdb7c61cb8

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - configure.ac

[Libreoffice Gerrit user]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 47390e2ddf4a00b1d2c957e8b9b0b2ec923929df
Author: Christian Lohmaier 
AuthorDate: Tue Jan 8 23:12:06 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 23:12:06 2019 +0100

bump product version to 6.2.1.0.0+

Change-Id: Ia770c121cc64c748964e6d6dbedd8742c2cf79f9

diff --git a/configure.ac b/configure.ac
index c9a12c07ecd4..ec46de16a857 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.2.0.1.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.2.1.0.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/js

[Libreoffice Gerrit user]

 loleaflet/js/toolbar.js |   11 ++-
 1 file changed, 2 insertions(+), 9 deletions(-)

New commits:
commit 6435ef289586f8c539520a275e2f92914cce0c39
Author: Henry Castro 
AuthorDate: Tue Jan 8 16:16:41 2019 -0400
Commit: Henry Castro 
CommitDate: Tue Jan 8 16:51:31 2019 -0400

loleaflet: simplify code to show next and prev tool items

Change-Id: Id6a3f8862b9b4539fa2c47f4c91d0f0f781b1089

diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index acf248928..8909f13e5 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -851,14 +851,7 @@ function initMobileToolbar(toolItems) {
onClick(e, e.target);
hideTooltip(this, e.target);
},
-   onRefresh: function(e) {
-   var docType = map.getDocType();
-   if (docType === 'presentation' && (e.target === 'prev' 
|| e.target === 'next')) {
-   if (this.get(e.target).hidden === true) {
-   this.show(e.target);
-   }
-   }
-
+   onRefresh: function() {
var showUserList = map['wopi'].HideUserList !== null &&

map['wopi'].HideUserList !== undefined &&

$.inArray('true', map['wopi'].HideUserList) < 0 &&
@@ -1696,11 +1689,11 @@ function onDocLayerInit() {
]);
}
 
-   break;
// FALLTHROUGH intended
case 'drawing':
toolbarUp.show('leftpara', 'centerpara', 'rightpara', 
'justifypara', 'breakpara', 'linespacing',
'breakspacing', 'defaultbullet', 'defaultnumbering', 
'breakbullet', 'inserttable');
+   statusbar.show('prev', 'next');
 
$('#presentation-toolbar').show();
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - translations

[Libreoffice Gerrit user]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b468430ab0c7b9aca13aa1f063ad151250885d38
Author: Christian Lohmaier 
AuthorDate: Tue Jan 8 22:27:36 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Jan 8 22:45:06 2019 +0100

Update git submodules

* Update translations from branch 'libreoffice-6-2'
  - update translations for 6.2.0 rc2

and force-fix errors using pocheck

Change-Id: I295803099da158e7266eb8e7836528d2bd0b8cdd

diff --git a/translations b/translations
index a07d2a278260..c1299cddf602 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit a07d2a278260311d531fe47e2176eb6c261ed033
+Subproject commit c1299cddf602f746c2bf47435fbce62a02b1b3e0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/js

[Libreoffice Gerrit user]

 loleaflet/js/toolbar.js |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 36e6396f62833b97e8136be83ac29508864c0438
Author: Henry Castro 
AuthorDate: Fri Jan 4 13:02:26 2019 -0400
Commit: Henry Castro 
CommitDate: Tue Jan 8 16:23:59 2019 -0400

loleaflet: avoid fire timer event for each toolbar item

onRefresh is called for each item, so calling show will
queue timer event O(n)

Change-Id: Ice9f4d0a515f6bf56471a8eb1d07e40638a7e020

diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 7517de31c..acf248928 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -851,11 +851,12 @@ function initMobileToolbar(toolItems) {
onClick(e, e.target);
hideTooltip(this, e.target);
},
-   onRefresh: function() {
+   onRefresh: function(e) {
var docType = map.getDocType();
-   if (docType === 'presentation') {
-   this.show('prev');
-   this.show('next');
+   if (docType === 'presentation' && (e.target === 'prev' 
|| e.target === 'next')) {
+   if (this.get(e.target).hidden === true) {
+   this.show(e.target);
+   }
}
 
var showUserList = map['wopi'].HideUserList !== null &&
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Libreoffice Gerrit user]

 sfx2/source/doc/objserv.cxx |   19 ++-
 1 file changed, 14 insertions(+), 5 deletions(-)

New commits:
commit 79358a7588e1d5f02b8f9bf1ba9feb316af7f2a5
Author: Caolán McNamara 
AuthorDate: Tue Jan 8 17:11:50 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 8 22:00:21 2019 +0100

Resolves: tdf#122308 ensure parent for message dialog

Change-Id: Ie7e97d3beedfa007243e4a6b7408341857f2d903
Reviewed-on: https://gerrit.libreoffice.org/65979
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index 9fb13a899b1b..ff6755257000 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -404,13 +404,22 @@ uno::Sequence< document::CmisVersion > 
SfxObjectShell::GetCmisVersions( )
 
 void SfxObjectShell::ExecFile_Impl(SfxRequest )
 {
+weld::Window* pDialogParent = rReq.GetFrameWeld();
+if (!pDialogParent)
+{
+SfxViewFrame* pFrame = GetFrame();
+if (!pFrame)
+pFrame = SfxViewFrame::GetFirst(this);
+if (pFrame)
+pDialogParent = pFrame->GetWindow().GetFrameWeld();
+}
 
 sal_uInt16 nId = rReq.GetSlot();
 
 if( SID_SIGNATURE == nId || SID_MACRO_SIGNATURE == nId )
 {
 if ( QueryHiddenInformation( HiddenWarningFact::WhenSigning, nullptr ) 
== RET_YES )
-( SID_SIGNATURE == nId ) ? 
SignDocumentContent(rReq.GetFrameWeld()) : 
SignScriptingContent(rReq.GetFrameWeld());
+( SID_SIGNATURE == nId ) ? SignDocumentContent(pDialogParent) : 
SignScriptingContent(pDialogParent);
 return;
 }
 
@@ -437,7 +446,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 if ( !IsOwnStorageFormat( *GetMedium() ) )
 return;
 
-SfxVersionDialog aDlg(rReq.GetFrameWeld(), pFrame, 
IsSaveVersionOnClose());
+SfxVersionDialog aDlg(pDialogParent, pFrame, 
IsSaveVersionOnClose());
 aDlg.run();
 SetSaveVersionOnClose(aDlg.IsSaveVersionOnClose());
 rReq.Done();
@@ -802,7 +811,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 if ( lErr != ERRCODE_IO_ABORT )
 {
 SfxErrorContext aEc(ERRCTX_SFX_SAVEASDOC,GetTitle());
-ErrorHandler::HandleError(lErr, rReq.GetFrameWeld());
+ErrorHandler::HandleError(lErr, pDialogParent);
 }
 
 if ( nId == SID_EXPORTDOCASPDF )
@@ -891,7 +900,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 
 SetModified( false );
 ErrCode lErr = GetErrorCode();
-ErrorHandler::HandleError(lErr, rReq.GetFrameWeld());
+ErrorHandler::HandleError(lErr, pDialogParent);
 
 rReq.SetReturnValue( SfxBoolItem(0, true) );
 rReq.Done();
@@ -904,7 +913,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 case SID_DOCTEMPLATE:
 {
 // save as document templates
-SfxSaveAsTemplateDialog aDlg(rReq.GetFrameWeld(), GetModel());
+SfxSaveAsTemplateDialog aDlg(pDialogParent, GetModel());
 (void)aDlg.run();
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - configure.ac

[Libreoffice Gerrit user]

 configure.ac |   29 +
 1 file changed, 21 insertions(+), 8 deletions(-)

New commits:
commit a9e05d48a0a4e00acd49a7e06375e227f11ae26e
Author: Samuel Mehrbrodt 
AuthorDate: Mon Jan 7 11:21:44 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 22:54:25 2019 +0100

Disable removal of GPG socketdir with older gpgconf versions

Change-Id: Id068f1c1b70c3db3d3a0faa5ebe7706f205fe4da
Reviewed-on: https://gerrit.libreoffice.org/65932
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit 32b85ec64e5c901369ce3ce5dbda0e96f2ec7fc0)
Reviewed-on: https://gerrit.libreoffice.org/65983
Reviewed-by: Christian Lohmaier 

diff --git a/configure.ac b/configure.ac
index 38b7709fbe1a..c9a12c07ecd4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10602,17 +10602,30 @@ elif test "$_os" = "Linux" -o "$_os" = "Darwin" -o 
"$_os" = "WINNT" ; then
   if test -d /run/user/$uid; then
 AC_MSG_RESULT([yes])
 AC_PATH_PROG(GPGCONF, gpgconf)
-AC_MSG_CHECKING([for gpgconf --create-socketdir... ])
-if $GPGCONF --dump-options > /dev/null ; then
-  if $GPGCONF --dump-options | grep -q create-socketdir ; then
-   AC_MSG_RESULT([yes])
-AC_DEFINE([HAVE_GPGCONF_SOCKETDIR])
-AC_DEFINE_UNQUOTED([GPGME_GPGCONF], ["$GPGCONF"])
+
+# Older versions of gpgconf are not working as expected, since
+# `gpgconf --remove-socketdir` fails to exit any gpg-agent daemon 
operating
+# on that socket dir that has (indirectly) been started by the tests 
in xmlsecurity/qa/unit/signing/signing.cxx
+# (see commit message of f0305ec0a7d199e605511844d9d6af98b66d4bfd%5E )
+AC_MSG_CHECKING([whether version of gpgconf is suitable ... ])
+GPGCONF_VERSION=`"$GPGCONF" --version | "$AWK" '/^gpgconf 
\(GnuPG\)/{print $3}'`
+GPGCONF_NUMVER=`echo $GPGCONF_VERSION | $AWK -F. '{ print 
\$1*1+\$2*100+\$3 }'`
+if test "$GPGCONF_VERSION" = "2.2_OOo" -o "$GPGCONF_NUMVER" -ge 
"020200"; then
+  AC_MSG_RESULT([yes, $GPGCONF_VERSION])
+  AC_MSG_CHECKING([for gpgconf --create-socketdir... ])
+  if $GPGCONF --dump-options > /dev/null ; then
+if $GPGCONF --dump-options | grep -q create-socketdir ; then
+  AC_MSG_RESULT([yes])
+  AC_DEFINE([HAVE_GPGCONF_SOCKETDIR])
+  AC_DEFINE_UNQUOTED([GPGME_GPGCONF], ["$GPGCONF"])
+else
+  AC_MSG_RESULT([no])
+fi
   else
-AC_MSG_RESULT([no])
+AC_MSG_RESULT([no. missing or broken gpgconf?])
   fi
 else
- AC_MSG_RESULT([no. missing or broken gpgconf?])
+  AC_MSG_RESULT([no, $GPGCONF_VERSION])
 fi
   else
 AC_MSG_RESULT([no])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - 2 commits - sw/qa sw/source

[Libreoffice Gerrit user]

 sw/qa/extras/ww8export/data/tdf122429_header.doc |binary
 sw/qa/extras/ww8export/ww8export3.cxx|9 +
 sw/source/filter/ww8/wrtw8sty.cxx|2 +-
 sw/source/uibase/wrtsh/wrtundo.cxx   |3 ++-
 4 files changed, 12 insertions(+), 2 deletions(-)

New commits:
commit 6b2f6e5062ee4320ab952fd11684c389432bb568
Author: Caolán McNamara 
AuthorDate: Tue Jan 8 13:46:53 2019 +
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 22:54:17 2019 +0100

Resolves: tdf#121940 mnemonic ends up in tooltip text

Change-Id: Ic698f23e71dbc613db2acf884fdefdeab06fde0f
Reviewed-on: https://gerrit.libreoffice.org/65969
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/sw/source/uibase/wrtsh/wrtundo.cxx 
b/sw/source/uibase/wrtsh/wrtundo.cxx
index 2cc9e54ba232..ee9c315c96f0 100644
--- a/sw/source/uibase/wrtsh/wrtundo.cxx
+++ b/sw/source/uibase/wrtsh/wrtundo.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // Undo ends all modes. If a selection is emerged by the Undo,
 // this must be considered for further action.
@@ -108,7 +109,7 @@ OUString SwWrtShell::GetDoString( DoType eDoType ) const
 default:;//prevent warning
 }
 
-return SvtResId(pResStr) + aUndoStr;
+return MnemonicGenerator::EraseAllMnemonicChars(SvtResId(pResStr)) + 
aUndoStr;
 }
 
 void SwWrtShell::GetDoStrings( DoType eDoType, SfxStringListItem& rStrs ) const
commit 73c7b0414679c002cd925ead8018837dd39eaf86
Author: Justin Luth 
AuthorDate: Thu Jan 3 20:23:54 2019 +0300
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 22:54:09 2019 +0100

tdf#122429/tdf#122431 ww8export: export H/F to default section

Just like bug 121374 for DOCX, which was just fixed in LO62,
DOC apparently also sometimes can miss out on headers and footers.

It wouldn't be terrible to duplicate headers/footers
unnecessarily, but it is terrible to have them disappear.
If the last SectPr has no idea about the section start,
it can't know whether it is continuous or started with
a page break. In that case, just ensure that the
header and footer are explicitly written out.

RTF continues to work without this in all known cases.

Change-Id: I93f2b08535a3548c0a9e9bcdb6ee2cd965dc8367
Reviewed-on: https://gerrit.libreoffice.org/65840
Tested-by: Jenkins
Reviewed-by: Justin Luth 
(cherry picked from commit 0a6c609bdc89dd0317d3f5013c13d85d50d30669)
Reviewed-on: https://gerrit.libreoffice.org/65943
Reviewed-by: Xisco Faulí 
Tested-by: Xisco Faulí 
Reviewed-by: Christian Lohmaier 

diff --git a/sw/qa/extras/ww8export/data/tdf122429_header.doc 
b/sw/qa/extras/ww8export/data/tdf122429_header.doc
new file mode 100644
index ..37afc067b02a
Binary files /dev/null and b/sw/qa/extras/ww8export/data/tdf122429_header.doc 
differ
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx 
b/sw/qa/extras/ww8export/ww8export3.cxx
index e85ec0efa18f..ccf79c83e300 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -46,6 +46,15 @@ DECLARE_WW8EXPORT_TEST(testTdf37778_readonlySection, 
"tdf37778_readonlySection.d
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Number of Sections", sal_Int32(0), 
xSections->getCount());
 }
 
+DECLARE_WW8EXPORT_TEST(testTdf122429_header, "tdf122429_header.doc")
+{
+uno::Reference pageStyles = 
getStyles("PageStyles");
+uno::Reference pageStyle(pageStyles->getByName("Default 
Style"), uno::UNO_QUERY);
+bool headerIsOn = getProperty(pageStyle, "HeaderIsOn");
+CPPUNIT_ASSERT(headerIsOn);
+}
+
+
 DECLARE_WW8EXPORT_TEST(testFdo53985, "fdo53985.doc")
 {
 uno::Reference xTablesSupplier(mxComponent, 
uno::UNO_QUERY);
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx 
b/sw/source/filter/ww8/wrtw8sty.cxx
index 286a613e8e62..b5ee75531701 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -1555,7 +1555,7 @@ void MSWordExportBase::SectionProperties( const 
WW8_SepInfo& rSepInfo, WW8_PdAtt
 }
 
 if ( reinterpret_cast(sal_IntPtr(-1)) == 
rSepInfo.pSectionFormat )
-bEnsureHeaderFooterWritten |= !rSepInfo.pPDNd && GetExportFormat() 
== ExportFormat::DOCX;
+bEnsureHeaderFooterWritten |= !rSepInfo.pPDNd && GetExportFormat() 
!= ExportFormat::RTF;
 else
 {
 if ( nBreakCode == 0 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-6-2-0' available with the following commits:
commit cbf16c681c8f71752aab2753515a07348d353fdc
Author: Christian Lohmaier 
Date:   Tue Jan 8 23:02:11 2019 +0100

Branch libreoffice-libreoffice-6-2-0

This is 'libreoffice-libreoffice-6-2-0' - the stable branch for the 6.2.0 
release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.2.x release,
please use the 'libreoffice-libreoffice-6-2' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Id8be2a61e03b8f14dd41e69f2849b71f5dad31a8

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - RepositoryFixes.mk

[Libreoffice Gerrit user]

 RepositoryFixes.mk |4 
 1 file changed, 4 deletions(-)

New commits:
commit e740db63c438be0e387b9f5a1d0fd6d81afb825e
Author: Jim Jagielski 
AuthorDate: Tue Jan 8 20:39:48 2019 +
Commit: Jim Jagielski 
CommitDate: Tue Jan 8 20:39:48 2019 +

Bring somewhat up to date... remove reference to 10.4 and allow for newer 
SDKs for 4.20.x

diff --git a/RepositoryFixes.mk b/RepositoryFixes.mk
index 8bbed45f8ab7..770076337604 100644
--- a/RepositoryFixes.mk
+++ b/RepositoryFixes.mk
@@ -75,11 +75,7 @@ gb_Library_FILENAMES := $(patsubst 
store:libuno_store%,store:libstore%,$(gb_Libr
 gb_Library_FILENAMES := $(patsubst 
sunjavaplugin:libsunjavaplugin%,sunjavaplugin:sunjavaplugin%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
jurt:libjpipe.dylib%,jurt:libjpipe.jnilib%,$(gb_Library_FILENAMES))
 
-ifneq ($(MACOSX_DEPLOYMENT_TARGET),10.4) # default to use libc++
 gb_Library_FILENAMES := $(patsubst 
stl:%,stl:libc++.dylib,$(gb_Library_FILENAMES))
-else # use libstdc++ instead on ancient MacOSX targets
-gb_Library_FILENAMES := $(patsubst 
stl:%,stl:libstdc++.dylib,$(gb_Library_FILENAMES))
-endif
 gb_Library_TARGETS := $(filter-out stl,$(gb_Library_TARGETS))
 
 endif # ifeq ($(OS),MACOSX)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-0' - configure.ac

[Libreoffice Gerrit user]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c3d38f3f0b54db8522c01f01299c48f1cf39efb2
Author: Christian Lohmaier 
AuthorDate: Tue Jan 8 23:32:03 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 23:32:03 2019 +0100

bump product version to 6.2.0.2.0+

Change-Id: I596e6cf1beaf17a801e65f832b67c7067c17495e

diff --git a/configure.ac b/configure.ac
index c9a12c07ecd4..163f17297424 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.2.0.1.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.2.0.2.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.2.0.2'

[Libreoffice Gerrit user]

Tag 'libreoffice-6.2.0.2' created by Christian Lohmaier 
 at 2019-01-08 22:28 +

Tag libreoffice-6.2.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw1JCcACgkQ9DSh76/u
rqNRvxAAiGypOhGUrSCMPjUNeTKpeO8nUGBSYyltWF96EOx/8o/4XJHcjFPgw93j
LxGIuI+C0WjQRpSbtce33Z0lV56WatX/jbCZtTw14mK7OucKw2+uGzzl1VnbFCsO
0lW529yq9Gyo7N1qQ5dCb5V2pj2QzYx5dlxTcL5vNeaBJCi7nFhnH9tNC506dP+o
cV3N5VFLRUZwjerqgUol/e5fQUqEIJc9Qd3LkchWbiXJ6/e0eWDesZZarJvD1ZGG
P/7FJfHKRhJHxRIcRsdBhqqoXpA4q+/rtN3r7e1Aj0k/oDK2ODoqBy6W0K5XbYxo
wadP7FEFYlOf5hjHR/R29k1uouqIAf5VK3+00Ilgl8arAnrzXH5gllBWtq/IKCjk
mwepL7lqniI54T4LnMctGWJ+M6joPAljKxPZzLT/apFiO0k4Z9z3VRszKszDnQ40
fvAcudezp9pF3tCMhhuqHn22peslhedGkaF7kap0g1Hsvy+zIlGLj/33BbKfbjzP
GGRiVMS9Qjvpl4N6XY3jCFlIkyOwoFlSzgPEgWz5EsFtiKgDYNiKHCsahw6PT/nV
AhEi7q5CbpJ2KUTd8NOtXk8tU5S6VqESbFuxGG9T7N7RpfyujkFuCdd/76V642QO
yp3rWR/fSVkEQrdmHrpRzM5NI7oBLH8o6MJUVCefYb1PL+iRP1s=
=ySyd
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-5:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/js

[Libreoffice Gerrit user]

 loleaflet/js/toolbar.js |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 9d8e2cf16f81b8c7ac44b6477c48220e53a7feb1
Author: Henry Castro 
AuthorDate: Fri Jan 4 11:44:32 2019 -0400
Commit: Henry Castro 
CommitDate: Tue Jan 8 16:22:42 2019 -0400

loleaflet: add a missing break statement

Change-Id: I950de5a697d5d538ab17737e3dccf3888966c5e1

diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 1c2f266f8..7517de31c 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -1694,6 +1694,8 @@ function onDocLayerInit() {
{type: 'break', id: 'break8', mobile: false}
]);
}
+
+   break;
// FALLTHROUGH intended
case 'drawing':
toolbarUp.show('leftpara', 'centerpara', 'rightpara', 
'justifypara', 'breakpara', 'linespacing',
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Branch 'libreoffice-libreoffice-6-2-0' - 0 commits -

[Libreoffice Gerrit user]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Branch 'libreoffice-libreoffice-6-2-0' - 0 commits -

[Libreoffice Gerrit user]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-6-2-0' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-6-2-0' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-libreoffice-6-2-0' - 0 commits -

[Libreoffice Gerrit user]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-libreoffice-6-2-0' - 0 commits -

[Libreoffice Gerrit user]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-2-0'

[Libreoffice Gerrit user]

New branch 'libreoffice-6-2-0' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.2.0.2'

[Libreoffice Gerrit user]

Tag 'libreoffice-6.2.0.2' created by Christian Lohmaier 
 at 2019-01-08 22:29 +

Tag libreoffice-6.2.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw1JC4ACgkQ9DSh76/u
rqOt3A//csLhpyd8CtPy+TFlgDDugmYrgzXMleA1iVS66RMswkDWcFHpjrhGeKIF
7j7UDv5+PV3NOU9LTFPn2wkl7ynUkJNSKDfMEt8Wk0a8hCwPYVcu3tvHDqS6UhO8
yDR1jQo4hV87Y3zjXVJJ9Iqu6uKem2Lpsz5guSKmz6+DPGzz3v49jZA2j2d5TyoN
WGl579yYKOkLm6CQlCbqsnA4r3eBdHj+jvil/DeVL4kyNKGfzDnqt/IccQVrGoNO
jbjlS5gKYcYRls+Q3hXpvx+S8Gt8rQGfjBMSjmndByxve/a2+q8dQTpbexTu2wnF
4mdcVJquPL76JIpbGh6VaBapTlm5a2cSFSuNHnaiSTcMmGlMI9ywClDdLXwxzKym
Tj1WeVLPtqWRbFAb6gQNqt0U48lcBa0UMhY8bWWBsDRSoJ+AWQMtEgJ/U8HAhvOS
o25DtSkAlrLbGaZz3+C+9gasNjRBCehYjEagXJ3wqkTIP8VJcAUEPCBUZXmR/8kO
HPuFUPz8qCS0LZ3whYeJHrOLG1nzRw1PdUBXZ7rL0lQhhopcxYlo1mWJabxlieJc
68zjH+wFTC6G0F3mlS+y8IdKMZTTsJhWIpK8FLCtl4BRDEmMZZzgX/1FLMY5IRfl
/6vgGu6zLt1N3fwNg77wEX+18/YmOJpFlKzLUAFN8mCdeo8vHZU=
=yM+3
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-35:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.2.0.2'

[Libreoffice Gerrit user]

Tag 'libreoffice-6.2.0.2' created by Christian Lohmaier 
 at 2019-01-08 22:29 +

Tag libreoffice-6.2.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw1JC8ACgkQ9DSh76/u
rqPjvxAAiie1gODr7HSGCs2+Hl1rSSX3w+k118Fs+sepRfXYBYz8X7Cyso6n4DbO
iWgXp1lh0gdDuR8FEIomVdPqSa3o/2nqeMJNNN7wAhQ2f8bUGZhbOn6r2cJnsnkf
DIb06UaSTZoz2IXW08KZyFAzQaHlwxvLAyZhtFPTrC9S9JB9TUf0emwiNT5deOPk
ualSTPb0qgUdnZaHJUEVkc8KQXBTxOFmE/dQw0JHnD0HqXwBi5TS8zuCaa22OlJu
yNF2OJs6ZBkc5iQQ6vb+OTSb/4FSpIroortmW+gk/sjRPgqP7woYfDz/ncjb/umj
lLttgCU4ukz9sFojSf+Ls/HhyoOkSF/noWbUcGS4X6GNKRjtRliv2/jVcl1QpW5O
aICvIc6ctzbQeUvIqn0y5kiUUnu9o4G0bVHboNs3+YDJVmvLc9xSVnHAx5oJiNtr
DbPht6kaHTCyyz4lSVhdBoh1tXWzLsM5ApNZyPgVXcfWkCF/4hjAup4cq8U7Mt76
30pwOykokIaR8IQvAR1204GWcfeVlUC8T2XJJdOEozK48/SmaU68g1HsRG2dD1+x
SMoMM94WBdFA9L2dsuL0FGPnPq9D/06KOvqJo22S9Ay1jt+YxWFn6Mo+9bFclDLM
xiw3J3Tam3jROdYTz1jKd37dyPU0FCTJnGJJIZftUX1zG8jcReE=
=iirV
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-863:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.2.0.2'

[Libreoffice Gerrit user]

Tag 'libreoffice-6.2.0.2' created by Christian Lohmaier 
 at 2019-01-08 22:29 +

Tag libreoffice-6.2.0.2
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw1JC8ACgkQ9DSh76/u
rqMMiw/+IHvRtrk9jB4TolaJBCLGNzV6UTXOR5aP4IGFqAKhkNAWFRhHpaRNl2LW
NkZ0Q24Sba8GpQVtCfArdzBAbLujcWSG5DzBgyScLCuPdpsfpf4GXjlgs/xL9TAH
xA+YuOPa4J5UTNTcen8DKfiFCvtSnnwCqTeUUP1ENGZqtu6dD4kpvpnzn5mszcmm
jzZG7X00d9Dv7rhGgQr9nzcoCHaKXBS/tVeH7PGnIqVLZ8DUqn36KTIF4SFjA6jq
S9gWAwpUQXYRz4kcNngVbJc1GcGK1rqrbbkxemkC55IHB0djQDIx04DlkHfv9+vw
M7Yq26Pp/uKojqvymrd0TAIaRlfFu5i2k7Nzbr1Fj9QMQec+YFS/dWec5Gkk91UQ
BsAxZU7BM0zQrvGlShTSx06/JxTJ6nPRbxbJnXOrcAyZxh0wQRvuxNVC6CAdCCVF
aJpt1VQcgiYBrEhihmwbte7scpIFjvgDxxjq7/l8pKkF3DiTXRSoqx5ndHAZ1hSt
ZSBzMzM3kdBzO3ZMu02miKBf7knuc1nMOwjQmwrW4JszwxWaaolyGpQ8PowipdqU
AoFhce6iFv5U1hlDOTZYaBTE/YHe3Xb2FZ8RYlpop78pe96Lo/NC405u3BWe6DES
Fj29K7SaY3rI/9XM8QMElg2JZkeCAGZsAmPDbZ7PUtQwKYwnuI4=
=SP0l
-END PGP SIGNATURE-

Changes since libreoffice-6-2-branch-point-15:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Libreoffice Gerrit user]

 vcl/source/control/edit.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 16dbaf8e4a487c75f5977f5f4febdeae4466c264
Author: Jim Raykowski 
AuthorDate: Wed Jan 9 00:18:40 2019 +0100
Commit: Jim Raykowski 
CommitDate: Wed Jan 9 02:25:22 2019 +0100

Revert "tdf#120170 Use parent key input handler for controls that use 
subedit"

This reverts commit 144ee02fc714f2f022e5046aeec2b46cd4cd1476.

Change-Id: I8dac626851895b67d24a2ee413c0121f7a5cfe16
Reviewed-on: https://gerrit.libreoffice.org/65988
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 9bc6942790c2..12b9b8943d8e 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -1710,7 +1710,7 @@ void Edit::KeyInput( const KeyEvent& rKEvt )
 mpUpdateDataTimer->Start();//do not update while the user is still 
travelling in the control
 
 if ( mpSubEdit || !ImplHandleKeyEvent( rKEvt ) )
-GetParent()->KeyInput( rKEvt );
+Control::KeyInput( rKEvt );
 }
 
 void Edit::FillLayoutData() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: libreoffice pdfimport w/ poppler-0.72.0: build failure

[Andreas Sturmlechner]

On Dienstag, 8. Jänner 2019 06:17:59 CET Kaganski Mike wrote:
> Could you please post the patch to gerrit [1] [2], and also post your 
> license statement [3]?
> 
> [1] https://gerrit.libreoffice.org

https://gerrit.libreoffice.org/#/c/65960/

> [3] 
> https://wiki.documentfoundation.org/Development/Developers#License_Statement
> s

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

Regards,
Andreas


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svx/source

[Libreoffice Gerrit user]

 svx/source/gallery2/GalleryControl.cxx |   30 --
 svx/source/gallery2/galbrws1.cxx   |4 +++-
 2 files changed, 23 insertions(+), 11 deletions(-)

New commits:
commit c9a7c4358d902900eb0fe66db36e283dc8df0336
Author: Aditya 
AuthorDate: Mon Jan 7 01:37:34 2019 +0530
Commit: Mike Kaganski 
CommitDate: Wed Jan 9 08:06:52 2019 +0100

tdf#120086: Patch for TAB-ing order of Gallery sidebar panel

The current TAB-ing order of Gallery sidebar panel is not sequential
and the order needed to be changed. This patch fixes the TAB-ing order
of the gallery sidebar panel to a more sequential and convenient one.
It also fixes the reverse TAB-ing order (Shift+TAB).

Change-Id: Ib0b22ccef1fa4676e535f42a794fb7c836741d0b
Reviewed-on: https://gerrit.libreoffice.org/65907
Reviewed-by: Jim Raykowski 
Tested-by: Mike Kaganski 

diff --git a/svx/source/gallery2/GalleryControl.cxx 
b/svx/source/gallery2/GalleryControl.cxx
old mode 100644
new mode 100755
index d41c3e803bdb..f54034aa88da
--- a/svx/source/gallery2/GalleryControl.cxx
+++ b/svx/source/gallery2/GalleryControl.cxx
@@ -185,25 +185,35 @@ bool GalleryControl::GalleryKeyInput( const KeyEvent& 
rKEvt )
 {
 if( !rKEvt.GetKeyCode().IsShift() )
 {
-if( mpBrowser1->mpThemes->HasChildPathFocus( true ) )
-mpBrowser2->GetViewWindow()->GrabFocus();
-else if( mpBrowser2->GetViewWindow()->HasFocus() )
+if( mpBrowser1->maNewTheme->HasFocus() )
+mpBrowser1->mpThemes->GrabFocus();
+else if( mpBrowser1->mpThemes->HasChildPathFocus( true ) )
 mpBrowser2->maViewBox->GrabFocus();
 else if( mpBrowser2->maViewBox->HasFocus() )
-mpBrowser1->maNewTheme->GrabFocus();
+mpBrowser2->GetViewWindow()->GrabFocus();
 else
-mpBrowser1->mpThemes->GrabFocus();
+{
+if( mpBrowser1->maNewTheme->IsEnabled() )
+mpBrowser1->maNewTheme->GrabFocus();
+else
+mpBrowser1->mpThemes->GrabFocus();
+}
 }
 else
 {
-if( mpBrowser1->mpThemes->HasChildPathFocus( true ) )
-mpBrowser1->maNewTheme->GrabFocus();
-else if( mpBrowser1->maNewTheme->HasFocus() )
+if( mpBrowser2->GetViewWindow()->HasFocus() )
 mpBrowser2->maViewBox->GrabFocus();
 else if( mpBrowser2->maViewBox->HasFocus() )
-mpBrowser2->GetViewWindow()->GrabFocus();
-else
 mpBrowser1->mpThemes->GrabFocus();
+else if( mpBrowser1->mpThemes->HasChildPathFocus( true ) )
+{
+if( mpBrowser1->maNewTheme->IsEnabled() )
+mpBrowser1->maNewTheme->GrabFocus();
+else
+mpBrowser2->GetViewWindow()->GrabFocus();
+}
+else
+mpBrowser2->GetViewWindow()->GrabFocus();
 }
 }
 
diff --git a/svx/source/gallery2/galbrws1.cxx b/svx/source/gallery2/galbrws1.cxx
old mode 100644
new mode 100755
index 416fa67f48e7..8c54ac56de4b
--- a/svx/source/gallery2/galbrws1.cxx
+++ b/svx/source/gallery2/galbrws1.cxx
@@ -410,7 +410,9 @@ void GalleryBrowser1::Resize()
 void GalleryBrowser1::GetFocus()
 {
 Control::GetFocus();
-if( mpThemes )
+if( maNewTheme->IsEnabled() )
+maNewTheme->GrabFocus();
+else
 mpThemes->GrabFocus();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Libreoffice Gerrit user]

 sd/source/core/drawdoc2.cxx  |3 --
 sd/source/core/drawdoc3.cxx  |   14 --
 sd/source/core/sdpage.cxx|   11 +++-
 sd/source/filter/eppt/epptso.cxx |   45 +++
 sd/source/filter/sdpptwrp.cxx|4 ---
 sd/source/ui/dlg/animobjs.cxx|   10 +++
 sd/source/ui/func/fuexpand.cxx   |   37 +---
 sd/source/ui/view/ToolBarManager.cxx |   14 ++
 sd/source/ui/view/sdview3.cxx|   24 +++---
 9 files changed, 68 insertions(+), 94 deletions(-)

New commits:
commit 850fb2ac2d89e68570db840bab65ac46df9d4314
Author: Noel Grandin 
AuthorDate: Tue Jan 8 15:26:37 2019 +0200
Commit: Noel Grandin 
CommitDate: Wed Jan 9 07:04:14 2019 +0100

use unique_ptr in sd

Change-Id: Ie212034c286146067c3ce49e62b2c47478ad7282
Reviewed-on: https://gerrit.libreoffice.org/65967
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sd/source/core/drawdoc2.cxx b/sd/source/core/drawdoc2.cxx
index f4ecee1d518d..c8eeb6e0830a 100644
--- a/sd/source/core/drawdoc2.cxx
+++ b/sd/source/core/drawdoc2.cxx
@@ -1047,7 +1047,7 @@ IMapObject* SdDrawDocument::GetHitIMapObject( SdrObject 
const * pObj,
 if ( auto pGrafObj = dynamic_cast< const SdrGrafObj *>( pObj ) ) // 
simple graphics object
 {
 const GeoStat&  rGeo = pGrafObj->GetGeoStat();
-SdrGrafObjGeoData*  pGeoData = static_cast( 
pGrafObj->GetGeoData() );
+std::unique_ptr 
pGeoData(static_cast( pGrafObj->GetGeoData() ));
 
 // Undo rotation
 if ( rGeo.nRotationAngle )
@@ -1067,7 +1067,6 @@ IMapObject* SdDrawDocument::GetHitIMapObject( SdrObject 
const * pObj,
 aGraphSize = OutputDevice::LogicToLogic( 
pGrafObj->GetGrafPrefSize(),
  
pGrafObj->GetGrafPrefMapMode(), aMap100 );
 
-delete pGeoData;
 bObjSupported = true;
 }
 else if ( auto pOleObj = dynamic_cast(pObj) ) // 
OLE object
diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx
index 28217258aff2..1075d85bb14c 100644
--- a/sd/source/core/drawdoc3.cxx
+++ b/sd/source/core/drawdoc3.cxx
@@ -1042,7 +1042,7 @@ bool SdDrawDocument::InsertBookmarkAsObject(
 if (pBMView)
 {
 // Insert selected objects
-::sd::View* pView = new ::sd::View(*this, nullptr);
+std::unique_ptr<::sd::View> pView(new ::sd::View(*this, nullptr));
 pView->EndListening(*this);
 
 // Look for the page into which the objects are supposed to be inserted
@@ -1100,7 +1100,7 @@ bool SdDrawDocument::InsertBookmarkAsObject(
 if (!bOLEObjFound)
 delete pTmpDoc; // Would otherwise be destroyed by DocShell
 
-delete pView;
+pView.reset();
 
 // Get number of objects after inserting.
 const size_t nCount = pPage->GetObjCount();
@@ -1471,19 +1471,17 @@ void SdDrawDocument::SetMasterPage(sal_uInt16 
nSdPageNum,
 if (pSourceDoc != this)
 {
 // #i121863# clone masterpages, they are from another model (!)
-SdPage* pNewNotesMaster = dynamic_cast< SdPage* 
>(pNotesMaster->CloneSdrPage(*this));
-SdPage* pNewMaster = dynamic_cast< SdPage* 
>(pMaster->CloneSdrPage(*this));
+std::unique_ptr pNewNotesMaster(dynamic_cast< SdPage* 
>(pNotesMaster->CloneSdrPage(*this)));
+std::unique_ptr pNewMaster(dynamic_cast< SdPage* 
>(pMaster->CloneSdrPage(*this)));
 
 if(!pNewNotesMaster || !pNewMaster)
 {
-delete pNewNotesMaster;
-delete pNewMaster;
 OSL_FAIL("SdDrawDocument::SetMasterPage() cloning of 
MasterPage/NoteAmsterPage failed!" );
 return;
 }
 
-pNotesMaster = pNewNotesMaster;
-pMaster = pNewMaster;
+pNotesMaster = pNewNotesMaster.release();
+pMaster = pNewMaster.release();
 
 // layout name needs to be unique
 aTargetNewLayoutName = pMaster->GetLayoutName();
diff --git a/sd/source/core/sdpage.cxx b/sd/source/core/sdpage.cxx
index a6de2cb6556d..78adba107798 100644
--- a/sd/source/core/sdpage.cxx
+++ b/sd/source/core/sdpage.cxx
@@ -2447,21 +2447,21 @@ void SdPage::SetObjText(SdrTextObj* pObj, SdrOutliner* 
pOutliner, PresObjKind eO
 aString += rString;
 
 // check if we need to add a text field
-SvxFieldData* pData = nullptr;
+std::unique_ptr pData;
 
 switch( eObjKind )
 {
 case PRESOBJ_HEADER:
-pData = new SvxHeaderField();
+pData.reset(new SvxHeaderField());
 break;
 case PRESOBJ_FOOTER:
-pData = new SvxFooterField();
+pData .reset(new 

Dawid Gan license statement

[Deve]

   All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - cpputools/Executable_regcomp.mk cpputools/Executable_regsingleton.mk cpputools/Executable_sp2bv.mk cpputools/Executable_uno.mk cpputool

[Libreoffice Gerrit user]

 cpputools/Executable_regcomp.mk  |   51 
 cpputools/Executable_regsingleton.mk |   54 --
 cpputools/Executable_sp2bv.mk|   36 
 cpputools/Executable_uno.mk  |   63 ---
 cpputools/Makefile   |   32 -
 cpputools/Module_cpputools.mk|   42 ---
 cpputools/Package_bin.mk |   27 ---
 cpputools/prj/build.lst  |7 +++
 cpputools/prj/d.lst  |   10 +
 cpputools/prj/makefile.mk|   44 
 10 files changed, 16 insertions(+), 350 deletions(-)

New commits:
commit 562339ffebf2bef1be04c98b45e7f67445a27d84
Author: Jim Jagielski 
AuthorDate: Wed Jan 9 01:26:47 2019 +
Commit: Jim Jagielski 
CommitDate: Wed Jan 9 01:26:47 2019 +

And remove the added files

diff --git a/cpputools/Executable_regcomp.mk b/cpputools/Executable_regcomp.mk
deleted file mode 100644
index e69de29bb2d1..
diff --git a/cpputools/Executable_regsingleton.mk 
b/cpputools/Executable_regsingleton.mk
deleted file mode 100644
index e69de29bb2d1..
diff --git a/cpputools/Executable_sp2bv.mk b/cpputools/Executable_sp2bv.mk
deleted file mode 100644
index e69de29bb2d1..
diff --git a/cpputools/Executable_uno.mk b/cpputools/Executable_uno.mk
deleted file mode 100644
index e69de29bb2d1..
diff --git a/cpputools/Makefile b/cpputools/Makefile
deleted file mode 100644
index e69de29bb2d1..
diff --git a/cpputools/Module_cpputools.mk b/cpputools/Module_cpputools.mk
deleted file mode 100644
index ccde29c8d44e..
--- a/cpputools/Module_cpputools.mk
+++ /dev/null
@@ -1,42 +0,0 @@
-#**
-#  
-#  Licensed to the Apache Software Foundation (ASF) under one
-#  or more contributor license agreements.  See the NOTICE file
-#  distributed with this work for additional information
-#  regarding copyright ownership.  The ASF licenses this file
-#  to you under the Apache License, Version 2.0 (the
-#  "License"); you may not use this file except in compliance
-#  with the License.  You may obtain a copy of the License at
-#  
-#http://www.apache.org/licenses/LICENSE-2.0
-#  
-#  Unless required by applicable law or agreed to in writing,
-#  software distributed under the License is distributed on an
-#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-#  KIND, either express or implied.  See the License for the
-#  specific language governing permissions and limitations
-#  under the License.
-#  
-#**
-
-
-
-$(eval $(call gb_Module_Module,cpputools))
-
-$(eval $(call gb_Module_add_targets,cpputools,\
-   Executable_regcomp \
-   Executable_regsingleton \
-   Executable_sp2bv \
-   Executable_uno \
-))
-
-ifeq ($(GUIBASE),WIN)
-else ifeq ($(GUIBASE),OS2)
-else
-$(eval $(call gb_Module_add_targets,cpputools,\
-   Package_bin \
-))
-endif
-
-
-# vim: set noet sw=4 ts=4:
diff --git a/cpputools/Package_bin.mk b/cpputools/Package_bin.mk
deleted file mode 100644
index e69de29bb2d1..
commit 6eabe2919eed2b052c5ee2c1d791ad14f6984f69
Author: Jim Jagielski 
AuthorDate: Wed Jan 9 01:26:27 2019 +
Commit: Jim Jagielski 
CommitDate: Wed Jan 9 01:26:27 2019 +

Revert -r 1838934 which breaks macOS. Porting this to gbuild isn't needed 
so this is basically a safe no-op

diff --git a/cpputools/Executable_regcomp.mk b/cpputools/Executable_regcomp.mk
index 3222f5d9cfd0..e69de29bb2d1 100644
--- a/cpputools/Executable_regcomp.mk
+++ b/cpputools/Executable_regcomp.mk
@@ -1,51 +0,0 @@
-#**
-#  
-#  Licensed to the Apache Software Foundation (ASF) under one
-#  or more contributor license agreements.  See the NOTICE file
-#  distributed with this work for additional information
-#  regarding copyright ownership.  The ASF licenses this file
-#  to you under the Apache License, Version 2.0 (the
-#  "License"); you may not use this file except in compliance
-#  with the License.  You may obtain a copy of the License at
-#  
-#http://www.apache.org/licenses/LICENSE-2.0
-#  
-#  Unless required by applicable law or agreed to in writing,
-#  software distributed under the License is distributed on an
-#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-#  KIND, either express or implied.  See the License for the
-#  specific language governing permissions and limitations
-#  under the License.
-#  
-#**
-
-
-
-$(eval $(call gb_Executable_Executable,regcomp))
-
-$(eval $(call gb_Executable_add_linked_libs,regcomp,\
-   cppu \
-   cppuhelper \
-   sal \
-   stl \
-$(gb_STDLIBS) \
-))
-
-$(eval $(call 

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/uibase/inc/UnfloatTableButton.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c3e815b216ab4495f3c5d36e798c453f1618b2df
Author: Andrea Gelmini 
AuthorDate: Tue Jan 8 13:34:52 2019 +0100
Commit: Julien Nabet 
CommitDate: Tue Jan 8 14:37:26 2019 +0100

Fix typo

Change-Id: I0f2f69bc1c5ed15ff4c2580ad7d81259add27007
Reviewed-on: https://gerrit.libreoffice.org/65948
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/sw/source/uibase/inc/UnfloatTableButton.hxx 
b/sw/source/uibase/inc/UnfloatTableButton.hxx
index 1ecfa8a3849f..94b4eb761ca0 100644
--- a/sw/source/uibase/inc/UnfloatTableButton.hxx
+++ b/sw/source/uibase/inc/UnfloatTableButton.hxx
@@ -16,7 +16,7 @@
 /** Class for unfloat table button
  *
  * This unfloat button is used to convert a floating table into a simple 
writer table embedded to the text body.
- * This unfloat oparation is useful typically for documents imported from MSO 
file formats containing
+ * This unfloat operation is useful typically for documents imported from MSO 
file formats containing
  * multi-page floating tables. In case of a multi-page table the text frame 
cuts off the table because
  * the frame can't span across multiple pages. With unfloating we can get a 
multi-page table without
  * floating properties.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sdext/source

[Libreoffice Gerrit user]

 sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 65a6c9ae4791188ffcecf489073cf38873ce5e17
Author: Andreas Sturmlechner 
AuthorDate: Tue Jan 8 11:24:40 2019 +0100
Commit: Michael Stahl 
CommitDate: Tue Jan 8 15:04:54 2019 +0100

Fix build with poppler-0.72

Change-Id: I0664d1b39e97b7555c0a3cba442db52b84f37134
Reviewed-on: https://gerrit.libreoffice.org/65960
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx 
b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
index 101e3bec731b..dab405bc81a1 100644
--- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
+++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
@@ -555,7 +555,11 @@ void PDFOutDev::processLink(Link* link, Catalog*)
 LinkAction* pAction = link->getAction();
 if (pAction && pAction->getKind() == actionURI)
 {
+#if POPPLER_CHECK_VERSION(0, 72, 0)
+const char* pURI = static_cast(pAction)->getURI()->c_str();
+#else
 const char* pURI = 
static_cast(pAction)->getURI()->getCString();
+#endif
 
 std::vector aEsc( lcl_escapeLineFeeds(pURI) );
 
@@ -757,7 +761,11 @@ void PDFOutDev::updateFont(GfxState *state)
 
 aFont = it->second;
 
+#if POPPLER_CHECK_VERSION(0, 72, 0)
+std::vector aEsc( 
lcl_escapeLineFeeds(aFont.familyName.c_str()) );
+#else
 std::vector aEsc( 
lcl_escapeLineFeeds(aFont.familyName.getCString()) );
+#endif
 printf( " %d %d %d %d %f %d %s",
 aFont.isEmbedded,
 aFont.isBold,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - xmloff/source

[Libreoffice Gerrit user]

 xmloff/source/chart/SchXMLExport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit eee044b76a2c4ef515475004a550dbd11635e5df
Author: Julien Nabet 
AuthorDate: Sun Dec 30 13:10:30 2018 +0100
Commit: Noel Grandin 
CommitDate: Tue Jan 8 14:23:32 2019 +0100

tdf#112782: data-pilot-source is invalid in odf1.2 strict

Change-Id: Ie24c416cb9ba8de904bf6e725a60b62ce7787596
Reviewed-on: https://gerrit.libreoffice.org/65742
(cherry picked from commit 18b9f23f13fd503e94d669ab80b5d2354d1817a1)
Reviewed-on: https://gerrit.libreoffice.org/65884
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmloff/source/chart/SchXMLExport.cxx 
b/xmloff/source/chart/SchXMLExport.cxx
index 7c8aa03b302b..e9e755dde3d1 100644
--- a/xmloff/source/chart/SchXMLExport.cxx
+++ b/xmloff/source/chart/SchXMLExport.cxx
@@ -1202,7 +1202,7 @@ void SchXMLExportHelper_Impl::parseDocument( Reference< 
chart::XChartDocument >
 }
 
 Reference 
xPivotTableDataProvider(xNewDoc->getDataProvider(), uno::UNO_QUERY);
-if (xPivotTableDataProvider.is())
+if (xPivotTableDataProvider.is() && nCurrentODFVersion > 
SvtSaveOptions::ODFVER_012)
 {
 OUString sPivotTableName = 
xPivotTableDataProvider->getPivotTableName();
 mrExport.AddAttribute(XML_NAMESPACE_LO_EXT, XML_DATA_PILOT_SOURCE, 
sPivotTableName);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - include/sfx2 sfx2/source

[Libreoffice Gerrit user]

 include/sfx2/sfxhelp.hxx |2 ++
 sfx2/source/appl/sfxhelp.cxx |   30 ++
 2 files changed, 32 insertions(+)

New commits:
commit 242119f8cdf0743afd96a5c467c81adace9a8c40
Author: Caolán McNamara 
AuthorDate: Sun Dec 23 17:46:48 2018 +
Commit: Noel Grandin 
CommitDate: Tue Jan 8 14:24:17 2019 +0100

tdf#122273 modal dialog on modeless dialog needs special handling

Change-Id: Idb5111b3f795f55c4b5644b5bcc6145106ff1392
Reviewed-on: https://gerrit.libreoffice.org/65584
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/sfx2/sfxhelp.hxx b/include/sfx2/sfxhelp.hxx
index d7afeb2b9af0..eaee5346b30e 100644
--- a/include/sfx2/sfxhelp.hxx
+++ b/include/sfx2/sfxhelp.hxx
@@ -40,6 +40,8 @@ private:
 SAL_DLLPRIVATE virtual bool Start(const OUString& rURL, weld::Widget* 
pWidget) override;
 SAL_DLLPRIVATE static OUString GetHelpModuleName_Impl(const OUString 
);
 SAL_DLLPRIVATE static OUString CreateHelpURL_Impl( const OUString& 
aCommandURL, const OUString& rModuleName );
+SAL_DLLPRIVATE static void incBusy(const vcl::Window* pParent);
+SAL_DLLPRIVATE static void decBusy(const vcl::Window* pParent);
 
 public:
 SfxHelp();
diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index 9e457b7968a8..08de23e30de6 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -1023,6 +1023,32 @@ namespace
 }
 }
 
+void SfxHelp::incBusy(const vcl::Window* pParent)
+{
+// lock any toplevel windows from being closed until busy is over
+// ensure any dialogs are reset before entering
+vcl::Window *xTopWin = Application::GetFirstTopLevelWindow();
+while (xTopWin)
+{
+if (xTopWin != pParent)
+xTopWin->IncModalCount();
+xTopWin = Application::GetNextTopLevelWindow(xTopWin);
+}
+}
+
+void SfxHelp::decBusy(const vcl::Window* pParent)
+{
+// unlock any toplevel windows from being closed until busy is over
+// ensure any dialogs are reset before entering
+vcl::Window *xTopWin = Application::GetFirstTopLevelWindow();
+while (xTopWin)
+{
+if (xTopWin != pParent)
+xTopWin->DecModalCount();
+xTopWin = Application::GetNextTopLevelWindow(xTopWin);
+}
+}
+
 bool SfxHelp::Start_Impl(const OUString& rURL, const vcl::Window* pWindow, 
const OUString& rKeyword)
 {
 OUStringBuffer aHelpRootURL("vnd.sun.star.help://");
@@ -1131,6 +1157,7 @@ bool SfxHelp::Start_Impl(const OUString& rURL, const 
vcl::Window* pWindow, const
 
 if(bShowOfflineHelpPopUp)
 {
+incBusy(pWindow);
 std::unique_ptr 
xBuilder(Application::CreateBuilder(pWindow ? pWindow->GetFrameWeld() : 
nullptr, "sfx/ui/helpmanual.ui"));
 std::unique_ptr 
xQueryBox(xBuilder->weld_message_dialog("onlinehelpmanual"));
 std::unique_ptr 
m_xHideOfflineHelpCB(xBuilder->weld_check_button("hidedialog"));
@@ -1141,6 +1168,7 @@ bool SfxHelp::Start_Impl(const OUString& rURL, const 
vcl::Window* pWindow, const
 short OnlineHelpBox = xQueryBox->run();
 bShowOfflineHelpPopUp = OnlineHelpBox != RET_OK;
 
aHelpOptions.SetOfflineHelpPopUp(!m_xHideOfflineHelpCB->get_state());
+decBusy(pWindow);
 }
 if(!bShowOfflineHelpPopUp)
 {
@@ -1148,8 +1176,10 @@ bool SfxHelp::Start_Impl(const OUString& rURL, const 
vcl::Window* pWindow, const
 return true;
 else
 {
+incBusy(pWindow);
 NoHelpErrorBox aErrBox(pWindow ? pWindow->GetFrameWeld() : 
nullptr);
 aErrBox.run();
+decBusy(pWindow);
 return false;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - extras/source

[Libreoffice Gerrit user]

 extras/source/templates/wizard/agenda/10grey.ott |binary
 extras/source/templates/wizard/agenda/1simple.ott|binary
 extras/source/templates/wizard/agenda/2elegant.ott   |binary
 extras/source/templates/wizard/agenda/3modern.ott|binary
 extras/source/templates/wizard/agenda/4classic.ott   |binary
 extras/source/templates/wizard/agenda/5blue.ott  |binary
 extras/source/templates/wizard/agenda/6orange.ott|binary
 extras/source/templates/wizard/agenda/7red.ott   |binary
 extras/source/templates/wizard/agenda/8green.ott |binary
 extras/source/templates/wizard/agenda/9colorful.ott  |binary
 extras/source/templates/wizard/agenda/aw-10grey.ott  |binary
 extras/source/templates/wizard/agenda/aw-1simple.ott |binary
 extras/source/templates/wizard/agenda/aw-2elegant.ott|binary
 extras/source/templates/wizard/agenda/aw-3modern.ott |binary
 extras/source/templates/wizard/agenda/aw-4classic.ott|binary
 extras/source/templates/wizard/agenda/aw-5blue.ott   |binary
 extras/source/templates/wizard/agenda/aw-6orange.ott |binary
 extras/source/templates/wizard/agenda/aw-7red.ott|binary
 extras/source/templates/wizard/agenda/aw-8green.ott  |binary
 extras/source/templates/wizard/agenda/aw-9colorful.ott   |binary
 extras/source/templates/wizard/desktop/html.stw  |binary
 extras/source/templates/wizard/desktop/idxexample.odt|binary
 extras/source/templates/wizard/fax/bus-classic-pri_f.ott |binary
 extras/source/templates/wizard/fax/bus-classic_f.ott |binary
 extras/source/templates/wizard/fax/bus-modern-pri_f.ott  |binary
 extras/source/templates/wizard/fax/bus-modern_f.ott  |binary
 extras/source/templates/wizard/fax/pri-bottle_f.ott  |binary
 extras/source/templates/wizard/fax/pri-fax_f.ott |binary
 extras/source/templates/wizard/fax/pri-lines_f.ott   |binary
 extras/source/templates/wizard/fax/pri-marine_f.ott  |binary
 extras/source/templates/wizard/letter/bus-elegant_l.ott  |binary
 extras/source/templates/wizard/letter/bus-modern_l.ott   |binary
 extras/source/templates/wizard/letter/bus-office_l.ott   |binary
 extras/source/templates/wizard/letter/off-elegant_l.ott  |binary
 extras/source/templates/wizard/letter/off-modern_l.ott   |binary
 extras/source/templates/wizard/letter/off-office_l.ott   |binary
 extras/source/templates/wizard/letter/pri-bottle_l.ott   |binary
 extras/source/templates/wizard/letter/pri-mail_l.ott |binary
 extras/source/templates/wizard/letter/pri-marine_l.ott   |binary
 extras/source/templates/wizard/letter/pri-redline_l.ott  |binary
 extras/source/templates/wizard/report/cnt-01.ott |binary
 extras/source/templates/wizard/report/cnt-011.ott|binary
 extras/source/templates/wizard/report/cnt-012.ott|binary
 extras/source/templates/wizard/report/cnt-02.ott |binary
 extras/source/templates/wizard/report/cnt-021.ott|binary
 extras/source/templates/wizard/report/cnt-022.ott|binary
 extras/source/templates/wizard/report/cnt-03.ott |binary
 extras/source/templates/wizard/report/cnt-031.ott|binary
 extras/source/templates/wizard/report/cnt-032.ott|binary
 extras/source/templates/wizard/report/cnt-04.ott |binary
 extras/source/templates/wizard/report/cnt-041.ott|binary
 extras/source/templates/wizard/report/cnt-042.ott|binary
 extras/source/templates/wizard/report/cnt-05.ott |binary
 extras/source/templates/wizard/report/cnt-051.ott|binary
 extras/source/templates/wizard/report/cnt-052.ott|binary
 extras/source/templates/wizard/report/cnt-06.ott |binary
 extras/source/templates/wizard/report/cnt-061.ott|binary
 extras/source/templates/wizard/report/cnt-062.ott|binary
 extras/source/templates/wizard/report/cnt-default.ott|binary
 extras/source/templates/wizard/report/stl-01.ott |binary
 extras/source/templates/wizard/report/stl-02.ott |binary
 extras/source/templates/wizard/report/stl-03.ott |binary
 extras/source/templates/wizard/report/stl-04.ott |binary
 extras/source/templates/wizard/report/stl-05.ott |binary
 extras/source/templates/wizard/report/stl-06.ott |binary
 extras/source/templates/wizard/report/stl-07.ott |binary
 extras/source/templates/wizard/report/stl-08.ott |binary
 extras/source/templates/wizard/report/stl-09.ott |binary
 extras/source/templates/wizard/report/stl-default.ott|binary
 extras/source/templates/wizard/styles/black_white.ots|binary
 extras/source/templates/wizard/styles/blackberry.ots |binary
 extras/source/templates/wizard/styles/default.ots|binary
 extras/source/templates/wizard/styles/diner.ots  |binary
 extras/source/templates/wizard/styles/fall.ots   |binary
 extras/source/templates/wizard/styles/glacier.ots|binary
 

[Libreoffice-commits] core.git: 2 commits - sw/source

[Libreoffice Gerrit user]

 sw/source/core/doc/DocumentRedlineManager.cxx |   40 +++---
 sw/source/filter/ww8/wrtww8.cxx   |4 +-
 sw/source/filter/ww8/ww8par.cxx   |   11 +--
 3 files changed, 35 insertions(+), 20 deletions(-)

New commits:
commit 2dda396f4de051cccf3442f17c84bf2ff5d1db1d
Author: Michael Stahl 
AuthorDate: Tue Jan 8 13:32:05 2019 +0100
Commit: Michael Stahl 
CommitDate: Tue Jan 8 15:16:50 2019 +0100

tdf#122452 sw_redlinehide: WW8 import/export sets layout show/hide mode

... and not SetRedlineFlags(), similar to the way the ODF filter does it.

The RTF/DOCX filters don't appear to be able to export the show/hide
flag currently, they can only handle the enabled flag.

Change-Id: I76bc19292882d7de5c28ea6afe0f81eadbd4a04f
Reviewed-on: https://gerrit.libreoffice.org/65966
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 371912fba436..69be4bc2ce55 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -58,6 +58,7 @@
 #include 
 #include 
 #include 
+#include <../../core/inc/rootfrm.hxx>
 #include 
 #include 
 #include 
@@ -3352,7 +3353,8 @@ ErrCode WW8Export::ExportDocument_Impl()
 pDop.reset(new WW8Dop);
 
 pDop->fRevMarking = bool( RedlineFlags::On & m_nOrigRedlineFlags );
-pDop->fRMView = bool( RedlineFlags::ShowDelete & m_nOrigRedlineFlags );
+SwRootFrame const*const 
pLayout(m_pDoc->getIDocumentLayoutAccess().GetCurrentLayout());
+pDop->fRMView = pLayout == nullptr || !pLayout->IsHideRedlines();
 pDop->fRMPrint = pDop->fRMView;
 
 // set AutoHyphenation flag if found in default para style
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 4b4ca3df60d2..ed9754aee1e7 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -83,6 +83,7 @@
 #include 
 #include 
 #include 
+#include <../../core/inc/DocumentRedlineManager.hxx>
 #include 
 #include 
 #include 
@@ -4981,7 +4982,7 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const 
*pGloss)
 SwNodeIndex aSttNdIdx( m_rDoc.GetNodes() );
 SwRelNumRuleSpaces aRelNumRule(m_rDoc, m_bNewDoc);
 
-RedlineFlags eMode = RedlineFlags::ShowInsert;
+RedlineFlags eMode = RedlineFlags::ShowInsert | RedlineFlags::ShowDelete;
 
 m_xSprmParser.reset(new wwSprmParser(*m_xWwFib));
 
@@ -5281,12 +5282,13 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const 
*pGloss)
 }
 }
 
+bool isHideRedlines(false);
+
 if (m_bNewDoc)
 {
 if( m_xWDop->fRevMarking )
 eMode |= RedlineFlags::On;
-if( m_xWDop->fRMView )
-eMode |= RedlineFlags::ShowDelete;
+isHideRedlines = !m_xWDop->fRMView;
 }
 
 m_aInsertedTables.DelAndMakeTableFrames();
@@ -5420,6 +5422,9 @@ ErrCode SwWW8ImplReader::CoreLoad(WW8Glossary const 
*pGloss)
 
 UpdatePageDescs(m_rDoc, nPageDescOffset);
 
+// can't set it on the layout or view shell because it doesn't exist yet
+m_rDoc.GetDocumentRedlineManager().SetHideRedlines(isHideRedlines);
+
 return ERRCODE_NONE;
 }
 
commit b15f1ed2a1df45a57b587ac90efa90c1c18866fc
Author: Michael Stahl 
AuthorDate: Tue Jan 8 13:22:31 2019 +0100
Commit: Michael Stahl 
CommitDate: Tue Jan 8 15:16:44 2019 +0100

sw_redlinehide: try harder to prevent SetRedlineFlags from messing things up

Rearrange the code added in 15f1555da8adfa81ea1d4b0d8b694164fddbb2ae
to set all layouts to non-hidden before moving redlines in the model.

tdf52550-1.doc contains lots of consecutive delete redlines that
when exported to ODF trigger asserts about wrong start nodes in
CheckParaRedlineMerge().

Change-Id: I89c3d4fefd26691a9632807b9899138eee895fff
Reviewed-on: https://gerrit.libreoffice.org/65965
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx 
b/sw/source/core/doc/DocumentRedlineManager.cxx
index 326b151da2a7..5eddd00f0ebf 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -839,6 +839,25 @@ void DocumentRedlineManager::SetRedlineFlags( RedlineFlags 
eMode )
 CheckAnchoredFlyConsistency(m_rDoc);
 CHECK_REDLINE( *this )
 
+std::set hiddenLayouts;
+if (eShowMode == (RedlineFlags::ShowInsert | 
RedlineFlags::ShowDelete))
+{
+// sw_redlinehide: the problem here is that MoveFromSection
+// creates the frames wrongly (non-merged), because its own
+// SwRangeRedline has wrong positions until after the nodes
+// are all moved, so fix things up by force by re-creating
+// all merged frames from scratch.
+std::set const layouts(m_rDoc.GetAllLayouts());
+for (SwRootFrame 

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/uibase/wrtsh/wrtundo.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 8249fc75a28fe6434a9b60c50487e8f2a2e1e588
Author: Caolán McNamara 
AuthorDate: Tue Jan 8 13:46:53 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 8 16:09:53 2019 +0100

Resolves: tdf#121940 mnemonic ends up in tooltip text

Change-Id: Ic698f23e71dbc613db2acf884fdefdeab06fde0f
Reviewed-on: https://gerrit.libreoffice.org/65968
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/wrtsh/wrtundo.cxx 
b/sw/source/uibase/wrtsh/wrtundo.cxx
index 2cc9e54ba232..ee9c315c96f0 100644
--- a/sw/source/uibase/wrtsh/wrtundo.cxx
+++ b/sw/source/uibase/wrtsh/wrtundo.cxx
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 
 // Undo ends all modes. If a selection is emerged by the Undo,
 // this must be considered for further action.
@@ -108,7 +109,7 @@ OUString SwWrtShell::GetDoString( DoType eDoType ) const
 default:;//prevent warning
 }
 
-return SvtResId(pResStr) + aUndoStr;
+return MnemonicGenerator::EraseAllMnemonicChars(SvtResId(pResStr)) + 
aUndoStr;
 }
 
 void SwWrtShell::GetDoStrings( DoType eDoType, SfxStringListItem& rStrs ) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - icon-themes/breeze icon-themes/colibre icon-themes/colibre_svg

[Libreoffice Gerrit user]

 icon-themes/breeze/links.txt   |3 +++
 icon-themes/colibre/cmd/32/toolbarmode.png |binary
 icon-themes/colibre/cmd/lc_toolbarmode.png |binary
 icon-themes/colibre/links.txt  |3 +++
 icon-themes/colibre_svg/cmd/32/toolbarmode.svg |   18 ++
 icon-themes/colibre_svg/cmd/lc_toolbarmode.svg |   18 ++
 icon-themes/colibre_svg/cmd/sc_toolbarmode.svg |8 +---
 7 files changed, 43 insertions(+), 7 deletions(-)

New commits:
commit 4d3cdbf3700e1247ba62d99d86da38efd3c181b7
Author: andreas kainz 
AuthorDate: Mon Jan 7 22:16:25 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jan 8 10:09:42 2019 +0100

Colibre icon: update toolbarmode and donate icon

Change-Id: Ie628d666f3f8d8bf0cfefd212706d5ce4e76dfe0
Reviewed-on: https://gerrit.libreoffice.org/65946
Tested-by: Jenkins
Reviewed-by: andreas_kainz 
(cherry picked from commit a236da0c740e79aed9213005c6a106b4fe2cb293)
Reviewed-on: https://gerrit.libreoffice.org/65954
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index 4fdae9a5250c..696f78f53887 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -1799,3 +1799,6 @@ cmd/sc_basicideappear.png cmd/sc_toolsmacroedit.png
 cmd/sc_macrosmenu.png res/im30821.png
 cmd/sc_macrodialog.png cmd/sc_scriptorganizer.png
 cmd/lc_macrodialog.png cmd/lc_scriptorganizer.png
+
+cmd/lc_donation.png cmd/lc_currencyfield.png
+cmd/sc_donation.png cmd/sc_currencyfield.png
diff --git a/icon-themes/colibre/cmd/32/toolbarmode.png 
b/icon-themes/colibre/cmd/32/toolbarmode.png
new file mode 100644
index ..098361bfe914
Binary files /dev/null and b/icon-themes/colibre/cmd/32/toolbarmode.png differ
diff --git a/icon-themes/colibre/cmd/lc_toolbarmode.png 
b/icon-themes/colibre/cmd/lc_toolbarmode.png
new file mode 100644
index ..ed7834ed7584
Binary files /dev/null and b/icon-themes/colibre/cmd/lc_toolbarmode.png differ
diff --git a/icon-themes/colibre/links.txt b/icon-themes/colibre/links.txt
index feb84b9a3436..4b391cf8100b 100644
--- a/icon-themes/colibre/links.txt
+++ b/icon-themes/colibre/links.txt
@@ -1808,3 +1808,6 @@ cmd/lc_basicideappear.png cmd/lc_toolsmacroedit.png
 
 cmd/sc_macrosmenu.png cmd/sc_choosemacro.png
 cmd/sc_basicideappear.png cmd/sc_toolsmacroedit.png
+
+cmd/lc_donation.png cmd/lc_currencyfield.png
+cmd/sc_donation.png cmd/sc_currencyfield.png
diff --git a/icon-themes/colibre_svg/cmd/32/toolbarmode.svg 
b/icon-themes/colibre_svg/cmd/32/toolbarmode.svg
new file mode 100644
index ..3745ea5cd464
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/toolbarmode.svg
@@ -0,0 +1,18 @@
+http://www.w3.org/2000/svg;>
+  
+  
+  
+  
+
diff --git a/icon-themes/colibre_svg/cmd/lc_toolbarmode.svg 
b/icon-themes/colibre_svg/cmd/lc_toolbarmode.svg
new file mode 100644
index ..3ba9321f5f03
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/lc_toolbarmode.svg
@@ -0,0 +1,18 @@
+http://www.w3.org/2000/svg;>
+  
+  
+  
+  
+
diff --git a/icon-themes/colibre_svg/cmd/sc_toolbarmode.svg 
b/icon-themes/colibre_svg/cmd/sc_toolbarmode.svg
index 8f948ef7c839..8cab7ea3bf30 100644
--- a/icon-themes/colibre_svg/cmd/sc_toolbarmode.svg
+++ b/icon-themes/colibre_svg/cmd/sc_toolbarmode.svg
@@ -1,8 +1,2 @@
 http://www.w3.org/2000/svg;>
-
-
-
-
-
- /
- 
\ No newline at end of file
+ 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Weekly QA Report (W01-2019)

[Xisco Fauli]

Hello,

What have happened in QA in the last 7 days?

  * 122 bugs have been reported by 76 people.
        + Link: http://tinyurl.com/ya6smf6a

  * Top 10 reporters:
        + NISZ LibreOffice Team (16)
        + Xisco Faulí (9)
        + Cor Nouws (7)
        + Telesto (5)
        + Harald Koester (4)
        + William Gathoye (3)
        + Andras Timar (3)
        + seven (2)
        + Elmar (2)
        + Marco A.G.Pinto (2)

  * Top 10 commenters:
        + Xisco Faulí (50)
        + NISZ LibreOffice Team (33)
        + Buovjaga (31)
        + durgapriyanka.arun (30)
        + Cor Nouws (29)
        + Dieter Praas (28)
        + raal (21)
        + Heiko Tietze (21)
        + Mike Kaganski (19)
        + Roman Kuznetsov (18)

  * 32 bugs reported haven't been triaged yet.
        + Link: http://tinyurl.com/y9kj25qg

  * Total number of unconfirmed bugs: 519

  * 706 comments have been written by 156 people.

  * 44 new people have signed up to Bugzilla.

== STATUSES CHANGED ==
  * 3 bugs have been changed from 'ASSIGNED' to 'NEW'.
        + Link: http://tinyurl.com/y9wj5wu2
        + Done by:
  Xisco Faulí (3)

  * 14 bugs have been changed from 'ASSIGNED' to 'RESOLVED FIXED'.
        + Link: http://tinyurl.com/ybh5hcq9
        + Done by:
  László Németh (3), Muhammet Kara (2), Mike Kaganski (2),
  Adolfo Jayme (2), Tamás Zolnai (1), Julien Nabet (1),
  Laurent BP (1), Bartosz (1), David Tardon (1)

  * 1 bug has been changed from 'NEEDINFO' to 'NEW'.
        + Link: http://tinyurl.com/yayqwt4r
        + Done by:
  V Stuart Foote (1)

  * 1 bug has been changed from 'NEEDINFO' to 'RESOLVED FIXED'.
        + Link: http://tinyurl.com/ybkjn6d5
        + Done by:
  simobb2002 (1)

  * 1 bug has been changed from 'NEEDINFO' to 'RESOLVED INSUFFICIENTDATA'.
        + Link: http://tinyurl.com/y9b4rf4r
        + Done by:
  Andre Klapper (1)

  * 10 bugs have been changed from 'NEEDINFO' to 'UNCONFIRMED'.
        + Link: http://tinyurl.com/y9n4v98d
        + Done by:
  ibelin123 (2), Buovjaga (1), Telesto (1), san_ionut (1),
  rtaube (1), nospam.nurdglaw (1), Marco A.G.Pinto (1),
  Mohamed Anis MANI (1), anmeldung-documentfoundation (1)

  * 13 bugs have been changed from 'NEW' to 'ASSIGNED'.
        + Link: http://tinyurl.com/yarst4t2
        + Done by:
  Justin L (4), Muhammet Kara (2), Mike Kaganski (2),
  Aditya Sahu (2), Xisco Faulí (1), László Németh (1),
  Bartosz (1)

  * 1 bug has been changed from 'NEW' to 'NEEDINFO'.
        + Link: http://tinyurl.com/y7nwjvqn
        + Done by:
  Xisco Faulí (1)

  * 6 bugs have been changed from 'NEW' to 'RESOLVED DUPLICATE'.
        + Link: http://tinyurl.com/yalloqqy
        + Done by:
  Timur (2), Buovjaga (1), Heiko Tietze (1), Thomas Lendo (1),
  Rob Snelders (1)

  * 11 bugs have been changed from 'NEW' to 'RESOLVED FIXED'.
        + Link: http://tinyurl.com/y9ulh5zt
        + Done by:
  andreas_k (4), László Németh (2), Heiko Tietze (1),
  Oliver Brinzing (1), Justin L (1), dr.yehmy (1),
  Aron Budea (1)

  * 1 bug has been changed from 'NEW' to 'RESOLVED NOTABUG'.
        + Link: http://tinyurl.com/hhfb4cb
        + Done by:
  Cor Nouws (1)

  * 2 bugs have been changed from 'NEW' to 'RESOLVED NOTOURBUG'.
        + Link: http://tinyurl.com/yc5cqgh9
        + Done by:
  Buovjaga (1), Regina Henschel (1)

  * 1 bug has been changed from 'NEW' to 'RESOLVED WONTFIX'.
        + Link: http://tinyurl.com/ycyvkmud
        + Done by:
  Buovjaga (1)

  * 15 bugs have been changed from 'NEW' to 'RESOLVED WORKSFORME'.
        + Link: http://tinyurl.com/ycp3zkwj
        + Done by:
  Buovjaga (5), Roman Kuznetsov (3), Dieter Praas (2),
  Xisco Faulí (1), Thomas Lendo (1), Jean-Baptiste Faure (1),
  Helmut Leininger (1), Cor Nouws (1)

  * 1 bug has been changed from 'NEW' to 'UNCONFIRMED'.
        + Link: http://tinyurl.com/yatcd44p
        + Done by:
  Xisco Faulí (1)

  * 1 bug has been changed from 'REOPENED' to 'NEW'.
        + Link: http://tinyurl.com/y7ch4rdr
        + Done by:
  Heiko Tietze (1)

  * 1 bug has been changed from 'REOPENED' to 'RESOLVED FIXED'.
        + Link: http://tinyurl.com/y8o6hqwg
        + Done by:
  Jim Raykowski (1)

  * 1 bug has been changed from 'REOPENED' to 'UNCONFIRMED'.
        + Link: http://tinyurl.com/ybjhp5e6
        + Done by:
  Dieter Praas (1)

  * 1 bug has been changed from 'RESOLVED DUPLICATE' to 'NEW '.
        + Link: http://tinyurl.com/y95pwr6p
        + Done by:
  Harald Koester (1)

  * 1 bug has been changed from 'RESOLVED DUPLICATE' to 'REOPENED '.
        + Link: http://tinyurl.com/ycncw7ml
        + Done by:
  Martin Srebotnjak (1)

  * 1 bug has been changed from 'RESOLVED FIXED' to 'NEW'.
        + Link: http://tinyurl.com/ybgha3mz
        + Done by:
  Alex 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/qa sw/source

[Libreoffice Gerrit user]

 sw/qa/extras/ww8import/data/tdf122425_1.doc |binary
 sw/qa/extras/ww8import/data/tdf122425_2.doc |binary
 sw/qa/extras/ww8import/ww8import.cxx|   66 
 sw/source/filter/ww8/ww8graf.cxx|1 
 sw/source/filter/ww8/ww8par.cxx |7 ++
 5 files changed, 73 insertions(+), 1 deletion(-)

New commits:
commit 988f4db332a723ca5c6af569328605a7c5a12bb7
Author: Mike Kaganski 
AuthorDate: Sun Jan 6 19:35:41 2019 +0300
Commit: Andras Timar 
CommitDate: Tue Jan 8 11:33:16 2019 +0100

tdf#122425: explicitly remove borders for newly created flys

After commit d398e9248c183cf988b6d985b342b0cbff93ea02, it's necessary
to make sure that each created floating object has proper default
border and spacing values (empty and 0), to not inherit frame style's
non-0 values unintentionally.

This fixes two places for objects in headers/footers.

Change-Id: I2632bcd4066609c97aa15e39d69e9089ac691ff2
Reviewed-on: https://gerrit.libreoffice.org/65906
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 2e189c2464de007b3d59ba37d4f3f1cfbe5b480c)
Reviewed-on: https://gerrit.libreoffice.org/65908
Tested-by: Mike Kaganski 
Reviewed-by: Andras Timar 

diff --git a/sw/qa/extras/ww8import/data/tdf122425_1.doc 
b/sw/qa/extras/ww8import/data/tdf122425_1.doc
new file mode 100644
index ..f0e5b148d347
Binary files /dev/null and b/sw/qa/extras/ww8import/data/tdf122425_1.doc differ
diff --git a/sw/qa/extras/ww8import/data/tdf122425_2.doc 
b/sw/qa/extras/ww8import/data/tdf122425_2.doc
new file mode 100644
index ..8debcddc1690
Binary files /dev/null and b/sw/qa/extras/ww8import/data/tdf122425_2.doc differ
diff --git a/sw/qa/extras/ww8import/ww8import.cxx 
b/sw/qa/extras/ww8import/ww8import.cxx
index 718c8948645d..76eb495bb499 100644
--- a/sw/qa/extras/ww8import/ww8import.cxx
+++ b/sw/qa/extras/ww8import/ww8import.cxx
@@ -182,6 +182,72 @@ DECLARE_WW8IMPORT_TEST(testTdf121734, "tdf121734.doc")
 }
 }
 
+DECLARE_WW8IMPORT_TEST(testTdf122425_1, "tdf122425_1.doc")
+{
+// This is for header text in case we use a hack for fixed-height headers
+// (see SwWW8ImplReader::Read_HdFtTextAsHackedFrame)
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
+SwPosFlyFrames aPosFlyFrames = pDoc->GetAllFlyFormats(nullptr, false);
+// There are two fly frames in the document: for first page's header, and 
for other pages'
+CPPUNIT_ASSERT_EQUAL(size_t(2), aPosFlyFrames.size());
+for (const auto& rPosFlyFrame : aPosFlyFrames)
+{
+const SwFrameFormat& rFormat = rPosFlyFrame->GetFormat();
+const SfxPoolItem* pItem = nullptr;
+
+// The LR and UL spacings and borders must all be set explicitly;
+// spacings and border distances must be 0; borders must be absent
+
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, 
rFormat.GetItemState(RES_LR_SPACE, false, ));
+auto pLR = static_cast(pItem);
+CPPUNIT_ASSERT(pLR);
+CPPUNIT_ASSERT_EQUAL(long(0), pLR->GetLeft());
+CPPUNIT_ASSERT_EQUAL(long(0), pLR->GetRight());
+
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, 
rFormat.GetItemState(RES_UL_SPACE, false, ));
+auto pUL = static_cast(pItem);
+CPPUNIT_ASSERT(pUL);
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), pUL->GetUpper());
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), pUL->GetLower());
+
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, rFormat.GetItemState(RES_BOX, 
false, ));
+auto pBox = static_cast(pItem);
+CPPUNIT_ASSERT(pBox);
+for (auto eLine : { SvxBoxItemLine::TOP, SvxBoxItemLine::BOTTOM,
+SvxBoxItemLine::LEFT, SvxBoxItemLine::RIGHT })
+{
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), pBox->GetDistance(eLine));
+CPPUNIT_ASSERT(!pBox->GetLine(eLine));
+}
+}
+}
+
+DECLARE_WW8IMPORT_TEST(testTdf122425_2, "tdf122425_2.doc")
+{
+// This is for graphic objects in headers/footers
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
+SwPosFlyFrames aPosFlyFrames = pDoc->GetAllFlyFormats(nullptr, false);
+// There is one fly frame in the document: the text box
+CPPUNIT_ASSERT_EQUAL(size_t(1), aPosFlyFrames.size());
+for (const auto& rPosFlyFrame : aPosFlyFrames)
+{
+const SwFrameFormat& rFormat = rPosFlyFrame->GetFormat();
+const SfxPoolItem* pItem = nullptr;
+
+// Check for correct explicitly-set values of UL spacings. Previously 
this was "DEFAULT",
+// and resulted in inherited values (114 = 2 mm) used.
+CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, 
rFormat.GetItemState(RES_UL_SPACE, false, ));
+auto pUL = static_cast(pItem);
+

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

[Libreoffice Gerrit user]

 sc/source/ui/pagedlg/scuitphfedit.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit a1f3bcc6312a56fee9825703394fe5b3a20a
Author: Caolán McNamara 
AuthorDate: Thu Dec 20 16:52:11 2018 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jan 8 11:37:29 2019 +0100

Resolves: tdf#114695 limit width of this combo

Change-Id: I3bcb880d05b9b2b6a7faf7b3646b169f3b11a46b
Reviewed-on: https://gerrit.libreoffice.org/65509
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx 
b/sc/source/ui/pagedlg/scuitphfedit.cxx
index 46d94e7d751d..f1c9d194da63 100644
--- a/sc/source/ui/pagedlg/scuitphfedit.cxx
+++ b/sc/source/ui/pagedlg/scuitphfedit.cxx
@@ -64,6 +64,10 @@ ScHFEditPage::ScHFEditPage( vcl::Window* pParent,
 m_pWndRight->SetLocation(Right);
 
 get(m_pLbDefined,"comboLB_DEFINED");
+// tdf#114695 override natural size with a small value
+// we expect this to get stretched to some larger but
+// limited size based on surrounding widgets
+m_pLbDefined->set_width_request(m_pLbDefined->approximate_digit_width() * 
20);
 
 get(m_pBtnText,"buttonBTN_TEXT");
 get(m_pBtnTable,"buttonBTN_TABLE");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Building LibreOffice on MacOS mojave

[Stephan Bergmann]

On 08/01/2019 09:22, Tor Lillqvist wrote:

I wonder if we should finally turn Java into opt-in instead of opt-out?


...or probably make 
 
"tdf#121925 test for URLClassPath.ClassPathURLCheck" less noisy/scary 
when it determines url_check_unknown (which seems to be common with Java 
< 11)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - compilerplugins/LICENSE.TXT cui/uiconfig odk/docs odk/examples odk/index.html odk/index_online.html readlicense_oo/license setup_native/sourc

[Libreoffice Gerrit user]

 compilerplugins/LICENSE.TXT   |2 
 cui/uiconfig/ui/aboutdialog.ui|2 
 odk/docs/install.html |2 
 odk/docs/tools.html   |2 
 odk/examples/DevelopersGuide/examples.html|2 
 odk/examples/examples.html|2 
 odk/index.html|2 
 odk/index_online.html |2 
 readlicense_oo/license/LICENSE|2 
 readlicense_oo/license/LICENSE.fodt   |2 
 readlicense_oo/license/LICENSE.html   |2 
 setup_native/source/packinfo/packinfo_brand.txt   |   16 +-
 setup_native/source/packinfo/packinfo_extensions.txt  |8 -
 setup_native/source/packinfo/packinfo_office.txt  |  118 +-
 setup_native/source/packinfo/packinfo_office_help.txt |2 
 setup_native/source/packinfo/packinfo_office_lang.txt |   20 +--
 setup_native/source/packinfo/packinfo_sdkoo.txt   |2 
 setup_native/source/packinfo/packinfo_ure.txt |4 
 sfx2/uiconfig/ui/licensedialog.ui |2 
 19 files changed, 97 insertions(+), 97 deletions(-)

New commits:
commit eb10f958001cdfdb83cd1e4a537ccf4903b72922
Author: Adolfo Jayme Barrientos 
AuthorDate: Tue Jan 1 00:00:00 2019 -0600
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 11:56:52 2019 +0100

Bump copyright year to 2019

Change-Id: I0d49ec7db57a0f7d18489dad61e86cbfdf4418cd
(cherry picked from commit 588dc2808c79da714cc107548631a65a7ddfe5d0)
Reviewed-on: https://gerrit.libreoffice.org/65957
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/compilerplugins/LICENSE.TXT b/compilerplugins/LICENSE.TXT
index d1adeab308fb..d3bf81a9d1c4 100644
--- a/compilerplugins/LICENSE.TXT
+++ b/compilerplugins/LICENSE.TXT
@@ -1,7 +1,7 @@
 University of Illinois/NCSA
 Open Source License
 
-Copyright (c) 2012-2018 The Document Foundation
+Copyright (c) 2012-2019 The Document Foundation
 All rights reserved.
 
 Developed by:
diff --git a/cui/uiconfig/ui/aboutdialog.ui b/cui/uiconfig/ui/aboutdialog.ui
index ac2746111731..552fd1570185 100644
--- a/cui/uiconfig/ui/aboutdialog.ui
+++ b/cui/uiconfig/ui/aboutdialog.ui
@@ -224,7 +224,7 @@
 12
 12
 True
-Copyright © 2000–2018 LibreOffice 
contributors.
+Copyright © 2000–2019 LibreOffice 
contributors.
 center
 True
   
diff --git a/odk/docs/install.html b/odk/docs/install.html
index be303622580e..266fd7c33b88 100644
--- a/odk/docs/install.html
+++ b/odk/docs/install.html
@@ -527,7 +527,7 @@
 
 
   
-Copyright © 2000–2018 LibreOffice contributors. All rights
+Copyright © 2000–2019 LibreOffice contributors. All rights
   reserved.
   LibreOffice was created by The Document Foundation, based on
   Apache OpenOffice, which is Copyright 2011 The Apache Software
diff --git a/odk/docs/tools.html b/odk/docs/tools.html
index 273b2eb55848..27e2ce62c02f 100644
--- a/odk/docs/tools.html
+++ b/odk/docs/tools.html
@@ -911,7 +911,7 @@ types the specified types depend on.
 
 
 
-Copyright © 2000–2018 LibreOffice contributors. 
All rights reserved.
+Copyright © 2000–2019 LibreOffice contributors. 
All rights reserved.
 
 LibreOffice was created by The Document Foundation,
 based on Apache OpenOffice, which is Copyright 
2011,
diff --git a/odk/examples/DevelopersGuide/examples.html 
b/odk/examples/DevelopersGuide/examples.html
index 7774eac5c550..6f7ea16b30cb 100644
--- a/odk/examples/DevelopersGuide/examples.html
+++ b/odk/examples/DevelopersGuide/examples.html
@@ -2856,7 +2856,7 @@ for the Office application.
 
 
 
-Copyright © 2000–2018 LibreOffice contributors. 
All rights reserved.
+Copyright © 2000–2019 LibreOffice contributors. 
All rights reserved.
 
 LibreOffice was created by The Document Foundation,
 based on Apache OpenOffice, which is Copyright 2011
diff --git a/odk/examples/examples.html b/odk/examples/examples.html
index 4d3a3acff4c9..8dc3b588cf65 100644
--- a/odk/examples/examples.html
+++ b/odk/examples/examples.html
@@ -810,7 +810,7 @@
 
 
 
-Copyright © 2000–2018 LibreOffice contributors. 
All rights reserved.
+ 

[Libreoffice-commits] core.git: sw/qa

[Libreoffice Gerrit user]

 sw/qa/extras/rtfexport/data/ulw.rtf   |1 +
 sw/qa/extras/rtfexport/rtfexport3.cxx |6 ++
 2 files changed, 7 insertions(+)

New commits:
commit 74b30472e845123c93ec83172a458eae99a793a0
Author: Miklos Vajna 
AuthorDate: Mon Jan 7 21:05:37 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 8 09:06:23 2019 +0100

RTF filter: add URW testcase

lcov points out this was uncovered previously.

Change-Id: I831b7e6c2b475d2b3ddd64fb21714c3b6667832a
Reviewed-on: https://gerrit.libreoffice.org/65944
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/rtfexport/data/ulw.rtf 
b/sw/qa/extras/rtfexport/data/ulw.rtf
new file mode 100644
index ..241898e47c17
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/ulw.rtf
@@ -0,0 +1 @@
+{\rtf1\ulw Aaa bbb.\par}
diff --git a/sw/qa/extras/rtfexport/rtfexport3.cxx 
b/sw/qa/extras/rtfexport/rtfexport3.cxx
index 2657c5494061..deb380f7e3de 100644
--- a/sw/qa/extras/rtfexport/rtfexport3.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport3.cxx
@@ -218,6 +218,12 @@ 
DECLARE_RTFEXPORT_TEST(testTdf122424_textOutsideCellInATableRow, "tdf122424.rtf"
 CPPUNIT_ASSERT_EQUAL(OUString("cell3"), xCell->getString());
 }
 
+DECLARE_RTFEXPORT_TEST(testUlw, "ulw.rtf")
+{
+// Test underlying in individual words mode.
+CPPUNIT_ASSERT(getProperty(getRun(getParagraph(1), 1), 
"CharWordMode"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: store/IwyuFilter_store.yaml store/source

[Libreoffice Gerrit user]

 store/IwyuFilter_store.yaml |   17 +
 store/source/lockbyte.cxx   |1 -
 store/source/lockbyte.hxx   |3 ++-
 store/source/object.hxx |1 -
 store/source/storbase.hxx   |5 -
 store/source/storbios.cxx   |2 --
 store/source/storbios.hxx   |4 ++--
 store/source/storcach.cxx   |3 +--
 store/source/storcach.hxx   |5 +++--
 store/source/stordata.hxx   |4 +++-
 store/source/stordir.cxx|2 +-
 store/source/stordir.hxx|2 +-
 store/source/storlckb.cxx   |2 --
 store/source/storlckb.hxx   |4 ++--
 store/source/storpage.cxx   |4 
 store/source/storpage.hxx   |3 ++-
 store/source/stortree.cxx   |1 +
 17 files changed, 35 insertions(+), 28 deletions(-)

New commits:
commit 31c1995037a7ad408a5af6917288d8e3888a472d
Author: Gabor Kelemen 
AuthorDate: Thu Dec 27 19:24:45 2018 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 8 09:06:44 2019 +0100

tdf#42949 Fix IWYU warnings in store/source/*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I99f1611f41378a0baa7688db5a5f78e0169f0d5b
Reviewed-on: https://gerrit.libreoffice.org/65649
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/store/IwyuFilter_store.yaml b/store/IwyuFilter_store.yaml
new file mode 100644
index ..2dadc69a50ac
--- /dev/null
+++ b/store/IwyuFilter_store.yaml
@@ -0,0 +1,17 @@
+---
+assumeFilename: store/source/storbase.cxx
+blacklist:
+store/source/storbase.hxx:
+# Needed for OSL_BIGENDIAN macro
+- osl/endian.h
+store/source/stordir.hxx:
+# Checking other file gives this
+- namespace store { struct OStoreDirectoryPageData; }
+store/source/storlckb.hxx:
+# Checking other file gives this
+- namespace store { struct OStoreDataPageData; }
+- namespace store { struct OStoreDirectoryPageData; }
+store/source/storpage.hxx:
+# Checking other file gives this
+- namespace store { struct OStoreDirectoryPageData; }
+- namespace store { class OStoreDirectoryPageObject; }
diff --git a/store/source/lockbyte.cxx b/store/source/lockbyte.cxx
index 4d21848bfe32..dfc7ad920a99 100644
--- a/store/source/lockbyte.cxx
+++ b/store/source/lockbyte.cxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/store/source/lockbyte.hxx b/store/source/lockbyte.hxx
index a7beb54dd7b9..04634328a922 100644
--- a/store/source/lockbyte.hxx
+++ b/store/source/lockbyte.hxx
@@ -26,13 +26,14 @@
 
 #include 
 
-#include 
 #include 
 #include 
 
 #include 
 #include "storbase.hxx"
 
+namespace rtl { template  class Reference; }
+
 namespace store
 {
 
diff --git a/store/source/object.hxx b/store/source/object.hxx
index 32e54292134f..f19936558ccb 100644
--- a/store/source/object.hxx
+++ b/store/source/object.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_STORE_SOURCE_OBJECT_HXX
 
 #include 
-#include 
 #include 
 
 namespace store
diff --git a/store/source/storbase.hxx b/store/source/storbase.hxx
index accfdf7d73f9..9a630348e58f 100644
--- a/store/source/storbase.hxx
+++ b/store/source/storbase.hxx
@@ -25,7 +25,6 @@
 
 #include 
 
-#include 
 #include 
 #include 
 
@@ -35,8 +34,6 @@
 #include 
 
 #include 
-#include 
-#include 
 #include 
 
 /** @file store common internals.
@@ -518,8 +515,6 @@ public:
 }
 };
 
-class OStorePageBIOS;
-
 class OStorePageObject
 {
 typedef PageData   page;
diff --git a/store/source/storbios.cxx b/store/source/storbios.cxx
index 1edd3feb39e4..b1bac9852938 100644
--- a/store/source/storbios.cxx
+++ b/store/source/storbios.cxx
@@ -22,7 +22,6 @@
 #include "storbios.hxx"
 
 #include 
-#include 
 #include 
 
 #include 
@@ -32,7 +31,6 @@
 #include 
 
 #include 
-#include "object.hxx"
 #include "lockbyte.hxx"
 #include "storcach.hxx"
 
diff --git a/store/source/storbios.hxx b/store/source/storbios.hxx
index 8c2abd54f5a7..6ba09a876e50 100644
--- a/store/source/storbios.hxx
+++ b/store/source/storbios.hxx
@@ -26,13 +26,13 @@
 
 #include 
 #include "object.hxx"
-#include "lockbyte.hxx"
 #include "storbase.hxx"
-#include "storcach.hxx"
 
 namespace store
 {
 
+class ILockBytes;
+class PageCache;
 struct SuperBlockPage;
 
 class OStorePageBIOS : public store::OStoreObject
diff --git a/store/source/storcach.cxx b/store/source/storcach.cxx
index ab89b50eb904..3fdf60ec13a0 100644
--- a/store/source/storcach.cxx
+++ b/store/source/storcach.cxx
@@ -28,11 +28,10 @@
 #include 
 
 #include 
-#include "object.hxx"
 #include "storbase.hxx"
 
 #include 
-#include 
+#include 
 
 using namespace store;
 
diff --git a/store/source/storcach.hxx b/store/source/storcach.hxx
index c2626cbfa3bf..ec7d6d138aa3 100644
--- a/store/source/storcach.hxx
+++ b/store/source/storcach.hxx
@@ -25,12 +25,13 @@
 #include 
 
 #include 
-#include 
 
 #include 
-#include "storbase.hxx"
 #include "object.hxx"
 
+namespace rtl { template  class Reference; }
+namespace store { struct PageData; }
+
 namespace 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/qa sw/source

[Libreoffice Gerrit user]

 sw/qa/extras/uiwriter/uiwriter2.cxx |   52 ++--
 sw/source/core/inc/flyfrm.hxx   |3 ++
 sw/source/core/layout/fly.cxx   |   11 +++
 3 files changed, 64 insertions(+), 2 deletions(-)

New commits:
commit 419ce1399c496e062676b7a8e4f87277f552d3d5
Author: Tamás Zolnai 
AuthorDate: Fri Jan 4 11:23:59 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 8 09:07:21 2019 +0100

Unfloat: Test layout change of unfloat operation

Change-Id: I75298a392de6a10861ac96e1bc58a30173cd2dd2
Reviewed-on: https://gerrit.libreoffice.org/65823
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 
(cherry picked from commit dd0b559d6aac5bf09566af735bd00b28c00fb2e4)
Reviewed-on: https://gerrit.libreoffice.org/65874
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 088d02ca4761..274bec37d0b1 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -18,8 +18,7 @@
 #include 
 #include 
 #include 
-#include 
-#include 
+#include 
 
 namespace
 {
@@ -35,12 +34,14 @@ public:
 void testUnfloatButtonSmallTable();
 void testUnfloatButton();
 void testUnfloatButtonReadOnlyMode();
+void testUnfloating();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest2);
 CPPUNIT_TEST(testTdf101534);
 CPPUNIT_TEST(testUnfloatButtonSmallTable);
 CPPUNIT_TEST(testUnfloatButton);
 CPPUNIT_TEST(testUnfloatButtonReadOnlyMode);
+CPPUNIT_TEST(testUnfloating);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -171,6 +172,53 @@ void SwUiWriterTest2::testUnfloatButtonReadOnlyMode()
 CPPUNIT_ASSERT(!pFlyFrame->IsShowUnfloatButton(pWrtShell));
 }
 
+void SwUiWriterTest2::testUnfloating()
+{
+// Test what happens when pushing the unfloat button
+load(FLOATING_TABLE_DATA_DIRECTORY, "unfloatable_floating_table.odt");
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtShell);
+
+SwFlyFrame* pFlyFrame;
+
+// Before unfloating we have only one page with a fly frame
+{
+CPPUNIT_ASSERT_EQUAL(SwFrameType::Page, 
pWrtShell->GetLayout()->GetLower()->GetType());
+CPPUNIT_ASSERT(!pWrtShell->GetLayout()->GetLower()->GetNext());
+CPPUNIT_ASSERT_EQUAL(SwFrameType::Txt,
+ 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetType());
+const SwSortedObjs* pAnchored
+= 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetDrawObjs();
+CPPUNIT_ASSERT(pAnchored);
+CPPUNIT_ASSERT_EQUAL(static_cast(1), pAnchored->size());
+SwAnchoredObject* pAnchoredObj = (*pAnchored)[0];
+pFlyFrame = dynamic_cast(pAnchoredObj);
+CPPUNIT_ASSERT(pFlyFrame);
+}
+
+// Select the floating table
+SdrObject* pObj = pFlyFrame->GetFormat()->FindRealSdrObject();
+CPPUNIT_ASSERT(pObj);
+pWrtShell->SelectObj(Point(), 0, pObj);
+CPPUNIT_ASSERT(pFlyFrame->IsShowUnfloatButton(pWrtShell));
+
+// Push the unfloat button
+pFlyFrame->ActiveUnfloatButton(pWrtShell);
+
+// After unfloating we have two pages with one tablre frame on each page
+CPPUNIT_ASSERT(pWrtShell->GetLayout()->GetLower()->GetNext());
+CPPUNIT_ASSERT_EQUAL(SwFrameType::Page,
+ 
pWrtShell->GetLayout()->GetLower()->GetNext()->GetType());
+CPPUNIT_ASSERT(!pWrtShell->GetLayout()->GetLower()->GetNext()->GetNext());
+CPPUNIT_ASSERT_EQUAL(SwFrameType::Tab,
+ 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetType());
+CPPUNIT_ASSERT_EQUAL(
+SwFrameType::Tab,
+
pWrtShell->GetLayout()->GetLower()->GetNext()->GetLower()->GetLower()->GetType());
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest2);
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/flyfrm.hxx b/sw/source/core/inc/flyfrm.hxx
index bc9cea59e963..65ba6d636676 100644
--- a/sw/source/core/inc/flyfrm.hxx
+++ b/sw/source/core/inc/flyfrm.hxx
@@ -273,6 +273,9 @@ public:
 void SelectionHasChanged(SwFEShell* pShell);
 bool IsShowUnfloatButton(SwWrtShell* pWrtSh) const;
 
+// For testing only (see uiwriter)
+void ActiveUnfloatButton(SwWrtShell* pWrtSh);
+
 private:
 void UpdateUnfloatButton(SwWrtShell* pWrtSh, bool bShow) const;
 void PaintDecorators() const;
diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx
index 59c825239e60..e19893fb62ce 100644
--- a/sw/source/core/layout/fly.cxx
+++ b/sw/source/core/layout/fly.cxx
@@ -1840,6 +1840,17 @@ bool SwFlyFrame::IsShowUnfloatButton(SwWrtShell* pWrtSh) 
const
 return nBodyHeight < nTableHeight + nFrameOffset;
 }
 
+void SwFlyFrame::ActiveUnfloatButton(SwWrtShell* pWrtSh)
+{
+SwEditWin& rEditWin = 

Re: Problem in running make file on Ubuntu 16.04

[Kaganski Mike]

On 08.01.2019 10:44, Komal Bharadiya wrote:
> I have been trying to setup libreoffice dev-environment lately. After 
> executing ./autogen.sh file, I hit make command. The execution takes 
> ample amount of time. It hangs my laptop, and I end up switching it off. 
> I have tried multiple no. of times. But couldn't run it successfully, 
> what can I do? Please help!
> I have Dell Vostro 3568 model.
> Thanking you in anticipation!

https://wiki.documentfoundation.org/Development/BuildingOnLinux#Performance


> Building LibreOffice takes time, a lot of time. Exactly how much depends on 
> how powerful your machine is

Several lines below, there's "Approximate times" section, telling 
someone's experience with some unspecified repo revision, which took 1.5 
hrs. I can tell you that I used to have ~8 hrs build time on Kaveri 7700 
box with spinning HDD.

You should expect long build times on your laptop. But if you also are 
going to do other tasks on it during the build (to increase build times 
even more), then you may adjust it using --with-parallelism (discussed 
there), which defaults to use all your cores, but which you could want 
to set to a lower value to free some resources; or you may run make 
using nice (`nice make`) to decrease its priority and make system 
responsive to interaction without sacrificing cores.

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: wsd/Admin.cpp wsd/AdminModel.hpp wsd/LOOLWSD.cpp

[Libreoffice Gerrit user]

 wsd/Admin.cpp  |   24 
 wsd/AdminModel.hpp |   19 ++-
 wsd/LOOLWSD.cpp|   16 
 3 files changed, 34 insertions(+), 25 deletions(-)

New commits:
commit d00c6382986249fcc9dc2bc97b2ed59ba151babc
Author: Miklos Vajna 
AuthorDate: Tue Jan 8 09:05:40 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 8 09:05:46 2019 +0100

DocProcSettings: make members private

Which shows that LimitDataMemKb was an unused member, so remove it.

Change-Id: I48c9a5df09b78e5fc267550219d7f4c78a03ec01

diff --git a/wsd/Admin.cpp b/wsd/Admin.cpp
index 7efc46331..8cb2aa389 100644
--- a/wsd/Admin.cpp
+++ b/wsd/Admin.cpp
@@ -183,10 +183,10 @@ void AdminSocketHandler::handleMessage(bool /* fin */, 
WSOpCode /* code */,
 << "net_stats_interval=" << 
std::to_string(_admin->getNetStatsInterval()) << ' ';
 
 const DocProcSettings& docProcSettings = 
_admin->getDefDocProcSettings();
-oss << "limit_virt_mem_mb=" << docProcSettings.LimitVirtMemMb << ' '
-<< "limit_stack_mem_kb=" << docProcSettings.LimitStackMemKb << ' '
-<< "limit_file_size_mb=" << docProcSettings.LimitFileSizeMb << ' '
-<< "limit_num_open_files=" << docProcSettings.LimitNumberOpenFiles 
<< ' ';
+oss << "limit_virt_mem_mb=" << docProcSettings.getLimitVirtMemMb() << 
' '
+<< "limit_stack_mem_kb=" << docProcSettings.getLimitStackMemKb() 
<< ' '
+<< "limit_file_size_mb=" << docProcSettings.getLimitFileSizeMb() 
<< ' '
+<< "limit_num_open_files=" << 
docProcSettings.getLimitNumberOpenFiles() << ' ';
 
 sendTextFrame(oss.str());
 }
@@ -251,13 +251,13 @@ void AdminSocketHandler::handleMessage(bool /* fin */, 
WSOpCode /* code */,
 {
 DocProcSettings docProcSettings = 
_admin->getDefDocProcSettings();
 if (settingName == "limit_virt_mem_mb")
-docProcSettings.LimitVirtMemMb = settingVal;
+docProcSettings.setLimitVirtMemMb(settingVal);
 else if (settingName == "limit_stack_mem_kb")
-docProcSettings.LimitStackMemKb = settingVal;
+docProcSettings.setLimitStackMemKb(settingVal);
 else if (settingName == "limit_file_size_mb")
-docProcSettings.LimitFileSizeMb = settingVal;
+docProcSettings.setLimitFileSizeMb(settingVal);
 else if (settingName == "limit_num_open_files")
-docProcSettings.LimitNumberOpenFiles = settingVal;
+docProcSettings.setLimitNumberOpenFiles(settingVal);
 else
 LOG_ERR("Unknown limit: " << settingName);
 
@@ -572,10 +572,10 @@ void Admin::addBytes(const std::string& docKey, uint64_t 
sent, uint64_t recv)
 void Admin::notifyForkit()
 {
 std::ostringstream oss;
-oss << "setconfig limit_virt_mem_mb " << 
_defDocProcSettings.LimitVirtMemMb << '\n'
-<< "setconfig limit_stack_mem_kb " << 
_defDocProcSettings.LimitStackMemKb << '\n'
-<< "setconfig limit_file_size_mb " << 
_defDocProcSettings.LimitFileSizeMb << '\n'
-<< "setconfig limit_num_open_files " << 
_defDocProcSettings.LimitNumberOpenFiles << '\n';
+oss << "setconfig limit_virt_mem_mb " << 
_defDocProcSettings.getLimitVirtMemMb() << '\n'
+<< "setconfig limit_stack_mem_kb " << 
_defDocProcSettings.getLimitStackMemKb() << '\n'
+<< "setconfig limit_file_size_mb " << 
_defDocProcSettings.getLimitFileSizeMb() << '\n'
+<< "setconfig limit_num_open_files " << 
_defDocProcSettings.getLimitNumberOpenFiles() << '\n';
 
 if (_forKitWritePipe != -1)
 IoUtil::writeToPipe(_forKitWritePipe, oss.str());
diff --git a/wsd/AdminModel.hpp b/wsd/AdminModel.hpp
index 86c68df33..2b69f900b 100644
--- a/wsd/AdminModel.hpp
+++ b/wsd/AdminModel.hpp
@@ -48,11 +48,20 @@ private:
 
 struct DocProcSettings
 {
-size_t LimitVirtMemMb;
-size_t LimitDataMemKb;
-size_t LimitStackMemKb;
-size_t LimitFileSizeMb;
-size_t LimitNumberOpenFiles;
+void setLimitVirtMemMb(size_t limitVirtMemMb) { _limitVirtMemMb = 
limitVirtMemMb; }
+size_t getLimitVirtMemMb() const { return _limitVirtMemMb; }
+void setLimitStackMemKb(size_t limitStackMemKb) { _limitStackMemKb = 
limitStackMemKb; }
+size_t getLimitStackMemKb() const { return _limitStackMemKb; }
+void setLimitFileSizeMb(size_t limitFileSizeMb) { _limitFileSizeMb = 
limitFileSizeMb; }
+size_t getLimitFileSizeMb() const { return _limitFileSizeMb; }
+void setLimitNumberOpenFiles(size_t limitNumberOpenFiles) { 
_limitNumberOpenFiles = limitNumberOpenFiles; }
+size_t getLimitNumberOpenFiles() const { return _limitNumberOpenFiles; }
+
+private:
+size_t _limitVirtMemMb;
+size_t _limitStackMemKb;
+size_t _limitFileSizeMb;
+size_t _limitNumberOpenFiles;
 };
 
 /// Containing basic information 

Re: Building LibreOffice on MacOS mojave

[Tor Lillqvist]

I wonder if we should finally turn Java into opt-in instead of opt-out?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - officecfg/registry

[Libreoffice Gerrit user]

 officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4da3eeca4e0ff313a4b84493d5dd541a420a57aa
Author: Matthias Seidel 
AuthorDate: Tue Jan 8 15:11:33 2019 +
Commit: Matthias Seidel 
CommitDate: Tue Jan 8 15:11:33 2019 +

Fixed typo (0.5 -> Zoom 50%)

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu
index 4096726c5ffe..1021abbc0588 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu
@@ -172,7 +172,7 @@
 
 
 
-0.5
+Zoom 50%
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Libreoffice Gerrit user]

 svx/source/dialog/dialcontrol.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit c83011038db6b9a61cb053395f33f4ed6cb53494
Author: Andrea Gelmini 
AuthorDate: Mon Jan 7 10:52:15 2019 +
Commit: Julien Nabet 
CommitDate: Wed Jan 9 08:34:30 2019 +0100

Removed duplicated include

Change-Id: Iea1d992fb7b7e0d60ee3432a20b74cb8d312fc08
Reviewed-on: https://gerrit.libreoffice.org/65991
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/source/dialog/dialcontrol.cxx 
b/svx/source/dialog/dialcontrol.cxx
index 95c68ce17ccd..72c7aec62853 100644
--- a/svx/source/dialog/dialcontrol.cxx
+++ b/svx/source/dialog/dialcontrol.cxx
@@ -28,7 +28,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 namespace svx {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/qa

[Libreoffice Gerrit user]

 xmlsecurity/qa/unit/signing/signing.cxx |  167 +---
 1 file changed, 48 insertions(+), 119 deletions(-)

New commits:
commit b4cd1acc00a4a0cdbcd350b4441156ea22a965c5
Author: Miklos Vajna 
AuthorDate: Tue Jan 8 21:23:10 2019 +0100
Commit: Miklos Vajna 
CommitDate: Wed Jan 9 08:40:45 2019 +0100

CppunitTest_xmlsecurity_signing: use CPPUNIT_TEST_FIXTURE()

Change-Id: I3e6c7f5af6edb1c7ae4867aa46f56fec695e5bcf
Reviewed-on: https://gerrit.libreoffice.org/65984
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/xmlsecurity/qa/unit/signing/signing.cxx 
b/xmlsecurity/qa/unit/signing/signing.cxx
index d9507982486b..604d006b82d1 100644
--- a/xmlsecurity/qa/unit/signing/signing.cxx
+++ b/xmlsecurity/qa/unit/signing/signing.cxx
@@ -55,6 +55,7 @@ char const DATA_DIRECTORY[] = 
"/xmlsecurity/qa/unit/signing/data/";
 /// Testsuite for the document signing feature.
 class SigningTest : public test::BootstrapFixture, public unotest::MacrosTest, 
public XmlTestTools
 {
+protected:
 uno::Reference mxComponentContext;
 uno::Reference mxComponent;
 uno::Reference mxSEInitializer;
@@ -70,96 +71,7 @@ public:
 virtual void tearDown() override;
 void registerNamespaces(xmlXPathContextPtr& pXmlXpathCtx) override;
 
-void testDescription();
-void testECDSA();
-void testECDSAOOXML();
-void testECDSAPDF();
-/// Test a typical ODF where all streams are signed.
-void testODFGood();
-/// Test a typical broken ODF signature where one stream is corrupted.
-void testODFBroken();
-/// Document has a signature stream, but no actual signatures.
-void testODFNo();
-/// Test a typical OOXML where a number of (but not all) streams are 
signed.
-void testOOXMLPartial();
-/// Test a typical broken OOXML signature where one stream is corrupted.
-void testOOXMLBroken();
-void testOOXMLDescription();
-/// Test appending a new signature next to an existing one.
-void testOOXMLAppend();
-/// Test removing a signature from existing ones.
-void testOOXMLRemove();
-/// Test removing all signatures from a document.
-void testOOXMLRemoveAll();
-#if HAVE_FEATURE_PDFIMPORT
-/// Test a typical PDF where the signature is good.
-void testPDFGood();
-/// Test a typical PDF where the signature is bad.
-void testPDFBad();
-/// Test a typical PDF which is not signed.
-void testPDFNo();
-#endif
-void test96097Calc();
-void test96097Doc();
-/// Creates a XAdES signature from scratch.
-void testXAdES();
-/// Works with an existing good XAdES signature.
-void testXAdESGood();
-/// Test importing of signature line
-void testSignatureLineOOXML();
-void testSignatureLineODF();
-#if HAVE_FEATURE_GPGVERIFY
-/// Test a typical ODF where all streams are GPG-signed.
-void testODFGoodGPG();
-/// Test a typical ODF where all streams are GPG-signed, but we don't 
trust the signature.
-void testODFUntrustedGoodGPG();
-/// Test a typical broken ODF signature where one stream is corrupted.
-void testODFBrokenStreamGPG();
-/// Test a typical broken ODF signature where the XML dsig hash is 
corrupted.
-void testODFBrokenDsigGPG();
-#if HAVE_GPGCONF_SOCKETDIR
-/// Test loading an encrypted ODF document
-void testODFEncryptedGPG();
-#endif
-#endif
-CPPUNIT_TEST_SUITE(SigningTest);
-CPPUNIT_TEST(testDescription);
-CPPUNIT_TEST(testECDSA);
-CPPUNIT_TEST(testECDSAOOXML);
-CPPUNIT_TEST(testECDSAPDF);
-CPPUNIT_TEST(testODFGood);
-CPPUNIT_TEST(testODFBroken);
-CPPUNIT_TEST(testODFNo);
-CPPUNIT_TEST(testODFBroken);
-CPPUNIT_TEST(testOOXMLPartial);
-CPPUNIT_TEST(testOOXMLBroken);
-CPPUNIT_TEST(testOOXMLDescription);
-CPPUNIT_TEST(testOOXMLAppend);
-CPPUNIT_TEST(testOOXMLRemove);
-CPPUNIT_TEST(testOOXMLRemoveAll);
-#if HAVE_FEATURE_PDFIMPORT
-CPPUNIT_TEST(testPDFGood);
-CPPUNIT_TEST(testPDFBad);
-CPPUNIT_TEST(testPDFNo);
-#endif
-CPPUNIT_TEST(test96097Calc);
-CPPUNIT_TEST(test96097Doc);
-CPPUNIT_TEST(testXAdES);
-CPPUNIT_TEST(testXAdESGood);
-CPPUNIT_TEST(testSignatureLineOOXML);
-CPPUNIT_TEST(testSignatureLineODF);
-#if HAVE_FEATURE_GPGVERIFY
-CPPUNIT_TEST(testODFGoodGPG);
-CPPUNIT_TEST(testODFUntrustedGoodGPG);
-CPPUNIT_TEST(testODFBrokenStreamGPG);
-CPPUNIT_TEST(testODFBrokenDsigGPG);
-#if HAVE_GPGCONF_SOCKETDIR
-CPPUNIT_TEST(testODFEncryptedGPG);
-#endif
-#endif
-CPPUNIT_TEST_SUITE_END();
-
-private:
+protected:
 void createDoc(const OUString& rURL);
 void createCalc(const OUString& rURL);
 uno::Reference
@@ -278,7 +190,7 @@ SigningTest::getCertificate(DocumentSignatureManager& 
rSignatureManager,
 return uno::Reference();
 }
 
-void SigningTest::testDescription()
+CPPUNIT_TEST_FIXTURE(SigningTest, testDescription)
 {
 // Create an empty document and store it to a tempfile, finally load 

[Libreoffice-commits] core.git: include/salhelper salhelper/IwyuFilter_salhelper.yaml salhelper/qa salhelper/source

[Libreoffice Gerrit user]

 include/salhelper/condition.hxx |3 ---
 salhelper/IwyuFilter_salhelper.yaml |2 ++
 salhelper/qa/test_api.cxx   |8 
 salhelper/source/dynload.cxx|1 -
 salhelper/source/timer.cxx  |1 -
 5 files changed, 2 insertions(+), 13 deletions(-)

New commits:
commit 54515a6a01a372729bf8a7f9e992c51f214ec9a6
Author: Gabor Kelemen 
AuthorDate: Wed Dec 26 16:58:46 2018 +0100
Commit: Miklos Vajna 
CommitDate: Wed Jan 9 08:41:50 2019 +0100

tdf#42949 Fix IWYU warnings in salhelper/

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and only for files that are actually compiling

Change-Id: I70357eade9552984fdb3b7590f1e8237a02a7d1d
Reviewed-on: https://gerrit.libreoffice.org/65650
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/salhelper/condition.hxx b/include/salhelper/condition.hxx
index 06cadec852f3..0f936d4e5b40 100644
--- a/include/salhelper/condition.hxx
+++ b/include/salhelper/condition.hxx
@@ -29,9 +29,6 @@ namespace osl { class Mutex; }
 
 namespace salhelper
 {
-class ConditionModifier;
-class ConditionWaiter;
-
 
 class SALHELPER_DLLPUBLIC Condition
 {
diff --git a/salhelper/IwyuFilter_salhelper.yaml 
b/salhelper/IwyuFilter_salhelper.yaml
new file mode 100644
index ..f017243be88c
--- /dev/null
+++ b/salhelper/IwyuFilter_salhelper.yaml
@@ -0,0 +1,2 @@
+---
+assumeFilename: salhelper/source/dynload.cxx
diff --git a/salhelper/qa/test_api.cxx b/salhelper/qa/test_api.cxx
index 2e276860037c..dd45f4c730f2 100644
--- a/salhelper/qa/test_api.cxx
+++ b/salhelper/qa/test_api.cxx
@@ -30,14 +30,6 @@
 #include 
 #include 
 
-namespace salhelper {
-class Condition;
-class ConditionModifier;
-class ConditionWaiter;
-class ORealDynamicLoader;
-class SimpleReferenceObject;
-}
-
 namespace {
 
 std::type_info const & getConditionTypeInfo()
diff --git a/salhelper/source/dynload.cxx b/salhelper/source/dynload.cxx
index 63e3201f3ae7..d3b8e70fb292 100644
--- a/salhelper/source/dynload.cxx
+++ b/salhelper/source/dynload.cxx
@@ -18,7 +18,6 @@
  */
 
 #include 
-#include 
 
 namespace salhelper
 {
diff --git a/salhelper/source/timer.cxx b/salhelper/source/timer.cxx
index b4e2dba961ee..8101b23875fb 100644
--- a/salhelper/source/timer.cxx
+++ b/salhelper/source/timer.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 #include 
-#include 
 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/Admin.cpp wsd/Admin.hpp

[Libreoffice Gerrit user]

 wsd/Admin.cpp |8 
 wsd/Admin.hpp |   10 +-
 2 files changed, 13 insertions(+), 5 deletions(-)

New commits:
commit 8244726d3970db0d2b868c9c37179a3243bb6bc8
Author: Miklos Vajna 
AuthorDate: Wed Jan 9 08:45:46 2019 +0100
Commit: Miklos Vajna 
CommitDate: Wed Jan 9 08:45:53 2019 +0100

MonitorConnectRecord: make members private

Change-Id: I485ed48bca0e5c2c0be15f44f553fc48651c59c9

diff --git a/wsd/Admin.cpp b/wsd/Admin.cpp
index 8cb2aa389..650429af4 100644
--- a/wsd/Admin.cpp
+++ b/wsd/Admin.cpp
@@ -451,10 +451,10 @@ void Admin::pollingThread()
 if (_pendingConnects.size())
 {
 MonitorConnectRecord rec = _pendingConnects[0];
-if (rec._when < now)
+if (rec.getWhen() < now)
 {
 _pendingConnects.erase(_pendingConnects.begin());
-connectToMonitorSync(rec._uri);
+connectToMonitorSync(rec.getUri());
 }
 }
 
@@ -688,8 +688,8 @@ void Admin::scheduleMonitorConnect(const std::string , 
std::chrono::steady_c
 assertCorrectThread();
 
 MonitorConnectRecord todo;
-todo._when = when;
-todo._uri = uri;
+todo.setWhen(when);
+todo.setUri(uri);
 _pendingConnects.push_back(todo);
 }
 
diff --git a/wsd/Admin.hpp b/wsd/Admin.hpp
index eb2f97c79..d818a6cea 100644
--- a/wsd/Admin.hpp
+++ b/wsd/Admin.hpp
@@ -155,7 +155,15 @@ private:
 size_t _totalSysMemKb;
 size_t _totalAvailMemKb;
 
-struct MonitorConnectRecord {
+struct MonitorConnectRecord
+{
+void setWhen(std::chrono::steady_clock::time_point when) { _when = 
when; }
+std::chrono::steady_clock::time_point getWhen() const { return _when; }
+
+void setUri(const std::string& uri) { _uri = uri; }
+std::string getUri() const { return _uri; }
+
+protected:
 std::chrono::steady_clock::time_point _when;
 std::string _uri;
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: HTML import filter very (too) basic

[Tor Lillqvist]

In *my* honest opinion, we should just remove such features that work badly
and nobody is interested in fixing. It is much worse to pretend to have
some feature, but whenever somebody actually tries to use it, they notice
that it doesn't work.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: configure.ac

[Libreoffice Gerrit user]

 configure.ac |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 4691d2b18a1e20e286672083eb9a57443c6f8ce3
Author: Samuel Mehrbrodt 
AuthorDate: Tue Jan 8 18:49:12 2019 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Tue Jan 8 18:49:12 2019 +0100

Add some messages whether we are building with support key

Change-Id: If41767c549e9e46b7f0a6f23fa5d819a946f9bdb

diff --git a/configure.ac b/configure.ac
index f8b12322d..d5e3c1726 100644
--- a/configure.ac
+++ b/configure.ac
@@ -474,6 +474,7 @@ AC_CHECK_HEADERS([security/pam_appl.h],
  [AC_MSG_ERROR([header security/pam_appl.h not found, install 
PAM development package])])
 AC_CHECK_LIB(pam, pam_start, [], [AC_MSG_ERROR([No. Install PAM development 
package])])
 
+AC_MSG_CHECKING([whether to build with support public key])
 if test "x$with_support_public_key" != "x"; then
 AC_DEFINE([ENABLE_SUPPORT_KEY],1,[Whether to enable support key])
 
@@ -481,9 +482,11 @@ if test "x$with_support_public_key" != "x"; then
 echo -e "#ifndef INCLUDED_SUPPORT_PUBLIC_KEY_HPP\n#define 
INCLUDED_SUPPORT_PUBLIC_KEY_HPP\n#include \nconst static std::string 
SUPPORT_PUBLIC_KEY(" > "${srcdir}/common/support-public-key.hpp"
 sed 's/\(.*\)/"\1\\n"/' "$with_support_public_key" >> 
"${srcdir}/common/support-public-key.hpp"
 echo -e ");\n#endif" >> "${srcdir}/common/support-public-key.hpp"
+AC_MSG_RESULT([yes])
 else
 AC_DEFINE([ENABLE_SUPPORT_KEY],0,[Whether to enable support key])
 rm -f "${srcdir}/common/support-public-key.hpp"
+AC_MSG_RESULT([no])
 fi
 AC_SUBST(ENABLE_SUPPORT_KEY)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: qa/createBlogReport.py

[Libreoffice Gerrit user]

 qa/createBlogReport.py |   79 ++---
 1 file changed, 69 insertions(+), 10 deletions(-)

New commits:
commit 10e555befacf5c4eda6a039322baf2d845b24bfb
Author: Xisco Fauli 
AuthorDate: Tue Jan 8 12:50:26 2019 +0100
Commit: Xisco Fauli 
CommitDate: Tue Jan 8 12:54:36 2019 +0100

QA: Add chart for bibisectRequest

and try to make results more accurate.
I can't find a general case that works for all charts but at least
the results are pretty close now

diff --git a/qa/createBlogReport.py b/qa/createBlogReport.py
index 8889dc0..afe9dcc 100755
--- a/qa/createBlogReport.py
+++ b/qa/createBlogReport.py
@@ -15,7 +15,7 @@ import math
 import matplotlib
 import matplotlib.pyplot as plt
 
-lKeywords = ['haveBacktrace', 'regression', 'bisected']
+lKeywords = ['havebacktrace', 'regression', 'bisected']
 
 
 def util_create_basic_schema():
@@ -38,6 +38,7 @@ def util_create_statList():
 'people' : {},
 'unconfirmedCount' : {},
 'regressionCount' : {},
+'bibisectRequestCount' : {},
 'highestCount' : {},
 'highCount' : {},
 'stat': {'oldest': datetime.now(), 'newest': datetime(2001, 1, 1)}
@@ -80,9 +81,11 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 
 unconfirmedCountPerDay = {}
 regressionsCountPerDay = {}
+bibisectRequestCountPerDay = {}
 highestCountPerDay = {}
 highCountPerDay = {}
 fixedBugs = {}
+
 for key, row in bugzillaData['bugs'].items():
 rowId = row['id']
 
@@ -123,10 +126,13 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 authorVerified = None
 isRegression = False
 isRegressionClosed = False
+isBibisectRequest = False
+isBibisectRequestClosed = False
 isHighest = False
 isHighestClosed = False
 isHigh = False
 isHighClosed = False
+isThisBugClosed = False
 
 for action in row['history']:
 actionMail = action['who']
@@ -143,7 +149,9 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 addedPriority = change['added']
 removedPriority = change['removed']
 
-if not isHighestClosed:
+# Sometimes the priority is increased to highest 
after the bug is fixed
+# Ignore those cases
+if not isThisBugClosed and not isHighestClosed:
 if not isHighest and addedPriority == 
"highest":
 strDay = actionDate.strftime("%Y-%m-%d")
 if strDay not in highestCountPerDay:
@@ -158,6 +166,7 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 highestCountPerDay[strDay] -= 1
 isHighest = False
 
+# TODO: IsThisBugClosed should be check here, but 
the result is not accurate
 if not isHighClosed:
 if not isHigh and addedPriority == "high":
 strDay = actionDate.strftime("%Y-%m-%d")
@@ -177,6 +186,11 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 addedStatus = change['added']
 removedStatus = change['removed']
 
+if common.isOpen(addedStatus):
+isThisBugClosed = False
+else:
+isThisBugClosed = True
+
 #See above
 if rowId >= 89589:
 if removedStatus == "UNCONFIRMED":
@@ -193,7 +207,7 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 
 if isRegression:
 # the regression is being reopened
-if isRegressionClosed and 
common.isOpen(addedStatus):
+if isRegressionClosed and not isThisBugClosed:
 strDay = actionDate.strftime("%Y-%m-%d")
 if strDay not in regressionsCountPerDay:
 regressionsCountPerDay[strDay] = 0
@@ -201,16 +215,33 @@ def analyze_bugzilla_data(statList, bugzillaData, cfg):
 isRegressionClosed = False
 
 # the regression is being closed
-if not isRegressionClosed and 
common.isClosed(addedStatus):
+if not isRegressionClosed and isThisBugClosed:
 strDay = actionDate.strftime("%Y-%m-%d")
 if strDay not in 

Re: Problem in running make file on Ubuntu 16.04

[Komal Bharadiya]

Thanks, I'll check it out.

On Jan 8, 2019 1:44 PM, "Kaganski Mike"  wrote:

> On 08.01.2019 10:44, Komal Bharadiya wrote:
> > I have been trying to setup libreoffice dev-environment lately. After
> > executing ./autogen.sh file, I hit make command. The execution takes
> > ample amount of time. It hangs my laptop, and I end up switching it off.
> > I have tried multiple no. of times. But couldn't run it successfully,
> > what can I do? Please help!
> > I have Dell Vostro 3568 model.
> > Thanking you in anticipation!
>
> https://wiki.documentfoundation.org/Development/BuildingOnLinux#
> Performance
>
>
> > Building LibreOffice takes time, a lot of time. Exactly how much depends
> on how powerful your machine is
>
> Several lines below, there's "Approximate times" section, telling
> someone's experience with some unspecified repo revision, which took 1.5
> hrs. I can tell you that I used to have ~8 hrs build time on Kaveri 7700
> box with spinning HDD.
>
> You should expect long build times on your laptop. But if you also are
> going to do other tasks on it during the build (to increase build times
> even more), then you may adjust it using --with-parallelism (discussed
> there), which defaults to use all your cores, but which you could want
> to set to a lower value to free some resources; or you may run make
> using nice (`nice make`) to decrease its priority and make system
> responsive to interaction without sacrificing cores.
>
> --
> Best regards,
> Mike Kaganski
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: compilerplugins/clang include/sfx2 sfx2/source

[Libreoffice Gerrit user]

 compilerplugins/clang/constantparam.booleans.results |  466 ++-
 compilerplugins/clang/constantparam.constructors.results |   60 -
 compilerplugins/clang/constantparam.numbers.results  |  228 +++
 include/sfx2/tabdlg.hxx  |2 
 sfx2/source/dialog/tabdlg.cxx|   12 
 5 files changed, 360 insertions(+), 408 deletions(-)

New commits:
commit 7a26512fdbef282e77028f0f318faf72b11190ee
Author: Noel Grandin 
AuthorDate: Tue Jan 8 08:36:57 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 8 10:05:45 2019 +0100

loplugin:constantparam

Change-Id: Id5c7e66b8f8bc324f097dd739ce683d74fc6491b
Reviewed-on: https://gerrit.libreoffice.org/65953
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/constantparam.booleans.results 
b/compilerplugins/clang/constantparam.booleans.results
index c4db1d1680e2..91337c449487 100644
--- a/compilerplugins/clang/constantparam.booleans.results
+++ b/compilerplugins/clang/constantparam.booleans.results
@@ -6,16 +6,12 @@ accessibility/source/standard/vclxaccessibletoolbox.cxx:98
 void (anonymous 
namespace)::OToolBoxWindowItem::OToolBoxWindowItem(int,const class 
com::sun::star::uno::Reference 
&,const class com::sun::star::uno::Reference &,const class 
com::sun::star::uno::Reference &)
 int _nIndexInParent
 0
-basctl/source/basicide/macrodlg.hxx:92
-void basctl::MacroChooser::MacroChooser(class weld::Window *,const class 
com::sun::star::uno::Reference &,_Bool)
-_Bool bCreateEntries
-1
 basctl/source/basicide/moduldlg.hxx:157
 void basctl::LibDialog::EnableReference(_Bool)
 _Bool b
 0
 basctl/source/basicide/moduldlg.hxx:254
-class SbModule * createModImpl(class weld::Window *,const class 
basctl::ScriptDocument &,class basctl::TreeListBox &,const class rtl::OUString 
&,const class rtl::OUString &,_Bool)
+class SbModule * createModImpl(class weld::Window *,const class 
basctl::ScriptDocument &,class basctl::TreeListBox &,const class rtl::OUString 
&,_Bool)
 _Bool bMain
 1
 basctl/source/inc/scriptdocument.hxx:89
@@ -54,7 +50,7 @@ chart2/qa/extras/chart2dump/chart2dump.cxx:99
 void Chart2DumpTest::Chart2DumpTest(_Bool)
 _Bool bDumpMode
 0
-chart2/qa/extras/chart2export.cxx:319
+chart2/qa/extras/chart2export.cxx:321
 void checkCommonTrendline(const class com::sun::star::uno::Reference 
&,double,double,_Bool,double,_Bool,_Bool)
 _Bool aExpectedShowEquation
 1
@@ -110,15 +106,15 @@ 
chart2/source/controller/dialogs/ChartTypeDialogController.hxx:54
 void chart::ChartTypeParameter::ChartTypeParameter(int,_Bool,_Bool,enum 
chart::GlobalStackMode,_Bool,_Bool,enum com::sun::star::chart2::CurveStyle)
 enum com::sun::star::chart2::CurveStyle eCurveStyle
 0
-chart2/source/controller/dialogs/DialogModel.cxx:175
+chart2/source/controller/dialogs/DialogModel.cxx:171
 struct (anonymous namespace)::lcl_DataSeriesContainerAppend & (anonymous 
namespace)::lcl_DataSeriesContainerAppend::operator++(int)
 int 
 0
-chart2/source/controller/dialogs/DialogModel.cxx:234
+chart2/source/controller/dialogs/DialogModel.cxx:230
 struct (anonymous namespace)::lcl_RolesWithRangeAppend & (anonymous 
namespace)::lcl_RolesWithRangeAppend::operator++(int)
 int 
 0
-chart2/source/controller/inc/ChartController.hxx:368
+chart2/source/controller/inc/ChartController.hxx:367
 class chart::ChartController::TheModelRef & 
chart::ChartController::TheModelRef::operator=(class 
chart::ChartController::TheModel *)
  ###1
 0
@@ -258,19 +254,19 @@ cui/source/options/optjsearch.hxx:65
 void SvxJSearchOptionsPage::EnableSaveOptions(_Bool)
 _Bool bVal
 0
-dbaccess/source/core/dataaccess/databasedocument.hxx:673
+dbaccess/source/core/dataaccess/databasedocument.hxx:674
 void dbaccess::DocumentGuard::DocumentGuard(const class 
dbaccess::ODatabaseDocument &,enum dbaccess::DocumentGuard::DefaultMethod_)
 enum dbaccess::DocumentGuard::DefaultMethod_ 
 0
-dbaccess/source/core/dataaccess/databasedocument.hxx:691
+dbaccess/source/core/dataaccess/databasedocument.hxx:692
 void dbaccess::DocumentGuard::DocumentGuard(const class 
dbaccess::ODatabaseDocument &,enum dbaccess::DocumentGuard::InitMethod_)
 enum dbaccess::DocumentGuard::InitMethod_ 
 0
-dbaccess/source/core/dataaccess/databasedocument.hxx:710
+dbaccess/source/core/dataaccess/databasedocument.hxx:711
 void dbaccess::DocumentGuard::DocumentGuard(const class 
dbaccess::ODatabaseDocument &,enum 
dbaccess::DocumentGuard::MethodUsedDuringInit_)
 enum dbaccess::DocumentGuard::MethodUsedDuringInit_ 
 0
-dbaccess/source/core/dataaccess/databasedocument.hxx:725
+dbaccess/source/core/dataaccess/databasedocument.hxx:726
 void dbaccess::DocumentGuard::DocumentGuard(const class 
dbaccess::ODatabaseDocument &,enum dbaccess::DocumentGuard::MethodWithoutInit_)
 enum 

[Libreoffice-commits] core.git: sd/source

[Libreoffice Gerrit user]

 sd/source/ui/remotecontrol/BluetoothServer.cxx |   11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 638be04c8334e5e29f9258ff870fbe63603ce7e0
Author: Noel Grandin 
AuthorDate: Tue Jan 8 09:27:11 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 8 10:18:14 2019 +0100

use unique_ptr in sd::BluetoothServer::Impl

Change-Id: I54bd8fbac488182d2017e90b7afced2659f01728
Reviewed-on: https://gerrit.libreoffice.org/65955
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sd/source/ui/remotecontrol/BluetoothServer.cxx 
b/sd/source/ui/remotecontrol/BluetoothServer.cxx
index f614af007e78..170a2f08396d 100644
--- a/sd/source/ui/remotecontrol/BluetoothServer.cxx
+++ b/sd/source/ui/remotecontrol/BluetoothServer.cxx
@@ -90,14 +90,13 @@ struct sd::BluetoothServer::Impl {
 // the glib mainloop running in the thread
 GMainContext *mpContext;
 DBusConnection *mpConnection;
-DBusObject *mpService;
+std::unique_ptr mpService;
 enum class BluezVersion { BLUEZ4, BLUEZ5, UNKNOWN };
 BluezVersion maBluezVersion;
 
 Impl()
 : mpContext( g_main_context_new() )
 , mpConnection( nullptr )
-, mpService( nullptr )
 , maBluezVersion( BluezVersion::UNKNOWN )
 { }
 
@@ -853,17 +852,15 @@ setDiscoverable( DBusConnection *pConnection, DBusObject 
*pAdapter, bool bDiscov
 }
 }
 
-static DBusObject *
+static std::unique_ptr
 registerWithDefaultAdapter( DBusConnection *pConnection )
 {
-DBusObject *pService;
-pService = bluez4GetDefaultService( pConnection );
+std::unique_ptr pService(bluez4GetDefaultService( pConnection 
));
 if( pService )
 {
-if( !bluez4RegisterServiceRecord( pConnection, pService,
+if( !bluez4RegisterServiceRecord( pConnection, pService.get(),
  bluetooth_service_record ) )
 {
-delete pService;
 return nullptr;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

[Libreoffice Gerrit user]

 sc/inc/xmlwrap.hxx|2 +-
 sc/source/filter/xml/xmlexprt.cxx |6 --
 sc/source/filter/xml/xmlexprt.hxx |7 ---
 sc/source/filter/xml/xmlwrap.cxx  |   10 +-
 4 files changed, 14 insertions(+), 11 deletions(-)

New commits:
commit c2d59ec2832c8b51568e73e9314ab9c82f1f5b7b
Author: Noel Grandin 
AuthorDate: Tue Jan 8 10:32:01 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 8 11:16:37 2019 +0100

use unique_ptr in ScXMLImportWrapper

Change-Id: I98e29a832509f4ea0453f92ccd6fb274e39b5afc
Reviewed-on: https://gerrit.libreoffice.org/65956
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/xmlwrap.hxx b/sc/inc/xmlwrap.hxx
index caa351515273..b03a6c249797 100644
--- a/sc/inc/xmlwrap.hxx
+++ b/sc/inc/xmlwrap.hxx
@@ -79,7 +79,7 @@ class ScXMLImportWrapper
 const css::uno::Sequence& aDescriptor,
 const OUString& sName, const OUString& sMediaType, const OUString& 
sComponentName,
 const css::uno::Sequence& aArgs,
-ScMySharedData*& pSharedData);
+std::unique_ptr& pSharedData);
 
 public:
 
diff --git a/sc/source/filter/xml/xmlexprt.cxx 
b/sc/source/filter/xml/xmlexprt.cxx
index fc61bd6c8487..d3d882d8c4d1 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -343,7 +343,6 @@ ScXMLExport::ScXMLExport(
 rContext, implementationName, XML_SPREADSHEET, nExportFlag ),
 pDoc(nullptr),
 nSourceStreamPos(0),
-pSharedData(nullptr),
 aTableStyles(),
 pCurrentCell(nullptr),
 nOpenRow(-1),
@@ -489,7 +488,7 @@ void ScXMLExport::CollectSharedData(SCTAB& nTableCount, 
sal_Int32& nShapesCount)
 
 nTableCount = xIndex->getCount();
 if (!pSharedData)
-pSharedData = new ScMySharedData(nTableCount);
+pSharedData.reset(new ScMySharedData(nTableCount));
 
 pCellStyles->AddNewTable(nTableCount - 1);
 
@@ -5417,4 +5416,7 @@ void ScXMLExport::DisposingModel()
 xCurrentTable = nullptr;
 }
 
+void ScXMLExport::SetSharedData(std::unique_ptr pTemp) { 
pSharedData = std::move(pTemp); }
+
+std::unique_ptr ScXMLExport::ReleaseSharedData() { return 
std::move(pSharedData); }
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/filter/xml/xmlexprt.hxx 
b/sc/source/filter/xml/xmlexprt.hxx
index 560177ab46f3..3a97a7d07e70 100644
--- a/sc/source/filter/xml/xmlexprt.hxx
+++ b/sc/source/filter/xml/xmlexprt.hxx
@@ -94,7 +94,7 @@ class ScXMLExport : public SvXMLExport
 std::unique_ptr 
pNumberFormatAttributesExportHelper;
 typedef std::unordered_map  NumberFormatIndexMap;
 NumberFormatIndexMapaNumFmtIndexMap;
-ScMySharedData* pSharedData;
+std::unique_ptr pSharedData;
 std::unique_ptr pColumnStyles;
 std::unique_ptrpRowStyles;
 std::unique_ptrpCellStyles;
@@ -253,8 +253,9 @@ public:
 
 virtual void exportAnnotationMeta( const css::uno::Reference < 
css::drawing::XShape >& xShape) override;
 
-void SetSharedData(ScMySharedData* pTemp) { pSharedData = pTemp; }
-ScMySharedData* GetSharedData() { return pSharedData; }
+void SetSharedData(std::unique_ptr pTemp);
+ScMySharedData* GetSharedData() { return pSharedData.get(); }
+std::unique_ptr ReleaseSharedData();
 XMLNumberFormatAttributesExportHelper* 
GetNumberFormatAttributesExportHelper();
 
 // Export the document.
diff --git a/sc/source/filter/xml/xmlwrap.cxx b/sc/source/filter/xml/xmlwrap.cxx
index a81f7fb6475e..36f6b7f1cf1e 100644
--- a/sc/source/filter/xml/xmlwrap.cxx
+++ b/sc/source/filter/xml/xmlwrap.cxx
@@ -614,7 +614,7 @@ bool ScXMLImportWrapper::ExportToComponent(const 
uno::Reference& xModel, const 
uno::Reference& xWriter,
 const uno::Sequence& aDescriptor, const OUString& 
sName,
 const OUString& sMediaType, const OUString& sComponentName,
-const uno::Sequence& aArgs, ScMySharedData*& pSharedData)
+const uno::Sequence& aArgs, std::unique_ptr& 
pSharedData)
 {
 bool bRet(false);
 uno::Reference xOut;
@@ -667,7 +667,7 @@ bool ScXMLImportWrapper::ExportToComponent(const 
uno::Reference(SvXMLExport::getImplementation(xFilter));
-pExport->SetSharedData(pSharedData);
+pExport->SetSharedData(std::move(pSharedData));
 
 // if there are sheets to copy, get the source stream
 if ( sName == "content.xml" && lcl_HasValidStream(rDoc) && ( 
pExport->getExportFlags() & SvXMLExportFlags::OASIS ) )
@@ -715,7 +715,7 @@ bool ScXMLImportWrapper::ExportToComponent(const 
uno::Referencefilter( aDescriptor );
 
-pSharedData = pExport->GetSharedData();
+pSharedData = pExport->ReleaseSharedData();
 }
 
 return bRet;
@@ -817,7 +817,7 @@ bool ScXMLImportWrapper::Export(bool bStylesOnly)
 bool bStylesRet (false);
 bool bDocRet(false);
 bool bSettingsRet(false);
-ScMySharedData* pSharedData = 

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Libreoffice Gerrit user]

 sw/qa/extras/ooxmlimport/data/tdf14.docx  |binary
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx |   11 +++
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |9 +
 3 files changed, 20 insertions(+)

New commits:
commit 7209feef41c3c858476a2ae9795a7d2264c0ffc0
Author: László Németh 
AuthorDate: Mon Jan 7 21:28:29 2019 +0100
Commit: László Németh 
CommitDate: Tue Jan 8 11:09:11 2019 +0100

tdf#14 DOCX import: fix formula field syntax

by removing the DOCX custom number format string
which caused a syntax error message here instead
of the formula calculation.

Change-Id: Ia643e966440117871f6b4ddceab610100ac34138
Reviewed-on: https://gerrit.libreoffice.org/65945
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf14.docx 
b/sw/qa/extras/ooxmlimport/data/tdf14.docx
new file mode 100644
index ..14518403cae1
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf14.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index 347fa0c96aeb..e29432694e9a 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -295,6 +295,17 @@ DECLARE_OOXMLIMPORT_TEST(testTdf115094v2, 
"tdf115094v2.docx")
 CPPUNIT_ASSERT(getProperty(getShapeByName("Grafik 19"), 
"IsLayoutInCell"));
 }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf14, "tdf14.docx")
+{
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTextTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
+uno::Reference xCell(xTable->getCellByName("A2"), 
uno::UNO_QUERY_THROW);
+// This was "** Expression is faulty **", because of the unnecessary DOCX 
number format string
+CPPUNIT_ASSERT_EQUAL(OUString("2000"), xCell->getString());
+}
+
 // tests should only be added to ooxmlIMPORT *if* they fail round-tripping in 
ooxmlEXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 244969372080..6e2fc620fc93 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -3401,6 +3401,15 @@ void DomainMapper_Impl::handleFieldFormula
  uno::Reference< beans::XPropertySet > const& xFieldProperties)
 {
 OUString command = pContext->GetCommand().trim();
+
+//  Remove number formatting from \# to end of command
+//  TODO: handle custom number formatting
+sal_Int32 delimPos = command.indexOf("\\#");
+if (delimPos != -1)
+{
+command = command.replaceAt(delimPos, command.getLength() - delimPos, 
"").trim();
+}
+
 // command must contains = and at least another char
 if (command.getLength() < 2)
 return;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - filter/source

[Libreoffice Gerrit user]

 filter/source/xsltdialog/xmlfilterdialogcomponent.cxx |   20 +++--
 filter/source/xsltdialog/xmlfiltersettingsdialog.cxx  |   38 +++---
 filter/source/xsltdialog/xmlfiltersettingsdialog.hxx  |7 +--
 3 files changed, 44 insertions(+), 21 deletions(-)

New commits:
commit 55f3a2d1d44751be38d6e374cc2291f97cae63a2
Author: Caolán McNamara 
AuthorDate: Wed Dec 19 11:03:44 2018 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jan 8 11:08:53 2019 +0100

tdf#122171 block closing final window while xslt filter dialog is modal

and

Resolves: tdf#122219 base form writer-window doesn't honour CloseVeto 
properly

just hit this with the same all-modal hammer we now use in the extension 
manager,
a modeless dialog, with modal subdialogs run by a normal non-async subloop, 
turns
into a modal dialog for all other toplevels

Change-Id: Ia35fad7a1be2ec493011c7e4354b70231b78a7fc
Reviewed-on: https://gerrit.libreoffice.org/65511
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx 
b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
index 31e69c3ec0e9..cea939f6426d 100644
--- a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
+++ b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx
@@ -249,24 +249,20 @@ void SAL_CALL XMLFilterDialogComponent::disposing()
 void SAL_CALL XMLFilterDialogComponent::queryTermination( const EventObject& 
/* Event */ )
 {
 ::SolarMutexGuard aGuard;
-
 if (!mpDialog)
 return;
-
-// we will never give a veto here
-if (!mpDialog->isClosable())
-{
-mpDialog->ToTop();
-throw TerminationVetoException(
-"The office cannot be closed while the XMLFilterDialog is running",
-static_cast(this));
-}
-else
-mpDialog->Close();
+mpDialog->ToTop();
 }
 
 void SAL_CALL XMLFilterDialogComponent::notifyTermination( const EventObject& 
/* Event */ )
 {
+{
+::SolarMutexGuard aGuard;
+if (!mpDialog)
+return;
+mpDialog->Close();
+}
+
 // we are going down, so dispose us!
 dispose();
 }
diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx 
b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx
index d54ee2376305..3af2023f67c5 100644
--- a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx
+++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx
@@ -17,17 +17,19 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
 #include 
+#include 
 #include 
 
 #include 
 
 #include 
-#include 
 #include 
 #include 
-#include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -68,7 +70,6 @@ XMLFilterSettingsDialog::XMLFilterSettingsDialog(vcl::Window* 
pParent,
 Dialog::InitFlag eFlag)
 : ModelessDialog(pParent, "XMLFilterSettingsDialog", 
"filter/ui/xmlfiltersettings.ui", eFlag)
 , mxContext( rxContext )
-, m_bIsClosable(true)
 , m_sTemplatePath("$(user)/template/")
 , m_sDocTypePrefix("doctype:")
 {
@@ -130,9 +131,36 @@ void XMLFilterSettingsDialog::dispose()
 ModelessDialog::dispose();
 }
 
+void XMLFilterSettingsDialog::incBusy()
+{
+// lock any toplevel windows from being closed until busy is over
+// ensure any dialogs are reset before entering
+vcl::Window *xTopWin = Application::GetFirstTopLevelWindow();
+while (xTopWin)
+{
+if (xTopWin != this)
+xTopWin->IncModalCount();
+xTopWin = Application::GetNextTopLevelWindow(xTopWin);
+}
+}
+
+void XMLFilterSettingsDialog::decBusy()
+{
+// unlock any toplevel windows from being closed until busy is over
+// ensure any dialogs are reset before entering
+vcl::Window *xTopWin = Application::GetFirstTopLevelWindow();
+while (xTopWin)
+{
+if (xTopWin != this)
+xTopWin->DecModalCount();
+xTopWin = Application::GetNextTopLevelWindow(xTopWin);
+}
+}
+
 IMPL_LINK(XMLFilterSettingsDialog, ClickHdl_Impl, Button *, pButton, void )
 {
-m_bIsClosable = false;
+// tdf#122171 block closing libreoffice until the following dialog is 
dismissed
+incBusy();
 
 if (m_pPBNew == pButton)
 {
@@ -163,7 +191,7 @@ IMPL_LINK(XMLFilterSettingsDialog, ClickHdl_Impl, Button *, 
pButton, void )
 Close();
 }
 
-m_bIsClosable = true;
+decBusy();
 }
 
 IMPL_LINK_NOARG(XMLFilterSettingsDialog, SelectionChangedHdl_Impl, 
SvTreeListBox*, void)
diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.hxx 
b/filter/source/xsltdialog/xmlfiltersettingsdialog.hxx
index 7ca7d432582d..37ed80f2d7aa 100644
--- a/filter/source/xsltdialog/xmlfiltersettingsdialog.hxx
+++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.hxx
@@ -105,12 +105,13 @@ public:
 
 virtual bool EventNotify( NotifyEvent& rNEvt ) override;
 
-boolisClosable() { return m_bIsClosable;}
-
 private:
   

[Libreoffice-commits] core.git: vcl/win

[Libreoffice Gerrit user]

 vcl/win/gdi/gdiimpl.cxx|   10 --
 vcl/win/gdi/scoped_gdi.hxx |7 +++
 2 files changed, 11 insertions(+), 6 deletions(-)

New commits:
commit bcbcfa7927c575ddb1379b3cd8ef1b2df709ba66
Author: Dmitriy Shilin 
AuthorDate: Sun Jan 6 23:53:45 2019 -0800
Commit: Mike Kaganski 
CommitDate: Tue Jan 8 11:12:14 2019 +0100

tdf#107792 vcl/win/gdi: introduce ScopedHRGN

Change-Id: I3d103dcb6ebb81d50bb8a10371dba7feb92c421d
Reviewed-on: https://gerrit.libreoffice.org/65924
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index 2eb537931d50..1bb39b84cd2e 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -296,9 +296,8 @@ void MakeInvisibleArea(const RECT& rSrcRect,
 rhInvalidateRgn = CreateRectRgnIndirect();
 }
 
-HRGN hTempRgn = CreateRectRgn(nLeft, nTop, nRight, nBottom);
-CombineRgn(rhInvalidateRgn, rhInvalidateRgn, hTempRgn, RGN_DIFF);
-DeleteRegion(hTempRgn);
+ScopedHRGN hTempRgn(CreateRectRgn(nLeft, nTop, nRight, nBottom));
+CombineRgn(rhInvalidateRgn, rhInvalidateRgn, hTempRgn.get(), RGN_DIFF);
 }
 
 void ImplCalcOutSideRgn( const RECT& rSrcRect,
@@ -1259,9 +1258,8 @@ bool WinSalGraphicsImpl::setClipRegion( const 
vcl::Region& i_rClip )
 
 for( sal_uLong n = 1; n < pHeader.nCount; n++, pRect++ )
 {
-HRGN hRgn = CreateRectRgn( pRect->left, pRect->top, 
pRect->right, pRect->bottom );
-CombineRgn( mrParent.mhRegion, mrParent.mhRegion, 
hRgn, RGN_OR );
-DeleteRegion( hRgn );
+ScopedHRGN hRgn(CreateRectRgn(pRect->left, pRect->top, 
pRect->right, pRect->bottom));
+CombineRgn( mrParent.mhRegion, mrParent.mhRegion, 
hRgn.get(), RGN_OR );
 }
 }
 }
diff --git a/vcl/win/gdi/scoped_gdi.hxx b/vcl/win/gdi/scoped_gdi.hxx
index 64dbd180b969..90af7340f06a 100644
--- a/vcl/win/gdi/scoped_gdi.hxx
+++ b/vcl/win/gdi/scoped_gdi.hxx
@@ -21,7 +21,14 @@ struct HBRUSHDeleter
 void operator()(HBRUSH hBrush) { DeleteBrush(hBrush); }
 };
 
+struct HRGNDeleter
+{
+using pointer = HRGN;
+void operator()(HRGN hRgn) { DeleteRegion(hRgn); }
+};
+
 using ScopedHBRUSH = std::unique_ptr;
+using ScopedHRGN = std::unique_ptr;
 
 #endif // INCLUDED_VCL_WIN_GDI_SCOPED_GDI_HXX
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: readlicense_oo/license

[Libreoffice Gerrit user]

 readlicense_oo/license/CREDITS.fodt | 3290 ++--
 1 file changed, 1680 insertions(+), 1610 deletions(-)

New commits:
commit 4d9ed6769f431f18d6cad3fc209afa3f0c62
Author: Christian Lohmaier 
AuthorDate: Tue Jan 8 13:53:19 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 13:53:19 2019 +0100

update credits

Change-Id: I816269e022ad85f247f8691f669898beb24775b6

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index 69a53cc927ba..13703755beb5 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,13 +1,13 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.1.3.2$Linux_X86_64
 
LibreOffice_project/86daf60bf00efa86ad547e59e09d6bb77c699acb2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.1.4.2$Linux_X86_64
 
LibreOffice_project/9d0f32d1f0b509096fd65e0d4bec26ddd1938fd32012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   637
+   545
501
50872
-   26940
+   26007
true
true

@@ -16,9 +16,9 @@
  3577
  3434
  501
- 637
+ 545
  51372
- 27575
+ 26550
  0
  0
  false
@@ -69,7 +69,7 @@
false
false
true
-   8294212
+   8323313
false
false
false
@@ -320,23 +320,26 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
+  
+   
+  
   

   
@@ -401,23 +404,26 @@

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
+  
+   
+  
   

   
@@ -1051,7 +1057,7 @@

   
  Credits
-1378 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-12-10 22:20:51.
+1388 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-01-08 09:32:01.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1075,16 +1081,16 @@
  
  
   
-   Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
+   Caolán 
McNamaraCommits: 25451Joined: 
2000-10-10
   
   
-   Caolán 
McNamaraCommits: 25395Joined: 
2000-10-10
+   Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Stephan 
BergmannCommits: 16635Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 16669Joined: 
2000-10-04
   
   
-   *Noel GrandinCommits: 
10789Joined: 2011-12-12
+   *Noel GrandinCommits: 
10865Joined: 2011-12-12
   
  
  
@@ -1092,10 +1098,10 @@
Ivo 
HinkelmannCommits: 9480Joined: 
2002-09-09
   
   
-   Tor 
LillqvistCommits: 8452Joined: 
2010-03-23
+   Tor 
LillqvistCommits: 8475Joined: 
2010-03-23
   
   
-   Miklos 
VajnaCommits: 7207Joined: 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - readlicense_oo/license

[Libreoffice Gerrit user]

 readlicense_oo/license/CREDITS.fodt | 3290 ++--
 1 file changed, 1680 insertions(+), 1610 deletions(-)

New commits:
commit 78cc10e2615d06017a6a5700d464bc915395bd23
Author: Christian Lohmaier 
AuthorDate: Tue Jan 8 13:53:19 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 13:55:04 2019 +0100

update credits

Change-Id: I816269e022ad85f247f8691f669898beb24775b6
(cherry picked from commit 4d9ed6769f431f18d6cad3fc209afa3f0c62)

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index 69a53cc927ba..13703755beb5 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,13 +1,13 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.1.3.2$Linux_X86_64
 
LibreOffice_project/86daf60bf00efa86ad547e59e09d6bb77c699acb2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.1.4.2$Linux_X86_64
 
LibreOffice_project/9d0f32d1f0b509096fd65e0d4bec26ddd1938fd32012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   637
+   545
501
50872
-   26940
+   26007
true
true

@@ -16,9 +16,9 @@
  3577
  3434
  501
- 637
+ 545
  51372
- 27575
+ 26550
  0
  0
  false
@@ -69,7 +69,7 @@
false
false
true
-   8294212
+   8323313
false
false
false
@@ -320,23 +320,26 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
+  
+   
+  
   

   
@@ -401,23 +404,26 @@

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
+  
+   
+  
   

   
@@ -1051,7 +1057,7 @@

   
  Credits
-1378 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-12-10 22:20:51.
+1388 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-01-08 09:32:01.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1075,16 +1081,16 @@
  
  
   
-   Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
+   Caolán 
McNamaraCommits: 25451Joined: 
2000-10-10
   
   
-   Caolán 
McNamaraCommits: 25395Joined: 
2000-10-10
+   Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Stephan 
BergmannCommits: 16635Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 16669Joined: 
2000-10-04
   
   
-   *Noel GrandinCommits: 
10789Joined: 2011-12-12
+   *Noel GrandinCommits: 
10865Joined: 2011-12-12
   
  
  
@@ -1092,10 +1098,10 @@
Ivo 
HinkelmannCommits: 9480Joined: 
2002-09-09
   
   
-   Tor 
LillqvistCommits: 8452Joined: 
2010-03-23
+   Tor 
LillqvistCommits: 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - readlicense_oo/license

[Libreoffice Gerrit user]

 readlicense_oo/license/CREDITS.fodt | 3290 ++--
 1 file changed, 1680 insertions(+), 1610 deletions(-)

New commits:
commit 7838e0a33a320ca90d2379982234ca89ccb9a229
Author: Christian Lohmaier 
AuthorDate: Tue Jan 8 13:53:19 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 8 13:54:36 2019 +0100

update credits

Change-Id: I816269e022ad85f247f8691f669898beb24775b6
(cherry picked from commit 4d9ed6769f431f18d6cad3fc209afa3f0c62)

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index 69a53cc927ba..13703755beb5 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,13 +1,13 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.1.3.2$Linux_X86_64
 
LibreOffice_project/86daf60bf00efa86ad547e59e09d6bb77c699acb2012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.1.4.2$Linux_X86_64
 
LibreOffice_project/9d0f32d1f0b509096fd65e0d4bec26ddd1938fd32012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   637
+   545
501
50872
-   26940
+   26007
true
true

@@ -16,9 +16,9 @@
  3577
  3434
  501
- 637
+ 545
  51372
- 27575
+ 26550
  0
  0
  false
@@ -69,7 +69,7 @@
false
false
true
-   8294212
+   8323313
false
false
false
@@ -320,23 +320,26 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
+  
+   
+  
   

   
@@ -401,23 +404,26 @@

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
+  
+   
+  
   

   
@@ -1051,7 +1057,7 @@

   
  Credits
-1378 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-12-10 22:20:51.
+1388 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2019-01-08 09:32:01.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1075,16 +1081,16 @@
  
  
   
-   Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
+   Caolán 
McNamaraCommits: 25451Joined: 
2000-10-10
   
   
-   Caolán 
McNamaraCommits: 25395Joined: 
2000-10-10
+   Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Stephan 
BergmannCommits: 16635Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 16669Joined: 
2000-10-04
   
   
-   *Noel GrandinCommits: 
10789Joined: 2011-12-12
+   *Noel GrandinCommits: 
10865Joined: 2011-12-12
   
  
  
@@ -1092,10 +1098,10 @@
Ivo 
HinkelmannCommits: 9480Joined: 
2002-09-09
   
   
-   Tor 
LillqvistCommits: 8452Joined: 
2010-03-23
+   Tor 
LillqvistCommits: 

[Libreoffice-commits] core.git: sc/source

[Libreoffice Gerrit user]

 sc/source/ui/formdlg/dwfunctr.cxx   |4 --
 sc/source/ui/miscdlgs/acredlin.cxx  |   47 
 sc/source/ui/miscdlgs/conflictsdlg.cxx  |   21 ++
 sc/source/ui/miscdlgs/datafdlg.cxx  |   19 
 sc/source/ui/miscdlgs/highred.cxx   |5 +--
 sc/source/ui/miscdlgs/lbseldlg.cxx  |5 +--
 sc/source/ui/miscdlgs/optsolver.cxx |   13 
 sc/source/ui/miscdlgs/retypepassdlg.cxx |4 +-
 sc/source/ui/miscdlgs/scuiautofmt.cxx   |5 +--
 sc/source/ui/namedlg/namedlg.cxx|   13 +++-
 sc/source/ui/namedlg/namemgrtable.cxx   |7 ++--
 sc/source/ui/namedlg/namepast.cxx   |   11 ++-
 sc/source/ui/navipi/content.cxx |   33 +-
 sc/source/ui/pagedlg/areasdlg.cxx   |   19 ++--
 sc/source/ui/undo/undobase.cxx  |5 +--
 sc/source/ui/undo/undoblk.cxx   |   46 ++-
 sc/source/ui/undo/undoblk2.cxx  |   22 --
 sc/source/ui/undo/undoblk3.cxx  |   39 ++
 sc/source/ui/undo/undorangename.cxx |5 +--
 sc/source/ui/undo/undostyl.cxx  |   12 
 sc/source/ui/undo/undotab.cxx   |5 ---
 21 files changed, 150 insertions(+), 190 deletions(-)

New commits:
commit 5072e17ec99da280e70413fa2ec571aa928c4503
Author: Arkadiy Illarionov 
AuthorDate: Tue Jan 8 14:14:32 2019 +0300
Commit: Noel Grandin 
CommitDate: Tue Jan 8 14:16:45 2019 +0100

Simplify containers iterations in sc/source/ui/[f-u]*

Use range-based loop or replace with STL functions

Change-Id: Ia117ee3bea76c1cee84c0d2bb43195c59764fe93
Reviewed-on: https://gerrit.libreoffice.org/65961
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/formdlg/dwfunctr.cxx 
b/sc/source/ui/formdlg/dwfunctr.cxx
index 980fd83b70de..f2c52f45fad7 100644
--- a/sc/source/ui/formdlg/dwfunctr.cxx
+++ b/sc/source/ui/formdlg/dwfunctr.cxx
@@ -239,10 +239,8 @@ void ScFunctionWin::UpdateFunctionList()
 }
 else // LRU list
 {
-for (::std::vector::iterator 
iter=aLRUList.begin();
-iter != aLRUList.end(); ++iter)
+for (const formula::IFunctionDescription* pDesc : aLRUList)
 {
-const formula::IFunctionDescription* pDesc = *iter;
 if (pDesc)
 aFuncList->SetEntryData( aFuncList->InsertEntry( 
pDesc->getFunctionName()), const_cast(pDesc));
 }
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx 
b/sc/source/ui/miscdlgs/acredlin.cxx
index b1294a0ddff6..05d1ab0b22d3 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -202,9 +202,8 @@ void ScAcceptChgDlg::Init()
 aChangeViewSet.SetTheAuthorToShow(pChanges->GetUser());
 pTPFilter->ClearAuthors();
 const std::set& rUserColl = pChanges->GetUserCollection();
-std::set::const_iterator it = rUserColl.begin(), itEnd = 
rUserColl.end();
-for (; it != itEnd; ++it)
-pTPFilter->InsertAuthor(*it);
+for (const auto& rItem : rUserColl)
+pTPFilter->InsertAuthor(rItem);
 }
 
 ScChangeViewSettings* pViewSettings=pDoc->GetChangeViewSettings();
@@ -1124,13 +1123,8 @@ bool 
ScAcceptChgDlg::InsertContentChildren(ScChangeActionMap* pActionMap,SvTreeL
 }
 SvTreeListEntry* pEntry=nullptr;
 
-ScChangeActionMap::iterator itChangeAction = pActionMap->begin();
-while( itChangeAction != pActionMap->end() )
-{
-if( itChangeAction->second->GetState()==SC_CAS_VIRGIN )
-break;
-++itChangeAction;
-}
+ScChangeActionMap::iterator itChangeAction = 
std::find_if(pActionMap->begin(), pActionMap->end(),
+[](const std::pair& rEntry) { return 
rEntry.second->GetState() == SC_CAS_VIRGIN; });
 
 if( itChangeAction == pActionMap->end() )
 return true;
@@ -1215,11 +1209,10 @@ bool ScAcceptChgDlg::InsertChildren(ScChangeActionMap* 
pActionMap,SvTreeListEntr
 {
 ScChangeTrack* pChanges=pDoc->GetChangeTrack();
 bool bTheTestFlag = true;
-ScChangeActionMap::iterator itChangeAction;
 
-for( itChangeAction = pActionMap->begin(); itChangeAction != 
pActionMap->end(); ++itChangeAction )
+for( const auto& rChangeAction : *pActionMap )
 {
-SvTreeListEntry* pEntry=AppendChangeAction( itChangeAction->second, 
pParent, false, true );
+SvTreeListEntry* pEntry=AppendChangeAction( rChangeAction.second, 
pParent, false, true );
 
 if(pEntry!=nullptr)
 {
@@ -1230,8 +1223,8 @@ bool ScAcceptChgDlg::InsertChildren(ScChangeActionMap* 
pActionMap,SvTreeListEntr
 pEntryData->bIsAcceptable=false;
 pEntryData->bDisabled=true;
 
-if( itChangeAction->second->IsDialogParent() )
-Expand( pChanges, itChangeAction->second, pEntry );
+if( rChangeAction.second->IsDialogParent() )
+Expand( pChanges, 

[Libreoffice-bugs] [Bug 119649] FILEOPEN: PPTX: color isn't imported correctly after pptx roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119649

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108226


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||119649


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=119649
[Bug 119649] FILEOPEN: PPTX: color isn't imported correctly after pptx
roundtrip
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122561] LibreOffice crashes at start of second document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122561

--- Comment #2 from Durgapriyanka  ---
Thank you for reporting the bug. I can not reproduce this big in

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113510] [META] Bugs that cause CPU to run at 100%

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113510

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||116975


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116975
[Bug 116975] Laggy behavior when clicking between table cells in impress
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118781] UI: Change the 'Contains' section in the Modify Style dialogues to improve the transparency and use of hierarchical styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118781

--- Comment #5 from Harald Koester  ---
Created attachment 148150
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148150=edit
Another mockup

For discussion I created another mockup. The main difference is, that the
initial mockup is more a list whereas this one is a table. Therewith a user is
able to compare the value of each preference between the inherited style and
the current style easily, I also added a column for the value of the inherited
style.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122581] Table of contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122581

--- Comment #1 from Nicolas Christener  ---
Created attachment 148155
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148155=edit
Google Docs TOC insert

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122581] Table of contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122581

--- Comment #2 from Nicolas Christener  ---
Created attachment 148156
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148156=edit
Google Docs TOC update

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120569] Custom Animation Sound Effect Not Played After ODP File Moved To Another Computer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120569

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||109362


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109362
[Bug 109362] [META] Custom/object animation bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118458] FILEOPEN PPTX Columns don’t appear in the text box in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118458

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108226


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||118458


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=118458
[Bug 118458] FILEOPEN PPTX Columns don’t appear in the text box in Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87341] FORMATTING: Wrong cells formating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87341

--- Comment #11 from Xavier Van Wijmeersch  ---
repro with

Version: 6.3.0.0.alpha0+
Build ID: 32b85ec64e5c901369ce3ce5dbda0e96f2ec7fc0
CPU threads: 2; OS: Linux 4.19; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-01-07_16:08:14
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 122308, which changed state.

Bug 122308 Summary: Crash: closing LibreOffice while warning about signatures 
is open (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=122308

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122578] Dialog theming/UX - colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122578

--- Comment #1 from Nicolas Christener  ---
Created attachment 148151
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148151=edit
Colors in a iOS dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122579] New: Calc crashes when deleting a style that is in use

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122579

Bug ID: 122579
   Summary: Calc crashes when deleting a style that is in use
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rjmcken...@fastmail.com

Description:
When deleting a style that is in use, the pop up dialog will appear asking you
if you want to delete it. If you select yes, the program will hang. I let it
sit for a few minutes this way, but it didn't look like it was going to
recover. Had to force close.

Steps to Reproduce:
1.Have a style that is in use
2.Try to delete that style
3.Agree to doing so


Actual Results:
Program Crash

Expected Results:
Deleted the style and revert cells that were using that style to the default
style


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122458] Heading 1 style font (and others) fail to update if top level heading font is changed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122458

--- Comment #6 from Luke Forbach  ---
Additional Note: Issue does not persist upon closing and reopening document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122578] Dialog theming/UX - colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122578

--- Comment #2 from Nicolas Christener  ---
Created attachment 148152
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148152=edit
Colors of a current libo dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122580] Dialog theming/UX - main dialog buttons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122580

--- Comment #2 from Nicolas Christener  ---
Created attachment 148154
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148154=edit
libo app dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122580] Dialog theming/UX - main dialog buttons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122580

--- Comment #1 from Nicolas Christener  ---
Created attachment 148153
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148153=edit
native iOS dialog (example)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122576] Dialog theming/UX - dialogs too small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122576

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu,
   ||t...@iki.fi

--- Comment #2 from Aron Budea  ---
Yes, the dialog looks crooked and should be bigger, and probably the text
should be smaller as well.
Confirmed using verion 0.1 (13).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61398] FILEOPEN: can't get rid of macro warning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61398

--- Comment #8 from Richard Parkins  ---
Created attachment 148157
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148157=edit
Minimal example to provoke bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122570] Doesn't work Enter key in Autofilter window in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122570

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122570] Doesn't work Enter key in Autofilter window in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122570

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 148139
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148139=edit
Example ODS file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113331] [META] PPT (binary) format bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113331
Bug 113331 depends on bug 120375, which changed state.

Bug 120375 Summary: Crash in: VirtualDevice::~VirtualDevice when exporting to 
PPT
https://bugs.documentfoundation.org/show_bug.cgi?id=120375

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118649] Impress Slideshow "Fade Smoothly" Starts Aggressively

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118649

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103704


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103704
[Bug 103704] [META] Slide transition bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103704] [META] Slide transition bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103704

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||118649


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=118649
[Bug 118649] Impress Slideshow "Fade Smoothly" Starts Aggressively
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs