[Libreoffice-commits] help.git: source/text

[Libreoffice Gerrit user]

 source/text/shared/guide/language_select.xhp |   18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

New commits:
commit 37852a4343f3a9023ac6481947acd401dd9fe55d
Author: Sophia Schröder 
AuthorDate: Fri Nov 9 20:22:15 2018 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Jan 14 16:53:05 2019 +0100

Help files: http -> https

+ some more conservative changes

Change-Id: I34de2e567574679ac724655ec0840cce6ed96edb
Reviewed-on: https://gerrit.libreoffice.org/63212
Tested-by: Jenkins
Reviewed-by: Sophie Gautier 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/shared/guide/language_select.xhp 
b/source/text/shared/guide/language_select.xhp
index 0ed43f570..99be9162d 100644
--- a/source/text/shared/guide/language_select.xhp
+++ b/source/text/shared/guide/language_select.xhp
@@ -1,6 +1,5 @@
 
 
-   
 
- 
-   
+
 
   
  Selecting the Document 
Language
@@ -102,7 +100,7 @@
 Click on the name of the character style to which you want to 
apply a different language.
  
  
-Then open the context menu in the Styles window and select 
Modify. This opens the Character Style 
dialog.
+Then open the context menu in the Styles window 
and select Modify. This opens the Character Style 
dialog.
  
  
 Select the Font tab.
@@ -121,10 +119,10 @@
 Select a dictionary in the list of descriptions. Click the 
heading in a dictionary description that you want to get.
  
  
-In 
the next page, click the Get It icon to download the dictionary extension. Note 
the folder name to which your browser downloads the file. Download additional 
dictionaries as you like.
+In 
the next page, click the Get It icon to download the dictionary 
extension. Note the folder name to which your browser downloads the file. 
Download additional dictionaries as you like.
  
  
-In 
%PRODUCTNAME, choose Tools - Extension Manager and 
click Add to install the downloaded extensions.
+In 
%PRODUCTNAME, choose Tools - Extension Manager and 
click Add to install the downloaded extensions.
  
  
 After you installed the extensions, you should close 
%PRODUCTNAME (including the Quickstarter), and restart.
@@ -141,7 +139,7 @@
 Select another UI language in the "User interface" 
listbox.
  
  
-Click OK and restart the %PRODUCTNAME software.
+Click OK and restart the %PRODUCTNAME 
software.
  
  
 If 
the listbox doesn't list the language that you want, see "Adding More UI 
Languages".
@@ -155,7 +153,7 @@
 Close %PRODUCTNAME software (also close the Quickstarter, if 
you enabled it).
  
  
-Run %PRODUCTNAME installer, choose Modify, then select the 
language that you would like to install from the Additional user interface 
languages group.
+Run %PRODUCTNAME installer, choose Modify, then 
select the language that you would like to install from the Additional 
user interface languages group.
  
   
   
@@ -172,7 +170,7 @@
   If you 
downloaded %PRODUCTNAME packages from the main %PRODUCTNAME Web site, follow 
the steps below.
   
  
-Open your Web browser and enter http://www.libreoffice.org/download/;>http://www.libreoffice.org/download/
+Open your web browser and enter https://www.libreoffice.org/download/;>https://www.libreoffice.org/download/.
  
  
 Select and download the correct language pack for your version 
of %PRODUCTNAME software.
@@ -188,7 +186,7 @@
   
   
  
-Open your Web browser and enter http://www.libreoffice.org/download/;>http://www.libreoffice.org/download/
+Open your web browser and enter https://www.libreoffice.org/download/;>https://www.libreoffice.org/download/.
  
  
 Select and download the correct language pack for your version 
of %PRODUCTNAME software.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Libreoffice Gerrit user]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit be78f86cd0b0b819abe9f7db5d605ac0df191653
Author: Sophia Schröder 
AuthorDate: Fri Nov 9 20:22:15 2018 +0100
Commit: Gerrit Code Review 
CommitDate: Mon Jan 14 16:53:05 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Help files: http -> https

+ some more conservative changes

Change-Id: I34de2e567574679ac724655ec0840cce6ed96edb
Reviewed-on: https://gerrit.libreoffice.org/63212
Tested-by: Jenkins
Reviewed-by: Sophie Gautier 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 01d79bef0c18..37852a4343f3 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 01d79bef0c183c39ef56c4bd8bbdb6ae6e9ff4f8
+Subproject commit 37852a4343f3a9023ac6481947acd401dd9fe55d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - include/vcl sc/source vcl/source

[Libreoffice Gerrit user]

 include/vcl/gdimtf.hxx|2 +-
 sc/source/ui/docshell/docfunc.cxx |4 ++--
 vcl/source/gdi/gdimtf.cxx |4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 99ccad6fa5eab2e69fa8c43db3b27b8c02ad8217
Author: Arkadiy Illarionov 
AuthorDate: Sat Jan 12 18:20:51 2019 +0300
Commit: Noel Grandin 
CommitDate: Mon Jan 14 16:40:02 2019 +0100

Fix loop conditions

2b88f6d32f572792597ccbb15276b9db52db7d10 follow-up

Change-Id: I3b525506ee222c80ff04ea38eec90a581c928985
Reviewed-on: https://gerrit.libreoffice.org/66216
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index ef9fe0137e6a..bfea212bd7cc 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -1827,7 +1827,7 @@ bool ScDocFunc::InsertCells( const ScRange& rRange, const 
ScMarkData* pTabMark,
 std::unique_ptr pUndoRemoveMerge;
 
 itr = aMark.begin();
-for (; itr != itrEnd && nTabCount; ++itr)
+for (; itr != itrEnd && *itr < nTabCount; ++itr)
 {
 i = *itr;
 if( rDoc.HasAttrib( nMergeTestStartCol, nMergeTestStartRow, i, 
nMergeTestEndCol, nMergeTestEndRow, i, HasAttrFlags::Merged | 
HasAttrFlags::Overlapped ) )
@@ -4730,7 +4730,7 @@ bool ScDocFunc::FillAuto( ScRange& rRange, const 
ScMarkData* pTabMark, FillDir e
 pUndoDoc.reset(new ScDocument( SCDOCMODE_UNDO ));
 pUndoDoc->InitUndo( , nDestStartTab, nDestStartTab );
 ScMarkData::iterator itr = aMark.begin(), itrEnd = aMark.end();
-for (; itr != itrEnd && nTabCount; ++itr)
+for (; itr != itrEnd && *itr < nTabCount; ++itr)
 if (*itr != nDestStartTab)
 pUndoDoc->AddUndoTab( *itr, *itr );
 
commit 0bb77f2161e8bcaf42c536a859c2095a3f03428a
Author: Muhammet Kara 
AuthorDate: Mon Jan 14 10:27:40 2019 +0300
Commit: Noel Grandin 
CommitDate: Mon Jan 14 16:39:53 2019 +0100

Add fileName to GDIMetaFile::dumpAsXml()

GDIMetaFile::dumpAsXml() is very useful while investigating/examining
the meta files, but it overwrites with the same file name each time.
To be able to get different dumps at the same time, let's add
a fileName parameter to it.

Change-Id: I993720b460f326cd65519556cf1e902591d90d42
Reviewed-on: https://gerrit.libreoffice.org/66283
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/gdimtf.hxx b/include/vcl/gdimtf.hxx
index 59d4f0939076..9b43cd2f6ef8 100644
--- a/include/vcl/gdimtf.hxx
+++ b/include/vcl/gdimtf.hxx
@@ -199,7 +199,7 @@ public:
 boolGetUseCanvas() const { return m_bUseCanvas; }
 
 /// Dumps the meta actions as XML in metafile.xml.
-void dumpAsXml() const;
+void dumpAsXml( const OUString& sFileName = OUString() ) const;
 };
 
 #endif // INCLUDED_VCL_GDIMTF_HXX
diff --git a/vcl/source/gdi/gdimtf.cxx b/vcl/source/gdi/gdimtf.cxx
index db292eebb298..7038fb7c5244 100644
--- a/vcl/source/gdi/gdimtf.cxx
+++ b/vcl/source/gdi/gdimtf.cxx
@@ -2835,9 +2835,9 @@ void GDIMetaFile::UseCanvas( bool _bUseCanvas )
 m_bUseCanvas = _bUseCanvas;
 }
 
-void GDIMetaFile::dumpAsXml() const
+void GDIMetaFile::dumpAsXml( const OUString& sFileName ) const
 {
-SvFileStream aStream("metafile.xml", StreamMode::STD_READWRITE | 
StreamMode::TRUNC);
+SvFileStream aStream(sFileName.isEmpty() ? "metafile.xml" : sFileName, 
StreamMode::STD_READWRITE | StreamMode::TRUNC);
 MetafileXmlDump aDumper;
 aDumper.dump(*this, aStream);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [libreoffice-l10n] Re: [libreoffice-documentation] New XHP editor online for testing and feedback

[Martin Srebotnjak]

Hello Olivier et. al.,

will the editor in any way change underlying string/text
non-changed-with-editing code (i.e. if a small edit of one word is
performed, does the whole chunk of help page save/change (regarding also
xml checks and corrections and beautification?).

Did you try any tests, how many fuzzy strings does a small edit of one word
on an average hep page in English cause in git/po files? I am just worried
that this might cause a lot of fuzzy (not fully translated) strings in l10n
projects and a lot of collateral damage for l10n teams. But I might just be
too much worried.

Thanks, m.

V V pon., 14. jan. 2019 ob 12:43 je oseba Olivier Hallot <
olivier.hal...@libreoffice.org> napisala:

> Hi Help Authors, L10n Translators and developers
>
> Following Mike's announcement, I have improved and fixed a bit the XHP
> editor, and changed the page address (*) (apologies)
>
> The editor is still work in progress, but starts to become interesting
> for creating and editing Help pages.
>
> What's new
>
> --
>
> + Mike's implementation of the autocompletion of XHP tags
>
> + The left and right panes are now fixed in browser screen and scrollable
>
> + The right pane uses 99% of the current Help transformation rendering,
> plus
>
> + some visual debug information left intentionally to help Author in
> adjusting s, s and s
>
> + You can now open a Help page directly from the interface. The help
> page is normally
>
> source/text//AAA/BBB/myHelpPage.xhp
>
> Type /AAA/BBB/myHelpPage.xhp in the text box and click "Open
> File" to load in the editor
>
> Press "Render page" to see it on the right.
>
> + A set of buttons with XHP snippets to shorten editing workload:
>
> - For paragraphs, notes, headings, emph, menuitems, etc... select the
> raw text or contents and click the corresponding button. The raw text
> will be wrapped with the opening and closing tag. For paragraph-like
> contents, an unique id will be created automatically.
>
> - Other snippets builds fragments of XHP tags, such as tables, tablerow,
> lists, sections, and more, including the
>
> - just play with and do not forget to render the page on the right.
>
> Restrictions
>
> -
>
> + The editor works with Firefox only. Issues with Chrome and Edge. Other
> browsers not yet tested.
>
> + saving files not implemented. However you can copy the editor contents
> and finish the patch in you preferred editor
>
> + More XHP checking are under development, specially id's unicity and
> DTD checking
>
> + If you get a blank page on the right, this is because you hit a bug in
> the browser transformation. Unfortunately debugging the browser
> transformation is very hard, support is almost none. We will have to
> address these issues.
>
>
> Invitation for developers and testers
>
> -
>
> You are invited to test the editor and report bugs and suggest
> improvements.
>
> The user interface is simple HTML and Javascript. If you have skills in
> these technologies you are a potential developer for the editor, but we
> know that PHP will be the right tech choice in near future.
>
> The source code is in the dev-tool repository. To clone the dev-tool
> repository :
>
> git clone https://gerrit.libreoffice.org/dev-tools dev-tools
>
> The editor is in dev-tools/help3/html/
>
> If you have a web server working in your computer (Apache, Nginx, etc...)
> you can run the editor locally:
>
> create a link between the web server root and the editor. For example,
> under Debian-like Linux:
>
> sudo cd /var/www/html
> sudo ln -s help-editor /dev-tools/help3/html
>
> and point your browser to
>
> http://localhost/help-editor
>
> Seeking Help and discussion on the editor
> -
>
> + Please use this list, the developer list and our IRC channels to get in
> touch with the development of the editor.
>
> Kind regards
>
> (*) https://newdesign.libreoffice.org/help_editor/index.html
>
> Olivier
>
> Em 04/01/2019 08:39, Mike Saunders escreveu:
> > Hello everyone,
> >
> > Olivier and I have been working on a new XHP editor, to simplify the
> > editing of help documentation. The goals of this editor are:
> >
> > * Ease of use -- with syntax highlighting and autocompletion
> > * Web-based -- so it can be used immediately
> > * Integrated -- into the Gerrit/Git workflow
> >
> > We're still working on that final point, but for now, you can try the
> > editor here:
> >
> > https://newdesign.libreoffice.org/new_help_editor/index.html
> >
> > To test the autocompletion, start with a blank document and type a "<"
> > character. You'll see that "helpdocument" is suggested as a top-level
> > tag. Hit enter to complete it, then add ">".
> >
> > Now go to another line and add "<" again, and you'll see child tags
> > suggested: "meta" and "body". You can also close the "helpdocument" tag.
> > For some tags that have parameters, the editor will show them as well.
> >
> > Underneath, you see various 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - cui/source

[Libreoffice Gerrit user]

 cui/source/tabpages/autocdlg.cxx |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit a3db8a7ec8c28053c6bd3ca3e5e30bd2cedf7d57
Author: Caolán McNamara 
AuthorDate: Mon Jan 14 10:08:08 2019 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Jan 14 16:33:10 2019 +0100

Resolves: tdf#122627 be explicit about what column to check

Change-Id: Icdd1cef6b0bc9d8dd61c309dc9de66021fc9422d
Reviewed-on: https://gerrit.libreoffice.org/66287
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index 0c76a85333c5..6f9f82a0eb62 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -245,6 +245,10 @@ void OfaAutocorrOptionsPage::InsertEntry(const OUString& 
rTxt)
 m_xCheckLB->set_text(nRow, rTxt, 1);
 }
 
+#define CBCOL_FIRST 0
+#define CBCOL_SECOND1
+#define CBCOL_BOTH  2
+
 void OfaAutocorrOptionsPage::Reset( const SfxItemSet* )
 {
 SvxAutoCorrect* pAutoCorrect = SvxAutoCorrCfg::Get().GetAutoCorrect();
@@ -263,14 +267,14 @@ void OfaAutocorrOptionsPage::Reset( const SfxItemSet* )
 InsertEntry(m_sAccidentalCaps);
 
 int nPos = 0;
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::Autocorrect) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CapitalStartWord) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & 
ACFlags::CapitalStartSentence) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgWeightUnderl) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::SetINetAttr) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgToEnEmDash) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::IgnoreDoubleSpace) 
);
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CorrectCapsLock) );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::Autocorrect), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CapitalStartWord), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & 
ACFlags::CapitalStartSentence), CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgWeightUnderl), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::SetINetAttr), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgToEnEmDash), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::IgnoreDoubleSpace), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CorrectCapsLock), 
CBCOL_FIRST );
 
 m_xCheckLB->thaw();
 }
@@ -319,10 +323,6 @@ public:
 /*   */
 /*/
 
-#define CBCOL_FIRST 0
-#define CBCOL_SECOND1
-#define CBCOL_BOTH  2
-
 enum OfaAutoFmtOptions
 {
 USE_REPLACE_TABLE,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

RE: need advices and help about Bookmark API.

[LORENZO Vincent]

Hello everybody,
I thank you for your anwsers. I will continue with Bookmark which seem me quite 
easy to implement.

I found a way to avoid to search the text in the document:
 short value = ((Integer) text.length()).shortValue();
 cursor.setString(text);
   cursor.gotoEnd(false);

 cursor.goLeft(value, false);
 InsertBookmark(odtEditor.getXTextDocument(), cursor, 
"muBookmarkName");
   cursor.gotoEnd(false);

It seems work find.

/Vincent

De : LibreOffice [mailto:libreoffice-boun...@lists.freedesktop.org] De la part 
de sos
Envoyé : vendredi 11 janvier 2019 10:36
À : libreoffice@lists.freedesktop.org
Objet : Re: need advices and help about Bookmark API.


Hallo,
We did some test to use RDF (also Miklos his advice) to store some information 
about images in a Writerdoc, before we stored the information in the 
ImageObject , what was not a good idea.
Greetz
Fernand

below the code who works well

const BASE_TYPE = 
"http://PMGopmaak.writer/Allgraphics;
const TYPE_NAME = "GraphicURL"

const FILE_NAME = "PMGopmaak.writer/Allgraphics.rdf"


Sub StoreRDF
  RemoveRDF()

  ' "graph" staat hier niet voor een graphic maar voor een ellement die data 
kan omschrijven en stockeren
  ' een "litera" is een string die we stockeren en kunnen opvragen
  doc = ThisComponent
  repo = doc.getRDFRepository()
  type_uri = GetTypeURI()
  graph_name = doc.addMetadataFile(FILE_NAME, Array(type_uri))
  named_graph = repo.getGraph(graph_name)

  value_uri = CreateURI(com.sun.star.rdf.URIs.RDF_VALUE)



  if doc.supportsService("com.sun.star.text.TextDocument") then

   oDocGraphics = doc.GraphicObjects

vAlleFotos = oDocGraphics.getElementNames()
aantal = oDocGraphics.count
 For iG = 0 to aantal - 1
iFotNr = ig + 1
 '   sFotMetNr = vAlleFotos(iG)
oGraphic1 = oDocGraphics.GetbyIndex(ig)
  named_graph.addStatement(CreateURI(oGraphic1.Name &":", 
"URL"),value_uri,CreateLiteral(Ographic1.Title))
  named_graph.addStatement(CreateURI(oGraphic1.Name &":", 
"ONDERSCHRIFT"),value_uri,CreateLiteral(Ographic1.Hyperlinkname))

  next IG

  End If

  doc.setModified(True)
End Sub

Sub ReadRDF()
zoek = "Image1:URL"
  doc = ThisComponent
  repo = doc.getRDFRepository()

  type_uri = GetTypeURI()

  graph_names = doc.getMetadataGraphsWithType(type_uri)

  If ubound(graph_names) = -1 then exit sub

  graph_name = graph_names(0)

  named_graph = repo.getGraph(graph_name)
  value_uri = CreateURI(com.sun.star.rdf.URIs.RDF_VALUE)

 ' named_graph.clear
  enume = named_graph.getStatements(Null, value_uri, Null)
 ' xray named_graph.getStatements(null, value_uri, Null)
  s = ""
   Do while Enume.hasMoreElements
st = enume.nextElement()
 name = st.Subject.StringValue
   sts = st.Object.StringValue
s = s & name & ": " & sts & chr(10)
print name
   ' if name = zoek  then
   ' print sts
  ' named_graph.removeStatements(st.Subject, value_uri,st.Object)
   ' exit do
  ' endif
 loop

  msgbox s
End Sub


Sub RemoveRDF
  doc = ThisComponent
  repo = doc.getRDFRepository()

  type_uri = GetTypeURI()
  graph_names = doc.getMetadataGraphsWithType(type_uri)
  if ubound(graph_names) = -1 then exit sub
  graph_name = graph_names(0)
  doc.removeMetadataFile(graph_name)
  doc.setModified(True)
End Sub


Function GetTypeURI() As variant
  GetTypeURI = CreateURI(BASE_TYPE & "/" & TYPE_NAME)
End Function


Function CreateURI(n, Optional l) As Variant
  If IsMissing(l) Then
a = Array(n)
  Else
a = Array(n, l)
  End If
  uri = CreateUnoServiceWithArguments("com.sun.star.rdf.URI", a)
  CreateURI = uri
End Function

Function CreateLiteral(v) As Variant
  a = Array(v)
  literal = CreateUnoServiceWithArguments("com.sun.star.rdf.Literal", a)
  CreateLiteral = literal
End Function





On 1/11/2019 9:27 AM, Miklos Vajna wrote:

Hi Vincent,



On Thu, Jan 10, 2019 at 02:13:58PM +, LORENZO Vincent 
 wrote:

Question 1:

Currently we are studying the possibility to use the Bookmark field's name to 
store these datas. We want to use the Bookmark with start and end tag, to get 
something like that.



  Some text

   



In reality, I would prefer to be able to use a more structured datas, extending 
the Bookmark object (or using another solution ? ) to get that, something like 
that:



   

   Some text

   



but I have no idea if it is possible and how to do that. Please, does someone 
have an idea to structure my datas ?

Of course, if you have a better solution than Bookmark, fell free to propose it.



Bookmark is just a string; one hack you can do is to give it a unique

name, which refers to a per-document custom metadata, where the value

disturbs the user less. But that's still just a string, so you need to

serialize/load to/from string if you want to store key-value pairs.



An alternative is to use RDF 

[Libreoffice-commits] core.git: oox/source sd/qa

[Libreoffice Gerrit user]

 oox/source/drawingml/diagram/diagramlayoutatoms.cxx |   10 ++
 sd/qa/unit/data/pptx/smartart-org-chart.pptx|binary
 sd/qa/unit/import-tests-smartart.cxx|   15 +++
 3 files changed, 25 insertions(+)

New commits:
commit 8638cc1b737195df16a160b148d2cd2c68131174
Author: Miklos Vajna 
AuthorDate: Mon Jan 14 15:10:19 2019 +0100
Commit: Miklos Vajna 
CommitDate: Mon Jan 14 17:43:00 2019 +0100

oox smartart, org chart: fix height of manager nodes without employees

Employees and/or assistants reduce the height of managers -- this effect
is wanted even if there are no employees/assistants.

Change-Id: I7bfcbf6819ee225aa2fbf21d4e064322912f8d5f
Reviewed-on: https://gerrit.libreoffice.org/66304
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx 
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index e768bebf362d..0e091da68b0e 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -552,6 +552,13 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
 
 sal_Int32 nCount = rShape->getChildren().size();
 
+// A manager node's height should be indepdenent from if it has
+// assistants and employees, compensate for that.
+bool bTop = mnType == XML_hierRoot && rShape->getInternalName() == 
"hierRoot1";
+double fHeightScale = 1.0;
+if (mnType == XML_hierRoot && nCount < 3 && bTop)
+fHeightScale = fHeightScale * nCount / 3;
+
 if (mnType == XML_hierRoot && nCount == 3)
 {
 // Order assistant nodes above employee nodes.
@@ -563,7 +570,10 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
 
 awt::Size aChildSize = rShape->getSize();
 if (nDir == XML_fromT)
+{
 aChildSize.Height /= nCount;
+aChildSize.Height *= fHeightScale;
+}
 else
 aChildSize.Width /= nCount;
 
diff --git a/sd/qa/unit/data/pptx/smartart-org-chart.pptx 
b/sd/qa/unit/data/pptx/smartart-org-chart.pptx
index df6e0521fdca..08c9a4fc916d 100644
Binary files a/sd/qa/unit/data/pptx/smartart-org-chart.pptx and 
b/sd/qa/unit/data/pptx/smartart-org-chart.pptx differ
diff --git a/sd/qa/unit/import-tests-smartart.cxx 
b/sd/qa/unit/import-tests-smartart.cxx
index 5895289ad0ce..66fdfbc254cd 100644
--- a/sd/qa/unit/import-tests-smartart.cxx
+++ b/sd/qa/unit/import-tests-smartart.cxx
@@ -718,6 +718,7 @@ void SdImportTestSmartArt::testOrgChart()
 CPPUNIT_ASSERT(xManagerShape.is());
 
 awt::Point aManagerPos = xManagerShape->getPosition();
+awt::Size aManagerSize = xManagerShape->getSize();
 
 // Make sure that the manager has 2 employees.
 // Without the accompanying fix in place, this test would have failed with
@@ -776,6 +777,20 @@ void SdImportTestSmartArt::testOrgChart()
 // assistant shape was below the employee shape.
 CPPUNIT_ASSERT_GREATER(aAssistantPos.Y, aEmployeePos.Y);
 
+// Make sure the height of xManager and xManager2 is the same.
+uno::Reference xManager2(
+getChildShape(getChildShape(getChildShape(xGroup, 1), 0), 0), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xManager2.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Manager2"), xManager2->getString());
+
+uno::Reference xManager2Shape(xManager2, uno::UNO_QUERY);
+CPPUNIT_ASSERT(xManager2Shape.is());
+
+awt::Size aManager2Size = xManager2Shape->getSize();
+// Without the accompanying fix in place, this test would have failed:
+// xManager2's height was 3 times larger than xManager's height.
+CPPUNIT_ASSERT_EQUAL(aManagerSize.Height, aManager2Size.Height);
+
 xDocShRef->DoClose();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: binaryurp/source

[Libreoffice Gerrit user]

 binaryurp/source/binaryany.hxx  |4 +---
 binaryurp/source/bridge.hxx |4 ++--
 binaryurp/source/bridgefactory.hxx  |4 ++--
 binaryurp/source/currentcontext.cxx |6 +-
 binaryurp/source/currentcontext.hxx |   10 ++
 binaryurp/source/lessoperators.cxx  |4 ++--
 binaryurp/source/lessoperators.hxx  |8 +++-
 binaryurp/source/proxy.hxx  |4 +---
 binaryurp/source/unmarshal.hxx  |4 +---
 9 files changed, 15 insertions(+), 33 deletions(-)

New commits:
commit e01b9e772637bbb3b6d856bd0288fb9691bc234d
Author: Stephan Bergmann 
AuthorDate: Mon Jan 14 14:20:50 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Jan 14 15:28:21 2019 +0100

Use C++17 nested namespace definitions (in binaryurp)

Change-Id: I21594a9fec47ac4a0dd1b821a6b47ea468445c42
Reviewed-on: https://gerrit.libreoffice.org/66295
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/binaryurp/source/binaryany.hxx b/binaryurp/source/binaryany.hxx
index 7b4a9011a256..8422ca1ac424 100644
--- a/binaryurp/source/binaryany.hxx
+++ b/binaryurp/source/binaryany.hxx
@@ -24,9 +24,7 @@
 
 #include 
 
-namespace com { namespace sun { namespace star { namespace uno {
-class TypeDescription;
-} } } }
+namespace com::sun::star::uno { class TypeDescription; }
 
 namespace binaryurp {
 
diff --git a/binaryurp/source/bridge.hxx b/binaryurp/source/bridge.hxx
index a258f331639e..4572e7e573c2 100644
--- a/binaryurp/source/bridge.hxx
+++ b/binaryurp/source/bridge.hxx
@@ -50,7 +50,7 @@ namespace binaryurp {
 class Proxy;
 class Reader;
 }
-namespace com { namespace sun { namespace star {
+namespace com::sun::star {
 namespace bridge { class XInstanceProvider; }
 namespace connection { class XConnection; }
 namespace lang { class XEventListener; }
@@ -60,7 +60,7 @@ namespace com { namespace sun { namespace star {
 class UnoInterfaceReference;
 class XInterface;
 }
-} } }
+}
 namespace rtl { class ByteSequence; }
 
 namespace binaryurp {
diff --git a/binaryurp/source/bridgefactory.hxx 
b/binaryurp/source/bridgefactory.hxx
index 048cbb8deeaf..1a83962ee6b7 100644
--- a/binaryurp/source/bridgefactory.hxx
+++ b/binaryurp/source/bridgefactory.hxx
@@ -35,13 +35,13 @@
 #include 
 #include 
 
-namespace com { namespace sun { namespace star {
+namespace com::sun::star {
 namespace connection { class XConnection; }
 namespace uno {
 class XComponentContext;
 class XInterface;
 }
-} } }
+}
 
 namespace binaryurp {
 
diff --git a/binaryurp/source/currentcontext.cxx 
b/binaryurp/source/currentcontext.cxx
index 510f2509486b..56c3306aae29 100644
--- a/binaryurp/source/currentcontext.cxx
+++ b/binaryurp/source/currentcontext.cxx
@@ -30,9 +30,7 @@
 
 #include "currentcontext.hxx"
 
-namespace binaryurp {
-
-namespace current_context {
+namespace binaryurp::current_context {
 
 css::uno::UnoInterfaceReference get() {
 css::uno::UnoInterfaceReference cc;
@@ -57,6 +55,4 @@ void set(css::uno::UnoInterfaceReference const & value) {
 
 }
 
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/binaryurp/source/currentcontext.hxx 
b/binaryurp/source/currentcontext.hxx
index 2a929bf294f8..95600e62d713 100644
--- a/binaryurp/source/currentcontext.hxx
+++ b/binaryurp/source/currentcontext.hxx
@@ -22,13 +22,9 @@
 
 #include 
 
-namespace com { namespace sun { namespace star { namespace uno {
-class UnoInterfaceReference;
-} } } }
+namespace com::sun::star::uno { class UnoInterfaceReference; }
 
-namespace binaryurp {
-
-namespace current_context {
+namespace binaryurp::current_context {
 
 com::sun::star::uno::UnoInterfaceReference get();
 
@@ -36,8 +32,6 @@ void set(com::sun::star::uno::UnoInterfaceReference const & 
value);
 
 }
 
-}
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/binaryurp/source/lessoperators.cxx 
b/binaryurp/source/lessoperators.cxx
index 98857171f108..acab8117583f 100644
--- a/binaryurp/source/lessoperators.cxx
+++ b/binaryurp/source/lessoperators.cxx
@@ -30,7 +30,7 @@
 
 #include "lessoperators.hxx"
 
-namespace com { namespace sun { namespace star { namespace uno {
+namespace com::sun::star::uno {
 
 bool operator <(TypeDescription const & left, TypeDescription const & right) {
 assert(left.is() && right.is());
@@ -42,7 +42,7 @@ bool operator <(TypeDescription const & left, TypeDescription 
const & right) {
   OUString::unacquired(()->pTypeName)));
 }
 
-} } } }
+}
 
 namespace rtl {
 
diff --git a/binaryurp/source/lessoperators.hxx 
b/binaryurp/source/lessoperators.hxx
index 8090db850e66..65f2c5366ca3 100644
--- a/binaryurp/source/lessoperators.hxx
+++ b/binaryurp/source/lessoperators.hxx
@@ -22,16 +22,14 @@
 
 #include 
 
-namespace com { namespace sun { namespace star { namespace uno {
-class TypeDescription;
-} } } }
+namespace com::sun::star::uno { class TypeDescription; }
 namespace rtl { class ByteSequence; }
 
-namespace 

[Libreoffice-commits] online.git: debian/control loolwsd.spec.in

[Libreoffice Gerrit user]

 debian/control  |2 +-
 loolwsd.spec.in |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 889fb7a1ce67d708432a1f4be82f4d7f2805c401
Author: Andras Timar 
AuthorDate: Mon Jan 14 15:17:09 2019 +0100
Commit: Andras Timar 
CommitDate: Mon Jan 14 15:17:20 2019 +0100

build requires m4

Change-Id: I23a102762a43890d5487ea7a6e3adac035fc3b68

diff --git a/debian/control b/debian/control
index c5497b564..fa4b53712 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,7 @@ Source: loolwsd
 Section: web
 Priority: optional
 Maintainer: Andras Timar 
-Build-Depends: debhelper (>= 9), dh-systemd (>= 1.3), libcap-dev, libcap2-bin, 
libpcre3-dev, libpng-dev, libpoco-dev (>= 1.7.5), linux-libc-dev, nodejs, 
python-polib, python-lxml, fontconfig, libpam-dev, libcppunit-dev, pkg-config, 
devscripts
+Build-Depends: debhelper (>= 9), dh-systemd (>= 1.3), libcap-dev, libcap2-bin, 
libpcre3-dev, libpng-dev, libpoco-dev (>= 1.7.5), linux-libc-dev, nodejs, 
python-polib, python-lxml, fontconfig, libpam-dev, libcppunit-dev, pkg-config, 
devscripts, m4
 Standards-Version: 3.9.7
 
 Package: loolwsd
diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index 929bff10b..c0e8847a4 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -17,7 +17,7 @@ Vendor: %{vendor}
 Summary:LibreOffice Online WebSocket Daemon
 License:MPL
 Source0:loolwsd-@package_vers...@.tar.gz
-BuildRequires:  libcap-devel libpng-devel poco-devel >= 1.7.5
+BuildRequires:  libcap-devel libpng-devel poco-devel >= 1.7.5 m4
 %if 0%{?fedora} || 0%{?rhel} >= 7
 BuildRequires:  libpcap kernel-headers
 %else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_svg

[Libreoffice Gerrit user]

 icon-themes/sifr/cmd/lc_adddirect.png|binary
 icon-themes/sifr/cmd/lc_addfield.png |binary
 icon-themes/sifr/cmd/lc_alignblock.png   |binary
 icon-themes/sifr/cmd/lc_aligncenter.png  |binary
 icon-themes/sifr/cmd/lc_aligndown.png|binary
 icon-themes/sifr/cmd/lc_alignhorizontalcenter.png|binary
 icon-themes/sifr/cmd/lc_alignleft.png|binary
 icon-themes/sifr/cmd/lc_alignmiddle.png  |binary
 icon-themes/sifr/cmd/lc_alignright.png   |binary
 icon-themes/sifr/cmd/lc_alignup.png  |binary
 icon-themes/sifr/cmd/lc_datafilterstandardfilter.png |binary
 icon-themes/sifr/cmd/lc_objectalign.png  |binary
 icon-themes/sifr/cmd/lc_objectalignleft.png  |binary
 icon-themes/sifr/cmd/lc_objectalignright.png |binary
 icon-themes/sifr/cmd/sc_adddirect.png|binary
 icon-themes/sifr/cmd/sc_addfield.png |binary
 icon-themes/sifr/cmd/sc_alignblock.png   |binary
 icon-themes/sifr/cmd/sc_aligncenter.png  |binary
 icon-themes/sifr/cmd/sc_aligndown.png|binary
 icon-themes/sifr/cmd/sc_alignhorizontalcenter.png|binary
 icon-themes/sifr/cmd/sc_alignleft.png|binary
 icon-themes/sifr/cmd/sc_alignmiddle.png  |binary
 icon-themes/sifr/cmd/sc_alignright.png   |binary
 icon-themes/sifr/cmd/sc_alignup.png  |binary
 icon-themes/sifr/cmd/sc_datafilterstandardfilter.png |binary
 icon-themes/sifr/cmd/sc_objectalign.png  |binary
 icon-themes/sifr/cmd/sc_objectalignleft.png  |binary
 icon-themes/sifr/cmd/sc_objectalignright.png |binary
 icon-themes/sifr_svg/cmd/lc_adddirect.svg|   10 
 icon-themes/sifr_svg/cmd/lc_addfield.svg |   18 +++
 icon-themes/sifr_svg/cmd/lc_alignblock.svg   |6 +
 icon-themes/sifr_svg/cmd/lc_aligncenter.svg  |6 +
 icon-themes/sifr_svg/cmd/lc_aligndown.svg|6 +
 icon-themes/sifr_svg/cmd/lc_alignhorizontalcenter.svg|6 +
 icon-themes/sifr_svg/cmd/lc_alignleft.svg|6 +
 icon-themes/sifr_svg/cmd/lc_alignmiddle.svg  |6 +
 icon-themes/sifr_svg/cmd/lc_alignright.svg   |6 +
 icon-themes/sifr_svg/cmd/lc_alignup.svg  |6 +
 icon-themes/sifr_svg/cmd/lc_datafilterstandardfilter.svg |6 +
 icon-themes/sifr_svg/cmd/lc_objectalign.svg  |6 +
 icon-themes/sifr_svg/cmd/lc_objectalignleft.svg  |6 +
 icon-themes/sifr_svg/cmd/lc_objectalignright.svg |6 +
 icon-themes/sifr_svg/cmd/sc_adddirect.svg|   10 
 icon-themes/sifr_svg/cmd/sc_addfield.svg |   14 +++
 icon-themes/sifr_svg/cmd/sc_alignblock.svg   |6 +
 icon-themes/sifr_svg/cmd/sc_aligncenter.svg  |6 +
 icon-themes/sifr_svg/cmd/sc_aligndown.svg|6 +
 icon-themes/sifr_svg/cmd/sc_alignhorizontalcenter.svg|6 +
 icon-themes/sifr_svg/cmd/sc_alignleft.svg|6 +
 icon-themes/sifr_svg/cmd/sc_alignmiddle.svg  |6 +
 icon-themes/sifr_svg/cmd/sc_alignright.svg   |6 +
 icon-themes/sifr_svg/cmd/sc_alignup.svg  |6 +
 icon-themes/sifr_svg/cmd/sc_datafilterstandardfilter.svg |6 +
 icon-themes/sifr_svg/cmd/sc_objectalign.svg  |6 +
 icon-themes/sifr_svg/cmd/sc_objectalignleft.svg  |6 +
 icon-themes/sifr_svg/cmd/sc_objectalignright.svg |6 +
 56 files changed, 196 insertions(+)

New commits:
commit d872cd935e16525e22db1ee43a75d5913ebefcf5
Author: andreas kainz 
AuthorDate: Mon Jan 14 01:00:33 2019 +0100
Commit: andreas_kainz 
CommitDate: Mon Jan 14 15:45:13 2019 +0100

Sifr icon theme: add svg align icons

Change-Id: I39d20716420233bfe9545fd997ee4364548c3552
Reviewed-on: https://gerrit.libreoffice.org/66278
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/sifr/cmd/lc_adddirect.png 
b/icon-themes/sifr/cmd/lc_adddirect.png
index 49c348807dd1..48e102279bfc 100644
Binary files a/icon-themes/sifr/cmd/lc_adddirect.png and 
b/icon-themes/sifr/cmd/lc_adddirect.png differ
diff --git a/icon-themes/sifr/cmd/lc_addfield.png 
b/icon-themes/sifr/cmd/lc_addfield.png
index ae8b144de34e..93a1ccd30cc9 100644
Binary files a/icon-themes/sifr/cmd/lc_addfield.png and 
b/icon-themes/sifr/cmd/lc_addfield.png differ
diff --git a/icon-themes/sifr/cmd/lc_alignblock.png 
b/icon-themes/sifr/cmd/lc_alignblock.png
index c754717864a9..a83aff773637 100644
Binary files a/icon-themes/sifr/cmd/lc_alignblock.png and 

[Libreoffice-commits] help.git: source/text

[Libreoffice Gerrit user]

 source/text/shared/guide/start_parameters.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9c8587d4fb6450302aa85054d4199f9fa1194818
Author: Olivier Hallot 
AuthorDate: Mon Jan 14 14:36:30 2019 -0200
Commit: Mike Kaganski 
CommitDate: Mon Jan 14 19:29:34 2019 +0100

tdf#117312 clarify --cat in start parameters

Change-Id: Ia519899081e5bbceca7aedc2cb8b0d84549cbd88
Reviewed-on: https://gerrit.libreoffice.org/66330
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/source/text/shared/guide/start_parameters.xhp 
b/source/text/shared/guide/start_parameters.xhp
index 8535922ec..26f897f0c 100644
--- a/source/text/shared/guide/start_parameters.xhp
+++ b/source/text/shared/guide/start_parameters.xhp
@@ -498,7 +498,7 @@
--cat


-   Dump text content of the following files to console (implies 
--headless). Cannot be used with 
--convert-to.
+   Applies filter "txt:Text" to the following text documents and 
dump text content to console (implies --headless). Cannot be used 
with --convert-to.


 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Libreoffice Gerrit user]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 97be67bbd6bd72fb510814e1fbb9dfc65d190f78
Author: Olivier Hallot 
AuthorDate: Mon Jan 14 14:36:30 2019 -0200
Commit: Gerrit Code Review 
CommitDate: Mon Jan 14 19:29:34 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - tdf#117312 clarify --cat in start parameters

Change-Id: Ia519899081e5bbceca7aedc2cb8b0d84549cbd88
Reviewed-on: https://gerrit.libreoffice.org/66330
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/helpcontent2 b/helpcontent2
index 37852a4343f3..9c8587d4fb64 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 37852a4343f3a9023ac6481947acd401dd9fe55d
+Subproject commit 9c8587d4fb6450302aa85054d4199f9fa1194818
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - bridges/Library_cpp_uno.mk

[Libreoffice Gerrit user]

 bridges/Library_cpp_uno.mk |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit e3dd9f0fcf6f8293a3a22d43c30eb4a297cc03f2
Author: Damjan Jovanovic 
AuthorDate: Mon Jan 14 17:23:33 2019 +
Commit: Damjan Jovanovic 
CommitDate: Mon Jan 14 17:23:33 2019 +

Fix the path to s5abi_macosx_x86-64 (the last separator is a minus,

not an underscore).

Patch by: me

diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk
index 86e0f9c51c13..e4c214a4bb1a 100644
--- a/bridges/Library_cpp_uno.mk
+++ b/bridges/Library_cpp_uno.mk
@@ -454,10 +454,10 @@ else ifeq 
($(OS)-$(CPUNAME)-$(COMNAME),MACOSX-X86_64-s5abi)
 ###
 
 $(eval $(call gb_Library_add_exception_objects,$(COMNAME)_uno,\
-   bridges/source/cpp_uno/s5abi_macosx_x86_64/abi \
-   bridges/source/cpp_uno/s5abi_macosx_x86_64/except \
-   bridges/source/cpp_uno/s5abi_macosx_x86_64/cpp2uno \
-   bridges/source/cpp_uno/s5abi_macosx_x86_64/uno2cpp \
+   bridges/source/cpp_uno/s5abi_macosx_x86-64/abi \
+   bridges/source/cpp_uno/s5abi_macosx_x86-64/except \
+   bridges/source/cpp_uno/s5abi_macosx_x86-64/cpp2uno \
+   bridges/source/cpp_uno/s5abi_macosx_x86-64/uno2cpp \
 ))
 
 #
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Branch 'libreoffice-6-2' - source/sl

[Libreoffice Gerrit user]

 source/sl/chart2/messages.po   
|   54 
 source/sl/connectivity/registry/mysql_jdbc/org/openoffice/Office/DataAccess.po 
|6 
 source/sl/cui/messages.po  
|   10 -
 source/sl/dbaccess/messages.po 
|   42 +++---
 source/sl/formula/messages.po  
|   21 ++-
 source/sl/helpcontent2/source/text/sbasic/shared.po
|   12 -
 source/sl/helpcontent2/source/text/scalc/00.po 
|4 
 source/sl/helpcontent2/source/text/scalc/01.po 
|   18 +-
 source/sl/helpcontent2/source/text/scalc/02.po 
|4 
 source/sl/helpcontent2/source/text/scalc/guide.po  
|4 
 source/sl/helpcontent2/source/text/shared.po   
|6 
 source/sl/helpcontent2/source/text/shared/00.po
|4 
 source/sl/helpcontent2/source/text/shared/01.po
|   20 +--
 source/sl/helpcontent2/source/text/shared/02.po
|4 
 source/sl/helpcontent2/source/text/shared/04.po
|6 
 source/sl/helpcontent2/source/text/shared/explorer/database.po 
|   20 +--
 source/sl/helpcontent2/source/text/shared/guide.po 
|4 
 source/sl/helpcontent2/source/text/shared/optionen.po  
|   10 -
 source/sl/helpcontent2/source/text/swriter.po  
|4 
 source/sl/helpcontent2/source/text/swriter/01.po   
|6 
 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po  
|   16 +-
 source/sl/sc/messages.po   
|   16 +-
 source/sl/sd/messages.po   
|   64 +-
 source/sl/sfx2/messages.po 
|   10 -
 source/sl/svx/messages.po  
|4 
 source/sl/sw/messages.po   
|8 -
 source/sl/vcl/messages.po  
|   40 +++---
 27 files changed, 213 insertions(+), 204 deletions(-)

New commits:
commit 3af8fa3625c380fc9dc417b247cc230ddda73f8d
Author: Andras Timar 
AuthorDate: Mon Jan 14 20:59:50 2019 +0100
Commit: Andras Timar 
CommitDate: Mon Jan 14 20:59:50 2019 +0100

Updated Slovenian translation

Change-Id: I07561f22049061a2f8f3abcef7576bdd06e381b8

diff --git a/source/sl/chart2/messages.po b/source/sl/chart2/messages.po
index 5c8c613b15d..797a10f0fca 100644
--- a/source/sl/chart2/messages.po
+++ b/source/sl/chart2/messages.po
@@ -3,7 +3,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 6.2\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2018-12-18 10:10+0100\n"
+"POT-Creation-Date: 2019-01-12 17:20+0100\n"
 "PO-Revision-Date: 2018-12-05 00:05+0200\n"
 "Last-Translator: Martin Srebotnjak \n"
 "Language-Team: sl.libreoffice.org\n"
@@ -2694,120 +2694,120 @@ msgctxt "tp_RangeChooser|STR_PAGE_DATA_RANGE"
 msgid "Data Range"
 msgstr "Obseg podatkov"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:63
+#: chart2/uiconfig/ui/tp_Scale.ui:59
 msgctxt "tp_Scale|CBX_REVERSE"
 msgid "_Reverse direction"
 msgstr "_Nasprotna smer"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:79
+#: chart2/uiconfig/ui/tp_Scale.ui:75
 msgctxt "tp_Scale|CBX_LOGARITHM"
 msgid "_Logarithmic scale"
 msgstr "_Logaritmično merilo"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:102
+#: chart2/uiconfig/ui/tp_Scale.ui:98
 msgctxt "tp_Scale|TXT_AXIS_TYPE"
 msgid "T_ype"
 msgstr "V_rsta"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:118
+#: chart2/uiconfig/ui/tp_Scale.ui:114
 msgctxt "tp_Scale|LB_AXIS_TYPE"
 msgid "Automatic"
 msgstr "Samodejno"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:119
+#: chart2/uiconfig/ui/tp_Scale.ui:115
 msgctxt "tp_Scale|LB_AXIS_TYPE"
 msgid "Text"
 msgstr "Besedilo"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:120
+#: chart2/uiconfig/ui/tp_Scale.ui:116
 msgctxt "tp_Scale|LB_AXIS_TYPE"
 msgid "Date"
 msgstr "Datum"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:153
+#: chart2/uiconfig/ui/tp_Scale.ui:149
 msgctxt "tp_Scale|TXT_MIN"
 msgid "_Minimum"
 msgstr "N_ajmanj"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:167
+#: chart2/uiconfig/ui/tp_Scale.ui:163
 msgctxt "tp_Scale|TXT_MAX"
 msgid "Ma_ximum"
 msgstr "Na_jveč"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:179
+#: chart2/uiconfig/ui/tp_Scale.ui:175
 msgctxt "tp_Scale|CBX_AUTO_MIN"
 msgid "_Automatic"
 msgstr "S_amodejno"
 
-#: chart2/uiconfig/ui/tp_Scale.ui:194
+#: chart2/uiconfig/ui/tp_Scale.ui:190
 msgctxt "tp_Scale|CBX_AUTO_MAX"
 msgid 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - translations

[Libreoffice Gerrit user]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 44a24c1c565a6b0651c239dcda843f8bfa3c0600
Author: Andras Timar 
AuthorDate: Mon Jan 14 20:59:50 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Mon Jan 14 20:59:58 2019 +0100

Update git submodules

* Update translations from branch 'libreoffice-6-2'
  - Updated Slovenian translation

Change-Id: I07561f22049061a2f8f3abcef7576bdd06e381b8

diff --git a/translations b/translations
index c1299cddf602..3af8fa3625c3 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit c1299cddf602f746c2bf47435fbce62a02b1b3e0
+Subproject commit 3af8fa3625c380fc9dc417b247cc230ddda73f8d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/ww8atr.cxx |   20 +++-
 1 file changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 1a6367269df971dd6764db419162896170b4b21d
Author: Justin Luth 
AuthorDate: Wed Nov 28 15:44:27 2018 +0300
Commit: Justin Luth 
CommitDate: Mon Jan 14 20:32:04 2019 +0100

tdf#12 ww8export: fillstyle_NONE needs a nil background

Without this, there is no way to cancel out an inherited
background color.

tdf#116071's unit test depends on this
fix in order to round-trip.

Change-Id: I99ad28ee87a6bea040e0ef3c712c1c911be70004
Reviewed-on: https://gerrit.libreoffice.org/64185
Tested-by: Justin Luth 
Reviewed-by: Justin Luth 

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 5120aa5f9094..44b3321fe3a2 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -4216,8 +4216,26 @@ void WW8AttributeOutput::FormatBackground( const 
SvxBrushItem& rBrush )
 }
 }
 
-void WW8AttributeOutput::FormatFillStyle( const XFillStyleItem& /*rFillStyle*/ 
)
+void WW8AttributeOutput::FormatFillStyle( const XFillStyleItem& rFillStyle )
 {
+// WW cannot have background in a section
+if ( !m_rWW8Export.m_bOutPageDescs )
+{
+// see MSWordExportBase::OutputItemSet for how _SOLID is handled
+if ( rFillStyle.GetValue() == drawing::FillStyle_NONE )
+{
+//Shd80Nil
+m_rWW8Export.InsUInt16( NS_sprm::sprmPShd80 );
+m_rWW8Export.InsUInt16( 0x );
+
+//cvAuto
+m_rWW8Export.InsUInt16( NS_sprm::sprmPShd );
+m_rWW8Export.pO->push_back( 10 );
+m_rWW8Export.InsUInt32( 0xFF00 );
+m_rWW8Export.InsUInt32( 0xFF00 );
+m_rWW8Export.InsUInt16( 0x );
+}
+}
 }
 
 void WW8AttributeOutput::FormatFillGradient( const XFillGradientItem& 
/*rFillGradient*/ )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: How to re-trigger a single build job in gerrit?

[Matteo Casalin]

Thanks Miklos.
Kind regards
Matteo

On 1/14/19 9:15 AM, Miklos Vajna wrote:

Hi Matteo,

On Sun, Jan 13, 2019 at 11:18:55AM +0100, Matteo Casalin 
 wrote:

executing all of the jobs (gerrit_linux*, gerrit_macos, gerrit_windows)? Up
to know I just rebased the patch, but this looks to me as quite inefficient.


Register at ci.libreoffice.org, then talk to the infra guys at
#tdf-infra (freenode IRC), once you get the right to "resume a build",
you would see an extra button on the Jenkins UI to do exactly this: just
try the failing builds once more, without rebuilding already successful
platforms.

Regards,

Miklos


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libra Office-Android developer] My Introduction to the Libra office community

[Dundi Raja Vamsi Reddy]

Hello Everyone,

My name is Dundi Raja Vamsi Reddy. I am a Computer Science student at
SMVDU, Katra, India. I am interested in contributing to your community. I
heard about the Libra Office Community.

I am Comfortable with Java and Android and recently I began learning the
React. I am also familiar with JavaScript but have not used it extensively
over the past year but I will come up to speed as required. I am also
interested to participate in the upcoming GSoC 2019 competition as an
intern.
Can you please guide me where I can get started?
Thanks very much.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Building LO 6.0.7.3 with system-wide poppler 0.73.0 fails for several reasons

[Дилян Палаузов]

Hello,

poppler-0.73.0/NEWS contains:

Release 0.71.0:
core:
 * Replace GBool, gTrue, and gFalse by bool, true, false, resp.

Compiling LO 6.0.7.3 with system-wide poppler 0.73.0 fails with the erroro 
below and one of the reason is the assumption
in LO, that GBool is defined.

poppler-0.73.0/poppler/OutputDev.h declares:

virtual void setDefaultCTM(const double *ctm); ⇐ with const, while 
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hpp
contains:
   virtual void setDefaultCTM(double *ctm) override; ⇐ without const

without const…

Regards
  Дилян
--

[build CXX] sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
[build CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx
[build CXX] sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
In file included from 
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:20:
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:153:17:
 error: ‘GBool’ does not name a
type; did you mean ‘bool’?
 virtual GBool upsideDown() override { return gTrue; }
 ^
 bool
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:156:17:
 error: ‘GBool’ does not name a
type; did you mean ‘bool’?
 virtual GBool useDrawChar() override { return gTrue; }
 ^
 bool
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:160:17:
 error: ‘GBool’ does not name a
type; did you mean ‘bool’?
 virtual GBool interpretType3Chars() override { return gFalse; }
 ^
 bool
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:163:17:
 error: ‘GBool’ does not name a
type; did you mean ‘bool’?
 virtual GBool needNonText() override { return gTrue; }
 ^
 bool
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:235:59:
 error: ‘GBool’ has not been
declared
int width, int height, GBool invert,
   ^
In file included from 
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24,
 from 
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:153:17:
 error: ‘GBool’ does not name a
type; did you mean ‘bool’?
 virtual GBool upsideDown() override { return gTrue; }
 ^
 bool
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:237:36:
 error: ‘GBool’ has not been
declared
GBool interpolate,
^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:239:36:
 error: ‘GBool’ has not been
declared
GBool inlineImg) override;
^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:243:32:
 error: ‘GBool’ has not been
declared
GBool interpolate,
^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:245:49:
 error: ‘GBool’ has not been
declared
int *maskColors, GBool inlineImg) override;
 ^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:250:38:
 error: ‘GBool’ has not been
declared
  GBool interpolate,
  ^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:253:38:
 error: ‘GBool’ has not been
declared
  GBool maskInvert
  ^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:255:40:
 error: ‘GBool’ has not been
declared
  , GBool maskInterpolate
^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:262:42:
 error: ‘GBool’ has not been
declared
  GBool interpolate,
  ^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:268:44:
 error: ‘GBool’ has not been
declared
  , GBool maskInterpolate
^
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:168:22:
 error: ‘virtual void
pdfi::PDFOutDev::setDefaultCTM(double*)’ marked ‘override’, but does not 
override
 virtual void setDefaultCTM(double *ctm) override;
  ^

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - cpputools/Executable_regsingleton.mk cpputools/Executable_sp2bv.mk solenv/inc

[Libreoffice Gerrit user]

 cpputools/Executable_regsingleton.mk |6 ++
 cpputools/Executable_sp2bv.mk|5 +
 solenv/inc/unxmacc.mk|2 +-
 solenv/inc/unxmacx.mk|2 +-
 4 files changed, 13 insertions(+), 2 deletions(-)

New commits:
commit f454c3c33c87ed1e754ba5b5cdde1b72cfb56ac5
Author: Jim Jagielski 
AuthorDate: Mon Jan 14 21:24:02 2019 +
Commit: Jim Jagielski 
CommitDate: Mon Jan 14 21:24:02 2019 +

Force -dynamiclib with -install_name and allow for max pathlen, just in case

diff --git a/cpputools/Executable_regsingleton.mk 
b/cpputools/Executable_regsingleton.mk
index 747a01a94ea5..364897c54aac 100644
--- a/cpputools/Executable_regsingleton.mk
+++ b/cpputools/Executable_regsingleton.mk
@@ -31,6 +31,12 @@ $(eval $(call gb_Executable_add_linked_libs,regsingleton,\
 $(gb_STDLIBS) \
 ))
 
+ifeq ($(OS),MACOSX)
+$(eval $(call gb_Executable_add_ldflags,regsingleton,\
+   -dynamiclib -headerpad_max_install_names \
+))
+endif
+
 $(eval $(call 
gb_Executable_set_private_extract_of_public_api,regsingleton,$(OUTDIR)/bin/udkapi.rdb,\
com.sun.star.uno.TypeClass \
com.sun.star.uno.XAggregation \
diff --git a/cpputools/Executable_sp2bv.mk b/cpputools/Executable_sp2bv.mk
index 17f4294ce336..4fa1ad524bbd 100644
--- a/cpputools/Executable_sp2bv.mk
+++ b/cpputools/Executable_sp2bv.mk
@@ -29,6 +29,11 @@ $(eval $(call gb_Executable_add_linked_libs,sp2bv,\
 $(gb_STDLIBS) \
 ))
 
+ifeq ($(OS),MACOSX)
+$(eval $(call gb_Executable_add_ldflags,sp2bv,\
+   -dynamiclib -headerpad_max_install_names \
+))
+endif
 $(eval $(call gb_Executable_add_exception_objects,sp2bv,\
cpputools/source/sp2bv/sp2bv \
 ))
diff --git a/solenv/inc/unxmacc.mk b/solenv/inc/unxmacc.mk
index 8150c5c0819e..4e9cca9ccef8 100644
--- a/solenv/inc/unxmacc.mk
+++ b/solenv/inc/unxmacc.mk
@@ -167,7 +167,7 @@ LINK*=$(CXX)
 LINKC*=$(CC)
 
 ###LINKFLAGSDEFS*=-Wl,-multiply_defined,suppress
-EXTRA_LINKFLAGS*=-L$(MACOSX_SDK_PATH) -Wl,-headerpad,ff
+EXTRA_LINKFLAGS*=-L$(MACOSX_SDK_PATH) -Wl,-headerpad_max_install_names
 LINKFLAGSRUNPATH_URELIB=-install_name '@___URELIB/$(@:f)'
 LINKFLAGSRUNPATH_UREBIN=
 LINKFLAGSRUNPATH_OOO=-install_name '@___OOO/$(@:f)'
diff --git a/solenv/inc/unxmacx.mk b/solenv/inc/unxmacx.mk
index ec23c4349405..dc19e67dc7a8 100644
--- a/solenv/inc/unxmacx.mk
+++ b/solenv/inc/unxmacx.mk
@@ -186,7 +186,7 @@ LIBSTLPORTST=$(SOLARVERSION)/$(INPATH)/lib/libstlport_gcc.a
 LINK*=$(CXX)
 LINKC*=$(CC)
 
-LINKFLAGSDEFS*=-Wl,-headerpad,ff,-multiply_defined,suppress
+LINKFLAGSDEFS*=-Wl,-headerpad_max_install_names,-multiply_defined,suppress
 # assure backwards-compatibility
 EXTRA_LINKFLAGS*=-Wl,-syslibroot,/Developer/SDKs/MacOSX10.4u.sdk
 LINKFLAGSRUNPATH_URELIB=-install_name '@___URELIB/$(@:f)'
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Weekly QA Report (W02-2019)

[Xisco Fauli]

Hello,

What have happened in QA in the last 7 days?

  * 175 bugs have been reported by 107 people.
        + Link: http://tinyurl.com/y9f36g6a

  * Top 10 reporters:
        + Nicolas Christener (20)
        + ricky.tigg (7)
        + Cor Nouws (7)
        + Telesto (5)
        + Jim Avera (5)
        + Gabor Kelemen (4)
        + Andy (3)
        + Robert Großkopf (3)
        + 和尚蟹 (3)
        + NISZ LibreOffice Team (3)

  * Top 10 commenters:
        + Xisco Faulí (182)
        + Cor Nouws (63)
        + Timur (50)
        + Roman Kuznetsov (44)
        + Caolán McNamara (38)
        + Dieter Praas (29)
        + Heiko Tietze (27)
        + raal (27)
        + Buovjaga (26)
        + durgapriyanka.arun (24)

  * 60 bugs reported haven't been triaged yet.
        + Link: http://tinyurl.com/ydddt42n

  * Total number of unconfirmed bugs: 532

  * 1176 comments have been written by 222 people.

  * 72 new people have signed up to Bugzilla.

== STATUSES CHANGED ==
  * 1 bug has been changed from 'ASSIGNED' to 'NEEDINFO'.
        + Link: http://tinyurl.com/ybl3tdrp
        + Done by:
  Florian Reisinger (1)

  * 2 bugs have been changed from 'ASSIGNED' to 'NEW'.
        + Link: http://tinyurl.com/ybxhrj7g
        + Done by:
  Heiko Tietze (1), Balázs Varga (1)

  * 2 bugs have been changed from 'ASSIGNED' to 'RESOLVED DUPLICATE'.
        + Link: http://tinyurl.com/yd5n7qnw
        + Done by:
  Xisco Faulí (1), Bartosz (1)

  * 33 bugs have been changed from 'ASSIGNED' to 'RESOLVED FIXED'.
        + Link: http://tinyurl.com/ydczjduo
        + Done by:
  Caolán McNamara (18), Bartosz (3), Xisco Faulí (2),
  László Németh (2), Justin L (2), Winfried Donkers (1),
  Heiko Tietze (1), Mike Kaganski (1), Adolfo Jayme (1),
  Aditya Sahu (1), Armin Le Grand (CIB) (1)

  * 6 bugs have been changed from 'NEEDINFO' to 'NEW'.
        + Link: http://tinyurl.com/yc7rlza2
        + Done by:
  Franklin Schiftan (2), Xisco Faulí (1), Jacques Beckand (1),
  Timur (1), Cor Nouws (1)

  * 3 bugs have been changed from 'NEEDINFO' to 'RESOLVED DUPLICATE'.
        + Link: http://tinyurl.com/yah888c2
        + Done by:
  Xisco Faulí (2), Timur (1)

  * 5 bugs have been changed from 'NEEDINFO' to 'RESOLVED FIXED'.
        + Link: http://tinyurl.com/y8ov8z44
        + Done by:
  和尚蟹 (1), Uwe Hartwig (1), Lifeisgreat (1), Tamas Bunth (1),
  Alfredo (1)

  * 51 bugs have been changed from 'NEEDINFO' to 'RESOLVED
INSUFFICIENTDATA'.
        + Link: http://tinyurl.com/y7nlgg3b
        + Done by:
  qa-admin (51)

  * 1 bug has been changed from 'NEEDINFO' to 'RESOLVED INVALID'.
        + Link: http://tinyurl.com/ycozco7w
        + Done by:
  Eyal Rozenberg (1)

  * 1 bug has been changed from 'NEEDINFO' to 'RESOLVED NOTABUG'.
        + Link: http://tinyurl.com/y7vq9lhz
        + Done by:
  Oliver Brinzing (1)

  * 1 bug has been changed from 'NEEDINFO' to 'RESOLVED NOTOURBUG'.
        + Link: http://tinyurl.com/y7sc3rum
        + Done by:
  Buovjaga (1)

  * 3 bugs have been changed from 'NEEDINFO' to 'RESOLVED WORKSFORME'.
        + Link: http://tinyurl.com/ybcw38dz
        + Done by:
  Xisco Faulí (1), Buovjaga (1), Franklin Weng (1)

  * 23 bugs have been changed from 'NEEDINFO' to 'UNCONFIRMED'.
        + Link: http://tinyurl.com/ya4qwj6x
        + Done by:
  raal (2), photographen (2), ibelin123 (1), Xisco Faulí (1),
  Vera Blagoveschenskaya (1), Thierry Seewald (1), Telesto (1),
  Richard Elkins (1), rbird (1), Regina Henschel (1),
  Libomark (1), la .myrf. (1), lj308 (1), lin (1), sfrjoe (1),
  Chameleon (1), enanitoleg (1), cr...@arno.com (1),
  cmflatscher (1), Aron Budea (1), Markus Elfring (1)

  * 41 bugs have been changed from 'NEW' to 'ASSIGNED'.
        + Link: http://tinyurl.com/yanmfxgb
        + Done by:
  Caolán McNamara (17), Xisco Faulí (5), Heiko Tietze (2),
  László Németh (2), Mike Kaganski (2), Justin L (2),
  Bartosz (2), Miklos Vajna (1), rishi.vikram.1 (1), raal (1),
  Tobias Lippert (1), Eike Rathke (1), Aleksei Nikiforov (1),
  Aditya Sahu (1), Katarina Behrens (CIB) (1),
  Armin Le Grand (CIB) (1)

  * 13 bugs have been changed from 'NEW' to 'NEEDINFO'.
        + Link: http://tinyurl.com/y8rv9glh
        + Done by:
  Xisco Faulí (4), Buovjaga (2), Thorsten Behrens (CIB) (2),
  Heiko Tietze (1), Oliver Brinzing (1), Timur (1),
  Cor Nouws (1), Caolán McNamara (1)

  * 16 bugs have been changed from 'NEW' to 'RESOLVED DUPLICATE'.
        + Link: http://tinyurl.com/ybsdct4x
        + Done by:
  Xisco Faulí (5), Timur (3), Roman Kuznetsov (2),
  Buovjaga (1), Oliver Brinzing (1), Maxim Monastirsky (1),
  Caolán McNamara (1), Balázs Varga (1),
  Katarina Behrens (CIB) (1)

  * 12 bugs have been changed from 'NEW' to 'RESOLVED 

[Libreoffice-commits] core.git: 2 commits - include/svx sd/source svx/source vcl/unx

[Libreoffice Gerrit user]

 include/svx/svdhdl.hxx   |3 ++
 include/svx/svdmrkv.hxx  |1 
 include/svx/svdpntv.hxx  |1 
 include/svx/svdview.hxx  |1 
 sd/source/ui/func/fudraw.cxx |3 ++
 sd/source/ui/view/viewoverlaymanager.cxx |   39 ++-
 svx/source/svdraw/svdhdl.cxx |4 +++
 svx/source/svdraw/svdmrkv.cxx|   19 +++
 vcl/unx/gtk3/gtk3gtkinst.cxx |1 
 9 files changed, 66 insertions(+), 6 deletions(-)

New commits:
commit 423d70f7e45749fad680b3dfe0ccdaed1c1afb19
Author: Caolán McNamara 
AuthorDate: Mon Jan 14 10:56:04 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Jan 14 21:55:25 2019 +0100

Resolves: tdf#122695 Content Type selector tooltip missing

Change-Id: I0ffe6448d865f569fb59d9facbb1582d2152a9ba
Reviewed-on: https://gerrit.libreoffice.org/66291
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index caf95813973d..5832e33bc2ac 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -242,6 +242,9 @@ public:
 visualisation during mouse over it must override this method and call 
Touch(). */
 virtual void onMouseEnter(const MouseEvent& rMEvt);
 
+/** is called when help is requested for the area of this handle */
+virtual void onHelpRequest(const HelpEvent& rHEvt);
+
 /** is called when the mouse leaves the area of this handle. If the handle 
changes his
 visualisation during mouse over it must override this method and call 
Touch(). */
 virtual void onMouseLeave();
diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx
index 83eefb9dd54f..a864477fb80b 100644
--- a/include/svx/svdmrkv.hxx
+++ b/include/svx/svdmrkv.hxx
@@ -150,6 +150,7 @@ protected:
 void CheckMarked();  
// Scan MarkList after Del and Lock Layer ...
 void AddDragModeHdl(SdrDragMode eMode);
 virtual bool MouseMove(const MouseEvent& rMEvt, vcl::Window* pWin) 
override;
+virtual bool RequestHelp(const HelpEvent& rHEvt) override;
 
 // add custom handles (used by other apps, e.g. AnchorPos)
 virtual void AddCustomHdl();
diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx
index 2913850ed04b..429e9b96f020 100644
--- a/include/svx/svdpntv.hxx
+++ b/include/svx/svdpntv.hxx
@@ -463,6 +463,7 @@ public:
 virtual bool MouseButtonDown(const MouseEvent& /*rMEvt*/, vcl::Window* 
/*pWin*/) { return false; }
 virtual bool MouseButtonUp(const MouseEvent& /*rMEvt*/, vcl::Window* 
/*pWin*/) { return false; }
 virtual bool MouseMove(const MouseEvent& /*rMEvt*/, vcl::Window* /*pWin*/) 
{ return false; }
+virtual bool RequestHelp(const HelpEvent& /*rHEvt*/) { return false; }
 virtual bool Command(const CommandEvent& /*rCEvt*/, vcl::Window* /*pWin*/) 
{ return false; }
 
 void GetAttributes(SfxItemSet& rTargetSet, bool bOnlyHardAttr) const;
diff --git a/include/svx/svdview.hxx b/include/svx/svdview.hxx
index 149bffcb872f..a63618089747 100644
--- a/include/svx/svdview.hxx
+++ b/include/svx/svdview.hxx
@@ -187,6 +187,7 @@ public:
 virtual bool MouseButtonDown(const MouseEvent& rMEvt, vcl::Window* pWin) 
override;
 virtual bool MouseButtonUp(const MouseEvent& rMEvt, vcl::Window* pWin) 
override;
 virtual bool MouseMove(const MouseEvent& rMEvt, vcl::Window* pWin) 
override;
+using SdrCreateView::RequestHelp;
 virtual bool Command(const CommandEvent& rCEvt, vcl::Window* pWin) 
override;
 
 virtual void ConfigurationChanged( utl::ConfigurationBroadcaster*, 
ConfigurationHints ) override;
diff --git a/sd/source/ui/func/fudraw.cxx b/sd/source/ui/func/fudraw.cxx
index 6b3872fefdae..2ecc44fe0a20 100644
--- a/sd/source/ui/func/fudraw.cxx
+++ b/sd/source/ui/func/fudraw.cxx
@@ -765,6 +765,9 @@ bool FuDraw::RequestHelp(const HelpEvent& rHEvt)
 bReturn = FuPoor::RequestHelp(rHEvt);
 }
 
+if (!bReturn)
+   bReturn = mpView->RequestHelp(rHEvt);
+
 return bReturn;
 }
 
diff --git a/sd/source/ui/view/viewoverlaymanager.cxx 
b/sd/source/ui/view/viewoverlaymanager.cxx
index 5cf0f42fc5f0..1fa0b235ae07 100644
--- a/sd/source/ui/view/viewoverlaymanager.cxx
+++ b/sd/source/ui/view/viewoverlaymanager.cxx
@@ -146,10 +146,12 @@ public:
 virtual bool isMarkable() const override;
 
 virtual void onMouseEnter(const MouseEvent& rMEvt) override;
+virtual void onHelpRequest(const HelpEvent& rHEvt) override;
 virtual void onMouseLeave() override;
 
 int getHighlightId() const { return mnHighlightId; }
 
+void ShowTip();
 static void HideTip();
 
 private:
@@ -177,6 +179,35 @@ void ImageButtonHdl::HideTip()
 Help::HideBalloonAndQuickHelp();
 }
 
+void ImageButtonHdl::ShowTip()
+{
+if (!pHdlList || !pHdlList->GetView() || mnHighlightId == -1)
+return;
+
+

libreoffice pdfimport w/ poppler-0.73.0: build failure

[Andreas Sturmlechner]

In 6.2.0.2 (git master has no relevant commits over this part), libreoffice 
fails to build with:

In file included from /usr/src/portage/app-office/libreoffice-6.2.0.2/work/
libreoffice-6.2.0.2/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24,
 from /usr/src/portage/app-office/libreoffice-6.2.0.2/work/
libreoffice-6.2.0.2/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:281:9: error:  typedef Guchar 
Output_t;
 ^~
 u_char
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:282:22: error:  typedef 
std::vector< Output_t > OutputBuffer;
  ^~~~
cat 
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sysui/
desktop/mimetypes/openoffice.mime | tr -d "\015" > /usr/src/portage/app-office/
libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/workdir/CustomTarget/sysui/share/
libreoffice/openoffice.mime
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:282:22: note: suggested 
alternative: ‘OutputDev typedef std::vector< Output_t > OutputBuffer;
  ^~~~
  OutputDev
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:282:31: error: template 
argument 
1 is invalid
 typedef std::vector< Output_t > OutputBuffer;
   ^
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:282:31: error: template 
argument 
2 is invalid
In file included from /usr/src/portage/app-office/libreoffice-6.2.0.2/work/
libreoffice-6.2.0.2/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pnghelper.hxx:56:48: error:  static 
sal_uInt32 deflateBuffer( const Output_t* i_pBuf, size_t i_nLen, OutputBuffer& 
o_rOut );
^~~~
OutputDev
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pnghelper.hxx: In static member function ‘static 
void pdfi::PngHelper::append(sal_uInt32, OutputBuffer&)/usr/src/portage/app-
office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/source/pdfimport/
xpdfwrapper/pnghelper.hxx:42:40: error: request for member ‘size 
size_t nCur = o_rOutputBuf.size();
^~~~
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pnghelper.hxx:43:26: error: request for member 
‘insert o_rOutputBuf.insert( o_rOutputBuf.end(), 4, Output_t(0) );
  ^~
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pnghelper.hxx:43:47: error: request for member 
‘end o_rOutputBuf.insert( o_rOutputBuf.end(), 4, Output_t(0) );
   ^~~
/usr/src/portage/app-office/libreoffice-6.2.0.2/work/libreoffice-6.2.0.2/sdext/
source/pdfimport/xpdfwrapper/pnghelper.hxx:43:57: error:  
o_rOutputBuf.insert( o_rOutputBuf.end(), 4, Output_t(0) );
 ^~~~

(it goes on like that)

The relevant change in poppler 0.73 release notes:
* Remove Gulong, Guint, Gushort, Guchar typedefs

Regards,
Andreas



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/qa sw/source

[Libreoffice Gerrit user]

 sw/qa/extras/ooxmlexport/data/tdf122186_input_list.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |   11 +++
 sw/source/filter/ww8/docxattributeoutput.cxx   |2 +-
 3 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 35ea8fc24ae749b8a87b7ddb5df22ecc4f58cfd3
Author: Tamás Zolnai 
AuthorDate: Mon Jan 14 15:12:16 2019 +0100
Commit: Tamás Zolnai 
CommitDate: Tue Jan 15 01:59:40 2019 +0100

tdf#122186: Fix broken Input list after RT in DOCX format

We should not write out the text of the field, because it
confuses the import code and it's unneeded anyway.

Change-Id: Id114f74c5d135e9fe6cb059e25ebf324464c8362
Reviewed-on: https://gerrit.libreoffice.org/66338
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf122186_input_list.odt 
b/sw/qa/extras/ooxmlexport/data/tdf122186_input_list.odt
new file mode 100755
index ..76a6289f7045
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf122186_input_list.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index dac93371abb6..1f59e1c4db0a 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -86,6 +86,17 @@ DECLARE_OOXMLEXPORT_TEST(testDateControl, 
"empty-date-control.odt")
 assertXPathContent(pXmlDoc, 
"/w:document/w:body/w:p/w:sdt/w:sdtContent/w:r/w:t", u" ");
 }
 
+
+DECLARE_OOXMLEXPORT_TEST(testInputListExport, "tdf122186_input_list.odt")
+{
+// We need to make sure we don't export the text itself next to the input 
list field
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+return;
+assertXPath(pXmlDoc, "/w:document/w:body/w:p/w:r", 5);
+assertXPath(pXmlDoc, "/w:document/w:body/w:p/w:r[4]/w:t", 0);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index e845fe0655c7..00e6249d6faa 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -2030,7 +2030,7 @@ void DocxAttributeOutput::EndField_Impl( const 
SwTextNode* pNode, sal_Int32 nPos
 sExpand = static_cast(rInfos.pField.get())
 ->ExpandCitation(AUTH_FIELD_TITLE, nullptr);
 }
-else
+else if(rInfos.eType != ww::eFORMDROPDOWN)
 {
 sExpand = rInfos.pField->ExpandField(true, nullptr);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

[Дилян Палаузов]

Hello,

the LO source code requires const GooString*, but the 
/usr/local/include/poppler/OutputDev.h file had no const in the
declaration of drawString.  The installed poppler was newer than 0.64.0.

The hack is, that in the past I installed poppler and it installed OutputDev.h 
.  When I later compiled newer version of
poppler I have not passed ENABLE_XPDF_HEADERS / ENABLE_UNSTABLE_API_ABI_HEADERS 
to cmake and in turn “make install” has
not overwritten /usr/local/include/poppler/OutputDev.h.  This led to a 
situation with new libpoppler and old OutputDev.h
without const.  Indeed override triggered correctly.

--without-system-poppler mitigates.

Regards
  Дилян

On Mon, 2019-01-14 at 08:48 +, Kaganski Mike wrote:
> On 14.01.2019 11:46, Stephan Bergmann wrote:
> > On 13/01/2019 23:57, Дилян Палаузов wrote:
> > > LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting:
> > > 
> > > [build SPP] scp2/source/ooo/ure
> > > [build SCP] scp2/source/writer/file_writer
> > > [build SPP] scp2/source/xsltfilter/file_xsltfilter
> > > [build SPP] scp2/source/xsltfilter/module_xsltfilter
> > > [build SPP] scp2/source/gnome/file_gnome
> > > [build SPP] scp2/source/gnome/module_gnome
> > > [build SPP] scp2/source/sdkoo/sdkoo
> > > [build SCP] scp2/source/writer/module_writer
> > > [build CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx
> > > In file included from 
> > > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24,
> > >  
> > > 
> > >   from 
> > > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
> > >  
> > > 
> > > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22:
> > >  
> > > error: ‘virtual void
> > > pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked 
> > > ‘override’, but does not override
> > >   virtual void drawString(GfxState *state, const GooString *s) 
> > > override;
> > >^~
> > > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22:
> > >  
> > > warning:   by ‘virtual void
> > > pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ 
> > > [-Woverloaded-virtual]
> > > make[1]: *** 
> > > [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: 
> > > /src/libreoffice-
> > 
> > You likely need a backport of 
> > 
> >  
> > "fix build with poppler 0.64" (and maybe also backports of further 
> > poppler-adaption fixes in that area), or configure 
> > --without-system-poppler.
> > 
> > There is obviously always a chance that building old versions of LO 
> > against current system components does not work.  Often enough, you will 
> > find fixes for those issues in later versions of LO, and which are often 
> > even easy to backport to the version where you need them.
> 
> I'm afraid that the message implies that the fix from spring 2018 is 
> already there - the constness of the GooString parameter is there in the 
> message. So possibly there's some problem detecting the poppler library 
> version?
> 
> -- 
> Best regards,
> Mike Kaganski
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/ww8par.cxx  |   16 
 sw/source/filter/ww8/ww8par5.cxx |5 ++---
 sw/source/filter/ww8/ww8scan.cxx |   15 +++
 sw/source/filter/ww8/ww8scan.hxx |4 ++--
 4 files changed, 19 insertions(+), 21 deletions(-)

New commits:
commit 7883a5d1640f007ab05817540164043aa098b0dd
Author: Noel Grandin 
AuthorDate: Mon Jan 14 10:53:08 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:58:18 2019 +0100

use unique_ptr in WW8Style

Change-Id: I01b7b42d626a29b0702cc2aa51d0fdeb75282740
Reviewed-on: https://gerrit.libreoffice.org/66320
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 5df59ec42ccd..976fe8971f27 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -6875,9 +6875,9 @@ WW8Style::WW8Style(SvStream& rStream, WW8Fib& rFibPara)
 // so it has no empty slot, we should allocate memory and a pointer should
 // reference to STD (perhaps filled with 0). If the slot is empty,
 // it will return a null pointer.
-WW8_STD* WW8Style::Read1STDFixed(sal_uInt16& rSkip)
+std::unique_ptr WW8Style::Read1STDFixed(sal_uInt16& rSkip)
 {
-WW8_STD* pStd = nullptr;
+std::unique_ptr pStd;
 
 sal_uInt16 cbStd(0);
 m_rStream.ReadUInt16(cbStd);   // read length
@@ -6888,8 +6888,8 @@ WW8_STD* WW8Style::Read1STDFixed(sal_uInt16& rSkip)
 // Fixed part completely available
 
 // read fixed part of STD
-pStd = new WW8_STD;
-memset( pStd, 0, sizeof( *pStd ) );
+pStd.reset(new WW8_STD);
+memset( pStd.get(), 0, sizeof( *pStd ) );
 
 do
 {
@@ -6936,8 +6936,7 @@ WW8_STD* WW8Style::Read1STDFixed(sal_uInt16& rSkip)
 
 if (!m_rStream.good() || !nRead)
 {
-delete pStd;
-pStd = nullptr;   // report error with NULL
+pStd.reset(); // report error with NULL
 }
 
 rSkip = cbStd - m_cbSTDBaseInFile;
@@ -6951,12 +6950,12 @@ WW8_STD* WW8Style::Read1STDFixed(sal_uInt16& rSkip)
 return pStd;
 }
 
-WW8_STD* WW8Style::Read1Style(sal_uInt16& rSkip, OUString* pString)
+std::unique_ptr WW8Style::Read1Style(sal_uInt16& rSkip, OUString* 
pString)
 {
 // Attention: MacWord-Documents have their Stylenames
 // always in ANSI, even if eStructCharSet == CHARSET_MAC !!
 
-WW8_STD* pStd = Read1STDFixed(rSkip); // read STD
+std::unique_ptr pStd = Read1STDFixed(rSkip); // read STD
 
 // string desired?
 if( pString )
diff --git a/sw/source/filter/ww8/ww8scan.hxx b/sw/source/filter/ww8/ww8scan.hxx
index 9a9dd905cabd..5aa3dc596798 100644
--- a/sw/source/filter/ww8/ww8scan.hxx
+++ b/sw/source/filter/ww8/ww8scan.hxx
@@ -1571,8 +1571,8 @@ protected:
 
 public:
 WW8Style( SvStream& rSt, WW8Fib& rFibPara );
-WW8_STD* Read1STDFixed(sal_uInt16& rSkip);
-WW8_STD* Read1Style(sal_uInt16& rSkip, OUString* pString);
+std::unique_ptr Read1STDFixed(sal_uInt16& rSkip);
+std::unique_ptr Read1Style(sal_uInt16& rSkip, OUString* pString);
 sal_uInt16 GetCount() const { return m_cstd; }
 };
 
commit 2e0763633719f9f2a009956ace3e30d79d236ff9
Author: Noel Grandin 
AuthorDate: Mon Jan 14 10:49:23 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:58:07 2019 +0100

use unique_ptr in sw

Change-Id: I02026ffd808fa4939666c791c476cd0c0632cde3
Reviewed-on: https://gerrit.libreoffice.org/66319
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index f938fd78d117..18642cc06621 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -5771,10 +5771,10 @@ ErrCode 
SwWW8ImplReader::LoadThroughDecryption(WW8Glossary *pGloss)
 m_pStrm->Seek(0);
 size_t nUnencryptedHdr =
 (8 == m_xWwFib->m_nVersion) ? 0x44 : 0x34;
-sal_uInt8 *pIn = new sal_uInt8[nUnencryptedHdr];
-nUnencryptedHdr = m_pStrm->ReadBytes(pIn, 
nUnencryptedHdr);
-aDecryptMain.WriteBytes(pIn, nUnencryptedHdr);
-delete [] pIn;
+std::unique_ptr pIn(new 
sal_uInt8[nUnencryptedHdr]);
+nUnencryptedHdr = m_pStrm->ReadBytes(pIn.get(), 
nUnencryptedHdr);
+aDecryptMain.WriteBytes(pIn.get(), nUnencryptedHdr);
+pIn.reset();
 
 DecryptXOR(aCtx, *m_pStrm, aDecryptMain);
 
@@ -5838,14 +5838,14 @@ ErrCode 
SwWW8ImplReader::LoadThroughDecryption(WW8Glossary *pGloss)
 
 m_pStrm->Seek(0);
 std::size_t nUnencryptedHdr = 0x44;
-sal_uInt8 *pIn = new sal_uInt8[nUnencryptedHdr];
-nUnencryptedHdr = m_pStrm->ReadBytes(pIn, 

[Libreoffice-commits] core.git: 2 commits - sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/wrtw8num.cxx |   10 --
 sw/source/filter/ww8/ww8par.hxx   |2 +-
 sw/source/filter/ww8/ww8par2.cxx  |   14 --
 sw/source/filter/ww8/ww8par6.cxx  |   10 --
 sw/source/uibase/wrtsh/wrtsh2.cxx |   26 +-
 5 files changed, 26 insertions(+), 36 deletions(-)

New commits:
commit 11f85d828a16b1beee5c476bd4d8d21c3e450592
Author: Noel Grandin 
AuthorDate: Mon Jan 14 10:43:10 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:57:58 2019 +0100

use unique_ptr in SwWW8ImplReader::ConstructApo

Change-Id: I104168fbbd04f81d500bc9d63d4328aee0a11f24
Reviewed-on: https://gerrit.libreoffice.org/66318
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ww8/ww8par.hxx b/sw/source/filter/ww8/ww8par.hxx
index 4a91dc1da609..33b0a9349141 100644
--- a/sw/source/filter/ww8/ww8par.hxx
+++ b/sw/source/filter/ww8/ww8par.hxx
@@ -1493,7 +1493,7 @@ private:
 bool IsListOrDropcap() { return (!m_xCurrentItemSet  || m_bDropCap); };
 
 //Apo == Absolutely Positioned Object, MSWord's old-style frames
-WW8FlyPara *ConstructApo(const ApoTestResults ,
+std::unique_ptr ConstructApo(const ApoTestResults ,
 const WW8_TablePos *pTabPos);
 bool StartApo(const ApoTestResults , const WW8_TablePos *pTabPos);
 void StopApo();
diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index 04f896ea268f..f5224bec80a1 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -460,9 +460,7 @@ ApoTestResults SwWW8ImplReader::TestApo(int nCellLevel, 
bool bTableRowEnd,
 bool bNowApo = aRet.HasFrame() || pTopLevelTable;
 if (bNowApo)
 {
-if (WW8FlyPara *pTest = ConstructApo(aRet, pTabPos))
-delete pTest;
-else
+if (!ConstructApo(aRet, pTabPos))
 bNowApo = false;
 }
 
@@ -2080,10 +2078,7 @@ WW8TabDesc::WW8TabDesc(SwWW8ImplReader* pIoClass, WW8_CP 
nStartCp) :
 if (aApo.mbStartApo)
 {
 //if there really is a fly here, and not a "null" fly then break.
-WW8FlyPara *pNewFly = m_pIo->ConstructApo(aApo, pTabPos);
-if (pNewFly)
-delete pNewFly;
-else
+if (m_pIo->ConstructApo(aApo, pTabPos))
 break;
 }
 
@@ -3408,7 +3403,7 @@ bool SwWW8ImplReader::StartTable(WW8_CP nStartCp)
 
 // #i33818# - determine absolute position object attributes,
 // if possible. It's needed for nested tables.
-WW8FlyPara* pTableWFlyPara( nullptr );
+std::unique_ptr pTableWFlyPara;
 WW8SwFlyPara* pTableSFlyPara( nullptr );
 // #i45301# - anchor nested table inside Writer fly frame
 // only at-character, if absolute position object attributes are available.
@@ -3485,7 +3480,7 @@ bool SwWW8ImplReader::StartTable(WW8_CP nStartCp)
 // if existing, and apply them to the created Writer fly frame.
 if ( pTableWFlyPara && pTableSFlyPara )
 {
-WW8FlySet aFlySet( *this, pTableWFlyPara, pTableSFlyPara, 
false );
+WW8FlySet aFlySet( *this, pTableWFlyPara.get(), 
pTableSFlyPara, false );
 SwFormatAnchor aAnchor( RndStdIds::FLY_AT_CHAR );
 aAnchor.SetAnchor( m_xTableDesc->m_pParentPos );
 aFlySet.Put( aAnchor );
@@ -3510,7 +3505,6 @@ bool SwWW8ImplReader::StartTable(WW8_CP nStartCp)
 PopTableDesc();
 
 // #i33818#
-delete pTableWFlyPara;
 delete pTableSFlyPara;
 
 return m_xTableDesc != nullptr;
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index a178f5c788d0..2b12c2619a1b 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -2364,14 +2364,13 @@ SwTwips SwWW8ImplReader::MoveOutsideFly(SwFrameFormat 
*pFlyFormat,
 return nRetWidth;
 }
 
-WW8FlyPara *SwWW8ImplReader::ConstructApo(const ApoTestResults ,
+std::unique_ptr SwWW8ImplReader::ConstructApo(const ApoTestResults 
,
 const WW8_TablePos *pTabPos)
 {
-WW8FlyPara *pRet = nullptr;
 OSL_ENSURE(rApo.HasFrame() || pTabPos,
 "If no frame found, *MUST* be in a table");
 
-pRet = new WW8FlyPara(m_bVer67, rApo.mpStyleApo);
+std::unique_ptr pRet(new WW8FlyPara(m_bVer67, 
rApo.mpStyleApo));
 
 // find APO parameter and test for bGrafApo
 if (rApo.HasFrame())
@@ -2381,8 +2380,7 @@ WW8FlyPara *SwWW8ImplReader::ConstructApo(const 
ApoTestResults ,
 
 if (pRet->IsEmpty())
 {
-delete pRet;
-pRet = nullptr;
+pRet.reset();
 }
 return pRet;
 }
@@ -2418,7 +2416,7 @@ bool SwWW8ImplReader::IsDropCap()
 
 bool SwWW8ImplReader::StartApo(const ApoTestResults , const WW8_TablePos 
*pTabPos)
 {
-m_xWFlyPara.reset(ConstructApo(rApo, pTabPos));
+m_xWFlyPara = ConstructApo(rApo, pTabPos);
 if (!m_xWFlyPara)
 return false;
 
commit 

[Libreoffice-commits] core.git: oox/source

[Libreoffice Gerrit user]

 oox/source/drawingml/diagram/diagramlayoutatoms.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 479626aa7254dc918fd84006b352f0fb68891aeb
Author: Andrea Gelmini 
AuthorDate: Mon Jan 14 18:33:41 2019 +
Commit: Julien Nabet 
CommitDate: Tue Jan 15 07:06:44 2019 +0100

Fix typo

Change-Id: I8a91600a6559decf5b9a8a576d91a6401c6b92d9
Reviewed-on: https://gerrit.libreoffice.org/66342
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx 
b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
index 0e091da68b0e..1e68896b1e9c 100644
--- a/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
+++ b/oox/source/drawingml/diagram/diagramlayoutatoms.cxx
@@ -552,7 +552,7 @@ void AlgAtom::layoutShape( const ShapePtr& rShape,
 
 sal_Int32 nCount = rShape->getChildren().size();
 
-// A manager node's height should be indepdenent from if it has
+// A manager node's height should be independent from if it has
 // assistants and employees, compensate for that.
 bool bTop = mnType == XML_hierRoot && rShape->getInternalName() == 
"hierRoot1";
 double fHeightScale = 1.0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Android Build Error at ./autogen.sh

[Gülşah Köse]

Hello,

~/home/brenda/Android/Sdk/ndk-bundle/ looks like wrong path. i think it
says /home/brenda/home/brenda/Android/Sdk/ndk-bundle/ By the way If we put
at "/" at the end of the parameter like says wiki, the path in the code
look like ndk-bundle// so remove / at the end.

However checked all of them and set ANDROID_API_LEVEL and minSdkVersion to
16 ./autogen.sh still shows same error. Although the file exist, control
configure.ac line 384 behaves file doesn't exists

Any idea about it?



-- 
Gülşah Köse
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

[Libreoffice Gerrit user]

 sc/source/ui/cctrl/checklistmenu.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 05b9bf2099460a370af4e9c13feff815cdd234d0
Author: Arkadiy Illarionov 
AuthorDate: Mon Jan 14 22:39:57 2019 +0300
Commit: Noel Grandin 
CommitDate: Tue Jan 15 08:05:06 2019 +0100

Use proper iterator in loop body

Loop iterates over children to set their state
7967e5e51e5210b8c3d3dc63502bd7d875eb36b7 follow-up

Change-Id: I425b3204fb3581a22e9ed2b00c7b8c24ed2060a8
Reviewed-on: https://gerrit.libreoffice.org/66333
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 5dd7e9b9ced5..8153d13b581b 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1153,7 +1153,7 @@ void ScCheckListMenuWindow::setAllMemberState(bool bSet)
 SvTreeListEntries& rEntries = (*itr)->GetChildEntries();
 for (auto it = rEntries.begin(), itEnd = rEntries.end(); it != 
itEnd; ++ it)
 {
-maChecks->CheckEntry(*itr, bSet);
+maChecks->CheckEntry(it->get(), bSet);
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Android Build Error at ./autogen.sh

[Gülşah Köse]

Hello,

I found the last problem and works for me now. We should't use ~ while
giving parameter. we should write full path of sdk and ndk. As a parameter
"/home/brenda/Android/Sdk/ndk-bundle"
 should work for you too.

---
Gülşah Köse
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

[Kaganski Mike]

Hi!

On 15.01.2019 1:40, Дилян Палаузов wrote:
> Hello,
> 
> the LO source code requires const GooString*, but the 
> /usr/local/include/poppler/OutputDev.h file had no const in the
> declaration of drawString.  The installed poppler was newer than 0.64.0.
> 
> The hack is, that in the past I installed poppler and it installed 
> OutputDev.h .  When I later compiled newer version of
> poppler I have not passed ENABLE_XPDF_HEADERS / 
> ENABLE_UNSTABLE_API_ABI_HEADERS to cmake and in turn “make install” has
> not overwritten /usr/local/include/poppler/OutputDev.h.  This led to a 
> situation with new libpoppler and old OutputDev.h
> without const.  Indeed override triggered correctly.
> 
> --without-system-poppler mitigates.

All current LibreOffice branches, including 6-0-7, have the patch 
mentioned by Stephan previously. You may see the source here:

https://cgit.freedesktop.org/libreoffice/core/tree/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx?h=libreoffice-6-0-7

and the commit to 6-1 here:

https://cgit.freedesktop.org/libreoffice/core/commit?id=106b2c96e9807af14d6eb6e8f83dcf25095a093e

The commit conditionally makes the parameter const when reported poppler 
is 0.64 or newer, following the poppler change "Add const to several 
classes and members" (see 
https://poppler.freedesktop.org/releases.html). Poppler 0.64 and newer 
does have the const in the declaration of drawString - you may check its 
source code at 
https://cgit.freedesktop.org/poppler/poppler/tree/poppler/OutputDev.h?h=poppler-0.64.0,
 
and the commit is 
https://cgit.freedesktop.org/poppler/poppler/commit/poppler/OutputDev.h?h=poppler-0.64.0=c4af5981ab2a5f42a9a1194bb5929c2151fc2674.

So the problem in your situation is most likely that you have messed up 
with the mix of new and old headers and library.

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sfx2/source

[Libreoffice Gerrit user]

 sfx2/source/view/viewfrm.cxx |   29 +
 1 file changed, 5 insertions(+), 24 deletions(-)

New commits:
commit 9b829d4d40d1adcb2e53a753fba015ef6ed5ac4d
Author: Justin Luth 
AuthorDate: Fri Jan 11 13:46:41 2019 +0300
Commit: Mike Kaganski 
CommitDate: Tue Jan 15 07:32:47 2019 +0100

tdf#120271 thanks ESC: disable getInvolved for stable 6.1 build

https://lists.freedesktop.org/archives/libreoffice/2019-January/081715.html

with the revelant part being:
AI:   + propose remove it from 6.3 and 6.1-stable (Justin)
AI:   => disable for 6.1 for now

Because it is possible for both getInvolved and donate to pop
up simultaneously (by setting lasttime to 1 for example), it
is best to reset it to 0, so that if re-activated again at some point
(like switching to 6.2) then the 90 day timer will again be
started fresh instead of being triggered immediately.

Change-Id: I4e6bc3c23f569302e8c132a3bf1474735199532a
Reviewed-on: https://gerrit.libreoffice.org/66158
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 1a852e0f1f2a..510e7238a417 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1218,32 +1218,13 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/, 
const SfxHint& rHint )
 rBind.Invalidate( SID_RELOAD );
 rBind.Invalidate( SID_EDITDOC );
 
-// inform about the community involvement
-const sal_Int64 nLastShown = 
officecfg::Setup::Product::LastTimeGetInvolvedShown::get();
-const sal_Int64 nNow = 
std::chrono::duration_cast(std::chrono::system_clock::now().time_since_epoch()).count();
-const sal_Int64 nPeriodSec(60 * 60 * 24 * 30); // 30 days in 
seconds
-bool bUpdateLastTimeGetInvolvedShown = false;
-
-if (nLastShown == 0)
-bUpdateLastTimeGetInvolvedShown = true;
-else if (nPeriodSec < nNow && nLastShown < nNow - nPeriodSec)
-{
-bUpdateLastTimeGetInvolvedShown = true;
-
-VclPtr pInfoBar = 
AppendInfoBar("getinvolved", SfxResId(STR_GET_INVOLVED_TEXT), 
InfoBarType::Info);
-
-VclPtrInstance 
xGetInvolvedButton(());
-
xGetInvolvedButton->SetText(SfxResId(STR_GET_INVOLVED_BUTTON));
-
xGetInvolvedButton->SetSizePixel(xGetInvolvedButton->GetOptimalSize());
-xGetInvolvedButton->SetClickHdl(LINK(this, SfxViewFrame, 
GetInvolvedHandler));
-pInfoBar->addButton(xGetInvolvedButton);
-}
-
-if (bUpdateLastTimeGetInvolvedShown
-&& 
!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
+// Inform about the community involvement (disabled for 6.1 
stable as per ESC decision).
+// Reset the timers so that both "get involved" and "donate" 
don't pop up simultaneously
+// when the feature is re-activated by 6.2.
+if 
(!officecfg::Setup::Product::LastTimeGetInvolvedShown::isReadOnly())
 {
 std::shared_ptr 
batch(comphelper::ConfigurationChanges::create());
-
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(nNow, batch);
+
officecfg::Setup::Product::LastTimeGetInvolvedShown::set(0, batch);
 batch->commit();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: download.lst external/boost sfx2/source ucb/Library_ucpcmis1.mk

[Libreoffice Gerrit user]

 download.lst |4 
 external/boost/UnpackedTarball_boost.mk  |3 
 external/boost/boost-android-unified.patch.1 |   46 +-
 external/boost/boost.noiconv.patch   |6 
 external/boost/clang-cl.patch.0  |   18 
 external/boost/include/boost/uuid/sha1.hpp   |   28 -
 external/boost/msvc2017.patch.0  |   22 -
 external/boost/rtti.patch.0  |9 
 external/boost/sse.patch.0   |  533 +++
 sfx2/source/appl/shutdownicon.cxx|2 
 ucb/Library_ucpcmis1.mk  |   11 
 11 files changed, 572 insertions(+), 110 deletions(-)

New commits:
commit 23a8d5ffbbe58761b89f590f0735abccd69a3681
Author: Stephan Bergmann 
AuthorDate: Fri Jan 11 17:40:17 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 15 08:24:05 2019 +0100

Upgrade external/boost to Boost 1.69.0

 is a copy of

,
SHA256 hash as given at .

* removed from external/boost/include/boost/ those files that are no longer
  present in workdir/UnpackedTarball/boost/boost/

* the shrunk external/boost/rtti.patch.0 can probably be removed completely 
in a
  follow-up commit

* the patch to libs/filesystem/src/operations.cpp in
  external/boost/boost-android-unified.patch.1 no longer applied, and 
appears to
  be no longer necessary anyway (seeing a working build without it of
  --with-distro=LibreOfficeAndroid and NDK r16b); but with the non-standard
  Clang 5.0.300080 from NDK r16b, the build now caused failures like

> 
workdir/UnpackedTarball/boost/boost/type_traits/detail/is_function_cxx_11.hpp:36:11:
 error: class template partial specialization contains a template parameter 
that cannot be deduced; this partial specialization will never be used 
[-Wunusable-partial-specialization]
>struct is_function : public true_type {};
>   
^
> 
workdir/UnpackedTarball/boost/boost/type_traits/detail/is_function_cxx_11.hpp:35:38:
 note: non-deducible template parameter 'NE'
>template 
>  ^
> 
workdir/UnpackedTarball/boost/boost/type_traits/detail/is_function_cxx_11.hpp:22:40:
 note: expanded from macro 'BOOST_TT_NOEXCEPT_PARAM'
> #define BOOST_TT_NOEXCEPT_PARAM , bool NE
>^

  showing that that version of Clang has the same problem handling 
noexcept(b)
  as a deduced template parameter as MSVC has, as already supported by the 
code

* new external/boost/sse.patch.0 needed on Windows x86 to silence errors 
like

> 
C:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/type_traits/detail/is_function_cxx_11.hpp(111):
 error C2215: '__vectorcall' cannot be used with '/arch:SSE'

  (); according to
  : "_M_IX86_FP Defined as an integer literal value that 
indicates
  the /arch compiler option that was set, or the default. This macro is 
always
  defined when the compilation target is an x86 processor. Otherwise, 
undefined.
  When defined, the value is: [...] 1 if the /arch:SSE compiler option was 
set."
  and we specify /arch:SSE explicitly for Windows x86 since
  8bd6bf93b7711a7ac7c5cbd7c3bb980481570ebd "fdo#82430: configure: MSVC 
build:
  avoid using SSE2 instructions"

* boost::logic::tribool conversion operator to bool is explicit now

Change-Id: Iea49560d734f545539f062dce46740fbf812dd84
Reviewed-on: https://gerrit.libreoffice.org/66189
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/download.lst b/download.lst
index d6d35ed7d422..d43cdf06f27d 100644
--- a/download.lst
+++ b/download.lst
@@ -6,8 +6,8 @@ export APR_SHA256SUM := 
1af06e1720a58851d90694a984af18355b65bb0d047be03ec7d659c7
 export APR_TARBALL := apr-1.5.2.tar.gz
 export APR_UTIL_SHA256SUM := 
976a12a59bc286d634a21d7be0841cc74289ea9077aa1af46be19d1a6e844c19
 export APR_UTIL_TARBALL := apr-util-1.5.4.tar.gz
-export BOOST_SHA256SUM := 
5721818253e6a0989583192f96782c4a98eb6204965316df9f5ad75819225ca9
-export BOOST_TARBALL := boost_1_66_0.tar.bz2
+export BOOST_SHA256SUM := 
8f32d4617390d1c2d16f26a27ab60d97807b35440d45891fa340fc2648b04406
+export BOOST_TARBALL := boost_1_69_0.tar.bz2
 export BREAKPAD_SHA256SUM := 
7060149be16a8789b0ccf596bdeaf63115f03f520acb508f72a14686fb311cb9
 export BREAKPAD_TARBALL := breakpad.zip
 export BSH_SHA256SUM := 
9e93c73e23aff644b17dfff65674c14150e7f3b38b19635e622235e01c96
diff --git 

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

[Libreoffice Gerrit user]

 sw/inc/PostItMgr.hxx |4 +--
 sw/qa/extras/uiwriter/uiwriter.cxx   |2 -
 sw/source/uibase/docvw/PostItMgr.cxx |   45 +--
 3 files changed, 25 insertions(+), 26 deletions(-)

New commits:
commit 339e866d09717b4919dafaad96ebf772d30ec9cb
Author: Noel Grandin 
AuthorDate: Mon Jan 14 09:17:36 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 08:43:02 2019 +0100

use unique_ptr in SwPostItMgr

Change-Id: Icc946b986f62d986e979e6a3f3ba0d2c28cb9adf
Reviewed-on: https://gerrit.libreoffice.org/66312
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/PostItMgr.hxx b/sw/inc/PostItMgr.hxx
index 9650996c50f3..b6f8242864f0 100644
--- a/sw/inc/PostItMgr.hxx
+++ b/sw/inc/PostItMgr.hxx
@@ -130,7 +130,7 @@ class SwPostItMgr: public SfxListener
 SwView* mpView;
 SwWrtShell* mpWrtShell;
 VclPtr   mpEditWin;
-std::vector mvPostItFields;
+std::vector> mvPostItFields;
 std::vector>  mPages;
 ImplSVEvent *   mnEventId;
 boolmbWaitingForCalcRects;
@@ -178,7 +178,7 @@ class SwPostItMgr: public SfxListener
 SwPostItMgr(SwView* aDoc);
 virtual ~SwPostItMgr() override;
 
-typedef std::vector< SwSidebarItem* >::const_iterator const_iterator;
+typedef std::vector< std::unique_ptr >::const_iterator 
const_iterator;
 const_iterator begin()  const { return mvPostItFields.begin(); }
 const_iterator end()const { return mvPostItFields.end();  }
 
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index bc05aeaa0445..5e9d9c639f75 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -4153,7 +4153,7 @@ void SwUiWriterTest::testTdf89720()
 SwDoc* pDoc = createDoc("tdf89720.odt");
 SwView* pView = pDoc->GetDocShell()->GetView();
 SwPostItMgr* pPostItMgr = pView->GetPostItMgr();
-for (SwSidebarItem* pItem : *pPostItMgr)
+for (std::unique_ptr const & pItem : *pPostItMgr)
 {
 if (pItem->pPostIt->IsFollow())
 // This was non-0: reply comments had a text range overlay,
diff --git a/sw/source/uibase/docvw/PostItMgr.cxx 
b/sw/source/uibase/docvw/PostItMgr.cxx
index 657d2d3b7c1d..73dba5a4 100644
--- a/sw/source/uibase/docvw/PostItMgr.cxx
+++ b/sw/source/uibase/docvw/PostItMgr.cxx
@@ -105,7 +105,7 @@ namespace {
 
 enum class CommentNotificationType { Add, Remove, Modify };
 
-bool comp_pos(const SwSidebarItem* a, const SwSidebarItem* b)
+bool comp_pos(const std::unique_ptr& a, const 
std::unique_ptr& b)
 {
 // sort by anchor position
 SwPosition aPosAnchorA = a->GetAnchorPosition();
@@ -243,21 +243,21 @@ void SwPostItMgr::CheckForRemovedPostIts()
 {
 IDocumentRedlineAccess const& 
rIDRA(mpWrtShell->getIDocumentRedlineAccess());
 bool bRemoved = false;
-auto currentIt = mvPostItFields.begin();
-while(currentIt != mvPostItFields.end())
+auto it = mvPostItFields.begin();
+while(it != mvPostItFields.end())
 {
-auto it = currentIt++;
 if (!(*it)->UseElement(*mpWrtShell->GetLayout(), rIDRA))
 {
 
EndListening(const_cast(*(*it)->GetBroadCaster()));
-SwSidebarItem* p = *it;
-currentIt = 
mvPostItFields.erase(std::remove(mvPostItFields.begin(), mvPostItFields.end(), 
*it), mvPostItFields.end());
+std::unique_ptr p = std::move(*it);
+it = mvPostItFields.erase(it);
 if (GetActiveSidebarWin() == p->pPostIt)
 SetActiveSidebarWin(nullptr);
 p->pPostIt.disposeAndClear();
-delete p;
 bRemoved = true;
 }
+else
+++it;
 }
 
 if ( bRemoved )
@@ -278,21 +278,21 @@ void SwPostItMgr::CheckForRemovedPostIts()
 
 SwSidebarItem* SwPostItMgr::InsertItem(SfxBroadcaster* pItem, bool 
bCheckExistence, bool bFocus)
 {
-SwSidebarItem* pAnnotationItem = nullptr;
 if (bCheckExistence)
 {
 for (auto const& postItField : mvPostItFields)
 {
 if ( postItField->GetBroadCaster() == pItem )
-return pAnnotationItem;
+return nullptr;
 }
 }
 mbLayout = bFocus;
 
+SwSidebarItem* pAnnotationItem = nullptr;
 if (dynamic_cast< const SwFormatField *>( pItem ) !=  nullptr)
 {
-pAnnotationItem = new 
SwAnnotationItem(static_cast(*pItem), bFocus);
-mvPostItFields.push_back(pAnnotationItem);
+
mvPostItFields.push_back(std::make_unique(static_cast(*pItem),
 bFocus));
+pAnnotationItem = mvPostItFields.back().get();
 }
 OSL_ENSURE(dynamic_cast< const SwFormatField *>( pItem ) !=  
nullptr,"Mgr::InsertItem: seems like new stuff was added");
 StartListening(*pItem);
@@ -303,10 +303,10 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - basic/source toolkit/source

[Libreoffice Gerrit user]

 basic/source/sbx/sbxarray.cxx |6 +-
 toolkit/source/awt/vclxwindow.cxx |2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit b2fa854e81d329c9ed49bd10944cea1a430ecf7e
Author: Noel Grandin 
AuthorDate: Mon Jan 14 13:19:32 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:56:54 2019 +0100

tdf#122250 Crash when running extension

as a consequence of

commit 4e07987ce8134312920682e3481c3f8e3d7b66c3
Date:   Thu Aug 25 15:08:55 2016 +0200
cid#1371154 Missing move assignment operator

this extensions appears to pass bogus data into VCLXWindow::setProperty,
so I had to workaround that when debugging

Change-Id: Ib6728c0a990bd7cfbfed43d79b7560bd2f7f5a67
Reviewed-on: https://gerrit.libreoffice.org/66297
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basic/source/sbx/sbxarray.cxx b/basic/source/sbx/sbxarray.cxx
index 668b4df03bc5..c6ccb208065c 100644
--- a/basic/source/sbx/sbxarray.cxx
+++ b/basic/source/sbx/sbxarray.cxx
@@ -198,10 +198,14 @@ void SbxArray::Put( SbxVariable* pVar, sal_uInt16 nIdx )
 if( eType != SbxOBJECT || pVar->GetClass() != 
SbxClassType::Object )
 pVar->Convert( eType );
 SbxVariableRef& rRef = GetRef( nIdx );
+// tdf#122250. It is possible that I hold the last reference to 
myself, so check, otherwise I might
+// call SetFlag on myself after I have died.
+bool removingMyself = rRef.get() && rRef->GetParameters() == this && 
GetRefCount() == 1;
 if(rRef.get() != pVar )
 {
 rRef = pVar;
-SetFlag( SbxFlagBits::Modified );
+if (!removingMyself)
+SetFlag( SbxFlagBits::Modified );
 }
 }
 }
diff --git a/toolkit/source/awt/vclxwindow.cxx 
b/toolkit/source/awt/vclxwindow.cxx
index 45c7d1dcdc62..6d89c13f3697 100644
--- a/toolkit/source/awt/vclxwindow.cxx
+++ b/toolkit/source/awt/vclxwindow.cxx
@@ -1722,6 +1722,8 @@ void VCLXWindow::setProperty( const OUString& 
PropertyName, const css::uno::Any&
 WinBits nStyle = pWindow->GetStyle();
 sal_uInt16 nTmp = 0;
 Value >>= nTmp;
+// clear any dodgy bits passed in, can come from dodgy extensions
+nTmp &= o3tl::typed_flags::mask;
 WindowBorderStyle nBorder = static_cast(nTmp);
 if ( !bool(nBorder) )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

[Libreoffice Gerrit user]

 sw/inc/swabstdlg.hxx   |2 +-
 sw/source/ui/dialog/swdlgfact.cxx  |2 +-
 sw/source/ui/dialog/swdlgfact.hxx  |6 +++---
 sw/source/ui/table/instable.cxx|4 ++--
 sw/source/uibase/app/docsh.cxx |9 -
 sw/source/uibase/app/docsh2.cxx|5 ++---
 sw/source/uibase/app/docstyle.cxx  |   12 ++--
 sw/source/uibase/inc/instable.hxx  |2 +-
 sw/source/uibase/lingu/hhcwrp.cxx  |   12 ++--
 sw/source/uibase/shells/basesh.cxx |7 +++
 10 files changed, 29 insertions(+), 32 deletions(-)

New commits:
commit 6018adfabc30ee68939c2d974aa612757bbca938
Author: Noel Grandin 
AuthorDate: Mon Jan 14 10:07:09 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:57:09 2019 +0100

use unique_ptr for SwTableAutoFormat

Change-Id: Ib83be524b5c15e4639a834494726501ac7aa6755
Reviewed-on: https://gerrit.libreoffice.org/66314
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 2e97df323db9..075d41e873c0 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -120,7 +120,7 @@ protected:
 public:
 virtual voidGetValues( OUString& rName, sal_uInt16& rRow, 
sal_uInt16& rCol,
 SwInsertTableOptions& rInsTableFlags, 
OUString& rTableAutoFormatName,
-SwTableAutoFormat *& prTAFormat ) = 0;
+std::unique_ptr& prTAFormat 
) = 0;
 };
 
 class AbstractJavaEditDialog : public VclAbstractDialog
diff --git a/sw/source/ui/dialog/swdlgfact.cxx 
b/sw/source/ui/dialog/swdlgfact.cxx
index c40f17d9cf4a..d928f116fd90 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -550,7 +550,7 @@ void AbstractInsFootNoteDlg_Impl::SetText( const OUString& 
rStr )
 
 void AbstractInsTableDlg_Impl::GetValues( OUString& rName, sal_uInt16& rRow, 
sal_uInt16& rCol,
 SwInsertTableOptions& rInsTableFlags, 
OUString& rTableAutoFormatName,
-SwTableAutoFormat *& prTAFormat )
+std::unique_ptr& prTAFormat 
)
 {
 m_xDlg->GetValues(rName, rRow, rCol, rInsTableFlags, rTableAutoFormatName, 
prTAFormat);
 }
diff --git a/sw/source/ui/dialog/swdlgfact.hxx 
b/sw/source/ui/dialog/swdlgfact.hxx
index 2d9251ce3095..067097fcd3aa 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -444,9 +444,9 @@ public:
 {
 }
 virtual short Execute() override;
-virtual voidGetValues( OUString& rName, sal_uInt16& rRow, 
sal_uInt16& rCol,
-SwInsertTableOptions& rInsTableFlags, 
OUString& rTableAutoFormatName,
-SwTableAutoFormat *& prTAFormat ) override;
+virtual void  GetValues( OUString& rName, sal_uInt16& rRow, sal_uInt16& 
rCol,
+ SwInsertTableOptions& rInsTableFlags, OUString& 
rTableAutoFormatName,
+ std::unique_ptr& prTAFormat ) 
override;
 };
 
 class SwJavaEditDialog;
diff --git a/sw/source/ui/table/instable.cxx b/sw/source/ui/table/instable.cxx
index b960dcb4f168..f2d7f6f3c305 100644
--- a/sw/source/ui/table/instable.cxx
+++ b/sw/source/ui/table/instable.cxx
@@ -29,7 +29,7 @@
 
 void SwInsTableDlg::GetValues( OUString& rName, sal_uInt16& rRow, sal_uInt16& 
rCol,
 SwInsertTableOptions& rInsTableOpts, OUString& 
rAutoName,
-SwTableAutoFormat *& prTAFormat )
+std::unique_ptr& prTAFormat 
)
 {
 SwInsertTableFlags nInsMode = SwInsertTableFlags::NONE;
 rName = m_xNameEdit->get_text();
@@ -46,7 +46,7 @@ void SwInsTableDlg::GetValues( OUString& rName, sal_uInt16& 
rRow, sal_uInt16& rC
 nInsMode |= SwInsertTableFlags::SplitLayout;
 if( pTAutoFormat )
 {
-prTAFormat = new SwTableAutoFormat( *pTAutoFormat );
+prTAFormat.reset(new SwTableAutoFormat( *pTAutoFormat ));
 rAutoName = prTAFormat->GetName();
 }
 
diff --git a/sw/source/uibase/inc/instable.hxx 
b/sw/source/uibase/inc/instable.hxx
index c0194403ab98..7c12ce1f3434 100644
--- a/sw/source/uibase/inc/instable.hxx
+++ b/sw/source/uibase/inc/instable.hxx
@@ -82,7 +82,7 @@ public:
 
 void GetValues( OUString& rName, sal_uInt16& rRow, sal_uInt16& rCol,
 SwInsertTableOptions& rInsTableOpts, OUString& 
rTableAutoFormatName,
-SwTableAutoFormat *& prTAFormat );
+std::unique_ptr& prTAFormat );
 };
 
 #endif
diff --git a/sw/source/uibase/lingu/hhcwrp.cxx 
b/sw/source/uibase/lingu/hhcwrp.cxx
index 4a6c2a61f650..8fce3fae3a3a 100644
--- a/sw/source/uibase/lingu/hhcwrp.cxx
+++ b/sw/source/uibase/lingu/hhcwrp.cxx
@@ -374,7 +374,7 @@ void SwHHCWrapper::ReplaceUnit(
 OUString aOrigText( m_rWrtShell.GetSelText() );
 OUString aNewText( rReplaceWith );
 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - basic/source toolkit/source

[Libreoffice Gerrit user]

 basic/source/sbx/sbxarray.cxx |6 +-
 toolkit/source/awt/vclxwindow.cxx |2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit c906431aabf1e0c00f1048bf580beeb3d52349d9
Author: Noel Grandin 
AuthorDate: Mon Jan 14 13:19:32 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:56:45 2019 +0100

tdf#122250 Crash when running extension

as a consequence of

commit 4e07987ce8134312920682e3481c3f8e3d7b66c3
Date:   Thu Aug 25 15:08:55 2016 +0200
cid#1371154 Missing move assignment operator

this extensions appears to pass bogus data into VCLXWindow::setProperty,
so I had to workaround that when debugging

Change-Id: Ib6728c0a990bd7cfbfed43d79b7560bd2f7f5a67
Reviewed-on: https://gerrit.libreoffice.org/66296
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basic/source/sbx/sbxarray.cxx b/basic/source/sbx/sbxarray.cxx
index fc86839c1d24..1b7054f2d9f7 100644
--- a/basic/source/sbx/sbxarray.cxx
+++ b/basic/source/sbx/sbxarray.cxx
@@ -190,10 +190,14 @@ void SbxArray::Put( SbxVariable* pVar, sal_uInt16 nIdx )
 if( eType != SbxOBJECT || pVar->GetClass() != 
SbxClassType::Object )
 pVar->Convert( eType );
 SbxVariableRef& rRef = GetRef( nIdx );
+// tdf#122250. It is possible that I hold the last reference to 
myself, so check, otherwise I might
+// call SetFlag on myself after I have died.
+bool removingMyself = rRef.get() && rRef->GetParameters() == this && 
GetRefCount() == 1;
 if(rRef.get() != pVar )
 {
 rRef = pVar;
-SetFlag( SbxFlagBits::Modified );
+if (!removingMyself)
+SetFlag( SbxFlagBits::Modified );
 }
 }
 }
diff --git a/toolkit/source/awt/vclxwindow.cxx 
b/toolkit/source/awt/vclxwindow.cxx
index 108f6b36f7bc..86aa4dc1a292 100644
--- a/toolkit/source/awt/vclxwindow.cxx
+++ b/toolkit/source/awt/vclxwindow.cxx
@@ -1715,6 +1715,8 @@ void VCLXWindow::setProperty( const OUString& 
PropertyName, const css::uno::Any&
 WinBits nStyle = pWindow->GetStyle();
 sal_uInt16 nTmp = 0;
 Value >>= nTmp;
+// clear any dodgy bits passed in, can come from dodgy extensions
+nTmp &= o3tl::typed_flags::mask;
 WindowBorderStyle nBorder = static_cast(nTmp);
 if ( !bool(nBorder) )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

[Libreoffice Gerrit user]

 sw/inc/swunohelper.hxx |3 +--
 sw/source/core/unocore/swunohelper.cxx |6 +++---
 sw/source/uibase/utlui/gloslst.cxx |   14 +-
 3 files changed, 9 insertions(+), 14 deletions(-)

New commits:
commit 1c4acfdcb10b2cdeac8efb331fc9db8d01de9c66
Author: Noel Grandin 
AuthorDate: Mon Jan 14 10:15:18 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:57:30 2019 +0100

fix unnecessary delete

the erase on the preceding line will delete it,

ever since
commit a846c7106d4e4e1b8cc61e237cc2e158d037e816
Date:   Wed Jul 25 12:26:15 2018 +0200
loplugin:useuniqueptr in SwGlossaryList

Change-Id: I8f71bca8eebf762aeea3225d3a3b52ec2ac60e19
Reviewed-on: https://gerrit.libreoffice.org/66316
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/uibase/utlui/gloslst.cxx 
b/sw/source/uibase/utlui/gloslst.cxx
index 2c92c4a5acbb..d7e97deff15b 100644
--- a/sw/source/uibase/utlui/gloslst.cxx
+++ b/sw/source/uibase/utlui/gloslst.cxx
@@ -318,7 +318,6 @@ void SwGlossaryList::Update()
 if(!bFound)
 {
 aGroupArr.erase(aGroupArr.begin() + i);
-delete pGroup;
 }
 }
 }
commit f7214c70676b35baff427d986ffb85b8c79c0ca8
Author: Noel Grandin 
AuthorDate: Mon Jan 14 10:11:45 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 15 06:57:19 2019 +0100

simplify UCB_GetFileListOfFolder

no need to use heap objects here

Change-Id: Iadc35b019da7b9446ede79c96a9d8ce8c6db81ef
Reviewed-on: https://gerrit.libreoffice.org/66315
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/swunohelper.hxx b/sw/inc/swunohelper.hxx
index 35459bdcfa31..b87d7dda833e 100644
--- a/sw/inc/swunohelper.hxx
+++ b/sw/inc/swunohelper.hxx
@@ -56,11 +56,10 @@ SW_DLLPUBLIC bool UCB_IsReadOnlyFileName( const OUString& 
rURL );
 // options: pExtension = 0 -> all, else this specific extension
 //  pDateTime != 0 -> returns also the modified date/time of
 //   the files in a vector -->
-//   !! objects must be deleted from the caller!!
 bool UCB_GetFileListOfFolder( const OUString& rURL,
 std::vector& rList,
 const OUString* pExtension,
-std::vector* pDateTimeList = 
nullptr );
+std::vector* pDateTimeList = nullptr 
);
 
 // is the URL an existing file?
 SW_DLLPUBLIC bool UCB_IsFile( const OUString& rURL );
diff --git a/sw/source/core/unocore/swunohelper.cxx 
b/sw/source/core/unocore/swunohelper.cxx
index e2fcdcf0724f..29e76e9bd554 100644
--- a/sw/source/core/unocore/swunohelper.cxx
+++ b/sw/source/core/unocore/swunohelper.cxx
@@ -184,7 +184,7 @@ bool UCB_IsDirectory( const OUString& rURL )
 bool UCB_GetFileListOfFolder( const OUString& rURL,
 std::vector& rList,
 const OUString* pExtension,
-std::vector< ::DateTime* >* pDateTimeList )
+std::vector< ::DateTime >* pDateTimeList )
 {
 bool bOk = false;
 try
@@ -227,7 +227,7 @@ bool UCB_GetFileListOfFolder( const OUString& rURL,
 if( pDateTimeList )
 {
 css::util::DateTime aStamp = 
xRow->getTimestamp(2);
-::DateTime* pDateTime = new ::DateTime(
+::DateTime aDateTime(
 ::Date( aStamp.Day,
 aStamp.Month,
 aStamp.Year ),
@@ -235,7 +235,7 @@ bool UCB_GetFileListOfFolder( const OUString& rURL,
 aStamp.Minutes,
 aStamp.Seconds,
 aStamp.NanoSeconds ));
-pDateTimeList->push_back( pDateTime );
+pDateTimeList->push_back( aDateTime );
 }
 }
 
diff --git a/sw/source/uibase/utlui/gloslst.cxx 
b/sw/source/uibase/utlui/gloslst.cxx
index 0a05aa8acaf3..2c92c4a5acbb 100644
--- a/sw/source/uibase/utlui/gloslst.cxx
+++ b/sw/source/uibase/utlui/gloslst.cxx
@@ -270,14 +270,14 @@ void SwGlossaryList::Update()
 {
 std::vector aFoundGroupNames;
 std::vector aFiles;
-std::vector aDateTimeArr;
+std::vector aDateTimeArr;
 
 SWUnoHelper::UCB_GetFileListOfFolder( rPathArr[nPath], aFiles,
 ,  );
 for( size_t nFiles = 0; nFiles < aFiles.size(); ++nFiles )
  

[Libreoffice-commits] core.git: sc/source

[Libreoffice Gerrit user]

 sc/source/ui/docshell/autostyl.cxx|   23 -
 sc/source/ui/docshell/datastream.cxx  |5 
 sc/source/ui/docshell/dbdocfun.cxx|   16 -
 sc/source/ui/docshell/docfunc.cxx |  367 --
 sc/source/ui/docshell/docfuncutil.cxx |   22 -
 sc/source/ui/docshell/docsh.cxx   |4 
 sc/source/ui/docshell/docsh4.cxx  |5 
 sc/source/ui/docshell/documentlinkmgr.cxx |4 
 sc/source/ui/docshell/editable.cxx|   14 -
 sc/source/ui/docshell/externalrefmgr.cxx  |  220 +++--
 sc/source/ui/docshell/macromgr.cxx|9 
 11 files changed, 334 insertions(+), 355 deletions(-)

New commits:
commit 739a3243944d533d94d244d1464c0b8ec49e214c
Author: Arkadiy Illarionov 
AuthorDate: Fri Jan 11 01:40:49 2019 +0300
Commit: Noel Grandin 
CommitDate: Tue Jan 15 07:05:18 2019 +0100

Simplify containers iterations in sc/source/ui/docshell

Use range-based loop or replace with STL functions

Change-Id: I7ab254241ff5b9637ac28282ad0868b3c55a1fb3
Reviewed-on: https://gerrit.libreoffice.org/66135
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/docshell/autostyl.cxx 
b/sc/source/ui/docshell/autostyl.cxx
index d7db2e4a7d5a..41458d241159 100644
--- a/sc/source/ui/docshell/autostyl.cxx
+++ b/sc/source/ui/docshell/autostyl.cxx
@@ -83,15 +83,14 @@ void ScAutoStyleList::AddInitial( const ScRange& rRange, 
const OUString& rStyle1
 
 IMPL_LINK_NOARG(ScAutoStyleList, InitHdl, Timer *, void)
 {
-std::vector::iterator iter;
-for (iter = aInitials.begin(); iter != aInitials.end(); ++iter)
+for (const auto& rInitial : aInitials)
 {
 //  apply first style immediately
-pDocSh->DoAutoStyle(iter->aRange,iter->aStyle1);
+pDocSh->DoAutoStyle(rInitial.aRange, rInitial.aStyle1);
 
 //  add second style to list
-if (iter->nTimeout)
-AddEntry(iter->nTimeout,iter->aRange,iter->aStyle2 );
+if (rInitial.nTimeout)
+AddEntry(rInitial.nTimeout, rInitial.aRange, rInitial.aStyle2 );
 }
 
 aInitials.clear();
@@ -131,13 +130,12 @@ void ScAutoStyleList::AddEntry( sal_uLong nTimeout, const 
ScRange& rRange, const
 
 void ScAutoStyleList::AdjustEntries( sal_uLong nDiff )  // milliseconds
 {
-std::vector::iterator iter;
-for (iter = aEntries.begin(); iter != aEntries.end(); ++iter)
+for (auto& rEntry : aEntries)
 {
-if (iter->nTimeout <= nDiff)
-iter->nTimeout = 0; // expired
+if (rEntry.nTimeout <= nDiff)
+rEntry.nTimeout = 0; // expired
 else
-iter->nTimeout -= nDiff;// continue counting
+rEntry.nTimeout -= nDiff;// continue counting
 }
 }
 
@@ -162,9 +160,8 @@ void ScAutoStyleList::ExecuteAllNow()
 {
 aTimer.Stop();
 
-std::vector::iterator iter;
-for (iter = aEntries.begin(); iter != aEntries.end(); ++iter)
-pDocSh->DoAutoStyle(iter->aRange,iter->aStyle);
+for (const auto& rEntry : aEntries)
+pDocSh->DoAutoStyle(rEntry.aRange, rEntry.aStyle);
 
 aEntries.clear();
 }
diff --git a/sc/source/ui/docshell/datastream.cxx 
b/sc/source/ui/docshell/datastream.cxx
index bbbed185ef35..4e3c700c73f1 100644
--- a/sc/source/ui/docshell/datastream.cxx
+++ b/sc/source/ui/docshell/datastream.cxx
@@ -477,12 +477,10 @@ void DataStream::Text2Doc()
 
 MoveData();
 {
-std::vector::const_iterator it = aLine.maCells.begin(), itEnd = 
aLine.maCells.end();
 SCCOL nCol = maStartRange.aStart.Col();
 const char* pLineHead = aLine.maLine.getStr();
-for (; it != itEnd; ++it, ++nCol)
+for (const Cell& rCell : aLine.maCells)
 {
-const Cell& rCell = *it;
 if (rCell.mbValue)
 {
 maDocAccess.setNumericCell(
@@ -494,6 +492,7 @@ void DataStream::Text2Doc()
 ScAddress(nCol, mnCurRow, maStartRange.aStart.Tab()),
 OUString(pLineHead+rCell.maStr.Pos, rCell.maStr.Size, 
RTL_TEXTENCODING_UTF8));
 }
+++nCol;
 }
 }
 
diff --git a/sc/source/ui/docshell/dbdocfun.cxx 
b/sc/source/ui/docshell/dbdocfun.cxx
index aec29c4434e8..8a7896a71024 100644
--- a/sc/source/ui/docshell/dbdocfun.cxx
+++ b/sc/source/ui/docshell/dbdocfun.cxx
@@ -251,12 +251,11 @@ void ScDBDocFunc::ModifyAllDBData( const ScDBCollection& 
rNewColl, const std::ve
 std::unique_ptr pUndoColl;
 bool bRecord = rDoc.IsUndoEnabled();
 
-std::vector::const_iterator iter;
-for (iter = rDelAreaList.begin(); iter != rDelAreaList.end(); ++iter)
+for (const auto& rDelArea : rDelAreaList)
 {
 // unregistering target in SBA no longer necessary
-const ScAddress& rStart = iter->aStart;
-const ScAddress& rEnd   = iter->aEnd;
+const ScAddress& rStart = rDelArea.aStart;
+const ScAddress& 

[Libreoffice-commits] core.git: desktop/source

[Libreoffice Gerrit user]

 desktop/source/app/dispatchwatcher.cxx |   41 -
 1 file changed, 15 insertions(+), 26 deletions(-)

New commits:
commit a975d17e715bcf317e40d19ef47cc37660b81f7e
Author: Mike Kaganski 
AuthorDate: Tue Jan 15 07:22:37 2019 +0100
Commit: Mike Kaganski 
CommitDate: Tue Jan 15 08:39:23 2019 +0100

Use utl::TempFile for exception safety

... to not leak temporary cat files

Change-Id: I99e230054f1a3ed6aabce63d427483808e969716
Reviewed-on: https://gerrit.libreoffice.org/66343
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/desktop/source/app/dispatchwatcher.cxx 
b/desktop/source/app/dispatchwatcher.cxx
index 21fa4ff6b956..3a8b2d9961a0 100644
--- a/desktop/source/app/dispatchwatcher.cxx
+++ b/desktop/source/app/dispatchwatcher.cxx
@@ -57,6 +57,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -579,12 +580,15 @@ bool DispatchWatcher::executeDispatchRequests( const 
std::vector fileForCat;
 if( aDispatchRequest.aRequestType == REQUEST_CAT )
 {
-if( ::osl::FileBase::createTempFile(nullptr, 
nullptr, ) != ::osl::FileBase::E_None )
+fileForCat = std::make_unique();
+if (fileForCat->IsValid())
+fileForCat->EnableKillingFile();
+else
 std::cerr << "Error: Cannot create 
temporary file..." << std::endl ;
-aOutFile = fileForCat;
+aOutFile = fileForCat->GetURL();
 }
 
 if ( bGuess )
@@ -657,33 +661,18 @@ bool DispatchWatcher::executeDispatchRequests( const 
std::vectorIsValid())
 {
-osl::File aFile(fileForCat);
-osl::File::RC aRC = 
aFile.open(osl_File_OpenFlag_Read);
-if (aRC != osl::File::E_None)
-{
-std::cerr << "Error: Cannot read from 
temp file" << std::endl;
-}
-else
+SvStream* aStream = 
fileForCat->GetStream(StreamMode::STD_READ);
+while (aStream->good())
 {
-sal_Bool eof;
-for (;;)
+OString aStr;
+aStream->ReadLine(aStr, SAL_MAX_INT32);
+for (sal_Int32 i = 0; i < 
aStr.getLength(); ++i)
 {
-aFile.isEndOfFile(  );
-if (eof)
-break;
-rtl::ByteSequence bseq;
-aFile.readLine(bseq);
-unsigned const char * aStr = 
reinterpret_cast(bseq.getConstArray());
-for (sal_Int32 i = 0; i < 
bseq.getLength(); ++i)
-{
-std::cout << aStr[i];
-}
-std::cout << std::endl;
+std::cout << aStr[i];
 }
-aFile.close();
-osl::File::remove(fileForCat);
+std::cout << std::endl;
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

[Stephan Bergmann]

On 13/01/2019 23:57, Дилян Палаузов wrote:

LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting:

[build SPP] scp2/source/ooo/ure
[build SCP] scp2/source/writer/file_writer
[build SPP] scp2/source/xsltfilter/file_xsltfilter
[build SPP] scp2/source/xsltfilter/module_xsltfilter
[build SPP] scp2/source/gnome/file_gnome
[build SPP] scp2/source/gnome/module_gnome
[build SPP] scp2/source/sdkoo/sdkoo
[build SCP] scp2/source/writer/module_writer
[build CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx
In file included from 
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24,
  from 
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22:
 error: ‘virtual void
pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, 
but does not override
  virtual void drawString(GfxState *state, const GooString *s) override;
   ^~
/src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22:
 warning:   by ‘virtual void
pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ [-Woverloaded-virtual]
make[1]: *** [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: 
/src/libreoffice-


You likely need a backport of 
 
"fix build with poppler 0.64" (and maybe also backports of further 
poppler-adaption fixes in that area), or configure --without-system-poppler.


There is obviously always a chance that building old versions of LO 
against current system components does not work.  Often enough, you will 
find fixes for those issues in later versions of LO, and which are often 
even easy to backport to the version where you need them.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

[Kaganski Mike]

On 14.01.2019 11:46, Stephan Bergmann wrote:
> On 13/01/2019 23:57, Дилян Палаузов wrote:
>> LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting:
>>
>> [build SPP] scp2/source/ooo/ure
>> [build SCP] scp2/source/writer/file_writer
>> [build SPP] scp2/source/xsltfilter/file_xsltfilter
>> [build SPP] scp2/source/xsltfilter/module_xsltfilter
>> [build SPP] scp2/source/gnome/file_gnome
>> [build SPP] scp2/source/gnome/module_gnome
>> [build SPP] scp2/source/sdkoo/sdkoo
>> [build SCP] scp2/source/writer/module_writer
>> [build CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx
>> In file included from 
>> /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24,
>>  
>>
>>   from 
>> /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
>>  
>>
>> /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22:
>>  
>> error: ‘virtual void
>> pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked 
>> ‘override’, but does not override
>>   virtual void drawString(GfxState *state, const GooString *s) 
>> override;
>>    ^~
>> /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22:
>>  
>> warning:   by ‘virtual void
>> pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ 
>> [-Woverloaded-virtual]
>> make[1]: *** 
>> [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: 
>> /src/libreoffice-
> 
> You likely need a backport of 
> 
>  
> "fix build with poppler 0.64" (and maybe also backports of further 
> poppler-adaption fixes in that area), or configure 
> --without-system-poppler.
> 
> There is obviously always a chance that building old versions of LO 
> against current system components does not work.  Often enough, you will 
> find fixes for those issues in later versions of LO, and which are often 
> even easy to backport to the version where you need them.

I'm afraid that the message implies that the fix from spring 2018 is 
already there - the constness of the GooString parameter is there in the 
message. So possibly there's some problem detecting the poppler library 
version?

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sd/source

[Libreoffice Gerrit user]

 sd/source/ui/view/drviews3.cxx |2 +-
 sd/source/ui/view/outlnvs2.cxx |2 +-
 sd/source/ui/view/sdview2.cxx  |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit de63114d76433b5a1f1ed0286e28545c72330630
Author: Noel Grandin 
AuthorDate: Thu Jan 10 15:00:45 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 14 09:04:05 2019 +0100

no need to test for the presence of the dialog factory

Change-Id: I3994b2fcd552ce616d8a2e6fa144069853966a61
Reviewed-on: https://gerrit.libreoffice.org/66100
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sd/source/ui/view/drviews3.cxx b/sd/source/ui/view/drviews3.cxx
index 7d0d48fed5d3..90ec37b63b08 100644
--- a/sd/source/ui/view/drviews3.cxx
+++ b/sd/source/ui/view/drviews3.cxx
@@ -295,7 +295,7 @@ void  DrawViewShell::ExecCtrl(SfxRequest& rReq)
 case SID_INSERT_DATE_TIME:
 {
 SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create();
-VclPtr pDlg(pFact ? 
pFact->CreateHeaderFooterDialog( this, GetActiveWindow(), GetDoc(), 
mpActualPage ) : nullptr);
+VclPtr 
pDlg(pFact->CreateHeaderFooterDialog( this, GetActiveWindow(), GetDoc(), 
mpActualPage ));
 std::shared_ptr xRequest(new SfxRequest(rReq));
 rReq.Ignore(); // the 'old' request is not relevant any more
 pDlg->StartExecuteAsync([this, xRequest](sal_Int32 /*nResult*/){
diff --git a/sd/source/ui/view/outlnvs2.cxx b/sd/source/ui/view/outlnvs2.cxx
index 7526d58275e0..867ebe45bc4f 100644
--- a/sd/source/ui/view/outlnvs2.cxx
+++ b/sd/source/ui/view/outlnvs2.cxx
@@ -570,7 +570,7 @@ void OutlineViewShell::FuTemporaryModify(SfxRequest )
 // Dialog...
 SdAbstractDialogFactory* pFact = 
SdAbstractDialogFactory::Create();
 vcl::Window* pWin = GetActiveWindow();
-ScopedVclPtr pDlg(pFact ? 
pFact->CreateSdModifyFieldDlg(pWin ? pWin->GetFrameWeld() : nullptr, 
pFldItem->GetField(), pOutlinerView->GetAttribs() ) : nullptr);
+ScopedVclPtr 
pDlg(pFact->CreateSdModifyFieldDlg(pWin ? pWin->GetFrameWeld() : nullptr, 
pFldItem->GetField(), pOutlinerView->GetAttribs() ));
 if( pDlg->Execute() == RET_OK )
 {
 std::unique_ptr pField(pDlg->GetField());
diff --git a/sd/source/ui/view/sdview2.cxx b/sd/source/ui/view/sdview2.cxx
index e9fd56d3d8d0..8b7975bfabf6 100644
--- a/sd/source/ui/view/sdview2.cxx
+++ b/sd/source/ui/view/sdview2.cxx
@@ -874,7 +874,7 @@ bool View::GetExchangeList (std::vector 
,
 OUString aDesc(SdResId(STR_DESC_NAMEGROUP));
 
 SvxAbstractDialogFactory* pFact = 
SvxAbstractDialogFactory::Create();
-ScopedVclPtr pDlg(pFact ? 
pFact->CreateSvxNameDialog(mpViewSh->GetFrameWeld(), aNewName, aDesc) : 
nullptr);
+ScopedVclPtr 
pDlg(pFact->CreateSvxNameDialog(mpViewSh->GetFrameWeld(), aNewName, aDesc));
 
 pDlg->SetEditHelpId( HID_SD_NAMEDIALOG_OBJECT );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: How to re-trigger a single build job in gerrit?

[Miklos Vajna]

Hi Matteo,

On Sun, Jan 13, 2019 at 11:18:55AM +0100, Matteo Casalin 
 wrote:
> executing all of the jobs (gerrit_linux*, gerrit_macos, gerrit_windows)? Up
> to know I just rebased the patch, but this looks to me as quite inefficient.

Register at ci.libreoffice.org, then talk to the infra guys at
#tdf-infra (freenode IRC), once you get the right to "resume a build",
you would see an extra button on the Jenkins UI to do exactly this: just
try the failing builds once more, without rebuilding already successful
platforms.

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/win

[Libreoffice Gerrit user]

 vcl/win/gdi/gdiimpl.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 4da70cfe433c7c2b52709d5f689b274e1bccaaeb
Author: Andrea Gelmini 
AuthorDate: Sun Jan 13 22:12:14 2019 +
Commit: Julien Nabet 
CommitDate: Mon Jan 14 09:31:04 2019 +0100

Fix typos

Change-Id: Ie78ae1a8d440d23cece788dc01789c8fd0cfe2e3
Reviewed-on: https://gerrit.libreoffice.org/66276
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index bb70bc3901c3..3b209075defc 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -1941,7 +1941,7 @@ static void impAddB2DPolygonToGDIPlusGraphicsPathReal(
 
 // tdf#99165 MS Gdiplus cannot handle creating correct 
extra geometry for fat lines
 // with LineCap or LineJoin when a bezier segment starts 
or ends trivial, e.g. has
-// no 1st or 2nd control point, despite that these are 
mathematicaly correct definitions
+// no 1st or 2nd control point, despite that these are 
mathematically correct definitions
 // (basegfx can handle that).
 // Caution: This error (and it's correction) might be 
necessary for other graphical
 // sub-systems in a similar way.
@@ -2347,9 +2347,9 @@ bool WinSalGraphicsImpl::drawPolyLine(
 
 if(mrParent.isPrinter())
 {
-// tdf#122384 As metioned above in WinSalGraphicsImpl::drawPolyPolygon
+// tdf#122384 As mentioned above in WinSalGraphicsImpl::drawPolyPolygon
 // (look for 'One more hint: This *may* also be needed now in'...).
-// See comments in same spot above *uregntly* before doing changes 
here,
+// See comments in same spot above *urgently* before doing changes 
here,
 // these comments are *still fully valid* at this place (!)
 const Gdiplus::REAL aDpiX(aGraphics.GetDpiX());
 const Gdiplus::REAL aDpiY(aGraphics.GetDpiY());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - officecfg/registry

[Libreoffice Gerrit user]

 officecfg/registry/data/org/openoffice/VCL.xcu |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 3b10c732a83122198886ec16986110d5ad668a1e
Author: Gabor Kelemen 
AuthorDate: Wed Jan 9 07:28:28 2019 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jan 14 10:25:53 2019 +0100

tdf#107416 Revert "tdf#103703 Turn on single print jobs for collated prints"

Turns out this was a wrong solution to the problem, also
causing printout mixups on busy printers for the users

This reverts commit 37c3e57c788fb5ad931126ea233093d87ac3dbc3.

Change-Id: I8a456f4c90f48854c1f5e92dc39ed4ec8a17cf75
Reviewed-on: https://gerrit.libreoffice.org/65993
Tested-by: Jenkins
Reviewed-by: László Németh 
(cherry picked from commit 2117257eafac507b6af0be86ae62261fd192089a)
Reviewed-on: https://gerrit.libreoffice.org/66127
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/officecfg/registry/data/org/openoffice/VCL.xcu 
b/officecfg/registry/data/org/openoffice/VCL.xcu
index 4ad59f829c0e..97f2770dee56 100644
--- a/officecfg/registry/data/org/openoffice/VCL.xcu
+++ b/officecfg/registry/data/org/openoffice/VCL.xcu
@@ -47,9 +47,6 @@
   
 Default
   
-  
-true
-  
 
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-0' - vcl/win

[Libreoffice Gerrit user]

 vcl/win/gdi/gdiimpl.cxx |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit d37d6070dd5300d249940d7f8d960ff6d4d9a036
Author: Armin Le Grand 
AuthorDate: Fri Jan 11 17:59:59 2019 +0100
Commit: Caolán McNamara 
CommitDate: Mon Jan 14 10:27:05 2019 +0100

tdf#122384 Added isPrinter support to WinSalGraphicsImpl::drawPolyLine

As already guessed but not been sure (see 'One more hint'
in WinSalGraphicsImpl::drawPolyPolygon) the strange WinGDI
transform is also needed when printing for WinSalGraphicsImpl::
drawPolyLine.

Change-Id: I39f89eac0c17e524949221306723a355c6e94a17
Reviewed-on: https://gerrit.libreoffice.org/66190
Tested-by: Jenkins
Reviewed-by: Armin Le Grand 
(cherry picked from commit 6e3c4ae8bca898700cde9caaff43c3a8a61eebc2)
Reviewed-on: https://gerrit.libreoffice.org/66270
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 5af161ebbe2a0183c1302099c995548d82965fa9)
Reviewed-on: https://gerrit.libreoffice.org/66271
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index fa6dccb48c5a..10aad77ed229 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -2310,6 +2310,21 @@ bool WinSalGraphicsImpl::drawPolyLine(
 aGraphics.SetSmoothingMode(Gdiplus::SmoothingModeNone);
 }
 
+if(mrParent.isPrinter())
+{
+// tdf#122384 As metioned above in WinSalGraphicsImpl::drawPolyPolygon
+// (look for 'One more hint: This *may* also be needed now in'...).
+// See comments in same spot above *uregntly* before doing changes 
here,
+// these comments are *still fully valid* at this place (!)
+const Gdiplus::REAL aDpiX(aGraphics.GetDpiX());
+const Gdiplus::REAL aDpiY(aGraphics.GetDpiY());
+
+aGraphics.ScaleTransform(
+Gdiplus::REAL(100.0) / aDpiX,
+Gdiplus::REAL(100.0) / aDpiY,
+Gdiplus::MatrixOrderAppend);
+}
+
 aGraphics.DrawPath(
 ,
 &(*pGraphicsPath));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/xmloff sw/source xmloff/source

[Libreoffice Gerrit user]

 include/xmloff/prhdlfac.hxx   |2 
 sw/source/filter/xml/xmlexpit.cxx |4 
 sw/source/filter/xml/xmlimpit.cxx |   15 --
 xmloff/source/style/prhdlfac.cxx  |  213 ++
 4 files changed, 112 insertions(+), 122 deletions(-)

New commits:
commit 6a70f2a42944918379f3bbefe080a6189bafd6a8
Author: Noel Grandin 
AuthorDate: Fri Jan 11 15:20:15 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 14 10:57:24 2019 +0100

use unique_ptr in XMLPropertyHandlerFactory::CreatePropertyHandler

Change-Id: Idb33e3a23b7e6001b2c549875a16b475d3ecd470
Reviewed-on: https://gerrit.libreoffice.org/66186
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/xmloff/prhdlfac.hxx b/include/xmloff/prhdlfac.hxx
index 0b517208aeee..2ad3f3d7a920 100644
--- a/include/xmloff/prhdlfac.hxx
+++ b/include/xmloff/prhdlfac.hxx
@@ -87,7 +87,7 @@ public:
  *  use the handler cache. This method should only be called in special
  *  circumstances; calling GetPropertyHandler is almost always
  *  preferable. */
-static const XMLPropertyHandler* CreatePropertyHandler( sal_Int32 nType );
+static std::unique_ptr CreatePropertyHandler( 
sal_Int32 nType );
 
 protected:
 /** Retrieves a PropertyHandler from the internal cache */
diff --git a/sw/source/filter/xml/xmlexpit.cxx 
b/sw/source/filter/xml/xmlexpit.cxx
index 127fa9f4d909..989602e666b6 100644
--- a/sw/source/filter/xml/xmlexpit.cxx
+++ b/sw/source/filter/xml/xmlexpit.cxx
@@ -1062,7 +1062,7 @@ bool SvXMLExportItemMapper::QueryXMLValue(
 bOk = rItem.QueryValue( aAny );
 if( bOk )
 {
-const XMLPropertyHandler* pWritingModeHandler =
+std::unique_ptr pWritingModeHandler =
 XMLPropertyHandlerFactory::CreatePropertyHandler(
 XML_TYPE_TEXT_WRITING_MODE_WITH_DEFAULT );
 OUString sValue;
@@ -1070,8 +1070,6 @@ bool SvXMLExportItemMapper::QueryXMLValue(
   rUnitConverter );
 if( bOk )
 aOut.append( sValue );
-
-delete pWritingModeHandler;
 }
 }
 break;
diff --git a/sw/source/filter/xml/xmlimpit.cxx 
b/sw/source/filter/xml/xmlimpit.cxx
index 5136416a06ae..1e921ac9dce6 100644
--- a/sw/source/filter/xml/xmlimpit.cxx
+++ b/sw/source/filter/xml/xmlimpit.cxx
@@ -905,19 +905,14 @@ bool SvXMLImportItemMapper::PutXMLValue(
 
 case RES_FRAMEDIR:
 {
-const XMLPropertyHandler* pWritingModeHandler =
+std::unique_ptr pWritingModeHandler =
 XMLPropertyHandlerFactory::CreatePropertyHandler(
 XML_TYPE_TEXT_WRITING_MODE_WITH_DEFAULT );
-if( pWritingModeHandler != nullptr )
-{
-Any aAny;
-bOk = pWritingModeHandler->importXML( rValue, aAny,
+Any aAny;
+bOk = pWritingModeHandler->importXML( rValue, aAny,
   rUnitConverter );
-if( bOk )
-bOk = rItem.PutValue( aAny, 0 );
-
-delete pWritingModeHandler;
-}
+if( bOk )
+bOk = rItem.PutValue( aAny, 0 );
 }
 break;
 
diff --git a/xmloff/source/style/prhdlfac.cxx b/xmloff/source/style/prhdlfac.cxx
index 539967955d77..2f5387c8c471 100644
--- a/xmloff/source/style/prhdlfac.cxx
+++ b/xmloff/source/style/prhdlfac.cxx
@@ -158,310 +158,307 @@ void XMLPropertyHandlerFactory::PutHdlCache( sal_Int32 
nType, const XMLPropertyH
 const XMLPropertyHandler* XMLPropertyHandlerFactory::GetBasicHandler( 
sal_Int32 nType ) const
 {
 const XMLPropertyHandler* pPropHdl = GetHdlCache( nType );
+if( pPropHdl )
+return pPropHdl;
 
-if( !pPropHdl )
-{
-pPropHdl = CreatePropertyHandler( nType );
-
-if( pPropHdl )
-PutHdlCache( nType, pPropHdl );
-}
-
-return pPropHdl;
+std::unique_ptr pNewPropHdl = CreatePropertyHandler( 
nType );
+if( pNewPropHdl )
+PutHdlCache( nType, pNewPropHdl.get() );
+return pNewPropHdl.release();
 }
 
-const XMLPropertyHandler* XMLPropertyHandlerFactory::CreatePropertyHandler( 
sal_Int32 nType )
+std::unique_ptr 
XMLPropertyHandlerFactory::CreatePropertyHandler( sal_Int32 nType )
 {
-XMLPropertyHandler* pPropHdl = nullptr;
+std::unique_ptr pPropHdl;
 
 switch( nType )
 {
 case XML_TYPE_BOOL :
-pPropHdl = new XMLBoolPropHdl;
+pPropHdl.reset(new XMLBoolPropHdl);
 break;
 case XML_TYPE_BOOL_FALSE :
-pPropHdl = new XMLBoolFalsePropHdl;
+pPropHdl.reset(new XMLBoolFalsePropHdl);
 break;
 case XML_TYPE_MEASURE :
-pPropHdl = new XMLMeasurePropHdl( 4 );
+pPropHdl.reset(new XMLMeasurePropHdl( 4 ));

[Libreoffice-commits] core.git: svl/source sw/source

[Libreoffice Gerrit user]

 svl/source/items/itempool.cxx   |4 ++--
 sw/source/core/doc/DocumentStylePoolManager.cxx |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 424a1a8a06eb03d4c84fd63ca1b73abad0324f89
Author: Caolán McNamara 
AuthorDate: Mon Jan 14 09:22:17 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Jan 14 11:47:35 2019 +0100

ofz#12507 micro opt

Change-Id: I7cdb2e371cb3e209b71659174594bf5bb687f379
Reviewed-on: https://gerrit.libreoffice.org/66284
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx
index f0945aaf3b2e..4ac7eb7cd60d 100644
--- a/svl/source/items/itempool.cxx
+++ b/svl/source/items/itempool.cxx
@@ -756,8 +756,8 @@ void SfxItemPool::Remove( const SfxPoolItem& rItem )
 SfxPoolItemArray_Impl* pItemArr = pImpl->maPoolItems[nIndex].get();
 assert(pItemArr && "removing Item not in Pool");
 
-SfxPoolItemArray_Impl::PoolItemPtrToIndexMap::const_iterator it;
-it = pItemArr->maPtrToIndex.find(const_cast());
+SfxPoolItemArray_Impl::PoolItemPtrToIndexMap::const_iterator it
+= pItemArr->maPtrToIndex.find(const_cast());
 if (it != pItemArr->maPtrToIndex.end())
 {
 sal_uInt32 nIdx = it->second;
diff --git a/sw/source/core/doc/DocumentStylePoolManager.cxx 
b/sw/source/core/doc/DocumentStylePoolManager.cxx
index 7edd055f1e95..19c09209e1bf 100644
--- a/sw/source/core/doc/DocumentStylePoolManager.cxx
+++ b/sw/source/core/doc/DocumentStylePoolManager.cxx
@@ -583,7 +583,7 @@ SwTextFormatColl* 
DocumentStylePoolManager::GetTextCollFromPool( sal_uInt16 nId,
 
 SwTextFormatColl* pNewColl;
 sal_uInt16 nOutLvlBits = 0;
-for( size_t n = 0; n < m_rDoc.GetTextFormatColls()->size(); ++n )
+for (size_t n = 0, nSize = m_rDoc.GetTextFormatColls()->size(); n < nSize; 
++n)
 {
 if( nId == ( pNewColl = (*m_rDoc.GetTextFormatColls())[ n ] 
)->GetPoolFormatId() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source

[Libreoffice Gerrit user]

 cui/source/options/optgdlg.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6c904345b1f3e02db5ab163f46517fec2b85e539
Author: Caolán McNamara 
AuthorDate: Mon Jan 14 09:48:43 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Jan 14 12:09:53 2019 +0100

Resolves: tdf#122701 opengl settings don't affect gtk3

Change-Id: Iffcf9b6ea8d191a509c2ca451f2ce4a249fde922
Reviewed-on: https://gerrit.libreoffice.org/66285
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index 9fa7ce06d79b..80cb1cb442a7 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -526,7 +526,7 @@ CanvasSettings::CanvasSettings() :
 bool CanvasSettings::IsHardwareAccelerationAvailable() const
 {
 #if HAVE_FEATURE_OPENGL
-if( OpenGLWrapper::isVCLOpenGLEnabled() )
+if (OpenGLWrapper::isVCLOpenGLEnabled() && Application::GetToolkitName() 
!= "gtk3")
 mbHWAccelAvailable = false;
 
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Libreoffice Gerrit user]

 vcl/source/outdev/font.cxx |   12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

New commits:
commit 64d8e5f8db70f4f913abb902b41f4cff8dd1cdad
Author: Mike Kaganski 
AuthorDate: Mon Jan 14 12:50:01 2019 +0100
Commit: Mike Kaganski 
CommitDate: Mon Jan 14 14:18:53 2019 +0100

Don't use own redundant mutex, since it's guarded by SolarMutex

Change-Id: Ie93519c6e0363344baf91bb2792f9da2cd13df7d
Reviewed-on: https://gerrit.libreoffice.org/66294
Reviewed-by: Michael Meeks 
Tested-by: Jenkins

diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index 4d982e9d1f3a..04e689a17f67 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -595,18 +595,10 @@ void OutputDevice::ImplClearAllFontData(bool 
bNewFontLists)
 }
 }
 
-namespace {
-osl::Mutex& GetFontUpdatesLockMutex()
-{
-static osl::Mutex aFontUpdatesMutex;
-return aFontUpdatesMutex;
-}
-}
-
 void OutputDevice::ImplRefreshAllFontData(bool bNewFontLists)
 {
 auto svdata = ImplGetSVData();
-osl::MutexGuard aGuard(GetFontUpdatesLockMutex());
+DBG_TESTSOLARMUTEX();
 if (!svdata->mnFontUpdatesLockCount)
 ImplUpdateFontDataForAllFrames(::ImplRefreshFontData, 
bNewFontLists);
 else
@@ -663,7 +655,7 @@ void OutputDevice::ImplUpdateFontDataForAllFrames( const 
FontUpdateHandler_t pHd
 void OutputDevice::LockFontUpdates(bool bLock)
 {
 auto svdata = ImplGetSVData();
-osl::MutexGuard aGuard(GetFontUpdatesLockMutex());
+DBG_TESTSOLARMUTEX();
 if (bLock)
 {
 ++svdata->mnFontUpdatesLockCount;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source

[Libreoffice Gerrit user]

 cui/source/tabpages/autocdlg.cxx |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 8aa5abf3aaae062ae41a4d2f122170da9e31cf67
Author: Caolán McNamara 
AuthorDate: Mon Jan 14 10:08:08 2019 +
Commit: Caolán McNamara 
CommitDate: Mon Jan 14 14:22:29 2019 +0100

Resolves: tdf#122627 be explicit about what column to check

Change-Id: Icdd1cef6b0bc9d8dd61c309dc9de66021fc9422d
Reviewed-on: https://gerrit.libreoffice.org/66286
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index add6fb72f3cf..3d177683458d 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -245,6 +245,10 @@ void OfaAutocorrOptionsPage::InsertEntry(const OUString& 
rTxt)
 m_xCheckLB->set_text(nRow, rTxt, 1);
 }
 
+#define CBCOL_FIRST 0
+#define CBCOL_SECOND1
+#define CBCOL_BOTH  2
+
 void OfaAutocorrOptionsPage::Reset( const SfxItemSet* )
 {
 SvxAutoCorrect* pAutoCorrect = SvxAutoCorrCfg::Get().GetAutoCorrect();
@@ -263,14 +267,14 @@ void OfaAutocorrOptionsPage::Reset( const SfxItemSet* )
 InsertEntry(m_sAccidentalCaps);
 
 int nPos = 0;
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::Autocorrect) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CapitalStartWord) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & 
ACFlags::CapitalStartSentence) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgWeightUnderl) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::SetINetAttr) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgToEnEmDash) );
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::IgnoreDoubleSpace) 
);
-m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CorrectCapsLock) );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::Autocorrect), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CapitalStartWord), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & 
ACFlags::CapitalStartSentence), CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgWeightUnderl), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::SetINetAttr), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::ChgToEnEmDash), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::IgnoreDoubleSpace), 
CBCOL_FIRST );
+m_xCheckLB->set_toggle( nPos++, bool(nFlags & ACFlags::CorrectCapsLock), 
CBCOL_FIRST );
 
 m_xCheckLB->thaw();
 }
@@ -319,10 +323,6 @@ public:
 /*   */
 /*/
 
-#define CBCOL_FIRST 0
-#define CBCOL_SECOND1
-#define CBCOL_BOTH  2
-
 enum OfaAutoFmtOptions
 {
 USE_REPLACE_TABLE,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source toolkit/source

[Libreoffice Gerrit user]

 basic/source/sbx/sbxarray.cxx |6 +-
 toolkit/source/awt/vclxwindow.cxx |2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 1977291fc08de7425db469e21bd2ad385e722707
Author: Noel Grandin 
AuthorDate: Mon Jan 14 13:19:32 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 14 15:03:32 2019 +0100

tdf#122250 Crash when running extension

as a consequence of

commit 4e07987ce8134312920682e3481c3f8e3d7b66c3
Date:   Thu Aug 25 15:08:55 2016 +0200
cid#1371154 Missing move assignment operator

this extensions appears to pass bogus data into VCLXWindow::setProperty,
so I had to workaround that when debugging

Change-Id: Ib6728c0a990bd7cfbfed43d79b7560bd2f7f5a67
Reviewed-on: https://gerrit.libreoffice.org/66293
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basic/source/sbx/sbxarray.cxx b/basic/source/sbx/sbxarray.cxx
index fc86839c1d24..1b7054f2d9f7 100644
--- a/basic/source/sbx/sbxarray.cxx
+++ b/basic/source/sbx/sbxarray.cxx
@@ -190,10 +190,14 @@ void SbxArray::Put( SbxVariable* pVar, sal_uInt16 nIdx )
 if( eType != SbxOBJECT || pVar->GetClass() != 
SbxClassType::Object )
 pVar->Convert( eType );
 SbxVariableRef& rRef = GetRef( nIdx );
+// tdf#122250. It is possible that I hold the last reference to 
myself, so check, otherwise I might
+// call SetFlag on myself after I have died.
+bool removingMyself = rRef.get() && rRef->GetParameters() == this && 
GetRefCount() == 1;
 if(rRef.get() != pVar )
 {
 rRef = pVar;
-SetFlag( SbxFlagBits::Modified );
+if (!removingMyself)
+SetFlag( SbxFlagBits::Modified );
 }
 }
 }
diff --git a/toolkit/source/awt/vclxwindow.cxx 
b/toolkit/source/awt/vclxwindow.cxx
index ddd25add186a..6f8212149db8 100644
--- a/toolkit/source/awt/vclxwindow.cxx
+++ b/toolkit/source/awt/vclxwindow.cxx
@@ -1717,6 +1717,8 @@ void VCLXWindow::setProperty( const OUString& 
PropertyName, const css::uno::Any&
 WinBits nStyle = pWindow->GetStyle();
 sal_uInt16 nTmp = 0;
 Value >>= nTmp;
+// clear any dodgy bits passed in, can come from dodgy extensions
+nTmp &= o3tl::typed_flags::mask;
 WindowBorderStyle nBorder = static_cast(nTmp);
 if ( !bool(nBorder) )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-0' - vcl/inc vcl/qt5

[Libreoffice Gerrit user]

 vcl/inc/qt5/Qt5Menu.hxx |2 +-
 vcl/qt5/Qt5Menu.cxx |   13 -
 2 files changed, 9 insertions(+), 6 deletions(-)

New commits:
commit 561f0d49a3ad481eefc24cf94b44ce10bdad
Author: Aleksei Nikiforov 
AuthorDate: Thu Jan 10 15:54:56 2019 +0300
Commit: Katarina Behrens 
CommitDate: Mon Jan 14 12:33:29 2019 +0100

tdf#122253 KDE5: Correct parent menu before it's used

Also correct action group of menu

Change-Id: Ie7eddd3cdc9fa1c36fdeaa1e96eb5d50d7126c09
Reviewed-on: https://gerrit.libreoffice.org/66146
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit c278857137ea0e9e25613d5f6bf8ddaf1336fbcc)
Reviewed-on: https://gerrit.libreoffice.org/66173
Reviewed-by: Aleksei Nikiforov 
Reviewed-by: Michael Weghorn 
(cherry picked from commit b6704c14ce2241e76904e494125a520814ec5021)
Reviewed-on: https://gerrit.libreoffice.org/66290
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index 9f7469fa3f78..b3b06bfeabac 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -33,7 +33,7 @@ private:
 QMenu* mpQMenu;
 QActionGroup* mpQActionGroup;
 
-void DoFullMenuUpdate(Menu* pMenuBar, QMenu* pParentMenu = nullptr);
+void DoFullMenuUpdate(Menu* pMenuBar);
 static void NativeItemText(OUString& rItemText);
 
 QMenu* InsertMenuItem(Qt5MenuItem* pSalMenuItem, unsigned nPos);
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 130d7c583f58..d92c0c0e3a8b 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -219,18 +219,17 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
 if (pMainWindow)
 {
 mpQMenuBar = pMainWindow->menuBar();
+mpQMenu = nullptr;
+mpQActionGroup = nullptr;
 
 DoFullMenuUpdate(mpVCLMenu);
 }
 }
 
-void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar, QMenu* pParentMenu)
+void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar)
 {
-mpQMenu = pParentMenu;
-
 if (mbMenuBar && mpQMenuBar)
 mpQMenuBar->clear();
-mpQActionGroup = nullptr;
 
 for (sal_Int32 nItem = 0; nItem < static_cast(GetItemCount()); 
nItem++)
 {
@@ -240,8 +239,12 @@ void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar, QMenu* 
pParentMenu)
 
 if (pSalMenuItem->mpSubMenu != nullptr)
 {
+// correct parent menu and action group before calling 
HandleMenuActivateEvent
+pSalMenuItem->mpSubMenu->mpQMenu = pQMenu;
+pSalMenuItem->mpSubMenu->mpQActionGroup = nullptr;
+
 
pMenuBar->HandleMenuActivateEvent(pSalMenuItem->mpSubMenu->GetMenu());
-pSalMenuItem->mpSubMenu->DoFullMenuUpdate(pMenuBar, pQMenu);
+pSalMenuItem->mpSubMenu->DoFullMenuUpdate(pMenuBar);
 
pMenuBar->HandleMenuDeActivateEvent(pSalMenuItem->mpSubMenu->GetMenu());
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - translations

[Libreoffice Gerrit user]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cec943a9409fbc42f544a3eff5e004f04ee7065e
Author: Christian Lohmaier 
AuthorDate: Mon Jan 14 14:21:35 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Mon Jan 14 14:26:47 2019 +0100

Update git submodules

* Update translations from branch 'libreoffice-6-1'
  - update translations for 6.1.5 rc1

and force-fix errors using pocheck

Change-Id: I166615aa99b23172c2e80a03e86827da34239a44

diff --git a/translations b/translations
index 64dc0c3d98e9..b64d6630ab0c 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 64dc0c3d98e9e84196c25f7ec5e7aca3b5439b0e
+Subproject commit b64d6630ab0c6c02fa0c91988f2193e6aab26df5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/source writerfilter/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/docxattributeoutput.cxx |6 ++
 writerfilter/source/dmapper/SdtHelper.cxx|2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 6ab71fa2d138daa80cba8fd77419fbf2ec89b794
Author: Tamás Zolnai 
AuthorDate: Mon Jan 14 11:27:11 2019 +0100
Commit: Andras Timar 
CommitDate: Mon Jan 14 12:04:17 2019 +0100

tdf#122658: Empty date form field is not exported correctly to DOCX file

We need to export date format and also text content
in case of empty date field. Otherwise the exported
date field will be lost during import into LO Writer
or MSO Word.

Reviewed-on: https://gerrit.libreoffice.org/66194
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 24613d7abf820aff639a276a1819ada8d83e9063)

Change-Id: I5cf65bedba010f64ca8f56262057f3cce32b0943
Reviewed-on: https://gerrit.libreoffice.org/66289
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 915075964cf5..67846f34f73a 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -4997,7 +4997,13 @@ void 
DocxAttributeOutput::WritePostponedFormControl(const SdrObject* pObject)
 }
 }
 else
+{
 aContentText = 
xPropertySet->getPropertyValue("HelpText").get();
+if(aContentText.isEmpty())
+aContentText = " "; // Need to write out something to have it 
imported by MS Word
+if(sDateFormat.isEmpty())
+sDateFormat = "dd/MM/"; // Need to set date format even if 
there is no date set
+}
 
 // output component
 
diff --git a/writerfilter/source/dmapper/SdtHelper.cxx 
b/writerfilter/source/dmapper/SdtHelper.cxx
index 2e93f1b98c83..831b8664097b 100644
--- a/writerfilter/source/dmapper/SdtHelper.cxx
+++ b/writerfilter/source/dmapper/SdtHelper.cxx
@@ -125,7 +125,7 @@ void SdtHelper::createDateControl(OUString const& 
rContentText, const beans::Pro
 xPropertySet->setPropertyValue("Date", uno::makeAny(aDate));
 }
 else
-xPropertySet->setPropertyValue("HelpText", uno::makeAny(rContentText));
+xPropertySet->setPropertyValue("HelpText", 
uno::makeAny(rContentText.trim()));
 
 // append date format to grab bag
 comphelper::SequenceAsHashMap aGrabBag;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [libreoffice-documentation] New XHP editor online for testing and feedback

[Olivier Hallot]

Hi Help Authors, L10n Translators and developers

Following Mike's announcement, I have improved and fixed a bit the XHP
editor, and changed the page address (*) (apologies)

The editor is still work in progress, but starts to become interesting
for creating and editing Help pages.

What's new

--

+ Mike's implementation of the autocompletion of XHP tags

+ The left and right panes are now fixed in browser screen and scrollable

+ The right pane uses 99% of the current Help transformation rendering, plus

+ some visual debug information left intentionally to help Author in
adjusting s, s and s

+ You can now open a Help page directly from the interface. The help
page is normally

source/text//AAA/BBB/myHelpPage.xhp

Type /AAA/BBB/myHelpPage.xhp in the text box and click "Open
File" to load in the editor

Press "Render page" to see it on the right.

+ A set of buttons with XHP snippets to shorten editing workload:

- For paragraphs, notes, headings, emph, menuitems, etc... select the
raw text or contents and click the corresponding button. The raw text
will be wrapped with the opening and closing tag. For paragraph-like
contents, an unique id will be created automatically.

- Other snippets builds fragments of XHP tags, such as tables, tablerow,
lists, sections, and more, including the

- just play with and do not forget to render the page on the right.

Restrictions

-

+ The editor works with Firefox only. Issues with Chrome and Edge. Other
browsers not yet tested.

+ saving files not implemented. However you can copy the editor contents
and finish the patch in you preferred editor

+ More XHP checking are under development, specially id's unicity and
DTD checking

+ If you get a blank page on the right, this is because you hit a bug in
the browser transformation. Unfortunately debugging the browser
transformation is very hard, support is almost none. We will have to
address these issues.


Invitation for developers and testers

-

You are invited to test the editor and report bugs and suggest improvements.

The user interface is simple HTML and Javascript. If you have skills in
these technologies you are a potential developer for the editor, but we
know that PHP will be the right tech choice in near future.

The source code is in the dev-tool repository. To clone the dev-tool
repository :

git clone https://gerrit.libreoffice.org/dev-tools dev-tools

The editor is in dev-tools/help3/html/

If you have a web server working in your computer (Apache, Nginx, etc...) you 
can run the editor locally:

create a link between the web server root and the editor. For example, under 
Debian-like Linux:

sudo cd /var/www/html
sudo ln -s help-editor /dev-tools/help3/html

and point your browser to 

http://localhost/help-editor

Seeking Help and discussion on the editor
-

+ Please use this list, the developer list and our IRC channels to get in touch 
with the development of the editor.

Kind regards

(*) https://newdesign.libreoffice.org/help_editor/index.html

Olivier

Em 04/01/2019 08:39, Mike Saunders escreveu:
> Hello everyone,
>
> Olivier and I have been working on a new XHP editor, to simplify the
> editing of help documentation. The goals of this editor are:
>
> * Ease of use -- with syntax highlighting and autocompletion
> * Web-based -- so it can be used immediately
> * Integrated -- into the Gerrit/Git workflow
>
> We're still working on that final point, but for now, you can try the
> editor here:
>
> https://newdesign.libreoffice.org/new_help_editor/index.html
>
> To test the autocompletion, start with a blank document and type a "<"
> character. You'll see that "helpdocument" is suggested as a top-level
> tag. Hit enter to complete it, then add ">".
>
> Now go to another line and add "<" again, and you'll see child tags
> suggested: "meta" and "body". You can also close the "helpdocument" tag.
> For some tags that have parameters, the editor will show them as well.
>
> Underneath, you see various buttons: undo/redo, starting a new document
> (with the basic structure), and various tags/sections. Rendering on the
> right-hand pane doesn't work yet, but Olivier is looking at that.
>
> Anyway, play around with it, see what you think, and if you want the
> full code to test changes, Olivier can show you how to get it!
>
-- 
Olivier Hallot
LibreOffice Documentation Coordinator
Comunidade LibreOffice 
Rio de Janeiro - Brasil - Local Time: UTC-03:00
http://tdf.io/joinus 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: chart2/qa

[Libreoffice Gerrit user]

 chart2/qa/extras/PivotChartTest.cxx|9 ++---
 chart2/qa/extras/chart2dump/chart2dump.cxx |4 +---
 chart2/qa/extras/chart2export.cxx  |7 +++
 chart2/qa/extras/chart2import.cxx  |7 +++
 chart2/qa/extras/charttest.hxx |   17 +
 chart2/qa/extras/xshape/chart2xshape.cxx   |7 ---
 chart2/qa/unit/chart2-dialogs-test.cxx |3 ---
 7 files changed, 14 insertions(+), 40 deletions(-)

New commits:
commit 267164a8cf6c9acfb6055ec6516058bc5487b474
Author: Gabor Kelemen 
AuthorDate: Sat Jan 5 11:00:28 2019 +0100
Commit: Miklos Vajna 
CommitDate: Mon Jan 14 12:15:57 2019 +0100

tdf#42949 Fix IWYU warnings in chart2/qa/*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4fa8e6e7dad8b87d8e31140de35fa948f631bee9
Reviewed-on: https://gerrit.libreoffice.org/65888
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/chart2/qa/extras/PivotChartTest.cxx 
b/chart2/qa/extras/PivotChartTest.cxx
index 40ba87e4cbe6..086c4e91bcdb 100644
--- a/chart2/qa/extras/PivotChartTest.cxx
+++ b/chart2/qa/extras/PivotChartTest.cxx
@@ -19,22 +19,17 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
 #include 
 #include 
 
-#include 
-
-#include 
+namespace com { namespace sun { namespace star { namespace table { class 
XCellRange; } } } }
+namespace com { namespace sun { namespace star { namespace util { class 
XNumberFormats; } } } }
 
 class PivotChartTest : public ChartTest
 {
diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx 
b/chart2/qa/extras/chart2dump/chart2dump.cxx
index 001382bbfe39..030fb92e9918 100644
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -10,17 +10,15 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index 5bf1e730f93c..3f34f5e7598e 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -13,20 +13,19 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 #include 
+#include 
 
 #include 
-#include 
 
 #include 
-#include 
 
 #include 
 
diff --git a/chart2/qa/extras/chart2import.cxx 
b/chart2/qa/extras/chart2import.cxx
index 5d8b43e739a6..f4f87734f27c 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -8,24 +8,23 @@
  */
 
 #include "charttest.hxx"
-#include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx
index 84cea90845c3..a2b8efd2c427 100644
--- a/chart2/qa/extras/charttest.hxx
+++ b/chart2/qa/extras/charttest.hxx
@@ -19,25 +19,19 @@
 #include 
 
 #include 
-#include 
 #include 
 #include 
-#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
-#include 
 
 #include 
 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -47,11 +41,8 @@
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -62,9 +53,6 @@
 #include 
 #include 
 
-#include 
-#include 
-
 #include 
 #include 
 #include 
@@ -72,6 +60,11 @@
 using namespace css;
 using namespace css::uno;
 
+namespace com { namespace sun { namespace star { namespace chart2 { class 
XDataSeries; } } } }
+namespace com { namespace sun { namespace star { namespace chart2 { class 
XDiagram; } } } }
+namespace com { namespace sun { namespace star { namespace table { class 
XTableCharts; } } } }
+namespace com { namespace sun { namespace star { namespace table { class 
XTablePivotCharts; } } } }
+
 class ChartTest : public test::BootstrapFixture, public unotest::MacrosTest
 {
 public:
diff --git a/chart2/qa/extras/xshape/chart2xshape.cxx 
b/chart2/qa/extras/xshape/chart2xshape.cxx
index 19ed5bf40974..2906b078a798 100644
--- a/chart2/qa/extras/xshape/chart2xshape.cxx
+++ b/chart2/qa/extras/xshape/chart2xshape.cxx
@@ -8,14 +8,7 @@
  */
 
 #include 
-#include 
-#include 
-#include 
-#include 
 #include 
-#include 
-#include 
-#include 
 
 #include 
 
diff --git a/chart2/qa/unit/chart2-dialogs-test.cxx 
b/chart2/qa/unit/chart2-dialogs-test.cxx
index 88145f98e100..ef99582eb517 100644
--- a/chart2/qa/unit/chart2-dialogs-test.cxx
+++ b/chart2/qa/unit/chart2-dialogs-test.cxx
@@ -9,9 +9,6 @@
 
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
 
 using namespace ::com::sun::star;

[Libreoffice-bugs] [Bug 99530] DOCX without effects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99530

Buovjaga  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #12 from Buovjaga  ---
(In reply to Dennis Roczek from comment #11)
> Sadly my old remote windows server is not working at the moment.
> 
> At least what I can tell: when using mso2013 and mso2019: the "stars" are
> behind the image(s) - dunno if ms has changed some behavior (or file format)
> or if the file were changed before sent to buovjaga.
> 
> @buovjaga: could you ever confirm that? I believe to remember that I only
> checked libreoffice using that attached file, never used mso for that...

The file was not sent to me. It was in the URL field before:
https://bugs.documentfoundation.org/show_activity.cgi?id=99530

I did not check with MSO ever.

Good catch. The star shapes are behind the images in LibO as well. Looks like
we are bug-to-bug compatible. Let's close.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73398] Writer PRINT DIALOG: Clarify syntax for "Pages to print" field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=73398

Timur  changed:

   What|Removed |Added

Summary|PRINT DIALOG: Clarify   |Writer PRINT DIALOG:
   |syntax for "Pages to print" |Clarify syntax for "Pages
   |field and interpret space   |to print" field
   |as a list separator of  |
   |distinct pages to print |
 CC||olivier.hallot@documentfoun
   ||dation.org
 Status|REOPENED|NEW
  Component|Writer  |Documentation
URL||https://help.libreoffice.or
   ||g/6.2/en-US/text/shared/01/
   ||0113.html

--- Comment #18 from Timur  ---
(In reply to Dieter Praas from comment #14)
> I don't get those tooltips, although I have activated extended tooltips in
> Tools > Options > LibreOffice > General. What version you are using?
Tooltips are "Extended tips" and it should come from Offline help. 
But:
- help doesn't explain that:
https://help.libreoffice.org/6.2/en-US/text/shared/optionen/01010600.html?
- they don't work per Bug 120538.

If I understand this bug well, all works except it's not documented. 
If so, I'll convert to Documentation. 
Current help from 6.2 is
https://help.libreoffice.org/6.2/en-US/text/shared/01/0113.html
But it doesn't explain syntax. 
In "Printing text documents:" there should be a subtitle '"Pages to print" 
syntax'.

As for "1 3" I personally agree it could be "1,3" but someone will expect
"1-3". I guess no solution for all here. Anyway, let's start with documenting. 

Note: to complicate somewhat, new dialog in 6.3+ doesn't open correct Help:
I'll report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122702] Tall bar chart pushes together the X axis labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122702

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||filter:xls, regression

--- Comment #2 from raal  ---
I'll bisect it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122702] Tall bar chart pushes together the X axis labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122702

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
 CC||balazs.varga...@gmail.com

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Balazs Varga ; Could you possibly take a look at this one?
Thanks

74c7873c04833c943321f335ee67226fae5e826c is the first bad commit
commit 74c7873c04833c943321f335ee67226fae5e826c
Author: Jenkins Build User 
Date:   Tue Dec 18 15:31:21 2018 +0100

source sha:f8d6de19181d749d7c2b345ce7084c0c07fa3eab

author  Balazs Varga 2018-12-14 14:38:49
+0100
committer   Bartosz Kosiorek 2018-12-18
11:04:40 +0100
commit  f8d6de19181d749d7c2b345ce7084c0c07fa3eab (patch)
tree3e3ce690b0ddffc46f2372f91542982130dd06e9
parent  574678cf92d50abf456ebbb56b9ea6cc5ca5ecf6 (diff)
tdf#108021 Chart: Fix text break of column chart X axis

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122702] Tall bar chart pushes together the X axis labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122702

--- Comment #4 from Balázs Varga  ---
(In reply to raal from comment #3)
> This seems to have begun at the below commit.
> Adding Cc: to Balazs Varga ; Could you possibly take a look at this one?
> Thanks

Of course, sorry for that.

I already work on the second part of tdf#108021 bug.
(https://gerrit.libreoffice.org/#/c/65937/) But unfortunately, even with this
patch, it is far from the good working. Until, I figure out how can I solve
this tdf#108021 bug better (without causing any regression), I will revert that
patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122071] Better support for time series diagram with trilean values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122071

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW

--- Comment #1 from Xisco Faulí  ---
Sound reasonable...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122709] New: In LibreOffice Writer (6.1.2 to 6.1.4, German) under Windows 10: Displayed window does not fit to mous coordinates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122709

Bug ID: 122709
   Summary: In LibreOffice Writer (6.1.2 to 6.1.4, German) under
Windows 10: Displayed window does not fit to mous
coordinates
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gross_at...@posteo.de

Description:
Since I installed LibreOffice 6.1.2 the displayed window does not fit to what
usually is displayed. For example: The bottom status line is shown 50 percent
only, the status bar to the left is missing completely.
Additionally it's pretty difficult to really hit the menu buttons due to
misleading mouse coordinates. E.g.: When I try to hit the "Safe" icon (third
from the left in default) I've to click somewhere below and to the right
relatively to icon position. I'm pretty sure this has not been the case under
Windows 7, but I had to upgrade and to re-install the 6.1.x LibreOffice. That's
when the bug first occured.
I've made a screenshot (and blurred my text 'cause it's not necessary to
describe the bug): https://www.magentacloud.de/share/2qjoou80gi

Steps to Reproduce:
1. Simply open LibreOffice Writer, there's no second step
2.
3.

Actual Results:
There's nothing more to happen, it's difficult to interact with the mouse
within the LibreOffice Writer screen. Some icons and functionality even is not
reachable due to this bug.

Expected Results:
What should happen: That the "inner" metrics of the screen fit to the window so
that all which should be shown within the window is actually shown within the
window (size) ;)


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
It's not possible to reach the "Help - About LibreOffice" information,
otherwise I'd have pasted it here. I've a Intel HD Graphics 520, OpenGL 4.4
enabled. I could not reset my UserProfile (can't find the menu icons to do so -
possibly due to the bug).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122659] FORMATTING: Outline numbering modification only keeps the last modified style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122659

--- Comment #3 from Oliver Brinzing  ---
(In reply to dubreucq from comment #2)
> That's it. Maybe this bug was corrected in 6.1.4.2 version.
> I've encountered the same problem on 2 different machines with LO 6.1.3.2
> (the other one is on Linux/Ubuntu too)

so can we close this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122007] Support for multiple selection of list entries in data series selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122007

Markus Elfring  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---

--- Comment #2 from Markus Elfring  ---
(In reply to Xisco Faulí from comment #1)
The topic “Chart: Impossible to choose non-contiguous range when editing data
range with use of the Expand button” is related a bit.
But I imagine that it could become easier to support the deletion of selected
entries from the data series list directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122700] Writer - Can't change shadow color on tab Borders in dialogue Character style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122700

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Durgapriyanka  ---
Thank you for reporting the bug.I can confirm this bug in

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121802] In the "Options", the function of changing the color of "vertical scroll" and "horizontal scroll" is added.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121802

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Xisco Faulí  ---
I'm not sure I'm undertanding correctly your suggestion. You would like to
change the scrolls' color from LibreOffice? I'm afraid that's not possible as
they are decorated by the OS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122011] Support for referring to tables from external files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122011

Markus Elfring  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|NOTABUG |---

--- Comment #2 from Markus Elfring  ---
(In reply to Xisco Faulí from comment #1)
I suggest to take another look for the direct support of external data by the
chart wizard.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121833] Low raster quality when using "compress" on SVG inside Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121833

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121832] editing PPT in Impress changes title field labels so titles are not shown in outline views

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121832

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
Bug 104520 depends on bug 99530, which changed state.

Bug 99530 Summary: DOCX without effects
https://bugs.documentfoundation.org/show_bug.cgi?id=99530

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122661] FORMS: Borders of form-controls set to 'FLAT' style are so narrow and light as to be all but lost to view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122661

Alex Thurgood  changed:

   What|Removed |Added

 OS|Linux (All) |All

--- Comment #4 from Alex Thurgood  ---
Not just Linux, I can reproduce this on macOS 10.14.2 with LO6202RC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116112] [META] Regressions introduced by alg_writerframes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116112
Bug 116112 depends on bug 116758, which changed state.

Bug 116758 Summary: background color of frame is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=116758

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122312] UI: Image quality drop down box is too narrow to fit its selection in HTML Export dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122312

BogdanB  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED
 CC||bogdan...@gmail.com

--- Comment #8 from BogdanB  ---
Solved.
Verified on
Version: 6.3.0.0.alpha0+
Build ID: afbbdcc216a84b59fb263777659b044c4a7cf6f0
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-01-13_03:54:12
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded

Solved also in
Version: 6.2.0.2
Build ID: 2ce5217b30a543f7666022df50f0562f82be0cff
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122704] Inner table border lines crossing the outer border depending on zoom level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122704

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm this bug and also I see the
lines thinning out where lines connect.

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121915] In the "Options", add "Contacts" to change the design.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121915

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Xisco Faulí  ---
Hello,
I'm having troubles to understand what is the request here.
Could you please try to elaborate it a bit more?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121631] Sorbian string is automatically converted into lower case

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121631

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Xisco Faulí  ---
Closing as RESOLVED WORKSFORME based on comment 1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121831] Low raster quality when saving SVG as PNG to DOC(X)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121831

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121851] Calc loses time zone information for datetime cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121851

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1781

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121808] LibreOfficeKit saveAs options fails for PDF export filter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121808

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121799] When calling LibreOffice in server mode to update the TOC of a large document, the page numbers in the TOC are wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121799

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121796] When calling LibreOffice in server mode via UNO, the produced ODT document may have, in meta.xml, a meta:page-count="1" for a document containing 2 pages.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121796

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122656] UI: Items are skipped when moving through the Fontwork Gallery with arrow keys

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122656

--- Comment #3 from Telesto  ---
@Caolán 
Not sure if you're interested, but there is another small bug related to the
Fontwork Dialog (bug 35152):
1. Open FontWork dialog
2. Press Enter -> No Fontwork applied

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122707] New: Writer: Print (selected) pages harder to use in new printer dialog in 6.3+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122707

Bug ID: 122707
   Summary: Writer: Print (selected) pages harder to use in new
printer dialog in 6.3+
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gti...@gmail.com
CC: libreoffice-ux-adv...@lists.freedesktop.org
Blocks: 103309

Created attachment 148308
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148308=edit
Ranges and Copies - compare LO 6.2 6.3+.jpg

Writer has new printer dialog from 6.3+.
Print (selected) pages is harder to use in new printer dialog in 6.3+
Previously, "Pages" to select was visible, although one had to select first to
write pages. 
Now, "Print pages" is not visible, which I find a step backwards.

Since there seems to be enough space, I don't know why there's dropdown for: 
Print all pages,
Print pages,
Print even pages,
Print odd pages.
IMHO, radio would be better. 

Also, click on pages number field should select "Print pages" option, so that
we save a click.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103309
[Bug 103309] [META] Print dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103309

Timur  changed:

   What|Removed |Added

 Depends on||122707


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122707
[Bug 122707] Writer: Print (selected) pages harder to use in new printer dialog
in 6.3+
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 122707] New: Writer: Print (selected) pages harder to use in new printer dialog in 6.3+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122707

Bug ID: 122707
   Summary: Writer: Print (selected) pages harder to use in new
printer dialog in 6.3+
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: gti...@gmail.com
CC: libreoffice-ux-advise@lists.freedesktop.org
Blocks: 103309

Created attachment 148308
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148308=edit
Ranges and Copies - compare LO 6.2 6.3+.jpg

Writer has new printer dialog from 6.3+.
Print (selected) pages is harder to use in new printer dialog in 6.3+
Previously, "Pages" to select was visible, although one had to select first to
write pages. 
Now, "Print pages" is not visible, which I find a step backwards.

Since there seems to be enough space, I don't know why there's dropdown for: 
Print all pages,
Print pages,
Print even pages,
Print odd pages.
IMHO, radio would be better. 

Also, click on pages number field should select "Print pages" option, so that
we save a click.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103309
[Bug 103309] [META] Print dialog bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 122662] Menubar in opened forms is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122662

--- Comment #5 from Robert Großkopf  ---
(In reply to Alex Thurgood from comment #2)
> 
> @Robert : if you start LO with the GEN vcl plugin instead of the default for
> your desktop manager, does the main menu re-appear ?

How could I execute this? Have had a look at start-parameters didn't find any
parameter for VCL.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
Bug 103341 depends on bug 122627, which changed state.

Bug 122627 Summary: 'URL Recognition' in Options tab of AutoCorrect Options 
dialog is broken (gen/gtk2)
https://bugs.documentfoundation.org/show_bug.cgi?id=122627

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122661] FORMS: Borders of form-controls set to 'FLAT' style are so narrow and light as to be all but lost to view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122661

Alex Thurgood  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116758] background color of frame is missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116758

Justin L  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

--- Comment #4 from Justin L  ---
Definitely not a duplicate. This is importing problems and bug 85283 is about
.doc importing, while this one is about ODT importing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53300] Chart: Impossible to choose non-contiguous range when, editing data range with use of the Expand button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53300

Xisco Faulí  changed:

   What|Removed |Added

 CC||markus.elfr...@web.de

--- Comment #31 from Xisco Faulí  ---
*** Bug 122012 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122012] Extended graphical user interface for the specification of several cell areas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122012

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Thanks for reporting this issue. It seems like a dupe of bug 53300

*** This bug has been marked as a duplicate of bug 53300 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119989] Crash in: SwIndex::SwIndex(SwIndexReg * const, long)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119989

--- Comment #13 from Nick Beneker  ---
I do not seem to be able to reproduce it.  I have not seen a recurrence of the
issue in over a month. So I think it is safe to close. 

Thank you for addressing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122696] Page settings missing a few paper sizes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122696

Adolfo Jayme  changed:

   What|Removed |Added

Summary|Improvement for "page"  |Page settings missing a few
   |configuration   |paper sizes
Version|6.2.0.2 rc  |Inherited From OOo
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122710] New: PRINT DIALOG: For "Pages to print" field interpret space as separator for a list of distinct pages to print

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122710

Bug ID: 122710
   Summary: PRINT DIALOG: For "Pages to print" field interpret
space as separator for a list of distinct pages to
print
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ulf.zi...@gmx.de

Description:
Unexpected huge amount of printed pages.

Steps to Reproduce:
1. Open Print dialogue.
2. Enter a couple of numbers in the "Pages to print" field, separated by space
character.
3. Start print.

Actual Results:
All pages from the smallest to the biggest number are printed.
A space character in the "Pages to print" field is interpreted as "form .. to".
This is not intuitive, and wastes a lot of paper.

Expected Results:
Only the entered pages should be printed.
A space character should be interpreted as separator for a list of distinct
pages to print.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121947] [NEWHELP] Add a scroll to top icon for long pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121947

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Moving to NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121873] Menue is missing on Samsung Book tablet PC on WIndows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121873

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug.
Could you please try to reproduce it with a master build from
http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the master build

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs