[Libreoffice-bugs] [Bug 124677] New: [META] Regressions from bug 114306
https://bugs.documentfoundation.org/show_bug.cgi?id=124677 Bug ID: 124677 Summary: [META] Regressions from bug 114306 Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Metabugs for tracking all regressions created by bug 114306 Commits: http://cgit.freedesktop.org/libreoffice/core/commit/?id=18765b9fa739337d2d891513f6e2fb7c3ce23b50 http://cgit.freedesktop.org/libreoffice/core/commit/?id=e4400f4c4e267f8528df3a7d5a09623c888bd10c http://cgit.freedesktop.org/libreoffice/core/commit/?id=d30eefb677b446886f7b5bab6de93d489ba63529 The problem commits have been reverted in branch 6.1 before its last minor release -> https://git.libreoffice.org/core/+/f15146021b722dda0cf10cb08de6e0a3c525168a%5E%21 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124676] FILESAVE: xlsx document with pivot table exported by Calc results in recovery dialog when opened in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=124676 Dennis Francis changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |dennisfrancis...@gmail.com |desktop.org | CC||dennisfrancis...@gmail.com --- Comment #1 from Dennis Francis --- Created attachment 150686 --> https://bugs.documentfoundation.org/attachment.cgi?id=150686=edit ods file for reproduction of the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124676] New: FILESAVE: xlsx document with pivot table exported by Calc results in recovery dialog when opened in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=124676 Bug ID: 124676 Summary: FILESAVE: xlsx document with pivot table exported by Calc results in recovery dialog when opened in Excel Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dennisfrancis...@gmail.com Description: xlsx file created by Calc, when opened in Excel 2016 results in recovery dialog and recovery of the document results in removal of the pivot table. Steps to Reproduce: 1. Open the attached ods file in Calc 2. "Save as" in the xlsx format. 3. Open the xlsx file in Excel. Actual Results: A recovery dialog pops up. If you choose to click "Yes" then it will further say that pivot-table related content was removed from the document. In the second sheet you will see the pivot table's contents but it is now no more a "real" pivot table. Expected Results: Excel opens the file without any recovery process and the pivot table is correctly preserved in the second sheet. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 6.3.0.0.alpha0+ Build ID: 2bad874634e45a4457d8c91e7b87554319cc7fd3 CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; Locale: en-US (en_US.utf8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 --- Comment #6 from Alex Thurgood --- I would add that LO6222 is not the default distro-provided version for LM19.1, so either you are using a snap, or else you have downloaded and installed a PPA, or you have obtained that LO version from somewhere else. Please specify. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124675] CRASH: after moving the content down and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=124675 --- Comment #2 from Xisco Faulí --- Steps to reproduce: 1. Open attachment 129209 from bug 87764 2. Hold the return key for a few seconds until it reaches half of second page 3. Hold Ctrl + Z -> Crash! Reproduced in Version: 6.3.0.0.alpha0+ Build ID: 040a54d89e8ca33171e86647ced8dc58efd85fbe CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded but not in Version: 6.3.0.0.alpha0+ Build ID: d31d77b7199ecc9a7edc899d9703e9da52d5cbd1 CPU threads: 1; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-04-01_00:04:09 Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded thus, only Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 Alex Thurgood changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #5 from Alex Thurgood --- @Mike : sorry, but we need more information than just screenshots. 1) Which kind of database are you attempting to create ? 2) From the trace, it appears that you tried to create an embedded Firebird ODB file, but can you please set out the steps you carried out to try and create this file ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124675] CRASH: after moving the content down and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=124675 Xisco Faulí changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||4306 Version|6.3.0.0.alpha0+ Master |6.1.0.0.alpha1+ CC||manfred.bl...@cib.de, ||michael.st...@cib.de, ||t...@libreoffice.org, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Regression introduced by: author Manfred Blume 2017-12-08 15:01:51 +0100 committer Thorsten Behrens 2017-12-22 00:20:40 +0100 commit 18765b9fa739337d2d891513f6e2fb7c3ce23b50 (patch) tree61acc1c9001d529d0df88affe48310187784cc99 parent baaf6c12c8e9f785dc91e5d3db8b2f5072d4e3f5 (diff) tdf#114306 fix unexpected page break in row-spanned table Bisected with: bibisect-linux64-6.1 Adding Cc: to Manfred Blume -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124675] New: CRASH: after moving the content down and undoing
https://bugs.documentfoundation.org/show_bug.cgi?id=124675 Bug ID: 124675 Summary: CRASH: after moving the content down and undoing Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Steps to reproduce: 1. Open attachment 129210 from bug 87764 2. Hold the return key for a few seconds until it reaches half of second page 3. Hold Ctrl + Z -> Crash! Reproduced in Version: 6.3.0.0.alpha0+ Build ID: 040a54d89e8ca33171e86647ced8dc58efd85fbe CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded but not in Version: 6.3.0.0.alpha0+ Build ID: d31d77b7199ecc9a7edc899d9703e9da52d5cbd1 CPU threads: 1; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-04-01_00:04:09 Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Make API versioning compiler evaluable
On 11.04.19 09:32, Jan-Marek Glogowski wrote: * Has UDK an independent versioning, or is it also the Office version? it used to have independent versioning in OOo days, although looking at @since tags in include/rtl that is evidently replaced by LO versioning now. More comments? i'm not sure if it is worth the effort - we generally discourage C++ extensions anyway since Java or Python extensions have a lot less pitfalls; Java doesn't have a preprocessor, and so the way to build against an old API is to just put a corresonding old jar on the classpath; Python doesn't even have static typing so it's not applicable. also, if you look at the URE headers, almost any new addition in the last years is behind #ifdef LIBO_INTERNAL_ONLY anyway. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 Mike Sapsard changed: What|Removed |Added Status|NEEDINFO|REOPENED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 --- Comment #4 from Mike Sapsard --- Created attachment 150685 --> https://bugs.documentfoundation.org/attachment.cgi?id=150685=edit 3rd Dialog After this dialog, it cycles back to first dialog. This does not happen in Windows 10. It only happens in Linux Mint 19.1. I have looked at permissions, but can find no obvious problems. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 --- Comment #3 from Mike Sapsard --- Created attachment 150684 --> https://bugs.documentfoundation.org/attachment.cgi?id=150684=edit 2nd Dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 --- Comment #2 from Mike Sapsard --- Created attachment 150683 --> https://bugs.documentfoundation.org/attachment.cgi?id=150683=edit Dialog that opens after saving new database. Dialog that opens after saving new database. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124674] writer -> menubar -> TableNumberRecognition
https://bugs.documentfoundation.org/show_bug.cgi?id=124674 andreas_k changed: What|Removed |Added Keywords||needsUXEval CC||kain...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124674] New: writer -> menubar -> TableNumberRecognition
https://bugs.documentfoundation.org/show_bug.cgi?id=124674 Bug ID: 124674 Summary: writer -> menubar -> TableNumberRecognition Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com what's the reason TableNumberRecognition is one of the only item in writer -> menubar -> table -> which is activated when no table is selected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124673] why toggle function DrawText, HyperlinkDialog and Horizontal Line
https://bugs.documentfoundation.org/show_bug.cgi?id=124673 andreas_k changed: What|Removed |Added Keywords||needsUXEval CC||kain...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124673] New: why toggle function DrawText, HyperlinkDialog and Horizontal Line
https://bugs.documentfoundation.org/show_bug.cgi?id=124673 Bug ID: 124673 Summary: why toggle function DrawText, HyperlinkDialog and Horizontal Line Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com open writer -> menubar -> insert there are 3 toggle functions - DrawText - HyperlinkDialog - Horizontal Line why are this 3 items toglle functions with an checkbox, cause nothing happen when DrawText is checked. Same for the other two functions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124671] Impress does not render UI elements or slideshow animations until mouse move over them
https://bugs.documentfoundation.org/show_bug.cgi?id=124671 --- Comment #3 from Babak Razmjoo --- Created attachment 150682 --> https://bugs.documentfoundation.org/attachment.cgi?id=150682=edit I can see this effect when click a menu item and scroll through menus by arrow keys -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124672] Hi-Contrast mode not correctly applied to menus and icons
https://bugs.documentfoundation.org/show_bug.cgi?id=124672 --- Comment #1 from Heiko Tietze --- Created attachment 150681 --> https://bugs.documentfoundation.org/attachment.cgi?id=150681=edit Screenshot 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124672] New: Hi-Contrast mode not correctly applied to menus and icons
https://bugs.documentfoundation.org/show_bug.cgi?id=124672 Bug ID: 124672 Summary: Hi-Contrast mode not correctly applied to menus and icons Product: LibreOffice Version: 6.2.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Keywords: accessibility Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tietze.he...@gmail.com CC: caol...@redhat.com, catbil...@gmail.com, vstuart.fo...@utsa.edu Created attachment 150680 --> https://bugs.documentfoundation.org/attachment.cgi?id=150680=edit Screenshot 1 Started Windows 10 in a VM, switched to the high contrast mode and started LibreOffice. The menu items have gray font color on a gray canvas and the sidebar has a dark background (unlike the toolbars) with Sifr dark icons. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
New commits:
commit cafed2e65e86d813822d2c650fa057f1a1f81c06
Author: Patrick Jaap
AuthorDate: Wed Apr 3 14:58:05 2019 +0200
Commit: Miklos Vajna
CommitDate: Thu Apr 11 10:15:29 2019 +0200
Fix in convertToOOXMLHoriOrient: values of VertOrient were taken
Change-Id: I47093292aeed5c0579dd4b365561ee86935632e4
Reviewed-on: https://gerrit.libreoffice.org/70197
Tested-by: Jenkins
Reviewed-by: Julien Nabet
(cherry picked from commit 2111f607973166ebc39414ba6d2019832bcfe4da)
Reviewed-on: https://gerrit.libreoffice.org/70513
Reviewed-by: Miklos Vajna
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 7d6a618b554f..aab60d8cec1c 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -512,24 +512,21 @@ static OString convertToOOXMLVertOrient(sal_Int16 nOrient)
}
}
-static OString convertToOOXMLHoriOrient(sal_Int16 nOrient)
+static OString convertToOOXMLHoriOrient(sal_Int16 nOrient, bool bIsPosToggle)
{
switch( nOrient )
{
-case text::VertOrientation::NONE:
+case text::HoriOrientation::NONE:
return OString();
-case text::VertOrientation::CENTER:
-case text::VertOrientation::LINE_CENTER:
-return OString( "center" );
-case text::VertOrientation::BOTTOM:
-return OString( "bottom" );
-case text::VertOrientation::LINE_BOTTOM:
-return OString( "outside" );
-case text::VertOrientation::TOP:
-return OString( "top" );
-case text::VertOrientation::LINE_TOP:
+case text::HoriOrientation::LEFT:
+return OString( bIsPosToggle ? "inside" : "left" );
+case text::HoriOrientation::RIGHT:
+return OString( bIsPosToggle ? "outside" : "right" );
+case text::HoriOrientation::CENTER:
+// fall-through indended
+case text::HoriOrientation::FULL:
default:
-return OString( "inside" );
+return OString( "center" );
}
}
@@ -8407,7 +8404,7 @@ void DocxAttributeOutput::FormatVertOrientation( const
SwFormatVertOrient& rFlyV
void DocxAttributeOutput::FormatHorizOrientation( const SwFormatHoriOrient&
rFlyHori )
{
-OString sAlign = convertToOOXMLHoriOrient( rFlyHori.GetHoriOrient() );
+OString sAlign = convertToOOXMLHoriOrient( rFlyHori.GetHoriOrient(),
rFlyHori.IsPosToggle() );
OString sHAnchor = convertToOOXMLHoriOrientRel(
rFlyHori.GetRelationOrient() );
if (m_rExport.SdrExporter().getTextFrameSyntax())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124665] writer -> menubar -> Edit -> .uno:ShadowCursor isn't related to select subgroup
https://bugs.documentfoundation.org/show_bug.cgi?id=124665 --- Comment #2 from andreas_k --- that could work well, yes and we don't have to update help. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124665] writer -> menubar -> Edit -> .uno:ShadowCursor isn't related to select subgroup
https://bugs.documentfoundation.org/show_bug.cgi?id=124665 --- Comment #2 from andreas_k --- that could work well, yes and we don't have to update help. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124671] Impress does not render UI elements or slideshow animations until mouse move over them
https://bugs.documentfoundation.org/show_bug.cgi?id=124671 --- Comment #2 from Babak Razmjoo --- Created attachment 150679 --> https://bugs.documentfoundation.org/attachment.cgi?id=150679=edit Most of the times, openning a dialog results in this -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124671] Impress does not render UI elements or slideshow animations until mouse move over them
https://bugs.documentfoundation.org/show_bug.cgi?id=124671 --- Comment #1 from Babak Razmjoo --- Created attachment 150678 --> https://bugs.documentfoundation.org/attachment.cgi?id=150678=edit Opening a menu will result in this situation until mouse move over it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124671] New: Impress does not render UI elements or slideshow animations until mouse move over them
https://bugs.documentfoundation.org/show_bug.cgi?id=124671 Bug ID: 124671 Summary: Impress does not render UI elements or slideshow animations until mouse move over them Product: LibreOffice Version: 6.1.5.2 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b.razm...@protonmail.com Created attachment 150677 --> https://bugs.documentfoundation.org/attachment.cgi?id=150677=edit The presentation causing this problem I have these problems with a particular presentation. When this file is opened in Impress, Impress won't render its UI elements (menus and dialogues) until I move mouse pointer over them. Without mouse movement I can only see transparent or black boxes. Also when starting slide show for this presentation, only a black screen is visible and I have to move the mouse to see slides and their animations (The animation currently works by mouse movement, while it must run independently) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Bug 93529 depends on bug 122767, which changed state. Bug 122767 Summary: Artifacts from comment popup with OpenGL enabled https://bugs.documentfoundation.org/show_bug.cgi?id=122767 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Bug 101216 depends on bug 122767, which changed state. Bug 122767 Summary: Artifacts from comment popup with OpenGL enabled https://bugs.documentfoundation.org/show_bug.cgi?id=122767 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124642] remove formular toolbar from writer -> view -> toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=124642 Xisco Faulí changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||xiscofa...@libreoffice.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124663] Crash in: com::sun::star::uno::WeakReferenceHelper::get
https://bugs.documentfoundation.org/show_bug.cgi?id=124663 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124642] remove formular toolbar from writer -> view -> toolbars
https://bugs.documentfoundation.org/show_bug.cgi?id=124642 Xisco Faulí changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/notemark.cxx | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
New commits:
commit 37aa4f0d64e276c46821ef6122483fb6b4c04781
Author: Miklos Vajna
AuthorDate: Thu Apr 11 09:13:59 2019 +0200
Commit: Miklos Vajna
CommitDate: Thu Apr 11 10:03:22 2019 +0200
tdf#122767 sc opengl: fix rendering artifacts after hiding a cell comment
Actually this is not specific to opengl, affects e.g. the Linux gen
backend as well, it just doesn't happen with the Windows gdi backend.
The rendering of the caption itself was OK. Focusing on the arrow
polygon at the end of the comment's "tail" (connector polyline):
- What gets painted is determined by SdrCaptionObj ->
ViewContactOfSdrCaptionObj::createViewIndependentPrimitive2DSequence(),
which produces a PolyPolygonColorPrimitive2D, which is then processed by
VclPixelProcessor2D::tryDrawPolyPolygonColorPrimitive2DDirect().
- The polygon passed to VCL there is within the bounds of the
invalidation rectangle set in ScNoteMarker::TimeHdl().
So it seems the only reason sometimes these 1px rendering artifacts are
left around is anti-aliasing. Fix those by simply extending the
invalidation rectangle in each direction.
Change-Id: I37b8e666999d3ff5ee1328fca7ac017ee8c7e9e0
Reviewed-on: https://gerrit.libreoffice.org/70584
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sc/source/ui/view/notemark.cxx b/sc/source/ui/view/notemark.cxx
index 0868f557cfb5..642bf405a2e8 100644
--- a/sc/source/ui/view/notemark.cxx
+++ b/sc/source/ui/view/notemark.cxx
@@ -170,21 +170,30 @@ void ScNoteMarker::InvalidateWin()
{
if (m_bVisible)
{
-m_pWindow->Invalidate( OutputDevice::LogicToLogic(m_aRect, m_aMapMode,
m_pWindow->GetMapMode()) );
+// Extend the invalidated rectangle by 1 pixel in each direction in
case AA would slightly
+// paint outside the nominal area.
+tools::Rectangle aRect(m_aRect);
+const Size aPixelSize = m_pWindow->PixelToLogic(Size(1, 1));
+aRect.AdjustLeft(-aPixelSize.getWidth());
+aRect.AdjustTop(-aPixelSize.getHeight());
+aRect.AdjustRight(aPixelSize.getWidth());
+aRect.AdjustBottom(aPixelSize.getHeight());
+
+m_pWindow->Invalidate( OutputDevice::LogicToLogic(aRect, m_aMapMode,
m_pWindow->GetMapMode()) );
if ( m_pRightWin || m_pBottomWin )
{
Size aWinSize = m_pWindow->PixelToLogic(
m_pWindow->GetOutputSizePixel(), m_aMapMode );
if ( m_pRightWin )
-m_pRightWin->Invalidate( OutputDevice::LogicToLogic(m_aRect,
+m_pRightWin->Invalidate( OutputDevice::LogicToLogic(aRect,
lcl_MoveMapMode( m_aMapMode, Size(
aWinSize.Width(), 0 ) ),
m_pRightWin->GetMapMode()) );
if ( m_pBottomWin )
-m_pBottomWin->Invalidate( OutputDevice::LogicToLogic(m_aRect,
+m_pBottomWin->Invalidate( OutputDevice::LogicToLogic(aRect,
lcl_MoveMapMode( m_aMapMode, Size( 0,
aWinSize.Height() ) ),
m_pBottomWin->GetMapMode()) );
if ( m_pDiagWin )
-m_pDiagWin->Invalidate( OutputDevice::LogicToLogic(m_aRect,
+m_pDiagWin->Invalidate( OutputDevice::LogicToLogic(aRect,
lcl_MoveMapMode( m_aMapMode, aWinSize
),
m_pDiagWin->GetMapMode()) );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Faulty handle position in shapes imported from MS Office
Hi Regina, On Wed, Apr 10, 2019 at 02:41:17PM +0200, Regina Henschel wrote: > The needed calculation depends on the shape type, the handle and the > parameter ( X, Y, Radius, Angle) of the handle. Different handles of a shape > can need different calculations. On the other hand, different shapes can use > the same calculation for their handles, e.g all those, which are correct > with the current implementation. I might be wrong, but I would expect that the evaluation of the formulas don't depend on the shape type. If it does, it feels we don't understand the general rule, so we work the problem around with evaluating a formula in different ways for different shape types. > Would that be OK? If yes, which are suitable C++ tools to do that and where > should the parts be placed? Sure, if special-casing on the shape type improves the situation, then it's better than nothing. I would keep it simple: just create an enum with the different cases, and then you can have a switch to handle each. If the function gets large, extract the handling of complicated cases to their own functions. Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/vcl sc/source sc/uiconfig solenv/sanitizers vcl/source vcl/unx
include/vcl/weld.hxx |1
sc/source/ui/inc/namedlg.hxx | 76 +++---
sc/source/ui/inc/namemgrtable.hxx | 13 -
sc/source/ui/inc/reffact.hxx | 13 +
sc/source/ui/inc/tabvwsh.hxx |1
sc/source/ui/namedlg/namedlg.cxx | 345 ++
sc/source/ui/namedlg/namemgrtable.cxx | 38 +++
sc/source/ui/view/reffact.cxx | 28 ++
sc/source/ui/view/tabvwshc.cxx| 112 +++--
sc/uiconfig/scalc/ui/managenamesdialog.ui | 91 ++-
solenv/sanitizers/ui/modules/scalc.suppr |1
vcl/source/app/salvtables.cxx |8
vcl/unx/gtk3/gtk3gtkinst.cxx | 19 +
13 files changed, 441 insertions(+), 305 deletions(-)
New commits:
commit 565a254a814a06086ac067d5c64b4557e73c9666
Author: Caolán McNamara
AuthorDate: Wed Apr 10 15:50:49 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:58:26 2019 +0200
weld ScNameDlg
Change-Id: I7a00dd386a1cb52e046d0f57c77fe3fdf8252bb7
Reviewed-on: https://gerrit.libreoffice.org/70548
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 2a7511b419fc..4074df14b8c7 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1435,6 +1435,7 @@ public:
virtual void set_label(const OUString& rText) = 0;
virtual OUString get_label() const = 0;
virtual void set_mnemonic_widget(Widget* pTarget) = 0;
+virtual void set_error(bool bShowError) = 0;
};
class VCL_DLLPUBLIC TextView : virtual public Container
diff --git a/sc/source/ui/inc/namedlg.hxx b/sc/source/ui/inc/namedlg.hxx
index cf8192ba4196..2034cd26e918 100644
--- a/sc/source/ui/inc/namedlg.hxx
+++ b/sc/source/ui/inc/namedlg.hxx
@@ -33,28 +33,9 @@ class ScViewData;
class ScDocument;
//logic behind the manage names dialog
-class ScNameDlg : public ScAnyRefDlg, public ScRangeManagerTable::InitListener
+class ScNameDlg : public ScAnyRefDlgController
{
private:
-VclPtr m_pEdName;
-VclPtr m_pEdAssign;
-VclPtr m_pRbAssign;
-VclPtrm_pLbScope;
-
-VclPtr m_pBtnPrintArea;
-VclPtr m_pBtnColHeader;
-VclPtr m_pBtnCriteria;
-VclPtr m_pBtnRowHeader;
-
-VclPtr m_pBtnAdd;
-VclPtr m_pBtnDelete;
-VclPtr m_pBtnOk;
-VclPtr m_pBtnCancel;
-
-VclPtr m_pFtInfo;
-
-VclPtr m_pRangeManagerTable;
-
const OUString maGlobalNameStr;
const OUString maErrInvalidNameStr;
const OUString maErrNameInUse;
@@ -74,6 +55,28 @@ private:
RangeNameContainer m_RangeMap;
+std::unique_ptr m_xEdName;
+std::unique_ptr m_xFtAssign;
+std::unique_ptr m_xEdAssign;
+std::unique_ptr m_xRbAssign;
+std::unique_ptr m_xLbScope;
+
+std::unique_ptr m_xBtnPrintArea;
+std::unique_ptr m_xBtnColHeader;
+std::unique_ptr m_xBtnCriteria;
+std::unique_ptr m_xBtnRowHeader;
+
+std::unique_ptr m_xBtnAdd;
+std::unique_ptr m_xBtnDelete;
+std::unique_ptr m_xBtnOk;
+std::unique_ptr m_xBtnCancel;
+
+std::unique_ptr m_xFtInfo;
+
+std::unique_ptr m_xExpander;
+
+std::unique_ptr m_xRangeManagerTable;
+
private:
void Init();
void UpdateChecks(const ScRangeData* pData);
@@ -87,41 +90,38 @@ private:
void AddPushed();
void RemovePushed();
-void CancelPushed();
void ScopeChanged();
void NameModified();
void SelectionChanged();
// Handler:
-DECL_LINK( OkBtnHdl, Button*, void );
-DECL_LINK( CancelBtnHdl, Button*, void );
-DECL_LINK( AddBtnHdl, Button*, void );
-DECL_LINK( RemoveBtnHdl, Button*, void );
-DECL_LINK( EdModifyHdl, Edit&, void );
-DECL_LINK( EdModifyCheckBoxHdl, CheckBox&, void );
-DECL_LINK( AssignGetFocusHdl, Control&, void );
-DECL_LINK( SelectionChangedHdl_Impl, SvTreeListBox*, void );
-DECL_LINK( ScopeChangedHdl, ListBox&, void );
+DECL_LINK( OkBtnHdl, weld::Button&, void );
+DECL_LINK( CancelBtnHdl, weld::Button&, void );
+DECL_LINK( AddBtnHdl, weld::Button&, void );
+DECL_LINK( RemoveBtnHdl, weld::Button&, void );
+DECL_LINK( EdModifyHdl, weld::Entry&, void );
+DECL_LINK( RefEdModifyHdl, formula::WeldRefEdit&, void );
+DECL_LINK( EdModifyCheckBoxHdl, weld::ToggleButton&, void );
+DECL_LINK( AssignGetFocusHdl, formula::WeldRefEdit&, void );
+DECL_LINK( SelectionChangedHdl_Impl, weld::TreeView&, void );
+DECL_LINK( ScopeChangedHdl, weld::ComboBox&, void );
protected:
virtual voidRefInputDone( bool bForced = false ) override;
public:
-ScNameDlg( SfxBindings* pB, SfxChildWindow* pCW,
vcl::Window* pParent,
- ScViewData* ptrViewData,
- const ScAddress& aCursorPos,
- std::map>*
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx|6
sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx |2
sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx |2
sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx |2
sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx |6
sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx |2
sc/source/ui/StatisticsDialogs/MovingAverageDialog.cxx |2
sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx | 324
--
sc/source/ui/inc/AnalysisOfVarianceDialog.hxx |2
sc/source/ui/inc/ChiSquareTestDialog.hxx |2
sc/source/ui/inc/DescriptiveStatisticsDialog.hxx |2
sc/source/ui/inc/ExponentialSmoothingDialog.hxx|2
sc/source/ui/inc/FourierAnalysisDialog.hxx |2
sc/source/ui/inc/MatrixComparisonGenerator.hxx |2
sc/source/ui/inc/MovingAverageDialog.hxx |2
sc/source/ui/inc/StatisticsInputOutputDialog.hxx | 73 --
16 files changed, 43 insertions(+), 390 deletions(-)
New commits:
commit 92b25179973fce7cafa3364dc19693a5a22f4952
Author: Caolán McNamara
AuthorDate: Wed Apr 10 12:41:36 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:58:14 2019 +0200
rename ScStatisticsInputOutputDialogController back...
to...
ScStatisticsInputOutputDialog
Change-Id: I641798943c0b469572ebd971eb39250c41c5db20
Reviewed-on: https://gerrit.libreoffice.org/70547
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
index 0dc391a17e2f..0c4aaa7b3d70 100644
--- a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
@@ -67,10 +67,10 @@ OUString lclCreateMultiParameterFormula(
return aResult.makeStringAndClear();
}
-void lclMakeSubRangesList(ScRangeList& rRangeList, const ScRange& rInputRange,
ScStatisticsInputOutputDialogController::GroupedBy aGroupedBy)
+void lclMakeSubRangesList(ScRangeList& rRangeList, const ScRange& rInputRange,
ScStatisticsInputOutputDialog::GroupedBy aGroupedBy)
{
std::unique_ptr pIterator;
-if (aGroupedBy == ScStatisticsInputOutputDialogController::BY_COLUMN)
+if (aGroupedBy == ScStatisticsInputOutputDialog::BY_COLUMN)
pIterator.reset(new DataRangeByColumnIterator(rInputRange));
else
pIterator.reset(new DataRangeByRowIterator(rInputRange));
@@ -87,7 +87,7 @@ void lclMakeSubRangesList(ScRangeList& rRangeList, const
ScRange& rInputRange, S
ScAnalysisOfVarianceDialog::ScAnalysisOfVarianceDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
weld::Window* pParent, ScViewData* pViewData )
-: ScStatisticsInputOutputDialogController(
+: ScStatisticsInputOutputDialog(
pSfxBindings, pChildWindow, pParent, pViewData,
"modules/scalc/ui/analysisofvariancedialog.ui",
"AnalysisOfVarianceDialog")
diff --git a/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
b/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
index 96349ed6f955..0d5a4faabf98 100644
--- a/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
@@ -17,7 +17,7 @@
ScChiSquareTestDialog::ScChiSquareTestDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
weld::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsInputOutputDialogController(
+ScStatisticsInputOutputDialog(
pSfxBindings, pChildWindow, pParent, pViewData,
"modules/scalc/ui/chisquaretestdialog.ui", "ChiSquareTestDialog")
{
diff --git a/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
b/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
index aabb3ae06c88..99798b0c73d5 100644
--- a/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
@@ -49,7 +49,7 @@ static const StatisticCalculation lclCalcDefinitions[] =
ScDescriptiveStatisticsDialog::ScDescriptiveStatisticsDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
weld::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsInputOutputDialogController(
+ScStatisticsInputOutputDialog(
pSfxBindings, pChildWindow, pParent, pViewData,
"modules/scalc/ui/descriptivestatisticsdialog.ui",
"DescriptiveStatisticsDialog")
diff --git a/sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx
[Libreoffice-commits] core.git: sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx | 67 ++-
sc/source/ui/inc/FourierAnalysisDialog.hxx | 21 ++--
sc/source/ui/inc/reffact.hxx |2
sc/source/ui/view/tabvwshc.cxx | 11 +-
sc/uiconfig/scalc/ui/fourieranalysisdialog.ui| 14 ++-
solenv/sanitizers/ui/modules/scalc.suppr |2
6 files changed, 57 insertions(+), 60 deletions(-)
New commits:
commit 849f575abb2521aa3ca628346b5de7efd2bd2c17
Author: Caolán McNamara
AuthorDate: Wed Apr 10 12:31:14 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:57:14 2019 +0200
weld ScFourierAnalysisDialog
Change-Id: I87e28f62cf03f4a612def322fda5e03d702bec4c
Reviewed-on: https://gerrit.libreoffice.org/70543
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx
b/sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx
index 7ccabfcb0ed5..d41cb9b61674 100644
--- a/sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx
@@ -26,11 +26,11 @@
#include
ScFourierAnalysisDialog::ScFourierAnalysisDialog(SfxBindings* pSfxBindings,
- SfxChildWindow* pChildWindow,
vcl::Window* pParent,
- ScViewData* pViewData)
-: ScStatisticsInputOutputDialog(pSfxBindings, pChildWindow, pParent,
pViewData,
-"FourierAnalysisDialog",
-
"modules/scalc/ui/fourieranalysisdialog.ui")
+ SfxChildWindow* pChildWindow,
+ weld::Window* pParent,
ScViewData* pViewData)
+: ScStatisticsInputOutputDialogController(pSfxBindings, pChildWindow,
pParent, pViewData,
+
"modules/scalc/ui/fourieranalysisdialog.ui",
+ "FourierAnalysisDialog")
, maLabelAddr(ScAddress::INITIALIZE_INVALID)
, maActualInputRange(ScAddress::INITIALIZE_INVALID)
, mnLen(0)
@@ -40,32 +40,22 @@
ScFourierAnalysisDialog::ScFourierAnalysisDialog(SfxBindings* pSfxBindings,
, mbWithLabels(false)
, mbInverse(false)
, mbPolar(false)
+, mxWithLabelsCheckBox(m_xBuilder->weld_check_button("withlabels-check"))
+, mxInverseCheckBox(m_xBuilder->weld_check_button("inverse-check"))
+, mxPolarCheckBox(m_xBuilder->weld_check_button("polar-check"))
+, mxMinMagnitudeField(m_xBuilder->weld_spin_button("minmagnitude-spin"))
+, mxErrorMessage(m_xBuilder->weld_label("error-message"))
{
-SetText(ScResId(STR_FOURIER_ANALYSIS));
-get(mpWithLabelsCheckBox, "withlabels-check");
-get(mpInverseCheckBox, "inverse-check");
-get(mpPolarCheckBox, "polar-check");
-get(mpMinMagnitudeField, "minmagnitude-spin");
-get(mpErrorMessage, "error-message");
-
-mpWithLabelsCheckBox->SetToggleHdl(LINK(this, ScFourierAnalysisDialog,
CheckBoxHdl));
-}
-
-ScFourierAnalysisDialog::~ScFourierAnalysisDialog() { disposeOnce(); }
+m_xDialog->set_title(ScResId(STR_FOURIER_ANALYSIS));
-bool ScFourierAnalysisDialog::Close()
-{
-return DoClose(ScFourierAnalysisDialogWrapper::GetChildWindowId());
+mxWithLabelsCheckBox->connect_toggled(LINK(this, ScFourierAnalysisDialog,
CheckBoxHdl));
}
-void ScFourierAnalysisDialog::dispose()
+ScFourierAnalysisDialog::~ScFourierAnalysisDialog() {}
+
+void ScFourierAnalysisDialog::Close()
{
-mpWithLabelsCheckBox.disposeAndClear();
-mpInverseCheckBox.disposeAndClear();
-mpPolarCheckBox.disposeAndClear();
-mpMinMagnitudeField.disposeAndClear();
-mpErrorMessage.disposeAndClear();
-ScStatisticsInputOutputDialog::dispose();
+DoClose(ScFourierAnalysisDialogWrapper::GetChildWindowId());
}
const char* ScFourierAnalysisDialog::GetUndoNameId() { return
STR_FOURIER_ANALYSIS; }
@@ -120,20 +110,20 @@ bool ScFourierAnalysisDialog::InputRangesValid()
{
if (!mInputRange.IsValid())
{
-mpErrorMessage->SetText(ScResId(STR_MESSAGE_INVALID_INPUT_RANGE));
+mxErrorMessage->set_label(ScResId(STR_MESSAGE_INVALID_INPUT_RANGE));
return false;
}
if (!mOutputAddress.IsValid())
{
-mpErrorMessage->SetText(ScResId(STR_MESSAGE_INVALID_OUTPUT_ADDR));
+mxErrorMessage->set_label(ScResId(STR_MESSAGE_INVALID_OUTPUT_ADDR));
return false;
}
mInputRange.PutInOrder();
mbGroupedByColumn = mGroupedBy == BY_COLUMN;
-mbWithLabels = mpWithLabelsCheckBox->IsChecked();
+mbWithLabels = mxWithLabelsCheckBox->get_active();
mbUse3DAddresses = mInputRange.aStart.Tab() != mOutputAddress.Tab();
@@ -147,13 +137,13 @@ bool ScFourierAnalysisDialog::InputRangesValid()
{
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx |2
sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx |2
sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx | 76 ---
sc/source/ui/inc/CorrelationDialog.hxx |2
sc/source/ui/inc/CovarianceDialog.hxx|2
sc/source/ui/inc/MatrixComparisonGenerator.hxx | 22 ---
6 files changed, 9 insertions(+), 97 deletions(-)
New commits:
commit 725a5bc4729a8122f1c36ae49ad8d34b83983526
Author: Caolán McNamara
AuthorDate: Wed Apr 10 12:34:42 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:57:47 2019 +0200
rename ScMatrixComparisonGeneratorController back...
to... ScMatrixComparisonGenerator
Change-Id: Ib81e922455cebe7c57422aab10bc1b1d6cb325ef
Reviewed-on: https://gerrit.libreoffice.org/70545
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
b/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
index d1463f608b3d..6ac135d33b43 100644
--- a/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
@@ -16,7 +16,7 @@
ScCorrelationDialog::ScCorrelationDialog(
SfxBindings* pSfxBindings, SfxChildWindow*
pChildWindow,
weld::Window* pParent, ScViewData* pViewData ) :
-ScMatrixComparisonGeneratorController(
+ScMatrixComparisonGenerator(
pSfxBindings, pChildWindow, pParent, pViewData,
"modules/scalc/ui/correlationdialog.ui", "CorrelationDialog")
{}
diff --git a/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
b/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
index 522297cc731d..f447b89d0c93 100644
--- a/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
@@ -16,7 +16,7 @@
ScCovarianceDialog::ScCovarianceDialog(
SfxBindings* pSfxBindings, SfxChildWindow*
pChildWindow,
weld::Window* pParent, ScViewData* pViewData ) :
-ScMatrixComparisonGeneratorController(
+ScMatrixComparisonGenerator(
pSfxBindings, pChildWindow, pParent, pViewData,
"modules/scalc/ui/covariancedialog.ui", "CovarianceDialog")
{}
diff --git a/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
b/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
index 11146e438224..4ae4ef0e392d 100644
--- a/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
+++ b/sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx
@@ -39,7 +39,7 @@ namespace
}
}
-ScMatrixComparisonGeneratorController::ScMatrixComparisonGeneratorController(
+ScMatrixComparisonGenerator::ScMatrixComparisonGenerator(
SfxBindings* pSfxBindings, SfxChildWindow*
pChildWindow,
weld::Window* pParent, ScViewData*
pViewData,
const OUString& rUiXmlDescription,
@@ -47,15 +47,15 @@
ScMatrixComparisonGeneratorController::ScMatrixComparisonGeneratorController(
: ScStatisticsInputOutputDialogController(pSfxBindings, pChildWindow,
pParent, pViewData, rUiXmlDescription, rID)
{}
-ScMatrixComparisonGeneratorController::~ScMatrixComparisonGeneratorController()
+ScMatrixComparisonGenerator::~ScMatrixComparisonGenerator()
{}
-const char* ScMatrixComparisonGeneratorController::GetUndoNameId()
+const char* ScMatrixComparisonGenerator::GetUndoNameId()
{
return STR_CORRELATION_UNDO_NAME;
}
-ScRange ScMatrixComparisonGeneratorController::ApplyOutput(ScDocShell*
pDocShell)
+ScRange ScMatrixComparisonGenerator::ApplyOutput(ScDocShell* pDocShell)
{
AddressWalkerWriter output(mOutputAddress, pDocShell, mDocument,
formula::FormulaGrammar::mergeToGrammar(
formula::FormulaGrammar::GRAM_ENGLISH, mAddressDetails.eConv));
diff --git a/sc/source/ui/inc/CorrelationDialog.hxx
b/sc/source/ui/inc/CorrelationDialog.hxx
index 2a98da43881f..12db6f39df5b 100644
--- a/sc/source/ui/inc/CorrelationDialog.hxx
+++ b/sc/source/ui/inc/CorrelationDialog.hxx
@@ -13,7 +13,7 @@
#include "MatrixComparisonGenerator.hxx"
-class ScCorrelationDialog : public ScMatrixComparisonGeneratorController
+class ScCorrelationDialog : public ScMatrixComparisonGenerator
{
public:
ScCorrelationDialog(
diff --git a/sc/source/ui/inc/CovarianceDialog.hxx
b/sc/source/ui/inc/CovarianceDialog.hxx
index 99052c51b644..21acb96e4b75 100644
--- a/sc/source/ui/inc/CovarianceDialog.hxx
+++ b/sc/source/ui/inc/CovarianceDialog.hxx
@@ -13,7 +13,7 @@
#include "MatrixComparisonGenerator.hxx"
-class ScCovarianceDialog : public ScMatrixComparisonGeneratorController
+class ScCovarianceDialog : public ScMatrixComparisonGenerator
{
public:
ScCovarianceDialog(
diff --git
[Libreoffice-commits] core.git: 2 commits - sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx | 12
sc/source/ui/StatisticsDialogs/FTestDialog.cxx |2
sc/source/ui/StatisticsDialogs/RegressionDialog.cxx|2
sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx | 48 +--
sc/source/ui/StatisticsDialogs/TTestDialog.cxx |2
sc/source/ui/StatisticsDialogs/ZTestDialog.cxx |2
sc/source/ui/inc/ChiSquareTestDialog.hxx |6
sc/source/ui/inc/FTestDialog.hxx |2
sc/source/ui/inc/RegressionDialog.hxx |2
sc/source/ui/inc/StatisticsTwoVariableDialog.hxx |6
sc/source/ui/inc/TTestDialog.hxx |2
sc/source/ui/inc/ZTestDialog.hxx |2
sc/source/ui/inc/reffact.hxx |2
sc/source/ui/view/tabvwshc.cxx | 11
sc/uiconfig/scalc/ui/chisquaretestdialog.ui| 141
+-
solenv/sanitizers/ui/modules/scalc.suppr |2
16 files changed, 126 insertions(+), 118 deletions(-)
New commits:
commit 8d526da348107227bee3101ccc7aa9a2beb5dbd2
Author: Caolán McNamara
AuthorDate: Wed Apr 10 12:24:15 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:56:59 2019 +0200
weld ScChiSquareTestDialog
Change-Id: I652bf123bc9cba5edbb052bddd9be02640b3884c
Reviewed-on: https://gerrit.libreoffice.org/70542
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
b/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
index d6f729c086d4..96349ed6f955 100644
--- a/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
@@ -16,20 +16,20 @@
ScChiSquareTestDialog::ScChiSquareTestDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsInputOutputDialog(
+weld::Window* pParent, ScViewData* pViewData ) :
+ScStatisticsInputOutputDialogController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"ChiSquareTestDialog", "modules/scalc/ui/chisquaretestdialog.ui" )
+"modules/scalc/ui/chisquaretestdialog.ui", "ChiSquareTestDialog")
{
-SetText(ScResId(STR_CHI_SQUARE_TEST));
+m_xDialog->set_title(ScResId(STR_CHI_SQUARE_TEST));
}
ScChiSquareTestDialog::~ScChiSquareTestDialog()
{}
-bool ScChiSquareTestDialog::Close()
+void ScChiSquareTestDialog::Close()
{
-return DoClose(ScChiSquareTestDialogWrapper::GetChildWindowId());
+DoClose(ScChiSquareTestDialogWrapper::GetChildWindowId());
}
const char* ScChiSquareTestDialog::GetUndoNameId()
diff --git a/sc/source/ui/inc/ChiSquareTestDialog.hxx
b/sc/source/ui/inc/ChiSquareTestDialog.hxx
index 849914d57f6e..78d1895b6332 100644
--- a/sc/source/ui/inc/ChiSquareTestDialog.hxx
+++ b/sc/source/ui/inc/ChiSquareTestDialog.hxx
@@ -13,16 +13,16 @@
#include "StatisticsInputOutputDialog.hxx"
-class ScChiSquareTestDialog : public ScStatisticsInputOutputDialog
+class ScChiSquareTestDialog : public ScStatisticsInputOutputDialogController
{
public:
ScChiSquareTestDialog(
SfxBindings* pB, SfxChildWindow* pCW,
-vcl::Window* pParent, ScViewData* pViewData );
+weld::Window* pParent, ScViewData* pViewData );
virtual ~ScChiSquareTestDialog() override;
-virtual bool Close() override;
+virtual void Close() override;
protected:
virtual const char* GetUndoNameId() override;
diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx
index b04e4860da6b..e9fb083c472f 100644
--- a/sc/source/ui/inc/reffact.hxx
+++ b/sc/source/ui/inc/reffact.hxx
@@ -135,7 +135,7 @@ private:
};
class ScChiSquareTestDialogWrapper :
-public ChildWindowWrapper
+public ChildControllerWrapper
{
private:
ScChiSquareTestDialogWrapper() = delete;
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 8b86b2986cb1..22405862f434 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -330,12 +330,6 @@ VclPtr ScTabViewShell::CreateRefDialog(
}
break;
-case SID_CHI_SQUARE_TEST_DIALOG:
-{
-pResult = VclPtr::Create( pB, pCW, pParent,
() );
-}
-break;
-
case SID_FOURIER_ANALYSIS_DIALOG:
{
pResult = VclPtr::Create( pB, pCW,
pParent, () );
@@ -528,6 +522,11 @@ std::unique_ptr
ScTabViewShell::CreateRefDialogCont
xResult.reset(new ScZTestDialog(pB, pCW, pParent, ()));
}
break;
+case SID_CHI_SQUARE_TEST_DIALOG:
+{
+xResult.reset(new ScChiSquareTestDialog(pB, pCW,
[Libreoffice-commits] core.git: sc/source
sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx | 317
--
sc/source/ui/inc/StatisticsTwoVariableDialog.hxx | 72 --
2 files changed, 389 deletions(-)
New commits:
commit f4a0c9d9728499176460f8641d3c4edd3a31fdb4
Author: Caolán McNamara
AuthorDate: Wed Apr 10 12:16:49 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:56:23 2019 +0200
ScStatisticsTwoVariableDialog no longer used
Change-Id: Id0aff27f71263769c74ce0a4fc8240ce4fe2110e
Reviewed-on: https://gerrit.libreoffice.org/70540
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
b/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
index 1dfce0397f53..07cb21b60b90 100644
--- a/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx
@@ -18,323 +18,6 @@
#include
-ScStatisticsTwoVariableDialog::ScStatisticsTwoVariableDialog(
-SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData, const
OUString& rID, const OUString& rUIXMLDescription ) :
-ScAnyRefDlg ( pSfxBindings, pChildWindow, pParent, rID,
rUIXMLDescription ),
-mViewData ( pViewData ),
-mDocument ( pViewData->GetDocument() ),
-mVariable1Range ( ScAddress::INITIALIZE_INVALID ),
-mVariable2Range ( ScAddress::INITIALIZE_INVALID ),
-mAddressDetails ( mDocument->GetAddressConvention(), 0, 0 ),
-mOutputAddress ( ScAddress::INITIALIZE_INVALID ),
-mGroupedBy ( BY_COLUMN ),
-mpActiveEdit( nullptr ),
-mCurrentAddress ( pViewData->GetCurX(), pViewData->GetCurY(),
pViewData->GetTabNo() ),
-mDialogLostFocus( false )
-{
-get(mpVariable1RangeLabel, "variable1-range-label");
-get(mpVariable1RangeEdit, "variable1-range-edit");
-get(mpVariable1RangeButton, "variable1-range-button");
-mpVariable1RangeEdit->SetReferences(this, mpVariable1RangeLabel);
-mpVariable1RangeButton->SetReferences(this, mpVariable1RangeEdit);
-
-get(mpVariable2RangeLabel, "variable2-range-label");
-get(mpVariable2RangeEdit, "variable2-range-edit");
-get(mpVariable2RangeButton, "variable2-range-button");
-mpVariable2RangeEdit->SetReferences(this, mpVariable2RangeLabel);
-mpVariable2RangeButton->SetReferences(this, mpVariable2RangeEdit);
-
-get(mpOutputRangeLabel, "output-range-label");
-get(mpOutputRangeEdit, "output-range-edit");
-get(mpOutputRangeButton, "output-range-button");
-mpOutputRangeEdit->SetReferences(this, mpOutputRangeLabel);
-mpOutputRangeButton->SetReferences(this, mpOutputRangeEdit);
-
-get(mpButtonOk, "ok");
-
-get(mpGroupByColumnsRadio, "groupedby-columns-radio");
-get(mpGroupByRowsRadio, "groupedby-rows-radio");
-
-Init();
-GetRangeFromSelection();
-}
-
-ScStatisticsTwoVariableDialog::~ScStatisticsTwoVariableDialog()
-{
-disposeOnce();
-}
-
-void ScStatisticsTwoVariableDialog::dispose()
-{
-mpVariable1RangeLabel.clear();
-mpVariable1RangeEdit.clear();
-mpVariable1RangeButton.clear();
-mpVariable2RangeLabel.clear();
-mpVariable2RangeEdit.clear();
-mpVariable2RangeButton.clear();
-mpOutputRangeLabel.clear();
-mpOutputRangeEdit.clear();
-mpOutputRangeButton.clear();
-mpButtonOk.clear();
-mpGroupByColumnsRadio.clear();
-mpGroupByRowsRadio.clear();
-mpActiveEdit.clear();
-ScAnyRefDlg::dispose();
-}
-
-void ScStatisticsTwoVariableDialog::Init()
-{
-mpButtonOk->SetClickHdl( LINK( this, ScStatisticsTwoVariableDialog,
OkClicked ) );
-mpButtonOk->Enable(false);
-
-Link aLink = LINK( this, ScStatisticsTwoVariableDialog,
GetFocusHandler );
-mpVariable1RangeEdit->SetGetFocusHdl( aLink );
-mpVariable1RangeButton->SetGetFocusHdl( aLink );
-mpVariable2RangeEdit->SetGetFocusHdl( aLink );
-mpVariable2RangeButton->SetGetFocusHdl( aLink );
-mpOutputRangeEdit->SetGetFocusHdl( aLink );
-mpOutputRangeButton->SetGetFocusHdl( aLink );
-
-aLink = LINK( this, ScStatisticsTwoVariableDialog, LoseFocusHandler );
-mpVariable1RangeEdit->SetLoseFocusHdl( aLink );
-mpVariable1RangeButton->SetLoseFocusHdl( aLink );
-mpVariable2RangeEdit->SetLoseFocusHdl( aLink );
-mpVariable2RangeButton->SetLoseFocusHdl( aLink );
-mpOutputRangeEdit->SetLoseFocusHdl( aLink );
-mpOutputRangeButton->SetLoseFocusHdl( aLink );
-
-Link aLink2 = LINK( this, ScStatisticsTwoVariableDialog,
RefInputModifyHandler);
-mpVariable1RangeEdit->SetModifyHdl( aLink2);
-mpVariable2RangeEdit->SetModifyHdl( aLink2);
-mpOutputRangeEdit->SetModifyHdl( aLink2);
-
-mpOutputRangeEdit->GrabFocus();
-
-mpGroupByColumnsRadio->SetToggleHdl( LINK( this,
ScStatisticsTwoVariableDialog, GroupByChanged ) );
-mpGroupByRowsRadio->SetToggleHdl( LINK(
[Libreoffice-commits] core.git: 2 commits - sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/FTestDialog.cxx | 12 +-
sc/source/ui/StatisticsDialogs/TTestDialog.cxx | 12 +-
sc/source/ui/StatisticsDialogs/ZTestDialog.cxx | 12 +-
sc/source/ui/inc/FTestDialog.hxx |6 -
sc/source/ui/inc/TTestDialog.hxx |6 -
sc/source/ui/inc/ZTestDialog.hxx |6 -
sc/source/ui/inc/reffact.hxx |6 -
sc/source/ui/view/tabvwshc.cxx | 33 ++---
sc/uiconfig/scalc/ui/ttestdialog.ui| 148 +
sc/uiconfig/scalc/ui/ztestdialog.ui| 148 +
solenv/sanitizers/ui/modules/scalc.suppr |6 +
11 files changed, 207 insertions(+), 188 deletions(-)
New commits:
commit c2d2f91a6cb684c435ff5a5b68f90be69328aab2
Author: Caolán McNamara
AuthorDate: Wed Apr 10 12:13:21 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:55:35 2019 +0200
weld ScZTestDialog
Change-Id: I9cd624d0dd80d56e772c0241e20ec93e253d8d2b
Reviewed-on: https://gerrit.libreoffice.org/70539
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/ZTestDialog.cxx
b/sc/source/ui/StatisticsDialogs/ZTestDialog.cxx
index 0a1e64526df0..f03f8a41a7bf 100644
--- a/sc/source/ui/StatisticsDialogs/ZTestDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/ZTestDialog.cxx
@@ -18,20 +18,20 @@
ScZTestDialog::ScZTestDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsTwoVariableDialog(
+weld::Window* pParent, ScViewData* pViewData ) :
+ScStatisticsTwoVariableDialogController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"ZTestDialog", "modules/scalc/ui/ztestdialog.ui" )
+"modules/scalc/ui/ztestdialog.ui", "ZTestDialog")
{
-SetText(ScResId(STR_ZTEST));
+m_xDialog->set_title(ScResId(STR_ZTEST));
}
ScZTestDialog::~ScZTestDialog()
{}
-bool ScZTestDialog::Close()
+void ScZTestDialog::Close()
{
-return DoClose( ScZTestDialogWrapper::GetChildWindowId() );
+DoClose( ScZTestDialogWrapper::GetChildWindowId() );
}
const char* ScZTestDialog::GetUndoNameId()
diff --git a/sc/source/ui/inc/ZTestDialog.hxx b/sc/source/ui/inc/ZTestDialog.hxx
index 6fd8496c814b..529dd3f9d850 100644
--- a/sc/source/ui/inc/ZTestDialog.hxx
+++ b/sc/source/ui/inc/ZTestDialog.hxx
@@ -13,16 +13,16 @@
#include "StatisticsTwoVariableDialog.hxx"
-class ScZTestDialog : public ScStatisticsTwoVariableDialog
+class ScZTestDialog : public ScStatisticsTwoVariableDialogController
{
public:
ScZTestDialog(
SfxBindings* pB, SfxChildWindow* pCW,
-vcl::Window* pParent, ScViewData* pViewData );
+weld::Window* pParent, ScViewData* pViewData );
virtual ~ScZTestDialog() override;
-virtual bool Close() override;
+virtual void Close() override;
protected:
virtual const char* GetUndoNameId() override;
diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx
index c3e90eda63d7..b04e4860da6b 100644
--- a/sc/source/ui/inc/reffact.hxx
+++ b/sc/source/ui/inc/reffact.hxx
@@ -128,7 +128,7 @@ private:
};
class ScZTestDialogWrapper :
-public ChildWindowWrapper
+public ChildControllerWrapper
{
private:
ScZTestDialogWrapper() = delete;
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index f84644eba3bb..8b86b2986cb1 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -330,12 +330,6 @@ VclPtr ScTabViewShell::CreateRefDialog(
}
break;
-case SID_ZTEST_DIALOG:
-{
-pResult = VclPtr::Create( pB, pCW, pParent,
() );
-}
-break;
-
case SID_CHI_SQUARE_TEST_DIALOG:
{
pResult = VclPtr::Create( pB, pCW, pParent,
() );
@@ -529,6 +523,11 @@ std::unique_ptr
ScTabViewShell::CreateRefDialogCont
xResult.reset(new ScTTestDialog(pB, pCW, pParent, ()));
}
break;
+case SID_ZTEST_DIALOG:
+{
+xResult.reset(new ScZTestDialog(pB, pCW, pParent, ()));
+}
+break;
}
if (xResult)
diff --git a/sc/uiconfig/scalc/ui/ztestdialog.ui
b/sc/uiconfig/scalc/ui/ztestdialog.ui
index 7bb7e4e0d28e..a23dd22ab90f 100644
--- a/sc/uiconfig/scalc/ui/ztestdialog.ui
+++ b/sc/uiconfig/scalc/ui/ztestdialog.ui
@@ -1,17 +1,80 @@
-
+
-
False
6
+0
+0
dialog
+
+
+
False
vertical
12
+
+
+False
+end
+
+
+gtk-ok
+True
+True
+True
+True
+True
+True
+
+
+
[Libreoffice-commits] core.git: 2 commits - sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/MovingAverageDialog.cxx | 22
sc/source/ui/StatisticsDialogs/RegressionDialog.cxx| 94 +-
sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx | 319
++
sc/source/ui/inc/MovingAverageDialog.hxx |9
sc/source/ui/inc/RegressionDialog.hxx | 29
sc/source/ui/inc/StatisticsTwoVariableDialog.hxx | 73 ++
sc/source/ui/inc/reffact.hxx |4
sc/source/ui/view/tabvwshc.cxx | 22
sc/uiconfig/scalc/ui/movingaveragedialog.ui| 146 ++--
sc/uiconfig/scalc/ui/regressiondialog.ui | 27
solenv/sanitizers/ui/modules/scalc.suppr | 13
11 files changed, 570 insertions(+), 188 deletions(-)
New commits:
commit 5a816c4241c98b97d464007f25657b946eb29005
Author: Caolán McNamara
AuthorDate: Wed Apr 10 11:36:45 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:54:55 2019 +0200
weld ScRegressionDialog
Change-Id: I26cbf2b5ed7482daa8d02adb206b6a783524985a
Reviewed-on: https://gerrit.libreoffice.org/70517
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
index 11ac7b017e77..02b57e2e75db 100644
--- a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
@@ -132,49 +132,35 @@ static size_t lcl_GetNumRowsColsInRange(const ScRange&
rRange, bool bRows)
ScRegressionDialog::ScRegressionDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsTwoVariableDialog(
+weld::Window* pParent, ScViewData* pViewData )
+: ScStatisticsTwoVariableDialogController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"RegressionDialog", "modules/scalc/ui/regressiondialog.ui" ),
-mbUnivariate(true),
-mnNumIndependentVars(1),
-mnNumObservations(0),
-mbUse3DAddresses(false),
-mbCalcIntercept(true)
+"modules/scalc/ui/regressiondialog.ui", "RegressionDialog")
+, mbUnivariate(true)
+, mnNumIndependentVars(1)
+, mnNumObservations(0)
+, mbUse3DAddresses(false)
+, mbCalcIntercept(true)
+, mxWithLabelsCheckBox(m_xBuilder->weld_check_button("withlabels-check"))
+, mxLinearRadioButton(m_xBuilder->weld_radio_button("linear-radio"))
+,
mxLogarithmicRadioButton(m_xBuilder->weld_radio_button("logarithmic-radio"))
+, mxPowerRadioButton(m_xBuilder->weld_radio_button("power-radio"))
+, mxErrorMessage(m_xBuilder->weld_label("error-message"))
+,
mxConfidenceLevelField(m_xBuilder->weld_spin_button("confidencelevel-spin"))
+,
mxCalcResidualsCheckBox(m_xBuilder->weld_check_button("calcresiduals-check"))
+, mxNoInterceptCheckBox(m_xBuilder->weld_check_button("nointercept-check"))
{
-get(mpWithLabelsCheckBox, "withlabels-check");
-get(mpLinearRadioButton, "linear-radio");
-get(mpLogarithmicRadioButton, "logarithmic-radio");
-get(mpPowerRadioButton, "power-radio");
-get(mpConfidenceLevelField, "confidencelevel-spin");
-get(mpCalcResidualsCheckBox, "calcresiduals-check");
-get(mpNoInterceptCheckBox, "nointercept-check");
-get(mpErrorMessage, "error-message");
-mpWithLabelsCheckBox->SetToggleHdl(LINK(this, ScRegressionDialog,
CheckBoxHdl));
-mpConfidenceLevelField->SetModifyHdl(LINK(this, ScRegressionDialog,
NumericFieldHdl));
+mxWithLabelsCheckBox->connect_toggled(LINK(this, ScRegressionDialog,
CheckBoxHdl));
+mxConfidenceLevelField->connect_value_changed(LINK(this,
ScRegressionDialog, NumericFieldHdl));
}
ScRegressionDialog::~ScRegressionDialog()
{
-disposeOnce();
}
-bool ScRegressionDialog::Close()
+void ScRegressionDialog::Close()
{
-return DoClose(ScRegressionDialogWrapper::GetChildWindowId());
-}
-
-void ScRegressionDialog::dispose()
-{
-mpWithLabelsCheckBox.disposeAndClear();
-mpLinearRadioButton.disposeAndClear();
-mpLogarithmicRadioButton.disposeAndClear();
-mpPowerRadioButton.disposeAndClear();
-mpConfidenceLevelField.disposeAndClear();
-mpCalcResidualsCheckBox.disposeAndClear();
-mpNoInterceptCheckBox.disposeAndClear();
-mpErrorMessage.disposeAndClear();
-ScStatisticsTwoVariableDialog::dispose();
+DoClose(ScRegressionDialogWrapper::GetChildWindowId());
}
const char* ScRegressionDialog::GetUndoNameId()
@@ -188,7 +174,7 @@ ScRange ScRegressionDialog::ApplyOutput(ScDocShell*
pDocShell)
formula::FormulaGrammar::mergeToGrammar(
formula::FormulaGrammar::GRAM_ENGLISH, mAddressDetails.eConv));
FormulaTemplate aTemplate(mDocument);
[Libreoffice-commits] core.git: sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx | 22 -
sc/source/ui/inc/ExponentialSmoothingDialog.hxx |9
sc/source/ui/inc/reffact.hxx |2
sc/source/ui/view/tabvwshc.cxx| 11
sc/uiconfig/scalc/ui/exponentialsmoothingdialog.ui| 146 +-
solenv/sanitizers/ui/modules/scalc.suppr |2
6 files changed, 97 insertions(+), 95 deletions(-)
New commits:
commit ab2906c593c280c95de7f1984b4e0eea7b52b768
Author: Caolán McNamara
AuthorDate: Wed Apr 10 10:32:56 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:54:12 2019 +0200
weld ScExponentialSmoothingDialog
Change-Id: Ib648cc1c877eeddcf76c4c5add9058116816d707
Reviewed-on: https://gerrit.libreoffice.org/70510
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx
b/sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx
index b2ab5b48f438..3a94e7c5de72 100644
--- a/sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx
@@ -18,28 +18,22 @@
ScExponentialSmoothingDialog::ScExponentialSmoothingDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsInputOutputDialog(
+weld::Window* pParent, ScViewData* pViewData )
+: ScStatisticsInputOutputDialogController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"ExponentialSmoothingDialog",
"modules/scalc/ui/exponentialsmoothingdialog.ui" )
+"modules/scalc/ui/exponentialsmoothingdialog.ui",
+"ExponentialSmoothingDialog")
+, mxSmoothingFactor(m_xBuilder->weld_spin_button("smoothing-factor-spin"))
{
-get(mpSmoothingFactor, "smoothing-factor-spin");
}
ScExponentialSmoothingDialog::~ScExponentialSmoothingDialog()
{
-disposeOnce();
}
-void ScExponentialSmoothingDialog::dispose()
+void ScExponentialSmoothingDialog::Close()
{
-mpSmoothingFactor.clear();
-ScStatisticsInputOutputDialog::dispose();
-}
-
-bool ScExponentialSmoothingDialog::Close()
-{
-return DoClose( ScExponentialSmoothingDialogWrapper::GetChildWindowId() );
+DoClose( ScExponentialSmoothingDialogWrapper::GetChildWindowId() );
}
const char* ScExponentialSmoothingDialog::GetUndoNameId()
@@ -54,7 +48,7 @@ ScRange ScExponentialSmoothingDialog::ApplyOutput(ScDocShell*
pDocShell)
FormulaTemplate aTemplate(mDocument);
// Smoothing factor
-double aSmoothingFactor = mpSmoothingFactor->GetValue() / 100.0;
+double aSmoothingFactor = mxSmoothingFactor->get_value() / 100.0;
// Alpha
output.writeBoldString(ScResId(STR_LABEL_ALPHA));
diff --git a/sc/source/ui/inc/ExponentialSmoothingDialog.hxx
b/sc/source/ui/inc/ExponentialSmoothingDialog.hxx
index ae2b255df918..f8fad4fa95cf 100644
--- a/sc/source/ui/inc/ExponentialSmoothingDialog.hxx
+++ b/sc/source/ui/inc/ExponentialSmoothingDialog.hxx
@@ -16,20 +16,19 @@
#include "StatisticsInputOutputDialog.hxx"
-class ScExponentialSmoothingDialog : public ScStatisticsInputOutputDialog
+class ScExponentialSmoothingDialog : public
ScStatisticsInputOutputDialogController
{
private:
-VclPtr mpSmoothingFactor;
+std::unique_ptr mxSmoothingFactor;
public:
ScExponentialSmoothingDialog(
SfxBindings* pB, SfxChildWindow* pCW,
-vcl::Window* pParent, ScViewData* pViewData );
+weld::Window* pParent, ScViewData* pViewData );
virtual ~ScExponentialSmoothingDialog() override;
-virtual void dispose() override;
-virtual bool Close() override;
+virtual void Close() override;
protected:
virtual const char* GetUndoNameId() override;
diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx
index fe9070e61771..eb4923dc7903 100644
--- a/sc/source/ui/inc/reffact.hxx
+++ b/sc/source/ui/inc/reffact.hxx
@@ -93,7 +93,7 @@ private:
};
class ScExponentialSmoothingDialogWrapper :
-public ChildWindowWrapper
+public ChildControllerWrapper
{
private:
ScExponentialSmoothingDialogWrapper() = delete;
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 818a1f610b28..5052ab24ec55 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -330,12 +330,6 @@ VclPtr ScTabViewShell::CreateRefDialog(
}
break;
-case SID_EXPONENTIAL_SMOOTHING_DIALOG:
-{
-pResult = VclPtr::Create( pB, pCW,
pParent, () );
-}
-break;
-
case SID_MOVING_AVERAGE_DIALOG:
{
pResult = VclPtr::Create( pB, pCW, pParent,
() );
@@ -534,6 +528,11 @@ std::unique_ptr
ScTabViewShell::CreateRefDialogCont
xResult.reset(new
[Libreoffice-commits] core.git: sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx | 66 +---
sc/source/ui/inc/AnalysisOfVarianceDialog.hxx | 19 +--
sc/source/ui/inc/reffact.hxx|2
sc/source/ui/view/tabvwshc.cxx | 11 --
sc/uiconfig/scalc/ui/analysisofvariancedialog.ui| 32 +++--
sc/uiconfig/scalc/ui/correlationdialog.ui |4
sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui |2
sc/uiconfig/scalc/ui/samplingdialog.ui |4
solenv/sanitizers/ui/modules/scalc.suppr|2
9 files changed, 75 insertions(+), 67 deletions(-)
New commits:
commit a5a0d6050b05362a39424ae9f44627fb3c604b8a
Author: Caolán McNamara
AuthorDate: Wed Apr 10 10:15:20 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:53:25 2019 +0200
weld ScAnalysisOfVarianceDialog
Change-Id: I94b736bbc5268f36a56a4a40ec39c6adaf67afbf
Reviewed-on: https://gerrit.libreoffice.org/70506
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
index b8284c6f885d..0dc391a17e2f 100644
--- a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
@@ -67,10 +67,10 @@ OUString lclCreateMultiParameterFormula(
return aResult.makeStringAndClear();
}
-void lclMakeSubRangesList(ScRangeList& rRangeList, const ScRange& rInputRange,
ScStatisticsInputOutputDialog::GroupedBy aGroupedBy)
+void lclMakeSubRangesList(ScRangeList& rRangeList, const ScRange& rInputRange,
ScStatisticsInputOutputDialogController::GroupedBy aGroupedBy)
{
std::unique_ptr pIterator;
-if (aGroupedBy == ScStatisticsInputOutputDialog::BY_COLUMN)
+if (aGroupedBy == ScStatisticsInputOutputDialogController::BY_COLUMN)
pIterator.reset(new DataRangeByColumnIterator(rInputRange));
else
pIterator.reset(new DataRangeByRowIterator(rInputRange));
@@ -86,43 +86,33 @@ void lclMakeSubRangesList(ScRangeList& rRangeList, const
ScRange& rInputRange, S
ScAnalysisOfVarianceDialog::ScAnalysisOfVarianceDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsInputOutputDialog(
+weld::Window* pParent, ScViewData* pViewData )
+: ScStatisticsInputOutputDialogController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"AnalysisOfVarianceDialog",
"modules/scalc/ui/analysisofvariancedialog.ui" ),
-meFactor(SINGLE_FACTOR)
+"modules/scalc/ui/analysisofvariancedialog.ui",
+"AnalysisOfVarianceDialog")
+, meFactor(SINGLE_FACTOR)
+, mxAlphaField(m_xBuilder->weld_spin_button("alpha-spin"))
+, mxSingleFactorRadio(m_xBuilder->weld_radio_button("radio-single-factor"))
+, mxTwoFactorRadio(m_xBuilder->weld_radio_button("radio-two-factor"))
+,
mxRowsPerSampleField(m_xBuilder->weld_spin_button("rows-per-sample-spin"))
{
-get(mpAlphaField, "alpha-spin");
-get(mpSingleFactorRadio, "radio-single-factor");
-get(mpTwoFactorRadio, "radio-two-factor");
-get(mpRowsPerSampleField, "rows-per-sample-spin");
+mxSingleFactorRadio->connect_toggled( LINK( this,
ScAnalysisOfVarianceDialog, FactorChanged ) );
+mxTwoFactorRadio->connect_toggled( LINK( this, ScAnalysisOfVarianceDialog,
FactorChanged ) );
-mpSingleFactorRadio->SetToggleHdl( LINK( this, ScAnalysisOfVarianceDialog,
FactorChanged ) );
-mpTwoFactorRadio->SetToggleHdl( LINK( this, ScAnalysisOfVarianceDialog,
FactorChanged ) );
-
-mpSingleFactorRadio->Check();
-mpTwoFactorRadio->Check(false);
+mxSingleFactorRadio->set_active(true);
+mxTwoFactorRadio->set_active(false);
FactorChanged();
}
ScAnalysisOfVarianceDialog::~ScAnalysisOfVarianceDialog()
{
-disposeOnce();
-}
-
-void ScAnalysisOfVarianceDialog::dispose()
-{
-mpAlphaField.clear();
-mpSingleFactorRadio.clear();
-mpTwoFactorRadio.clear();
-mpRowsPerSampleField.clear();
-ScStatisticsInputOutputDialog::dispose();
}
-bool ScAnalysisOfVarianceDialog::Close()
+void ScAnalysisOfVarianceDialog::Close()
{
-return DoClose( ScAnalysisOfVarianceDialogWrapper::GetChildWindowId() );
+DoClose( ScAnalysisOfVarianceDialogWrapper::GetChildWindowId() );
}
const char* ScAnalysisOfVarianceDialog::GetUndoNameId()
@@ -130,25 +120,25 @@ const char* ScAnalysisOfVarianceDialog::GetUndoNameId()
return STR_ANALYSIS_OF_VARIANCE_UNDO_NAME;
}
-IMPL_LINK_NOARG( ScAnalysisOfVarianceDialog, FactorChanged, RadioButton&, void
)
+IMPL_LINK_NOARG( ScAnalysisOfVarianceDialog, FactorChanged,
weld::ToggleButton&, void )
{
FactorChanged();
}
void
[Libreoffice-commits] core.git: sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx | 10 -
sc/source/ui/inc/CovarianceDialog.hxx |6
sc/source/ui/inc/reffact.hxx|2
sc/source/ui/view/tabvwshc.cxx | 11 -
sc/uiconfig/scalc/ui/covariancedialog.ui| 140 ++--
solenv/sanitizers/ui/modules/scalc.suppr|2
6 files changed, 90 insertions(+), 81 deletions(-)
New commits:
commit 364880e744398bf4e95eb9176819a870c1852e03
Author: Caolán McNamara
AuthorDate: Wed Apr 10 10:23:49 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:53:46 2019 +0200
weld ScCovarianceDialog
Change-Id: I7546aa234ee986701b9908f33a6c96e6779d654d
Reviewed-on: https://gerrit.libreoffice.org/70509
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
b/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
index d5243745278b..522297cc731d 100644
--- a/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx
@@ -15,10 +15,10 @@
ScCovarianceDialog::ScCovarianceDialog(
SfxBindings* pSfxBindings, SfxChildWindow*
pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScMatrixComparisonGenerator(
+weld::Window* pParent, ScViewData* pViewData ) :
+ScMatrixComparisonGeneratorController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"CovarianceDialog", "modules/scalc/ui/covariancedialog.ui" )
+"modules/scalc/ui/covariancedialog.ui", "CovarianceDialog")
{}
const char* ScCovarianceDialog::GetUndoNameId()
@@ -26,9 +26,9 @@ const char* ScCovarianceDialog::GetUndoNameId()
return STR_COVARIANCE_UNDO_NAME;
}
-bool ScCovarianceDialog::Close()
+void ScCovarianceDialog::Close()
{
-return DoClose( ScCovarianceDialogWrapper::GetChildWindowId() );
+DoClose( ScCovarianceDialogWrapper::GetChildWindowId() );
}
const OUString ScCovarianceDialog::getLabel()
diff --git a/sc/source/ui/inc/CovarianceDialog.hxx
b/sc/source/ui/inc/CovarianceDialog.hxx
index 3bd5a9e2657b..99052c51b644 100644
--- a/sc/source/ui/inc/CovarianceDialog.hxx
+++ b/sc/source/ui/inc/CovarianceDialog.hxx
@@ -13,14 +13,14 @@
#include "MatrixComparisonGenerator.hxx"
-class ScCovarianceDialog : public ScMatrixComparisonGenerator
+class ScCovarianceDialog : public ScMatrixComparisonGeneratorController
{
public:
ScCovarianceDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData);
+weld::Window* pParent, ScViewData* pViewData);
-virtual bool Close() override;
+virtual void Close() override;
protected:
virtual const OUString getLabel() override;
diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx
index b1dda37d1249..fe9070e61771 100644
--- a/sc/source/ui/inc/reffact.hxx
+++ b/sc/source/ui/inc/reffact.hxx
@@ -86,7 +86,7 @@ private:
};
class ScCovarianceDialogWrapper :
-public ChildWindowWrapper
+public ChildControllerWrapper
{
private:
ScCovarianceDialogWrapper() = delete;
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 379bf2ad3f1f..818a1f610b28 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -330,12 +330,6 @@ VclPtr ScTabViewShell::CreateRefDialog(
}
break;
-case SID_COVARIANCE_DIALOG:
-{
-pResult = VclPtr::Create( pB, pCW, pParent,
() );
-}
-break;
-
case SID_EXPONENTIAL_SMOOTHING_DIALOG:
{
pResult = VclPtr::Create( pB, pCW,
pParent, () );
@@ -535,6 +529,11 @@ std::unique_ptr
ScTabViewShell::CreateRefDialogCont
xResult.reset(new ScAnalysisOfVarianceDialog(pB, pCW, pParent,
()));
}
break;
+case SID_COVARIANCE_DIALOG:
+{
+xResult.reset(new ScCovarianceDialog(pB, pCW, pParent,
()));
+}
+break;
}
if (xResult)
diff --git a/sc/uiconfig/scalc/ui/covariancedialog.ui
b/sc/uiconfig/scalc/ui/covariancedialog.ui
index f8a92854221b..07a766a13dd4 100644
--- a/sc/uiconfig/scalc/ui/covariancedialog.ui
+++ b/sc/uiconfig/scalc/ui/covariancedialog.ui
@@ -1,5 +1,5 @@
-
+
@@ -8,12 +8,76 @@
6
Covariance
False
+0
+0
dialog
+
+
+
False
vertical
12
+
+
+False
+end
+
+
+gtk-ok
+True
+True
+True
+True
+True
+True
+
+
+False
+True
+0
+
+
+
+
[Libreoffice-commits] core.git: sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx | 11
sc/source/ui/inc/DescriptiveStatisticsDialog.hxx |6
sc/source/ui/inc/reffact.hxx |2
sc/source/ui/view/tabvwshc.cxx | 11
sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui| 139
+-
solenv/sanitizers/ui/modules/scalc.suppr |2
6 files changed, 89 insertions(+), 82 deletions(-)
New commits:
commit 48af979d264fff14352b2c69db137332fcfdb25e
Author: Caolán McNamara
AuthorDate: Wed Apr 10 09:56:19 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:52:30 2019 +0200
weld ScDescriptiveStatisticsDialog
Change-Id: Idedc0c47bed3ce57e9e681146222dc7f7573819e
Reviewed-on: https://gerrit.libreoffice.org/70505
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
b/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
index 3e55faced5d9..aabb3ae06c88 100644
--- a/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx
@@ -48,18 +48,19 @@ static const StatisticCalculation lclCalcDefinitions[] =
ScDescriptiveStatisticsDialog::ScDescriptiveStatisticsDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScStatisticsInputOutputDialog(
+weld::Window* pParent, ScViewData* pViewData ) :
+ScStatisticsInputOutputDialogController(
pSfxBindings, pChildWindow, pParent, pViewData,
-"DescriptiveStatisticsDialog",
"modules/scalc/ui/descriptivestatisticsdialog.ui" )
+"modules/scalc/ui/descriptivestatisticsdialog.ui",
+"DescriptiveStatisticsDialog")
{}
ScDescriptiveStatisticsDialog::~ScDescriptiveStatisticsDialog()
{}
-bool ScDescriptiveStatisticsDialog::Close()
+void ScDescriptiveStatisticsDialog::Close()
{
-return DoClose( ScDescriptiveStatisticsDialogWrapper::GetChildWindowId() );
+DoClose( ScDescriptiveStatisticsDialogWrapper::GetChildWindowId() );
}
const char* ScDescriptiveStatisticsDialog::GetUndoNameId()
diff --git a/sc/source/ui/inc/DescriptiveStatisticsDialog.hxx
b/sc/source/ui/inc/DescriptiveStatisticsDialog.hxx
index bbdc727b06e4..0ffe831163bc 100644
--- a/sc/source/ui/inc/DescriptiveStatisticsDialog.hxx
+++ b/sc/source/ui/inc/DescriptiveStatisticsDialog.hxx
@@ -13,16 +13,16 @@
#include "StatisticsInputOutputDialog.hxx"
-class ScDescriptiveStatisticsDialog : public ScStatisticsInputOutputDialog
+class ScDescriptiveStatisticsDialog : public
ScStatisticsInputOutputDialogController
{
public:
ScDescriptiveStatisticsDialog(
SfxBindings* pB, SfxChildWindow* pCW,
-vcl::Window* pParent, ScViewData* pViewData );
+weld::Window* pParent, ScViewData* pViewData );
virtual ~ScDescriptiveStatisticsDialog() override;
-virtual bool Close() override;
+virtual void Close() override;
protected:
virtual const char* GetUndoNameId() override;
diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx
index a19ef1686d1b..c8ce5507bc08 100644
--- a/sc/source/ui/inc/reffact.hxx
+++ b/sc/source/ui/inc/reffact.hxx
@@ -51,7 +51,7 @@ DECL_WRAPPER_WITHID(ScHighlightChgDlgWrapper)
DECL_WRAPPER_WITHID(ScCondFormatDlgWrapper)
class ScDescriptiveStatisticsDialogWrapper :
-public ChildWindowWrapper
+public ChildControllerWrapper
{
private:
ScDescriptiveStatisticsDialogWrapper() = delete;
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 6f3a947e7dce..545a9dc4974f 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -330,12 +330,6 @@ VclPtr ScTabViewShell::CreateRefDialog(
}
break;
-case SID_DESCRIPTIVE_STATISTICS_DIALOG:
-{
-pResult = VclPtr::Create( pB, pCW,
pParent, () );
-}
-break;
-
case SID_ANALYSIS_OF_VARIANCE_DIALOG:
{
pResult = VclPtr::Create( pB, pCW,
pParent, () );
@@ -537,6 +531,11 @@ std::unique_ptr
ScTabViewShell::CreateRefDialogCont
xResult.reset(new ScSamplingDialog(pB, pCW, pParent,
()));
}
break;
+case SID_DESCRIPTIVE_STATISTICS_DIALOG:
+{
+xResult.reset(new ScDescriptiveStatisticsDialog(pB, pCW, pParent,
()));
+}
+break;
}
if (xResult)
diff --git a/sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui
b/sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui
index a4c5bbea3413..4086f5a7cdb7 100644
--- a/sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui
+++ b/sc/uiconfig/scalc/ui/descriptivestatisticsdialog.ui
@@ -1,19 +1,82 @@
-
+
-
False
6
[Libreoffice-commits] core.git: sc/source sc/uiconfig solenv/sanitizers
sc/source/ui/StatisticsDialogs/SamplingDialog.cxx | 305 ++
sc/source/ui/inc/SamplingDialog.hxx | 65 ++--
sc/source/ui/inc/reffact.hxx |2
sc/source/ui/view/tabvwshc.cxx| 11
sc/uiconfig/scalc/ui/samplingdialog.ui| 14 -
solenv/sanitizers/ui/modules/scalc.suppr |2
6 files changed, 197 insertions(+), 202 deletions(-)
New commits:
commit ab181504329e33a31ad23c887d817519374c9797
Author: Caolán McNamara
AuthorDate: Wed Apr 10 09:05:57 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 11 09:52:11 2019 +0200
weld ScSamplingDialog
Change-Id: Ifbae09b2d2b6ebf0c56332ef4f87f3045f97f1ad
Reviewed-on: https://gerrit.libreoffice.org/70503
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
b/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
index 277485f6b492..59fbb194df9f 100644
--- a/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/SamplingDialog.cxx
@@ -19,43 +19,39 @@
#include
#include
-ScSamplingDialog::ScSamplingDialog(
-SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-vcl::Window* pParent, ScViewData* pViewData ) :
-ScAnyRefDlg ( pSfxBindings, pChildWindow, pParent,
- "SamplingDialog", "modules/scalc/ui/samplingdialog.ui" ),
-mpActiveEdit( nullptr ),
-mViewData ( pViewData ),
-mDocument ( pViewData->GetDocument() ),
-mInputRange ( ScAddress::INITIALIZE_INVALID ),
-mAddressDetails ( mDocument->GetAddressConvention(), 0, 0 ),
-mOutputAddress ( ScAddress::INITIALIZE_INVALID ),
-mCurrentAddress ( pViewData->GetCurX(), pViewData->GetCurY(),
pViewData->GetTabNo() ),
-mnLastSampleSizeValue(1),
-mnLastPeriodValue(1),
-mDialogLostFocus( false )
+ScSamplingDialog::ScSamplingDialog(SfxBindings* pSfxBindings, SfxChildWindow*
pChildWindow,
+ weld::Window* pParent, ScViewData*
pViewData)
+: ScAnyRefDlgController(pSfxBindings, pChildWindow, pParent,
+ "modules/scalc/ui/samplingdialog.ui",
"SamplingDialog")
+, mpActiveEdit(nullptr)
+, mViewData(pViewData)
+, mDocument(pViewData->GetDocument())
+, mInputRange(ScAddress::INITIALIZE_INVALID)
+, mAddressDetails(mDocument->GetAddressConvention(), 0, 0)
+, mOutputAddress(ScAddress::INITIALIZE_INVALID)
+, mCurrentAddress(pViewData->GetCurX(), pViewData->GetCurY(),
pViewData->GetTabNo())
+, mnLastSampleSizeValue(1)
+, mnLastPeriodValue(1)
+, mDialogLostFocus(false)
+, mxInputRangeLabel(m_xBuilder->weld_label("input-range-label"))
+, mxInputRangeEdit(new
formula::WeldRefEdit(m_xBuilder->weld_entry("input-range-edit")))
+, mxInputRangeButton(new
formula::WeldRefButton(m_xBuilder->weld_button("input-range-button")))
+, mxOutputRangeLabel(m_xBuilder->weld_label("output-range-label"))
+, mxOutputRangeEdit(new
formula::WeldRefEdit(m_xBuilder->weld_entry("output-range-edit")))
+, mxOutputRangeButton(new
formula::WeldRefButton(m_xBuilder->weld_button("output-range-button")))
+, mxSampleSize(m_xBuilder->weld_spin_button("sample-size-spin"))
+, mxPeriod(m_xBuilder->weld_spin_button("period-spin"))
+, mxRandomMethodRadio(m_xBuilder->weld_radio_button("random-method-radio"))
+, mxWithReplacement(m_xBuilder->weld_check_button("with-replacement"))
+, mxKeepOrder(m_xBuilder->weld_check_button("keep-order"))
+,
mxPeriodicMethodRadio(m_xBuilder->weld_radio_button("periodic-method-radio"))
+, mxButtonOk(m_xBuilder->weld_button("ok"))
{
-get(mpInputRangeLabel, "input-range-label");
-get(mpInputRangeEdit, "input-range-edit");
-get(mpInputRangeButton, "input-range-button");
-mpInputRangeEdit->SetReferences(this, mpInputRangeLabel);
-mpInputRangeButton->SetReferences(this, mpInputRangeEdit);
+mxInputRangeEdit->SetReferences(this, mxInputRangeLabel.get());
+mxInputRangeButton->SetReferences(this, mxInputRangeEdit.get());
-get(mpOutputRangeLabel, "output-range-label");
-get(mpOutputRangeEdit, "output-range-edit");
-get(mpOutputRangeButton, "output-range-button");
-mpOutputRangeEdit->SetReferences(this, mpOutputRangeLabel);
-mpOutputRangeButton->SetReferences(this, mpOutputRangeEdit);
-
-get(mpSampleSize, "sample-size-spin");
-get(mpPeriod, "period-spin");
-
-get(mpRandomMethodRadio, "random-method-radio");
-get(mpWithReplacement, "with-replacement");
-get(mpKeepOrder, "keep-order");
-get(mpPeriodicMethodRadio, "periodic-method-radio");
-
-get(mpButtonOk, "ok");
+mxOutputRangeEdit->SetReferences(this, mxOutputRangeLabel.get());
+mxOutputRangeButton->SetReferences(this, mxOutputRangeEdit.get());
[Libreoffice-bugs] [Bug 124665] writer -> menubar -> Edit -> .uno:ShadowCursor isn't related to select subgroup
https://bugs.documentfoundation.org/show_bug.cgi?id=124665 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Heiko Tietze --- How about next to Edit Mode at the bottom of this menu? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124665] writer -> menubar -> Edit -> .uno:ShadowCursor isn't related to select subgroup
https://bugs.documentfoundation.org/show_bug.cgi?id=124665 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #1 from Heiko Tietze --- How about next to Edit Mode at the bottom of this menu? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124643] Calc - skips existing sum cell if I create a new sum containing the existing cell(using mouse for selecting cells)
https://bugs.documentfoundation.org/show_bug.cgi?id=124643 --- Comment #3 from Petr Polacek --- This bug in Calc is very old and is on all platforms I tested: LibreOffice & OpenOffice on Windows PC - Intel/AMD (32 bit and 64bit) LibreOffice & OpenOffice on Linux PC (Centos, Debian) - Intel/AMD (32/64bit) LibreOffice on Linux - ARM CPU - BananaPi LibreOffice on PowerMac G5 - MacOS X & Linux (IBM PowerPC CPU) NeoOffice on PowerMac G5 - MacOS X (IBM PowerPC CPU) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Make API versioning compiler evaluable
Hi everyone, while discussing https://gerrit.libreoffice.org/#/c/70528/, I realized that we have actually extended API documentation using @deprecated and @since (which I knew), but I don't know a way to automatically check them. Maybe I'm just unaware, but I also couldn't find anything, neither via Web search nor various greps on the code base. Using opengrok I got "Searched full:deprecated" = 593 and "Searched full:"@ deprecated"" = 348. And while at it "Searched full:since" = 2959 and "Searched full:"@ since" = 1447. So massive info is there :-) IMHO we want to introduce something like glib/gversionmacros.h (see the end of https://developer.gnome.org/glib/stable/glib-compiling.html). Nobody can manually verify the use of deprecated or introduced functions with regard to the version (@deprecated is sadly currently unversioned). I was just aware of G_DISABLE_DEPRECATED, which glib / gtk has "since ever". Now I found there also is (and we should use) GLIB_VERSION_MIN_REQUIRED and GLIB_VERSION_MAX_ALLOWED. I was already bitten by not using this, when I checked in the timer changes for the VCL gtk backend and found that our baseline glib was too old, after pushing it. Some questions that came to my mind: * Has UDK an independent versioning, or is it also the Office version? * Does anybody have a sensible idea to generate macros from docs or the other way around? * Is this easyhackable, if the required infrastructure is in place? * Any good idea to automatically version the @deprecated? More comments? Jan-Marek P.S. there are some funny @since, like "@since #i39203#". I've attached a "git grep '@since' | sed 's/^[^@]*//' | sort -u". The 2007 dates are from reportbuilder/java/org/libreoffice/report/pentaho/. The rest looks promising. P.P.S. that would have been something for GSoC... @overload @since LibreOffice 5.3 */ @overload @since LibreOffice 5.4 */ @since 02.03.2007 @since 05.03.2007 @since 06.03.2007 @since 07.03.2007 @since 08.03.2007 @since 09.03.2007 @since 0.9.2 @since 11.03.2007 @since 12.03.2007 @since 13.03.2007 @since 1.4 @since 14.03.2007 @since 15.03.2007 @since 1.7.0 @since 1.8.0.8 @since 19.03.2007 @since 20.03.2007 @since 22.03.2007 @since 24.03.2007 @since 26.03.2007 @since 30.03.2007 @since 31.03.2007 @since 3.5 @since 3.5.0 @since 4.5 @since AOO bug 75163 (OpenOffice.org 2.4.3 - OOH 680 milestone 212) @since Apache OpenOffice 4.0, LibreOffice 4.2 @since \#i32109# @since #i39203# @since #i40086# @since LibreOffice 3.3 @since LibreOffice 3.3 @since LibreOffice 3.4 @since LibreOffice 3.5 @since LibreOffice 3.5. @since LibreOffice 3.6 @since LibreOffice 4.0 @since LibreOffice 4.0 */ @since LibreOffice 4.1 @since LibreOffice 4.2 @since LibreOffice 4.3 @since LibreOffice 4.3 **/ @since LibreOffice 4.4 @since LibreOffice 5.0 @since LibreOffice 5.0 */ @since LibreOffice 5.1 @since LibreOffice 5.2 @since LibreOffice 5.3 @since LibreOffice 5.3 */ @since LibreOffice 5.4 @since LibreOffice 5.5 @since LibreOffice 6.0 @since LibreOffice 6.0 */ const short CHECKBOX_GPGENCRYPTION = 211; @since LibreOffice 6.1 @since LibreOffice 6.1 */ const short LISTBOX_IMAGE_ANCHOR = 212; @since LibreOffice 6.1 */ const short LISTBOX_IMAGE_ANCHOR_LABEL = 213; @since LibreOffice 6.1) @since LibreOffice 6.2 @since LibreOffice 6.3 @since OOo 1.1.2 @since OOo 2.0 @since OOo 2.0.0 @since OOo 2.0.1 @since OOo 2.0.1 @since OOo 2.0.3 @since OOo 2.0.4 @since OOo 2.1 @since OOo 2.1 @since OOo 2.2 @since OOo 2.3 @since OOo 2.3.1 @since OOo 2.4 @since OOo 2.4 @since OOo 3.0 @since OOo 3.0.1 @since OOo 3.0.1 @since OOo 3.1 @since OOo 3.2 @since OOo 3.3 @since OOo 3.4 @since OOo 3.5 @since pFilterOptions argument added in LibreOffice 5.0 @since UDK1.0 @since UDK 1.0 @since UDK1.0 @since UDK2.0 @since UDK 3.1.0 @since UDK 3.2 @since UDK 3.2.0 @since UDK 3.2.1 @since UDK 3.2.10 @since UDK 3.2.12 @since UDK 3.2.13 @since UDK 3.2.2 @since UDK 3.2.3 @since UDK 3.2.7 @since UDK 3.2.8 @since UDK 3.2.9 @since UDK 3.6 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: On backporting fix for tdf#124503 "LibreOffice doesn't detect JVM because of unexpected java.vendor property value"
Hi Stephan, Stephan Bergmann wrote: > If not, the question is whether to backport the above fix to > libreoffice-6-1 (towards LO 6.1.6), libreoffice-6-2 (towards LO > 6.2.4), and maybe even libreoffice-6-2-3. The fix isn't exactly > small, so I would prefer to not backport it aggressively. But I > don't know how severely users would be affected by this issue. > I'd prefer a backport to both maintained branches - at the current speed of new binary Java distros springing up (and the overall trajectory of that ecosystem there), I'd expect more of those issues down the road. Cheers, -- Thorsten signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 116714] Are we bound to the old OOo Tango styled icons/oasis for the sysui
https://bugs.documentfoundation.org/show_bug.cgi?id=116714 --- Comment #9 from Heiko Tietze --- (In reply to andreas_k from comment #7) > we have .ico and .icons files for applications and mimetype in core. please > use them. The task is rather vice versa to also update the icons mentioned here. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 116714] Are we bound to the old OOo Tango styled icons/oasis for the sysui
https://bugs.documentfoundation.org/show_bug.cgi?id=116714 --- Comment #9 from Heiko Tietze --- (In reply to andreas_k from comment #7) > we have .ico and .icons files for applications and mimetype in core. please > use them. The task is rather vice versa to also update the icons mentioned here. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/unowriter/unowriter.cxx | 66 +++
1 file changed, 14 insertions(+), 52 deletions(-)
New commits:
commit e0fde23412496d548c74603223f7a21b638ece79
Author: Miklos Vajna
AuthorDate: Wed Apr 10 21:21:13 2019 +0200
Commit: Miklos Vajna
CommitDate: Thu Apr 11 09:13:45 2019 +0200
CppunitTest_sw_unowriter: use CPPUNIT_TEST_FIXTURE()
Instead of the custom DECLARE_UNOAPI_TEST_FILE() and
DECLARE_UNOAPI_TEST().
Change-Id: I5565ad1661ada870f3f53da808bd5a30f2172013
Reviewed-on: https://gerrit.libreoffice.org/70538
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/unowriter/unowriter.cxx
b/sw/qa/extras/unowriter/unowriter.cxx
index 361a608df78b..376ba0389637 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -83,49 +83,7 @@ public:
}
};
-/**
- * Macro to declare a new test with preloaded file
- * (similar to DECLARE_SW_ROUNDTRIP_TEST)
- */
-#define DECLARE_UNOAPI_TEST_FILE(TestName, filename)
\
-class TestName : public SwUnoWriter
\
-{
\
-protected:
\
-virtual OUString getTestName() override { return OUString(#TestName);
}\
-
\
-public:
\
-CPPUNIT_TEST_SUITE(TestName);
\
-CPPUNIT_TEST(loadAndTest);
\
-CPPUNIT_TEST_SUITE_END();
\
-void loadAndTest()
\
-{
\
-load(mpTestDocumentPath, filename);
\
-runTest();
\
-}
\
-void runTest();
\
-};
\
-CPPUNIT_TEST_SUITE_REGISTRATION(TestName);
\
-void TestName::runTest()
-
-/**
- * Macro to declare a new test without loading any files
- */
-#define DECLARE_UNOAPI_TEST(TestName)
\
-class TestName : public SwUnoWriter
\
-{
\
-protected:
\
-virtual OUString getTestName() override { return OUString(#TestName);
}\
-
\
-public:
\
-CPPUNIT_TEST_SUITE(TestName);
\
-CPPUNIT_TEST(runTest);
\
-CPPUNIT_TEST_SUITE_END();
\
-void runTest();
\
-};
\
-CPPUNIT_TEST_SUITE_REGISTRATION(TestName);
\
-void TestName::runTest()
-
-DECLARE_UNOAPI_TEST(testDefaultCharStyle)
+CPPUNIT_TEST_FIXTURE(SwUnoWriter, testDefaultCharStyle)
{
// Create a new document, type a character, set its char style to Emphasis
// and assert the style was set.
@@ -151,7 +109,7 @@ DECLARE_UNOAPI_TEST(testDefaultCharStyle)
getProperty(xCursorProps,
"CharPosture"));
}
-DECLARE_UNOAPI_TEST(testGraphicDesciptorURL)
+CPPUNIT_TEST_FIXTURE(SwUnoWriter, testGraphicDesciptorURL)
{
loadURL("private:factory/swriter", nullptr);
@@ -178,7 +136,7 @@ DECLARE_UNOAPI_TEST(testGraphicDesciptorURL)
CPPUNIT_ASSERT(xGraphic.is());
}
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||112681 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112681 [Bug 112681] [META] DOC (binary) character-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOC document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Summary|Lost of space symbols in|Lost of space symbols in |DOCX document |DOC document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112681] [META] DOC (binary) character-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112681 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124670 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124670 [Bug 124670] Lost of space symbols in DOCX document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108769] [META] DOCX (OOXML) character-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108769 Mike Kaganski changed: What|Removed |Added Depends on|124670 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124670 [Bug 124670] Lost of space symbols in DOCX document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Blocks|108769 | Status|UNCONFIRMED |NEW Version|6.1.0.3 release |6.0.0.1 rc Keywords|filter:docx |filter:doc Summary|Lost of space symbols in|Lost of space symbols in |DOC document|DOCX document --- Comment #2 from Mike Kaganski --- Reproducible since Version: 6.0.0.1 (x64) Build ID: d2bec56d7865f05a1003dc88449f2b0fdd85309a CPU threads: 12; OS: Windows 10.0; UI render: GL; Locale: ru-RU (ru_RU); Calc: group and in current master. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108769 [Bug 108769] [META] DOCX (OOXML) character-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOC document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Andrew changed: What|Removed |Added Summary|Lost of space symbols in|Lost of space symbols in |DOCX document |DOC document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Andrew changed: What|Removed |Added Version|6.1.5.2 release |6.1.0.3 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||bibisectRequest, regression Blocks||108769 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108769 [Bug 108769] [META] DOCX (OOXML) character-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108769] [META] DOCX (OOXML) character-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108769 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124670 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124670 [Bug 124670] Lost of space symbols in DOCX document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||filter:docx -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 --- Comment #1 from Andrew --- Created attachment 150676 --> https://bugs.documentfoundation.org/attachment.cgi?id=150676=edit Sample 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124670] New: Lost of space symbols in DOCX document
https://bugs.documentfoundation.org/show_bug.cgi?id=124670 Bug ID: 124670 Summary: Lost of space symbols in DOCX document Product: LibreOffice Version: 6.1.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tenc...@gmail.com Created attachment 150675 --> https://bugs.documentfoundation.org/attachment.cgi?id=150675=edit Sample 1 In version 6.x this documents imported without any space symbols In 5.x it seems normal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 044e58900d2e68c1885cac490118e61b7fffb00b Author: Andrea Gelmini AuthorDate: Wed Apr 10 16:06:15 2019 + Commit: Julien Nabet CommitDate: Thu Apr 11 08:56:58 2019 +0200 Fix typo Change-Id: I9f86967383e98ee051aee5e98bcb68fb4f165ef2 Reviewed-on: https://gerrit.libreoffice.org/70577 Tested-by: Jenkins Reviewed-by: himajin10 Reviewed-by: Julien Nabet diff --git a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx index f6ee8695ddae..f74321d69c23 100644 --- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx +++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx @@ -117,7 +117,7 @@ private: boolm_bLinesAllowed; //this should only be used, if the DataSeriesPointWrapper is initialized via the XInitialize interface -//because a big change in the chartmodel may lead to an dataseriespointer that is not connected to the model anymore +//because a big change in the chartmodel may lead to a dataseriespointer that is not connected to the model anymore //with the indices instead we can always get the new dataseries css::uno::Reference< css::chart2::XDataSeries > m_xDataSeries; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/chartapiwrapper/TitleWrapper.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 28458290212618ab2a9bcb0d12745a0512b1e8b5
Author: Andrea Gelmini
AuthorDate: Wed Apr 10 16:06:14 2019 +
Commit: Julien Nabet
CommitDate: Thu Apr 11 08:56:26 2019 +0200
Fix typo
Change-Id: Ia4cad4c7ca97a8230439b94f2fca74324a4dad41
Reviewed-on: https://gerrit.libreoffice.org/70578
Reviewed-by: himajin10
Reviewed-by: Julien Nabet
Tested-by: Julien Nabet
diff --git a/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
b/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
index e14d528c6163..767dfa36b55b 100644
--- a/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
@@ -98,7 +98,7 @@ Any WrappedTitleStringProperty::getPropertyValue( const
Reference< beans::XPrope
}
Any WrappedTitleStringProperty::getPropertyDefault( const Reference<
beans::XPropertyState >& /*xInnerPropertyState*/ ) const
{
-return uno::Any( OUString() );//default title is a empty String
+return uno::Any( OUString() );//default title is an empty String
}
class WrappedStackedTextProperty : public WrappedProperty
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source udkapi/com
connectivity/source/drivers/dbase/dindexnode.cxx |2 +- udkapi/com/sun/star/bridge/oleautomation/NamedArgument.idl |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 81514d136ec5480faffc697cc057c2abd76799a5 Author: Andrea Gelmini AuthorDate: Wed Apr 10 16:29:47 2019 + Commit: Julien Nabet CommitDate: Thu Apr 11 08:55:50 2019 +0200 Fix typos Change-Id: I1c3fccac03b5cc8acdd1d25dc5536f5874ff26ad Reviewed-on: https://gerrit.libreoffice.org/70575 Tested-by: Jenkins Reviewed-by: himajin10 Reviewed-by: Julien Nabet diff --git a/connectivity/source/drivers/dbase/dindexnode.cxx b/connectivity/source/drivers/dbase/dindexnode.cxx index 8b4fd49fb54d..be85e87096b4 100644 --- a/connectivity/source/drivers/dbase/dindexnode.cxx +++ b/connectivity/source/drivers/dbase/dindexnode.cxx @@ -459,7 +459,7 @@ ONDXNode ONDXPage::Split(ONDXPage& rPage) aResultNode = (*this)[(nCount + 1) / 2]; nCount = (nCount + 1) / 2; -// new page points to page with extraced node +// new page points to page with extracted node rPage.SetChild(aResultNode.GetChild()); } // node points to new page diff --git a/udkapi/com/sun/star/bridge/oleautomation/NamedArgument.idl b/udkapi/com/sun/star/bridge/oleautomation/NamedArgument.idl index 0abc343ef2dd..9de3ae2faec3 100644 --- a/udkapi/com/sun/star/bridge/oleautomation/NamedArgument.idl +++ b/udkapi/com/sun/star/bridge/oleautomation/NamedArgument.idl @@ -43,7 +43,7 @@ struct NamedArgument */ string Name; -/** The value of the argument whoose name is the one as contained in the +/** The value of the argument whose name is the one as contained in the member #Name. */ any Value; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: apple_remote/source
apple_remote/source/KeyspanFrontRowControl.m |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 79ed7a64f6f43dff1d0285d7d450300bc941c251 Author: Andrea Gelmini AuthorDate: Wed Apr 10 16:06:17 2019 + Commit: Julien Nabet CommitDate: Thu Apr 11 08:54:41 2019 +0200 Fix typo Change-Id: I1b5424df5b26cd18b6f28e48b8a1c3e4a3f1d0c8 Reviewed-on: https://gerrit.libreoffice.org/70576 Tested-by: Jenkins Reviewed-by: himajin10 Reviewed-by: Julien Nabet diff --git a/apple_remote/source/KeyspanFrontRowControl.m b/apple_remote/source/KeyspanFrontRowControl.m index ed0cd106869c..a337c497844f 100644 --- a/apple_remote/source/KeyspanFrontRowControl.m +++ b/apple_remote/source/KeyspanFrontRowControl.m @@ -45,7 +45,7 @@ [_cookieToButtonMapping setObject:[NSNumber numberWithInt:kRemoteButtonPlay] forKey:@"11_18_61_10_"]; [_cookieToButtonMapping setObject:[NSNumber numberWithInt:kRemoteButtonRight]forKey:@"11_18_96_10_"]; [_cookieToButtonMapping setObject:[NSNumber numberWithInt:kRemoteButtonLeft] forKey:@"11_18_97_10_"]; -/* hold events are not being send by this device +/* hold events are not being sent by this device [_cookieToButtonMapping setObject:[NSNumber numberWithInt:kRemoteButtonRight_Hold] forKey:@"14_6_4_2_"]; [_cookieToButtonMapping setObject:[NSNumber numberWithInt:kRemoteButtonLeft_Hold] forKey:@"14_6_3_2_"]; [_cookieToButtonMapping setObject:[NSNumber numberWithInt:kRemoteButtonMenu_Hold] forKey:@"14_6_14_6_"]; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1e755202656276edf2f07de1a0b6e2583d59349e
Author: Andrea Gelmini
AuthorDate: Wed Apr 10 16:06:13 2019 +
Commit: Julien Nabet
CommitDate: Thu Apr 11 08:55:07 2019 +0200
Fix typo
Change-Id: I9861cda038b6ab32aea44bc82dd0d1253a0679d4
Reviewed-on: https://gerrit.libreoffice.org/70579
Tested-by: Jenkins
Reviewed-by: himajin10
Reviewed-by: Julien Nabet
diff --git a/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx
b/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx
index c3787eb933c6..9f6cfc4dc738 100644
--- a/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx
+++ b/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx
@@ -35,7 +35,7 @@ ChartTypeUnoDlg::ChartTypeUnoDlg( const uno::Reference<
uno::XComponentContext >
}
ChartTypeUnoDlg::~ChartTypeUnoDlg()
{
-// we do this here cause the base class' call to destroyDialog won't reach
us anymore: we're within an dtor,
+// we do this here cause the base class' call to destroyDialog won't reach
us anymore: we're within a dtor,
// so this virtual-method-call the base class does not work, we're already
dead then...
if (m_aDialog)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk
compilerplugins/clang/sequentialassign.cxx | 331
compilerplugins/clang/test/sequentialassign.cxx | 95 ++
solenv/CompilerTest_compilerplugins_clang.mk|1
3 files changed, 427 insertions(+)
New commits:
commit b65f3fbb2beea99273371179703fcbc1d0ff326e
Author: Noel Grandin
AuthorDate: Wed Apr 10 18:38:10 2019 +0200
Commit: Noel Grandin
CommitDate: Thu Apr 11 08:52:49 2019 +0200
new loplugin sequentialassign
Look for places we are assigning to the same variable twice
in succession, which means we can simplify that to a single assign
Change-Id: I499d20e28f5595e81e927bef8e1bf364eea8ba91
Reviewed-on: https://gerrit.libreoffice.org/70531
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/sequentialassign.cxx
b/compilerplugins/clang/sequentialassign.cxx
new file mode 100644
index ..bc674694f8f1
--- /dev/null
+++ b/compilerplugins/clang/sequentialassign.cxx
@@ -0,0 +1,331 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+#include
+#include
+#include
+
+#include "plugin.hxx"
+#include "check.hxx"
+#include "clang/AST/CXXInheritance.h"
+#include "clang/AST/StmtVisitor.h"
+
+/**
+This is a kind of simplified dead-store analysis.
+
+We are looking for patterns like:
+ Foo x = a;
+ x = b;
+which can be simplified to
+x = b
+
+or
+Foo x = a;
+x = f(x)
+which can be simplified to
+Foo x = f(a)
+
+ TODO Improve this plugin to make it safer. We should really be checking the
following
+ conditions inside the RHS of the second statement:
+ If the variable is having it's address taken, or a non-const method
called on it,
+ on passed by non-const-ref.
+*/
+
+namespace
+{
+//static bool startswith(const std::string& rStr, const char* pSubStr) {
+//return rStr.compare(0, strlen(pSubStr), pSubStr) == 0;
+//}
+class SequentialAssign : public loplugin::FilteringPlugin
+{
+public:
+explicit SequentialAssign(loplugin::InstantiationData const& data)
+: FilteringPlugin(data)
+{
+}
+
+virtual void run() override
+{
+std::string fn(handler.getMainFileName());
+loplugin::normalizeDotDotInFilePath(fn);
+// places where the existing code style just looks better
+// TODO lots of these would be unnecessary if I taught the plugin
+// to ignore vars which are assigned to repeatedly
+if (fn == SRCDIR "/vcl/source/helper/commandinfoprovider.cxx"
+|| fn == SRCDIR "/basegfx/source/polygon/b2dpolygonclipper.cxx"
+|| fn == SRCDIR "/i18nlangtag/source/isolang/insys.cxx"
+|| fn == SRCDIR "/vcl/unx/generic/fontmanager/fontconfig.cxx"
+|| fn == SRCDIR "/svtools/source/filter/exportdialog.cxx"
+|| fn == SRCDIR "/svtools/source/control/ruler.cxx"
+|| fn == SRCDIR "/basic/qa/cppunit/test_scanner.cxx"
+|| fn == SRCDIR "/basic/source/uno/namecont.cxx"
+|| fn == SRCDIR "/test/source/sheet/xnamedrange.cxx"
+|| fn == SRCDIR "/i18npool/qa/cppunit/test_breakiterator.cxx"
+|| fn == SRCDIR "/i18npool/source/localedata/LocaleNode.cxx"
+|| fn == SRCDIR
"/i18npool/source/transliteration/transliteration_Ignore.cxx"
+|| fn == SRCDIR "/i18npool/qa/cppunit/test_textsearch.cxx"
+|| fn == SRCDIR "/framework/source/jobs/jobdata.cxx"
+|| fn == SRCDIR "/framework/source/services/pathsettings.cxx"
+|| fn == SRCDIR "/xmloff/source/chart/SchXMLTools.cxx"
+|| fn == SRCDIR "/svx/source/tbxctrls/Palette.cxx"
+|| fn == SRCDIR
"/svx/source/sdr/contact/objectcontactofpageview.cxx"
+|| fn == SRCDIR "/svx/source/form/fmservs.cxx"
+|| fn == SRCDIR "/svx/source/svdraw/svdograf.cxx"
+|| fn == SRCDIR "/svx/source/accessibility/AccessibleShape.cxx"
+|| fn == SRCDIR "/svx/source/fmcomp/fmgridcl.cxx"
+|| fn == SRCDIR "/chart2/source/tools/CharacterProperties.cxx"
+|| fn == SRCDIR "/svx/source/dialog/dialcontrol.cxx"
+|| fn == SRCDIR "/connectivity/source/commontools/TTableHelper.cxx"
+|| fn == SRCDIR "/svx/source/dialog/_bmpmask.cxx"
+|| fn == SRCDIR
"/media/noel/disk2/libo4/cui/source/dialogs/SignSignatureLineDialog.cxx"
+|| fn == SRCDIR "/filter/source/msfilter/msdffimp.cxx"
+|| fn == SRCDIR "/filter/source/flash/swffilter.cxx"
+|| fn == SRCDIR "/cui/source/dialogs/SignSignatureLineDialog.cxx"
+|| fn == SRCDIR
[Libreoffice-bugs] [Bug 112416] [META] XLSX pivot table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=112416 Bug 112416 depends on bug 124651, which changed state. Bug 124651 Summary: Pivot table: saving this ODS as XLSX produces a file that makes Excel warn and delete pivot table https://bugs.documentfoundation.org/show_bug.cgi?id=124651 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods |binary
sc/qa/unit/pivottable_filters_test.cxx | 15 +++
sc/source/filter/excel/xepivotxml.cxx |7 +--
3 files changed, 20 insertions(+), 2 deletions(-)
New commits:
commit 577b95f4d0cc1cf8836ff35fc30189c64fefb508
Author: Mike Kaganski
AuthorDate: Wed Apr 10 15:18:07 2019 +0300
Commit: Mike Kaganski
CommitDate: Thu Apr 11 08:26:18 2019 +0200
tdf#124651: always write "name" attribute to dataField element
Despite being optional as per ECMA-376-1:2016, Excel 2016 seems to
require the presence of "name" attribute in dataField element of
pivot table definition, so make sure to write at least empty string
there.
Change-Id: Iaab5674f86b7dd0b267776678e11af47086635d7
Reviewed-on: https://gerrit.libreoffice.org/70522
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods
b/sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods
new file mode 100644
index ..05fd5fec838f
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods
differ
diff --git a/sc/qa/unit/pivottable_filters_test.cxx
b/sc/qa/unit/pivottable_filters_test.cxx
index 739af618ec7d..d5b1afd64701 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -85,6 +85,7 @@ public:
void testTdf112106();
void testTdf123923();
void testTdf123939();
+void testTdf124651();
CPPUNIT_TEST_SUITE(ScPivotTableFiltersTest);
@@ -127,6 +128,7 @@ public:
CPPUNIT_TEST(testTdf112106);
CPPUNIT_TEST(testTdf123923);
CPPUNIT_TEST(testTdf123939);
+CPPUNIT_TEST(testTdf124651);
CPPUNIT_TEST_SUITE_END();
@@ -2430,6 +2432,19 @@ void ScPivotTableFiltersTest::testTdf123939()
"containsMixedTypes", "1");
}
+void ScPivotTableFiltersTest::testTdf124651()
+{
+ScDocShellRef xDocSh = loadDoc("tdf124651_simplePivotTable.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+
+xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory,
+"xl/pivotTables/pivotTable1.xml", FORMAT_XLSX);
+CPPUNIT_ASSERT(pDoc);
+// We have to export name attribute, even though it's optional according
to ECMA-376 standard,
+// because Excel (at least 2016) seems to require it.
+assertXPath(pDoc, "/x:pivotTableDefinition/x:dataFields/x:dataField",
"name", "");
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(ScPivotTableFiltersTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx
b/sc/source/filter/excel/xepivotxml.cxx
index 1a47e2cfeb5b..69c98d13c55b 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -947,9 +947,12 @@ void XclExpXmlPivotTables::SavePivotTableXml(
XclExpXmlStream& rStrm, const ScDP
assert(aCachedDims[nDimIdx]); // the loop above should have
screened for NULL's.
const ScDPSaveDimension& rDim = *rDataField.mpDim;
const boost::optional & pName = rDim.GetLayoutName();
+// tdf#124651: despite being optional in CT_DataField according to
ECMA-376 Part 1,
+// Excel (at least 2016) seems to insist on the presence of "name"
attribute in
+// dataField element, even if empty
+const OString sName = pName ? pName->toUtf8() : "";
pPivotStrm->write("<")->writeId(XML_dataField);
-if (pName)
-rStrm.WriteAttributes(XML_name, pName->toUtf8(), FSEND);
+rStrm.WriteAttributes(XML_name, sName, FSEND);
rStrm.WriteAttributes(XML_fld, OString::number(nDimIdx).getStr(),
FSEND);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/qa sc/qa sd/qa sw/qa test/source
chart2/qa/extras/chart2export.cxx |7 +--
sc/qa/unit/subsequent_export-test.cxx |8 +---
sd/qa/unit/export-tests-ooxml2.cxx|3 ++-
sw/qa/extras/ooxmlexport/ooxmlexport3.cxx | 18 --
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx | 10 +++---
sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |3 ++-
sw/qa/extras/ooxmlexport/ooxmlexport6.cxx |3 ++-
sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |2 +-
test/source/xmltesttools.cxx |3 +++
9 files changed, 39 insertions(+), 18 deletions(-)
New commits:
commit f315fee54eee57e6e55e5fcacf2522534682c2ce
Author: Mike Kaganski
AuthorDate: Wed Apr 10 15:18:07 2019 +0300
Commit: Mike Kaganski
CommitDate: Thu Apr 11 08:25:58 2019 +0200
XmlTestTools::getXPath now asserts that non-empty attribute exists
It turns out that this change revealed unit tests written incorrectly
(and untested), or maybe which became broken (not testing) because of
some previous assertXPath change? They incorrectly used 3-arg form of
it to check node content equality to passed string, while in fact, an
attribute was looked for with that name, and its empty return tested
to match default empty 4th argument.
Change-Id: If24e18518543102d115a22a6282e4cca9cf694e2
Reviewed-on: https://gerrit.libreoffice.org/70581
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index 6c769f0bbe63..b0cca5802f22 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -565,7 +565,10 @@ void Chart2ExportTest::testStockChart()
assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:plotArea/c:stockChart/c:ser[1]/c:idx", "val", "1");
assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:plotArea/c:stockChart/c:ser[1]/c:order", "val", "1");
-assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:plotArea/c:stockChart/c:ser[1]/c:tx/c:strRef/c:strCache/c:pt/c:v",
"Open");
+assertXPathContent(
+pXmlDoc,
+
"/c:chartSpace/c:chart/c:plotArea/c:stockChart/c:ser[1]/c:tx/c:strRef/c:strCache/c:pt/c:v",
+"Open");
}
void Chart2ExportTest::testBarChart()
@@ -721,7 +724,7 @@ void Chart2ExportTest::testDoughnutChart()
xmlDocPtr pXmlDoc = parseExport("word/charts/chart", "Office Open XML
Text");
CPPUNIT_ASSERT(pXmlDoc);
-assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:doughnutChart",
"1");
+assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:doughnutChart");
}
void Chart2ExportTest::testDisplayUnits()
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 76acc6b5c640..17158933ec34 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -717,10 +717,11 @@ void ScExportTest::testCommentExportXLSX()
= XPathHelper::parseExport(pXPathFile, m_xSFactory,
"xl/comments1.xml");
CPPUNIT_ASSERT(pComments);
-assertXPath(pComments, "/x:comments/x:authors/x:author[1]", "BAKO");
+assertXPathContent(pComments, "/x:comments/x:authors/x:author[1]", "BAKO");
assertXPath(pComments, "/x:comments/x:authors/x:author", 1);
-assertXPath(pComments,
"/x:comments/x:commentList/x:comment/x:text/x:r/x:t", "Komentarz");
+assertXPathContent(pComments,
"/x:comments/x:commentList/x:comment/x:text/x:r/x:t",
+ "Komentarz");
const xmlDocPtr pVmlDrawing
= XPathHelper::parseExport(pXPathFile, m_xSFactory,
"xl/drawings/vmlDrawing1.vml");
@@ -758,7 +759,8 @@ void ScExportTest::testCommentExportXLSX_2_XLSX()
= XPathHelper::parseExport(pXPathFile, m_xSFactory,
"xl/comments1.xml");
CPPUNIT_ASSERT(pComments);
-assertXPath(pComments,
"/x:comments/x:commentList/x:comment/x:text/x:r/x:t", "visible comment");
+assertXPathContent(pComments,
"/x:comments/x:commentList/x:comment/x:text/x:r/x:t",
+ "visible comment");
const xmlDocPtr pVmlDrawing
= XPathHelper::parseExport(pXPathFile, m_xSFactory,
"xl/drawings/vmlDrawing1.vml");
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx
b/sd/qa/unit/export-tests-ooxml2.cxx
index 91929569f204..5b8f77f9a744 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -1374,7 +1374,8 @@ void SdOOXMLExportTest2::testSmartartRotation2()
xDocShRef->DoClose();
xmlDocPtr pXmlDocContent = parseExport(tempFile, "ppt/slides/slide1.xml");
-assertXPath(pXmlDocContent,
"/p:sld/p:cSld/p:spTree/p:grpSp/p:sp[3]/p:txBody/a:p/a:r/a:t", "Text");
+assertXPathContent(pXmlDocContent,
+
"/p:sld/p:cSld/p:spTree/p:grpSp/p:sp[3]/p:txBody/a:p/a:r/a:t", "Text");
assertXPath(pXmlDocContent,
"/p:sld/p:cSld/p:spTree/p:grpSp/p:sp[3]/p:txBody/a:bodyPr", "rot", "1080");
double dX = getXPath(pXmlDocContent,
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sfx2/source
sfx2/source/doc/docfile.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 237169136883a5b312fadcec4c73aa183076828c
Author: Mike Kaganski
AuthorDate: Tue Dec 18 02:51:31 2018 +0100
Commit: Aron Budea
CommitDate: Thu Apr 11 08:13:07 2019 +0200
tdf#116320: properly decode file name for File Locked dialog
Change-Id: I51bd7c6695ef52b08e0b6d809160d74daebb8505
Reviewed-on: https://gerrit.libreoffice.org/65298
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 8dc3fe631583228fe5bb49b44d2308470ec30df0)
Reviewed-on: https://gerrit.libreoffice.org/70583
Tested-by: Aron Budea
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 8b403e446952..f198cb6b085a 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -885,7 +885,8 @@ SfxMedium::ShowLockResult
SfxMedium::ShowLockedDocumentDialog(const OUString& aD
if ( xHandler.is() && ( bIsLoading || !bHandleSysLocked || bOwnLock ) )
{
-OUString aDocumentURL = GetURLObject().GetLastName();
+OUString aDocumentURL
+=
GetURLObject().GetLastName(INetURLObject::DecodeMechanism::WithCharset);
OUString aInfo;
::rtl::Reference< ::ucbhelper::InteractionRequest >
xInteractionRequestImpl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
