[Libreoffice-commits] core.git: external/redland

[Stephan Bergmann (via logerrit)]

 external/redland/redland/redland-msvc.patch.1 |1 -
 1 file changed, 1 deletion(-)

New commits:
commit c443979549dfff4a5a02b62e7037c7805e13e2cb
Author: Stephan Bergmann 
AuthorDate: Mon Apr 29 10:34:31 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 29 12:37:59 2019 +0200

Remove spurious non-empty line from end of patch file

(had caused a "patch unexpectedly ends in middle of line" warning)

Change-Id: I10860a25266d1672f1fdd0ce89f3de37b260a5fb
Reviewed-on: https://gerrit.libreoffice.org/71509
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/redland/redland/redland-msvc.patch.1 
b/external/redland/redland/redland-msvc.patch.1
index 1cdc6cf48775..e1f96b42a292 100644
--- a/external/redland/redland/redland-msvc.patch.1
+++ b/external/redland/redland/redland-msvc.patch.1
@@ -121,4 +121,3 @@
  #endif
  
  /* for gettimeofday */
- 
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - icon-themes/colibre sw/uiconfig

[andreas kainz (via logerrit)]

 icon-themes/colibre/links.txt|1 
 sw/uiconfig/swriter/ui/notebookbar_single.ui | 8653 ---
 2 files changed, 7809 insertions(+), 845 deletions(-)

New commits:
commit 0d47abc53d6a20b7bdab7939137be89fb422020c
Author: andreas kainz 
AuthorDate: Mon Apr 29 01:24:03 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 29 08:42:34 2019 +0200

NB: update contextual single NB in writer

Change-Id: I742881a631bbf60b8b2808554304ba6f75bb8151
Reviewed-on: https://gerrit.libreoffice.org/71501
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_single.ui 
b/sw/uiconfig/swriter/ui/notebookbar_single.ui
index a7b655ac5ce3..c6a71650067f 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_single.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_single.ui
@@ -1,296 +1,47 @@
 
-
+
 
   
   
-  
   
 True
 False
 
-  
+  
 True
 False
-center
-center
-True
 vertical
 
-  
+  
 True
 False
-center
-6
-6
-3
 
-  
-True
-True
-False
-
-  
-True
-False
-True
-.uno:Open
-True
-  
-  
-False
-True
-  
-
-
-  
-True
-False
-True
-.uno:Save
-True
-  
-  
-False
-True
-  
-
-
-  
-True
-False
-True
-.uno:Print
-True
-  
-  
-False
-True
-  
-
-  
-  
-False
-True
-0
-  
-
-
-  
-18
-True
-False
-center
-vertical
-  
-  
-False
-True
-1
-  
-
-
-  
-True
-True
-False
-
-  
-True
-False
-True
-.uno:Undo
-True
-  
-  
-False
-True
-  
-
-
-  
-True
-False
-True
-.uno:Redo
-True
-  
-  
-False
-True
-  
-
-  
-  
-False
-True
-2
-  
-
-
-  
-18
-True
-False
-center
-vertical
-  
-  
-False
-True
-3
-  
-
-
-  
-True
-True
-False
-
-  
-True
-False
-True
-.uno:SearchDialog
-True
-  
-  
-False
-True
-  
-
-
-  
-False
-.uno:SpellingAndGrammarDialog
-True
-  
-  
-False
-True
-  
-
-
-  
-False
-.uno:ControlCodes
-True
-  
-  
-False
-True
-  
-
-
-  
-True
-False
-.uno:TrackChanges
-True
-  
-  
-False
-True
-  
-
-  
-  
-False
-True
-  

alg license statement

[Armin Le Grand]

All of my past & future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license.

--
ALG (PGP: EE1C 4B3F E751 D8BC C485 DEC1 3C59 F953 D81C F4A2)___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: oox/source sw/qa

[Miklos Vajna (via logerrit)]

 oox/source/drawingml/shape.cxx   |5 -
 oox/source/shape/WpgContext.cxx  |6 +-
 sw/qa/extras/ooxmlimport/data/tdf124398.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx|   12 
 4 files changed, 21 insertions(+), 2 deletions(-)

New commits:
commit fdf4aaa3dc5cc1d2e7a112e6c32d7845f13caef8
Author: Miklos Vajna 
AuthorDate: Mon Apr 29 08:35:29 2019 +0200
Commit: Miklos Vajna 
CommitDate: Mon Apr 29 09:57:04 2019 +0200

tdf#124398 DOCX drawingML import: handle charts in group shapes

Regression from commit 8c73b16f5f18f3bc1dbf9ff6c1475db56b44d304 (DOCX
import: declare wpg as a supported feature, 2013-12-05), the problem was
that  did not forward to to the relevant oox context,
and also Writer had no idea how to create a
com.sun.star.drawing.OLE2Shape. Fix the later by using the same service
name that's in use for the non-groupshape case.

Change-Id: Id3536854da7c1f01525bb38d801496ecebd4c161
Reviewed-on: https://gerrit.libreoffice.org/71505
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 3c84428389a5..41c8d9493dcf 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -220,7 +220,10 @@ ChartShapeInfo& Shape::setChartType( bool bEmbedShapes )
 {
 OSL_ENSURE( meFrameType == FRAMETYPE_GENERIC, "Shape::setChartType - 
multiple frame types" );
 meFrameType = FRAMETYPE_CHART;
-msServiceName = "com.sun.star.drawing.OLE2Shape";
+if (mbWps)
+msServiceName = "com.sun.star.drawing.temporaryForXMLImportOLE2Shape";
+else
+msServiceName = "com.sun.star.drawing.OLE2Shape";
 mxChartShapeInfo.reset( new ChartShapeInfo( bEmbedShapes ) );
 return *mxChartShapeInfo;
 }
diff --git a/oox/source/shape/WpgContext.cxx b/oox/source/shape/WpgContext.cxx
index c297ff16d822..33fb318e73e8 100644
--- a/oox/source/shape/WpgContext.cxx
+++ b/oox/source/shape/WpgContext.cxx
@@ -61,7 +61,11 @@ oox::core::ContextHandlerRef 
WpgContext::onCreateContext(sal_Int32 nElementToken
 return new oox::drawingml::ShapeGroupContext(*this, mpShape, 
std::make_shared("com.sun.star.drawing.GroupShape"));
 }
 case XML_graphicFrame:
-break;
+{
+auto pShape = 
std::make_shared("com.sun.star.drawing.GraphicObjectShape");
+pShape->setWps(true);
+return new oox::drawingml::GraphicalObjectFrameContext(*this, mpShape, 
pShape, /*bEmbedShapesInChart=*/true);
+}
 default:
 SAL_WARN("oox", "WpgContext::createFastChildContext: unhandled 
element: " << getBaseToken(nElementToken));
 break;
diff --git a/sw/qa/extras/ooxmlimport/data/tdf124398.docx 
b/sw/qa/extras/ooxmlimport/data/tdf124398.docx
new file mode 100644
index ..4d1855347fd6
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf124398.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index 3df3f1adf8db..fcd6d8d34d91 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -217,6 +217,18 @@ DECLARE_OOXMLIMPORT_TEST(testTdf112443, "tdf112443.docx")
 // and as result only one page should be generated.
 DECLARE_OOXMLIMPORT_TEST(testTdf113182, "tdf113182.docx") { 
CPPUNIT_ASSERT_EQUAL(1, getPages()); }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf124398, "tdf124398.docx")
+{
+uno::Reference xGroup(getShape(1), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xGroup.is());
+// Without the accompanying fix in place, this test would have failed with 
'Expected: 2; Actual:
+// 1', i.e. the chart children of the group shape was lost.
+CPPUNIT_ASSERT_EQUAL(static_cast(2), xGroup->getCount());
+
+uno::Reference xShape(xGroup->getByIndex(1), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("com.sun.star.drawing.OLE2Shape"), 
xShape->getShapeType());
+}
+
 DECLARE_OOXMLIMPORT_TEST(testTdf113946, "tdf113946.docx")
 {
 OUString aTop = 
parseDump("/root/page/body/txt/anchored/SwAnchoredDrawObject/bounds", "top");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sd/uiconfig

[Muhammet Kara (via logerrit)]

 sd/uiconfig/simpress/menubar/menubar.xml |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 06cebd57c89b4612fad31cbd9a5fd9a231eaf71d
Author: Muhammet Kara 
AuthorDate: Mon Apr 29 11:13:58 2019 +0300
Commit: Andras Timar 
CommitDate: Mon Apr 29 10:23:54 2019 +0200

Add RedactDoc to Tools menu of Impress

Now that we have redaction enabled for Impress,
after commit 33e840896a69a66c44e74beb995d558735fb84ad,
let's sync the Impress Tools menu with Writer and Calc.

Cherry-picked from commit f1c27ccc7ece38cc5395c14d01d634fd4bb77c11

Change-Id: I1af03f6aa2043a70779a3b783045c69adc8641a3
Reviewed-on: https://gerrit.libreoffice.org/71508
Reviewed-by: Muhammet Kara 
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sd/uiconfig/simpress/menubar/menubar.xml 
b/sd/uiconfig/simpress/menubar/menubar.xml
index 656843353af8..ebacfd20cd8e 100644
--- a/sd/uiconfig/simpress/menubar/menubar.xml
+++ b/sd/uiconfig/simpress/menubar/menubar.xml
@@ -572,6 +572,7 @@
 
 
 
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/filter/graphicfilter.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 3b69a91bf7b3ccf665c55373121f78f921408009
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 11:52:11 2019 +0100
Commit: Michael Stahl 
CommitDate: Mon Apr 29 11:47:04 2019 +0200

ofz#14469 null deref

since...

commit af84fc9d906626255aaf136eefc5e55236e0e8a6
Date:   Tue Apr 23 15:48:41 2019 +0200

lazy image loading shouldn't read the entire .xls file (tdf#124828)

nLength is just an unchecked value in the dff stream, it might not be sane
so limit it to the max len of the stream

Change-Id: Ia8a2830478952afe1317b5cd795f35059d9b380a
Reviewed-on: https://gerrit.libreoffice.org/71414
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/vcl/source/filter/graphicfilter.cxx 
b/vcl/source/filter/graphicfilter.cxx
index cad4d4ae1fd5..654393238eba 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -1454,7 +1454,9 @@ Graphic GraphicFilter::ImportUnloadedGraphic(SvStream& 
rIStream, sal_uInt64 size
 ErrCode nStatus = ImpTestOrFindFormat("", rIStream, nFormat);
 
 rIStream.Seek(nStreamBegin);
-const sal_uInt32 nStreamLength( sizeLimit ? sizeLimit : 
rIStream.Seek(STREAM_SEEK_TO_END) - nStreamBegin);
+sal_uInt32 nStreamLength(rIStream.remainingSize());
+if (sizeLimit && sizeLimit < nStreamLength)
+nStreamLength = sizeLimit;
 
 OUString aFilterName = pConfig->GetImportFilterName(nFormat);
 OUString aExternalFilterName = pConfig->GetExternalFilterName(nFormat, 
false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/win

[Miklos Vajna (via logerrit)]

 vcl/win/gdi/winlayout.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b97495c5ea1bb6dd6504609d4951ce70b3d5be89
Author: Miklos Vajna 
AuthorDate: Thu Apr 18 18:03:36 2019 +0200
Commit: Luboš Luňák 
CommitDate: Mon Apr 29 11:46:58 2019 +0200

tdf#113076 vcl windows opengl: specific italic set font was clipped on ...

... right edge in presentation mode.

This seems to be a problem since commit
a51b7a1c3a7e7cf7b0c733e1dec40288278c1884 (tdf#103831, tdf#100986: Force
using GDI when needed, 2017-03-03), which blacklisted DirectWrite in the
OpenGL case for both vertical text and horizontally stretched text.

I tested that the overlapping characters problem from tdf#103831 is not
re-introduced, and switching to DW (in the horizontal stretching &&
OpenGL case) fixes the unwanted clipping of glyphs for the tdf#113076
bugdoc.

This also simplifies the situation, since the general rule since commit
d436065bc1c68fc2d90e73253d8c00503c72dfd0 (tdf#103725: Default to GDI
even with the new layout engine, 2016-11-15) is that non-OpenGL defaults
to GDI rendering and OpenGL defaults to DirectWrite rendering.

(cherry picked from commit 4657335fa5bcbe7980f229ca41ddd82d93c355eb)

Change-Id: I44d035ab0890614be393599a5492e42e09231d86
Reviewed-on: https://gerrit.libreoffice.org/71288
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index 91e82e8ba40e..3aa8133be598 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -465,12 +465,12 @@ void WinSalGraphics::DrawTextLayout(const 
GenericSalLayout& rLayout)
 
 const WinFontInstance* pWinFont = static_cast(());
 const HFONT hLayoutFont = pWinFont->GetHFONT();
+bool bUseOpenGL = OpenGLHelper::isVCLOpenGLEnabled() && !mbPrinter;
 
 // Our DirectWrite renderer is incomplete, skip it for non-horizontal or
 // stretched text.
-bool bForceGDI = rLayout.GetOrientation() || pWinFont->hasHScale();
+bool bForceGDI = rLayout.GetOrientation() || (pWinFont->hasHScale() && 
!bUseOpenGL);
 
-bool bUseOpenGL = OpenGLHelper::isVCLOpenGLEnabled() && !mbPrinter;
 if (!bUseOpenGL)
 {
 // no OpenGL, just classic rendering
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 8eb4ad0529c5efedf95c7220b6b8b9aad63e3ea4
Author: Caolán McNamara 
AuthorDate: Fri Apr 26 21:39:09 2019 +0100
Commit: Caolán McNamara 
CommitDate: Mon Apr 29 13:11:35 2019 +0200

Resolves: tdf#124980 drop dangling timer

Change-Id: I05ec394ee83f0422ecccf3ae3377818af6feb1d1
Reviewed-on: https://gerrit.libreoffice.org/71398
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 9207516888e73398599a9890af78cd677ddd0992)
Reviewed-on: https://gerrit.libreoffice.org/71411
Reviewed-by: Michael Stahl 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 18d897cbba4b..caec6ba5ac6c 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -7505,6 +7505,8 @@ public:
 
 virtual ~GtkInstanceEntryTreeView() override
 {
+if (m_nAutoCompleteIdleId)
+g_source_remove(m_nAutoCompleteIdleId);
 GtkWidget* pWidget = m_pEntry->getWidget();
 g_signal_handler_disconnect(pWidget, m_nKeyPressSignalId);
 g_signal_handler_disconnect(pWidget, m_nEntryInsertTextSignalId);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: ucb/source

[Stephan Bergmann (via logerrit)]

 ucb/source/ucp/gio/gio_content.cxx |   52 -
 ucb/source/ucp/gio/gio_content.hxx |9 ++
 2 files changed, 38 insertions(+), 23 deletions(-)

New commits:
commit 6d3dd64391e67e6cfe406dea047e13227ea94c4b
Author: Stephan Bergmann 
AuthorDate: Mon Apr 29 11:45:46 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 29 13:46:42 2019 +0200

tdf#123472: Propagate getGFileInfo failure less aggressively

...from Content::getPropertyValues.  
ca0308797df86ebece19260f3ca438a0cb437208
"tdf#121337: Fail on GIO error in GIO UCP getPropertyValue" had made
Content::getPropertyValues fail for every getGFileInfo failure.  However, 
when
saving to a not-yet exisiting file, SfxMedium::Transfer_Impl
(sfx2/source/doc/docfile.cxx) requests the properties "Title" and "ObjectId"
from the Content representing the not-yet existing file, and apparently 
expects
those requests not to fail.  So restructure Content::getPropertyValues to 
only
call getGFileInfo when actually needed (that covers not failing for the 
unknown-
anyway "ObjecdtId" property), and handle "Title" specially by not failing 
for
a non-existing file.  (The documentation at 
offapi/com/sun/star/ucb/Content.idl
says for the "getPropertyValues" command that: "The execution will not be
aborted, if there are properties requested, that are unknown to the 
content."
But that leaves it somewhat unclear whether failure to obtain a known 
property
should be propagated.  It apparently should be in the context of tfd#121337
fixed previously, but apparently not for "Title" here.)

Change-Id: I12a9a5bd93d661922ea3b7b19a84a7e73e7e4b50
Reviewed-on: https://gerrit.libreoffice.org/71515
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/ucb/source/ucp/gio/gio_content.cxx 
b/ucb/source/ucp/gio/gio_content.cxx
index d3a910c02c4a..e3f2c0cb0222 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -432,12 +432,11 @@ static util::DateTime getDateFromUnix (time_t t)
 return util::DateTime();
 }
 
-uno::Reference< sdbc::XRow > Content::getPropertyValuesFromGFileInfo(GFileInfo 
*pInfo,
-const uno::Reference< uno::XComponentContext >& rxContext,
-const uno::Reference< ucb::XCommandEnvironment > & xEnv,
-const uno::Sequence< beans::Property >& rProperties)
+uno::Reference< sdbc::XRow > Content::getPropertyValues(
+const uno::Sequence< beans::Property >& rProperties,
+const uno::Reference< ucb::XCommandEnvironment >& xEnv )
 {
-rtl::Reference< ::ucbhelper::PropertyValueSet > xRow = new 
::ucbhelper::PropertyValueSet( rxContext );
+rtl::Reference< ::ucbhelper::PropertyValueSet > xRow = new 
::ucbhelper::PropertyValueSet( m_xContext );
 
 sal_Int32 nProps;
 const beans::Property* pProps;
@@ -445,12 +444,14 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 nProps = rProperties.getLength();
 pProps = rProperties.getConstArray();
 
+GFileInfo *pInfo = nullptr;
 for( sal_Int32 n = 0; n < nProps; ++n )
 {
 const beans::Property& rProp = pProps[ n ];
 
 if ( rProp.Name == "IsDocument" )
 {
+getFileInfo(xEnv, , true);
 if (pInfo != nullptr && g_file_info_has_attribute(pInfo, 
G_FILE_ATTRIBUTE_STANDARD_TYPE))
 xRow->appendBoolean( rProp, ( g_file_info_get_file_type( pInfo 
) == G_FILE_TYPE_REGULAR ||
g_file_info_get_file_type( 
pInfo ) == G_FILE_TYPE_UNKNOWN ) );
@@ -459,6 +460,7 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 }
 else if ( rProp.Name == "IsFolder" )
 {
+getFileInfo(xEnv, , true);
 if (pInfo != nullptr && g_file_info_has_attribute( pInfo, 
G_FILE_ATTRIBUTE_STANDARD_TYPE) )
 xRow->appendBoolean( rProp, ( g_file_info_get_file_type( pInfo 
) == G_FILE_TYPE_DIRECTORY ));
 else
@@ -466,6 +468,7 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 }
 else if ( rProp.Name == "Title" )
 {
+getFileInfo(xEnv, , false);
 if (pInfo != nullptr && g_file_info_has_attribute(pInfo, 
G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME))
 {
 const char *pName = g_file_info_get_display_name(pInfo);
@@ -476,6 +479,7 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 }
 else if ( rProp.Name == "IsReadOnly" )
 {
+getFileInfo(xEnv, , true);
 if (pInfo != nullptr && g_file_info_has_attribute( pInfo, 
G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE ) )
 xRow->appendBoolean( rProp, 
!g_file_info_get_attribute_boolean( pInfo, G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE) );
 else
@@ -483,6 +487,7 @@ 

Re: Regarding Exporting in Libreoffice

[Miklos Vajna]

Hi,

On Fri, Apr 26, 2019 at 01:37:56PM -0700, Coffee Champagne 
 wrote:
> I was wondering if you could help me understand how the exporting works in
> libreoffice? Thank you.

Please ask such questions on the public dev list, not in private.

There is some (somewhat outdated) overview here:

https://wiki.openoffice.org/wiki/Export_filter_framework

Do you have any specific question?

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/qa

[Caolán McNamara (via logerrit)]

 vcl/qa/cppunit/complextext.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 01806eb7b96a79e3265e6ef8172e427226884574
Author: Caolán McNamara 
AuthorDate: Thu Apr 25 11:06:35 2019 +0100
Commit: Michael Stahl 
CommitDate: Mon Apr 29 11:50:50 2019 +0200

test unreliable under windows

Change-Id: I1f46c6043b3263ef983991ffa4aa0418006d55a7
Reviewed-on: https://gerrit.libreoffice.org/71292
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 3e898d3ce8f12c6f4b4f3a8202812fe8871e0a7f)
Reviewed-on: https://gerrit.libreoffice.org/71419
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index 96332585673b..0ff5234a2ff5 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -92,11 +92,11 @@ void VclComplexTextTest::testArabic()
 // this sporadically returns 75 or 74 on some of the windows tinderboxes 
eg. tb73
 CPPUNIT_ASSERT_EQUAL(72L, nTextWidth);
 CPPUNIT_ASSERT_EQUAL(nTextWidth, aCharWidths.back());
-#endif
 
 // text advance width and line height
 CPPUNIT_ASSERT_EQUAL(72L, pOutDev->GetTextWidth(aOneTwoThree));
 CPPUNIT_ASSERT_EQUAL(14L, pOutDev->GetTextHeight());
+#endif
 
 // exact bounding rectangle, not essentially the same as text width/height
 #if defined(MACOSX) || defined(_WIN32)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[László Németh (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf123460.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx|   14 +++---
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx|   20 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   17 +
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |4 +++-
 5 files changed, 47 insertions(+), 8 deletions(-)

New commits:
commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be
Author: László Németh 
AuthorDate: Fri Apr 26 17:24:38 2019 +0200
Commit: László Németh 
CommitDate: Mon Apr 29 12:14:54 2019 +0200

tdf#123460 DOCX track changes: moveFrom completely

also with the paragraph mark, not leaving an empty
paragraph at the original place of the moved text.

Note: as desktop version of MSO does, but its
online version leaves empty paragraphs interestingly.

Change-Id: I03dda8997df3efbc82e936bd31a3813323e6b5ab
Reviewed-on: https://gerrit.libreoffice.org/71382
Reviewed-by: László Németh 
Tested-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf123460.docx 
b/sw/qa/extras/ooxmlexport/data/tdf123460.docx
new file mode 100644
index ..c3b723b4e5ad
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf123460.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index 7d9b392f635b..52068e385454 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -796,13 +796,13 @@ DECLARE_OOXMLIMPORT_TEST(testTdf104797, "tdf104797.docx")
 CPPUNIT_ASSERT_EQUAL(true,getProperty(getRun(getParagraph(1), 2), 
"IsStart"));
 CPPUNIT_ASSERT_EQUAL( OUString( "This is a filler sentence. Will this 
sentence be duplicated ADDED STUFF?" ),
 getParagraph( 2 )->getString());
-CPPUNIT_ASSERT_EQUAL( OUString( "This is a filler sentence." ), getRun( 
getParagraph( 2 ), 1 )->getString());
-CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 2 
)->getString());
-CPPUNIT_ASSERT_EQUAL( OUString( " Will this sentence be duplicated ADDED 
STUFF?" ), getRun( getParagraph( 2 ), 3 )->getString());
-CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 4 
)->getString());
-CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(2), 5), "RedlineType"));
-
CPPUNIT_ASSERT_EQUAL(OUString("Insert"),getProperty(getRun(getParagraph(2),
 5), "RedlineType"));
-CPPUNIT_ASSERT_EQUAL(false,getProperty(getRun(getParagraph(2), 5), 
"IsStart"));
+CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 1 
)->getString());
+CPPUNIT_ASSERT_EQUAL( OUString( "This is a filler sentence." ), getRun( 
getParagraph( 2 ), 2 )->getString());
+CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 3 
)->getString());
+CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(2), 3), "RedlineType"));
+
CPPUNIT_ASSERT_EQUAL(OUString("Insert"),getProperty(getRun(getParagraph(2),
 3), "RedlineType"));
+CPPUNIT_ASSERT_EQUAL(true,getProperty(getRun(getParagraph(2), 3), 
"IsStart"));
+CPPUNIT_ASSERT_EQUAL( OUString( " Will this sentence be duplicated ADDED 
STUFF?" ), getRun( getParagraph( 2 ), 4 )->getString());
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTdf113608_runAwayNumbering, 
"tdf113608_runAwayNumbering.docx")
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index c3aacdcc6b42..4448275021bf 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -239,6 +239,26 @@ DECLARE_OOXMLEXPORT_TEST(testTextInput, "textinput.odt")
 assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[5]/w:t", 
"SomeText");
 }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf123460, "tdf123460.docx")
+{
+// check paragraph mark deletion at terminating moveFrom
+CPPUNIT_ASSERT_EQUAL(true,getParagraph( 2 
)->getString().startsWith("Nunc"));
+CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 1 
)->getString());
+CPPUNIT_ASSERT(hasProperty(getRun(getParagraph(2), 1), "RedlineType"));
+
CPPUNIT_ASSERT_EQUAL(OUString("Delete"),getProperty(getRun(getParagraph(2),
 1), "RedlineType"));
+CPPUNIT_ASSERT_EQUAL(true, getRun( getParagraph( 2 ), 2 
)->getString().endsWith("tellus."));
+CPPUNIT_ASSERT_EQUAL( OUString( "" ), getRun( getParagraph( 2 ), 3 
)->getString());
+bool bCaught = false;
+try
+{
+getRun( getParagraph( 2 ), 4 );
+}
+catch (container::NoSuchElementException&)
+{
+bCaught = true;
+}
+CPPUNIT_ASSERT_EQUAL(true, bCaught);
+}
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 961a88872bff..d3daa6f9f908 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1690,6 +1690,11 @@ void 

[Libreoffice-commits] core.git: include/comphelper

[Mike Kaganski (via logerrit)]

 include/comphelper/scopeguard.hxx |   28 
 1 file changed, 28 insertions(+)

New commits:
commit f24e50c90fb802cba0a9d77ecb0f105ea4516ebb
Author: Mike Kaganski 
AuthorDate: Mon Apr 29 11:36:51 2019 +0300
Commit: Mike Kaganski 
CommitDate: Mon Apr 29 12:22:51 2019 +0200

Fix Android build after commit ac419786b3244d909901db053841862abf5e7a2f

... giving this error:

   In file included from
   
/home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:50:
   
/home/android/lo/master-android-arm/include/comphelper/scopeguard.hxx:36:14:
   error: function 'comphelper::<(lambda at
   
/home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:146:34)>'
   has internal linkage but is not defined [-Werror,-Wundefined-internal]
   explicit ScopeGuard( Func && func ) : m_func( std::move(func) ) {}
^
   
/home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:146:28:
   note: used here
   comphelper::ScopeGuard guard([&]() {
  ^

See 
https://lists.freedesktop.org/archives/libreoffice/2019-April/082599.html

Change-Id: If719d183d2ce15fa4877cd8bbf457d79097765be
Reviewed-on: https://gerrit.libreoffice.org/71510
Reviewed-by: Miklos Vajna 
Tested-by: Mike Kaganski 

diff --git a/include/comphelper/scopeguard.hxx 
b/include/comphelper/scopeguard.hxx
index 60836a7661c7..6b5b397686f4 100644
--- a/include/comphelper/scopeguard.hxx
+++ b/include/comphelper/scopeguard.hxx
@@ -24,6 +24,28 @@
 #include 
 #include 
 
+
+// For some reason, Android buildbot issues -Werror like this:
+//   In file included from
+//   
/home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:50:
+//   
/home/android/lo/master-android-arm/include/comphelper/scopeguard.hxx:36:14:
+//   error: function 'comphelper::<(lambda at
+//   
/home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:146:34)>'
+//   has internal linkage but is not defined [-Werror,-Wundefined-internal]
+//   explicit ScopeGuard( Func && func ) : m_func( std::move(func) ) {}
+//^
+//   
/home/android/lo/master-android-arm/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx:146:28:
+//   note: used here
+//   comphelper::ScopeGuard guard([&]() {
+//  ^
+#ifdef ANDROID
+#if defined __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wundefined-internal"
+#endif
+#endif
+
+
 namespace comphelper {
 
 /** ScopeGuard to ease writing exception-safe code.
@@ -69,6 +91,12 @@ private:
 
 } // namespace comphelper
 
+#ifdef ANDROID
+#if defined __clang__
+#pragma clang diagnostic pop
+#endif
+#endif
+
 #endif // ! defined(INCLUDED_COMPHELPER_SCOPEGUARD_HXX)
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: hwpfilter/source soltools/mkdepend

[Julien Nabet (via logerrit)]

 hwpfilter/source/hstyle.cxx |2 +-
 soltools/mkdepend/include.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7cf3574ac9208e70c03eeaca2def0235ec90f55f
Author: Julien Nabet 
AuthorDate: Sun Apr 28 16:03:10 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 29 09:11:26 2019 +0200

Avoid -Werror=format/stringop-truncation

It also affects gcc 8.3

Change-Id: I896e84d5e1e96abfe81294e921cfcc060e44fb6f
Reviewed-on: https://gerrit.libreoffice.org/71474
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/hwpfilter/source/hstyle.cxx b/hwpfilter/source/hstyle.cxx
index 87fd1efbe978..1848067f14df 100644
--- a/hwpfilter/source/hstyle.cxx
+++ b/hwpfilter/source/hstyle.cxx
@@ -67,7 +67,7 @@ void HWPStyle::SetName(int n, char const *name)
 {
 if (name)
 {
-#if defined __GNUC__ && __GNUC__ == 8 && __GNUC_MINOR__ == 2 && !defined 
__clang__
+#if defined __GNUC__ && __GNUC__ == 8 && (__GNUC_MINOR__ == 2 || 
__GNUC_MINOR__ == 3) && !defined __clang__
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wstringop-truncation"
 #endif
diff --git a/soltools/mkdepend/include.c b/soltools/mkdepend/include.c
index 4af7c47248e5..27f20f40fb98 100644
--- a/soltools/mkdepend/include.c
+++ b/soltools/mkdepend/include.c
@@ -243,7 +243,7 @@ int issymbolic(char *dir, char *component)
 struct stat st;
 charbuf[ BUFSIZ ], **pp;
 
-#if defined __GNUC__ && __GNUC__ == 8 && __GNUC_MINOR__ == 2 && !defined 
__clang__
+#if defined __GNUC__ && __GNUC__ == 8 && (__GNUC_MINOR__ == 2 || 
__GNUC_MINOR__ == 3) && !defined __clang__
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wformat-truncation"
 // silence "‘snprintf’ output may be truncated before the last format 
character"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source filter/source include/svx reportdesign/source sd/source solenv/clang-format svx/source sw/source

[Gabor Kelemen (via logerrit)]

 cui/source/dialogs/cuiimapwnd.cxx  |1 
 cui/source/inc/cuitabarea.hxx  |1 
 cui/source/tabpages/backgrnd.cxx   |1 
 cui/source/tabpages/tparea.cxx |4 ++
 cui/source/tabpages/tpbitmap.cxx   |1 
 cui/source/tabpages/tpcolor.cxx|1 
 cui/source/tabpages/tpgradnt.cxx   |1 
 cui/source/tabpages/tphatch.cxx|2 +
 cui/source/tabpages/tppattern.cxx  |1 
 cui/source/tabpages/tpshadow.cxx   |4 ++
 cui/source/tabpages/tptrans.cxx|5 ++
 filter/source/msfilter/msdffimp.cxx|4 ++
 filter/source/msfilter/svdfppt.cxx |2 +
 include/svx/xattr.hxx  |1 
 include/svx/xfillit.hxx|   42 -
 reportdesign/source/ui/report/ReportController.cxx |7 +++
 sd/source/ui/sidebar/SlideBackground.cxx   |1 
 sd/source/ui/view/sdview4.cxx  |2 -
 solenv/clang-format/blacklist  |1 
 svx/source/dialog/contwnd.cxx  |2 -
 svx/source/dialog/imapwnd.cxx  |2 -
 svx/source/engine3d/obj3d.cxx  |1 
 svx/source/tbxctrls/colrctrl.cxx   |1 
 svx/source/tbxctrls/fillctrl.cxx   |4 ++
 svx/source/xoutdev/xattr.cxx   |6 +++
 svx/source/xoutdev/xattrbmp.cxx|1 
 svx/source/xoutdev/xpool.cxx   |6 +++
 sw/source/core/frmedt/fecopy.cxx   |2 -
 sw/source/core/frmedt/feshview.cxx |1 
 sw/source/filter/html/htmldrawreader.cxx   |2 -
 sw/source/filter/html/htmldrawwriter.cxx   |2 -
 sw/source/filter/ww8/ww8graf.cxx   |3 +
 sw/source/uibase/sidebar/PageStylesPanel.cxx   |4 ++
 sw/source/uibase/sidebar/PageStylesPanel.hxx   |1 
 sw/source/uibase/uiview/viewtab.cxx|5 ++
 35 files changed, 67 insertions(+), 58 deletions(-)

New commits:
commit 7722ffd1f50ee431dfc501c4f0fecd40eb9046d3
Author: Gabor Kelemen 
AuthorDate: Fri Apr 26 01:59:08 2019 +0200
Commit: Miklos Vajna 
CommitDate: Mon Apr 29 10:11:13 2019 +0200

tdf#62699 Drop pass-through header file include/svx/xfillit.hxx

Change-Id: I6598d81b166486f3c48b119cc136b9f6e6c2a12c
Reviewed-on: https://gerrit.libreoffice.org/71336
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/cui/source/dialogs/cuiimapwnd.cxx 
b/cui/source/dialogs/cuiimapwnd.cxx
index 516b35c7e55c..7634ea091aed 100644
--- a/cui/source/dialogs/cuiimapwnd.cxx
+++ b/cui/source/dialogs/cuiimapwnd.cxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/cui/source/inc/cuitabarea.hxx b/cui/source/inc/cuitabarea.hxx
index 8e2a6e9b29c3..4b2dd2f3ac84 100644
--- a/cui/source/inc/cuitabarea.hxx
+++ b/cui/source/inc/cuitabarea.hxx
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index c2166e87c275..1bec48871dfb 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index 7204e5f72b0a..43c078c87285 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -32,6 +32,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/tpbitmap.cxx b/cui/source/tabpages/tpbitmap.cxx
index 4aad7f105476..fcab3c124d03 100644
--- a/cui/source/tabpages/tpbitmap.cxx
+++ b/cui/source/tabpages/tpbitmap.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/tpcolor.cxx b/cui/source/tabpages/tpcolor.cxx
index 911bbf748060..a938bacbe6ff 100644
--- a/cui/source/tabpages/tpcolor.cxx
+++ b/cui/source/tabpages/tpcolor.cxx
@@ -35,6 +35,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/tpgradnt.cxx b/cui/source/tabpages/tpgradnt.cxx
index 37a46fc59ea5..abc476b14c86 100644
--- a/cui/source/tabpages/tpgradnt.cxx
+++ b/cui/source/tabpages/tpgradnt.cxx
@@ -29,6 +29,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/tphatch.cxx b/cui/source/tabpages/tphatch.cxx
index 09c35101ff2e..8b59d3f2f353 100644
--- a/cui/source/tabpages/tphatch.cxx
+++ b/cui/source/tabpages/tphatch.cxx
@@ -30,6 +30,8 @@
 #include 
 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git 

Todor Balabanov license statement

[Todor Balabanov]

All of my past & future contributions to LibreOffice may be licensed under
the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Fwd: Tinderbox failure, Android-ARM@24-Bytemark-Hosting, MASTER, last success: 2019-04-26 20:22:54

[Miklos Vajna]

Hi Mike,

On Sat, Apr 27, 2019 at 09:58:57AM +, Kaganski Mike 
 wrote:
> After my commit ac419786b324 "Don't use std::function in scope guard for 
> performance reasons", errors are generated by Android-ARM, as in the 
> forwarded message below.
> 
> According to 
> https://stackoverflow.com/questions/43514188/lambda-passed-to-template-not-defined,
>  
> it's https://bugs.llvm.org//show_bug.cgi?id=20296 . But why doesn't it 
> show up on our jenkins builds; and what should I preferably do: just 
> revert the commit, or silence the warning locally somehow (e.g., 
> conditionally for Android only)?

If the Android toolchain is broken at the moment (false warning), then
indeed I would just silence the warning via #pragma, guarded by #ifdef
ANDROID. And hope that it can be cleaned up with the next Android
toolchain update.

In any case, keeping the tinderbox green would be great. :-)

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

[Noel Grandin (via logerrit)]

 vcl/source/app/svdata.cxx |   15 +++
 1 file changed, 3 insertions(+), 12 deletions(-)

New commits:
commit 60e7bf52450aaa20aa3ad9f10d32db590879e8c2
Author: Noel Grandin 
AuthorDate: Mon Apr 29 09:29:12 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Apr 29 11:28:49 2019 +0200

clean up iterator code in SystemDependentDataBuffer

Change-Id: I5f0cd0884b6490ae3018de13e3508b76e201d55f
Reviewed-on: https://gerrit.libreoffice.org/71507
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx
index 5613e8aa7b73..93335d48624b 100644
--- a/vcl/source/app/svdata.cxx
+++ b/vcl/source/app/svdata.cxx
@@ -115,8 +115,7 @@ namespace
 public:
 SystemDependentDataBuffer(const sal_Char* pDebugName)
 :   basegfx::SystemDependentDataManager(),
-maTimer(std::make_unique(pDebugName)),
-maEntries()
+maTimer(std::make_unique(pDebugName))
 {
 maTimer->SetTimeout(1000);
 maTimer->SetInvokeHandler(LINK(this, SystemDependentDataBuffer, 
implTimeoutHdl));
@@ -168,7 +167,6 @@ namespace
 void flushAll() override
 {
 ::osl::MutexGuard aGuard(m_aMutex);
-EntryMap::iterator aIter(maEntries.begin());
 
 if(maTimer)
 {
@@ -176,12 +174,7 @@ namespace
 maTimer.reset();
 }
 
-while(aIter != maEntries.end())
-{
-EntryMap::iterator aDelete(aIter);
-++aIter;
-maEntries.erase(aDelete);
-}
+maEntries.clear();
 }
 };
 
@@ -199,9 +192,7 @@ namespace
 }
 else
 {
-EntryMap::iterator aDelete(aIter);
-++aIter;
-maEntries.erase(aDelete);
+aIter = maEntries.erase(aIter);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/win

[Miklos Vajna (via logerrit)]

 vcl/inc/win/DWriteTextRenderer.hxx |   12 
 vcl/inc/win/winlayout.hxx  |1 +
 vcl/win/gdi/DWriteTextRenderer.cxx |   21 +++--
 vcl/win/gdi/winlayout.cxx  |   19 +++
 4 files changed, 47 insertions(+), 6 deletions(-)

New commits:
commit 4266020a78e98d7271e7dca8f5727cd7a419afc6
Author: Miklos Vajna 
AuthorDate: Wed Apr 24 17:07:30 2019 +0200
Commit: Luboš Luňák 
CommitDate: Mon Apr 29 11:48:31 2019 +0200

Related: tdf#113076 vcl win DirectWrite: handle stretched text

Commit a51b7a1c3a7e7cf7b0c733e1dec40288278c1884 (tdf#103831, tdf#100986:
Force using GDI when needed, 2017-03-03) noted that the DirectWrite text
renderer doesn't support stretched text, add support for this now by
setting a DirectWrite transform matrix that only does horizontal
scaling.

With this, tdf#113076 is kept fixed, but at the same time manually
stretched text keeps working. Previously the glyphs of the text had the
correct size and position, but the glyphs themselves where not streched,
but simply aligned to the left.

(cherry picked from commit 51bcbfc3596fceedfe019e841aab129425c9)

Change-Id: I8fe8e74d3edc0d71ed2f16fcce66c6f5009ed264
Reviewed-on: https://gerrit.libreoffice.org/71289
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/inc/win/DWriteTextRenderer.hxx 
b/vcl/inc/win/DWriteTextRenderer.hxx
index 0e81b67167d1..270c4772716f 100644
--- a/vcl/inc/win/DWriteTextRenderer.hxx
+++ b/vcl/inc/win/DWriteTextRenderer.hxx
@@ -95,6 +95,18 @@ private:
 D2DTextAntiAliasMode meTextAntiAliasMode;
 };
 
+/// Sets and unsets the needed DirectWrite transform to support the font's 
horizontal scaling.
+class WinFontStretchGuard
+{
+public:
+WinFontStretchGuard(ID2D1RenderTarget* pRenderTarget, float fHScale);
+~WinFontStretchGuard();
+
+private:
+ID2D1RenderTarget* mpRenderTarget;
+D2D1::Matrix3x2F maTransform;
+};
+
 #endif // INCLUDED_VCL_INC_WIN_DWRITERENDERER_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 042e30e9f299..2bbd87a12206 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -151,6 +151,7 @@ public:
 ~WinFontInstance() override;
 
 bool hasHScale() const;
+float getHScale() const;
 
 void SetGraphics(WinSalGraphics*);
 WinSalGraphics* GetGraphics() const { return m_pGraphics; }
diff --git a/vcl/win/gdi/DWriteTextRenderer.cxx 
b/vcl/win/gdi/DWriteTextRenderer.cxx
index 6dbfdbf403c3..50ec50897c80 100644
--- a/vcl/win/gdi/DWriteTextRenderer.cxx
+++ b/vcl/win/gdi/DWriteTextRenderer.cxx
@@ -271,6 +271,10 @@ bool 
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
 if (!GetDWriteFaceFromHDC(hDC, , ))
 return false;
 
+const WinFontInstance& rWinFont = static_cast(rLayout.GetFont());
+float fHScale = rWinFont.getHScale();
+WinFontStretchGuard aStretchGuard(mpRT, fHScale);
+
 tools::Rectangle bounds;
 bool succeeded = rLayout.GetBoundRect(bounds);
 if (succeeded)
@@ -297,9 +301,10 @@ bool 
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
 while (rLayout.GetNextGlyph(, aPos, nStart))
 {
 UINT16 glyphIndices[] = { pGlyph->m_aGlyphId };
-FLOAT glyphAdvances[] = { static_cast(pGlyph->m_nNewWidth) 
};
+FLOAT glyphAdvances[] = { static_cast(pGlyph->m_nNewWidth) 
/ fHScale };
 DWRITE_GLYPH_OFFSET glyphOffsets[] = { { 0.0f, 0.0f }, };
-D2D1_POINT_2F baseline = { static_cast(aPos.X() - 
bounds.Left()), static_cast(aPos.Y() - bounds.Top()) };
+D2D1_POINT_2F baseline = { static_cast(aPos.X() - 
bounds.Left()) / fHScale,
+   static_cast(aPos.Y() - 
bounds.Top()) };
 DWRITE_GLYPH_RUN glyphs = {
 mpFontFace,
 mlfEmHeight,
@@ -418,6 +423,18 @@ bool D2DWriteTextOutRenderer::GetDWriteFaceFromHDC(HDC 
hDC, IDWriteFontFace ** p
 return succeeded;
 }
 
+WinFontStretchGuard::WinFontStretchGuard(ID2D1RenderTarget* pRenderTarget, 
float fHScale)
+: mpRenderTarget(pRenderTarget)
+{
+pRenderTarget->GetTransform();
+if (fHScale == 1.0f)
+return;
+
+D2D1::Matrix3x2F aTransform
+= maTransform * D2D1::Matrix3x2F::Scale(D2D1::Size(fHScale, 1.0f), 
D2D1::Point2F(0, 0));
+mpRenderTarget->SetTransform(aTransform);
+}
 
+WinFontStretchGuard::~WinFontStretchGuard() { 
mpRenderTarget->SetTransform(maTransform); }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index 3aa8133be598..b9453f7b96d1 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -117,10 +117,11 @@ bool WinFontInstance::CacheGlyphToAtlas(HDC hDC, HFONT 
hFont, int nGlyphIndex, S
 std::vector aGlyphAdv(1);   // 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/filter/graphicfilter.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit dc3752ef01e7646af1978337aa5ba458f27774b6
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 11:52:11 2019 +0100
Commit: Michael Stahl 
CommitDate: Mon Apr 29 11:47:41 2019 +0200

ofz#14469 null deref

since...

commit af84fc9d906626255aaf136eefc5e55236e0e8a6
Date:   Tue Apr 23 15:48:41 2019 +0200

lazy image loading shouldn't read the entire .xls file (tdf#124828)

nLength is just an unchecked value in the dff stream, it might not be sane
so limit it to the max len of the stream

Change-Id: Ia8a2830478952afe1317b5cd795f35059d9b380a
Reviewed-on: https://gerrit.libreoffice.org/71413
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/vcl/source/filter/graphicfilter.cxx 
b/vcl/source/filter/graphicfilter.cxx
index 0cc982e68082..9be6f0723079 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -1443,7 +1443,9 @@ Graphic GraphicFilter::ImportUnloadedGraphic(SvStream& 
rIStream, sal_uInt64 size
 ErrCode nStatus = ImpTestOrFindFormat("", rIStream, nFormat);
 
 rIStream.Seek(nStreamBegin);
-const sal_uInt32 nStreamLength( sizeLimit ? sizeLimit : 
rIStream.remainingSize());
+sal_uInt32 nStreamLength(rIStream.remainingSize());
+if (sizeLimit && sizeLimit < nStreamLength)
+nStreamLength = sizeLimit;
 
 OUString aFilterName = pConfig->GetImportFilterName(nFormat);
 OUString aExternalFilterName = pConfig->GetExternalFilterName(nFormat, 
false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx

[Stephan Bergmann (via logerrit)]

 include/svx/ctredlin.hxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 598c96a9afaf97a235371ce8d00405bdbbb24d25
Author: Stephan Bergmann 
AuthorDate: Mon Apr 29 11:31:44 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 29 13:10:33 2019 +0200

-Werror,-Wunused-private-field

Change-Id: I465627958ef7a18c0e80361ae4a1c6ba27ec735d
Reviewed-on: https://gerrit.libreoffice.org/71513
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/svx/ctredlin.hxx b/include/svx/ctredlin.hxx
index 946ffb414dfa..cb0f854821b5 100644
--- a/include/svx/ctredlin.hxx
+++ b/include/svx/ctredlin.hxx
@@ -38,7 +38,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -124,9 +123,6 @@ private:
 DateTimeaDaTiFilterFirst;
 DateTimeaDaTiFilterLast;
 OUStringaAuthor;
-Color   maEntryColor;
-Image   maEntryImage;
-OUStringmaEntryString;
 std::unique_ptr pCommentSearcher;
 
 int ColCompare(const weld::TreeIter& rLeft, const weld::TreeIter& rRight);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/inc xmlsecurity/IwyuFilter_xmlsecurity.yaml xmlsecurity/qa xmlsecurity/source

[Gabor Kelemen (via logerrit)]

 xmlsecurity/IwyuFilter_xmlsecurity.yaml   |  109 ++
 xmlsecurity/inc/certificatechooser.hxx|6 
 xmlsecurity/inc/documentsignaturehelper.hxx   |4 
 xmlsecurity/inc/documentsignaturemanager.hxx  |2 
 xmlsecurity/inc/framework/saxeventkeeperimpl.hxx  |8 
 xmlsecurity/inc/framework/signaturecreatorimpl.hxx|6 
 xmlsecurity/inc/framework/signatureengine.hxx |   14 -
 xmlsecurity/inc/framework/signatureverifierimpl.hxx   |7 
 xmlsecurity/inc/framework/xmlsignaturetemplateimpl.hxx|7 
 xmlsecurity/inc/gpg/SEInitializer.hxx |6 
 xmlsecurity/inc/gpg/xmlsignature_gpgimpl.hxx  |   10 
 xmlsecurity/inc/macrosecurity.hxx |2 
 xmlsecurity/inc/xmlsec/errorcallback.hxx  |4 
 xmlsecurity/inc/xmlsec/saxhelper.hxx  |9 
 xmlsecurity/inc/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx  |5 
 xmlsecurity/inc/xmlsec/xmlstreamio.hxx|6 
 xmlsecurity/inc/xmlsignaturehelper.hxx|   18 -
 xmlsecurity/inc/xmlsignaturehelper2.hxx   |3 
 xmlsecurity/inc/xsecctl.hxx   |   26 --
 xmlsecurity/qa/unit/signing/signing.cxx   |1 
 xmlsecurity/source/component/documentdigitalsignatures.cxx|2 
 xmlsecurity/source/dialogs/certificatechooser.cxx |1 
 xmlsecurity/source/framework/buffernode.hxx   |5 
 xmlsecurity/source/framework/elementcollector.cxx |1 
 xmlsecurity/source/framework/elementcollector.hxx |4 
 xmlsecurity/source/framework/elementmark.hxx  |1 
 xmlsecurity/source/framework/saxeventkeeperimpl.cxx   |2 
 xmlsecurity/source/framework/signaturecreatorimpl.cxx |2 
 xmlsecurity/source/framework/signatureverifierimpl.cxx|2 
 xmlsecurity/source/framework/xmlsignaturetemplateimpl.cxx |1 
 xmlsecurity/source/gpg/CertificateImpl.hxx|4 
 xmlsecurity/source/gpg/CipherContext.hxx  |2 
 xmlsecurity/source/gpg/DigestContext.hxx  |2 
 xmlsecurity/source/gpg/SEInitializer.cxx  |2 
 xmlsecurity/source/gpg/SecurityEnvironment.cxx|   13 +
 xmlsecurity/source/gpg/SecurityEnvironment.hxx|   17 -
 xmlsecurity/source/gpg/XMLEncryption.hxx  |8 
 xmlsecurity/source/gpg/XMLSecurityContext.hxx |8 
 xmlsecurity/source/helper/documentsignaturehelper.cxx |1 
 xmlsecurity/source/helper/documentsignaturemanager.cxx|3 
 xmlsecurity/source/helper/ooxmlsecexporter.cxx|1 
 xmlsecurity/source/helper/ooxmlsecparser.cxx  |1 
 xmlsecurity/source/helper/ooxmlsecparser.hxx  |5 
 xmlsecurity/source/helper/xsecctl.cxx |2 
 xmlsecurity/source/helper/xsecparser.cxx  |1 
 xmlsecurity/source/helper/xsecparser.hxx  |7 
 xmlsecurity/source/xmlsec/certificateextension_xmlsecimpl.hxx |4 
 xmlsecurity/source/xmlsec/errorcallback.cxx   |1 
 xmlsecurity/source/xmlsec/nss/ciphercontext.cxx   |1 
 xmlsecurity/source/xmlsec/nss/ciphercontext.hxx   |3 
 xmlsecurity/source/xmlsec/nss/nssinitializer.hxx  |3 
 xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx|5 
 xmlsecurity/source/xmlsec/nss/secerror.hxx|2 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |6 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx |   16 -
 xmlsecurity/source/xmlsec/nss/seinitializer_nssimpl.hxx   |5 
 xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx |1 
 xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.hxx |6 
 xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx  |3 
 xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx|3 
 xmlsecurity/source/xmlsec/saxhelper.cxx   |4 
 xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx   |1 
 xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx|5 
 xmlsecurity/source/xmlsec/xmlstreamio.cxx |2 
 64 files changed, 250 insertions(+), 172 deletions(-)

New commits:
commit d1ab132367c6e4ce0ca5711b7c5259d1f6e0e5cc
Author: Gabor Kelemen 
AuthorDate: Sat Apr 27 23:53:02 2019 +0200
Commit: Miklos Vajna 
CommitDate: Mon Apr 29 13:17:59 2019 +0200

tdf#42949 Fix IWYU warnings in  xmlsecurity/*hxx

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

All hxx cleaned except 

[Libreoffice-commits] core.git: desktop/source

[Mike Kaganski (via logerrit)]

 desktop/source/lib/init.cxx |  253 ++--
 1 file changed, 104 insertions(+), 149 deletions(-)

New commits:
commit a5c0cf416faff2a4b273ac526a83c9c2575a5d51
Author: Mike Kaganski 
AuthorDate: Sun Apr 28 23:29:49 2019 +0300
Commit: Miklos Vajna 
CommitDate: Mon Apr 29 09:31:11 2019 +0200

tdf#120703 PVS: dereference before nullptr check

Use a function to consistently check if gImpl is valid before assigning last
exception message.

V595 The 'gImpl' pointer was utilized before it was verified against 
nullptr.
 Check lines: 2673, 2683.

Change-Id: I18fc0d632c84f37b05e9d1c3c83689e6eaa6f66c
Reviewed-on: https://gerrit.libreoffice.org/71488
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 937331376024..497c31b34101 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -163,6 +163,12 @@ static LibLibreOffice_Impl *gImpl = nullptr;
 static std::weak_ptr< LibreOfficeKitClass > gOfficeClass;
 static std::weak_ptr< LibreOfficeKitDocumentClass > gDocumentClass;
 
+static void SetLastExceptionMsg(const OUString& s = OUString())
+{
+if (gImpl)
+gImpl->maLastExceptionMsg = s;
+}
+
 struct ExtensionMap
 {
 const char *extn;
@@ -1872,8 +1878,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, 
const char* sUrl, const cha
 comphelper::ProfileZone aZone("doc_saveAs");
 
 SolarMutexGuard aGuard;
-if (gImpl)
-gImpl->maLastExceptionMsg.clear();
+SetLastExceptionMsg();
 
 LibLODocument_Impl* pDocument = static_cast(pThis);
 
@@ -1881,7 +1886,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, 
const char* sUrl, const cha
 OUString aURL(getAbsoluteURL(sUrl));
 if (aURL.isEmpty())
 {
-gImpl->maLastExceptionMsg = "Filename to save to was not provided.";
+SetLastExceptionMsg("Filename to save to was not provided.");
 SAL_INFO("lok", "URL for save is empty");
 return false;
 }
@@ -1920,7 +1925,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, 
const char* sUrl, const cha
 }
 else
 {
-gImpl->maLastExceptionMsg = "input filename without a suffix";
+SetLastExceptionMsg("input filename without a suffix");
 return false;
 }
 }
@@ -1936,7 +1941,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, 
const char* sUrl, const cha
 }
 if (aFilterName.isEmpty())
 {
-gImpl->maLastExceptionMsg = "no output filter found for provided 
suffix";
+SetLastExceptionMsg("no output filter found for provided suffix");
 return false;
 }
 
@@ -2016,7 +2021,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, 
const char* sUrl, const cha
 }
 catch (const uno::Exception& exception)
 {
-gImpl->maLastExceptionMsg = "exception: " + exception.Message;
+SetLastExceptionMsg("exception: " + exception.Message);
 }
 return false;
 }
@@ -2024,8 +2029,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, 
const char* sUrl, const cha
 static void doc_iniUnoCommands ()
 {
 SolarMutexGuard aGuard;
-if (gImpl)
-gImpl->maLastExceptionMsg.clear();
+SetLastExceptionMsg();
 
 OUString sUnoCommands[] =
 {
@@ -2173,8 +2177,7 @@ static int doc_getDocumentType (LibreOfficeKitDocument* 
pThis)
 comphelper::ProfileZone aZone("doc_getDocumentType");
 
 SolarMutexGuard aGuard;
-if (gImpl)
-gImpl->maLastExceptionMsg.clear();
+SetLastExceptionMsg();
 
 LibLODocument_Impl* pDocument = static_cast(pThis);
 
@@ -2200,12 +2203,12 @@ static int doc_getDocumentType (LibreOfficeKitDocument* 
pThis)
 }
 else
 {
-gImpl->maLastExceptionMsg = "unknown document type";
+SetLastExceptionMsg("unknown document type");
 }
 }
 catch (const uno::Exception& exception)
 {
-gImpl->maLastExceptionMsg = "exception: " + exception.Message;
+SetLastExceptionMsg("exception: " + exception.Message);
 }
 return LOK_DOCTYPE_OTHER;
 }
@@ -2219,7 +,7 @@ static int doc_getParts (LibreOfficeKitDocument* pThis)
 ITiledRenderable* pDoc = getTiledRenderable(pThis);
 if (!pDoc)
 {
-gImpl->maLastExceptionMsg = "Document doesn't support tiled rendering";
+SetLastExceptionMsg("Document doesn't support tiled rendering");
 return 0;
 }
 
@@ -2231,13 +2234,12 @@ static int doc_getPart (LibreOfficeKitDocument* pThis)
 comphelper::ProfileZone aZone("doc_getPart");
 
 SolarMutexGuard aGuard;
-if (gImpl)
-gImpl->maLastExceptionMsg.clear();
+SetLastExceptionMsg();
 
 ITiledRenderable* pDoc = getTiledRenderable(pThis);
 if (!pDoc)
 {
-gImpl->maLastExceptionMsg = "Document doesn't 

Re: error when starting LibreOffice

[Michael Stahl]

On 26.04.19 18:24, Adrien Ollier wrote:

Hello everybody,

I successfully compiled my modified version of LO but it crashes at 
startup. The GUI starts launching but it closes after about 3 seconds 
and the following message appear:


$ instdir/program/soffice
Application Error


try "make debugrun", at the gdb prompt type "run" [note: probably you'll 
have to do this twice, if you see exit code 81, then only config 
directory was created], and when it reports a crash type "bt".



By looking in the error journal, I can see this:


dunno, that's reported by gnome-shell, at first glance i find it 
unlikely that gnome-shell calling setenv with a null pointer is caused 
by LO.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: officecfg/registry

[Shubham Goyal (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |   15 
++
 1 file changed, 15 insertions(+)

New commits:
commit c3ca559841c857bf7b39f665433d71c89d220d0f
Author: Shubham Goyal <22shub...@gmail.com>
AuthorDate: Wed Apr 24 21:09:40 2019 +0530
Commit: Heiko Tietze 
CommitDate: Mon Apr 29 11:40:07 2019 +0200

tdf#124854 Rename the Tooltip of Table Toolbar elements

Added Tooltip labels to icons.

Change-Id: Idace4947f98c0a03214e3feffe692711063543e1
Reviewed-on: https://gerrit.libreoffice.org/70981
Reviewed-by: Heiko Tietze 
Tested-by: Jenkins

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 2c153b87fa52..56512b9ece26 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -1535,6 +1535,9 @@
 
   ~Rows
 
+
+  Delete selected rows
+
 
   1
 
@@ -1546,6 +1549,9 @@
 
   ~Columns
 
+
+  Delete selected columns
+
 
   1
 
@@ -1557,6 +1563,9 @@
 
   ~Table
 
+
+  Delete table
+
 
   1
 
@@ -1645,6 +1654,9 @@
 
   C~ell
 
+
+  Select Cell
+
 
   1
 
@@ -1680,6 +1692,9 @@
 
   ~Table
 
+
+  Select Table
+
 
   1
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/source include/opencl opencl/Executable_opencltest.mk opencl/inc opencl/Module_opencl.mk opencl/opencltest opencl/source Repository.mk

[Luboš Luňák (via logerrit)]

 Repository.mk|1 
 desktop/source/app/opencl.cxx|   61 
 include/opencl/openclwrapper.hxx |2 
 opencl/Executable_opencltest.mk  |   30 ++
 opencl/Module_opencl.mk  |1 
 opencl/inc/clew_setup.hxx|   25 +
 opencl/opencltest/main.cxx   |  185 +++
 opencl/source/openclwrapper.cxx  |   24 +
 8 files changed, 328 insertions(+), 1 deletion(-)

New commits:
commit 101eea01c778ad255d3c8467e06643b23ff6bd76
Author: Luboš Luňák 
AuthorDate: Mon Apr 22 21:23:44 2019 +0200
Commit: Luboš Luňák 
CommitDate: Mon Apr 29 10:40:12 2019 +0200

test in a separate helper process if OpenCL crashes (tdf#112252)

Some OpenCL implementations may be broken, e.g. pocl simply
asserts and aborts if it can't find Clang. In order to protect
against crashes caused by faulty OpenCL drivers, when testing OpenCL
functionality on OpenCL setup change, first do a simple test
in a separate helper.

Change-Id: I1cf328e731c48f47745b27c7130e7521254209f5
Reviewed-on: https://gerrit.libreoffice.org/71080
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/Repository.mk b/Repository.mk
index b97a68e371e5..d9654e717025 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -209,6 +209,7 @@ $(eval $(call 
gb_Helper_register_executables_for_install,OOO,ooo, \
$(if $(filter WNT,$(OS)), \
senddoc \
) \
+   $(if $(filter OPENCL,$(BUILD_TYPE)),opencltest) \
 ))
 
 ifeq ($(OS),WNT)
diff --git a/desktop/source/app/opencl.cxx b/desktop/source/app/opencl.cxx
index f62c93e32e1f..a728ba2b8b7d 100644
--- a/desktop/source/app/opencl.cxx
+++ b/desktop/source/app/opencl.cxx
@@ -38,6 +38,7 @@
 #include 
 
 #include 
+#include 
 
 using namespace ::osl;
 using namespace ::com::sun::star::uno;
@@ -47,6 +48,61 @@ namespace desktop {
 
 #if HAVE_FEATURE_OPENCL
 
+static bool testOpenCLDriver()
+{
+// A simple OpenCL test run in a separate process in order to test
+// whether the driver crashes (asserts,etc.) when trying to use OpenCL.
+SAL_INFO("opencl", "Starting CL driver test");
+
+OUString testerURL("$BRAND_BASE_DIR/" LIBO_BIN_FOLDER "/opencltest");
+rtl::Bootstrap::expandMacros(testerURL); //TODO: detect failure
+
+OUString deviceName, platformName;
+openclwrapper::getOpenCLDeviceName( deviceName, platformName );
+rtl_uString* args[] = { deviceName.pData, platformName.pData };
+sal_Int32 numArgs = 2;
+
+oslProcess process;
+oslSecurity security = osl_getCurrentSecurity();
+oslProcessError error = osl_executeProcess(testerURL.pData, args, numArgs,
+osl_Process_SEARCHPATH | osl_Process_HIDDEN, security,
+nullptr, nullptr, 0,  );
+osl_freeSecurityHandle( security );
+if( error != osl_Process_E_None )
+{
+SAL_WARN( "opencl", "failed to start CL driver test: " << error );
+return false;
+}
+// If the driver takes more than 10 seconds, it's probably broken/useless.
+TimeValue timeout( 10, 0 );
+error = osl_joinProcessWithTimeout( process,  );
+if( error == osl_Process_E_None )
+{
+oslProcessInfo info;
+info.Size = sizeof( info );
+error = osl_getProcessInfo( process, osl_Process_EXITCODE,  );
+if( error == osl_Process_E_None )
+{
+if( info.Code == 0 )
+{
+SAL_INFO( "opencl", "CL driver test passed" );
+osl_freeProcessHandle( process );
+return true;
+}
+else
+{
+SAL_WARN( "opencl", "CL driver test failed - disabling: " << 
info.Code );
+osl_freeProcessHandle( process );
+return false;
+}
+}
+}
+SAL_WARN( "opencl", "CL driver test did not finish - disabling: " << error 
);
+osl_terminateProcess( process );
+osl_freeProcessHandle( process );
+return false;
+}
+
 static bool testOpenCLCompute(const Reference< XDesktop2 > , const 
OUString )
 {
 bool bSuccess = false;
@@ -178,7 +234,10 @@ void Desktop::CheckOpenCLCompute(const Reference< 
XDesktop2 > )
 xBatch->commit();
 }
 
-bool bSucceeded = testOpenCLCompute(xDesktop, aURL);
+// Hopefully at least basic functionality always works and broken 
OpenCL implementations break
+// only when they are used to compute something. If this assumptions 
turns out to be not true,
+// the driver check needs to be moved sooner.
+bool bSucceeded = testOpenCLDriver() && testOpenCLCompute(xDesktop, 
aURL);
 
 { // restore the minimum group size
 std::shared_ptr 
xBatch(comphelper::ConfigurationChanges::create());
diff --git a/include/opencl/openclwrapper.hxx b/include/opencl/openclwrapper.hxx
index 67dfc8798416..81138ced24e8 100644
--- a/include/opencl/openclwrapper.hxx
+++ b/include/opencl/openclwrapper.hxx

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - kit/Kit.cpp net/ServerSocket.hpp net/Socket.cpp wsd/LOOLWSD.cpp

[Libreoffice Gerrit user]

 kit/Kit.cpp  |2 +-
 net/ServerSocket.hpp |4 
 net/Socket.cpp   |   23 ++-
 wsd/LOOLWSD.cpp  |2 ++
 4 files changed, 17 insertions(+), 14 deletions(-)

New commits:
commit e5499d27536237aae9be1a436339230934284285
Author: Tor Lillqvist 
AuthorDate: Mon Apr 29 10:35:00 2019 +0300
Commit: Tor Lillqvist 
CommitDate: Mon Apr 29 14:03:10 2019 +0300

Fix build in the MOBILEAPP case

Even with this fix, at least the iOS app doesn't work properly when
built from HEAD of this branch and of the cp-6.0 branch, though. At
least combo boxes in tunnelled dialogs don't work any longer.

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 48bccf106..2cc114422 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2463,7 +2463,7 @@ void lokit_main(
 #ifndef MOBILEAPP
 mainKit.insertNewUnixSocket(MasterLocation, pathAndQuery, 
websocketHandler);
 #else
-mainKit.insertNewFakeSocketSync(docBrokerSocket, websocketHandler);
+mainKit.insertNewFakeSocket(docBrokerSocket, websocketHandler);
 #endif
 
 LOG_INF("New kit client websocket inserted.");
diff --git a/net/ServerSocket.hpp b/net/ServerSocket.hpp
index 1b1f10fb9..f91e3a505 100644
--- a/net/ServerSocket.hpp
+++ b/net/ServerSocket.hpp
@@ -96,6 +96,8 @@ protected:
 std::shared_ptr _sockFactory;
 };
 
+#ifndef MOBILEAPP
+
 /// A non-blocking, streaming Unix Domain Socket for local use
 class LocalServerSocket : public ServerSocket
 {
@@ -114,4 +116,6 @@ private:
 
 #endif
 
+#endif
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/net/Socket.cpp b/net/Socket.cpp
index f3492c37f..16d609f3b 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -201,6 +201,8 @@ void SocketPoll::wakeupWorld()
 wakeup(fd);
 }
 
+#ifndef MOBILEAPP
+
 void SocketPoll::insertNewWebSocketSync(
 const Poco::URI ,
 const std::shared_ptr& websocketHandler)
@@ -332,7 +334,8 @@ void SocketPoll::insertNewUnixSocket(
 }
 }
 
-#ifdef MOBILEAPP
+#else
+
 void SocketPoll::insertNewFakeSocket(
 int peerSocket,
 const std::shared_ptr& websocketHandler)
@@ -362,6 +365,7 @@ void SocketPoll::insertNewFakeSocket(
 }
 }
 }
+
 #endif
 
 void ServerSocket::dumpState(std::ostream& os)
@@ -490,7 +494,7 @@ std::shared_ptr ServerSocket::accept()
 {
 // Accept a connection (if any) and set it to non-blocking.
 // There still need the client's address to filter request from POST(call 
from REST) here.
-#if !MOBILEAPP
+#ifndef MOBILEAPP
 assert(_type != Socket::Type::Unix);
 
 struct sockaddr_in6 clientInfo;
@@ -507,7 +511,7 @@ std::shared_ptr ServerSocket::accept()
 {
 std::shared_ptr _socket = _sockFactory->create(rc);
 
-#if !MOBILEAPP
+#ifndef MOBILEAPP
 char addrstr[INET6_ADDRSTRLEN];
 
 const void *inAddr;
@@ -540,6 +544,8 @@ std::shared_ptr ServerSocket::accept()
 return nullptr;
 }
 
+#ifndef MOBILEAPP
+
 int Socket::getPid() const
 {
 struct ucred creds;
@@ -554,11 +560,7 @@ int Socket::getPid() const
 
 std::shared_ptr LocalServerSocket::accept()
 {
-#if !MOBILEAPP
 const int rc = ::accept4(getFD(), nullptr, nullptr, SOCK_NONBLOCK);
-#else
-const int rc = fakeSocketAccept4(getFD());
-#endif
 try
 {
 LOG_DBG("Accepted prisoner socket #" << rc << ", creating socket 
object.");
@@ -566,7 +568,6 @@ std::shared_ptr LocalServerSocket::accept()
 return std::shared_ptr(nullptr);
 
 std::shared_ptr _socket = _sockFactory->create(rc);
-#if MOBILEAPP
 // Sanity check this incoming socket
 struct ucred creds;
 socklen_t credSize = sizeof(struct ucred);
@@ -592,7 +593,6 @@ std::shared_ptr LocalServerSocket::accept()
 
 LOG_DBG("Accepted socket is UDS - address " << addr <<
 " and pid/gid " << creds.pid << "/" << creds.gid);
-#endif
 return _socket;
 }
 catch (const std::exception& ex)
@@ -605,7 +605,6 @@ std::shared_ptr LocalServerSocket::accept()
 /// Returns true on success only.
 std::string LocalServerSocket::bind()
 {
-#ifndef MOBILEAPP
 int rc;
 struct sockaddr_un addrunix;
 do
@@ -625,12 +624,10 @@ std::string LocalServerSocket::bind()
 
 if (rc >= 0)
 return std::string(_path[1]);
-#endif
+
 return "";
 }
 
-#ifndef MOBILEAPP
-
 bool StreamSocket::parseHeader(const char *clientName,
Poco::MemoryInputStream ,
Poco::Net::HTTPRequest ,
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 7a7dfed54..1dd17d8b9 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2924,12 +2924,14 @@ public:
 SocketPoll::InhibitThreadChecks = true;
 
 os << "LOOLWSDServer:\n"
+#ifndef MOBILEAPP
<< "  Ports: server " << ClientPortNumber
<<  " prisoner " << MasterLocation << "\n"
<< "  SSL: " << (LOOLWSD::isSSLEnabled() ? "https" : "http") << "\n"
<< "  

[Libreoffice-commits] core.git: svtools/source

[Julien Nabet (via logerrit)]

 svtools/source/dialogs/ServerDetailsControls.cxx |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit b9b930046368532c61b20637cb0356e195529440
Author: Julien Nabet 
AuthorDate: Thu Apr 25 18:54:09 2019 +0200
Commit: Caolán McNamara 
CommitDate: Mon Apr 29 13:12:47 2019 +0200

tdf#113834: fix crash when service host empty

The crash affects Windows, not Linux where an error popup appears instead 
(MacOs?)
It seems the fact the url was empty triggers an exception in 
ucbhelper::Content ctr
So let's put the lines in the try catch and log the exception.
See comments of bugtracker for slight more details.

Change-Id: I60e55be488632ff6e0106fde832a818c6431f58e
Reviewed-on: https://gerrit.libreoffice.org/71321
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svtools/source/dialogs/ServerDetailsControls.cxx 
b/svtools/source/dialogs/ServerDetailsControls.cxx
index e65150b7cff5..23bd16d1eeea 100644
--- a/svtools/source/dialogs/ServerDetailsControls.cxx
+++ b/svtools/source/dialogs/ServerDetailsControls.cxx
@@ -25,6 +25,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -446,12 +447,11 @@ IMPL_LINK_NOARG( CmisDetailsContainer, RefreshReposHdl, 
weld::Button&, void  )
 catch( const Exception& )
 {}
 
-// Get the Content
-::ucbhelper::Content aCnt( sUrl, m_xCmdEnv, 
comphelper::getProcessComponentContext() );
-Sequence aProps { "Title" };
-
 try
 {
+// Get the Content
+::ucbhelper::Content aCnt( sUrl, m_xCmdEnv, 
comphelper::getProcessComponentContext() );
+Sequence aProps { "Title" };
 Reference< XResultSet > xResultSet( aCnt.createCursor( aProps ), 
UNO_QUERY_THROW );
 Reference< XContentAccess > xAccess( xResultSet, UNO_QUERY_THROW );
 while ( xResultSet->next() )
@@ -467,8 +467,9 @@ IMPL_LINK_NOARG( CmisDetailsContainer, RefreshReposHdl, 
weld::Button&, void  )
 m_pDialog->m_xLBRepository->append_text(sName);
 }
 }
-catch ( const Exception& )
+catch ( const Exception& e)
 {
+SAL_WARN( "svtools.dialogs", "RefreshReposHdl exception=" << e );
 }
 
 // Auto-select the first one
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - comphelper/source include/comphelper vcl/inc vcl/unx

[Noel Grandin (via logerrit)]

 comphelper/source/xml/attributelist.cxx |   70 ++--
 include/comphelper/attributelist.hxx|   40 ++
 vcl/inc/unx/gtk/gtksalmenu.hxx  |2 
 vcl/unx/gtk/gtksalmenu.cxx  |   25 ---
 4 files changed, 58 insertions(+), 79 deletions(-)

New commits:
commit 9eae42ce01cb289b9e736454abcf835b8394
Author: Noel Grandin 
AuthorDate: Sun Apr 28 09:54:42 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Apr 29 08:30:26 2019 +0200

speed up gtk menu construction at startup

Change-Id: Ia28b1f0281485691e3b4188d23947014c1eff385
Reviewed-on: https://gerrit.libreoffice.org/71465
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx
index bdacee7ca178..b973684b21f1 100644
--- a/vcl/inc/unx/gtk/gtksalmenu.hxx
+++ b/vcl/inc/unx/gtk/gtksalmenu.hxx
@@ -59,6 +59,8 @@ private:
 boolmbNeedsUpdate;
 boolmbReturnFocusToDocument;
 boolmbAddedGrab;
+/// Even setting  null icon on a menuitem can be expensive, so cache state 
to avoid that call
+boolmbHasNullItemIcon = true;
 GtkWidget*  mpMenuBarContainerWidget;
 std::unique_ptr  mxPersonaImage;
 BitmapExmaPersonaBitmap;
diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx
index 2f85e0710043..e3d9dc85c087 100644
--- a/vcl/unx/gtk/gtksalmenu.cxx
+++ b/vcl/unx/gtk/gtksalmenu.cxx
@@ -1063,6 +1063,9 @@ namespace
 void GtkSalMenu::NativeSetItemIcon( unsigned nSection, unsigned nItemPos, 
const Image& rImage )
 {
 #if GLIB_CHECK_VERSION(2,38,0)
+if (!!rImage && mbHasNullItemIcon)
+return;
+
 SolarMutexGuard aGuard;
 
 if (!!rImage)
@@ -1081,9 +1084,13 @@ void GtkSalMenu::NativeSetItemIcon( unsigned nSection, 
unsigned nItemPos, const
 g_lo_menu_set_icon_to_item_in_section( G_LO_MENU( mpMenuModel ), 
nSection, nItemPos, pIcon );
 g_object_unref(pIcon);
 g_bytes_unref(pBytes);
+mbHasNullItemIcon = false;
 }
 else
+{
 g_lo_menu_set_icon_to_item_in_section( G_LO_MENU( mpMenuModel ), 
nSection, nItemPos, nullptr );
+mbHasNullItemIcon = true;
+}
 #else
 (void)nSection;
 (void)nItemPos;
@@ -1222,12 +1229,18 @@ void GtkSalMenu::ActivateAllSubmenus(Menu* pMenuBar)
 {
 if ( pSalItem->mpSubMenu != nullptr )
 {
-pSalItem->mpSubMenu->mbInActivateCallback = true;
-pMenuBar->HandleMenuActivateEvent(pSalItem->mpSubMenu->GetMenu());
-pSalItem->mpSubMenu->mbInActivateCallback = false;
-pSalItem->mpSubMenu->ActivateAllSubmenus(pMenuBar);
-pSalItem->mpSubMenu->Update();
-
pMenuBar->HandleMenuDeActivateEvent(pSalItem->mpSubMenu->GetMenu());
+// We can re-enter this method via the new event loop that gets 
created
+// in GtkClipboardTransferable::getTransferDataFlavorsAsVector, so 
use the InActivateCallback
+// flag to detect that and skip some startup work.
+if (!pSalItem->mpSubMenu->mbInActivateCallback)
+{
+pSalItem->mpSubMenu->mbInActivateCallback = true;
+
pMenuBar->HandleMenuActivateEvent(pSalItem->mpSubMenu->GetMenu());
+pSalItem->mpSubMenu->mbInActivateCallback = false;
+pSalItem->mpSubMenu->ActivateAllSubmenus(pMenuBar);
+pSalItem->mpSubMenu->Update();
+
pMenuBar->HandleMenuDeActivateEvent(pSalItem->mpSubMenu->GetMenu());
+}
 }
 }
 }
commit 8647288180806f8515bf2548db7280cbc657eaf3
Author: Noel Grandin 
AuthorDate: Sat Apr 27 09:44:15 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Apr 29 08:30:17 2019 +0200

optimise comphelper::AttributeList a little

Change-Id: I48cb0a1b5dfcf6471c1cdf9d79445281f9f33020
Reviewed-on: https://gerrit.libreoffice.org/71463
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/xml/attributelist.cxx 
b/comphelper/source/xml/attributelist.cxx
index 6c1578defd8f..fa918d01da29 100644
--- a/comphelper/source/xml/attributelist.cxx
+++ b/comphelper/source/xml/attributelist.cxx
@@ -27,57 +27,9 @@ using namespace com::sun::star;
 
 namespace comphelper {
 
-struct TagAttribute_Impl
-{
-TagAttribute_Impl( const OUString , const OUString ,
- const OUString  )
-{
-sName = aName;
-sType = aType;
-sValue= aValue;
-}
-
-OUString sName;
-OUString sType;
-OUString sValue;
-};
-
-struct AttributeList_Impl
-{
-AttributeList_Impl()
-{
-// performance improvement during adding
-vecAttribute.reserve(20);
-}
-std::vector vecAttribute;
-};
-
-sal_Int16 SAL_CALL AttributeList::getLength()
-{
- 

[Libreoffice-commits] core.git: 2 commits - svx/source xmloff/inc xmloff/source

[Noel Grandin (via logerrit)]

 svx/source/unodraw/unoprov.cxx  |   31 
 xmloff/inc/txtfldi.hxx  |2 -
 xmloff/source/chart/XMLSymbolImageContext.cxx   |2 -
 xmloff/source/draw/XMLImageMapContext.cxx   |2 -
 xmloff/source/style/DashStyle.cxx   |2 -
 xmloff/source/style/GradientStyle.cxx   |2 -
 xmloff/source/style/HatchStyle.cxx  |4 +-
 xmloff/source/style/ImageStyle.cxx  |2 -
 xmloff/source/style/TransGradientStyle.cxx  |2 -
 xmloff/source/style/XMLBackgroundImageContext.cxx   |   28 ++
 xmloff/source/style/xmltabi.cxx |2 -
 xmloff/source/text/XMLFootnoteImportContext.cxx |2 -
 xmloff/source/text/XMLIndexSourceBaseContext.cxx|2 -
 xmloff/source/text/XMLLineNumberingImportContext.cxx|2 -
 xmloff/source/text/XMLSectionImportContext.cxx  |2 -
 xmloff/source/text/XMLSectionSourceDDEImportContext.cxx |2 -
 xmloff/source/text/XMLSectionSourceImportContext.cxx|2 -
 xmloff/source/text/txtdropi.cxx |2 -
 xmloff/source/text/txtfldi.cxx  |4 +-
 xmloff/source/xforms/xformsapi.cxx  |4 +-
 20 files changed, 56 insertions(+), 45 deletions(-)

New commits:
commit b1e36f4d264f1d8d8df4558ba0c781ccb93a4244
Author: Noel Grandin 
AuthorDate: Sun Apr 28 12:38:01 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Apr 29 08:31:21 2019 +0200

tdf#63640 FILEOPEN/FILESAVE: particular .odt loads/saves very slow, part4

cache the XMLTokenMap data in static const vars, so we only need to
initialise them once

Change-Id: Ib63bedc5af5d5927fed189a6b1a86a5db6865c72
Reviewed-on: https://gerrit.libreoffice.org/71466
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmloff/inc/txtfldi.hxx b/xmloff/inc/txtfldi.hxx
index 44540e4df500..794ddef20ea5 100644
--- a/xmloff/inc/txtfldi.hxx
+++ b/xmloff/inc/txtfldi.hxx
@@ -945,8 +945,6 @@ protected:
 /** import dde field declaration container () */
 class XMLDdeFieldDeclsImportContext : public SvXMLImportContext
 {
-SvXMLTokenMap const aTokenMap;
-
 public:
 
 XMLDdeFieldDeclsImportContext(SvXMLImport& rImport,
diff --git a/xmloff/source/chart/XMLSymbolImageContext.cxx 
b/xmloff/source/chart/XMLSymbolImageContext.cxx
index 4e9fae4a9df5..5fce5f613f05 100644
--- a/xmloff/source/chart/XMLSymbolImageContext.cxx
+++ b/xmloff/source/chart/XMLSymbolImageContext.cxx
@@ -61,7 +61,7 @@ XMLSymbolImageContext::~XMLSymbolImageContext()
 
 void XMLSymbolImageContext::StartElement( const uno::Reference< 
xml::sax::XAttributeList >& xAttrList )
 {
-SvXMLTokenMap aTokenMap( aSymbolImageAttrTokenMap );
+static const SvXMLTokenMap aTokenMap( aSymbolImageAttrTokenMap );
 OUString aLocalName;
 
 sal_Int16 nAttrCount = xAttrList.is() ? xAttrList->getLength() : 0;
diff --git a/xmloff/source/draw/XMLImageMapContext.cxx 
b/xmloff/source/draw/XMLImageMapContext.cxx
index b7386c24f0d7..c7126b055865 100644
--- a/xmloff/source/draw/XMLImageMapContext.cxx
+++ b/xmloff/source/draw/XMLImageMapContext.cxx
@@ -173,7 +173,7 @@ XMLImageMapObjectContext::XMLImageMapObjectContext(
 void XMLImageMapObjectContext::StartElement(
 const Reference& xAttrList )
 {
-SvXMLTokenMap aMap(aImageMapObjectTokenMap);
+static const SvXMLTokenMap aMap(aImageMapObjectTokenMap);
 
 sal_Int16 nLength = xAttrList->getLength();
 for(sal_Int16 nAttr = 0; nAttr < nLength; nAttr++)
diff --git a/xmloff/source/style/DashStyle.cxx 
b/xmloff/source/style/DashStyle.cxx
index d940a143dd65..353591ba963c 100644
--- a/xmloff/source/style/DashStyle.cxx
+++ b/xmloff/source/style/DashStyle.cxx
@@ -104,7 +104,7 @@ void XMLDashStyleImport::importXML(
 SvXMLNamespaceMap& rNamespaceMap = rImport.GetNamespaceMap();
 SvXMLUnitConverter& rUnitConverter = rImport.GetMM100UnitConverter();
 
-SvXMLTokenMap aTokenMap( aDashStyleAttrTokenMap );
+static const SvXMLTokenMap aTokenMap( aDashStyleAttrTokenMap );
 
 sal_Int16 nAttrCount = xAttrList.is() ? xAttrList->getLength() : 0;
 for( sal_Int16 i=0; i < nAttrCount; i++ )
diff --git a/xmloff/source/style/GradientStyle.cxx 
b/xmloff/source/style/GradientStyle.cxx
index 8feb95d56c8f..ed3d5dad1323 100644
--- a/xmloff/source/style/GradientStyle.cxx
+++ b/xmloff/source/style/GradientStyle.cxx
@@ -111,7 +111,7 @@ void XMLGradientStyleImport::importXML(
 aGradient.Angle = 0;
 aGradient.Border = 0;
 
-SvXMLTokenMap aTokenMap( aGradientAttrTokenMap );
+static const SvXMLTokenMap aTokenMap( aGradientAttrTokenMap );
 SvXMLNamespaceMap& rNamespaceMap = rImport.GetNamespaceMap();
 
 sal_Int16 nAttrCount = xAttrList.is() ? xAttrList->getLength() : 0;
diff --git a/xmloff/source/style/HatchStyle.cxx 
b/xmloff/source/style/HatchStyle.cxx
index 

[Libreoffice-commits] core.git: 2 commits - include/svl include/svx svl/source vcl/source

[Noel Grandin (via logerrit)]

 include/svl/custritm.hxx   |2 +
 include/svx/xbtmpit.hxx|2 +
 include/svx/xcolit.hxx |2 +
 include/svx/xflgrit.hxx|2 +
 include/svx/xflhtit.hxx|2 +
 include/svx/xlndsit.hxx|2 +
 include/svx/xlnedit.hxx|2 +
 include/svx/xlnstit.hxx|2 +
 svl/source/items/custritm.cxx  |   11 ++-
 vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx |   31 -
 10 files changed, 38 insertions(+), 20 deletions(-)

New commits:
commit beacd77aa985ed90532cd5fdd7b56314c0a7b0eb
Author: Noel Grandin 
AuthorDate: Sat Apr 27 09:43:28 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Apr 29 08:30:07 2019 +0200

optimise ImplScaleConvolutionVer a little

cache the reading of the source scan line, and use sal_Int32 for pixels
and counts (long is 64-bit on 64-bit linux)

Change-Id: Iaa0abc3ed3316d3137184b0c051612874885ddf4
Reviewed-on: https://gerrit.libreoffice.org/71462
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx 
b/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx
index 7375d0260dfb..389b2a3b11b3 100644
--- a/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx
+++ b/vcl/source/bitmap/BitmapScaleConvolutionFilter.cxx
@@ -39,8 +39,8 @@ void ImplCalculateContributions(
 const long aDestinationSize,
 long& aNumberOfContributions,
 std::vector& rWeights,
-std::vector& rPixels,
-std::vector& rCounts,
+std::vector& rPixels,
+std::vector& rCounts,
 const Kernel& aKernel)
 {
 const double fSamplingRadius(aKernel.GetWidth());
@@ -103,8 +103,8 @@ bool ImplScaleConvolutionHor(Bitmap& rSource, Bitmap& 
rTarget, const double& rSc
 if(pReadAcc)
 {
 std::vector aWeights;
-std::vector aPixels;
-std::vector aCounts;
+std::vector aPixels;
+std::vector aCounts;
 long aNumberOfContributions(0);
 
 const long nHeight(rSource.GetSizePixel().Height());
@@ -191,8 +191,8 @@ bool ImplScaleConvolutionVer(Bitmap& rSource, Bitmap& 
rTarget, const double& rSc
 if(pReadAcc)
 {
 std::vector aWeights;
-std::vector aPixels;
-std::vector aCounts;
+std::vector aPixels;
+std::vector aCounts;
 long aNumberOfContributions(0);
 
 const long nWidth(rSource.GetSizePixel().Width());
@@ -203,8 +203,14 @@ bool ImplScaleConvolutionVer(Bitmap& rSource, Bitmap& 
rTarget, const double& rSc
 
 if(pWriteAcc)
 {
+std::vector aScanline(nHeight);
 for(long x(0); x < nWidth; x++)
 {
+for(long y(0); y < nHeight; y++)
+if(pReadAcc->HasPalette())
+aScanline[y] = 
pReadAcc->GetPaletteColor(pReadAcc->GetPixelIndex(y, x));
+else
+aScanline[y] = pReadAcc->GetPixel(y, x);
 for(long y(0); y < nNewHeight; y++)
 {
 const long aBaseIndex(y * aNumberOfContributions);
@@ -217,19 +223,8 @@ bool ImplScaleConvolutionVer(Bitmap& rSource, Bitmap& 
rTarget, const double& rSc
 {
 const long aIndex(aBaseIndex + j);
 const double aWeight(aWeights[aIndex]);
-BitmapColor aColor;
-
 aSum += aWeight;
-
-if(pReadAcc->HasPalette())
-{
-aColor = 
pReadAcc->GetPaletteColor(pReadAcc->GetPixelIndex(aPixels[aIndex], x));
-}
-else
-{
-aColor = pReadAcc->GetPixel(aPixels[aIndex], x);
-}
-
+const BitmapColor & aColor = 
aScanline[aPixels[aIndex]];
 aValueRed += aWeight * aColor.GetRed();
 aValueGreen += aWeight * aColor.GetGreen();
 aValueBlue += aWeight * aColor.GetBlue();
commit 24503d5ddfc0a83ac88aa23d03b69ed47f989e8e
Author: Noel Grandin 
AuthorDate: Fri Apr 26 18:59:17 2019 +0200
Commit: Noel Grandin 
CommitDate: Mon Apr 29 08:30:00 2019 +0200

tdf#63640 FILEOPEN/FILESAVE: particular .odt loads/saves very slow, part1

Make CntUnencodedStringItem sortable, implementing operator<.
This takes the load time from 4s to 3.3s

Change-Id: I532cdf65149a733d41d2caf367675800d2ba4d41
Reviewed-on: https://gerrit.libreoffice.org/71460
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svl/custritm.hxx b/include/svl/custritm.hxx
index 65facd5cd54e..3899df7b2fbc 100644
--- 

Re: is gerrit #26348 still somewhere?

[Kaganski Mike]

Hi,

On 29.04.2019 15:04, Eike Rathke wrote:
> Maybe changes marked as abandoned get purged after a while? I don't know.

... but definitely, if a user deletes a draft patch, without publishing 
it, it is deleted irreversibly (or at least irreversibly for the user).

-- 
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] dev-tools.git: uitest/mass-testing

[Libreoffice Gerrit user]

 uitest/mass-testing/calc.py |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit a76301ebdcfe1bf4ecf61ff5e24d993d7fd02265
Author: Xisco Fauli 
AuthorDate: Mon Apr 29 15:03:16 2019 +0200
Commit: Xisco Fauli 
CommitDate: Mon Apr 29 15:03:16 2019 +0200

mass-uitesting: deselect all sheets before using hide/show

diff --git a/uitest/mass-testing/calc.py b/uitest/mass-testing/calc.py
index a6911ad..f26591d 100755
--- a/uitest/mass-testing/calc.py
+++ b/uitest/mass-testing/calc.py
@@ -50,6 +50,9 @@ class massTesting(UITestCase):
 for i in range(nrSheets - 1):
 self.xUITest.executeCommand(".uno:JumpToPrevTable")
 
+#Just in case more than 1 sheet is selected
+self.xUITest.executeCommand(".uno:TableDeselectAll")
+
 # Make sure all sheets are visible
 self.xUITest.executeCommand(".uno:Hide")
 self.xUITest.executeCommand(".uno:Show")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/mcecchetti/accessibility/paragraph' - comphelper/source sc/source sw/source vcl/unx

[Marco Cecchetti (via logerrit)]

 comphelper/source/misc/accessibleeventnotifier.cxx   |9 
 sc/source/ui/Accessibility/AccessibleContextBase.cxx |4 
 sw/source/core/access/acccontext.cxx |   12 +
 vcl/unx/gtk/a11y/atklistener.cxx |2 
 vcl/unx/gtk/a11y/atkutil.cxx |  176 +--
 vcl/unx/gtk/a11y/atkwrapper.cxx  |4 
 6 files changed, 193 insertions(+), 14 deletions(-)

New commits:
commit f1bb63dc9688d82aa6b32f694d77760fc2a8f597
Author: Marco Cecchetti 
AuthorDate: Mon Apr 29 13:59:49 2019 +0200
Commit: Marco Cecchetti 
CommitDate: Mon Apr 29 14:04:22 2019 +0200

[DRAFT] - lok: AT - get current paragraph with formatting - 2

diff --git a/comphelper/source/misc/accessibleeventnotifier.cxx 
b/comphelper/source/misc/accessibleeventnotifier.cxx
index f14176a03528..704039ba12d4 100644
--- a/comphelper/source/misc/accessibleeventnotifier.cxx
+++ b/comphelper/source/misc/accessibleeventnotifier.cxx
@@ -22,6 +22,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -149,6 +151,9 @@ AccessibleEventNotifier::TClientId 
AccessibleEventNotifier::registerClient()
 // generate a new client id
 TClientId nNewClientId = generateId( );
 
+//if (nNewClientId < 40)
+//SAL_DEBUG("AccessibleEventNotifier::registerClient: nNewClientId: " << 
nNewClientId);
+
 // the event listeners for the new client
 ::comphelper::OInterfaceContainerHelper2 *const pNewListeners =
 new ::comphelper::OInterfaceContainerHelper2( lclMutex::get() );
@@ -225,6 +230,9 @@ sal_Int32 AccessibleEventNotifier::addEventListener(
 if ( _rxListener.is() )
 aClientPos->second->addInterface( _rxListener );
 
+//if (_nClient < 40)
+//SAL_DEBUG("AccessibleEventNotifier::addEventListener: _nClient: " << 
_nClient << ", _rxListener: " << _rxListener.get());
+
 return aClientPos->second->getLength();
 }
 
@@ -260,6 +268,7 @@ void AccessibleEventNotifier::addEvent( const TClientId 
_nClient, const Accessib
 aListeners = aClientPos->second->getElements();
 }
 
+//SAL_DEBUG("AccessibleEventNotifier::addEvent: client id: " << _nClient 
<< ", event id: " << _rEvent.EventId);
 // default handling: loop through all listeners, and notify them
 for ( const auto& rListener : aListeners )
 {
diff --git a/sc/source/ui/Accessibility/AccessibleContextBase.cxx 
b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
index 40fd9d9609d4..0ee734f18138 100644
--- a/sc/source/ui/Accessibility/AccessibleContextBase.cxx
+++ b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
@@ -32,6 +32,8 @@
 #include 
 #include 
 
+#include 
+
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::accessibility;
 
@@ -70,6 +72,8 @@ void ScAccessibleContextBase::Init()
 }
 msName = createAccessibleName();
 msDescription = createAccessibleDescription();
+
+SAL_DEBUG("ScAccessibleContextBase::Init: this: " << this << ", msName: " 
<< msName << ", msDescription: " << msDescription);
 }
 
 void SAL_CALL ScAccessibleContextBase::disposing()
diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index 4f18aa6ed6b5..445dd7474626 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -1166,6 +1166,11 @@ void SwAccessibleContext::InvalidateChildPosOrSize(
 // nothing to do;
 return;
 }
+SAL_DEBUG("SwAccessibleContext this: " << this
+<< ", role: " << getAccessibleRole()
+<< ", name: " << getAccessibleName()
+<< ", parent: " << getAccessibleParent().get()
+<< ", child count: " << getAccessibleChildCount());
 
 const bool bVisibleChildrenOnly = SwAccessibleChild( GetFrame() 
).IsVisibleChildrenOnly();
 const bool bNew = rOldFrame.IsEmpty() ||
@@ -1182,6 +1187,13 @@ void SwAccessibleContext::InvalidateChildPosOrSize(
 // The frame becomes visible. A child event must be send.
 ::rtl::Reference< SwAccessibleContext > xAccImpl =
 GetMap()->GetContextImpl( rChildFrameOrObj.GetSwFrame() );
+
+SAL_DEBUG("SwAccessibleContext xAccImpl: " << xAccImpl.get()
+<< ", role: " << xAccImpl->getAccessibleRole()
+<< ", name: " << xAccImpl->getAccessibleName()
+<< ", parent: " << 
xAccImpl->getAccessibleParent().get()
+<< ", child count: " << 
xAccImpl->getAccessibleChildCount());
+
 xAccImpl->ScrolledIn();
 }
 else if ( rChildFrameOrObj.GetDrawObject() )
diff --git a/vcl/unx/gtk/a11y/atklistener.cxx b/vcl/unx/gtk/a11y/atklistener.cxx
index 24f01691d0dc..150f1ce8346e 100644
--- a/vcl/unx/gtk/a11y/atklistener.cxx
+++ b/vcl/unx/gtk/a11y/atklistener.cxx
@@ -481,7 +481,7 @@ void AtkListener::notifyEvent( const 
accessibility::AccessibleEventObject& aEven
  

Re: is gerrit #26348 still somewhere?

[Eike Rathke]

Hi Winfried,

On Friday, 2019-04-26 08:02:34 +, Winfried Donkers wrote:

> I know the gerrit change number, 26348, and that one comment is dated 16 
> June, 2016. The link in the mail of that comment (To view, visit 
> https://gerrit.libreoffice.org/26348) does not work for me.

It might be you submitted the change as draft under a different gerrit
account, drafts are not visible to other accounts unless explicitly
added as reviewers. I would had thought though that I was on reviewer Cc
and I just tried and couldn't access it either.

Maybe changes marked as abandoned get purged after a while? I don't know.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: is gerrit #26348 still somewhere?

[Christian Lohmaier]

Hi Winfried, *,

On Fri, Apr 26, 2019 at 9:04 AM Winfried Donkers
 wrote:
>
> I am working on tdf#124710, which means that I need to convert functions IFS 
> and SWITCH to 'jump functions'. I tried this before, but abandoned my work, 
> which was in gerrit #26348.
>
> Somehow I cannot retrieve that 'commit'.
>
> Is there any way to retrieve it (so that I can read the comments and 
> changes), or does it really no longer exist?

Not on gerrit anymore, but is available on jenkins mirror...

Attached is the change v1 - if there was a second revision, then that is lost.

ciao
Christian
commit 44ae1f7586d0a038d6f41b5a0c01fc1275009c24
Author: Winfried Donkers 
Date:   Thu Jun 16 09:00:58 2016 +0200

Convert ScInterpreter::ScIfs_MS() and ScSwitch_MS() to jump functions.

Current situation:
All seems to work well, except when any argument (other than the first)
contains a function or expression. See comment above ScSwitch_MS() in
interpr1.cxx. The 'test code' in ScSwitch_MS() was used to get the results
in the comment.

How do I recognise that an argument is an expression? I think I need to
know that first to be able to handle that argument correctly.

I left the trace code in, but renamed SAL_DEBUG to SAL__DEBUG to get the
code accepted by git.

Change-Id: I879a211dc525502f4730d67215b324e30ed54955

diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx
index 675da4bb422a..d84d2c5409a0 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -930,6 +930,8 @@ bool FormulaCompiler::IsOpCodeJumpCommand( OpCode eOp )
 case ocIfError:
 case ocIfNA:
 case ocChoose:
+case ocIfs_MS:
+case ocSwitch_MS:
 return true;
 default:
 ;
@@ -1540,6 +1542,8 @@ void FormulaCompiler::Factor()
 pFacToken->GetJump()[ 0 ] = 3;  // if, else, behind
 break;
 case ocChoose:
+case ocIfs_MS:
+case ocSwitch_MS:
 pFacToken->GetJump()[ 0 ] = FORMULA_MAXJUMPCOUNT + 1;
 break;
 case ocIfError:
@@ -1572,6 +1576,8 @@ void FormulaCompiler::Factor()
 nJumpMax = 3;
 break;
 case ocChoose:
+case ocIfs_MS:
+case ocSwitch_MS:
 nJumpMax = FORMULA_MAXJUMPCOUNT;
 break;
 case ocIfError:
@@ -1611,6 +1617,8 @@ void FormulaCompiler::Factor()
 bLimitOk = (nJumpCount <= 3);
 break;
 case ocChoose:
+case ocIfs_MS:
+case ocSwitch_MS:
 bLimitOk = (nJumpCount < FORMULA_MAXJUMPCOUNT);
 break;
 case ocIfError:
diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx
index 9c16870ea6fa..d49dd01b590a 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -85,7 +85,8 @@ bool FormulaToken::IsFunction() const
 eOp != ocTableRef &&
(GetByte() != 0  // x parameters
 || (SC_OPCODE_START_NO_PAR <= eOp && eOp < SC_OPCODE_STOP_NO_PAR)   // no parameter
-|| (ocIf == eOp || ocIfError == eOp || ocIfNA == eOp || ocChoose == eOp ) // @ jump commands
+|| (ocIf == eOp || ocIfError == eOp || ocIfNA == eOp ||
+ocChoose == eOp || ocIfs_MS == eOp || ocSwitch_MS == eOp )   // @ jump commands
 || (SC_OPCODE_START_1_PAR <= eOp && eOp < SC_OPCODE_STOP_1_PAR) // one parameter
 || (SC_OPCODE_START_2_PAR <= eOp && eOp < SC_OPCODE_STOP_2_PAR) // x parameters (cByte==0 in
 // FuncAutoPilot)
@@ -101,10 +102,11 @@ sal_uInt8 FormulaToken::GetParamCount() const
 {
 if ( eOp < SC_OPCODE_STOP_DIV && eOp != ocExternal && eOp != ocMacro &&
  eOp != ocIf && eOp != ocIfError && eOp != ocIfNA && eOp != ocChoose &&
- eOp != ocPercentSign )
+ eOp != ocIfs_MS && eOp != ocSwitch_MS && eOp != ocPercentSign )
 return 0;   // parameters and specials
-// ocIf, ocIfError, ocIfNA and ocChoose not for FAP, have cByte then
-//2do: bool parameter whether FAP or not?
+// ocIf, ocIfError, ocIfNA, ocChoose, ocIfs_MS and ocSwitch_MS not for FAP,
+// have cByte then
+// todo : bool parameter whether FAP or not?
 else if ( GetByte() )
 return GetByte();   // all functions, also ocExternal and ocMacro
 else if (SC_OPCODE_START_BIN_OP <= eOp && eOp < SC_OPCODE_STOP_BIN_OP)
@@ -116,7 +118,8 @@ sal_uInt8 FormulaToken::GetParamCount() const
 return 

[Libreoffice-commits] core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 56b7d6c40c698a4be4a228d34792dd70f251054d
Author: Ilmari Lauhakangas 
AuthorDate: Mon Apr 29 15:43:53 2019 +0300
Commit: Gerrit Code Review 
CommitDate: Mon Apr 29 16:54:06 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Limit the scope of getting class names for index titles

Change-Id: I2d586605118032aaf38ff70d420bc7c2bf4979ae
Reviewed-on: https://gerrit.libreoffice.org/71529
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 0615e893e70b..de68dd22d495 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0615e893e70bfb8a0f3fe9d86361da5faaa3dd72
+Subproject commit de68dd22d495f86837eda91277af0961c57696e2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: help3xsl/help.js

[Libreoffice Gerrit user]

 help3xsl/help.js |   13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)

New commits:
commit de68dd22d495f86837eda91277af0961c57696e2
Author: Ilmari Lauhakangas 
AuthorDate: Mon Apr 29 15:43:53 2019 +0300
Commit: Olivier Hallot 
CommitDate: Mon Apr 29 16:54:06 2019 +0200

Limit the scope of getting class names for index titles

Change-Id: I2d586605118032aaf38ff70d420bc7c2bf4979ae
Reviewed-on: https://gerrit.libreoffice.org/71529
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/help.js b/help3xsl/help.js
index 59dd378c7..2767b157f 100644
--- a/help3xsl/help.js
+++ b/help3xsl/help.js
@@ -22,7 +22,8 @@ if(url.indexOf('explorer/database/') !== -1) {
 var results = null;
 var fullLinkified = '';
 var modules = ['CALC', 'WRITER', 'IMPRESS', 'DRAW', 'BASE', 'MATH', 'CHART', 
'BASIC', 'SHARED'];
-var indexkids = function() { 
document.getElementsByClassName("index")[0].children; };
+var index = document.getElementsByClassName("index")[0];
+var indexkids = index.children;
 // if user is not on a shared category page, limit the index to the current 
module + shared
 if(currentModule !== 'HARED') {
 bookmarks = bookmarks.filter(function(obj) {
@@ -33,9 +34,9 @@ bookmarks.forEach(function(obj) {
 fullLinkified += '' + obj['text'] + '';
 });
 function fullList() {
-document.getElementsByClassName("index")[0].innerHTML = fullLinkified;
+index.innerHTML = fullLinkified;
 addIds();
-Paginator(document.getElementsByClassName("index")[0]);
+Paginator(index);
 }
 // add id to the first items of each category in the index. CSS ::before rule 
adds the heading text
 function addIds() {
@@ -43,7 +44,7 @@ function addIds() {
 indexkids[i].removeAttribute("id");
 }
 modules.forEach(function(module) {
-var moduleHeader = document.getElementsByClassName(module)[0];
+var moduleHeader = index.getElementsByClassName(module)[0];
 if (typeof moduleHeader !== 'undefined') {
 // let's wrap the header in a span, so the ::before element will 
not become a link
 moduleHeader.outerHTML = '' + moduleHeader.outerHTML + '';
@@ -65,9 +66,9 @@ var filter = function() {
 results.forEach(function(result) {
 filtered += '' + fuzzysort.highlight(result) + '';
 });
-document.getElementsByClassName("index")[0].innerHTML = filtered;
+index.innerHTML = filtered;
 addIds();
-Paginator(document.getElementsByClassName("index")[0]);
+Paginator(index);
 };
 function debounce(fn, wait) {
 var timeout;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/source

[Miklos Vajna (via logerrit)]

 xmlsecurity/source/helper/xsecctl.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f5f8891d823f01090853217479de584f940de459
Author: Miklos Vajna 
AuthorDate: Mon Apr 29 16:13:36 2019 +0200
Commit: Miklos Vajna 
CommitDate: Mon Apr 29 16:13:36 2019 +0200

xmlsecurity: fix the Android build

Change-Id: Ib04060ee4dc2a4ece2858548690e8ef182bf00b1

diff --git a/xmlsecurity/source/helper/xsecctl.cxx 
b/xmlsecurity/source/helper/xsecctl.cxx
index f4ff8a156f47..4a0778ca6329 100644
--- a/xmlsecurity/source/helper/xsecctl.cxx
+++ b/xmlsecurity/source/helper/xsecctl.cxx
@@ -33,6 +33,9 @@
 #include 
 #include 

 #include 
+#ifdef ANDROID
+#include 
+#endif
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

[Stephan Bergmann (via logerrit)]

 sc/inc/strings.hrc |1 -
 sc/source/ui/inc/conflictsdlg.hxx  |1 -
 sc/source/ui/miscdlgs/conflictsdlg.cxx |1 -
 3 files changed, 3 deletions(-)

New commits:
commit 0d5ae0b0e88e30b7c196613bd0b8f3d3eb18674a
Author: Stephan Bergmann 
AuthorDate: Mon Apr 29 12:33:35 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 29 14:03:33 2019 +0200

-Werror,-Wunused-private-field

Change-Id: Ie6aeff552b13d2b9abe38c178a4f467d47fc0ca5
Reviewed-on: https://gerrit.libreoffice.org/71520
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sc/inc/strings.hrc b/sc/inc/strings.hrc
index dcceddab3190..3a5e2710aed0 100644
--- a/sc/inc/strings.hrc
+++ b/sc/inc/strings.hrc
@@ -182,7 +182,6 @@
 #define SCSTR_QHELP_EXPAND_FORMULA  
NC_("SCSTR_QHELP_EXPAND_FORMULA", "Expand Formula Bar")
 #define SCSTR_QHELP_COLLAPSE_FORMULA
NC_("SCSTR_QHELP_COLLAPSE_FORMULA", "Collapse Formula Bar")
 
-#define STR_TITLE_CONFLICT  NC_("STR_TITLE_CONFLICT", 
"Conflict")
 #define STR_TITLE_AUTHORNC_("STR_TITLE_AUTHOR", 
"Author")
 #define STR_TITLE_DATE  NC_("STR_TITLE_DATE", 
"Date")
 #define STR_UNKNOWN_USER_CONFLICT   
NC_("STR_UNKNOWN_USER_CONFLICT", "Unknown User")
diff --git a/sc/source/ui/inc/conflictsdlg.hxx 
b/sc/source/ui/inc/conflictsdlg.hxx
index 433d4584b140..4f32a398d0de 100644
--- a/sc/source/ui/inc/conflictsdlg.hxx
+++ b/sc/source/ui/inc/conflictsdlg.hxx
@@ -114,7 +114,6 @@ public:
 class ScConflictsDlg : public weld::GenericDialogController
 {
 private:
-OUString const  maStrTitleConflict;
 OUString const  maStrUnknownUser;
 
 ScViewData* const   mpViewData;
diff --git a/sc/source/ui/miscdlgs/conflictsdlg.cxx 
b/sc/source/ui/miscdlgs/conflictsdlg.cxx
index 95e2a285c381..28d69d0421ba 100644
--- a/sc/source/ui/miscdlgs/conflictsdlg.cxx
+++ b/sc/source/ui/miscdlgs/conflictsdlg.cxx
@@ -331,7 +331,6 @@ void ScConflictsResolver::HandleAction( ScChangeAction* 
pAction, bool bIsSharedA
 
 ScConflictsDlg::ScConflictsDlg(weld::Window* pParent, ScViewData* pViewData, 
ScDocument* pSharedDoc, ScConflictsList& rConflictsList)
 : GenericDialogController(pParent, "modules/scalc/ui/conflictsdialog.ui", 
"ConflictsDialog")
-, maStrTitleConflict ( ScResId( STR_TITLE_CONFLICT ) )
 , maStrUnknownUser   ( ScResId( STR_UNKNOWN_USER_CONFLICT ) )
 , mpViewData ( pViewData )
 , mpOwnDoc   ( nullptr )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: hwpfilter/source soltools/mkdepend

[Stephan Bergmann (via logerrit)]

 hwpfilter/source/hstyle.cxx |2 +-
 soltools/mkdepend/include.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit df5d1e47c33a8b9bf2b9783d5338f8432827a760
Author: Stephan Bergmann 
AuthorDate: Mon Apr 29 12:35:40 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Mon Apr 29 14:27:56 2019 +0200

Fix conditional around closing #pragma GCC diagnostic pop

...which 7cf3574ac9208e70c03eeaca2def0235ec90f55f "Avoid
-Werror=format/stringop-truncation" had failed to adapt

Change-Id: Ide00c8136db27519c2d694576910c423d40d481e
Reviewed-on: https://gerrit.libreoffice.org/71521
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/hwpfilter/source/hstyle.cxx b/hwpfilter/source/hstyle.cxx
index 1848067f14df..8950cb46fb67 100644
--- a/hwpfilter/source/hstyle.cxx
+++ b/hwpfilter/source/hstyle.cxx
@@ -74,7 +74,7 @@ void HWPStyle::SetName(int n, char const *name)
 auto const p = DATA[n].name;
 strncpy(p, name, MAXSTYLENAME);
 p[MAXSTYLENAME] = '\0'; // just in case, even though the array is 
zero-initialized
-#if defined __GNUC__ && __GNUC__ == 8 && __GNUC_MINOR__ == 2 && !defined 
__clang__
+#if defined __GNUC__ && __GNUC__ == 8 && (__GNUC_MINOR__ == 2 || 
__GNUC_MINOR__ == 3) && !defined __clang__
 #pragma GCC diagnostic pop
 #endif
 }
diff --git a/soltools/mkdepend/include.c b/soltools/mkdepend/include.c
index 27f20f40fb98..c95af5451b47 100644
--- a/soltools/mkdepend/include.c
+++ b/soltools/mkdepend/include.c
@@ -249,7 +249,7 @@ int issymbolic(char *dir, char *component)
 // silence "‘snprintf’ output may be truncated before the last format 
character"
 #endif
 int n = snprintf(buf, BUFSIZ, "%s%s%s", dir, *dir ? "/" : "", component);
-#if defined __GNUC__ && __GNUC__ == 8 && __GNUC_MINOR__ == 2 && !defined 
__clang__
+#if defined __GNUC__ && __GNUC__ == 8 && (__GNUC_MINOR__ == 2 || 
__GNUC_MINOR__ == 3) && !defined __clang__
 #pragma GCC diagnostic pop
 #endif
 assert(n < BUFSIZ);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - sw/qa sw/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/textinput.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport12.cxx  |   11 +++
 sw/source/filter/ww8/docxexport.cxx |6 --
 3 files changed, 15 insertions(+), 2 deletions(-)

New commits:
commit 72131204cadbd20678a41b1da910bf66740c0886
Author: Vasily Melenchuk 
AuthorDate: Mon Apr 15 17:22:04 2019 +0300
Commit: Thorsten Behrens 
CommitDate: Mon Apr 29 15:19:59 2019 +0200

docx export: implement text-input field export

It is expected that  will be converted to
{FORMTEXT} MS field, but practical implementation was
missing.

Reviewed-on: https://gerrit.libreoffice.org/70786
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

 Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx

Change-Id: Ifd17a523e253555a240f853bea5f21572d90d853
Reviewed-on: https://gerrit.libreoffice.org/71506
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ooxmlexport/data/textinput.odt 
b/sw/qa/extras/ooxmlexport/data/textinput.odt
new file mode 100644
index ..04b8d054c354
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/textinput.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
index d7d41b1d1e36..25fc6b4d69f7 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport12.cxx
@@ -771,6 +771,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf105444, "tdf105444.docx")
 assertXPath(pXmlComm, "/w:comments/w:comment/w:p", 1);
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTextInput, "textinput.odt")
+{
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+return;
+// Ensure we have a formfield
+assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[3]/w:instrText", " 
FORMTEXT ");
+// and it's content is not gone
+assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[5]/w:t", 
"SomeText");
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/docxexport.cxx 
b/sw/source/filter/ww8/docxexport.cxx
index cd52c0768833..e4a2d274544e 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -375,9 +375,11 @@ void DocxExport::DoComboBox(const OUString& rName,
 m_pDocumentFS->endElementNS( XML_w, XML_ffData );
 }
 
-void DocxExport::DoFormText(const SwInputField* /*pField*/)
+void DocxExport::DoFormText(const SwInputField* pField)
 {
-SAL_INFO("sw.ww8", "TODO DocxExport::ForFormText()" );
+assert(pField);
+const OUString sStr = FieldString(ww::eFORMTEXT);
+OutputField(pField, ww::eFORMTEXT, sStr);
 }
 
 OString DocxExport::OutputChart( uno::Reference< frame::XModel > const & 
xModel, sal_Int32 nCount, ::sax_fastparser::FSHelperPtr const & m_pSerializer )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/filter/html/htmltab.cxx |   96 +++---
 1 file changed, 48 insertions(+), 48 deletions(-)

New commits:
commit 73df787fe2c66d16cec08d28e383a72fe3855bfd
Author: Miklos Vajna 
AuthorDate: Mon Apr 29 13:15:01 2019 +0200
Commit: Miklos Vajna 
CommitDate: Mon Apr 29 14:50:03 2019 +0200

sw: prefix members of HTMLTableCell

Change-Id: I4ed4307b5c4f820be1b25ffa0372cc30c97c85d7
Reviewed-on: https://gerrit.libreoffice.org/71522
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/source/filter/html/htmltab.cxx 
b/sw/source/filter/html/htmltab.cxx
index 6fd76d4f2aa4..729513c1573c 100644
--- a/sw/source/filter/html/htmltab.cxx
+++ b/sw/source/filter/html/htmltab.cxx
@@ -215,17 +215,17 @@ class HTMLTableCell
 std::shared_ptr m_xBGBrush; // cell background
 std::shared_ptr m_xBoxItem;
 
-double nValue;
-sal_uInt32 nNumFormat;
-sal_uInt16 nRowSpan;   // cell ROWSPAN
-sal_uInt16 nColSpan;   // cell COLSPAN
-sal_uInt16 nWidth; // cell WIDTH
-sal_Int16 eVertOri; // vertical alignment of the cell
-bool bProtected : 1;   // cell must not filled
-bool bRelWidth : 1;// nWidth is given in %
-bool bHasNumFormat : 1;
-bool bHasValue : 1;
-bool bNoWrap : 1;
+double m_nValue;
+sal_uInt32 m_nNumFormat;
+sal_uInt16 m_nRowSpan;   // cell ROWSPAN
+sal_uInt16 m_nColSpan;   // cell COLSPAN
+sal_uInt16 m_nWidth; // cell WIDTH
+sal_Int16 m_eVertOrient; // vertical alignment of the cell
+bool m_bProtected : 1;   // cell must not filled
+bool m_bRelWidth : 1;// nWidth is given in %
+bool m_bHasNumFormat : 1;
+bool m_bHasValue : 1;
+bool m_bNoWrap : 1;
 bool mbCovered : 1;
 
 public:
@@ -247,11 +247,11 @@ public:
 const std::shared_ptr& GetContents() const { return 
m_xContents; }
 
 // Set/Get cell ROWSPAN/COLSPAN
-void SetRowSpan( sal_uInt16 nRSpan ) { nRowSpan = nRSpan; }
-sal_uInt16 GetRowSpan() const { return nRowSpan; }
+void SetRowSpan( sal_uInt16 nRSpan ) { m_nRowSpan = nRSpan; }
+sal_uInt16 GetRowSpan() const { return m_nRowSpan; }
 
-void SetColSpan( sal_uInt16 nCSpan ) { nColSpan = nCSpan; }
-sal_uInt16 GetColSpan() const { return nColSpan; }
+void SetColSpan( sal_uInt16 nCSpan ) { m_nColSpan = nCSpan; }
+sal_uInt16 GetColSpan() const { return m_nColSpan; }
 
 inline void SetWidth( sal_uInt16 nWidth, bool bRelWidth );
 
@@ -261,10 +261,10 @@ public:
 inline bool GetNumFormat( sal_uInt32& rNumFormat ) const;
 inline bool GetValue( double& rValue ) const;
 
-sal_Int16 GetVertOri() const { return eVertOri; }
+sal_Int16 GetVertOri() const { return m_eVertOrient; }
 
 // Is the cell filled or protected ?
-bool IsUsed() const { return m_xContents || bProtected; }
+bool IsUsed() const { return m_xContents || m_bProtected; }
 
 std::unique_ptr CreateLayoutInfo();
 
@@ -689,17 +689,17 @@ const std::shared_ptr& 
HTMLTableCnts::CreateLayoutInfo()
 }
 
 HTMLTableCell::HTMLTableCell():
-nValue(0),
-nNumFormat(0),
-nRowSpan(1),
-nColSpan(1),
-nWidth( 0 ),
-eVertOri( text::VertOrientation::NONE ),
-bProtected(false),
-bRelWidth( false ),
-bHasNumFormat(false),
-bHasValue(false),
-bNoWrap(false),
+m_nValue(0),
+m_nNumFormat(0),
+m_nRowSpan(1),
+m_nColSpan(1),
+m_nWidth( 0 ),
+m_eVertOrient( text::VertOrientation::NONE ),
+m_bProtected(false),
+m_bRelWidth( false ),
+m_bHasNumFormat(false),
+m_bHasValue(false),
+m_bNoWrap(false),
 mbCovered(false)
 {}
 
@@ -710,26 +710,26 @@ void HTMLTableCell::Set( std::shared_ptr 
const& rCnts, sal_uInt16
  bool bNWrap, bool bCovered )
 {
 m_xContents = rCnts;
-nRowSpan = nRSpan;
-nColSpan = nCSpan;
-bProtected = false;
-eVertOri = eVert;
+m_nRowSpan = nRSpan;
+m_nColSpan = nCSpan;
+m_bProtected = false;
+m_eVertOrient = eVert;
 m_xBGBrush = rBrush;
 m_xBoxItem = rBoxItem;
 
-bHasNumFormat = bHasNF;
-bHasValue = bHasV;
-nNumFormat = nNF;
-nValue = nVal;
+m_bHasNumFormat = bHasNF;
+m_bHasValue = bHasV;
+m_nNumFormat = nNF;
+m_nValue = nVal;
 
-bNoWrap = bNWrap;
+m_bNoWrap = bNWrap;
 mbCovered = bCovered;
 }
 
 inline void HTMLTableCell::SetWidth( sal_uInt16 nWdth, bool bRelWdth )
 {
-nWidth = nWdth;
-bRelWidth = bRelWdth;
+m_nWidth = nWdth;
+m_bRelWidth = bRelWdth;
 }
 
 void HTMLTableCell::SetProtected()
@@ -743,21 +743,21 @@ void HTMLTableCell::SetProtected()
 if (m_xBGBrush)
 m_xBGBrush.reset(new SvxBrushItem(*m_xBGBrush));
 
-nRowSpan = 1;
-nColSpan = 1;
-bProtected = true;
+m_nRowSpan = 1;
+m_nColSpan = 1;
+m_bProtected = true;
 }
 
 inline bool HTMLTableCell::GetNumFormat( 

Re: Myanmar dictionary

[Eike Rathke]

Hi Cyrille,

On Saturday, 2019-04-27 18:06:20 +0200, Cyrille wrote:

> For dictionary on this link
> 
> I found an old extension with an hunspell dic for OpenOffice and it is
> probably possible to create a new extension for Libreoffice.

https://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/#OOoGr
talks about my-MMDict.oxt and says that would need some Myanmar word
break patches as well to work. It says "You only need the .diff patch
files" but doesn't list any .diff patch files (or I'm blind).

But since then years went by and maybe ICU word break does something
suiting now.

https://github.com/thanlwinsoft says "RIP Keith Stribley. 1976 - 2011"
so I guess he's dead and nothing will happen there. There's
https://github.com/thanlwinsoft/myoooext a "Myanmar line breaking and
spellchecking extension for OpenOffice.org" that you maybe could fork
and continue.

> I'm ready
> to do the work, but I couldn't maintain it. Would it be possible to add
> it directly to Libreoffice sources?

If nobody is going to maintain it then sticking it into LibO core
doesn't help either. For an extension then it would be better if it was
hosted at GitLab or GitHub so anyone willing could submit pull requests
(that you would have to handle), or fork and continue development.

> The same page says that the ui is translated but on Ubuntu I couldn't
> see the translation with the "my" locale. the
> http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
> page says too that graphite give this UI translation, then how to use it
> on LO?

You can't expect a translation of another version (specifically not OOo)
to work in a current LibreOffice version. Maybe Ubuntu doesn't offer
a 'my' language pack in its current version, I don't know.

LO has its (54%) Burmese 'my' translation, see
https://translations.documentfoundation.org/my/ and installation packs
are available, just choose the "need another language?" link on the
download page and look for Burmese.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/headless

[Michael Meeks (via logerrit)]

 vcl/headless/svpinst.cxx |   18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

New commits:
commit 065f603379efe669d6ab496e6b8659de88949487
Author: Michael Meeks 
AuthorDate: Sat Apr 27 22:23:03 2019 +0100
Commit: Michael Meeks 
CommitDate: Mon Apr 29 17:24:14 2019 +0200

unipoll: do the legacy wakeup if not in unipoll mode.

Change-Id: I7f5663f3316eb2bafcf13d07e2af69ae6f0637f5
Reviewed-on: https://gerrit.libreoffice.org/71445
Reviewed-by: Ashod Nakashian 
Tested-by: Jenkins

diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index a9c3488114fc..275ffc092735 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -374,8 +374,22 @@ sal_uInt32 SvpSalYieldMutex::doRelease(bool const 
bUnlockAll)
 // read m_nCount before doRelease
 bool const isReleased(bUnlockAll || m_nCount == 1);
 nCount = comphelper::SolarMutex::doRelease( bUnlockAll );
-if (isReleased && pInst)
-pInst->Wakeup(SvpRequest::NONE);
+
+if (isReleased)
+{
+ImplSVData* pSVData = ImplGetSVData();
+if (pSVData->mpPollCallback) // is unipoll
+{
+if (pInst)
+pInst->Wakeup(SvpRequest::NONE);
+}
+else
+{
+std::unique_lock g(m_WakeUpMainMutex);
+m_wakeUpMain = true;
+m_WakeUpMainCond.notify_one();
+}
+}
 }
 return nCount;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source sc/uiconfig solenv/sanitizers vcl/unx

[Caolán McNamara (via logerrit)]

 sc/inc/orcusfilters.hxx   |4 
 sc/inc/orcusxml.hxx   |   13 -
 sc/source/core/tool/orcusxml.cxx  |6 
 sc/source/filter/inc/orcusfiltersimpl.hxx |2 
 sc/source/filter/orcus/xmlcontext.cxx |   63 ++---
 sc/source/ui/inc/xmlsourcedlg.hxx |   75 +++---
 sc/source/ui/view/reffact.cxx |4 
 sc/source/ui/view/tabvwshc.cxx|   11 
 sc/source/ui/xmlsource/xmlsourcedlg.cxx   |  361 --
 sc/uiconfig/scalc/ui/xmlsourcedialog.ui   |  205 ++---
 solenv/sanitizers/ui/modules/scalc.false  |1 
 solenv/sanitizers/ui/modules/scalc.suppr  |4 
 vcl/unx/gtk3/gtk3gtkinst.cxx  |1 
 13 files changed, 376 insertions(+), 374 deletions(-)

New commits:
commit 260e5b61209b92e1583623d70b2ba3032b5ced14
Author: Caolán McNamara 
AuthorDate: Sun Apr 28 19:47:03 2019 +0100
Commit: Caolán McNamara 
CommitDate: Mon Apr 29 14:31:51 2019 +0200

weld ScXMLSourceDlg

Change-Id: If8894b7c432006f196e040571757943c940f13ea
Reviewed-on: https://gerrit.libreoffice.org/71489
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/orcusfilters.hxx b/sc/inc/orcusfilters.hxx
index 1f96d6ac1769..99f55306b226 100644
--- a/sc/inc/orcusfilters.hxx
+++ b/sc/inc/orcusfilters.hxx
@@ -13,11 +13,11 @@
 #include 
 
 class ScDocument;
-class SvTreeListBox;
 struct ScOrcusXMLTreeParam;
 struct ScOrcusImportXMLParam;
 class ScOrcusXMLContext;
 class SfxMedium;
+namespace weld { class TreeView; }
 
 /**
  * Collection of orcus filter wrappers.
@@ -60,7 +60,7 @@ class ScOrcusXMLContext
 public:
 virtual ~ScOrcusXMLContext() {}
 
-virtual void loadXMLStructure(SvTreeListBox& rTreeCtrl, 
ScOrcusXMLTreeParam& rParam) = 0;
+virtual void loadXMLStructure(weld::TreeView& rTreeCtrl, 
ScOrcusXMLTreeParam& rParam) = 0;
 
 virtual void importXML(const ScOrcusImportXMLParam& rParam) = 0;
 };
diff --git a/sc/inc/orcusxml.hxx b/sc/inc/orcusxml.hxx
index 2b8f94425f73..b635eca2d43d 100644
--- a/sc/inc/orcusxml.hxx
+++ b/sc/inc/orcusxml.hxx
@@ -17,7 +17,10 @@
 #include 
 #include 
 
-class SvTreeListEntry;
+namespace weld {
+class TreeIter;
+class TreeView;
+}
 
 /**
  * Parameter used during call to ScOrcusFilters::loadXMLStructure().
@@ -40,9 +43,9 @@ struct ScOrcusXMLTreeParam
 
 typedef std::vector> UserDataStoreType;
 
-Image maImgElementDefault;
-Image maImgElementRepeat;
-Image maImgAttribute;
+OUString maImgElementDefault;
+OUString maImgElementRepeat;
+OUString maImgAttribute;
 
 /**
  * Store all custom data instances since the tree control doesn't manage
@@ -50,7 +53,7 @@ struct ScOrcusXMLTreeParam
  */
 UserDataStoreType m_UserDataStore;
 
-static SC_DLLPUBLIC EntryData* getUserData(const SvTreeListEntry& rEntry);
+static SC_DLLPUBLIC EntryData* getUserData(const weld::TreeView& rControl, 
const weld::TreeIter& rEntry);
 };
 
 struct ScOrcusImportXMLParam
diff --git a/sc/source/core/tool/orcusxml.cxx b/sc/source/core/tool/orcusxml.cxx
index 13101973d2c6..1323362b4124 100644
--- a/sc/source/core/tool/orcusxml.cxx
+++ b/sc/source/core/tool/orcusxml.cxx
@@ -9,7 +9,7 @@
 
 #include 
 
-#include 
+#include 
 
 ScOrcusXMLTreeParam::EntryData::EntryData(EntryType eType)
 : mnNamespaceID(0)
@@ -19,9 +19,9 @@ ScOrcusXMLTreeParam::EntryData::EntryData(EntryType eType)
 , mbLeafNode(true)
 {}
 
-ScOrcusXMLTreeParam::EntryData* ScOrcusXMLTreeParam::getUserData(const 
SvTreeListEntry& rEntry)
+ScOrcusXMLTreeParam::EntryData* ScOrcusXMLTreeParam::getUserData(const 
weld::TreeView& rControl, const weld::TreeIter& rEntry)
 {
-return static_cast(rEntry.GetUserData());
+return 
reinterpret_cast(rControl.get_id(rEntry).toInt64());
 }
 
 ScOrcusImportXMLParam::CellLink::CellLink(const ScAddress& rPos, const 
OString& rPath) :
diff --git a/sc/source/filter/inc/orcusfiltersimpl.hxx 
b/sc/source/filter/inc/orcusfiltersimpl.hxx
index 1a27dc93ec1c..bef07a43e2dc 100644
--- a/sc/source/filter/inc/orcusfiltersimpl.hxx
+++ b/sc/source/filter/inc/orcusfiltersimpl.hxx
@@ -41,7 +41,7 @@ public:
 ScOrcusXMLContextImpl(ScDocument& rDoc, const OUString& rPath);
 virtual ~ScOrcusXMLContextImpl() override;
 
-virtual void loadXMLStructure(SvTreeListBox& rTreeCtrl, 
ScOrcusXMLTreeParam& rParam) override;
+virtual void loadXMLStructure(weld::TreeView& rTreeCtrl, 
ScOrcusXMLTreeParam& rParam) override;
 
 virtual void importXML(const ScOrcusImportXMLParam& rParam) override;
 };
diff --git a/sc/source/filter/orcus/xmlcontext.cxx 
b/sc/source/filter/orcus/xmlcontext.cxx
index 636e66271a7d..9cac43207cf4 100644
--- a/sc/source/filter/orcus/xmlcontext.cxx
+++ b/sc/source/filter/orcus/xmlcontext.cxx
@@ -15,6 +15,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -38,11 +39,11 @@ using namespace com::sun::star;
 
 namespace {
 
-ScOrcusXMLTreeParam::EntryData& 

[Libreoffice-commits] help.git: source/text

[Libreoffice Gerrit user]

 source/text/sbasic/python/python_document_events.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit caed5d5208b2c87fdf70a3d8618e66e72cf8ada2
Author: LibreOfficiant 
AuthorDate: Mon Apr 29 16:19:44 2019 +0200
Commit: Olivier Hallot 
CommitDate: Mon Apr 29 16:55:55 2019 +0200

Dropped parenthesis throws compiler error

Change-Id: Ib3179cd0d853e92e4b9ced7f3e504f27e88e6de3
Reviewed-on: https://gerrit.libreoffice.org/71536
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sbasic/python/python_document_events.xhp 
b/source/text/sbasic/python/python_document_events.xhp
index e2cf4562a..aa77ef63d 100644
--- a/source/text/sbasic/python/python_document_events.xhp
+++ b/source/text/sbasic/python/python_document_events.xhp
@@ -125,7 +125,7 @@
  
@staticmethod
  def 
log(level: str, text: str, msgBox=False):
  
 Append log message to console, optional user prompt 

- scr = 
Console._a2bScript(script=TraceLog
+ scr = 
Console._a2bScript(script=TraceLog)
  
scr.invoke((level,text,msgBox),(),())
  
@staticmethod
  def 
setLevel(logLevel: str):
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[LibreOfficiant (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0c500d3b8caa9b58f05c0ceb4d236f5878a06f6b
Author: LibreOfficiant 
AuthorDate: Mon Apr 29 16:19:44 2019 +0200
Commit: Gerrit Code Review 
CommitDate: Mon Apr 29 16:55:56 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - Dropped parenthesis throws compiler error

Change-Id: Ib3179cd0d853e92e4b9ced7f3e504f27e88e6de3
Reviewed-on: https://gerrit.libreoffice.org/71536
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index de68dd22d495..caed5d5208b2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit de68dd22d495f86837eda91277af0961c57696e2
+Subproject commit caed5d5208b2c87fdf70a3d8618e66e72cf8ada2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - vcl/inc

[Matthias Seidel (via logerrit)]

 vcl/inc/unx/x11_cursors/ase_mask.h  |1 +
 vcl/inc/unx/x11_cursors/null_curs.h |   10 +-
 vcl/inc/unx/x11_cursors/null_mask.h |   10 +-
 3 files changed, 11 insertions(+), 10 deletions(-)

New commits:
commit 22838948d7f1682bc8f892ba02c489edd617f269
Author: Matthias Seidel 
AuthorDate: Mon Apr 29 15:55:38 2019 +
Commit: Matthias Seidel 
CommitDate: Mon Apr 29 15:55:38 2019 +

Fixed error introduced in my last commit.

diff --git a/vcl/inc/unx/x11_cursors/null_curs.h 
b/vcl/inc/unx/x11_cursors/null_curs.h
index f99e0543e691..13ed507f74c6 100644
--- a/vcl/inc/unx/x11_cursors/null_curs.h
+++ b/vcl/inc/unx/x11_cursors/null_curs.h
@@ -20,9 +20,9 @@
  */
 
 
-#define null_curs_width 4
-#define null_curs_height 4
-#define null_curs_x_hot 2
-#define null_curs_y_hot 2
+#define nullcurs_width 4
+#define nullcurs_height 4
+#define nullcurs_x_hot 2
+#define nullcurs_y_hot 2
 
-static const unsigned char null_curs_bits[] = {0x00,0x00};
+static const unsigned char nullcurs_bits[] = {0x00,0x00};
diff --git a/vcl/inc/unx/x11_cursors/null_mask.h 
b/vcl/inc/unx/x11_cursors/null_mask.h
index ea648d54026f..5e4d6841e104 100644
--- a/vcl/inc/unx/x11_cursors/null_mask.h
+++ b/vcl/inc/unx/x11_cursors/null_mask.h
@@ -20,9 +20,9 @@
  */
 
 
-#define null_mask_width 4
-#define null_mask_height 4
-#define null_mask_x_hot 2
-#define null_mask_y_hot 2
+#define nullmask_width 4
+#define nullmask_height 4
+#define nullmask_x_hot 2
+#define nullmask_y_hot 2
 
-static const unsigned char null_mask_bits[] = {0x00,0x00};
+static const unsigned char nullmask_bits[] = {0x00,0x00};
commit 9ac6e891a23c99f06794473e43d24ddc3ce9a3a6
Author: Matthias Seidel 
AuthorDate: Mon Apr 29 15:49:19 2019 +
Commit: Matthias Seidel 
CommitDate: Mon Apr 29 15:49:19 2019 +

Fixed missing line

diff --git a/vcl/inc/unx/x11_cursors/ase_mask.h 
b/vcl/inc/unx/x11_cursors/ase_mask.h
index 9c2a3c2e7e63..e1610cdc983f 100644
--- a/vcl/inc/unx/x11_cursors/ase_mask.h
+++ b/vcl/inc/unx/x11_cursors/ase_mask.h
@@ -57,3 +57,4 @@ static const unsigned char ase_mask_bits[] = {
 0x00,0x00,0x00,0x00,
 0x00,0x00,0x00,0x00,
 0x00,0x00,0x00,0x00,
+0x00,0x00,0x00,0x00};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/headless

[Katarina Behrens (via logerrit)]

 vcl/headless/svpgdi.cxx |   20 +++-
 1 file changed, 7 insertions(+), 13 deletions(-)

New commits:
commit dc37b4babc3234df7e2bde67ac662324925f0e61
Author: Katarina Behrens 
AuthorDate: Fri Apr 26 17:12:41 2019 +0200
Commit: Caolán McNamara 
CommitDate: Mon Apr 29 18:30:05 2019 +0200

tdf#120797: Apply transformation also to the extents of damage

since 7034311dce663c895577267110baadbec312d491 affine transformation
is passed down to drawPolyPolygon and drawPolyLine functions.

The transformation was correctly applied to cairo context, but not
the extents of damage so those had old, untransformed coordinates and
were therefore not redrawn

Change-Id: I61ce005ef8770ce5c4560a9d953cd92f440043be
Reviewed-on: https://gerrit.libreoffice.org/71383
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

remove comment in light of fix for tdf#120797

Change-Id: I3093f764a26abdbdb651596352ba74b7fa1c3306
Reviewed-on: https://gerrit.libreoffice.org/71399
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/71511

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 3a785d642301..2e29518a7dac 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1143,6 +1143,9 @@ bool SvpSalGraphics::drawPolyLine(
 fMiterMinimumAngle,
 bPixelSnapHairline));
 
+// if transformation has been applied, transform also extents (ranges)
+// of damage so they can be correctly redrawn
+aExtents.transform(rObjectToDevice);
 releaseCairoContext(cr, false, aExtents);
 
 return bRetval;
@@ -1343,21 +1346,9 @@ bool SvpSalGraphics::drawPolyLine(
 }
 
 // extract extents
-if(nullptr != pExtents)
-{
-// This uses cairo_stroke_extents and combines with 
cairo_clip_extents, so
-// referring to Cairo-documentation:
-// "Computes a bounding box in user coordinates covering the area that 
would
-//  be affected, (the "inked" area), by a cairo_stroke() operation 
given the
-//  current path and stroke parameters."
-// It *should* use the current set cairo_matrix_t.
+if (pExtents)
 *pExtents = getClippedStrokeDamage(cr);
 
-// If not - the following code needs to be used to correct that:
-// if(!pExtents->isEmpty() && !bObjectToDeviceIsIdentity)
-// pExtents->transform(rObjectToDevice);
-}
-
 // draw and consume
 cairo_stroke(cr);
 
@@ -1490,6 +1481,9 @@ bool SvpSalGraphics::drawPolyPolygon(
 cairo_stroke_preserve(cr);
 }
 
+// if transformation has been applied, transform also extents (ranges)
+// of damage so they can be correctly redrawn
+extents.transform(rObjectToDevice);
 releaseCairoContext(cr, true, extents);
 
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - ucb/source

[Stephan Bergmann (via logerrit)]

 ucb/source/ucp/gio/gio_content.cxx |   52 -
 ucb/source/ucp/gio/gio_content.hxx |9 ++
 2 files changed, 38 insertions(+), 23 deletions(-)

New commits:
commit 41747b75076e4446947873b3edc2abe3e3c4ebd1
Author: Stephan Bergmann 
AuthorDate: Mon Apr 29 11:45:46 2019 +0200
Commit: Michael Stahl 
CommitDate: Mon Apr 29 18:43:51 2019 +0200

tdf#123472: Propagate getGFileInfo failure less aggressively

...from Content::getPropertyValues.  
ca0308797df86ebece19260f3ca438a0cb437208
"tdf#121337: Fail on GIO error in GIO UCP getPropertyValue" had made
Content::getPropertyValues fail for every getGFileInfo failure.  However, 
when
saving to a not-yet exisiting file, SfxMedium::Transfer_Impl
(sfx2/source/doc/docfile.cxx) requests the properties "Title" and "ObjectId"
from the Content representing the not-yet existing file, and apparently 
expects
those requests not to fail.  So restructure Content::getPropertyValues to 
only
call getGFileInfo when actually needed (that covers not failing for the 
unknown-
anyway "ObjecdtId" property), and handle "Title" specially by not failing 
for
a non-existing file.  (The documentation at 
offapi/com/sun/star/ucb/Content.idl
says for the "getPropertyValues" command that: "The execution will not be
aborted, if there are properties requested, that are unknown to the 
content."
But that leaves it somewhat unclear whether failure to obtain a known 
property
should be propagated.  It apparently should be in the context of tfd#121337
fixed previously, but apparently not for "Title" here.)

Change-Id: I12a9a5bd93d661922ea3b7b19a84a7e73e7e4b50
Reviewed-on: https://gerrit.libreoffice.org/71515
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 6d3dd64391e67e6cfe406dea047e13227ea94c4b)
Reviewed-on: https://gerrit.libreoffice.org/71525
Reviewed-by: Michael Stahl 

diff --git a/ucb/source/ucp/gio/gio_content.cxx 
b/ucb/source/ucp/gio/gio_content.cxx
index a581c34adb2a..a40576801424 100644
--- a/ucb/source/ucp/gio/gio_content.cxx
+++ b/ucb/source/ucp/gio/gio_content.cxx
@@ -425,12 +425,11 @@ static util::DateTime getDateFromUnix (time_t t)
 return util::DateTime();
 }
 
-uno::Reference< sdbc::XRow > Content::getPropertyValuesFromGFileInfo(GFileInfo 
*pInfo,
-const uno::Reference< uno::XComponentContext >& rxContext,
-const uno::Reference< ucb::XCommandEnvironment > & xEnv,
-const uno::Sequence< beans::Property >& rProperties)
+uno::Reference< sdbc::XRow > Content::getPropertyValues(
+const uno::Sequence< beans::Property >& rProperties,
+const uno::Reference< ucb::XCommandEnvironment >& xEnv )
 {
-rtl::Reference< ::ucbhelper::PropertyValueSet > xRow = new 
::ucbhelper::PropertyValueSet( rxContext );
+rtl::Reference< ::ucbhelper::PropertyValueSet > xRow = new 
::ucbhelper::PropertyValueSet( m_xContext );
 
 sal_Int32 nProps;
 const beans::Property* pProps;
@@ -438,12 +437,14 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 nProps = rProperties.getLength();
 pProps = rProperties.getConstArray();
 
+GFileInfo *pInfo = nullptr;
 for( sal_Int32 n = 0; n < nProps; ++n )
 {
 const beans::Property& rProp = pProps[ n ];
 
 if ( rProp.Name == "IsDocument" )
 {
+getFileInfo(xEnv, , true);
 if (pInfo != nullptr && g_file_info_has_attribute(pInfo, 
G_FILE_ATTRIBUTE_STANDARD_TYPE))
 xRow->appendBoolean( rProp, ( g_file_info_get_file_type( pInfo 
) == G_FILE_TYPE_REGULAR ||
g_file_info_get_file_type( 
pInfo ) == G_FILE_TYPE_UNKNOWN ) );
@@ -452,6 +453,7 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 }
 else if ( rProp.Name == "IsFolder" )
 {
+getFileInfo(xEnv, , true);
 if (pInfo != nullptr && g_file_info_has_attribute( pInfo, 
G_FILE_ATTRIBUTE_STANDARD_TYPE) )
 xRow->appendBoolean( rProp, ( g_file_info_get_file_type( pInfo 
) == G_FILE_TYPE_DIRECTORY ));
 else
@@ -459,6 +461,7 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 }
 else if ( rProp.Name == "Title" )
 {
+getFileInfo(xEnv, , false);
 if (pInfo != nullptr && g_file_info_has_attribute(pInfo, 
G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME))
 {
 const char *pName = g_file_info_get_display_name(pInfo);
@@ -469,6 +472,7 @@ uno::Reference< sdbc::XRow > 
Content::getPropertyValuesFromGFileInfo(GFileInfo *
 }
 else if ( rProp.Name == "IsReadOnly" )
 {
+getFileInfo(xEnv, , true);
 if (pInfo != nullptr && g_file_info_has_attribute( pInfo, 
G_FILE_ATTRIBUTE_ACCESS_CAN_WRITE ) )

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/moduldlg.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 5bb99883d383561d7c74f2f2a3cb41060137ebaf
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 19:30:34 2019 +0100
Commit: Michael Stahl 
CommitDate: Mon Apr 29 18:53:34 2019 +0200

Resolves: tdf#124984 organize basic macro new added module doesn't show up

Change-Id: I422131ab203eba62ed5cf6fb2e19e23325b43f6e
Reviewed-on: https://gerrit.libreoffice.org/71434
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/basctl/source/basicide/moduldlg.cxx 
b/basctl/source/basicide/moduldlg.cxx
index 1f525beb7c26..6626420f14cf 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -1128,8 +1128,10 @@ SbModule* createModImpl(weld::Window* pWin, const 
ScriptDocument& rDocument,
 bool bEntry = rBasicBox.FindEntry(aModName, 
OBJ_TYPE_MODULE, *xEntry);
 if (!bEntry)
 {
-rBasicBox.AddEntry(aModName, RID_BMP_MODULE, 
xEntry.get(), false,
+rBasicBox.AddEntry(aModName, RID_BMP_MODULE, 
xSubRootEntry.get(), false,

o3tl::make_unique(OBJ_TYPE_MODULE));
+rBasicBox.copy_iterator(*xSubRootEntry, *xEntry);
+rBasicBox.FindEntry(aModName, OBJ_TYPE_MODULE, 
*xEntry);
 }
 rBasicBox.set_cursor(*xEntry);
 rBasicBox.select(*xEntry);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svl/source

[Mike Kaganski (via logerrit)]

 svl/source/undo/undo.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f591bf522d2c63ad7f9fc87388671afbc16fbcd0
Author: Mike Kaganski 
AuthorDate: Mon Apr 29 19:25:42 2019 +0200
Commit: Mike Kaganski 
CommitDate: Mon Apr 29 20:56:09 2019 +0200

tdf#125030: Prevent double-clearing the guard

... discovered after after commit d38f9934f08939032cca64a32de58fa3901a88d5.

Change-Id: I09bcee0053d1a5132483c933a903f006a236a679
Reviewed-on: https://gerrit.libreoffice.org/71550
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx
index 7802985e6e1e..5cccb085d65f 100644
--- a/svl/source/undo/undo.cxx
+++ b/svl/source/undo/undo.cxx
@@ -871,6 +871,7 @@ bool SfxUndoManager::Repeat( SfxRepeatTarget  )
 aGuard.clear();
 if ( pAction->CanRepeat( rTarget ) )
 pAction->Repeat( rTarget );
+aGuard.reset(); // allow clearing in guard dtor
 return true;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 14c5af0ef085eb1fa03bfdcc47f4bc9505b31bad
Author: Caolán McNamara 
AuthorDate: Mon Apr 29 09:51:37 2019 +0100
Commit: Michael Stahl 
CommitDate: Mon Apr 29 18:48:28 2019 +0200

gtk_tree_model_iter_parent modifies the 1st arg, not 2nd

Change-Id: I015022c4dd68f152ef5e56947031ccf4bfaf2b1c
Reviewed-on: https://gerrit.libreoffice.org/71517
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index caec6ba5ac6c..a69e4df05806 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5470,7 +5470,6 @@ public:
 }
 if (!gtk_tree_model_iter_parent(pModel, , ))
 return false;
-tmp = iter;
 if (gtk_tree_model_iter_next(pModel, ))
 {
 rGtkIter.iter = tmp;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: l10ntools/source

[Eike Rathke (via logerrit)]

 l10ntools/source/ulfconv/msi-encodinglist.txt |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 0dcbc797a6cf7dc58ad17aae20bf0ccc7973cab1
Author: Eike Rathke 
AuthorDate: Mon Apr 29 16:02:55 2019 +0200
Commit: Eike Rathke 
CommitDate: Mon Apr 29 19:40:02 2019 +0200

Related: tdf#82184 correct wrong or obsoleted LCIDs for MSI

This solves the cases of Oromo, Kinyarwanda and Sinhala.

Kabyle is a problem on its own and apparently not easily solvable, see
attempts in https://gerrit.libreoffice.org/71247

Change-Id: Id001aeba07a95f283b4cd6057c1f6e8088de940a
Reviewed-on: https://gerrit.libreoffice.org/71535
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/l10ntools/source/ulfconv/msi-encodinglist.txt 
b/l10ntools/source/ulfconv/msi-encodinglist.txt
index 96f87341ae13..3c98165caae8 100644
--- a/l10ntools/source/ulfconv/msi-encodinglist.txt
+++ b/l10ntools/source/ulfconv/msi-encodinglist.txt
@@ -80,7 +80,7 @@ it   0  1040
 ja   0  1041
 jbo  0  1624
 ka   0  1079   # Georgian
-kab  0  1625
+kab  0  1625   # Kabyle
 kk   0  1087
 km   0  1107   # Khmer
 kmr-Latn 0  1574
@@ -116,7 +116,7 @@ nr   0  1580   # Ndebele South
 nso  0  1132
 ny   0  1598
 oc   0  1154   # Occitan-lengadocian
-om   0  2162
+om   0  1138   # Oromo
 or   0  1096   # Odia
 or-IN0  1096
 pa-IN0  1094   # Punjabi
@@ -130,13 +130,13 @@ qtz  0  1638   # key id pseudo language
 rm   0  1047   # Raeto-Romance
 ro   0  1048   # Romanian
 ru   0  1049
-rw   0  1569   # Kinyarwanda
+rw   0  1159   # Kinyarwanda
 sa-IN0  1103   # Sanskrit
 sat  0  1606   # Santali
 sb   0  1070   # Sorbian
 sc   0  3047
 sd   0  1113   # Sindhi
-si   0  2133
+si   0  1115   # Sinhala
 sid  0  1669   # Sidama, fake LCID
 sk   0  1051   # Slovak
 sl   0  1060   # Slovenian
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

[Katarina Behrens (via logerrit)]

 vcl/inc/qt5/Qt5DragAndDrop.hxx |2 ++
 vcl/qt5/Qt5DragAndDrop.cxx |   26 --
 2 files changed, 26 insertions(+), 2 deletions(-)

New commits:
commit cc6c1798b8d6d9d27dc40145e1ec71dd480c788a
Author: Katarina Behrens 
AuthorDate: Mon Apr 29 14:50:32 2019 +0200
Commit: Katarina Behrens 
CommitDate: Mon Apr 29 21:21:42 2019 +0200

tdf#124990: DnD operation can be set to fail in dropComplete

thus we reimplement it for Qt5DropTarget. This is qt5 remix of
tdf#118302 (in Calc drop into the same tab should cancel DnD, instead
of causing data loss)

Change-Id: Ib37ea5a018133779e85e8e131d81bb6cee7d9206
Reviewed-on: https://gerrit.libreoffice.org/71531
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/vcl/inc/qt5/Qt5DragAndDrop.hxx b/vcl/inc/qt5/Qt5DragAndDrop.hxx
index 099ba444ea15..3547131587f3 100644
--- a/vcl/inc/qt5/Qt5DragAndDrop.hxx
+++ b/vcl/inc/qt5/Qt5DragAndDrop.hxx
@@ -75,6 +75,8 @@ public:
 void fire_dragEnd(sal_Int8 nAction);
 
 static Qt5DragSource* m_ActiveDragSource;
+static bool m_bDropSuccessSet;
+static bool m_bDropSuccess;
 
 css::uno::Reference const& 
GetTransferable() const
 {
diff --git a/vcl/qt5/Qt5DragAndDrop.cxx b/vcl/qt5/Qt5DragAndDrop.cxx
index adc7a94fa0c2..42e61074a824 100644
--- a/vcl/qt5/Qt5DragAndDrop.cxx
+++ b/vcl/qt5/Qt5DragAndDrop.cxx
@@ -94,6 +94,9 @@ std::vector 
Qt5DnDTransferable::getTransferDataFl
 return aVector;
 }
 
+bool Qt5DragSource::m_bDropSuccessSet = false;
+bool Qt5DragSource::m_bDropSuccess = false;
+
 Qt5DragSource::~Qt5DragSource()
 {
 //if (m_pFrame)
@@ -140,6 +143,8 @@ void Qt5DragSource::startDrag(
 {
 Qt5Widget* qw = static_cast(m_pFrame->GetQWidget());
 m_ActiveDragSource = this;
+m_bDropSuccessSet = false;
+m_bDropSuccess = false;
 qw->startDrag(sourceActions);
 }
 else
@@ -165,7 +170,14 @@ void Qt5DragSource::fire_dragEnd(sal_Int8 nAction)
 {
 datatransfer::dnd::DragSourceDropEvent aEv;
 aEv.DropAction = nAction;
-aEv.DropSuccess = true; // FIXME: what if drop didn't work out?
+
+// internal DnD can accept the drop
+// but still fail in Qt5DropTarget::dropComplete
+if (m_bDropSuccessSet)
+aEv.DropSuccess = m_bDropSuccess;
+else
+aEv.DropSuccess = true;
+
 auto xListener = m_xListener;
 m_xListener.clear();
 xListener->dragDropEnd(aEv);
@@ -341,6 +353,16 @@ void Qt5DropTarget::rejectDrop()
 return;
 }
 
-void Qt5DropTarget::dropComplete(sal_Bool /*success*/) { return; }
+void Qt5DropTarget::dropComplete(sal_Bool success)
+{
+// internal DnD
+if (Qt5DragSource::m_ActiveDragSource)
+{
+Qt5DragSource::m_bDropSuccessSet = true;
+Qt5DragSource::m_bDropSuccess = success;
+}
+
+return;
+}
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Myanmar dictionary

[Cyrille]

I did some tests with similar languages. I install the Tamil and the
Thai oxt spellcheckers, both give nothing as correction (with little V
green logo).
But Tamil I install it on a system already and it worked well. Why now
not? Probably the problem is the same for all this 3 spellcheckers?

Il 29/04/2019 14:51, Eike Rathke ha scritto:
> Hi Cyrille,
>
> On Saturday, 2019-04-27 18:06:20 +0200, Cyrille wrote:
>
>> For dictionary on this link
>> 
>> I found an old extension with an hunspell dic for OpenOffice and it is
>> probably possible to create a new extension for Libreoffice.
> https://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/#OOoGr
> talks about my-MMDict.oxt and says that would need some Myanmar word
> break patches as well to work. It says "You only need the .diff patch
> files" but doesn't list any .diff patch files (or I'm blind).
>
> But since then years went by and maybe ICU word break does something
> suiting now.
>
> https://github.com/thanlwinsoft says "RIP Keith Stribley. 1976 - 2011"
> so I guess he's dead and nothing will happen there. There's
> https://github.com/thanlwinsoft/myoooext a "Myanmar line breaking and
> spellchecking extension for OpenOffice.org" that you maybe could fork
> and continue.
>
>> I'm ready
>> to do the work, but I couldn't maintain it. Would it be possible to add
>> it directly to Libreoffice sources?
> If nobody is going to maintain it then sticking it into LibO core
> doesn't help either. For an extension then it would be better if it was
> hosted at GitLab or GitHub so anyone willing could submit pull requests
> (that you would have to handle), or fork and continue development.
>
>> The same page says that the ui is translated but on Ubuntu I couldn't
>> see the translation with the "my" locale. the
>> http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
>> page says too that graphite give this UI translation, then how to use it
>> on LO?
> You can't expect a translation of another version (specifically not OOo)
> to work in a current LibreOffice version. Maybe Ubuntu doesn't offer
> a 'my' language pack in its current version, I don't know.
>
> LO has its (54%) Burmese 'my' translation, see
> https://translations.documentfoundation.org/my/ and installation packs
> are available, just choose the "need another language?" link on the
> download page and look for Burmese.
>
>   Eike
>




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Myanmar dictionary

[Cyrille]

Hi Heike,
Thank you for the help.

Il 29/04/2019 14:51, Eike Rathke ha scritto:
> Hi Cyrille,
>
> On Saturday, 2019-04-27 18:06:20 +0200, Cyrille wrote:
>
>> For dictionary on this link
>> 
>> I found an old extension with an hunspell dic for OpenOffice and it is
>> probably possible to create a new extension for Libreoffice.
> https://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/#OOoGr
> talks about my-MMDict.oxt and says that would need some Myanmar word
> break patches as well to work. It says "You only need the .diff patch
> files" but doesn't list any .diff patch files (or I'm blind).
>
> But since then years went by and maybe ICU word break does something
> suiting now.
>
> https://github.com/thanlwinsoft says "RIP Keith Stribley. 1976 - 2011"
> so I guess he's dead and nothing will happen there. There's
> https://github.com/thanlwinsoft/myoooext a "Myanmar line breaking and
> spellchecking extension for OpenOffice.org" that you maybe could fork
> and continue.
I create already a new repo on gitlab :
https://gitlab.com/lafricain79/myanmar-hunspell-dic but only for the
dic, the other things are not in my skills.
>> I'm ready
>> to do the work, but I couldn't maintain it. Would it be possible to add
>> it directly to Libreoffice sources?
> If nobody is going to maintain it then sticking it into LibO core
> doesn't help either. For an extension then it would be better if it was
> hosted at GitLab or GitHub so anyone willing could submit pull requests
> (that you would have to handle), or fork and continue development.
Yes, already done. But The dic doesn't "work". After installing the oxt,
or copy the files in /usr/share/hunspell. The spellchecking doesn't
work. Burmese or Myanmar don't appear in the list of language. I tried
to add manually "my" and "my_MM". Nothing. Can have a look to the
extension in gitlab to be sure I didn't make errors in it?
I remember similar problem when I tried to do the Kikongo (Kituba)
dictionary.
>> The same page says that the ui is translated but on Ubuntu I couldn't
>> see the translation with the "my" locale. the
>> http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
>> page says too that graphite give this UI translation, then how to use it
>> on LO?
> You can't expect a translation of another version (specifically not OOo)
> to work in a current LibreOffice version. Maybe Ubuntu doesn't offer
> a 'my' language pack in its current version, I don't know.
>
> LO has its (54%) Burmese 'my' translation, see
> https://translations.documentfoundation.org/my/ and installation packs
> are available, just choose the "need another language?" link on the
> download page and look for Burmese.
Ok I download the deb package, but I had dependencies issues with
Libreoffice of the Ubuntu official ppa, I need to install LO from the
Document Fondation website. Well it is now in Burmese! Very good.
Maybe for the hunspell spellchecker,  I need to use an other code, no?
Bu or something like that?
>
>   Eike
>




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/qa

[Andrea Gelmini (via logerrit)]

 vcl/qa/cppunit/svm/svmtest.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 20b4a6312074ec35f7b828962b0d2a0b80e48974
Author: Andrea Gelmini 
AuthorDate: Mon Apr 29 09:58:02 2019 +
Commit: Julien Nabet 
CommitDate: Mon Apr 29 21:38:01 2019 +0200

Fix typo

Change-Id: Ic4c0977357d7c4feb4100eeb15a6e9a4866374d3
Reviewed-on: https://gerrit.libreoffice.org/71554
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/vcl/qa/cppunit/svm/svmtest.cxx b/vcl/qa/cppunit/svm/svmtest.cxx
index a4cecaa12b14..23b05e8cfdad 100644
--- a/vcl/qa/cppunit/svm/svmtest.cxx
+++ b/vcl/qa/cppunit/svm/svmtest.cxx
@@ -1243,7 +1243,7 @@ void SvmTest::checkWallpaper(const GDIMetaFile& rMetaFile)
 {
 xmlDocPtr pDoc = dumpMeta(rMetaFile);
 
-// Fuuny enough - we don't serialize the rectangle of the wallpaper so 
it's always EMPTY
+// Funny enough - we don't serialize the rectangle of the wallpaper so 
it's always EMPTY
 assertXPathAttrs(pDoc, "/metafile/wallpaper[1]",
 {
 {"left", "0"},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry

[andreas kainz (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu |   32 
+-
 1 file changed, 16 insertions(+), 16 deletions(-)

New commits:
commit db39336550ff547bcb7ca15793b12291c913ab42
Author: andreas kainz 
AuthorDate: Mon Apr 29 22:30:42 2019 +0200
Commit: andreas_kainz 
CommitDate: Tue Apr 30 00:09:13 2019 +0200

LibO Layout arrangement tabbed compact to groupedbar compact

Change-Id: If92aa1c888af30f802ac5d764c90500d8010aeb5
Reviewed-on: https://gerrit.libreoffice.org/71555
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu
index caa48d024436..28afb946a9ba 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu
@@ -98,9 +98,9 @@
 Opened
   
 
-
+
   
-Tabbed Compact
+Tabbed
   
   
 true
@@ -109,10 +109,10 @@
 false
   
   
-3
+4
   
   
-notebookbar_compact.ui
+notebookbar.ui
   
   
 
@@ -126,9 +126,9 @@
 Arrow
   
 
-
+
   
-Tabbed
+Tabbed Compact
   
   
 true
@@ -137,10 +137,10 @@
 false
   
   
-4
+3
   
   
-notebookbar.ui
+notebookbar_compact.ui
   
   
 
@@ -358,9 +358,9 @@
 Opened
   
 
-
+
   
-Tabbed Compact
+Tabbed
   
   
 true
@@ -369,10 +369,10 @@
 false
   
   
-3
+4
   
   
-notebookbar_compact.ui
+notebookbar.ui
   
   
 
@@ -386,9 +386,9 @@
 Arrow
   
 
-
+
   
-Tabbed
+Tabbed Compact
   
   
 true
@@ -397,10 +397,10 @@
 false
   
   
-4
+3
   
   
-notebookbar.ui
+notebookbar_compact.ui
   
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Offer

[Sylvia Krossli Ljøkjell]

They is a donation for you. Reply back.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_svg icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_sv

[andreas kainz (via logerrit)]

 icon-themes/breeze/links.txt|1 -
 icon-themes/breeze/sfx2/res/symphony/open_more.png  |binary
 icon-themes/breeze_dark/sfx2/res/symphony/open_more.png |binary
 icon-themes/breeze_svg/sfx2/res/symphony/open_more.svg  |6 ++
 icon-themes/colibre/sfx2/res/symphony/open_more.png |binary
 icon-themes/colibre_svg/sfx2/res/symphony/open_more.svg |4 ++--
 icon-themes/sifr/sfx2/res/symphony/open_more.png|binary
 icon-themes/sifr/sfx2/res/symphony/open_more.svg|6 ++
 icon-themes/sifr_dark/sfx2/res/symphony/open_more.png   |binary
 icon-themes/sifr_svg/sfx2/res/symphony/open_more.svg|4 ++--
 icon-themes/tango/sfx2/res/symphony/open_more.png   |binary
 11 files changed, 16 insertions(+), 5 deletions(-)

New commits:
commit 0629d0f8edbf5000455c6aa66181990136f05d7e
Author: andreas kainz 
AuthorDate: Mon Apr 29 14:33:39 2019 +0200
Commit: andreas_kainz 
CommitDate: Mon Apr 29 21:41:21 2019 +0200

Icon Theme update open_more icon to have three dots

Change-Id: If48a34c4cb2d5b8712ab5ed408155e1902014733
Reviewed-on: https://gerrit.libreoffice.org/71527
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index d8670a9fd21c..4642273af13a 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -1428,7 +1428,6 @@ sfx2/res/search.png cmd/sc_recsearch.png
 sfx2/res/select.png cmd/sc_ok.png
 sfx2/res/signet.png cmd/sc_signature.png
 
-sfx2/res/symphony/open_more.png cmd/lc_controlproperties.png
 sfx2/res/symphony/sidebar-3d-large.png cmd/lc_cube.png
 sfx2/res/symphony/sidebar-3d-small.png cmd/sc_cube.png
 sfx2/res/symphony/sidebar-animation-large.png cmd/lc_animationobjects.png
diff --git a/icon-themes/breeze/sfx2/res/symphony/open_more.png 
b/icon-themes/breeze/sfx2/res/symphony/open_more.png
new file mode 100644
index ..d52636526cff
Binary files /dev/null and b/icon-themes/breeze/sfx2/res/symphony/open_more.png 
differ
diff --git a/icon-themes/breeze_dark/sfx2/res/symphony/open_more.png 
b/icon-themes/breeze_dark/sfx2/res/symphony/open_more.png
new file mode 100644
index ..0b1c12d96314
Binary files /dev/null and 
b/icon-themes/breeze_dark/sfx2/res/symphony/open_more.png differ
diff --git a/icon-themes/breeze_svg/sfx2/res/symphony/open_more.svg 
b/icon-themes/breeze_svg/sfx2/res/symphony/open_more.svg
new file mode 100644
index ..236633f3a7e8
--- /dev/null
+++ b/icon-themes/breeze_svg/sfx2/res/symphony/open_more.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg;>
+  
+
diff --git a/icon-themes/colibre/sfx2/res/symphony/open_more.png 
b/icon-themes/colibre/sfx2/res/symphony/open_more.png
index dfb7b65b25bb..9c8cbb5a4d18 100644
Binary files a/icon-themes/colibre/sfx2/res/symphony/open_more.png and 
b/icon-themes/colibre/sfx2/res/symphony/open_more.png differ
diff --git a/icon-themes/colibre_svg/sfx2/res/symphony/open_more.svg 
b/icon-themes/colibre_svg/sfx2/res/symphony/open_more.svg
index 29876fdd8a5a..5e454429544e 100644
--- a/icon-themes/colibre_svg/sfx2/res/symphony/open_more.svg
+++ b/icon-themes/colibre_svg/sfx2/res/symphony/open_more.svg
@@ -1,6 +1,6 @@
-http://www.w3.org/2000/svg;>
+http://www.w3.org/2000/svg;>
   
 
diff --git a/icon-themes/sifr/sfx2/res/symphony/open_more.png 
b/icon-themes/sifr/sfx2/res/symphony/open_more.png
index 9cd0044dc432..62a82c95951d 100644
Binary files a/icon-themes/sifr/sfx2/res/symphony/open_more.png and 
b/icon-themes/sifr/sfx2/res/symphony/open_more.png differ
diff --git a/icon-themes/sifr/sfx2/res/symphony/open_more.svg 
b/icon-themes/sifr/sfx2/res/symphony/open_more.svg
new file mode 100644
index ..6b81cf66a70b
--- /dev/null
+++ b/icon-themes/sifr/sfx2/res/symphony/open_more.svg
@@ -0,0 +1,6 @@
+http://www.w3.org/2000/svg;>
+  
+
diff --git a/icon-themes/sifr_dark/sfx2/res/symphony/open_more.png 
b/icon-themes/sifr_dark/sfx2/res/symphony/open_more.png
index 338cb64414f9..06bee894963a 100644
Binary files a/icon-themes/sifr_dark/sfx2/res/symphony/open_more.png and 
b/icon-themes/sifr_dark/sfx2/res/symphony/open_more.png differ
diff --git a/icon-themes/sifr_svg/sfx2/res/symphony/open_more.svg 
b/icon-themes/sifr_svg/sfx2/res/symphony/open_more.svg
index f0374e423f5a..6b81cf66a70b 100644
--- a/icon-themes/sifr_svg/sfx2/res/symphony/open_more.svg
+++ b/icon-themes/sifr_svg/sfx2/res/symphony/open_more.svg
@@ -1,6 +1,6 @@
-http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+http://www.w3.org/2000/svg;>
   
 
diff --git a/icon-themes/tango/sfx2/res/symphony/open_more.png 
b/icon-themes/tango/sfx2/res/symphony/open_more.png
index 977c4a7dfafd..9c8cbb5a4d18 100644
Binary files a/icon-themes/tango/sfx2/res/symphony/open_more.png and 
b/icon-themes/tango/sfx2/res/symphony/open_more.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - l10ntools/inc

[Matthias Seidel (via logerrit)]

 l10ntools/inc/tagtest.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 709c31bed08670e1949c04bc0e5cf79bbcbcd91e
Author: Matthias Seidel 
AuthorDate: Mon Apr 29 20:12:26 2019 +
Commit: Matthias Seidel 
CommitDate: Mon Apr 29 20:12:26 2019 +

Fixed typos

diff --git a/l10ntools/inc/tagtest.hxx b/l10ntools/inc/tagtest.hxx
index 9d0e14ae9223..241a6a7837c1 100644
--- a/l10ntools/inc/tagtest.hxx
+++ b/l10ntools/inc/tagtest.hxx
@@ -105,7 +105,7 @@ explicitTokenInfo( TokenId pnId, sal_uInt16 nP, String 
paStr, ParserMessageL
 sal_Bool IsPropertyInvariant( const ByteString , const String 
 ) const;
 /**
 a subset of IsPropertyInvariant but containing only those that are 
fixable
-we dont wat to fix e.g.: ahelp :: visibility
+we don't want to fix e.g.: ahelp :: visibility
 **/
 sal_Bool IsPropertyFixable( const ByteString  ) const;
 sal_Bool MatchesTranslation( TokenInfo& rInfo, sal_Bool bGenErrors, 
ParserMessageList , sal_Bool bFixTags = sal_False ) const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - automation/source

[Mechtilde Stehmann (via logerrit)]

 automation/source/server/statemnt.cxx |   85 --
 1 file changed, 42 insertions(+), 43 deletions(-)

New commits:
commit 8bd973400a4b29476fd12ab1787ce2be0c901f5e
Author: Mechtilde Stehmann 
AuthorDate: Mon Apr 29 19:12:20 2019 +
Commit: Mechtilde Stehmann 
CommitDate: Mon Apr 29 19:12:20 2019 +

translated comments into en-US the second part

diff --git a/automation/source/server/statemnt.cxx 
b/automation/source/server/statemnt.cxx
index f312631e4bed..946b81a22abf 100644
--- a/automation/source/server/statemnt.cxx
+++ b/automation/source/server/statemnt.cxx
@@ -4700,8 +4700,7 @@ sal_Bool StatementControl::Execute()
 
 /*  leads to problems because settext sets the text whereas typekeys adds to 
the text.
 if ( bDoTypeKeysDelay && nMethodId == M_SetText && ( nParams & 
PARAM_STR_1 ) )
-{   // Hier wird das Statement auf ein TypeKeys umgebogen
-nMethodId = M_TypeKeys;
+{   // Here the statement is bent to a TypeKeys
 nParams = PARAM_BOOL_1 | PARAM_STR_1;
 bBool1 = sal_True;
 pControl->GrabFocus();
@@ -4745,7 +4744,7 @@ sal_Bool StatementControl::Execute()
 pRet->GenReturn ( RET_Value, aUId, Id2Str( 
((TabControl*)pControl)->GetTabPage(((TabControl*)pControl)->GetCurPageId())->GetUniqueOrHelpId()
 ) );
 break;
 case M_SetPage :
-{   // Wegen lokaler Variablen
+{   // Due to local variables
 TabControl *pTControl = 
((TabControl*)pControl);
 sal_uInt16 nActive = pTControl->GetCurPageId();
 sal_uInt16 i,anz;
@@ -4776,7 +4775,7 @@ sal_Bool StatementControl::Execute()
 i++;
 if ( i >= pTControl->GetPageCount() )
 i = 0;
-if ( !MaybeDoTypeKeysDelay( pTControl ) || 
!MaybeDoTypeKeysDelay( pTControl ) || !MaybeDoTypeKeysDelay( pTControl ) )   // 
3 Mal aufrufen
+if ( !MaybeDoTypeKeysDelay( pTControl ) || 
!MaybeDoTypeKeysDelay( pTControl ) || !MaybeDoTypeKeysDelay( pTControl ) )   // 
Call up 3 times
 break;
 }
 if ( !aID.equals( aWantedID ) )
@@ -4975,7 +4974,7 @@ sal_Bool StatementControl::Execute()
 if ( bUnselectBeforeSelect )
 pLB->SetNoSelection();
 pLB->SelectEntryPos( nPos, bBool1 
);
-if ( pLB->IsEntryPosSelected( nPos 
) ? !bBool1 : bBool1 )   // XOR rein mit BOOL
+if ( pLB->IsEntryPosSelected( nPos 
) ? !bBool1 : bBool1 )   // XOR into with BOOL
 ReportError( aUId, 
GEN_RES_STR2( S_METHOD_FAILED, MethodString( nMethodId ), aString1 ) );
 }
 }
@@ -4988,7 +4987,7 @@ sal_Bool StatementControl::Execute()
 if ( bUnselectBeforeSelect )
 pLB->SetNoSelection();
 pLB->SelectEntryPos( nNr1-1, 
bBool1 );
-if ( pLB->IsEntryPosSelected( 
nNr1-1 ) ? !bBool1 : bBool1 ) // XOR rein mit BOOL
+if ( pLB->IsEntryPosSelected( 
nNr1-1 ) ? !bBool1 : bBool1 ) // XOR into with BOOL
 ReportError( aUId, 
GEN_RES_STR2( S_METHOD_FAILED, MethodString( nMethodId ), 
UniString::CreateFromInt32( nNr1 ) ) );
 }
 }
@@ -5232,7 +5231,7 @@ sal_Bool StatementControl::Execute()
 if ( !aUId.equals( pTB->GetUniqueOrHelpId() ) ) // So 
we found a Button on the ToolBox
 {
 if ( (nParams == PARAM_NONE) || (nParams == 
PARAM_USHORT_1) )
-{   // Wir f�lschen einen Parameter
+{   // We fake a parameter
 nParams |= PARAM_STR_1;
 aString1 = Id2Str( aUId );
 }
@@ -5303,7 +5302,7 @@ sal_Bool StatementControl::Execute()
 case M_Click :
 {
 FIND_ITEM;
-if ( bItemFound )   // FIND_ITEM 
Erfolgreich
+if ( bItemFound )   // FIND_ITEM 

RE: is gerrit #26348 still somewhere?

[Winfried Donkers]

Hi Christian, Mike, Eike,

(Combining mails into one reply)

> Not on gerrit anymore, but is available on jenkins mirror...
> Attached is the change v1 - if there was a second revision, then that is lost.
First of all, thank you, Christian, for retrieving the change v1. That'll help 
preventing making the same mistakes twice.

> ... but definitely, if a user deletes a draft patch, without publishing 
> it, it is deleted irreversibly (or at least irreversibly for the user).
It must have been a draft patch, then, Mike.

> I would had thought though that I was on reviewer Cc
> and I just tried and couldn't access it either.
You were reviewer and have commented (luckily I still have those comments).

I now have the patch and also the comments that Eike made. I can get on and 
concentrate on taking the next hurdle(s).

Thank you all!

Winfried

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[no subject]

[Rafał Hanuszewicz]

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - l10ntools/source

[Eike Rathke (via logerrit)]

 l10ntools/source/ulfconv/msi-encodinglist.txt |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 8d8a759da7ca6d2ae9aa53986d40cbbd106ffb86
Author: Eike Rathke 
AuthorDate: Mon Apr 29 16:02:55 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Apr 30 02:45:00 2019 +0200

Related: tdf#82184 correct wrong or obsoleted LCIDs for MSI

This solves the cases of Oromo, Kinyarwanda and Sinhala.

Kabyle is a problem on its own and apparently not easily solvable, see
attempts in https://gerrit.libreoffice.org/71247

Change-Id: Id001aeba07a95f283b4cd6057c1f6e8088de940a
Reviewed-on: https://gerrit.libreoffice.org/71535
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 0dcbc797a6cf7dc58ad17aae20bf0ccc7973cab1)
Reviewed-on: https://gerrit.libreoffice.org/71551
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/l10ntools/source/ulfconv/msi-encodinglist.txt 
b/l10ntools/source/ulfconv/msi-encodinglist.txt
index 96f87341ae13..3c98165caae8 100644
--- a/l10ntools/source/ulfconv/msi-encodinglist.txt
+++ b/l10ntools/source/ulfconv/msi-encodinglist.txt
@@ -80,7 +80,7 @@ it   0  1040
 ja   0  1041
 jbo  0  1624
 ka   0  1079   # Georgian
-kab  0  1625
+kab  0  1625   # Kabyle
 kk   0  1087
 km   0  1107   # Khmer
 kmr-Latn 0  1574
@@ -116,7 +116,7 @@ nr   0  1580   # Ndebele South
 nso  0  1132
 ny   0  1598
 oc   0  1154   # Occitan-lengadocian
-om   0  2162
+om   0  1138   # Oromo
 or   0  1096   # Odia
 or-IN0  1096
 pa-IN0  1094   # Punjabi
@@ -130,13 +130,13 @@ qtz  0  1638   # key id pseudo language
 rm   0  1047   # Raeto-Romance
 ro   0  1048   # Romanian
 ru   0  1049
-rw   0  1569   # Kinyarwanda
+rw   0  1159   # Kinyarwanda
 sa-IN0  1103   # Sanskrit
 sat  0  1606   # Santali
 sb   0  1070   # Sorbian
 sc   0  3047
 sd   0  1113   # Sindhi
-si   0  2133
+si   0  1115   # Sinhala
 sid  0  1669   # Sidama, fake LCID
 sk   0  1051   # Slovak
 sl   0  1060   # Slovenian
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - loleaflet/plugins

[Libreoffice Gerrit user]

 loleaflet/plugins/path-transform/src/Path.Transform.js |   26 +++--
 1 file changed, 23 insertions(+), 3 deletions(-)

New commits:
commit b51700b7b9498475932ebfda4159709e34752d61
Author: Marco Cecchetti 
AuthorDate: Mon Mar 4 20:36:45 2019 +0100
Commit: Henry Castro 
CommitDate: Tue Apr 30 04:14:50 2019 +0200

leaflet: after resizing a shape, dragging cursor with mouse pans view

The problem was in Path.Transform._apply executed at scale/rotate end
which enabled map dragging unconditionally.

Change-Id: Id42dc7de397a2ca2774f9d31a698c32b5e1c8514
Reviewed-on: https://gerrit.libreoffice.org/70559
Reviewed-by: Henry Castro 
Tested-by: Henry Castro 

diff --git a/loleaflet/plugins/path-transform/src/Path.Transform.js 
b/loleaflet/plugins/path-transform/src/Path.Transform.js
index f7efd72cc..3ea9ddaab 100644
--- a/loleaflet/plugins/path-transform/src/Path.Transform.js
+++ b/loleaflet/plugins/path-transform/src/Path.Transform.js
@@ -282,6 +282,7 @@ L.Handler.PathTransform = L.Handler.extend({
var matrix = this._matrix.clone();
var angle = this._angle;
var scale = this._scale.clone();
+   var moved = this._handleDragged;
 
this._transformGeometries();
 
@@ -299,7 +300,11 @@ L.Handler.PathTransform = L.Handler.extend({
 
this._updateHandlers();
 
-   map.dragging.enable();
+   if (this._mapDraggingWasEnabled) {
+   if (moved) L.DomEvent._fakeStop({ type: 'click' });
+   map.dragging.enable();
+   }
+
this._path.fire('transformed', {
matrix: matrix,
scale: scale,
@@ -576,7 +581,12 @@ L.Handler.PathTransform = L.Handler.extend({
_onRotateStart: function(evt) {
var map = this._map;
 
-   map.dragging.disable();
+   this._handleDragged = false;
+   this._mapDraggingWasEnabled = false;
+   if (map.dragging.enabled()) {
+   map.dragging.disable();
+   this._mapDraggingWasEnabled = true;
+   }
 
this._originMarker = null;
this._rotationOriginPt = 
map.latLngToLayerPoint(this._getRotationOrigin());
@@ -604,6 +614,8 @@ L.Handler.PathTransform = L.Handler.extend({
var previous = this._rotationStart;
var origin   = this._rotationOriginPt;
 
+   this._handleDragged = true;
+
// rotation step angle
this._angle = Math.atan2(pos.y - origin.y, pos.x - origin.x) -
Math.atan2(previous.y - origin.y, previous.x - 
origin.x);
@@ -649,7 +661,12 @@ L.Handler.PathTransform = L.Handler.extend({
var marker = evt.target;
var map = this._map;
 
-   map.dragging.disable();
+   this._handleDragged = false;
+   this._mapDraggingWasEnabled = false;
+   if (map.dragging.enabled()) {
+   map.dragging.disable();
+   this._mapDraggingWasEnabled = true;
+   }
 
this._activeMarker = marker;
 
@@ -688,6 +705,9 @@ L.Handler.PathTransform = L.Handler.extend({
_onScale: function(evt) {
var originPoint = this._originMarker._point;
var ratioX, ratioY;
+
+   this._handleDragged = true;
+
if (this.options.uniformScaling) {
ratioX = originPoint.distanceTo(evt.layerPoint) / 
this._initialDist;
ratioY = ratioX;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/build loleaflet/src

[Libreoffice Gerrit user]

 loleaflet/build/deps.js  |6 
 loleaflet/src/layer/GeoJSON.js   |  269 ---
 loleaflet/src/layer/vector/Path.Transform.js |9 
 3 files changed, 1 insertion(+), 283 deletions(-)

New commits:
commit bf3c4c56958175d5c3204bbf8578ff1a08c3763a
Author: Henry Castro 
AuthorDate: Mon Apr 29 17:01:51 2019 -0400
Commit: Henry Castro 
CommitDate: Mon Apr 29 22:23:18 2019 -0400

loleaflet: remove GeoJSON.js file

GeoJSON data is no longer used for document tiled rendering

Change-Id: Ic95371947b7e1705ac2431ca06b9a5814d249207

diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index eea5545a2..5a1650e22 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -204,12 +204,6 @@ var deps = {
desc: 'Canvas backend for vector layers.'
},
 
-   GeoJSON: {
-   src: ['layer/GeoJSON.js'],
-   deps: ['Polygon', 'Circle', 'CircleMarker', 'Marker', 
'FeatureGroup'],
-   desc: 'GeoJSON layer, parses the data and adds corresponding 
layers above.'
-   },
-
MapDrag: {
src: ['dom/DomEvent.js',
  'dom/Draggable.js',
diff --git a/loleaflet/src/layer/GeoJSON.js b/loleaflet/src/layer/GeoJSON.js
deleted file mode 100644
index 7458da924..0
--- a/loleaflet/src/layer/GeoJSON.js
+++ /dev/null
@@ -1,269 +0,0 @@
-/* -*- js-indent-level: 8 -*- */
-/*
- * L.GeoJSON turns any GeoJSON data into a Leaflet layer.
- */
-
-L.GeoJSON = L.FeatureGroup.extend({
-
-   initialize: function (geojson, options) {
-   L.setOptions(this, options);
-
-   this._layers = {};
-
-   if (geojson) {
-   this.addData(geojson);
-   }
-   },
-
-   addData: function (geojson) {
-   var features = L.Util.isArray(geojson) ? geojson : 
geojson.features,
-   i, len, feature;
-
-   if (features) {
-   for (i = 0, len = features.length; i < len; i++) {
-   // only add this if geometry or geometries are 
set and not null
-   feature = features[i];
-   if (feature.geometries || feature.geometry || 
feature.features || feature.coordinates) {
-   this.addData(feature);
-   }
-   }
-   return this;
-   }
-
-   var options = this.options;
-
-   if (options.filter && !options.filter(geojson)) { return this; }
-
-   var layer = L.GeoJSON.geometryToLayer(geojson, options);
-   layer.feature = L.GeoJSON.asFeature(geojson);
-
-   layer.defaultOptions = layer.options;
-   this.resetStyle(layer);
-
-   if (options.onEachFeature) {
-   options.onEachFeature(geojson, layer);
-   }
-
-   return this.addLayer(layer);
-   },
-
-   resetStyle: function (layer) {
-   // reset any custom styles
-   layer.options = layer.defaultOptions;
-   this._setLayerStyle(layer, this.options.style);
-   return this;
-   },
-
-   setStyle: function (style) {
-   return this.eachLayer(function (layer) {
-   this._setLayerStyle(layer, style);
-   }, this);
-   },
-
-   _setLayerStyle: function (layer, style) {
-   if (typeof style === 'function') {
-   style = style(layer.feature);
-   }
-   if (layer.setStyle) {
-   layer.setStyle(style);
-   }
-   }
-});
-
-L.extend(L.GeoJSON, {
-   geometryToLayer: function (geojson, options) {
-
-   var geometry = geojson.type === 'Feature' ? geojson.geometry : 
geojson,
-   coords = geometry.coordinates,
-   layers = [],
-   pointToLayer = options && options.pointToLayer,
-   coordsToLatLng = options && options.coordsToLatLng || 
this.coordsToLatLng,
-   latlng, latlngs, i, len;
-
-   switch (geometry.type) {
-   case 'Point':
-   latlng = coordsToLatLng(coords);
-   return pointToLayer ? pointToLayer(geojson, latlng) : 
new L.Marker(latlng);
-
-   case 'MultiPoint':
-   for (i = 0, len = coords.length; i < len; i++) {
-   latlng = coordsToLatLng(coords[i]);
-   layers.push(pointToLayer ? 
pointToLayer(geojson, latlng) : new L.Marker(latlng));
-   }
-   return new L.FeatureGroup(layers);
-
-   case 'LineString':
-   case 'MultiLineString':
-   latlngs = 

[Libreoffice-commits] core.git: connectivity/source

[Andrea Gelmini (via logerrit)]

 connectivity/source/drivers/postgresql/pq_statement.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f9f7cc62e95f12a9d4ea02413a658d40e09ccde6
Author: Andrea Gelmini 
AuthorDate: Sun Apr 28 21:11:40 2019 +
Commit: Julien Nabet 
CommitDate: Tue Apr 30 07:06:50 2019 +0200

Fix typo

Change-Id: Ie0193edb4e729c4469c15bc5940dbc8005caf28b
Reviewed-on: https://gerrit.libreoffice.org/71561
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/connectivity/source/drivers/postgresql/pq_statement.hxx 
b/connectivity/source/drivers/postgresql/pq_statement.hxx
index 8b91ec596642..e53c203af6d6 100644
--- a/connectivity/source/drivers/postgresql/pq_statement.hxx
+++ b/connectivity/source/drivers/postgresql/pq_statement.hxx
@@ -88,7 +88,7 @@ private:
 public:
 /**
  * @param ppConnection The piece of memory, pConnection points to, is 
accessible
- * as long as a reference to paramenter con is held.
+ * as long as a reference to parameter con is held.
  */
 Statement( const rtl::Reference< comphelper::RefCountedMutex > & refMutex,
const css::uno::Reference< css::sdbc::XConnection> & con,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Brian Fraser (via logerrit)]

 sd/source/core/CustomAnimationEffect.cxx |  107 ++-
 1 file changed, 79 insertions(+), 28 deletions(-)

New commits:
commit c0ff8a24365456383900ed7958c8fb9ea68043e9
Author: Brian Fraser 
AuthorDate: Mon Apr 15 09:49:53 2019 -0700
Commit: Jim Raykowski 
CommitDate: Tue Apr 30 03:01:02 2019 +0200

Impress: Delete an empty paragraph's animation over a non-empty one's

- Backspacing into empty paragraph deletes empty paragraph's animation,
  not the next paragraph's animation.
- Pressing delete while in empty paragraph deletes its animation, not next
  paragraph's animation.
- Changing indent level of an animated paragraph no longer collapses any
  expanded animations in the animation list side panel.

Change-Id: I65ff5813893b1ffe91687cc106f276447de4b225
Reviewed-on: https://gerrit.libreoffice.org/70792
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sd/source/core/CustomAnimationEffect.cxx 
b/sd/source/core/CustomAnimationEffect.cxx
index 04f4fed1e035..ac1e8bbabc1a 100644
--- a/sd/source/core/CustomAnimationEffect.cxx
+++ b/sd/source/core/CustomAnimationEffect.cxx
@@ -2176,6 +2176,39 @@ void EffectSequenceHelper::insertTextRange( const 
css::uno::Any& aTarget )
 rebuild();
 }
 
+static bool isParagraphTargetTextEmpty( ParagraphTarget aParaTarget )
+{
+// get paragraph
+Reference< XText > xText ( aParaTarget.Shape, UNO_QUERY );
+if( xText.is() )
+{
+Reference< XEnumerationAccess > xEA( xText, UNO_QUERY );
+if( xEA.is() )
+{
+Reference< XEnumeration > xEnumeration( xEA->createEnumeration(), 
UNO_QUERY );
+if( xEnumeration.is() )
+{
+// advance to the Nth paragraph
+sal_Int32 nPara = aParaTarget.Paragraph;
+while( xEnumeration->hasMoreElements() && nPara-- )
+xEnumeration->nextElement();
+
+// get Nth paragraph's text and check if it's empty
+if( xEnumeration->hasMoreElements() )
+{
+Reference< XTextRange > xRange( 
xEnumeration->nextElement(), UNO_QUERY );
+if( xRange.is() )
+{
+OUString text = xRange->getString();
+return text.isEmpty();
+}
+}
+}
+}
+}
+return false;
+}
+
 void EffectSequenceHelper::disposeTextRange( const css::uno::Any& aTarget )
 {
 ParagraphTarget aParaTarget;
@@ -2183,49 +2216,67 @@ void EffectSequenceHelper::disposeTextRange( const 
css::uno::Any& aTarget )
 return;
 
 bool bChanges = false;
-bool bErased = false;
 
-EffectSequence::iterator aIter( maEffects.begin() );
-while( aIter != maEffects.end() )
+// building list of effects for target shape; process effects not on 
target shape
+EffectSequence aTargetParagraphEffects;
+for( const auto  : maEffects )
 {
-Any aIterTarget( (*aIter)->getTarget() );
+Any aIterTarget( pEffect->getTarget() );
 if( aIterTarget.getValueType() == 
::cppu::UnoType::get() )
 {
 ParagraphTarget aIterParaTarget;
 if( (aIterTarget >>= aIterParaTarget) && (aIterParaTarget.Shape == 
aParaTarget.Shape) )
 {
-if( aIterParaTarget.Paragraph == aParaTarget.Paragraph )
-{
-// delete this effect if it targets the disposed paragraph 
directly
-(*aIter)->setEffectSequence( nullptr );
-aIter = maEffects.erase( aIter );
-bChanges = true;
-bErased = true;
-}
-else
-{
-if( aIterParaTarget.Paragraph > aParaTarget.Paragraph )
-{
-// shift all paragraphs after disposed paragraph
-aIterParaTarget.Paragraph--;
-(*aIter)->setTarget( makeAny( aIterParaTarget ) );
-}
-}
+aTargetParagraphEffects.push_back(pEffect);
 }
 }
-else if( (*aIter)->getTargetShape() == aParaTarget.Shape )
+else if( pEffect->getTargetShape() == aParaTarget.Shape )
 {
-bChanges |= (*aIter)->checkForText();
+bChanges |= pEffect->checkForText();
 }
+}
 
-if( bErased )
-bErased = false;
-else
-++aIter;
+// select effect to delete:
+// if paragraph before target is blank, then delete its animation effect 
(if any) instead
+ParagraphTarget aPreviousParagraph = aParaTarget;
+--aPreviousParagraph.Paragraph;
+bool bIsPreviousParagraphEmpty = isParagraphTargetTextEmpty( 
aPreviousParagraph );
+sal_Int16 anParaNumToDelete = bIsPreviousParagraphEmpty ? 

[Libreoffice-commits] core.git: connectivity/source

[Andrea Gelmini (via logerrit)]

 connectivity/source/drivers/postgresql/pq_preparedstatement.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8182f5e4325f4cbf4c333a76466740fdea4e7bff
Author: Andrea Gelmini 
AuthorDate: Sun Apr 28 21:11:41 2019 +
Commit: Julien Nabet 
CommitDate: Tue Apr 30 07:06:11 2019 +0200

Fix typo

Change-Id: I0af0c7c750018a9766dc0b3af4a6c114a7b27144
Reviewed-on: https://gerrit.libreoffice.org/71560
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/postgresql/pq_preparedstatement.hxx 
b/connectivity/source/drivers/postgresql/pq_preparedstatement.hxx
index fb05ce85d409..01eb2441f120 100644
--- a/connectivity/source/drivers/postgresql/pq_preparedstatement.hxx
+++ b/connectivity/source/drivers/postgresql/pq_preparedstatement.hxx
@@ -94,7 +94,7 @@ private:
 public:
 /**
  * @param ppConnection The piece of memory, pConnection points to, is 
accessible
- * as long as a reference to paramenter con is held.
+ * as long as a reference to parameter con is held.
  */
 PreparedStatement( const rtl::Reference< comphelper::RefCountedMutex > & 
refMutex,
const css::uno::Reference< css::sdbc::XConnection> & 
con,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source filter/source include/vcl sd/source sfx2/source svtools/source svx/qa svx/source sw/qa sw/source vcl/source

[Noel Grandin (via logerrit)]

 editeng/source/items/frmitems.cxx |6 +++---
 editeng/source/uno/unonrule.cxx   |2 +-
 filter/source/msfilter/escherex.cxx   |2 +-
 filter/source/msfilter/msdffimp.cxx   |2 +-
 include/vcl/graph.hxx |3 +--
 sd/source/filter/eppt/epptso.cxx  |2 +-
 sfx2/source/appl/linkmgr2.cxx |2 +-
 svtools/source/graphic/renderer.cxx   |2 +-
 svtools/source/misc/embedhlp.cxx  |2 +-
 svx/qa/unit/XTableImportExportTest.cxx|2 +-
 svx/source/gallery2/galbrws2.cxx  |2 +-
 svx/source/unodraw/UnoGraphicExporter.cxx |8 
 svx/source/unodraw/XPropertyTable.cxx |2 +-
 svx/source/unodraw/unoshap2.cxx   |4 ++--
 svx/source/xml/xmlgrhlp.cxx   |2 +-
 svx/source/xoutdev/xattrbmp.cxx   |2 +-
 sw/qa/extras/ooxmlexport/ooxmlexport4.cxx |2 +-
 sw/source/core/unocore/unoframe.cxx   |4 ++--
 sw/source/core/unocore/unosett.cxx|2 +-
 vcl/source/gdi/graph.cxx  |9 ++---
 vcl/source/graphic/GraphicObject.cxx  |2 +-
 vcl/source/graphic/UnoGraphic.cxx |   17 ++---
 vcl/source/graphic/UnoGraphicProvider.cxx |4 ++--
 23 files changed, 37 insertions(+), 48 deletions(-)

New commits:
commit 7334034ae93b49fc93b5859a3c047a319d138282
Author: Noel Grandin 
AuthorDate: Mon Apr 29 15:50:02 2019 +0200
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 30 04:57:21 2019 +0200

drop Graphic::operator bool

which tends to interact in very weird ways with other code, for example
it makes Graphic appear to have an operator<

Change-Id: I335fe8f3644b710bc61291e625cbca7334a37716
Reviewed-on: https://gerrit.libreoffice.org/71532
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index ac78520bdaa8..0d49c25681b6 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -2992,7 +2992,7 @@ bool SvxBrushItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 aGraphic = Graphic(xGraphic);
 }
 
-if (aGraphic)
+if (!aGraphic.IsNone())
 {
 maStrLink.clear();
 
@@ -3001,11 +3001,11 @@ bool SvxBrushItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 ApplyGraphicTransparency_Impl();
 xOldGrfObj.reset();
 
-if (aGraphic && eGraphicPos == GPOS_NONE)
+if (!aGraphic.IsNone() && eGraphicPos == GPOS_NONE)
 {
 eGraphicPos = GPOS_MM;
 }
-else if (!aGraphic)
+else if (aGraphic.IsNone())
 {
 eGraphicPos = GPOS_NONE;
 }
diff --git a/editeng/source/uno/unonrule.cxx b/editeng/source/uno/unonrule.cxx
index 4ed69af5c922..e3a3d5111706 100644
--- a/editeng/source/uno/unonrule.cxx
+++ b/editeng/source/uno/unonrule.cxx
@@ -361,7 +361,7 @@ void SvxUnoNumberingRules::setNumberingRuleByIndex(const 
Sequence>= aURL)
 {
 Graphic aGraphic = vcl::graphic::loadFromURL(aURL);
-if (aGraphic)
+if (!aGraphic.IsNone())
 {
 SvxBrushItem aBrushItem(aGraphic, GPOS_AREA, 
SID_ATTR_BRUSH);
 aFmt.SetGraphicBrush();
diff --git a/filter/source/msfilter/escherex.cxx 
b/filter/source/msfilter/escherex.cxx
index 8abcf7c64416..a34a47cf1847 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -1371,7 +1371,7 @@ void 
EscherPropertyContainer::CreateEmbeddedBitmapProperties(
 if (!xGraphic.is())
 return;
 const Graphic aGraphic(xGraphic);
-if (!aGraphic)
+if (aGraphic.IsNone())
 return;
 const GraphicObject aGraphicObject(aGraphic);
 if (aGraphicObject.GetType() == GraphicType::NONE)
diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 82a1abc20407..4caf50622d7f 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6588,7 +6588,7 @@ bool SvxMSDffManager::GetBLIPDirect( SvStream& 
rBLIPStream, Graphic& rData, tool
 // size to the size of this record.
 sal_uInt64 maxSize = pGrStream ==  ? nLength : 0;
 Graphic aGraphic = rGF.ImportUnloadedGraphic(*pGrStream, maxSize);
-if (aGraphic)
+if (!aGraphic.IsNone())
 {
 rData = aGraphic;
 nRes = ERRCODE_NONE;
diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index f44858c88085..e8af0d2c06ce 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -128,9 +128,8 @@ public:
 Graphic&operator=( Graphic&& rGraphic );
 booloperator==( const Graphic& rGraphic ) 

[Libreoffice-bugs] [Bug 124968] UI Performance Sllooowwww on 27" Retina iMac 2019 Model

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124968

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Alex Thurgood  ---


*** This bug has been marked as a duplicate of bug 113104 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124717] Auto correct isn’t correcting either while typing or using the apply settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124717

Alex Thurgood  changed:

   What|Removed |Added

 OS|Mac OS X (All)  |All

--- Comment #8 from Alex Thurgood  ---
Not Mac specific, per comment 7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125000] Writer page numbering takes no account of no page number required on title page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125000

Alex Thurgood  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Alex Thurgood  ---
This works as designed, as Dieter has indicated.

Version: 6.1.5.2
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
Threads CPU : 4; OS : Mac OS X 10.14.4; UI Render : par défaut; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded

"There is more than one way to skin a cat", as the saying goes.

On the first page, set a page style, let's use the First/Title Page style.

Type a title, then force a page break

Right mouse button click on the First Page, then look at the page properties.

Under the Page Management tab, you should see :

Style : First (Title) Page
Follow-on Style : Default Style

Click on the Edit Style button at the end of the Follow-On Style entry, which
opens an identical tabbed dialog to manage your follow-on style. Choose Footer
(or Header, depending on where you want your page numbering).

Click on Activate Footer. Leave the default ticked options (same content
left/right), same content first page. Click on Apply, then OK. The dialog
closes.

Click on Apply and then OK again to close the initial page management dialog.

Click on page 2, then insert a page number via Insert > Page Number. The number
2 is displayed. 

Force a manual page break and you will see a new page with the number 3 in the
footer.

No page numbering appears on the First/Title page.

I have enclosed an ODT file that demonstrates this. Made with LO6152 as
outlined above.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125000] Writer page numbering takes no account of no page number required on title page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125000

--- Comment #7 from Alex Thurgood  ---
I would also suggest that you download and read Bruce Byfield's book called
"Designing with LibreOffice", available as a free PDF/ODT download from here:

http://designingwithlibreoffice.com/wp-content/uploads/2016/03/DWL_fullbook.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125022] New: found syllabification error in German

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125022

Bug ID: 125022
   Summary: found syllabification error in German
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: katmel...@googlemail.com

Description:
found syllabification error in German. The word "aus­sprichst" will be seperate
as auss-prichst. It is wrong. "aus" is a prefix, so it is to separate
"aus-sprichst".

Steps to Reproduce:
1. make a document and set the language as german (germany)
2. set hyphenation as on
3. write the word "aussprichst" so it is an the end of the line

Actual Results:
auss-prichst

Expected Results:
aus-sprichst


Reproducible: Didn't try


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: de
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125021] Notebookbar as default layout on windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125021

--- Comment #3 from andreas_k  ---
I also prefer tabbed single line and as written its also easier.

I only start the discussion early cause if we found an solution for a switch it
need one year for preparation, as I wrote. Design finalization, dev
optimization, help and documentation updates, translation for everything,
teaching, ... marketing.

About the enterprises, what's the feedback from them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121235] [META] Regressions introduced by buffering SystemDependent GraphicData

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121235
Bug 121235 depends on bug 120797, which changed state.

Bug 120797 Summary: Comment not displayed on hovering with gtk3 and kde5
https://bugs.documentfoundation.org/show_bug.cgi?id=120797

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101216] [META] Calc comment bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
Bug 101216 depends on bug 120797, which changed state.

Bug 120797 Summary: Comment not displayed on hovering with gtk3 and kde5
https://bugs.documentfoundation.org/show_bug.cgi?id=120797

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 125009] Rename tabbed layout to notebookbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125009

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||it...@italovignoli.com

--- Comment #5 from Heiko Tietze  ---
Italo, what do you think? I don't like the term Notebookbar in the UI (neither
around marketing) but agree on "Tabbed" being boring and not really vivid. 

Synonyms for "tabulate" are arrange, assort, catalog (or catalogue),
categorize, classify, codify, diagram, enumerate, index, order, schematize,
sort
analyze, anatomize, assay, break down, cut, deconstruct, dissect
assess, diagnose, evaluate, examine, inspect, investigate, scrutinize
divide, reduce, segment, separate, subdivide
(https://www.merriam-webster.com/thesaurus/tabulator)

How about "Verbose Catalogues" and "Compact Catalogues"? Native speakers are
welcome here...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 125000] Writer page numbering takes no account of no page number required on title page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125000

--- Comment #8 from internalm...@gmail.com ---
(In reply to Dieter Praas from comment #3)
> (In reply to internalmemo from comment #2)
> > And yes, there there's a setting
> > 'same content on first page'. But it doesn't work properly. That is, if you
> > ensure that 'same content on first page' is unchecked and you insert '2' in,
> > let's say, the header on the second page, you do indeed suppress '1' from
> > appearing on the first page. However, '2' then appears on Page 3 and on all
> > subsequent pages!!
> 
> I can't confirm that. I don't understand, why you insert '2' on the second
> page. You just have to choose Insert => Pagenumber
> 
> Perhaps you could attach a document that shows the problem (only a document
> with some blak pages and the pagenumbers)

Dieter,

Believe me, I tried all the obvious commands, like Insert > Page Number, but I
always ended up with the same number on all pages including the First page, or
the same number on all pages coming after 2.

I've followed Alex's suggestion(s). With that, I simply couldn't find the steps
to which he referred. Possibly, that's because he and you are using 6.2.3,
whereas I'm using 6.1.5 (I didn't anticipate getting involved in LO's
Feedback). However, using his steps as a guide, I've managed to find the
crucial settings and have found that Alex's basically do work.

To illustrate the successful method I eventually found, I've written out the
sequence below, in my reply to Alex. I'm assuming that you don't have to repeat
these configuring steps for each new document, unless you want the document
style to be changed in some way. Otherwise, this would be a 'right old fag' to
have to do each time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125018] latest alpha version does not start up at all

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125018

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Does it work if you launch it line SAL_USE_VCLPLUGIN=gen  instdir/program/scalc
?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124729] Impress reliably crashes on THIS PowerPoint document in Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124729

--- Comment #11 from Timur  ---
(In reply to Xisco Faulí from comment #9)
> (In reply to Timur from comment #4)
> > I reproduced in Linux Mint with LO appimage 6.1 and extracted 6.3+ .
> Do you reproduce it without opengl ?
I tested in VM that doesn't use OpenGL, so yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124990] kde5: unfinished DnD of a sheet erases all contents of the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124990

Katarina Behrens (CIB)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |katarina.behr...@cib.de
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125005] Formatting changed on document using 6.0 or later

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125005

Dieter Praas  changed:

   What|Removed |Added

   Keywords||bibisectRequest,
   ||possibleRegression

--- Comment #8 from Dieter Praas  ---
(In reply to beckx020 from comment #7)

I found out the following:
If you delete this textbox and add some blank paragraphs (so that the layout is
correct), the layout is corrupted after save, close and reopening. If you
delete and and add a blank paragraph, everythings looks good again. It's no
problem to reopen it in LO 5.4. I can't explain why this happens.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125006] UI: Table Tooltips not Displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125006

Heiko Tietze  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #3 from Heiko Tietze  ---
(In reply to Roman Kuznetsov from comment #1)
> Heiko, IIRC you delete some tooltips from Writer table. What do you think?

Sounds familiar but I cannot find the patch. Xisco can you somehow help with
your bisecting power?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125009] Rename tabbed layout to notebookbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125009

--- Comment #6 from andreas_k  ---
In the past there was also muffin in marketing. But it is also not self
explanation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125009] Rename tabbed layout to notebookbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125009

--- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Heiko Tietze from comment #5)

> How about "Verbose Catalogues" and "Compact Catalogues"? Native speakers are
> welcome here...

How about "Ribbon"?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 125009] Rename tabbed layout to notebookbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125009

--- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Heiko Tietze from comment #5)

> How about "Verbose Catalogues" and "Compact Catalogues"? Native speakers are
> welcome here...

How about "Ribbon"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 125009] Rename tabbed layout to notebookbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125009

--- Comment #6 from andreas_k  ---
In the past there was also muffin in marketing. But it is also not self
explanation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 123863] Sumproduct delivers wrong result from calculated external data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123863

--- Comment #6 from Christoph Vogelbusch  ---
I have tried the steps with the latest 6.2.2:
1. Bug still exists. 
2. is independent of any renaming
3. only happens if content is updated
4. hard recalc works updates correctly only if 3. is not given

So the work around for us is:
• open document
• update content
• save & close document 
• open document (don't update)
• hard recalc shift+ctrl+f9

It's quite time consuming for our document as they are big and load slowly, so
I really hope the bug is quickly resolved (please)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125014] LO freeze when edit chart Y axis (gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125014

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Summary|LO freeze when edit chart Y |LO freeze when edit chart Y
   |axis|axis (gen)
   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||qui...@gmail.com,
   ||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=962debec1fa1c51d3eef96ca3432976ecfc0aa94

author  Tomaž Vajngerl  2019-04-13 00:07:48
+0900
committer   Tomaž Vajngerl2019-04-13 04:23:16
+0200
commit  962debec1fa1c51d3eef96ca3432976ecfc0aa94 (patch)
tree06ecc4cc05cd6624cd8b5fe6b7e6787bd4b62270
parent  9695896d8f0e3d4b2961c7a753c279a70f5bbaf2 (diff)
tdf#124543 add functs. to scale 32bit bitmaps to BitmapScaleSuper

Bisected with: bibisect-linux64-6.3

Adding Cc: to Tomaž Vajngerl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125012] [IDEA] Libre Calc - row numbering from 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125012

Eike Rathke  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Eike Rathke  ---
Agreed. That would only add to confusion as the reference syntax would not
match the row numbers, e.g. A1 for row 0. Which is something we'll definitely
not change.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107977] [META] Calc feature enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107977
Bug 107977 depends on bug 125012, which changed state.

Bug 125012 Summary: [IDEA] Libre Calc -  row numbering from 0
https://bugs.documentfoundation.org/show_bug.cgi?id=125012

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125007] AdoptOpenJDK is not recognized as JRE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125007

Stephan Bergmann  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #2 from Stephan Bergmann  ---
(In reply to pierre-yves samyn from comment #0)
> Env. windows7/64 (2 PCs) & Version: 6.1.5.2 (x64)
> Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
> CPU threads: 2; OS: Windows 6.1; UI render: default; 
> Locale: fr-FR (fr_FR); Calc: group threaded
> 
> AdoptOpenJDK is not recognized as JRE => warning message:

That would mean that

"Support AdoptOpenJDK", included in libreoffice-6-1-5 (prior to tag
libreoffice-6.1.5.2), does not work as intended.

(Which would be somewhat irrelevant as the fix for bug 124503 should indeed get
this fixed, through a different internal approach, for LO 6.1.6, but would
still be worrisome.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125018] New: latest alpha version does not start up at all

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125018

Bug ID: 125018
   Summary: latest alpha version does not start up at all
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@iafrica.com

Description:
master~2019-04-26_14.20.06_LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb.tar.gz

Steps to Reproduce:
1. downloaded 26 and 28Apr masters
2. install
3. try, nothing happens

Actual Results:
nothing happens

Expected Results:
should open calc sheet


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-ZA
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124860] Formatting: Formula result has different alignment than regular values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #9 from bugzil...@cb-computerservice.at ---
(In reply to Heiko Tietze from comment #8)
> The request to improve number recognition in bug 113241 has been done with 
> https://gerrit.libreoffice.org/#/c/61065/ by Cor.

The number recognition can be left ON. But disabling the alignment switch by
default would restore compatibility to documents that were saved with versions
prior to 6.2.x.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124860] Formatting: Formula result has different alignment than regular values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #9 from bugzil...@cb-computerservice.at ---
(In reply to Heiko Tietze from comment #8)
> The request to improve number recognition in bug 113241 has been done with 
> https://gerrit.libreoffice.org/#/c/61065/ by Cor.

The number recognition can be left ON. But disabling the alignment switch by
default would restore compatibility to documents that were saved with versions
prior to 6.2.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs