[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 25 commits - desktop/qa desktop/source include/LibreOfficeKit include/sfx2 sd/inc sd/sdi sd/source sfx2/source vcl/source

[Ashod Nakashian (via logerrit)]

 desktop/qa/desktop_lib/test_desktop_lib.cxx|3 
 desktop/source/lib/init.cxx|   21 +
 include/LibreOfficeKit/LibreOfficeKit.h|5 
 include/LibreOfficeKit/LibreOfficeKit.hxx  |   14 
 include/LibreOfficeKit/LibreOfficeKitEnums.h   |1 
 include/sfx2/dockwin.hxx   |2 
 include/sfx2/sidebar/Deck.hxx  |6 
 include/sfx2/sidebar/DeckLayouter.hxx  |1 
 include/sfx2/sidebar/SidebarChildWindow.hxx|5 
 include/sfx2/sidebar/SidebarController.hxx |   13 
 include/sfx2/sidebar/SidebarDockingWindow.hxx  |6 
 include/sfx2/sidebar/TabBar.hxx|3 
 sd/inc/app.hrc |1 
 sd/sdi/SlideSorterController.sdi   |5 
 sd/sdi/drviewsh.sdi|5 
 sd/sdi/sdraw.sdi   |   18 
 sd/source/ui/animations/CustomAnimationPane.cxx|   18 
 sd/source/ui/animations/SlideTransitionPane.cxx|   14 
 sd/source/ui/slidesorter/controller/SlsSlotManager.cxx |   11 
 sd/source/ui/view/ViewShellImplementation.cxx  |2 
 sd/source/ui/view/drviews2.cxx |5 
 sd/source/ui/view/drviewse.cxx |5 
 sfx2/source/sidebar/Deck.cxx   |   31 +
 sfx2/source/sidebar/DeckLayouter.cxx   |   35 +
 sfx2/source/sidebar/ResourceManager.cxx|   12 
 sfx2/source/sidebar/SidebarChildWindow.cxx |   57 +-
 sfx2/source/sidebar/SidebarController.cxx  |  328 -
 sfx2/source/sidebar/SidebarDockingWindow.cxx   |   50 ++
 sfx2/source/sidebar/TabBar.cxx |5 
 vcl/source/window/dockwin.cxx  |5 
 vcl/source/window/window.cxx   |2 
 31 files changed, 541 insertions(+), 148 deletions(-)

New commits:
commit 7be22a8bdef111bb0ee382ab96646930ca829b5d
Author: Ashod Nakashian 
AuthorDate: Sun Feb 3 10:53:21 2019 -0500
Commit: Jan Holesovsky 
CommitDate: Tue Apr 30 18:06:32 2019 +0200

sfx2: LOK: better fit of sidebar decks

As the patch comment explains, the properties
deck needs to be rendered with height long
enough to avoid scrolling, but others would
be greedy in using up all the available height,
so we render them in more restricted space.

Change-Id: I361e653239e22a7be0e5d75505cdcde18f2367d3

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index bc901a42c33a..420847351e53 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -416,13 +416,18 @@ void SidebarController::NotifyResize()
 {
 if (comphelper::LibreOfficeKit::isActive())
 {
+// We want to let the layouter use up as much of the
+// height as necessary to make sure no scrollbar is
+// visible. This only works when there are no greedy
+// panes that fill up all available area. So we only
+// use this for the PropertyDeck, which has no such
+// panes, while most other do. This is fine, since
+// it's the PropertyDeck that really has many panes
+// that can collapse or expand. For others, limit
+// the height to something sensible.
+const sal_Int32 nExtHeight = (msCurrentDeckId == 
"PropertyDeck" ? 2000 : 600);
 // No TabBar in LOK (use nWidth in full).
-// Use the minimum height that is large enough to let the
-// layouter expand the panes maximally (that have a minimal
-// height before the scrollbar is shown), so we never get
-// scrollbars (we want scrolling to be done on the rendered
-// image in the client, which is much faster).
-mpCurrentDeck->setPosSizePixel(nDeckX, 0, nWidth, 650);
+mpCurrentDeck->setPosSizePixel(nDeckX, 0, nWidth, nExtHeight);
 }
 else
 mpCurrentDeck->setPosSizePixel(nDeckX, 0, nWidth - 
nTabBarDefaultWidth, nHeight);
commit 94d7d8bcdcd609a5b714696259a8d4dcdd8f86a9
Author: Ashod Nakashian 
AuthorDate: Fri Feb 1 10:56:46 2019 -0500
Commit: Jan Holesovsky 
CommitDate: Tue Apr 30 18:06:32 2019 +0200

sfx2: LOK: resize the sidebar after layouting to avoid scrollbars

By resizing the deck we ensure that if the contents do not fit
in the existing height, they will after we expand to the minimum
height. Also, the minimum height is now the correct one.

This prevents seeing vertical scrollbar in LOK, which is very
slow and unfriendly, instead renders the 

[Libreoffice-commits] core.git: vcl/inc vcl/win

[Miklos Vajna (via logerrit)]

 vcl/inc/win/DWriteTextRenderer.hxx |   11 +++
 vcl/inc/win/winlayout.hxx  |2 +-
 vcl/win/gdi/DWriteTextRenderer.cxx |   25 ++---
 vcl/win/gdi/winlayout.cxx  |   16 +++-
 4 files changed, 37 insertions(+), 17 deletions(-)

New commits:
commit f7453b956bcf83ec13c805d243f20cb209289179
Author: Miklos Vajna 
AuthorDate: Tue Apr 30 17:38:14 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 21:56:11 2019 +0200

tdf#114209 vcl win DirectWrite: handle rotated text

Commit a51b7a1c3a7e7cf7b0c733e1dec40288278c1884 (tdf#103831, tdf#100986:
Force using GDI when needed, 2017-03-03) noted that the DirectWrite text
renderer doesn't support vertical text, add initial support for this now
by extending the DirectWrite transform matrix to do rotation as well.

This is initial support, as it can be improved in two ways:

- vertical text is not cached

- only vertical Latin text is handled, which wants rotated glyphs (vs
  e.g. Japanese text that would not rotate the glyphs)

With this, the "unreadable" text in the bugdoc's chart is on par with
the the GDI rendering.

Change-Id: I07af4de6cb437f83cc40546396ec8c8aac456bb3
Reviewed-on: https://gerrit.libreoffice.org/71592
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/vcl/inc/win/DWriteTextRenderer.hxx 
b/vcl/inc/win/DWriteTextRenderer.hxx
index a84cf81b9b66..9011a951d277 100644
--- a/vcl/inc/win/DWriteTextRenderer.hxx
+++ b/vcl/inc/win/DWriteTextRenderer.hxx
@@ -81,12 +81,15 @@ private:
 D2DTextAntiAliasMode meTextAntiAliasMode;
 };
 
-/// Sets and unsets the needed DirectWrite transform to support the font's 
horizontal scaling.
-class WinFontStretchGuard
+/**
+ * Sets and unsets the needed DirectWrite transform to support the font's 
horizontal scaling and
+ * rotation.
+ */
+class WinFontTransformGuard
 {
 public:
-WinFontStretchGuard(ID2D1RenderTarget* pRenderTarget, float fHScale);
-~WinFontStretchGuard();
+WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget, float fHScale, 
const GenericSalLayout& rLayout, const D2D1_POINT_2F& rBaseline);
+~WinFontTransformGuard();
 
 private:
 ID2D1RenderTarget* mpRenderTarget;
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 257c92e1a672..991c68f15b66 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -165,7 +165,7 @@ public:
 
 const WinFontFace * GetFontFace() const { return static_cast(LogicalFontInstance::GetFontFace()); }
 
-bool CacheGlyphToAtlas(HDC hDC, HFONT hFont, int nGlyphIndex, SalGraphics& 
rGraphics);
+bool CacheGlyphToAtlas(HDC hDC, HFONT hFont, int nGlyphIndex, SalGraphics& 
rGraphics, const GenericSalLayout& rLayout);
 OpenGLGlyphCache& GetOpenGLGlyphCache() { return maOpenGLGlyphCache; }
 
 bool GetGlyphOutline(sal_GlyphId, basegfx::B2DPolyPolygon&, bool) const 
override;
diff --git a/vcl/win/gdi/DWriteTextRenderer.cxx 
b/vcl/win/gdi/DWriteTextRenderer.cxx
index dac6452a41a5..98daff12c4a4 100644
--- a/vcl/win/gdi/DWriteTextRenderer.cxx
+++ b/vcl/win/gdi/DWriteTextRenderer.cxx
@@ -234,7 +234,6 @@ bool 
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
 
 const WinFontInstance& rWinFont = static_cast(rLayout.GetFont());
 float fHScale = rWinFont.getHScale();
-WinFontStretchGuard aStretchGuard(mpRT, fHScale);
 
 tools::Rectangle bounds;
 bool succeeded = rLayout.GetBoundRect(bounds);
@@ -266,6 +265,7 @@ bool 
D2DWriteTextOutRenderer::performRender(GenericSalLayout const & rLayout, Sa
 DWRITE_GLYPH_OFFSET glyphOffsets[] = { { 0.0f, 0.0f }, };
 D2D1_POINT_2F baseline = { static_cast(aPos.X() - 
bounds.Left()) / fHScale,
static_cast(aPos.Y() - 
bounds.Top()) };
+WinFontTransformGuard aTransformGuard(mpRT, fHScale, rLayout, 
baseline);
 DWRITE_GLYPH_RUN glyphs = {
 mpFontFace,
 mlfEmHeight,
@@ -384,18 +384,29 @@ bool D2DWriteTextOutRenderer::GetDWriteFaceFromHDC(HDC 
hDC, IDWriteFontFace ** p
 return succeeded;
 }
 
-WinFontStretchGuard::WinFontStretchGuard(ID2D1RenderTarget* pRenderTarget, 
float fHScale)
+WinFontTransformGuard::WinFontTransformGuard(ID2D1RenderTarget* pRenderTarget, 
float fHScale,
+ const GenericSalLayout& rLayout,
+ const D2D1_POINT_2F& rBaseline)
 : mpRenderTarget(pRenderTarget)
 {
 pRenderTarget->GetTransform();
-if (fHScale == 1.0f)
-return;
+D2D1::Matrix3x2F aTransform = maTransform;
+if (fHScale != 1.0f)
+{
+aTransform
+= aTransform * D2D1::Matrix3x2F::Scale(D2D1::Size(fHScale, 1.0f), 
D2D1::Point2F(0, 0));
+}
 
-D2D1::Matrix3x2F aTransform
-= maTransform * D2D1::Matrix3x2F::Scale(D2D1::Size(fHScale, 1.0f), 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sc/qa sc/source

[Mike Kaganski (via logerrit)]

 sc/qa/unit/data/xlsx/pivottable_long_text.xlsx |binary
 sc/qa/unit/pivottable_filters_test.cxx |   18 ++
 sc/source/filter/excel/xepivotxml.cxx  |   11 +++
 3 files changed, 29 insertions(+)

New commits:
commit f669f332733bf80b0a32022e1351957089958ce2
Author: Mike Kaganski 
AuthorDate: Tue Apr 30 16:45:54 2019 +0300
Commit: Mike Kaganski 
CommitDate: Tue Apr 30 17:25:42 2019 +0200

tdf#125046: export longText attribute for sharedItems element

Change-Id: Id727f10763bc5017eeb3e267b425d6013786d6a2
Reviewed-on: https://gerrit.libreoffice.org/71585
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/71590
Tested-by: Mike Kaganski 

diff --git a/sc/qa/unit/data/xlsx/pivottable_long_text.xlsx 
b/sc/qa/unit/data/xlsx/pivottable_long_text.xlsx
new file mode 100644
index ..f56db722e915
Binary files /dev/null and b/sc/qa/unit/data/xlsx/pivottable_long_text.xlsx 
differ
diff --git a/sc/qa/unit/pivottable_filters_test.cxx 
b/sc/qa/unit/pivottable_filters_test.cxx
index 3684497ca39a..100a8143facb 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -94,6 +94,7 @@ public:
 void tesTtdf124772NumFmt();
 void testTdf124810();
 void testTdf124883();
+void testTdf125046();
 
 CPPUNIT_TEST_SUITE(ScPivotTableFiltersTest);
 
@@ -142,6 +143,7 @@ public:
 CPPUNIT_TEST(tesTtdf124772NumFmt);
 CPPUNIT_TEST(testTdf124810);
 CPPUNIT_TEST(testTdf124883);
+CPPUNIT_TEST(testTdf125046);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -2636,6 +2638,22 @@ void ScPivotTableFiltersTest::testTdf124883()
 "Count of Value2");
 }
 
+void ScPivotTableFiltersTest::testTdf125046()
+{
+ScDocShellRef xDocSh = loadDoc("pivottable_long_text.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+
+std::shared_ptr pXPathFile
+= ScBootstrapFixture::exportTo(xDocSh.get(), FORMAT_XLSX);
+xDocSh->DoClose();
+
+xmlDocPtr pDoc = XPathHelper::parseExport(pXPathFile, m_xSFactory,
+  
"xl/pivotCache/pivotCacheDefinition1.xml");
+CPPUNIT_ASSERT(pDoc);
+assertXPath(pDoc, 
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[2]/x:sharedItems",
+"longText", "1");
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScPivotTableFiltersTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index 332c2ff2d8e3..fb174ef849f9 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -363,6 +363,7 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 double fMin = std::numeric_limits::infinity(), fMax = 
-std::numeric_limits::infinity();
 bool isValueInteger = true;
 bool isContainsDate = rCache.IsDateDimension(i);
+bool isLongText = false;
 double intpart;
 for (; it != itEnd; ++it)
 {
@@ -383,6 +384,10 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 isValueInteger = false;
 }
 }
+else if (eType == ScDPItemData::String && !isLongText)
+{
+isLongText = it->GetString().getLength() > 255;
+}
 }
 
 auto aDPTypeEnd = aDPTypes.cend();
@@ -460,6 +465,12 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 {
 pAttList->add(XML_count, 
OString::number(static_cast(rFieldItems.size(;
 }
+
+if (isLongText)
+{
+pAttList->add(XML_longText, ToPsz10(true));
+}
+
 sax_fastparser::XFastAttributeListRef xAttributeList(pAttList);
 
 pDefStrm->startElement(XML_sharedItems, xAttributeList);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

[Michael Stahl (via logerrit)]

 dev/null   |binary
 sw/qa/extras/layout/layout.cxx |3 ---
 2 files changed, 3 deletions(-)

New commits:
commit 4aeb48d4691f8852b7afd908637d1a85ae434c84
Author: Michael Stahl 
AuthorDate: Tue Apr 30 18:02:55 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 18:06:37 2019 +0200

sw: remove testForcepoint79 from SwLayoutWriter

Was recently added in 453e6fb7c1827d317dc775df32a6cf91b2bb5a67

Here this goes into an infinite loop, at least it doesn't finish in an
hour; Miklos claims it's due to missing fonts, let's just remove the
test for now, the file will still be tested by crashtesting.

Change-Id: I8acd05e9428ca25d1255b9f14ca56c7a9f5d4f00

diff --git a/sw/qa/extras/layout/data/forcepoint79-1.doc 
b/sw/qa/extras/layout/data/forcepoint79-1.doc
deleted file mode 100644
index ba53db79f278..
Binary files a/sw/qa/extras/layout/data/forcepoint79-1.doc and /dev/null differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index f6272278fee8..3e8e597dd6e8 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -2588,9 +2588,6 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint75)
 //just care it doesn't crash/assert
 CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint76) { 
createDoc("forcepoint76-1.rtf"); }
 
-//just care it doesn't crash/assert
-CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint79) { 
createDoc("forcepoint79-1.doc"); }
-
 CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf118058)
 {
 SwDoc* pDoc = createDoc("tdf118058.fodt");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Myanmar dictionary

[Cyrille]

Hello,
I found the solution. The locale iso code is wrong, I need to use bur
instead of my or my-MM. Please let me now if I'm not wrong.

Before to found the solution I wrote a other message, maybe it can be
interesting for you because it is a strange behaviour. The message:

I installed the oxt for the tamil dic. After reboot, in the list of
languages I have well the green/blue V that indicate I have the
spellchecker enable for this language (Tamil).
But not yet for Burmese even if the hunspell dic is installed.
The strange think it is if I wrote in Burmese, I have the Burmese words
proposed in the list of corrections. But the active language of the
paragraph is Tamil. If I wrote in Tamil it is the tamil words in the
proposition of correction. If I change the language of the paragraph for
Burmese, I have no more proposition of correction.
Look the screenshot.

Best regards, Cyrille

Il 29/04/2019 16:52, Cyrille ha scritto:
> I did some tests with similar languages. I install the Tamil and the
> Thai oxt spellcheckers, both give nothing as correction (with little V
> green logo).
> But Tamil I install it on a system already and it worked well. Why now
> not? Probably the problem is the same for all this 3 spellcheckers?
>
> Il 29/04/2019 14:51, Eike Rathke ha scritto:
>> Hi Cyrille,
>>
>> On Saturday, 2019-04-27 18:06:20 +0200, Cyrille wrote:
>>
>>> For dictionary on this link
>>> 
>>> I found an old extension with an hunspell dic for OpenOffice and it is
>>> probably possible to create a new extension for Libreoffice.
>> https://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/#OOoGr
>> talks about my-MMDict.oxt and says that would need some Myanmar word
>> break patches as well to work. It says "You only need the .diff patch
>> files" but doesn't list any .diff patch files (or I'm blind).
>>
>> But since then years went by and maybe ICU word break does something
>> suiting now.
>>
>> https://github.com/thanlwinsoft says "RIP Keith Stribley. 1976 - 2011"
>> so I guess he's dead and nothing will happen there. There's
>> https://github.com/thanlwinsoft/myoooext a "Myanmar line breaking and
>> spellchecking extension for OpenOffice.org" that you maybe could fork
>> and continue.
>>
>>> I'm ready
>>> to do the work, but I couldn't maintain it. Would it be possible to add
>>> it directly to Libreoffice sources?
>> If nobody is going to maintain it then sticking it into LibO core
>> doesn't help either. For an extension then it would be better if it was
>> hosted at GitLab or GitHub so anyone willing could submit pull requests
>> (that you would have to handle), or fork and continue development.
>>
>>> The same page says that the ui is translated but on Ubuntu I couldn't
>>> see the translation with the "my" locale. the
>>> http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
>>> page says too that graphite give this UI translation, then how to use it
>>> on LO?
>> You can't expect a translation of another version (specifically not OOo)
>> to work in a current LibreOffice version. Maybe Ubuntu doesn't offer
>> a 'my' language pack in its current version, I don't know.
>>
>> LO has its (54%) Burmese 'my' translation, see
>> https://translations.documentfoundation.org/my/ and installation packs
>> are available, just choose the "need another language?" link on the
>> download page and look for Burmese.
>>
>>   Eike
>>
>

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Burmess dictionary

[Cyrille]

Please update the page
https://wiki.documentfoundation.org/Language_support_of_LibreOffice with
the link to the new spellchecker for Burmese on gitlab:
https://gitlab.com/lafricain79/myanmar-hunspell-dic
I publish also an extension, but it not yet visible.

Il 30/04/2019 08:56, Cyrille ha scritto:
> Hello,
> I found the solution. The locale iso code is wrong, I need to use bur
> instead of my or my-MM. Please let me now if I'm not wrong.
>
> Before to found the solution I wrote a other message, maybe it can be
> interesting for you because it is a strange behaviour. The message:
>
> I installed the oxt for the tamil dic. After reboot, in the list of
> languages I have well the green/blue V that indicate I have the
> spellchecker enable for this language (Tamil).
> But not yet for Burmese even if the hunspell dic is installed.
> The strange think it is if I wrote in Burmese, I have the Burmese words
> proposed in the list of corrections. But the active language of the
> paragraph is Tamil. If I wrote in Tamil it is the tamil words in the
> proposition of correction. If I change the language of the paragraph for
> Burmese, I have no more proposition of correction.
> Look the screenshot.
>
> Best regards, Cyrille
>
> Il 29/04/2019 16:52, Cyrille ha scritto:
>> I did some tests with similar languages. I install the Tamil and the
>> Thai oxt spellcheckers, both give nothing as correction (with little V
>> green logo).
>> But Tamil I install it on a system already and it worked well. Why now
>> not? Probably the problem is the same for all this 3 spellcheckers?
>>
>> Il 29/04/2019 14:51, Eike Rathke ha scritto:
>>> Hi Cyrille,
>>>
>>> On Saturday, 2019-04-27 18:06:20 +0200, Cyrille wrote:
>>>
 For dictionary on this link
 
 I found an old extension with an hunspell dic for OpenOffice and it is
 probably possible to create a new extension for Libreoffice.
>>> https://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/#OOoGr
>>> talks about my-MMDict.oxt and says that would need some Myanmar word
>>> break patches as well to work. It says "You only need the .diff patch
>>> files" but doesn't list any .diff patch files (or I'm blind).
>>>
>>> But since then years went by and maybe ICU word break does something
>>> suiting now.
>>>
>>> https://github.com/thanlwinsoft says "RIP Keith Stribley. 1976 - 2011"
>>> so I guess he's dead and nothing will happen there. There's
>>> https://github.com/thanlwinsoft/myoooext a "Myanmar line breaking and
>>> spellchecking extension for OpenOffice.org" that you maybe could fork
>>> and continue.
>>>
 I'm ready
 to do the work, but I couldn't maintain it. Would it be possible to add
 it directly to Libreoffice sources?
>>> If nobody is going to maintain it then sticking it into LibO core
>>> doesn't help either. For an extension then it would be better if it was
>>> hosted at GitLab or GitHub so anyone willing could submit pull requests
>>> (that you would have to handle), or fork and continue development.
>>>
 The same page says that the ui is translated but on Ubuntu I couldn't
 see the translation with the "my" locale. the
 http://thanlwinsoft.github.io/www.thanlwinsoft.org/ThanLwinSoft/Downloads/
 page says too that graphite give this UI translation, then how to use it
 on LO?
>>> You can't expect a translation of another version (specifically not OOo)
>>> to work in a current LibreOffice version. Maybe Ubuntu doesn't offer
>>> a 'my' language pack in its current version, I don't know.
>>>
>>> LO has its (54%) Burmese 'my' translation, see
>>> https://translations.documentfoundation.org/my/ and installation packs
>>> are available, just choose the "need another language?" link on the
>>> download page and look for Burmese.
>>>
>>>   Eike
>>>


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Projects For Google Summer Of Code

[Shivam Bansal]

Hello, 
I wish to know if there are any availability for any projects under you for 
Google Summer Of Codes.

Thanks and Regards 
Shivam Bansal


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Bambara locale

[Cyrille]

Hello,
Currently I'm testing an other dictionary for the Bambara language. I
download it from
https://extensions.libreoffice.org/extensions/bambara-bamanakan-spell-checker/2.3.
The oxt is corrupt and can't be uninstall after installation on the
latest version of LO. Then I unzipped it and copied the dic/aff file in
the hunspell folder.
But LO doesn't recognize the dictionary in the list as a spellchecker. I
need to enter the code manually {bm} then it works.
The hunspell bm.dic works well with Thunderbird and Firefox. Is it a bug
with the bm locale or LO use an other code for the bambara language?
I tested also bam without success.

Please help me again.
Cyrille



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Projects For Google Summer Of Code

[Michael Stahl]

hi Shivam,

On 30.04.19 07:01, Shivam Bansal wrote:
I wish to know if there are any availability for any projects under you 
for Google Summer Of Codes.


good to hear you're interested in starting early for GSoC 2020!

we don't know yet if LibreOffice will be accepted as a project by 
Google, but we have been in the past, so we're optimistic.


so you have about 10 months to prepare by getting a build of git master 
and working on some easy-hacks :)


https://wiki.documentfoundation.org/Development/GetInvolved
https://wiki.documentfoundation.org/Development/EasyHacks

regards,
 michael
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: icon-themes/sifr_svg

[Matthias Freund (via logerrit)]

 icon-themes/sifr_svg/cmd/32/currencyfield.svg |  141 -
 icon-themes/sifr_svg/cmd/lc_currencyfield.svg |  173 --
 icon-themes/sifr_svg/cmd/sc_currencyfield.svg |  135 
 3 files changed, 3 insertions(+), 446 deletions(-)

New commits:
commit 29be6d1512375d637b41ea646be9e3ece715bba8
Author: Matthias Freund 
AuthorDate: Tue Apr 30 08:16:07 2019 +0200
Commit: Matthias Freund 
CommitDate: Wed May 1 00:09:55 2019 +0200

tdf#120135 Currency icon must not show the dollar sign SIFR

Reduced svg size

Change-Id: Iccfe353d33f7c78600a1cdf24fd67038831fc692
Reviewed-on: https://gerrit.libreoffice.org/71562
Tested-by: Jenkins
Reviewed-by: Matthias Freund 

diff --git a/icon-themes/sifr_svg/cmd/32/currencyfield.svg 
b/icon-themes/sifr_svg/cmd/32/currencyfield.svg
index f7908b83fc0e..ebd5cc8e79a2 100644
--- a/icon-themes/sifr_svg/cmd/32/currencyfield.svg
+++ b/icon-themes/sifr_svg/cmd/32/currencyfield.svg
@@ -1,140 +1 @@
-
-http://purl.org/dc/elements/1.1/;
-   xmlns:cc="http://creativecommons.org/ns#;
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
-   xmlns:svg="http://www.w3.org/2000/svg;
-   xmlns="http://www.w3.org/2000/svg;
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
-   viewBox="0 0 32 32"
-   version="1.1"
-   id="svg4"
-   sodipodi:docname="currencyfield.svg"
-   inkscape:version="0.92.4 (33fec40, 2019-01-16)"
-   
inkscape:export-filename="/home/matthias/git/icons/sifr2019/currencyfield.png"
-   inkscape:export-xdpi="96"
-   inkscape:export-ydpi="96">
-  
-
-  
-image/svg+xml
-http://purl.org/dc/dcmitype/StillImage; />
-  
-
-  
-  
-  
-
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/sifr_svg/cmd/lc_currencyfield.svg 
b/icon-themes/sifr_svg/cmd/lc_currencyfield.svg
index f051267cb5e3..0242e83980a0 100644
--- a/icon-themes/sifr_svg/cmd/lc_currencyfield.svg
+++ b/icon-themes/sifr_svg/cmd/lc_currencyfield.svg
@@ -1,172 +1 @@
-
-
-
-http://purl.org/dc/elements/1.1/;
-   xmlns:cc="http://creativecommons.org/ns#;
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
-   xmlns:svg="http://www.w3.org/2000/svg;
-   xmlns="http://www.w3.org/2000/svg;
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
-   width="24"
-   height="24"
-   id="svg7833"
-   version="1.1"
-   inkscape:version="0.92.4 (33fec40, 2019-01-16)"
-   viewBox="0 0 24 24"
-   sodipodi:docname="lc_currencyfield.svg"
-   
inkscape:export-filename="/home/matthias/git/icons/sifr2019/lc_currencyfield.png"
-   inkscape:export-xdpi="96"
-   inkscape:export-ydpi="96">
-  LibreOffice Symbolic Icon Theme SIFR
-  
-  
-
-  
-  
-
-  
-image/svg+xml
-http://purl.org/dc/dcmitype/StillImage; />
-LibreOffice Symbolic Icon Theme SIFR
-http://creativecommons.org/licenses/by-sa/4.0/; />
-
-  
-The Document Foundation
-  
-
-
-  
-Matthias Freund
-  
-
-  
-  http://creativecommons.org/licenses/by-sa/4.0/;>
-http://creativecommons.org/ns#Reproduction; />
-http://creativecommons.org/ns#Distribution; />
-http://creativecommons.org/ns#Notice; />
-http://creativecommons.org/ns#Attribution; />
-http://creativecommons.org/ns#DerivativeWorks; />
-http://creativecommons.org/ns#ShareAlike; />
-  
-
-  
-  
-
-
-
-
-
-
-
-
-
-
-
-  
-
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/sifr_svg/cmd/sc_currencyfield.svg 
b/icon-themes/sifr_svg/cmd/sc_currencyfield.svg
index 9242c78c6014..0e2b7a16d89d 100644
--- a/icon-themes/sifr_svg/cmd/sc_currencyfield.svg
+++ b/icon-themes/sifr_svg/cmd/sc_currencyfield.svg
@@ -1,134 +1 @@
-
-http://purl.org/dc/elements/1.1/;
-   xmlns:cc="http://creativecommons.org/ns#;
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
-   xmlns:svg="http://www.w3.org/2000/svg;
-   xmlns="http://www.w3.org/2000/svg;
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
-   viewBox="0 0 16 16"
-   version="1.1"
-   id="svg4"
-   sodipodi:docname="sc_currencyfield.svg"
-   inkscape:version="0.92.4 (33fec40, 2019-01-16)"
-   
inkscape:export-filename="/home/matthias/git/icons/sifr2019/sc_currencyfield.png"
-   inkscape:export-xdpi="96"
-   inkscape:export-ydpi="96">
-  
-
-  
-image/svg+xml
-http://purl.org/dc/dcmitype/StillImage; />
-  
-
-  
-  
-  
-
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-
+http://www.w3.org/2000/svg;>
\ No 

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

[andreas kainz (via logerrit)]

 icon-themes/colibre/cmd/32/mailmergecreatedocuments.png |binary
 icon-themes/colibre/cmd/32/mailmergeemaildocuments.png  |binary
 icon-themes/colibre/cmd/32/mailmergeexcludeentry.png|binary
 icon-themes/colibre/cmd/32/mailmergeprintdocuments.png  |binary
 icon-themes/colibre/cmd/32/mailmergesavedocuments.png   |binary
 icon-themes/colibre/cmd/32/mailmergewizard.png  |binary
 icon-themes/colibre/cmd/sc_mailmergeexcludeentry.png|binary
 icon-themes/colibre_svg/cmd/32/mailmergecreatedocuments.svg |   10 ++
 icon-themes/colibre_svg/cmd/32/mailmergeemaildocuments.svg  |1 +
 icon-themes/colibre_svg/cmd/32/mailmergeexcludeentry.svg|7 +++
 icon-themes/colibre_svg/cmd/32/mailmergeprintdocuments.svg  |8 
 icon-themes/colibre_svg/cmd/32/mailmergesavedocuments.svg   |9 +
 icon-themes/colibre_svg/cmd/sc_mailmergeexcludeentry.svg|4 ++--
 13 files changed, 37 insertions(+), 2 deletions(-)

New commits:
commit 0efbf84318da8232350e0114167c592e626024da
Author: andreas kainz 
AuthorDate: Wed May 1 01:03:53 2019 +0200
Commit: andreas_kainz 
CommitDate: Wed May 1 01:07:22 2019 +0200

Colibre mailmerge 32px support

Change-Id: I7614637d8b793d7e5329e110448dbdb04ada273d
Reviewed-on: https://gerrit.libreoffice.org/71606
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/colibre/cmd/32/mailmergecreatedocuments.png 
b/icon-themes/colibre/cmd/32/mailmergecreatedocuments.png
new file mode 100644
index ..d8d404fa6ba0
Binary files /dev/null and 
b/icon-themes/colibre/cmd/32/mailmergecreatedocuments.png differ
diff --git a/icon-themes/colibre/cmd/32/mailmergeemaildocuments.png 
b/icon-themes/colibre/cmd/32/mailmergeemaildocuments.png
new file mode 100644
index ..4c57111fff62
Binary files /dev/null and 
b/icon-themes/colibre/cmd/32/mailmergeemaildocuments.png differ
diff --git a/icon-themes/colibre/cmd/32/mailmergeexcludeentry.png 
b/icon-themes/colibre/cmd/32/mailmergeexcludeentry.png
new file mode 100644
index ..b39a62ad8d38
Binary files /dev/null and 
b/icon-themes/colibre/cmd/32/mailmergeexcludeentry.png differ
diff --git a/icon-themes/colibre/cmd/32/mailmergeprintdocuments.png 
b/icon-themes/colibre/cmd/32/mailmergeprintdocuments.png
new file mode 100644
index ..751cd9f411bc
Binary files /dev/null and 
b/icon-themes/colibre/cmd/32/mailmergeprintdocuments.png differ
diff --git a/icon-themes/colibre/cmd/32/mailmergesavedocuments.png 
b/icon-themes/colibre/cmd/32/mailmergesavedocuments.png
new file mode 100644
index ..d756e308f38c
Binary files /dev/null and 
b/icon-themes/colibre/cmd/32/mailmergesavedocuments.png differ
diff --git a/icon-themes/colibre/cmd/32/mailmergewizard.png 
b/icon-themes/colibre/cmd/32/mailmergewizard.png
index 5aa7c03bec1f..4c57111fff62 100644
Binary files a/icon-themes/colibre/cmd/32/mailmergewizard.png and 
b/icon-themes/colibre/cmd/32/mailmergewizard.png differ
diff --git a/icon-themes/colibre/cmd/sc_mailmergeexcludeentry.png 
b/icon-themes/colibre/cmd/sc_mailmergeexcludeentry.png
index cac4b31c5f61..e2cc1264a4ab 100644
Binary files a/icon-themes/colibre/cmd/sc_mailmergeexcludeentry.png and 
b/icon-themes/colibre/cmd/sc_mailmergeexcludeentry.png differ
diff --git a/icon-themes/colibre_svg/cmd/32/mailmergecreatedocuments.svg 
b/icon-themes/colibre_svg/cmd/32/mailmergecreatedocuments.svg
new file mode 100644
index ..43804ff15164
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/mailmergecreatedocuments.svg
@@ -0,0 +1,10 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+ 
+ 
+  
+  
+ 
+
diff --git a/icon-themes/colibre_svg/cmd/32/mailmergeemaildocuments.svg 
b/icon-themes/colibre_svg/cmd/32/mailmergeemaildocuments.svg
new file mode 100644
index ..c6f9bd4fa1b5
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/mailmergeemaildocuments.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/32/mailmergeexcludeentry.svg 
b/icon-themes/colibre_svg/cmd/32/mailmergeexcludeentry.svg
new file mode 100644
index ..f9eca5e8e4af
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/mailmergeexcludeentry.svg
@@ -0,0 +1,7 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+ 
+ 
+
diff --git a/icon-themes/colibre_svg/cmd/32/mailmergeprintdocuments.svg 
b/icon-themes/colibre_svg/cmd/32/mailmergeprintdocuments.svg
new file mode 100644
index ..92060d9813d6
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/mailmergeprintdocuments.svg
@@ -0,0 +1,8 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+ 
+ 
+ 
+
diff --git a/icon-themes/colibre_svg/cmd/32/mailmergesavedocuments.svg 
b/icon-themes/colibre_svg/cmd/32/mailmergesavedocuments.svg
new file mode 100644
index ..c70750a2b6da
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/mailmergesavedocuments.svg
@@ -0,0 +1,9 @@
+http://www.w3.org/2000/svg;>
+ 
+ 
+ 
+ 
+ 
+ 
+ 

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - shell/source

[Stephan Bergmann (via logerrit)]

 shell/source/unix/exec/shellexec.cxx |   36 ++
 shell/source/win32/SysShExec.cxx |  117 +++
 2 files changed, 153 insertions(+)

New commits:
commit bfa0f65f928e32aea98a0d639ef7ca7bf620fae3
Author: Stephan Bergmann 
AuthorDate: Fri Mar 29 14:01:19 2019 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Apr 30 23:43:34 2019 +0200

Filter out problematic file URLs

(cherry picked from commit 7e50e885ebbe130debcd4278a10a4e288655fdfc)
Conflicts:
shell/source/win32/SysShExec.cxx

Change-Id: I87fd37e56326bef4888354b923407530c6f70760
Reviewed-on: https://gerrit.libreoffice.org/70188
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit a35068ba25ed9da37bcb20598c9791b6979cf1ef)
Reviewed-on: https://gerrit.libreoffice.org/71589
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/shell/source/unix/exec/shellexec.cxx 
b/shell/source/unix/exec/shellexec.cxx
index 7f12a80b76ef..857e0b1ec90c 100644
--- a/shell/source/unix/exec/shellexec.cxx
+++ b/shell/source/unix/exec/shellexec.cxx
@@ -42,6 +42,9 @@
 #include 
 #include 
 
+#if defined MACOSX
+#include 
+#endif
 
 // namespace directives
 
@@ -129,6 +132,39 @@ void SAL_CALL ShellExec::execute( const OUString& 
aCommand, const OUString& aPar
 }
 
 #ifdef MACOSX
+if (uri->getScheme().equalsIgnoreAsciiCase("file")) {
+OUString pathname;
+auto const e1 = osl::FileBase::getSystemPathFromFileURL(aCommand, 
pathname);
+if (e1 != osl::FileBase::E_None) {
+throw css::lang::IllegalArgumentException(
+("XSystemShellExecute.execute, getSystemPathFromFileURL <" 
+ aCommand
+ + "> failed with " + OUString::number(e1)),
+{}, 0);
+}
+OString pathname8;
+if (!pathname.convertToString(
+, RTL_TEXTENCODING_UTF8,
+(RTL_UNICODETOTEXT_FLAGS_UNDEFINED_ERROR
+ | RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR)))
+{
+throw css::lang::IllegalArgumentException(
+"XSystemShellExecute.execute, cannot convert \"" + 
pathname + "\" to UTF-8", {},
+0);
+}
+struct stat st;
+auto const e2 = stat(pathname8.getStr(), );
+if (e2 != 0) {
+auto const e3 = errno;
+SAL_INFO("shell", "stat(" << pathname8 << ") failed with errno 
" << e3);
+}
+if (e2 != 0 || !S_ISREG(st.st_mode)
+|| (st.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH)) != 0)
+{
+throw css::lang::IllegalArgumentException(
+"XSystemShellExecute.execute, cannot process <" + aCommand 
+ ">", {}, 0);
+}
+}
+
 //TODO: Using open(1) with an argument that syntactically is an 
absolute
 // URI reference does not necessarily give expected results:
 // 1  If the given URI reference matches a supported scheme (e.g.,
diff --git a/shell/source/win32/SysShExec.cxx b/shell/source/win32/SysShExec.cxx
index 70c694749b66..3c577df58510 100644
--- a/shell/source/win32/SysShExec.cxx
+++ b/shell/source/win32/SysShExec.cxx
@@ -18,8 +18,11 @@
  */
 
 #include 
+#include 
 
 #include 
+#include 
+#include 
 #include "SysShExec.hxx"
 #include 
 #include 
@@ -27,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define WIN32_LEAN_AND_MEAN
 #if defined _MSC_VER
@@ -34,6 +38,7 @@
 #endif
 #include 
 #include 
+#include 
 #include 
 #if defined _MSC_VER
 #pragma warning(pop)
@@ -43,6 +48,8 @@
 // namespace directives
 
 
+#include 
+
 using com::sun::star::uno::Reference;
 using com::sun::star::uno::RuntimeException;
 using com::sun::star::uno::Sequence;
@@ -252,6 +259,20 @@ CSysShExec::CSysShExec( const Reference< 
css::uno::XComponentContext >& xContext
 CoInitialize( NULL );
 }
 
+namespace
+{
+bool checkExtension(OUString const & extension, OUString const & blacklist) {
+assert(!extension.isEmpty());
+for (sal_Int32 i = 0; i != -1;) {
+OUString tok = blacklist.getToken(0, ';', i);
+tok.startsWith(".", );
+if (extension.equalsIgnoreAsciiCase(tok)) {
+return false;
+}
+}
+return true;
+}
+}
 
 void SAL_CALL CSysShExec::execute( const OUString& aCommand, const OUString& 
aParameter, sal_Int32 nFlags )
 throw (IllegalArgumentException, SystemShellExecuteException, 
RuntimeException)
@@ -281,6 +302,102 @@ void SAL_CALL CSysShExec::execute( const OUString& 
aCommand, const OUString& aPa
  + aCommand,
 static_cast< cppu::OWeakObject * >(this), 0);
 }
+if (uri->getScheme().equalsIgnoreAsciiCase("file")) {
+OUString pathname;
+auto const e1 = 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/qt5

[Katarina Behrens (via logerrit)]

 vcl/qt5/Qt5Frame.cxx  |1 +
 vcl/qt5/Qt5Widget.cxx |1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 69582a4afcc2d8f0da602d319b5785609c0292ad
Author: Katarina Behrens 
AuthorDate: Mon Apr 29 15:42:40 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Apr 30 23:44:25 2019 +0200

tdf#123859: only accept drops when drop target was registered

some hard to reliably reproduce crashes when drag'n'dropping slides
in slide sorter in Impress can be tracked down to null drop target.
Not every SalFrame is registered as drop target, so let's accept
drops (QWidget::setAcceptDrops) only for those frames that are.

Change-Id: I01f006d619209c558e8d9976116daad65f51d7d9
Reviewed-on: https://gerrit.libreoffice.org/71533
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 
(cherry picked from commit 6a67ecd9b12e68031b5dbacb591955b59f476b86)
Reviewed-on: https://gerrit.libreoffice.org/71583
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index b1ad0f93d561..62d3808ba572 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -1100,6 +1100,7 @@ void Qt5Frame::registerDropTarget(Qt5DropTarget* 
pDropTarget)
 {
 assert(!m_pDropTarget);
 m_pDropTarget = pDropTarget;
+m_pQWidget->setAcceptDrops(true);
 }
 
 void Qt5Frame::deregisterDropTarget(Qt5DropTarget const* pDropTarget)
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 8f7cb8756c25..62fae3736247 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -445,7 +445,6 @@ Qt5Widget::Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f)
 {
 create();
 setMouseTracking(true);
-setAcceptDrops(true);
 setFocusPolicy(Qt::StrongFocus);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

[andreas kainz (via logerrit)]

 icon-themes/colibre/cmd/32/addressbooksource.png |binary
 icon-themes/colibre/cmd/32/firstpage.png |binary
 icon-themes/colibre_svg/cmd/32/addressbooksource.svg |   10 ++
 icon-themes/colibre_svg/cmd/32/firstpage.svg |2 +-
 4 files changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 66b9b44abd07b47f24ff408e49b701024862f8a6
Author: andreas kainz 
AuthorDate: Wed May 1 01:17:01 2019 +0200
Commit: andreas_kainz 
CommitDate: Wed May 1 01:18:21 2019 +0200

Colibre icon: finish mailmerge 32px support

Change-Id: I595c8494bef7c9dae16ae17bd963c79097f4a4c6
Reviewed-on: https://gerrit.libreoffice.org/71607
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/colibre/cmd/32/addressbooksource.png 
b/icon-themes/colibre/cmd/32/addressbooksource.png
new file mode 100644
index ..ccfd9853d245
Binary files /dev/null and b/icon-themes/colibre/cmd/32/addressbooksource.png 
differ
diff --git a/icon-themes/colibre/cmd/32/firstpage.png 
b/icon-themes/colibre/cmd/32/firstpage.png
index 4d458e4f03ad..97381c6916ed 100644
Binary files a/icon-themes/colibre/cmd/32/firstpage.png and 
b/icon-themes/colibre/cmd/32/firstpage.png differ
diff --git a/icon-themes/colibre_svg/cmd/32/addressbooksource.svg 
b/icon-themes/colibre_svg/cmd/32/addressbooksource.svg
new file mode 100644
index ..e285c1752494
--- /dev/null
+++ b/icon-themes/colibre_svg/cmd/32/addressbooksource.svg
@@ -0,0 +1,10 @@
+http://www.w3.org/2000/svg; viewBox="0 0 32 32">
+  
+  
+
diff --git a/icon-themes/colibre_svg/cmd/32/firstpage.svg 
b/icon-themes/colibre_svg/cmd/32/firstpage.svg
index 49cdbc6e5a4e..5bdae855d02d 100644
--- a/icon-themes/colibre_svg/cmd/32/firstpage.svg
+++ b/icon-themes/colibre_svg/cmd/32/firstpage.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/sifr_svg

[andreas kainz (via logerrit)]

 icon-themes/sifr_svg/cmd/lc_currencyfield.svg |7 ++-
 icon-themes/sifr_svg/cmd/sc_currencyfield.svg |7 ++-
 2 files changed, 12 insertions(+), 2 deletions(-)

New commits:
commit d7a0be56659b11367b20ca287bb11157865601bf
Author: andreas kainz 
AuthorDate: Wed May 1 00:32:54 2019 +0200
Commit: andreas_kainz 
CommitDate: Wed May 1 01:18:02 2019 +0200

Sifr currencyfield optimization

Change-Id: I12c8f7d73f9047e570fa094da82429fa3f523841
Reviewed-on: https://gerrit.libreoffice.org/71605
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/icon-themes/sifr_svg/cmd/lc_currencyfield.svg 
b/icon-themes/sifr_svg/cmd/lc_currencyfield.svg
index 0242e83980a0..dc3ad8d8904a 100644
--- a/icon-themes/sifr_svg/cmd/lc_currencyfield.svg
+++ b/icon-themes/sifr_svg/cmd/lc_currencyfield.svg
@@ -1 +1,6 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg; viewBox="0 0 24 24">
+  
+
diff --git a/icon-themes/sifr_svg/cmd/sc_currencyfield.svg 
b/icon-themes/sifr_svg/cmd/sc_currencyfield.svg
index 0e2b7a16d89d..40aba374a89e 100644
--- a/icon-themes/sifr_svg/cmd/sc_currencyfield.svg
+++ b/icon-themes/sifr_svg/cmd/sc_currencyfield.svg
@@ -1 +1,6 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg; viewBox="0 0 16 16">
+  
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - toolkit/qa

[Matthias Seidel (via logerrit)]

 toolkit/qa/complex/toolkit/GridControl.java |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a67bf7fdcbdd808a9b3eebf13d9a1a1084d3be2f
Author: Matthias Seidel 
AuthorDate: Tue Apr 30 18:07:54 2019 +
Commit: Matthias Seidel 
CommitDate: Tue Apr 30 18:07:54 2019 +

Fixed typos

diff --git a/toolkit/qa/complex/toolkit/GridControl.java 
b/toolkit/qa/complex/toolkit/GridControl.java
index 05440a5d9672..09efeb032008 100644
--- a/toolkit/qa/complex/toolkit/GridControl.java
+++ b/toolkit/qa/complex/toolkit/GridControl.java
@@ -128,7 +128,7 @@ public class GridControl
 // TODO: check all those generic properties for equality
 
 // the data model and the column model should have been cloned, too
-// in particular, the clone should not share the sub models with the 
orignal
+// in particular, the clone should not share the sub models with the 
original
 final XMutableGridDataModel originalDataModel = 
UnoRuntime.queryInterface( XMutableGridDataModel.class,
 m_gridControlModel.getPropertyValue( "GridDataModel" ) );
 final XMutableGridDataModel clonedDataModel = 
UnoRuntime.queryInterface( XMutableGridDataModel.class,
@@ -214,7 +214,7 @@ public class GridControl
 test.testUpdateRowHeading();
 test.cleanup();
 
-// a somehwat less straight-forward test: the data model is expected 
to implicitly increase its column count
+// a somewhat less straight-forward test: the data model is expected 
to implicitly increase its column count
 // when you add a row which has more columns than currently known
 final XMutableGridDataModel dataModel = DefaultGridDataModel.create( 
m_context );
 dataModel.addRow( 0, new Object[] { 1 } );
@@ -302,7 +302,7 @@ public class GridControl
 removeColumnIndex, removalIndex );
 }
 
-// calling addColumn with a column not created by the given 
model/implementatoion should not succeed
+// calling addColumn with a column not created by the given 
model/implementation should not succeed
 boolean caughtExpected = false;
 try
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/uiconfig

[andreas kainz (via logerrit)]

 sw/uiconfig/swriter/ui/notebookbar_single.ui |  563 +++
 1 file changed, 407 insertions(+), 156 deletions(-)

New commits:
commit 9a9d4099acb1896880939785cf80f9d00670e967
Author: andreas kainz 
AuthorDate: Wed May 1 00:07:56 2019 +0200
Commit: andreas_kainz 
CommitDate: Wed May 1 00:14:03 2019 +0200

NB contextual single update for vertical alignment

Change-Id: Id0b9a5816ee459837ca8fe2b4dd7a0233a517c0d
Reviewed-on: https://gerrit.libreoffice.org/71604
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_single.ui 
b/sw/uiconfig/swriter/ui/notebookbar_single.ui
index c6a71650067f..c3d41329d92d 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_single.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_single.ui
@@ -10,6 +10,8 @@
   
 True
 False
+center
+True
 vertical
 
   
@@ -19,17 +21,20 @@
   
 True
 False
-bottom
+center
 
   
 True
 False
 5
+4
+4
 False
 
   
 True
 False
+True
 .uno:Undo
   
   
@@ -41,6 +46,7 @@
   
 True
 False
+True
 .uno:Paste
   
   
@@ -55,21 +61,6 @@
 0
   
 
-
-  
-True
-False
-5
-5
-vertical
-  
-  
-False
-True
-5
-1
-  
-
   
   
 False
@@ -89,10 +80,29 @@
   
 True
 False
+center
+
+  
+True
+False
+center
+8
+8
+vertical
+  
+  
+False
+True
+5
+0
+  
+
 
   
 True
 False
+4
+4
 False
 
   
@@ -134,17 +144,16 @@
   
 True
 False
+center
 
   
 True
 False
-icons
 False
 
   
 True
 False
-True
 .uno:StyleApply
   
   
@@ -170,6 +179,8 @@
   
 True
 False
+center
+5
 
   
 True
@@ -179,17 +190,16 @@
   
 True
 False
-True
 .uno:CharFontName
   
   
-True
+False
 True
   
 
   
   
-True
+False
 True
 0
   
@@ -208,6 +218,8 @@
   
 True
 False
+center
+5
 
   
 True
@@ -217,17 +229,16 @@
   
 True
 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/qt5

[Katarina Behrens (via logerrit)]

 vcl/inc/qt5/Qt5DragAndDrop.hxx |2 ++
 vcl/qt5/Qt5DragAndDrop.cxx |   26 --
 2 files changed, 26 insertions(+), 2 deletions(-)

New commits:
commit 058537c95d172b4cb1256c1c6542860f4712cf21
Author: Katarina Behrens 
AuthorDate: Mon Apr 29 14:50:32 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Apr 30 23:46:20 2019 +0200

tdf#124990: DnD operation can be set to fail in dropComplete

thus we reimplement it for Qt5DropTarget. This is qt5 remix of
tdf#118302 (in Calc drop into the same tab should cancel DnD, instead
of causing data loss)

Change-Id: Ib37ea5a018133779e85e8e131d81bb6cee7d9206
Reviewed-on: https://gerrit.libreoffice.org/71531
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 
(cherry picked from commit cc6c1798b8d6d9d27dc40145e1ec71dd480c788a)
Reviewed-on: https://gerrit.libreoffice.org/71569
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/vcl/inc/qt5/Qt5DragAndDrop.hxx b/vcl/inc/qt5/Qt5DragAndDrop.hxx
index 099ba444ea15..3547131587f3 100644
--- a/vcl/inc/qt5/Qt5DragAndDrop.hxx
+++ b/vcl/inc/qt5/Qt5DragAndDrop.hxx
@@ -75,6 +75,8 @@ public:
 void fire_dragEnd(sal_Int8 nAction);
 
 static Qt5DragSource* m_ActiveDragSource;
+static bool m_bDropSuccessSet;
+static bool m_bDropSuccess;
 
 css::uno::Reference const& 
GetTransferable() const
 {
diff --git a/vcl/qt5/Qt5DragAndDrop.cxx b/vcl/qt5/Qt5DragAndDrop.cxx
index adc7a94fa0c2..42e61074a824 100644
--- a/vcl/qt5/Qt5DragAndDrop.cxx
+++ b/vcl/qt5/Qt5DragAndDrop.cxx
@@ -94,6 +94,9 @@ std::vector 
Qt5DnDTransferable::getTransferDataFl
 return aVector;
 }
 
+bool Qt5DragSource::m_bDropSuccessSet = false;
+bool Qt5DragSource::m_bDropSuccess = false;
+
 Qt5DragSource::~Qt5DragSource()
 {
 //if (m_pFrame)
@@ -140,6 +143,8 @@ void Qt5DragSource::startDrag(
 {
 Qt5Widget* qw = static_cast(m_pFrame->GetQWidget());
 m_ActiveDragSource = this;
+m_bDropSuccessSet = false;
+m_bDropSuccess = false;
 qw->startDrag(sourceActions);
 }
 else
@@ -165,7 +170,14 @@ void Qt5DragSource::fire_dragEnd(sal_Int8 nAction)
 {
 datatransfer::dnd::DragSourceDropEvent aEv;
 aEv.DropAction = nAction;
-aEv.DropSuccess = true; // FIXME: what if drop didn't work out?
+
+// internal DnD can accept the drop
+// but still fail in Qt5DropTarget::dropComplete
+if (m_bDropSuccessSet)
+aEv.DropSuccess = m_bDropSuccess;
+else
+aEv.DropSuccess = true;
+
 auto xListener = m_xListener;
 m_xListener.clear();
 xListener->dragDropEnd(aEv);
@@ -341,6 +353,16 @@ void Qt5DropTarget::rejectDrop()
 return;
 }
 
-void Qt5DropTarget::dropComplete(sal_Bool /*success*/) { return; }
+void Qt5DropTarget::dropComplete(sal_Bool success)
+{
+// internal DnD
+if (Qt5DragSource::m_ActiveDragSource)
+{
+Qt5DragSource::m_bDropSuccessSet = true;
+Qt5DragSource::m_bDropSuccess = success;
+}
+
+return;
+}
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/breeze_svg icon-themes/colibre_svg icon-themes/sifr_svg

[andreas kainz (via logerrit)]

 0 files changed

New commits:
commit cd1960e28991d62982bb4f5c636917f27db73a20
Author: andreas kainz 
AuthorDate: Tue Apr 30 23:24:35 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Wed May 1 00:16:03 2019 +0200

fix linux build replace color_scheme folder

Change-Id: Iaa20611ccde1d53cd85db63cbdab450c1622a303
Reviewed-on: https://gerrit.libreoffice.org/71601
Reviewed-by: andreas_kainz 
Tested-by: andreas_kainz 
Tested-by: Thorsten Behrens 

diff --git a/icon-themes/breeze_svg/color scheme/dark 
b/icon-themes/breeze_svg/color_scheme/dark
similarity index 100%
rename from icon-themes/breeze_svg/color scheme/dark
rename to icon-themes/breeze_svg/color_scheme/dark
diff --git a/icon-themes/breeze_svg/color scheme/standard 
b/icon-themes/breeze_svg/color_scheme/standard
similarity index 100%
rename from icon-themes/breeze_svg/color scheme/standard
rename to icon-themes/breeze_svg/color_scheme/standard
diff --git a/icon-themes/colibre_svg/color scheme/dark 
b/icon-themes/colibre_svg/color_scheme/dark
similarity index 100%
rename from icon-themes/colibre_svg/color scheme/dark
rename to icon-themes/colibre_svg/color_scheme/dark
diff --git a/icon-themes/colibre_svg/color scheme/standard 
b/icon-themes/colibre_svg/color_scheme/standard
similarity index 100%
rename from icon-themes/colibre_svg/color scheme/standard
rename to icon-themes/colibre_svg/color_scheme/standard
diff --git a/icon-themes/sifr_svg/color scheme/dark 
b/icon-themes/sifr_svg/color_scheme/dark
similarity index 100%
rename from icon-themes/sifr_svg/color scheme/dark
rename to icon-themes/sifr_svg/color_scheme/dark
diff --git a/icon-themes/sifr_svg/color scheme/standard 
b/icon-themes/sifr_svg/color_scheme/standard
similarity index 100%
rename from icon-themes/sifr_svg/color scheme/standard
rename to icon-themes/sifr_svg/color_scheme/standard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - include/o3tl

[Stephan Bergmann (via logerrit)]

 include/o3tl/runtimetooustring.hxx |   48 +
 1 file changed, 48 insertions(+)

New commits:
commit 1970481e40c825f5acbb1d54c88d9951585bd034
Author: Stephan Bergmann 
AuthorDate: Wed Nov 23 23:10:29 2016 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Apr 30 23:43:19 2019 +0200

New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUString

Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
(cherry picked from commit d689ad29c28ad7f077c2239a8fa4c2b6307a6aa1)
Reviewed-on: https://gerrit.libreoffice.org/71591
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/include/o3tl/runtimetooustring.hxx 
b/include/o3tl/runtimetooustring.hxx
new file mode 100644
index ..7f2015805722
--- /dev/null
+++ b/include/o3tl/runtimetooustring.hxx
@@ -0,0 +1,48 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_O3TL_RUNTIMETOOUSTRING_HXX
+#define INCLUDED_O3TL_RUNTIMETOOUSTRING_HXX
+
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+namespace o3tl {
+
+/** Convert an NTBS from the C++ runtime to an OUString.
+
+This is used to convert an NTBS as provided by std::exception::what or
+std::type_info::name into an OUString in a "lossless" way.  The conversion
+is done using RTL_TEXTENCODING_ISO_8859_1, so each char in the input maps
+to one Unicode character in the output.
+*/
+inline OUString runtimeToOUString(char const * runtimeString) {
+OUString s;
+bool ok = rtl_convertStringToUString(
+, runtimeString, std::strlen(runtimeString),
+RTL_TEXTENCODING_ISO_8859_1,
+(RTL_TEXTTOUNICODE_FLAGS_UNDEFINED_ERROR
+ | RTL_TEXTTOUNICODE_FLAGS_MBUNDEFINED_ERROR
+ | RTL_TEXTTOUNICODE_FLAGS_INVALID_ERROR));
+assert(ok); (void) ok;
+return s;
+}
+
+}
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa sc/source

[Mike Kaganski (via logerrit)]

 sc/qa/unit/data/xlsx/pivottable_long_text.xlsx |binary
 sc/qa/unit/pivottable_filters_test.cxx |   14 ++
 sc/source/filter/excel/xepivotxml.cxx  |   11 +++
 3 files changed, 25 insertions(+)

New commits:
commit 6952a3ba27d0d0fc08c5701b4ed7dd9982c9c60d
Author: Mike Kaganski 
AuthorDate: Tue Apr 30 16:45:54 2019 +0300
Commit: Mike Kaganski 
CommitDate: Tue Apr 30 17:07:39 2019 +0200

tdf#125046: export longText attribute for sharedItems element

Change-Id: Id727f10763bc5017eeb3e267b425d6013786d6a2
Reviewed-on: https://gerrit.libreoffice.org/71585
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/qa/unit/data/xlsx/pivottable_long_text.xlsx 
b/sc/qa/unit/data/xlsx/pivottable_long_text.xlsx
new file mode 100644
index ..f56db722e915
Binary files /dev/null and b/sc/qa/unit/data/xlsx/pivottable_long_text.xlsx 
differ
diff --git a/sc/qa/unit/pivottable_filters_test.cxx 
b/sc/qa/unit/pivottable_filters_test.cxx
index 222772b48866..d9804d0713f1 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -91,6 +91,7 @@ public:
 void tesTtdf124772NumFmt();
 void testTdf124810();
 void testTdf124883();
+void testTdf125046();
 
 CPPUNIT_TEST_SUITE(ScPivotTableFiltersTest);
 
@@ -139,6 +140,7 @@ public:
 CPPUNIT_TEST(tesTtdf124772NumFmt);
 CPPUNIT_TEST(testTdf124810);
 CPPUNIT_TEST(testTdf124883);
+CPPUNIT_TEST(testTdf125046);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -2632,6 +2634,18 @@ void ScPivotTableFiltersTest::testTdf124883()
 "Count of Value2");
 }
 
+void ScPivotTableFiltersTest::testTdf125046()
+{
+ScDocShellRef xDocSh = loadDoc("pivottable_long_text.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+
+xmlDocPtr pDoc = XPathHelper::parseExport2(
+*this, *xDocSh, m_xSFactory, 
"xl/pivotCache/pivotCacheDefinition1.xml", FORMAT_XLSX);
+CPPUNIT_ASSERT(pDoc);
+assertXPath(pDoc, 
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[2]/x:sharedItems",
+"longText", "1");
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScPivotTableFiltersTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index 75cb94dd2baa..8c263795fe94 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -350,6 +350,7 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 double fMin = std::numeric_limits::infinity(), fMax = 
-std::numeric_limits::infinity();
 bool isValueInteger = true;
 bool isContainsDate = rCache.IsDateDimension(i);
+bool isLongText = false;
 for (const auto& rFieldItem : rFieldItems)
 {
 ScDPItemData::Type eType = rFieldItem.GetType();
@@ -369,6 +370,10 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 isValueInteger = false;
 }
 }
+else if (eType == ScDPItemData::String && !isLongText)
+{
+isLongText = rFieldItem.GetString().getLength() > 255;
+}
 }
 
 auto pAttList = sax_fastparser::FastSerializerHelper::createAttrList();
@@ -444,6 +449,12 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( 
XclExpXmlStream& rStrm, const Entr
 {
 pAttList->add(XML_count, 
OString::number(static_cast(rFieldItems.size(;
 }
+
+if (isLongText)
+{
+pAttList->add(XML_longText, ToPsz10(true));
+}
+
 sax_fastparser::XFastAttributeListRef xAttributeList(pAttList);
 
 pDefStrm->startElement(XML_sharedItems, xAttributeList);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Regina Henschel (via logerrit)]

 svx/source/customshapes/EnhancedCustomShape2d.cxx |  324 --
 1 file changed, 307 insertions(+), 17 deletions(-)

New commits:
commit 89ce0ef3744572127a75fbe82c2fc194ce63b702
Author: Regina Henschel 
AuthorDate: Wed Apr 24 22:08:37 2019 +0200
Commit: Regina Henschel 
CommitDate: Tue Apr 30 17:10:35 2019 +0200

tdf#115813 Get correct adjust value from XY handle of ooxml-shape

If an adjust value is not directly bind to a handle parameter but
via formulas, the calculation of the adjust value depends on the
individual shape. The error was, that one calculation method was
applied to any OOXML-shape. User noticed, that handles did not
stick to the position, where they are released but jumped to
unexpected positions. The patch calculates guide formulas backwards
to get an adjust value. The patch solves the problem for preset
OOXML-shapes until some day a general method for any shape is
implemented.

Change-Id: I1a47082d5110a63530a273665d80348c119dc08b
Reviewed-on: https://gerrit.libreoffice.org/71258
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index 0e38216c1cd1..d34e514a69a4 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -1192,8 +1192,210 @@ bool EnhancedCustomShape2d::GetHandlePosition( const 
sal_uInt32 nIndex, Point& r
 return bRetValue;
 }
 
+static double lcl_getXAdjustmentValue(OUString& rShapeType, const sal_uInt32 
nHandleIndex,
+  const double fX, const double fW, const 
double fH)
+{
+// degenerated shapes are not worth to calculate special case for each 
shape type
+if (fW <= 0.0 || fH <= 0.0)
+return 5;
+
+// pattern (w - x) / ss * 10 or (r - x) / ss * 10
+if ((rShapeType == "ooxml-bentArrow" && nHandleIndex == 2) || (rShapeType 
== "ooxml-chevron")
+|| (rShapeType == "ooxml-curvedRightArrow") || (rShapeType == 
"ooxml-foldedCorner")
+|| (rShapeType == "ooxml-homePlate") || (rShapeType == 
"ooxml-notchedRightArrow")
+|| (rShapeType == "ooxml-rightArrow")
+|| (rShapeType == "ooxml-rightArrowCallout" && nHandleIndex == 2)
+|| (rShapeType == "ooxml-round1Rect")
+|| (rShapeType == "ooxml-round2DiagRect" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-round2SameRect" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-snip1Rect")
+|| (rShapeType == "ooxml-snip2DiagRect" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-snip2SameRect" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-snipRoundRect" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-stripedRightArrow"))
+return (fW - fX) / std::min(fW, fH) * 10.0;
+
+// pattern  x / ss * 10 or (x - l) / ss * 10
+if ((rShapeType == "ooxml-bentArrow" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-bentArrow" && nHandleIndex == 3) || 
(rShapeType == "ooxml-corner")
+|| (rShapeType == "ooxml-curvedDownArrow") || (rShapeType == 
"ooxml-curvedLeftArrow")
+|| (rShapeType == "ooxml-curvedUpArrow") || (rShapeType == 
"ooxml-leftArrow")
+|| (rShapeType == "ooxml-leftArrowCallout" && nHandleIndex == 2)
+|| (rShapeType == "ooxml-leftRightArrow")
+|| (rShapeType == "ooxml-leftRightArrowCallout" && nHandleIndex == 2)
+|| (rShapeType == "ooxml-round2DiagRect" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-round2SameRect" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-roundRect")
+|| (rShapeType == "ooxml-snip2DiagRect" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-snip2SameRect" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-snipRoundRect" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-uturnArrow" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-uturnArrow" && nHandleIndex == 3))
+return fX / std::min(fW, fH) * 10.0;
+
+// pattern (hc - x) / ss * 20
+if ((rShapeType == "ooxml-downArrowCallout" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-leftRightUpArrow" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-quadArrow" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-quadArrowCallout" && nHandleIndex == 0)
+|| (rShapeType == "ooxml-upArrowCallout" && nHandleIndex == 0))
+return (fW / 2.0 - fX) / std::min(fW, fH) * 20.0;
+
+// pattern (hc - x) / ss * 10
+if ((rShapeType == "ooxml-downArrowCallout" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-leftRightUpArrow" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-quadArrow" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-quadArrowCallout" && nHandleIndex == 1)
+|| (rShapeType == "ooxml-upArrowCallout" && nHandleIndex == 1))
+

How to run LO online on my xubuntu?

[edoardo EMAT]

Hi i've compiled both LO core and LO online.
I know i can run LO core with this command
*Start the program by running: instdir/program/soffice *it works!
**
but i really cant't understand how to start the server for usign LO
online...
i've searched for some instructions but i don't know what to do.
What's the command/procedure to start using LO online via my browser on my
xubuntu?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cui/source filter/source include/svx solenv/clang-format svx/source sw/source

[Gabor Kelemen (via logerrit)]

 cui/source/dialogs/cuiimapwnd.cxx   |1 
 cui/source/tabpages/tpline.cxx  |   11 
 cui/source/tabpages/tplnedef.cxx|3 ++
 cui/source/tabpages/tplneend.cxx|6 
 filter/source/msfilter/msdffimp.cxx |9 +++
 filter/source/msfilter/svdfppt.cxx  |2 +
 include/svx/tabline.hxx |1 
 include/svx/xattr.hxx   |1 
 include/svx/xlineit.hxx |   46 
 solenv/clang-format/blacklist   |1 
 svx/source/dialog/imapwnd.cxx   |3 +-
 svx/source/svdraw/svdcrtv.cxx   |1 
 svx/source/tbxctrls/colrctrl.cxx|1 
 svx/source/tbxctrls/linectrl.cxx|4 +++
 svx/source/xoutdev/xattr.cxx|9 +++
 svx/source/xoutdev/xpool.cxx|9 +++
 sw/source/filter/ww8/ww8graf.cxx|   10 +++
 17 files changed, 66 insertions(+), 52 deletions(-)

New commits:
commit e1a928f28ac70c4b13cf4b6fe73e7b33e2e86d2f
Author: Gabor Kelemen 
AuthorDate: Sun Apr 28 10:32:43 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 12:27:04 2019 +0200

tdf#62699 Drop pass-through header file include/svx/xlineit.hxx

Change-Id: I3ae76558f476934dffc2b43b19af848b5ad5015e
Reviewed-on: https://gerrit.libreoffice.org/71454
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/cui/source/dialogs/cuiimapwnd.cxx 
b/cui/source/dialogs/cuiimapwnd.cxx
index 7634ea091aed..c4b41afcad54 100644
--- a/cui/source/dialogs/cuiimapwnd.cxx
+++ b/cui/source/dialogs/cuiimapwnd.cxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 
diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index e2aad7f8f8a9..481dee2f39c2 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -27,6 +27,17 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+
 #include 
 #include 
 #include 
diff --git a/cui/source/tabpages/tplnedef.cxx b/cui/source/tabpages/tplnedef.cxx
index 1888b4b46b31..3264719f4809 100644
--- a/cui/source/tabpages/tplnedef.cxx
+++ b/cui/source/tabpages/tplnedef.cxx
@@ -30,6 +30,9 @@
 #include 
 
 #include 
+#include 
+#include 
+#include 
 #include 
 #include 
 
diff --git a/cui/source/tabpages/tplneend.cxx b/cui/source/tabpages/tplneend.cxx
index b97636815e25..5b5359aa6d77 100644
--- a/cui/source/tabpages/tplneend.cxx
+++ b/cui/source/tabpages/tplneend.cxx
@@ -33,6 +33,12 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 4caf50622d7f..0a1ff5c8bcf5 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -122,6 +122,15 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index b714abf001ea..30d82094bfa2 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -61,6 +61,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/include/svx/tabline.hxx b/include/svx/tabline.hxx
index ed9a8bb2f20a..dda8a85bccd5 100644
--- a/include/svx/tabline.hxx
+++ b/include/svx/tabline.hxx
@@ -22,7 +22,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/include/svx/xattr.hxx b/include/svx/xattr.hxx
index ee814da03efe..04a40f9ba58f 100644
--- a/include/svx/xattr.hxx
+++ b/include/svx/xattr.hxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/include/svx/xlineit.hxx b/include/svx/xlineit.hxx
deleted file mode 100644
index 0f364c20a31a..
--- a/include/svx/xlineit.hxx
+++ /dev/null
@@ -1,46 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef INCLUDED_SVX_XLINEIT_HXX

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/uibase/dialog/regionsw.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 6e07375f92f79959cc9288bb2a3b237b480e952c
Author: Caolán McNamara 
AuthorDate: Tue Apr 30 09:13:26 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Apr 30 12:31:10 2019 +0200

Resolves: tdf#124920 insert section from clipboard dialog doesn't cancel

Change-Id: Ic85cea08a9730cbd87d4ba1344ee6ddaa1b9d7bb
Reviewed-on: https://gerrit.libreoffice.org/71567
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/uibase/dialog/regionsw.cxx 
b/sw/source/uibase/dialog/regionsw.cxx
index 96b1a2fd9ce9..e513cbed436d 100644
--- a/sw/source/uibase/dialog/regionsw.cxx
+++ b/sw/source/uibase/dialog/regionsw.cxx
@@ -192,7 +192,9 @@ void SwWrtShell::StartInsertRegionDialog(const 
SwSectionData& rSectionData)
 VclPtr 
aTabDlg(pFact->CreateInsertSectionTabDialog(
 GetView().GetViewFrame()->GetWindow().GetFrameWeld(), aSet, *this));
 aTabDlg->SetSectionData(rSectionData);
-aTabDlg->StartExecuteAsync(nullptr);
+aTabDlg->StartExecuteAsync([aTabDlg](sal_Int32 /*nResult*/){
+aTabDlg->disposeOnce();
+});
 }
 
 void SwBaseShell::EditRegionDialog(SfxRequest const & rReq)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - vcl/headless

[Tor Lillqvist (via logerrit)]

 vcl/headless/svpinst.cxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit a1f8bc9f610e7dd234d837202bfd24337d171fdc
Author: Tor Lillqvist 
AuthorDate: Wed Apr 24 13:25:08 2019 +0300
Commit: Tor Lillqvist 
CommitDate: Tue Apr 30 12:22:08 2019 +0300

Remove unneeded iOS ifdeffery

Now with "Unipoll" this actually caused the app to hang in the master
branch, and here in this branch it caused the combo boxes in tunnelled
dialogs to stop working. Unclear whether this ifdef had ever been
strictly needed. (But before "Unipoll" it did not cause any harm.)

Change-Id: I5cc399f76fcdb267eb96bf7790474c14f2ce9955

diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index 37cc0c9bda3c..96364ae07e54 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -170,9 +170,7 @@ void SvpSalInstance::Wakeup(SvpRequest const request)
 g_CheckedMutex = true;
 }
 #endif
-#ifdef IOS
-(void)request;
-#else
+
 ImplSVData* pSVData = ImplGetSVData();
 
 if (pSVData->mpWakeCallback)
@@ -184,7 +182,6 @@ void SvpSalInstance::Wakeup(SvpRequest const request)
 pMutex->m_Request = request;
 pMutex->m_wakeUpMain = true;
 pMutex->m_WakeUpMainCond.notify_one();
-#endif
 }
 
 bool SvpSalInstance::CheckTimeout( bool bExecuteTimers )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: How to run LO online on my xubuntu?

[Tor Lillqvist]

"make run" in your online build directory.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

[Tomaž Vajngerl (via logerrit)]

 vcl/source/bitmap/BitmapScaleSuperFilter.cxx |   28 ---
 1 file changed, 21 insertions(+), 7 deletions(-)

New commits:
commit 60095b481d9663f7bcfe8078d669030ab2bc6a05
Author: Tomaž Vajngerl 
AuthorDate: Tue Apr 30 00:53:37 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 30 10:53:23 2019 +0200

tdf#125014 only use a fastpath if src. and dest. bitcount matches

It can happen that a bitmap is 32-bit (made from a VirtualDevice)
but we can't even create a 32-bit bitmap ourselves. In that case
we can only create a 24-bit, but now we can't use the fastpath
anymore as the bitdepth of source and destination is not the same.

Fix this by making sure the general scaler will be used when
source and destination bitmaps don't have the same bitcount.

Change-Id: Icdb974093558d618b7c056b29963b45ee31ce200
Reviewed-on: https://gerrit.libreoffice.org/71540
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx 
b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
index 26ea43af44a8..54f22f2dc5d8 100644
--- a/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
+++ b/vcl/source/bitmap/BitmapScaleSuperFilter.cxx
@@ -1049,10 +1049,12 @@ BitmapEx BitmapScaleSuperFilter::execute(BitmapEx 
const& rBitmap) const
 {
 Bitmap::ScopedReadAccess pReadAccess(aBitmap);
 
-sal_Int16 nTargetBitcount = aBitmap.GetBitCount() == 32 ? 32 : 24;
+sal_uInt16 nSourceBitcount = aBitmap.GetBitCount();
 
-Bitmap aOutBmp(Size(nDstW, nDstH), nTargetBitcount);
+Bitmap aOutBmp(Size(nDstW, nDstH), std::max(nSourceBitcount, 
sal_uInt16(24)));
 Size aOutSize = aOutBmp.GetSizePixel();
+sal_uInt16 nTargetBitcount = aOutBmp.GetBitCount();
+
 if (!aOutSize.Width() || !aOutSize.Height())
 {
 SAL_WARN("vcl.gdi", "bmp creation failed");
@@ -1076,7 +1078,10 @@ BitmapEx BitmapScaleSuperFilter::execute(BitmapEx const& 
rBitmap) const
bVMirr, bHMirr );
 
 bool bScaleUp = fScaleX >= fScaleThresh && fScaleY >= fScaleThresh;
-if( pReadAccess->HasPalette() )
+// If we have a source bitmap with a palette the scaling converts
+// from up to 8 bit image -> 24 bit non-palette, which is then
+// adapted back to the same type as original.
+if (pReadAccess->HasPalette())
 {
 switch( pReadAccess->GetScanlineFormat() )
 {
@@ -1090,21 +1095,30 @@ BitmapEx BitmapScaleSuperFilter::execute(BitmapEx 
const& rBitmap) const
 break;
 }
 }
+// Here we know that we are dealing with a non-palette source 
bitmap.
+// The target is either 24 or 32 bit, depending on the image and
+// the capabilities of the backend. If for some reason the 
destination
+// is not the same bit-depth as the source, then we can't use
+// a fast path, so we always need to process with a general scaler.
+else if (nSourceBitcount != nTargetBitcount)
+{
+pScaleRangeFn = bScaleUp ? scaleUpNonPalleteGeneral : 
scaleDownNonPalleteGeneral;
+}
+// If we get here then we can only use a fast path, but let's
+// still keep the fallback to the general scaler alive.
 else
 {
 switch( pReadAccess->GetScanlineFormat() )
 {
 case ScanlineFormat::N24BitTcBgr:
 case ScanlineFormat::N24BitTcRgb:
-pScaleRangeFn = bScaleUp ? scaleUp24bit
- : scaleDown24bit;
+pScaleRangeFn = bScaleUp ? scaleUp24bit : scaleDown24bit;
 break;
 case ScanlineFormat::N32BitTcRgba:
 case ScanlineFormat::N32BitTcBgra:
 case ScanlineFormat::N32BitTcArgb:
 case ScanlineFormat::N32BitTcAbgr:
-pScaleRangeFn = bScaleUp ? scaleUp32bit
- : scaleDown32bit;
+pScaleRangeFn = bScaleUp ? scaleUp32bit : scaleDown32bit;
 break;
 default:
 pScaleRangeFn = bScaleUp ? scaleUpNonPalleteGeneral
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

confusing use of 'OpCode' in formula/source/core/api/FormulaCompiler.cxx

[Winfried Donkers]

Hi,

I stumbled over an inconsistency in the use of opcodes in 
formula/source/core/api/FormulaCompiler.cxx: in two locations SC_OPCODE_xxx is 
used for functions, whereas in all other code (apart from the definitions,  
formula/inc/core_resource.hrc, sc/inc/scfuncs.hrc and 
sc/source/core/data/funcdesc.cxx) ocXxx is used. (It took me hours with gdb to 
find out why ocIf was handled differenty than ocIfs_MS when the latter was 
changed to a fump function).

I want to replace the use of SC_OPCODE_XXX in 
formula/source/core/api/FormulaCompiler.cxx with ocXxx.
In sc/source/core/data/funcdesc.cxx the situation is the other way round, 
SC_OPCODE_XXX is consequently used for functions and ocXxx is use for oSep, 
ocOpen and similar. I want to change that too to get a consistent use of opcode 
names.

So far, no real problems.
But when looking into formula/source/core/api/FormulaCompiler.cxx I noticed 
that the term 'OpCode' seems to be used both for
type  e.g. line 58:SvNumFormatType lcl_GetRetFormat( OpCode eOpCode ),
members e.g. line 127 aEntry.Token.OpCode = nOpCode; and
variables e.g. line 184: xMap->putOpCode( aOpStr, OpCode(i), pCharClass); .

And as type for opcodes both OpCode (e.g. line 58) and sal_UInt16 (e.g. line 
173) are used. OpCode cannot be used in the case of SC_OPCODE_START_UN_OP and 
the like, but
changing
static const sal_UInt16 aOpCodes[] = {
SC_OPCODE_OPEN,
SC_OPCODE_CLOSE,
SC_OPCODE_SEP,
};
to
static const OpCode aOpCodes[] = {
SC_OPCODE_OPEN,
SC_OPCODE_CLOSE,
SC_OPCODE_SEP,
};
produces compiler errors ('invalid conversion from int to OpCode' and 'invalid 
conversion from const OpCode to sal_UInt16').

I am confused by this (non) use of 'OpCode'.
Anyone who knows the why and how of this?

Winfried

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg icon-themes/colibre icon-themes/colibre_svg icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_sv

[andreas kainz (via logerrit)]

 dev/null  |binary
 icon-themes/breeze/cmd/sc_cellcontentsmenu.png|binary
 icon-themes/breeze/cmd/sc_chartmenu.png   |binary
 icon-themes/breeze/cmd/sc_editcommentsmenu.png|binary
 icon-themes/breeze/cmd/sc_flipmenu.png|binary
 icon-themes/breeze/cmd/sc_groupoutlinemenu.png|binary
 icon-themes/breeze/cmd/sc_insertpagefield.png |binary
 icon-themes/breeze/cmd/sc_openxmlfiltersettings.png   |binary
 icon-themes/breeze/cmd/sc_selectcolumn.png|binary
 icon-themes/breeze/cmd/sc_selectdata.png  |binary
 icon-themes/breeze/cmd/sc_selectrow.png   |binary
 icon-themes/breeze/cmd/sc_tablemenu.png   |binary
 icon-themes/breeze/links.txt  |   16 +-
 icon-themes/breeze_dark/cmd/sc_cellcontentsmenu.png   |binary
 icon-themes/breeze_dark/cmd/sc_chartmenu.png  |binary
 icon-themes/breeze_dark/cmd/sc_editcommentsmenu.png   |binary
 icon-themes/breeze_dark/cmd/sc_flipmenu.png   |binary
 icon-themes/breeze_dark/cmd/sc_groupoutlinemenu.png   |binary
 icon-themes/breeze_dark/cmd/sc_insertpagefield.png|binary
 icon-themes/breeze_dark/cmd/sc_openxmlfiltersettings.png  |binary
 icon-themes/breeze_dark/cmd/sc_tablemenu.png  |binary
 icon-themes/breeze_svg/cmd/sc_cellcontentsmenu.svg|   10 +++
 icon-themes/breeze_svg/cmd/sc_chartmenu.svg   |7 ++
 icon-themes/breeze_svg/cmd/sc_editcommentsmenu.svg|6 ++
 icon-themes/breeze_svg/cmd/sc_flipmenu.svg|7 ++
 icon-themes/breeze_svg/cmd/sc_groupoutlinemenu.svg|   10 +++
 icon-themes/breeze_svg/cmd/sc_insertpagefield.svg |7 ++
 icon-themes/breeze_svg/cmd/sc_openxmlfiltersettings.svg   |1 
 icon-themes/breeze_svg/cmd/sc_tablemenu.svg   |7 ++
 icon-themes/colibre/cmd/lc_dismantle.png  |binary
 icon-themes/colibre/cmd/sc_dismantle.png  |binary
 icon-themes/colibre/cmd/sc_formatungroup.png  |binary
 icon-themes/colibre/cmd/sc_groupoutlinemenu.png   |binary
 icon-themes/colibre/cmd/sc_openxmlfiltersettings.png  |binary
 icon-themes/colibre/cmd/sc_selectcolumn.png   |binary
 icon-themes/colibre/cmd/sc_selectdata.png |binary
 icon-themes/colibre/cmd/sc_selectrow.png  |binary
 icon-themes/colibre/links.txt |7 +-
 icon-themes/colibre_svg/cmd/sc_groupoutlinemenu.svg   |   18 ++
 icon-themes/colibre_svg/cmd/sc_openxmlfiltersettings.svg  |1 
 icon-themes/colibre_svg/cmd/sc_selectcolumn.svg   |1 
 icon-themes/colibre_svg/cmd/sc_selectdata.svg |1 
 icon-themes/colibre_svg/cmd/sc_selectrow.svg  |1 
 icon-themes/sifr/cmd/sc_pie.png   |binary
 icon-themes/sifr/cmd/sc_pie_unfilled.png  |binary
 icon-themes/sifr/cmd/sc_tablemenu.png |binary
 icon-themes/sifr/links.txt|6 --
 icon-themes/sifr_dark/cmd/sc_pie.png  |binary
 icon-themes/sifr_dark/cmd/sc_pie_unfilled.png |binary
 icon-themes/sifr_dark/cmd/sc_tablemenu.png|binary
 icon-themes/sifr_svg/cmd/sc_formatstylesmenu.svg  |6 --
 icon-themes/sifr_svg/cmd/sc_insertbreakmenu.svg   |6 --
 icon-themes/sifr_svg/cmd/sc_insertformmenu.svg|   14 -
 icon-themes/sifr_svg/cmd/sc_navigatemenu.svg  |6 --
 icon-themes/sifr_svg/cmd/sc_pie.svg   |4 +
 icon-themes/sifr_svg/cmd/sc_pie_unfilled.svg  |4 -
 icon-themes/sifr_svg/cmd/sc_tablemenu.svg |6 ++
 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |3 +
 sc/uiconfig/scalc/menubar/menubar.xml |   26 
+-
 sd/uiconfig/sdraw/menubar/menubar.xml |6 +-
 sd/uiconfig/simpress/menubar/menubar.xml  |6 +-
 sw/uiconfig/swriter/menubar/menubar.xml   |4 -
 62 files changed, 123 insertions(+), 74 deletions(-)

New commits:
commit 267d97ccca46a1c7eb729be7f333e1b8137b8a08
Author: andreas kainz 
AuthorDate: Tue Apr 30 01:19:58 2019 +0200
Commit: andreas_kainz 
CommitDate: Tue Apr 30 08:54:32 2019 +0200

Sifr, Breeze, Colibre 

[Libreoffice-commits] core.git: sw/qa xmloff/source

[Miklos Vajna (via logerrit)]

 sw/qa/extras/odfexport/data/btlr-frame.odt |binary
 sw/qa/extras/odfexport/odfexport.cxx   |   12 
 xmloff/source/style/prhdlfac.cxx   |1 +
 xmloff/source/style/xmlexppr.cxx   |   15 ++-
 xmloff/source/text/txtprmap.cxx|1 +
 5 files changed, 28 insertions(+), 1 deletion(-)

New commits:
commit cd2a7acd789297e613424a59b2fe24cedd9a72b6
Author: Miklos Vajna 
AuthorDate: Mon Apr 29 20:01:21 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 09:11:07 2019 +0200

sw btlr writing mode: implement ODF filter for textframes

Layout is still not yet correct right after the import, though.

Change-Id: Icdba2e8d608f35b6b5b43b88ffb223f779af1b89
Reviewed-on: https://gerrit.libreoffice.org/71552
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/odfexport/data/btlr-frame.odt 
b/sw/qa/extras/odfexport/data/btlr-frame.odt
new file mode 100644
index ..31cb03849c53
Binary files /dev/null and b/sw/qa/extras/odfexport/data/btlr-frame.odt differ
diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index 8348438437a1..4ef1128d3118 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -1409,6 +1409,18 @@ DECLARE_ODFEXPORT_TEST(testBtlrCell, "btlr-cell.odt")
 CPPUNIT_ASSERT_EQUAL(text::WritingMode2::TB_RL, 
getProperty(xC1, "WritingMode"));
 }
 
+DECLARE_ODFEXPORT_TEST(testBtlrFrame, "btlr-frame.odt")
+{
+// Without the accompanying fix in place, this test would have failed, as
+// the btlr text direction in the text frame was lost on ODF import and
+// export.
+uno::Reference xTextFrame(getShape(1), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xTextFrame.is());
+
+auto nActual = getProperty(xTextFrame, "WritingMode");
+CPPUNIT_ASSERT_EQUAL(text::WritingMode2::BT_LR, nActual);
+}
+
 DECLARE_ODFEXPORT_TEST(testFdo86963, "fdo86963.odt")
 {
 // Export of this document failed with beans::UnknownPropertyException.
diff --git a/xmloff/source/style/prhdlfac.cxx b/xmloff/source/style/prhdlfac.cxx
index a67fa04c781b..8dede8e8faa3 100644
--- a/xmloff/source/style/prhdlfac.cxx
+++ b/xmloff/source/style/prhdlfac.cxx
@@ -91,6 +91,7 @@ static SvXMLEnumMapEntry const 
aXML_WritingDirection_Enum[] =
 { XML_RL_TB,text::WritingMode2::RL_TB },
 { XML_TB_RL,text::WritingMode2::TB_RL },
 { XML_TB_LR,text::WritingMode2::TB_LR },
+{ XML_BT_LR,text::WritingMode2::BT_LR },
 
 // alternative names of the above, as accepted by XSL
 { XML_LR,   text::WritingMode2::LR_TB },
diff --git a/xmloff/source/style/xmlexppr.cxx b/xmloff/source/style/xmlexppr.cxx
index 5b2f073453fa..63994492afbc 100644
--- a/xmloff/source/style/xmlexppr.cxx
+++ b/xmloff/source/style/xmlexppr.cxx
@@ -973,7 +973,7 @@ void SvXMLExportPropertyMapper::_exportXML(
 else if ((mpImpl->mxPropMapper->GetEntryFlags(rProperty.mnIndex) & 
MID_FLAG_ELEMENT_ITEM_EXPORT ) == 0)
 {
 OUString aValue;
-const OUString sName = rNamespaceMap.GetQNameByKey(
+OUString sName = rNamespaceMap.GetQNameByKey(
 mpImpl->mxPropMapper->GetEntryNameSpace(rProperty.mnIndex),
 mpImpl->mxPropMapper->GetEntryXMLName(rProperty.mnIndex));
 
@@ -988,6 +988,19 @@ void SvXMLExportPropertyMapper::_exportXML(
 {
 if( bRemove )
 rAttrList.RemoveAttribute( sName );
+
+if 
(IsXMLToken(mpImpl->mxPropMapper->GetEntryXMLName(rProperty.mnIndex), 
XML_WRITING_MODE))
+{
+// We don't seem to have a generic mechanism to write an 
attribute in the extension
+// namespace in case of certain attribute values only, so do 
this manually.
+if (IsXMLToken(aValue, XML_BT_LR))
+{
+sName = rNamespaceMap.GetQNameByKey(
+XML_NAMESPACE_LO_EXT,
+
mpImpl->mxPropMapper->GetEntryXMLName(rProperty.mnIndex));
+}
+}
+
 rAttrList.AddAttribute( sName, aValue );
 }
 }
diff --git a/xmloff/source/text/txtprmap.cxx b/xmloff/source/text/txtprmap.cxx
index 7817bbfc2101..2cd5005dfc64 100644
--- a/xmloff/source/text/txtprmap.cxx
+++ b/xmloff/source/text/txtprmap.cxx
@@ -850,6 +850,7 @@ XMLPropertyMapEntry const aXMLFramePropMap[] =
 // RES_GRFATR_DRAWMODE
 MG_E( "GraphicColorMode", DRAW, COLOR_MODE, XML_TYPE_COLOR_MODE, 0 
),
 MG_E( "WritingMode",  STYLE, WRITING_MODE,   
XML_TYPE_TEXT_WRITING_MODE_WITH_DEFAULT, 0 ),
+MAP_EXT_I("WritingMode", XML_NAMESPACE_LO_EXT, XML_WRITING_MODE, 
XML_TYPE_TEXT_WRITING_MODE_WITH_DEFAULT|XML_TYPE_PROP_GRAPHIC, 0),
 // RES_FOLLOW_TEXT_FLOW - DVO #i18732#
 MG_E( "IsFollowingTextFlow", DRAW, FLOW_WITH_TEXT,  
XML_TYPE_BOOL|MID_FLAG_SPECIAL_ITEM_EXPORT, CTF_OLD_FLOW_WITH_TEXT ),
 MG_E( 

[Libreoffice-commits] core.git: compilerplugins/clang

[Noel Grandin (via logerrit)]

 compilerplugins/clang/stringconstant.cxx  |  105 ++
 compilerplugins/clang/test/stringconstant.cxx |   16 ---
 2 files changed, 45 insertions(+), 76 deletions(-)

New commits:
commit e02b9ccf58e9eda01f8588868ec2f367f7075dcf
Author: Noel Grandin 
AuthorDate: Tue Apr 30 09:26:47 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 30 09:28:40 2019 +0200

revert part of "improve loplugin:stringconstant"

Revert part of
commit dd8d5e5795358d732a9f7a8af7c35f662321e332
Date:   Mon Apr 29 11:18:21 2019 +0200
improve loplugin:stringconstant

sberg's original gerrit comment:
but there can also be other problematic overloads for parameters like
`void const *` or `std::string_view`.  I'm not sure this change is worth
the potential false positives.

and continuing IRC discussion:
 I'll revert the compilerplugins/ part
 noelgrandin, my main concern is that /if/ somebody eventually
runs into such an overload situation, it's really hard to get the
warnings/errors fixed for those people, short of going into the plugin
itself

Change-Id: I4916ce8943c4319d7ef9084e22d6a0eeb430b15c

diff --git a/compilerplugins/clang/stringconstant.cxx 
b/compilerplugins/clang/stringconstant.cxx
index 6a009e510297..05cfa03ff711 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -58,19 +58,7 @@ bool isLhsOfAssignment(FunctionDecl const * decl, unsigned 
parameter) {
 || (oo >= OO_PlusEqual && oo <= OO_GreaterGreaterEqual);
 }
 
-bool typecheckIsOUStringParam(const clang::QualType t) {
-return bool(loplugin::TypeCheck(t).NotSubstTemplateTypeParmType()
-.LvalueReference().Const().NotSubstTemplateTypeParmType()
-.Class("OUString").Namespace("rtl").GlobalNamespace());
-}
-
-bool typecheckIsOStringParam(const clang::QualType t) {
-return bool(loplugin::TypeCheck(t).NotSubstTemplateTypeParmType()
-.LvalueReference().Const().NotSubstTemplateTypeParmType()
-.Class("OString").Namespace("rtl").GlobalNamespace());
-}
-
-bool hasOverloads(FunctionDecl const * decl, unsigned arguments, unsigned 
paramIndex) {
+bool hasOverloads(FunctionDecl const * decl, unsigned arguments) {
 int n = 0;
 auto ctx = decl->getDeclContext();
 if (ctx->getDeclKind() == Decl::LinkageSpec) {
@@ -79,32 +67,17 @@ bool hasOverloads(FunctionDecl const * decl, unsigned 
arguments, unsigned paramI
 auto res = ctx->lookup(decl->getDeclName());
 for (auto d = res.begin(); d != res.end(); ++d) {
 FunctionDecl const * f = dyn_cast(*d);
-if (f == nullptr || f->getMinRequiredArguments() > arguments
-|| f->getNumParams() < arguments) {
-continue;
-}
-auto consDecl = dyn_cast(f);
-if (consDecl && consDecl->isCopyOrMoveConstructor()) {
-continue;
-}
-// Deleted stuff like in ORowSetValueDecorator in connectivity can 
cause
-// trouble.
-if (consDecl && consDecl->isDeleted()) {
-return true;
-}
-if (paramIndex >= f->getNumParams()) {
-continue;
-}
-auto t = f->getParamDecl(paramIndex)->getType();
-// bool because 'const char *' converts to bool
-if (!typecheckIsOUStringParam(t) && !typecheckIsOStringParam(t)
-&& !loplugin::TypeCheck(t).Pointer().Const().Char()
-&& !loplugin::TypeCheck(t).AnyBoolean()) {
-continue;
-}
-++n;
-if (n == 2) {
-return true;
+if (f != nullptr && f->getMinRequiredArguments() <= arguments
+&& f->getNumParams() >= arguments)
+{
+auto consDecl = dyn_cast(f);
+if (consDecl && consDecl->isCopyOrMoveConstructor()) {
+continue;
+}
+++n;
+if (n == 2) {
+return true;
+}
 }
 }
 return false;
@@ -296,6 +269,29 @@ bool StringConstant::VisitCallExpr(CallExpr const * expr) {
 if (fdecl == nullptr) {
 return true;
 }
+for (unsigned i = 0; i != fdecl->getNumParams(); ++i) {
+auto t = fdecl->getParamDecl(i)->getType();
+if (loplugin::TypeCheck(t).NotSubstTemplateTypeParmType()
+.LvalueReference().Const().NotSubstTemplateTypeParmType()
+.Class("OUString").Namespace("rtl").GlobalNamespace())
+{
+if (!(isLhsOfAssignment(fdecl, i)
+  || hasOverloads(fdecl, expr->getNumArgs(
+{
+handleOUStringCtor(expr, i, fdecl, true);
+}
+}
+if (loplugin::TypeCheck(t).NotSubstTemplateTypeParmType()
+.LvalueReference().Const().NotSubstTemplateTypeParmType()
+.Class("OString").Namespace("rtl").GlobalNamespace())
+{
+if (!(isLhsOfAssignment(fdecl, i)
+  

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - vcl/headless

[Katarina Behrens (via logerrit)]

 vcl/headless/svpgdi.cxx |   20 +++-
 1 file changed, 7 insertions(+), 13 deletions(-)

New commits:
commit 70ecf4bb6d300e02e8765754ef2bb41bd2d851c2
Author: Katarina Behrens 
AuthorDate: Fri Apr 26 17:12:41 2019 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Apr 30 10:19:46 2019 +0200

tdf#120797: Apply transformation also to the extents of damage

since 7034311dce663c895577267110baadbec312d491 affine transformation
is passed down to drawPolyPolygon and drawPolyLine functions.

The transformation was correctly applied to cairo context, but not
the extents of damage so those had old, untransformed coordinates and
were therefore not redrawn

Change-Id: I61ce005ef8770ce5c4560a9d953cd92f440043be
Reviewed-on: https://gerrit.libreoffice.org/71383
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

remove comment in light of fix for tdf#120797

Change-Id: I3093f764a26abdbdb651596352ba74b7fa1c3306
Reviewed-on: https://gerrit.libreoffice.org/71399
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/71534
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 0e5a07ec7d61..7efb9423359c 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1136,6 +1136,9 @@ bool SvpSalGraphics::drawPolyLine(
 fMiterMinimumAngle,
 bPixelSnapHairline));
 
+// if transformation has been applied, transform also extents (ranges)
+// of damage so they can be correctly redrawn
+aExtents.transform(rObjectToDevice);
 releaseCairoContext(cr, false, aExtents);
 
 return bRetval;
@@ -1336,21 +1339,9 @@ bool SvpSalGraphics::drawPolyLine(
 }
 
 // extract extents
-if(nullptr != pExtents)
-{
-// This uses cairo_stroke_extents and combines with 
cairo_clip_extents, so
-// referring to Cairo-documentation:
-// "Computes a bounding box in user coordinates covering the area that 
would
-//  be affected, (the "inked" area), by a cairo_stroke() operation 
given the
-//  current path and stroke parameters."
-// It *should* use the current set cairo_matrix_t.
+if (pExtents)
 *pExtents = getClippedStrokeDamage(cr);
 
-// If not - the following code needs to be used to correct that:
-// if(!pExtents->isEmpty() && !bObjectToDeviceIsIdentity)
-// pExtents->transform(rObjectToDevice);
-}
-
 // draw and consume
 cairo_stroke(cr);
 
@@ -1483,6 +1474,9 @@ bool SvpSalGraphics::drawPolyPolygon(
 cairo_stroke_preserve(cr);
 }
 
+// if transformation has been applied, transform also extents (ranges)
+// of damage so they can be correctly redrawn
+extents.transform(rObjectToDevice);
 releaseCairoContext(cr, true, extents);
 
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang editeng/source filter/source framework/source include/uno reportdesign/source sal/qa sc/source sdext/source sd/source sfx2/source stoc/source svx/

[Noel Grandin (via logerrit)]

 compilerplugins/clang/stringconstant.cxx   |  105 
+-
 compilerplugins/clang/test/stringconstant.cxx  |   16 +
 editeng/source/misc/swafopt.cxx|3 
 filter/source/msfilter/eschesdo.cxx|4 
 filter/source/pdf/pdfexport.cxx|4 
 framework/source/fwe/classes/addonsoptions.cxx |2 
 include/uno/mapping.hxx|8 
 reportdesign/source/core/api/ReportComponent.cxx   |6 
 reportdesign/source/core/api/ReportDefinition.cxx  |6 
 reportdesign/source/ui/report/dlgedfac.cxx |2 
 sal/qa/rtl/oustringbuffer/test_oustringbuffer_tostring.cxx |2 
 sc/source/core/tool/interpr5.cxx   |4 
 sc/source/filter/excel/excform.cxx |4 
 sc/source/filter/excel/excform8.cxx|4 
 sc/source/ui/app/scmod.cxx |2 
 sd/source/core/stlpool.cxx |2 
 sdext/source/presenter/PresenterNotesView.cxx  |2 
 sdext/source/presenter/PresenterScrollBar.cxx  |2 
 sdext/source/presenter/PresenterSlidePreview.cxx   |2 
 sdext/source/presenter/PresenterWindowManager.cxx  |2 
 sfx2/source/control/unoctitm.cxx   |4 
 stoc/source/corereflection/crefl.cxx   |8 
 svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx  |4 
 svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx |8 
 sw/qa/extras/uiwriter/uiwriter.cxx |4 
 sw/source/core/doc/DocumentTimerManager.cxx|3 
 sw/source/core/swg/SwXMLTextBlocks1.cxx|2 
 sw/source/filter/ww8/rtfexport.cxx |2 
 sw/source/uibase/app/appopt.cxx|6 
 tools/qa/cppunit/test_config.cxx   |   18 -
 tools/source/fsys/urlobj.cxx   |3 
 vcl/headless/svpprn.cxx|4 
 vcl/source/app/settings.cxx|2 
 vcl/source/filter/GraphicNativeTransform.cxx   |4 
 vcl/source/gdi/print3.cxx  |   38 
+--
 vcl/source/treelist/treelistbox.cxx|2 
 vcl/source/window/builder.cxx  |   24 
+-
 vcl/source/window/settings.cxx |2 
 vcl/source/window/toolbox2.cxx |4 
 vcl/unx/generic/print/printerjob.cxx   |2 
 vcl/unx/generic/print/prtsetup.cxx |   12 -
 vcl/unx/generic/printer/jobdata.cxx|   12 -
 vcl/unx/generic/printer/ppdparser.cxx  |   38 
+--
 vcl/unx/generic/printer/printerinfomanager.cxx |6 
 writerfilter/source/rtftok/rtfdispatchdestination.cxx  |2 
 xmloff/source/style/xmlnumfi.cxx   |4 
 46 files changed, 210 insertions(+), 190 deletions(-)

New commits:
commit dd8d5e5795358d732a9f7a8af7c35f662321e332
Author: Noel Grandin 
AuthorDate: Mon Apr 29 11:18:21 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 30 08:43:51 2019 +0200

improve loplugin:stringconstant

to find more places we can elide the OUString() constructor at call
sites

Change-Id: Ie09f3c61f2c4b4959c97dc98ebcbaf7c51d5d713
Reviewed-on: https://gerrit.libreoffice.org/71514
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/stringconstant.cxx 
b/compilerplugins/clang/stringconstant.cxx
index 05cfa03ff711..6a009e510297 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -58,7 +58,19 @@ bool isLhsOfAssignment(FunctionDecl const * decl, unsigned 
parameter) {
 || (oo >= OO_PlusEqual && oo <= OO_GreaterGreaterEqual);
 }
 
-bool hasOverloads(FunctionDecl const * decl, unsigned arguments) {
+bool typecheckIsOUStringParam(const clang::QualType t) {
+return bool(loplugin::TypeCheck(t).NotSubstTemplateTypeParmType()
+.LvalueReference().Const().NotSubstTemplateTypeParmType()
+.Class("OUString").Namespace("rtl").GlobalNamespace());
+}
+
+bool 

[Libreoffice-commits] core.git: basctl/source basic/source chart2/source comphelper/source compilerplugins/clang connectivity/source filter/source include/com include/comphelper include/oox include/rt

[Noel Grandin (via logerrit)]

 basctl/source/basicide/documentenumeration.cxx  |4 -
 basic/source/basmgr/basicmanagerrepository.cxx  |3 
 chart2/source/view/charttypes/BarChart.cxx  |   23 --
 comphelper/source/container/embeddedobjectcontainer.cxx |7 --
 compilerplugins/clang/refcounting.cxx   |2 
 connectivity/source/cpool/ZPoolCollection.hxx   |5 -
 filter/source/svg/svgfilter.hxx |   22 ++
 include/com/sun/star/uno/Reference.hxx  |   20 ++
 include/comphelper/accessiblewrapper.hxx|2 
 include/comphelper/stl_types.hxx|   15 
 include/oox/export/shapes.hxx   |   14 
 include/rtl/ref.hxx |   24 +++
 include/svx/fmtools.hxx |5 -
 io/source/acceptor/acc_socket.cxx   |   23 --
 io/source/connector/connector.hxx   |   23 --
 oox/source/export/shapes.cxx|5 -
 reportdesign/source/core/sdr/UndoEnv.cxx|3 
 scripting/source/provider/ActiveMSPList.hxx |3 
 stoc/source/servicemanager/servicemanager.cxx   |   22 --
 svx/source/form/fmpgeimp.cxx|2 
 svx/source/form/navigatortree.cxx   |3 
 svx/source/inc/fmcontrolbordermanager.hxx   |4 -
 svx/source/inc/fmvwimp.hxx  |   10 ---
 svx/source/table/accessibletableshape.cxx   |   10 ---
 xmloff/source/forms/eventimport.hxx |4 -
 xmloff/source/forms/ifacecompare.hxx|   53 
 xmloff/source/forms/layerexport.hxx |7 --
 xmloff/source/forms/layerimport.hxx |3 
 28 files changed, 73 insertions(+), 248 deletions(-)

New commits:
commit 22f2cf3ccc6d0c9ba2c2860735e789d6b3a25f72
Author: Noel Grandin 
AuthorDate: Mon Apr 29 16:24:12 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Apr 30 08:43:04 2019 +0200

implement std::hash for css::uno::Reference and rtl::Reference

The declaration in BarChart.cxx is particularly suspicious, because it
was using a < for the KeyEqual template parameter.
Been there since:
commit b2c3233e5f267b5d244d722a94424a3b224b3314
Date:   Thu Dec 21 20:08:33 2017 +0900
chart2: suspend/resume setting rects dirty for 3D shapes

comphelper::OInterfaceCompare is no longer necessary

Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975
Reviewed-on: https://gerrit.libreoffice.org/71537
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/basicide/documentenumeration.cxx 
b/basctl/source/basicide/documentenumeration.cxx
index fd1517d097f9..9d00474efa00 100644
--- a/basctl/source/basicide/documentenumeration.cxx
+++ b/basctl/source/basicide/documentenumeration.cxx
@@ -29,8 +29,6 @@
 
 #include 
 
-#include 
-
 namespace basctl { namespace docs {
 
 using ::com::sun::star::uno::Exception;
@@ -105,7 +103,7 @@ namespace basctl { namespace docs {
 const IDocumentDescriptorFilter* _pFilter )
 {
 // ensure we don't encounter some models multiple times
-std::set< Reference< XModel >, ::comphelper::OInterfaceCompare< 
XModel > > aEncounteredModels;
+std::set< Reference< XModel > > aEncounteredModels;
 
 for ( auto const & rFrame : _rFrames )
 {
diff --git a/basic/source/basmgr/basicmanagerrepository.cxx 
b/basic/source/basmgr/basicmanagerrepository.cxx
index 5b8b10f56d31..b725f0563a3c 100644
--- a/basic/source/basmgr/basicmanagerrepository.cxx
+++ b/basic/source/basmgr/basicmanagerrepository.cxx
@@ -35,7 +35,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -62,7 +61,7 @@ namespace basic
 using ::com::sun::star::document::XStorageBasedDocument;
 using ::com::sun::star::document::XEmbeddedScripts;
 
-typedef std::map< Reference< XInterface >, std::unique_ptr, 
::comphelper::OInterfaceCompare< XInterface > > BasicManagerStore;
+typedef std::map< Reference< XInterface >, std::unique_ptr > 
BasicManagerStore;
 
 typedef std::vector< BasicManagerCreationListener* >  CreationListeners;
 
diff --git a/chart2/source/view/charttypes/BarChart.cxx 
b/chart2/source/view/charttypes/BarChart.cxx
index b3d27a933d7a..bb1c50387d2e 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -45,27 +45,6 @@ using namespace ::com::sun::star;
 using namespace ::rtl::math;
 using namespace ::com::sun::star::chart2;
 
-namespace
-{
-
-struct XShapeCompare
-{
-bool operator() (uno::Reference const & lhs, 
uno::Reference const & rhs) const
-{
-return lhs.get() < rhs.get();
-}
-};
-
-struct XShapeHash
-{
-bool 

[Libreoffice-commits] core.git: dictionaries

[wishawa (via logerrit)]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f45f8d0c6eb1d5d28a92399b82d13c2894f06069
Author: wishawa 
AuthorDate: Mon Apr 29 17:38:28 2019 +0700
Commit: Gerrit Code Review 
CommitDate: Tue Apr 30 09:35:45 2019 +0200

Update git submodules

* Update dictionaries from branch 'master'
  - Update Thai dictionary: corrections, UTF-8, and over ten thousand more 
words.

Change-Id: Iea084036516e727af2f70729bd7484fb9cbdad90
Reviewed-on: https://gerrit.libreoffice.org/71523
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/dictionaries b/dictionaries
index 5fe575dbcfeb..661e18650eb4 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 5fe575dbcfeb789e2ab2d9731b88ac0dacc4f453
+Subproject commit 661e18650eb4f810b566fe4cbae64755a7ecf804
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/qt5

[Katarina Behrens (via logerrit)]

 vcl/qt5/Qt5Frame.cxx  |1 +
 vcl/qt5/Qt5Widget.cxx |1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6a67ecd9b12e68031b5dbacb591955b59f476b86
Author: Katarina Behrens 
AuthorDate: Mon Apr 29 15:42:40 2019 +0200
Commit: Katarina Behrens 
CommitDate: Tue Apr 30 10:08:09 2019 +0200

tdf#123859: only accept drops when drop target was registered

some hard to reliably reproduce crashes when drag'n'dropping slides
in slide sorter in Impress can be tracked down to null drop target.
Not every SalFrame is registered as drop target, so let's accept
drops (QWidget::setAcceptDrops) only for those frames that are.

Change-Id: I01f006d619209c558e8d9976116daad65f51d7d9
Reviewed-on: https://gerrit.libreoffice.org/71533
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 93c37f7a426f..b07ea360a1cc 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -,6 +,7 @@ void Qt5Frame::registerDropTarget(Qt5DropTarget* 
pDropTarget)
 {
 assert(!m_pDropTarget);
 m_pDropTarget = pDropTarget;
+m_pQWidget->setAcceptDrops(true);
 }
 
 void Qt5Frame::deregisterDropTarget(Qt5DropTarget const* pDropTarget)
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index c04564a75e06..f2c574a99655 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -446,7 +446,6 @@ Qt5Widget::Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f)
 {
 create();
 setMouseTracking(true);
-setAcceptDrops(true);
 setFocusPolicy(Qt::StrongFocus);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - vcl/headless

[Michael Meeks (via logerrit)]

 vcl/headless/svpinst.cxx |   18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

New commits:
commit 0484c3a4d5b20d70209982265b9d44bd24b88aa9
Author: Michael Meeks 
AuthorDate: Sat Apr 27 22:23:03 2019 +0100
Commit: Michael Meeks 
CommitDate: Tue Apr 30 10:30:24 2019 +0200

unipoll: do the legacy wakeup if not in unipoll mode.

Change-Id: I7f5663f3316eb2bafcf13d07e2af69ae6f0637f5
Reviewed-on: https://gerrit.libreoffice.org/71504
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index 9b339bf72018..37cc0c9bda3c 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -367,9 +367,23 @@ sal_uInt32 SvpSalYieldMutex::doRelease(bool const 
bUnlockAll)
 // read m_nCount before doRelease
 bool const isReleased(bUnlockAll || m_nCount == 1);
 nCount = comphelper::GenericSolarMutex::doRelease( bUnlockAll );
-if (isReleased && pInst)
-pInst->Wakeup(SvpRequest::NONE);
+if (isReleased)
+{
+ImplSVData* pSVData = ImplGetSVData();
+if (pSVData->mpPollCallback) // is unipoll
+{
+if (pInst)
+pInst->Wakeup(SvpRequest::NONE);
+}
+else
+{
+std::unique_lock g(m_WakeUpMainMutex);
+m_wakeUpMain = true;
+m_WakeUpMainCond.notify_one();
+}
+}
 }
+
 return nCount;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: scp2/source

[Xisco Fauli (via logerrit)]

 scp2/source/ooo/scpaction_ooo.scp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1d940ec1de349349b048056c4284223d6eea48f3
Author: Xisco Fauli 
AuthorDate: Sat Apr 27 14:51:08 2019 +0200
Commit: Andras Timar 
CommitDate: Tue Apr 30 08:48:27 2019 +0200

Fix mac build with --with-package-format=dmg

Regression from 7a9f6df7fb83ec23d09cb5744c2c865fa22e7143

ERROR: The following errors occurred in packaging process:

ERROR: Source for LICENSE.html not found!
ERROR: Could not copy  to
 /Users/gerrit/lode/bibisect/core63/workdir/installation/LibreOfficeDev/dmg/

install/en-US_inprogress/LibreOfficeDev_6.3.0.0.alpha0_MacOS_x86-64/LICENSEs/LICENSE.html
 No such file or directory

Change-Id: I6c51a853238b1ecea64f900c0c60e7a9bb370dc9
Reviewed-on: https://gerrit.libreoffice.org/71417
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/scp2/source/ooo/scpaction_ooo.scp 
b/scp2/source/ooo/scpaction_ooo.scp
index ad15dfb8aaab..415963480734 100644
--- a/scp2/source/ooo/scpaction_ooo.scp
+++ b/scp2/source/ooo/scpaction_ooo.scp
@@ -20,8 +20,8 @@
 
 #ifdef MACOSX
 ScpAction scp_Copy_Thirdpartylicense_Readme_Html
-Copy = "LICENSE.html";
-Name= "LICENSE.html";
+Copy = "license.html";
+Name= "license.html";
 Subdir = "LICENSEs";
 End
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/oox oox/source sd/qa

[Grzegorz Araminowicz (via logerrit)]

 include/oox/drawingml/theme.hxx|1 
 oox/source/ppt/presentationfragmenthandler.cxx |7 +-
 sd/qa/unit/data/pptx/ooxtheme.pptx |binary
 sd/qa/unit/import-tests.cxx|   28 +
 4 files changed, 35 insertions(+), 1 deletion(-)

New commits:
commit cd08835d1bd9274412c7326db32fb3752bc94fb3
Author: Grzegorz Araminowicz 
AuthorDate: Mon Apr 29 14:44:20 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 09:13:28 2019 +0200

PPTX import: store OOXTheme in InteropGrabBag for SmartArt re-generation

Change-Id: I343dc3a275ecbbb483e179d8cc2deebfb71b9c8f
Reviewed-on: https://gerrit.libreoffice.org/71530
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/oox/drawingml/theme.hxx b/include/oox/drawingml/theme.hxx
index 9593b77eb5f9..bde25e748ba8 100644
--- a/include/oox/drawingml/theme.hxx
+++ b/include/oox/drawingml/theme.hxx
@@ -97,6 +97,7 @@ public:
 Shape&   getTxDef() { return maTxDef; }
 const Shape& getTxDef() const { return maTxDef; }
 
+const css::uno::Reference& getFragment() const { 
return mxFragment; }
 void setFragment( const css::uno::Reference< 
css::xml::dom::XDocument>& xRef ) { mxFragment=xRef; }
 
 private:
diff --git a/oox/source/ppt/presentationfragmenthandler.cxx 
b/oox/source/ppt/presentationfragmenthandler.cxx
index 90e8013b741e..689e6e162cc5 100644
--- a/oox/source/ppt/presentationfragmenthandler.cxx
+++ b/oox/source/ppt/presentationfragmenthandler.cxx
@@ -179,7 +179,7 @@ void PresentationFragmentHandler::saveThemeToGrabBag(const 
oox::drawingml::Theme
 // get existing grab bag
 comphelper::SequenceAsHashMap 
aGrabBag(xDocProps->getPropertyValue(aGrabBagPropName));
 
-uno::Sequence aTheme(1);
+uno::Sequence aTheme(2);
 comphelper::SequenceAsHashMap aThemesHashMap;
 
 // create current theme
@@ -204,6 +204,11 @@ void PresentationFragmentHandler::saveThemeToGrabBag(const 
oox::drawingml::Theme
 const uno::Any& rCurrentTheme = makeAny(aCurrentTheme);
 aTheme[0].Value = rCurrentTheme;
 
+// store DOM fragment for SmartArt re-generation
+aTheme[1].Name = "OOXTheme";
+const uno::Any& rOOXTheme = makeAny(pThemePtr->getFragment());
+aTheme[1].Value = rOOXTheme;
+
 aThemesHashMap << aTheme;
 
 // put the new items
diff --git a/sd/qa/unit/data/pptx/ooxtheme.pptx 
b/sd/qa/unit/data/pptx/ooxtheme.pptx
new file mode 100644
index ..f0f3f2575894
Binary files /dev/null and b/sd/qa/unit/data/pptx/ooxtheme.pptx differ
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 5d690c8a1491..566818755c5b 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -79,6 +79,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -199,6 +200,7 @@ public:
 void testTdf83247();
 void testTdf47365();
 void testTdf122899();
+void testOOXTheme();
 
 CPPUNIT_TEST_SUITE(SdImportTest);
 
@@ -288,6 +290,7 @@ public:
 CPPUNIT_TEST(testTdf83247);
 CPPUNIT_TEST(testTdf47365);
 CPPUNIT_TEST(testTdf122899);
+CPPUNIT_TEST(testOOXTheme);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -2743,6 +2746,31 @@ void SdImportTest::testTdf122899()
 xDocShRef->DoClose();
 }
 
+void SdImportTest::testOOXTheme()
+{
+sd::DrawDocShellRef xDocShRef
+= 
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/ooxtheme.pptx"), 
PPTX);
+
+uno::Reference 
xPropSet(xDocShRef->GetDoc()->getUnoModel(), uno::UNO_QUERY_THROW);
+uno::Sequence aGrabBag;
+xPropSet->getPropertyValue("InteropGrabBag") >>= aGrabBag;
+
+bool bTheme = false;
+for (int i = 0; i < aGrabBag.getLength(); i++)
+{
+if (aGrabBag[i].Name == "OOXTheme")
+{
+bTheme = true;
+uno::Reference aThemeDom;
+CPPUNIT_ASSERT(aGrabBag[i].Value >>= aThemeDom); // PropertyValue 
of proper type
+CPPUNIT_ASSERT(aThemeDom.get()); // Reference not empty
+}
+}
+CPPUNIT_ASSERT(bTheme); // Grab Bag has all the expected elements
+
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

[Libreoffice Gerrit user]

 esc-reporting/esc-analyze.py |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit d0bb7798e7865411682fcda4ce63a3092dfff62b
Author: Xisco Fauli 
AuthorDate: Tue Apr 30 09:33:50 2019 +0200
Commit: Xisco Fauli 
CommitDate: Tue Apr 30 09:33:50 2019 +0200

ESC: Add a different reviewer for online

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index b59352b..927f513 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -720,7 +720,11 @@ def analyze_reports():
 if cntReview == 0 and not 
statList['people'][ownerEmail]['isCommitter']:
 tmpListToReview.append({'id': entry['id'], 'fullid': 
entry['fullid'], 'patchset': patchset})
 
-defaultEmail = util_check_mail('', 
cfg['automate']['gerritReviewUserEmail'])
+if gerritData['patch'][rowTmp['id']]['project'] == 'online':
+defaultEmail = util_check_mail('', 
cfg['automate']['gerritReviewOnlineUserEmail'])
+else:
+defaultEmail = util_check_mail('', 
cfg['automate']['gerritReviewUserEmail'])
+
 for rowTmp in tmpListToReview:
   reviewEmail = defaultEmail
   txt = gerritData['patch'][rowTmp['id']]['subject']
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sfx2/source

[Tamás Zolnai (via logerrit)]

 sfx2/source/doc/objstor.cxx |   14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

New commits:
commit c6be7681bffb008e83f2b2a9b0e2b08847a18289
Author: Tamás Zolnai 
AuthorDate: Sun Apr 28 15:21:39 2019 +0200
Commit: Andras Timar 
CommitDate: Tue Apr 30 09:02:12 2019 +0200

WebDav: Don't unlock the file during saving of a document

Otherwise it can happen that the file is locked by someone
else during the saving method is running.
I just extended the scope of the existing DisableUnlockWebDAV()
calls a bit. In case of webdav it does not cause an issue to
avoid unlocking the file before locking it again with an other
SfxMedium.

Change-Id: I6ac4e3326c63c9e184a7710ce8994cac1ed79449
Reviewed-on: https://gerrit.libreoffice.org/71484
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 
(cherry picked from commit fdab153636ad7e3ce4b09836a63d2fa11b42e728)
Reviewed-on: https://gerrit.libreoffice.org/71512
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index c776ff944957..1b04019c95c3 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -1200,6 +1200,10 @@ bool SfxObjectShell::SaveTo_Impl
   && !rMedium.GetName().equalsIgnoreAsciiCase("private:stream")
   && ::utl::UCBContentHelper::EqualURLs( pMedium->GetName(), 
rMedium.GetName() ) )
 {
+// Do not unlock the file during saving.
+// need to modify this for WebDAV if this method is called outside of
+// the process of saving a file
+pMedium->DisableUnlockWebDAV();
 bStoreToSameLocation = true;
 
 if ( pMedium->DocNeedsFileDateCheck() )
@@ -1298,6 +1302,7 @@ bool SfxObjectShell::SaveTo_Impl
 }
 }
 }
+pMedium->DisableUnlockWebDAV(false);
 }
 else
 {
@@ -1718,10 +1723,6 @@ bool SfxObjectShell::SaveTo_Impl
 return bOk;
 }
 
-
-// This method contains a call to disable the UNLOCK of a WebDAV resource, 
that work while saving a file.
-// If the method is called from another process (e.g. not when saving a file),
-// that disabling needs tweaking
 bool SfxObjectShell::DisconnectStorage_Impl( SfxMedium& rSrcMedium, SfxMedium& 
rTargetMedium )
 {
 // this method disconnects the storage from source medium, and attaches it 
to the backup created by the target medium
@@ -1742,12 +1743,7 @@ bool SfxObjectShell::DisconnectStorage_Impl( SfxMedium& 
rSrcMedium, SfxMedium& r
 rTargetMedium.ResetError();
 xOptStorage->writeAndAttachToStream( uno::Reference< 
io::XStream >() );
 rSrcMedium.CanDisposeStorage_Impl( false );
-// need to modify this for WebDAV if this method is called 
outside
-// the process of saving a file
-rSrcMedium.DisableUnlockWebDAV();
 rSrcMedium.Close();
-// see comment on the previous third row
-rSrcMedium.DisableUnlockWebDAV( false );
 
 // now try to create the backup
 rTargetMedium.GetBackup_Impl();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: th_TH/description.xml th_TH/README_th_TH.txt th_TH/th_TH.aff th_TH/th_TH.dic

[Libreoffice Gerrit user]

 th_TH/README_th_TH.txt |   11 
 th_TH/description.xml  |2 
 th_TH/th_TH.aff|   18 
 th_TH/th_TH.dic|90926 -
 4 files changed, 52072 insertions(+), 38885 deletions(-)

New commits:
commit 661e18650eb4f810b566fe4cbae64755a7ecf804
Author: wishawa 
AuthorDate: Mon Apr 29 17:38:28 2019 +0700
Commit: Andras Timar 
CommitDate: Tue Apr 30 09:35:45 2019 +0200

Update Thai dictionary: corrections, UTF-8, and over ten thousand more 
words.

Change-Id: Iea084036516e727af2f70729bd7484fb9cbdad90
Reviewed-on: https://gerrit.libreoffice.org/71523
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/th_TH/README_th_TH.txt b/th_TH/README_th_TH.txt
index cb95054..d84eb04 100644
--- a/th_TH/README_th_TH.txt
+++ b/th_TH/README_th_TH.txt
@@ -1,17 +1,12 @@
-name   :  th_TH 0.2 version of the thai dictionary
-date   :  2005.05.30
+name   :  th_TH version of the thai dictionary
+date   :  2019.04.11
 License:  LGPL
-Copyright 2005 by NECTEC, Thailand
 
 This dictionary, Thai wordlist are compound from 
  - LEXiTRON dictionary (http://lexitron.nectec.or.th/) Online English-Thai, 
Thai-English Dictionary by NECTEC.
  - Unknown Thai word from NECTEC researched.
+ - Words from libthai data
 
-It use for Pspell, Aspell and Myspell.
 
-Thanks to everybody for their wonderful work.
-
-Sila Chunwijitra 
-Maintainer
 
 
diff --git a/th_TH/description.xml b/th_TH/description.xml
index 13cd591..b3a5f73 100644
--- a/th_TH/description.xml
+++ b/th_TH/description.xml
@@ -1,6 +1,6 @@
 
 http://openoffice.org/extensions/description/2006; 
xmlns:d="http://openoffice.org/extensions/description/2006;  
xmlns:xlink="http://www.w3.org/1999/xlink;>
-
+
 
 
 Thai spelling dictionary
diff --git a/th_TH/th_TH.aff b/th_TH/th_TH.aff
index ad92d0b..5d7485e 100644
--- a/th_TH/th_TH.aff
+++ b/th_TH/th_TH.aff
@@ -1,7 +1,13 @@
-SET TIS620-2533
+SET UTF-8
 
-REP 4
-REP �� �
-REP � ��
-REP � �
-REP � �
+REP 10
+REP ทร ซ
+REP ซ ทร
+REP ส ซ
+REP ซ ส
+REP รร ะ
+REP ะ รร
+REP ั รร
+REP รร ั
+REP ฎ ฏ
+REP ฏ ฎ
diff --git a/th_TH/th_TH.dic b/th_TH/th_TH.dic
index 3fafbb6..4d7fdfd 100644
--- a/th_TH/th_TH.dic
+++ b/th_TH/th_TH.dic
@@ -1,38870 +1,52056 @@
-38869
-�.
-��
-��
-��.
-��
-���ʹ
-���.
-���.
-��ظ�ѳ��
-��
-�.�.
-���.
-��
-��
-��
-��
-�
-�¹
-���ѡ�
-���ҡ
-
-
-
-�
-
-�
-��˭�
-���ҧ
-��
-з�ǧ
-��ࡳ��
-ͺѧ�Ѻ
-Ҩ�
-ǧ
-���ҵ�
-���ѵ�
-���ѵ��˻�ЪҪҵ�
-���ú��
-���ú��
-���ط��Թ��
-��º
-Ÿ���
-��
-�µ��ǧ
-�¾ҳԪ��
-
-���ҧ�
-���ç�ҹ
-���٧�ش
-���ҭ�
-��
-觡���
-¡���֡
-��Թ
-��Թ�ҹ
-��
-��
-�
-˧
-
-���ѹ
-�
-��
-���Ҥ�
-�
-���ʹ
-��ѧ��
-���
-
-�.�.
-���ǷԵ�
-���Ƿ�
-�
-��ѭ�ص�
-��ѭ��
-��ѭ�س
-
-��
-��ԡ�
-��ԡ��ѭ��
-���
-آ
-���.
-���.
-���.
-���.
-��.
-��
-��
-���
-�鹡�
-�鹡�ͧ
-�鹡�д�
-�鹡د�
-���.
-�鹢�
-�鹤���
-�鹵��Թ
-�鹶ا
-�鹺��
-�鹻ʹ
-��
-�ҧ
-�
-���.
-���ɰ�
-��
-���.
-���
-���
-���ҹ
-���.
-���
-�ҴԹ��
-
-���.
-���.
-���.
-���.
-���.
-���.
-�.�.�.
-���.
-�.�.
-�.�.�.
-���.
-�
-���.
-���.
-���.
-��.
-�.�.
-���
-��
-���
-���ŧ
-���˹��
-���˹�ҡ
-��
-���ѧ
-��
-�.�.
-�á�
-�á�Ҥ�
-�ç
-�ç�ѧ
-��
-���
-�ó��
-�ó�
-�óը���
-�óշ��
-�óվԾҷ
-�óվ
-��
-�ó�¡Ԩ
-�ó���觴�ǹ
-�ó��֡��
-�ô
-�ô���жѹ
-�ô��ѹ
-�ô��
-�ô��ʿ��ԡ
-�ô�й��
-�ô�
-�ù
-�ú��
-�û.��ҧ
-���
-��
-�â��觷ҧ��
-�ä�ҵ�ҧ�
-��
-�èѴ�ҧҹ
-�úԹ�ҳԪ��
-�û���ͧ
-�û�Сѹ���
-�üѧ���ͧ
-�ý֡�Ѵ���
-�þѲ�Ҫ
-��ᾷ��
-ʹ�
-���֡�ҹ͡�ç���¹
-Ǻž��
-Ǻä�Դ���
-оĵ�
-�ҷ��
-Ż�зҹ
-�Ǩ�ѭ���ˡó�
-��Ǩ
-�Ѿ���Թ�ҧ�ѭ��
-�Ѿ�ҡøó�
-Һ
-���¹��ä��
-��
-ҧ��ǧ
-��Թ
-���ѡ��
-
-�Сѹ���
-ѧ�Ѻ���
-ѭ�ա�ҧ
-�Ъ�ʧ��
-�Ъ�ѹ��
-
-���ѵ��
-�
-�ɳ��Ţ
-�и٭
-
-���Ҫ�ѧ
-��֡��
-Ѳ�ҷ��Թ
-Ѳ�ҽ�ç�ҹ
-Ѳ��ѧ�ҹ
-Ըա�÷ٵ
-��û
-¸Ҹԡ��
-Ҫ�ѳ��
-Ҫͧ��ѡ��
-ç�ҹ�ص��ˡ���
-Ԫҡ��
-Ԫҡ���ɵ�
-Էʵᾷ��
-Էʵ���ԡ��
-ˡ��
-�Żҡ�
-�šҡ�
-��ɰ�Ԩ��þҳԪ��
-��ɵ�
-͡
-���س�ҾǴ
-���ˡó�
-���ص��ˡ���
-���ʹ���ѭС�
-���
-�þ���Ե
-�þҡ�
-��ʴԡФ�ͧ�ç�ҹ
-��ѭ�֡��
-�ù���
-آ�Ҿ�Ե
-���
-�ǧ
-���ͧ�ҧ�
-���͹
-���ԡừԿԡ��
-Ҫ���֡��
-���¹
-صعԷ��
-���µ��ѹ�͡
-�� ���ѹ�͡��ҧ Ϳ�ԡ�
-�
-�§
-���⪡
-��ó
-��óԡ���
-��õ�
-��õء�á
-��õ��Ҩ�
-
-��
-���
-��á
-��õѴ�Թ
-��ü��Ѵ���
-���Գ�
-���
-�ҹ
-���ʹͧ
-�ѹ���
-�Ը�
-�Ҩ�
-�Ը�
-�Ըա�ü�Ե
-�Ժҡ
-���
-�Է���
-�Է��
-Ҫվ
-Ҹԡ��
-��Ǵ
-��Ǵ
-��Ǵ���
-�
-
-�ԧ
-���
-���.
-��͡
-��͡�á
-��ͧ
-��ʹ
-���͹
-��ͺ
-��ͺ�ú
-��ͺ�Դ

LibreOffice ESC call, Thur - 16:00 central European (local) time

[Michael Meeks]

Hi everyone,

Prototype agenda below, bug metrics also at the link below;
extra items appreciated as last-week:

https://demo.collaboracloudsuite.com/tdf/

For now we continue using the public jitsi server:

https://meet.jit.si/tdfesc

ATB,

Michael.

* Completed Action Items:

* Pending Action Items:
+ run the certification script (Kendy)

* Release Engineering update (Christian)
+ 6.2.4 rc1 – next week starting April 29th
+ 6.1.6 rc2 - status
+ 6.3 alpha1: early May, week 19
+ Remotes
+ Android viewer
+ Online

* Documentation (Olivier)

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
252(252) (topicUI) bugs open, 209(209) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
 added 11(0) 21(1) 35(1)   80(2)  
 commented 75(4)216(-1)   489(-4)1397(7)  
   removed  2(2)  6(1) 14(1)   24(2)  
  resolved  2(-1)11(0) 46(-4) 131(-1) 
+ top 10 contributors:
  Tietze, Heiko made 93 changes in 1 month, and 577 changes in 1 year
  Roman Kuznetsov made 64 changes in 1 month, and 191 changes in 1 year
  Kainz, Andreas made 62 changes in 1 month, and 216 changes in 1 year
  Foote, V Stuart made 48 changes in 1 month, and 211 changes in 1 year
  Xisco Faulí made 30 changes in 1 month, and 251 changes in 1 year
  Cor Nouws made 29 changes in 1 month, and 125 changes in 1 year
  Thomas Lendo made 16 changes in 1 month, and 218 changes in 1 year
  Brinzing, Oliver made 15 changes in 1 month, and 29 changes in 1 year
  Rasmus Jonsson made 8 changes in 1 month, and 10 changes in 1 year
* Crash Testing (Caolan)
+ Google / ossfuzz:
  + ?? 12 (+2,-0) issues
+ Crash testing:
  + 10(+4) import failure, 10(-12) export failures
+ CNA bits – got 1st batch of CVE numbers.
  + CVE-2019-9847 assigned
+ waiting
  + ForcePoint ?
  + coverity scan – until new version that supports c++17(?)

* Crash Reporting (Xisco)
  + http://crashreport.libreoffice.org/stats/version/6.1.4.2
+ 878 (-112)
  + http://crashreport.libreoffice.org/stats/version/6.1.5.2
+ 1103 (-29)
  + http://crashreport.libreoffice.org/stats/version/6.2.2.2
+ 2013 (-454)
  + http://crashreport.libreoffice.org/stats/version/6.2.3.2
+ 869 (-)
  + pinged Markus for advice on fixing symbol issues for 6.2.3.2
 + problems have come back for this version.

* Hackfests & Events (Sophie)
   + this year hackfests coming up:
+ Paris in Summer (Sophie)
  + first week of July Fri/Sat 5th / 6th
+ near Gare de Nord, La Mouette working on communication
  + designing a flier – avoids stomping on exams at end of June
  + https://wiki.documentfoundation.org/Hackfest/Paris2019 
  + hope to have a Hackfest NG setup again – mentees, please speak up!
  + people are adding themselves to the wiki already.
+ tentative Dresden: late autumn (past mid-October, for having students)
  + Brussels Hackathon (Italo)
  + pending October hackfest – needs confirmation
  + conflicts with Dresden – need a decision in May or so.
   + hope to have one each quarter.

* GSOC 2019 (Thorsten/Xisco/Moggi/Heiko)
   + Slot selection
   + Timeline:
 + May 1, 2019: Organizations to finish project selection
 + May 6, 2019: Student projects announced
   + got 6 slots.
 + have 5 clearly winning slots
 + need to grab the students before others.
AI:+ accept 5 slots, and Kendy to reach out.

* C++ lectures (Xisco)
+ Linked Lists / Stack Classes; PQs and Heaps
+ NEXT SESSION: April, 25, TODAY!
   + Izabela taking care of organization from now on.

* mentoring/easyhack update
  committer...   1 week  1 month 3 months12 months   
  open  123(84) 163(64)  164(61) 175(62) 
   reviews 1580(540)   4918(203)   13260(85)   48345(936)
merged  372(169)   1170(31) 3620(56)   14707(109)
 abandoned   15(7)   44(-39) 181(1)  807(-2) 
   own commits  282(89) 964(15) 3191(50)   14327(-17)
review commits   90(19) 352(42)  894(25)3835(7)  
contributor...   1 week1 month3 months   12 months   
  open 29(3)  64(6)  66(8)   67(8)   
   reviews 44(-1)264(-47)   530(-10)   5106(-548)
merged 40(-15)   238(15)468(14)1760(8)   
 abandoned  5(-1) 45(-2) 99(-1) 310(-7)  
   own commits 50(-6)246(23)511(16)1825(20)  
review commits  0(0)   0(0)   0(0)0(0)   
+ easyHack statistics:
   needsDevEval 94(94)   

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 5 commits - chart2/source desktop/source filter/source include/LibreOfficeKit offapi/com sd/qa svx/source sw/inc sw/source

[Marco Cecchetti (via logerrit)]

 chart2/source/controller/inc/ChartController.hxx   |7 
 chart2/source/controller/inc/SelectionHelper.hxx   |6 
 chart2/source/controller/main/ChartController.cxx  |   22 +
 chart2/source/controller/main/ChartController_Position.cxx |   96 +++--
 chart2/source/controller/main/ChartController_Tools.cxx|   37 ++
 chart2/source/controller/main/ChartController_Window.cxx   |   11 
 chart2/source/controller/main/SelectionHelper.cxx  |6 
 chart2/source/inc/ObjectIdentifier.hxx |4 
 chart2/source/tools/ObjectIdentifier.cxx   |6 
 desktop/source/lib/init.cxx|   47 ++
 filter/source/svg/svgexport.cxx|2 
 include/LibreOfficeKit/LibreOfficeKitEnums.h   |   37 +-
 offapi/com/sun/star/text/TextGraphicObject.idl |3 
 sd/qa/unit/tiledrendering/tiledrendering.cxx   |   36 +-
 svx/source/svdraw/svdmrkv.cxx  |  220 -
 sw/inc/cmdid.h |2 
 sw/inc/unoprnms.hxx|1 
 sw/source/core/draw/dflyobj.cxx|   13 
 sw/source/core/inc/dflyobj.hxx |1 
 sw/source/core/unocore/unoframe.cxx|   31 +
 sw/source/core/unocore/unomap1.cxx |1 
 21 files changed, 511 insertions(+), 78 deletions(-)

New commits:
commit 7e2089e4fd30b70cd341dd02b0c8673434831386
Author: Marco Cecchetti 
AuthorDate: Tue Mar 26 15:11:33 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Tue Apr 30 12:06:31 2019 +0200

lok: update graphic selection callback description

Change-Id: I1ae073cc8e307b5c42aed9b17d405ef36ce4dc43

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 9639aaf9348e..fe252ca9bdbc 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -161,11 +161,40 @@ typedef enum
  */
 LOK_CALLBACK_CURSOR_VISIBLE = 5,
 /**
- * The size and/or the position of the graphic selection changed and
- * the rotation angle of the embedded graphic object
+ * The size and/or the position of the graphic selection changed,
+ * the rotation angle of the embedded graphic object, and a property list
+ * which can be used for informing the client about severl properties.
  *
- * Format is "x, y, width, height, angle", where angle is in 100th
- * of degree.
+ * Format is "x, y, width, height, angle, { list of properties }",
+ * where angle is in 100th of degree, and the property list is optional.
+ *
+ * The "{ list of properties }" part is in JSON format.
+ * Follow some examples of the property list part:
+ *
+ * 1) when the selected object is an image inserted in Writer:
+ *
+ *  { "isWriterGraphic": true }
+ *
+ * 2) when the selected object is a chart legend:
+ *
+ *  { "isDraggable": true, "isResizable": true, "isRotatable": false }
+ *
+ * 3) when the selected object is a pie segment in a chart:
+ *
+ *  {
+ *  "isDraggable": true,
+ *  "isResizable": false,
+ *  "isRotatable": false,
+ *  "dragInfo": {
+ *  "dragMethod": "PieSegmentDragging",
+ *  "initialOffset": 50,
+ *  "dragDirection": [x, y],
+ *  "svg": "
AuthorDate: Tue Mar 26 13:17:08 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Tue Apr 30 12:06:15 2019 +0200

lok: chart: constrained dragging of pie segments

The extra information for the graphic selection is now formatted
according to JSON syntax so that is easier to parse.

Information for allowing the client to performa constrained dragging
of a pie segment is appended when needed to the graphic selection
message.

A polygon approximation of the pie segment in svg format is attached
too to the graphic selection message.

Core now is able to handle a specific msg from the client with data
about the new pie segment offset computed by the client on drag end.
This information is dispatched by the chart controller to a specific
method: executeDispatch_LOKPieSegmentDragging.

Change-Id: I42e7742508fa3a453383bf7b95e47df169f24834

diff --git a/chart2/source/controller/inc/ChartController.hxx 
b/chart2/source/controller/inc/ChartController.hxx
index c2b3756601a6..3fdb357dc4d9 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -493,6 +493,7 @@ private:
 void executeDispatch_ToggleGridVertical();
 
 void executeDispatch_LOKSetTextSelection(int nType, int nX, int nY);
+void executeDispatch_LOKPieSegmentDragging(int nOffset);
 
  

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 2 commits - include/sot sot/source svtools/source vcl/osx

[Tomaž Vajngerl (via logerrit)]

 include/sot/formats.hxx  |3 ++-
 sot/source/base/exchange.cxx |3 ++-
 sot/source/base/formats.cxx  |   19 +++
 svtools/source/misc/transfer.cxx |   14 ++
 vcl/osx/DataFlavorMapping.cxx|1 +
 vcl/osx/salframe.cxx |2 ++
 vcl/osx/salnativewidgets.cxx |   17 +
 7 files changed, 57 insertions(+), 2 deletions(-)

New commits:
commit 8ed628cf8b7c6f1bc6dae9eb94c9b702aa93c21b
Author: Tomaž Vajngerl 
AuthorDate: Fri Apr 26 20:17:00 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Apr 30 21:29:24 2019 +0900

tdf#118977 support PDF documents as a clipboard format

On macOS it is possible to copy from a PDF a subset of a document,
which will be transported as a new PDF document containing the
subset.
LibreOffice didn't support PDF as a valid clipboard format and
previously it also didn't support showing PDFs inside the document,
so in such cases it copy-pasted a low resolution bitmap. The result
wasn't good.

As we are now able to display PDF documents as Graphic in LO, we
can also support this use-case. This adds support for the PDF
documents as a clipboard format in general and to the macOS
backend. This commit only adds support for Writer.

Reviewed-on: https://gerrit.libreoffice.org/71364
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 615202cab983f1f13407f6515aeb047e4e09f6ed)

Change-Id: Ib982b55391b390ae06974b4ad836e376dd722a4c

diff --git a/include/sot/formats.hxx b/include/sot/formats.hxx
index 4e36686203a8..a096b904149d 100644
--- a/include/sot/formats.hxx
+++ b/include/sot/formats.hxx
@@ -174,8 +174,9 @@ enum class SotClipboardFormatId : sal_uLong
 JPEG   = 144,
 RICHTEXT   = 145,
 STRING_TSVC= 146,
+PDF= 147,
 // the point at which we start allocating "runtime" format IDs
-USER_END  = STRING_TSVC
+USER_END  = PDF
 };
 
 /** Make it easier to iterate over format IDs */
diff --git a/sot/source/base/exchange.cxx b/sot/source/base/exchange.cxx
index 8dbc5bfd4686..124fd6cf780a 100644
--- a/sot/source/base/exchange.cxx
+++ b/sot/source/base/exchange.cxx
@@ -204,7 +204,8 @@ namespace
 /*143 SotClipboardFormatId::MATHML*/   { "application/mathml+xml", 
"MathML", &::cppu::UnoType>::get() },
 /*144 SotClipboardFormatId::JPEG*/ { "image/jpeg", "JPEG Bitmap", 
::UnoType>::get() },
 /*145 SotClipboardFormatId::RICHTEXT*/ { "text/richtext", 
"Richtext Format", ::UnoType>::get() },
-/*146 SotClipboardFormatId::STRING_TSVC*/{ 
"application/x-libreoffice-tsvc", "Text TSV-Calc", 
::UnoType::get() }
+/*146 SotClipboardFormatId::STRING_TSVC*/{ 
"application/x-libreoffice-tsvc", "Text TSV-Calc", 
::UnoType::get() },
+/*147 SotClipboardFormatId::PDF*/{ "application/pdf", 
"PDF Document", ::UnoType>::get() },
 };
 return [0];
 }
diff --git a/sot/source/base/formats.cxx b/sot/source/base/formats.cxx
index 522063972782..645152083a86 100644
--- a/sot/source/base/formats.cxx
+++ b/sot/source/base/formats.cxx
@@ -18,6 +18,7 @@
  */
 
 #include 
+#include 
 
 #include 
 #include 
@@ -347,6 +348,9 @@ SotAction_Impl const aEXCHG_DEST_DOC_GRAPHOBJ_Def[] =
 {
 { SotClipboardFormatId::GDIMETAFILE, EXCHG_IN_ACTION_COPY },
 { SotClipboardFormatId::DRAWING, EXCHG_IN_ACTION_COPY },
+#if HAVE_FEATURE_PDFIUM
+{ SotClipboardFormatId::PDF, EXCHG_IN_ACTION_COPY },
+#endif
 { SotClipboardFormatId::PNG, EXCHG_IN_ACTION_COPY },
 { SotClipboardFormatId::JPEG, EXCHG_IN_ACTION_COPY },
 { SotClipboardFormatId::BITMAP, EXCHG_IN_ACTION_COPY },
@@ -367,6 +371,9 @@ SotAction_Impl const aEXCHG_DEST_DOC_GRAPHOBJ_Move[] =
 { SotClipboardFormatId::DRAWING, EXCHG_OUT_ACTION_REPLACE_DRAWOBJ, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
 { SotClipboardFormatId::SVXB, EXCHG_OUT_ACTION_REPLACE_SVXB, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
 { SotClipboardFormatId::GDIMETAFILE, EXCHG_OUT_ACTION_REPLACE_GDIMETAFILE, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
+#if HAVE_FEATURE_PDFIUM
+{ SotClipboardFormatId::PDF, EXCHG_OUT_ACTION_INSERT_GRAPH, 
SotExchangeActionFlags::InsertImageMap  | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
+#endif
 { SotClipboardFormatId::PNG, EXCHG_OUT_ACTION_REPLACE_BITMAP, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
 { SotClipboardFormatId::JPEG, EXCHG_OUT_ACTION_REPLACE_BITMAP, 
SotExchangeActionFlags::InsertImageMap | 

[Libreoffice-commits] cppunit.git: examples/cppunittest

[Libreoffice Gerrit user]

 examples/cppunittest/OrthodoxTest.h |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 78e64f0edb4f3271a6ddbcdf9cba05138597bfca
Author: Martin Liška 
AuthorDate: Tue Apr 30 10:44:44 2019 +0200
Commit: Tomáš Chvátal 
CommitDate: Tue Apr 30 13:39:18 2019 +0200

Fix build with gcc9.1

Change-Id: I8a0d7a0b51b5c537dbcfa8fdd34e816605b1f32e
Reviewed-on: https://gerrit.libreoffice.org/71573
Reviewed-by: Tomáš Chvátal 
Tested-by: Tomáš Chvátal 

diff --git a/examples/cppunittest/OrthodoxTest.h 
b/examples/cppunittest/OrthodoxTest.h
index 8fc2a08..a2bc678 100644
--- a/examples/cppunittest/OrthodoxTest.h
+++ b/examples/cppunittest/OrthodoxTest.h
@@ -38,6 +38,8 @@ private:
   public:
 Value( int value =0 ) : m_value( value ) {}
 
+Value( const Value & ) = default;
+
 Value& operator= ( const Value& v )
 {
   m_value = v.m_value;
@@ -143,6 +145,8 @@ private:
 {
   return ValueBadCall( -1 - m_value );
 }
+
+ValueBadCall  =( const ValueBadCall & ) = default;
   };
 
 
@@ -161,6 +165,8 @@ private:
   ++m_value;
   return *this;
 }
+
+ValueBadAssignment( const ValueBadAssignment & ) = default;
   };
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Miklos Vajna (via logerrit)]

 svx/source/svdraw/svdomedia.cxx |8 
 1 file changed, 8 deletions(-)

New commits:
commit a1a16b22629d7952ef3aaefc76f080f7fdba7296
Author: Miklos Vajna 
AuthorDate: Tue Apr 30 13:52:00 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 14:59:35 2019 +0200

svx: remove nested redundant #ifs

Change-Id: I325fbf7573903a1cb99ea1f1c81d6b5a482efe09
Reviewed-on: https://gerrit.libreoffice.org/71578
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/svx/source/svdraw/svdomedia.cxx b/svx/source/svdraw/svdomedia.cxx
index 9951417613d5..5a355dd8cafd 100644
--- a/svx/source/svdraw/svdomedia.cxx
+++ b/svx/source/svdraw/svdomedia.cxx
@@ -356,16 +356,12 @@ void SdrMediaObj::mediaPropertiesChanged( const 
::avmedia::MediaItem& rNewProper
 {
 m_xImpl->m_pTempFile.reset(
 new ::avmedia::MediaTempFile(tempFileURL));
-#if HAVE_FEATURE_AVMEDIA
 m_xImpl->m_MediaProperties.setURL(url, tempFileURL, "");
-#endif
 }
 else // this case is for Clone via operator=
 {
 m_xImpl->m_pTempFile.reset();
-#if HAVE_FEATURE_AVMEDIA
 m_xImpl->m_MediaProperties.setURL("", "", "");
-#endif
 // UGLY: oox import also gets here, because unlike ODF
 // getDocumentStorage() is not the imported file...
 m_xImpl->m_LastFailedPkgURL = url;
@@ -373,18 +369,14 @@ void SdrMediaObj::mediaPropertiesChanged( const 
::avmedia::MediaItem& rNewProper
 }
 else
 {
-#if HAVE_FEATURE_AVMEDIA
 m_xImpl->m_MediaProperties.setURL(url,
 rNewProperties.getTempURL(), "");
-#endif
 }
 }
 else
 {
 m_xImpl->m_pTempFile.reset();
-#if HAVE_FEATURE_AVMEDIA
 m_xImpl->m_MediaProperties.setURL(url, "", 
rNewProperties.getReferer());
-#endif
 }
 bBroadcastChanged = true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/qa sd/source

[Mark Hung (via logerrit)]

 sd/qa/unit/export-tests-ooxml2.cxx|   15 ---
 sd/source/filter/eppt/pptx-animations.cxx |   39 +++---
 sd/source/filter/eppt/pptx-epptooxml.cxx  |5 ++-
 3 files changed, 50 insertions(+), 9 deletions(-)

New commits:
commit b593634d3cfbb2fc8522d99ce1c3f2a11445ea59
Author: Mark Hung 
AuthorDate: Sat Apr 27 19:02:25 2019 +0800
Commit: Mark Hung 
CommitDate: Tue Apr 30 15:03:19 2019 +0200

tdf#124230 pptx: make exported animation sound work.

1. Fix target path for the embedded media. Move the media
file to /ppt/media ( was /media ) and use the relative path
../media for the target path when adding the relation. This
is necessary for MSO to play the sound.

2. Write timenode id for the start or end conditions if the
animation node for the begin event or the end event is
available. Events like BEGIN or END has to refer a timenode.
Without specifying referred timenode in start and end
condition, Impress will not activate the audio node after
importing the document.

Change-Id: I6027be2e836e2f86061e401c8af806b2b1993a49
Reviewed-on: https://gerrit.libreoffice.org/71427
Tested-by: Jenkins
Reviewed-by: Mark Hung 

diff --git a/sd/qa/unit/export-tests-ooxml2.cxx 
b/sd/qa/unit/export-tests-ooxml2.cxx
index 7c27e0a315cc..66c6154f1da2 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -2087,31 +2087,38 @@ void SdOOXMLExportTest2::testTdf44223()
 = 
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/tdf44223.pptx"), 
PPTX);
 xDocShRef = saveAndReload(xDocShRef.get(), PPTX, );
 
-std::shared_ptr const pStream1(parseExportStream(tempFile, 
"media/audio1.wav"));
+std::shared_ptr const pStream1(parseExportStream(tempFile, 
"ppt/media/audio1.wav"));
 CPPUNIT_ASSERT_EQUAL(sal_uInt64(11140), pStream1->remainingSize());
 
-std::shared_ptr const pStream2(parseExportStream(tempFile, 
"media/audio2.wav"));
+std::shared_ptr const pStream2(parseExportStream(tempFile, 
"ppt/media/audio2.wav"));
 CPPUNIT_ASSERT_EQUAL(sal_uInt64(28074), pStream2->remainingSize());
 
 xmlDocPtr pXmlContentType = parseExport(tempFile, "[Content_Types].xml");
 assertXPath(pXmlContentType,
-
"/ContentType:Types/ContentType:Override[@PartName='/media/audio1.wav']",
+
"/ContentType:Types/ContentType:Override[@PartName='/ppt/media/audio1.wav']",
 "ContentType",
 "audio/x-wav");
 
 assertXPath(pXmlContentType,
-
"/ContentType:Types/ContentType:Override[@PartName='/media/audio2.wav']",
+
"/ContentType:Types/ContentType:Override[@PartName='/ppt/media/audio2.wav']",
 "ContentType",
 "audio/x-wav");
 
 xmlDocPtr pDoc1 = parseExport(tempFile, "ppt/slides/slide1.xml");
 
+// Start condition: 0s after timenode id 5 begins.
 assertXPath(pDoc1 , "//p:audio/p:cMediaNode/p:cTn/p:stCondLst/p:cond", 
"evt", "begin");
 assertXPath(pDoc1 , "//p:audio/p:cMediaNode/p:cTn/p:stCondLst/p:cond", 
"delay", "0");
+assertXPath(pDoc1 , 
"//p:audio/p:cMediaNode/p:cTn/p:stCondLst/p:cond/p:tn", "val", "5");
 
 xmlDocPtr pDoc2 = parseExport(tempFile, "ppt/slides/slide2.xml");
 assertXPath(pDoc2 , "//p:transition/p:sndAc/p:stSnd/p:snd[@r:embed]", 2);
 
+xmlDocPtr pRels1 = parseExport(tempFile, 
"ppt/slides/_rels/slide1.xml.rels");
+assertXPath(pRels1, "//rels:Relationship[@Id='rId1']", "Type",
+
"http://schemas.openxmlformats.org/officeDocument/2006/relationships/audio;);
+assertXPath(pRels1, "//rels:Relationship[@Id='rId1']", "Target", 
"../media/audio1.wav");
+
 xDocShRef->DoClose();
 }
 
diff --git a/sd/source/filter/eppt/pptx-animations.cxx 
b/sd/source/filter/eppt/pptx-animations.cxx
index a8c062b5c7df..da5223c50ec7 100644
--- a/sd/source/filter/eppt/pptx-animations.cxx
+++ b/sd/source/filter/eppt/pptx-animations.cxx
@@ -59,6 +59,7 @@
 #include "pptexanimations.hxx"
 #include "pptx-animations.hxx"
 #include "../ppt/pptanimations.hxx"
+#include 
 
 using namespace ::com::sun::star::animations;
 using namespace ::com::sun::star::container;
@@ -569,6 +570,7 @@ struct Cond
 OString msDelay;
 const char* mpEvent;
 Reference mxShape;
+Reference mxNode;
 
 Cond(const Any& rAny, bool bIsMainSeqChild);
 
@@ -596,7 +598,8 @@ Cond::Cond(const Any& rAny, bool bIsMainSeqChild)
 else
 {
 mpEvent = convertEventTrigger(aEvent.Trigger);
-aEvent.Source >>= mxShape;
+if (!(aEvent.Source >>= mxShape))
+aEvent.Source >>= mxNode;
 
 if (aEvent.Offset >>= fDelay)
 bHasFDelay = true;
@@ -632,6 +635,11 @@ class PPTXAnimationExport
 const FSHelperPtr& mpFS;
 const NodeContext* mpContext;
 
+std::map, sal_Int32, 
::comphelper::OInterfaceCompare>
+maAnimationNodeIdMap;
+

[Libreoffice-commits] core.git: sw/qa sw/source

[Justin Luth (via logerrit)]

 sw/qa/extras/ww8export/data/tdf101826_xattrTextBoxFill.doc |binary
 sw/qa/extras/ww8export/ww8export3.cxx  |   10 
 sw/source/filter/ww8/ww8graf.cxx   |   27 -
 3 files changed, 35 insertions(+), 2 deletions(-)

New commits:
commit cc899c6967238877f0094bcf00627145e484ffec
Author: Justin Luth 
AuthorDate: Mon Jan 14 22:18:46 2019 +0300
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 15:13:42 2019 +0200

tdf#101826 ww8import: Fly - don't convert XATTR back and forth

In this case we are explicitly interested in textboxes,
but any fly that accepts XATTR will now use that and skip
the old RES_BACKGROUND.

In the case of textbox import, the properties were being
converted into RES_BACKGROUND and then back to XATTR again.
Just copy the XATTR properties to the new FlySet instead.

The ability to import XATTRs into a textbox was added to LO6.3
with commit 15819181772d95963d16c1c2eaa9e51af81f7f68

Change-Id: Ib65b3d9097d0a56dbe205b419d052af53d0132c8
Reviewed-on: https://gerrit.libreoffice.org/66331
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ww8export/data/tdf101826_xattrTextBoxFill.doc 
b/sw/qa/extras/ww8export/data/tdf101826_xattrTextBoxFill.doc
new file mode 100755
index ..206f4830958a
Binary files /dev/null and 
b/sw/qa/extras/ww8export/data/tdf101826_xattrTextBoxFill.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export3.cxx 
b/sw/qa/extras/ww8export/ww8export3.cxx
index 239ce2bcbf2e..339ebd17e440 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -179,6 +179,16 @@ DECLARE_WW8EXPORT_TEST(testTdf12_fillStyleNone, 
"tdf12_fillStyleNone.doc
 CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_SOLID, 
getProperty(xText, "FillStyle"));
 }
 
+DECLARE_WW8EXPORT_TEST(testTdf101826_xattrTextBoxFill, 
"tdf101826_xattrTextBoxFill.doc")
+{
+//Basic 1 Color Fill: gradient from yellow(00) to brown(767600) 
currently saves as mid-color
+CPPUNIT_ASSERT_MESSAGE("background color", Color(0xFF, 0xFF, 0x00) != 
getProperty(getShape(1), "BackColor"));
+//Basic 2 Color Fill: gradient from yellow(00) to green(00B050) 
currently saves as mid-color
+CPPUNIT_ASSERT_MESSAGE("background color", Color(0xFF, 0xFF, 0x00) != 
getProperty(getShape(4), "BackColor"));
+//Basic Picture Fill: Tux image
+CPPUNIT_ASSERT_EQUAL_MESSAGE("background image", 
drawing::FillStyle_BITMAP, getProperty(getShape(5), 
"FillStyle"));
+}
+
 DECLARE_WW8EXPORT_TEST(testTdf123433_fillStyleStop, 
"tdf123433_fillStyleStop.doc")
 {
 uno::Reference xText(getParagraph(12));
diff --git a/sw/source/filter/ww8/ww8graf.cxx b/sw/source/filter/ww8/ww8graf.cxx
index 49440291710a..551376439e05 100644
--- a/sw/source/filter/ww8/ww8graf.cxx
+++ b/sw/source/filter/ww8/ww8graf.cxx
@@ -1691,6 +1691,29 @@ void SwWW8ImplReader::MatchSdrItemsIntoFlySet( SdrObject 
const * pSdrObj,
 rFlySet.Put( *pPoolItem );
 }
 
+// take new XATTR items directly. Skip old RES_BACKGROUND if new FILLSTYLE 
taken.
+bool bSkipResBackground = false;
+SfxItemPool* pPool = rFlySet.GetPool();
+if ( pPool )
+{
+for ( sal_uInt16 i = XATTR_START; i < XATTR_END; ++i )
+{
+// Not all Fly types support XATTRs - skip unsupported attributes
+SfxItemPool* pAttrPool = pPool->GetMasterPool();
+while ( pAttrPool && !pAttrPool->IsInRange(i) )
+pAttrPool = pAttrPool->GetSecondaryPool();
+if ( !pAttrPool )
+continue;
+
+if ( SfxItemState::SET == rOldSet.GetItemState(i, false, 
) )
+{
+rFlySet.Put( *pPoolItem );
+if ( i == XATTR_FILLSTYLE )
+bSkipResBackground = true;
+}
+}
+}
+
 // now calculate the borders and build the box: The unit is needed for the
 // frame SIZE!
 SvxBoxItem aBox(sw::util::ItemGet(rFlySet, RES_BOX));
@@ -1817,7 +1840,7 @@ void SwWW8ImplReader::MatchSdrItemsIntoFlySet( SdrObject 
const * pSdrObj,
 
 // Separate transparency
 eState = rOldSet.GetItemState(XATTR_FILLTRANSPARENCE, true, );
-if (eState == SfxItemState::SET)
+if (!bSkipResBackground && eState == SfxItemState::SET)
 {
 sal_uInt16 nRes = WW8ITEMVALUE(rOldSet, XATTR_FILLTRANSPARENCE,
 XFillTransparenceItem);
@@ -1828,7 +1851,7 @@ void SwWW8ImplReader::MatchSdrItemsIntoFlySet( SdrObject 
const * pSdrObj,
 
 // Background: SvxBrushItem
 eState = rOldSet.GetItemState(XATTR_FILLSTYLE, true, );
-if (eState == SfxItemState::SET)
+if (!bSkipResBackground && eState == SfxItemState::SET)
 {
 const drawing::FillStyle eFill = static_cast(pItem)->GetValue();
 
___
Libreoffice-commits mailing list

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - include/sot sot/source vcl/osx vcl/source

[Tomaž Vajngerl (via logerrit)]

 include/sot/formats.hxx  |3 ++-
 sot/source/base/exchange.cxx |3 ++-
 sot/source/base/formats.cxx  |   19 +++
 vcl/osx/DataFlavorMapping.cxx|1 +
 vcl/source/treelist/transfer.cxx |   14 ++
 5 files changed, 38 insertions(+), 2 deletions(-)

New commits:
commit e20c57976583cb2721dd91949d8ff0e8db446351
Author: Tomaž Vajngerl 
AuthorDate: Fri Apr 26 20:17:00 2019 +0900
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 15:19:46 2019 +0200

tdf#118977 support PDF documents as a clipboard format

On macOS it is possible to copy from a PDF a subset of a document,
which will be transported as a new PDF document containing the
subset.
LibreOffice didn't support PDF as a valid clipboard format and
previously it also didn't support showing PDFs inside the document,
so in such cases it copy-pasted a low resolution bitmap. The result
wasn't good.

As we are now able to display PDF documents as Graphic in LO, we
can also support this use-case. This adds support for the PDF
documents as a clipboard format in general and to the macOS
backend. This commit only adds support for Writer.

Reviewed-on: https://gerrit.libreoffice.org/71364
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 615202cab983f1f13407f6515aeb047e4e09f6ed)

Change-Id: Ib982b55391b390ae06974b4ad836e376dd722a4c
Reviewed-on: https://gerrit.libreoffice.org/71575
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/sot/formats.hxx b/include/sot/formats.hxx
index 968af5232c79..202c03bbe280 100644
--- a/include/sot/formats.hxx
+++ b/include/sot/formats.hxx
@@ -174,8 +174,9 @@ enum class SotClipboardFormatId : sal_uInt32
 JPEG   = 144,
 RICHTEXT   = 145,
 STRING_TSVC= 146,
+PDF= 147,
 // the point at which we start allocating "runtime" format IDs
-USER_END  = STRING_TSVC
+USER_END  = PDF
 };
 
 /** Make it easier to iterate over format IDs */
diff --git a/sot/source/base/exchange.cxx b/sot/source/base/exchange.cxx
index cb9c502b0561..99f941e3321d 100644
--- a/sot/source/base/exchange.cxx
+++ b/sot/source/base/exchange.cxx
@@ -204,7 +204,8 @@ namespace
 /*143 SotClipboardFormatId::MATHML*/   { "application/mathml+xml", 
"MathML", &::cppu::UnoType>::get() },
 /*144 SotClipboardFormatId::JPEG*/ { "image/jpeg", "JPEG Bitmap", 
::UnoType>::get() },
 /*145 SotClipboardFormatId::RICHTEXT*/ { "text/richtext", 
"Richtext Format", ::UnoType>::get() },
-/*146 SotClipboardFormatId::STRING_TSVC*/{ 
"application/x-libreoffice-tsvc", "Text TSV-Calc", 
::UnoType::get() }
+/*146 SotClipboardFormatId::STRING_TSVC*/{ 
"application/x-libreoffice-tsvc", "Text TSV-Calc", 
::UnoType::get() },
+/*147 SotClipboardFormatId::PDF*/{ "application/pdf", 
"PDF Document", ::UnoType>::get() },
 };
 return [0];
 }
diff --git a/sot/source/base/formats.cxx b/sot/source/base/formats.cxx
index 9b7770f146ef..b3199f39142e 100644
--- a/sot/source/base/formats.cxx
+++ b/sot/source/base/formats.cxx
@@ -18,6 +18,7 @@
  */
 
 #include 
+#include 
 
 #include 
 #include 
@@ -335,6 +336,9 @@ SotAction_Impl const aEXCHG_DEST_DOC_GRAPHOBJ_Def[] =
 {
 { SotClipboardFormatId::GDIMETAFILE, EXCHG_IN_ACTION_COPY },
 { SotClipboardFormatId::DRAWING, EXCHG_IN_ACTION_COPY },
+#if HAVE_FEATURE_PDFIUM
+{ SotClipboardFormatId::PDF, EXCHG_IN_ACTION_COPY },
+#endif
 { SotClipboardFormatId::PNG, EXCHG_IN_ACTION_COPY },
 { SotClipboardFormatId::JPEG, EXCHG_IN_ACTION_COPY },
 { SotClipboardFormatId::BITMAP, EXCHG_IN_ACTION_COPY },
@@ -355,6 +359,9 @@ SotAction_Impl const aEXCHG_DEST_DOC_GRAPHOBJ_Move[] =
 { SotClipboardFormatId::DRAWING, EXCHG_OUT_ACTION_REPLACE_DRAWOBJ, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
 { SotClipboardFormatId::SVXB, EXCHG_OUT_ACTION_REPLACE_SVXB, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
 { SotClipboardFormatId::GDIMETAFILE, EXCHG_OUT_ACTION_REPLACE_GDIMETAFILE, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
+#if HAVE_FEATURE_PDFIUM
+{ SotClipboardFormatId::PDF, EXCHG_OUT_ACTION_INSERT_GRAPH, 
SotExchangeActionFlags::InsertImageMap  | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
+#endif
 { SotClipboardFormatId::PNG, EXCHG_OUT_ACTION_REPLACE_BITMAP, 
SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::KeepPosSize | 
SotExchangeActionFlags::InsertTargetUrl, 0 },
 { SotClipboardFormatId::JPEG, EXCHG_OUT_ACTION_REPLACE_BITMAP, 
SotExchangeActionFlags::InsertImageMap | 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/miscdlgs/acredlin.cxx |   45 +++--
 1 file changed, 28 insertions(+), 17 deletions(-)

New commits:
commit 80c1d52946d3d60721f7d76e537caa722a5ca5a6
Author: Caolán McNamara 
AuthorDate: Tue Apr 23 11:06:20 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 15:18:16 2019 +0200

multiple concatted AcceptChgDat stored in config

FillInfo is called more often than Initialize, so we've ended up
with multiple AcceptChgDat strings

Change-Id: I99e9398757d63e2c6315ec9c3101910d5978b13b
Reviewed-on: https://gerrit.libreoffice.org/71120
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sc/source/ui/miscdlgs/acredlin.cxx 
b/sc/source/ui/miscdlgs/acredlin.cxx
index b1294a0ddff6..3349eee8e910 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1714,34 +1714,43 @@ IMPL_LINK_NOARG(ScAcceptChgDlg, CommandHdl, 
SvSimpleTable*, void)
 }
 }
 
-void ScAcceptChgDlg::Initialize(SfxChildWinInfo *pInfo)
+namespace
 {
-OUString aStr;
-if(pInfo!=nullptr)
+//at one point we were writing multiple AcceptChgDat strings,
+//so strip all of them and keep the results of the last one
+OUString lcl_StripAcceptChgDat(OUString )
 {
-if ( !pInfo->aExtraString.isEmpty() )
+OUString aStr;
+while (true)
 {
-sal_Int32 nPos = pInfo->aExtraString.indexOf("AcceptChgDat:");
-
+sal_Int32 nPos = rExtraString.indexOf("AcceptChgDat:");
+if (nPos == -1)
+break;
 // Try to read the alignment string "ALIGN:(...)"; if it is missing
 // we have an old version
-if ( nPos != -1 )
+sal_Int32 n1 = rExtraString.indexOf('(', nPos);
+if ( n1 != -1 )
 {
-sal_Int32 n1 = pInfo->aExtraString.indexOf('(', nPos);
-if ( n1 != -1 )
+sal_Int32 n2 = rExtraString.indexOf(')', n1);
+if ( n2 != -1 )
 {
-sal_Int32 n2 = pInfo->aExtraString.indexOf(')', n1);
-if ( n2 != -1 )
-{
-// cut out alignment string
-aStr = pInfo->aExtraString.copy(nPos, n2 - nPos + 1);
-pInfo->aExtraString = 
pInfo->aExtraString.replaceAt(nPos, n2 - nPos + 1, "");
-aStr = aStr.copy( n1-nPos+1 );
-}
+// cut out alignment string
+aStr = rExtraString.copy(nPos, n2 - nPos + 1);
+rExtraString = rExtraString.replaceAt(nPos, n2 - nPos + 1, 
"");
+aStr = aStr.copy( n1-nPos+1 );
 }
 }
 }
+return aStr;
 }
+}
+
+void ScAcceptChgDlg::Initialize(SfxChildWinInfo *pInfo)
+{
+OUString aStr;
+if (pInfo && !pInfo->aExtraString.isEmpty())
+aStr = lcl_StripAcceptChgDat(pInfo->aExtraString);
+
 SfxModelessDialog::Initialize(pInfo);
 
 if ( !aStr.isEmpty())
@@ -1760,6 +1769,8 @@ void ScAcceptChgDlg::Initialize(SfxChildWinInfo *pInfo)
 void ScAcceptChgDlg::FillInfo(SfxChildWinInfo& rInfo) const
 {
 SfxModelessDialog::FillInfo(rInfo);
+//remove any old one before adding a new one
+lcl_StripAcceptChgDat(rInfo.aExtraString);
 rInfo.aExtraString += "AcceptChgDat:(";
 
 sal_uInt16  nCount=pTheView->TabCount();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: drawinglayer/source

[Luboš Luňák (via logerrit)]

 drawinglayer/source/tools/converters.cxx |   24 +---
 1 file changed, 21 insertions(+), 3 deletions(-)

New commits:
commit 37874c29b0d266b7a49978ce68a4909bc6e50fcd
Author: Luboš Luňák 
AuthorDate: Wed Apr 24 13:46:03 2019 +0200
Commit: Luboš Luňák 
CommitDate: Tue Apr 30 13:52:25 2019 +0200

make debug code work properly also on non-win32

Change-Id: I5ccf6b079ef8b6a341d06627e4b0abc9d90e0f8b
Reviewed-on: https://gerrit.libreoffice.org/71566
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/drawinglayer/source/tools/converters.cxx 
b/drawinglayer/source/tools/converters.cxx
index 3f601f84d47a..010f71810c30 100644
--- a/drawinglayer/source/tools/converters.cxx
+++ b/drawinglayer/source/tools/converters.cxx
@@ -100,7 +100,13 @@ namespace drawinglayer
 #ifdef DBG_UTIL
 if(bDoSaveForVisualControl)
 {
-SvFileStream aNew("c:\\test_content.png", 
StreamMode::WRITE|StreamMode::TRUNC);
+SvFileStream aNew(
+#ifdef _WIN32
+"c:\\test_content.png"
+#else
+"~/test_content.png"
+#endif
+, StreamMode::WRITE|StreamMode::TRUNC);
 BitmapEx aContentEx(aContent);
 vcl::PNGWriter aPNGWriter(aContentEx);
 aPNGWriter.Write(aNew);
@@ -131,7 +137,13 @@ namespace drawinglayer
 #ifdef DBG_UTIL
 if(bDoSaveForVisualControl)
 {
-SvFileStream aNew("c:\\test_alpha.png", 
StreamMode::WRITE|StreamMode::TRUNC);
+SvFileStream aNew(
+#ifdef _WIN32
+"c:\\test_alpha.png"
+#else
+"~/test_alpha.png"
+#endif
+, StreamMode::WRITE|StreamMode::TRUNC);
 BitmapEx aAlphaEx(aAlpha);
 vcl::PNGWriter aPNGWriter(aAlphaEx);
 aPNGWriter.Write(aNew);
@@ -143,7 +155,13 @@ namespace drawinglayer
 #ifdef DBG_UTIL
 if(bDoSaveForVisualControl)
 {
-SvFileStream aNew("c:\\test_combined.png", 
StreamMode::WRITE|StreamMode::TRUNC);
+SvFileStream aNew(
+#ifdef _WIN32
+"c:\\test_combined.png"
+#else
+"~/test_combined.png"
+#endif
+, StreamMode::WRITE|StreamMode::TRUNC);
 vcl::PNGWriter aPNGWriter(aRetval);
 aPNGWriter.Write(aNew);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/miscdlgs/simpref.cxx |4 
 sc/source/ui/view/tabview3.cxx|   24 +++-
 2 files changed, 27 insertions(+), 1 deletion(-)

New commits:
commit f2466b915cbf7bee03df16d0972f06155b7512de
Author: Caolán McNamara 
AuthorDate: Tue Apr 30 11:25:01 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Apr 30 13:52:44 2019 +0200

tdf#124975 changing the clipboard selection clears the widget selection

gtk listens to the selection so realizes that the GtkEntry selection
is not the desktop selection anymore and drops the visual selection.

But we're relying on the visual selection to know what part of
a multiselection we are modifying

Change-Id: I42d5718ba029b4f94c436cb755485d05511b5708
Reviewed-on: https://gerrit.libreoffice.org/71576
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/miscdlgs/simpref.cxx 
b/sc/source/ui/miscdlgs/simpref.cxx
index 0f39e4cc6073..c1d230314133 100644
--- a/sc/source/ui/miscdlgs/simpref.cxx
+++ b/sc/source/ui/miscdlgs/simpref.cxx
@@ -165,6 +165,8 @@ void ScSimpleRefDlg::RefInputDone( bool bForced)
 
 IMPL_LINK_NOARG(ScSimpleRefDlg, OkBtnHdl, weld::Button&, void)
 {
+if (IsClosing())
+return;
 bAutoReOpen = false;
 OUString aResult=m_xEdAssign->GetText();
 aCloseHdl.Call();
@@ -175,6 +177,8 @@ IMPL_LINK_NOARG(ScSimpleRefDlg, OkBtnHdl, weld::Button&, 
void)
 
 IMPL_LINK_NOARG(ScSimpleRefDlg, CancelBtnHdl, weld::Button&, void)
 {
+if (IsClosing())
+return;
 bAutoReOpen = false;
 OUString aResult=m_xEdAssign->GetText();
 aCloseHdl.Call(nullptr);
diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 0eebfb583d2f..bfdc208bf128 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -64,6 +64,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -436,6 +437,22 @@ void ScTabView::SetCursor( SCCOL nPosX, SCROW nPosY, bool 
bNew )
 }
 }
 
+static bool lcl_IsScSimpleRefDlgOpen(SfxViewFrame* pViewFrm)
+{
+if (pViewFrm->HasChildWindow(WID_SIMPLE_REF))
+{
+SfxChildWindow* pChild = pViewFrm->GetChildWindow(WID_SIMPLE_REF);
+if (pChild)
+{
+auto xDlgController = pChild->GetController();
+if (xDlgController && xDlgController->getDialog()->get_visible())
+return true;
+}
+}
+
+return false;
+}
+
 void ScTabView::CheckSelectionTransfer()
 {
 if ( aViewData.IsActive() ) // only for active view
@@ -451,7 +468,12 @@ void ScTabView::CheckSelectionTransfer()
 pOld->ForgetView();
 
 pScMod->SetSelectionTransfer( pNew.get() );
-pNew->CopyToSelection( GetActiveWin() );// may 
delete pOld
+
+// tdf#124975 changing the calc selection can trigger removal of 
the
+// selection of an open ScSimpleRefDlg dialog, so don't inform the
+// desktop clipboard of the changed selection if that dialog is 
open
+if 
(!lcl_IsScSimpleRefDlgOpen(aViewData.GetViewShell()->GetViewFrame()))
+pNew->CopyToSelection( GetActiveWin() );// 
may delete pOld
 
 // Log the selection change
 ScMarkData& rMark = aViewData.GetMarkData();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

tdf124710 convert Calc function IFS (and SWITCH) to jump function

[Winfried Donkers]

Hi Eike,

Some time ago (when I submitted a draft patch) you suggested an alternative, 
possible easier way, to convert IFS and SWITCH to jump functions.
The idea was not to extend the jump functionality, but to internally convert 
IFS and SWITCH to IF:
IFS( b1, r1, b2, r2 ) should become IF( b1, r1, IF( b2, r2 ) )
and
SWITCH( x, v1, r1, v2, r2 ) should become IF( x = v1, r1, IF( x=v2, r2 ) ).
For the IFS example you gave the RPN code : 'b1 ocIf r1 , b2 ocIf , r2 )' .

I have two questions about this:
-Shouldn't the RPN code be 'b1 ocIf r1 , b2 ocif r2 ) )'?
-Am I right in thinking that this construction means that all conditions (b1, 
b2, etc.) are evaluated upon placing them on the stack, or is each condition 
only evaluated when taken from the stack?

Winfried

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: tools/inc tools/IwyuFilter_tools.yaml tools/qa tools/source

[Gabor Kelemen (via logerrit)]

 tools/IwyuFilter_tools.yaml|   34 +
 tools/inc/poly.h   |6 ---
 tools/qa/cppunit/test_100mm2twips.cxx  |4 --
 tools/qa/cppunit/test_bigint.cxx   |3 -
 tools/qa/cppunit/test_color.cxx|2 -
 tools/qa/cppunit/test_fract.cxx|1 
 tools/qa/cppunit/test_fround.cxx   |1 
 tools/qa/cppunit/test_inetmime.cxx |2 -
 tools/qa/cppunit/test_minmax.cxx   |1 
 tools/qa/cppunit/test_pathutils.cxx|2 -
 tools/qa/cppunit/test_rectangle.cxx|2 -
 tools/qa/cppunit/test_stream.cxx   |1 
 tools/qa/cppunit/test_xmlwalker.cxx|5 ---
 tools/source/datetime/systemdatetime.cxx   |2 -
 tools/source/datetime/ttime.cxx|4 --
 tools/source/debug/debug.cxx   |   15 -
 tools/source/fsys/fileutil.cxx |2 -
 tools/source/fsys/urlobj.cxx   |2 -
 tools/source/generic/bigint.cxx|2 -
 tools/source/generic/config.cxx|5 ---
 tools/source/generic/fract.cxx |3 -
 tools/source/generic/line.cxx  |4 --
 tools/source/generic/point.cxx |2 -
 tools/source/generic/poly2.cxx |2 -
 tools/source/inet/inetmime.cxx |2 -
 tools/source/inet/inetmsg.cxx  |2 -
 tools/source/inet/inetstrm.cxx |1 
 tools/source/misc/extendapplicationenvironment.cxx |7 
 tools/source/stream/stream.cxx |1 
 tools/source/stream/strmunx.cxx|5 ---
 tools/source/zcodec/zcodec.cxx |1 
 31 files changed, 37 insertions(+), 89 deletions(-)

New commits:
commit 83abdf803a023067ebc207fd82dde987df233754
Author: Gabor Kelemen 
AuthorDate: Mon Apr 29 23:40:38 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 15:02:42 2019 +0200

tdf#42949 Fix IWYU warnings in tools/

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I47974f5c24819eb60e6724f42d51bb206dc26d21
Reviewed-on: https://gerrit.libreoffice.org/71557
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/tools/IwyuFilter_tools.yaml b/tools/IwyuFilter_tools.yaml
new file mode 100644
index ..c24beaef25d9
--- /dev/null
+++ b/tools/IwyuFilter_tools.yaml
@@ -0,0 +1,34 @@
+---
+assumeFilename: tools/source/generic/gen.cxx
+blacklist:
+tools/qa/cppunit/test_pathutils.cxx:
+# Needed for WIN32 specific unit test
+- cppunit/TestAssert.h
+- cppunit/plugin/TestPlugIn.h
+- tools/pathutils.hxx
+- cwchar
+tools/source/debug/debug.cxx:
+# Needed for linker visibility
+- tools/diagnose_ex.h
+tools/source/generic/poly.cxx:
+# OSL_BIGENDIAN is being checked
+- osl/endian.h
+tools/source/misc/extendapplicationenvironment.cxx:
+# Needed on MACOSX
+- config_folders.h
+# Needed for linker visibility
+- tools/extendapplicationenvironment.hxx
+tools/source/ref/ref.cxx:
+# Don't replace with impl. detail
+- tools/weakbase.hxx
+tools/source/stream/strmwnt.cxx:
+# WIN32-specific file
+- string.h
+- osl/thread.h
+- o3tl/char16_t2wchar_t.hxx
+tools/source/stream/strmunx.cxx:
+# Needed for OSL_DEBUG_LEVEL > 1
+- osl/thread.h
+tools/source/string/tenccvt.cxx:
+# Needed for linker visibility
+- tools/tenccvt.hxx
diff --git a/tools/inc/poly.h b/tools/inc/poly.h
index 2c84bf7459cf..17819ac93482 100644
--- a/tools/inc/poly.h
+++ b/tools/inc/poly.h
@@ -22,8 +22,6 @@
 #include 
 #include 
 
-class Point;
-
 class SAL_WARN_UNUSED ImplPolygon
 {
 public:
@@ -55,10 +53,6 @@ public:
 
 #define MAX_POLYGONSSAL_MAX_UINT16
 
-namespace tools {
-class Polygon;
-}
-
 struct ImplPolyPolygon
 {
 std::vector mvPolyAry;
diff --git a/tools/qa/cppunit/test_100mm2twips.cxx 
b/tools/qa/cppunit/test_100mm2twips.cxx
index 93eab264f8da..80ceda2ffb3f 100644
--- a/tools/qa/cppunit/test_100mm2twips.cxx
+++ b/tools/qa/cppunit/test_100mm2twips.cxx
@@ -18,16 +18,12 @@
  */
 
 #include 
-#include 
 
 #include 
 #include 
-#include 
 
 #include 
 
-#include 
-
 namespace tools
 {
 class cm2TwipsTest : public CppUnit::TestFixture
diff --git a/tools/qa/cppunit/test_bigint.cxx b/tools/qa/cppunit/test_bigint.cxx
index 9e02a609cce6..ef147961dbf4 100644
--- a/tools/qa/cppunit/test_bigint.cxx
+++ b/tools/qa/cppunit/test_bigint.cxx
@@ -17,12 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
 #include 
 #include 
 
-#include 
-
 #include 
 
 namespace tools
diff --git a/tools/qa/cppunit/test_color.cxx b/tools/qa/cppunit/test_color.cxx

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/baside2b.cxx |   19 ---
 1 file changed, 12 insertions(+), 7 deletions(-)

New commits:
commit 45d2f8a4bdd2c805b11ab374fb4946a2c079e7ee
Author: Caolán McNamara 
AuthorDate: Sun Apr 28 16:28:49 2019 +0100
Commit: Michael Stahl 
CommitDate: Tue Apr 30 15:06:49 2019 +0200

Resolves: tdf#124704 need to state the area the tooltip is for

to make it work under gtk3

Change-Id: I4c895181af233a16292ce16b194f0a60994446fb
Reviewed-on: https://gerrit.libreoffice.org/71479
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index 99208550315b..e307250ba663 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -337,7 +337,7 @@ void EditorWindow::RequestHelp( const HelpEvent& rHEvt )
 else if ( rHEvt.GetMode() & HelpEventMode::QUICK )
 {
 OUString aHelpText;
-Point aTopLeft;
+tools::Rectangle aHelpRect;
 if ( StarBASIC::IsRunning() )
 {
 Point aWindowPos = rHEvt.GetMousePosPixel();
@@ -371,15 +371,20 @@ void EditorWindow::RequestHelp( const HelpEvent& rHEvt )
 }
 if ( !aHelpText.isEmpty() )
 {
-aTopLeft = 
GetEditView()->GetTextEngine()->PaMtoEditCursor( aStartOfWord ).BottomLeft();
-aTopLeft = GetEditView()->GetWindowPos( aTopLeft );
-aTopLeft.AdjustX(5 );
-aTopLeft.AdjustY(5 );
-aTopLeft = OutputToScreenPixel( aTopLeft );
+tools::Rectangle 
aStartWordRect(GetEditView()->GetTextEngine()->PaMtoEditCursor(aStartOfWord));
+TextPaM aEndOfWord(aStartOfWord.GetPara(), 
aStartOfWord.GetIndex() + aWord.getLength());
+tools::Rectangle 
aEndWordRect(GetEditView()->GetTextEngine()->PaMtoEditCursor(aEndOfWord));
+aHelpRect = aStartWordRect.GetUnion(aEndWordRect);
+
+Point aTopLeft = 
GetEditView()->GetWindowPos(aHelpRect.TopLeft());
+aTopLeft = 
GetEditView()->GetWindow()->OutputToScreenPixel(aTopLeft);
+
+aHelpRect.setX(aTopLeft.X());
+aHelpRect.setY(aTopLeft.Y());
 }
 }
 }
-Help::ShowQuickHelp( this, tools::Rectangle( aTopLeft, Size( 1, 1 
) ), aHelpText, QuickHelpFlags::Top|QuickHelpFlags::Left);
+Help::ShowQuickHelp( this, aHelpRect, aHelpText, 
QuickHelpFlags::NONE);
 bDone = true;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Justin Luth (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak2.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |3 +
 writerfilter/source/dmapper/DomainMapper.cxx   |   16 
++
 3 files changed, 18 insertions(+), 1 deletion(-)

New commits:
commit f6f53f76e15f5eecc5b6ce56e471c53cebfea8ad
Author: Justin Luth 
AuthorDate: Wed Apr 24 22:20:51 2019 +0300
Commit: Miklos Vajna 
CommitDate: Tue Apr 30 15:16:19 2019 +0200

tdf#123636 writerfilter: handle deferred breaks on frames

...similar to handling breaks before shapes in lcl_startShape.

Three different examples found to create/split a paragraph.
Which one to use? (addDummy, m_bIsSplitPara, and
lcl_startCharacterGroup). SplitPara is not good because the
paragraph properties probably should not be copied to the
dummy paragraph (like numbering for example). Slightly
modified the lcl_startChar example to ensure that the dummy
paragraph doesn't steal a part of the properties, but is
only default properties plus page-break.

This doesn't export very well, so roundtripping is very poor.

Research Note: There exists a compat flag showBreaksInFrames
(Display Page/Column Breaks Present in Frames)
"This element specifies whether applications should
honor the presence of page and/or column breaks which are
present within the contents of paragraphs which have been
defined as frames using the framePr element."
--Currently, LO does nothing with this flag. Probably too
exotic and irrelevant (word 2003 era?).

No existing unit tests found that have isSet(pg_brk) frames.

Change-Id: I29f815355401c7af8b347a3ed9d0298bc9b27b93
Reviewed-on: https://gerrit.libreoffice.org/71255
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak2.docx 
b/sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak2.docx
index 30698c4675cf..a876bea84e02 100644
Binary files a/sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak2.docx 
and b/sw/qa/extras/ooxmlexport/data/tdf123636_newlinePageBreak2.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index 4448275021bf..dfde7c2f399a 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -97,7 +97,8 @@ DECLARE_OOXMLEXPORT_TEST(testTdf123636_newlinePageBreak2, 
"tdf123636_newlinePage
 {
 //WITHOUT SplitPgBreakAndParaMark: a following anchored shape should force 
a page break
 //CPPUNIT_ASSERT_EQUAL_MESSAGE( "Number of Paragraphs", 2, getParagraphs() 
);
-//CPPUNIT_ASSERT_EQUAL_MESSAGE( "Number of Pages", 2, getPages() );
+CPPUNIT_ASSERT_EQUAL(OUString(), getProperty(getParagraph(2, 
""), "NumberingStyleName"));
+CPPUNIT_ASSERT_EQUAL_MESSAGE( "Number of Pages", 2, getPages() );
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTdf123636_newlinePageBreak3, 
"tdf123636_newlinePageBreak3.docx")
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 1a9be316b85d..cc7b7c720e05 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1965,6 +1965,22 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 PropertyMapPtr pContext = 
m_pImpl->GetTopContextOfType(CONTEXT_PARAGRAPH);
 if( pContext.get() )
 {
+// If there is a deferred page break applied to this framed 
paragraph,
+// create a dummy paragraph without extra properties,
+// so that the anchored frame will be on the correct page (similar 
to shapes).
+if (pContext->isSet(PROP_BREAK_TYPE))
+{
+pContext->Erase(PROP_BREAK_TYPE);
+
+lcl_startParagraphGroup();
+m_pImpl->GetTopContext()->Insert(PROP_BREAK_TYPE, 
uno::makeAny(style::BreakType_PAGE_BEFORE));
+lcl_startCharacterGroup();
+sal_uInt8 const sBreak[] = { 0xd };
+lcl_text(sBreak, 1);
+lcl_endCharacterGroup();
+lcl_endParagraphGroup();
+}
+
 ParagraphPropertyMap* pParaContext = dynamic_cast< 
ParagraphPropertyMap* >( pContext.get() );
 if (pParaContext)
 pParaContext->SetFrameMode();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/bastyp/swcache.cxx |1 +
 sw/source/core/inc/swcache.hxx|9 +++--
 sw/source/core/text/txtcache.cxx  |   36 
 sw/source/core/view/viewsh.cxx|   10 --
 4 files changed, 44 insertions(+), 12 deletions(-)

New commits:
commit 3d37463eec0c891243a8971a34903b2da01c9e24
Author: Michael Stahl 
AuthorDate: Mon Apr 29 17:21:18 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 15:28:03 2019 +0200

tdf#122607 sw: fix preservation of text frame cache entries

SwSaveSetLRUOfst would leave only 50 cache entries available for the
CalcLayout() to use; apparently it's not enough for this document.

The difference between the 1st loading/layout and the 3rd loading/layout
of the document is that in many paragraphs the cache entry is missing,
because the entires of the previous loads were clogging up the cache
and were preserved here, and the cache only has 50 available entries;
if enough entries are available, everything is positioned properly.

The idea with the 100 entries per visible shell actually comes from the
CVS initial import, where there was a comment suggesting that; but the
corresponding parameter was actually unused and removed in
7c704c78d3c652504c064b4ac7af55a2c1ee49bb.

Ideally we'd have time to investigate why a missing cache entry causes
the wrong position...

Change-Id: I64a72a94361dbf5717bbc709fa3bc9abbe18a37c
Reviewed-on: https://gerrit.libreoffice.org/71542
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/bastyp/swcache.cxx 
b/sw/source/core/bastyp/swcache.cxx
index ff6d568b8e83..64eb233b6bf7 100644
--- a/sw/source/core/bastyp/swcache.cxx
+++ b/sw/source/core/bastyp/swcache.cxx
@@ -436,6 +436,7 @@ bool SwCache::Insert( SwCacheObj *pNew )
 
 void SwCache::SetLRUOfst( const sal_uInt16 nOfst )
 {
+assert(nOfst < m_nCurMax);
 if ( !m_pRealFirst || ((m_aCacheObjects.size() - m_aFreePositions.size()) 
< nOfst) )
 return;
 
diff --git a/sw/source/core/inc/swcache.hxx b/sw/source/core/inc/swcache.hxx
index 9a6563e256ba..00f33514ff39 100644
--- a/sw/source/core/inc/swcache.hxx
+++ b/sw/source/core/inc/swcache.hxx
@@ -117,15 +117,12 @@ public:
 sal_uInt16 size() { return m_aCacheObjects.size(); }
 };
 
-/// Safely manipulate the cache
+/// Try to prevent visible SwParaPortions from being deleted.
 class SwSaveSetLRUOfst
 {
-SwCache 
 public:
-SwSaveSetLRUOfst( SwCache , const sal_uInt16 nOfst )
-: rCache( rC )  { rCache.SetLRUOfst( nOfst );  }
-
-~SwSaveSetLRUOfst() { rCache.ResetLRUOfst(); }
+SwSaveSetLRUOfst();
+~SwSaveSetLRUOfst();
 };
 
 /**
diff --git a/sw/source/core/text/txtcache.cxx b/sw/source/core/text/txtcache.cxx
index b0f540a2a024..fcc8b434cdd8 100644
--- a/sw/source/core/text/txtcache.cxx
+++ b/sw/source/core/text/txtcache.cxx
@@ -21,6 +21,9 @@
 #include 
 #include "porlay.hxx"
 
+#include 
+#include 
+
 SwTextLine::SwTextLine( SwTextFrame const *pFrame, 
std::unique_ptr pNew ) :
 SwCacheObj( static_cast(pFrame) ),
 pLine( std::move(pNew) )
@@ -135,4 +138,37 @@ void SwTextFrame::SetPara( SwParaPortion *pNew, bool 
bDelete )
 }
 }
 
+/** Prevent the SwParaPortions of the *visible* paragraphs from being deleted;
+they would just be recreated on the next paint.
+
+Heuristic: 100 per view are visible
+
+If the cache is too small, enlarge it to ensure there are sufficient free
+entries for the layout so it doesn't have to throw away a node's
+SwParaPortion when it starts formatting the next node.
+*/
+SwSaveSetLRUOfst::SwSaveSetLRUOfst()
+{
+sal_uInt16 nVisibleShells(0);
+for (auto pView = SfxViewShell::GetFirst(true, checkSfxViewShell);
+ pView != nullptr;
+ pView = SfxViewShell::GetNext(*pView, true, 
checkSfxViewShell))
+{
+++nVisibleShells;
+}
+
+sal_uInt16 const nPreserved(100 * nVisibleShells);
+SwCache & rCache(*SwTextFrame::GetTextCache());
+if (rCache.GetCurMax() < nPreserved + 250)
+{
+rCache.IncreaseMax(nPreserved + 250 - rCache.GetCurMax());
+}
+rCache.SetLRUOfst(nPreserved);
+}
+
+SwSaveSetLRUOfst::~SwSaveSetLRUOfst()
+{
+SwTextFrame::GetTextCache()->ResetLRUOfst();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index f8a805dad4a9..ae1bc40512d0 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -712,9 +712,8 @@ void SwViewShell::LayoutIdle()
 #endif
 
 {
-//Prepare and recover cache, so that it will not get fouled.
-SwSaveSetLRUOfst aSave( *SwTextFrame::GetTextCache(),
- SwTextFrame::GetTextCache()->GetCurMax() - 50 );
+// Preserve top of the text frame cache.
+SwSaveSetLRUOfst aSaveLRU;
 // #125243# there are lots of 

[Libreoffice-commits] core.git: sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/bastyp/swcache.cxx |9 +
 sw/source/core/inc/swcache.hxx|1 +
 sw/source/core/text/txtfrm.cxx|4 
 3 files changed, 14 insertions(+)

New commits:
commit 31ae7509003b1e650463ee1468c0b315ba13efe6
Author: Michael Stahl 
AuthorDate: Mon Apr 29 17:14:42 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 15:27:47 2019 +0200

tdf#122607 sw: remove deleted SwTextFrame's cache entry

Apparently nothing else would remove the entry, and without SwTextFrame
it's not accessible any more.

If the entry was recently used, then the SwSaveSetLRUOfst usage in
SwViewShell::CalcLayout() will preserve it instead of giving the cache
entry to a new frame.

Change-Id: Id43fdbad2ac006853928e30a7b6768c3e3dc1667
Reviewed-on: https://gerrit.libreoffice.org/71541
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/bastyp/swcache.cxx 
b/sw/source/core/bastyp/swcache.cxx
index 705c49accd79..ff6d568b8e83 100644
--- a/sw/source/core/bastyp/swcache.cxx
+++ b/sw/source/core/bastyp/swcache.cxx
@@ -323,6 +323,15 @@ void SwCache::DeleteObj( SwCacheObj *pObj )
 CHECK;
 }
 
+void SwCache::Delete(void const*const pOwner, sal_uInt16 const nIndex)
+{
+INCREMENT( m_nDelete );
+if (SwCacheObj *const pObj = Get(pOwner, nIndex, false))
+{
+DeleteObj(pObj);
+}
+}
+
 void SwCache::Delete( const void *pOwner )
 {
 INCREMENT( m_nDelete );
diff --git a/sw/source/core/inc/swcache.hxx b/sw/source/core/inc/swcache.hxx
index aa0e4188d608..9a6563e256ba 100644
--- a/sw/source/core/inc/swcache.hxx
+++ b/sw/source/core/inc/swcache.hxx
@@ -102,6 +102,7 @@ public:
 void ToTop( SwCacheObj *pObj );
 
 bool Insert( SwCacheObj *pNew );
+void Delete(const void * pOwner, sal_uInt16 nIndex);
 void Delete( const void *pOwner );
 
 void SetLRUOfst( const sal_uInt16 nOfst );  /// nOfst determines how many 
are not to be touched
diff --git a/sw/source/core/text/txtfrm.cxx b/sw/source/core/text/txtfrm.cxx
index 90541798c63f..37c1c406d365 100644
--- a/sw/source/core/text/txtfrm.cxx
+++ b/sw/source/core/text/txtfrm.cxx
@@ -881,6 +881,10 @@ void SwTextFrame::DestroyImpl()
 
 SwTextFrame::~SwTextFrame()
 {
+if (GetCacheIdx() != USHRT_MAX)
+{
+s_pTextCache->Delete(this, GetCacheIdx());
+}
 }
 
 namespace sw {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/qa/extras/layout/data/tdf122607_leerzeile.odt |binary
 sw/qa/extras/layout/layout.cxx   |   48 +++
 sw/source/uibase/uno/unotxdoc.cxx|7 +--
 3 files changed, 52 insertions(+), 3 deletions(-)

New commits:
commit 5879351aeb1935e2bf86fda59703f7d49fdeb6ed
Author: Michael Stahl 
AuthorDate: Mon Apr 29 17:40:45 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 15:29:52 2019 +0200

tdf#122607 sw: restore CalcLayout() call in getRendererCount()

Effectively revert commit 1ecca673b40fedc53db125e332b087d1c120a254.

There are some documents that aren't formatted correctly.

Change-Id: I4b0cf6313c249a0ed916c2630cd5194d809bfb48

diff --git a/sw/qa/extras/layout/data/tdf122607_leerzeile.odt 
b/sw/qa/extras/layout/data/tdf122607_leerzeile.odt
new file mode 100644
index ..9819a229344a
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf122607_leerzeile.odt 
differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index c17adf1bba92..f6272278fee8 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -2738,6 +2738,54 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf122607)
 "Portion", "Fax:");
 }
 
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf122607_regression)
+{
+discardDumpedLayout();
+if (mxComponent.is())
+mxComponent->dispose();
+
+auto const pName("tdf122607_leerzeile.odt");
+
+OUString const url(m_directories.getURLFromSrc(DATA_DIRECTORY)
+   + OUString::createFromAscii(pName));
+
+// note: must set Hidden property, so that 
SfxFrameViewWindow_Impl::Resize()
+// does *not* forward initial VCL Window Resize and thereby triggers a
+// layout which does not happen on soffice --convert-to pdf.
+std::vector aFilterOptions = {
+{ beans::PropertyValue("Hidden", -1, uno::Any(true), 
beans::PropertyState_DIRECT_VALUE) },
+};
+
+std::cout << pName << ":\n";
+
+// inline the loading because currently properties can't be passed...
+mxComponent = loadFromDesktop(url, "com.sun.star.text.TextDocument",
+  
comphelper::containerToSequence(aFilterOptions));
+
+CPPUNIT_ASSERT(mxComponent.is());
+
+uno::Sequence 
props(comphelper::InitPropertySequence({
+{ "FilterName", uno::Any(OUString("writer_pdf_Export")) },
+}));
+utl::TempFile aTempFile;
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+xStorable->storeToURL(aTempFile.GetURL(), props);
+
+xmlDocPtr pXmlDoc = parseLayoutDump();
+// somehow these 2 rows overlapped in the PDF unless CalcLayout() runs
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[1]/infos/bounds", "mbFixSize",
+"false");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[1]/infos/bounds", "top", "2977");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[1]/infos/bounds", "height", "241");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[2]/infos/bounds", "mbFixSize",
+"true");
+// this was 3034, causing the overlap
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[2]/infos/bounds", "top", "3218");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[2]/infos/bounds", "height", "164");
+
+aTempFile.EnableKillingFile();
+}
+
 CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testBtlrCell)
 {
 SwDoc* pDoc = createDoc("btlr-cell.odt");
diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 4a5dcee452aa..5b95045842a3 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -2614,9 +2614,10 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
 // should be set for printing as well ...
 pViewShell->SetPDFExportOption( true );
 
-// tdf#122607 Re-layout the doc. Calling CalcLayout here is not 
enough, as it depends
-// on the currently visible area which is 0 when doing headless 
conversion.
-pViewShell->Reformat();
+// there is some redundancy between those two function calls, but 
right now
+// there is no time to sort this out.
+//TODO: check what exactly needs to be done and make just one 
function for that
+pViewShell->CalcLayout();
 pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() );
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/inc vcl/quartz

[Tomaž Vajngerl (via logerrit)]

 vcl/inc/quartz/salgdi.h |6 --
 vcl/quartz/ctfonts.cxx  |5 ++---
 vcl/quartz/salgdi.cxx   |9 +
 3 files changed, 15 insertions(+), 5 deletions(-)

New commits:
commit c17588930688b01253434a3d8acb4b9c0c58adf7
Author: Tomaž Vajngerl 
AuthorDate: Sat Apr 20 21:50:37 2019 +0900
Commit: Andras Timar 
CommitDate: Tue Apr 30 16:03:23 2019 +0200

tdf#101854 Move to CommonSalLayout removed faux bold in macos

Previously faux bold was drawn with setting a dictionary key
kCTStrokeWidthAttributeName and a value of the stroke width. This
stopped working because we don't use attributedString for drawing
anymore but we always use CTFontDrawGlyphs and draw the glyphs,
which doesn't have a way to set this attributes.

It took me a while to find a workaround (thanks to Apple's great
documentation), where we switch text drawing to fill and stroke,
and after that we can modify the stroke by changing the line
width.

Change-Id: I594fcb9c796a9c04ea8234a9938ca2f719706199
Reviewed-on: https://gerrit.libreoffice.org/71012
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit eb5606511fac2a8ee1af7cc03c12d6c5b16f7c96)
Reviewed-on: https://gerrit.libreoffice.org/71061
Reviewed-by: Andras Timar 

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index cacf56dcb84f..70b4ddad47f1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -90,9 +90,11 @@ public:
 CFMutableDictionaryRef  GetStyleDict( void ) const { return mpStyleDict; }
 
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
-float   mfFontStretch;
+float mfFontStretch;
 /// text rotation in radian
-float   mfFontRotation;
+float mfFontRotation;
+/// faux bold - true, if font doesn't have proper bold variants
+float mbFauxBold;
 
 private:
 explicit CoreTextStyle(const PhysicalFontFace&, const FontSelectPattern&);
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index e98fac83b0f6..03582bf9cf3d 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle(const PhysicalFontFace& rPFF, 
const FontSelectPatte
 : LogicalFontInstance(rPFF, rFSP)
 , mfFontStretch( 1.0 )
 , mfFontRotation( 0.0 )
+, mbFauxBold(false)
 , mpStyleDict( nullptr )
 {
 double fScaledFontHeight = rFSP.mfExactHeight;
@@ -81,9 +82,7 @@ CoreTextStyle::CoreTextStyle(const PhysicalFontFace& rPFF, 
const FontSelectPatte
  ((rPFF.GetWeight() < WEIGHT_SEMIBOLD) &&
   (rPFF.GetWeight() != WEIGHT_DONTKNOW)) )
 {
-int nStroke = -lrint((3.5F * rFSP.GetWeight()) / rPFF.GetWeight());
-CFNumberRef rStroke = CFNumberCreate(nullptr, kCFNumberSInt32Type, 
);
-CFDictionarySetValue(mpStyleDict, kCTStrokeWidthAttributeName, 
rStroke);
+mbFauxBold = true;
 }
 
 // fake italic
diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index d64fc8677ce7..33ca4573e382 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -460,6 +460,15 @@ void AquaSalGraphics::DrawTextLayout(const 
GenericSalLayout& rLayout)
 SAL_INFO("vcl.cg", "CGContextSetFillColor(" << mrContext << "," << 
maTextColor << ")");
 CGContextSetFillColor(mrContext, maTextColor.AsArray());
 
+if (rStyle.mbFauxBold)
+{
+
+float fSize = rFontSelect.mnHeight / 23.0f;
+CGContextSetStrokeColor(mrContext, maTextColor.AsArray());
+CGContextSetLineWidth(mrContext, fSize);
+CGContextSetTextDrawingMode(mrContext, kCGTextFillStroke);
+}
+
 auto aIt = aGlyphOrientation.cbegin();
 while (aIt != aGlyphOrientation.cend())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/qa/extras/layout/data/tdf122607_leerzeile.odt |binary
 sw/qa/extras/layout/layout.cxx   |   50 +++
 sw/source/uibase/uno/unotxdoc.cxx|7 +--
 3 files changed, 54 insertions(+), 3 deletions(-)

New commits:
commit 70c54e1503e2132fa9be908c9fda76f6902b7d7c
Author: Michael Stahl 
AuthorDate: Mon Apr 29 17:40:45 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 16:07:14 2019 +0200

tdf#122607 sw: restore CalcLayout() call in getRendererCount()

Effectively revert commit 1ecca673b40fedc53db125e332b087d1c120a254.

There are some documents that aren't formatted correctly.

(cherry picked from commit 5879351aeb1935e2bf86fda59703f7d49fdeb6ed)

Change-Id: I4b0cf6313c249a0ed916c2630cd5194d809bfb48

diff --git a/sw/qa/extras/layout/data/tdf122607_leerzeile.odt 
b/sw/qa/extras/layout/data/tdf122607_leerzeile.odt
new file mode 100644
index ..9819a229344a
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf122607_leerzeile.odt 
differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 615061572ec1..a107d6472aa3 100755
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -34,6 +34,7 @@ public:
 void testTdf119875();
 void testTdf116989();
 void testTdf122607();
+void testTdf122607_regression();
 void testTdf123898();
 
 CPPUNIT_TEST_SUITE(SwLayoutWriter);
@@ -53,6 +54,7 @@ public:
 CPPUNIT_TEST(testTdf119875);
 CPPUNIT_TEST(testTdf116989);
 CPPUNIT_TEST(testTdf122607);
+CPPUNIT_TEST(testTdf122607_regression);
 CPPUNIT_TEST(testTdf123898);
 CPPUNIT_TEST_SUITE_END();
 
@@ -323,6 +325,54 @@ void SwLayoutWriter::testTdf122607()
 "nWidth", "428");
 }
 
+void SwLayoutWriter::testTdf122607_regression()
+{
+discardDumpedLayout();
+if (mxComponent.is())
+mxComponent->dispose();
+
+auto const pName("tdf122607_leerzeile.odt");
+
+OUString const url(m_directories.getURLFromSrc(DATA_DIRECTORY)
+   + OUString::createFromAscii(pName));
+
+// note: must set Hidden property, so that 
SfxFrameViewWindow_Impl::Resize()
+// does *not* forward initial VCL Window Resize and thereby triggers a
+// layout which does not happen on soffice --convert-to pdf.
+std::vector aFilterOptions = {
+{ beans::PropertyValue("Hidden", -1, uno::Any(true), 
beans::PropertyState_DIRECT_VALUE) },
+};
+
+std::cout << pName << ":\n";
+
+// inline the loading because currently properties can't be passed...
+mxComponent = loadFromDesktop(url, "com.sun.star.text.TextDocument",
+  
comphelper::containerToSequence(aFilterOptions));
+
+CPPUNIT_ASSERT(mxComponent.is());
+
+uno::Sequence 
props(comphelper::InitPropertySequence({
+{ "FilterName", uno::Any(OUString("writer_pdf_Export")) },
+}));
+utl::TempFile aTempFile;
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+xStorable->storeToURL(aTempFile.GetURL(), props);
+
+xmlDocPtr pXmlDoc = parseLayoutDump();
+// somehow these 2 rows overlapped in the PDF unless CalcLayout() runs
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[1]/infos/bounds", "mbFixSize",
+"false");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[1]/infos/bounds", "top", "2977");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[1]/infos/bounds", "height", "241");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[2]/infos/bounds", "mbFixSize",
+"true");
+// this was 3034, causing the overlap
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[2]/infos/bounds", "top", "3218");
+assertXPath(pXmlDoc, 
"/root/page[1]/anchored/fly/tab[1]/row[2]/infos/bounds", "height", "164");
+
+aTempFile.EnableKillingFile();
+}
+
 void SwLayoutWriter::testTdf123898()
 {
 createDoc("tdf123898.odt");
diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index d2d512fd8c6f..f351dafdc4ec 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -2622,9 +2622,10 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
 // should be set for printing as well ...
 pViewShell->SetPDFExportOption( true );
 
-// tdf#122607 Re-layout the doc. Calling CalcLayout here is not 
enough, as it depends
-// on the currently visible area which is 0 when doing headless 
conversion.
-pViewShell->Reformat();
+// there is some redundancy between those two function calls, but 
right now
+// there is no time to sort this out.
+//TODO: check what exactly needs to be done and make just one 
function for that
+pViewShell->CalcLayout();
 pViewShell->CalcPagesForPrint( pViewShell->GetPageCount() );
 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1-6' - vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/filter/graphicfilter.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit e80bac9279564c366691cbd51cf557c7083d37c3
Author: Caolán McNamara 
AuthorDate: Sat Apr 27 11:52:11 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Apr 30 16:32:03 2019 +0200

ofz#14469 null deref

since...

commit af84fc9d906626255aaf136eefc5e55236e0e8a6
Date:   Tue Apr 23 15:48:41 2019 +0200

lazy image loading shouldn't read the entire .xls file (tdf#124828)

nLength is just an unchecked value in the dff stream, it might not be sane
so limit it to the max len of the stream

Change-Id: Ia8a2830478952afe1317b5cd795f35059d9b380a
Reviewed-on: https://gerrit.libreoffice.org/71415
Reviewed-by: Michael Stahl 
Tested-by: Xisco Faulí 
Reviewed-by: Noel Grandin 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/filter/graphicfilter.cxx 
b/vcl/source/filter/graphicfilter.cxx
index cad4d4ae1fd5..654393238eba 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -1454,7 +1454,9 @@ Graphic GraphicFilter::ImportUnloadedGraphic(SvStream& 
rIStream, sal_uInt64 size
 ErrCode nStatus = ImpTestOrFindFormat("", rIStream, nFormat);
 
 rIStream.Seek(nStreamBegin);
-const sal_uInt32 nStreamLength( sizeLimit ? sizeLimit : 
rIStream.Seek(STREAM_SEEK_TO_END) - nStreamBegin);
+sal_uInt32 nStreamLength(rIStream.remainingSize());
+if (sizeLimit && sizeLimit < nStreamLength)
+nStreamLength = sizeLimit;
 
 OUString aFilterName = pConfig->GetImportFilterName(nFormat);
 OUString aExternalFilterName = pConfig->GetExternalFilterName(nFormat, 
false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Michael Stahl (via logerrit)]

 sd/source/filter/eppt/pptx-animations.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit bf8c8699f7ed09519db2041e1ec1554097e94ab4
Author: Michael Stahl 
AuthorDate: Tue Apr 30 15:37:59 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 15:37:59 2019 +0200

sd: fix comphelper::OInterfaceCompare build breakage

This was removed today.

Change-Id: I07e7515d0d4b63721c6f80193917a9e1c5f1f09b

diff --git a/sd/source/filter/eppt/pptx-animations.cxx 
b/sd/source/filter/eppt/pptx-animations.cxx
index da5223c50ec7..c1c86f46ae3a 100644
--- a/sd/source/filter/eppt/pptx-animations.cxx
+++ b/sd/source/filter/eppt/pptx-animations.cxx
@@ -635,8 +635,7 @@ class PPTXAnimationExport
 const FSHelperPtr& mpFS;
 const NodeContext* mpContext;
 
-std::map, sal_Int32, 
::comphelper::OInterfaceCompare>
-maAnimationNodeIdMap;
+std::map, sal_Int32> maAnimationNodeIdMap;
 sal_Int32 GetNextAnimationNodeId(const Reference& rNode);
 sal_Int32 GetAnimationNodeId(const Reference& rNode);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57c' - 2 commits - sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/bastyp/swcache.cxx |   10 ++
 sw/source/core/inc/swcache.hxx|   10 --
 sw/source/core/text/txtcache.cxx  |   36 
 sw/source/core/text/txtfrm.cxx|4 
 sw/source/core/view/viewsh.cxx|   10 --
 5 files changed, 58 insertions(+), 12 deletions(-)

New commits:
commit 16b7f46a40c194398d0b1ca39afc619f419ccb4f
Author: Michael Stahl 
AuthorDate: Mon Apr 29 17:21:18 2019 +0200
Commit: Michael Stahl 
CommitDate: Tue Apr 30 15:34:04 2019 +0200

tdf#122607 sw: fix preservation of text frame cache entries

SwSaveSetLRUOfst would leave only 50 cache entries available for the
CalcLayout() to use; apparently it's not enough for this document.

The difference between the 1st loading/layout and the 3rd loading/layout
of the document is that in many paragraphs the cache entry is missing,
because the entires of the previous loads were clogging up the cache
and were preserved here, and the cache only has 50 available entries;
if enough entries are available, everything is positioned properly.

The idea with the 100 entries per visible shell actually comes from the
CVS initial import, where there was a comment suggesting that; but the
corresponding parameter was actually unused and removed in
7c704c78d3c652504c064b4ac7af55a2c1ee49bb.

Ideally we'd have time to investigate why a missing cache entry causes
the wrong position...

Reviewed-on: https://gerrit.libreoffice.org/71542
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 3d37463eec0c891243a8971a34903b2da01c9e24)

Change-Id: I64a72a94361dbf5717bbc709fa3bc9abbe18a37c

diff --git a/sw/source/core/bastyp/swcache.cxx 
b/sw/source/core/bastyp/swcache.cxx
index ab82fe11ba74..e90f89b87612 100644
--- a/sw/source/core/bastyp/swcache.cxx
+++ b/sw/source/core/bastyp/swcache.cxx
@@ -440,6 +440,7 @@ bool SwCache::Insert( SwCacheObj *pNew )
 
 void SwCache::SetLRUOfst( const sal_uInt16 nOfst )
 {
+assert(nOfst < m_nCurMax);
 if ( !m_pRealFirst || ((m_aCacheObjects.size() - m_aFreePositions.size()) 
< nOfst) )
 return;
 
diff --git a/sw/source/core/inc/swcache.hxx b/sw/source/core/inc/swcache.hxx
index a481bbff28ff..2cc6138cb2b1 100644
--- a/sw/source/core/inc/swcache.hxx
+++ b/sw/source/core/inc/swcache.hxx
@@ -117,15 +117,12 @@ public:
 sal_uInt16 size() { return m_aCacheObjects.size(); }
 };
 
-/// Safely manipulate the cache
+/// Try to prevent visible SwParaPortions from being deleted.
 class SwSaveSetLRUOfst
 {
-SwCache 
 public:
-SwSaveSetLRUOfst( SwCache , const sal_uInt16 nOfst )
-: rCache( rC )  { rCache.SetLRUOfst( nOfst );  }
-
-~SwSaveSetLRUOfst() { rCache.ResetLRUOfst(); }
+SwSaveSetLRUOfst();
+~SwSaveSetLRUOfst();
 };
 
 /**
diff --git a/sw/source/core/text/txtcache.cxx b/sw/source/core/text/txtcache.cxx
index b2f412b07c5b..20b992d9e275 100644
--- a/sw/source/core/text/txtcache.cxx
+++ b/sw/source/core/text/txtcache.cxx
@@ -21,6 +21,9 @@
 #include 
 #include "porlay.hxx"
 
+#include 
+#include 
+
 SwTextLine::SwTextLine( SwTextFrame const *pFrame, SwParaPortion *pNew ) :
 SwCacheObj( static_cast(pFrame) ),
 pLine( pNew )
@@ -135,4 +138,37 @@ void SwTextFrame::SetPara( SwParaPortion *pNew, bool 
bDelete )
 }
 }
 
+/** Prevent the SwParaPortions of the *visible* paragraphs from being deleted;
+they would just be recreated on the next paint.
+
+Heuristic: 100 per view are visible
+
+If the cache is too small, enlarge it to ensure there are sufficient free
+entries for the layout so it doesn't have to throw away a node's
+SwParaPortion when it starts formatting the next node.
+*/
+SwSaveSetLRUOfst::SwSaveSetLRUOfst()
+{
+sal_uInt16 nVisibleShells(0);
+for (auto pView = SfxViewShell::GetFirst(true, checkSfxViewShell);
+ pView != nullptr;
+ pView = SfxViewShell::GetNext(*pView, true, 
checkSfxViewShell))
+{
+++nVisibleShells;
+}
+
+sal_uInt16 const nPreserved(100 * nVisibleShells);
+SwCache & rCache(*SwTextFrame::GetTextCache());
+if (rCache.GetCurMax() < nPreserved + 250)
+{
+rCache.IncreaseMax(nPreserved + 250 - rCache.GetCurMax());
+}
+rCache.SetLRUOfst(nPreserved);
+}
+
+SwSaveSetLRUOfst::~SwSaveSetLRUOfst()
+{
+SwTextFrame::GetTextCache()->ResetLRUOfst();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 76435e704cd9..640db966432e 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -700,9 +700,8 @@ void SwViewShell::LayoutIdle()
 #endif
 
 {
-//Prepare and recover cache, so that it will not get fouled.
-SwSaveSetLRUOfst aSave( *SwTextFrame::GetTextCache(),
- SwTextFrame::GetTextCache()->GetCurMax() - 50 );
+

[Libreoffice-commits] core.git: sc/uiconfig

[Caolán McNamara (via logerrit)]

 sc/uiconfig/scalc/ui/paratemplatedialog.ui |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 1ae5ca077119982ae83833871326c86d9930ae11
Author: Caolán McNamara 
AuthorDate: Tue Apr 30 11:35:56 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Apr 30 16:26:05 2019 +0200

tdf#124241 let dialog be resizable

so it can shrink to its optimal size

Change-Id: Ia83b8b29a56e0e232956770a3a3374035db2c6ef
Reviewed-on: https://gerrit.libreoffice.org/71577
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/uiconfig/scalc/ui/paratemplatedialog.ui 
b/sc/uiconfig/scalc/ui/paratemplatedialog.ui
index 6bffb382..cc1ef8f2bc86 100644
--- a/sc/uiconfig/scalc/ui/paratemplatedialog.ui
+++ b/sc/uiconfig/scalc/ui/paratemplatedialog.ui
@@ -6,7 +6,6 @@
 False
 6
 Cell Style
-False
 True
 0
 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119202] LibreOffice apps should not change their WM_CLASS values after being launched

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119202

--- Comment #4 from Michael Weghorn  ---
(In reply to Xisco Faulí from comment #3)
> @Michael Weghorn, do you reproduce this on your end ?

I'm quite sure I tried a while ago but couldn't reproduce easily. As far as I
understand, a workaround has been implemented in Plasma, s. this commit:
https://cgit.kde.org/plasma-workspace.git/commit/?id=b15eaf38b6bf8d5af7fdc0caff05679a063819cf

Therefore, one would probably have to use an older version of Plasma or revert
that patch to be able to still reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101524] Seeking during media playback shouldnt pause playback

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101524

Katarina Behrens (CIB)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |katarina.behr...@cib.de
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116629] notebookbar hide arrow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116629

--- Comment #4 from andreas_k  ---
Created attachment 151096
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151096=edit
Add an icon to the arrow

is it possible to add an icon to the > arrow. This will help to click it (which
is now very difficult, cause the > is very tiny) and as MSO use it in there
2019 implementation users will know how it work.

Let me know if it's possible, dan I will add the icon. I think 14x16 px size
will be ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104461] [META] DOCX (OOXML) frame-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104461
Bug 104461 depends on bug 123636, which changed state.

Bug 123636 Summary: FILEOPEN DOCX with frame content on multiple pages is 
condensed to single page
https://bugs.documentfoundation.org/show_bug.cgi?id=123636

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124982] Calc seems only capable of using one CPU core

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124982

Owen Savill  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] Formatting: Formula result has different alignment than regular values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #10 from Cor Nouws  ---
(In reply to bugzilla2 from comment #9)
> The number recognition can be left ON. But disabling the alignment switch by
> default would restore compatibility to documents that were saved with
> versions prior to 6.2.x.

Existing documents are not changed on opening.
But yes, if one edits an existing document, the behavior is changed.
This is then something the user has to fiddle out. And to be honest, as far as
I know, not been considered with creating the change.

Of course the choice in bug 113241 was deliberate - allowing the creation of
better default tables by default for all users, preventing people to hassle
with tabs, outline, spaces .. ;|
So my choice would be to leave it as it is now.
A nice blog to get some attention and for easy reference, would be good of
course.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 124860] Formatting: Formula result has different alignment than regular values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #10 from Cor Nouws  ---
(In reply to bugzilla2 from comment #9)
> The number recognition can be left ON. But disabling the alignment switch by
> default would restore compatibility to documents that were saved with
> versions prior to 6.2.x.

Existing documents are not changed on opening.
But yes, if one edits an existing document, the behavior is changed.
This is then something the user has to fiddle out. And to be honest, as far as
I know, not been considered with creating the change.

Of course the choice in bug 113241 was deliberate - allowing the creation of
better default tables by default for all users, preventing people to hassle
with tabs, outline, spaces .. ;|
So my choice would be to leave it as it is now.
A nice blog to get some attention and for easy reference, would be good of
course.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 124356] Shift key is accepted as input and clears cell content in KDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124356

--- Comment #20 from Michael Weghorn  ---
(In reply to Owen Savill from comment #19)
> Issue does not seem to be happening with Version: 6.3.0.0.alpha0+
> Build ID: 6a67ecd9b12e68031b5dbacb591955b59f476b86 but is still happening in
> 6.2.3.2

OK, this might explain why I was unable to reproduce, even with IBUS enabled (I
only tried master then).

Can we mark this bug as WORKSFORME then, since it doesn't happen with the
current development version any more?

I quickly had a look at the kde-specific commits that are in 6.3.0.0.alpha0+,
but not in 6.2, but none seemed obvious for having fixed this. It *might* even
be it will be fixed with the upcoming 6.2.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125052] Data error risk from not calculating on large spreadsheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125052

--- Comment #2 from davidpbrown  ---
Upgrade had no effect..

same symptoms:
+ vlookups and other formulas are not actioning and copying an instance from
adjacent cells copies the appearance of the same result of the old cell,
without reference to the new cell; without knowing that result is wrong it's
not obvious.
+ adding new data, doesn't see that trigger update of calculations.. simple
calculations too.

I haven't been able to reproduce on a small file but expect it's a symptom of
some limit in size.. file is 1.1MB

Above tempts "Version: (earliest affected)", rather than noting the latest
=>
Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded

Perhaps any file full of vlookup calculations to similar size will exhibit the
same?? If I can find an example for sharing, will do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125043] Can't insert a space before new Drop-Down Form Field in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125043

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Dieter Praas  ---
I confirm that with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 421e6fc3cd2e6fe37afbef341e2d0ad7b8edde37
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-04-07_01:12:58
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

But I couldn't insert any character before Drop-Down Form Field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125052] Data error risk from not calculating on large spreadsheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125052

--- Comment #3 from davidpbrown  ---
Not simple to reproduce unfortunately.. it's not just about file size.

I created a larger than intended 21.9MB instance that was vlookups from another
sheet and that with simple calculations done but it continued to try to
calculate change.. and successfully, though rather greedy with the resource
available.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] QA Meeting Minutes (2019-04-30)

[Xisco Fauli]

Meeting started by x1sc0 at 15:00:30 UTC.  The full logs are available
at
http://dev-downloads.libreoffice.org/meetbot/libreoffice-qa/2019/libreoffice-qa.2019-04-30-15.00.log.html


Meeting summary

---

* regular tasks  (x1sc0, 15:04:18)
  * ACTION: x1sc0 create draft ( and send email to the mailing list )
    and others add on top  (x1sc0, 15:15:30)

* BHS for Libo 6.3 alpha1  (x1sc0, 15:17:01)
  * Monday 13, May

* UIforETW
  * LINK:
 
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_how_to_get_an_ETW_performance_trace
(x1sc0, 15:30:15)

* Script for checking fileopen/filesave regressions
  * LINK:
  https://gerrit.libreoffice.org/#/c/71069/

* triage week  (x1sc0, 15:48:12)
  * LINK: https://wiki.mozilla.org/SeaMonkey:Triage_Week  (x1sc0,
    15:50:21)
  * IDEA: triage 5 bugs a day  (x1sc0, 16:04:56)



Meeting ended at 16:09:17 UTC.



Action items, by person
---

* x1sc0
  * x1sc0 create draft ( and send email to the mailing list ) and others
    add on top



People present (lines said)
---

* x1sc0 (89)
* buovjaga (32)
* lo-qa-tg1 (16)
* az (12)
* CorNouws (10)
* bearon (7)
* IZBot (5)
* Telesto (2)

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 94657] borders not visible on loading docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94657

V Stuart Foote  changed:

   What|Removed |Added

 CC||philip.ludwig@griffithscorp
   ||.com

--- Comment #9 from V Stuart Foote  ---
*** Bug 125050 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124755] Crash - Hsqldb ODB file crashes office on opening from StartCenter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124755

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #12 from raal  ---
No crash Version: 6.3.0.0.alpha0+
Build ID: 1ae5ca077119982ae83833871326c86d9930ae11
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124409] Opening the WriterGuideLO.odt manual is slower in 6.3 compared to 4.4.7.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124409

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm the bug present in 

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

It takes about 90sec to open the file.

Whereas in Version 3.3.0 it takes only 8 secs to open the file.
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125052] New: Data error risk from not calculating on large spreadsheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125052

Bug ID: 125052
   Summary: Data error risk from not calculating on large
spreadsheets
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: openfo...@davidpbrown.co.uk

Sheet not calculating, gives misleading results - because that inaction is not
declared.

At some point not obvious it seems a large spreadsheet becomes too large, that
Calc stops being dynamic and does not update at every opportunity.

Ctrl+Shift+F9 works to force recalculation
which is great - IF you know to do that AND IF you know that it's necessary -
because you spot cells are not updated correctly.

I saw this from odd vlookup results and fortunately figured out from a quick
search but it is to be expected many users will not see the change and even
those aware of this, will remain uncertain when and if, this feature has
actioned.. and it's a feature because it's a lot faster on a large spreadsheet
to not calculate complexity. (It would be useful to know how to force this
switch off before it is just too large.)

Expected behaviour: some fundamental change is declared explicitly and/or some
indicator on the bottom toolbar perhaps notes that the sheet requires forced
update.

It's made worse by the opening of that file not apparently triggering
recalculation.. there is no suggestion that is required.

Risk of data errors is obvious, from sheets where this has occurred.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125053] UI: Calc used to store an image from copied selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125053

Hans-Peter Jansen  changed:

   What|Removed |Added

Version|unspecified |6.2.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125053] New: UI: Calc used to store an image from copied selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125053

Bug ID: 125053
   Summary: UI: Calc used to store an image from copied selection
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h...@urpla.net

Hi,

today, I noticed a regression of Calc, that I'm using a lot:

With Calc 5.0.6.8, it was possible to select a couple of cells and copy them to
the clipboard. Pasting that in another app (e.g. Gimp) was possible, since LO
copied an image to the clipboard.

With Calc 6.2.2.2 from openSUSE Tumbleweed, it only copies some html artefacts.

The former behavior is preferred here, as I use it to paste parts of a sheet
into mails, that appear with all formatting to the receiver. The html pastes
isn't an adequate replacement. At least, LO should optionally provide those
images..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125052] Data error risk from not calculating on large spreadsheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125052

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
The 6.0 it's a bit outdated version. Some issues with cells no recalculated
under some circumstances, have been resolved, so please if you can share a file
showing the problem to test, or  can yourself test with a recent version like
6.2.3?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124044] KDE5 VCL may require a little more cooking for wide consumption (at least on impress)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124044

Michael Weghorn  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #11 from Michael Weghorn  ---
I agree with bubli wrt most annying issues that should be fixed.

In addition to the first list, I'd add tdf#120774, which is already fixed on
master but needs some more work to be backported to 6.2

(In reply to Katarina Behrens (CIB) from comment #9)
> With the bugs from the first group fixed, I would keep kde5 in 6.2

Sounds reasonable to me.

@Sergio, as the original reporter: Anything you want to add here or any other
concerns?

(Let's set bug status to NEW in the meanwhile)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125049] New: Request more standard (and useful) way to select anchor point for object align

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125049

Bug ID: 125049
   Summary: Request more standard (and useful) way to select
anchor point for object align
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kurt.fitz...@gmail.com

Description:
The use of the align in Draw is not consistent with the way align works in most
other drawing programs, and the way it works now makes it impossible to use in
many circumstances.



Steps to Reproduce:
.


Actual Results:
The way it works now is that it seems to align all objects to the selected part
of their global bounding box.  So if you select three objects and then use
"Align -> Top", all objects will move to the topmost edge of the topmost
object.  For Align -> Center, it is particularly difficult because all objects
in the selected will move the center of the bounding box.  So if you have
several objects of different height that you want to align with the center of
existing object, you can't.  All objects will move to their global bounding box
center.

Expected Results:
The way most drawing programs (including InkScape and Corel Draw) handle this,
is to make one object in the selection an anchor object.  In InkScape it is the
last object selected in the group.  This means that you can always select which
object to have all other objects reference against.

I can think of almost no instance where you would want to align the centers of
objects and have them all move to the global bounding box center.  Align is
almost always used to bring other objects in alignment with at least one other
object in it's existing position.  Being able to select that object will be
beneficial for all types of alignment and will bring LibreOffice Draw into
agreement with best practices in drawing software.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125048] Saved file has wrong group if calc file contains a chart. (Truly bizarre ...)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125048

--- Comment #2 from Nigel Arnot  ---
Just confirmed that this bug is also present in 6.2.3.2 as downloaded from
https://www.libreoffice.org/download/download/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125051] New: EDITING: CRASH when start SpellCheck

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125051

Bug ID: 125051
   Summary: EDITING: CRASH when start SpellCheck
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libreoff...@bielefeldundbuss.de

Steps how to reproduce with server installation of Version: 6.3.0.0.alpha0+ 
Build ID: 2e3b0c5d42d60d46cd9f8b8eda9424b095c63418; Windows 6.1:

0) Launch LibO with newly created User Profile
1) From Start Center open new Calc document
2)  for spell check
   » CRASH

Additional info:

a) for me 100% reproducible
b) Endless crash loop if I try recovery: Document opens with open 
   Spell Check dialog, crashes immediately, recorvery, CRASH, ...
c) NOT reproducible with Version: 6.3.0.0.alpha0+ (x64)
  Build ID: f42554a1886ebe49170c25096dc3281b2c7bb1f4
  CPU threads: 4; OS: Windows 6.1; UI render: GL; VCL: win; 
  TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-08_22:37:30
  Locale: de-DE (de_DE); UI-Language: en-US
  Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120594] Crash attempting to open More Fields dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120594

--- Comment #15 from Andreas Hirsch  
---
Created attachment 151100
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151100=edit
Screenshot of Windows-Crash-Info (german)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125050] New: Viewing Page Border

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125050

Bug ID: 125050
   Summary: Viewing Page Border
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip.lud...@griffithscorp.com

Created attachment 151101
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151101=edit
Example Word doc with Art style border

Page Border in DOCX and DOC documents created with Microsoft Word (any version)
using style Art is not supported or displayed in LibreOffice Writer.

Steps to Reproduce:
1. Create a new document in Microsoft Word.
2. On the Page Layout tab, in the Page Background group, click Page
Borders.
3. Select Page Border tab.
4. Select the Box Settings type.
5. Select any Art option from the Style column.
6. Click on OK button.
7. Save the file as DOCX or DOC
8. Open the saved file in LibreOffice Writer.

Actual Result:
No page boarder displayed at all.

Expected Result:
Same page border displayed as Microsoft Word.

Reproducible: Always

After opening the file in LibreOffice Writer, Save As a new file (making no
changes), page border missing when saved file opened in Microsoft Word.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125050] Viewing Page Border

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125050

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 94657 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125053] UI: Calc used to store an image from copied selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125053

Hans-Peter Jansen  changed:

   What|Removed |Added

 OS|All |Linux (All)
   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125004] Multiple Sheet Windows Open ABENDS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125004

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
(In reply to Joe from comment #0)

> 
> At this point, you may have more than 30 logged errors as I do ask that the
> program send them all to you.
> 
Please post the logs URL.

Please copy and paste here the contents of your Help - About from your
LibreOffice. This allows us to know more about your system.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98360] [META] CMIS bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98360
Bug 98360 depends on bug 113834, which changed state.

Bug 113834 Summary: FILESAVE Crashes when saving remotely when service host is 
empty
https://bugs.documentfoundation.org/show_bug.cgi?id=113834

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114081] Playing slideshow with video on 1st slide shows artifacts (with OpenGL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114081

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||385,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4756
 CC||vmik...@collabora.com

--- Comment #10 from Aron Budea  ---
(In reply to Aron Budea from comment #9)
> However, in 6.3.0.0.alpha0+ (951282a27a9dd4c64fc206fcbdd805b4cb602816),
> there is now a white background, except the (still) video only blinks up for
> a split second, and is painted over with white as well, which I wouldn't
> call correct.
The change happened with the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d7f4f5650dd2c7fe1ccec50efd806e695b8bc18a
author  Miklos Vajna 2019-04-17 11:38:47
+0200
committer   Miklos Vajna 2019-04-17 15:43:48
+0200

tdf#124756 slideshow: avoid mbPaintDisabled for media windows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96385] Tracker: GL black / flickering issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96385

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4081

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120594] Crash attempting to open More Fields dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120594

--- Comment #16 from Andreas Hirsch  
---
Sorry for my mistake concerning the sceenshot. I expected this to be added to
my comment but my comment did not make its way.

Here is my comment to Julien Nabet:

Writer still crashes while trying to insert using the more fileds dialog.

I'm using:
Version: 6.2.2.2 (x64)
Build-ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d

Andreas

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125039] Regression from bug 123259 when anchoring a graphic as character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125039

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||michael.st...@cib.de,
   ||r...@post.cz
   Keywords||bibisected, bisected,
   ||regression

--- Comment #1 from raal  ---
(In reply to Roland Baudin from comment #0)
> 
> I traced the regression back to bug #123259 by compiling and bisecting and I
> found the problematic commit is 214e6ed5286566e689a4ef13a9115e2ad38fff57.

This seems to have begun at the below commit.
Adding Cc: to Michael Stahl ; Could you possibly take a look at this one?
Thanks

author  Michael Stahl 2019-03-07 15:53:36 +0100
committer   Thorsten Behrens   2019-03-10
01:21:23 +0100
commit  214e6ed5286566e689a4ef13a9115e2ad38fff57 (patch)
tree289fbf18c01ee0c9cbbc21a838f564198257d01b
parent  f8c00f23660e6816dd0a15708702c986c0cb4062 (diff)
tdf#123259 sw_redlinehide: fix reanchoring of drawing objects


Confirm with Version: 6.3.0.0.alpha0+
Build ID: 1ae5ca077119982ae83833871326c86d9930ae11
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs