[Libreoffice-commits] core.git: toolkit/source
toolkit/source/awt/vclxtabpagecontainer.cxx |2 ++ toolkit/source/controls/tabpagecontainer.cxx |4 2 files changed, 6 insertions(+) New commits: commit 0e86f0c79e29bde4a29ef77046621398b6bede63 Author: Samuel Mehrbrodt AuthorDate: Fri May 3 16:16:33 2019 +0200 Commit: Samuel Mehrbrodt CommitDate: Mon May 6 07:30:57 2019 +0200 Throw exception when peer for tabpage container is missing To give extension developers a clue what is missing Change-Id: I4a4727bdbf0522f8dd398c7aa877e49235efeb86 Reviewed-on: https://gerrit.libreoffice.org/71751 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt diff --git a/toolkit/source/awt/vclxtabpagecontainer.cxx b/toolkit/source/awt/vclxtabpagecontainer.cxx index da6ed54f8941..56e492ea8069 100644 --- a/toolkit/source/awt/vclxtabpagecontainer.cxx +++ b/toolkit/source/awt/vclxtabpagecontainer.cxx @@ -179,6 +179,8 @@ void SAL_CALL VCLXTabPageContainer::elementInserted( const css::container::Conta Reference< awt::tab::XTabPageModel > xP( xControl->getModel(), UNO_QUERY ); sal_Int16 nPageID = xP->getTabPageID(); +if (!xControl->getPeer().is()) +throw RuntimeException("No peer for tabpage container!"); VclPtr pWindow = VCLUnoHelper::GetWindow(xControl->getPeer()); TabPage* pPage = static_cast(pWindow.get()); pTabCtrl->InsertPage(nPageID,pPage->GetText()); diff --git a/toolkit/source/controls/tabpagecontainer.cxx b/toolkit/source/controls/tabpagecontainer.cxx index f7084896db19..18bda42e9e11 100644 --- a/toolkit/source/controls/tabpagecontainer.cxx +++ b/toolkit/source/controls/tabpagecontainer.cxx @@ -301,6 +301,8 @@ void SAL_CALL UnoControlTabPageContainer::removeTabPageContainerListener( const void UnoControlTabPageContainer::updateFromModel() { UnoControlTabPageContainer_Base::updateFromModel(); +if (!getPeer().is()) +throw RuntimeException("No peer for tabpage container!"); Reference< XContainerListener > xContainerListener( getPeer(), UNO_QUERY ); ENSURE_OR_RETURN_VOID( xContainerListener.is(), "UnoListBoxControl::updateFromModel: a peer which is no ItemListListener?!" ); @@ -320,6 +322,8 @@ void SAL_CALL UnoControlTabPageContainer::addControl( const OUString& Name, cons { SolarMutexGuard aSolarGuard; ControlContainerBase::addControl(Name,Control); +if (!getPeer().is()) +throw RuntimeException("No peer for tabpage container!"); Reference< XContainerListener > xContainerListener( getPeer(), UNO_QUERY ); ContainerEvent aEvent; aEvent.Source = getModel(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/items/itempool.cxx | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) New commits: commit 668de126d9217636ff8592928bb581ecd59db66f Author: Noel Grandin AuthorDate: Sun May 5 18:27:01 2019 +0200 Commit: Noel Grandin CommitDate: Mon May 6 07:17:20 2019 +0200 improve assert in SfxItemPooL::Put need to check for ownership passing in both variants of the loop, so just move it into the common block below. Change-Id: I75929377dd64df722a8ef040b5f714346417475d Reviewed-on: https://gerrit.libreoffice.org/71826 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx index 8df891a247f5..7c6f746ba319 100644 --- a/svl/source/items/itempool.cxx +++ b/svl/source/items/itempool.cxx @@ -620,9 +620,8 @@ const SfxPoolItem& SfxItemPool::PutImpl( const SfxPoolItem& rItem, sal_uInt16 nW // if is already in a pool, then it is worth checking if it is in this one. if ( IsPooledItem() ) { -auto it = rItemArr.find(const_cast()); - // 1. search for an identical pointer in the pool +auto it = rItemArr.find(const_cast()); if (it != rItemArr.end()) { AddRef(rItem); @@ -637,10 +636,7 @@ const SfxPoolItem& SfxItemPool::PutImpl( const SfxPoolItem& rItem, sal_uInt16 nW { pFoundItem = rItemArr.findByLessThan(); if (pFoundItem) -{ assert(*pFoundItem == rItem); -AddRef(*pFoundItem); -} } else { @@ -649,15 +645,14 @@ const SfxPoolItem& SfxItemPool::PutImpl( const SfxPoolItem& rItem, sal_uInt16 nW if (**itr == rItem) { pFoundItem = *itr; -assert((!bPassingOwnership || ( != *itr)) && "can't be passing ownership and have the item already in the pool"); -AddRef(**itr); break; } } } - if (pFoundItem) { +assert((!bPassingOwnership || ( != pFoundItem)) && "can't be passing ownership and have the item already in the pool"); +AddRef(*pFoundItem); if (bPassingOwnership) delete return *pFoundItem; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100693] FORMATTING MS-COMPAT: fo:wrap-option should be set for graphic-objects in text documents
https://bugs.documentfoundation.org/show_bug.cgi?id=100693 V Stuart Foote changed: What|Removed |Added CC||lukebe...@hotmail.com --- Comment #14 from V Stuart Foote --- *** Bug 125127 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125127] FILEOPEN: Support "Wrap Text" Option in Word Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=125127 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- see cmnt 13 of duplicate, Word wrap and frame size is correct for text in Draw shapes. But frames for Draw Text boxes have issues with wrapping, affecting filter import from OOXML. *** This bug has been marked as a duplicate of bug 100693 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125117] EDIT: Table of Contens (TOC) spanning more than page: Only the first page of the TOC can successfully be assigned to the page style „Index“
https://bugs.documentfoundation.org/show_bug.cgi?id=125117 --- Comment #4 from Jens Radloff --- (In reply to Dieter Praas from comment #3) > I had a look at your document, and it just works as expected: Page style > "Index" has "Default Style" as next style. So just change next style to > "Index" and add a new page break with style "Default Style" after yout TOC. > > => RESOLVED WORKSFORME Hi Dieter, OK, that's quite easy, one only has to deactivate the write-protection of the TOC. How about updating the LO Help, i.e. how about inserting in it a How-to about how to resolve this specific issue for the users? Regards, Jens -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117416] FILEOPEN: DOCX: Floating table is imported in the wrong position
https://bugs.documentfoundation.org/show_bug.cgi?id=117416 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117327] FIELDS-DIALOG: empty spaces in DocInformation => Type
https://bugs.documentfoundation.org/show_bug.cgi?id=117327 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116159] Can only select another language if you add a word that has to be corrected by the English spell checking ( steps in comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=116159 --- Comment #11 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117366] EDITING Calc hangs on Select All/Cut when the file contains a large table
https://bugs.documentfoundation.org/show_bug.cgi?id=117366 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123793] Can't step with keyboard to/between favorite special characters on group button
https://bugs.documentfoundation.org/show_bug.cgi?id=123793 Jim Raykowski changed: What|Removed |Added CC||rayk...@gmail.com Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #5 from Jim Raykowski --- Hi All, Here is a patch that provides for keyboard tab navigation of the special characters popup window and also focuses on the 'More Characters...' button when the popup window is displayed. https://gerrit.libreoffice.org/#/c/71834/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/registry sw/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |2 sw/uiconfig/swriter/ui/notebookbar.ui| 7103 ++ sw/uiconfig/swriter/ui/notebookbar_compact.ui| 3900 +++-- sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui | 777 - sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui| 941 + sw/uiconfig/swriter/ui/notebookbar_single.ui | 272 6 files changed, 8549 insertions(+), 4446 deletions(-) New commits: commit d6e8e41c22023bc15cc4c9659b33c1cc3d6edb75 Author: andreas kainz AuthorDate: Sun May 5 01:33:16 2019 +0200 Commit: andreas_kainz CommitDate: Mon May 6 00:41:04 2019 +0200 Writer Notebookbar Layout syncronisation Change-Id: Ibe8fb5114e624482292928d14ad8cc89b711f5a8 Reviewed-on: https://gerrit.libreoffice.org/71814 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu index 2e0500a621d1..7dfefa1bc10a 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu @@ -3635,7 +3635,7 @@ - AutoFormat Table Styles + Table Styles Auto~Format Styles... diff --git a/sw/uiconfig/swriter/ui/notebookbar.ui b/sw/uiconfig/swriter/ui/notebookbar.ui index 709631129bfe..cba0ed11b43d 100644 --- a/sw/uiconfig/swriter/ui/notebookbar.ui +++ b/sw/uiconfig/swriter/ui/notebookbar.ui @@ -1130,6 +1130,19 @@ True False + +True +False +.uno:ObjectMenue + + + + +True +False + + + True False @@ -1164,6 +1177,12 @@ + +True +False + + + True False @@ -2065,7 +2084,7 @@ - + True False cmd/sc_recentfilelist.png @@ -2281,20 +2300,33 @@ 0 + + +False +True +0 + + + + +True +False +center +True - + True False center vertical - + True -True +False both-horiz False - + True False .uno:NewDoc @@ -2313,13 +2345,13 @@ - + True -True +False both-horiz False - + True False .uno:SaveAsTemplate @@ -2344,8 +2376,24 @@ 1 + ++ + + +False +True +1 + + + + +True +False +center +True - + True False 5 @@ -2356,22 +2404,9 @@ False True 5 -2 +0 -
[Libreoffice-bugs] [Bug 125104] [Ubuntu, Writer] Chaging page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later
https://bugs.documentfoundation.org/show_bug.cgi?id=125104 bok...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125104] [Ubuntu, Writer] Chaging page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later
https://bugs.documentfoundation.org/show_bug.cgi?id=125104 --- Comment #10 from bok...@gmail.com --- Comment on attachment 151193 --> https://bugs.documentfoundation.org/attachment.cgi?id=151193 The file that crashes when i try to edit its page settings It is a completely new file I made just for this, since the bug can be reproduced with any file (on my computer). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125104] [Ubuntu, Writer] Chaging page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later
https://bugs.documentfoundation.org/show_bug.cgi?id=125104 --- Comment #9 from bok...@gmail.com --- Created attachment 151193 --> https://bugs.documentfoundation.org/attachment.cgi?id=151193=edit The file that crashes when i try to edit its page settings -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72662] Use Different Measurement Units for Line vs Page Properties (e.g. point vs inch)
https://bugs.documentfoundation.org/show_bug.cgi?id=72662 --- Comment #26 from Roland Hutchinson --- Some of you young whipper-snappers may very well believe that all typographical measurements are supposed to be in PostScript points. Well, font size and leading are traditionally given in points, but LINE LENGTH is given in PICAS. When using PostScript points, of course these will be PostScript picas (1/6 international inch exactly). When using picas, fractions of a pica should be expressed in points, not as decimal fractions of a pica. Thus, 10p6 rather than 10.5 pc, or 10p8.2 rather than 10.6 pc. (Adobe supports this -- so can we!) Hardcoding any measurement unit as mandatory would of course a dreadful mistake. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 72662] Use Different Measurement Units for Line vs Page Properties (e.g. point vs inch)
https://bugs.documentfoundation.org/show_bug.cgi?id=72662 --- Comment #26 from Roland Hutchinson --- Some of you young whipper-snappers may very well believe that all typographical measurements are supposed to be in PostScript points. Well, font size and leading are traditionally given in points, but LINE LENGTH is given in PICAS. When using PostScript points, of course these will be PostScript picas (1/6 international inch exactly). When using picas, fractions of a pica should be expressed in points, not as decimal fractions of a pica. Thus, 10p6 rather than 10.5 pc, or 10p8.2 rather than 10.6 pc. (Adobe supports this -- so can we!) Hardcoding any measurement unit as mandatory would of course a dreadful mistake. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 121593] Change of font not applied to all selected objects
https://bugs.documentfoundation.org/show_bug.cgi?id=121593 --- Comment #2 from rot_...@yahoo.de --- Created attachment 151192 --> https://bugs.documentfoundation.org/attachment.cgi?id=151192=edit Situation of multi-selection after click inside text area -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121593] Change of font not applied to all selected objects
https://bugs.documentfoundation.org/show_bug.cgi?id=121593 --- Comment #3 from rot_...@yahoo.de --- (In reply to Timur from comment #1) > Please explain and add precise steps. What are rectangles, text boxes? > I don't reproduce with text boxes. I figured out that this problem only occurs if the second selection of the multi-selection is selected by a shift+click inside the text are of that object (see screenshot). The expected behavior would be that the multi-selection is a selection of objects. Instead multiple objects get selected but the focus is on editing the text of the object selected last. In the case of a multi-selection a click inside the text area should trigger a selection of the object instead editing the text. This happens for both, text boxes as well as shapes with area and text (e.g. rectangle with text). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/item_refactor2' - 1299 commits - accessibility/inc accessibility/source android/README android/source animations/source apple_remote/source avmedia/inc
Rebased ref, commits from common ancestor: commit 6f72ff948b8f7581e2f46ded1e55803d94cb2606 Author: Armin Le Grand AuthorDate: Sun May 5 17:09:42 2019 +0200 Commit: Armin Le Grand CommitDate: Sun May 5 23:10:50 2019 +0200 WIP: Re-simplified StateChanged interface Added rebase correctiojns Change-Id: Ib0aa5e964fe1bb9365cd1f9d4fffe448134663cb diff --git a/avmedia/source/framework/mediatoolbox.cxx b/avmedia/source/framework/mediatoolbox.cxx index e75ba15aa390..191adfa913a9 100644 --- a/avmedia/source/framework/mediatoolbox.cxx +++ b/avmedia/source/framework/mediatoolbox.cxx @@ -84,7 +84,7 @@ MediaToolBoxControl::~MediaToolBoxControl() } -void MediaToolBoxControl::StateChanged( sal_uInt16, SfxItemState eState, const SfxPoolItem* pState, const std::unique_ptr& /*rSlotItem*/ ) +void MediaToolBoxControl::StateChanged( sal_uInt16, SfxItemState eState, const SfxPoolItem* pState, const Item::ItemBase* /*pSlotItem*/ ) { MediaToolBoxControl_Impl* pCtrl = static_cast< MediaToolBoxControl_Impl* >( GetToolBox().GetItemWindow( GetId() ) ); diff --git a/basctl/source/basicide/IDEComboBox.cxx b/basctl/source/basicide/IDEComboBox.cxx index edb312499a4f..1ff980a0baa5 100644 --- a/basctl/source/basicide/IDEComboBox.cxx +++ b/basctl/source/basicide/IDEComboBox.cxx @@ -60,7 +60,7 @@ LibBoxControl::LibBoxControl(sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx) { } -void LibBoxControl::StateChanged(sal_uInt16, SfxItemState eState, const SfxPoolItem* pState, const ::std::unique_ptr& /*rSlotItem*/) +void LibBoxControl::StateChanged(sal_uInt16, SfxItemState eState, const SfxPoolItem* pState, const ::Item::ItemBase* /*pSlotItem*/) { LibBox* pBox = static_cast(GetToolBox().GetItemWindow(GetId())); @@ -337,7 +337,7 @@ LanguageBoxControl::LanguageBoxControl(sal_uInt16 nSlotId, sal_uInt16 nId, ToolB { } -void LanguageBoxControl::StateChanged(sal_uInt16, SfxItemState eState, const SfxPoolItem* pItem, const ::std::unique_ptr& /*rSlotItem*/) +void LanguageBoxControl::StateChanged(sal_uInt16, SfxItemState eState, const SfxPoolItem* pItem, const ::Item::ItemBase* /*pSlotItem*/) { if (LanguageBox* pBox = static_cast(GetToolBox().GetItemWindow(GetId( { diff --git a/basctl/source/inc/IDEComboBox.hxx b/basctl/source/inc/IDEComboBox.hxx index aa67d1d7576e..8b05ecf15ce9 100644 --- a/basctl/source/inc/IDEComboBox.hxx +++ b/basctl/source/inc/IDEComboBox.hxx @@ -60,7 +60,7 @@ public: * @param pState -- */ virtual void StateChanged(sal_uInt16 nSlotID, SfxItemState eState, - const SfxPoolItem* pState, const ::std::unique_ptr& rSlotItem) override; + const SfxPoolItem* pState, const ::Item::ItemBase* pSlotItem) override; /*! * Create combobox of Macro and Dialog Library * @@ -189,7 +189,7 @@ public: * @param pState -- */ virtual void StateChanged(sal_uInt16 nSID, SfxItemState eState, - const SfxPoolItem* pState, const ::std::unique_ptr& rSlotItem) override; + const SfxPoolItem* pState, const ::Item::ItemBase* pSlotItem) override; /*! * Create ComboBox of Language * diff --git a/cui/source/dialogs/cuihyperdlg.cxx b/cui/source/dialogs/cuihyperdlg.cxx index 53c07d4e9115..0bfbe9025d48 100644 --- a/cui/source/dialogs/cuihyperdlg.cxx +++ b/cui/source/dialogs/cuihyperdlg.cxx @@ -57,7 +57,7 @@ void SvxHlinkCtrl::dispose() } void SvxHlinkCtrl::StateChanged( sal_uInt16 nSID, SfxItemState eState, - const SfxPoolItem* pState, const std::unique_ptr& /*rSlotItem*/ ) + const SfxPoolItem* pState, const Item::ItemBase* /*pSlotItem*/ ) { if ( eState == SfxItemState::DEFAULT && !pParent->IsDisposed() ) { diff --git a/cui/source/inc/cuihyperdlg.hxx b/cui/source/inc/cuihyperdlg.hxx index bb7dc8ee05b2..62e9a3f3f6f4 100644 --- a/cui/source/inc/cuihyperdlg.hxx +++ b/cui/source/inc/cuihyperdlg.hxx @@ -61,7 +61,7 @@ public: virtual void dispose() override; virtual voidStateChanged( sal_uInt16 nSID, SfxItemState eState, -const SfxPoolItem* pState, const std::unique_ptr& rSlotItem ) override; +const SfxPoolItem* pState, const Item::ItemBase* pSlotItem ) override; }; diff --git a/include/avmedia/mediatoolbox.hxx b/include/avmedia/mediatoolbox.hxx index a70751ab2d78..cfe7902d6961 100644 --- a/include/avmedia/mediatoolbox.hxx +++ b/include/avmedia/mediatoolbox.hxx @@ -39,7 +39,7 @@ public: MediaToolBoxControl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbX ); virtual ~MediaToolBoxControl() override; -virtual voidStateChanged( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState, const std::unique_ptr& rSlotItem ) override; +virtual
[Libreoffice-bugs] [Bug 125127] FILEOPEN: Support "Wrap Text" Option in Word Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=125127 Luke changed: What|Removed |Added Summary|FILEOPEN: Support "Wrap |FILEOPEN: Support "Wrap |Text" Option in MSO Text|Text" Option in Word Text |Box |Box -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125104] [Ubuntu, Writer] Chaging page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later
https://bugs.documentfoundation.org/show_bug.cgi?id=125104 Xisco Faulí changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Xisco Faulí --- > Additional Info: > Workaround: Rename the document's filename extension from ".odt" to ".zip". > Open "styles.xml" and find an instance of: style:num-format="1st" > Change this to: style:num-format="1" > Update the .zip file with this new change and rename it back to .odt. > It should work without crashing now. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125104] [Ubuntu, Writer] Chaging page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later
https://bugs.documentfoundation.org/show_bug.cgi?id=125104 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #7 from Xisco Faulí --- I can't reproduce it in Version: 6.3.0.0.alpha0+ Build ID: f20810f7829d9f3b7167df316e1303810b746366 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded nor in Versión: 6.2.3.2 Id. de compilación: aecc05fe267cc68dde00352a451aa867b3b546ac Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125127] FILEOPEN: Support "Wrap Text" Option in MSO Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=125127 --- Comment #1 from Luke --- Created attachment 151191 --> https://bugs.documentfoundation.org/attachment.cgi?id=151191=edit Impress correctly handles Wrap option in Text Box Issue is Writer specific -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125127] New: FILEOPEN: Support "Wrap Text" Option in MSO Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=125127 Bug ID: 125127 Summary: FILEOPEN: Support "Wrap Text" Option in MSO Text Box Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lukebe...@hotmail.com Created attachment 151190 --> https://bugs.documentfoundation.org/attachment.cgi?id=151190=edit Example DOCX text boxes with wrap disabled In MS Office, Text Boxes expand horizontally (or vertically with vertical text) when "Wrap Text" Option is not checked to fit the text on a single line. The docx importer does not handling the "Wrap Text" option correctly. Steps to reproduce: 1. Open TexboxWrap.docx in Writer 2. Open in Word 3. Compare The first 2 text boxes should be a single line, as there is no wrapping allowed. The 3rd shows how the resize option will automatically expand the shape vertically. If you roundtrip the file, the "Wrap Text" Option changed to true. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123196] Writer hangs if you Try to Open a Specific DOCX with check box form fields
https://bugs.documentfoundation.org/show_bug.cgi?id=123196 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||104523, 104450 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104450 [Bug 104450] [META] DOCX (OOXML) file opening issues https://bugs.documentfoundation.org/show_bug.cgi?id=104523 [Bug 104523] [META] DOCX (OOXML) ActiveX and Legacy form control related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123196 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123196 [Bug 123196] Writer hangs if you Try to Open a Specific DOCX with check box form fields -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104523] [META] DOCX (OOXML) ActiveX and Legacy form control related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104523 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123196 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123196 [Bug 123196] Writer hangs if you Try to Open a Specific DOCX with check box form fields -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122721] Missing Flat XML format for master odt document
https://bugs.documentfoundation.org/show_bug.cgi?id=122721 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW --- Comment #2 from Dieter Praas --- (In reply to y+documentfoundation.org from comment #1) > Just here to confirm this bug. If you're able to confirm a bug, you are also allowed to change the status to NEW => status NEW, because of comment 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124415] Small memory leak when pasting Chart over and over
https://bugs.documentfoundation.org/show_bug.cgi?id=124415 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||122652 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122652 [Bug 122652] [META] Memory problems in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122652 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||124415 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=124415 [Bug 124415] Small memory leak when pasting Chart over and over -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123869] import .csv with floats and delimiter=pipe is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=123869 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||109236 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109236 [Bug 109236] [META] CSV import bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109236] [META] CSV import bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109236 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123869 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123869 [Bug 123869] import .csv with floats and delimiter=pipe is wrong -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/CppunitTest_sw_apitests.mk sw/inc sw/qa sw/source
sw/CppunitTest_sw_apitests.mk |1 sw/inc/fmtfld.hxx |2 sw/qa/api/SwXTextField.cxx | 89 ++ sw/qa/python/xtext.py |8 + sw/source/core/txtnode/atrfld.cxx |4 sw/source/core/unocore/unofield.cxx | 174 6 files changed, 177 insertions(+), 101 deletions(-) New commits: commit e18359445fabad9ba1a704600e9ee327112cc6ae Author: Bjoern Michaelsen AuthorDate: Sun Apr 14 13:33:35 2019 +0200 Commit: Björn Michaelsen CommitDate: Sun May 5 22:27:54 2019 +0200 [API CHANGE] SwXTextField: no more SwModify/SwClient - fix unittest assuming the double-insertion of annotation throwing an IllegalArgumentException was intentional - remove SwModify/SwClient in SwXTextField - also: add basic C++ api test Change-Id: Ia4657dc65dfadc3e975bdf409bd5e43413ea1f5a Reviewed-on: https://gerrit.libreoffice.org/71452 Tested-by: Jenkins Reviewed-by: Björn Michaelsen diff --git a/sw/CppunitTest_sw_apitests.mk b/sw/CppunitTest_sw_apitests.mk index ca2c919e0aa6..370ed779d8b9 100644 --- a/sw/CppunitTest_sw_apitests.mk +++ b/sw/CppunitTest_sw_apitests.mk @@ -16,6 +16,7 @@ $(eval $(call gb_CppunitTest_use_external,sw_apitests,boost_headers)) $(eval $(call gb_CppunitTest_add_exception_objects,sw_apitests, \ sw/qa/api/SwXDocumentIndex \ sw/qa/api/SwXDocumentSettings \ +sw/qa/api/SwXTextField \ sw/qa/api/SwXTextTable \ )) diff --git a/sw/inc/fmtfld.hxx b/sw/inc/fmtfld.hxx index b144243ec4c9..d9eafeea82a3 100644 --- a/sw/inc/fmtfld.hxx +++ b/sw/inc/fmtfld.hxx @@ -36,7 +36,7 @@ namespace com { namespace sun { namespace star { namespace text { class XTextFie // ATT_FLD class SW_DLLPUBLIC SwFormatField : public SfxPoolItem -, public SwModify +, public sw::BroadcastingModify , public SfxBroadcaster { friend void InitCore(); diff --git a/sw/qa/api/SwXTextField.cxx b/sw/qa/api/SwXTextField.cxx new file mode 100644 index ..1de775d1e3d7 --- /dev/null +++ b/sw/qa/api/SwXTextField.cxx @@ -0,0 +1,89 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include +#include + +#include + +#include + +#include + +#include +#include +#include +#include +#include +#include + +#include + +using namespace css; +using namespace css::uno; +using namespace css::beans; + +namespace +{ +/** + * Initial tests for SwXTextField. + */ +struct SwXTextField final : public test::BootstrapFixture, +public unotest::MacrosTest, +public apitest::XComponent +{ +virtual void setUp() override; + +Reference init() override; +void triggerDesktopTerminate() override; + +CPPUNIT_TEST_SUITE(SwXTextField); +CPPUNIT_TEST(testAddEventListener); +CPPUNIT_TEST(testRemoveEventListener); +//CPPUNIT_TEST(testDisposedByDesktopTerminate); +CPPUNIT_TEST_SUITE_END(); +}; + +void SwXTextField::setUp() +{ +test::BootstrapFixture::setUp(); +mxDesktop.set( + frame::Desktop::create(comphelper::getComponentContext(getMultiServiceFactory(; +} + +void SwXTextField::triggerDesktopTerminate() { mxDesktop->terminate(); } + +Reference SwXTextField::init() +{ +auto xComponent = loadFromDesktop("private:factory/swriter", "com.sun.star.text.TextDocument"); +CPPUNIT_ASSERT(xComponent.is()); +Reference xTextDocument(xComponent, UNO_QUERY_THROW); +Reference xMSF(xComponent, UNO_QUERY_THROW); + +Reference xFieldMaster( +xMSF->createInstance("com.sun.star.text.FieldMaster.Database"), UNO_QUERY_THROW); +xFieldMaster->setPropertyValue("DataBaseName", makeAny(OUString("Address Book File"))); +xFieldMaster->setPropertyValue("DataTableName", makeAny(OUString("address"))); +xFieldMaster->setPropertyValue("DataColumnName", makeAny(OUString("FIRSTNAME"))); + +Reference xField( +xMSF->createInstance("com.sun.star.text.TextField.Database"), UNO_QUERY_THROW); +xField->attachTextFieldMaster(xFieldMaster); +Reference xText = xTextDocument->getText(); +Reference xCursor = xText->createTextCursor(); +Reference xFieldAsContent(xField, UNO_QUERY_THROW); +xText->insertTextContent(xCursor, xFieldAsContent, false); +return Reference(xField, UNO_QUERY_THROW); +} + +CPPUNIT_TEST_SUITE_REGISTRATION(SwXTextField); +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/qa/python/xtext.py b/sw/qa/python/xtext.py index d137cb1f69ce..b8bc25d90e92 100644 --- a/sw/qa/python/xtext.py +++ b/sw/qa/python/xtext.py @@ -37,9 +37,11 @@ class TestXText(unittest.TestCase): # And the
[Libreoffice-bugs] [Bug 109236] [META] CSV import bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109236 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||123055 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=123055 [Bug 123055] CSV database encoded with UTF-8 BOM: First header line value keeps quotes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123055] CSV database encoded with UTF-8 BOM: First header line value keeps quotes
https://bugs.documentfoundation.org/show_bug.cgi?id=123055 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=82 ||254 Blocks||109236 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109236 [Bug 109236] [META] CSV import bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82254] FILESAVE: UTF-8 BOM removed from CSV when saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=82254 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3055 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121859] Wrong convertion to .csv
https://bugs.documentfoundation.org/show_bug.cgi?id=121859 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||109237 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109237 [Bug 109237] [META] CSV export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109237] [META] CSV export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109237 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||121859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121859 [Bug 121859] Wrong convertion to .csv -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119044] Wrong rendering of some symbols in math equations
https://bugs.documentfoundation.org/show_bug.cgi?id=119044 Dieter Praas changed: What|Removed |Added Assignee|opensuse.lietuviu.kalba@gma |libreoffice-b...@lists.free |il.com |desktop.org Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extras/CustomTarget_tploffimisc.mk
extras/CustomTarget_tploffimisc.mk | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) New commits: commit 74ac288132de7046ce25eb4539be6b9a25138399 Author: Laurent BP AuthorDate: Sun Apr 28 14:30:51 2019 +0200 Commit: Laurent BP CommitDate: Sun May 5 22:23:05 2019 +0200 tdf#125010 No compression to mimetype in templates For Offimisc Writer template zip mimetype file with -0 option --filesync option must be removed as it remove mimetype remove unused test of exiting files restore script extras_Tploffimisc_make_file_deps Change-Id: I7851635f483d10bcf179b568250be31d763d60b9 Reviewed-on: https://gerrit.libreoffice.org/71473 Tested-by: Jenkins Reviewed-by: Laurent BP diff --git a/extras/CustomTarget_tploffimisc.mk b/extras/CustomTarget_tploffimisc.mk index 1d684d89de5d..79d4262ff466 100644 --- a/extras/CustomTarget_tploffimisc.mk +++ b/extras/CustomTarget_tploffimisc.mk @@ -27,10 +27,6 @@ extras_OFFIMISC_XMLFILES := \ extras_TPLOFFIMISC_MIMETYPEFILES := $(foreach atexts,$(extras_TEMPLATES_OFFIMISC),$(atexts)/mimetype) -ifneq ($(sort $(foreach file,$(extras_OFFIMISC_XMLFILES),$(wordlist 1, 1, $(subst /, ,$(file),$(sort $(extras_TEMPLATES_OFFIMISC))) -$(call gb_Output_error,defined template text do not match existing directories) -endif - $(call gb_CustomTarget_get_target,extras/source/templates/offimisc) : \ $(foreach atexts,$(extras_TEMPLATES_OFFIMISC),$(call gb_CustomTarget_get_workdir,extras/source/templates/offimisc)/$(atexts).ott) @@ -67,7 +63,8 @@ $(call gb_CustomTarget_get_workdir,extras/source/templates/offimisc)/%.ott : $(call gb_Output_announce,$*.ott,$(true),ZIP,2) $(call gb_Helper_abbreviate_dirs,\ cd $(EXTRAS_OFFIMISC_DIR) && \ - zip -qrX --filesync --must-match $@ $(EXTRAS_OFFIMISC_FILES) \ + zip -q0X --filesync --must-match $@ $(EXTRAS_OFFIMISC_MIMEFILES_FILTER) && \ + zip -qrX --must-match $@ $(EXTRAS_OFFIMISC_XMLFILES_FILTER) \ ) define extras_Tploffimisc_make_file_deps @@ -82,14 +79,16 @@ $(call gb_CustomTarget_get_workdir,$(1))/$(2) : \ | $(dir $(call gb_CustomTarget_get_workdir,$(1))/$(2)).dir $(call gb_CustomTarget_get_workdir,$(1))/$(2) : \ - EXTRAS_OFFIMISC_FILES := $(foreach file,$(filter $(3)/%,$(extras_TPLOFFIMISC_MIMETYPEFILES) $(extras_OFFIMISC_XMLFILES)),$(subst $(3)/,,$(file))) + EXTRAS_OFFIMISC_MIMEFILES_FILTER := $(foreach file,$(filter $(3)/%,$(extras_TPLOFFIMISC_MIMETYPEFILES)),$(subst $(3)/,,$(file))) +$(call gb_CustomTarget_get_workdir,$(1))/$(2) : \ + EXTRAS_OFFIMISC_XMLFILES_FILTER := $(foreach file,$(filter $(3)/%,$(extras_OFFIMISC_XMLFILES)),$(subst $(3)/,,$(file))) $(call gb_CustomTarget_get_workdir,$(1))/$(2) : \ EXTRAS_OFFIMISC_DIR := $(call gb_CustomTarget_get_workdir,$(1))/$(3) endef $(eval $(foreach file,$(extras_TPLOFFIMISC_MIMETYPEFILES) $(extras_OFFIMISC_XMLFILES),\ - $(call extras_Tploffimisc_make_zip_deps,extras/source/templates/offimisc,$(file)) \ + $(call extras_Tploffimisc_make_file_deps,extras/source/templates/offimisc,$(file)) \ )) $(eval $(foreach atexts,$(extras_TEMPLATES_OFFIMISC),\ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 109236] [META] CSV import bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109236 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||125110 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125110 [Bug 125110] CalcSpreadsheet: issues converting .CSV where there are more than 30K rows of data -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125110] CalcSpreadsheet: issues converting .CSV where there are more than 30K rows of data
https://bugs.documentfoundation.org/show_bug.cgi?id=125110 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||109236 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109236 [Bug 109236] [META] CSV import bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 125118] shift-click for absolute reference when entering formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=125118 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107977 OS|Windows (All) |All Hardware|x86-64 (AMD64) |All Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107977 [Bug 107977] [META] Calc feature enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 125118] shift-click for absolute reference when entering formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=125118 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107977 OS|Windows (All) |All Hardware|x86-64 (AMD64) |All Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107977 [Bug 107977] [META] Calc feature enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107977] [META] Calc feature enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107977 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||125118 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125118 [Bug 125118] shift-click for absolute reference when entering formulas -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119044] Wrong rendering of some symbols in math equations
https://bugs.documentfoundation.org/show_bug.cgi?id=119044 opensuse.lietuviu.ka...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |opensuse.lietuviu.kalba@gma |desktop.org |il.com --- Comment #26 from opensuse.lietuviu.ka...@gmail.com --- Created attachment 151188 --> https://bugs.documentfoundation.org/attachment.cgi?id=151188=edit LibreOffice 6.3.0.0.alpha0+ (2019-05-04 build) in openSUSE Linux Yes, I still can reproduce in openSUSE 15.0 64 bit Linux system (where Microsoft fonts are not native) in LibreOffice version: Version: 6.3.0.0.alpha0+ Build ID: 98630a0bd49bd80652145a21e4e0d0ded792b36b CPU threads: 1; OS: Linux 4.12; UI render: default; VCL: kde5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-04_04:44:35 Locale: lt-LT (lt_LT.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119044] Wrong rendering of some symbols in math equations
https://bugs.documentfoundation.org/show_bug.cgi?id=119044 opensuse.lietuviu.ka...@gmail.com changed: What|Removed |Added OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119044] Wrong rendering of some symbols in math equations
https://bugs.documentfoundation.org/show_bug.cgi?id=119044 --- Comment #25 from opensuse.lietuviu.ka...@gmail.com --- @Dieter Praas, You will not be able reproduce, because you use Windows. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124455] EDITING: Edit Index Entry impossible for 1st key in alphabetical index
https://bugs.documentfoundation.org/show_bug.cgi?id=124455 --- Comment #3 from gilbert.sn...@yahoo.fr --- I controled a text file I created before july 2016 (I don't remember exactly when, where the key words have been entered. When I want to edit the entries the key words do not appear. Though when I create a new lexical index in that document, it uses the key words as if I just had entered them. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40563] FORMATTING hyperlinks do not word wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=40563 --- Comment #14 from Heinz --- Problem still exists in LO 6.2.3.2 (on Arch Linux), see today's screenshot. This is also very annoying in bibliography slides in LO Impress. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40563] FORMATTING hyperlinks do not word wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=40563 --- Comment #13 from Heinz --- Created attachment 151187 --> https://bugs.documentfoundation.org/attachment.cgi?id=151187=edit Demo screenshot of LO Calc 6.2.3.2 on Arch Linix -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124455] EDITING: Edit Index Entry impossible for 1st key in alphabetical index
https://bugs.documentfoundation.org/show_bug.cgi?id=124455 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de, ||gollum...@gmail.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisectRequest --- Comment #2 from Dieter Praas --- (In reply to gilbert.sn...@yahoo.fr from comment #1) > I encounter the same problem on my version of LibreOffice (6.2.2) on Linux > Debian AND64 9.8.0. Impossible to fill the two boxes. I am not sure it > worked on 6.1.5, but I think it workes on old versions like 5.x. > I asked for a solution on LibreOffice site (libreoffice.org). My question is > in French, its title is "Impossible de saisir les mots clefs à la création > d'une entrée d'index sur writer" Gilbert, if you're able to reproduce a bug, you are allowed to change status to NEW => I change status to NEW because of comment 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125124] How Can I Install Help for a Development Build of LO?
https://bugs.documentfoundation.org/show_bug.cgi?id=125124 --- Comment #2 from Adalbert Hanßen --- I followed your advice and posted https://ask.libreoffice.org/de/question/192756/vergeblicher-versuch-hilfe-zur-entwicklerversion-zu-installieren/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125110] CalcSpreadsheet: issues converting .CSV where there are more than 30K rows of data
https://bugs.documentfoundation.org/show_bug.cgi?id=125110 --- Comment #7 from Mike Kaganski --- (In reply to Julien Nabet from comment #4) > Let's take the original line for example: > 6005347055939,5498,,"PUSH PINS" 1`S, 1`S,14205,Inactive,False,False Let me describe my idea about what happens now, and what should happen instead. IIUC, when LO sees string separator (double quote) in the beginning of a field (start of line, or right after field separator), it enters "quote-enclosed field" mode. It expects the field to end with another double quote *exactly in the end-of-field position* (i.e., followed by a newline or field separator). And it continues consuming everything, until it finds such a specially-positioned double quote. For the sample above, it means that the closing double quote after PINS will be consumed without terminating the "quote-enclosed field" mode (because it's followed by space, not by end-of-field); and it will not find a suitable double quote until EOF. But the non-escaped double quote in the middle of a field is not valid for proper quote-enclosed field! But let's modify the sample a little: > 6005347055939,5498,,PUSH "PINS" 1`S, 1`S,14205,Inactive,False,False The first double quote now isn't in the beginning of the field. And LibreOffice treats it as a normal field character, properly finding the end of field, producing the field 'PUSH "PINS" 1`S'. Now recall that CSV has been used without any formal description for decades before RFC 4180 came; and the latter standard is a best effort to organize "best practices", but it cannot simply undo all the pre-existing history - so what is true for initially-formally-defined standards ("be strict when generating; be forgiving when consuming") is tenfold true for CSV. So I suppose that what should have been done here is: 1. Seeing the opening double quote in the beginning of the field, start "quote-enclosed field" mode. 2. If it encounters something *invalid* for such a mode, it should re-read the field again, this time without the "quote-enclosed field" mode (to properly re-consume possible field separators that could had been read in the first pass as the quoted field content). This way, this sample would be read properly, without introducing any ambiguity. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46817] Screen font anti-aliasing does not work (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=46817 --- Comment #48 from Petr Kraus --- OK, I retested a bit (with Impress 6.2.3.2). The Windows High DPI (150 %) setting seems OK enough. I think it is bit blurry though... With no option the text gets AA with subpixel technique. The HW accelleration option does nothing wrt output. The antialiasing option does nothing with text (text is AA even if off). It changes some graphic elements though. Enabling the OpenGL option breaks things. It tries to (single color; non-subpixel) antialias it, but it seems it does it wrong. It looks like it does not use the vector fonts correctly. Or the AA does not work in y direction or something. If I export it as PDF, my reader also whole-pixel antialias, but it still looks right. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124999] Notebook Bar sluggish when window is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=124999 --- Comment #2 from Vrajaraja Govinda Das --- Version: 6.2.2.2 Build ID: 1:6.2.2-0ubuntu0.16.04.1~lo1 CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: en-IN (en_US.UTF-8); UI-Language: en-US OpenGL was disabled already. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - starmath/source
starmath/source/toolbox.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b0a43fc66fdc2a4aacff989de7c3d5034a917b69 Author: Matthias Seidel AuthorDate: Sun May 5 17:45:04 2019 + Commit: Matthias Seidel CommitDate: Sun May 5 17:45:04 2019 + Set initial size to 5 lines for math toolbox diff --git a/starmath/source/toolbox.cxx b/starmath/source/toolbox.cxx index bcbfa00b8f67..45a7c8f22dda 100644 --- a/starmath/source/toolbox.cxx +++ b/starmath/source/toolbox.cxx @@ -256,7 +256,7 @@ void SmToolBoxWindow::StateChanged( StateChangedType nStateChange ) void SmToolBoxWindow::AdjustPosSize( sal_Bool bSetPos ) { Size aCatSize( aToolBoxCat.CalcWindowSizePixel( 2 ) ); -Size aCmdSize( pToolBoxCmd->CalcWindowSizePixel( 4 /* see nLines in SetCategory */ ) ); +Size aCmdSize( pToolBoxCmd->CalcWindowSizePixel( 5 /* see nLines in SetCategory */ ) ); DBG_ASSERT( aCatSize.Width() == aCmdSize.Width(), "width mismatch" ); // catalog settings @@ -324,7 +324,7 @@ void SmToolBoxWindow::SetCategory(sal_uInt16 nCategoryRID) // check for valid resource id switch (nCategoryRID) { -case RID_UNBINOPS_CAT : nLines = 4; break; +case RID_UNBINOPS_CAT : nLines = 5; break; case RID_RELATIONS_CAT: nLines = 5; break; case RID_SETOPERATIONS_CAT: nLines = 5; break; case RID_FUNCTIONS_CAT: nLines = 5; break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'libreoffice-6-1' - 8 commits - common/Png.hpp configure.ac loleaflet/js loleaflet/src net/Socket.hpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/LOOLWSD
common/Png.hpp|6 + configure.ac |2 - loleaflet/js/toolbar.js | 12 --- loleaflet/src/map/handler/Map.Keyboard.js | 23 ++--- net/Socket.hpp|6 - wsd/DocumentBroker.cpp| 23 +++-- wsd/DocumentBroker.hpp| 21 +++ wsd/LOOLWSD.cpp | 32 ++ 8 files changed, 90 insertions(+), 35 deletions(-) New commits: commit e340f89a8b80fdfe592beb2d066d7e187ba98bf5 Author: Andras Timar AuthorDate: Sun May 5 19:36:37 2019 +0200 Commit: Andras Timar CommitDate: Sun May 5 19:36:37 2019 +0200 Bump version to 6.1.6.2 Change-Id: I353dd5f90a63d3ce43f0fc9ed558d83414d586a2 diff --git a/configure.ac b/configure.ac index d18186a24..f1f592e9c 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.63]) -AC_INIT([libreoffice-online], [6.1.3.2], [libreoffice@lists.freedesktop.org]) +AC_INIT([libreoffice-online], [6.1.6.2], [libreoffice@lists.freedesktop.org]) LT_INIT([shared, disable-static, dlopen]) AM_INIT_AUTOMAKE([1.10 subdir-objects tar-pax -Wno-portability]) commit a71683d5b3ac978b22cf4c331ae1e8a15486ccdd Author: Iván Sánchez Ortega AuthorDate: Thu May 2 09:28:55 2019 +0200 Commit: Andras Timar CommitDate: Sun May 5 19:34:02 2019 +0200 tdf#124749:loleaflet: use "KeyboardEvent.key" to detect ignored key events Replace KeyboardEvent.keyCode with KeyboardEvent.key for detection of "Delete" and "Insert" keys. keyCode misbehaves when using an AZERTY/DVORAK keyboard layout, e.g. the keyCode for "Delete" in QWERTY is the same as "." in AZERTY. This works on all major browsers, the only outlier being MSIE8: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key#Browser_compatibility Change-Id: I5cbfa18ef59ab4989a866fdf4b5708610beccaad Reviewed-on: https://gerrit.libreoffice.org/71735 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/loleaflet/src/map/handler/Map.Keyboard.js b/loleaflet/src/map/handler/Map.Keyboard.js index b0d309527..385007920 100644 --- a/loleaflet/src/map/handler/Map.Keyboard.js +++ b/loleaflet/src/map/handler/Map.Keyboard.js @@ -181,16 +181,23 @@ L.Map.Keyboard = L.Handler.extend({ this._map.off('compositionstart compositionupdate compositionend textInput', this._onKeyDown, this); }, + /* +* Returns true whenever the key event shall be ignored. +* This means shift+insert and shift+delete (or "insert or delete when holding +* shift down"). Those events are handled elsewhere to trigger "cut" and +* "paste" events, and need to be ignored in order to avoid double-handling them. +*/ _ignoreKeyEvent: function(e) { - var shift = e.originalEvent.shiftKey ? this.keyModifier.shift : 0; - if (shift && (e.originalEvent.keyCode === 45 || e.originalEvent.keyCode === 46)) { - // don't handle shift+insert, shift+delete - // These are converted to 'cut', 'paste' events which are - // automatically handled by us, so avoid double-handling - return true; + var shift = e.originalEvent.shiftKey; + if ('key' in e.originalEvent) { + var key = e.originalEvent.key; + return (shift && (key === 'Delete' || key === 'Insert')); + } else { + // keyCode is not reliable in AZERTY/DVORAK keyboard layouts, is used + // only as a fallback for MSIE8. + var keyCode = e.originalEvent.keyCode; + return (shift && (keyCode === 45 || keyCode === 46)); } - - return false; }, _setPanOffset: function (pan) { commit 9498edfea92f255699475adc6173390ad027caef Author: Ashod Nakashian AuthorDate: Fri Apr 19 20:09:22 2019 -0400 Commit: Andras Timar CommitDate: Sun May 5 19:31:39 2019 +0200 wsd: use fast deflate level for png The default deflate level of 6 is quite slow and the benefits are hardly worth the high latency that users experience. Tested on a writer document with some small images and a few pages of text: Level 4 gives virtually identical compression ratio to level 6, but is between 5-10% faster. Level 3 runs almost twice as fast as level 6, but the output is typically 2-3x larger. Perhaps this should be exposed via config so it would be possible to reduce latency due to compression when CPU is scarce but network bandwidth ample, and vice versa. Change-Id: Iba88eea8f180d11458b33c68389e797234df1a60 Reviewed-on:
[Libreoffice-bugs] [Bug 124749] Dot character can't be entered with French AZERTY layout, in dialogs or in documents when using Firefox
https://bugs.documentfoundation.org/show_bug.cgi?id=124749 --- Comment #4 from Commit Notification --- Iván Sánchez Ortega committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/online/+/a71683d5b3ac978b22cf4c331ae1e8a15486ccdd%5E%21 tdf#124749:loleaflet: use "KeyboardEvent.key" to detect ignored key events -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124749] Dot character can't be entered with French AZERTY layout, in dialogs or in documents when using Firefox
https://bugs.documentfoundation.org/show_bug.cgi?id=124749 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0|target:6.3.0 target:6.1.0.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Changes to 'refs/tags/libreoffice-6.1.6.2'
Tag 'libreoffice-6.1.6.2' created by Andras Timar at 2019-05-05 17:51 + libreoffice-6.1.6.2 Changes since libreoffice-6.1.3.2-9: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 46817] Screen font anti-aliasing does not work (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=46817 --- Comment #47 from Petr Kraus --- PS: It is not obvious what the options even do. Certainly not for average user. There's some room for improvement there too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46817] Screen font anti-aliasing does not work (Windows)
https://bugs.documentfoundation.org/show_bug.cgi?id=46817 --- Comment #46 from Petr Kraus --- Seems fine to me now, except when OpenGL is enabled. Maybe it is only a matter of forbidding OpenGL support on Windows (at least till we recruit that superprogrammer). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/chart/SchXMLTableContext.cxx | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) New commits: commit ddd5587d48eb685cbfc1106f694fb6b582fac6b8 Author: Arkadiy Illarionov AuthorDate: Sun May 5 19:14:24 2019 +0300 Commit: Noel Grandin CommitDate: Sun May 5 19:24:18 2019 +0200 Drop lcl_SequenceToVector in favor of comphelper::sequenceToContainer Change-Id: I86284553e1b0229d0b576ef1d92efd040b524a1b Reviewed-on: https://gerrit.libreoffice.org/71825 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/xmloff/source/chart/SchXMLTableContext.cxx b/xmloff/source/chart/SchXMLTableContext.cxx index cb0423c92976..996f2b82c287 100644 --- a/xmloff/source/chart/SchXMLTableContext.cxx +++ b/xmloff/source/chart/SchXMLTableContext.cxx @@ -196,14 +196,6 @@ bool lcl_tableOfRangeMatches( (rRange.indexOf( rTableName ) != -1 )); } -template< typename T > -::std::vector< T > lcl_SequenceToVector( const uno::Sequence< T > & rSequence ) -{ -::std::vector< T > aResult( rSequence.getLength()); -::std::copy( rSequence.begin(), rSequence.end(), aResult.begin()); -return aResult; -} - } // anonymous namespace // class SchXMLTableContext @@ -298,7 +290,7 @@ void SchXMLTableContext::EndElement() if( mbHasColumnPermutation ) { SAL_WARN_IF( mbHasRowPermutation, "xmloff.chart", "mbHasColumnPermutation is true" ); -::std::vector< sal_Int32 > aPermutation( lcl_SequenceToVector( maColumnPermutation )); +auto aPermutation( comphelper::sequenceToContainer>( maColumnPermutation )); SAL_WARN_IF( aPermutation.empty(), "xmloff.chart", "aPermutation is NULL"); if( aPermutation.empty()) return; @@ -338,7 +330,7 @@ void SchXMLTableContext::EndElement() } else if( mbHasRowPermutation ) { -::std::vector< sal_Int32 > aPermutation( lcl_SequenceToVector( maRowPermutation )); +auto aPermutation( comphelper::sequenceToContainer>( maRowPermutation )); SAL_WARN_IF( aPermutation.empty(), "xmloff.chart", "aPermutation is NULL"); if( aPermutation.empty()) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124937] crash when trying to open a .doc file
https://bugs.documentfoundation.org/show_bug.cgi?id=124937 Mark Hung changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mark...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125119] preview selected font in selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=125119 --- Comment #2 from Paul G. --- Well, I didnt knew that, thanks, but still, this is not a nice "live preview". The intention was to have a text preview in the actual document to get a glimpse how the text would look in the page rather than in an isolated extra window. And I really miss the simplicity of just scrolling through the font list with my mousewheel and watching the font change without to have press enter to activate the font. Same applies to font size selection box. If I mousewheel scroll through the sizes I then have to press enter to apply the size... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125122] LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 --- Comment #6 from Olaf Hautow --- Thank you very much. All the best for you! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124908] Widows and Orphans Control Does Not Work as Expected for Paragraphs in Tables (Formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=124908 Adalbert Hanßen changed: What|Removed |Added Attachment #150947|0 |1 is obsolete|| --- Comment #1 from Adalbert Hanßen --- Created attachment 151186 --> https://bugs.documentfoundation.org/attachment.cgi?id=151186=edit Augmented Samplemade to easily reproduce and study the buggy behaviour, with screenshots taken with development version of 2019-05-04 I have checked if the bug is still in the current development version: Unfortunately it is. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125122] LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 Julien Nabet changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #5 from Julien Nabet --- "WFM" for "Works For Me". Let's close this one completely then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125122] LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 --- Comment #4 from Olaf Hautow --- Excuse me, my English is not very good. What do you mean with WFM? I wanted mark this problem as soluted. But I cannot find where I can do it. Shall I put the status on closed? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Bug 104442 depends on bug 115813, which changed state. Bug 115813 Summary: Position shifted while moving the handle of OOXML Callout shape https://bugs.documentfoundation.org/show_bug.cgi?id=115813 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125124] How Can I Install Help for a Development Build of LO?
https://bugs.documentfoundation.org/show_bug.cgi?id=125124 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Dieter Praas --- Adalbert, your question is not a bug. Please use Ask LibreOffice (https://ask.libreoffice.org/de/questions/) or the german mailing list us...@de.libreoffice.org. I suppose you will get an answer sooner than in Bugzilla. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125126] New: Polar handle of OOXML preset shapes do not act as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=125126 Bug ID: 125126 Summary: Polar handle of OOXML preset shapes do not act as expected Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 151185 --> https://bugs.documentfoundation.org/attachment.cgi?id=151185=edit All preset custom shapes with polar handles to test the behavior Open attached document. It was generated by SoftMaker 2016. The same error exists with documents generated by PowerPoint. It does not exist, if our own shapes are used. The first three shapes ('arc', 'pie' and 'chord') should work correctly. They are included to make sure a patch will not introduce regressions. The shape 'notEqual' has the error, that the top handle, which should alter the angle for the vertical bar, is not moveable. The shapes 'noSmoking', 'donut' and 'blockArc' show the error, that the thickness of the shape outline changes in opposite direction as the handle movement. The circular arrow shapes have a correct handle at the end. But the three handles at the arrow tip show jumping handles and outline changes in wrong direction. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125100] EDITING: Insert OLE Object behaves different if new document is generated from template
https://bugs.documentfoundation.org/show_bug.cgi?id=125100 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW --- Comment #4 from Dieter Praas --- Set to NEW because of comment 3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125117] EDIT: Table of Contens (TOC) spanning more than page: Only the first page of the TOC can successfully be assigned to the page style „Index“
https://bugs.documentfoundation.org/show_bug.cgi?id=125117 Dieter Praas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #3 from Dieter Praas --- I had a look at your document, and it just works as expected: Page style "Index" has "Default Style" as next style. So just change next style to "Index" and add a new page break with style "Default Style" after yout TOC. => RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/oslendian.cxx | 17 + 1 file changed, 17 insertions(+) New commits: commit acd8ee107f336d629782956350ed3981ca302024 Author: Luboš Luňák AuthorDate: Mon Apr 29 22:39:00 2019 +0200 Commit: Luboš Luňák CommitDate: Sun May 5 17:44:48 2019 +0200 avoid false warnings from oslendian clang plugin if PCH is used Change-Id: I3ab8371b14068601995616dc9979a3297313d761 Reviewed-on: https://gerrit.libreoffice.org/71563 Tested-by: Jenkins Reviewed-by: Luboš Luňák diff --git a/compilerplugins/clang/oslendian.cxx b/compilerplugins/clang/oslendian.cxx index 3cb1adbe3da0..13296330baf6 100644 --- a/compilerplugins/clang/oslendian.cxx +++ b/compilerplugins/clang/oslendian.cxx @@ -25,6 +25,22 @@ public: private: void run() override {} +virtual void FileChanged(SourceLocation, FileChangeReason, SrcMgr::CharacteristicKind, FileID) override { +if(!startChecked) { +// With precompiled headers MacroDefined() would not be called, so check already at the very +// start whether the macros exist. +startChecked = true; +if(const MacroInfo* macroBig = compiler.getPreprocessor().getMacroInfo( + ().getIdentifierTable().get("OSL_BIGENDIAN"))) { +definedBig_ = macroBig->getDefinitionLoc(); +} +if(const MacroInfo* macroLit = compiler.getPreprocessor().getMacroInfo( + ().getIdentifierTable().get("OSL_LITENDIAN"))) { +definedLit_ = macroLit->getDefinitionLoc(); +} +} +} + void MacroDefined(Token const & MacroNameTok, MacroDirective const *) override { @@ -107,6 +123,7 @@ private: SourceLocation definedBig_; SourceLocation definedLit_; +bool startChecked = false; }; loplugin::Plugin::Registration X("oslendian"); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bridges/Library_cpp_uno.mk external/curl external/firebird external/gpgmepp external/harfbuzz external/icu external/liblangtag
bridges/Library_cpp_uno.mk|2 +- external/curl/ExternalProject_curl.mk |2 +- external/firebird/ExternalProject_firebird.mk |2 +- external/gpgmepp/ExternalProject_gpgmepp.mk |6 +++--- external/harfbuzz/ExternalProject_harfbuzz.mk |2 +- external/icu/ExternalProject_icu.mk |4 ++-- external/liblangtag/ExternalProject_liblangtag.mk |2 +- 7 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 1334c2bf93a4ea7168718a3a2678fbf9848ec469 Author: Stephan Bergmann AuthorDate: Sat May 4 17:48:51 2019 +0200 Commit: Luboš Luňák CommitDate: Sun May 5 17:43:11 2019 +0200 Fix remaining uses of gb_SYMBOL ...after c33ada5923f1f534334b22c15d6e2c6f1d35 "merge --enable-selective-debuginfo into --enable-symbols" had removed it Change-Id: I83aed6e21c4b983d8645707daa65bd85ec16ff6b Reviewed-on: https://gerrit.libreoffice.org/71798 Tested-by: Jenkins Reviewed-by: Luboš Luňák diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk index 421483f08f42..eded406d3f35 100644 --- a/bridges/Library_cpp_uno.mk +++ b/bridges/Library_cpp_uno.mk @@ -219,7 +219,7 @@ bridges_NON_CALL_EXCEPTIONS_FLAGS := -fnon-call-exceptions endif endif -bridges_DEBUGINFO_FLAGS := $(if $(filter $(true),$(gb_SYMBOL)),$(gb_DEBUGINFO_FLAGS)) +bridges_DEBUGINFO_FLAGS := $(if $(call gb_LinkTarget__symbols_enabled,Library_$(gb_CPPU_ENV)_uno),$(gb_DEBUGINFO_FLAGS)) $(eval $(call gb_Library_use_libraries,$(gb_CPPU_ENV)_uno,\ cppu \ diff --git a/external/curl/ExternalProject_curl.mk b/external/curl/ExternalProject_curl.mk index 86e22aa2fa19..366ff1e39d95 100644 --- a/external/curl/ExternalProject_curl.mk +++ b/external/curl/ExternalProject_curl.mk @@ -78,7 +78,7 @@ $(call gb_ExternalProject_get_state_target,curl,build): mode=dll \ VC=12 \ $(if $(filter X86_64,$(CPUNAME)),MACHINE=x64,MACHINE=x86) \ - GEN_PDB=$(if $(gb_SYMBOL),yes,no) \ + GEN_PDB=$(if $(call gb_Module__symbols_enabled,curl),yes,no) \ DEBUG=$(if $(MSVC_USE_DEBUG_RUNTIME),yes,no) \ ENABLE_IPV6=yes \ ENABLE_SSPI=yes \ diff --git a/external/firebird/ExternalProject_firebird.mk b/external/firebird/ExternalProject_firebird.mk index 3b444397442d..a70a53d0e9d5 100644 --- a/external/firebird/ExternalProject_firebird.mk +++ b/external/firebird/ExternalProject_firebird.mk @@ -74,7 +74,7 @@ $(call gb_ExternalProject_get_state_target,firebird,build): ) \ $(CXXFLAGS_CXX11) \ $(firebird_NO_CXX11_NARROWING) \ - $(if $(filter $(true),$(gb_SYMBOL)),$(gb_DEBUGINFO_FLAGS)) \ + $(if $(call gb_Module__symbols_enabled,firebird),$(gb_DEBUGINFO_FLAGS)) \ " \ && export LDFLAGS=" \ $(if $(SYSTEM_ICU),$(ICU_LIBS), \ diff --git a/external/gpgmepp/ExternalProject_gpgmepp.mk b/external/gpgmepp/ExternalProject_gpgmepp.mk index 6ee9b568980b..8ecdf60e6f87 100644 --- a/external/gpgmepp/ExternalProject_gpgmepp.mk +++ b/external/gpgmepp/ExternalProject_gpgmepp.mk @@ -37,7 +37,7 @@ $(call gb_ExternalProject_get_state_target,gpgmepp,build): $(call gb_Executable_ CFLAGS='$(CFLAGS) \ $(if $(ENABLE_OPTIMIZED), \ $(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS)) \ - $(if $(filter $(true),$(gb_SYMBOL)),$(gb_DEBUGINFO_FLAGS))' \ + $(if $(call gb_Module__symbols_enabled,gpgmepp),$(gb_DEBUGINFO_FLAGS))' \ --host=$(gb_ExternalProject_gpgmepp_host) \ RC='windres -O COFF --target=$(gb_ExternalProject_gpgmepp_target) --preprocessor='\''$(call gb_Executable_get_target,cpp) -+ -DRC_INVOKED -DWINAPI_FAMILY=0 $(SOLARINC)'\' \ MAKE=$(MAKE) \ @@ -57,12 +57,12 @@ $(call gb_ExternalProject_get_state_target,gpgmepp,build): CFLAGS='$(CFLAGS) \ $(if $(ENABLE_OPTIMIZED), \ $(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS)) \ - $(if $(filter $(true),$(gb_SYMBOL)),$(gb_DEBUGINFO_FLAGS))' \ + $(if $(call gb_Module__symbols_enabled,gpgmepp),$(gb_DEBUGINFO_FLAGS))' \ CXXFLAGS='$(CXXFLAGS) \ $(if $(ENABLE_OPTIMIZED), \ $(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS)) \ $(if $(ENABLE_DBGUTIL),-D_GLIBCXX_DEBUG) \ - $(if $(filter $(true),$(gb_SYMBOL)),$(gb_DEBUGINFO_FLAGS))' \ + $(if
[Libreoffice-bugs] [Bug 124406] Dropdown list of formulaes in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=124406 --- Comment #1 from Ettore Atalan --- I would like this feature, too. See description about this feature in Excel: https://support.office.com/en-ie/article/use-formula-autocomplete-6d13daa5-e003-4431-abab-9edef51fae6b -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/item_refactor2' - 2 commits - avmedia/source basctl/source cui/source include/avmedia include/item include/sfx2 include/svx item/Library_item.mk item/so
avmedia/source/framework/mediatoolbox.cxx |2 basctl/source/basicide/IDEComboBox.cxx |4 basctl/source/basicide/basides1.cxx | 92 - basctl/source/basicide/bastype2.cxx | 26 basctl/source/basicide/moduldl2.cxx | 26 basctl/source/basicide/moduldlg.cxx | 104 - basctl/source/basicide/sbxitem.cxx | 72 basctl/source/inc/IDEComboBox.hxx |4 basctl/source/inc/sbxitem.hxx | 64 cui/source/dialogs/cuihyperdlg.cxx |2 cui/source/inc/cuihyperdlg.hxx |2 cui/source/tabpages/swpossizetabpage.cxx|8 include/avmedia/mediatoolbox.hxx|2 include/item/base/ItemAdministrator.hxx | 171 -- include/item/base/ItemBase.hxx | 147 - include/item/base/ItemBuffered.hxx | 101 + include/item/base/ItemControlBlock.hxx | 38 include/item/base/ItemSet.hxx | 83 - include/item/base/ModelSpecificItemValues.hxx | 10 include/item/simple/CntInt16.hxx| 19 include/item/simple/CntOUString.hxx | 18 include/sfx2/ctrlitem.hxx |4 include/sfx2/dispatch.hxx |4 include/sfx2/msg.hxx| 14 include/sfx2/sfxstatuslistener.hxx |6 include/sfx2/sidebar/ControllerItem.hxx |2 include/sfx2/stbitem.hxx|2 include/sfx2/tbxctrl.hxx|2 include/sfx2/unoctitm.hxx |2 include/svx/ParaSpacingControl.hxx |4 include/svx/bmpmask.hxx |2 include/svx/clipboardctl.hxx|2 include/svx/fillctrl.hxx|2 include/svx/float3d.hxx |4 include/svx/fontwork.hxx|2 include/svx/formatpaintbrushctrl.hxx|2 include/svx/grafctrl.hxx|4 include/svx/imapdlg.hxx |2 include/svx/insctrl.hxx |2 include/svx/item/TransformAnchor.hxx| 12 include/svx/layctrl.hxx |4 include/svx/lboxctrl.hxx|2 include/svx/linectrl.hxx|4 include/svx/modctrl.hxx |2 include/svx/pszctrl.hxx |2 include/svx/selctrl.hxx |2 include/svx/tbcontrl.hxx|4 include/svx/tbxctl.hxx |2 include/svx/verttexttbxctrl.hxx |2 include/svx/xmlsecctrl.hxx |2 include/svx/zoomctrl.hxx|2 include/svx/zoomsliderctrl.hxx |2 item/Library_item.mk|1 item/source/base/ItemAdministrator.cxx | 183 -- item/source/base/ItemBase.cxx | 188 -- item/source/base/ItemBuffered.cxx | 166 ++ item/source/base/ItemControlBlock.cxx | 42 item/source/base/ItemSet.cxx| 138 + item/source/base/ModelSpecificItemValues.cxx| 38 item/source/simple/CntInt16.cxx | 54 item/source/simple/CntOUString.cxx | 54 item/test/ItemTest.cxx | 1595 ++-- reportdesign/source/ui/misc/statusbarcontroller.cxx |6 sc/inc/NumberFormatControl.hxx |2 sc/source/ui/cctrl/tbzoomsliderctrl.cxx |2 sc/source/ui/inc/navcitem.hxx |2 sc/source/ui/inc/tbzoomsliderctrl.hxx |2 sc/source/ui/navipi/navcitem.cxx|2 sc/source/ui/sidebar/NumberFormatControl.cxx|2 sd/source/ui/app/tmplctrl.cxx |2 sd/source/ui/dlg/animobjs.cxx |2 sd/source/ui/dlg/diactrl.cxx|2 sd/source/ui/dlg/gluectrl.cxx |4 sd/source/ui/dlg/navigatr.cxx |4 sd/source/ui/inc/animobjs.hxx |2 sd/source/ui/inc/diactrl.hxx|2 sd/source/ui/inc/gluectrl.hxx |2 sd/source/ui/inc/navigatr.hxx |4 sd/source/ui/inc/tmplctrl.hxx |2 sd/source/ui/view/sdruler.cxx |4 sfx2/inc/inettbc.hxx|2
[Libreoffice-bugs] [Bug 125125] New: Undoing autoformat does not preserve text
https://bugs.documentfoundation.org/show_bug.cgi?id=125125 Bug ID: 125125 Summary: Undoing autoformat does not preserve text Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: davian...@gmail.com If typing a certain character like * has caused the autoformat to be applied, undoing it does not restore the typed character. Autoformat should make two undo actions: for typing the trigger character, and the formatting itself. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125018] latest alpha version does not start up at all
https://bugs.documentfoundation.org/show_bug.cgi?id=125018 --- Comment #7 from MM --- Yep, it works for me with Version: 6.3.0.0.alpha0+ Build ID: 98630a0bd49bd80652145a21e4e0d0ded792b36b CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-04_04:44:35 Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - starmath/source
starmath/source/toolbox.cxx | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) New commits: commit b530338b6f4b1cdd8aed2d431ee5df0fa418bba3 Author: Matthias Seidel AuthorDate: Sun May 5 12:49:15 2019 + Commit: Matthias Seidel CommitDate: Sun May 5 12:49:15 2019 + Enable forgotten 5th line for math toolbox diff --git a/starmath/source/toolbox.cxx b/starmath/source/toolbox.cxx index fc630a67999f..bcbfa00b8f67 100644 --- a/starmath/source/toolbox.cxx +++ b/starmath/source/toolbox.cxx @@ -248,7 +248,7 @@ void SmToolBoxWindow::StateChanged( StateChangedType nStateChange ) AdjustPosSize( bSetPosition ); bSetPosition = sal_False; } -//... otherwise the base class will remember the last position of the window +// ... otherwise the base class will remember the last position of the window SfxFloatingWindow::StateChanged( nStateChange ); } @@ -256,7 +256,7 @@ void SmToolBoxWindow::StateChanged( StateChangedType nStateChange ) void SmToolBoxWindow::AdjustPosSize( sal_Bool bSetPos ) { Size aCatSize( aToolBoxCat.CalcWindowSizePixel( 2 ) ); -Size aCmdSize( pToolBoxCmd->CalcWindowSizePixel( 4 /* see nLines in SetCategory*/ ) ); +Size aCmdSize( pToolBoxCmd->CalcWindowSizePixel( 4 /* see nLines in SetCategory */ ) ); DBG_ASSERT( aCatSize.Width() == aCmdSize.Width(), "width mismatch" ); // catalog settings @@ -325,13 +325,13 @@ void SmToolBoxWindow::SetCategory(sal_uInt16 nCategoryRID) switch (nCategoryRID) { case RID_UNBINOPS_CAT : nLines = 4; break; -case RID_RELATIONS_CAT: nLines = 4; break; -case RID_SETOPERATIONS_CAT: nLines = 4; break; -case RID_FUNCTIONS_CAT: nLines = 4; break; +case RID_RELATIONS_CAT: nLines = 5; break; +case RID_SETOPERATIONS_CAT: nLines = 5; break; +case RID_FUNCTIONS_CAT: nLines = 5; break; case RID_OPERATORS_CAT: nLines = 3; break; -case RID_ATTRIBUTES_CAT:nLines = 4; break; +case RID_ATTRIBUTES_CAT:nLines = 5; break; case RID_MISC_CAT: nLines = 4; break; -case RID_BRACKETS_CAT: nLines = 4; break; +case RID_BRACKETS_CAT: nLines = 5; break; case RID_FORMAT_CAT:nLines = 3; break; default: // nothing to be done @@ -397,4 +397,3 @@ SmToolBoxWrapper::SmToolBoxWrapper(Window *pParentWindow, ((SfxFloatingWindow *)pWindow)->Initialize(pInfo); } - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Question about submitting patch for dictionaries
I gave a try to https://wiki.documentfoundation.org/Development/Submodules but it finally really pushed directly the patch. However, I had also took a look to the content of loggerrit and saw that "submit" was calling "push". So I'm a bit confused... If my patch is wrong, don't hesitate to revert it cause I'm not even sure to know how to revert this. "dictionaries" part is really not clear for me. -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 170fe2bffdd74c611eb8e9d96668a6680cd949ae Author: Julien Nabet AuthorDate: Sun May 5 14:10:40 2019 +0200 Commit: Gerrit Code Review CommitDate: Sun May 5 16:03:44 2019 +0200 Update git submodules * Update dictionaries from branch 'master' - Fix logo management for "ca" Thread 1 "soffice.bin" hit Breakpoint 1, (anonymous namespace)::GraphicProvider::queryGraphic (this=0x5b446140, rMediaProperties=uno::Sequence of length 1 = {...}) at /home/julien/lo/libreoffice/vcl/source/graphic/UnoGraphicProvider.cxx:430 430 SAL_WARN("svtools", "Could not create graphic: " << error); (gdb) p rMediaProperties $2 = uno::Sequence of length 1 = {{Name = "URL", Handle = 0, Value = uno::Any("string": "file:///home/julien/lo/libreoffice/instdir/program/../share/extensions/dict-ca/images/SC-logo.png"), State = com::sun::star::beans::PropertyState::PropertyState_DIRECT_VALUE}} (gdb) c Continuing. warn:svtools:21636:21636:vcl/source/graphic/UnoGraphicProvider.cxx:430: Could not create graphic: 0x8201(Error Area:Vcl Class:General Code:1) Change-Id: I4b160ccd6777988ddb0107b663006efdaa48e366 diff --git a/dictionaries b/dictionaries index 661e18650eb4..23120b6ade92 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 661e18650eb4f810b566fe4cbae64755a7ecf804 +Subproject commit 23120b6ade924b892055e26148c18f44896821c6 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Dictionary_ca.mk
Dictionary_ca.mk |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 23120b6ade924b892055e26148c18f44896821c6 Author: Julien Nabet AuthorDate: Sun May 5 14:10:40 2019 +0200 Commit: Julien Nabet CommitDate: Sun May 5 14:10:40 2019 +0200 Fix logo management for "ca" Thread 1 "soffice.bin" hit Breakpoint 1, (anonymous namespace)::GraphicProvider::queryGraphic (this=0x5b446140, rMediaProperties=uno::Sequence of length 1 = {...}) at /home/julien/lo/libreoffice/vcl/source/graphic/UnoGraphicProvider.cxx:430 430 SAL_WARN("svtools", "Could not create graphic: " << error); (gdb) p rMediaProperties $2 = uno::Sequence of length 1 = {{Name = "URL", Handle = 0, Value = uno::Any("string": "file:///home/julien/lo/libreoffice/instdir/program/../share/extensions/dict-ca/images/SC-logo.png"), State = com::sun::star::beans::PropertyState::PropertyState_DIRECT_VALUE}} (gdb) c Continuing. warn:svtools:21636:21636:vcl/source/graphic/UnoGraphicProvider.cxx:430: Could not create graphic: 0x8201(Error Area:Vcl Class:General Code:1) Change-Id: I4b160ccd6777988ddb0107b663006efdaa48e366 diff --git a/Dictionary_ca.mk b/Dictionary_ca.mk index eae51d2..487db29 100644 --- a/Dictionary_ca.mk +++ b/Dictionary_ca.mk @@ -15,11 +15,14 @@ $(eval $(call gb_Dictionary_add_root_files,dict-ca,\ dictionaries/ca/dictionaries/ca-valencia.aff \ dictionaries/ca/dictionaries/ca-valencia.dic \ dictionaries/ca/dictionaries/hyph_ca.dic \ - dictionaries/ca/images/SC-logo.png \ dictionaries/ca/LICENSES-en.txt \ dictionaries/ca/LLICENCIES-ca.txt \ )) +$(eval $(call gb_Dictionary_add_files,dict-ca,images,\ +dictionaries/ca/images/SC-logo.png \ +)) + $(eval $(call gb_Dictionary_add_thesauri,dict-ca,\ dictionaries/ca/dictionaries/th_ca_ES_v3.dat \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/check-elf-dynamic-objects
bin/check-elf-dynamic-objects |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4f95f74d9f9944fc225c92d17bed9921d059690e Author: Christian Lohmaier AuthorDate: Sat May 4 23:51:57 2019 +0200 Commit: Michael Weghorn CommitDate: Sun May 5 15:58:38 2019 +0200 check_dynamic_objects: --enable-gtk3-kde5 also wants qt5/kf5 whitelist.. Change-Id: I098e894d80c2b319307bf9e9eece7a59d2ff0bd0 Reviewed-on: https://gerrit.libreoffice.org/71810 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/bin/check-elf-dynamic-objects b/bin/check-elf-dynamic-objects index c83649850331..80885cc7e37e 100755 --- a/bin/check-elf-dynamic-objects +++ b/bin/check-elf-dynamic-objects @@ -143,7 +143,7 @@ local file="$1" ;; */libvclplug_gtk3_kde5lo.so) if [ "$ENABLE_GTK3_KDE5" = TRUE ]; then -whitelist="${whitelist} ${x11whitelist} ${gtk3whitelist}" +whitelist="${whitelist} ${x11whitelist} ${gtk3whitelist} ${qt5whitelist} ${kf5whitelist} libxcb.so.1" fi ;; */lo_kde5filepicker) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125122] LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 Julien Nabet changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #3 from Julien Nabet --- Thank you Olaf for your feedback. Let's put this one to WFM then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125122] LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 --- Comment #2 from Olaf Hautow --- Dear Julien Nabet, your solution went proceeding smoothly. I have been able the Extension troubless install and it work correct. Many thanks and with kindest regards. Olaf Hautow -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38187] BUG : When exporting .odt to .pdf: there is no hyperlink between main text and endnote, missing both ways
https://bugs.documentfoundation.org/show_bug.cgi?id=38187 --- Comment #26 from stragu --- I can confirm this bug with the following version and setup: Version: 6.2.2.2 Build ID: 1:6.2.2-0ubuntu0.18.04.1~lo1 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125121] Line animation hides background objects
https://bugs.documentfoundation.org/show_bug.cgi?id=125121 Michael Zapf changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125121] Line animation hides background objects
https://bugs.documentfoundation.org/show_bug.cgi?id=125121 --- Comment #2 from Michael Zapf --- I'm adding two screen recordings for illustration. The first one is recorded from LibreOffice 6.2.0 in openSUSE Tumbleweed (LibreOffice being locked to 6.2.0). http://www.mizapf.eu/files/anim620_1.mp4 The second one is recorded from LibreOffice 6.2.3.2 as distributed in Tumbleweed. That is, I just unlocked the files and did an update, and then I did the same actions again. The operating system itself received no updates. http://www.mizapf.eu/files/anim623_1.mp4 Until this is fixed, I have to lock LibreOffice to the 6.2.0 state, since I need the presentations every day. For me this is indeed a showstopper issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Question about submitting patch for dictionaries
Hello, I'm trying to submit a patch for dictionaries part. In /dictionaries I typed this: ../logerrit submit After several minutes, it's still trying to send the patch. Did I miss something? I know there is this page https://wiki.documentfoundation.org/Development/Submodules but I thought having read that dictionaries was no more a submodule. In brief, how to submit a patch for dictionaries? Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 125124] New: How Can I Install Help for a Development Build of LO?
https://bugs.documentfoundation.org/show_bug.cgi?id=125124 Bug ID: 125124 Summary: How Can I Install Help for a Development Build of LO? Product: LibreOffice Version: 6.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de First I downloaded and installed https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF/current/master~2019-05-04_04.44.35_LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb.tar.gz. That worked. Then I tried to download and install the German help system for it. But that did not work because the installed Version of LO speaks English. - That's ok for me. Then I downloaded https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF/current/master~2019-05-04_04.44.35_LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb_helppack_en-US.tar.gz and unpacked the file to ~/Downloads/tmp/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb_helppack_en-US/. I found a dictionary DEBS in it and therefore I issued $ cd ~/Downloads/tmp/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_deb_helppack_en-US/DEBS/ $ There I issued the command $ sudo dpkg -i *.deb Vormals nicht ausgewähltes Paket lodevbasis6.3-en-us-help wird gewählt. (Lese Datenbank ... 303232 Dateien und Verzeichnisse sind derzeit installiert.) $ However, after trying to open help, firefox opened and wanted to show me file:///tmp/lu11967av05m5.tmp/NewHelp1.html However, there is no such file. Nor is there any NewHelp1.html on the whole computer. What is necessary to install the en-US help for this development version of LO? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125123] [enhancement]Would Libreoffice Impress support inline math?
https://bugs.documentfoundation.org/show_bug.cgi?id=125123 --- Comment #1 from somebor...@163.com --- Created attachment 151184 --> https://bugs.documentfoundation.org/attachment.cgi?id=151184=edit A *.pptx file produced by Microsoft Office 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125123] New: [enhancement]Would Libreoffice Impress support inline math?
https://bugs.documentfoundation.org/show_bug.cgi?id=125123 Bug ID: 125123 Summary: [enhancement]Would Libreoffice Impress support inline math? Product: LibreOffice Version: 6.1.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: somebor...@163.com Description: (Please forgive my poor English) Microsoft Office now uses UnicodeMath instead of MathType. Writer works well. But when it comes to Impress,it don't show the math and all animation points to the picture compatiable with Microsoft Office 2007. The reason might be that UnicodeMath is not an object. Steps to Reproduce: 1.Use Microsoft Office to produce a *.pptx file 2.Open it using Libreoffice 3. Actual Results: It don't show the math and all animation points to the picture compatiable with Microsoft Office 2007. Expected Results: It should work as what Microsoft Office as. Reproducible: Always User Profile Reset: No Additional Info: 版本: 6.1.5.2 Build ID: 1:6.1.5-3~bpo9+1 CPU 线程: 4; 操作系统: Linux 4.9; UI 渲染: 默认; VCL: gtk3; 区域语言: zh-CN (zh_CN.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125122] LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this. For the test, could you rename your LO directory profile (see https://wiki.documentfoundation.org/UserProfile#Windows) and if you still reproduce this: - uninstall LO - rename (again) your LO directory profile - install LO - install extension -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/inc/swmodeltestbase.hxx | 18 + sw/qa/extras/ooxmlexport/ooxmlexport11.cxx | 56 ++--- 2 files changed, 30 insertions(+), 44 deletions(-) New commits: commit 3b1b3728cae244e8d079a3c5d6ed67e933ead389 Author: Thorsten Behrens AuthorDate: Fri May 3 18:54:05 2019 +0200 Commit: Thorsten Behrens CommitDate: Sun May 5 12:25:19 2019 +0200 sw: make ooxml export tests fail when re-reading doc fails Bit odd to bail a unit test when reading back the document doesn't succeed for whatever reasons. Since there are tests that also check the initial loading of a docx (even for ooxml export tests), leave those untouched. Change-Id: Iede4b360eecf3ff2c864a5d565d21120fd0e1020 Reviewed-on: https://gerrit.libreoffice.org/71503 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx b/sw/qa/extras/inc/swmodeltestbase.hxx index 2a34875c91fa..2475c5edcf71 100644 --- a/sw/qa/extras/inc/swmodeltestbase.hxx +++ b/sw/qa/extras/inc/swmodeltestbase.hxx @@ -83,8 +83,26 @@ using namespace css; CPPUNIT_TEST_SUITE_REGISTRATION(TestName); \ void TestName::verify() +#define DECLARE_SW_EXPORTONLY_TEST(TestName, filename, password, BaseClass) \ +class TestName : public BaseClass { \ +protected:\ +virtual OUString getTestName() override { return OUString(#TestName); } \ +public:\ +CPPUNIT_TEST_SUITE(TestName); \ +CPPUNIT_TEST(Import_Export_Import); \ +CPPUNIT_TEST_SUITE_END(); \ +\ +void Import_Export_Import() {\ +executeImportExportImportTest(filename, password);\ +}\ +void verify() override;\ +}; \ +CPPUNIT_TEST_SUITE_REGISTRATION(TestName); \ +void TestName::verify() + #define DECLARE_OOXMLIMPORT_TEST(TestName, filename) DECLARE_SW_IMPORT_TEST(TestName, filename, nullptr, Test) #define DECLARE_OOXMLEXPORT_TEST(TestName, filename) DECLARE_SW_ROUNDTRIP_TEST(TestName, filename, nullptr, Test) +#define DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(TestName, filename) DECLARE_SW_EXPORTONLY_TEST(TestName, filename, nullptr, Test) #define DECLARE_RTFIMPORT_TEST(TestName, filename) DECLARE_SW_IMPORT_TEST(TestName, filename, nullptr, Test) #define DECLARE_RTFEXPORT_TEST(TestName, filename) DECLARE_SW_ROUNDTRIP_TEST(TestName, filename, nullptr, Test) #define DECLARE_ODFIMPORT_TEST(TestName, filename) DECLARE_SW_IMPORT_TEST(TestName, filename, nullptr, Test) diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx index 52068e385454..42677b6de0eb 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx @@ -136,12 +136,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf121456_tabsOffset, "tdf121456_tabsOffset.odt") } // tdf#121561: make sure w:sdt/w:sdtContent around TOC is written during ODT->DOCX conversion -DECLARE_OOXMLEXPORT_TEST(testTdf121561_tocTitle, "tdf121456_tabsOffset.odt") +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf121561_tocTitle, "tdf121456_tabsOffset.odt") { xmlDocPtr pXmlDoc = parseExport(); -if (!pXmlDoc) -return; - assertXPathContent(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtContent/w:p/w:r/w:t", "Inhaltsverzeichnis"); assertXPathContent(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtContent/w:p/w:r/w:instrText", " TOC \\f \\o \"1-9\" \\h"); assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:docPartObj/w:docPartGallery", "val", "Table of Contents"); @@ -158,11 +155,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf124106, "tdf121456.docx") CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), text->getString().indexOf('y')); } -DECLARE_OOXMLEXPORT_TEST(testTdf121561_tocTitleDocx, "tdf121456_tabsOffset.odt") +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf121561_tocTitleDocx, "tdf121456_tabsOffset.odt") { xmlDocPtr pXmlDoc = parseExport(); -if (!pXmlDoc) -return; // get TOC node uno::Reference xIndexSupplier(mxComponent, uno::UNO_QUERY); @@ -216,11 +211,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf82065_Ind_start_strict, "tdf82065_Ind_start_stri CPPUNIT_ASSERT_EQUAL_MESSAGE("IndentAt defined", true, bFoundIndentAt); } -DECLARE_OOXMLEXPORT_TEST(testTdf76683_negativeTwipsMeasure, "tdf76683_negativeTwipsMeasure.docx") +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf76683_negativeTwipsMeasure, "tdf76683_negativeTwipsMeasure.docx") { xmlDocPtr pXmlDoc = parseExport("word/document.xml"); -if (!pXmlDoc) -return; assertXPath(pXmlDoc, "/w:document/w:body/w:sectPr/w:cols/w:col", 2); sal_uInt32 nColumn1 = getXPath(pXmlDoc, "/w:document/w:body/w:sectPr/w:cols/w:col[1]", "w").toUInt32(); sal_uInt32 nColumn2 = getXPath(pXmlDoc, "/w:document/w:body/w:sectPr/w:cols/w:col[2]", "w").toUInt32(); @@ -322,26 +315,19 @@ DECLARE_OOXMLEXPORT_TEST(testTdf117988, "tdf117988.docx") CPPUNIT_ASSERT_EQUAL(1, getPages()); }
[Libreoffice-commits] core.git: unoxml/source
unoxml/source/events/eventdispatcher.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit adafd453c564a65eb3b9c435e457c7ee7131b737 Author: Julien Nabet AuthorDate: Sun May 5 09:44:22 2019 +0200 Commit: Julien Nabet CommitDate: Sun May 5 10:57:27 2019 +0200 Use returned iterator from erase Change-Id: I1ae4e4d0adc467f1bcce08fdd07a5dbf94c3111c Reviewed-on: https://gerrit.libreoffice.org/71815 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/unoxml/source/events/eventdispatcher.cxx b/unoxml/source/events/eventdispatcher.cxx index b5d5ef705b31..40a08305bfd0 100644 --- a/unoxml/source/events/eventdispatcher.cxx +++ b/unoxml/source/events/eventdispatcher.cxx @@ -69,9 +69,7 @@ namespace DOM { namespace events { // erase all references to specified listener if (iter->second.is() && iter->second == aListener) { -ListenerMap::iterator tmp_iter = iter; -++iter; -rMap.erase(tmp_iter); +iter = rMap.erase(iter); } else ++iter; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125122] New: LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt«
https://bugs.documentfoundation.org/show_bug.cgi?id=125122 Bug ID: 125122 Summary: LibreOffice Extensionmanager doesn't work with »DirectColourManager-L-1.2.4.oxt« Product: LibreOffice Version: 6.1.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Extensions Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olaf_hau...@t-online.de Description: I need help. I cannot install the extention »DirectColourManager-L-1.2.4.oxt«. I have already deinstalled Liberoffice and than install again. It is always the same mistake. I use the extensionmanager to install this extension. It always appears the notice »Extension(s) hinzufügen: C:\Users\Nutzer\AppData\Roaming\LibreOffice\4\user\uno_packages\cache\uno_packages\Iu18136gv33g.tmp_\directcolourmanager-1-1-0.oxt existiert nicht.« Windows 10 Home Version 1809 Betriebssystembuild 17763.475 LibreOffice 6.1.5.2 (x64) Build 90f8dcf33c87b3705e78202e3df5142b201bd805 With kindest regards. OHautow Steps to Reproduce: 1. Download Extension »DirectColourManager-L-1.2.4.oxt« anywhere on your PC 2. Call the Extensionmanager and try to install this Extension 3. It appears the Error-message Actual Results: It appears the Error-message: »Extension(s) hinzufügen: C:\Users\Nutzer\AppData\Roaming\LibreOffice\4\user\uno_packages\cache\uno_packages\Iu18136gv33g.tmp_\directcolourmanager-1-1-0.oxt existiert nicht. Expected Results: Install the extention »DirectColourManager-L-1.2.4.oxt« Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125114] CALC save in read only can be edited in other spreadsheet program
https://bugs.documentfoundation.org/show_bug.cgi?id=125114 Julien Nabet changed: What|Removed |Added Summary|CALC save in read only can |CALC save in read only can |be edited in other |be edited in other |spreadsheet programm|spreadsheet program -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs