[Libreoffice-bugs] [Bug 127647] Spanish translation is missing in LO 6.3.1.2 Spanish Version - Insert Menu> Format Mark> all options.

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127647

--- Comment #11 from Albert Acer  ---
Spanish is my native language and I can assure you that the word "guión" in its
singular form goes with a marked accent, but in its plural form it must be
written without a marked accent (guiones).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127757] UI: "Save" icon is not correctly displayed on 4K display when changes are present

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127757

Aron Budea  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |7434|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127434] With UI scaled to 200% the 6.3.x status bar, sidebar tab icons are too small, 6.2.x was fine

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127434

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
   Keywords|bibisectRequest |bibisectNotNeeded
 Status|NEW |RESOLVED
 OS|Windows (All)   |All
 Resolution|--- |FIXED
   See Also|https://bugs.documentfounda |https://bugs.documentfounda
   |tion.org/show_bug.cgi?id=12 |tion.org/show_bug.cgi?id=12
   |7757|6293

--- Comment #5 from Aron Budea  ---
This is fixed now, and by the same commit as bug 126293:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac6fe36ac6ccebf3bf891b891bd47c8e3744a056

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126293] Save icon changes size when document gets modified

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126293

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||7434

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Aron Budea  changed:

   What|Removed |Added

 Depends on|127512  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127512
[Bug 127512] MSO line chart color is off
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127512] MSO line chart color is off

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127512

Aron Budea  changed:

   What|Removed |Added

 Blocks|108226  |75057


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=75057
[Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=75057

Aron Budea  changed:

   What|Removed |Added

 Depends on||127512


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127512
[Bug 127512] MSO line chart color is off
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108226

Aron Budea  changed:

   What|Removed |Added

 Depends on||127512


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127512
[Bug 127512] MSO line chart color is off
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108230] [META] OOXML document theme issues

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108230

Aron Budea  changed:

   What|Removed |Added

 Depends on||127512


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127512
[Bug 127512] MSO line chart color is off
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127512] MSO line chart color is off

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127512

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||108226, 108230
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #5 from Aron Budea  ---
Bibisected to the following commit using repo bibisect-44max.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=08818d8a45e034ad825c7fafbb76766f106f1d1d
author  Matúš Kukan  2014-07-04 15:12:59
+0200
committer   Matúš Kukan  2014-07-07 17:49:09
+0200

bnc#882383: Do not ignore themeOverride for charts in .pptx


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
[Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108230
[Bug 108230] [META] OOXML document theme issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127838] FORMATTING: Heading style sometimes incorrectly applied when I paste a character from copyq

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127838

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #5 from Dieter Praas  ---
(In reply to Duong Do Minh Chau from comment #3)
> Weird, it works now,

So we can close this bug report? => NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New Defects reported by Coverity Scan for LibreOffice

2019-10-05 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

9 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 9 of 9 defect(s)


** CID 1454634:  Error handling issues  (CHECKED_RETURN)
/vcl/source/app/salvtables.cxx: 1602 in 
SalInstanceAssistant::set_current_page(int)()



*** CID 1454634:  Error handling issues  (CHECKED_RETURN)
/vcl/source/app/salvtables.cxx: 1602 in 
SalInstanceAssistant::set_current_page(int)()
1596 if (aPageSize.Height() > aFinalSize.Height())
1597 aFinalSize.setHeight(aPageSize.Height());
1598 }
1599 m_xWizard->SetPageSizePixel(aFinalSize);
1600 }
1601 
>>> CID 1454634:  Error handling issues  (CHECKED_RETURN)
>>> Calling "ShowPage" without checking return value (as is done elsewhere 
>>> 4 out of 5 times).
1602 m_xWizard->ShowPage(m_aIds[nPage]);
1603 enable_notify_events();
1604 }
1605 
1606 virtual void set_current_page(const OString& rIdent) override
1607 {

** CID 1454633:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/unx/generic/gdi/salgdi.cxx: 92 in X11SalGraphics::~X11SalGraphics()()



*** CID 1454633:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/unx/generic/gdi/salgdi.cxx: 92 in X11SalGraphics::~X11SalGraphics()()
86 mxTextRenderImpl.reset(new X11CairoTextRender(*this));
87 mxImpl.reset(new X11SalGraphicsImpl(*this));
88 }
89 
90 }
91 
>>> CID 1454633:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "noexcept" doesn't allow it to be thrown. This will 
>>> cause a call to unexpected() which usually calls terminate().
92 X11SalGraphics::~X11SalGraphics()
93 {
94 DeInit();
95 ReleaseFonts();
96 freeResources();
97 }

** CID 1454632:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/unx/generic/app/saldisp.cxx: 294 in SalDisplay::~SalDisplay()()



*** CID 1454632:  Error handling issues  (UNCAUGHT_EXCEPT)
/vcl/unx/generic/app/saldisp.cxx: 294 in SalDisplay::~SalDisplay()()
288 SAL_WARN_IF(  pData->GetDisplay(), "vcl", "Second SalDisplay 
created !!!" );
289 pData->SetDisplay( this );
290 
291 m_nXDefaultScreen = SalX11Screen( DefaultScreen( pDisp_ ) );
292 }
293 
>>> CID 1454632:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "noexcept" doesn't allow it to be thrown. This will 
>>> cause a call to unexpected() which usually calls terminate().
294 SalDisplay::~SalDisplay()
295 {
296 #if OSL_DEBUG_LEVEL > 1
297 fprintf( stderr, "SalDisplay::~SalDisplay()\n" );
298 #endif
299 if( pDisp_ )

** CID 1454631:  Control flow issues  (DEADCODE)
/basegfx/source/tools/systemdependentdata.cxx: 112 in 
basegfx::SystemDependentData::calculateCombinedHoldCyclesInSeconds() const()



*** CID 1454631:  Control flow issues  (DEADCODE)
/basegfx/source/tools/systemdependentdata.cxx: 112 in 
basegfx::SystemDependentData::calculateCombinedHoldCyclesInSeconds() const()
106 {
107 nResult = nSeconds;
108 }
109 }
110 
111 // set locally (once, on-demand created, non-zero)
>>> CID 1454631:  Control flow issues  (DEADCODE)
>>> Execution cannot reach the expression "1U" inside this statement: 
>>> "const_cast(this)->mnCalculatedCycles 
= nResult < 1 ? 1 : nResult;
113 }
114 
115 return mnCalculatedCycles;
116 }
117 

** CID 1454630:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/dpcache.cxx: 175 in ::Bucket::Bucket()()



*** CID 1454630:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/dpcache.cxx: 175 in ::Bucket::Bucket()()
169 
170 struct Bucket
171 {
172 ScDPItemData maValue;
173 SCROW mnOrderIndex;
174 SCROW mnDataIndex;
>>> CID 1454630:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "mnDataIndex" is not initialized in this 
>>> constructor 

[Libreoffice-bugs] [Bug 127963] Toolbar flickers while the window is resized

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127963

V Stuart Foote  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123882] Appearance of blue and red line

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123882

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123882] Appearance of blue and red line

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123882

--- Comment #4 from QA Administrators  ---
Dear BEAUPIED Camille,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127965] LibreOffice Draw crashes without error after applying properties

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127965

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127965] LibreOffice Draw crashes without error after applying properties

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127965

--- Comment #10 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124143] Image not showing, preview and printing work correctly, restart windows help to show

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124143

--- Comment #5 from QA Administrators  ---
Dear seven,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127491] Enter a half-width character at begining of line , The Language change from Japanese to English.

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127491

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99157] "Insert Index or Table of contents": remove 'preview' introduce 'apply' button

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99157

--- Comment #3 from QA Administrators  ---
Dear Koen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89611] TOC: Undos lost after modifying index/table of contents

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89611

--- Comment #12 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123947] Export to PDF from Writer broke picture size (only width size). Could be linked to reducing dpi size

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123947

--- Comment #6 from QA Administrators  ---
Dear roumanet,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123908] LibreOffice Calc selecting/Editing multiple cells

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123908

--- Comment #4 from QA Administrators  ---
Dear Sean P,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119821] Slowdown when holding space

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119821

--- Comment #8 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124509] Calc doesn’t allow naming a sheet "Meditación", indicating I’ve used a forbidden character at the end

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124509

--- Comment #3 from QA Administrators  ---
Dear Er Crápula,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 95462] Find toolbar doesnt appear in full screen mode

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95462

--- Comment #17 from QA Administrators  ---
Dear MarjaE,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105148] Lose formatting when alternating page styles on Odd and Even pages in documents saved as DOC files

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105148

--- Comment #7 from QA Administrators  ---
Dear Tales Tomaz,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 31915] Modal dialogs aren't on OS X and multiple copies can be opened simultaneously or menu entries activated

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=31915

--- Comment #19 from QA Administrators  ---
Dear Laurent Godard,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95462] Find toolbar doesnt appear in full screen mode

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95462

--- Comment #17 from QA Administrators  ---
Dear MarjaE,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108356] FILESAVE: Master slide background image set as tiled when exporting to PPTX

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108356

--- Comment #4 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94307] Child automatic character styles not recalculated correctly on reopening document

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94307

--- Comment #9 from QA Administrators  ---
Dear matthias.temp,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127963] Toolbar flickers while the window is resized

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127963

alexleduc  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127963] Toolbar flickers while the window is resized

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127963

--- Comment #3 from alexleduc  ---
(In reply to Xisco Faulí from comment #1)
> Hello alexleduc,
> Many flickering issues has been fixed in 6.3.
> Could you please try to reproduce it with the latest version of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ?
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the bug is still present in the latest version.

Hi Xisco,

I installed the version you linked to, launched it and disabled OpenGL
rendering, restarted it and then the flickering was still happening.

Version: 6.3.2.2 (x64)
Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: fr-CA (fr_CA); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127852] UI: locked odt document disables menus from keyboard

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127852

--- Comment #2 from Nick Levinson  ---
I keep my distro (Fedora 30 Linux) evergreen and LO is up to 6.2.7.1 on that
distro, which is the version still offered at LibreOffice.org as only "slightly
older". I don't want to risk instability and have to roll back, but perhaps
someone else would like to test in 6.3.2 or a developer's version. Meanwhile,
I'll leave the status at needinfo.

In my opening post, I meant to take out the description as better covered in
the other sections (STR, actual, expected, etc.). My fault; sorry. I can't edit
the post.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/xmlreader xmlreader/source

2019-10-05 Thread Julien Nabet (via logerrit)
 include/xmlreader/xmlreader.hxx |2 ++
 xmlreader/source/xmlreader.cxx  |   10 ++
 2 files changed, 12 insertions(+)

New commits:
commit def00961243da0662f394bdf58b1157cfd45dfab
Author: Julien Nabet 
AuthorDate: Sat Oct 5 15:34:54 2019 +0200
Commit: Julien Nabet 
CommitDate: Sun Oct 6 00:28:13 2019 +0200

Optimize getNamespaceId (xmlreader)

Adding a map to cache values allows me
20s -> 13s to start LO

Change-Id: If343225def253e29696b96f223cdcb54d0d8525d
Reviewed-on: https://gerrit.libreoffice.org/80290
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/include/xmlreader/xmlreader.hxx b/include/xmlreader/xmlreader.hxx
index b86544e494e2..a7f7dbb6d1ce 100644
--- a/include/xmlreader/xmlreader.hxx
+++ b/include/xmlreader/xmlreader.hxx
@@ -22,6 +22,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -172,6 +173,7 @@ private:
 void * fileAddress_;
 NamespaceIris namespaceIris_;
 NamespaceList namespaces_;
+mutable std::unordered_map cacheNSIds_;
 ElementStack elements_;
 char const * pos_;
 char const * end_;
diff --git a/xmlreader/source/xmlreader.cxx b/xmlreader/source/xmlreader.cxx
index 1651f857e411..229be044662c 100644
--- a/xmlreader/source/xmlreader.cxx
+++ b/xmlreader/source/xmlreader.cxx
@@ -182,11 +182,21 @@ Span XmlReader::getAttributeValue(bool fullyNormalize) {
 }
 
 int XmlReader::getNamespaceId(Span const & prefix) const {
+OUString spanString = prefix.convertFromUtf8();
+
+if (auto it = cacheNSIds_.find(spanString); it != cacheNSIds_.end())
+{
+return it->second;
+}
+
 auto i = std::find_if(namespaces_.crbegin(), namespaces_.crend(),
 [](const NamespaceData& rNamespaceData) { return 
prefix.equals(rNamespaceData.prefix); });
 
 if (i != namespaces_.rend())
+{
+cacheNSIds_[spanString]= i->nsId;
 return i->nsId;
+}
 
 return NAMESPACE_UNKNOWN;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/inc sc/source

2019-10-05 Thread Eike Rathke (via logerrit)
 sc/inc/refdata.hxx  |7 +--
 sc/source/core/tool/refdata.cxx |2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 58367241f53ffca86c933f1cec506f05513b6a4f
Author: Eike Rathke 
AuthorDate: Thu Oct 3 21:00:28 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sun Oct 6 00:27:48 2019 +0200

Resolves: tdf#122011 fix ValidExternal() check

Tab==-1 may have been the condition 10 years ago, but at least since

commit 296baa2fb6dd4150a7855114093a9703cdc18b09
CommitDate: Tue Oct 5 18:14:37 2010 -0400

Ported calc-extref-interpreter-rework-*.diff from ooo-build.

that's not the case anymore.

The check is only used in
ScRefTokenHelper::compileRangeRepresentation() that is only used
when creating chart data sources and sequences, thus may have gone
undetected.

Change-Id: I2eeb20ec740d286918b6ea29c017c32d03f970ad
Reviewed-on: https://gerrit.libreoffice.org/80163
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 354b29ace32b19a1b40e46612349b8d76f00c0c6)
Reviewed-on: https://gerrit.libreoffice.org/80168
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sc/inc/refdata.hxx b/sc/inc/refdata.hxx
index 7edac9f4bb01..1274636d17da 100644
--- a/sc/inc/refdata.hxx
+++ b/sc/inc/refdata.hxx
@@ -94,7 +94,9 @@ public:
 bool ColValid() const;
 bool RowValid() const;
 bool TabValid() const;
-/// In external references nTab is -1
+/** In external references nTab is -1 if the external document was not
+loaded but the sheet was cached, or >=0 if the external document was
+loaded. */
 bool ValidExternal() const;
 
 ScAddress toAbs( const ScAddress& rPos ) const;
@@ -145,7 +147,8 @@ struct ScComplexRefData
 bool Valid() const;
 
 /** In external references nTab is -1 for the start tab and -1 for the end
-tab if one sheet, or >=0 if more than one sheets. */
+tab if one sheet and the external document was not loaded but sheet was
+cached, or >=0 also if more than one sheets. */
 bool ValidExternal() const;
 
 /** Whether this references entire columns, A:A */
diff --git a/sc/source/core/tool/refdata.cxx b/sc/source/core/tool/refdata.cxx
index bae3acc83ad1..4262da9c8ce3 100644
--- a/sc/source/core/tool/refdata.cxx
+++ b/sc/source/core/tool/refdata.cxx
@@ -181,7 +181,7 @@ bool ScSingleRefData::TabValid() const
 
 bool ScSingleRefData::ValidExternal() const
 {
-return ColValid() && RowValid() && mnTab == -1;
+return ColValid() && RowValid() && mnTab >= -1;
 }
 
 ScAddress ScSingleRefData::toAbs( const ScAddress& rPos ) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

CppCheck Report Failure

2019-10-05 Thread cppcheck.libreoff...@gmail.com

The cppcheck job failed with message: "Failed to run cppcheck."


Note:
The script generating this report was run at :
2019-06-10 00:17:00 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh




cppcheck-report.log.gz
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Pradyumna Sinha license statement

2019-10-05 Thread Pradyumn Sinha
 All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 127759] EDITING cut/move table rows/columns in Writer tables

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127759

--- Comment #12 from Ahiijny  ---
Ah, please ignore my previous comment. I'm using an old version of Word (2003)
so it's probably not very relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127759] EDITING cut/move table rows/columns in Writer tables

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127759

--- Comment #12 from Ahiijny  ---
Ah, please ignore my previous comment. I'm using an old version of Word (2003)
so it's probably not very relevant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 127759] EDITING cut/move table rows/columns in Writer tables

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127759

Ahiijny  changed:

   What|Removed |Added

 CC||ahii...@gmail.com

--- Comment #11 from Ahiijny  ---
Point of clarification: In Word, it is possible to cut both (1) only the
contents of a row, and (2) the full row. However, when cutting

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127759] EDITING cut/move table rows/columns in Writer tables

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127759

Ahiijny  changed:

   What|Removed |Added

 CC||ahii...@gmail.com

--- Comment #11 from Ahiijny  ---
Point of clarification: In Word, it is possible to cut both (1) only the
contents of a row, and (2) the full row. However, when cutting

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: helpcontent2

2019-10-05 Thread Kohei Yoshida (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 892851fe0c0490860d9aeea4b0752de52e886721
Author: Kohei Yoshida 
AuthorDate: Sat Oct 5 15:40:34 2019 -0400
Commit: Gerrit Code Review 
CommitDate: Sat Oct 5 21:53:51 2019 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  - XML Source is no longer an experimental feature.

See abb6ee1d2a0f40a4a29c60fb0c71c5644294d658 in the core repository.

Change-Id: I486931b9519200a922bd82dfb051c1500ada12d0
Reviewed-on: https://gerrit.libreoffice.org/80309
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/helpcontent2 b/helpcontent2
index 259b7b03dc58..360d9cfe12b1 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 259b7b03dc58e6a6513d108517e9393d343c6471
+Subproject commit 360d9cfe12b151b55b9db7daeaed60b1ce60a476
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2019-10-05 Thread Kohei Yoshida (via logerrit)
 source/text/scalc/01/xml_source.xhp |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 360d9cfe12b151b55b9db7daeaed60b1ce60a476
Author: Kohei Yoshida 
AuthorDate: Sat Oct 5 15:40:34 2019 -0400
Commit: Andras Timar 
CommitDate: Sat Oct 5 21:53:51 2019 +0200

XML Source is no longer an experimental feature.

See abb6ee1d2a0f40a4a29c60fb0c71c5644294d658 in the core repository.

Change-Id: I486931b9519200a922bd82dfb051c1500ada12d0
Reviewed-on: https://gerrit.libreoffice.org/80309
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/source/text/scalc/01/xml_source.xhp 
b/source/text/scalc/01/xml_source.xhp
index 7bfc6744b..6250ef7f7 100644
--- a/source/text/scalc/01/xml_source.xhp
+++ b/source/text/scalc/01/xml_source.xhp
@@ -35,13 +35,11 @@
 XML 
Source
 Import XML data in a 
spreadsheet.
 
-
 The XML Source feature allows to import data from arbitrarily 
structured XML content into cells in an existing spreadsheet document. It 
allows XML content to be imported either partially or in full, depending on the 
structure of the XML content and the map definitions that the user defines. The 
user can specify multiple non-overlapping sub-structures to be mapped to 
different cell positions within the same document. The user can import either 
element contents, attribute values or both.
 
 
 Choose Data - XML 
Source.
 
-This 
option is only available if Enable experimental features is 
selected in %PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME - 
Advanced.
 XML Source Dialog
 XML Source 
Dialog
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: tools/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 tools/source/generic/fract.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit f9877e1e9abd10bb5bfcae00269c743ca6e62c60
Author: Caolán McNamara 
AuthorDate: Sat Oct 5 19:15:46 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 21:29:38 2019 +0200

ofz#17212 Floating point exception

deploy a workaround, bug logged against boost as:
https://github.com/boostorg/boost/issues/335

Change-Id: I9791133e926dd474ddc5960a33fd90592ce3dcb3
Reviewed-on: https://gerrit.libreoffice.org/80304
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx
index 3a8eb09822c8..8ec17b94a477 100644
--- a/tools/source/generic/fract.cxx
+++ b/tools/source/generic/fract.cxx
@@ -104,6 +104,10 @@ Fraction::operator double() const
 return 0.0;
 }
 
+// https://github.com/boostorg/boost/issues/335 when these are 
std::numeric_limits::min
+if (mnNumerator == mnDenominator)
+return 1.0;
+
 return boost::rational_cast(toRational(mnNumerator, 
mnDenominator));
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98839] Distorting and flipping shape, shape changes after closing/reopening file

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98839

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel  ---
The sign of the shear angle is wrong. I see the error still in Version:
6.4.0.0.alpha0+ (x64)
Build ID: b2d8093b19642038631dfb8f1ab6745a380a652c
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-23_22:42:37
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2019-10-05 Thread Kohei Yoshida (via logerrit)
 sc/source/ui/view/cellsh2.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 20a1904945ea95df0a5d689705d2db97a6424109
Author: Kohei Yoshida 
AuthorDate: Sat Oct 5 12:00:26 2019 -0400
Commit: Kohei Yoshida 
CommitDate: Sat Oct 5 21:19:58 2019 +0200

Let's bring XML Source out of the list of experimental features.

Change-Id: I872a047fe3791253aa52b19d544fb5f26ff22f9d
Reviewed-on: https://gerrit.libreoffice.org/80296
Tested-by: Jenkins
Reviewed-by: Andras Timar 
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/ui/view/cellsh2.cxx b/sc/source/ui/view/cellsh2.cxx
index ef5c0086b7cd..d697762a4ed5 100644
--- a/sc/source/ui/view/cellsh2.cxx
+++ b/sc/source/ui/view/cellsh2.cxx
@@ -1250,12 +1250,7 @@ void ScCellShell::GetDBState( SfxItemSet& rSet )
 }
 break;
 case SID_MANAGE_XML_SOURCE:
-{
-SvtMiscOptions aMiscOptions;
-if ( !aMiscOptions.IsExperimentalMode() )
-rSet.DisableItem( nWhich );
-}
-break;
+break;
 }
 nWhich = aIter.NextWhich();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127965] LibreOffice Draw crashes without error after applying properties

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127965

Michael Weghorn  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #9 from Michael Weghorn  ---
(In reply to Julien Nabet from comment #8)
> gdb shows a big stacktrace.
> 
> Michael: I wonder if it could be an endless recursion involving notification.

Yes, this really looks like some recursion.

@Lars: Can you please try again with a daily build that has debug information?
A backtrace with such a version gives more helpful information.
(Installing debug symbols for Qt might also help, since most of the methods
shown in the backtrace are Qt-internal ones)
Such daily builds are available at [1] and it's possible to install those in
parallel to your existing LibreOffice version as described at [2].

The backtrace suggests that you're running Plasma on Wayland, is that correct?
What Qt version do you have?

[1]
https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF-dbg/
[2] https://wiki.documentfoundation.org/Installing_in_parallel/Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 include/vcl/edit.hxx|7 --
 include/vcl/vclmedit.hxx|6 ++---
 vcl/source/control/edit.cxx |   49 
 3 files changed, 3 insertions(+), 59 deletions(-)

New commits:
commit 368195c06679417e493db4f2060321895472f0b3
Author: Caolán McNamara 
AuthorDate: Fri Oct 4 14:33:47 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 20:13:45 2019 +0200

only MultiLineEditSyntaxHighlight uses UpdateData

and only the VclMultiLineEdit one which hides the Edit one so remove the 
unused
Edit UpdataData related functions leaving the VclMultiLineEdit set

Change-Id: Icd9a633d28907b3e5a3d52771b31574984e64d92
Reviewed-on: https://gerrit.libreoffice.org/80228
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx
index 2634b18fcc01..2ebb5e903f0f 100644
--- a/include/vcl/edit.hxx
+++ b/include/vcl/edit.hxx
@@ -58,7 +58,6 @@ class VCL_DLLPUBLIC Edit : public Control, public 
vcl::unohelper::DragAndDropCli
 {
 private:
 VclPtrmpSubEdit;
-std::unique_ptr mpUpdateDataTimer;
 TextFilter* mpFilterText;
 std::unique_ptr> mpDDInfo;
 std::unique_ptr mpIMEInfos;
@@ -90,8 +89,6 @@ private:
 
 css::uno::Reference mxISC;
 
-DECL_DLLPRIVATE_LINK(ImplUpdateDataHdl, Timer*, void);
-
 SAL_DLLPRIVATE boolImplTruncateToMaxLen( OUString&, sal_Int32 
nSelectionLen ) const;
 SAL_DLLPRIVATE voidImplInitEditData();
 SAL_DLLPRIVATE voidImplModified();
@@ -170,7 +167,6 @@ public:
 virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
 
 virtual voidModify();
-virtual voidUpdateData();
 
 static bool IsCharInput( const KeyEvent& rKEvt );
 
@@ -178,9 +174,6 @@ public:
 virtual voidClearModifyFlag();
 virtual boolIsModified() const { return mpSubEdit ? 
mpSubEdit->mbModified : mbModified; }
 
-virtual voidEnableUpdateData( sal_uLong nTimeout );
-virtual voidDisableUpdateData();
-
 voidSetEchoChar( sal_Unicode c );
 sal_Unicode GetEchoChar() const { return mcEchoChar; }
 
diff --git a/include/vcl/vclmedit.hxx b/include/vcl/vclmedit.hxx
index e6144cb930b3..414705c2d70f 100644
--- a/include/vcl/vclmedit.hxx
+++ b/include/vcl/vclmedit.hxx
@@ -110,14 +110,14 @@ public:
 voidSelectionChanged();
 voidCaretChanged();
 virtual voidModify() override;
-virtual voidUpdateData() override;
 
 virtual voidSetModifyFlag() override;
 virtual voidClearModifyFlag() override;
 virtual boolIsModified() const override;
 
-virtual voidEnableUpdateData( sal_uLong nTimeout ) override;
-virtual voidDisableUpdateData() override { pUpdateDataTimer.reset(); }
+voidEnableUpdateData( sal_uLong nTimeout );
+virtual voidUpdateData();
+voidDisableUpdateData() { pUpdateDataTimer.reset(); }
 
 virtual voidSetReadOnly( bool bReadOnly = true ) override;
 virtual boolIsReadOnly() const override;
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 259c2374f011..1620532ffba3 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -223,7 +223,6 @@ void Edit::dispose()
 }
 
 mpIMEInfos.reset();
-mpUpdateDataTimer.reset();
 
 if ( mxDnDListener.is() )
 {
@@ -251,7 +250,6 @@ void Edit::dispose()
 void Edit::ImplInitEditData()
 {
 mpSubEdit   = VclPtr();
-mpUpdateDataTimer   = nullptr;
 mpFilterText= nullptr;
 mnXOffset   = 0;
 mnAlign = EDIT_ALIGN_LEFT;
@@ -1384,9 +1382,6 @@ void Edit::Tracking( const TrackingEvent& rTEvt )
 ImplSetCursorPos( nCharPos, true );
 }
 }
-
-if ( mpUpdateDataTimer && !mbIsSubEdit && mpUpdateDataTimer->IsActive() )
-mpUpdateDataTimer->Start();//do not update while the user is still 
travelling in the control
 }
 
 bool Edit::ImplHandleKeyEvent( const KeyEvent& rKEvt )
@@ -1701,9 +1696,6 @@ bool Edit::ImplHandleKeyEvent( const KeyEvent& rKEvt )
 
 void Edit::KeyInput( const KeyEvent& rKEvt )
 {
-if ( mpUpdateDataTimer && !mbIsSubEdit && mpUpdateDataTimer->IsActive() )
-mpUpdateDataTimer->Start();//do not update while the user is still 
travelling in the control
-
 if ( mpSubEdit || !ImplHandleKeyEvent( rKEvt ) )
 Control::KeyInput( rKEvt );
 }
@@ -1894,13 +1886,6 @@ void Edit::GetFocus()
 
 void Edit::LoseFocus()
 {
-if ( mpUpdateDataTimer && !mbIsSubEdit && mpUpdateDataTimer->IsActive() )
-{
-//notify an update latest when the focus is lost
-mpUpdateDataTimer->Stop();
-mpUpdateDataTimer->Invoke();
-}
-
 if ( !mpSubEdit )
 {
 // FIXME: this is currently only on macOS
@@ 

[Libreoffice-bugs] [Bug 127978] Navigator's tooltip shows URI-encoded URL (with %%%) instead cyrillic path to file

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127978

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 154771
  --> https://bugs.documentfoundation.org/attachment.cgi?id=154771=edit
Screenshots with problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114019] [META] Tooltip bugs and enhancements

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114019

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||127978


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127978
[Bug 127978] Navigator's tooltip shows URI-encoded URL (with %%%) instead
cyrillic path to file
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127978] Navigator's tooltip shows URI-encoded URL (with %%%) instead cyrillic path to file

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127978

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||114019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114019
[Bug 114019] [META] Tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127978] New: Navigator's tooltip shows URI-encoded URL (with %%%) instead cyrillic path to file

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127978

Bug ID: 127978
   Summary: Navigator's tooltip shows URI-encoded URL (with %%%)
instead cyrillic path to file
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Navigator's tooltip shows URI-encoded URL (with %%%) instead cyrillic path to
file

Steps to Reproduce:
1. Create Master document
2. Add any file with ciryllic symbols in path to file 
3. place mouse point to file name in Navigator
4. look at tooltip (see screenshot in attach)

Actual Results:
Path to file in tooltip has URI-encoded URL instead ciryllic symbols

Expected Results:
Path to file in tooltip has ciryllic symbols


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+
Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-08-09_06:28:42
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svtools solenv/clang-format svtools/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 solenv/clang-format/blacklist   |2 +-
 svtools/source/control/filectrl.cxx |2 +-
 svtools/source/inc/filectrl.hxx |   13 ++---
 svtools/source/uno/unoiface.cxx |2 +-
 4 files changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 8fe484a989a1bea05dd9d1bc032c859c83966b0b
Author: Caolán McNamara 
AuthorDate: Fri Oct 4 15:07:02 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 19:51:20 2019 +0200

FileControl can be private inside svtools

Change-Id: I52edd5166edc9aceeafffed898835fe5bc46880c
Reviewed-on: https://gerrit.libreoffice.org/80232
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 0367f48f13e2..8d8a0a30b3c1 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -6938,7 +6938,6 @@ include/svtools/embedhlp.hxx
 include/svtools/embedtransfer.hxx
 include/svtools/extcolorcfg.hxx
 include/svtools/filechangedchecker.hxx
-include/svtools/filectrl.hxx
 include/svtools/fileurlbox.hxx
 include/svtools/fontsubstconfig.hxx
 include/svtools/framestatuslistener.hxx
@@ -13739,6 +13738,7 @@ svtools/source/hatchwindow/hatchwindow.cxx
 svtools/source/hatchwindow/hatchwindowfactory.cxx
 svtools/source/hatchwindow/ipwin.cxx
 svtools/source/hatchwindow/ipwin.hxx
+svtools/source/inc/filectrl.hxx
 svtools/source/inc/hatchwindow.hxx
 svtools/source/inc/unoiface.hxx
 svtools/source/java/javacontext.cxx
diff --git a/svtools/source/control/filectrl.cxx 
b/svtools/source/control/filectrl.cxx
index f615e282a7c1..6f3704d9d3bb 100644
--- a/svtools/source/control/filectrl.cxx
+++ b/svtools/source/control/filectrl.cxx
@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include 
+#include 
 
 #include 
 #include 
diff --git a/include/svtools/filectrl.hxx b/svtools/source/inc/filectrl.hxx
similarity index 84%
rename from include/svtools/filectrl.hxx
rename to svtools/source/inc/filectrl.hxx
index fc4fd00f003c..87cd28a33645 100644
--- a/include/svtools/filectrl.hxx
+++ b/svtools/source/inc/filectrl.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_SVTOOLS_FILECTRL_HXX
 #define INCLUDED_SVTOOLS_FILECTRL_HXX
 
-#include 
 #include 
 #include 
 
@@ -39,18 +38,18 @@ namespace o3tl
 }
 
 
-class SVT_DLLPUBLIC FileControl final : public vcl::Window
+class FileControl final : public vcl::Window
 {
 VclPtr   maEdit;
 VclPtr maButton;
 OUString const   maButtonText;
 FileControlMode_InternalmnInternalFlags;
 
-SVT_DLLPRIVATE void Resize() override;
-SVT_DLLPRIVATE void GetFocus() override;
-SVT_DLLPRIVATE void StateChanged( StateChangedType nType ) override;
-SVT_DLLPRIVATE WinBits  ImplInitStyle( WinBits nStyle );
-DECL_DLLPRIVATE_LINK( ButtonHdl, Button*, void );
+void Resize() override;
+void GetFocus() override;
+void StateChanged( StateChangedType nType ) override;
+WinBits  ImplInitStyle( WinBits nStyle );
+DECL_LINK( ButtonHdl, Button*, void );
 
 public:
 FileControl( vcl::Window* pParent, WinBits nStyle );
diff --git a/svtools/source/uno/unoiface.cxx b/svtools/source/uno/unoiface.cxx
index 05c377dfcb36..6cfd6f304905 100644
--- a/svtools/source/uno/unoiface.cxx
+++ b/svtools/source/uno/unoiface.cxx
@@ -24,8 +24,8 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 5 commits - loleaflet/css loleaflet/images loleaflet/src

2019-10-05 Thread Tamás Zolnai (via logerrit)
 loleaflet/css/toolbar.css|6 ++
 loleaflet/images/lc_insertion_mobile_wizard.svg  |   69 +++
 loleaflet/src/control/Control.JSDialogBuilder.js |   66 ++
 loleaflet/src/control/Control.Menubar.js |   51 -
 loleaflet/src/control/Control.MobileWizard.js|   15 +++--
 loleaflet/src/control/Control.Toolbar.js |   19 +-
 loleaflet/src/layer/tile/CalcTileLayer.js|8 --
 loleaflet/src/layer/tile/WriterTileLayer.js  |8 --
 8 files changed, 222 insertions(+), 20 deletions(-)

New commits:
commit 7b469564bbe5280b2602e110513a314002c20797
Author: Tamás Zolnai 
AuthorDate: Sat Oct 5 19:08:10 2019 +0200
Commit: Tamás Zolnai 
CommitDate: Sat Oct 5 19:08:10 2019 +0200

mobile-wizard: Update toolbar buttons by closing

Change-Id: I72b276e9cf0e54522d755eea156d5044a77166e2

diff --git a/loleaflet/src/control/Control.MobileWizard.js 
b/loleaflet/src/control/Control.MobileWizard.js
index c71b1f51f..b98506858 100644
--- a/loleaflet/src/control/Control.MobileWizard.js
+++ b/loleaflet/src/control/Control.MobileWizard.js
@@ -3,7 +3,7 @@
  * L.Control.MobileWizard
  */
 
-/* global $ */
+/* global $ w2ui*/
 L.Control.MobileWizard = L.Control.extend({
 
_inMainMenu: true,
@@ -70,10 +70,10 @@ L.Control.MobileWizard = L.Control.extend({
this._hideWizard();
this._currentDepth = 0;
if (window.mobileWizard === true) {
-   this.map.sendUnoCommand('.uno:Sidebar');
-   window.mobileWizard = false
+   w2ui['actionbar'].click('mobile_wizard')
+   } else if (window.insertionMobileWizard === true) {
+   
w2ui['actionbar'].click('insertion_mobile_wizard')
}
-   window.insertionMobileWizard = false
} else {
this._currentDepth--;
 
commit ea9eb2525d23f7cb6bcae0dac8b1f3417ad01246
Author: Tamás Zolnai 
AuthorDate: Sat Oct 5 18:47:40 2019 +0200
Commit: Tamás Zolnai 
CommitDate: Sat Oct 5 18:47:40 2019 +0200

insertion-mobile-wizard: Add a title for the main menu (e.g. "Insert")

Change-Id: I498f474d731d87591e33f2db1b7c9b52b7dafa47

diff --git a/loleaflet/src/control/Control.MobileWizard.js 
b/loleaflet/src/control/Control.MobileWizard.js
index 5a9132ffc..c71b1f51f 100644
--- a/loleaflet/src/control/Control.MobileWizard.js
+++ b/loleaflet/src/control/Control.MobileWizard.js
@@ -9,6 +9,7 @@ L.Control.MobileWizard = L.Control.extend({
_inMainMenu: true,
_isActive: false,
_currentDepth: 0,
+   _mainTitle: '',
 
onAdd: function (map) {
this.map = map;
@@ -80,7 +81,7 @@ L.Control.MobileWizard = L.Control.extend({
if (this._currentDepth > 0 && parent)
this._setTitle(parent.get(0).title);
else
-   this._setTitle('');
+   this._setTitle(this._mainTitle);
 
$('.ui-content.level-' + this._currentDepth + 
'.mobile-wizard').hide('slide', { direction: 'right' }, 'fast');
$('.ui-header.level-' + this._currentDepth + 
'.mobile-wizard').show('slide', { direction: 'left' }, 'fast');
@@ -106,6 +107,9 @@ L.Control.MobileWizard = L.Control.extend({
this._hideKeyboard();
 
L.control.jsDialogBuilder({mobileWizard: this, map: 
this.map}).build(this.content.get(0), [data]);
+
+   this._mainTitle = data.text ? data.text : '';
+   this._setTitle(this._mainTitle);
}
}
 });
commit 33e5e7977a49b8cf5a210415076c0d6ce2f10269
Author: Tamás Zolnai 
AuthorDate: Sat Oct 5 17:35:48 2019 +0200
Commit: Tamás Zolnai 
CommitDate: Sat Oct 5 18:44:39 2019 +0200

insertion-mobile-wizard: Align the sub menu arrow correctly

Change-Id: If0952435dc058d2cada04f4c6c5351d3c9aeaa91

diff --git a/loleaflet/css/toolbar.css b/loleaflet/css/toolbar.css
index 937dfb9f2..b726377ae 100644
--- a/loleaflet/css/toolbar.css
+++ b/loleaflet/css/toolbar.css
@@ -827,3 +827,8 @@ tr.useritem > td > img {
display: table-cell;
vertical-align: middle;
 }
+
+.sub-menu-arrow {
+   margin-right: 40px;
+   background: transparent;
+}
diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index 3a9f4529b..f4b4e3d26 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -140,7 +140,16 @@ L.Control.JSDialogBuilder = L.Control.extend({
 
_explorableMenu: function(parentContainer, title, children, builder) {
var sectionTitle = 

Re: Crash test update

2019-10-05 Thread Dennis Francis
At least the below two crashes are due to commit
845e1cdca3349c72e3083186502285d5b776abbe, and I'm working on a fix.

Crash:/srv/crashtestdata/files/ods/tdf77970-1.ods through disposed
Crash:/srv/crashtestdata/files/ods/fdo31831-1.ods through disposed

Thanks,
Dennis

On Sat, Oct 5, 2019 at 9:22 PM Crashtest VM 
wrote:

> New crashtest update available at
> http://dev-builds.libreoffice.org/crashtest/314958decf4491ca7b11c2ef014d29ea2ae14d69/
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 127975] convert text in board doesn't work

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127975

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with LO Debian package 6.3.2, I don't see anything wrong.

Could you provide the txt file example + odt file?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 sfx2/source/view/viewfrm.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 9be58fddb9c88d0fb058dcb7936a17c9d45d0237
Author: Caolán McNamara 
AuthorDate: Sat Oct 5 14:49:59 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 19:16:34 2019 +0200

Resolves: tdf#127946 pass in argument for dialog parent

Change-Id: If1e8339277cedf2577934246a568ecc869355a9e
Reviewed-on: https://gerrit.libreoffice.org/80291
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 490bd3519831..90e79b29ff08 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -1315,8 +1315,11 @@ void SfxViewFrame::Notify( SfxBroadcaster& /*rBC*/, 
const SfxHint& rHint )
 if (bShowTipOfTheDay && !Application::IsHeadlessModeEnabled() 
&& !bIsUITest) {
 const sal_Int32 nLastTipOfTheDay = 
officecfg::Office::Common::Misc::LastTipOfTheDayShown::get();
 const sal_Int32 nDay = 
std::chrono::duration_cast(t0).count()/24; // days since 
1970-01-01
-if (nDay-nLastTipOfTheDay > 0) //only once per day
-GetDispatcher()->Execute(SID_TIPOFTHEDAY);
+if (nDay-nLastTipOfTheDay > 0) { //only once per day
+// tdf#127946 pass in argument for dialog parent
+SfxUnoFrameItem aDocFrame(SID_FILLFRAME, 
GetFrame().GetFrameInterface());
+GetDispatcher()->ExecuteList(SID_TIPOFTHEDAY, 
SfxCallMode::SLOT, {}, {  });
+}
 } //bShowTipOfTheDay
 
 // inform about the community involvement
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127973] Sidebar: Measurement unit's not initialized with char unit

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127973

Julien Nabet  changed:

   What|Removed |Added

Summary|Sidebar: Measurment unit's  |Sidebar: Measurement unit's
   |not initialized with char   |not initialized with char
   |unit|unit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127957] calc using scenarios crash after 5 minutes away

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127957

--- Comment #4 from Oliver Brinzing  ---
with 

Version: 6.4.0.0.alpha0+ (x64)
Build ID: b0b8851021cee26412182b51ed28fe574632a4d6
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

LO crashed at:
> 15. click save

warn:vcl.schedule:2636:3028:vcl/source/app/scheduler.cxx:373: we're too early -
restart the timer (6ms)!
warn:vcl.schedule:2636:3028:vcl/source/app/scheduler.cxx:373: we're too early -
restart the timer (10ms)!
warn:sfx.control:2636:3028:sfx2/source/control/dispatch.cxx:1309: Childwindow
slot missing: 25917
warn:sfx.control:2636:3028:sfx2/source/control/dispatch.cxx:1309: Childwindow
slot missing: 25917
warn:vcl.schedule:2636:3028:vcl/source/app/scheduler.cxx:373: we're too early -
restart the timer (4ms)!
warn:xmloff:2636:3028:xmloff/source/style/impastpl.cxx:395: Adding duplicate
family table-column with mismatching mapper ! class SvXMLExportPropertyMapper *
__ptr64 class SvXMLExportPropertyMapper
warn:xmloff:2636:3028:xmloff/source/style/impastpl.cxx:395: Adding duplicate
family table-row with mismatching mapper ! class SvXMLExportPropertyMapper *
__ptr64 class SvXMLExportPropertyMapper
warn:xmloff:2636:3028:xmloff/source/style/impastpl.cxx:395: Adding duplicate
family table-cell with mismatching mapper ! class SvXMLExportPropertyMapper *
__ptr64 class XMLShapeExportPropertyMapper
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
5
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
2
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
5
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
10
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
2
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
3
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
5
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
2
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
5
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
10
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
2
warn:editeng:2636:3028:editeng/source/uno/unofield.cxx:404: Id service unknown:
3
warn:xmloff:2636:3028:xmloff/source/style/impastpl.cxx:395: Adding duplicate
family table-column with mismatching mapper ! class SvXMLExportPropertyMapper *
__ptr64 class SvXMLExportPropertyMapper
warn:xmloff:2636:3028:xmloff/source/style/impastpl.cxx:395: Adding duplicate
family table-row with mismatching mapper ! class SvXMLExportPropertyMapper *
__ptr64 class SvXMLExportPropertyMapper
warn:xmloff:2636:3028:xmloff/source/style/impastpl.cxx:395: Adding duplicate
family table-cell with mismatching mapper ! class SvXMLExportPropertyMapper *
__ptr64 class XMLShapeExportPropertyMapper
Assertion failed: nPrevIndex >= 0 && "coverity#1438402", file
D:/sources/libo-core/sc/source/filter/xml/xmlexprt.cxx, line 862

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127957] calc using scenarios crash after 5 minutes away

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127957

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de
   Hardware|x86 (IA32)  |All
 Status|UNCONFIRMED |NEW
Crash report or||crashreport.libreoffice.org
crash signature||/stats/crash_details/e1a77c
   ||28-0559-47f4-944b-935b04493
   ||501
 Ever confirmed|0   |1
 OS|Mac OS X (All)  |All

--- Comment #3 from Oliver Brinzing  ---
reproducible with:

Version: 6.3.2.2 (x64)
Build-ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: 

btw: LO crashed at:
> 14. click here and there to change focus to a1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: xcode and libreoffice are not working

2019-10-05 Thread Bruno Patin - wanadoo
I did as you said and it's working fine. Let me now some time to gulp
this huge database of code in order to be of some (liited) help. The
fact is my first build did not include debugging infos so I am making it
again but it takes time. After that we'll see.
Thanks again
Bruno Patin

Le 05/10/2019 à 10:46, Tor Lillqvist a écrit :
>
> The command indicated (make xcode-ide-integration) worked fairly
> well to build what I think are the xcodeproj files. Unhappily when
> opening them there is an issue for xcode not recognising them. 
>
> Most likely nobody has used that since whoever last worked on it gave
> up, I mean, got more urgent or interesting things to do? Unless you
> want to work on fixing it (which would be great), do not bother trying
> what "make xcode-ide-integration" produces. The only thing I
> personally use Xcode for when working on LibreOffice on macOS is
> debugging, by attaching Xcode to an already running soffice process.
> See osx/README.
>
> --tml 
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: canvas/source include/vcl vcl/source

2019-10-05 Thread Stephan Bergmann (via logerrit)
 canvas/source/cairo/cairo_canvas.cxx   |   17 -
 canvas/source/cairo/cairo_spritecanvas.cxx |   19 +--
 canvas/source/directx/dx_canvas.cxx|   12 ++--
 canvas/source/directx/dx_spritecanvas.cxx  |   10 +-
 canvas/source/opengl/ogl_spritecanvas.cxx  |   17 -
 canvas/source/vcl/canvas.cxx   |   11 +--
 canvas/source/vcl/spritecanvas.cxx |   15 +++
 include/vcl/window.hxx |1 -
 vcl/source/window/window.cxx   |   23 +--
 9 files changed, 53 insertions(+), 72 deletions(-)

New commits:
commit 5926b22b5dc33490d23d594b129eb8a70b94ffb0
Author: Stephan Bergmann 
AuthorDate: Sat Oct 5 17:19:24 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Oct 5 18:31:20 2019 +0200

The SystemEnvData passed into the canvas factories appears to be unused

It was passed in as aArg[1] ever since 
d551190e8311242eadda4a3e82efff160175cb04
"INTEGRATION: CWS canvas05", but I can't find any current use of that 
specific
argument in canvas/source/ (assuming that all the factories are implemented
there), nor can I find any trace in the git history of it ever havig been 
used.

That means that Window::GetSystemDataAny is unused now and can be removed.

Change-Id: I16efe548afb5cc3e0606cffea135f7e6674d5def
Reviewed-on: https://gerrit.libreoffice.org/80295
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/canvas/source/cairo/cairo_canvas.cxx 
b/canvas/source/cairo/cairo_canvas.cxx
index 025beafda4ba..1a5e215171ac 100644
--- a/canvas/source/cairo/cairo_canvas.cxx
+++ b/canvas/source/cairo/cairo_canvas.cxx
@@ -59,17 +59,16 @@ namespace cairocanvas
 
 /* maArguments:
0: ptr to creating instance (Window or VirtualDevice)
-   1: SystemEnvData as a streamed Any (or empty for VirtualDevice)
-   2: current bounds of creating instance
-   3: bool, denoting always on top state for Window (always false for 
VirtualDevice)
-   4: XWindow for creating Window (or empty for VirtualDevice)
-   5: SystemGraphicsData as a streamed Any
+   1: current bounds of creating instance
+   2: bool, denoting always on top state for Window (always false for 
VirtualDevice)
+   3: XWindow for creating Window (or empty for VirtualDevice)
+   4: SystemGraphicsData as a streamed Any
  */
 SAL_INFO("canvas.cairo","Canvas created " <<  this);
 
-ENSURE_ARG_OR_THROW( maArguments.getLength() >= 6 &&
+ENSURE_ARG_OR_THROW( maArguments.getLength() >= 5 &&
  maArguments[0].getValueTypeClass() == 
uno::TypeClass_HYPER &&
- maArguments[5].getValueTypeClass() == 
uno::TypeClass_SEQUENCE,
+ maArguments[4].getValueTypeClass() == 
uno::TypeClass_SEQUENCE,
  "Canvas::initialize: wrong number of arguments, 
or wrong types" );
 
 // We expect a single Any here, containing a pointer to a valid
@@ -82,10 +81,10 @@ namespace cairocanvas
  "Canvas::initialize: invalid OutDev pointer" );
 
 awt::Rectangle aBounds;
-maArguments[2] >>= aBounds;
+maArguments[1] >>= aBounds;
 
 uno::Sequence aSeq;
-maArguments[5] >>= aSeq;
+maArguments[4] >>= aSeq;
 
 const SystemGraphicsData* pSysData=reinterpret_cast(aSeq.getConstArray());
 if( !pSysData || !pSysData->nSize )
diff --git a/canvas/source/cairo/cairo_spritecanvas.cxx 
b/canvas/source/cairo/cairo_spritecanvas.cxx
index 1ec6f7e65810..23b0bf04eb52 100644
--- a/canvas/source/cairo/cairo_spritecanvas.cxx
+++ b/canvas/source/cairo/cairo_spritecanvas.cxx
@@ -59,25 +59,24 @@ namespace cairocanvas
 
 /* maArguments:
0: ptr to creating instance (Window or VirtualDevice)
-   1: SystemEnvData as a streamed Any (or empty for VirtualDevice)
-   2: current bounds of creating instance
-   3: bool, denoting always on top state for Window (always false for 
VirtualDevice)
-   4: XWindow for creating Window (or empty for VirtualDevice)
-   5: SystemGraphicsData as a streamed Any
+   1: current bounds of creating instance
+   2: bool, denoting always on top state for Window (always false for 
VirtualDevice)
+   3: XWindow for creating Window (or empty for VirtualDevice)
+   4: SystemGraphicsData as a streamed Any
  */
-ENSURE_ARG_OR_THROW( maArguments.getLength() >= 5 &&
+ENSURE_ARG_OR_THROW( maArguments.getLength() >= 4 &&
  maArguments[0].getValueTypeClass() == 
uno::TypeClass_HYPER &&
- maArguments[4].getValueTypeClass() == 
uno::TypeClass_INTERFACE,
+ maArguments[3].getValueTypeClass() == 

[Libreoffice-bugs] [Bug 127977] [Sifr theme] Create good icons for Set reminder, Header, Footer and Headings level show icons in Navigator

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127977

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||125965


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125965
[Bug 125965] [META] Sifr icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127977] [Sifr theme] Create good icons for Set reminder, Header, Footer and Headings level show icons in Navigator

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127977

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 154770
  --> https://bugs.documentfoundation.org/attachment.cgi?id=154770=edit
Screenshot with Sifr icons problem in Navigator

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125965

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||127977


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127977
[Bug 127977] [Sifr theme] Create good icons for Set reminder, Header, Footer
and Headings level show icons in Navigator
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127977] New: [Sifr theme] Create good icons for Set reminder, Header, Footer and Headings level show icons in Navigator

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127977

Bug ID: 127977
   Summary: [Sifr theme] Create good icons for Set reminder,
Header, Footer and Headings level show icons in
Navigator
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
[Sifr theme] Create good icons for Set reminder, Header, Footer and Headings
level show icons in Navigator

Steps to Reproduce:
1. Open Writer
2. Press F5 -> Opens Navigator
3. Look at Set reminder, Header, Footer and Headings level show icons in
Navigator. It looks like Breeze theme icons

Actual Results:
We have not good icons for Set reminder, Header, Footer and Headings level show
functions in Navigator 

Expected Results:
We have native Sifr theme's icons for Set reminder, Header, Footer and Headings
level show functions in Navigator 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+
Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-08-09_06:28:42
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127976] Change Navigator's Update icon in Master document mode (Writer)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127976

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||125965


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125965
[Bug 125965] [META] Sifr icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127976] [Sifr theme] Change Navigator's Update icon in Master document mode (Writer)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127976

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

Summary|Change Navigator's Update   |[Sifr theme] Change
   |icon in Master document |Navigator's Update icon in
   |mode (Writer)   |Master document mode
   ||(Writer)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125965

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||127976


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127976
[Bug 127976] Change Navigator's Update icon in Master document mode (Writer)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127976] Change Navigator's Update icon in Master document mode (Writer)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127976

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 154769
  --> https://bugs.documentfoundation.org/attachment.cgi?id=154769=edit
Screenshot with Sifr icon problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127976] New: Change Navigator's Update icon in Master document mode (Writer)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127976

Bug ID: 127976
   Summary: Change Navigator's Update icon in Master document mode
(Writer)
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Change Navigator's Update icon in Master document mode (Writer)

Steps to Reproduce:
1. File->New->Master Document
2. Look at Navigator's Update icon (Sifr theme). Comparise it with
Tools->Update menu item's icon

Actual Results:
Wrong icon for Update function in Master Document's Navigator

Expected Results:
Good icon for Update function in Master Document's Navigator like for
Tools->Update menu item


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+
Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-08-09_06:28:42
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Promote XML Source to become a regular (non-experimental) feature

2019-10-05 Thread Kohei Yoshida
On Thu, 2019-08-29 at 09:04 -0400, Kohei Yoshida wrote:
> 
> I would like to promote Calc's XML Source feature to be a regular 
> feature, enabled without enabling the experimental features check
> box.

...

> If there are any other reasons why that feature should remain an 
> experimental feature, let me know.  Otherwise, I would like to work
> on getting it off the experimental features list.

A little over a month has passed, and no replies. So I take it as no
objections. :-)

And this is the change to make it into reality:

https://gerrit.libreoffice.org/#/c/80296/

Kohei

-- 
Kohei Yoshida, LibreOffice Calc volunteer hacker

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 127975] New: convert text in board doesn't work

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127975

Bug ID: 127975
   Summary: convert text in board doesn't work
   Product: LibreOffice
   Version: 6.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: totolafrimou...@laposte.net

Description:
when y try to convert in board a selected part of text in a .txt file the
résult is a lot of cell board. Writer does not use separator char to create
collums

Steps to Reproduce:
1.open a txt file with lines like 
" text1; text2;text3
  auther text1; auther text2; auther text3
"
2. select text
3. menu > board > covert text to board
4. in form choose ";" as collum separator 


Actual Results:
bad construction of board

Expected Results:
A good board whith collum created by ";"


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Y am french and y use the french version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127845] Opening a file LO says it previously crashed, but fails to recover (win10 only?)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127845

--- Comment #62 from t...@tim-passingham.co.uk ---
(In reply to tim from comment #61)
> I'm sure it's not an LO bug, but I cannot yet be sure this problems has gone
> away for me.  I am puzzled about printer driver versions, since I haven't
> changed that for at least several months, and it's the same on all my
> systems.  But only one system repeatedly failed just opening odt and ods
> files.
> 
> I am at something of a loss as to know what to do.
The strange and unsettling world of Windows. The 'must have' update KB4524147
(for 1903) of 4th October is now 'optional' on 5th October.  I've taken a new
recovery drive and backups, but will leave the optional update until pushed for
other updates (probably this Tuesday). 

I have also made free partition space on the disks to install a linux flavour
(probably xubuntu 1804) if it comes to that.  We only got this machine as a new
Windows-only system because we thought there might be more support from local
people if the wotsits hit the fan - could be a mistaken decision.

My printer driver was (and is) definitely up to date, so there are, or were,
other issues relating to the updates of 26 September.

I now have even less hair.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127935] Double-click does not expand option tree

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127935

Caolán McNamara  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102187
Bug 102187 depends on bug 127935, which changed state.

Bug 127935 Summary: Double-click does not expand option tree
https://bugs.documentfoundation.org/show_bug.cgi?id=127935

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127965] LibreOffice Draw crashes without error after applying properties

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127965

--- Comment #8 from Julien Nabet  ---
gdb shows a big stacktrace.

Michael: I wonder if it could be an endless recursion involving notification.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127906] FILESAVE Libreoffice Impress : does not save background colors of pictures

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127906

prog-amat...@tutamail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from prog-amat...@tutamail.com ---
Thank you for your kind help. I have followed the process described in your
link (https://wiki.documentfoundation.org/UserProfile). 

>start LibreOffice and select Help ▸ Restart in Safe Mode
>in the 'Enter Safe Mode' dialog select 'Restart'
>LibreOffice will restart and display the 'Safe Mode' dialog
>If the problem persists, you can exit the safe mode because the user
profile was not the cause of the problem.

This was the case for me (problem is still present in safe mode). So I have
changed the status from NEEDINFO' to 'UNCONFIRMED'. 

Just for information : the image I copy-paste is a png format from Jupyter
notebook (a web computational environment).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48722] Add Realistic [soft-edge/fuzzy/Gaussian-blur] Shadows for Objects

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=48722

--- Comment #14 from andreas_k  ---
I need this feature for the update of the gallery items, cause with blur shadow
I can improve gallery items a lot. 

In additon MSO save blured shadow so it would be very cool if LibO can import
the shadow correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127935] Double-click does not expand option tree

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127935

--- Comment #3 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/623c0cff7589e3f2298c16c7402cf160b99fabe2

tdf#127935 Make double click expand/collapse entry in option tree

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127935] Double-click does not expand option tree

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127935

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2019-10-05 Thread Jim Raykowski (via logerrit)
 cui/source/inc/treeopt.hxx |1 +
 cui/source/options/treeopt.cxx |9 +
 2 files changed, 10 insertions(+)

New commits:
commit 623c0cff7589e3f2298c16c7402cf160b99fabe2
Author: Jim Raykowski 
AuthorDate: Thu Oct 3 15:28:46 2019 -0800
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 16:16:48 2019 +0200

tdf#127935 Make double click expand/collapse entry in option tree

Also makes keyboard use to expand/collapse work

Change-Id: I5b9d065ebe4a612ebe9658feb9ff71c504de7982
Reviewed-on: https://gerrit.libreoffice.org/80173
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index aa6f7f5b0a02..1042b68877e3 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -159,6 +159,7 @@ private:
 
 voidApplyOptions( bool deactivate );
 
+DECL_STATIC_LINK(OfaTreeOptionsDialog, ExpandCollapseHdl_Impl, 
weld::TreeView&, void);
 DECL_LINK(ShowPageHdl_Impl, weld::TreeView&, void);
 DECL_LINK(BackHdl_Impl, weld::Button&, void);
 DECL_LINK(ApplyHdl_Impl, weld::Button&, void);
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 845e7651ad68..ab802ecaa63b 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -608,6 +608,14 @@ sal_uInt16  OfaTreeOptionsDialog::AddGroup(const OUString& 
rGroupName,
 return nRet - 1;
 }
 
+IMPL_STATIC_LINK(OfaTreeOptionsDialog, ExpandCollapseHdl_Impl, 
weld::TreeView&, xTreeView, void)
+{
+std::unique_ptr xEntry(xTreeView.make_iterator());
+xTreeView.get_selected(xEntry.get());
+if (xTreeView.iter_has_child(*xEntry))
+xTreeView.get_row_expanded(*xEntry) ? xTreeView.collapse_row(*xEntry) 
: xTreeView.expand_row(*xEntry);
+}
+
 IMPL_LINK_NOARG(OfaTreeOptionsDialog, ShowPageHdl_Impl, weld::TreeView&, void)
 {
 SelectHdl_Impl();
@@ -741,6 +749,7 @@ void OfaTreeOptionsDialog::ApplyItemSets()
 void OfaTreeOptionsDialog::InitTreeAndHandler()
 {
 xTreeLB->set_help_id(HID_OFADLG_TREELISTBOX);
+xTreeLB->connect_row_activated( LINK( this, OfaTreeOptionsDialog, 
ExpandCollapseHdl_Impl ) );
 xTreeLB->connect_changed( LINK( this, OfaTreeOptionsDialog, 
ShowPageHdl_Impl ) );
 xBackPB->connect_clicked( LINK( this, OfaTreeOptionsDialog, BackHdl_Impl ) 
);
 xApplyPB->connect_clicked( LINK( this, OfaTreeOptionsDialog, ApplyHdl_Impl 
) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 dbaccess/source/ui/misc/datasourceconnector.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 588dceaa3858ce96172d968be21ee5c7ad401e44
Author: Caolán McNamara 
AuthorDate: Fri Oct 4 15:03:44 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 16:13:22 2019 +0200

don't need button.hxx here

Change-Id: I6c3225e28a05633fb68d5a08e2134c1251308717
Reviewed-on: https://gerrit.libreoffice.org/80231
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/dbaccess/source/ui/misc/datasourceconnector.cxx 
b/dbaccess/source/ui/misc/datasourceconnector.cxx
index 2d9fec95b8cf..45dc4a08e82a 100644
--- a/dbaccess/source/ui/misc/datasourceconnector.cxx
+++ b/dbaccess/source/ui/misc/datasourceconnector.cxx
@@ -33,8 +33,8 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source fpicker/inc fpicker/Library_fps_office.mk fpicker/source include/svl include/svtools solenv/clang-format svtools/inc svtools/Library_svt.mk svtools/sour

2019-10-05 Thread Caolán McNamara (via logerrit)
 dbaccess/source/ui/app/AppControllerDnD.cxx   |2 -
 dbaccess/source/ui/misc/UITools.cxx   |1 
 fpicker/Library_fps_office.mk |5 ++
 fpicker/inc/bitmaps.hlst  |2 +
 fpicker/source/office/OfficeControlAccess.hxx |2 -
 fpicker/source/office/RemoteFilesDialog.hxx   |4 +-
 fpicker/source/office/asyncfilepicker.cxx |2 -
 fpicker/source/office/fileview.cxx|   48 ++--
 fpicker/source/office/fileview.hxx|   33 +---
 fpicker/source/office/foldertree.cxx  |2 -
 fpicker/source/office/foldertree.hxx  |5 --
 fpicker/source/office/iconview.cxx|6 +--
 fpicker/source/office/iconviewimpl.cxx|4 +-
 fpicker/source/office/iodlg.cxx   |2 -
 fpicker/source/office/iodlgimp.cxx|2 -
 include/svtools/querydelete.hxx   |   52 ++
 include/svtools/urlfilter.hxx |3 +
 solenv/clang-format/blacklist |   22 +--
 svtools/Library_svt.mk|6 ---
 svtools/inc/bitmaps.hlst  |1 
 svtools/source/contnr/querydelete.cxx |   35 +
 svtools/source/control/inettbc.cxx|   26 -
 22 files changed, 154 insertions(+), 111 deletions(-)

New commits:
commit 76c5f33e65e9a36c94c46f1ed0b6d33721d21cfb
Author: Caolán McNamara 
AuthorDate: Fri Oct 4 13:23:55 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 16:06:59 2019 +0200

move file picker only code to fpicker

Change-Id: I47cc2cb7db396a06a2abeffe4a5d40a039f21c58
Reviewed-on: https://gerrit.libreoffice.org/80222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/dbaccess/source/ui/app/AppControllerDnD.cxx 
b/dbaccess/source/ui/app/AppControllerDnD.cxx
index 4051a29245b9..8e285146644c 100644
--- a/dbaccess/source/ui/app/AppControllerDnD.cxx
+++ b/dbaccess/source/ui/app/AppControllerDnD.cxx
@@ -69,9 +69,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/dbaccess/source/ui/misc/UITools.cxx 
b/dbaccess/source/ui/misc/UITools.cxx
index 417b42eb7aa1..fe68343700d1 100644
--- a/dbaccess/source/ui/misc/UITools.cxx
+++ b/dbaccess/source/ui/misc/UITools.cxx
@@ -105,7 +105,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
diff --git a/fpicker/Library_fps_office.mk b/fpicker/Library_fps_office.mk
index 996e5994d07a..626f357a98b3 100644
--- a/fpicker/Library_fps_office.mk
+++ b/fpicker/Library_fps_office.mk
@@ -45,9 +45,14 @@ $(eval $(call gb_Library_add_exception_objects,fps_office,\
fpicker/source/office/asyncfilepicker \
fpicker/source/office/breadcrumb \
fpicker/source/office/commonpicker \
+fpicker/source/office/contentenumeration \
+   fpicker/source/office/fileview \
+fpicker/source/office/foldertree \
fpicker/source/office/fpinteraction \
fpicker/source/office/fpsmartcontent \
fpicker/source/office/fps_office \
+   fpicker/source/office/iconview \
+   fpicker/source/office/iconviewimpl \
fpicker/source/office/iodlg \
fpicker/source/office/iodlgimp \
fpicker/source/office/OfficeControlAccess \
diff --git a/fpicker/inc/bitmaps.hlst b/fpicker/inc/bitmaps.hlst
index 61d5b71186de..878058154fb6 100644
--- a/fpicker/inc/bitmaps.hlst
+++ b/fpicker/inc/bitmaps.hlst
@@ -10,10 +10,12 @@
 #ifndef INCLUDED_FPICKER_INC_BITMAPS_HRC
 #define INCLUDED_FPICKER_INC_BITMAPS_HRC
 
+#define RID_BMP_FOLDER_OPEN "res/folderop.png"
 #define BMP_FILEDLG_BTN_UP  "res/fp010.png"
 #define BMP_FILEDLG_CREATEFOLDER"fpicker/res/fp014.png"
 #define BMP_FILEDLG_PLACE_LOCAL "fpicker/res/fp015.png"
 #define BMP_FILEDLG_PLACE_REMOTE"fpicker/res/fp016.png"
+#define RID_BMP_FOLDER  "svtools/res/folder.png"
 
 #endif
 
diff --git a/fpicker/source/office/OfficeControlAccess.hxx 
b/fpicker/source/office/OfficeControlAccess.hxx
index 7f1600bd587c..fcba48674dc9 100644
--- a/fpicker/source/office/OfficeControlAccess.hxx
+++ b/fpicker/source/office/OfficeControlAccess.hxx
@@ -20,9 +20,9 @@
 #ifndef INCLUDED_FPICKER_SOURCE_OFFICE_OFFICECONTROLACCESS_HXX
 #define INCLUDED_FPICKER_SOURCE_OFFICE_OFFICECONTROLACCESS_HXX
 
-#include 
 #include 
 #include 
+#include "fileview.hxx"
 #include "pickercallbacks.hxx"
 #include 
 
diff --git a/fpicker/source/office/RemoteFilesDialog.hxx 
b/fpicker/source/office/RemoteFilesDialog.hxx
index 140dd65622ec..5331107018d5 100644
--- a/fpicker/source/office/RemoteFilesDialog.hxx
+++ b/fpicker/source/office/RemoteFilesDialog.hxx
@@ -11,10 +11,8 @@
 #define INCLUDED_SVTOOLS_REMOTEFILESDIALOG_HXX
 
 #include 
-#include 
 #include 
 #include 
-#include 
 
 #include 
 
@@ -38,6 +36,8 @@
 
 #include "fpdialogbase.hxx"
 #include 

[Libreoffice-bugs] [Bug 64499] Goalseek does not get answer although Excel has no problem on same sheet saved in xls format

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64499

--- Comment #33 from Bruce Sobey  ---
Rechecked on 5 Oct 2019 on Windows version 6.3.1.2 and problem still persists.
I tried using Solver.  All the supplied Solver engines except the experimental
non-linear one get the correct result.  It has something to do with the
Goalseek engine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: canvas/source

2019-10-05 Thread Stephan Bergmann (via logerrit)
 canvas/source/cairo/cairo_spritecanvas.cxx |2 +-
 canvas/source/vcl/spritecanvas.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 108d1b7c62bba7220f0e61bba8bb04ccc545bc63
Author: Stephan Bergmann 
AuthorDate: Sat Oct 5 13:45:14 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Sat Oct 5 16:01:33 2019 +0200

The checks should apparenty be maArguments.getLength() >= 5

...given that maArguments[4] is accessed two lines further down, in both 
cases.
Looks like typos in b6a7c4da52acf45a7b69d1e81cf9548f8552752e "INTEGRATION: 
CWS
canvas05".

Change-Id: Iee8a26f2b81c9e586fe8e3c569fbd81dd8f4
Reviewed-on: https://gerrit.libreoffice.org/80289
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/canvas/source/cairo/cairo_spritecanvas.cxx 
b/canvas/source/cairo/cairo_spritecanvas.cxx
index 00ddd6c66cb7..1ec6f7e65810 100644
--- a/canvas/source/cairo/cairo_spritecanvas.cxx
+++ b/canvas/source/cairo/cairo_spritecanvas.cxx
@@ -65,7 +65,7 @@ namespace cairocanvas
4: XWindow for creating Window (or empty for VirtualDevice)
5: SystemGraphicsData as a streamed Any
  */
-ENSURE_ARG_OR_THROW( maArguments.getLength() >= 4 &&
+ENSURE_ARG_OR_THROW( maArguments.getLength() >= 5 &&
  maArguments[0].getValueTypeClass() == 
uno::TypeClass_HYPER &&
  maArguments[4].getValueTypeClass() == 
uno::TypeClass_INTERFACE,
  "CairoSpriteCanvas::initialize: wrong number of 
arguments, or wrong types" );
diff --git a/canvas/source/vcl/spritecanvas.cxx 
b/canvas/source/vcl/spritecanvas.cxx
index 90697dda794d..1a2580f6c852 100644
--- a/canvas/source/vcl/spritecanvas.cxx
+++ b/canvas/source/vcl/spritecanvas.cxx
@@ -82,7 +82,7 @@ namespace vclcanvas
4: XWindow for creating Window (or empty for VirtualDevice)
5: SystemGraphicsData as a streamed Any
  */
-ENSURE_ARG_OR_THROW( maArguments.getLength() >= 4 &&
+ENSURE_ARG_OR_THROW( maArguments.getLength() >= 5 &&
  maArguments[0].getValueTypeClass() == 
uno::TypeClass_HYPER &&
  maArguments[4].getValueTypeClass() == 
uno::TypeClass_INTERFACE,
  "VCLSpriteCanvas::initialize: wrong number of 
arguments, or wrong types" );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127946] CRASH closing LibreOffice with the tip of the day dialog open (reintroduced)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127946

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127946] CRASH closing LibreOffice with the tip of the day dialog open (reintroduced)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127946

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #4 from Caolán McNamara  ---
yeah, via menu there's an "internal" argument passed which contains the frame
to use as parent for the dialog. We can add that argument in the direct
dispatch and solve this that way. https://gerrit.libreoffice.org/#/c/80291/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127973] Sidebar: Measurment unit's not initialized with char unit

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127973

V Stuart Foote  changed:

   What|Removed |Added

Version|6.2.7.1 release |5.3.7.2 release
 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
The 'ch' and 'line' units are being picked up from Tools -> Options -> Language
Settings -> Languages when an entry is made in the Asian check box for 'Default
Languages for Documents'.

When unchecked use of 'Western' or 'CTL' locales will not offer those units in
the 'Indents and Spacing' tabs of either the Paragrah... dialog or the Styles
and Formatting deck of the Sidebar.

It was already like that for the 5.3.7 builds, so not sure how far back the
change enabling Asian 'Default languages for Documents' occurred.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 filter/source/graphicfilter/idxf/dxf2mtf.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 86875a2e910bcc1a9d2c47c34ea5f71501776193
Author: Caolán McNamara 
AuthorDate: Fri Oct 4 16:59:36 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 15:17:26 2019 +0200

ofz#17448 avoid OOM

Change-Id: Ie709eb0ce7c3987081b4b01fd96e7f99e7a48c27
Reviewed-on: https://gerrit.libreoffice.org/80240
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/idxf/dxf2mtf.cxx 
b/filter/source/graphicfilter/idxf/dxf2mtf.cxx
index 74895eb4251f..c57ad6b97924 100644
--- a/filter/source/graphicfilter/idxf/dxf2mtf.cxx
+++ b/filter/source/graphicfilter/idxf/dxf2mtf.cxx
@@ -19,6 +19,7 @@
 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -300,6 +301,8 @@ void DXF2GDIMetaFile::DrawCircleEntity(const 
DXFCircleEntity & rE, const DXFTran
 
 void DXF2GDIMetaFile::DrawLine(const Point& rA, const Point& rB)
 {
+if (utl::ConfigManager::IsFuzzing())
+return;
 GDIMetaFile* pMetaFile = pVirDev->GetConnectMetaFile();
 assert(pMetaFile);
 //use AddAction instead of OutputDevice::DrawLine so that we can 
explicitly share
@@ -811,7 +814,8 @@ bool DXF2GDIMetaFile::Convert(const DXFRepresentation & 
rDXF, GDIMetaFile & rMTF
 }
 
 pVirDev->EnableOutput(false);
-rMTF.Record(pVirDev);
+if (!utl::ConfigManager::IsFuzzing()) // for fuzzing don't bother 
recording the drawing
+rMTF.Record(pVirDev);
 
 aActLineColor = pVirDev->GetLineColor();
 aActFillColor = pVirDev->GetFillColor();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 filter/source/graphicfilter/itiff/itiff.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit dd2b43c8a3c7cc5b7f057f26c0f43978b9e31f68
Author: Caolán McNamara 
AuthorDate: Fri Oct 4 17:27:37 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Oct 5 15:17:07 2019 +0200

ofz#16306 avoid timeout

Change-Id: I668b590d7abf466b90a1123ef9c8b9fed1a907ed
Reviewed-on: https://gerrit.libreoffice.org/80251
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 31f91c10eb3e..0d1bf7ae059d 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1508,7 +1508,10 @@ bool TIFFReader::ReadTIFF(SvStream & rTIFF, Graphic & 
rGraphic )
 if ( bStatus )
 {
 sal_uInt64 nRowSize = (static_cast(nImageWidth) * 
nSamplesPerPixel / nPlanes * nBitsPerSample + 7) >> 3;
-if (nRowSize > SAL_MAX_INT32 / SAL_N_ELEMENTS(aMap))
+auto nMaxSize = SAL_MAX_INT32 / SAL_N_ELEMENTS(aMap);
+if (utl::ConfigManager::IsFuzzing())
+nMaxSize /= 2;
+if (nRowSize > nMaxSize)
 {
 SAL_WARN("filter.tiff", "Ludicrous row size of: " << 
nRowSize << " required");
 bStatus = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125914] Validation with cells referencing themselves always gives error

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125914

--- Comment #7 from Aron Budea  ---
Please read both of my previous explanations:

(In reply to Aron Budea from comment #0)
> "equal to" setting that refers to the cell itself. This means only the basic
> criteria is taken into account (whole number, decimal, date, time), and any
> such entry can be entered.

(In reply to Aron Budea from comment #5)
> The point of self-referring the cell is that you only want to allow the
> entry of a specific type of data (ie. whole numbers, decimals etc.), but
> want to put no further restriction on it. There's no such option in the
> "Data" dropdown, so it can't be done in a different way AFAIK.

Trying once again with an explanation. If you set it to eg. whole number this
way, only a whole number can be entered in the cell. It's a way to only allow
certain type of data to be entered, without having to specify further,
unnecessary restrictions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127974] New: Solver Macro cannot solve to a target because there is not suitable API object

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127974

Bug ID: 127974
   Summary: Solver Macro cannot solve to a target because there is
not suitable API object
   Product: LibreOffice
   Version: 6.3.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bso...@gmail.com

Created attachment 154768
  --> https://bugs.documentfoundation.org/attachment.cgi?id=154768=edit
File to Demonstrate problem with Basic Macro to Solve to target

It is possible to call Solver from a macro program and solve for a maximum (and
I think minimum) but there is no object one can set such as there is for
"solv.maximise = true"  I would expect something such as "solve.target =
dTarget"  I have checked the documentation and forums and used xray and got the
list at the end but nothing indicates that a target can be set.

Calling solver with the uno does not allow presetting any values so is also not
useful.  

The examples are shown in the file HelloSheet3.ods

AssumeNonNegative boolean False   
SwarmSize long   70   
LearningCycleslong 2000   
GuessVariableRangeboolean  True   
VariableRangeThresholddouble  3   
UseACRComparator  boolean False   
UseRandomStartingPointboolean False   
StagnationLimit   long   70   
Tolerance double  1E-06   
EnhancedSolverStatus  boolean  True   
AgentSwitchRate   double0.5   
DEFactor  double0.5   
DECR  double0.9   
PSC1  double  1.494   
PSC2  double  1.494   
PSWeight  double  0.729   
PSCL  double  0   
ImplementationNamestring  <...>  (get),
read-only 
SupportedServiceNames []string   (get),
read-only 
Localestruct (get,set) 
Document  object attribute 
Objective struct attribute 
Variables []struct   attribute 
Constraints   []struct   attribute 
Maximize  boolean False  attribute 
Success   boolean False  attribute,
read-only 
ResultValue   double  0  attribute,
read-only 
Solution  []double   attribute,
read-only 
ComponentDescription  string  "DEPS Evolutionary Algorithm"  attribute,
read-only 
StatusDescription string ""  attribute,
read-only 
PropertySetInfo   object (get),
read-only 
Properties[]struct   (get),
read-only 
Types []type (get),
read-only 
ImplementationId  []byte  (get),
read-only

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127954] Please rename "Show formatting marks" to something correct!

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127954

--- Comment #4 from V Stuart Foote  ---
I have no real objection to reverting the labeling to 'Non-printing
Characters', but don't see much benefit either. Was commenting on why it was
done when Jay was reworking menu/GUI items.

My real hope is that suggestions of bug 58434 get picked up to make the
.uno:ControlCodes command more meaningful.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127954] Please rename "Show formatting marks" to something correct!

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127954

--- Comment #4 from V Stuart Foote  ---
I have no real objection to reverting the labeling to 'Non-printing
Characters', but don't see much benefit either. Was commenting on why it was
done when Jay was reworking menu/GUI items.

My real hope is that suggestions of bug 58434 get picked up to make the
.uno:ControlCodes command more meaningful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - include/sfx2 vcl/unx

2019-10-05 Thread Caolán McNamara (via logerrit)
 include/sfx2/dinfdlg.hxx |2 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx |1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit b5e6978869227d70eb68a6fd25922674a21b8c8f
Author: Caolán McNamara 
AuthorDate: Thu Oct 3 12:41:32 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Oct 5 14:23:23 2019 +0200

Resolves: tdf#127882 gtk 3.18 crash in property dialog teardown

due to the menubutton popovers in the custom property page

workaround by reordering so scrolling window is torn down after the 
menubutton
is destroyed and clear the popover in the menubutton dtor

Change-Id: Icf06d912524af13a5590f160150f1a4e15f3e9f7
Reviewed-on: https://gerrit.libreoffice.org/80118
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/include/sfx2/dinfdlg.hxx b/include/sfx2/dinfdlg.hxx
index 0cf1b6424908..f984f20b0332 100644
--- a/include/sfx2/dinfdlg.hxx
+++ b/include/sfx2/dinfdlg.hxx
@@ -414,8 +414,8 @@ private:
 
 std::unique_ptr m_xBox;
 std::unique_ptr m_xBody;
-std::unique_ptr m_xPropertiesWin;
 std::unique_ptr m_xVertScroll;
+std::unique_ptr m_xPropertiesWin;
 std::unique_ptr m_xName;
 std::unique_ptr m_xType;
 std::unique_ptr m_xValue;
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 5b7efd8ce43a..5bd596bb4c09 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5347,6 +5347,7 @@ public:
 if (m_pMenuHack)
 {
 g_signal_handler_disconnect(m_pMenuButton, m_nSignalId);
+gtk_menu_button_set_popover(m_pMenuButton, nullptr);
 gtk_widget_destroy(GTK_WIDGET(m_pMenuHack));
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source

2019-10-05 Thread Caolán McNamara (via logerrit)
 sc/source/ui/formdlg/dwfunctr.cxx |   16 
 sc/source/ui/inc/dwfunctr.hxx |   20 +++-
 2 files changed, 35 insertions(+), 1 deletion(-)

New commits:
commit 2aa275bc5fd40bbd6e5ee06296481a4fcc276e45
Author: Caolán McNamara 
AuthorDate: Thu Oct 3 14:32:14 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Oct 5 14:21:25 2019 +0200

Resolves: tdf#120209 reload names if setting for their language changes

Change-Id: I386a598ae680c90e7d31bf821e7fb58391e5d45c
Reviewed-on: https://gerrit.libreoffice.org/80131
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sc/source/ui/formdlg/dwfunctr.cxx 
b/sc/source/ui/formdlg/dwfunctr.cxx
index bc99704c9dbc..76edb39ccd0d 100644
--- a/sc/source/ui/formdlg/dwfunctr.cxx
+++ b/sc/source/ui/formdlg/dwfunctr.cxx
@@ -47,6 +47,8 @@
 
 ScFunctionWin::ScFunctionWin(vcl::Window* pParent, const 
css::uno::Reference )
 : PanelLayout(pParent, "FunctionPanel", 
"modules/scalc/ui/functionpanel.ui", rFrame)
+, xConfigListener(new 
comphelper::ConfigurationListener("/org.openoffice.Office.Calc/Formula/Syntax"))
+, 
xConfigChange(std::make_unique(xConfigListener, 
this))
 , pFuncDesc(nullptr)
 {
 get(aCatBox, "category");
@@ -99,6 +101,12 @@ ScFunctionWin::~ScFunctionWin()
 
 void ScFunctionWin::dispose()
 {
+if (xConfigChange)
+{
+xConfigChange.reset();
+xConfigListener->dispose();
+xConfigListener.clear();
+}
 aCatBox.clear();
 aFuncList.clear();
 aInsertButton.clear();
@@ -412,9 +420,17 @@ IMPL_LINK_NOARG( ScFunctionWin, SetSelectionClickHdl, 
Button*, void )
 {
 DoEnter();  // saves the input
 }
+
 IMPL_LINK_NOARG( ScFunctionWin, SetSelectionHdl, ListBox&, void )
 {
 DoEnter();  // saves the input
 }
 
+void EnglishFunctionNameChange::setProperty(const css::uno::Any )
+{
+ConfigurationListenerProperty::setProperty(rProperty);
+m_xFunctionWin->InitLRUList();
+m_xFunctionWin->UpdateFunctionList();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/dwfunctr.hxx b/sc/source/ui/inc/dwfunctr.hxx
index 2be013f2b9a7..3bf7158f5df7 100644
--- a/sc/source/ui/inc/dwfunctr.hxx
+++ b/sc/source/ui/inc/dwfunctr.hxx
@@ -19,6 +19,7 @@
 #ifndef INCLUDED_SC_SOURCE_UI_INC_DWFUNCTR_HXX
 #define INCLUDED_SC_SOURCE_UI_INC_DWFUNCTR_HXX
 
+#include 
 #include 
 #include 
 #include 
@@ -26,6 +27,21 @@
 class ScFuncDesc;
 namespace formula { class IFunctionDescription; }
 
+class ScFunctionWin;
+
+class EnglishFunctionNameChange : public 
comphelper::ConfigurationListenerProperty
+{
+VclPtr m_xFunctionWin;
+protected:
+virtual void setProperty(const css::uno::Any ) override;
+public:
+EnglishFunctionNameChange(const 
rtl::Reference , ScFunctionWin* 
pFunctionWin)
+: ConfigurationListenerProperty(rListener, "EnglishFunctionName")
+, m_xFunctionWin(pFunctionWin)
+{
+}
+};
+
 class ScFunctionWin : public PanelLayout
 {
 
@@ -35,12 +51,13 @@ private:
 
 VclPtr  aInsertButton;
 VclPtr   aFiFuncDesc;
+rtl::Reference xConfigListener;
+std::unique_ptr xConfigChange;
 const ScFuncDesc*   pFuncDesc;
 sal_uInt16  nArgs;
 
 ::std::vector< const formula::IFunctionDescription*> aLRUList;
 
-voidUpdateFunctionList();
 voidUpdateLRUList();
 voidDoEnter();
 voidSetDescription();
@@ -56,6 +73,7 @@ public:
 virtual voiddispose() override;
 
 voidInitLRUList();
+voidUpdateFunctionList();
 };
 
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127845] Opening a file LO says it previously crashed, but fails to recover (win10 only?)

2019-10-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127845

--- Comment #61 from t...@tim-passingham.co.uk ---
I'm sure it's not an LO bug, but I cannot yet be sure this problems has gone
away for me.  I am puzzled about printer driver versions, since I haven't
changed that for at least several months, and it's the same on all my systems. 
But only one system repeatedly failed just opening odt and ods files.

I am at something of a loss as to know what to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - shell/source

2019-10-05 Thread Julien Nabet (via logerrit)
 shell/source/unix/misc/senddoc.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 95ddf1f58919608e29fdbe78080fbce4e5277f85
Author: Julien Nabet 
AuthorDate: Mon Sep 23 21:10:59 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Oct 5 14:08:10 2019 +0200

tdf#127710: fix sending documents to Claws Mail

Thanks to the Paul's (p...@claws-mail.org) contribution

Change-Id: Ie4144ab78691b33d8d341d4520c40c56010a0dd8
Reviewed-on: https://gerrit.libreoffice.org/79423
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit 1c03df6e82e4bf30294fc0b9e64de5cc39efc5c4)
Reviewed-on: https://gerrit.libreoffice.org/79460
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/shell/source/unix/misc/senddoc.sh 
b/shell/source/unix/misc/senddoc.sh
index 372cee475fe2..394087156a74 100755
--- a/shell/source/unix/misc/senddoc.sh
+++ b/shell/source/unix/misc/senddoc.sh
@@ -349,7 +349,7 @@ case $(basename "$MAILER" | sed 's/-.*$//') in
 shift
 ;;
 --attach)
-ATTACH="${ATTACH:-}${ATTACH:+ }$2"
+ATTACH=${ATTACH:-}${ATTACH:+,}$(echo "file://$2" | 
"${URI_ENCODE}")
 shift
 ;;
 *)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

  1   2   >