[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from m.a.riosv --- Repro. Version: 6.5.0.0.alpha0+ (x64) Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 --- Comment #5 from m.a.riosv --- *** Bug 129699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129699] EDITING “Paste special - Unformatted text” does not overwrite content with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=129699 m.a.riosv changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 129701 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 129699] EDITING “Paste special - Unformatted text” does not overwrite content with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=129699 m.a.riosv changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from m.a.riosv --- *** This bug has been marked as a duplicate of bug 129701 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 108479] [META] Paste special bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108479 Bug 108479 depends on bug 129699, which changed state. Bug 129699 Summary: EDITING “Paste special - Unformatted text” does not overwrite content with empty cell https://bugs.documentfoundation.org/show_bug.cgi?id=129699 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129699] EDITING “Paste special - Unformatted text” does not overwrite content with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=129699 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #4 from m.a.riosv --- Repro Version: 6.5.0.0.alpha0+ (x64) Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 129699] EDITING “Paste special - Unformatted text” does not overwrite content with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=129699 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #4 from m.a.riosv --- Repro Version: 6.5.0.0.alpha0+ (x64) Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129092] The font Times New Roman:dlig does not create ligatures
https://bugs.documentfoundation.org/show_bug.cgi?id=129092 --- Comment #8 from Dieter Praas --- In the PDF I can see the difference in your document, but I can't reproduce it. Perhaps somebody else can help. Additional information: When I open your document, I always get the following warning: "This document contains macros.Macros may contain viruses. Execution of macros is disabled due to the current macro security setting in Tools - Options - LibreOfficeDev - Security. Therefore, some functionality may not be available." I don't know, if you get a better result in a document without a macro. Are you still using LO 6.4.0.0? Please paste inormations from Help => About LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129489] UI: AutoCorrect should be simplified and fixed
https://bugs.documentfoundation.org/show_bug.cgi?id=129489 John changed: What|Removed |Added Component|UI |Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list
https://bugs.documentfoundation.org/show_bug.cgi?id=108458 --- Comment #48 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/444f0d256957544d26b9af9a0898364e829df1b5 tdf#108458 related: Make command tooltip show in tooltip It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/customize/cfgutil.cxx |3 +++
cui/uiconfig/ui/accelconfigpage.ui |1 +
2 files changed, 4 insertions(+)
New commits:
commit 444f0d256957544d26b9af9a0898364e829df1b5
Author: Jim Raykowski
AuthorDate: Mon Dec 23 23:55:26 2019 -0900
Commit: Jim Raykowski
CommitDate: Tue Dec 31 08:18:19 2019 +0100
tdf#108458 related: Make command tooltip show in tooltip
Make Customize > Keyboard > Function TreeView show command tooltip in
the tooltip.
Change-Id: I5d2ca7090e00d7c18d792da73c567cdfd6895da2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85776
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index e52ed440d311..d181470df57f 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -599,11 +599,14 @@ void CuiConfigGroupListBox::FillFunctionsList(const
css::uno::Sequencefreeze();
for (const auto & rInfo : xCommands)
{
+auto aProperties =
vcl::CommandInfoProvider::GetCommandProperties(rInfo.Command,
m_sModuleLongName);
+
OUString sUIName = MapCommand2UIName(rInfo.Command);
aArr.push_back( std::make_unique(
SfxCfgKind::FUNCTION_SLOT, 0 ) );
SfxGroupInfo_Impl* pGrpInfo = aArr.back().get();
pGrpInfo->sCommand = rInfo.Command;
pGrpInfo->sLabel = sUIName;
+pGrpInfo->sTooltip =
vcl::CommandInfoProvider::GetTooltipForCommand(rInfo.Command, aProperties,
m_xFrame);
m_pFunctionListBox->append(OUString::number(reinterpret_cast(pGrpInfo)),
sUIName);
}
m_pFunctionListBox->thaw();
diff --git a/cui/uiconfig/ui/accelconfigpage.ui
b/cui/uiconfig/ui/accelconfigpage.ui
index 61f01d016892..83159c789fb5 100644
--- a/cui/uiconfig/ui/accelconfigpage.ui
+++ b/cui/uiconfig/ui/accelconfigpage.ui
@@ -433,6 +433,7 @@
True
True
True
+True
True
True
liststore2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125193] Draw tab of Tabbed menu become inactive in certain cases
https://bugs.documentfoundation.org/show_bug.cgi?id=125193 Peter Benedek changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from Peter Benedek --- LibreOffice 6.3.4 (Impress) still include the bug. Verzió: 6.3.4.2 Build az.: 1:6.3.4-0ubuntu0.18.04.1~lo2 CPU szálak: 2; OS: Linux 5.3; Felületmegjelenítés: alapértelmezett; VCL: gtk3; Területi beállítások: hu-HU (hu_HU.UTF-8); Felület nyelve: hu-HU Calc: threaded What information do you need? -- Open new Impress document -- View - User Interface - Tabbed -- there are two objects -- two objects is overlap -- Click the rectangle_1. Result: Now the Draw menu is active. -- Click on the common area of the two rectangles. Try clicking on any item in the draw menu. What happen? Impress jumps to the home tab. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129488] F6 incorrectly lands on font size control in read-only mode
https://bugs.documentfoundation.org/show_bug.cgi?id=129488 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #2 from Jim Raykowski --- A patch for this is here: https://gerrit.libreoffice.org/c/core/+/86040 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/po loleaflet/src
loleaflet/po/templates/loleaflet-ui.pot |6 +++--- loleaflet/po/ui-ab.po|6 +++--- loleaflet/po/ui-af.po|6 +++--- loleaflet/po/ui-am.po|6 +++--- loleaflet/po/ui-an.po|6 +++--- loleaflet/po/ui-anp.po |6 +++--- loleaflet/po/ui-ar.po|6 +++--- loleaflet/po/ui-as.po|6 +++--- loleaflet/po/ui-ast.po |6 +++--- loleaflet/po/ui-az.po|6 +++--- loleaflet/po/ui-bar.po |6 +++--- loleaflet/po/ui-be.po|6 +++--- loleaflet/po/ui-bg.po|6 +++--- loleaflet/po/ui-bm.po|6 +++--- loleaflet/po/ui-bn.po|6 +++--- loleaflet/po/ui-bn_IN.po |6 +++--- loleaflet/po/ui-bo.po|6 +++--- loleaflet/po/ui-br.po|6 +++--- loleaflet/po/ui-brx.po |6 +++--- loleaflet/po/ui-bs.po|6 +++--- loleaflet/po/ui-ca-valencia.po |6 +++--- loleaflet/po/ui-ca.po|8 loleaflet/po/ui-ce.po|6 +++--- loleaflet/po/ui-cs.po|6 +++--- loleaflet/po/ui-cy.po|6 +++--- loleaflet/po/ui-da.po|6 +++--- loleaflet/po/ui-de.po|6 +++--- loleaflet/po/ui-dgo.po |6 +++--- loleaflet/po/ui-dsb.po |6 +++--- loleaflet/po/ui-dz.po|6 +++--- loleaflet/po/ui-el.po|6 +++--- loleaflet/po/ui-en_AU.po |6 +++--- loleaflet/po/ui-en_GB.po |6 +++--- loleaflet/po/ui-en_ZA.po |6 +++--- loleaflet/po/ui-eo.po|6 +++--- loleaflet/po/ui-es.po|8 loleaflet/po/ui-et.po|6 +++--- loleaflet/po/ui-eu.po|6 +++--- loleaflet/po/ui-fa.po|6 +++--- loleaflet/po/ui-fi.po|6 +++--- loleaflet/po/ui-fr.po|6 +++--- loleaflet/po/ui-fur.po |6 +++--- loleaflet/po/ui-fy.po|6 +++--- loleaflet/po/ui-ga.po|6 +++--- loleaflet/po/ui-gbm.po |6 +++--- loleaflet/po/ui-gd.po|6 +++--- loleaflet/po/ui-gl.po|6 +++--- loleaflet/po/ui-gu.po|6 +++--- loleaflet/po/ui-gug.po |6 +++--- loleaflet/po/ui-he.po|6 +++--- loleaflet/po/ui-hi.po|6 +++--- loleaflet/po/ui-hr.po|6 +++--- loleaflet/po/ui-hsb.po |6 +++--- loleaflet/po/ui-hu.po|6 +++--- loleaflet/po/ui-hy.po|6 +++--- loleaflet/po/ui-id.po|6 +++--- loleaflet/po/ui-is.po|6 +++--- loleaflet/po/ui-it.po|6 +++--- loleaflet/po/ui-ja.po|6 +++--- loleaflet/po/ui-jv.po|6 +++--- loleaflet/po/ui-ka.po|6 +++--- loleaflet/po/ui-kab.po |6 +++--- loleaflet/po/ui-kk.po|6 +++--- loleaflet/po/ui-kl.po|6 +++--- loleaflet/po/ui-km.po|6 +++--- loleaflet/po/ui-kmr-Latn.po |6 +++--- loleaflet/po/ui-kn.po|6 +++--- loleaflet/po/ui-ko.po|6 +++--- loleaflet/po/ui-kok.po |6 +++--- loleaflet/po/ui-ks.po|6 +++--- loleaflet/po/ui-ky.po|6 +++--- loleaflet/po/ui-lb.po|6 +++--- loleaflet/po/ui-lo.po|6 +++--- loleaflet/po/ui-lt.po|6 +++--- loleaflet/po/ui-lv.po|6 +++--- loleaflet/po/ui-mai.po |6 +++--- loleaflet/po/ui-mk.po|6 +++--- loleaflet/po/ui-ml.po|6 +++---
[Libreoffice-bugs] [Bug 124041] Place focus on header/footer frame menu button when header/footer is empty
https://bugs.documentfoundation.org/show_bug.cgi?id=124041 --- Comment #16 from Jim Raykowski --- Another idea for this annoyance: Since the cursor remains in the document when the Add header/footer frame menu button is displayed. How about simply hiding it if a key is pressed?. This would be consistent with a mouse click in the document area. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106609] Inserting a note or a comment, after sharing an .ODS or .ODT files, greyed out...
https://bugs.documentfoundation.org/show_bug.cgi?id=106609 Clara Byrne changed: What|Removed |Added URL||https://seersco.com/cookie- ||consent-banner.html --- Comment #15 from Clara Byrne --- This is really helping & informational website -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94223] Selection box for text box not shown
https://bugs.documentfoundation.org/show_bug.cgi?id=94223 --- Comment #24 from Jonathan Buhacoff --- I noticed that I'm having this problem only with text boxes that are part of the slide layout - title, content, etc. including clones where I copied & pasted an affected text box to make a second one. When I add text boxes to a slide with the insert text box tool, I do see a blue border around the box when I click on it, and clicking on the blue border shows the resize boxes. I also noticed that the action area for this blue border extends a few pixels into the text box so it's easier to activate. This behavior is just fine... I'm wondering why this good behavior doesn't apply to the text boxes that are defined by the master slides in my presentation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] UI Calc-File has empty/invisible menu options in LO 6.4.0.1 WIN10 x64
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 --- Comment #2 from V Stuart Foote --- Please post text of Help -> About LibreOffice and the text from your OpenGL device log: C:\Users\\AppData\Roaming\LibreOffice\4\cache\opengl_device.log Then, check behavior if you enable/disable OpenGL rendering: Tools -> Options -> View: 'Use OpenGL for all rendering' do the empty menus appear with or without OpenGL rendering, or Hardware Acceleration checked enabled. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[no subject]
Sent from Yahoo Mail on Android___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 126210] File open dialog hides behind front window
https://bugs.documentfoundation.org/show_bug.cgi?id=126210 --- Comment #2 from QA Administrators --- Dear ikke, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129092] The font Times New Roman:dlig does not create ligatures
https://bugs.documentfoundation.org/show_bug.cgi?id=129092 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125193] Draw tab of Tabbed menu become inactive in certain cases
https://bugs.documentfoundation.org/show_bug.cgi?id=125193 --- Comment #4 from QA Administrators --- Dear Peter Benedek, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129431] Crashes other program when I over-write pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=129431 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129092] The font Times New Roman:dlig does not create ligatures
https://bugs.documentfoundation.org/show_bug.cgi?id=129092 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129092] The font Times New Roman:dlig does not create ligatures
https://bugs.documentfoundation.org/show_bug.cgi?id=129092 --- Comment #6 from mkass...@internode.net --- Created attachment 156859 --> https://bugs.documentfoundation.org/attachment.cgi?id=156859=edit .pdf showing TimesNewRoman:dlig does not work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94223] Selection box for text box not shown
https://bugs.documentfoundation.org/show_bug.cgi?id=94223 --- Comment #23 from Jonathan Buhacoff --- I have the same problem. Here's what is working for me now: Step 1. Click inside the text box as if to edit it Step 2. Click the "Select" action icon in the toolbar to make the resizing squares visible Step 3. Either use the resizing squares, or position the mouse on the invisible line between the squares to drag the box It would help if we could make the resizing squares always show up around the text box while typing, and also show dotted lines between them to give a hint about where to put the mouse to move the box. It would also help if the action area would be larger around the dragging lines between the resizing squares, because it's really hard to keep the mouse on it -- sometimes when I try to click on the line the mouse moves just a little when I click and then I miss the line, and have to start over with steps 1 & 2 above. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 39 --
vcl/source/gdi/pdfwriter_impl.hxx |2 +
2 files changed, 23 insertions(+), 18 deletions(-)
New commits:
commit f7a2f63994e22c99010c1d25a4493a8a0c57866e
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 20:32:50 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Dec 31 00:09:41 2019 +0100
pdf: move PDFPage dependency out of Matrix3 class (append method)
PDFPage should be responsible to append the Matrix3 data and not
the other way arround.
This is needed so it can be moved into it's own class.
Change-Id: I98ca1830e7105b73fe26a0559df99da2b2df4307
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86035
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 9599ca737822..1ec13034a9bf 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -566,7 +566,10 @@ public:
void translate( double tx, double ty );
void invert();
-void append( PDFPage const & rPage, OStringBuffer& rBuffer );
+double get(size_t i) const
+{
+return f[i];
+}
Point transform( const Point& rPoint ) const;
};
@@ -670,19 +673,6 @@ void Matrix3::invert()
set( fn );
}
-void Matrix3::append( PDFPage const & rPage, OStringBuffer& rBuffer )
-{
-appendDouble( f[0], rBuffer );
-rBuffer.append( ' ' );
-appendDouble( f[1], rBuffer );
-rBuffer.append( ' ' );
-appendDouble( f[2], rBuffer );
-rBuffer.append( ' ' );
-appendDouble( f[3], rBuffer );
-rBuffer.append( ' ' );
-rPage.appendPoint( Point( static_cast(f[4]), static_cast(f[5])
), rBuffer );
-}
-
PDFPage::PDFPage( PDFWriterImpl* pWriter, double nPageWidth, double
nPageHeight, PDFWriter::Orientation eOrientation )
:
m_pWriter( pWriter ),
@@ -1242,7 +1232,20 @@ void PDFPage::appendWaveLine( sal_Int32 nWidth,
sal_Int32 nY, sal_Int32 nDelta,
rBuffer.append( "S\n" );
}
- PDFWriterImpl::PDFWriterImpl( const PDFWriter::PDFWriterContext& rContext,
+void PDFPage::appendMatrix3(Matrix3 const & rMatrix, OStringBuffer& rBuffer)
+{
+appendDouble(rMatrix.get(0), rBuffer);
+rBuffer.append(' ');
+appendDouble(rMatrix.get(1), rBuffer);
+rBuffer.append(' ');
+appendDouble(rMatrix.get(2), rBuffer);
+rBuffer.append(' ');
+appendDouble(rMatrix.get(3), rBuffer);
+rBuffer.append(' ');
+appendPoint(Point(long(rMatrix.get(4)), long(rMatrix.get(5))), rBuffer);
+}
+
+PDFWriterImpl::PDFWriterImpl( const PDFWriter::PDFWriterContext& rContext,
const css::uno::Reference<
css::beans::XMaterialHolder >& xEnc,
PDFWriter& i_rOuterFace)
: VirtualDevice(Application::GetDefaultDevice(),
DeviceFormat::DEFAULT, DeviceFormat::NONE, OUTDEV_PDF),
@@ -5860,7 +5863,7 @@ void PDFWriterImpl::drawVerticalGlyphs(
aMat.scale( fTempXScale, fYScale );
aMat.rotate( fAngle+fDeltaAngle );
aMat.translate( aCurPos.X()+aDeltaPos.X(), aCurPos.Y()+aDeltaPos.Y() );
-aMat.append( m_aPages.back(), rLine );
+m_aPages.back().appendMatrix3(aMat, rLine);
rLine.append( " Tm" );
if( i == 0 || rGlyphs[i-1].m_nMappedFontId !=
rGlyphs[i].m_nMappedFontId )
{
@@ -5932,7 +5935,7 @@ void PDFWriterImpl::drawHorizontalGlyphs(
aMat.scale( fXScale, 1.0 );
aMat.rotate( fAngle );
aMat.translate( aCurPos.X(), aCurPos.Y() );
-aMat.append( m_aPages.back(), rLine );
+m_aPages.back().appendMatrix3(aMat, rLine);
rLine.append( " Tm\n" );
}
// set up correct font
@@ -7140,7 +7143,7 @@ void PDFWriterImpl::drawTextLine( const Point& rPos, long
nWidth, FontStrikeout
Matrix3 aMat;
aMat.rotate( fAngle );
aMat.translate( aPos.X(), aPos.Y() );
-aMat.append( m_aPages.back(), aLine );
+m_aPages.back().appendMatrix3(aMat, aLine);
aLine.append( " cm\n" );
if ( aUnderlineColor.GetTransparency() != 0 )
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 0b155145e250..be201c3be127 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -164,6 +164,8 @@ struct PDFPage
// appends a horizontal waveline with vertical offset (helper for
drawWaveLine)
void appendWaveLine( sal_Int32 nLength, sal_Int32 nYOffset, sal_Int32
nDelta, OStringBuffer& rBuffer ) const;
+void appendMatrix3(Matrix3 const & rMatrix, OStringBuffer& rBuffer);
+
double getHeight() const { return m_nPageHeight ? m_nPageHeight :
vcl::pdf::g_nInheritedPageHeight; }
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/Library_vcl.mk vcl/source
vcl/Library_vcl.mk|1
vcl/inc/pdf/Matrix3.hxx | 54 +++
vcl/source/gdi/pdfwriter_impl.cxx | 130 --
vcl/source/gdi/pdfwriter_impl.hxx |2
vcl/source/pdf/Matrix3.cxx| 117 ++
5 files changed, 173 insertions(+), 131 deletions(-)
New commits:
commit 5a068e585429c9aabfbb36f7c9f028c0acc578aa
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 20:38:21 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Dec 31 00:10:00 2019 +0100
pdf: extract Matrix3 to it's own files
Change-Id: Ic855b01d8b812e4604b266427c4f646cd1625b86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86036
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index d557ce3f0bc4..e2a3fc9fb889 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -317,6 +317,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
vcl/source/gdi/CommonSalLayout \
vcl/source/gdi/TypeSerializer \
vcl/source/pdf/ResourceDict \
+vcl/source/pdf/Matrix3 \
vcl/source/graphic/GraphicLoader \
vcl/source/graphic/GraphicObject \
vcl/source/graphic/GraphicObject2 \
diff --git a/vcl/inc/pdf/Matrix3.hxx b/vcl/inc/pdf/Matrix3.hxx
new file mode 100644
index ..c36332015c13
--- /dev/null
+++ b/vcl/inc/pdf/Matrix3.hxx
@@ -0,0 +1,54 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_INC_PDF_MATRIX3_HXX
+#define INCLUDED_VCL_INC_PDF_MATRIX3_HXX
+
+#include
+#include
+
+namespace vcl::pdf
+{
+// matrix helper class
+// TODO: use basegfx matrix class instead or derive from it
+
+/* for sparse matrices of the form (2D linear transformations)
+ * f[0] f[1] 0
+ * f[2] f[3] 0
+ * f[4] f[5] 1
+ */
+class Matrix3
+{
+double f[6];
+
+void set(const double* pn)
+{
+for (int i = 0; i < 6; i++)
+f[i] = pn[i];
+}
+
+public:
+Matrix3();
+
+void skew(double alpha, double beta);
+void scale(double sx, double sy);
+void rotate(double angle);
+void translate(double tx, double ty);
+void invert();
+
+double get(size_t i) const { return f[i]; }
+
+Point transform(const Point& rPoint) const;
+};
+}
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 1ec13034a9bf..c5078143874c 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -543,136 +543,6 @@ void PDFWriterImpl::appendNonStrokingColor( const Color&
rColor, OStringBuffer&
}
}
-// matrix helper class
-// TODO: use basegfx matrix class instead or derive from it
-namespace vcl // TODO: use anonymous namespace to keep this class local
-{
-/* for sparse matrices of the form (2D linear transformations)
- * f[0] f[1] 0
- * f[2] f[3] 0
- * f[4] f[5] 1
- */
-class Matrix3
-{
-double f[6];
-
-void set( const double *pn ) { for( int i = 0 ; i < 6; i++ ) f[i] = pn[i];
}
-public:
-Matrix3();
-
-void skew( double alpha, double beta );
-void scale( double sx, double sy );
-void rotate( double angle );
-void translate( double tx, double ty );
-void invert();
-
-double get(size_t i) const
-{
-return f[i];
-}
-
-Point transform( const Point& rPoint ) const;
-};
-}
-
-Matrix3::Matrix3()
-{
-// initialize to unity
-f[0] = 1.0;
-f[1] = 0.0;
-f[2] = 0.0;
-f[3] = 1.0;
-f[4] = 0.0;
-f[5] = 0.0;
-}
-
-Point Matrix3::transform( const Point& rOrig ) const
-{
-double x = static_cast(rOrig.X()), y =
static_cast(rOrig.Y());
-return Point( static_cast(x*f[0] + y*f[2] + f[4]),
static_cast(x*f[1] + y*f[3] + f[5]) );
-}
-
-void Matrix3::skew( double alpha, double beta )
-{
-double fn[6];
-double tb = tan( beta );
-fn[0] = f[0] + f[2]*tb;
-fn[1] = f[1];
-fn[2] = f[2] + f[3]*tb;
-fn[3] = f[3];
-fn[4] = f[4] + f[5]*tb;
-fn[5] = f[5];
-if( alpha != 0.0 )
-{
-double ta = tan( alpha );
-fn[1] += f[0]*ta;
-fn[3] += f[2]*ta;
-fn[5] += f[4]*ta;
-}
-set( fn );
-}
-
-void Matrix3::scale( double sx, double sy )
-{
-double fn[6];
-fn[0] = sx*f[0];
-fn[1] = sy*f[1];
-fn[2] = sx*f[2];
-fn[3] = sy*f[3];
-fn[4] = sx*f[4];
-fn[5] = sy*f[5];
-set( fn );
-}
-
-void Matrix3::rotate( double angle )
-{
-double fn[6];
-double fSin = sin(angle);
-double fCos = cos(angle);
-fn[0] = f[0]*fCos - f[1]*fSin;
-fn[1] = f[0]*fSin + f[1]*fCos;
-fn[2] = f[2]*fCos - f[3]*fSin;
-fn[3] =
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
New commits:
commit 45f208207be6ad23fa6fc22faebfaf676346da80
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 19:56:37 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Dec 31 00:08:41 2019 +0100
pdf: move GraphicsStateUpdateFlags to vcl::pdf namespace
Change-Id: I328943f0f928a739759f984db0a6bfea3a65b015
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86034
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 4ce4d7d9aea8..0b155145e250 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -70,6 +70,9 @@ constexpr sal_Int32 SECUR_128BIT_KEY = 16;
// PDF spec ver. 1.4: see there for details
constexpr sal_Int32 MAXIMUM_RC4_KEY_LENGTH = SECUR_128BIT_KEY + 3 + 2;
+namespace vcl::pdf
+{
+
enum class GraphicsStateUpdateFlags {
Font = 0x0001,
MapMode = 0x0002,
@@ -81,8 +84,11 @@ enum class GraphicsStateUpdateFlags {
DigitLanguage = 0x0400,
All = 0x077f
};
+
+} // end vcl::pdf
+
namespace o3tl {
-template<> struct typed_flags :
is_typed_flags {};
+template<> struct typed_flags :
is_typed_flags {};
}
namespace vcl
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |6 +++---
vcl/source/gdi/pdfwriter_impl.hxx |6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 0d3c9d26e83bbfebade5d696e80ef10f4a63de8c
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:21:58 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Dec 31 00:07:47 2019 +0100
pdf: move Mode out of PDFWriterImpl class and convert to enum class
Change-Id: I92e7ca9fb16ef932b61cef09762c42068498764d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86032
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 65437464de72..9599ca737822 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -7338,7 +7338,7 @@ void PDFWriterImpl::beginRedirect( SvStream* pStream,
const tools::Rectangle& rT
clearClipRegion();
// this is needed to point m_aCurrentPDFState at the pushed state
// ... but it's pointless to actually write into the "outer" stream here!
-updateGraphicsState(NOWRITE);
+updateGraphicsState(Mode::NOWRITE);
m_aOutputStreams.push_front( StreamRedirect() );
m_aOutputStreams.front().m_pStream = pStream;
@@ -7380,7 +7380,7 @@ SvStream* PDFWriterImpl::endRedirect()
m_aCurrentPDFState.m_aFillColor = COL_TRANSPARENT;
// needed after pop() to set m_aCurrentPDFState
-updateGraphicsState(NOWRITE);
+updateGraphicsState(Mode::NOWRITE);
return pStream;
}
@@ -9818,7 +9818,7 @@ void PDFWriterImpl::updateGraphicsState(Mode const mode)
// everything is up to date now
m_aCurrentPDFState = m_aGraphicsStack.front();
-if ((mode != NOWRITE) && !aLine.isEmpty())
+if ((mode != Mode::NOWRITE) && !aLine.isEmpty())
writeBuffer( aLine.getStr(), aLine.getLength() );
}
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 59fc55aea458..ac580202a35b 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -589,6 +589,8 @@ struct GraphicsState
{}
};
+enum class Mode { DEFAULT, NOWRITE };
+
}
class PDFWriterImpl : public VirtualDevice
@@ -776,12 +778,10 @@ i12626
void drawRelief( SalLayout& rLayout, const OUString& rText, bool
bTextLines );
void drawShadow( SalLayout& rLayout, const OUString& rText, bool
bTextLines );
-enum Mode { DEFAULT, NOWRITE };
-
/* writes differences between graphics stack and current real PDF
* state to the file
*/
-void updateGraphicsState(Mode mode = DEFAULT);
+void updateGraphicsState(Mode mode = Mode::DEFAULT);
/* writes a transparency group object */
void writeTransparentObject( TransparencyEmit& rObject );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit 33bec7973ecb626ff5e2b40a6bf695e00adec6a7
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 19:54:25 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Dec 31 00:08:07 2019 +0100
pdf: change define constants to constexpr
Change-Id: I55dec1364d1329884270a86a6a200d050c08686c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86033
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index ac580202a35b..4ce4d7d9aea8 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -62,14 +62,13 @@ class SvStream;
class SvMemoryStream;
// the maximum password length
-#define ENCRYPTED_PWD_SIZE 32
-#define MD5_DIGEST_SIZE16
-#define SECUR_40BIT_KEY 5
+constexpr sal_Int32 ENCRYPTED_PWD_SIZE = 32;
+constexpr sal_Int32 MD5_DIGEST_SIZE = 16;
// security 128 bit
-#define SECUR_128BIT_KEY 16
+constexpr sal_Int32 SECUR_128BIT_KEY = 16;
// maximum length of MD5 digest input, in step 2 of algorithm 3.1
// PDF spec ver. 1.4: see there for details
-#define MAXIMUM_RC4_KEY_LENGTH (SECUR_128BIT_KEY+3+2)
+constexpr sal_Int32 MAXIMUM_RC4_KEY_LENGTH = SECUR_128BIT_KEY + 3 + 2;
enum class GraphicsStateUpdateFlags {
Font = 0x0001,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 57 +++---
1 file changed, 29 insertions(+), 28 deletions(-)
New commits:
commit dc3e13a83271423302beee1e4060dbc7a1178858
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:13:23 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Tue Dec 31 00:07:29 2019 +0100
pdf: move GraphicsState out of PDFWriterImpl class
Change-Id: I22a89410c4835e9d42b3e232d20154be033110e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86031
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 4c677e76b119..59fc55aea458 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -560,6 +560,35 @@ struct StreamRedirect
ResourceDictm_aResourceDict;
};
+// graphics state
+struct GraphicsState
+{
+vcl::Fontm_aFont;
+MapMode m_aMapMode;
+Colorm_aLineColor;
+Colorm_aFillColor;
+Colorm_aTextLineColor;
+Colorm_aOverlineColor;
+basegfx::B2DPolyPolygon m_aClipRegion;
+bool m_bClipRegion;
+ComplexTextLayoutFlagsm_nLayoutMode;
+LanguageType m_aDigitLanguage;
+PushFlagsm_nFlags;
+GraphicsStateUpdateFlags m_nUpdateFlags;
+
+GraphicsState() :
+m_aLineColor( COL_TRANSPARENT ),
+m_aFillColor( COL_TRANSPARENT ),
+m_aTextLineColor( COL_TRANSPARENT ),
+m_aOverlineColor( COL_TRANSPARENT ),
+m_bClipRegion( false ),
+m_nLayoutMode( ComplexTextLayoutFlags::Default ),
+m_aDigitLanguage( 0 ),
+m_nFlags( PushFlags::ALL ),
+m_nUpdateFlags( GraphicsStateUpdateFlags::All )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -684,34 +713,6 @@ private:
*/
std::list< StreamRedirect > m_aOutputStreams;
-// graphics state
-struct GraphicsState
-{
-vcl::Fontm_aFont;
-MapMode m_aMapMode;
-Colorm_aLineColor;
-Colorm_aFillColor;
-Colorm_aTextLineColor;
-Colorm_aOverlineColor;
-basegfx::B2DPolyPolygon m_aClipRegion;
-bool m_bClipRegion;
-ComplexTextLayoutFlagsm_nLayoutMode;
-LanguageType m_aDigitLanguage;
-PushFlagsm_nFlags;
-GraphicsStateUpdateFlags m_nUpdateFlags;
-
-GraphicsState() :
-m_aLineColor( COL_TRANSPARENT ),
-m_aFillColor( COL_TRANSPARENT ),
-m_aTextLineColor( COL_TRANSPARENT ),
-m_aOverlineColor( COL_TRANSPARENT ),
-m_bClipRegion( false ),
-m_nLayoutMode( ComplexTextLayoutFlags::Default ),
-m_aDigitLanguage( 0 ),
-m_nFlags( PushFlags::ALL ),
-m_nUpdateFlags( GraphicsStateUpdateFlags::All )
-{}
-};
std::list< GraphicsState > m_aGraphicsStack;
GraphicsState m_aCurrentPDFState;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #134 from Roger Paradise --- I installed the version from the 6.5.0.0 alpha link just provided. I'm still seeing the problem. (MacBook Pro 2014) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9622 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9622 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129622] Layout problem, listbox width too wide, in Options-LibreOffice-View dialog for RU GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=129622 V Stuart Foote changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8721 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
New commits:
commit 9cdcc900223a2727a2bca482bd5e70ea63e15a88
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:11:19 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 23:16:36 2019 +0100
pdf: move StreamRedirect out of PDFWriterImpl class
Change-Id: Ia11129ec83c041ffbf462c29bb814b400c1a3f56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86030
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 6e4a99f7bcf2..4c677e76b119 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -552,6 +552,14 @@ struct PDFGlyph
{}
};
+struct StreamRedirect
+{
+SvStream* m_pStream;
+MapMode m_aMapMode;
+tools::Rectangle m_aTargetRect;
+ResourceDictm_aResourceDict;
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -674,13 +682,6 @@ private:
/* output redirection; e.g. to accumulate content streams for
XObjects
*/
-struct StreamRedirect
-{
-SvStream* m_pStream;
-MapMode m_aMapMode;
-tools::Rectangle m_aTargetRect;
-ResourceDictm_aResourceDict;
-};
std::list< StreamRedirect > m_aOutputStreams;
// graphics state
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |4 +--
vcl/source/gdi/pdfwriter_impl.hxx | 44 +++---
2 files changed, 24 insertions(+), 24 deletions(-)
New commits:
commit 21aab417b0562a3629aaa8d93c669c62d71049f9
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:08:45 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 23:15:34 2019 +0100
pdf: move PDFGlyph out of PDFWriterImpl class
Change-Id: Icb536e45f92bd03e7b223d38e40565b0b55462c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86029
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 677987d81d97..65437464de72 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -5808,7 +5808,7 @@ void PDFWriterImpl::drawShadow( SalLayout& rLayout, const
OUString& rText, bool
}
void PDFWriterImpl::drawVerticalGlyphs(
-const std::vector& rGlyphs,
+const std::vector& rGlyphs,
OStringBuffer& rLine,
const Point& rAlignOffset,
const Matrix3& rRotScale,
@@ -5877,7 +5877,7 @@ void PDFWriterImpl::drawVerticalGlyphs(
}
void PDFWriterImpl::drawHorizontalGlyphs(
-const std::vector& rGlyphs,
+const std::vector& rGlyphs,
OStringBuffer& rLine,
const Point& rAlignOffset,
bool bFirst,
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 3302c533acfa..6e4a99f7bcf2 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -530,6 +530,28 @@ struct PDFAddStream
PDFAddStream() : m_pStream( nullptr ), m_nStreamObject( 0 ), m_bCompress(
true ) {}
};
+// helper structure for drawLayout and friends
+struct PDFGlyph
+{
+Point const m_aPos;
+const GlyphItem* m_pGlyph;
+sal_Int32 const m_nNativeWidth;
+sal_Int32 const m_nMappedFontId;
+sal_uInt8 const m_nMappedGlyphId;
+int const m_nCharPos;
+
+PDFGlyph( const Point& rPos,
+ const GlyphItem* pGlyph,
+ sal_Int32 nNativeWidth,
+ sal_Int32 nFontId,
+ sal_uInt8 nMappedGlyphId,
+ int nCharPos )
+: m_aPos( rPos ), m_pGlyph(pGlyph), m_nNativeWidth( nNativeWidth ),
+ m_nMappedFontId( nFontId ), m_nMappedGlyphId( nMappedGlyphId ),
+ m_nCharPos(nCharPos)
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -539,28 +561,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-// helper structure for drawLayout and friends
-struct PDFGlyph
-{
-Point const m_aPos;
-const GlyphItem* m_pGlyph;
-sal_Int32 const m_nNativeWidth;
-sal_Int32 const m_nMappedFontId;
-sal_uInt8 const m_nMappedGlyphId;
-int const m_nCharPos;
-
-PDFGlyph( const Point& rPos,
- const GlyphItem* pGlyph,
- sal_Int32 nNativeWidth,
- sal_Int32 nFontId,
- sal_uInt8 nMappedGlyphId,
- int nCharPos )
-: m_aPos( rPos ), m_pGlyph(pGlyph), m_nNativeWidth( nNativeWidth ),
- m_nMappedFontId( nFontId ), m_nMappedGlyphId( nMappedGlyphId ),
- m_nCharPos(nCharPos)
-{}
-};
-
static const char* getStructureTag( PDFWriter::StructElement );
static const char* getAttributeTag( PDFWriter::StructAttribute eAtr );
static const char* getAttributeValueTag( PDFWriter::StructAttributeValue
eVal );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 86 +++---
1 file changed, 43 insertions(+), 43 deletions(-)
New commits:
commit be3856df54e6a19041312479b8ffa8bd944aadd8
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:06:34 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 23:14:45 2019 +0100
pdf: move PDFAddStream out of PDFWriterImpl class
Change-Id: I3c96fcb3438f982fa6d40f806c4fc90db5025091
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86028
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 0ece9135782c..3302c533acfa 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -520,6 +520,16 @@ struct PDFStructureElement
};
+struct PDFAddStream
+{
+OUString m_aMimeType;
+PDFOutputStream*m_pStream;
+sal_Int32 m_nStreamObject;
+boolm_bCompress;
+
+PDFAddStream() : m_pStream( nullptr ), m_nStreamObject( 0 ), m_bCompress(
true ) {}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -529,16 +539,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFAddStream
-{
-OUString m_aMimeType;
-PDFOutputStream*m_pStream;
-sal_Int32 m_nStreamObject;
-boolm_bCompress;
-
-PDFAddStream() : m_pStream( nullptr ), m_nStreamObject( 0 ),
m_bCompress( true ) {}
-};
-
// helper structure for drawLayout and friends
struct PDFGlyph
{
commit a8085e5a0765ae078b3125dec7e05eddaecf9a1d
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:05:15 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 23:14:35 2019 +0100
pdf: move PDFStructureElement out of PDFWriterImpl class
Change-Id: I41b2f314f3eef7b28af7e1592a7167a216c1fd7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86027
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index eefb11b79d4b..0ece9135782c 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -487,6 +487,39 @@ struct PDFStructureElementKid // for Kids entries
PDFStructureElementKid( sal_Int32 MCID, sal_Int32 nPage ) : nObject( nPage
), nMCID( MCID ) {}
};
+struct PDFStructureElement
+{
+sal_Int32 m_nObject;
+PDFWriter::StructElementm_eType;
+OStringm_aAlias;
+sal_Int32 m_nOwnElement; //
index into structure vector
+sal_Int32 m_nParentElement; //
index into structure vector
+sal_Int32 m_nFirstPageObject;
+boolm_bOpenMCSeq;
+std::list< sal_Int32 > m_aChildren; //
indexes into structure vector
+std::list< PDFStructureElementKid > m_aKids;
+std::map
+m_aAttributes;
+tools::Rectanglem_aBBox;
+OUStringm_aActualText;
+OUStringm_aAltText;
+css::lang::Locale m_aLocale;
+
+// m_aContents contains the element's marked content sequence
+// as pairs of (page nr, MCID)
+
+PDFStructureElement()
+: m_nObject( 0 ),
+ m_eType( PDFWriter::NonStructElement ),
+ m_nOwnElement( -1 ),
+ m_nParentElement( -1 ),
+ m_nFirstPageObject( 0 ),
+ m_bOpenMCSeq( false )
+{
+}
+
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -496,39 +529,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFStructureElement
-{
-sal_Int32 m_nObject;
-PDFWriter::StructElementm_eType;
-OStringm_aAlias;
-sal_Int32 m_nOwnElement; //
index into structure vector
-sal_Int32 m_nParentElement;
// index into structure vector
-sal_Int32 m_nFirstPageObject;
-boolm_bOpenMCSeq;
-std::list< sal_Int32 > m_aChildren; //
indexes into structure vector
-std::list< PDFStructureElementKid > m_aKids;
-std::map
-
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #133 from Sebastian Djupsjöbacka --- Daily build 2019-12-30 works well, still no blur. This time the report also contains the exact download link as requested. Version: 6.5.0.0.alpha0+ Build ID: e258dcb9134be64a826547407de3482e5bb2a80b CPU threads: 2; OS: Mac OS X 10.13.6; UI render: default; VCL: osx; Locale: en-US (en_FI.UTF-8); UI-Language: en-US Calc: threaded Download link: https://dev-builds.libreoffice.org/daily/master/MacOSX-x86_64@tb81-TDF/2019-12-30_05.29.53/LibreOfficeDev_6.5.0.0.alpha0_MacOS_x86-64.dmg -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125536] Garbled combo box within Format / Character / Font dialog box on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=125536 Thorsten Wagner changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125532] Characters rendered black on selected dialog tabs on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=125532 Thorsten Wagner changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126506] Tab label too low within macro editor
https://bugs.documentfoundation.org/show_bug.cgi?id=126506 Andreas Heinisch changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129704] hyphenation with big string and wrap picture bad on first line
https://bugs.documentfoundation.org/show_bug.cgi?id=129704 --- Comment #2 from Mike Kaganski --- Created attachment 156858 --> https://bugs.documentfoundation.org/attachment.cgi?id=156858=edit A long line and an image with page wrap Trying to move the image up (e.g., clicking it and then pressing arrow up key) will demonstrate the problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129704] hyphenation with big string and wrap picture bad on first line
https://bugs.documentfoundation.org/show_bug.cgi?id=129704 Mike Kaganski changed: What|Removed |Added Version|6.4.0.1 rc |Inherited From OOo Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Mike Kaganski --- Repro - also with OpenOffice.org 3.2.0 OOO320m12 (Build:9483). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129704] New: hyphenation with big string and wrap picture bad on first line
https://bugs.documentfoundation.org/show_bug.cgi?id=129704 Bug ID: 129704 Summary: hyphenation with big string and wrap picture bad on first line Product: LibreOffice Version: 6.4.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: noscollecti...@gmail.com Description: type a very long string in a writer document. The test is better if you do a string that cover many lines (10 lines). At the end of the line, the continuation continues on the next line and this for the 10 lines. This is normal. Now I insert a picture in the document with wrap to "page wrap" or " "optimal page wrap" or left or right wrap. put the picture a the right of the page, under the string. Move up the picture to be inside the string.AT the begining this is good. But if the picture cross the first line of the string, the first line can't be break by hyphenation and all the paragraph is move to the buttom of the picture. So paragraph presentation is wrong with the picture. I have see this probleme since several versions. Steps to Reproduce: 1.type a very ling string in writer (10 lines) 2.insert picture (width 4cm for exemple) 3.put the picture on the right of paragraph string 4. if the picture cross the first string line, all the string if move under the picture Actual Results: all the string if move under the picture Expected Results: 1er line must be break by hyphenation like the line 2 and the next to have a correct presentation. Like a paragrapheof several lines with words. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: test with several windows versions, also in linux 4.3.3.2 if you put textbox and not picture, the problem is the same -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129659] CRASH on file opening
https://bugs.documentfoundation.org/show_bug.cgi?id=129659 Telesto changed: What|Removed |Added Keywords||bibisectRequest, ||possibleRegression --- Comment #4 from Telesto --- The file can be opened, following bug 120351. So a regression i guess -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 26000465c11656b4189b524546c661cacd555e36
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:03:21 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 21:16:21 2019 +0100
pdf: move PDFStructureElementKid out of PDFWriterImpl class
Change-Id: I4d213944d83b70058be2ed676a5533481904169e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86023
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 9ca568cbea64..eefb11b79d4b 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -477,6 +477,16 @@ struct PDFStructureAttribute
{}
};
+struct PDFStructureElementKid // for Kids entries
+{
+sal_Int32 const nObject; // an object number if nMCID is -1,
+// else the page object relevant to MCID
+sal_Int32 const nMCID;// an MCID if >= 0
+
+explicit PDFStructureElementKid( sal_Int32 nObj ) : nObject( nObj ),
nMCID( -1 ) {}
+PDFStructureElementKid( sal_Int32 MCID, sal_Int32 nPage ) : nObject( nPage
), nMCID( MCID ) {}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -486,16 +496,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFStructureElementKid // for Kids entries
-{
-sal_Int32 const nObject; // an object number if nMCID is -1,
-// else the page object relevant to MCID
-sal_Int32 const nMCID;// an MCID if >= 0
-
-explicit PDFStructureElementKid( sal_Int32 nObj ) : nObject( nObj ),
nMCID( -1 ) {}
-PDFStructureElementKid( sal_Int32 MCID, sal_Int32 nPage ) : nObject(
nPage ), nMCID( MCID ) {}
-};
-
struct PDFStructureElement
{
sal_Int32 m_nObject;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |4 -
vcl/source/gdi/pdfwriter_impl.hxx | 92 +++---
2 files changed, 48 insertions(+), 48 deletions(-)
New commits:
commit c6ea20161c7e8004021ad3b6976a2b35ac8b9b31
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:57:54 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 21:15:03 2019 +0100
pdf: move PDFWidget out of PDFWriterImpl class
Change-Id: I0fce968ec566cb663352ecb57279110f0ae9f3e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86021
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 3f1a3aaadb7f..372d5e2c15d7 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -5421,9 +5421,9 @@ struct AnnotSortContainer
struct AnnotSorterLess
{
-std::vector< PDFWriterImpl::PDFWidget >& m_rWidgets;
+std::vector& m_rWidgets;
-explicit AnnotSorterLess( std::vector< PDFWriterImpl::PDFWidget >&
rWidgets ) : m_rWidgets( rWidgets ) {}
+explicit AnnotSorterLess( std::vector& rWidgets ) : m_rWidgets(
rWidgets ) {}
bool operator()( const AnnotationSortEntry& rLeft, const
AnnotationSortEntry& rRight )
{
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index c2145aa8c2de..9c4a527aa5ab 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -410,6 +410,52 @@ struct PDFScreen : public PDFAnnotation
}
};
+struct PDFWidget : public PDFAnnotation
+{
+typedef std::unordered_map PDFAppearanceStreams;
+
+PDFWriter::WidgetType m_eType;
+OStringm_aName;
+OUString m_aDescription;
+OUString m_aText;
+DrawTextFlags m_nTextStyle;
+OUString m_aValue;
+OStringm_aDAString;
+OStringm_aDRDict;
+OStringm_aMKDict;
+OStringm_aMKDictCAString; // i12626, added to be able to
encrypt the /CA text string
+// since the object number
is not known at the moment
+// of filling m_aMKDict,
the string will be encrypted when emitted.
+// the /CA string MUST BE
the last added to m_aMKDict
+// see code for details
+sal_Int32 m_nFlags;
+sal_Int32 m_nParent; // if not 0, parent's object number
+std::vector m_aKids; // widget children, contains object
numbers
+std::vector m_aKidsIndex; // widget children, contains
index to m_aWidgets
+OUString m_aOnValue;
+sal_Int32 m_nTabOrder; // lowest number gets first in
tab order
+sal_Int32 m_nRadioGroup;
+sal_Int32 m_nMaxLen;
+boolm_bSubmit;
+boolm_bSubmitGet;
+sal_Int32 m_nDest;
+std::vector m_aListEntries;
+std::vector m_aSelectedEntries;
+std::unordered_map m_aAppearances;
+PDFWidget()
+: m_eType( PDFWriter::PushButton ),
+ m_nTextStyle( DrawTextFlags::NONE ),
+ m_nFlags( 0 ),
+ m_nParent( 0 ),
+ m_nTabOrder( 0 ),
+ m_nRadioGroup( -1 ),
+ m_nMaxLen( 0 ),
+ m_bSubmit( false ),
+ m_bSubmitGet( false ),
+ m_nDest( -1 )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -419,52 +465,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFWidget : public PDFAnnotation
-{
-typedef std::unordered_map
PDFAppearanceStreams;
-
-PDFWriter::WidgetType m_eType;
-OStringm_aName;
-OUString m_aDescription;
-OUString m_aText;
-DrawTextFlags m_nTextStyle;
-OUString m_aValue;
-OStringm_aDAString;
-OStringm_aDRDict;
-OStringm_aMKDict;
-OStringm_aMKDictCAString; // i12626, added to be able
to encrypt the /CA text string
-// since the object
number is not known at the moment
-// of filling
m_aMKDict, the string will be encrypted when emitted.
-// the /CA string MUST
BE the last added to m_aMKDict
-// see code for details
-sal_Int32 m_nFlags;
-sal_Int32
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |2 -
vcl/source/gdi/pdfwriter_impl.hxx | 42 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
New commits:
commit c19db4b31764727673bdfc959a1ee4860dcc44b6
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 18:02:08 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 21:15:20 2019 +0100
pdf: move PDFStructureAttribute out of PDFWriterImpl class
Change-Id: I4fb49c00fd9298d76b3c562d10115d4e8a04ab42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86022
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 372d5e2c15d7..677987d81d97 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -1932,7 +1932,7 @@ const char* PDFWriterImpl::getAttributeValueTag(
PDFWriter::StructAttributeValue
return it != aValueStrings.end() ? it->second : "";
}
-static void appendStructureAttributeLine( PDFWriter::StructAttribute i_eAttr,
const PDFWriterImpl::PDFStructureAttribute& i_rVal, OStringBuffer& o_rLine,
bool i_bIsFixedInt )
+static void appendStructureAttributeLine( PDFWriter::StructAttribute i_eAttr,
const PDFStructureAttribute& i_rVal, OStringBuffer& o_rLine, bool i_bIsFixedInt
)
{
o_rLine.append( "/" );
o_rLine.append( PDFWriterImpl::getAttributeTag( i_eAttr ) );
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 9c4a527aa5ab..9ca568cbea64 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -456,6 +456,27 @@ struct PDFWidget : public PDFAnnotation
{}
};
+struct PDFStructureAttribute
+{
+PDFWriter::StructAttributeValue eValue;
+sal_Int32 nValue;
+
+PDFStructureAttribute()
+: eValue( PDFWriter::Invalid ),
+ nValue( 0 )
+{}
+
+explicit PDFStructureAttribute( PDFWriter::StructAttributeValue eVal )
+: eValue( eVal ),
+ nValue( 0 )
+{}
+
+explicit PDFStructureAttribute( sal_Int32 nVal )
+: eValue( PDFWriter::Invalid ),
+ nValue( nVal )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -465,27 +486,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFStructureAttribute
-{
-PDFWriter::StructAttributeValue eValue;
-sal_Int32 nValue;
-
-PDFStructureAttribute()
-: eValue( PDFWriter::Invalid ),
- nValue( 0 )
-{}
-
-explicit PDFStructureAttribute( PDFWriter::StructAttributeValue eVal )
-: eValue( eVal ),
- nValue( 0 )
-{}
-
-explicit PDFStructureAttribute( sal_Int32 nVal )
-: eValue( PDFWriter::Invalid ),
- nValue( nVal )
-{}
-};
-
struct PDFStructureElementKid // for Kids entries
{
sal_Int32 const nObject; // an object number if nMCID is -1,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
New commits:
commit 7cd0a5b1a1b23a7c50b92302511e081703c8ec3a
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:54:55 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 21:14:37 2019 +0100
pdf: move PDFScreen out of PDFWriterImpl class
Change-Id: I9d41a1a1daac66ca760ae47e88b17bd97a1278e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86020
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 62a6f467adf2..c2145aa8c2de 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -394,6 +394,22 @@ struct PDFNoteEntry : public PDFAnnotation
{}
};
+/// A PDF Screen annotation.
+struct PDFScreen : public PDFAnnotation
+{
+/// Linked video.
+OUString m_aURL;
+/// Embedded video.
+OUString m_aTempFileURL;
+/// ID of the EmbeddedFile object.
+sal_Int32 m_nTempFileObject;
+
+PDFScreen()
+: m_nTempFileObject(0)
+{
+}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -403,22 +419,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-/// A PDF Screen annotation.
-struct PDFScreen : public PDFAnnotation
-{
-/// Linked video.
-OUString m_aURL;
-/// Embedded video.
-OUString m_aTempFileURL;
-/// ID of the EmbeddedFile object.
-sal_Int32 m_nTempFileObject;
-
-PDFScreen()
-: m_nTempFileObject(0)
-{
-}
-};
-
struct PDFWidget : public PDFAnnotation
{
typedef std::unordered_map
PDFAppearanceStreams;
commit 7327e9b392124679280921131079d2c4ca2588b7
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:53:49 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 21:14:24 2019 +0100
pdf: move PDFNoteEntry out of PDFWriterImpl class
Change-Id: I1837f85fe1a532c644581ca3103808247b335295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86019
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 37b2d6762fdc..62a6f467adf2 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -386,6 +386,14 @@ struct PDFEmbeddedFile
}
};
+struct PDFNoteEntry : public PDFAnnotation
+{
+PDFNote m_aContents;
+
+PDFNoteEntry()
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -411,14 +419,6 @@ public:
}
};
-struct PDFNoteEntry : public PDFAnnotation
-{
-PDFNote m_aContents;
-
-PDFNoteEntry()
-{}
-};
-
struct PDFWidget : public PDFAnnotation
{
typedef std::unordered_map
PDFAppearanceStreams;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
New commits:
commit dec7ec8a73f1bb24099ab5f0a5dd8733bbf3
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:52:40 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 21:14:06 2019 +0100
pdf: move PDFEmbeddedFile out of PDFWriterImpl class
Change-Id: Idde43d29ebee795319ced46667d89bfda3f7ec8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86018
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 899fa0eac71f..37b2d6762fdc 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -372,6 +372,20 @@ struct PDFLink : public PDFAnnotation
{}
};
+/// A PDF embedded file.
+struct PDFEmbeddedFile
+{
+/// ID of the file.
+sal_Int32 m_nObject;
+/// Contents of the file.
+std::shared_ptr> m_pData;
+
+PDFEmbeddedFile()
+: m_nObject(0)
+{
+}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -397,20 +411,6 @@ public:
}
};
-/// A PDF embedded file.
-struct PDFEmbeddedFile
-{
-/// ID of the file.
-sal_Int32 m_nObject;
-/// Contents of the file.
-std::shared_ptr> m_pData;
-
-PDFEmbeddedFile()
-: m_nObject(0)
-{
-}
-};
-
struct PDFNoteEntry : public PDFAnnotation
{
PDFNote m_aContents;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129672] Export pdf -> impossible d'extraire la police incorporée DAAAAA+ LiberationSerif.
https://bugs.documentfoundation.org/show_bug.cgi?id=129672 --- Comment #6 from Mansuz --- with 6.3.4, I also have the bug. my file must be corrupt. It has been restored several times. How the cleaner? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84838] trying to Copy text causes crash shutdown on windows document in SUSE
https://bugs.documentfoundation.org/show_bug.cgi?id=84838 --- Comment #11 from podsigara --- After a thorough research I found the best solution. I'm posting you here for support. https://www.podmodelektroniksigara.com Thank you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 24
1 file changed, 12 insertions(+), 12 deletions(-)
New commits:
commit c13dda739056ac8c37d29ea4ac08dd140d2e4563
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:51:32 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 20:49:37 2019 +0100
pdf: move PDFLink out of PDFWriterImpl class
Change-Id: If0a5e148e97c5ea11a70fe737e114cf7ff6f15a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86017
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 1e6f40c24843..899fa0eac71f 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -360,6 +360,18 @@ struct PDFAnnotation
{}
};
+struct PDFLink : public PDFAnnotation
+{
+sal_Int32 m_nDest; // set to -1 for URL, to a dest else
+OUString m_aURL;
+sal_Int32 m_nStructParent; // struct parent entry
+
+PDFLink()
+: m_nDest( -1 ),
+ m_nStructParent( -1 )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -369,18 +381,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFLink : public PDFAnnotation
-{
-sal_Int32 m_nDest; // set to -1 for URL, to a dest
else
-OUString m_aURL;
-sal_Int32 m_nStructParent; // struct parent entry
-
-PDFLink()
-: m_nDest( -1 ),
- m_nStructParent( -1 )
-{}
-};
-
/// A PDF Screen annotation.
struct PDFScreen : public PDFAnnotation
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129672] Export pdf -> impossible d'extraire la police incorporée DAAAAA+ LiberationSerif.
https://bugs.documentfoundation.org/show_bug.cgi?id=129672 --- Comment #5 from Mansuz --- https://fr.libreoffice.org/ I don't have version 6.3.4.2, or 6.5.0.0.alpha0 +. I only have the version: 6.3.3.2. I tried with earlier versions. I have the same problem. The pdf export generates a problem on my file. With Adobe Reader I have an error. And my printer has a truncated file after upload to the server. je vais télécharger la 6.3.4 pour tester. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: 2 commits - AllLangPackage_html_media_lang.mk Package_html_media.mk source/media source/text
AllLangPackage_html_media_lang.mk |2 Package_html_media.mk |2 source/media/screenshots/modules/simpress/ui/customanimationtexttab/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/af/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/am/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/ar/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/as/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/ast/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/be/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/bg/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/bn-IN/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/bn/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/bo/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/br/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/brx/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/bs/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/ca-valencia/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/ca/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/cs/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/cy/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/da/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/de/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/dgo/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/dsb/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/dz/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/el/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/en-GB/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/en-ZA/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/eo/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/es/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/et/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/eu/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/fa/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/fi/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/fr/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/fy/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/ga/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/gd/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/gl/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/gu/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/gug/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/he/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/hi/TextAnimationTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationtexttab/hr/TextAnimationTab.png |binary
[Libreoffice-commits] core.git: 2 commits - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bf267565381c51526c8c85c3c4dd3469e81d Author: Olivier Hallot AuthorDate: Mon Dec 30 16:03:18 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Dec 30 20:03:18 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 6c1caad97684f883c802f66588674e333dd66861 - Add screenshot for text animation help page Change-Id: Ic7988ead5f7cd23e89a684d5c9835ab6102dcdd9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86008 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 39313533e950..6c1caad97684 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 39313533e9503da346ac626e6480faa8d21a64c4 +Subproject commit 6c1caad97684f883c802f66588674e333dd66861 commit 796819b3a08b4d53168bd149b0985583679ba180 Author: Olivier Hallot AuthorDate: Mon Dec 30 16:02:55 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Dec 30 20:02:55 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 39313533e9503da346ac626e6480faa8d21a64c4 - Add screenshot for enhanced animation effects Change-Id: I51750fb6c756cca0b700f2dde49702b4143f5a34 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/85997 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 1d0961caddb9..39313533e950 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 1d0961caddb984150ce61d21200d5b08aefa3084 +Subproject commit 39313533e9503da346ac626e6480faa8d21a64c4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangPackage_html_media_lang.mk Package_html_media.mk source/media source/text
AllLangPackage_html_media_lang.mk |1 Package_html_media.mk |1 source/media/screenshots/modules/simpress/ui/customanimationeffecttab/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/af/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/am/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/ar/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/as/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/ast/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/be/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/bg/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/bn-IN/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/bn/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/bo/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/br/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/brx/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/bs/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/ca-valencia/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/ca/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/cs/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/cy/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/da/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/de/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/dgo/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/dsb/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/dz/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/el/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/en-GB/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/en-ZA/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/eo/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/es/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/et/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/eu/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/fa/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/fi/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/fr/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/fy/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/ga/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/gd/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/gl/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/gu/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/gug/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/he/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/hi/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/hr/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/hsb/EffectTab.png |binary source/media/screenshots/modules/simpress/ui/customanimationeffecttab/hu/EffectTab.png |binary
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7f2d408ccd8176d199cfc8616587652f2d8cc126 Author: Olivier Hallot AuthorDate: Mon Dec 30 16:03:37 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Dec 30 20:03:37 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 363bc1ec76f31829614a103213b0fac3174599c1 - Add animation timing screenhot to help page Change-Id: Ieb94d4b05ad2a1105cf50731ec870f1a796a7ea5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86009 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 6c1caad97684..363bc1ec76f3 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 6c1caad97684f883c802f66588674e333dd66861 +Subproject commit 363bc1ec76f31829614a103213b0fac3174599c1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/source vcl/unx
vcl/source/gdi/pdfwriter_impl.hxx | 24
vcl/unx/gtk3/gtk3gtkobject.cxx|4 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 69b221263be58118b3293363ab9ecf7581c50c6f
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:50:25 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 19:45:18 2019 +0100
pdf: move PDFAnnotation out of PDFWriterImpl class
Change-Id: I37db3419eeaa8c5f8096a663a2ccede178bfadf7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86016
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 8ee67280c962..1e6f40c24843 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -348,6 +348,18 @@ struct PDFOutlineEntry
{}
};
+struct PDFAnnotation
+{
+sal_Int32 m_nObject;
+tools::Rectangle m_aRect;
+sal_Int32 m_nPage;
+
+PDFAnnotation()
+: m_nObject( -1 ),
+ m_nPage( -1 )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -357,18 +369,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFAnnotation
-{
-sal_Int32 m_nObject;
-tools::Rectangle m_aRect;
-sal_Int32 m_nPage;
-
-PDFAnnotation()
-: m_nObject( -1 ),
- m_nPage( -1 )
-{}
-};
-
struct PDFLink : public PDFAnnotation
{
sal_Int32 m_nDest; // set to -1 for URL, to a dest
else
commit 82a22f62e5b1c7bfa7fb117a0423475f10410194
Author: Stephan Bergmann
AuthorDate: Sun Dec 29 23:24:42 2019 +0100
Commit: Stephan Bergmann
CommitDate: Mon Dec 30 19:45:10 2019 +0100
Fix GDK_KEY_RELEASE -> GDK_KEY_RELEASE_MASK
...as found with recent Clang 10 trunk:
> vcl/unx/gtk3/gtk3gtkobject.cxx:255:76: error: bitwise operation between
different enumeration types ('GdkEventMask' and 'GdkEventType') is deprecated
[-Werror,-Wdeprecated-enum-enum-conversion]
> gtk_widget_add_events( GTK_WIDGET( m_pSocket ),
GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE );
>
~~ ^ ~~~
This is presumably a typo originating with
31fa4545985acc1594107e087cedc2d99b3d0f0b "split the gtk2 and gtk2
gtkobjects".
states that the "gint events" parameter of gtk_widget_add_events is "an
event
mask, see GdkEventMask", and /usr/include/gtk-3.0/gdk/gdktypes.h has
> typedef enum
> {
[...]
> GDK_KEY_PRESS_MASK= 1 << 10,
> GDK_KEY_RELEASE_MASK = 1 << 11,
[...]
> } GdkEventMask;
while /usr/include/gtk-3.0/gdk/gdkevents.h (both
gtk3-devel-3.24.13-1.fc31.x86_64) has
> typedef enum
> {
[...]
> GDK_KEY_PRESS = 8,
> GDK_KEY_RELEASE = 9,
[...]
> } GdkEventType;
Change-Id: I23acfef5e59803d2b71eed6c65a78e9895e415af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85971
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/unx/gtk3/gtk3gtkobject.cxx b/vcl/unx/gtk3/gtk3gtkobject.cxx
index d038a6121432..9b9fff958908 100644
--- a/vcl/unx/gtk3/gtk3gtkobject.cxx
+++ b/vcl/unx/gtk3/gtk3gtkobject.cxx
@@ -252,9 +252,9 @@ void GtkSalObject::signalDestroy( GtkWidget* pObj, gpointer
object )
void GtkSalObjectBase::SetForwardKey( bool bEnable )
{
if( bEnable )
-gtk_widget_add_events( GTK_WIDGET( m_pSocket ), GDK_KEY_PRESS_MASK |
GDK_KEY_RELEASE );
+gtk_widget_add_events( GTK_WIDGET( m_pSocket ), GDK_KEY_PRESS_MASK |
GDK_KEY_RELEASE_MASK );
else
-gtk_widget_set_events( GTK_WIDGET( m_pSocket ), ~(GDK_KEY_PRESS_MASK |
GDK_KEY_RELEASE) & gtk_widget_get_events( GTK_WIDGET( m_pSocket ) ) );
+gtk_widget_set_events( GTK_WIDGET( m_pSocket ), ~(GDK_KEY_PRESS_MASK |
GDK_KEY_RELEASE_MASK) & gtk_widget_get_events( GTK_WIDGET( m_pSocket ) ) );
}
GtkSalObjectWidgetClip::GtkSalObjectWidgetClip(GtkSalFrame* pParent, bool
bShow)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/servicemanager.cxx | 144 +--
cppuhelper/source/servicemanager.hxx | 69 +---
2 files changed, 95 insertions(+), 118 deletions(-)
New commits:
commit c97965e1b5b890a2a48d87d7a060396be71f2a00
Author: Stephan Bergmann
AuthorDate: Mon Dec 30 16:36:57 2019 +0100
Commit: Stephan Bergmann
CommitDate: Mon Dec 30 19:42:49 2019 +0100
Merge ImplementationInfo back into Implementation
...and rename constructor members to constructorName/constructorFn for
disambiguation.
"Splitting ImplementationInfo out of Implementation has become necessary to
avoid circular references" in c16d0dd846e25df56feffe868a15eb33bb55e42a
"fdo#49291 Postpone actual factory instantiation as long as possible", but
was
no longer necessary since 997d21183322a0a94b96868073808841d2773902 "Support
for
singleton constructor functions" (which also removed the need to hold
ImplemenationInfo by shared_ptr, which has already been cleaned up with
fc11bce4917aae7e8324f2c721ce50a88d231b0c "ImplementationInfo can be
inlined").
Change-Id: I51467aa7b1fce56d6549738efd1f34f91925dac5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86013
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/cppuhelper/source/servicemanager.cxx
b/cppuhelper/source/servicemanager.cxx
index c9a21ba1a557..9f4f541b1388 100644
--- a/cppuhelper/source/servicemanager.cxx
+++ b/cppuhelper/source/servicemanager.cxx
@@ -391,13 +391,13 @@ void Parser::handleImplementation() {
void Parser::handleService() {
OUString name(getNameAttribute());
-implementation_->info.services.push_back(name);
+implementation_->services.push_back(name);
data_->services[name].push_back(implementation_);
}
void Parser::handleSingleton() {
OUString name(getNameAttribute());
-implementation_->info.singletons.push_back(name);
+implementation_->singletons.push_back(name);
data_->singletons[name].push_back(implementation_);
}
@@ -614,7 +614,7 @@ OUString ImplementationWrapper::getImplementationName()
{
std::shared_ptr< cppuhelper::ServiceManager::Data::Implementation > impl =
implementation_.lock();
assert(impl);
-return impl->info.name;
+return impl->name;
}
sal_Bool ImplementationWrapper::supportsService(OUString const & ServiceName)
@@ -627,15 +627,15 @@ ImplementationWrapper::getSupportedServiceNames()
{
std::shared_ptr< cppuhelper::ServiceManager::Data::Implementation > impl =
implementation_.lock();
assert(impl);
-if (impl->info.services.size()
+if (impl->services.size()
> static_cast< sal_uInt32 >(SAL_MAX_INT32))
{
throw css::uno::RuntimeException(
-("Implementation " + impl->info.name
+("Implementation " + impl->name
+ " supports too many services"),
static_cast< cppu::OWeakObject * >(this));
}
-return comphelper::containerToSequence(impl->info.services);
+return comphelper::containerToSequence(impl->services);
}
}
@@ -646,9 +646,9 @@
cppuhelper::ServiceManager::Data::Implementation::createInstance(
bool singletonRequest)
{
css::uno::Reference inst;
-if (constructor) {
+if (constructorFn) {
inst.set(
-constructor(context.get(), css::uno::Sequence()),
+constructorFn(context.get(), css::uno::Sequence()),
SAL_NO_ACQUIRE);
} else if (factory1.is()) {
inst = factory1->createInstanceWithContext(context);
@@ -666,8 +666,8 @@
cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(
bool singletonRequest, css::uno::Sequence const & arguments)
{
css::uno::Reference inst;
-if (constructor) {
-inst.set(constructor(context.get(), arguments), SAL_NO_ACQUIRE);
+if (constructorFn) {
+inst.set(constructorFn(context.get(), arguments), SAL_NO_ACQUIRE);
//HACK: The constructor will either observe arguments and return inst
// that does not implement XInitialization (or null), or ignore
// arguments and return inst that implements XInitialization; this
@@ -703,7 +703,7 @@ void
cppuhelper::ServiceManager::Data::Implementation::updateDisposeSingleton(
osl::MutexGuard g(mutex);
disposeSingleton.clear();
dispose = false;
-} else if (!info.singletons.empty()) {
+} else if (!singletons.empty()) {
css::uno::Reference comp(
instance, css::uno::UNO_QUERY);
if (comp.is()) {
@@ -725,7 +725,7 @@ void cppuhelper::ServiceManager::addSingletonContextEntries(
assert(rImpls[0].get() != nullptr);
SAL_INFO_IF(
rImpls.size() > 1, "cppuhelper",
-"Arbitrarily choosing " << rImpls[0]->info.name
+"Arbitrarily choosing " << rImpls[0]->name
<< " among multiple implementations for " << rName);
[Libreoffice-commits] core.git: configmgr/source
configmgr/source/access.hxx|1 - configmgr/source/components.hxx|1 - configmgr/source/configurationprovider.cxx |1 - configmgr/source/rootaccess.hxx|1 - configmgr/source/update.cxx|1 - 5 files changed, 5 deletions(-) New commits: commit 87dd1232054b4c85a2bdadc8aa2c84dd4947bedb Author: Stephan Bergmann AuthorDate: Mon Dec 30 16:35:01 2019 +0100 Commit: Stephan Bergmann CommitDate: Mon Dec 30 19:42:19 2019 +0100 Clean up newly unused includes ...after 122598af564082786f01b4eafdb9f09f0cffdf5f "no need to use shared_ptr here" Change-Id: I5b7525388eed96005c9163a58c9b260d0b100cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86012 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/configmgr/source/access.hxx b/configmgr/source/access.hxx index 24f4ddadf665..db2decb48874 100644 --- a/configmgr/source/access.hxx +++ b/configmgr/source/access.hxx @@ -22,7 +22,6 @@ #include -#include #include #include #include "config_map.hxx" diff --git a/configmgr/source/components.hxx b/configmgr/source/components.hxx index f9e8ff0cd295..c23beee82777 100644 --- a/configmgr/source/components.hxx +++ b/configmgr/source/components.hxx @@ -22,7 +22,6 @@ #include -#include #include #include diff --git a/configmgr/source/configurationprovider.cxx b/configmgr/source/configurationprovider.cxx index 65e785e2afe1..7d39593ab62e 100644 --- a/configmgr/source/configurationprovider.cxx +++ b/configmgr/source/configurationprovider.cxx @@ -20,7 +20,6 @@ #include #include -#include #include #include diff --git a/configmgr/source/rootaccess.hxx b/configmgr/source/rootaccess.hxx index 8157f8e6c7a2..bc26179fc2e2 100644 --- a/configmgr/source/rootaccess.hxx +++ b/configmgr/source/rootaccess.hxx @@ -22,7 +22,6 @@ #include -#include #include #include diff --git a/configmgr/source/update.cxx b/configmgr/source/update.cxx index 983c2e88fac2..c8f6505243ee 100644 --- a/configmgr/source/update.cxx +++ b/configmgr/source/update.cxx @@ -20,7 +20,6 @@ #include #include -#include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svtools svtools/source
include/svtools/accessibilityoptions.hxx |5 +
svtools/source/config/accessibilityoptions.cxx |8
2 files changed, 1 insertion(+), 12 deletions(-)
New commits:
commit 3135d820d0172ef5695a4b97cec505e6ad03d67a
Author: Stephan Bergmann
AuthorDate: Mon Dec 23 22:34:20 2019 +0100
Commit: Stephan Bergmann
CommitDate: Mon Dec 30 19:41:53 2019 +0100
SvtAccessibilityOptions base SfxListener appears to be unused
Change-Id: I96fa0c6eb7f0510eb8233b98072fd555307f8329
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86011
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/svtools/accessibilityoptions.hxx
b/include/svtools/accessibilityoptions.hxx
index 6f2aebac5c83..06c24c009d10 100644
--- a/include/svtools/accessibilityoptions.hxx
+++ b/include/svtools/accessibilityoptions.hxx
@@ -20,13 +20,12 @@
#define INCLUDED_SVTOOLS_ACCESSIBILITYOPTIONS_HXX
#include
-#include
#include
class SvtAccessibilityOptions_Impl;
class SVT_DLLPUBLIC SvtAccessibilityOptions final :
-public utl::detail::Options, private SfxListener
+public utl::detail::Options
{
private:
static SvtAccessibilityOptions_Impl* sm_pSingleImplConfig;
@@ -43,8 +42,6 @@ public:
boolGetIsAutomaticFontColor() const;
boolIsSelectionInReadonly() const;
-//SfxListener:
-virtual voidNotify( SfxBroadcaster& rBC, const SfxHint& rHint )
override;
voidSetVCLSettings();
};
diff --git a/svtools/source/config/accessibilityoptions.cxx
b/svtools/source/config/accessibilityoptions.cxx
index 315a0333b7b7..43fa4287f9e0 100644
--- a/svtools/source/config/accessibilityoptions.cxx
+++ b/svtools/source/config/accessibilityoptions.cxx
@@ -28,8 +28,6 @@
#include
#include
-#include
-
#include
#include
#include
@@ -385,12 +383,6 @@ SvtAccessibilityOptions::~SvtAccessibilityOptions()
}
}
-void SvtAccessibilityOptions::Notify( SfxBroadcaster&, const SfxHint& )
-{
-NotifyListeners(ConfigurationHints::NONE);
-}
-
-
bool SvtAccessibilityOptions::GetIsForPagePreviews() const
{
return sm_pSingleImplConfig->GetIsForPagePreviews();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126886] Calc window contents are not visible when opening a CSV in Compiz from Calc 6.3
https://bugs.documentfoundation.org/show_bug.cgi?id=126886 Gabriel changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #8 from Gabriel --- Hello Xisco, It does work indeed if I open it with that command -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 124ebc32de32c8619618776b589934bae464711e
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 17:49:23 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 19:34:06 2019 +0100
pdf: move PDFOutlineEntry out of PDFWriterImpl class
Change-Id: I69e1c9821bde7c7a7164bef041bbe45a5ea2d4d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86015
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 8b2a98dbdad6..8ee67280c962 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -329,6 +329,25 @@ struct PDFNamedDest
tools::Rectangle m_aRect;
};
+struct PDFOutlineEntry
+{
+sal_Int32 m_nObject;
+sal_Int32 m_nParentObject;
+sal_Int32 m_nNextObject;
+sal_Int32 m_nPrevObject;
+std::vector< sal_Int32 >m_aChildren;
+OUString m_aTitle;
+sal_Int32 m_nDestID;
+
+PDFOutlineEntry()
+: m_nObject( 0 ),
+ m_nParentObject( 0 ),
+ m_nNextObject( 0 ),
+ m_nPrevObject( 0 ),
+ m_nDestID( -1 )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -338,25 +357,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFOutlineEntry
-{
-sal_Int32 m_nObject;
-sal_Int32 m_nParentObject;
-sal_Int32 m_nNextObject;
-sal_Int32 m_nPrevObject;
-std::vector< sal_Int32 >m_aChildren;
-OUString m_aTitle;
-sal_Int32 m_nDestID;
-
-PDFOutlineEntry()
-: m_nObject( 0 ),
- m_nParentObject( 0 ),
- m_nNextObject( 0 ),
- m_nPrevObject( 0 ),
- m_nDestID( -1 )
-{}
-};
-
struct PDFAnnotation
{
sal_Int32 m_nObject;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128910] DocumentFormat.OpenXml cannot open LibreOffice spreadsheet due to FileFormatException in WindowsBase.dll MS.Internal.IO.Zip.ZipIOLocalFileBlock.Validate
https://bugs.documentfoundation.org/show_bug.cgi?id=128910
Julien Nabet changed:
What|Removed |Added
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #13 from Julien Nabet ---
Thank you for your feedback.
I used 'unzip -t' on your last attachment and had the same warnings:
file #3 (docProps/app.xml):
mismatch between local and central GPF bit 11 ("UTF-8"),
continuing with central flag (IsUTF8 = 0)
testing: docProps/app.xml OK
file #4 (xl/styles.xml):
mismatch between local and central GPF bit 11 ("UTF-8"),
continuing with central flag (IsUTF8 = 0)
testing: xl/styles.xmlOK
file #5 (xl/workbook.xml):
mismatch between local and central GPF bit 11 ("UTF-8"),
continuing with central flag (IsUTF8 = 0)
testing: xl/workbook.xml OK
testing: [trash]/.dat OK
file #7 (xl/sharedStrings.xml):
mismatch between local and central GPF bit 11 ("UTF-8"),
continuing with central flag (IsUTF8 = 0)
testing: xl/sharedStrings.xml OK
file #8 (xl/worksheets/_rels/sheet1.xml.rels):
mismatch between local and central GPF bit 11 ("UTF-8"),
continuing with central flag (IsUTF8 = 0)
testing: xl/worksheets/_rels/sheet1.xml.rels OK
file #9 (xl/worksheets/sheet1.xml):
mismatch between local and central GPF bit 11 ("UTF-8"),
continuing with central flag (IsUTF8 = 0)
Let's put this one to NEW.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93831] FILEOPEN XLSX Slow to open
https://bugs.documentfoundation.org/show_bug.cgi?id=93831 --- Comment #13 from Julien Nabet --- Created attachment 156857 --> https://bugs.documentfoundation.org/attachment.cgi?id=156857=edit Flamegraph Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129697] New Help: the heading "Global" is not translatable
https://bugs.documentfoundation.org/show_bug.cgi?id=129697 --- Comment #2 from Mihkel Tõnnov --- The other modules expectedly so, as they are proper nouns - unlike "Global". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88109] PERF: Calc autofill is very slow
https://bugs.documentfoundation.org/show_bug.cgi?id=88109 --- Comment #11 from Julien Nabet --- Created attachment 156856 --> https://bugs.documentfoundation.org/attachment.cgi?id=156856=edit perf flamegraph Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] UI Calc-File has empty/invisible menu options in LO 6.4.0.1 WIN10 x64
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 karsten.henn...@gmx.de changed: What|Removed |Added CC||karsten.henn...@gmx.de --- Comment #1 from karsten.henn...@gmx.de --- Created attachment 156855 --> https://bugs.documentfoundation.org/attachment.cgi?id=156855=edit empty menu in Calc This is a Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129703] New: UI Calc-File has empty/invisible menu options in LO 6.4.0.1 WIN10 x64
https://bugs.documentfoundation.org/show_bug.cgi?id=129703 Bug ID: 129703 Summary: UI Calc-File has empty/invisible menu options in LO 6.4.0.1 WIN10 x64 Product: LibreOffice Version: 6.4.0.1 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: karsten.henn...@gmx.de Description: After updating to version 6.4.0.1 no more menu options in a Calc file. The Calc file uses conditional formatting and is saved with password. A new file with conditional formatting does not have this effect. Also without this effect the file can be opened in the same Linux version. This is due to Windows 10 (1803). Actual Results: no more menu options in a Calc file Expected Results: All menu options in a Calc file Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129702] New: [UI] Smart tags wrongly listed in AutoCorrect options dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129702 Bug ID: 129702 Summary: [UI] Smart tags wrongly listed in AutoCorrect options dialog Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jeanmarczam...@gmail.com Description: When one or more smart tags extensions are installed, the available smart tag types should be listed in the "Smart Tags" tab of the AutoCorrect options dialog (Tools -> AutoCorrect -> AutoCorrect Options...), following the scheme " ()". This works fine in OpenOffice. In LibreOffice, the names are all replaced by the boolean strings "TRUE" or "FALSE", according to the check box status. It's therefore impossible to know which smart tag types are active or not. If needed, one can test with this smart tags extension from Hanya: https://forum.openoffice.org/en/forum/viewtopic.php?p=387917#p387917. Steps to Reproduce: 1. install a smart tags extension (see link above if needed); 2. restart the program; 3. open the AutoCorrect options dialog and see the "Smart Tags" tab. Actual Results: The listbox only shows "TRUE" or, if unchecked, "FALSE". Expected Results: The listbox should show the smart tag caption and its recognizer name. Reproducible: Always User Profile Reset: No Additional Info: It probably happens in "FillListBox" from cui/source/tabpages/autocdlg.cxx (l. 2178), but I'm unable to really understand the C++ code. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129700] LibreOffice incorrectly display text inside drawn box for MS Word Document
https://bugs.documentfoundation.org/show_bug.cgi?id=129700 iantheprogram...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from iantheprogram...@gmail.com --- Thank you for reporting the bug. I can confirm that the bug is present in the most recent stable build on a Windows machine. Version: 6.3.4.2 (x64) Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 2; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xltools.cxx | 24
1 file changed, 24 insertions(+)
New commits:
commit c3c0d671e1025ef4a1485dd0b2aa20b8b3a3f3af
Author: Mike Kaganski
AuthorDate: Mon Dec 30 14:05:54 2019 +0100
Commit: Mike Kaganski
CommitDate: Mon Dec 30 17:43:50 2019 +0100
Document what is discovered about XclTools::GetXclDefColWidthCorrection
This is based only on "reverse-engineering" of the formula, and is not
necessarily correct.
Change-Id: I2fa09e07e38de6c706cc6bf4ede7da4f04cb7c54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85994
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/filter/excel/xltools.cxx
b/sc/source/filter/excel/xltools.cxx
index 9c94d10765c1..d8c5eb6f13c9 100644
--- a/sc/source/filter/excel/xltools.cxx
+++ b/sc/source/filter/excel/xltools.cxx
@@ -312,8 +312,32 @@ sal_uInt16 XclTools::GetXclColumnWidth( sal_uInt16
nScWidth, long nScCharWidth )
return limit_cast< sal_uInt16 >( fXclWidth );
}
+// takes font height in twips (1/20 pt = 1/1440 in)
+// returns correction value in 1/256th of *digit width* of default font
double XclTools::GetXclDefColWidthCorrection( long nXclDefFontHeight )
{
+// Excel uses *max digit width of default font* (W) as cell width unit.
Also it has 5-pixel
+// "correction" to cell widths (ECMA-376-1:2016 18.3.1.81): each cell has
1-pixel padding, then
+// 3 pixels for the border (which may be 1-pixel - hairline - then it will
have 2 additional
+// 1-pixel spacings from each side; or e.g. 2 hairlines with 1-pixel
spacing in the middle; or
+// thick 3-pixel). Obviously, correction size entirely depends on pixel
size (and it is actually
+// different in Excel on monitors with different resolution). Thus actual
(displayed/printed)
+// cell widths consist of X*W+5px; stored in file is the X (or X*256 if
1/256th of digit width
+// units are used) value.
+// This formula apparently converts this 5-pixel correction to 1/256th of
digit width units.
+// Looks like it is created from
+//
+//5 * 256 * 1440 * 2.1333 / (96 * max(N-15, 60)) + 50.0
+//
+// where 5 - pixel correction; 256 - used to produce 1/256th of digit
width; 1440 - used to
+// convert font height N (in twips) to inches; 2.1333 - an (empirical?)
quotient to convert
+// font *height* into digit *width*; 96 - "standard" monitor resolution
(DPI).
+// Additionally the formula uses 15 (of unknown origin), 60 (minimal font
height 3 pt), and
+// 50.0 (also of unknown origin).
+//
+// TODO: convert this to take font digit width directly (and possibly
DPI?), to avoid guessing
+// the digit width and pixel size. Or DPI might stay 96, to not follow
Excel dependency on DPI
+// in addition to used font, and have absolute size of the correction
fixed 5/96 in.
return 40960.0 / ::std::max( nXclDefFontHeight - 15, 60L ) + 50.0;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129437] [PYUNO] "setPropertyValue" method does not accept particular Enum value
https://bugs.documentfoundation.org/show_bug.cgi?id=129437 --- Comment #3 from jeanmarczam...@gmail.com --- Thanks both of you for your comments. I understand (I think) why the definition of the interface can't be changed. But I'm not sure at all why this report is marked as "NOTABUG", while it obviously concerns a defect: the error is not the expected behaviour, and doesn't occur with other languages, especially basic and java. Isn't this rather a pyuno bug? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
New commits:
commit 3a719bb9c3eea2972d04dbb5d12d6e80129e7890
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:27:23 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:41:49 2019 +0100
pdf: move PDFNamedDest out of PDFWriterImpl class
Change-Id: I6c1524718fce655faff08f6fc0eeba56595f9f07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86007
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 60679ffe5a40..8b2a98dbdad6 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -320,6 +320,15 @@ struct PDFDest
tools::Rectangle m_aRect;
};
+//--->i56629
+struct PDFNamedDest
+{
+OUString m_aDestName;
+sal_Int32 m_nPage;
+PDFWriter::DestAreaType m_eType;
+tools::Rectangle m_aRect;
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -329,15 +338,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-//--->i56629
-struct PDFNamedDest
-{
-OUString m_aDestName;
-sal_Int32 m_nPage;
-PDFWriter::DestAreaType m_eType;
-tools::Rectangle m_aRect;
-};
-
struct PDFOutlineEntry
{
sal_Int32 m_nObject;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit ee1e73ba8ce217c6ca78ad7966f068fdf9cdb1c7
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:25:57 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:41:27 2019 +0100
pdf: move PDFDest out of PDFWriterImpl class
Change-Id: I5d5e2d6e9e922a28d7de5bab9fb94f36960b78dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86006
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index e93d4005121e..60679ffe5a40 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -313,6 +313,13 @@ struct EmbedFont
EmbedFont() : m_nNormalFontID( 0 ) {}
};
+struct PDFDest
+{
+sal_Int32 m_nPage;
+PDFWriter::DestAreaType m_eType;
+tools::Rectangle m_aRect;
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -322,13 +329,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct PDFDest
-{
-sal_Int32 m_nPage;
-PDFWriter::DestAreaType m_eType;
-tools::Rectangle m_aRect;
-};
-
//--->i56629
struct PDFNamedDest
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 106 +++---
1 file changed, 55 insertions(+), 51 deletions(-)
New commits:
commit 2351ee06d6c4d5af35b46d63510d93c618ad0276
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:23:50 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:41:15 2019 +0100
pdf: move FontEmit, Glyph, FontSubset, EmbedFont from PDFWriterImpl
Change-Id: I8032a31d3237459713ec386c6810b6f05daabf08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86005
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 3696316c0626..e93d4005121e 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -286,6 +286,33 @@ public:
}
};
+struct FontEmit
+{
+sal_Int32 m_nFontID;
+std::map m_aMapping;
+
+explicit FontEmit( sal_Int32 nID ) : m_nFontID( nID ) {}
+};
+
+struct Glyph
+{
+sal_Int32 m_nFontID;
+sal_uInt8 m_nSubsetGlyphID;
+};
+
+struct FontSubset
+{
+std::vector< FontEmit >m_aSubsets;
+std::map m_aMapping;
+};
+
+struct EmbedFont
+{
+sal_Int32 m_nNormalFontID;
+
+EmbedFont() : m_nNormalFontID( 0 ) {}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -295,30 +322,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct FontEmit
-{
-sal_Int32 m_nFontID;
-std::map m_aMapping;
-
-explicit FontEmit( sal_Int32 nID ) : m_nFontID( nID ) {}
-};
-struct Glyph
-{
-sal_Int32 m_nFontID;
-sal_uInt8 m_nSubsetGlyphID;
-};
-struct FontSubset
-{
-std::vector< FontEmit >m_aSubsets;
-std::map m_aMapping;
-};
-struct EmbedFont
-{
-sal_Int32 m_nNormalFontID;
-
-EmbedFont() : m_nNormalFontID( 0 ) {}
-};
-
struct PDFDest
{
sal_Int32 m_nPage;
commit fffc244319a4f39beef3739c9d08c087e713f36b
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:19:26 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:41:01 2019 +0100
pdf: move GlyphEmit out of PDFWriterImpl class
Change-Id: I9ea67cd219a7304baa7abe20be207156a4c0e75e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86004
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 57e9ca4eb9c7..3696316c0626 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -256,6 +256,36 @@ struct TransparencyEmit
{}
};
+// font subsets
+class GlyphEmit
+{
+// performance: actually this should probably a vector;
+std::vectorm_CodeUnits;
+sal_uInt8 m_nSubsetGlyphID;
+
+public:
+GlyphEmit() : m_nSubsetGlyphID(0)
+{
+}
+
+void setGlyphId( sal_uInt8 i_nId ) { m_nSubsetGlyphID = i_nId; }
+sal_uInt8 getGlyphId() const { return m_nSubsetGlyphID; }
+
+void addCode( sal_Ucs i_cCode )
+{
+m_CodeUnits.push_back(i_cCode);
+}
+sal_Int32 countCodes() const { return m_CodeUnits.size(); }
+const std::vector& codes() const { return m_CodeUnits; }
+sal_Ucs getCode( sal_Int32 i_nIndex ) const
+{
+sal_Ucs nRet = 0;
+if (static_cast(i_nIndex) < m_CodeUnits.size())
+nRet = m_CodeUnits[i_nIndex];
+return nRet;
+}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -265,35 +295,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-// font subsets
-class GlyphEmit
-{
-// performance: actually this should probably a vector;
-std::vectorm_CodeUnits;
-sal_uInt8 m_nSubsetGlyphID;
-
-public:
-GlyphEmit() : m_nSubsetGlyphID(0)
-{
-}
-
-void setGlyphId( sal_uInt8 i_nId ) { m_nSubsetGlyphID = i_nId; }
-sal_uInt8 getGlyphId() const { return m_nSubsetGlyphID; }
-
-void addCode( sal_Ucs i_cCode )
-{
-m_CodeUnits.push_back(i_cCode);
-}
-sal_Int32 countCodes() const { return m_CodeUnits.size(); }
-const std::vector& codes() const { return m_CodeUnits; }
-sal_Ucs getCode( sal_Int32 i_nIndex ) const
-{
-sal_Ucs nRet = 0;
-if (static_cast(i_nIndex) < m_CodeUnits.size())
-nRet = m_CodeUnits[i_nIndex];
-return nRet;
-}
-};
struct FontEmit
{
sal_Int32 m_nFontID;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
New commits:
commit e11dd7a101f2ab64cb7ee4a5c6ac46232356c573
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:17:39 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:34:08 2019 +0100
pdf: move TransparencyEmit out of PDFWriterImpl class
Change-Id: I974845db88c0ae07881c573091a69c5098fa311b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86003
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 2c1730345e96..57e9ca4eb9c7 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -239,6 +239,23 @@ struct TilingEmit
{}
};
+// for transparency group XObjects
+struct TransparencyEmit
+{
+sal_Int32 m_nObject;
+sal_Int32 m_nExtGStateObject;
+double m_fAlpha;
+tools::Rectanglem_aBoundRect;
+std::unique_ptr m_pContentStream;
+std::unique_ptr m_pSoftMaskStream;
+
+TransparencyEmit()
+: m_nObject( 0 ),
+ m_nExtGStateObject( -1 ),
+ m_fAlpha( 0.0 )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -248,23 +265,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-// for transparency group XObjects
-struct TransparencyEmit
-{
-sal_Int32 m_nObject;
-sal_Int32 m_nExtGStateObject;
-double m_fAlpha;
-tools::Rectanglem_aBoundRect;
-std::unique_ptr m_pContentStream;
-std::unique_ptr m_pSoftMaskStream;
-
-TransparencyEmit()
-: m_nObject( 0 ),
- m_nExtGStateObject( -1 ),
- m_fAlpha( 0.0 )
-{}
-};
-
// font subsets
class GlyphEmit
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
New commits:
commit 960f781ad48b0e475a43ff7e58f67f2e65d3f4de
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:14:23 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:33:42 2019 +0100
pdf: move TilingEmit out of PDFWriterImpl class
Change-Id: I80011f4c31359a4471daea7efc86dd3cb446ed9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86002
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 4e66f8f101c7..2c1730345e96 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -224,6 +224,21 @@ struct GradientEmit
sal_Int32 m_nObject;
};
+// for tilings (drawWallpaper, begin/endPattern)
+struct TilingEmit
+{
+sal_Int32 m_nObject;
+tools::Rectangle m_aRectangle;
+Sizem_aCellSize;
+SvtGraphicFill::Transform m_aTransform;
+ResourceDictm_aResources;
+std::unique_ptr m_pTilingStream;
+
+TilingEmit()
+: m_nObject( 0 )
+{}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -233,21 +248,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-// for tilings (drawWallpaper, begin/endPattern)
-struct TilingEmit
-{
-sal_Int32 m_nObject;
-tools::Rectangle m_aRectangle;
-Sizem_aCellSize;
-SvtGraphicFill::Transform m_aTransform;
-ResourceDictm_aResources;
-std::unique_ptr m_pTilingStream;
-
-TilingEmit()
-: m_nObject( 0 )
-{}
-};
-
// for transparency group XObjects
struct TransparencyEmit
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129698] Freeze Rows and Columns context menu item not displayed for selected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=129698 jdgoodric...@gmail.com changed: What|Removed |Added Severity|normal |minor Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from jdgoodric...@gmail.com --- I just found the Freeze Rows and Columns button on the toolbar. I think it's fair to downgrade to minor, as there is a workaround now (for me, anyways). Test: * Open 2020 file. * Select a sheet with frozen columns and rows. * Select the cell C2. + Expected: The FRaC button on the toolbar is active (darker background in dark mode). + Actual: The FRaC button on the toolbar is now active. * Click the FRaC button on the toolbar. + Expected: Row 1 and columns A-B are unfrozen, and the FRaC button is inactive. + Actual: Row 1 and columns A-B are now unfrozen, and the FRaC button is now inactive. * Click the FRaC button on the toolbar. + Expected: Row 1 and columns A-B are frozen, and the FRaC button is active. + Actual: Row 1 and columns A-B are now frozen, and the FRaC button is now active. == Whether or not the entry in the context menu returns, I am good to go again. I'll mark this bug as resolved and worksforme, with the workaround identified above. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 62794b55ede3af9b805319c49d440b0cb4266879
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:12:47 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:20:50 2019 +0100
pdf: move GradientEmit out of PDFWriterImpl class
Change-Id: Ia2e6a03aef2f7de7563bb5e9500062592c241634
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86001
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index c04424fe7932..4e66f8f101c7 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -217,6 +217,13 @@ struct JPGEmit
}
};
+struct GradientEmit
+{
+Gradientm_aGradient;
+Sizem_aSize;
+sal_Int32 m_nObject;
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -226,13 +233,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct GradientEmit
-{
-Gradientm_aGradient;
-Sizem_aSize;
-sal_Int32 m_nObject;
-};
-
// for tilings (drawWallpaper, begin/endPattern)
struct TilingEmit
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.hxx | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
New commits:
commit 7c23451b591dae03a0ede4c12340994bdf22d1e3
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:11:17 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:20:33 2019 +0100
pdf: move JPGEmit out of PDFWriterImpl class
Change-Id: I0a3b3270ebba4c968cf9d9cab1e34c760fed05ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86000
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 8e3b188a13bc..c04424fe7932 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -200,6 +200,23 @@ struct BitmapEmit
}
};
+struct JPGEmit
+{
+BitmapIDm_aID;
+std::unique_ptr
+m_pStream;
+Bitmap m_aMask;
+sal_Int32 m_nObject;
+boolm_bTrueColor;
+ReferenceXObjectEmit m_aReferenceXObject;
+
+JPGEmit()
+: m_nObject(0)
+, m_bTrueColor(false)
+{
+}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -209,23 +226,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct JPGEmit
-{
-BitmapIDm_aID;
-std::unique_ptr
-m_pStream;
-Bitmap m_aMask;
-sal_Int32 m_nObject;
-boolm_bTrueColor;
-ReferenceXObjectEmit m_aReferenceXObject;
-
-JPGEmit()
-: m_nObject(0)
-, m_bTrueColor(false)
-{
-}
-};
-
struct GradientEmit
{
Gradientm_aGradient;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/source
vcl/source/gdi/pdfwriter_impl.cxx |4 +-
vcl/source/gdi/pdfwriter_impl.hxx | 76 +++---
2 files changed, 40 insertions(+), 40 deletions(-)
New commits:
commit e03895b8e621f641af686fa83d359e3571047ddb
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:09:36 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:20:21 2019 +0100
pdf: move BitmapEmit out of PDFWriterImpl class
Change-Id: Ia86803e9ad732d94cac59814ac8dcae8772542a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85999
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index f05260d613b7..3f1a3aaadb7f 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -9387,7 +9387,7 @@ void PDFWriterImpl::drawBitmap( const Point& rDestPoint,
const Size& rDestSize,
writeBuffer( aLine.getStr(), aLine.getLength() );
}
-const PDFWriterImpl::BitmapEmit& PDFWriterImpl::createBitmapEmit( const
BitmapEx& i_rBitmap, const Graphic& rGraphic )
+const BitmapEmit& PDFWriterImpl::createBitmapEmit( const BitmapEx& i_rBitmap,
const Graphic& rGraphic )
{
BitmapEx aBitmap( i_rBitmap );
if( m_aContext.ColorMode == PDFWriter::DrawGreyscale )
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 37d8a1fbe94c..8e3b188a13bc 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -187,6 +187,19 @@ struct ReferenceXObjectEmit
sal_Int32 getObject() const;
};
+struct BitmapEmit
+{
+BitmapIDm_aID;
+BitmapExm_aBitmap;
+sal_Int32 m_nObject;
+ReferenceXObjectEmit m_aReferenceXObject;
+
+BitmapEmit()
+: m_nObject(0)
+{
+}
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -196,19 +209,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-struct BitmapEmit
-{
-BitmapIDm_aID;
-BitmapExm_aBitmap;
-sal_Int32 m_nObject;
-ReferenceXObjectEmit m_aReferenceXObject;
-
-BitmapEmit()
-: m_nObject(0)
-{
-}
-};
-
struct JPGEmit
{
BitmapIDm_aID;
commit 99940fd70cd36c93872d89c604a0ddb0e77163ef
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 30 12:06:03 2019 +0100
Commit: Tomaž Vajngerl
CommitDate: Mon Dec 30 17:20:10 2019 +0100
pdf: move ReferenceXObjectEmit out of PDFWriterImpl class
Change-Id: Ic173a6fcb189966e785907cd24a3e90857811b83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85998
Reviewed-by: Tomaž Vajngerl
Tested-by: Tomaž Vajngerl
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 7cb77f2f60c4..f05260d613b7 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -11224,7 +11224,7 @@ void PDFWriterImpl::MARK( const char* pString )
emitComment( pString );
}
-sal_Int32 PDFWriterImpl::ReferenceXObjectEmit::getObject() const
+sal_Int32 ReferenceXObjectEmit::getObject() const
{
if (m_nFormObject > 0)
return m_nFormObject;
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index d375d7842bd0..37d8a1fbe94c 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -162,6 +162,31 @@ struct PDFPage
double getHeight() const { return m_nPageHeight ? m_nPageHeight :
vcl::pdf::g_nInheritedPageHeight; }
};
+/// Contains information to emit a reference XObject.
+struct ReferenceXObjectEmit
+{
+/// ID of the Form XObject, if any.
+sal_Int32 m_nFormObject;
+/// ID of the vector/embedded object, if m_nFormObject is used.
+sal_Int32 m_nEmbeddedObject;
+/// ID of the bitmap object, if m_nFormObject is used.
+sal_Int32 m_nBitmapObject;
+/// Size of the bitmap replacement, in pixels.
+Size m_aPixelSize;
+/// PDF data from the graphic object, if not writing a reference XObject.
+std::vector m_aPDFData;
+
+ReferenceXObjectEmit()
+: m_nFormObject(0),
+ m_nEmbeddedObject(0),
+ m_nBitmapObject(0)
+{
+}
+
+/// Returns the ID one should use when referring to this bitmap.
+sal_Int32 getObject() const;
+};
+
}
class PDFWriterImpl : public VirtualDevice
@@ -171,31 +196,6 @@ class PDFWriterImpl : public VirtualDevice
public:
friend struct vcl::pdf::PDFPage;
-/// Contains information to emit a reference XObject.
-struct ReferenceXObjectEmit
-{
-/// ID of the Form XObject, if any.
-sal_Int32 m_nFormObject;
-/// ID of the vector/embedded object, if m_nFormObject is used.
-sal_Int32 m_nEmbeddedObject;
-/// ID of the bitmap object, if m_nFormObject is used.
-sal_Int32 m_nBitmapObject;
-/// Size of the bitmap replacement, in pixels.
-Size
[Libreoffice-bugs] [Bug 65793] command not found when calling libreoffice or libreofficedev
https://bugs.documentfoundation.org/show_bug.cgi?id=65793 prabesh...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #7 from prabesh...@gmail.com --- Version: 6.3.4.2 Build ID: 1:6.3.4-0ubuntu0.19.10.1 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Same problem here in Ubuntu 19.10 when I try to open the document from Desktop (not the Desktop folder). But when I use File manager and go to Desktop folder, then I can open it normally. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: android/lib
android/lib/src/main/cpp/CMakeLists.txt.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2ea84e11cb9284c6e5ab8b650fc4e2c95492c3af
Author: Jan Holesovsky
AuthorDate: Mon Dec 30 16:43:52 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 30 16:46:32 2019 +0100
android: Fix a typo in the 32bit build.
Change-Id: I8a1d68327c48da47d970eccdd586c26467bb495c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86014
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/android/lib/src/main/cpp/CMakeLists.txt.in
b/android/lib/src/main/cpp/CMakeLists.txt.in
index 2d5dc09e1..b76d8fe97 100644
--- a/android/lib/src/main/cpp/CMakeLists.txt.in
+++ b/android/lib/src/main/cpp/CMakeLists.txt.in
@@ -26,7 +26,7 @@ target_compile_definitions(androidapp PRIVATE
LOOLWSD_CONFIGDIR="/etc/loolwsd")
# According to the ABI, we need to use different source trees
if(${ANDROID_ABI} STREQUAL "armeabi-v7a")
set(LOBUILDDIR_ABI @LOBUILDDIR@)
-set(POCOINCLUDE_ABI ${POCOINCLUDE_ABI})
+set(POCOINCLUDE_ABI @POCOINCLUDE@)
set(POCOLIB_ABI @POCOLIB@)
elseif(${ANDROID_ABI} STREQUAL "arm64-v8a")
set(LOBUILDDIR_ABI @LOBUILDDIR_ARM64_V8A@)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: How are Jenkins builds killed exactly?
Hi Stephan, *,
On Sun, Dec 29, 2019 at 3:17 PM Stephan Bergmann wrote:
>
> Still trying to track down why sometimes zombie processes survive on the
> (Linux) Jenkins build machines […]
> […]
> That tb_slave_wrapper script contains
>
> > trap cleanup 1 2 3 6 15
> >
> > cleanup()
> > {
> > echo "Caught Signal ... killing everything"
> > # kill everything in same process group (pseudo-pid 0)
> > kill -9 0
> > }
>
> intended to kill all processes if the script itself receives any of
> SIGHUP/-INT/-QUIT/-ABRT/-TERM.
>
> But how does the tb_slave_wrapper script get terminated by whatever
> entity that starts it and prints out the
>
> > Build timed out (after 15 minutes). Marking the build as aborted.
> > Build was aborted
> > Finished: ABORTED
>
> mentioned above?
Regular abortion should be using
https://wiki.jenkins.io/display/JENKINS/ProcessTreeKiller
it looks for processes with the BUILD_ID environment variable that the
scripts inherit when running under jenkins.
that tries a term and kill - although our handler from the scirpt then
should take over.
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/ProcessTree.java#L776
> Could it be that the script itself gets killed with
> SIGKILL, so its cleanup() trap doesn't fire, and processes (indirectly)
> spawned from the script may stay alive?
Timeout based abortion is done via
https://github.com/jenkinsci/build-timeout-plugin and that triggers
interrupt for the thread.
ciao
Christian
ciao
Christian
--
Christian Lohmaier, Release Engineer
Tel: +49 30 5557992-60 | IRC: cloph on Freenode
The Document Foundation, Kurfürstendamm 188, 10707 Berlin, DE
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 65758] Error not triggered in an "if" statement
https://bugs.documentfoundation.org/show_bug.cgi?id=65758 --- Comment #16 from LibreOfficiant --- (In reply to LibreOfficiant from comment #15) > Created attachment 156854 [details] > Fix proposal for this bug > > I have tried to synthetize what's existing in some Basic-like languages into > a sound improvement. The main idea is to distinguish between Error statement and Error function. And make sure Basic code blocks have no impact on Error variants. A collateral would be to add extra features to the Error statement, which can be phased separately. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65758] Error not triggered in an "if" statement
https://bugs.documentfoundation.org/show_bug.cgi?id=65758 LibreOfficiant changed: What|Removed |Added CC||libreoffici...@sfr.fr --- Comment #15 from LibreOfficiant --- Created attachment 156854 --> https://bugs.documentfoundation.org/attachment.cgi?id=156854=edit Fix proposal for this bug I have tried to synthetize what's existing in some Basic-like languages into a sound improvement. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112979] Applying a template style and formatting to a large file is slower as it has been before
https://bugs.documentfoundation.org/show_bug.cgi?id=112979 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9701 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2979 CC||kelem...@ubuntu.com, ||nem...@numbertext.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 NISZ LibreOffice Team changed: What|Removed |Added Depends on||129701 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=129701 [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 NISZ LibreOffice Team changed: What|Removed |Added Blocks||102593 Keywords||implementationError --- Comment #4 from NISZ LibreOffice Team --- Bibisected using bibisect-win32-6.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3bd4957191f12457c17404645bab0794639c95f8 author Laurent BP 2017-12-17 17:14:55 +0100 committer Eike Rathke 2017-12-21 23:16:23 +0100 tdf#113979 Add option to Skip empty cells Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 --- Comment #3 from NISZ LibreOffice Team --- Created attachment 156853 --> https://bugs.documentfoundation.org/attachment.cgi?id=156853=edit The file after pasting with A3 not becoming empty -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 --- Comment #2 from NISZ LibreOffice Team --- Created attachment 156852 --> https://bugs.documentfoundation.org/attachment.cgi?id=156852=edit The Text Import dialog before pasting -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129697] New Help: the heading "Global" is not translatable
https://bugs.documentfoundation.org/show_bug.cgi?id=129697 Olivier Hallot changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Olivier Hallot --- True, but none of the other names too because they are the modules names... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] New: Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 Bug ID: 129701 Summary: Skip empty cells option does not work in Calc Text Import dialog Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@nisz.hu Description: When using the Unformatted text paste option in Calc the Skip empty cells option does not seem to make a difference whether its enabled or not Steps to Reproduce: 1. Open attachment # from bug # (ide jön az előző bugból a melléklet és a bug száma) 2. Copy the range B1:B4 and paste it while standing in A1 using the Paste button -> Unformatted text option 3. The Skip empty cells option in the Text Import dialog is turned on by default. Its tooltip says the sources empty cells should not overwrite the target when enabled. 4. Try pasting again with Skip empty cells turned off. Actual Results: Whether Skip empty cells is enabled or not, the empty cell in B3 does not overwrite the content in A3. Expected Results: When Skip empty cells is disabled the content in A3 should be cleared. Reproducible: Always User Profile Reset: No Additional Info: LibreOffice details: Verzió: 6.4.0.0.beta1 (x86) Build az.: 4d7e5b0c40ed843384704eca3ce21981d4e98920 CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: alapértelmezett; VCL: win; Területi beállítások: hu-HU (hu_HU); Felület nyelve: hu-HU Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129701] Skip empty cells option does not work in Calc Text Import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129701 --- Comment #1 from NISZ LibreOffice Team --- Created attachment 156851 --> https://bugs.documentfoundation.org/attachment.cgi?id=156851=edit Example file from Calc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/sidebartableedit.ui | 19 +++ 1 file changed, 19 insertions(+) New commits: commit bda150d3cfc6f0a466e570bd3ba36c013f995c65 Author: Caolán McNamara AuthorDate: Mon Dec 23 16:17:08 2019 + Commit: Caolán McNamara CommitDate: Mon Dec 30 15:34:39 2019 +0100 use smaller toolbar icons for sidebar Change-Id: I3f94d23522eb5121e36acbed88ec052208200959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85763 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/sidebartableedit.ui b/sw/uiconfig/swriter/ui/sidebartableedit.ui index f6e6d9ad2e2f..9cc20ada1085 100644 --- a/sw/uiconfig/swriter/ui/sidebartableedit.ui +++ b/sw/uiconfig/swriter/ui/sidebartableedit.ui @@ -63,6 +63,7 @@ False icons False +2 True @@ -129,6 +130,9 @@ True False +icons +False +2 True @@ -267,6 +271,9 @@ True False +icons +False +2 True @@ -310,6 +317,9 @@ True False +text +False +2 True @@ -365,6 +375,9 @@ True False +icons +False +2 True @@ -420,6 +433,9 @@ True False +icons +False +2 True @@ -474,6 +490,9 @@ True False start +icons +False +2 True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
