date:20200316

[Libreoffice-bugs] [Bug 131382] The scope of function definitions (Calc or BASIC) is unclear

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131382

--- Comment #1 from Mike Kaganski  ---
Also https://ask.libreoffice.org/en/question/233897/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127597] [META] Macro-Related Documentation, incl. local/online help or wiki

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127597

himajin100...@gmail.com changed:

   What|Removed |Added

 Depends on||131368


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131368
[Bug 131368] WeekDay BASIC function's second argument undocumented
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131382] The scope of function definitions (Calc or BASIC) is unclear

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131382

himajin100...@gmail.com changed:

   What|Removed |Added

 Blocks||127597


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127597
[Bug 127597] [META] Macro-Related Documentation, incl. local/online help or
wiki
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131368] WeekDay BASIC function's second argument undocumented

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131368

himajin100...@gmail.com changed:

   What|Removed |Added

 Blocks|127592  |127597


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127592
[Bug 127592] [META] LibreOffice Basic incl."Option Compatible" modules
https://bugs.documentfoundation.org/show_bug.cgi?id=127597
[Bug 127597] [META] Macro-Related Documentation, incl. local/online help or
wiki
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127592] [META] LibreOffice Basic incl."Option Compatible" modules

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127592

himajin100...@gmail.com changed:

   What|Removed |Added

 Depends on|131368  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131368
[Bug 131368] WeekDay BASIC function's second argument undocumented
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127597] [META] Macro-Related Documentation, incl. local/online help or wiki

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127597

himajin100...@gmail.com changed:

   What|Removed |Added

 Depends on||131382


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131382
[Bug 131382] The scope of function definitions (Calc or BASIC) is unclear
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131377] Not Sorting Dates Correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131377

--- Comment #6 from c319ch...@aol.com ---
Created attachment 158732
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158732=edit
DateBug.xls file

Attached .xls file shows mis-sorted dates.

Dates were copied from a .csv file and pasted into the .xls file. You can see
the dates are not properly sorted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131190] Can not delete pagestyle in Calc

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131190

--- Comment #5 from Jim Raykowski  ---
(In reply to Jim Raykowski from comment #4)
> (In reply to Oliver Brinzing from comment #3)

> Here is a patch to return the ability to delete custom page styles in Calc.
> It doesn't solve the "isInUse" problem, it just changes all page style is in
> use queries to return as not in use. It will cause your macro to not report
> any page style in use instead of reporting all page styles in use.
> 

My first approach, of returning page style queries as not in use, does not pass
the CppunitTest_sc_subsequent_export_test ScExportTest::testHeaderImageODS
test.

I've taken a new approach that keeps the page style "isInUse" always true, as
before.

https://gerrit.libreoffice.org/c/core/+/90547

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131069] Bad symbols in internal menus while using cyrillic KOI8-R locale

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131069

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129900] Exiting Writer's Print Preview mode is slow in long documents

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129900

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126811] in 6.3, Base will not accept the ACCESS database

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126811

--- Comment #5 from QA Administrators  ---
Dear Ernst Sigl,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124259] LibreOffice 6.2 Turkish spell checking dictionary is missing in Turkish installation

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124259

--- Comment #4 from QA Administrators  ---
Dear HidayetKurnaz,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131051] Column Chart restricts the number of the second column data within 10 in Calc6.4

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131051

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131321] FILEOPEN: ms word docx with styles that include bulleting / numbering loses bullet / number part of style in Writer

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131321

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124259] LibreOffice 6.2 Turkish spell checking dictionary is missing in Turkish installation

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124259

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131321] FILEOPEN: ms word docx with styles that include bulleting / numbering loses bullet / number part of style in Writer

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131321

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127607] Scanner interface immediate Hangup

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127607

--- Comment #2 from QA Administrators  ---
Dear Hermann Rochholz,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126811] in 6.3, Base will not accept the ACCESS database

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126811

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130783] Change .uno: command for Protect Cells in Writer from .uno:Protect to .uno:CellProtection

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130783

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131064] bluetooth: connect to paired device fails

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131064

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127213] Libreoffice-writer: X; L-files are not showing correct items

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127213

--- Comment #2 from QA Administrators  ---
Dear hans.ullrich,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126864] Throws exception when removing .zip file extension via extension manager

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126864

--- Comment #6 from QA Administrators  ---
Dear adrianjgrady,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108804] [META] Print preview bugs and enhancements

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108804
Bug 108804 depends on bug 129900, which changed state.

Bug 129900 Summary: Exiting Writer's Print Preview mode is slow in long 
documents
https://bugs.documentfoundation.org/show_bug.cgi?id=129900

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129900] Exiting Writer's Print Preview mode is slow in long documents

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129900

Max Barry  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129900] Exiting Writer's Print Preview mode is slow in long documents

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129900

--- Comment #8 from Max Barry  ---
Created attachment 158731
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158731=edit
Madison May test doc (295 pages, 104k words)

Thanks again for your attention - it's much appreciated!

I will set to NEW because although 7.0 is indeed an improvement over 6.3, it is
still *much* slower than 5.x. 

In particular, I've found that in long documents that contain formatting, 7.0
takes 4 times longer than 5.x to flip in and out of Print Preview mode (2.4s
compared to 0.6s). This is better than LO6, but still so long that it makes me,
as a user, reluctant to use it.

I'm attaching a new test document (Madison May test doc), which is a scrambled
version of a document I work on, because this is closer to real-world
conditions, and better demonstrates the performance degradation - which did
indeed begin very suddenly in 6.0.

Madison May test doc (350 words per page, contains lots of basic formatting)

Time to enter & exit Print Preview mode:

5.3:
enter 0.7s
exit  0.0s (0.7s total)

5.4.7.2:
enter 0.6s
exit  0.0s (0.6s total)

6.0.0.1:
enter 0.9s
exit  1.5s (2.4s total)

6.3
enter 1.2s
exit  2.5s (3.7s total)

7.0:
enter 1.4s
exit  1.0s (2.4s total)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131384] New: Tabbed view erases conditional format on xlsx files when saving FILESAVE FORMATTING

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131384

Bug ID: 131384
   Summary: Tabbed view erases conditional format on xlsx files
when saving FILESAVE FORMATTING
   Product: LibreOffice
   Version: 6.4.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 2...@live.com.mx

Description:
Open an xlsx file that was previously saved on Microsoft Office (if it was
saved on LibreOffice it doesn't reproduce), change the interface to tabbed
view, save and then close the file. The next time you open the file, conditions
for conditional format remain, but the conditional styles have been removed so
not applied.

Steps to Reproduce:
1.Open any xlsx file previously saved on Microsoft Office, not LibreOffice
2.Change interface to tabbed view
3.Save file
4.Open file again

Actual Results:
Conditional styles are erased from the document

Expected Results:
Conditional styles should remain and conditional formatting applied


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.4.1.2
Build ID: 4d224e95b98b138af42a64d84056446d09082932
CPU threads: 4; OS: Linux 5.5; UI render: default; VCL: gtk3; 
Locale: es-MX (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

2020-03-16 Thread TJ Holt (via logerrit)

 svx/source/tbxctrls/layctrl.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 1fbeba66e823cea043fdd3f4c50d7b90585aaf30
Author: TJ Holt 
AuthorDate: Thu Mar 12 13:36:42 2020 -0700
Commit: Jim Raykowski 
CommitDate: Tue Mar 17 00:24:45 2020 +0100

tdf#127443 Table creation with keyboard

Change-Id: If0efe4c49e2da96677f24182afc39e640421b0a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90192
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/svx/source/tbxctrls/layctrl.cxx b/svx/source/tbxctrls/layctrl.cxx
index 6683500ec4a0..88b110e8c1f1 100644
--- a/svx/source/tbxctrls/layctrl.cxx
+++ b/svx/source/tbxctrls/layctrl.cxx
@@ -189,7 +189,11 @@ bool TableWidget::KeyInput(const KeyEvent& rKEvt)
 break;
 case KEY_DOWN:
 if ( nNewLine < TABLE_CELLS_VERT )
+{
 nNewLine++;
+if ( nNewCol == 0 )
+nNewCol = 1;
+}
 else
 mxControl->CloseAndShowTableDialog();
 break;
@@ -201,7 +205,11 @@ bool TableWidget::KeyInput(const KeyEvent& rKEvt)
 break;
 case KEY_RIGHT:
 if ( nNewCol < TABLE_CELLS_HORIZ )
+{
 nNewCol++;
+if ( nNewLine == 0 )
+nNewLine = 1;
+}
 else
 mxControl->CloseAndShowTableDialog();
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 131383] New: Positioning of comments in documents with two and more text columns is confusing

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131383

Bug ID: 131383
   Summary: Positioning of comments in documents with two and more
text columns is confusing
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kunsten...@web.de

Created attachment 158730
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158730=edit
test file to show confusing positioning of comments in documents with two
columns

This is a request for a better design how comments in documents with two and
more text columns are displayed. See test file attached. As you can see, the
comment boxes are positioned according to the text line number 2,4,10,11,12,
but this gets confusing, when more than one column is used. Solution would be
not to prioritize the 1st column but to treat al columns equal. So, comment
order should be 10,11,2,12,4.

Furthermore, it would be better not to overlap the horizontal dashed lines.
While writer highlights the right line, when I use mouse over, I cannot make a
distinction when printing a document with comments...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130859] Save icon in macro editor slow to reactivate after graying out

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130859

Dieter  changed:

   What|Removed |Added

 Blocks||107659
 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
I can't confirm with

Version: 6.3.5.2 (x64)
Build-ID: dd0751754f11728f69b42ee2af66670068624673
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107659
[Bug 107659] [META] Macro bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107659] [META] Macro bugs and enhancements

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107659

Dieter  changed:

   What|Removed |Added

 Depends on||130859


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130859
[Bug 130859] Save icon in macro editor slow to reactivate after graying out
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Your presentation on LibreOffice code

2020-03-16 Thread Arvind Kumar

Jan-Marek Glogowski  wrote:
> If you want to generate single glyphs from multiple keystrokes, then you 
> should have a look into input method handling (IM), like ibus or fcitx, 
> which> is normally used to type complex-glyph based languages, like Chinese.

I know this is outside LO, but is this as easy as editing a file and adding my 
mapping, and if so, is there an example I can look at?
> Hard to say, if this is a general problem of your font or a bug in LO or
> just caused by your changes to the VCL gtk3 plugin key handling code in LO.
>
> If you have some other working example document, like a UTF-8 encoded
> text file, which you know is displayed correctly in some Gtk
> application, than you could copy and paste that text into Writer and
> then select your font. That should already work, without any code changes.
I just tested this and it works very well and correctly shows my text! So it 
now comes down to the input mechanism and making it work for the keystrokes. 
LayoutText is not the right place?

> Maybe try contact either people from unicode.org or icu-project.org?
> They should eventually be able to assign some code point ranges for your
> language / glyphs, so other programs can also represent your glyphs
> correctly. I have no idea, how the unicode people work, but especially
> if you have an actively used language, that would be my way to go.

Unicode is the problem! In the early 1990s, UTF-8 encoding started off as 
31-bit encoding scheme. IEEE came up with a 32-bit scheme. Unicode should have 
done the same thing. It was well intentioned when it started off and was 
supposed to accommodate all languages. Today, Unicode Consortium is run by 
people from large firms who, over time, restricted Unicode to 16 and 20-bits 
and there is no space for every character. Of course, Unicode neatly fits in 
with the ancient DBCS technology of Microsoft. Another problem is that even 
GTK's code tests for unicode compatibility and will not accept "non-standard" 
strings, for example, file names not recognized as unicode compatible. 

Thanks!
-a
  ___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2020-03-16 Thread László Németh (via logerrit)

 sw/qa/extras/ooxmlexport/data/tdf128646.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |   14 ++
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   30 --
 3 files changed, 42 insertions(+), 2 deletions(-)

New commits:
commit 2be656908e9f30d0b0f795cc67096f0d673a3a21
Author: László Németh 
AuthorDate: Fri Mar 13 17:08:34 2020 +0100
Commit: László Németh 
CommitDate: Mon Mar 16 22:23:32 2020 +0100

tdf#128646 DOCX import: don't hide shape of hidden paragraph

if the shape is not hidden, but it's anchored to
an empty table cell paragraph.

Change-Id: I97e42431d083d3c70ff67981676e322ca8e7f89d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90568
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf128646.docx 
b/sw/qa/extras/ooxmlexport/data/tdf128646.docx
new file mode 100644
index ..9648df35a2f3
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf128646.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 470e47714940..cc4cc8f33bfa 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -641,6 +641,20 @@ DECLARE_OOXMLEXPORT_TEST(testTdf95033, "tdf95033.docx")
 assertXPath(pXmlDocument, 
"/w:document/w:body/w:tbl/w:tr[9]/w:tc[2]/w:tcPr/w:tcBorders/w:bottom[@w:val = 
'nil']", 0);
 }
 
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128646, "tdf128646.docx")
+{
+// The problem was that not hidden shapes anchored to empty hidden 
paragraphs were imported as hidden.
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+
+
assertXPath(pXmlDoc,"/w:document/w:body/w:tbl/w:tr/w:tc/w:p[7]/w:pPr/w:rPr/w:vanish",
 1);
+if (!mbExported)
+// originally no  (the same as )
+
assertXPath(pXmlDoc,"/w:document/w:body/w:tbl/w:tr/w:tc/w:p[7]/w:r/w:rPr/w:vanish",
 0);
+else
+// This was hidden ()
+
assertXPath(pXmlDoc,"/w:document/w:body/w:tbl/w:tr/w:tc/w:p[7]/w:r/w:rPr/w:vanish",
 "val", "false");
+}
+
 DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFdo77129, "fdo77129.docx")
 {
 // The problem was that text after TOC field was missing if footer 
reference  comes in field.
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 3e87fcb0a2b5..cc4311d0aaff 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1751,10 +1751,11 @@ void DomainMapper_Impl::finishParagraph( const 
PropertyMapPtr& pPropertyMap, con
 
 css::uno::Reference 
xParaProps(xTextRange, uno::UNO_QUERY);
 
-// table style has got bigger precedence than docDefault style
-// collect these pending paragraph properties to process in 
endTable()
+// table style precedence and not hidden shapes anchored to 
hidden empty table paragraphs
 if (xParaProps && m_nTableDepth > 0)
 {
+// table style has got bigger precedence than docDefault 
style
+// collect these pending paragraph properties to process 
in endTable()
 uno::Reference xCur = 
xTextRange->getText( )->createTextCursor( );
 xCur->gotoEnd(false);
 xCur->goLeft(1, false);
@@ -1763,6 +1764,31 @@ void DomainMapper_Impl::finishParagraph( const 
PropertyMapPtr& pPropertyMap, con
 xParaCursor->gotoStartOfParagraph(false);
 TableParagraph aPending{xParaCursor, xCur, pParaContext, 
xParaProps};
 m_aParagraphsToEndTable.push_back(aPending);
+
+// hidden empty paragraph with a not hidden shape, set as 
not hidden
+o3tl::optional pHidden;
+if ( !m_aAnchoredObjectAnchors.empty() && (pHidden = 
pParaContext->getProperty(PROP_CHAR_HIDDEN)) )
+{
+bool bIsHidden;
+pHidden->second >>= bIsHidden;
+if (bIsHidden)
+{
+bIsHidden = false;
+pHidden = 
GetTopContext()->getProperty(PROP_CHAR_HIDDEN);
+if (pHidden)
+pHidden->second >>= bIsHidden;
+if (!bIsHidden)
+{
+uno::Reference xCur3 =  
xTextRange->getText()->createTextCursorByRange(xParaCursor);
+xCur3->goRight(1, true);
+if (xCur3->getString() == SAL_NEWLINE_STRING)
+{
+uno::Reference< beans::XPropertySet > 
xProp( xCur3, uno::UNO_QUERY );
+

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=10
Bug 10 depends on bug 128646, which changed state.

Bug 128646 Summary: FILEOPEN DOCX Missing image in table cell anchored to text
https://bugs.documentfoundation.org/show_bug.cgi?id=128646

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131309] Validity>Custom>Formula does not have the expected effect without additional measures - evaluation of entered formula only happens after additional trigger

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131309

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||698
 Status|UNCONFIRMED |NEW
Summary|Validity>Custom>Formula |Validity>Custom>Formula
   |does not  have the expected |does not  have the expected
   |effect without additional   |effect without additional
   |measures.   |measures - evaluation of
   ||entered formula only
   ||happens after additional
   ||trigger

--- Comment #3 from Cor Nouws  ---
confirming as per comment #1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96698] Data => Validity => Custom (like Excel) is missing

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96698

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1309

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131372] FILESAVE XLSX Paste special of #N/A formula result result gives in Err:520 in Calc after reload

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131372

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #5 from m.a.riosv  ---
Works for me with
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 6f82f5163fdd43ea22958dfb28926c88ed97fa7c
CPU threads: 4; OS: Windows 10.0 Build 19582; UI render: Skia/Raster; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113381] text:anchor-type from style is not used

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113381

--- Comment #4 from s.folla...@gmail.com ---
with latest version 6.4.1.2 the anchor-type default to-char
(text:anchor-type="char")

I find this behavior extremely annoying, even taunting, since with this version
it is finally been added the option to don't allow overlap of image/frame
objects.

it's impossible to set up a proper default setting for importing image, which
anchor need to be manually changed for every single one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131377] Not Sorting Dates Correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131377

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #5 from m.a.riosv  ---
Using English USA language for import it's fine for me, I don't need select the
date column type.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: uitest/impress_tests uitest/writer_tests1

2020-03-16 Thread Xisco Fauli (via logerrit)

 uitest/impress_tests/backgrounds.py |8 +---
 uitest/writer_tests1/pageDialog.py  |8 
 2 files changed, 9 insertions(+), 7 deletions(-)

New commits:
commit bc6eb8e096416d42d2308a529d5c0d81778dca60
Author: Xisco Fauli 
AuthorDate: Mon Mar 16 19:30:30 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Mar 16 22:02:39 2020 +0100

uitest: use hex instead of int for colors

Change-Id: I7309a546546637a1837df8ac99807c2deb22c72a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90589
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/uitest/impress_tests/backgrounds.py 
b/uitest/impress_tests/backgrounds.py
index b0c36db36ab4..6e2493b063f1 100644
--- a/uitest/impress_tests/backgrounds.py
+++ b/uitest/impress_tests/backgrounds.py
@@ -18,13 +18,15 @@ class ImpressBackgrounds(UITestCase):
 if btn == 'btnnone':
 self.assertEqual(document.DrawPages.getByIndex(0).Background, None)
 elif btn == 'btncolor':
-
self.assertEqual(document.DrawPages.getByIndex(0).Background.FillColor, 7512015)
-
self.assertEqual(document.DrawPages.getByIndex(0).Background.FillColor, 7512015)
+self.assertEqual(
+  hex(document.DrawPages.getByIndex(0).Background.FillColor), 
'0x729fcf')
+self.assertEqual(
+  hex(document.DrawPages.getByIndex(0).Background.FillColor), 
'0x729fcf')
 elif btn == 'btngradient':
 self.assertEqual(
   document.DrawPages.getByIndex(0).Background.FillGradient.Style, 
LINEAR)
 self.assertEqual(
-  
document.DrawPages.getByIndex(0).Background.FillGradient.StartColor, 14543051)
+  
hex(document.DrawPages.getByIndex(0).Background.FillGradient.StartColor), 
'0xdde8cb')
 self.assertEqual(
   document.DrawPages.getByIndex(0).Background.FillGradient.Angle, 
300)
 self.assertEqual(
diff --git a/uitest/writer_tests1/pageDialog.py 
b/uitest/writer_tests1/pageDialog.py
index 233c269d891f..73e523444c6e 100644
--- a/uitest/writer_tests1/pageDialog.py
+++ b/uitest/writer_tests1/pageDialog.py
@@ -36,16 +36,16 @@ class WriterPageDialog(UITestCase):
 document.StyleFamilies.PageStyles.Standard.BackColor, -1)
 elif btn == 'btncolor':
 self.assertEqual(
-document.StyleFamilies.PageStyles.Standard.BackColor, 7512015)
+hex(document.StyleFamilies.PageStyles.Standard.BackColor), 
'0x729fcf')
 self.assertEqual(
-document.StyleFamilies.PageStyles.Standard.FillColor, 7512015)
+hex(document.StyleFamilies.PageStyles.Standard.FillColor), 
'0x729fcf')
 self.assertEqual(
-document.StyleFamilies.PageStyles.Standard.FillColor, 7512015)
+hex(document.StyleFamilies.PageStyles.Standard.FillColor), 
'0x729fcf')
 elif btn == 'btngradient':
 self.assertEqual(
 document.StyleFamilies.PageStyles.Standard.FillGradient.Style, 
LINEAR)
 self.assertEqual(
-
document.StyleFamilies.PageStyles.Standard.FillGradient.StartColor, 14543051)
+
hex(document.StyleFamilies.PageStyles.Standard.FillGradient.StartColor), 
'0xdde8cb')
 self.assertEqual(
 document.StyleFamilies.PageStyles.Standard.FillGradient.Angle, 
300)
 self.assertEqual(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2020-03-16 Thread Xisco Fauli (via logerrit)

 sc/qa/uitest/chart/chartWall.py |   45 +---
 1 file changed, 42 insertions(+), 3 deletions(-)

New commits:
commit 036820d685c3a76c7fbfe35f47ab7b133e8a55af
Author: Xisco Fauli 
AuthorDate: Mon Mar 16 19:23:50 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Mar 16 22:00:52 2020 +0100

uitest: chartWall.py: assert changes in chart

Change-Id: I8c9f4614a76015b0032347290f6b92b2892ddd10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90588
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sc/qa/uitest/chart/chartWall.py b/sc/qa/uitest/chart/chartWall.py
index 29452bf98238..d0546401bf7c 100644
--- a/sc/qa/uitest/chart/chartWall.py
+++ b/sc/qa/uitest/chart/chartWall.py
@@ -13,7 +13,7 @@ from libreoffice.uno.propertyvalue import mkPropertyValues
 from uitest.uihelper.common import get_state_as_dict, type_text
 import org.libreoffice.unotest
 import pathlib
-from uitest.path import get_srcdir_url
+
 def get_url_for_data_file(file_name):
 return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
 
@@ -41,6 +41,12 @@ class chartWall(UITestCase):
 xOKBtn = xDialog.getChild("ok")
 self.ui_test.close_dialog_through_button(xOKBtn)
 
+xWall = 
document.Sheets[0].Charts[0].getEmbeddedObject().getFirstDiagram().Wall
+self.assertEqual(xWall.LineWidth, 0)
+self.assertEqual(xWall.LineTransparence, 0)
+self.assertEqual(hex(xWall.FillColor), '0xe6e6e6')
+self.assertEqual(xWall.FillTransparence, 0)
+
 gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
 gridwin.executeAction("ACTIVATE", tuple())
 xChartMainTop = self.xUITest.getTopFocusWindow()
@@ -51,8 +57,6 @@ class chartWall(UITestCase):
 #Click on tab "Borders".
 tabcontrol = xDialog.getChild("tabcontrol")
 select_pos(tabcontrol, "0")
-# print(xDialog.getChildren())
-#
 
 xWidth = xDialog.getChild("MTR_FLD_LINE_WIDTH")
 transparency = xDialog.getChild("MTR_LINE_TRANSPARENT")
@@ -63,6 +67,11 @@ class chartWall(UITestCase):
 xOKBtn = xDialog.getChild("ok")
 self.ui_test.close_dialog_through_button(xOKBtn)
 
+self.assertEqual(xWall.LineWidth, 100)
+self.assertEqual(xWall.LineTransparence, 5)
+self.assertEqual(hex(xWall.FillColor), '0xe6e6e6')
+self.assertEqual(xWall.FillTransparence, 0)
+
 #reopen and verify tab "Borders".
 gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
 gridwin.executeAction("ACTIVATE", tuple())
@@ -80,6 +89,11 @@ class chartWall(UITestCase):
 self.assertEqual(get_state_as_dict(xWidth)["Text"], "0.10 cm")
 self.assertEqual(get_state_as_dict(transparency)["Text"], "5%")
 
+self.assertEqual(xWall.LineWidth, 100)
+self.assertEqual(xWall.LineTransparence, 5)
+self.assertEqual(hex(xWall.FillColor), '0xe6e6e6')
+self.assertEqual(xWall.FillTransparence, 0)
+
 #Click on tab "Area"
 tabcontrol = xDialog.getChild("tabcontrol")
 select_pos(tabcontrol, "1")
@@ -107,6 +121,11 @@ class chartWall(UITestCase):
 xOKBtn = xDialog.getChild("ok")
 self.ui_test.close_dialog_through_button(xOKBtn)
 
+self.assertEqual(xWall.LineWidth, 100)
+self.assertEqual(xWall.LineTransparence, 5)
+self.assertEqual(hex(xWall.FillColor), '0x23a9d3')
+self.assertEqual(xWall.FillTransparence, 0)
+
 #reopen and verify tab "Area".
 gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
 gridwin.executeAction("ACTIVATE", tuple())
@@ -127,6 +146,11 @@ class chartWall(UITestCase):
 self.assertEqual(get_state_as_dict(gCustom)["Text"], "169")
 self.assertEqual(get_state_as_dict(bCustom)["Text"], "211")
 
+self.assertEqual(xWall.LineWidth, 100)
+self.assertEqual(xWall.LineTransparence, 5)
+self.assertEqual(hex(xWall.FillColor), '0x23a9d3')
+self.assertEqual(xWall.FillTransparence, 0)
+
 #change tab "Transparency"
 select_pos(tabcontrol, "2")
 transparency = xDialog.getChild("RBT_TRANS_LINEAR")
@@ -138,6 +162,11 @@ class chartWall(UITestCase):
 xOKBtn = xDialog.getChild("ok")
 self.ui_test.close_dialog_through_button(xOKBtn)
 
+self.assertEqual(xWall.LineWidth, 100)
+self.assertEqual(xWall.LineTransparence, 5)
+self.assertEqual(hex(xWall.FillColor), '0x23a9d3')
+self.assertEqual(xWall.FillTransparence, 51)
+
 #reopen and verify tab "Transparency"
 gridwin.executeAction("SELECT", mkPropertyValues({"OBJECT": "Object 1"}))
 gridwin.executeAction("ACTIVATE", tuple())
@@ -156,8 +185,18 @@ class chartWall(UITestCase):
 self.assertEqual(get_state_as_dict(transparency)["Checked"], "true")
 self.assertEqual(get_state_as_dict(transparencyPercent)["Text"], "51%")
 
+self.assertEqual(xWall.LineWidth, 100)
+self.assertEqual(xWall.LineTransparence, 5)
+self.assertEqual(hex(xWall.FillColor), '0x23a9d3')
+self.assertEqual(xWall.FillTransparence, 51)
+
 xOKBtn =

[Libreoffice-bugs] [Bug 131244] Fill a word form and save as doc content will destroyed

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131244

--- Comment #8 from Oliver Westphal  ---
Today I tried it again like I described in firest comment, but everything looks
good and works well??? I do not aunderstand why, but no issue anymore! So sorry
if it was my fault, but I have definetely no idea what was wrong first time
(you can see the failures in the first file vrsion). Sorry forget the bug and
close.
oliver

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131244] Fill a word form and save as doc content will destroyed

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131244

--- Comment #7 from Oliver Westphal  ---
Created attachment 158729
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158729=edit
Original file downloaded from official website of a company

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131382] New: The scope of function definitions (Calc or BASIC) is unclear

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131382

Bug ID: 131382
   Summary: The scope of function definitions (Calc or BASIC) is
unclear
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com
CC: olivier.hal...@libreoffice.org

Compare two help sections for WeekDay:

https://bit.ly/2vpJuTG
https://bit.ly/3d42lVp

(both lead to subpages of https://help.libreoffice.org/latest/en-US/), and try
to tell which is about Calc function, and which about BASIC function.

The problem is, there's no clear marking that this is WEEKDAY *spreadsheet*
function vs WeekDay BASIC function.

There are a number of coinciding function names between the two modules; and I
suppose that all functions, even without counterparts, should be somehow made
unambiguous (e.g., to not create an impression that it might be used in a
module it doesn't belong to).

In fact, that creates actual confusion in users: see e.g.
https://ask.libreoffice.org/en/question/233750/.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131360] Syntax statements in Help files that do not specify number of parameters allowed for Calc functions

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131360

Steve Fanning  changed:

   What|Removed |Added

 CC||olivier.hallot@libreoffice.
   ||org
  Component|Calc|Documentation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131357] Help files lack syntax definition for some Calc functions

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131357

Steve Fanning  changed:

   What|Removed |Added

  Component|Calc|Documentation
 CC||olivier.hallot@libreoffice.
   ||org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131354] Suggested improvement to Help files that define syntax of Calc functions

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131354

Steve Fanning  changed:

   What|Removed |Added

 CC||olivier.hallot@libreoffice.
   ||org
  Component|Calc|Documentation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2020-03-16 Thread Tamás Zolnai (via logerrit)

 loleaflet/src/control/Control.ContextMenu.js |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit ed70636427c0be301a2c2afa0dcc9c860bdad2cf
Author: Tamás Zolnai 
AuthorDate: Mon Mar 16 18:01:23 2020 +0100
Commit: Tamás Zolnai 
CommitDate: Mon Mar 16 20:27:35 2020 +0100

Enable spellchecking context menu items for Impress/Calc.

Change-Id: I0684130d3d90b4c8ba4b3dea2c912549456e8420
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90590
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/loleaflet/src/control/Control.ContextMenu.js 
b/loleaflet/src/control/Control.ContextMenu.js
index 5b29ce168..c606ef5a1 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -37,7 +37,8 @@ L.Control.ContextMenu = L.Control.extend({
  'FormatTrendline', 
'FormatTrendlineEquation', 'FormatSelection', 'FormatStockLoss',
  'FormatStockGain', 'InsertDataLabel' 
, 'DeleteDataLabel', 'ResetDataPoint',
  'InsertTrendline', 'InsertMeanValue', 
'InsertXErrorBars' , 'InsertYErrorBars', 'ResetAllDataPoints' , 'DeleteAxis',
- 'InsertAxisTitle', 'InsertMinorGrid', 
'InsertMajorGrid' , 'InsertAxis', 'DeleteMajorGrid' , 'DeleteMinorGrid'],
+ 'InsertAxisTitle', 'InsertMinorGrid', 
'InsertMajorGrid' , 'InsertAxis', 'DeleteMajorGrid' , 'DeleteMinorGrid',
+ 'SpellCheckIgnoreAll', 
'LanguageStatus', 'SpellCheckApplySuggestion'],
 
text: ['TableInsertMenu',
   'InsertRowsBefore', 'InsertRowsAfter', 
'InsertColumnsBefore', 'InsertColumnsAfter',
@@ -46,8 +47,8 @@ L.Control.ContextMenu = L.Control.extend({
   'MergeCells', 'SetOptimalColumnWidth', 
'SetOptimalRowHeight',
   'UpdateCurIndex','RemoveTableOf',
   'ReplyComment', 'DeleteComment', 
'DeleteAuthor', 'DeleteAllNotes',
-  'SpellingAndGrammarDialog', 
'LanguageStatus', 'FontDialog', 'FontDialogForParagraph',
-  'SpellCheckIgnore', 'SpellCheckIgnoreAll', 
'SpellCheckApplySuggestion'],
+  'SpellingAndGrammarDialog', 'FontDialog', 
'FontDialogForParagraph',
+  'SpellCheckIgnore'],
 
spreadsheet: ['MergeCells', 'SplitCell', 
'RecalcPivotTable', 'FormatCellDialog',
  'ShowNote', 'DeleteNote', 
'SetAnchorToCell', 'SetAnchorToCellResize'],
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130998] EDITING: Text highlight does not work on windows 10

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130998

--- Comment #3 from Adam  ---
Thank you for reporting the bug. I can not reproduce the bug in


Version: 6.4.1.2 (x64)
Build ID: 4d224e95b98b138af42a64d84056446d09082932
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 7.0.0.0.alpha0+ (x64)
Build ID: 929d46bbf42aefc1f6cf046c2b9cf3d7c4e1efc5
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127551] LibreOffice Will Not Update to Version 6.2.7.1

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127551

Julien Nabet  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #5 from Julien Nabet  ---
Sorry if I missed your feedback.
Let's put this one to WFM since there's no specific fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127551] LibreOffice Will Not Update to Version 6.2.7.1

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=127551

idmoose...@yahoo.com  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from idmoose...@yahoo.com  ---
On September 15, 2019, at 11:51 AM Mountain Time, I replied with the following
to an email I received, "You are correct; it was "2902". Thank you for the
article links. I was able to install and run LibreOffice as of this morning."

No idea why is still open after six months, but this issue was resolved back in
September 2019.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131381] docx rendering problems

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131381

msdobre...@gmail.com  changed:

   What|Removed |Added

 Attachment #158728|document 1  |samples (documents 1 to 3)
description||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131380] Crash when opening xlsx file, FILEOPEN

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131380

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
Lorenzo, if you can't attach your file here, then try retest your problem in
LibreOffice build from TDF or try build it yourself from source code

You use build from Arch Linux and possibly the problem is in that...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131381] New: docx rendering problems

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131381

Bug ID: 131381
   Summary: docx rendering problems
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: msdobre...@gmail.com

Created attachment 158728
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158728=edit
document 1

Hello, I have some docx files that look scrambled in LibreOffice Wirter
(6.3.4.2.0+ under Sabayon Linux and Windows 10) by comparison to the original
Microsoft Word. This applies from characters to elements positioning.

I have attached three documents, each:
- in original form as .docx
- exported from Microsoft Word as .pdf
- screenshot as they appear in this version

Sample 1. The most messed up to illegibility. I can't even guess what should
look like, I can't select the rounded areas/drawings/images. The first line of
the title seems to have the characters replaced in other codepage.

Sample 2. An area moved from the page 3 to page 2, under some images.

Sample 3. There are mathematical operations. In our school convention, when
disposed vertically, after the operands a horizontal line is drawn. In this
case seems to strike some operands. Also rectangles appear around some texts.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131380] Crash when opening xlsx file, FILEOPEN

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131380

--- Comment #2 from Lorenzo  ---
Created attachment 158727
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158727=edit
Valgrind log

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131380] Crash when opening xlsx file, FILEOPEN

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131380

--- Comment #1 from Lorenzo  ---
Created attachment 158726
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158726=edit
gdb log

Shows a segmentation fault, maybe while drawing a graph?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131380] New: Crash when opening xlsx file, FILEOPEN

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131380

Bug ID: 131380
   Summary: Crash when opening xlsx file, FILEOPEN
   Product: LibreOffice
   Version: 6.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: buonanno.lore...@gmail.com

Description:
Trying to open the file, i get the message "Due to an error, Libreoffice
crashed". Both using LibreOffice 6.4.1.2 and LibreOffice 6.4.1.2

Unfortunately I cannot share the file, but I can share gdb log (which shows a
segmantation fault in graph related operations) and the valgrind log (which I
think shows an invalid memory read that causes the segfault)

Steps to Reproduce:
1. Try to open a specific xslx file

Actual Results:
I get the message "Due to an error, Libreoffice crashed"

Expected Results:
Being able to see the file contents


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.4.1.2
Build ID: 6.4.1-3
CPU threads: 8; OS: Linux 5.5; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.utf8); UI-Language: en-US
Calc: threaded

LibreOffice is a modern, easy-to-use, open source productivity suite for word
processing, spreadsheets, presentations and more.

This release was supplied by Arch Linux.
Copyright © 2000–2020 LibreOffice contributors.
LibreOffice was based on OpenOffice.org.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #5 from Jamie Dimmel  ---
Thank you for the explanation.

I wasn't thinking about styles being hardcoded and not appearing in a 'default'
template. I just assumed all styles were in the default templates, and thus
could overwrite any non-custom styles back to template (or program) defaults.

As an end user I do (or would) find it useful to be able to reset all styles in
a doc back to their original (whether program or template) defaults, rather
than saving a file to plain text, then save back to odt, since if you use the
latter method you lose the link between blocks of text and styling.

I guess this becomes an issue for the user interface or design group then. In
the meantime, I'll just create my own template with all standard styles so I
can use it to overwrite something if I need to.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130719] Overwriting Writer styles does not overwrite changes to Marginalia paragraph style

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130719

--- Comment #5 from Jamie Dimmel  ---
Thank you for the explanation.

I wasn't thinking about styles being hardcoded and not appearing in a 'default'
template. I just assumed all styles were in the default templates, and thus
could overwrite any non-custom styles back to template (or program) defaults.

As an end user I do (or would) find it useful to be able to reset all styles in
a doc back to their original (whether program or template) defaults, rather
than saving a file to plain text, then save back to odt, since if you use the
latter method you lose the link between blocks of text and styling.

I guess this becomes an issue for the user interface or design group then. In
the meantime, I'll just create my own template with all standard styles so I
can use it to overwrite something if I need to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: android/lib

2020-03-16 Thread Jan Holesovsky (via logerrit)

 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |   24 
+++---
 1 file changed, 18 insertions(+), 6 deletions(-)

New commits:
commit da9897f72575a502711cbb7b84fc7817cb31c2bd
Author: Jan Holesovsky 
AuthorDate: Mon Mar 16 18:35:43 2020 +0100
Commit: Michael Meeks 
CommitDate: Mon Mar 16 19:42:06 2020 +0100

android: Use "wt" mode even for Export As.

And use a real tempfile for that when I'm touching this code.

Change-Id: Iad6ea41b9e9c6459f66f1dee0258092ead1b8de5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90587
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 434b467ce..c1edd099a 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -613,20 +613,32 @@ public class LOActivity extends AppCompatActivity {
 }
 String format = getFormatForRequestCode(requestCode);
 if (format != null) {
-final File tempFile = new 
File(LOActivity.this.getCacheDir(), "temp.file");
-LOActivity.this.saveAs(tempFile.toURI().toString(), 
format);
-try (InputStream inputStream = new 
FileInputStream(tempFile)) {
-OutputStream outputStream = 
getContentResolver().openOutputStream(intent.getData());
+InputStream inputStream = null;
+OutputStream outputStream = null;
+try {
+final File tempFile = 
File.createTempFile("LibreOffice", "." + format, this.getCacheDir());
+LOActivity.this.saveAs(tempFile.toURI().toString(), 
format);
+
+inputStream = new FileInputStream(tempFile);
+outputStream = 
getContentResolver().openOutputStream(intent.getData(), "wt");
+
 byte[] buffer = new byte[4096];
 int len;
-while ((len = inputStream.read(buffer)) > 0) {
+while ((len = inputStream.read(buffer)) != -1) {
 outputStream.write(buffer, 0, len);
 }
 outputStream.flush();
-outputStream.close();
 } catch (Exception e) {
 Toast.makeText(this, "Something went wrong while 
Saving as: " + e.getMessage(), Toast.LENGTH_SHORT).show();
 e.printStackTrace();
+} finally {
+try {
+if (inputStream != null)
+inputStream.close();
+if (outputStream != null)
+outputStream.close();
+} catch (Exception e) {
+}
 }
 return;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

2020-03-16 Thread Jan Holesovsky (via logerrit)

 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 67757fac7e88edc528d10f9071c66ba22644dc67
Author: Jan Holesovsky 
AuthorDate: Mon Mar 16 17:38:23 2020 +0100
Commit: Michael Meeks 
CommitDate: Mon Mar 16 19:40:31 2020 +0100

android: Fix file corruption.

The problem was that when we were uploading back to the content Uri and
the length was shorter than the original content, the file remained as
long as before the save - which then was detected as corrupted file upon
further load.

Change-Id: Ica09a64739dbf7933d5722149134e461ae79bd80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90585
Tested-by: Michael Meeks 
Reviewed-by: Michael Meeks 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 8e5c3c7fe..434b467ce 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -522,7 +522,7 @@ public class LOActivity extends AppCompatActivity {
 inputStream = new FileInputStream(mTempFile);
 
 Uri uri = getIntent().getData();
-outputStream = contentResolver.openOutputStream(uri);
+outputStream = contentResolver.openOutputStream(uri, "wt");
 
 byte[] buffer = new byte[1024];
 int length;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

2020-03-16 Thread Jan Holesovsky (via logerrit)

 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |   22 
+++---
 1 file changed, 16 insertions(+), 6 deletions(-)

New commits:
commit 56632cc1c9bce65787608f60d454cd016b9e1eee
Author: Jan Holesovsky 
AuthorDate: Mon Mar 16 17:35:37 2020 +0100
Commit: Michael Meeks 
CommitDate: Mon Mar 16 19:40:09 2020 +0100

android: Cosmetic improvements to the content Uri download / upload.

Change-Id: I290211e0024dfc86c1f57314bbef00f7117928bd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90584
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index e02ce5382..8e5c3c7fe 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -484,11 +484,13 @@ public class LOActivity extends AppCompatActivity {
 
 byte[] buffer = new byte[1024];
 int length;
-while ((length = inputStream.read(buffer)) > 0) {
+long bytes = 0;
+while ((length = inputStream.read(buffer)) != -1) {
 outputStream.write(buffer, 0, length);
+bytes += length;
 }
-Log.e(TAG, "Success copying from " + uri + " to " + mTempFile);
-return true;
+
+Log.i(TAG, "Success copying " + bytes + " bytes from " + uri + 
" to " + mTempFile);
 } finally {
 if (inputStream != null)
 inputStream.close();
@@ -496,10 +498,14 @@ public class LOActivity extends AppCompatActivity {
 outputStream.close();
 }
 } catch (FileNotFoundException e) {
+Log.e(TAG, "file not found: " + e.getMessage());
 return false;
 } catch (IOException e) {
+Log.e(TAG, "exception: " + e.getMessage());
 return false;
 }
+
+return true;
 }
 
 /** Check that we have created a temp file, and if yes, copy it back to 
the content: URI. */
@@ -513,16 +519,20 @@ public class LOActivity extends AppCompatActivity {
 
 try {
 try {
+inputStream = new FileInputStream(mTempFile);
+
 Uri uri = getIntent().getData();
 outputStream = contentResolver.openOutputStream(uri);
-inputStream = new FileInputStream(mTempFile);
 
 byte[] buffer = new byte[1024];
 int length;
-while ((length = inputStream.read(buffer)) > 0) {
+long bytes = 0;
+while ((length = inputStream.read(buffer)) != -1) {
 outputStream.write(buffer, 0, length);
+bytes += length;
 }
-Log.e(TAG, "Success copying from " + mTempFile + " to " + uri);
+
+Log.i(TAG, "Success copying " + bytes + " bytes from " + 
mTempFile + " to " + uri);
 } finally {
 if (inputStream != null)
 inputStream.close();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

2020-03-16 Thread Jan Holesovsky (via logerrit)

 android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java |4 
++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b10113158efc2f646cc4ef14e6cb94521746e749
Author: Jan Holesovsky 
AuthorDate: Mon Mar 16 11:20:51 2020 +0100
Commit: Michael Meeks 
CommitDate: Mon Mar 16 19:38:16 2020 +0100

android: Dismiss the progress dialog on error too.

Change-Id: Ib88e98769bb59134ca90268a6a177459023aa842
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90583
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git 
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java 
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 470431e5b..e02ce5382 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -781,7 +781,7 @@ public class LOActivity extends AppCompatActivity {
 });
 
 // update progress bar when loading
-if (message.startsWith("'statusindicator")) {
+if (message.startsWith("'statusindicator") || 
message.startsWith("'error:")) {
 runOnUiThread(new Runnable() {
 public void run() {
 // update progress bar if it exists
@@ -798,7 +798,7 @@ public class LOActivity extends AppCompatActivity {
 
 mProgressDialog.determinateProgress(progress);
 }
-else if (message.startsWith("'statusindicatorfinish:")) {
+else if (message.startsWith("'statusindicatorfinish:") || 
message.startsWith("'error:")) {
 mProgressDialog.dismiss();
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp

2020-03-16 Thread Michael Meeks (via logerrit)

 wsd/LOOLWSD.cpp |   58 
 wsd/LOOLWSD.hpp |4 +++
 2 files changed, 33 insertions(+), 29 deletions(-)

New commits:
commit 4d9d769d950e6555de4392fb10c82efa53002611
Author: Michael Meeks 
AuthorDate: Mon Mar 16 16:19:37 2020 +
Commit: Michael Meeks 
CommitDate: Mon Mar 16 19:36:42 2020 +0100

Expose disk space and session checks via LOOLWSD class.

Change-Id: I7b135d325147694cc33946b34a29ab96b2e2b918
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90577
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index ecceaca34..177360dbc 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -256,8 +256,31 @@ inline void shutdownLimitReached(const 
std::shared_ptr
 }
 #endif
 
-inline void checkSessionLimitsAndWarnClients()
+#if !MOBILEAPP
+/// Internal implementation to alert all clients
+/// connected to any document.
+void alertAllUsersInternal(const std::string& msg)
+{
+std::lock_guard docBrokersLock(DocBrokersMutex);
+
+LOG_INF("Alerting all users: [" << msg << "]");
+
+if (UnitWSD::get().filterAlertAllusers(msg))
+return;
+
+for (auto& brokerIt : DocBrokers)
+{
+std::shared_ptr docBroker = brokerIt.second;
+docBroker->addCallback([msg, docBroker](){ 
docBroker->alertAllUsers(msg); });
+}
+}
+#endif
+
+} // end anonymous namespace
+
+void LOOLWSD::checkSessionLimitsAndWarnClients()
 {
+#if !ENABLE_SUPPORT_KEY
 #if !MOBILEAPP
 ssize_t docBrokerCount = DocBrokers.size() - 
ConvertToBroker::getInstanceCount();
 if (LOOLWSD::MaxDocuments < 1 &&
@@ -276,29 +299,10 @@ inline void checkSessionLimitsAndWarnClients()
 }
 }
 #endif
-}
-
-#if !MOBILEAPP
-/// Internal implementation to alert all clients
-/// connected to any document.
-void alertAllUsersInternal(const std::string& msg)
-{
-std::lock_guard docBrokersLock(DocBrokersMutex);
-
-LOG_INF("Alerting all users: [" << msg << "]");
-
-if (UnitWSD::get().filterAlertAllusers(msg))
-return;
-
-for (auto& brokerIt : DocBrokers)
-{
-std::shared_ptr docBroker = brokerIt.second;
-docBroker->addCallback([msg, docBroker](){ 
docBroker->alertAllUsers(msg); });
-}
-}
 #endif
+}
 
-static void checkDiskSpaceAndWarnClients(const bool cacheLastCheck)
+void LOOLWSD::checkDiskSpaceAndWarnClients(const bool cacheLastCheck)
 {
 #if !MOBILEAPP
 try
@@ -317,8 +321,6 @@ static void checkDiskSpaceAndWarnClients(const bool 
cacheLastCheck)
 #endif
 }
 
-}
-
 /// Remove dead and idle DocBrokers.
 /// The client of idle document should've greyed-out long ago.
 /// Returns true if at least one is removed.
@@ -378,7 +380,7 @@ static int forkChildren(const int number)
 
 if (number > 0)
 {
-checkDiskSpaceAndWarnClients(false);
+LOOLWSD::checkDiskSpaceAndWarnClients(false);
 
 #ifdef KIT_IN_PROCESS
 forkLibreOfficeKit(LOOLWSD::ChildRoot, LOOLWSD::SysTemplate, 
LOOLWSD::LoTemplate, LO_JAIL_SUBPATH, number);
@@ -2874,12 +2876,10 @@ private:
 // Add and load the session.
 docBroker->addSession(clientSession);
 
-checkDiskSpaceAndWarnClients(true);
-#if !ENABLE_SUPPORT_KEY
+LOOLWSD::checkDiskSpaceAndWarnClients(true);
 // Users of development versions get just an 
info
 // when reaching max documents or connections
-checkSessionLimitsAndWarnClients();
-#endif
+LOOLWSD::checkSessionLimitsAndWarnClients();
 }
 catch (const UnauthorizedRequestException& exc)
 {
diff --git a/wsd/LOOLWSD.hpp b/wsd/LOOLWSD.hpp
index 166de2817..383263314 100644
--- a/wsd/LOOLWSD.hpp
+++ b/wsd/LOOLWSD.hpp
@@ -191,6 +191,10 @@ public:
 /// child kit processes and cleans up DocBrokers.
 static void doHousekeeping();
 
+static void checkDiskSpaceAndWarnClients(const bool cacheLastCheck);
+
+static void checkSessionLimitsAndWarnClients();
+
 /// Close document with @docKey and a @message
 static void closeDocument(const std::string& docKey, const std::string& 
message);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basctl/source reportdesign/source sc/source sd/source sw/source vcl/source

2020-03-16 Thread Noel Grandin (via logerrit)

 basctl/source/dlged/dlgedview.cxx |1 -
 reportdesign/source/ui/report/SectionView.cxx |1 -
 sc/source/ui/view/olinewin.cxx|1 -
 sd/source/ui/slidesorter/view/SlideSorterView.cxx |1 -
 sw/source/core/view/vprint.cxx|1 -
 vcl/source/control/button.cxx |   17 -
 vcl/source/control/imp_listbox.cxx|1 -
 vcl/source/control/prgsbar.cxx|1 -
 vcl/source/control/slider.cxx |1 -
 vcl/source/control/spinbtn.cxx|7 ---
 vcl/source/control/spinfld.cxx|5 -
 vcl/source/treelist/iconviewimpl.cxx  |4 
 vcl/source/treelist/svimpbox.cxx  |5 -
 vcl/source/window/status.cxx  |   21 ++---
 14 files changed, 2 insertions(+), 65 deletions(-)

New commits:
commit a7de363cead5cd0021d2e3df4573d4cbe27df23b
Author: Noel Grandin 
AuthorDate: Mon Mar 16 15:48:43 2020 +0200
Commit: Noel Grandin 
CommitDate: Mon Mar 16 19:09:02 2020 +0100

remove unnecessary Window::Update() calls, which immediately follow 
Invalidate

Update() is effectively "paint immediately". Rather just let the
invalidate do it's thing and have the widget paint on the next paint
loop, along with the rest of the stuff.

This is probably mostly cargo-cult, from the days when our
invalidate/paint timer could take a long time to kick in.

Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567
Reviewed-by: Caolán McNamara 
Reviewed-by: Noel Grandin 
Tested-by: Jenkins

diff --git a/basctl/source/dlged/dlgedview.cxx 
b/basctl/source/dlged/dlgedview.cxx
index 3eda45a289d1..3ec0f72e1fda 100644
--- a/basctl/source/dlged/dlgedview.cxx
+++ b/basctl/source/dlged/dlgedview.cxx
@@ -110,7 +110,6 @@ void DlgEdView::MakeVisible( const tools::Rectangle& rRect, 
vcl::Window& rWin )
 rWin.Scroll( -nScrollX, -nScrollY );
 aMap.SetOrigin( Point( aOrg.X() - nScrollX, aOrg.Y() - nScrollY ) );
 rWin.SetMapMode( aMap );
-rWin.Update();
 rWin.Invalidate();
 
 // update scroll bars
diff --git a/reportdesign/source/ui/report/SectionView.cxx 
b/reportdesign/source/ui/report/SectionView.cxx
index 9a23632da48a..100703eef03e 100644
--- a/reportdesign/source/ui/report/SectionView.cxx
+++ b/reportdesign/source/ui/report/SectionView.cxx
@@ -110,7 +110,6 @@ void OSectionView::MakeVisible( const tools::Rectangle& 
rRect, vcl::Window& rWin
 rWin.Scroll( -nScrollX, -nScrollY );
 aMap.SetOrigin( Point( aOrg.X() - nScrollX, aOrg.Y() - nScrollY ) );
 rWin.SetMapMode( aMap );
-rWin.Update();
 rWin.Invalidate();
 
 if ( m_pReportWindow )
diff --git a/sc/source/ui/view/olinewin.cxx b/sc/source/ui/view/olinewin.cxx
index feaec576e295..ea117e566c90 100644
--- a/sc/source/ui/view/olinewin.cxx
+++ b/sc/source/ui/view/olinewin.cxx
@@ -123,7 +123,6 @@ void ScOutlineWindow::ScrollPixel( long nDiff )
 
 ScrollRel( nDiff, nStart, nEnd );
 Invalidate( GetRectangle( 0, nInvStart, GetOutputSizeLevel() - 1, nInvEnd 
) );
-Update();
 
 // if focus becomes invisible, move it to next visible button
 ImplMoveFocusToVisible( nDiff < 0 );
diff --git a/sd/source/ui/slidesorter/view/SlideSorterView.cxx 
b/sd/source/ui/slidesorter/view/SlideSorterView.cxx
index 31df3f5ae004..82eb09404c3d 100644
--- a/sd/source/ui/slidesorter/view/SlideSorterView.cxx
+++ b/sd/source/ui/slidesorter/view/SlideSorterView.cxx
@@ -826,7 +826,6 @@ SlideSorterView::DrawLock::~DrawLock()
 if (mpWindow)
 {
 mpWindow->Invalidate(mrView.maRedrawRegion);
-mpWindow->Update();
 }
 }
 
diff --git a/sw/source/core/view/vprint.cxx b/sw/source/core/view/vprint.cxx
index 5f09eb999216..be73000769d9 100644
--- a/sw/source/core/view/vprint.cxx
+++ b/sw/source/core/view/vprint.cxx
@@ -114,7 +114,6 @@ void SwPaintQueue::Repaint()
 {
 // for previewing, since rows/columns are known in 
PaintHdl (UI)
 pSh->GetWin()->Invalidate();
-pSh->GetWin()->Update();
 }
 }
 else
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index e859625f6d63..43636df0f94a 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -1462,7 +1462,6 @@ bool PushButton::PreNotify( NotifyEvent& rNEvt )
 else
 {
 pBorder->Invalidate( InvalidateFlags::NoErase );
-pBorder->Update();
 }
 }
 else if( (GetStyle() & WB_FLATBUTTON) ||
@@ -2206,7 +2205,6 @@ void RadioButton::ImplCallClick( bool bGrabFocus, 
GetFocusFlags nFocusFlags )
 mbChecked =

[Libreoffice-commits] core.git: solenv/gbuild sw/qa

2020-03-16 Thread Noel Grandin (via logerrit)

 solenv/gbuild/UITest.mk |1 +
 sw/qa/uitest/findReplace/findReplace.py |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 8ea5a522f76dd089446e901f3cd324f98cd973e7
Author: Noel Grandin 
AuthorDate: Mon Mar 16 15:29:52 2020 +0200
Commit: Noel Grandin 
CommitDate: Mon Mar 16 19:09:26 2020 +0100

make python warnings in our UITests error early

rather than erroring only on some of the buildbots (in particular one of
the daily buildbots seems to have this on by default)

And fix a invalid escape sequence we discover in the process.

Change-Id: Icd62dae2959e5117dec8949ce55dd484503fc446
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90565
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/UITest.mk b/solenv/gbuild/UITest.mk
index f90a1abe1b21..e428dbd03c48 100644
--- a/solenv/gbuild/UITest.mk
+++ b/solenv/gbuild/UITest.mk
@@ -73,6 +73,7 @@ else
PYTHONPATH="$(PYPATH)" \
TestUserDir="$(call gb_Helper_make_url,$(dir $(call 
gb_UITest_get_target,$*)))" \
PYTHONDONTWRITEBYTECODE=0 \
+   PYTHONWARNINGS=error \
$(gb_TEST_ENV_VARS) \
$(gb_UITest_COMMAND) \
--soffice="$(gb_UITest_SOFFICEARG)" \
diff --git a/sw/qa/uitest/findReplace/findReplace.py 
b/sw/qa/uitest/findReplace/findReplace.py
index f465e9b44aed..83821ae8662b 100644
--- a/sw/qa/uitest/findReplace/findReplace.py
+++ b/sw/qa/uitest/findReplace/findReplace.py
@@ -126,7 +126,7 @@ class findReplace(UITestCase):
 
self.ui_test.execute_modeless_dialog_through_command(".uno:SearchDialog")
 xDialog = self.xUITest.getTopFocusWindow()
 searchterm = xDialog.getChild("searchterm")
-searchterm.executeAction("TYPE", 
mkPropertyValues({"TEXT":"T(est|other)\>"}))   #find
+searchterm.executeAction("TYPE", 
mkPropertyValues({"TEXT":"T(est|other)\\>"}))   #find
 replaceterm = xDialog.getChild("replaceterm")
 replaceterm.executeAction("TYPE", 
mkPropertyValues({"TEXT":"replaced$1"})) #replace
 regexp = xDialog.getChild("regexp")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 131377] Not Sorting Dates Correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131377

--- Comment #4 from elmau  ---
Created attachment 158725
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158725=edit
Tes csv bug

File CSV is import correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131377] Not Sorting Dates Correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131377

--- Comment #3 from elmau  ---
I can't reproduce bug. 

Version: 6.4.1.2
Build ID: 4d224e95b98b138af42a64d84056446d09082932
CPU threads: 8; OS: Linux 5.5; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131379] New: Style selector not available.

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131379

Bug ID: 131379
   Summary: Style selector not available.
   Product: LibreOffice
   Version: 6.4.1.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zywek-mail...@nvps.pl

Description:
When i open a dialog, where i can insert a horizontal line, and modify the
styles, Orca says nothing, but should say some attribute to insert where the
focus is.

WHen pressing tab and shift tab, orca says a little part of attribute name,
then stops saying.

I received informations, that it's a problem with emitting accessibility events
on style selector dialog. It can be checked in accerciser, or another software,
which making possibility to test accessibility in applications.

Steps to Reproduce:
1. OPen some document in libre office, then make a new line, and press f11
2. Press home to hear "Default style" or something about the default writing
styles.
3. Press DOwn arrow

Actual Results:
Orca does not speak correctly the content of the style selector dialog

Expected Results:
Orca should say all informations about styles in the dialog.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I'm using a last version of orca from gnome git lab on archlinux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/images loleaflet/src

2020-03-16 Thread Pedro Pinto Silva (via logerrit)

 loleaflet/images/lc_sdtabledesignpanel.svg   |1 +
 loleaflet/src/control/Control.JSDialogBuilder.js |5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 6b4539f40ea40e492965feb1e429e23db4be761d
Author: Pedro Pinto Silva 
AuthorDate: Mon Mar 16 17:42:46 2020 +0100
Commit: Pedro Pinto da Silva 
CommitDate: Mon Mar 16 18:29:49 2020 +0100

Mobile: Impress: mobileWizard: Table properties: Add id to table design and 
add respective icon

Change-Id: I73ab3844fe0fbf8cb8178cb46e850ff5d3eb37c0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90579
Tested-by: Jenkins CollaboraOffice 
Tested-by: Pedro Pinto da Silva 
Reviewed-by: Pedro Pinto da Silva 

diff --git a/loleaflet/images/lc_sdtabledesignpanel.svg 
b/loleaflet/images/lc_sdtabledesignpanel.svg
new file mode 100644
index 0..c3c697518
--- /dev/null
+++ b/loleaflet/images/lc_sdtabledesignpanel.svg
@@ -0,0 +1 @@
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/loleaflet/src/control/Control.JSDialogBuilder.js 
b/loleaflet/src/control/Control.JSDialogBuilder.js
index c9c1965d1..f0171fb41 100644
--- a/loleaflet/src/control/Control.JSDialogBuilder.js
+++ b/loleaflet/src/control/Control.JSDialogBuilder.js
@@ -242,8 +242,9 @@ L.Control.JSDialogBuilder = L.Control.extend({
 
var leftDiv = L.DomUtil.create('div', 'ui-header-left', 
sectionTitle);
var titleClass = '';
-   if (sectionTitle.id === 'paperformat' || sectionTitle.id === 
'orientation' || sectionTitle.id === 'masterslide')
-   iconPath = 'images/lc_'+ sectionTitle.id +'.svg';
+   console.debug('sectionTitle.id' + sectionTitle.id);
+   if (sectionTitle.id === 'paperformat' || sectionTitle.id === 
'orientation' || sectionTitle.id === 'masterslide' || sectionTitle.id === 
'SdTableDesignPanel')
+   iconPath = 'images/lc_'+ sectionTitle.id.toLowerCase() 
+'.svg';
if (iconPath) {
var icon = L.DomUtil.create('img', 'menu-entry-icon', 
leftDiv);
icon.src = iconPath;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/source

2020-03-16 Thread Samuel Mehrbrodt (via logerrit)

 sc/source/ui/docshell/docsh4.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 67a52b17b51495a6112f42de7cb465d69f2bb139
Author: Samuel Mehrbrodt 
AuthorDate: Tue Mar 10 09:15:09 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Mar 16 18:27:33 2020 +0100

tdf#126742 Don't change visible area while retrieving it

This leads to funny size changes in embedded calc docs

Change-Id: I2c4a0fbebb782faae7508e7d61c8da9d440a5916
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90247
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit c185263f45a556e6c695c766476e67fbd2ea3593)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90386
Reviewed-by: Thorsten Behrens 

diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index ced26c3261d2..9c04bae44b0f 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -2114,8 +2114,6 @@ tools::Rectangle ScDocShell::GetVisArea( sal_uInt16 
nAspect ) const
 nStartRow = nEndRow;
 tools::Rectangle aNewArea = m_aDocument
 .GetMMRect( nStartCol,nStartRow, 
nEndCol,nEndRow, nVisTab );
-//TODO/LATER: different methods for setting VisArea?!
-const_cast(this)->SfxObjectShell::SetVisArea( aNewArea );
 return aNewArea;
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 2 commits - vcl/source vcl/win

2020-03-16 Thread Samuel Mehrbrodt (via logerrit)

 vcl/source/app/svapp.cxx   |   11 ++-
 vcl/source/window/menu.cxx |7 +++
 vcl/win/app/salinfo.cxx|   10 +-
 3 files changed, 26 insertions(+), 2 deletions(-)

New commits:
commit 5d8e07231b6e8b106292f212a3c80be004e11d6a
Author: Samuel Mehrbrodt 
AuthorDate: Thu Mar 12 14:12:59 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Mar 16 18:26:57 2020 +0100

Some more checks for correct screen size

Change-Id: Id5a811e4227052fd9117ab2b099de31e8e3b90c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90413
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit 3741d70743c297029f54b20b0ca711f40cff7097)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90576
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 33420e5456fc..5a02e96b05a5 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1229,7 +1229,16 @@ unsigned int Application::GetDisplayExternalScreen()
 tools::Rectangle Application::GetScreenPosSizePixel( unsigned int nScreen )
 {
 SalSystem* pSys = ImplGetSalSystem();
-return pSys ? pSys->GetDisplayScreenPosSizePixel( nScreen ) : 
tools::Rectangle();
+if (!pSys)
+{
+SAL_WARN("vcl", "Requesting screen size/pos for screen #" << nScreen 
<< " failed");
+assert(false);
+return tools::Rectangle();
+}
+tools::Rectangle aRect = pSys->GetDisplayScreenPosSizePixel(nScreen);
+if (aRect.getHeight() == 0)
+SAL_WARN("vcl", "Requesting screen size/pos for screen #" << nScreen 
<< " returned 0 height.");
+return aRect;
 }
 
 namespace {
diff --git a/vcl/win/app/salinfo.cxx b/vcl/win/app/salinfo.cxx
index 90fa81b04d0e..ba914e280e82 100644
--- a/vcl/win/app/salinfo.cxx
+++ b/vcl/win/app/salinfo.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 #include 
@@ -161,7 +162,14 @@ unsigned int WinSalSystem::GetDisplayBuiltInScreen()
 tools::Rectangle WinSalSystem::GetDisplayScreenPosSizePixel( unsigned int 
nScreen )
 {
 initMonitors();
-return (nScreen < m_aMonitors.size()) ? m_aMonitors[nScreen].m_aArea : 
tools::Rectangle();
+if (nScreen >= m_aMonitors.size())
+{
+SAL_WARN("vcl", "Requested screen size/pos for screen #"
+<< nScreen << ", but only " << m_aMonitors.size() 
<< " screens found.");
+assert(false);
+return tools::Rectangle();
+}
+return m_aMonitors[nScreen].m_aArea;
 }
 
 int WinSalSystem::ShowNativeMessageBox(const OUString& rTitle, const OUString& 
rMessage)
commit a22c6cdc74584ae6c9efd731ea524de210ec8c2c
Author: Samuel Mehrbrodt 
AuthorDate: Wed Mar 11 12:41:58 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Mar 16 18:26:42 2020 +0100

Add some fallback minimum size when screen size detection goes wrong

Change-Id: I97ec2359b8ae406e310a5d043ac068ddd89b3fd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90320
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 643a1492bd648fbd803ca86aca600cc2bdaf5819)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90575
Tested-by: Thorsten Behrens 

diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index a2d6083c234f..e2733c607e24 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -2927,6 +2927,13 @@ sal_uInt16 PopupMenu::ImplExecute( const 
VclPtr& pW, const tools::R
 nMaxHeight = std::min(nMaxHeight, std::max(nHeightAbove, 
nHeightBelow));
 }
 
+// In certain cases this might be misdetected with a height of 0, leading 
to menus not being displayed.
+// So assume that the available screen size matches at least the system 
requirements
+SAL_WARN_IF(nMaxHeight < 768, "vcl",
+"Available height misdetected as " << nMaxHeight
+   << "px. Setting to 768px 
instead.");
+nMaxHeight = std::max(nMaxHeight, 768l);
+
 if (pStartedFrom && pStartedFrom->IsMenuBar())
 nMaxHeight -= pW->GetSizePixel().Height();
 sal_Int32 nLeft, nTop, nRight, nBottom;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 131291] EDITING: Chart: Not possible to change format in labels ( only 6.3 )

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131291

--- Comment #5 from Xisco Faulí  ---
Just for the record, I do verify it's fixed in

Version: 6.3.6.0.0+
Build ID: 2af4d304992d2a508e0d79cd855b93ca7559ebef
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

however, https://gerrit.libreoffice.org/c/core/+/90391 still fails because of
another issue.

1. Open attachment 158371 from bug 131115
2. Edit the chart
3. Double click on the labels
4. Change format to Currency
5. Close Data Label Dialog
6. Open the dialog again
7. Format

-> Number is preselected instead of Currency.
This problem was fixed in mas and libreoffice-6-4 by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c0cd2d4e0fa70d6eaf3cd3929bc0ad4786e9f4ed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131378] software is not working

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131378

Ridmi Ekanayake  changed:

   What|Removed |Added

URL||https://github.com/bugzilla
   ||/bugzilla.git

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130371] calc: editing: ui: weakness with named ranges, copying of cell to another sheet creates name reference not in dropdown, and not 'undone' with undo of copy,

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130371

--- Comment #10 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9a7fb5f2c4eea895e545437081ad50582bf7cacf

tdf#130371: Add UItest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2020-03-16 Thread Xisco Fauli (via logerrit)

 sc/qa/uitest/calc_dialogs/openDialogs.py   |3 -
 sc/qa/uitest/calc_tests/data/tdf130371.ods |binary
 sc/qa/uitest/calc_tests9/tdf130371.py  |   72 +
 3 files changed, 74 insertions(+), 1 deletion(-)

New commits:
commit 9a7fb5f2c4eea895e545437081ad50582bf7cacf
Author: Xisco Fauli 
AuthorDate: Mon Mar 16 15:49:23 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Mar 16 18:13:56 2020 +0100

tdf#130371: Add UItest

Change-Id: Ia1bd884d3aa4210e777ea59aece50940d3aa6f68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90571
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sc/qa/uitest/calc_dialogs/openDialogs.py 
b/sc/qa/uitest/calc_dialogs/openDialogs.py
index 7d38ba004da1..d49701aae5f4 100644
--- a/sc/qa/uitest/calc_dialogs/openDialogs.py
+++ b/sc/qa/uitest/calc_dialogs/openDialogs.py
@@ -73,7 +73,8 @@ dialogs = [
 # {"command": ".uno:AddName", "closeButton": "cancel"},
 # Cancel button tested in uitest/demo_ui/edit.py
 # "add" button tested in uitest/calc_tests/create_range_name.py
-{"command": ".uno:DefineName", "closeButton": "cancel"},
+#{"command": ".uno:DefineName", "closeButton": "cancel"},
+# tested in sc/qa/uitest/calc_tests9/tdf130371.py
 # {"command": ".uno:SheetInsertName", "closeButton": "close"},
 # dialog does not open
 {"command": ".uno:CreateNames", "closeButton": "cancel", "skipTestOK": 
True},
diff --git a/sc/qa/uitest/calc_tests/data/tdf130371.ods 
b/sc/qa/uitest/calc_tests/data/tdf130371.ods
new file mode 100644
index ..41099bda3c51
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf130371.ods differ
diff --git a/sc/qa/uitest/calc_tests9/tdf130371.py 
b/sc/qa/uitest/calc_tests9/tdf130371.py
new file mode 100644
index ..6a8f00cbf7ef
--- /dev/null
+++ b/sc/qa/uitest/calc_tests9/tdf130371.py
@@ -0,0 +1,72 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+class namedRanges(UITestCase):
+
+def test_tdf130371(self):
+calc_doc =  
self.ui_test.load_file(get_url_for_data_file("tdf130371.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+
+text1 = "value\t$Sheet2.$B$2\tSheet2"
+text2 = "value\t$Sheet3.$B$2\tSheet3"
+text3 = "value\t$Sheet4.$B$2\tSheet4"
+
+self.ui_test.execute_dialog_through_command(".uno:DefineName")
+xDialog = self.xUITest.getTopFocusWindow()
+namesList = xDialog.getChild('names')
+self.assertEqual(2, len(namesList.getChildren()))
+self.assertEqual(get_state_as_dict(namesList.getChild('0'))["Text"], 
text1)
+self.assertEqual(get_state_as_dict(namesList.getChild('1'))["Text"], 
text2)
+
+xOkBtn = xDialog.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
+
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "B3"}))
+self.xUITest.executeCommand(".uno:Copy")
+
+self.xUITest.executeCommand(".uno:JumpToNextTable")
+self.xUITest.executeCommand(".uno:JumpToNextTable")
+
+self.xUITest.executeCommand(".uno:Paste")
+
+self.ui_test.execute_dialog_through_command(".uno:DefineName")
+xDialog = self.xUITest.getTopFocusWindow()
+namesList = xDialog.getChild('names')
+self.assertEqual(3, len(namesList.getChildren()))
+self.assertEqual(get_state_as_dict(namesList.getChild('0'))["Text"], 
text1)
+self.assertEqual(get_state_as_dict(namesList.getChild('1'))["Text"], 
text2)
+self.assertEqual(get_state_as_dict(namesList.getChild('2'))["Text"], 
text3)
+
+xOkBtn = xDialog.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
+
+self.xUITest.executeCommand(".uno:Undo")
+
+self.ui_test.execute_dialog_through_command(".uno:DefineName")
+xDialog = self.xUITest.getTopFocusWindow()
+namesList = xDialog.getChild('names')
+self.assertEqual(2, len(namesList.getChildren()))
+self.assertEqual(get_state_as_dict(namesList.getChild('0'))["Text"], 
text1)
+self.assertEqual(get_state_as_dict(namesList.getChild('1'))["Text"], 
text2)
+
+xCancelBtn = xDialog.getChild("cancel")
+xCancelBtn.executeAction("CLICK", tuple())
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4

[Libreoffice-commits] core.git: sc/qa

2020-03-16 Thread Xisco Fauli (via logerrit)

 sc/qa/unit/data/xlsx/tdf129985.xlsx   |binary
 sc/qa/unit/subsequent_export-test.cxx |   15 +++
 2 files changed, 15 insertions(+)

New commits:
commit 2f7f34bf9fb744a2615426e4414dff3ca6fbe6e4
Author: Xisco Fauli 
AuthorDate: Mon Mar 16 16:40:06 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Mar 16 18:14:18 2020 +0100

tdf#129985: Add unittest

Change-Id: I9a8b923da6ca20fef9a61b9e478267d8c91ace58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90573
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sc/qa/unit/data/xlsx/tdf129985.xlsx 
b/sc/qa/unit/data/xlsx/tdf129985.xlsx
new file mode 100644
index ..0877ca9b8976
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf129985.xlsx differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 5dad9a32ad66..5a1bba02b5f1 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -194,6 +194,7 @@ public:
 void testPreserveTextWhitespaceXLSX();
 void testPreserveTextWhitespace2XLSX();
 void testTextDirectionXLSX();
+void testTdf129985();
 
 void testRefStringXLSX();
 void testRefStringConfigXLSX();
@@ -327,6 +328,7 @@ public:
 CPPUNIT_TEST(testMoveCellAnchoredShapesODS);
 CPPUNIT_TEST(testMatrixMultiplicationXLSX);
 CPPUNIT_TEST(testTextDirectionXLSX);
+CPPUNIT_TEST(testTdf129985);
 
 CPPUNIT_TEST(testRefStringXLSX);
 CPPUNIT_TEST(testRefStringConfigXLSX);
@@ -4002,6 +4004,19 @@ void ScExportTest::testTextDirectionXLSX()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testTdf129985()
+{
+ScDocShellRef xDocSh = loadDoc("tdf129985.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+
+xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory, 
"xl/styles.xml", FORMAT_XLSX);
+CPPUNIT_ASSERT(pDoc);
+
+assertXPath(pDoc, "/x:styleSheet/x:numFmts/x:numFmt[2]", "formatCode", 
"m/d/");
+
+xDocSh->DoClose();
+}
+
 void ScExportTest::testTdf88657ODS()
 {
 ScDocShellRef xDocSh = loadDoc("tdf88657.", FORMAT_ODS);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 131378] New: software is not working

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131378

Bug ID: 131378
   Summary: software is not working
   Product: Document Liberation Project
   Version: unspecified
  Hardware: PowerPC
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: libabw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yrridmi1...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 131239] Remove More Fields sub menu and move its content to the parent form/dialog main menu

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131239

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #3 from Heiko Tietze  ---
WFM reason in c2. Plus, we should avoid to change the menu structure with no
good reason.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 131239] Remove More Fields sub menu and move its content to the parent form/dialog main menu

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131239

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #3 from Heiko Tietze  ---
WFM reason in c2. Plus, we should avoid to change the menu structure with no
good reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2020-03-16 Thread mert (via logerrit)

 loleaflet/src/layer/tile/TileLayer.js |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit c34ca443b2037b4cf200a17013481c1cc75090a4
Author: mert 
AuthorDate: Mon Mar 16 12:34:00 2020 +0300
Commit: Andras Timar 
CommitDate: Mon Mar 16 18:09:20 2020 +0100

mobile: fix hyperlink popup does not disappear.

popups dont disapper on impress also other types of documents
when tapping on graphics

Change-Id: I3b6c64f3347e6ea6aa52c9568bec3233b748d932
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90555
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index d302dccc4..4937e7c31 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -919,6 +919,9 @@ L.TileLayer = L.GridLayer.extend({
},
 
_onGraphicSelectionMsg: function (textMsg) {
+   if (this._map.hyperlinkPopup !== null) {
+   this._closeURLPopUp();
+   }
if (textMsg.match('EMPTY')) {
this._resetSelectionRanges();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
Bug 85811 depends on bug 131239, which changed state.

Bug 131239 Summary: Remove More Fields sub menu and move its content to the 
parent form/dialog main menu
https://bugs.documentfoundation.org/show_bug.cgi?id=131239

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131233] improve UX around info message "Missing hyphenation info - please install the hyphenation package for locale "de".

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131233

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||ilmari.lauhakangas@libreoff
   ||ice.org,
   ||olivier.hallot@libreoffice.
   ||org
   Keywords|needsUXEval |difficultyMedium, easyHack,
   ||skillCpp, topicUI
  Component|Linguistic  |Documentation

--- Comment #6 from Heiko Tietze  ---
So let's add a button to the infobar, which links to the right help page. The
button is pretty easy to implement, just look at how WhatsNew [1] and
on/offline help links [2] are implemented.
But we need a help page first. Olivier/Ilmari, anything that exists? 

[1]
https://opengrok.libreoffice.org/xref/core/sfx2/source/view/viewfrm.cxx?r=9ad252b2#1276
[2]
https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/tipofthedaydlg.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 131233] improve UX around info message "Missing hyphenation info - please install the hyphenation package for locale "de".

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131233

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||ilmari.lauhakangas@libreoff
   ||ice.org,
   ||olivier.hallot@libreoffice.
   ||org
   Keywords|needsUXEval |difficultyMedium, easyHack,
   ||skillCpp, topicUI
  Component|Linguistic  |Documentation

--- Comment #6 from Heiko Tietze  ---
So let's add a button to the infobar, which links to the right help page. The
button is pretty easy to implement, just look at how WhatsNew [1] and
on/offline help links [2] are implemented.
But we need a help page first. Olivier/Ilmari, anything that exists? 

[1]
https://opengrok.libreoffice.org/xref/core/sfx2/source/view/viewfrm.cxx?r=9ad252b2#1276
[2]
https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/tipofthedaydlg.cxx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: writerfilter/source

2020-03-16 Thread Miklos Vajna (via logerrit)

 writerfilter/source/dmapper/DomainMapper.cxx |   43 +--
 writerfilter/source/dmapper/NumberingManager.cxx |   21 +--
 writerfilter/source/ooxml/model.xml  |   10 -
 writerfilter/source/rtftok/rtfdispatchflag.cxx   |   23 
 writerfilter/source/rtftok/rtfdispatchvalue.cxx  |   11 +++--
 5 files changed, 88 insertions(+), 20 deletions(-)

New commits:
commit 496197fe4dff2cd94ceeb42fc04d0263ac8d8971
Author: Miklos Vajna 
AuthorDate: Mon Mar 16 17:25:31 2020 +0100
Commit: Miklos Vajna 
CommitDate: Mon Mar 16 18:07:54 2020 +0100

DOCX import: tokenize 

Which means CT_NumFmt has to be a property resource, not a single value,
and also ST_NumberFormat needs to recognize "custom" as a valid value.

Adapt the RTF tokenizer to emit the new token format.

This is needed (but not enough) to support markup like this:



Change-Id: I767e4b92fc41f9425f446d6eaad1d875e2233964
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90578
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index cd21f22d6acd..d84c94b2fbfe 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1179,6 +1179,37 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 m_pImpl->startOrEndPermissionRange(nIntValue);
 break;
 }
+case NS_ooxml::LN_CT_NumFmt_val:
+{
+try
+{
+uno::Reference xFtnEdnSettings;
+if (m_pImpl->IsInFootnoteProperties())
+{
+uno::Reference 
xFootnotesSupplier(
+m_pImpl->GetTextDocument(), uno::UNO_QUERY);
+if (xFootnotesSupplier.is())
+xFtnEdnSettings = 
xFootnotesSupplier->getFootnoteSettings();
+}
+else
+{
+uno::Reference xEndnotesSupplier(
+m_pImpl->GetTextDocument(), uno::UNO_QUERY);
+if (xEndnotesSupplier.is())
+xFtnEdnSettings = 
xEndnotesSupplier->getEndnoteSettings();
+}
+if (xFtnEdnSettings.is())
+{
+sal_Int16 nNumType = 
ConversionHelper::ConvertNumberingType(nIntValue);
+
xFtnEdnSettings->setPropertyValue(getPropertyName(PROP_NUMBERING_TYPE),
+  uno::makeAny(nNumType));
+}
+}
+catch (const uno::Exception&)
+{
+}
+}
+break;
 default:
 SAL_WARN("writerfilter", "DomainMapper::lcl_attribute: unhandled 
token: " << nName);
 }
@@ -2279,10 +2310,18 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 //endnotes in word can be at section end or document end - writer supports 
only the latter
 // -> so this property can be ignored
 break;
-case NS_ooxml::LN_EG_FtnEdnNumProps_numStart:
-case NS_ooxml::LN_EG_FtnEdnNumProps_numRestart:
 case NS_ooxml::LN_CT_FtnProps_numFmt:
 case NS_ooxml::LN_CT_EdnProps_numFmt:
+{
+writerfilter::Reference::Pointer_t pProperties = 
rSprm.getProps();
+if (pProperties.get())
+{
+pProperties->resolve(*this);
+}
+}
+break;
+case NS_ooxml::LN_EG_FtnEdnNumProps_numStart:
+case NS_ooxml::LN_EG_FtnEdnNumProps_numRestart:
 {
 try
 {
diff --git a/writerfilter/source/dmapper/NumberingManager.cxx 
b/writerfilter/source/dmapper/NumberingManager.cxx
index 7084547c4d1a..9c337708d255 100644
--- a/writerfilter/source/dmapper/NumberingManager.cxx
+++ b/writerfilter/source/dmapper/NumberingManager.cxx
@@ -100,7 +100,7 @@ void ListLevel::SetValue( Id nId, sal_Int32 nValue )
 case NS_ooxml::LN_CT_Lvl_start:
 m_nIStartAt = nValue;
 break;
-case NS_ooxml::LN_CT_Lvl_numFmt:
+case NS_ooxml::LN_CT_NumFmt_val:
 m_nNFC = nValue;
 break;
 case NS_ooxml::LN_CT_Lvl_isLgl:
@@ -738,6 +738,8 @@ void ListsManager::lcl_attribute( Id nName, Value& rVal )
 break;
 case NS_ooxml::LN_CT_Lvl_start:
 case NS_ooxml::LN_CT_Lvl_numFmt:
+case NS_ooxml::LN_CT_NumFmt_format:
+case NS_ooxml::LN_CT_NumFmt_val:
 case NS_ooxml::LN_CT_Lvl_isLgl:
 case NS_ooxml::LN_CT_Lvl_legacy:
 if ( pCurrentLvl.get( ) )
@@ -960,18 +962,29 @@ void ListsManager::lcl_sprm( Sprm& rSprm )
 bIsStartVisited = true;
 break;
 case NS_ooxml::LN_CT_Lvl_numFmt:
-case NS_ooxml::LN_CT_Lvl_isLgl:
-case NS_ooxml::LN_CT_Lvl_legacy:
+{
+

[Libreoffice-bugs] [Bug 130783] Change .uno: command for Protect Cells in Writer from .uno:Protect to .uno:CellProtection

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130783

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Severity|normal  |enhancement
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||kain...@gmail.com,
   ||vmik...@collabora.com

--- Comment #3 from Heiko Tietze  ---
We discussed the topic in the design meeting and at the ESC:


 +  exists for Writer and Calc
 + due to the same names the command take the same icons, which is the issue
here
 + request is to rename one of the two UNO commands

 + good to keep the old name working, in-doc macros and extensions can refer to
the old name (Miklos/ESC)

So yes to a new command but keep the current. Miklos/Maxim, could you please
add a code pointer?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130783] Change .uno: command for Protect Cells in Writer from .uno:Protect to .uno:CellProtection

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130783

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Severity|normal  |enhancement
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||kain...@gmail.com,
   ||vmik...@collabora.com

--- Comment #3 from Heiko Tietze  ---
We discussed the topic in the design meeting and at the ESC:


 +  exists for Writer and Calc
 + due to the same names the command take the same icons, which is the issue
here
 + request is to rename one of the two UNO commands

 + good to keep the old name working, in-doc macros and extensions can refer to
the old name (Miklos/ESC)

So yes to a new command but keep the current. Miklos/Maxim, could you please
add a code pointer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 34355] Option to show track changes in margin is missing

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34355

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

--- Comment #137 from Heiko Tietze  ---
This honey pot for spammers need a solution, not least to get rid of the spam.

Luckily it's more or less implemented, though as experimental feature. Check
Tools > Options > Advanced > Experimental to get the changes in the sidebar.
This list needs some refinement to become an equivalent to the inline tracking
(that you would switch off). In particular the actual change needs to be shown.
But I would go a step further and make the type of information variable, eg.
per dropdown menu as we have for toolbars. There are different use cases to
solve with this sidebar and some may need the change, other the author.

We could, of course, introduce a completely different solution with TC in the
document margin. But I wouldn't do so as it weakens our main interaction
element, the sidebar. And it is a lot additional effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 34355] Option to show track changes in margin is missing

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34355

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |

--- Comment #137 from Heiko Tietze  ---
This honey pot for spammers need a solution, not least to get rid of the spam.

Luckily it's more or less implemented, though as experimental feature. Check
Tools > Options > Advanced > Experimental to get the changes in the sidebar.
This list needs some refinement to become an equivalent to the inline tracking
(that you would switch off). In particular the actual change needs to be shown.
But I would go a step further and make the type of information variable, eg.
per dropdown menu as we have for toolbars. There are different use cases to
solve with this sidebar and some may need the change, other the author.

We could, of course, introduce a completely different solution with TC in the
document margin. But I wouldn't do so as it weakens our main interaction
element, the sidebar. And it is a lot additional effort.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102835] Feature request: Endnote by chapter near end of document.

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102835

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #9 from Heiko Tietze  ---
The request makes sense and could be implemented without too many changes to
the UI if footnotes/endnotes become part of the ToC > Type list. When the user
inserts the first endnote we could place the ToC for endnotes on-the-fly at the
end of the document, and make it related to the whole document. The user should
be able to edit this ToC and move it somewhere else, like at the end of the
chapter, and define the scope for just this chapter.

Alternatively, we could have two different endnote commands, one for the whole
document at the end (as today), the other for the chapter; maybe that's the
better approach as ToC have much more options that wouldn't be needed.

I wonder how the roundtrip with other office suites work. If that's not
possible the request is unfortunately a WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102835] Feature request: Endnote by chapter near end of document.

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102835

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #9 from Heiko Tietze  ---
The request makes sense and could be implemented without too many changes to
the UI if footnotes/endnotes become part of the ToC > Type list. When the user
inserts the first endnote we could place the ToC for endnotes on-the-fly at the
end of the document, and make it related to the whole document. The user should
be able to edit this ToC and move it somewhere else, like at the end of the
chapter, and define the scope for just this chapter.

Alternatively, we could have two different endnote commands, one for the whole
document at the end (as today), the other for the chapter; maybe that's the
better approach as ToC have much more options that wouldn't be needed.

I wonder how the roundtrip with other office suites work. If that's not
possible the request is unfortunately a WONTFIX.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84837

cosmo789  changed:

   What|Removed |Added

URL||https://vegus666.com/vegus1
   ||68/register.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131377] Not Sorting Dates Correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131377

--- Comment #2 from c319ch...@aol.com ---
Created attachment 158724
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158724=edit
Sample .csv file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source vcl/win

2020-03-16 Thread Samuel Mehrbrodt (via logerrit)

 vcl/source/app/svapp.cxx |   11 ++-
 vcl/win/app/salinfo.cxx  |   10 +-
 2 files changed, 19 insertions(+), 2 deletions(-)

New commits:
commit 3741d70743c297029f54b20b0ca711f40cff7097
Author: Samuel Mehrbrodt 
AuthorDate: Thu Mar 12 14:12:59 2020 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Mon Mar 16 16:55:01 2020 +0100

Some more checks for correct screen size

Change-Id: Id5a811e4227052fd9117ab2b099de31e8e3b90c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90413
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 1f422e33617a..301b934b4ab9 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1245,7 +1245,16 @@ unsigned int Application::GetDisplayExternalScreen()
 tools::Rectangle Application::GetScreenPosSizePixel( unsigned int nScreen )
 {
 SalSystem* pSys = ImplGetSalSystem();
-return pSys ? pSys->GetDisplayScreenPosSizePixel( nScreen ) : 
tools::Rectangle();
+if (!pSys)
+{
+SAL_WARN("vcl", "Requesting screen size/pos for screen #" << nScreen 
<< " failed");
+assert(false);
+return tools::Rectangle();
+}
+tools::Rectangle aRect = pSys->GetDisplayScreenPosSizePixel(nScreen);
+if (aRect.getHeight() == 0)
+SAL_WARN("vcl", "Requesting screen size/pos for screen #" << nScreen 
<< " returned 0 height.");
+return aRect;
 }
 
 namespace {
diff --git a/vcl/win/app/salinfo.cxx b/vcl/win/app/salinfo.cxx
index ccb6d3806f95..a19ca597f9c5 100644
--- a/vcl/win/app/salinfo.cxx
+++ b/vcl/win/app/salinfo.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 #include 
@@ -155,7 +156,14 @@ unsigned int WinSalSystem::GetDisplayBuiltInScreen()
 tools::Rectangle WinSalSystem::GetDisplayScreenPosSizePixel( unsigned int 
nScreen )
 {
 initMonitors();
-return (nScreen < m_aMonitors.size()) ? m_aMonitors[nScreen].m_aArea : 
tools::Rectangle();
+if (nScreen >= m_aMonitors.size())
+{
+SAL_WARN("vcl", "Requested screen size/pos for screen #"
+<< nScreen << ", but only " << m_aMonitors.size() 
<< " screens found.");
+assert(false);
+return tools::Rectangle();
+}
+return m_aMonitors[nScreen].m_aArea;
 }
 
 int WinSalSystem::ShowNativeMessageBox(const OUString& rTitle, const OUString& 
rMessage)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124424] EMF+ Gradients are not displayed correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124424

--- Comment #34 from Commit Notification 
 ---
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e11796866f94d2f51023e6bc2b23a39af10a7d96

tdf#124424 EMF+ Extend test options of SvgLinearGradientPrimitive2D

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source emfio/qa

2020-03-16 Thread Bartosz Kosiorek (via logerrit)

 drawinglayer/source/tools/primitive2dxmldump.cxx |   24 ++-
 emfio/qa/cppunit/emf/EmfImportTest.cxx   |9 
 2 files changed, 32 insertions(+), 1 deletion(-)

New commits:
commit e11796866f94d2f51023e6bc2b23a39af10a7d96
Author: Bartosz Kosiorek 
AuthorDate: Sun Mar 15 23:23:49 2020 +0100
Commit: Bartosz Kosiorek 
CommitDate: Mon Mar 16 16:52:24 2020 +0100

tdf#124424 EMF+ Extend test options of SvgLinearGradientPrimitive2D

The extended options were used in LinearGradient tests

Change-Id: I44336edda2d82f936b6e931668bdac46ee7899e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90541
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/primitive2dxmldump.cxx 
b/drawinglayer/source/tools/primitive2dxmldump.cxx
index e4fadac945a3..7d706849c63c 100644
--- a/drawinglayer/source/tools/primitive2dxmldump.cxx
+++ b/drawinglayer/source/tools/primitive2dxmldump.cxx
@@ -14,6 +14,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 #include 
@@ -138,7 +139,7 @@ xmlDocPtr Primitive2dXmlDump::dumpAndParse(
 std::unique_ptr pBuffer(new sal_uInt8[nSize + 1]);
 pStream->ReadBytes(pBuffer.get(), nSize);
 pBuffer[nSize] = 0;
-
+SAL_INFO("drawinglayer", "Parsed XML: " << pBuffer.get());
 xmlDocPtr pDoc = xmlParseDoc(reinterpret_cast(pBuffer.get()));
 
 return pDoc;
@@ -252,6 +253,7 @@ void Primitive2dXmlDump::decomposeAndWrite(
 double fRotate, fShearX;
 
if(rTextSimplePortionPrimitive2D.getTextTransform().decompose(aScale, 
aTranslate, fRotate, fShearX))
 {
+rWriter.attribute("width", aScale.getX());
 rWriter.attribute("height", aScale.getY());
 }
 rWriter.attribute("x", aTranslate.getX());
@@ -314,10 +316,30 @@ void Primitive2dXmlDump::decomposeAndWrite(
 {
 const SvgLinearGradientPrimitive2D& 
rSvgLinearGradientPrimitive2D = dynamic_cast(*pBasePrimitive);
 rWriter.startElement("svglineargradient");
+basegfx::B2DPoint aStartAttribute = 
rSvgLinearGradientPrimitive2D.getStart();
 basegfx::B2DPoint aEndAttribute = 
rSvgLinearGradientPrimitive2D.getEnd();
 
+rWriter.attribute("startx", aStartAttribute.getX());
+rWriter.attribute("starty", aStartAttribute.getY());
 rWriter.attribute("endx", aEndAttribute.getX());
 rWriter.attribute("endy", aEndAttribute.getY());
+//rWriter.attribute("spreadmethod", 
(int)rSvgLinearGradientPrimitive2D.getSpreadMethod());
+rWriter.attributeDouble("opacity", 
rSvgLinearGradientPrimitive2D.getGradientEntries().front().getOpacity());
+
+rWriter.startElement("transform");
+basegfx::B2DHomMatrix const & rMatrix = 
rSvgLinearGradientPrimitive2D.getGradientTransform();
+rWriter.attributeDouble("xy11", rMatrix.get(0,0));
+rWriter.attributeDouble("xy12", rMatrix.get(0,1));
+rWriter.attributeDouble("xy13", rMatrix.get(0,2));
+rWriter.attributeDouble("xy21", rMatrix.get(1,0));
+rWriter.attributeDouble("xy22", rMatrix.get(1,1));
+rWriter.attributeDouble("xy23", rMatrix.get(1,2));
+rWriter.attributeDouble("xy31", rMatrix.get(2,0));
+rWriter.attributeDouble("xy32", rMatrix.get(2,1));
+rWriter.attributeDouble("xy33", rMatrix.get(2,2));
+rWriter.endElement();
+
+writePolyPolygon(rWriter, 
rSvgLinearGradientPrimitive2D.getPolyPolygon());
 
 rWriter.endElement();
 }
diff --git a/emfio/qa/cppunit/emf/EmfImportTest.cxx 
b/emfio/qa/cppunit/emf/EmfImportTest.cxx
index 9ce4e15f4965..636216a79fc2 100644
--- a/emfio/qa/cppunit/emf/EmfImportTest.cxx
+++ b/emfio/qa/cppunit/emf/EmfImportTest.cxx
@@ -175,10 +175,19 @@ void Test::TestLinearGradient()
 assertXPath(pDocument, "/primitive2D/metafile/transform/mask/polypolygon", 
"height", "7610");
 assertXPath(pDocument, "/primitive2D/metafile/transform/mask/polypolygon", 
"width", "15232");
 assertXPath(pDocument, "/primitive2D/metafile/transform/mask/polypolygon", 
"path", "m0 0h15232v7610h-15232z");
+
+assertXPath(pDocument, 
"/primitive2D/metafile/transform/mask/svglineargradient[1]", "startx", "0");
+assertXPath(pDocument, 
"/primitive2D/metafile/transform/mask/svglineargradient[1]", "starty", "-1");
 assertXPath(pDocument, 
"/primitive2D/metafile/transform/mask/svglineargradient[1]", "endx", "0");
 assertXPath(pDocument, 
"/primitive2D/metafile/transform/mask/svglineargradient[1]", "endy", "-1");
+assertXPath(pDocument, 
"/primitive2D/metafile/transform/mask/svglineargradient[1]", "opacity", 
"0.392156862745098");
+assertXPath(pDocument,

[Libreoffice-bugs] [Bug 131366] Crash when I type the letter "i" after the letter "f" in a paragraph with style "emphasis" and font "Linux Biolinum G"

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131366

Miklos Vajna  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #5 from Miklos Vajna  ---
Sounds like a crash in graphite itself, should this be forwarded to
, to their issue tracker?

CC Justin who may know what is the preferred way of handling such "graphite in
LO" problems, I don't.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/source

2020-03-16 Thread Eike Rathke (via logerrit)

 sc/source/filter/oox/numberformatsbuffer.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 95d35dd3109263a1708fab143accc0f45a05758d
Author: Eike Rathke 
AuthorDate: Sun Mar 15 18:22:05 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Mar 16 16:47:18 2020 +0100

Resolves: tdf#129985 OOXML import: do not force a fixed-locale number format

... instead of system locale.

Change-Id: Ie7b4c6a560468f142df6916f50bfda9daaf7c379
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90538
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 5b88a664b1ad2b5761a4672678845cc77be6cd4d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90399
Reviewed-by: Xisco Faulí 

diff --git a/sc/source/filter/oox/numberformatsbuffer.cxx 
b/sc/source/filter/oox/numberformatsbuffer.cxx
index 2ca5a3dc88f2..2787dacd3aa0 100644
--- a/sc/source/filter/oox/numberformatsbuffer.cxx
+++ b/sc/source/filter/oox/numberformatsbuffer.cxx
@@ -2054,7 +2054,7 @@ void NumberFormatsBuffer::insertBuiltinFormats()
 {
 // do not put the current system locale for default table
 Locale aLocale;
-if( (*aVIt)->mpcParent[ 0 ] != '\0' )
+if( (*aVIt)->mpcParent[ 0 ] != '\0' && 
OUString::createFromAscii((*aVIt)->mpcLocale) != maLocaleStr )
 aLocale = aSysLocale;
 for( const BuiltinFormat* pBuiltin = (*aVIt)->mpFormats; pBuiltin && 
(pBuiltin->mnNumFmtId >= 0); ++pBuiltin )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 131366] Crash when I type the letter "i" after the letter "f" in a paragraph with style "emphasis" and font "Linux Biolinum G"

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131366

Timur  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131366] Crash when I type the letter "i" after the letter "f" in a paragraph with style "emphasis" and font "Linux Biolinum G"

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131366

Timur  changed:

   What|Removed |Added

 CC||vmik...@collabora.com
   Hardware|x86-64 (AMD64)  |All
   Keywords||bibisected, bisected,
   ||regression

--- Comment #4 from Timur  ---
Repro master 7.0+ both Win and Lin.
Np repro 6.2. Regression in 6.3.

41c8baa8134040fb2bcdf859113cc7d52c53e8c3 is the first bad commit
commit 41c8baa8134040fb2bcdf859113cc7d52c53e8c3
Author: Jenkins Build User 
Date:   Fri Dec 14 09:47:38 2018 +0100

source sha:6b84708914f9c026776b28a300ac6d278272881f

Previous commit 5d196bab4f73206315b9fff03fa8e126b658e2f3 (HEAD,
refs/bisect/good-5d196bab4f73206315b9fff03fa8e126b658e2f3)
Author: Jenkins Build User 
Date:   Fri Dec 14 08:14:37 2018 +0100

source sha:744c82af55d0ef1bfae61d13e5cf32fbd83c8b6b

Single source:
https://gerrit.libreoffice.org/plugins/gitiles/core/+/6b84708914f9c026776b28a300ac6d278272881f%5E!/

commit  6b84708914f9c026776b28a300ac6d278272881f[log]
author  Miklos Vajna Thu Dec 13 09:13:39 2018 +0100
committer   Miklos Vajna Fri Dec 14 09:08:04
2018 +0100
treef44f856fa3b8d105c951b250860a108c413b72e5
parent  744c82af55d0ef1bfae61d13e5cf32fbd83c8b6b [diff]

graphite: update to 1.3.12

Martin Hosken thinks all patches are redundant now, so drop them.

Change-Id: I062168416a1289b7f4dd42d8ae58b7df56a37712
Reviewed-on: https://gerrit.libreoffice.org/65074
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

CC: Miklos. Please take a look (to fix or to mark EasyHack).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 131377] Not Sorting Dates Correctly

2020-03-16 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131377

--- Comment #1 from elmau  ---
Please, attach file CSV for test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 >

1 - 100 of 261 matches

Mail list logo