[Libreoffice-commits] core.git: sw/uiconfig

[Seth Chaiklin (via logerrit)]

 sw/uiconfig/swriter/ui/templatedialog16.ui |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

New commits:
commit 1665d9b85282eda60d3cc09c0f74c83ad156d6e5
Author: Seth Chaiklin 
AuthorDate: Tue Jan 26 13:07:25 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Tue Feb 2 10:13:54 2021 +0100

tdf#139667 updating of "Numbering Style" dialog to "List Style"

   * change name of "Bullets" tab to "Unordered"
   * change name of "Numbering Style" tab to "Ordered"
   + add tooltips for "Ordered", "Outline" "Image", "Position"
 and "Customize" tabs

Change-Id: Ie960b28847092d6e5ad22b1e0abe41184309586b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109890
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sw/uiconfig/swriter/ui/templatedialog16.ui 
b/sw/uiconfig/swriter/ui/templatedialog16.ui
index af9fc59b834b..17dba0f466c1 100644
--- a/sw/uiconfig/swriter/ui/templatedialog16.ui
+++ b/sw/uiconfig/swriter/ui/templatedialog16.ui
@@ -5,7 +5,7 @@
   
 False
 6
-Numbering Style
+List Style
 True
 0
 0
@@ -211,7 +211,7 @@
   
 True
 False
-Bullets
+Unordered
   
   
 1
@@ -259,7 +259,8 @@
   
 True
 False
-Numbering Style
+Ordered
+Numbering schemes for ordered 
lists
   
   
 2
@@ -308,6 +309,7 @@
 True
 False
 Outline
+ Numbering schemes for 
hierarchical lists
   
   
 3
@@ -356,6 +358,7 @@
 True
 False
 Image
+Graphic bullet 
symbols
   
   
 4
@@ -404,6 +407,7 @@
 True
 False
 Position
+Indent, spacing, and alignment 
options for ordered and unordered lists
   
   
 5
@@ -452,6 +456,7 @@
 True
 False
 Customize
+Design your own bullet or 
numbering scheme
   
   
 6
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/uiconfig

[Seth Chaiklin (via logerrit)]

 sw/uiconfig/swriter/ui/numparapage.ui |   15 +--
 sw/uiconfig/swriter/ui/templatedialog2.ui |2 +-
 2 files changed, 10 insertions(+), 7 deletions(-)

New commits:
commit 77d96238449c117037a13f8b76d560ad060568ec
Author: Seth Chaiklin 
AuthorDate: Tue Jan 26 12:15:01 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Tue Feb 2 10:13:15 2021 +0100

tdf#139667 change "Numbering" labels to "List" in Paragraph dialogs

 * This patch modifies the dialog box for Paragraph and Paragraph Style
   to use "List Style" instead of Numbering Style.
 * It also updates and adds some tooltips to this dialog box.
 * The "Outline & Numbering" tab is changed to "Outline & List"

Change-Id: I2770a279b92f4c86b12373216301c6ebe0f2baf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109886
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sw/uiconfig/swriter/ui/numparapage.ui 
b/sw/uiconfig/swriter/ui/numparapage.ui
index 981cbe1fac73..485ba7330fce 100644
--- a/sw/uiconfig/swriter/ui/numparapage.ui
+++ b/sw/uiconfig/swriter/ui/numparapage.ui
@@ -41,6 +41,7 @@
 True
 comboLB_OUTLINE_LEVEL
 0
+Select or change the 
Outline Level applied to the selected paragraphs or Paragraph Style.
   
   
 False
@@ -119,7 +120,8 @@
   
 True
 False
-_Numbering style:
+_List style:
+Select the List Style 
to apply to the paragraph.
 True
 comboLB_NUMBER_STYLE
 0
@@ -144,7 +146,7 @@
 
 
   
-Select the Numbering 
Style that you want to apply to the paragraph.
+Select the List Style 
that you want to apply to the paragraph.
   
 
   
@@ -162,7 +164,7 @@
 False
 
   
-Edit the 
properties of the selected numbering style.
+Edit the 
properties of the selected List Style.
   
 
   
@@ -188,9 +190,10 @@
 
 
   
-R_estart at this paragraph
+R_estart numbering at this 
paragraph
 True
 False
+For Numbered Lists and 
List Styles with numbering
 True
 True
 none
@@ -282,7 +285,7 @@
   
 True
 False
-Numbering
+List
 
   
 
@@ -435,7 +438,7 @@
 
 
   
-Adds or removes outline level, 
numbering, or bullets from the paragraph. You can also select the style of 
numbering to use, and reset the numbering in a numbered list.
+Adds or removes Outline Level, 
List Style, and line numbering from the paragraph. You can also reset the 
numbering in a numbered list.
   
 
   
diff --git a/sw/uiconfig/swriter/ui/templatedialog2.ui 
b/sw/uiconfig/swriter/ui/templatedialog2.ui
index 74cfa9867d82..1c0f9099f0ae 100644
--- a/sw/uiconfig/swriter/ui/templatedialog2.ui
+++ b/sw/uiconfig/swriter/ui/templatedialog2.ui
@@ -931,7 +931,7 @@
   
 True
 False
-Outline  Numbering
+Outline  List
   
   
 9
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basegfx/CppunitTest_basegfx.mk basegfx/test

[Deb Barkley-Yeung (via logerrit)]

 basegfx/CppunitTest_basegfx.mk  |1 
 basegfx/test/BColorModifierTest.cxx |  188 
 2 files changed, 189 insertions(+)

New commits:
commit df5b9500c079ec1d3fd9485dbf55aeea338ae2fd
Author: Deb Barkley-Yeung 
AuthorDate: Sat Jan 23 22:59:38 2021 -0800
Commit: Michael Stahl 
CommitDate: Tue Feb 2 12:01:13 2021 +0100

Added Unit test to BColorModifier

Change-Id: I19aee93f68e5e01ef99f8447db4ffb1f68acaaa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109853
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/basegfx/CppunitTest_basegfx.mk b/basegfx/CppunitTest_basegfx.mk
index 231854cdf057..a0379e76612a 100644
--- a/basegfx/CppunitTest_basegfx.mk
+++ b/basegfx/CppunitTest_basegfx.mk
@@ -34,6 +34,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,basegfx,\
 basegfx/test/B2XRangeTest \
 basegfx/test/B2IBoxTest \
 basegfx/test/B2DTupleTest \
+basegfx/test/BColorModifierTest \
 basegfx/test/BColorTest \
 basegfx/test/SvgPathImportExport \
 basegfx/test/basegfx3d \
diff --git a/basegfx/test/BColorModifierTest.cxx 
b/basegfx/test/BColorModifierTest.cxx
new file mode 100755
index ..2371542663dc
--- /dev/null
+++ b/basegfx/test/BColorModifierTest.cxx
@@ -0,0 +1,188 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+namespace basegfx
+{
+class bcolormodifier : public CppUnit::TestFixture
+{
+BColor maWhite;
+BColor maBlack;
+BColor maRed;
+BColor maGreen;
+BColor maBlue;
+BColor maYellow;
+BColor maMagenta;
+BColor maCyan;
+BColor maGray;
+
+public:
+bcolormodifier()
+: maWhite(1, 1, 1)
+, maBlack(0, 0, 0)
+, maRed(1, 0, 0)
+, maGreen(0, 1, 0)
+, maBlue(0, 0, 1)
+, maYellow(1, 1, 0)
+, maMagenta(1, 0, 1)
+, maCyan(0, 1, 1)
+, maGray(.5, .5, .5)
+{
+}
+
+void testGray()
+{
+const basegfx::BColorModifierSharedPtr aBColorModifier
+= std::make_shared();
+
+CPPUNIT_ASSERT_EQUAL(maWhite, 
aBColorModifier->getModifiedColor(maWhite));
+CPPUNIT_ASSERT_EQUAL(maGray, 
aBColorModifier->getModifiedColor(maGray));
+CPPUNIT_ASSERT_EQUAL(maBlack, 
aBColorModifier->getModifiedColor(maBlack));
+
+BColor aGrayedRed(77.0 / 256.0, 77.0 / 256.0, 77.0 / 256.0);
+CPPUNIT_ASSERT_EQUAL(aGrayedRed, 
aBColorModifier->getModifiedColor(maRed));
+BColor aGrayedGreen(151.0 / 256.0, 151.0 / 256.0, 151.0 / 256.0);
+CPPUNIT_ASSERT_EQUAL(aGrayedGreen, 
aBColorModifier->getModifiedColor(maGreen));
+BColor aGrayedBlue(28.0 / 256.0, 28.0 / 256.0, 28.0 / 256.0);
+CPPUNIT_ASSERT_EQUAL(aGrayedBlue, 
aBColorModifier->getModifiedColor(maBlue));
+// 77 + 151 = 228
+BColor aGrayedYellow(228.0 / 256.0, 228.0 / 256.0, 228.0 / 256.0);
+CPPUNIT_ASSERT_EQUAL(aGrayedYellow, 
aBColorModifier->getModifiedColor(maYellow));
+// 77 + 28 = 105
+BColor aGrayedMagenta(105.0 / 256.0, 105.0 / 256.0, 105.0 / 256.0);
+CPPUNIT_ASSERT_EQUAL(aGrayedMagenta, 
aBColorModifier->getModifiedColor(maMagenta));
+// 151 + 28 = 179
+BColor aGrayedCyan(179.0 / 256.0, 179.0 / 256.0, 179.0 / 256.0);
+CPPUNIT_ASSERT_EQUAL(aGrayedCyan, 
aBColorModifier->getModifiedColor(maCyan));
+
+CPPUNIT_ASSERT(aBColorModifier->operator==(*aBColorModifier));
+const basegfx::BColorModifierSharedPtr aBColorModifierInvert
+= std::make_shared();
+CPPUNIT_ASSERT(*aBColorModifier != *aBColorModifierInvert);
+
+const basegfx::BColorModifierSharedPtr aBColorModifier2
+= std::make_shared();
+CPPUNIT_ASSERT(aBColorModifier->operator==(*aBColorModifier2));
+}
+
+void testInvert()
+{
+const basegfx::BColorModifierSharedPtr aBColorModifier
+= std::make_shared();
+
+CPPUNIT_ASSERT_EQUAL(maBlack, 
aBColorModifier->getModifiedColor(maWhite));
+CPPUNIT_ASSERT_EQUAL(maGray, 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/source

[Miklos Vajna (via logerrit)]

 sw/source/uibase/uno/unotxdoc.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit b982d0e6f94ca70765231ff4242c829f5bec5def
Author: Miklos Vajna 
AuthorDate: Mon Feb 1 17:44:39 2021 +0100
Commit: Miklos Vajna 
CommitDate: Tue Feb 2 09:50:14 2021 +0100

sw lok: disable field shadings

There are two problems with it:

First, the field shading is rendered behind bullet portions depending on
the cursor position (if the cursor is before the bullet, then we
render it; but not if the cursor is after the bullet), and tiled
rendering assumes that the render result is independent from the cursor
position.

Second, field shading is always painted directly (not going via
invalidation), so it's possible to end up with one tile showing field
shadings and another not, which is inconsistent. And even if it would be
there consistently, that would mean a lot of unnecessary invalidations.

The alternative would be to disable this from online.git's
loolconfig.xcu, but the item's path would end with something like
"ColorScheme['LibreOfficeDev']/WriterFieldShadings", which means it's
not easy to do this in a way that's independent from the product name.

(cherry picked from commit 876da94619d561e4b4c6c7d12a8d6726eb857df8)

Change-Id: I23c62acc3c15966cfba98fcee99cc96854ba4394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110283
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 42d872352e92..a3f165c1ff61 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -3479,6 +3479,10 @@ void SwXTextDocument::initializeForTiledRendering(const 
css::uno::SequenceGetViewOptions());
 aViewOption.SetHardBlank(false);
+
+// Disable field shadings: the result would depend on the cursor position.
+SwViewOption::SetAppearanceFlag(ViewOptFlags::FieldShadings, false);
+
 for (const beans::PropertyValue& rValue : rArguments)
 {
 if (rValue.Name == ".uno:HideWhitespace" && rValue.Value.has())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Tor Lillqvist (via logerrit)]

 sc/source/ui/docshell/docfunc.cxx |   29 +++--
 1 file changed, 15 insertions(+), 14 deletions(-)

New commits:
commit 2ee5769587024672bdc84d00c7cf8eb48ef8c620
Author: Tor Lillqvist 
AuthorDate: Mon Feb 1 13:18:23 2021 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Feb 2 10:18:16 2021 +0100

Probably this LOK invalidation should be done only if something changed

Change-Id: I0164ac8d74c08abce0a1d8c2e7a7dd9679da91fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110256
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110282
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index 98e07e22df5e..0c7b35ff000f 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -153,20 +153,6 @@ bool ScDocFunc::AdjustRowHeight( const ScRange& rRange, 
bool bPaint )
 SCROW nStartRow = rRange.aStart.Row();
 SCROW nEndRow   = rRange.aEnd.Row();
 
-if (comphelper::LibreOfficeKit::isActive())
-{
-SfxViewShell* pViewShell = SfxViewShell::GetFirst();
-while (pViewShell)
-{
-ScTabViewShell* pTabViewShell = 
dynamic_cast(pViewShell);
-if (pTabViewShell && pTabViewShell->GetDocId() == 
pSomeViewForThisDoc->GetDocId())
-{
-
pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)->invalidateByIndex(nStartRow);
-}
-pViewShell = SfxViewShell::GetNext(*pViewShell);
-}
-}
-
 ScSizeDeviceProvider aProv(  );
 Fraction aOne(1,1);
 
@@ -174,7 +160,22 @@ bool ScDocFunc::AdjustRowHeight( const ScRange& rRange, 
bool bPaint )
 bool bChanged = rDoc.SetOptimalHeight(aCxt, nStartRow, nEndRow, nTab);
 // tdf#76183: recalculate objects' positions
 if (bChanged)
+{
+if (comphelper::LibreOfficeKit::isActive())
+{
+SfxViewShell* pViewShell = SfxViewShell::GetFirst();
+while (pViewShell)
+{
+ScTabViewShell* pTabViewShell = 
dynamic_cast(pViewShell);
+if (pTabViewShell && pTabViewShell->GetDocId() == 
pSomeViewForThisDoc->GetDocId())
+{
+
pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)->invalidateByIndex(nStartRow);
+}
+pViewShell = SfxViewShell::GetNext(*pViewShell);
+}
+}
 rDoc.SetDrawPageSize(nTab);
+}
 
 if ( bPaint && bChanged )
 rDocShell.PostPaint(ScRange(0, nStartRow, nTab, rDoc.MaxCol(), 
rDoc.MaxRow(), nTab),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry

[Seth Chaiklin (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |   12 
+-
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu  |   12 
+-
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 5c7db49e2b492bed87ceeffd85545695cf90b3fd
Author: Seth Chaiklin 
AuthorDate: Fri Jan 29 12:59:04 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Tue Feb 2 10:16:14 2021 +0100

tdf#139667 change labels for Bullets icon and Numbering icon

  general aim to introduce consistency and clarity in labelling
  between menus, toolbar and appearance in Customize dialog.

  Label is shown in Customize dialog
  Context Label is shown in Menus
  Tooltip is shown in Toolbar

  GenericCommands.xcu has the .uno commands.
  WriterCommands.xcu has some .uno aliases that are used in
  the menubar and the context menus, but they use actual
  list styles. For now have marked their true labels, so that
  it is possible to see in UI whether one is working with DF
  or a List Style. Further development may be needed.

Change-Id: I2790a19d133d2c2a7bdf074eca398fda1e6f8e81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110137
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index c39a8e987762..624dbf9818c8 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -2617,13 +2617,13 @@ bit 3 (0x8): #define 
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
   
   
 
-  Bullets
+  Unordered Lists
 
 
-  ~Bulleted List
+  ~Unordered List
 
 
-  Toggle Bulleted List
+  Toggle Unordered List
 
 
   15
@@ -2631,13 +2631,13 @@ bit 3 (0x8): #define 
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
   
   
 
-  Numbering
+  Numbered Lists
 
 
-  ~Numbered List
+  ~Ordered List
 
 
-  Toggle Numbered List
+  Toggle Ordered List
 
 
   15
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 588d0fd16379..7450d72396d9 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -3533,15 +3533,15 @@
   
   
 
-  Bullet List
+  Bullet • List Style
 
   
   
 
-  Bullet List
+  Bullet • List Style
 
 
-  Bullet List Style
+  Bullet • List Style
 
 
   .uno:StyleApply?Style:string=List 
1FamilyName:string=NumberingStyles
@@ -3552,15 +3552,15 @@
   
   
 
-  Number List
+  Numbering 123 List Style
 
   
   
 
-  Number List
+  Numbering 123 List Style
 
 
-  Number List Style
+  Numbering 123 List Style
 
 
   .uno:StyleApply?Style:string=Numbering 
123FamilyName:string=NumberingStyles
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc

[Rizal Muttaqin (via logerrit)]

 sw/inc/strings.hrc |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9db40ef453eaa3e78ef852a35732e0d16e89b326
Author: Rizal Muttaqin 
AuthorDate: Tue Feb 2 13:48:11 2021 +0700
Commit: Rizal Muttaqin 
CommitDate: Tue Feb 2 10:40:13 2021 +0100

tdf#140078 change Text Frame string to Frame in Undo/Redo action label

Change-Id: Ic3e011fae80cc94cc5fb8e94abec18bc937dec5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110279
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index 56e7ab0473ba..3b5da067e5d6 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -475,8 +475,8 @@
 #define STR_TABLE_TBLCPYTBL NC_("STR_TABLE_TBLCPYTBL", 
"Copy table")
 #define STR_TABLE_CPYTBLNC_("STR_TABLE_CPYTBL", "Copy 
table")
 #define STR_INS_FROM_SHADOWCRSR NC_("STR_INS_FROM_SHADOWCRSR", 
"Set cursor")
-#define STR_UNDO_CHAIN  NC_("STR_UNDO_CHAIN", "Link 
text frames")
-#define STR_UNDO_UNCHAINNC_("STR_UNDO_UNCHAIN", 
"Unlink text frames")
+#define STR_UNDO_CHAIN  NC_("STR_UNDO_CHAIN", "Link 
frames")
+#define STR_UNDO_UNCHAINNC_("STR_UNDO_UNCHAIN", 
"Unlink frames")
 #define STR_UNDO_FTNINFONC_("STR_UNDO_FTNINFO", 
"Modify footnote options")
 #define STR_UNDO_COMPAREDOC NC_("STR_UNDO_COMPAREDOC", 
"Compare Document")
 #define STR_UNDO_SETFLYFRMFMT   NC_("STR_UNDO_SETFLYFRMFMT", 
"Apply frame style: $1")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/inc starmath/source

[dante (via logerrit)]

 starmath/inc/token.hxx|6 
 starmath/source/parse.cxx |  442 +++---
 2 files changed, 224 insertions(+), 224 deletions(-)

New commits:
commit 52dc0879e48afb2be1bebb567b34ad9d8fbd3314
Author: dante 
AuthorDate: Mon Feb 1 13:25:51 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Feb 2 11:30:47 2021 +0100

SmToken use u16string_view pIdent

The idea is to use 16 bits characters for node identities.
Avoids some intermediate createTextFromAscii
Will simplify the use of unicode 16 math identifiers

Change-Id: Ie084477f00219ba3bab0c4b53d3a4a5a310fa452
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110252
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/starmath/inc/token.hxx b/starmath/inc/token.hxx
index 374e23876a9f..c7d26e1efe0b 100644
--- a/starmath/inc/token.hxx
+++ b/starmath/inc/token.hxx
@@ -149,7 +149,7 @@ enum SmTokenType
 
 struct SmTokenTableEntry
 {
-const char* pIdent;
+const std::u16string_view pIdent;
 SmTokenType eType;
 sal_Unicode cMathChar;
 TG nGroup;
@@ -264,7 +264,7 @@ struct SmToken
 
 void operator=(const SmTokenTableEntry& aTokenTableEntry)
 {
-aText = OUString::createFromAscii(aTokenTableEntry.pIdent);
+aText = aTokenTableEntry.pIdent;
 eType = aTokenTableEntry.eType;
 cMathChar = aTokenTableEntry.cMathChar;
 nGroup = aTokenTableEntry.nGroup;
@@ -275,7 +275,7 @@ struct SmToken
 
 void operator=(const SmTokenTableEntry* aTokenTableEntry)
 {
-aText = OUString::createFromAscii(aTokenTableEntry->pIdent);
+aText = aTokenTableEntry->pIdent;
 eType = aTokenTableEntry->eType;
 cMathChar = aTokenTableEntry->cMathChar;
 nGroup = aTokenTableEntry->nGroup;
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 1e0846eb7667..0f3101450023 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -42,224 +42,224 @@ using namespace ::com::sun::star::i18n;
 //Definition of math keywords
 const SmTokenTableEntry aTokenTable[] =
 {
-{ "abs", TABS, '\0', TG::UnOper, 13 },
-{ "acute", TACUTE, MS_ACUTE, TG::Attribute, 5 },
-{ "aleph" , TALEPH, MS_ALEPH, TG::Standalone, 5 },
-{ "alignb", TALIGNC, '\0', TG::Align, 0},
-{ "alignc", TALIGNC, '\0', TG::Align, 0},
-{ "alignl", TALIGNL, '\0', TG::Align, 0},
-{ "alignm", TALIGNC, '\0', TG::Align, 0},
-{ "alignr", TALIGNR, '\0', TG::Align, 0},
-{ "alignt", TALIGNC, '\0', TG::Align, 0},
-{ "and", TAND, MS_AND, TG::Product, 0},
-{ "approx", TAPPROX, MS_APPROX, TG::Relation, 0},
-{ "arccos", TACOS, '\0', TG::Function, 5},
-{ "arccot", TACOT, '\0', TG::Function, 5},
-{ "arcosh", TACOSH, '\0', TG::Function, 5 },
-{ "arcoth", TACOTH, '\0', TG::Function, 5 },
-{ "arcsin", TASIN, '\0', TG::Function, 5},
-{ "arctan", TATAN, '\0', TG::Function, 5},
-{ "arsinh", TASINH, '\0', TG::Function, 5},
-{ "artanh", TATANH, '\0', TG::Function, 5},
-{ "backepsilon" , TBACKEPSILON, MS_BACKEPSILON, TG::Standalone, 5},
-{ "bar", TBAR, MS_BAR, TG::Attribute, 5},
-{ "binom", TBINOM, '\0', TG::NONE, 5 },
-{ "bold", TBOLD, '\0', TG::FontAttr, 5},
-{ "boper", TBOPER, '\0', TG::Product, 0},
-{ "breve", TBREVE, MS_BREVE, TG::Attribute, 5},
-{ "bslash", TBACKSLASH, MS_BACKSLASH, TG::Product, 0 },
-{ "cdot", TCDOT, MS_CDOT, TG::Product, 0},
-{ "check", TCHECK, MS_CHECK, TG::Attribute, 5},
-{ "circ" , TCIRC, MS_CIRC, TG::Standalone, 5},
-{ "circle", TCIRCLE, MS_CIRCLE, TG::Attribute, 5},
-{ "color", TCOLOR, '\0', TG::FontAttr, 5},
-{ "coprod", TCOPROD, MS_COPROD, TG::Oper, 5},
-{ "cos", TCOS, '\0', TG::Function, 5},
-{ "cosh", TCOSH, '\0', TG::Function, 5},
-{ "cot", TCOT, '\0', TG::Function, 5},
-{ "coth", TCOTH, '\0', TG::Function, 5},
-{ "csub", TCSUB, '\0', TG::Power, 0},
-{ "csup", TCSUP, '\0', TG::Power, 0},
-{ "dddot", TDDDOT, MS_DDDOT, TG::Attribute, 5},
-{ "ddot", TDDOT, MS_DDOT, TG::Attribute, 5},
-{ "def", TDEF, MS_DEF, TG::Relation, 0},
-{ "div", TDIV, MS_DIV, TG::Product, 0},
-{ "divides", TDIVIDES, MS_LINE, TG::Relation, 0},
-{ "dlarrow" , TDLARROW, MS_DLARROW, TG::Standalone, 5},
-{ "dlrarrow" , TDLRARROW, MS_DLRARROW, TG::Standalone, 5},
-{ "dot", TDOT, MS_DOT, TG::Attribute, 5},
-{ "dotsaxis", TDOTSAXIS, MS_DOTSAXIS, TG::Standalone, 5}, // 5 to continue 
expression
-{ "dotsdiag", TDOTSDIAG, MS_DOTSUP, TG::Standalone, 5},
-{ "dotsdown", TDOTSDOWN, MS_DOTSDOWN, TG::Standalone, 5},
-{ "dotslow", TDOTSLOW, MS_DOTSLOW, TG::Standalone, 5},
-{ "dotsup", TDOTSUP, MS_DOTSUP, TG::Standalone, 5},
-{ "dotsvert", TDOTSVERT, MS_DOTSVERT, TG::Standalone, 5},
-{ "downarrow" , TDOWNARROW, MS_DOWNARROW, TG::Standalone, 5},
-{ "drarrow" , TDRARROW, MS_DRARROW, TG::Standalone, 5},
-{ "emptyset" , TEMPTYSET, MS_EMPTYSET, 

[Libreoffice-commits] help.git: source/text

[Steve Fanning (via logerrit)]

 source/text/scalc/01/func_skewp.xhp |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 61f062fa0c0f33bb2578ebf04537d3db2129c7be
Author: Steve Fanning 
AuthorDate: Tue Feb 2 00:06:06 2021 +0100
Commit: Olivier Hallot 
CommitDate: Tue Feb 2 11:49:40 2021 +0100

Correct errors in the Help description for Calc’s SKEWP function.

Specifically, the given return value for the first two examples is wrong 
(should be 0.2329985562). The third and fourth examples do not describe the 
implemented behavior but, since the description already states that the 
parameters should specify at least three values, these examples should be 
deleted rather than corrected.

The only file affected is func_skewp.xhp.

Change-Id: I1951d81e3cbb52562b12defa4683ee8b65adef51
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110292
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/func_skewp.xhp 
b/source/text/scalc/01/func_skewp.xhp
index e87b514ff..23b7f93e7 100644
--- a/source/text/scalc/01/func_skewp.xhp
+++ b/source/text/scalc/01/func_skewp.xhp
@@ -41,11 +41,8 @@
 The 
parameters should specify at least three values.
 
 
-SKEWP(2;3;1;6;8;5) returns 0.2828158928
-
-SKEWP(A1:A6) returns 0.2828158928, when the range A1:A6 
contains {2;3;1;6;8;5}
-SKEWP(Number1; Number2) always returns zero, if Number1 
and Number2 results in two numbers.
-SKEWP(Number1) returns Err:502 (Invalid argument) if 
Number1 results in one number, because SKEWP cannot be calculated with one 
value.
+SKEWP(2;3;1;6;8;5) returns 
0.2329985562
+SKEWP(A1:A6) returns 0.2329985562, when the 
range A1:A6 contains {2;3;1;6;8;5}
 
 
 SKEW
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Steve Fanning (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 51220f978347877485653dd02043cd9b166af761
Author: Steve Fanning 
AuthorDate: Tue Feb 2 11:49:40 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Feb 2 11:49:40 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 61f062fa0c0f33bb2578ebf04537d3db2129c7be
  - Correct errors in the Help description for Calc’s SKEWP function.

Specifically, the given return value for the first two examples is 
wrong (should be 0.2329985562). The third and fourth examples do not describe 
the implemented behavior but, since the description already states that the 
parameters should specify at least three values, these examples should be 
deleted rather than corrected.

The only file affected is func_skewp.xhp.

Change-Id: I1951d81e3cbb52562b12defa4683ee8b65adef51
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110292
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index a14906302a55..61f062fa0c0f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a14906302a559fdd49efdd22444dea1643924fda
+Subproject commit 61f062fa0c0f33bb2578ebf04537d3db2129c7be
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

[Tor Lillqvist (via logerrit)]

 sc/inc/document.hxx   |2 -
 sc/inc/global.hxx |2 -
 sc/inc/table.hxx  |4 +--
 sc/source/core/data/dociter.cxx   |4 +--
 sc/source/core/data/document.cxx  |6 ++--
 sc/source/core/data/table1.cxx|   23 +
 sc/source/core/data/table2.cxx|   14 +-
 sc/source/filter/rtf/eeimpars.cxx |2 -
 sc/source/ui/docshell/docfunc.cxx |   50 +++---
 sc/source/ui/docshell/docsh5.cxx  |2 -
 sc/source/ui/inc/docfunc.hxx  |2 -
 sc/source/ui/inc/viewfunc.hxx |2 -
 sc/source/ui/undo/undobase.cxx|2 -
 sc/source/ui/undo/undoblk.cxx |6 ++--
 sc/source/ui/undo/undoblk3.cxx|6 ++--
 sc/source/ui/view/gridwin.cxx |5 ---
 sc/source/ui/view/viewfun2.cxx|6 ++--
 sc/source/ui/view/viewfun3.cxx|2 -
 sc/source/ui/view/viewfun4.cxx|2 -
 sc/source/ui/view/viewfunc.cxx|   10 +++
 20 files changed, 73 insertions(+), 79 deletions(-)

New commits:
commit e763e13873adfe3c6abfa4c2dfd3ac3847e2d494
Author: Tor Lillqvist 
AuthorDate: Tue Feb 2 10:39:21 2021 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Feb 2 12:01:56 2021 +0100

Don't bother shrinking row height when changing just one row interactively

This reverts dca0374fb1edbd9bdeeaadda3f1866ce66b3a778 and instead
tries to achieve the same without using a flag in ScGlobal. How
reliable that is I don't know. See
https://gerrit.libreoffice.org/c/core/+/110245 for discussion.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110245
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
Change-Id: I2a7aa5bf3d29e5fd071e2f1cab628b923b5b6754
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110285
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index e7ebb3653138..a8bfba521437 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1906,7 +1906,7 @@ public:
 const ScColWidthParam* 
pParam = nullptr );
 
 SC_DLLPUBLIC bool   SetOptimalHeight( sc::RowHeightContext& rCxt, 
SCROW nStartRow,
-   SCROW nEndRow, SCTAB nTab );
+  SCROW nEndRow, SCTAB nTab, 
bool bApi );
 
 voidUpdateAllRowHeights( sc::RowHeightContext& 
rCxt, const ScMarkData* pTabMark );
 
diff --git a/sc/inc/global.hxx b/sc/inc/global.hxx
index 320edbad54d1..f1a3559aa6ad 100644
--- a/sc/inc/global.hxx
+++ b/sc/inc/global.hxx
@@ -813,8 +813,6 @@ public:
 
 /// Calc's threaded group calculation is in progress.
 SC_DLLPUBLIC static bool bThreadedGroupCalcInProgress;
-
-SC_DLLPUBLIC static bool bKeyInputInProgress;
 };
 
 // maybe move to dbdata.hxx (?):
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 1962290cb862..a09781366821 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -779,7 +779,7 @@ public:
 bool bFormula, const ScMarkData* pMarkData,
 const ScColWidthParam* pParam );
 bool SetOptimalHeight(
-sc::RowHeightContext& rCxt, SCROW nStartRow, SCROW nEndRow,
+sc::RowHeightContext& rCxt, SCROW nStartRow, SCROW nEndRow, bool bApi,
 ScProgress* pOuterProgress = nullptr, sal_uLong nProgressStart = 0 );
 
 void SetOptimalHeightOnly(
@@ -796,7 +796,7 @@ public:
 voidSetColWidthOnly( SCCOL nCol, sal_uInt16 nNewWidth );
 voidSetRowHeight( SCROW nRow, sal_uInt16 nNewHeight );
 boolSetRowHeightRange( SCROW nStartRow, SCROW nEndRow, sal_uInt16 
nNewHeight,
-   double nPPTY );
+   double nPPTY, bool bApi );
 
 /**
  * Set specified row height to specified ranges.  Don't check for drawing
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 9597fcedbbfd..ebf49a63038c 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -2730,7 +2730,7 @@ void ScDocRowHeightUpdater::update()
 continue;
 
 mrDoc.maTabs[nTab]->SetOptimalHeight(
-aCxt, aData.mnRow1, aData.mnRow2, , nProgressStart);
+aCxt, aData.mnRow1, aData.mnRow2, true, , 
nProgressStart);
 
 nProgressStart += 
mrDoc.maTabs[nTab]->GetWeightedCount(aData.mnRow1, aData.mnRow2);
 }
@@ -2758,7 +2758,7 @@ void ScDocRowHeightUpdater::updateAll()
 if (!ValidTab(nTab) || !mrDoc.maTabs[nTab])
 continue;
 
-mrDoc.maTabs[nTab]->SetOptimalHeight(aCxt, 0, mrDoc.MaxRow(), 
, nProgressStart);
+mrDoc.maTabs[nTab]->SetOptimalHeight(aCxt, 0, mrDoc.MaxRow(), true, 
, nProgressStart);
 nProgressStart += mrDoc.maTabs[nTab]->GetWeightedCount();
 }
 }
diff --git 

[Libreoffice-commits] core.git: include/vcl vcl/qa vcl/source

[Miklos Vajna (via logerrit)]

 include/vcl/graphicfilter.hxx  |   15 +++
 vcl/qa/cppunit/GraphicDescriptorTest.cxx   |   28 -
 vcl/qa/cppunit/data/graphic-descriptor-mapmode.bmp |binary
 vcl/source/filter/graphicfilter2.cxx   |   17 
 vcl/source/gdi/impgraph.cxx|7 -
 5 files changed, 65 insertions(+), 2 deletions(-)

New commits:
commit ddc0714c40c6ea85336431a88b523f3e5c63a3f8
Author: Miklos Vajna 
AuthorDate: Mon Feb 1 21:03:39 2021 +0100
Commit: Miklos Vajna 
CommitDate: Tue Feb 2 09:04:56 2021 +0100

tdf#139869 vcl: fix lazy-loading of BMP images with logic size

Regression from commit 7b355669c6ddeab2e6cec692d6afdff41c61d0fb
(Function to load graphic swapped out (loaded on demand), 2018-04-14),
the code assumes that the map mode and size of a graphic is the same
when the image is not yet loaded and when it's loaded already.

This was not the case for the BMP import, where ImplReadDIBBody()
produced a map mode with scaling and MapUnit::MapMM as the map unit,
while GraphicDescriptor assumed that the logic size is always 
MapUnit::Map100thMM.

This resulted in SwNoTextNode::HasContour() using one map mode when the
contour polygon is imported and an other one was used while renderin,
effectively hiding the image.

Fix the problem by extending GraphicDescriptor, so a format detector can
opt in to provide its own map mode and size according to that map mode,
this way the detector and the BMP import will create matching map modes
and sizes, resulting in a visible image in the bugdoc.

Change-Id: I71e786a4601c63f58da2e6ab9d7681ec6dd7b806
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110275
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/graphicfilter.hxx b/include/vcl/graphicfilter.hxx
index 5b18654cb81b..237d3deb9c60 100644
--- a/include/vcl/graphicfilter.hxx
+++ b/include/vcl/graphicfilter.hxx
@@ -27,6 +27,7 @@
 #include 
 
 #include 
+#include 
 
 namespace com::sun::star::beans { struct PropertyValue; }
 namespace com::sun::star::uno { template  class Sequence; }
@@ -142,6 +143,8 @@ class VCL_DLLPUBLIC GraphicDescriptor final
 OUStringaPathExt;
 SizeaPixSize;
 SizeaLogSize;
+std::optional maPreferredLogSize;
+std::optional maPreferredMapMode;
 sal_uInt16  nBitsPerPixel;
 sal_uInt16  nPlanes;
 GraphicFileFormat   nFormat;
@@ -212,6 +215,18 @@ public:
 /** @return the logical graphic size in 1/100mm or 0 size */
 const Size& GetSize_100TH_MM() const { return aLogSize; }
 
+/**
+ * Returns the logic size, according to the map mode available via 
GetPreferredMapMode(). Prefer
+ * this size over GetSize_100TH_MM().
+ */
+std::optional GetPreferredLogSize() const { return 
maPreferredLogSize; }
+
+/**
+ * If available, this returns the map mode the graphic prefers, which may 
be other than pixel or
+ * 100th mm. Prefer this map mode over just assuming MapUnit::Map100thMM.
+ */
+std::optional GetPreferredMapMode() const { return 
maPreferredMapMode; }
+
 /** @return bits/pixel or 0 **/
 sal_uInt16  GetBitsPerPixel() const { return nBitsPerPixel; }
 
diff --git a/vcl/qa/cppunit/GraphicDescriptorTest.cxx 
b/vcl/qa/cppunit/GraphicDescriptorTest.cxx
index 13f51262c233..cb6c6d25d80a 100644
--- a/vcl/qa/cppunit/GraphicDescriptorTest.cxx
+++ b/vcl/qa/cppunit/GraphicDescriptorTest.cxx
@@ -7,6 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+
 #include 
 #include 
 #include 
@@ -21,16 +23,22 @@ using namespace css;
 
 namespace
 {
-class GraphicDescriptorTest : public CppUnit::TestFixture
+class GraphicDescriptorTest : public test::BootstrapFixtureBase
 {
+OUString getFullUrl(std::u16string_view sFileName)
+{
+return m_directories.getURLFromSrc(u"/vcl/qa/cppunit/data/") + 
sFileName;
+}
 void testDetectPNG();
 void testDetectJPG();
 void testDetectGIF();
+void testDetectBMP();
 
 CPPUNIT_TEST_SUITE(GraphicDescriptorTest);
 CPPUNIT_TEST(testDetectPNG);
 CPPUNIT_TEST(testDetectJPG);
 CPPUNIT_TEST(testDetectGIF);
+CPPUNIT_TEST(testDetectBMP);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -96,6 +104,24 @@ void GraphicDescriptorTest::testDetectGIF()
 CPPUNIT_ASSERT_EQUAL(tools::Long(100), 
aDescriptor.GetSizePixel().Height());
 }
 
+void GraphicDescriptorTest::testDetectBMP()
+{
+GraphicFilter& rGraphicFilter = GraphicFilter::GetGraphicFilter();
+SvFileStream aFileStream(getFullUrl(u"graphic-descriptor-mapmode.bmp"), 
StreamMode::READ);
+
+Graphic aGraphic = rGraphicFilter.ImportUnloadedGraphic(aFileStream);
+
+CPPUNIT_ASSERT(!aGraphic.isAvailable());
+// Without the accompanying fix in place, this test would have failed with:
+// - 

[Libreoffice-commits] core.git: offapi/com officecfg/registry sdext/source sd/source

[Gabor Kelemen (via logerrit)]

 offapi/com/sun/star/presentation/XSlideShowController.idl |6 +++
 officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu |   12 
+++
 sd/source/ui/slideshow/slideshowimpl.cxx  |   13 
+--
 sd/source/ui/slideshow/slideshowimpl.hxx  |2 -
 sdext/source/presenter/PresenterController.cxx|   17 
--
 5 files changed, 38 insertions(+), 12 deletions(-)

New commits:
commit 5544c178975d480242151083d6c72d42b88a1db4
Author: Gabor Kelemen 
AuthorDate: Sun Jan 10 22:01:38 2021 +0100
Commit: Miklos Vajna 
CommitDate: Tue Feb 2 09:24:31 2021 +0100

tdf#134281 [API-CHANGE] Add keyboard shortcut for UsePen and EraseInk

As suggested by UX meeting:
- Remove P and N keys from previous/next slide
- Assign them to Pen (on=off) and erase ink commands
Do this for presenter console as well.

Modify help text of the presenter console to reflect these changes.

Change-Id: I28d2178f7391739d4f8f5e8f63ab54714fcc97c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109108
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/offapi/com/sun/star/presentation/XSlideShowController.idl 
b/offapi/com/sun/star/presentation/XSlideShowController.idl
index 3d8528dbb722..2d93e33c935a 100644
--- a/offapi/com/sun/star/presentation/XSlideShowController.idl
+++ b/offapi/com/sun/star/presentation/XSlideShowController.idl
@@ -245,6 +245,12 @@ interface XSlideShowController
 [attribute] double PenWidth;
 
 
+/** This method clears ink drawing from the slideshow being played
+
+@since LibreOffice 7.2
+*/
+void setEraseAllInk( [in] boolean EraseAllInk );
+
 /** returns the actual XSlideShow instance that runs the
 slide show.
 Normally all navigation should be done using this controller and
diff --git a/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu 
b/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
index c60645af20d3..4f99dae763a8 100644
--- a/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu
@@ -973,7 +973,7 @@
   
 
   
-Left click, right or down arrow, spacebar, 
page down, enter, return, 'N'
+Left click, right or down arrow, spacebar, 
page down, enter, return
   
   
 Next slide, or next effect
@@ -981,7 +981,7 @@
 
 
   
-Right click, left or up arrow, page up, 
backspace, 'P'
+Right click, left or up arrow, page up, 
backspace
   
   
 Previous slide, or previous effect
@@ -989,10 +989,10 @@
 
 
   
- 
+'P'
   
   
- 
+Use mouse pointer as pen
   
 
 
@@ -1013,10 +1013,10 @@
 
 
   
- 
+'E'
   
   
- 
+Erase all ink on slide
   
 
 
diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx 
b/sd/source/ui/slideshow/slideshowimpl.cxx
index b10d116218c4..41c331644ac2 100644
--- a/sd/source/ui/slideshow/slideshowimpl.cxx
+++ b/sd/source/ui/slideshow/slideshowimpl.cxx
@@ -1756,7 +1756,6 @@ bool SlideshowImpl::keyInput(const KeyEvent& rKEvt)
 case KEY_SPACE:
 case KEY_RIGHT:
 case KEY_DOWN:
-case KEY_N:
 gotoNextEffect();
 break;
 
@@ -1801,11 +1800,19 @@ bool SlideshowImpl::keyInput(const KeyEvent& rKEvt)
 [[fallthrough]];
 case KEY_LEFT:
 case KEY_UP:
-case KEY_P:
 case KEY_BACKSPACE:
 gotoPreviousEffect();
 break;
 
+case KEY_P:
+setUsePen( !mbUsePen );
+break;
+
+case KEY_E:
+setEraseAllInk( true );
+updateSlideShow();
+break;
+
 case KEY_HOME:
 gotoFirstSlide();
 break;
@@ -2685,7 +2692,7 @@ void SAL_CALL SlideshowImpl::setPenColor( sal_Int32 
nColor )
 setUsePen( true ); // enable pen mode, update color
 }
 
-void SlideshowImpl::setEraseAllInk(bool bEraseAllInk)
+void SAL_CALL SlideshowImpl::setEraseAllInk(sal_Bool bEraseAllInk)
 {
 if( !bEraseAllInk )
 return;
diff --git a/sd/source/ui/slideshow/slideshowimpl.hxx 
b/sd/source/ui/slideshow/slideshowimpl.hxx
index 8f848a4f1aa9..5fbd564fc00f 100644
--- a/sd/source/ui/slideshow/slideshowimpl.hxx
+++ b/sd/source/ui/slideshow/slideshowimpl.hxx
@@ -146,7 +146,7 @@ public:
 virtual double SAL_CALL getPenWidth() override;
 virtual void SAL_CALL setPenWidth( double dStrokeWidth ) override;
 /// @throws css::uno::RuntimeException
-void setEraseAllInk( 

[Libreoffice-commits] core.git: sw/uiconfig

[Seth Chaiklin (via logerrit)]

 sw/uiconfig/swriter/ui/bulletsandnumbering.ui |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit cd99fbf15fff51fb1b7febbbc4a333a14900d253
Author: Seth Chaiklin 
AuthorDate: Tue Jan 26 13:25:58 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Tue Feb 2 10:14:35 2021 +0100

tdf#139667 Numbering->Ordered / Bullets->Unordered in dialog + tooltips

   * change "Bullets" tab label to "Unordered"
   * change "Numbering" tab label to "Ordered"
   + Add tooltips for "Ordered", "Outline", "Graphic" "Position",
 and "Customize" tabs

Change-Id: I5338180fd659aa10ca70b70e2d6daf2b8894d4af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109891
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sw/uiconfig/swriter/ui/bulletsandnumbering.ui 
b/sw/uiconfig/swriter/ui/bulletsandnumbering.ui
index f7d28020e31c..d1704ed6e1ae 100644
--- a/sw/uiconfig/swriter/ui/bulletsandnumbering.ui
+++ b/sw/uiconfig/swriter/ui/bulletsandnumbering.ui
@@ -159,7 +159,7 @@
   
 True
 False
-Bullets
+Unordered
   
   
 False
@@ -206,7 +206,8 @@
   
 True
 False
-Numbering
+Ordered
+Ordered numbering 
schemes
   
   
 1
@@ -255,6 +256,7 @@
 True
 False
 Outline
+Hierarchical numbering 
schemes
   
   
 2
@@ -303,6 +305,7 @@
 True
 False
 Image
+Graphic bullet 
symbols
   
   
 3
@@ -351,6 +354,7 @@
 True
 False
 Position
+Indent, spacing, and 
alignment options for ordered and unordered lists
   
   
 4
@@ -399,6 +403,7 @@
 True
 False
 Customize
+Design your own bullet or 
numbering scheme
   
   
 5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang sc/source sd/qa sd/source sfx2/source svx/source sw/inc sw/source vbahelper/source

[Noel (via logerrit)]

 compilerplugins/clang/redundantcast.cxx   |   37 ++
 compilerplugins/clang/test/redundantcast.cxx  |5 ++
 sc/source/ui/docshell/docsh.cxx   |2 -
 sc/source/ui/docshell/docsh4.cxx  |4 +-
 sc/source/ui/unoobj/docuno.cxx|2 -
 sc/source/ui/view/cellsh1.cxx |2 -
 sc/source/ui/view/gridwin.cxx |5 +-
 sd/qa/unit/misc-tests.cxx |4 +-
 sd/source/core/sdpage.cxx |1 
 sd/source/ui/animations/CustomAnimationPane.cxx   |2 -
 sd/source/ui/presenter/PresenterPreviewCache.cxx  |2 -
 sd/source/ui/view/drviewse.cxx|2 -
 sfx2/source/sidebar/SidebarController.cxx |2 -
 svx/source/engine3d/scene3d.cxx   |1 
 svx/source/sdr/properties/attributeproperties.cxx |8 ++--
 svx/source/svdraw/svdedxv.cxx |5 +-
 svx/source/svdraw/svditer.cxx |4 +-
 svx/source/svdraw/svdmodel.cxx|2 -
 svx/source/table/svdotable.cxx|4 +-
 sw/inc/postithelper.hxx   |2 -
 sw/source/core/doc/docfmt.cxx |6 +--
 sw/source/core/draw/dview.cxx |2 -
 sw/source/core/graphic/grfatr.cxx |7 ++--
 sw/source/core/layout/atrfrm.cxx  |2 -
 sw/source/core/layout/paintfrm.cxx|2 -
 sw/source/core/unocore/unochart.cxx   |   28 
 sw/source/uibase/uno/unotxdoc.cxx |4 +-
 vbahelper/source/vbahelper/vbahelper.cxx  |9 ++---
 28 files changed, 91 insertions(+), 65 deletions(-)

New commits:
commit 068d4108e5ae41ca5bc2bcf22277e6235c6bdd0b
Author: Noel 
AuthorDate: Tue Feb 2 09:41:52 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Feb 2 12:24:00 2021 +0100

loplugin:redundantcast catch more dynamic_cast

Change-Id: Ia28e58217cefa306567b53688d851fa210b7821c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110287
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/redundantcast.cxx 
b/compilerplugins/clang/redundantcast.cxx
index bdac3f3bcc56..afc1cb414681 100644
--- a/compilerplugins/clang/redundantcast.cxx
+++ b/compilerplugins/clang/redundantcast.cxx
@@ -800,16 +800,41 @@ bool 
RedundantCast::VisitCXXDynamicCastExpr(CXXDynamicCastExpr const * expr) {
 if (ignoreLocation(expr)) {
 return true;
 }
-// so far this only deals with dynamic casting from T to T
 auto const sub = compat::getSubExprAsWritten(expr);
 auto const t1 = expr->getTypeAsWritten();
 auto const t2 = sub->getType();
-if (t1.getCanonicalType() != t2.getCanonicalType())
+QualType qt1 = t1.getCanonicalType();
+QualType qt2 = t2.getCanonicalType();
+if (qt1 == qt2)
+{
+report(
+DiagnosticsEngine::Warning,
+"redundant dynamic cast from %0 to %1", expr->getExprLoc())
+<< t2 << t1 << expr->getSourceRange();
 return true;
-report(
-DiagnosticsEngine::Warning,
-"redundant dynamic cast from %0 to %1", expr->getExprLoc())
-<< t2 << t1 << expr->getSourceRange();
+}
+if (qt1->isPointerType() && qt2->isPointerType())
+{
+// casting from 'T*' to 'const T*' is redundant, so compare without 
the qualifiers
+qt1 = qt1->getPointeeType().getUnqualifiedType();
+qt2 = qt2->getPointeeType().getUnqualifiedType();
+if (qt1 == qt2)
+{
+report(
+DiagnosticsEngine::Warning,
+"redundant dynamic cast from %0 to %1", expr->getExprLoc())
+<< t2 << t1 << expr->getSourceRange();
+return true;
+}
+if (qt1->getAsCXXRecordDecl() && 
qt2->getAsCXXRecordDecl()->isDerivedFrom(qt1->getAsCXXRecordDecl()))
+{
+report(
+DiagnosticsEngine::Warning,
+"redundant dynamic upcast from %0 to %1", expr->getExprLoc())
+<< t2 << t1 << expr->getSourceRange();
+return true;
+}
+}
 return true;
 }
 
diff --git a/compilerplugins/clang/test/redundantcast.cxx 
b/compilerplugins/clang/test/redundantcast.cxx
index 03ce47796d65..97f4e6f73777 100644
--- a/compilerplugins/clang/test/redundantcast.cxx
+++ b/compilerplugins/clang/test/redundantcast.cxx
@@ -340,11 +340,14 @@ void testDynamicCast() {
 
 S1 * s1 = nullptr;
 S2 * s2 = nullptr;
+S3 * s3 = nullptr;
 
 (void) dynamic_cast(s1);
-(void) dynamic_cast(s2);
+(void) dynamic_cast(s2); // expected-error {{redundant dynamic 
upcast from 'S2 *' to 'S1 *' [loplugin:redundantcast]}}
 (void) dynamic_cast(s2); // expected-error {{redundant dynamic cast 
from 'S2 *' to 'S2 *' [loplugin:redundantcast]}}
 (void) 

[Libreoffice-commits] core.git: sw/inc sw/source

[László Németh (via logerrit)]

 sw/inc/view.hxx  |3 ++-
 sw/source/uibase/uiview/view.cxx |1 +
 sw/source/uibase/uiview/viewstat.cxx |   12 +---
 3 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 28d65bb877c193b3fa53a038f3b896e4ba2f7ee4
Author: László Németh 
AuthorDate: Mon Feb 1 22:18:56 2021 +0100
Commit: László Németh 
CommitDate: Tue Feb 2 10:58:30 2021 +0100

tdf#138870 sw: fix Track Changes toolbar reappearing

on Save automatically.

Now force enabling only on creating a new View
instead of depending on the state of document
modification (which is "unmodified" after saving the
document, too, not only on load).

Follow-up of commit afbbfb3b55beb937555a972d9edbb47ede91001a
(tdf#83958: sw: enable Track Changes toolbar automatically)

Change-Id: I8e074dadc4ec1280924ef88f589302c9e8dfc6e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110278
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/inc/view.hxx b/sw/inc/view.hxx
index abdba739c3b7..7e3feca87883 100644
--- a/sw/inc/view.hxx
+++ b/sw/inc/view.hxx
@@ -245,7 +245,8 @@ class SW_DLLPUBLIC SwView: public SfxViewShell
 m_bInDtor : 1, //detect destructor to prevent creating of 
sub shells while closing
 m_bOldShellWasPagePreview : 1,
 m_bIsPreviewDoubleClick : 1, // #i114045#
-m_bMakeSelectionVisible : 1; // transport the bookmark 
selection
+m_bMakeSelectionVisible : 1, // transport the bookmark 
selection
+m_bForceChangesToolbar : 1;  // on load of documents with 
change tracking
 bool m_bInitOnceCompleted = false;
 
 /// LibreOfficeKit has to force the page size for PgUp/PgDown
diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index 5f5fd34029af..a6639e3bcb9c 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -747,6 +747,7 @@ SwView::SwView( SfxViewFrame *_pFrame, SfxViewShell* pOldSh 
)
 m_bOldShellWasPagePreview(false),
 m_bIsPreviewDoubleClick(false),
 m_bMakeSelectionVisible(false),
+m_bForceChangesToolbar(true),
 m_nLOKPageUpDownOffset(0)
 {
 static bool bRequestDoubleBuffering = getenv("VCL_DOUBLEBUFFERING_ENABLE");
diff --git a/sw/source/uibase/uiview/viewstat.cxx 
b/sw/source/uibase/uiview/viewstat.cxx
index 8dbcbe650090..30c18bdc0180 100644
--- a/sw/source/uibase/uiview/viewstat.cxx
+++ b/sw/source/uibase/uiview/viewstat.cxx
@@ -324,17 +324,15 @@ void SwView::GetState(SfxItemSet )
 break;
 case FN_REDLINE_ON:
 rSet.Put( SfxBoolItem( nWhich, 
GetDocShell()->IsChangeRecording() ) );
-// switch on the disabled Tracked Changes toolbar if the 
document hasn't
-// modified, yet (i.e. on load), and if recording of changes 
is enabled
-// or if it contains tracked changes. TODO: the toolbar stays 
there, but
-// there is no need for it to manage changes only with the 
menus Edit/View,
-// keyboard shortcuts or the experimental sidebar, so it's 
worth to add
-// a View option for this behaviour.
-if ( !GetDocShell()->IsModified() && ( 
GetDocShell()->IsChangeRecording() ||
+// switch on the disabled Tracked Changes toolbar if the view 
is
+// new (e.g. on load), and if recording of changes is enabled
+// or if it contains tracked changes.
+if ( m_bForceChangesToolbar && ( 
GetDocShell()->IsChangeRecording() ||
 
m_pWrtShell->GetDoc()->getIDocumentRedlineAccess().GetRedlineTable().size() ) )
 {
 ShowUIElement("private:resource/toolbar/changes");
 }
+m_bForceChangesToolbar = false;
 break;
 case FN_REDLINE_PROTECT :
 rSet.Put( SfxBoolItem( nWhich, 
GetDocShell()->HasChangeRecordProtection() ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: wizards/Package_sfdocuments.mk wizards/source

[Jean-Pierre Ledure (via logerrit)]

 wizards/Package_sfdocuments.mk|1 
 wizards/source/sfdocuments/SF_Form.xba|   61 
 wizards/source/sfdocuments/SF_FormControl.xba | 1823 ++
 wizards/source/sfdocuments/SF_Register.xba|   40 
 wizards/source/sfdocuments/script.xlb |1 
 5 files changed, 1915 insertions(+), 11 deletions(-)

New commits:
commit 8b3aa6c866a3e5534c1c6d175b324e45826da491
Author: Jean-Pierre Ledure 
AuthorDate: Tue Feb 2 12:12:43 2021 +0100
Commit: Jean-Pierre Ledure 
CommitDate: Tue Feb 2 13:48:27 2021 +0100

ScriptForge - (new SF_FormControl): form control properties

The whole set of properties is created including
- updatable OnXxx event properties
- the Value property as a shortcut to the control content
for all the control types

Controls events management is included

Access to the subcontrols of table controls is included as well

Addition of the new file in the SFDocuments make file

Change-Id: I6308a71e3dd499d729cee1565002b6a9d84f7743
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110289
Tested-by: Jean-Pierre Ledure 
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 

diff --git a/wizards/Package_sfdocuments.mk b/wizards/Package_sfdocuments.mk
index 8d8be4597dd7..6f9cbf7f5ae2 100644
--- a/wizards/Package_sfdocuments.mk
+++ b/wizards/Package_sfdocuments.mk
@@ -24,6 +24,7 @@ $(eval $(call 
gb_Package_add_files,wizards_basicsrvsfdocuments,$(LIBO_SHARE_FOLD
SF_Calc.xba \
SF_Document.xba \
SF_Form.xba \
+   SF_FormControl.xba \
SF_Register.xba \
__License.xba \
dialog.xlb \
diff --git a/wizards/source/sfdocuments/SF_Form.xba 
b/wizards/source/sfdocuments/SF_Form.xba
index 9b259034e56d..5e1f011c8a1d 100644
--- a/wizards/source/sfdocuments/SF_Form.xba
+++ b/wizards/source/sfdocuments/SF_Form.xba
@@ -60,6 +60,11 @@ Option Explicit
To access a subform: 
myForm and mySubForm become distinct instances of the current class
  Set mySubForm = 
myForm.SubForms(mySubForm)
 
+ REM the form is the subject of an event
+ Sub OnEvent(ByRef poEvent As Object)
+ Dim myForm As Object
+ Set myForm = 
CreateScriptService(SFDocuments.FormEvent, poEvent)
+
 

 
 REM == 
EXCEPTIONS
@@ -83,7 +88,7 @@ Private _FormDocument As Object
com.sun.star.comp.sdb.Content - the con
  The form topmost container
 Private _Component As Object
com.sun.star.lang.XComponent or com.sun.star.comp.dba.ODatabaseDocument
 
- EVents management
+ Events management
 Private _CacheIndexAs Long  Index in 
central cache storage
 
  Form UNO references
@@ -94,7 +99,8 @@ Private _Database As Object   
 Database class instance
 
  Form attributes
 
- Persistent storage for controls
+ Cache storage for controls
+Private _ControlNames  As Variant   Array of control 
names
 Private _ControlCache  As Variant   Array of control 
objects sorted like ElementNames of XForm
 
 REM  MODULE 
CONSTANTS
@@ -111,7 +117,7 @@ REM 

 Private Sub Class_Initialize()
Set [Me] = Nothing
Set [_Parent] = Nothing
-   ObjectType = Form
+   ObjectType = FORM
ServiceName = SFDocuments.Form
_Name = 
_SheetName = 
@@ -121,6 +127,7 @@ Private Sub Class_Initialize()
_CacheIndex = -1
Set _Form = Nothing
Set _Database = Nothing
+   _ControlNames = Array()
_ControlCache = Array()
 End Sub  SFDocuments.SF_Form Constructor
 
@@ -554,13 +561,14 @@ Public Function Controls(Optional ByVal ControlName As 
Variant) As Variant
  ControlName is invalid
  Example:
  Dim myForm As Object, myList As 
Variant, myControl As Object
- Set myForm = 
CreateScriptService(SFDocuments.Form, Container, Library, FormName)
+ Set myForm = 
myDoc.Forms(myForm)
  myList = myForm.Controls()
  Set myControl = 
myForm.Controls(myTextBox)
 
 Dim oControl As Object   The new control class 
instance
 Dim lIndexOfNames As LongIndex in ElementNames 
array. Used to access _ControlCache
 Dim vControl As Variant  Alias of 
_ControlCache entry
+Dim i As Long
 Const cstThisSub = SFDocuments.Form.Controls
 Const cstSubArgs = [ControlName]
 
@@ -574,8 +582,51 @@ Check:
End If
 
 Try:
+ Collect all 

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ebf4e535864f98f3b32799596ae16b752132da0a
Author: Seth Chaiklin 
AuthorDate: Tue Feb 2 15:32:29 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Feb 2 15:32:29 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to e3e851ad54c73e59f18da86906a0516cc016161d
  - tdf#140075 update table and help for Apply border option in AutoCorrect

  appearance of auto-corrected borders was changed in 2010 and
  2013, but the table in help that described the border appearances
  was not updated until now.

  + added instructions about how to modify a border
  + added some  to separate the points clearly
  + added  in those paragraphs where changes were made.

Change-Id: Ic14a5a434f21fb416809b8f0ff1e9ea08ea1ffb1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110293
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index c3c3667537da..e3e851ad54c7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c3c3667537da499d21c5837f880f60b9a9876add
+Subproject commit e3e851ad54c73e59f18da86906a0516cc016161d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/shared/01/06040100.xhp |   27 ---
 1 file changed, 20 insertions(+), 7 deletions(-)

New commits:
commit e3e851ad54c73e59f18da86906a0516cc016161d
Author: Seth Chaiklin 
AuthorDate: Tue Feb 2 01:33:55 2021 +0100
Commit: Seth Chaiklin 
CommitDate: Tue Feb 2 15:32:29 2021 +0100

tdf#140075 update table and help for Apply border option in AutoCorrect

  appearance of auto-corrected borders was changed in 2010 and
  2013, but the table in help that described the border appearances
  was not updated until now.

  + added instructions about how to modify a border
  + added some  to separate the points clearly
  + added  in those paragraphs where changes were made.

Change-Id: Ic14a5a434f21fb416809b8f0ff1e9ea08ea1ffb1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110293
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/source/text/shared/01/06040100.xhp 
b/source/text/shared/01/06040100.xhp
index 7b85b2b14..6983b0665 100644
--- a/source/text/shared/01/06040100.xhp
+++ b/source/text/shared/01/06040100.xhp
@@ -175,7 +175,12 @@
 
 
 Apply border
-  Automatically applies a border at the base of the preceding 
paragraph when you type three or more specific characters, and then press 
Enter. To create a single line, type three or more hyphens (-), or underscores 
(_), and then press Enter. To create a double line, type three or more equal 
signs (=), asterisks (*), tildes (~), or hash marks (#), and then press 
Enter.
+  Automatically applies a border at the base of the preceding 
paragraph when you type three or more specific characters, and then press 
Enter. 
+  
+  
+To create a 
single line, type three or more hyphens (-), or underscores 
(_), and then press Enter. To create a 
double line, type three or more equal signs (=), asterisks 
(*), tildes (~), or hash marks 
(#), and then press Enter.
+  
+  
   To delete 
the created line, click the paragraph above the line, choose Format - 
Paragraph - Borders, delete the bottom border.
   The 
following table summarizes the line thickness for the different characters: 

   
@@ -184,7 +189,7 @@
---
 
 
-   0.5pt single underline
+   0.05pt single underline
 
  
  
@@ -200,7 +205,7 @@
===
 
 
-   1.1pt double underline
+   1.0pt double underline
 
  
  
@@ -208,7 +213,7 @@
***
 
 
-   4.5pt double underline
+   4.0pt thick-thin double underline
 
  
  
@@ -216,7 +221,7 @@
~~~
 
 
-   6.0pt double underline
+   4.0pt thin-thick double underline
 
  
  
@@ -224,12 +229,20 @@
###
 
 
-   9.0pt double underline
+   2.5pt double underline
 
  
   
+  
+  
+To modify 
attributes of a predefined border, such as color, style, width and shadow, 
click the paragraph above the line, choose Format - Paragraph - 
Borders tab.
+  
+  
+To 
delete the created line, click the paragraph above the line, choose 
Format - Paragraph - Borders, delete the bottom border.
+  
+  
+  To remove a line created with Apply 
Border, place the cursor above the line, press CommandCtrl+M.
   
-To remove a line created with Apply Border, 
place the cursor above the line, press CommandCtrl+M.
 
 
 Create table
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source include/editeng

[Miklos Vajna (via logerrit)]

 editeng/source/items/frmitems.cxx |5 +
 include/editeng/lrspitem.hxx  |4 
 2 files changed, 9 insertions(+)

New commits:
commit 48829edfb148ff61d1e03319547151380899ba63
Author: Miklos Vajna 
AuthorDate: Tue Feb 2 12:22:15 2021 +0100
Commit: Miklos Vajna 
CommitDate: Tue Feb 2 14:17:28 2021 +0100

sw page gutter margin: add doc model

The page gutter defines the amount of extra space added to the specified
margin, above any existing margin values. This can be helpful in case of
printed books: e.g. 1cm left margin, 1cm right margin, then some
additional gutter margin on the left can mean that once the book is
printed and binding consumes its space, the remaining left/right margin
is matching.

This is just the doc model, other parts will come in follow-up commits.

Change-Id: Ibd3e836ced664b57e817f5c0952098460b683089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110290
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index 184bf21cd994..e1520735d804 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -289,6 +289,7 @@ SvxLRSpaceItem::SvxLRSpaceItem( const sal_uInt16 nId ) :
 nTxtLeft( 0 ),
 nLeftMargin ( 0 ),
 nRightMargin( 0 ),
+m_nGutterMargin(0),
 nPropFirstLineOffset( 100 ),
 nPropLeftMargin( 100 ),
 nPropRightMargin( 100 ),
@@ -308,6 +309,7 @@ SvxLRSpaceItem::SvxLRSpaceItem( const tools::Long nLeft, 
const tools::Long nRigh
 nTxtLeft( nTLeft ),
 nLeftMargin ( nLeft ),
 nRightMargin( nRight ),
+m_nGutterMargin(0),
 nPropFirstLineOffset( 100 ),
 nPropLeftMargin( 100 ),
 nPropRightMargin( 100 ),
@@ -472,6 +474,7 @@ bool SvxLRSpaceItem::operator==( const SfxPoolItem& rAttr ) 
const
 return (
 nFirstLineOffset == rOther.GetTextFirstLineOffset() &&
 nTxtLeft == rOther.GetTextLeft() &&
+m_nGutterMargin == rOther.GetGutterMargin() &&
 nLeftMargin == rOther.GetLeft()  &&
 nRightMargin == rOther.GetRight() &&
 nPropFirstLineOffset == rOther.GetPropTextFirstLineOffset() &&
@@ -594,6 +597,8 @@ void SvxLRSpaceItem::dumpAsXml(xmlTextWriterPtr pWriter) 
const
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nTxtLeft"), 
BAD_CAST(OString::number(nTxtLeft).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nLeftMargin"), 
BAD_CAST(OString::number(nLeftMargin).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nRightMargin"), 
BAD_CAST(OString::number(nRightMargin).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST("m_nGutterMargin"),
+
BAD_CAST(OString::number(m_nGutterMargin).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nPropFirstLineOffset"), 
BAD_CAST(OString::number(nPropFirstLineOffset).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nPropLeftMargin"), 
BAD_CAST(OString::number(nPropLeftMargin).getStr()));
 xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nPropRightMargin"), 
BAD_CAST(OString::number(nPropRightMargin).getStr()));
diff --git a/include/editeng/lrspitem.hxx b/include/editeng/lrspitem.hxx
index b04944326407..9b3ec7734a8e 100644
--- a/include/editeng/lrspitem.hxx
+++ b/include/editeng/lrspitem.hxx
@@ -51,6 +51,8 @@ class EDITENG_DLLPUBLIC SvxLRSpaceItem final : public 
SfxPoolItem
 tools::LongnTxtLeft;   // We spend a sal_uInt16
 tools::LongnLeftMargin;// nLeft or the negative first-line 
indent
 tools::LongnRightMargin;   // The unproblematic right edge
+/// The amount of extra space added to the left margin.
+tools::Longm_nGutterMargin;
 
 sal_uInt16  nPropFirstLineOffset, nPropLeftMargin, nPropRightMargin;
 short   nFirstLineOffset; // First-line indent _always_ relative to 
nTxtLeft
@@ -116,6 +118,8 @@ public:
 { return nPropFirstLineOffset; }
 void SetTextFirstLineOffsetValue( const short nValue )
 { nFirstLineOffset = nValue; }
+void SetGutterMargin(const tools::Long nGutterMargin) { m_nGutterMargin = 
nGutterMargin; }
+tools::Long GetGutterMargin() const { return m_nGutterMargin; }
 
 void dumpAsXml(xmlTextWriterPtr pWriter) const override;
 virtual boost::property_tree::ptree dumpAsJSON() const override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3b778d346522ac8fc3018eb93509fb3d993233cc
Author: Seth Chaiklin 
AuthorDate: Wed Feb 3 07:55:32 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Feb 3 07:55:32 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 034fe242059b9b115ec97cce46888b65a1a2df33
  - tdf#14 add missing option to AutoCorrect Options

Change-Id: I2405d24d350a9490aacb3bf45bcea7714a0e3fec
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110302
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index e5e4bb9f487a..034fe242059b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e5e4bb9f487ad1b1238d69254a4103ab303d6bb2
+Subproject commit 034fe242059b9b115ec97cce46888b65a1a2df33
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/shared/01/06040100.xhp |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 034fe242059b9b115ec97cce46888b65a1a2df33
Author: Seth Chaiklin 
AuthorDate: Wed Feb 3 00:51:16 2021 +0100
Commit: Ilmari Lauhakangas 
CommitDate: Wed Feb 3 07:55:32 2021 +0100

tdf#14 add missing option to AutoCorrect Options

Change-Id: I2405d24d350a9490aacb3bf45bcea7714a0e3fec
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110302
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git a/source/text/shared/01/06040100.xhp 
b/source/text/shared/01/06040100.xhp
index 64adb7d88..f0b81539b 100644
--- a/source/text/shared/01/06040100.xhp
+++ b/source/text/shared/01/06040100.xhp
@@ -162,6 +162,8 @@
 [T] options only
   Ignore double spaces
   Replaces 
two or more consecutive spaces with a single space.
+  Correct accidental use of cAPS LOCK 
key
+  Inverts a 
capitalized word entered with the Caps Lock key enabled, 
after a space is entered, and disables the Caps 
Lock key. For example, entering Libre with 
Caps Lock enabled appears as lIBRE, which 
is converted automatically to Libre.
   Bulleted and numbered lists. Bullet 
symbol:
   Automatically creates a numbered list when you press Enter at 
the end of a line that starts with a number followed by a period, a space, and 
text. If a line starts with a hyphen (-), a plus sign (+), or an asterisk (*), 
followed by a space, and text, a bulleted list is created when you press Enter.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Steve Fanning (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6cee751a004e854287837241846203b9f77c971b
Author: Steve Fanning 
AuthorDate: Wed Feb 3 02:49:34 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Feb 3 02:49:34 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 24f765784f3a0e4d71df778da249b1f33841e460
  - Clarify default values in Help description for Calc’s ACCRINTM function.

Specifically, the description of the Par argument should match the 
corresponding description for the ACCRINT function. It should also include the 
pinned note that the default applied is an arbitrary value and should perhaps 
be avoided.

File 04060103.xhp affected.

Change-Id: Ieaf0d3eb23c989ee05e856146c0af3ad720a4fb2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110297
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index ca492b44070a..24f765784f3a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ca492b44070afd6338c18efd4fdf595e51155254
+Subproject commit 24f765784f3a0e4d71df778da249b1f33841e460
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Steve Fanning (via logerrit)]

 source/text/scalc/01/04060103.xhp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 24f765784f3a0e4d71df778da249b1f33841e460
Author: Steve Fanning 
AuthorDate: Tue Feb 2 21:12:44 2021 +0100
Commit: Olivier Hallot 
CommitDate: Wed Feb 3 02:49:34 2021 +0100

Clarify default values in Help description for Calc’s ACCRINTM function.

Specifically, the description of the Par argument should match the 
corresponding description for the ACCRINT function. It should also include the 
pinned note that the default applied is an arbitrary value and should perhaps 
be avoided.

File 04060103.xhp affected.

Change-Id: Ieaf0d3eb23c989ee05e856146c0af3ad720a4fb2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110297
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060103.xhp 
b/source/text/scalc/01/04060103.xhp
index c4f98fe89..7145fc474 100644
--- a/source/text/scalc/01/04060103.xhp
+++ b/source/text/scalc/01/04060103.xhp
@@ -127,7 +127,8 @@
  
 Rate (required) is the annual nominal rate of 
interest (coupon interest rate).
  
-Par (optional) is the par value of the 
security.
+Par (optional) is the par value of the security. If 
omitted, a default value of 1000 is used.
+ We recommend that you always specify 
the value that you require for ACCRINTM’s Par argument, rather 
than allowing Calc to apply an arbitrary default. This will make your formula 
easier to understand and easier to maintain.
  
  
  A 
security is issued on 2001-04-01. The maturity date is set for 2001-06-15. The 
Rate is 0.1 or 10% and Par is 1000 currency units. The basis of the 
daily/annual calculation is the daily balance (3). How much interest has 
accrued?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Steve Fanning (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b57db736998a9dd0b5bb40e5fbee2871bf520f9c
Author: Steve Fanning 
AuthorDate: Wed Feb 3 02:58:30 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Feb 3 02:58:30 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to e5e4bb9f487ad1b1238d69254a4103ab303d6bb2
  - Correct example given in Help file for Calc's DB function.

The explanation of the example given is confusing.

File 04060103.xhp is affected.

Change-Id: I7658d4d0497f83c68b2d56cfe14da48c1fe16b04
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110301
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 13b1e7bca5e5..e5e4bb9f487a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 13b1e7bca5e5860dbf4550949f514749a64e2d54
+Subproject commit e5e4bb9f487ad1b1238d69254a4103ab303d6bb2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Steve Fanning (via logerrit)]

 source/text/scalc/01/04060103.xhp |8 
 1 file changed, 8 insertions(+)

New commits:
commit 13b1e7bca5e5860dbf4550949f514749a64e2d54
Author: Steve Fanning 
AuthorDate: Tue Feb 2 21:45:25 2021 +0100
Commit: Olivier Hallot 
CommitDate: Wed Feb 3 02:58:06 2021 +0100

Provide examples in the Help descriptions of Calc’s AMORDEGRC and AMORLINC 
functions.

Relevant examples might be:

=AMORDEGRC(2000; "2020-02-01"; "2020-12-31"; 10; 4; 0.1; 0) returns a 
depreciation amount of 163 currency units.

=AMORLINC(2000; "2020-02-01"; "2020-12-31"; 10; 4; 0.1; 0) returns a 
depreciation amount of 200 currency units.

File 04060103.xhp affected.

Change-Id: I9161d974c00cfc30515fb1fcbe44aff09242f422
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110300
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060103.xhp 
b/source/text/scalc/01/04060103.xhp
index 7145fc474..75bfec5ba 100644
--- a/source/text/scalc/01/04060103.xhp
+++ b/source/text/scalc/01/04060103.xhp
@@ -58,6 +58,10 @@
  
 Rate is the rate of depreciation.
  
+ 
+ An asset was acquired on 2020-02-01 at a cost of 2000 currency 
units. The end date of the first settlement period was 2020-12-31. The salvage 
value of the asset at the end of its depreciable life will be 10 currency 
units. The rate of depreciation is 0.1 (10%) and the year is calculated using 
the US method (Basis 0). Assuming degressive depreciation, what is the amount 
of depreciation in the fourth depreciation period?
+ 
+=AMORDEGRC(2000; "2020-02-01"; "2020-12-31"; 10; 4; 0.1; 
0) returns a depreciation amount of 163 currency units.
   
   
 AMORLINC function
@@ -81,6 +85,10 @@
  
 Rate is the rate of depreciation.
  
+ 
+ An asset was acquired on 2020-02-01 at a cost of 2000 currency 
units. The end date of the first settlement period was 2020-12-31. The salvage 
value of the asset at the end of its depreciable life will be 10 currency 
units. The rate of depreciation is 0.1 (10%) and the year is calculated using 
the US method (Basis 0). Assuming linear depreciation, what is the amount of 
depreciation in the fourth depreciation period?
+ 
+=AMORLINC(2000; "2020-02-01"; "2020-12-31"; 10; 4; 0.1; 
0) returns a depreciation amount of 200 currency units.
   
   
 ACCRINT function
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Steve Fanning (via logerrit)]

 source/text/scalc/01/04060103.xhp |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit e5e4bb9f487ad1b1238d69254a4103ab303d6bb2
Author: Steve Fanning 
AuthorDate: Wed Feb 3 00:32:58 2021 +0100
Commit: Olivier Hallot 
CommitDate: Wed Feb 3 02:58:30 2021 +0100

Correct example given in Help file for Calc's DB function.

The explanation of the example given is confusing.

File 04060103.xhp is affected.

Change-Id: I7658d4d0497f83c68b2d56cfe14da48c1fe16b04
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110301
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060103.xhp 
b/source/text/scalc/01/04060103.xhp
index 75bfec5ba..bfc194e17 100644
--- a/source/text/scalc/01/04060103.xhp
+++ b/source/text/scalc/01/04060103.xhp
@@ -680,10 +680,9 @@
  
 Month (optional) denotes the number of months for the 
first year of depreciation. If an entry is not defined, 12 is used as the 
default.
 
- A 
computer system with an initial cost of 25,000 currency units is to be 
depreciated over a three year period. The salvage value is to be 1,000 currency 
units. One period is 30 days.
+ A 
computer system with an initial cost of 25,000 currency units is to be 
depreciated over a three-year period. The salvage value is to be 1,000 currency 
units. The first period of depreciation comprises 6 months. What is the 
fixed-declining balance depreciation of the computer system in the second 
period, which is a full year starting from the end of the first six-month 
period?
  
-=DB(25000;1000;36;1;6) = 1,075.00 
currency units
- The 
fixed-declining depreciation of the computer system is 1,075.00 currency 
units.
+=DB(25000; 1000; 3; 2; 6) returns 11,037.95 
currency units.
   
   
 IRR function
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Steve Fanning (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 083d1146e22319f208f42b098d329e7fdf4c3cae
Author: Steve Fanning 
AuthorDate: Wed Feb 3 02:58:06 2021 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Feb 3 02:58:06 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 13b1e7bca5e5860dbf4550949f514749a64e2d54
  - Provide examples in the Help descriptions of Calc’s AMORDEGRC and 
AMORLINC functions.

Relevant examples might be:

=AMORDEGRC(2000; "2020-02-01"; "2020-12-31"; 10; 4; 0.1; 0) returns a 
depreciation amount of 163 currency units.

=AMORLINC(2000; "2020-02-01"; "2020-12-31"; 10; 4; 0.1; 0) returns a 
depreciation amount of 200 currency units.

File 04060103.xhp affected.

Change-Id: I9161d974c00cfc30515fb1fcbe44aff09242f422
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110300
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 24f765784f3a..13b1e7bca5e5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 24f765784f3a0e4d71df778da249b1f33841e460
+Subproject commit 13b1e7bca5e5860dbf4550949f514749a64e2d54
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: There is a problem with Gerrit WIP.

[Ilmari Lauhakangas]

On 3.2.2021 1.41, Dante Doménech wrote:

There is a problem with Gerrit WIP.
After setting a patch as WIP a build is scheduled.

Over here: built started after setting it as work in progress:
https://gerrit.libreoffice.org/c/core/+/110255/8 

https://ci.libreoffice.org/job/gerrit_master/77366/ 

https://gerrit.libreoffice.org/c/core/+/110166/3 



This was discussed in the dev chat after you mentioned it. The logic is 
that a build is triggered whenever the WIP state is changed. It does not 
matter, if the WIP is activated or deactivated. So to go around this, 
you can submit your patch as WIP from the start with


./logerrit submit-wip master

Ilmari
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: compilerplugins/clang starmath/inc starmath/source

[dante (via logerrit)]

 compilerplugins/clang/unusedmethods.results |6 
 starmath/inc/mathml/starmathdatabase.hxx|2 
 starmath/inc/token.hxx  |   23 
 starmath/source/mathml/mathmlexport.cxx |8 
 starmath/source/mathml/starmathdatabase.cxx |  695 +---
 starmath/source/visitors.cxx|   12 
 6 files changed, 355 insertions(+), 391 deletions(-)

New commits:
commit 404f14ce91b3c8abdd59c017298923b71fa5cef0
Author: dante 
AuthorDate: Tue Feb 2 15:08:43 2021 +0100
Commit: Noel Grandin 
CommitDate: Wed Feb 3 07:56:45 2021 +0100

Clean up SmColorTokenTableEntry

Remove useless member SmColorTokenTableEntry::cIdent
aColorTokenTableDVIPS renamed (make the loop enter in one line)
removed redundant code in visitors (related to color)
removed temporal variables on visitors (related to color)
removed temporal variables on mthmlexport (related to color)
removed redundant code in mathmlexport (related to color)
Since SmColorTokenTableEntry is used as pointer remove useless operators

Change-Id: Icef831711c95e4f9c23b29a3a3606dd9d6fcf6c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110321
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedmethods.results 
b/compilerplugins/clang/unusedmethods.results
index 6673bd00e62a..de8f37e5db59 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -1324,12 +1324,6 @@ starmath/inc/token.hxx:166
  SmColorTokenTableEntry::SmColorTokenTableEntry()
 starmath/inc/token.hxx:182
  SmColorTokenTableEntry::SmColorTokenTableEntry(const class 
std::unique_ptr >)
-starmath/inc/token.hxx:207
-_Bool SmColorTokenTableEntry::operator==(const class rtl::OUString &) const
-starmath/inc/token.hxx:212
-_Bool SmColorTokenTableEntry::operator==(unsigned int) const
-starmath/inc/token.hxx:217
-_Bool SmColorTokenTableEntry::operator==(class Color) const
 starmath/inc/token.hxx:226
 _Bool SmColorTokenTableEntry::equals(class Color) const
 starmath/mathml/inc/mathmlMo.hxx:83
diff --git a/starmath/inc/mathml/starmathdatabase.hxx 
b/starmath/inc/mathml/starmathdatabase.hxx
index 7c16f38deafb..096a38b1e4c2 100644
--- a/starmath/inc/mathml/starmathdatabase.hxx
+++ b/starmath/inc/mathml/starmathdatabase.hxx
@@ -202,7 +202,7 @@ namespace starmathdatabase
 extern const SmColorTokenTableEntry aColorTokenTableParse[159];
 extern const SmColorTokenTableEntry aColorTokenTableHTML[148];
 extern const SmColorTokenTableEntry aColorTokenTableMATHML[16];
-extern const SmColorTokenTableEntry aColorTokenTableDVIPSNAMES[5];
+extern const SmColorTokenTableEntry aColorTokenTableDVIPS[5];
 
 /**
   * Identifies operator chars tokens for importing mathml.
diff --git a/starmath/inc/token.hxx b/starmath/inc/token.hxx
index c7d26e1efe0b..ad1289a5e09c 100644
--- a/starmath/inc/token.hxx
+++ b/starmath/inc/token.hxx
@@ -159,13 +159,11 @@ struct SmTokenTableEntry
 struct SmColorTokenTableEntry
 {
 const char* pIdent;
-const char* cIdent;
 SmTokenType eType;
 Color cColor;
 
 SmColorTokenTableEntry()
 : pIdent("")
-, cIdent("")
 , eType(TERROR)
 , cColor()
 {
@@ -173,7 +171,6 @@ struct SmColorTokenTableEntry
 
 SmColorTokenTableEntry(const SmColorTokenTableEntry* 
amColorTokenTableEntry)
 : pIdent(amColorTokenTableEntry->pIdent)
-, cIdent(amColorTokenTableEntry->cIdent)
 , eType(amColorTokenTableEntry->eType)
 , cColor(amColorTokenTableEntry->cColor)
 {
@@ -181,41 +178,25 @@ struct SmColorTokenTableEntry
 
 SmColorTokenTableEntry(const std::unique_ptr 
amColorTokenTableEntry)
 : pIdent(amColorTokenTableEntry->pIdent)
-, cIdent(amColorTokenTableEntry->cIdent)
 , eType(amColorTokenTableEntry->eType)
 , cColor(amColorTokenTableEntry->cColor)
 {
 }
 
-SmColorTokenTableEntry(const char* name, const char* codename, SmTokenType 
ctype, Color ncolor)
+SmColorTokenTableEntry(const char* name, SmTokenType ctype, Color ncolor)
 : pIdent(name)
-, cIdent(codename)
 , eType(ctype)
 , cColor(ncolor)
 {
 }
 
-SmColorTokenTableEntry(const char* name, const char* codename, SmTokenType 
ctype,
-   sal_uInt32 ncolor)
+SmColorTokenTableEntry(const char* name, SmTokenType ctype, sal_uInt32 
ncolor)
 : pIdent(name)
-, cIdent(codename)
 , eType(ctype)
 , cColor(ColorTransparency, ncolor)
 {
 }
 
-bool operator==(const OUString& colorname) const
-{
-return colorname.compareToIgnoreAsciiCaseAscii(pIdent) == 0;
-}
-
-bool operator==(sal_uInt32 colorcode) const
-{
-return colorcode == static_cast(cColor);
-}
-
-bool operator==(Color colorcode) const { return colorcode == cColor; }
-
 bool equals(const OUString& colorname) 

[Libreoffice-commits] core.git: include/sfx2 sc/source sd/source sfx2/source sw/inc sw/source

[Caolán McNamara (via logerrit)]

 include/sfx2/ipclient.hxx   |2 +-
 include/sfx2/viewsh.hxx |2 +-
 sc/source/ui/inc/tabvwsh.hxx|4 ++--
 sc/source/ui/view/tabvwshb.cxx  |4 ++--
 sd/source/ui/inc/DrawViewShell.hxx  |4 ++--
 sd/source/ui/inc/ViewShell.hxx  |4 ++--
 sd/source/ui/inc/ViewShellBase.hxx  |2 +-
 sd/source/ui/view/ViewShellBase.cxx |4 ++--
 sd/source/ui/view/drviews1.cxx  |6 ++
 sd/source/ui/view/viewshe2.cxx  |2 +-
 sd/source/ui/view/viewshel.cxx  |2 +-
 sfx2/source/view/ipclient.cxx   |2 +-
 sfx2/source/view/viewsh.cxx |6 +-
 sw/inc/view.hxx |2 +-
 sw/source/uibase/inc/wrtsh.hxx  |3 ++-
 sw/source/uibase/uiview/view.cxx|2 +-
 sw/source/uibase/wrtsh/wrtsh1.cxx   |3 +--
 17 files changed, 24 insertions(+), 30 deletions(-)

New commits:
commit a2e533767bed88f293d2129aca9dfd9c4c60226b
Author: Caolán McNamara 
AuthorDate: Tue Feb 2 12:03:20 2021 +
Commit: Caolán McNamara 
CommitDate: Tue Feb 2 17:56:38 2021 +0100

verbs can be sal_Int32 instead of tools::Long

Change-Id: I51c88b837928760c72b77de1535f7843b4fd575e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110318
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/sfx2/ipclient.hxx b/include/sfx2/ipclient.hxx
index d3fead566486..438807a0020d 100644
--- a/include/sfx2/ipclient.hxx
+++ b/include/sfx2/ipclient.hxx
@@ -81,7 +81,7 @@ public:
 static SfxInPlaceClient* GetClient( SfxObjectShell const * pDoc, const 
css::uno::Reference < css::embed::XEmbeddedObject >& xObject );
 sal_Int64   GetAspect() const;
 sal_Int64   GetObjectMiscStatus() const;
-ErrCode DoVerb( tools::Long nVerb );
+ErrCode DoVerb(sal_Int32 nVerb);
 voidVisAreaChanged();
 voidResetObject();
 boolIsUIActive() const;
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 67671a6a678b..a25da48c39d4 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -206,7 +206,7 @@ public:
 SfxInPlaceClient*   GetUIActiveClient() const;
 SfxInPlaceClient*   FindIPClient( const css::uno::Reference < 
css::embed::XEmbeddedObject >&  xObj, vcl::Window *pObjParentWin ) const;
 
-virtual ErrCode DoVerb(tools::Long nVerb);
+virtual ErrCode DoVerb(sal_Int32 nVerb);
 
 voidOutplaceActivated( bool bActive );
 virtual voidUIActivating( SfxInPlaceClient* pClient );
diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index b5d6306e937e..351c9e2cbeee 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -297,7 +297,7 @@ public:
 
 ObjectSelectionType GetCurObjectSelectionType() const { return eCurOST; }
 
-virtual ErrCode DoVerb(tools::Long nVerb) override;
+virtual ErrCode DoVerb(sal_Int32 nVerb) override;
 
 voidStopEditShell();
 boolIsDrawTextShell() const;
@@ -320,7 +320,7 @@ public:
 virtual std::unique_ptr 
CreatePrintOptionsPage(weld::Container* pPage, weld::DialogController* 
pController, const SfxItemSet ) override;
 
 voidConnectObject( const SdrOle2Obj* pObj );
-voidActivateObject( SdrOle2Obj* pObj, tools::Long nVerb );
+voidActivateObject(SdrOle2Obj* pObj, sal_Int32 nVerb);
 
 voidDeactivateOle();
 
diff --git a/sc/source/ui/view/tabvwshb.cxx b/sc/source/ui/view/tabvwshb.cxx
index d0006564d53e..3d545dd109aa 100644
--- a/sc/source/ui/view/tabvwshb.cxx
+++ b/sc/source/ui/view/tabvwshb.cxx
@@ -142,7 +142,7 @@ public:
 
 }
 
-void ScTabViewShell::ActivateObject( SdrOle2Obj* pObj, tools::Long nVerb )
+void ScTabViewShell::ActivateObject(SdrOle2Obj* pObj, sal_Int32 nVerb)
 {
 // Do not leave the hint message box on top of the object
 RemoveHintWindow();
@@ -260,7 +260,7 @@ void ScTabViewShell::ActivateObject( SdrOle2Obj* pObj, 
tools::Long nVerb )
 //xIPObj->SetDocumentName( GetViewData().GetDocShell()->GetTitle() );
 }
 
-ErrCode ScTabViewShell::DoVerb(tools::Long nVerb)
+ErrCode ScTabViewShell::DoVerb(sal_Int32 nVerb)
 {
 SdrView* pView = GetScDrawView();
 if (!pView)
diff --git a/sd/source/ui/inc/DrawViewShell.hxx 
b/sd/source/ui/inc/DrawViewShell.hxx
index 5170883b3379..384600f94771 100644
--- a/sd/source/ui/inc/DrawViewShell.hxx
+++ b/sd/source/ui/inc/DrawViewShell.hxx
@@ -264,8 +264,8 @@ public:
 virtual voidReadFrameViewData(FrameView* pView) override;
 virtual voidWriteFrameViewData() override;
 
-virtual ErrCode DoVerb(::tools::Long nVerb) override;
-virtual boolActivateObject(SdrOle2Obj* pObj, ::tools::Long nVerb) 
override;
+virtual ErrCode DoVerb(sal_Int32 nVerb) override;
+virtual boolActivateObject(SdrOle2Obj* pObj, sal_Int32 nVerb) 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2276554b5ce40c9b0cf27144b85c9d7dbf64d5d6
Author: Olivier Hallot 
AuthorDate: Tue Feb 2 12:33:51 2021 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Feb 2 16:33:51 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 7394ea48d9d1719a40e2b97ca6653acbb14fc555
  - Update presentation video for >7.1

Change-Id: I32702c6701957d4449679689360de3fcc045b8de
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110323
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index e3e851ad54c7..7394ea48d9d1 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e3e851ad54c73e59f18da86906a0516cc016161d
+Subproject commit 7394ea48d9d1719a40e2b97ca6653acbb14fc555
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/shared/01/06040100.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ca492b44070afd6338c18efd4fdf595e51155254
Author: Olivier Hallot 
AuthorDate: Tue Feb 2 12:17:21 2021 -0300
Commit: Olivier Hallot 
CommitDate: Tue Feb 2 16:34:14 2021 +0100

 Fix dup id's

Change-Id: I7c975fa2907da04c38b723376d4105d913665ab2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110324
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/06040100.xhp 
b/source/text/shared/01/06040100.xhp
index 6983b0665..64adb7d88 100644
--- a/source/text/shared/01/06040100.xhp
+++ b/source/text/shared/01/06040100.xhp
@@ -181,7 +181,7 @@
 To create a 
single line, type three or more hyphens (-), or underscores 
(_), and then press Enter. To create a 
double line, type three or more equal signs (=), asterisks 
(*), tildes (~), or hash marks 
(#), and then press Enter.
   
   
-  To delete 
the created line, click the paragraph above the line, choose Format - 
Paragraph - Borders, delete the bottom border.
+  To delete 
the created line, click the paragraph above the line, choose Format - 
Paragraph - Borders, delete the bottom border.
   The 
following table summarizes the line thickness for the different characters: 

   
  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 43fadd3beaf3fbc8a402363cf1c0bbda339b2edc
Author: Olivier Hallot 
AuthorDate: Tue Feb 2 12:34:14 2021 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Feb 2 16:34:14 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to ca492b44070afd6338c18efd4fdf595e51155254
  -  Fix dup id's

Change-Id: I7c975fa2907da04c38b723376d4105d913665ab2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110324
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 7394ea48d9d1..ca492b44070a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 7394ea48d9d1719a40e2b97ca6653acbb14fc555
+Subproject commit ca492b44070afd6338c18efd4fdf595e51155254
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/shared/06/youtubevideos.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7394ea48d9d1719a40e2b97ca6653acbb14fc555
Author: Olivier Hallot 
AuthorDate: Tue Feb 2 12:16:35 2021 -0300
Commit: Olivier Hallot 
CommitDate: Tue Feb 2 16:33:51 2021 +0100

Update presentation video for >7.1

Change-Id: I32702c6701957d4449679689360de3fcc045b8de
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110323
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/06/youtubevideos.xhp 
b/source/text/shared/06/youtubevideos.xhp
index f83390350..81f63aed7 100644
--- a/source/text/shared/06/youtubevideos.xhp
+++ b/source/text/shared/06/youtubevideos.xhp
@@ -17,7 +17,7 @@
 
 
 
-https://www.youtube-nocookie.com/embed/XusjjbBm81s; 
id="vid_id61521568603544" type="video/youtube" width="700" 
height="394"/>
+https://www.youtube-nocookie.com/embed/QTsnUupNhxo; 
id="vid_id61521568603544" type="video/youtube" width="700" 
height="394"/>
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source sd/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/drawfunc/fudraw.cxx |5 +++--
 sc/source/ui/drawfunc/fusel.cxx  |3 ++-
 sc/source/ui/uitest/uiobject.cxx |4 +++-
 sc/source/ui/view/tabvwshh.cxx   |4 +++-
 sd/source/ui/func/fupoor.cxx |4 +++-
 5 files changed, 14 insertions(+), 6 deletions(-)

New commits:
commit c94f55488ce85091d3510db2717951ca52793174
Author: Caolán McNamara 
AuthorDate: Tue Feb 2 11:53:04 2021 +
Commit: Caolán McNamara 
CommitDate: Tue Feb 2 16:32:47 2021 +0100

use css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY instead of bare 0

Change-Id: I3fb67bcdaa27159790d36100f897efa7d43856ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110317
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/drawfunc/fudraw.cxx b/sc/source/ui/drawfunc/fudraw.cxx
index 3d3201bd6c17..04d31cd6c8b3 100644
--- a/sc/source/ui/drawfunc/fudraw.cxx
+++ b/sc/source/ui/drawfunc/fudraw.cxx
@@ -37,6 +37,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace
 {
@@ -242,7 +243,7 @@ bool FuDraw::KeyInput(const KeyEvent& rKEvt)
 SdrObject* pObj = rMarkList.GetMark( 0 
)->GetMarkedSdrObj();
 if( dynamic_cast( pObj) && !bOle )
 {
-rViewShell.ActivateObject( static_cast< SdrOle2Obj* >( 
pObj ), 0 );
+
rViewShell.ActivateObject(static_cast(pObj), 
css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY);
 
 // consumed
 bReturn = true;
@@ -270,7 +271,7 @@ bool FuDraw::KeyInput(const KeyEvent& rKEvt)
 // in that case F2 is sent instead of double click
 if (isMobilePhone && ScDocument::IsChart(pObj))
 {
-rViewShell.ActivateObject( static_cast< SdrOle2Obj* >( 
pObj ), 0 );
+
rViewShell.ActivateObject(static_cast(pObj), 
css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY);
 break;
 }
 if ( lcl_KeyEditMode( pObj, rViewShell, nullptr ) )
// start text edit for suitable object
diff --git a/sc/source/ui/drawfunc/fusel.cxx b/sc/source/ui/drawfunc/fusel.cxx
index dca0beaa1ef1..b42979a3ba56 100644
--- a/sc/source/ui/drawfunc/fusel.cxx
+++ b/sc/source/ui/drawfunc/fusel.cxx
@@ -17,6 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
 #include 
 #include 
 #include 
@@ -467,7 +468,7 @@ bool FuSelection::MouseButtonUp(const MouseEvent& rMEvt)
 {
 if 
(static_cast(pObj)->GetObjRef().is())
 {
-rViewShell.ActivateObject( 
static_cast(pObj), 0 );
+
rViewShell.ActivateObject(static_cast(pObj), 
css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY);
 }
 }
 }
diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 661f69aacfcd..1e17f9301a58 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -27,6 +27,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -201,7 +203,7 @@ void ScGridWinUIObject::execute(const OUString& rAction,
 if (nSdrObjKind == OBJ_OLE2)
 {
 ScTabViewShell* pViewShell = getViewShell();
-pViewShell->ActivateObject( static_cast(pObj), 0 
);
+pViewShell->ActivateObject(static_cast(pObj), 
css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY);
 }
 else
 {
diff --git a/sc/source/ui/view/tabvwshh.cxx b/sc/source/ui/view/tabvwshh.cxx
index 4a448584aef7..f178175046fd 100644
--- a/sc/source/ui/view/tabvwshh.cxx
+++ b/sc/source/ui/view/tabvwshh.cxx
@@ -37,6 +37,8 @@
 #include 
 #include 
 
+#include 
+
 using namespace com::sun::star;
 
 void ScTabViewShell::ExecuteObject( const SfxRequest& rReq )
@@ -72,7 +74,7 @@ void ScTabViewShell::ExecuteObject( const SfxRequest& rReq )
 // activate
 
 if ( nSlotId == SID_OLE_ACTIVATE )
-pVisibleSh->DoVerb( 0 );
+
pVisibleSh->DoVerb(css::embed::EmbedVerbs::MS_OLEVERB_PRIMARY);
 }
 break;
 case SID_OLE_DEACTIVATE:
diff --git a/sd/source/ui/func/fupoor.cxx b/sd/source/ui/func/fupoor.cxx
index 3b0a81870672..7d1728be115e 100644
--- a/sd/source/ui/func/fupoor.cxx
+++ b/sd/source/ui/func/fupoor.cxx
@@ -40,6 +40,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 
 #include 
@@ -238,7 +240,7 @@ bool FuPoor::KeyInput(const KeyEvent& rKEvt)
 if( dynamic_cast< const SdrOle2Obj* >( pObj ) && 
!mpDocSh->IsUIActive() )
 {
 //HMHmpView->HideMarkHdl();
-mpViewShell->ActivateObject( static_cast< SdrOle2Obj* 
>( pObj ), 0 );
+   

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

[Michael Stahl (via logerrit)]

 sw/inc/ToxTextGenerator.hxx  |5 -
 sw/inc/swtypes.hxx   |2 
 sw/qa/extras/uiwriter/data3/udindex3.odt |binary
 sw/qa/extras/uiwriter/uiwriter3.cxx  |  125 +++
 sw/source/core/doc/doctxm.cxx|   10 --
 sw/source/core/inc/txmsrt.hxx|7 -
 sw/source/core/tox/ToxTextGenerator.cxx  |   16 +++
 sw/source/core/tox/txmsrt.cxx|   44 --
 sw/source/uibase/uiview/view2.cxx|   81 
 9 files changed, 269 insertions(+), 21 deletions(-)

New commits:
commit 7685c0746cf0db6f51c6a7a488f4a960f8eab3c9
Author: Michael Stahl 
AuthorDate: Thu Jan 28 19:59:35 2021 +0100
Commit: Michael Stahl 
CommitDate: Tue Feb 2 18:16:43 2021 +0100

tdf#121842 sw: add hyperlinks to toxmarks in ToC/User-Defined Index

The toxmark is identified by the type of index, the name of the index
type (only for user-defined; there is only one ToC type), the text
(either text:string-value or text content of the toxmark),
and a counter to distinguish marks with the same text.

Both text and type name can contain arbitrary characters so use U+0019
control character as separator.

Links look like: #1%19text%19Utypename|toxmark

Change-Id: I5aeec727e2cd3a02d676cf3ea4c302bf7c77d319
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110091
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/inc/ToxTextGenerator.hxx b/sw/inc/ToxTextGenerator.hxx
index 675835573266..d3a7e9177db0 100644
--- a/sw/inc/ToxTextGenerator.hxx
+++ b/sw/inc/ToxTextGenerator.hxx
@@ -27,6 +27,7 @@
 
 #include 
 #include 
+#include 
 
 class SfxItemSet;
 class SwAttrPool;
@@ -67,7 +68,9 @@ public:
  * process @p numberOfEntriesToProcess entries.
  */
 void
-GenerateText(SwDoc *doc, const 
std::vector>& entries,
+GenerateText(SwDoc *doc,
+std::unordered_map & rMarkURLs,
+const std::vector>& entries,
 sal_uInt16 indexOfEntryToProcess, sal_uInt16 numberOfEntriesToProcess,
 SwRootFrame const* pLayout);
 
diff --git a/sw/inc/swtypes.hxx b/sw/inc/swtypes.hxx
index 24e9c248b167..c45ce1a5a216 100644
--- a/sw/inc/swtypes.hxx
+++ b/sw/inc/swtypes.hxx
@@ -129,6 +129,8 @@ SW_DLLPUBLIC Size GetGraphicSizeTwip( const Graphic&, 
vcl::RenderContext* pOutDe
 const sal_Unicode cMarkSeparator = '|';
 // Sequences names for jumps are !
 const char cSequenceMarkSeparator = '!';
+/// separator for toxmarks: #%19%19|toxmark
+sal_Unicode const toxMarkSeparator = '\u0019';
 
 #define DB_DELIM u'\x00ff'// Database <-> table separator.
 
diff --git a/sw/qa/extras/uiwriter/data3/udindex3.odt 
b/sw/qa/extras/uiwriter/data3/udindex3.odt
new file mode 100644
index ..e6c7736b91e4
Binary files /dev/null and b/sw/qa/extras/uiwriter/data3/udindex3.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index f6b67313889f..87f2cc338038 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -28,6 +28,8 @@
 #include 
 #include 
 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -656,6 +658,129 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf124722)
 CPPUNIT_ASSERT_EQUAL(22, getPages());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testToxmarkLinks)
+{
+load(DATA_DIRECTORY, "udindex3.odt");
+
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwWrtShell& rWrtShell(*pTextDoc->GetDocShell()->GetWrtShell());
+SwView& rView(*pTextDoc->GetDocShell()->GetView());
+
+// update indexes
+for (auto i = rWrtShell.GetTOXCount(); 0 < i;)
+{
+--i;
+rWrtShell.UpdateTableOf(*rWrtShell.GetTOX(i));
+}
+
+// click on the links...
+{
+OUString const tmp("Table of Contents");
+rWrtShell.GotoNextTOXBase();
+}
+
+{ // ToC toxmark
+rWrtShell.Down(false);
+SfxItemSet aSet(rWrtShell.GetAttrPool(),
+svl::Items{});
+rWrtShell.GetCurAttr(aSet);
+CPPUNIT_ASSERT(aSet.HasItem(RES_TXTATR_INETFMT));
+rWrtShell.Push();
+OUString const 
url(aSet.GetItem(RES_TXTATR_INETFMT)->GetValue());
+CPPUNIT_ASSERT_EQUAL(OUString("#1%19the%20tocmark%19C%7Ctoxmark"), 
url);
+rView.JumpToSwMark(url.copy(1)); // SfxApplication::OpenDocExec_Impl 
eats the "#"
+CPPUNIT_ASSERT_EQUAL(OUString(OUStringChar(CH_TXTATR_INWORD) + 
"tocmark"),
+ 
rWrtShell.GetCursor()->GetNode().GetTextNode()->GetText());
+rWrtShell.Pop(SwCursorShell::PopMode::DeleteCurrent);
+}
+
+{ // ToC heading
+rWrtShell.Down(false);
+SfxItemSet aSet(rWrtShell.GetAttrPool(),
+svl::Items{});
+rWrtShell.GetCurAttr(aSet);
+CPPUNIT_ASSERT(aSet.HasItem(RES_TXTATR_INETFMT));
+rWrtShell.Push();
+OUString 

[Libreoffice-commits] core.git: sc/qa vcl/source

[Xisco Fauli (via logerrit)]

 sc/qa/uitest/autofilter/tdf92767.py   |   58 ++
 sc/qa/uitest/data/autofilter/tdf92767.ods |binary
 vcl/source/treelist/uiobject.cxx  |4 ++
 3 files changed, 62 insertions(+)

New commits:
commit 14d064cee7b76e8a2a2201d4da423336f68fe624
Author: Xisco Fauli 
AuthorDate: Tue Feb 2 19:55:19 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Feb 3 08:49:35 2021 +0100

tdf#92767: sc: Add UItest

Change-Id: I9f1d82d81364ee0ee833b4505e6925cce5e3e787
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110332
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/autofilter/tdf92767.py 
b/sc/qa/uitest/autofilter/tdf92767.py
new file mode 100644
index ..859620b73a8a
--- /dev/null
+++ b/sc/qa/uitest/autofilter/tdf92767.py
@@ -0,0 +1,58 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from libreoffice.calc.document import get_row
+from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
+
+def is_row_hidden(doc, index):
+row = get_row(doc, index)
+val = row.getPropertyValue("IsVisible")
+return not val
+
+class tdf92767(UITestCase):
+
+def test_tdf92767(self):
+calc_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf92767.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+
+for i in range(0,25):
+self.assertFalse(is_row_hidden(calc_doc, i))
+
+gridwin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "0", "ROW": "0"}))
+xFloatWindow = self.xUITest.getFloatWindow()
+xTreeList = xFloatWindow.getChild("check_tree_box")
+xFirstEntry = xTreeList.getChild("0")
+self.assertEqual('2015', get_state_as_dict(xFirstEntry)["Text"])
+self.assertEqual('7', get_state_as_dict(xFirstEntry)["Children"])
+
+# Deselect all the options but the last one
+for i in range(6):
+xChild = xFirstEntry.getChild(str(i))
+xChild.executeAction("CLICK", tuple())
+self.assertEqual('false', get_state_as_dict(xChild)['IsChecked'])
+
+xLastChild = xFirstEntry.getChild('6')
+self.assertEqual('true', get_state_as_dict(xLastChild)['IsChecked'])
+self.assertEqual('July', get_state_as_dict(xLastChild)['Text'])
+
+xOkBtn = xFloatWindow.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
+
+for i in range(1,22):
+self.assertTrue(is_row_hidden(calc_doc, i))
+
+# Without the fix in place, this test would have failed here
+self.assertFalse(is_row_hidden(calc_doc, 23))
+self.assertFalse(is_row_hidden(calc_doc, 24))
+self.assertFalse(is_row_hidden(calc_doc, 25))
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/uitest/data/autofilter/tdf92767.ods 
b/sc/qa/uitest/data/autofilter/tdf92767.ods
new file mode 100644
index ..34dfb002e2d0
Binary files /dev/null and b/sc/qa/uitest/data/autofilter/tdf92767.ods differ
diff --git a/vcl/source/treelist/uiobject.cxx b/vcl/source/treelist/uiobject.cxx
index e7fb516b5d21..0caea7163f76 100644
--- a/vcl/source/treelist/uiobject.cxx
+++ b/vcl/source/treelist/uiobject.cxx
@@ -108,6 +108,10 @@ StringMap TreeListEntryUIObject::get_state()
 aMap["VisibleChildCount"] = 
OUString::number(mxTreeList->GetVisibleChildCount(mpEntry));
 aMap["IsSelected"] = OUString::boolean(mxTreeList->IsSelected(mpEntry));
 
+SvLBoxButton* pItem = 
static_cast(mpEntry->GetFirstItem(SvLBoxItemType::Button));
+if (pItem)
+aMap["IsChecked"] = OUString::boolean(pItem->IsStateChecked());
+
 return aMap;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/stringviewparam.cxx  |4 
 compilerplugins/clang/test/stringviewparam.cxx |2 ++
 2 files changed, 6 insertions(+)

New commits:
commit dec14c4a074b4e4b156b932155e73647d6ebd519
Author: Stephan Bergmann 
AuthorDate: Tue Feb 2 18:29:41 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Feb 2 20:45:24 2021 +0100

Avoid --disable-assert-always-abort loplugin:stringviewparam false positives

...like

> l10ntools/source/helper.cxx:19:69: error: replace function parameter of 
type 'const rtl::OString &' with 'std::string_view' [loplugin:stringviewparam]
> const OString& rText, const OString& rUnEscaped, const OString& 
rEscaped )
>  
~~~^~~~

where the call to rEscaped.getLength(), which would otherwise suppress the
warning, is hidden inside an assert.

(Similar to aab0322580c87864a4f0c0af1fed07282c8dccbb "Disable
loplugin:casttovoid when --disable-assert-always-abort".)

Change-Id: Ie054f75317707757b1c6243c593f539d445a9fee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110331
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/stringviewparam.cxx 
b/compilerplugins/clang/stringviewparam.cxx
index 9182bf449bbe..862e9f331133 100644
--- a/compilerplugins/clang/stringviewparam.cxx
+++ b/compilerplugins/clang/stringviewparam.cxx
@@ -504,6 +504,10 @@ private:
 {
 return;
 }
+if 
(compiler.getPreprocessor().getIdentifierInfo("NDEBUG")->hasMacroDefinition())
+{
+return;
+}
 StringRef fn(handler.getMainFileName());
 // leave the string QA tests alone
 if (loplugin::hasPathnamePrefix(fn, SRCDIR "/sal/qa/"))
diff --git a/compilerplugins/clang/test/stringviewparam.cxx 
b/compilerplugins/clang/test/stringviewparam.cxx
index a9fcab3ac3a0..db57c8ac415f 100644
--- a/compilerplugins/clang/test/stringviewparam.cxx
+++ b/compilerplugins/clang/test/stringviewparam.cxx
@@ -7,6 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#undef NDEBUG
+
 #include "sal/config.h"
 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/subsequent_filters-test.cxx |   36 +
 1 file changed, 36 insertions(+)

New commits:
commit 4c95b7415340b07fd94e8f374aa2dfbb070783f8
Author: Xisco Fauli 
AuthorDate: Tue Feb 2 17:33:52 2021 +0100
Commit: Xisco Fauli 
CommitDate: Tue Feb 2 20:47:54 2021 +0100

tdf#84762: sc_subsequent_filters: Add unittest

Change-Id: I54f7b65628c40922eeb9159435f94e675f3c888a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110329
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 7ceee84f63ae..89a5eb084244 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -227,6 +227,7 @@ public:
 void testCopyMergedNumberFormats();
 void testVBAUserFunctionXLSM();
 void testEmbeddedImageXLS();
+void testTdf84762();
 void testTdf44076();
 void testEditEngStrikeThroughXLSX();
 void testRefStringXLSX();
@@ -413,6 +414,7 @@ public:
 CPPUNIT_TEST(testVBAUserFunctionXLSM);
 CPPUNIT_TEST(testEmbeddedImageXLS);
 CPPUNIT_TEST(testErrorOnExternalReferences);
+CPPUNIT_TEST(testTdf84762);
 CPPUNIT_TEST(testTdf44076);
 CPPUNIT_TEST(testEditEngStrikeThroughXLSX);
 CPPUNIT_TEST(testRefStringXLSX);
@@ -3704,6 +3706,40 @@ void ScFiltersTest::testErrorOnExternalReferences()
 xDocSh->DoClose();
 }
 
+void ScFiltersTest::testTdf84762()
+{
+ScDocShellRef xDocSh = loadDoc(u"blank.", FORMAT_ODS);
+CPPUNIT_ASSERT_MESSAGE("Failed to open empty doc", xDocSh.is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+rDoc.SetString(ScAddress(0,0,0), "=RAND()");
+rDoc.SetString(ScAddress(0,1,0), "=RAND()");
+rDoc.SetString(ScAddress(1,0,0), "=RAND()*A1");
+rDoc.SetString(ScAddress(1,1,0), "=RAND()*B1");
+
+double nValA1, nValB1, nValA2, nValB2;
+
+// Without the fix in place, some cells wouldn't have been updated
+// after using F9 a few times
+for(sal_Int16 i = 0; i < 10; ++i)
+{
+nValA1 = rDoc.GetValue(0, 0, 0);
+nValB1 = rDoc.GetValue(0, 1, 0);
+nValA2 = rDoc.GetValue(1, 0, 0);
+nValB2 = rDoc.GetValue(1, 1, 0);
+
+xDocSh->DoRecalc(false);
+
+CPPUNIT_ASSERT(nValA1 != rDoc.GetValue(0, 0, 0));
+CPPUNIT_ASSERT(nValA2 != rDoc.GetValue(0, 1, 0));
+CPPUNIT_ASSERT(nValB1 != rDoc.GetValue(1, 0, 0));
+CPPUNIT_ASSERT(nValB2 != rDoc.GetValue(1, 1, 0));
+}
+
+xDocSh->DoClose();
+}
+
 void ScFiltersTest::testTdf44076()
 {
 ScDocShellRef xDocSh = loadDoc(u"blank.", FORMAT_ODS);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/cppu include/cppuhelper include/osl include/rtl include/sal include/salhelper include/typelib include/uno

[msrijita18 (via logerrit)]

 include/cppu/Enterable.hxx  |4 
 include/cppu/EnvDcp.hxx |4 
 include/cppu/EnvGuards.hxx  |4 
 include/cppu/Map.hxx|4 
 include/cppu/cppudllapi.h   |3 +++
 include/cppu/helper/purpenv/Environment.hxx |4 
 include/cppu/helper/purpenv/Mapping.hxx |4 
 include/cppu/macros.hxx |4 
 include/cppu/unotype.hxx|4 
 include/cppuhelper/access_control.hxx   |4 
 include/cppuhelper/basemutex.hxx|4 
 include/cppuhelper/bootstrap.hxx|4 
 include/cppuhelper/compbase1.hxx|4 
 include/cppuhelper/compbase10.hxx   |4 
 include/cppuhelper/compbase11.hxx   |4 
 include/cppuhelper/compbase12.hxx   |4 
 include/cppuhelper/compbase2.hxx|4 
 include/cppuhelper/compbase3.hxx|4 
 include/cppuhelper/compbase4.hxx|4 
 include/cppuhelper/compbase5.hxx|4 
 include/cppuhelper/compbase6.hxx|4 
 include/cppuhelper/compbase7.hxx|4 
 include/cppuhelper/compbase8.hxx|4 
 include/cppuhelper/compbase9.hxx|4 
 include/cppuhelper/compbase_ex.hxx  |4 
 include/cppuhelper/component.hxx|4 
 include/cppuhelper/component_context.hxx|4 
 include/cppuhelper/cppuhelperdllapi.h   |4 
 include/cppuhelper/exc_hlp.hxx  |4 
 include/cppuhelper/factory.hxx  |4 
 include/cppuhelper/findsofficepath.h|4 
 include/cppuhelper/implbase1.hxx|4 
 include/cppuhelper/implbase10.hxx   |4 
 include/cppuhelper/implbase11.hxx   |4 
 include/cppuhelper/implbase12.hxx   |4 
 include/cppuhelper/implbase13.hxx   |4 
 include/cppuhelper/implbase2.hxx|4 
 include/cppuhelper/implbase3.hxx|4 
 include/cppuhelper/implbase4.hxx|4 
 include/cppuhelper/implbase5.hxx|4 
 include/cppuhelper/implbase6.hxx|4 
 include/cppuhelper/implbase7.hxx|4 
 include/cppuhelper/implbase8.hxx|4 
 include/cppuhelper/implbase9.hxx|4 
 include/cppuhelper/implbase_ex.hxx  |4 
 include/cppuhelper/implbase_ex_post.hxx |4 
 include/cppuhelper/implbase_ex_pre.hxx  |4 
 include/cppuhelper/implementationentry.hxx  |4 
 include/cppuhelper/interfacecontainer.h |4 
 include/cppuhelper/interfacecontainer.hxx   |4 
 include/cppuhelper/propertysetmixin.hxx |4 
 include/cppuhelper/propshlp.hxx |4 
 include/cppuhelper/proptypehlp.h|4 
 include/cppuhelper/proptypehlp.hxx  |4 
 include/cppuhelper/queryinterface.hxx   |4 
 include/cppuhelper/shlib.hxx|4 
 include/cppuhelper/supportsservice.hxx  |4 
 include/cppuhelper/typeprovider.hxx |4 
 include/cppuhelper/unourl.hxx   |4 
 include/cppuhelper/weak.hxx |4 
 include/cppuhelper/weakagg.hxx  |4 
 include/cppuhelper/weakref.hxx  |4 
 include/osl/conditn.h   |4 
 include/osl/conditn.hxx |4 
 include/osl/diagnose.h  |3 +++
 include/osl/doublecheckedlocking.h  |4 
 include/osl/endian.h|4 
 include/osl/file.h  |4 
 include/osl/file.hxx|4 
 include/osl/getglobalmutex.hxx  |4 
 include/osl/interlck.h  |4 
 include/osl/module.h|4 
 include/osl/module.hxx  |4 
 include/osl/mutex.h |4 
 include/osl/mutex.hxx   |4 
 include/osl/nlsupport.h |3 +++
 include/osl/pipe.h  |3 +++
 include/osl/pipe.hxx|4 
 include/osl/pipe_decl.hxx   |4 
 include/osl/process.h   |3 +++
 include/osl/profile.h   |4 
 include/osl/profile.hxx |4 
 include/osl/security.h  |4 
 include/osl/security.hxx|4 
 include/osl/security_decl.hxx   |4 
 include/osl/signal.h|4 
 include/osl/socket.h|4 
 include/osl/socket.hxx  

[Libreoffice-commits] core.git: embeddedobj/source

[Caolán McNamara (via logerrit)]

 embeddedobj/source/msole/oleembed.cxx |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 2d084836102fdf3a486bd8c01f55ae0a5a673d10
Author: Caolán McNamara 
AuthorDate: Tue Feb 2 12:58:47 2021 +
Commit: Caolán McNamara 
CommitDate: Tue Feb 2 21:16:34 2021 +0100

tdf#140079 Claim support for the OleEmbeddedObject::doVerb -9 fallback

So in SfxViewFrame::GetState_Impl in case SID_OBJECT hasVerbs is not
empty, so that the doVerb attempt with -9 fallback is attempted

Change-Id: If32c50fedbc2a269ac277061c76a63514d320bb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110316
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/embeddedobj/source/msole/oleembed.cxx 
b/embeddedobj/source/msole/oleembed.cxx
index 890457af909f..926f5b9e9393 100644
--- a/embeddedobj/source/msole/oleembed.cxx
+++ b/embeddedobj/source/msole/oleembed.cxx
@@ -1004,7 +1004,12 @@ uno::Sequence< embed::VerbDescriptor > SAL_CALL 
OleEmbeddedObject::getSupportedV
 else
 #endif
 {
-return uno::Sequence< embed::VerbDescriptor >();
+// tdf#140079 Claim support for the OleEmbeddedObject::doVerb -9 
fallback.
+// So in SfxViewFrame::GetState_Impl in case SID_OBJECT hasVerbs is not
+// empty, so that the doVerb attempt with -9 fallback is attempted
+uno::Sequence aRet(1);
+aRet[0].VerbID = -9;
+return aRet;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-6.4-21'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-21' created by Andras Timar  at 
2021-02-02 20:48 +

cp-6.4-21

Changes since cp-6.4-20-46:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

[Ilmari Lauhakangas (via logerrit)]

 sw/qa/uitest/writer_tests4/spellDialog.py |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 494fb41ff71e06557293adaf2b5e064ab8c0aef5
Author: Ilmari Lauhakangas 
AuthorDate: Mon Feb 1 14:54:44 2021 +0200
Commit: László Németh 
CommitDate: Tue Feb 2 13:05:29 2021 +0100

sw: Check for supported locale in test_tdf66043 (spelling)

similar to test_tdf46852().

Change-Id: I10aada93415231a97d44413c1374d42534bb7371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110253
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sw/qa/uitest/writer_tests4/spellDialog.py 
b/sw/qa/uitest/writer_tests4/spellDialog.py
index 635a9abfb5e7..ca08f7ee488d 100644
--- a/sw/qa/uitest/writer_tests4/spellDialog.py
+++ b/sw/qa/uitest/writer_tests4/spellDialog.py
@@ -100,6 +100,9 @@ frog, dogg, catt"""
 self.assertTrue(re.match(self.TDF46852_REGEX, output_text))
 
 def test_tdf66043(self):
+supported_locale = self.is_supported_locale("en", "US")
+if not supported_locale:
+self.skipTest("no dictionary support for en_US available")
 writer_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf66043.fodt"))
 document = self.ui_test.get_component()
 # Step 1: Initiate spellchecking, and make sure "Check grammar" is
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/uiconfig

[Olivier Hallot (via logerrit)]

 dbaccess/uiconfig/ui/fielddescpage.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b1aeed14f045de442024cc5fc8c2b67b8690fb27
Author: Olivier Hallot 
AuthorDate: Mon Feb 1 15:41:31 2021 -0300
Commit: Olivier Hallot 
CommitDate: Tue Feb 2 14:03:38 2021 +0100

tdf#86871 Replace ellipsis w/ meaningful label

Change-Id: I7297d80d369e67762ebfa50fff208332a9096107
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110268
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/dbaccess/uiconfig/ui/fielddescpage.ui 
b/dbaccess/uiconfig/ui/fielddescpage.ui
index 43fc1b915186..b6b7ad90b8b2 100644
--- a/dbaccess/uiconfig/ui/fielddescpage.ui
+++ b/dbaccess/uiconfig/ui/fielddescpage.ui
@@ -169,7 +169,7 @@
 
 
   
-_...
+_Format Field
 True
 True
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/sdatabase/0501.xhp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c3c3667537da499d21c5837f880f60b9a9876add
Author: Olivier Hallot 
AuthorDate: Mon Feb 1 15:53:15 2021 -0300
Commit: Olivier Hallot 
CommitDate: Tue Feb 2 14:04:03 2021 +0100

tdf#86871 Help part. Replace ellipsis w/ text label

Change-Id: I6bf4a0aa24a3c4f0febb8e751880b5befc1b213e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110270
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sdatabase/0501.xhp 
b/source/text/sdatabase/0501.xhp
index faabb59c8..6b99be84c 100644
--- a/source/text/sdatabase/0501.xhp
+++ b/source/text/sdatabase/0501.xhp
@@ -75,10 +75,10 @@
 Specifies the value that is the default in new data 
records.
 
 Format example
-Displays the format code to assign to the field 
value that you can select with the ... button.
+Displays the format code to assign to the field 
value that you can select with the Format Field 
button.
 
-...
-This button opens the Field 
Format dialog.
+Format Field
+This button opens the Format 
Field dialog.
 
 Help area
 Displays a help string or hint defined by 
the database designer for the given field.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cabe1726796517b8f87bceb26bba23818558814a
Author: Olivier Hallot 
AuthorDate: Tue Feb 2 10:04:03 2021 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Feb 2 14:04:03 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to c3c3667537da499d21c5837f880f60b9a9876add
  - tdf#86871 Help part. Replace ellipsis w/ text label

Change-Id: I6bf4a0aa24a3c4f0febb8e751880b5befc1b213e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110270
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 61f062fa0c0f..c3c3667537da 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 61f062fa0c0f33bb2578ebf04537d3db2129c7be
+Subproject commit c3c3667537da499d21c5837f880f60b9a9876add
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx svx/source

[Noel (via logerrit)]

 include/svx/svdedtv.hxx|2 +-
 svx/source/svdraw/svdedtv2.cxx |8 
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 2ec1dab4693cd45b475f02452114dd96ec0bda1b
Author: Noel 
AuthorDate: Tue Feb 2 13:24:24 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Feb 2 16:02:29 2021 +0100

use unique_ptr in SdrEditView::ImpConvertOneObj

Change-Id: I18a796291f4c2f3b203940f474e2785580bf7d1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110291
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx
index 560f4cf19fa5..916fdaeb186b 100644
--- a/include/svx/svdedtv.hxx
+++ b/include/svx/svdedtv.hxx
@@ -125,7 +125,7 @@ protected:
 // converts an object, when positive it removes the old one from its List
 // and inserts the new one instead. including Undo.
 // Nor MarkEntry nor ModelChgBroadcast is created.
-SdrObject* ImpConvertOneObj(SdrObject* pObj, bool bPath, bool bLineToArea);
+SdrObjectUniquePtr ImpConvertOneObj(SdrObject* pObj, bool bPath, bool 
bLineToArea);
 
 // set both flags: bToTopPossible and bToBtmPossible.
 // bToTopPossibleDirty and bToBtmPossibleDirty are reset at the same time
diff --git a/svx/source/svdraw/svdedtv2.cxx b/svx/source/svdraw/svdedtv2.cxx
index 9dd795bb632b..06cf4cdc06d3 100644
--- a/svx/source/svdraw/svdedtv2.cxx
+++ b/svx/source/svdraw/svdedtv2.cxx
@@ -1971,7 +1971,7 @@ void SdrEditView::UnGroupMarked()
 // ConvertToPoly
 
 
-SdrObject* SdrEditView::ImpConvertOneObj(SdrObject* pObj, bool bPath, bool 
bLineToArea)
+SdrObjectUniquePtr SdrEditView::ImpConvertOneObj(SdrObject* pObj, bool bPath, 
bool bLineToArea)
 {
 SdrObjectUniquePtr pNewObj = pObj->ConvertToPolyObj(bPath, bLineToArea);
 if (pNewObj)
@@ -1986,7 +1986,7 @@ SdrObject* SdrEditView::ImpConvertOneObj(SdrObject* pObj, 
bool bPath, bool bLine
 if( !bUndo )
 SdrObject::Free(pObj);
 }
-return pNewObj.release();
+return pNewObj;
 }
 
 void SdrEditView::ImpConvertTo(bool bPath, bool bLineToArea)
@@ -2030,10 +2030,10 @@ void SdrEditView::ImpConvertTo(bool bPath, bool 
bLineToArea)
 ImpConvertOneObj(pObj,bPath,bLineToArea);
 }
 } else {
-SdrObject* pNewObj=ImpConvertOneObj(pObj,bPath,bLineToArea);
+SdrObjectUniquePtr 
pNewObj=ImpConvertOneObj(pObj,bPath,bLineToArea);
 if (pNewObj!=nullptr) {
 bMrkChg=true;
-
GetMarkedObjectListWriteAccess().ReplaceMark(SdrMark(pNewObj,pPV),nm);
+
GetMarkedObjectListWriteAccess().ReplaceMark(SdrMark(pNewObj.release(),pPV),nm);
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/timar/fontconfigcrash' - 0 commits -

[(via logerrit)]

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/inc starmath/source

[dante (via logerrit)]

 starmath/inc/node.hxx|4 
 starmath/source/node.cxx |   14 ++
 2 files changed, 18 insertions(+)

New commits:
commit 15a02261047cc60f3e080e74697bd88127124a03
Author: dante 
AuthorDate: Tue Feb 2 16:20:28 2021 +0100
Commit: Noel Grandin 
CommitDate: Tue Feb 2 20:53:02 2021 +0100

Support patch for starmath syntax hightlight

Starmath syntax hightlight has dependences on node classes.
But those classes are whidely used.
So for avoiding future merge conflicts it should be merged separetely 
because syntax hightlight won't be merged soon.

Change-Id: Ifaf33cd67c9ea0d5cfffaad787ce5fabc1447a65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110325
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index 988a1024332a..d0b81737a31d 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -134,6 +134,10 @@ enum class SmNodeType
 /*25*/ Rectangle,   VerticalBrace, MathIdent
 };
 
+namespace starmathdatabase
+{
+bool isStructuralNode(SmNodeType ntype);
+}
 
 class SmNode : public SmRect
 {
diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 4de696dcabfa..e15d72312592 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -40,6 +40,20 @@
 #include 
 #include 
 
+bool starmathdatabase::isStructuralNode(SmNodeType ntype)
+{
+// clang-format off
+return ntype==SmNodeType::Table || ntype==SmNodeType::Line|| 
ntype==SmNodeType::UnHor
+|| ntype==SmNodeType::BinHor  || 
ntype==SmNodeType::BinVer
+|| ntype==SmNodeType::BinDiagonal || 
ntype==SmNodeType::SubSup
+|| ntype==SmNodeType::Matrix  || 
ntype==SmNodeType::Root
+|| ntype==SmNodeType::Expression  || 
ntype==SmNodeType::Brace
+|| ntype==SmNodeType::Bracebody   || 
ntype==SmNodeType::Oper
+|| ntype==SmNodeType::Align   || 
ntype==SmNodeType::Attribut
+|| ntype==SmNodeType::Font;
+// clang-format on
+}
+
 namespace {
 
 template
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/uicalc/data/tdf97215.ods |binary
 sc/qa/unit/uicalc/uicalc.cxx|   33 +
 2 files changed, 33 insertions(+)

New commits:
commit e99608ce752f34ddb6611146c6cf4643c97d62f3
Author: Xisco Fauli 
AuthorDate: Tue Feb 2 16:39:59 2021 +0100
Commit: Xisco Fauli 
CommitDate: Tue Feb 2 21:26:32 2021 +0100

tdf#97215: sc_uicalc: Add unittest

Change-Id: I829021d0ab5619317d831986309cab577499f278
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110326
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/uicalc/data/tdf97215.ods 
b/sc/qa/unit/uicalc/data/tdf97215.ods
new file mode 100644
index ..e6b01a67b324
Binary files /dev/null and b/sc/qa/unit/uicalc/data/tdf97215.ods differ
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 2d8d6389f907..5c42f7c61db4 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -140,6 +140,39 @@ ScModelObj* ScUiCalcTest::createDoc(const char* pName)
 return pModelObj;
 }
 
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf97215)
+{
+ScModelObj* pModelObj = createDoc("tdf97215.ods");
+ScDocument* pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+// Enable sorting with update reference
+ScModule* pMod = SC_MOD();
+ScInputOptions aInputOption = pMod->GetInputOptions();
+bool bOldStatus = aInputOption.GetSortRefUpdate();
+aInputOption.SetSortRefUpdate(true);
+pMod->SetInputOptions(aInputOption);
+
+CPPUNIT_ASSERT_EQUAL(OUString("Inserted at bottom"), 
pDoc->GetString(ScAddress(0, 23, 0)));
+
+goToCell("A1:M24");
+
+// Without the fix in place, this test would have hung here
+dispatchCommand(mxComponent, ".uno:SortAscending", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(OUString("Inserted at bottom"), 
pDoc->GetString(ScAddress(0, 0, 0)));
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(OUString("Inserted at bottom"), 
pDoc->GetString(ScAddress(0, 23, 0)));
+
+// Restore previous status
+aInputOption.SetSortRefUpdate(bOldStatus);
+pMod->SetInputOptions(aInputOption);
+}
+
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf92963)
 {
 ScModelObj* pModelObj = createDoc("tdf92963.ods");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - configure.ac

[Andras Timar (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 15f031f75ed3c4940d591bb005d6197894fd14ef
Author: Andras Timar 
AuthorDate: Tue Feb 2 21:48:22 2021 +0100
Commit: Andras Timar 
CommitDate: Tue Feb 2 21:48:22 2021 +0100

Bump version to 6.4-21

Change-Id: I185ab191a54a7d93f785031e5380e1bfecdefa9a

diff --git a/configure.ac b/configure.ac
index c03c41e77eaf..8dc97511c0f0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[6.4.10.20],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[6.4.10.21],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-6.4-21'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-21' created by Andras Timar  at 
2021-02-02 20:48 +

cp-6.4-21

Changes since cp-6.4-branch-point-11:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-6.4-21'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-21' created by Andras Timar  at 
2021-02-02 20:48 +

cp-6.4-21

Changes since co-6.4-20:
Andras Timar (1):
  update Danish dictionary

---
 da_DK/README_da_DK.txt |4 
 da_DK/da_DK.aff| 3401 
 da_DK/da_DK.dic|288016 
+++--
 da_DK/description.xml  |9 
 4 files changed, 139245 insertions(+), 152185 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-6.4-21'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-21' created by Andras Timar  at 
2021-02-02 20:48 +

cp-6.4-21

Changes since cp-6.4-15-1:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx svx/source

[Noel (via logerrit)]

 include/svx/svdedxv.hxx   |2 +-
 svx/source/svdraw/svdedxv.cxx |7 ---
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 85c5c168f00bb1f8571834587f3693efdfc2e4b3
Author: Noel 
AuthorDate: Tue Feb 2 13:28:54 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Feb 2 18:41:51 2021 +0100

use unique_ptr in ImpHandleMotionThroughBoxesKeyInput

Change-Id: Ieccf70ca52a639204cd576449c0d89c3419835fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110312
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdedxv.hxx b/include/svx/svdedxv.hxx
index 35c4be3282c1..36763ea01656 100644
--- a/include/svx/svdedxv.hxx
+++ b/include/svx/svdedxv.hxx
@@ -116,7 +116,7 @@ protected:
 virtual SdrUndoManager* getSdrUndoManagerForEnhancedTextEdit() const;
 
 void ImpMoveCursorAfterChainingEvent(TextChainCursorManager 
*pCursorManager);
-TextChainCursorManager *ImpHandleMotionThroughBoxesKeyInput(const 
KeyEvent& rKEvt, bool *bOutHandled);
+std::unique_ptr 
ImpHandleMotionThroughBoxesKeyInput(const KeyEvent& rKEvt, bool *bOutHandled);
 
 
 OutlinerView* ImpFindOutlinerView(vcl::Window const * pWin) const;
diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx
index 75190e09072c..a066f62d4471 100644
--- a/svx/source/svdraw/svdedxv.cxx
+++ b/svx/source/svdraw/svdedxv.cxx
@@ -1766,8 +1766,8 @@ bool SdrObjEditView::IsTextEditFrameHit(const Point& 
rHit) const
 return bOk;
 }
 
-TextChainCursorManager* 
SdrObjEditView::ImpHandleMotionThroughBoxesKeyInput(const KeyEvent& rKEvt,
-
bool* bOutHandled)
+std::unique_ptr
+SdrObjEditView::ImpHandleMotionThroughBoxesKeyInput(const KeyEvent& rKEvt, 
bool* bOutHandled)
 {
 *bOutHandled = false;
 
@@ -1778,7 +1778,8 @@ TextChainCursorManager* 
SdrObjEditView::ImpHandleMotionThroughBoxesKeyInput(cons
 if (!pTextObj->GetNextLinkInChain() && !pTextObj->GetPrevLinkInChain())
 return nullptr;
 
-TextChainCursorManager* pCursorManager = new TextChainCursorManager(this, 
pTextObj);
+std::unique_ptr pCursorManager(
+new TextChainCursorManager(this, pTextObj));
 if (pCursorManager->HandleKeyEvent(rKEvt))
 {
 // Possibly do other stuff here if necessary...
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source include/editeng offapi/com sw/inc sw/source

[Miklos Vajna (via logerrit)]

 editeng/source/items/frmitems.cxx|9 +
 include/editeng/memberids.h  |1 +
 offapi/com/sun/star/style/PageProperties.idl |7 +++
 sw/inc/unoprnms.hxx  |1 +
 sw/source/core/unocore/unomap1.cxx   |1 +
 5 files changed, 19 insertions(+)

New commits:
commit 947277146e4c1ff7544371095fcc6bd5842b2d98
Author: Miklos Vajna 
AuthorDate: Tue Feb 2 15:49:16 2021 +0100
Commit: Miklos Vajna 
CommitDate: Tue Feb 2 19:30:33 2021 +0100

sw page gutter margin: add UNO API

SvxLRSpaceItem is used for all sorts of left/right margins, but gutter
only makes sense for pages, so only expose the gutter margin in the page
properties.

Change-Id: Icfca2499e944081b70bbdbc4c62e78cade25f5c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110322
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index e1520735d804..c6b26c1c03a5 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -372,6 +372,11 @@ bool SvxLRSpaceItem::QueryValue( uno::Any& rVal, sal_uInt8 
nMemberId ) const
 rVal <<= IsAutoFirst();
 break;
 
+case MID_GUTTER_MARGIN:
+rVal <<= static_cast(bConvert ? 
convertTwipToMm100(m_nGutterMargin)
+ : m_nGutterMargin);
+break;
+
 default:
 bRet = false;
 // SfxDispatchController_Impl::StateChanged calls this with 
hardcoded 0 triggering this; there used to be a MID_LR_MARGIN 0 but what type 
would it have?
@@ -447,6 +452,10 @@ bool SvxLRSpaceItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 SetAutoFirst( Any2Bool(rVal) );
 break;
 
+case MID_GUTTER_MARGIN:
+SetGutterMargin(bConvert ? convertMm100ToTwip(nVal) : nVal);
+break;
+
 default:
 OSL_FAIL("unknown MemberId");
 return false;
diff --git a/include/editeng/memberids.h b/include/editeng/memberids.h
index a857d7593afb..8a6c9d0e7769 100644
--- a/include/editeng/memberids.h
+++ b/include/editeng/memberids.h
@@ -129,6 +129,7 @@
 #define MID_FIRST_LINE_REL_INDENT   9
 #define MID_FIRST_AUTO  10
 #define MID_TXT_LMARGIN 11
+#define MID_GUTTER_MARGIN 12
 
 //ProtectItem
 #define MID_PROTECT_CONTENT 0
diff --git a/offapi/com/sun/star/style/PageProperties.idl 
b/offapi/com/sun/star/style/PageProperties.idl
index 73242f230f90..dccd63f20b04 100644
--- a/offapi/com/sun/star/style/PageProperties.idl
+++ b/offapi/com/sun/star/style/PageProperties.idl
@@ -487,6 +487,13 @@ published service PageProperties
 @since LibreOffice 6.1
  */
 [optional, property, maybevoid] com::sun::star::graphic::XGraphic 
FooterBackGraphic;
+
+/** determines the gutter margin of the page.
+
+@since LibreOffice 7.2
+ */
+[optional, property] long GutterMargin;
+
 };
 
 }; }; }; };
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index 8fc67fdf5206..9cceac0f8d0f 100644
--- a/sw/inc/unoprnms.hxx
+++ b/sw/inc/unoprnms.hxx
@@ -66,6 +66,7 @@
 #define UNO_NAME_PARA_HYPHENATION_NO_CAPS "ParaHyphenationNoCaps"
 #define UNO_NAME_LEFT_MARGIN "LeftMargin"
 #define UNO_NAME_RIGHT_MARGIN "RightMargin"
+#define UNO_NAME_GUTTER_MARGIN "GutterMargin"
 #define UNO_NAME_HEADER_LEFT_MARGIN "HeaderLeftMargin"
 #define UNO_NAME_HEADER_RIGHT_MARGIN "HeaderRightMargin"
 #define UNO_NAME_FOOTER_LEFT_MARGIN "FooterLeftMargin"
diff --git a/sw/source/core/unocore/unomap1.cxx 
b/sw/source/core/unocore/unomap1.cxx
index d3fb8b909608..253da09f67f1 100644
--- a/sw/source/core/unocore/unomap1.cxx
+++ b/sw/source/core/unocore/unomap1.cxx
@@ -445,6 +445,7 @@ const SfxItemPropertyMapEntry*  
SwUnoPropertyMapProvider::GetPageStylePropertyMa
 { u"" UNO_NAME_BACK_GRAPHIC_LOCATION, RES_BACKGROUND, 
cppu::UnoType::get(), PROPERTY_NONE 
,MID_GRAPHIC_POSITION},
 { u"" UNO_NAME_LEFT_MARGIN, RES_LR_SPACE, 
cppu::UnoType::get(), PROPERTY_NONE, MID_L_MARGIN|CONVERT_TWIPS},
 { u"" UNO_NAME_RIGHT_MARGIN, RES_LR_SPACE,
cppu::UnoType::get(), PROPERTY_NONE, MID_R_MARGIN|CONVERT_TWIPS},
+{ u"" UNO_NAME_GUTTER_MARGIN, RES_LR_SPACE, 
cppu::UnoType::get(), PROPERTY_NONE, MID_GUTTER_MARGIN | 
CONVERT_TWIPS},
 { u"" UNO_NAME_BACK_TRANSPARENT, RES_BACKGROUND,  
cppu::UnoType::get(), PROPERTY_NONE ,MID_GRAPHIC_TRANSPARENT  
 },
 { u"" UNO_NAME_LEFT_BORDER, RES_BOX,  
cppu::UnoType::get(),  0, LEFT_BORDER  |CONVERT_TWIPS },
 { u"" UNO_NAME_RIGHT_BORDER, RES_BOX, 
cppu::UnoType::get(),  0, RIGHT_BORDER |CONVERT_TWIPS },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - desktop/qa sw/source

[Henry Castro (via logerrit)]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |   36 
 sw/source/uibase/docvw/AnnotationWin2.cxx   |5 ---
 2 files changed, 41 deletions(-)

New commits:
commit 7a9b6456227c2a54b0b23cfc18679883b638e969
Author: Henry Castro 
AuthorDate: Tue Feb 2 11:57:23 2021 -0400
Commit: Andras Timar 
CommitDate: Tue Feb 2 20:02:23 2021 +0100

lok: remove annotation viewshell notifier

Unfortunately the Annotation window sends cursor position
to client side and it causes horrible effects like
scrolling document due to different coordinates with the
document.

This patch will disable any notification to client side,
also it removes a unit test related to check annotation
cursor position.

Change-Id: Ib432ef020c48bb1a9c82acc43ffccdb4230589c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110328
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 4f708dfe76c5..af9b93620351 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -199,7 +199,6 @@ public:
 void testTrackChanges();
 void testRedlineCalc();
 void testPaintPartTile();
-void testWriterCommentInsertCursor();
 #if HAVE_MORE_FONTS
 void testGetFontSubset();
 #endif
@@ -261,7 +260,6 @@ public:
 CPPUNIT_TEST(testTrackChanges);
 CPPUNIT_TEST(testRedlineCalc);
 CPPUNIT_TEST(testPaintPartTile);
-CPPUNIT_TEST(testWriterCommentInsertCursor);
 #if HAVE_MORE_FONTS
 CPPUNIT_TEST(testGetFontSubset);
 #endif
@@ -2064,40 +2062,6 @@ void DesktopLOKTest::testPaintPartTile()
 //CPPUNIT_ASSERT(aView1.m_bTilesInvalidated);
 }
 
-void DesktopLOKTest::testWriterCommentInsertCursor()
-{
-// Load a document and type a character into the body text of the second 
view.
-LibLODocument_Impl* pDocument = loadDoc("blank_text.odt");
-pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
-ViewCallback aView1(pDocument);
-pDocument->m_pDocumentClass->createView(pDocument);
-pDocument->m_pDocumentClass->initializeForRendering(pDocument, "{}");
-ViewCallback aView2(pDocument);
-pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 'x', 0);
-pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
'x', 0);
-Scheduler::ProcessEventsToIdle();
-tools::Rectangle aBodyCursor = aView2.m_aOwnCursor;
-
-// Now insert a comment and make sure that the comment's cursor is shown,
-// not the body text's one.
-aView1.m_aOwnCursor.SetEmpty();
-const int nCtrlAltC = KEY_MOD1 + KEY_MOD2 + 512 + 'c' - 'a';
-pDocument->m_pDocumentClass->postKeyEvent(pDocument, 
LOK_KEYEVENT_KEYINPUT, 'c', nCtrlAltC);
-pDocument->m_pDocumentClass->postKeyEvent(pDocument, LOK_KEYEVENT_KEYUP, 
'c', nCtrlAltC);
-Scheduler::ProcessEventsToIdle();
-// Wait for SfxBindings to actually update the state, which updated the
-// cursor as well.
-osl::Thread::wait(std::chrono::seconds(1));
-Scheduler::ProcessEventsToIdle();
-// This failed: the body cursor was shown right after inserting a comment.
-CPPUNIT_ASSERT(aView2.m_aOwnCursor.getX() > aBodyCursor.getX());
-// This failed, the first view's cursor also jumped when the second view
-// inserted the comment.
-CPPUNIT_ASSERT(aView1.m_aOwnCursor.IsEmpty());
-
-Scheduler::ProcessEventsToIdle();
-}
-
 #if HAVE_MORE_FONTS
 void DesktopLOKTest::testGetFontSubset()
 {
diff --git a/sw/source/uibase/docvw/AnnotationWin2.cxx 
b/sw/source/uibase/docvw/AnnotationWin2.cxx
index 63cab37214b2..b3d976ddf850 100644
--- a/sw/source/uibase/docvw/AnnotationWin2.cxx
+++ b/sw/source/uibase/docvw/AnnotationWin2.cxx
@@ -934,11 +934,6 @@ void SwAnnotationWin::DoResize()
 
 mpOutliner->SetPaperSize( PixelToLogic( Size(aWidth,aHeight) ) ) ;
 
-if (comphelper::LibreOfficeKit::isActive() && 
!mpOutlinerView->GetViewShell())
-{
-mpOutlinerView->RegisterViewShell();
-}
-
 if (!mpVScrollbar->IsVisible())
 {   // if we do not have a scrollbar anymore, we want to see the complete 
text
 mpOutlinerView->SetVisArea( PixelToLogic( 
tools::Rectangle(0,0,aWidth,aHeight) ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/source

[dante (via logerrit)]

 starmath/source/parse.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 213752056fd8fcf75819a4e3dee716ea2bcefbbd
Author: dante 
AuthorDate: Mon Feb 1 19:55:07 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Feb 2 18:27:47 2021 +0100

Addition of hex command

I forgot to add it while working on color, internals already done.
It's the line of code which allows users to use the command.

Change-Id: I3f58e24b2ca795a46e0f8edb20c971816c9fdcdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110271
Tested-by: Stephan Bergmann 
Reviewed-by: Stephan Bergmann 

diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 0f3101450023..340bc465828b 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -117,6 +117,7 @@ const SmTokenTableEntry aTokenTable[] =
 { u"harpoon", THARPOON, MS_HARPOON, TG::Attribute, 5},
 { u"hat", THAT, MS_HAT, TG::Attribute, 5},
 { u"hbar" , THBAR, MS_HBAR, TG::Standalone, 5},
+{ u"hex" , THEX, '\0', TG::NONE, 5},
 { u"iiint", TIIINT, MS_IIINT, TG::Oper, 5},
 { u"iint", TIINT, MS_IINT, TG::Oper, 5},
 { u"im" , TIM, MS_IM, TG::Standalone, 5 },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - include/sfx2 include/svtools sfx2/source svtools/inc

[Samuel Mehrbrodt (via logerrit)]

 include/sfx2/docmacromode.hxx|7 +--
 include/svtools/sfxecode.hxx |1 +
 sfx2/source/doc/docmacromode.cxx |   23 +++
 sfx2/source/doc/objmisc.cxx  |5 +++--
 svtools/inc/errtxt.hrc   |1 +
 5 files changed, 29 insertions(+), 8 deletions(-)

New commits:
commit 91cf71e27e7a317b002697b1e54b749599e1d982
Author: Samuel Mehrbrodt 
AuthorDate: Mon Jan 18 15:24:48 2021 +0100
Commit: Andras Timar 
CommitDate: Tue Feb 2 20:08:53 2021 +0100

Improve macro checks

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb)

Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110076
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/include/sfx2/docmacromode.hxx b/include/sfx2/docmacromode.hxx
index a15bbbe9ba56..bd4f13fb016c 100644
--- a/include/sfx2/docmacromode.hxx
+++ b/include/sfx2/docmacromode.hxx
@@ -220,7 +220,8 @@ namespace sfx2
  if and only if macro execution in this document is 
allowed.
 */
 booladjustMacroMode(
-const css::uno::Reference< css::task::XInteractionHandler 
>& _rxInteraction
+const css::uno::Reference< css::task::XInteractionHandler 
>& _rxInteraction,
+bool bHasValidContentSignature = false
 );
 
 /** determines whether macro execution is disallowed
@@ -286,11 +287,13 @@ namespace sfx2
 */
 bool
 checkMacrosOnLoading(
-const css::uno::Reference< css::task::XInteractionHandler 
>& _rxInteraction
+const css::uno::Reference< css::task::XInteractionHandler 
>& _rxInteraction,
+bool bHasValidContentSignature = false
 );
 
 private:
 std::shared_ptr< DocumentMacroMode_Data >   m_xData;
+bool m_bNeedsContentSigned;
 };
 
 
diff --git a/include/svtools/sfxecode.hxx b/include/svtools/sfxecode.hxx
index 3cdad87f4cd9..ccdccae9014b 100644
--- a/include/svtools/sfxecode.hxx
+++ b/include/svtools/sfxecode.hxx
@@ -37,6 +37,7 @@ class ErrCode;
 #define ERRCODE_SFX_CANTCREATEBACKUPErrCode(ErrCodeArea::Sfx, 
ErrCodeClass::Create, 50)
 #define ERRCODE_SFX_MACROS_SUPPORT_DISABLED ErrCode(WarningFlag::Yes, 
ErrCodeArea::Sfx, ErrCodeClass::NONE, 51)
 #define ERRCODE_SFX_DOCUMENT_MACRO_DISABLED ErrCode(WarningFlag::Yes, 
ErrCodeArea::Sfx, ErrCodeClass::NONE, 52)
+#define ERRCODE_SFX_DOCUMENT_MACRO_DISABLED_CONTENT_UNSIGNED 
ErrCode(WarningFlag::Yes, ErrCodeArea::Sfx, ErrCodeClass::NONE, 53)
 #define ERRCODE_SFX_SHARED_NOPASSWORDCHANGE ErrCode(WarningFlag::Yes, 
ErrCodeArea::Sfx, ErrCodeClass::NONE, 54)
 #define ERRCODE_SFX_INCOMPLETE_ENCRYPTION   ErrCode(WarningFlag::Yes, 
ErrCodeArea::Sfx, ErrCodeClass::NONE, 55)
 #define ERRCODE_SFX_DOCUMENT_MACRO_DISABLED_MAC \
diff --git a/sfx2/source/doc/docmacromode.cxx b/sfx2/source/doc/docmacromode.cxx
index 492bd0a63009..2fa7b968fc41 100644
--- a/sfx2/source/doc/docmacromode.cxx
+++ b/sfx2/source/doc/docmacromode.cxx
@@ -113,6 +113,10 @@ namespace sfx2
 #endif
 }
 
+void lcl_showMacrosDisabledUnsignedContentError( const Reference< 
XInteractionHandler >& rxHandler, bool& rbAlreadyShown )
+{
+lcl_showGeneralSfxErrorOnce( rxHandler, 
ERRCODE_SFX_DOCUMENT_MACRO_DISABLED_CONTENT_UNSIGNED, rbAlreadyShown );
+}
 
 bool lcl_showMacroWarning( const Reference< XInteractionHandler >& 
rxHandler,
 const OUString& rDocumentLocation )
@@ -125,7 +129,8 @@ namespace sfx2
 
 //= DocumentMacroMode
 DocumentMacroMode::DocumentMacroMode( IMacroDocumentAccess& 
rDocumentAccess )
-:m_xData( new DocumentMacroMode_Data( rDocumentAccess ) )
+:m_xData( new DocumentMacroMode_Data( rDocumentAccess ) ),
+m_bNeedsContentSigned(false)
 {
 }
 
@@ -141,7 +146,7 @@ namespace sfx2
 return false;
 }
 
-bool DocumentMacroMode::adjustMacroMode( const Reference< 
XInteractionHandler >& rxInteraction )
+bool DocumentMacroMode::adjustMacroMode( const Reference< 
XInteractionHandler >& rxInteraction, bool bHasValidContentSignature )
 {
 sal_uInt16 nMacroExecutionMode = 
m_xData->m_rDocumentAccess.getCurrentMacroExecMode();
 
@@ -238,6 +243,14 @@ namespace sfx2
 lcl_showDocumentMacrosDisabledError(rxInteraction, 
m_xData->m_bDocMacroDisabledMessageShown);
 return disallowMacroExecution();
 }
+else if ( 
m_xData->m_rDocumentAccess.macroCallsSeenWhileLoading() &&
+  bHasTrustedMacroSignature &&
+  !bHasValidContentSignature)
+{
+// When macros are signed, and the 

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

[Regina Henschel (via logerrit)]

 sc/inc/document.hxx |3 
 sc/inc/drwlayer.hxx |   14 +
 sc/inc/table.hxx|4 
 sc/qa/unit/data/ods/tdf137081_RTL_page_anchored.ods |binary
 sc/qa/unit/data/ods/tdf137082_LTR_arrow_image.ods   |binary
 sc/qa/unit/data/ods/tdf137082_RTL_cell_anchored.ods |binary
 sc/qa/unit/scshapetest.cxx  |  155 +++
 sc/source/core/data/documen9.cxx|4 
 sc/source/core/data/document.cxx|   14 -
 sc/source/core/data/drwlayer.cxx|  162 +---
 sc/source/core/data/table2.cxx  |6 
 sc/source/filter/xml/xmlexprt.cxx   |   78 ++---
 sc/source/ui/docshell/docfunc.cxx   |2 
 sc/source/ui/undo/undotab.cxx   |2 
 14 files changed, 375 insertions(+), 69 deletions(-)

New commits:
commit 65129e0bc5abfe7afc612eb46f1434e627265a7d
Author: Regina Henschel 
AuthorDate: Tue Jan 26 14:28:40 2021 +0100
Commit: Regina Henschel 
CommitDate: Tue Feb 2 22:06:18 2021 +0100

tdf#137081, tdf137082 fixes shape handling in RTL sheets

The patch introduces an enum ScObjectHandling as parameter of
ScDrawLayer::SetPageSize to distinguish page size changes from show or
hide col/row from changes because of sheet flip for RTL.

RTL is now handled this way: On save/reload objects are not mirrored
but only shifted between positive and negative part of draw page. When
a user flips sheet to RTL or back, the objects are mirrored.

The 'noRotate' anchor is set to this meaning: maShapeRect contains the
logic rectangle of the object at time the anchor was created. It is
used to detect position relevant object changes in ScDrawView::Notify().
maStart contains the address of that cell, which is parent element of
the object in xml. The logic rectangle need not be in that cell.

Handling of DetectiveArrow and CellNote is not changed. Validation
circles were not drawn, when switching to RTL mode (no bug report).
That is fixed.

SetVisualCellAnchored handles 'noRotate' anchor. That anchor is not
visible on screen. I have changed the misleading name to
SetNonRotatedAnchor.

Change-Id: I3dd2d3e37c138c8418369c760293a1f19dddb753
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109959
Reviewed-by: Regina Henschel 
Tested-by: Regina Henschel 

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index a8bfba521437..79091e89504c 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -53,6 +53,7 @@
 #include 
 
 #include "markdata.hxx"
+#include "drwlayer.hxx"
 
 namespace com::sun::star::chart2 { class XChartDocument; }
 
@@ -963,7 +964,7 @@ public:
 boolIsStreamValidLocked() const { return 
mbStreamValidLocked; }
 boolIsPendingRowHeights( SCTAB nTab ) const;
 voidSetPendingRowHeights( SCTAB nTab, bool bSet );
-SC_DLLPUBLIC void   SetLayoutRTL( SCTAB nTab, bool bRTL );
+SC_DLLPUBLIC void   SetLayoutRTL( SCTAB nTab, bool bRTL, 
ScObjectHandling eObjectHandling = ScObjectHandling::RecalcPosMode);
 SC_DLLPUBLIC bool   IsLayoutRTL( SCTAB nTab ) const;
 SC_DLLPUBLIC bool   IsNegativePage( SCTAB nTab ) const;
 SC_DLLPUBLIC void   SetScenario( SCTAB nTab, bool bFlag );
diff --git a/sc/inc/drwlayer.hxx b/sc/inc/drwlayer.hxx
index 030fd3855ec8..008e56f8b8c6 100644
--- a/sc/inc/drwlayer.hxx
+++ b/sc/inc/drwlayer.hxx
@@ -86,6 +86,14 @@ public:
 virtual void Redo() override;
 };
 
+// for ScDrawLayer::SetPageSize
+enum class ScObjectHandling
+{
+RecalcPosMode, // used for row height or col width changes
+MoveRTLMode, // used for switch to RTL during import of right-to-left sheet
+MirrorRTLMode // used for switch between RTL and LTR by 
.uno:SheetRightToLeft
+};
+
 class SC_DLLPUBLIC ScDrawLayer final : public FmFormModel
 {
 private:
@@ -150,10 +158,12 @@ public:
 SCTAB nSourceTab, const tools::Rectangle& 
rSourceRange,
 const ScAddress& rDestPos, const 
tools::Rectangle& rDestRange );
 
-voidSetPageSize( sal_uInt16 nPageNo, const Size& rSize, bool 
bUpdateNoteCaptionPos );
+voidSetPageSize(sal_uInt16 nPageNo, const Size& rSize, bool 
bUpdateNoteCaptionPos,
+const ScObjectHandling eObjectHandling = 
ScObjectHandling::RecalcPosMode);
 
 //  mirror or move between positive and negative positions 
for RTL
 voidMirrorRTL( SdrObject* pObj );
+voidMoveRTL(SdrObject* pObj);
 static void MirrorRectRTL( tools::Rectangle& rRect );  // for 
bounding rectangles etc.
 
 /** Returns the rectangle for the 

[Libreoffice-commits] core.git: sc/CppunitTest_sc_uicalc.mk sc/qa

[Xisco Fauli (via logerrit)]

 sc/CppunitTest_sc_uicalc.mk  |1 
 sc/qa/unit/uicalc/data/tdf100582.xls |binary
 sc/qa/unit/uicalc/uicalc.cxx |   72 +++
 3 files changed, 73 insertions(+)

New commits:
commit 8c355246fdfb3fa021d213d65f8fb24dc01843ee
Author: Xisco Fauli 
AuthorDate: Tue Feb 2 22:02:41 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Feb 3 00:09:17 2021 +0100

tdf#100582: sc_uicalc: Add unittest

Change-Id: Icad48707d4806cb1fbc2de160059c199fceeda78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110334
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/CppunitTest_sc_uicalc.mk b/sc/CppunitTest_sc_uicalc.mk
index 4c1f99d87ddd..82bfb875b05e 100644
--- a/sc/CppunitTest_sc_uicalc.mk
+++ b/sc/CppunitTest_sc_uicalc.mk
@@ -27,6 +27,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sc_uicalc, \
 test \
 tl \
 unotest \
+utl \
 vcl \
 ))
 
diff --git a/sc/qa/unit/uicalc/data/tdf100582.xls 
b/sc/qa/unit/uicalc/data/tdf100582.xls
new file mode 100644
index ..24886a2fe605
Binary files /dev/null and b/sc/qa/unit/uicalc/data/tdf100582.xls differ
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 5c42f7c61db4..bb038104a60f 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -39,6 +40,8 @@ public:
 virtual void tearDown() override;
 
 ScModelObj* createDoc(const char* pName);
+ScModelObj* saveAndReload(css::uno::Reference& 
xComponent,
+  const OUString& rFilter);
 void goToCell(const OUString& rCell);
 void insertStringToCell(ScModelObj& rModelObj, const OUString& rCell, 
const std::string& rStr,
 bool bIsArray = false);
@@ -140,6 +143,75 @@ ScModelObj* ScUiCalcTest::createDoc(const char* pName)
 return pModelObj;
 }
 
+ScModelObj* 
ScUiCalcTest::saveAndReload(css::uno::Reference& 
xComponent,
+const OUString& rFilter)
+{
+utl::TempFile aTempFile;
+aTempFile.EnableKillingFile();
+css::uno::Sequence aArgs(1);
+aArgs[0].Name = "FilterName";
+aArgs[0].Value <<= rFilter;
+css::uno::Reference xStorable(xComponent, 
css::uno::UNO_QUERY_THROW);
+xStorable->storeAsURL(aTempFile.GetURL(), aArgs);
+css::uno::Reference xCloseable(xComponent, 
css::uno::UNO_QUERY_THROW);
+xCloseable->close(true);
+
+mxComponent = loadFromDesktop(aTempFile.GetURL(), 
"com.sun.star.sheet.SpreadsheetDocument");
+
+ScModelObj* pModelObj = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pModelObj);
+return pModelObj;
+}
+
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf100582)
+{
+ScModelObj* pModelObj = createDoc("tdf100582.xls");
+ScDocument* pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+// Disable replace cell warning
+ScModule* pMod = SC_MOD();
+ScInputOptions aInputOption = pMod->GetInputOptions();
+bool bOldStatus = aInputOption.GetReplaceCellsWarn();
+aInputOption.SetReplaceCellsWarn(false);
+pMod->SetInputOptions(aInputOption);
+
+goToCell("C10");
+
+ScDocument aClipDoc(SCDOCMODE_CLIP);
+ScDocShell::GetViewData()->GetView()->CopyToClip(, false, false, 
false, false);
+Scheduler::ProcessEventsToIdle();
+
+goToCell("C10:H14");
+
+
ScDocShell::GetViewData()->GetView()->PasteFromClip(InsertDeleteFlags::ALL, 
);
+Scheduler::ProcessEventsToIdle();
+
+pModelObj = saveAndReload(mxComponent, "MS Excel 97");
+pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+OUString aFormula;
+pDoc->GetFormula(3, 10, 0, aFormula);
+
+// Without the fix in place, this test would have failed with
+// - Expected: {=SUM(($B$3:$B$7=$B11)*(D$3:D$7))}
+//- Actual  :
+CPPUNIT_ASSERT_EQUAL(OUString("{=SUM(($B$3:$B$7=$B11)*(D$3:D$7))}"), 
aFormula);
+pDoc->GetFormula(4, 10, 0, aFormula);
+CPPUNIT_ASSERT_EQUAL(OUString("{=SUM(($B$3:$B$7=$B11)*(E$3:E$7))}"), 
aFormula);
+pDoc->GetFormula(5, 10, 0, aFormula);
+CPPUNIT_ASSERT_EQUAL(OUString("{=SUM(($B$3:$B$7=$B11)*(F$3:F$7))}"), 
aFormula);
+pDoc->GetFormula(6, 10, 0, aFormula);
+CPPUNIT_ASSERT_EQUAL(OUString("{=SUM(($B$3:$B$7=$B11)*(G$3:G$7))}"), 
aFormula);
+pDoc->GetFormula(7, 10, 0, aFormula);
+CPPUNIT_ASSERT_EQUAL(OUString("{=SUM(($B$3:$B$7=$B11)*(H$3:H$7))}"), 
aFormula);
+
+// Restore previous status
+aInputOption.SetReplaceCellsWarn(bOldStatus);
+pMod->SetInputOptions(aInputOption);
+}
+
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf97215)
 {
 ScModelObj* pModelObj = createDoc("tdf97215.ods");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Andrea Gelmini (via logerrit)]

 sc/source/filter/excel/xelink.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 649707cc58c2be1cabb91dad5210895ad22a442a
Author: Andrea Gelmini 
AuthorDate: Tue Feb 2 11:51:42 2021 +0100
Commit: Eike Rathke 
CommitDate: Wed Feb 3 00:46:56 2021 +0100

Fix typo

Change-Id: I9ce663427a7c967fa8825631412a07215bbb0229
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107183
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/source/filter/excel/xelink.cxx 
b/sc/source/filter/excel/xelink.cxx
index d9d61f37ab62..afd2c2c52bf2 100644
--- a/sc/source/filter/excel/xelink.cxx
+++ b/sc/source/filter/excel/xelink.cxx
@@ -2083,8 +2083,8 @@ void XclExpSupbookBuffer::Save( XclExpStream& rStrm )
 
 void XclExpSupbookBuffer::SaveXml( XclExpXmlStream& rStrm )
 {
-// Unused external references are not saved, only kept in memory
-// saveds must be indexed from 1, so indexes must be reordered
+// Unused external references are not saved, only kept in memory.
+// Those that are saved must be indexed from 1, so indexes must be 
reordered
 ScExternalRefManager* pRefMgr = GetDoc().GetExternalRefManager();
 vector aExternFileIds;
 for (size_t nPos = 0, nSize = maSupbookList.GetSize(); nPos < nSize; 
++nPos)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

There is a problem with Gerrit WIP.

[Dante Doménech]

There is a problem with Gerrit WIP.
After setting a patch as WIP a build is scheduled.

Over here: built started after setting it as work in progress:
https://gerrit.libreoffice.org/c/core/+/110255/8
https://ci.libreoffice.org/job/gerrit_master/77366/
https://gerrit.libreoffice.org/c/core/+/110166/3
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 139749] UI - Improve workflow regarding the thesaurus function: ability to type immediately after dialog window opens.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139749

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 CC||dgp-m...@gmx.de
   Severity|enhancement |minor

--- Comment #1 from Dieter  ---
I can't confirm it with

Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137217] LibreOffice 6 sec startup freeze when Internet Connection is Off

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137217

axad...@yahoo.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 128469] Paragraph/Character Style Dialog: "Reset" and "Standard" buttons have confusing labels

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128469

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 140080] Track changes doesn't undo PS font style change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140080

Telesto  changed:

   What|Removed |Added

 CC||libreoff...@nisz.hu

--- Comment #4 from Telesto  ---
I have seen László Németh doing some work in this area..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140081] New: Images disappear of page (2 images of 6 visible) (DOCX)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140081

Bug ID: 140081
   Summary: Images disappear of page (2 images of 6 visible)
(DOCX)
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Images disappear of page (2 images of 6 visible) (DOCX)

Steps to Reproduce:
1. Open attachment 127476
2. Save as DOCX
3. File reload

Actual Results:
2 images visible

Expected Results:
Same as ODT


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 66013201749df7d5ac5ddaf377a7b3732518a93b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139884] [UI] Need a menu entry + keyboard shortcut + icon in toolbar to set "Default character style"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139884

Heiko Tietze  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |0070|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139884] [UI] Need a menu entry + keyboard shortcut + icon in toolbar to set "Default character style"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139884

Heiko Tietze  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |0070|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 140070] Tools -> Customize dialog search 'All Commands' does not include controls from Styles or Macros categories

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140070

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   See Also|https://bugs.documentfounda |https://bugs.documentfounda
   |tion.org/show_bug.cgi?id=13 |tion.org/show_bug.cgi?id=10
   |9884|6681

--- Comment #1 from Heiko Tietze  ---
Stumbled over this problem myself. Search itself works but only when you switch
to Styles. We either have to move the superior categorization of command,
macro, style into another selection (this breaks the design). Or include those
items in All Commands to make them appear on search.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 140070] Tools -> Customize dialog search 'All Commands' does not include controls from Styles or Macros categories

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140070

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   See Also|https://bugs.documentfounda |https://bugs.documentfounda
   |tion.org/show_bug.cgi?id=13 |tion.org/show_bug.cgi?id=10
   |9884|6681

--- Comment #1 from Heiko Tietze  ---
Stumbled over this problem myself. Search itself works but only when you switch
to Styles. We either have to move the superior categorization of command,
macro, style into another selection (this breaks the design). Or include those
items in All Commands to make them appear on search.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102835] Allow ENDNOTES to be arranged by chapter at end of document; numbering restarts at each chapter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102835

R. Green  changed:

   What|Removed |Added

Summary|Feature request: Endnote by |Allow ENDNOTES to be
   |chapter near end of |arranged by chapter at end
   |document.   |of document; numbering
   ||restarts at each chapter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139764] Open a CSV Comma Separated Value file and Calc defaults to TAB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139764

--- Comment #5 from Jonny Grant  ---
It's a defect. Because a TSV file changes the CSV settings. the TSV change is
retained. a TSV file only contains Tab Separated Values.
My feedback is a waste of time. I'll consider not reporting bugs anymore, they
never get fixed in Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140088] New: No border around comboboxes with latest Breeze upstream changes (kf5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140088

Bug ID: 140088
   Summary: No border around comboboxes with latest Breeze
upstream changes (kf5)
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m.wegh...@posteo.de

Created attachment 169387
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169387=edit
Screenshot showing the issue

original report here: https://bugs.kde.org/show_bug.cgi?id=432395

Steps to reproduce:
0. use KDE Plasma with Breeze style selected, and a Breeze version that
includes commit
https://invent.kde.org/plasma/breeze/-/commit/2f351fe101d6a706b618b4f9518581006f50b242
(e.g. build from git master branch)
1. start LO Calc
2. take a look at the comboboxes

Result: There is no (more) border around the comboboxes

Expected result: There should be a border.

Further information:

* In https://bugs.kde.org/show_bug.cgi?id=432395#c1, Fabian Vogt wrote:
"The LO issue can be explained by LO not taking frame margins into account
(confirmed by adding 10px, but LO looked the same), so this might be fixed by
https://github.com/LibreOffice/core/commit/771f1411c588a02ed276febc9a479323bf4232cd.
I'm using 7.0.3.1 here, not sure whether that commit is included. Adding
Michael Weghorn for info."

However, this issue is not yet fixed by that commit (and the others for
tdf#138010). Possibly, a similar solution can be implemented for the comobox
case, though - presumably related: 'Qt5Graphics_Controls::drawNativeControl',
case 'else if (type == ControlType::Combobox)'

* The screenshot shows how this looks with Breeze 4:5.20.5-2 from Debian
testing (OK, left side) and Breeze built from master branch as of commit
471839bc758c991dbee30205cb080f4ba5bab5a9) (NOK, right-hand side).

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 21312572497e43317faa2f115a2a5449a97f1b44
CPU threads: 12; OS: Linux 5.10; UI render: default; VCL: kf5
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140087] Writer: Adding lines with accurate position is unreliable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140087

--- Comment #1 from Alan  ---
I couldn't see the option to "Use OpenGL for all rendering" but this is the
output of the suggested command in the terminal:

test@lobsang:~$ glxinfo | grep OpenGL
OpenGL vendor string: Intel
OpenGL renderer string: Mesa Intel(R) HD Graphics 530 (SKL GT2)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 20.2.6
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
OpenGL version string: 4.6 (Compatibility Profile) Mesa 20.2.6
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile
OpenGL extensions:
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 20.2.6
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
OpenGL ES profile extensions:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140087] Writer: Adding lines with accurate position is unreliable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140087

--- Comment #4 from Alan  ---
Created attachment 169389
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169389=edit
The docx corrupted file

This is what happens when I save it as a docx.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140079] EDITING: can't edit OLE object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140079

--- Comment #2 from Caolán McNamara  ---
The click is ignored because at 

sfx2/source/view/viewfrm2.cxx:305 case SID_OBJECT
GetViewShell()->GetVerbs().hasElements() is empty so SID_OBJECT is ignored

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137217] LibreOffice -> 6 seconds startup freeze when Internet Connection is Off

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137217

axad...@yahoo.com changed:

   What|Removed |Added

Summary|LibreOffice 6 sec startup   |LibreOffice -> 6 seconds
   |freeze when Internet|startup freeze when
   |Connection is Off   |Internet Connection is Off

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107555] Apply the 'Default Style' table style to newly inserted tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107555

--- Comment #20 from Heiko Tietze  ---
The request is to "apply the 'Default Style' table style". We have a lot of
patches and I'd expect it to be solved. Regarding c15, Default means DF, is
contrary to the request (no table style at all would fix the c15-issue). We
cannot have "empty" table styles, yet. This needs bug 49437 to be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140080] Track changes doesn't undo PS font style change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140080

Telesto  changed:

   What|Removed |Added

Version|6.2.0.3 release |3.5.0 release

--- Comment #3 from Telesto  ---
and in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and in
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140081] Images disappear of page (2 images of 6 visible) (DOCX import)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140081

Telesto  changed:

   What|Removed |Added

Version|7.2.0.0.alpha0+ Master  |7.1.0.0.beta1+
 CC||libreoff...@nisz.hu
   Keywords||bibisectRequest, regression

--- Comment #1 from Telesto  ---
Found in
Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

not in
Version: 7.0.0.0.beta1+ (x64)
Build ID: 2891e91a513520d68ea2b8c59c14335861a15253
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140083] New: Shifting letters on user action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140083

Bug ID: 140083
   Summary: Shifting letters on user action
   Product: LibreOffice
   Version: 3.5.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Shifting letters on user action

Steps to Reproduce:
1. Open the attached file
2. See screencast

Actual Results:
Letters repositioning

Expected Results:
Stable


Reproducible: Always


User Profile Reset: No



Additional Info:
Screencast made with
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140083] Shifting letters on user action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140083

--- Comment #1 from Telesto  ---
Created attachment 169381
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169381=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140084] New: Save and Save As dialogue boxes in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140084

Bug ID: 140084
   Summary: Save and Save As dialogue boxes in Writer
   Product: LibreOffice
   Version: 7.0.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pnorke...@yahoo.com.au

Description:
Hi. Great program. Reminds me of Word Prefect and almost good enough to give up
on Office and Word. 

But the Save and Save As dialogue Boxes are awful. 

No folders tree, only a Box called Places, where folders can be added, but to
get to the folders to add is also near impossible and clicking on the Saved
Folder still does not open the fold tree within that folder or allow you to go
back up the tree.

Also when you open a folder, the first file in the folder is highlighted, and
even if you have given the file a name, when save is clicked, it will try to
name the file with the automatically selected file's name, so you need to then
unselect that file by clicking and the name you have already given the file.

There is also no parent folder up button. 

Please just do a standard folder tree with a back button.

And I have no idea what the Servers button is for??

Thanks John


Actual Results:
is awful 

Expected Results:
still awful


Reproducible: Always


User Profile Reset: No



Additional Info:
please fix it

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140086] New: LO will many times the master password for open or save action an a remote server (webdav)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140086

Bug ID: 140086
   Summary: LO will many times the master password for open or
save action an a remote server (webdav)
   Product: LibreOffice
   Version: 7.1.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: albre...@uni-potsdam.de

Description:
LO 7.1.0.2 linux 64 bit (opensuse 15.2) german

open or save on a remote server 2 times the LO will have the master password
for every step in the filebrowser

If I start from dolphin only one master password is necessary

Steps to Reproduce:
1. start LO
2. open/save remote file
3. masterpasword-dialog 2 times
4. every change directory masterpasword-dialog 2 times
.

n. open or save the file

Actual Results:
Kennwort eingeben

Expected Results:
only one ask for master password


Reproducible: Always


User Profile Reset: No



Additional Info:
I dont know

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140079] New: EDITING: can't edit OLE object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140079

Bug ID: 140079
   Summary: EDITING: can't edit OLE object
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 130948 [details] from bug 130948
2. Double click on the table

-> Nothing happens. it should open Calc instead. Also reproduced with GEN

Reproduced in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 876da94619d561e4b4c6c7d12a8d6726eb857df8
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140080] New: Track changes doesn't undo PS font style change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140080

Bug ID: 140080
   Summary: Track changes doesn't undo PS font style change
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Track changes doesn't undo PS font style change

Steps to Reproduce:
1. Open the attached file
2. Place cursor before "Si" direct under the Heading
3. Place backspace until it stops (so heading deleted)
4. Edit -> Reject all changes 

Actual Results:
Paragraph starting with Si has Heading 3 formatting

Expected Results:
Not so. Same as original


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 66013201749df7d5ac5ddaf377a7b3732518a93b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140080] Track changes doesn't undo PS font style change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140080

--- Comment #1 from Telesto  ---
Created attachment 169379
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169379=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139884] [UI] Need a menu entry + keyboard shortcut + icon in toolbar to set "Default character style"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139884

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Heiko Tietze  ---
Olivier, what exactly are you missing in what UI setting?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139884] [UI] Need a menu entry + keyboard shortcut + icon in toolbar to set "Default character style"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139884

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Heiko Tietze  ---
Olivier, what exactly are you missing in what UI setting?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128631] GTK3: No mouse interaction with security warning dialog in embedded file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128631

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0079

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140079] EDITING: can't edit OLE object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140079

Xisco Faulí  changed:

   What|Removed |Added

Version|7.2.0.0.alpha0+ Master  |6.4.0.0.alpha0+
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8631
   Keywords||bibisected, bisected,
   ||regression
 Ever confirmed|0   |1
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=913b2530fff20bacb0cbb8e51be29b42983d56c8

author  Caolán McNamara 2019-11-06 15:00:55 +
committer   Caolán McNamara 2019-11-06 20:50:22
+0100
commit  913b2530fff20bacb0cbb8e51be29b42983d56c8 (patch)
treea2ed349d04099e07d77e2c6307e48896ecc78eac
parent  ef0e7e146f86999b04d7274688d72fadcaf53a36 (diff)
Resolves: tdf#128631 dispatch active ole async

Bisected with: bibisect-linux64-6.4

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140079] EDITING: can't edit OLE object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140079

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3955

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113955] EDITING: embedded table changes the style after editing it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113955

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0079

--- Comment #4 from Xisco Faulí  ---
At the moment, this issue is blocked by bug 140079

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140083] Shifting letters on user action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140083

--- Comment #2 from Telesto  ---
Created attachment 169382
  --> https://bugs.documentfoundation.org/attachment.cgi?id=169382=edit
Screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140083] Shifting letters on user action

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140083

Telesto  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from Telesto  ---
Font rendering and painting stuff on screen mysterious.. I put this in the list
of
Bug 103322; Bug 138919; Bug 139296

Doubt a little if this actually a rounding issue.. based on bug a above I would
say something is quirky with size of the canvas.. Pixel left/right/ top down
being marginally off (scroll position involved?) So frame is painted without
'exact' position.. could again be a rounding issue. 

But well no experience with scroll 'tics' and dimensional aspects (TWIPS?) and
the whole re-painting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140054] [FILESAVE] LibreOffice Calc Should Remember The Last Used Sizes of Columns/ Rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140054

--- Comment #2 from shortboar...@gmail.com ---
I downloaded the latest release and the issue with columns widths persists. 

I started to think that maybe the cause is that I open the file in question
from my Dropbox- folder as it is a file I need to access away from home?

Version installed now:
Version: 7.0.4.2 (x64)
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: fi-FI (en_FI); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140054] [FILESAVE] LibreOffice Calc Should Remember The Last Used Sizes of Columns/ Rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140054

--- Comment #3 from shortboar...@gmail.com ---
I moved the copy of the file from Dropbox- folder to my Desktop and opened the
file, made the adjustments manually to column widths, saved the file and closed
the file. Tried reopening the file from the Desktop and the column widths had
once again reset.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs